Re: [PATCH 0/3] hw/nvme: bug fixes and doc update
On Aug 8 09:04, Michael Tokarev wrote: > 08.08.2023 00:27, Ankit Kumar wrote: > > This series fixes two bugs > > 1. CRC64 generation when metadata buffer is used. > > 2. Protection information disable check for Type 3 protection. > > > > This series also updates the documentaion for pi (protection information), > > and adds missing pif (protection information format) entry. > > > > Ankit Kumar (3): > >hw/nvme: fix CRC64 for guard tag > >hw/nvme: fix disable pi checks for Type 3 protection > >docs: update hw/nvme documentation for protection information > > At least the CRC64 change smells like a -stable material, - the bug > is present in, for example, qemu-7.2 too. But I don't know how important > it is to keep nvme updated in 8.0 or before, and what the outcome of this > bug is, to begin with. Somehow I think nvme was in preliminary shape > before 8.0. > > Are the other changes also relevant for -stable? > > Please keep Cc: qemu-sta...@nongnu.org for anything you think is worth > to have in previous/stable releases. > Hi Michael, Yes, this is stable worthy. I'll add Cc: stable and fixes tags on relevant patches on the pull. Thanks for the heads up! signature.asc Description: PGP signature
Re: [PATCH 0/3] hw/nvme: bug fixes and doc update
08.08.2023 00:27, Ankit Kumar wrote: This series fixes two bugs 1. CRC64 generation when metadata buffer is used. 2. Protection information disable check for Type 3 protection. This series also updates the documentaion for pi (protection information), and adds missing pif (protection information format) entry. Ankit Kumar (3): hw/nvme: fix CRC64 for guard tag hw/nvme: fix disable pi checks for Type 3 protection docs: update hw/nvme documentation for protection information At least the CRC64 change smells like a -stable material, - the bug is present in, for example, qemu-7.2 too. But I don't know how important it is to keep nvme updated in 8.0 or before, and what the outcome of this bug is, to begin with. Somehow I think nvme was in preliminary shape before 8.0. Are the other changes also relevant for -stable? Please keep Cc: qemu-sta...@nongnu.org for anything you think is worth to have in previous/stable releases. Thanks, /mjt
[PATCH 0/3] hw/nvme: bug fixes and doc update
This series fixes two bugs 1. CRC64 generation when metadata buffer is used. 2. Protection information disable check for Type 3 protection. This series also updates the documentaion for pi (protection information), and adds missing pif (protection information format) entry. Ankit Kumar (3): hw/nvme: fix CRC64 for guard tag hw/nvme: fix disable pi checks for Type 3 protection docs: update hw/nvme documentation for protection information docs/system/devices/nvme.rst | 10 +++--- hw/nvme/dif.c| 9 + 2 files changed, 12 insertions(+), 7 deletions(-) -- 2.25.1
