Re: [PATCH v4 0/1] hw/hyperv/vmbus: Is it maintained?
On 13/11/2021, Maciej S. Szmigiero wrote: On 12.11.2021 21:39, Roman Kagan wrote: On Fri, Nov 12, 2021 at 09:32:31PM +0300, Vladimir Sementsov-Ogievskiy wrote: Add Den and Roman (his new address) Thanks, I missed it on the list indeed. 06.11.2021 16:41, Philippe Mathieu-Daudé wrote: This is the 4th time I send this patch. Is the VMBus infrastructure used / maintained? Should we deprecate & remove? I think it's fair to say it's not maintained. The whole hw/hyperv/vmbus.c was submitted as a part of the work by Jon to enable some obscure windows debugging feature which only worked in presence of VMBus. It was mostly taken from the respective branch of the (now effectively abandoned) downstream tree with an implementation of the core VMBus infrastructure and the devices using it; however, none of the actual VMBus devices ever made it into the mainline tree. The VMBus code works fine, is mostly self-contained and by being a part of the upstream QEMU it does benefit from any improvements done there and so it is much less likely to bit-rot with time. I am still committed to upstreaming a Hyper-V Dynamic Memory Protocol driver (which uses VMBus), however had been preempted by higher-priority work for now. Thanks, Maciej Hi guys, Sorry for the late reply, like Roman I also never got to submit the RFC for the Synth debugger device which requires the VMBus, I do hope to get to it at some point and VMBus is a required part for it. In the last year or so I have not had much time to spend on this but I do hope to get back to finishing what I have started. I'm not really sure I have the time or knowledge to maintain VMBus :( but I'll do my best to answer any questions as well. -- Jon.
Re: [PATCH v4 0/1] hw/hyperv/vmbus: Is it maintained?
On 08.11.2021 08:30, Philippe Mathieu-Daudé wrote: On 11/6/21 20:28, Maciej S. Szmigiero wrote: On 06.11.2021 14:41, Philippe Mathieu-Daudé wrote: This is the 4th time I send this patch. Is the VMBus infrastructure used / maintained? Should we deprecate & remove? $ ./scripts/get_maintainer.pl -f hw/hyperv/vmbus.c -f include/hw/hyperv/vmbus.h get_maintainer.pl: No maintainers found There's an email thread at [1] explaining the reasons for having VMBus infrastructure last time such question was asked. In short: mere presence of a working VMBus is needed for some high-speed Windows debugging, also people are working on VMBus host device drivers. Great. Do you mind adding an entry in MAINTAINERS to cover these files, so we stop wondering about them? I will submit a patch next week adding myself as a reviewer of VMBus code so there is at least some contact point for incoming patches. We'll see whether the code still gets just a random patch a few times a year or whether it requires a permanent maintainer to take care of it. Thanks, Maciej
Re: [PATCH v4 0/1] hw/hyperv/vmbus: Is it maintained?
On 12.11.2021 21:39, Roman Kagan wrote: On Fri, Nov 12, 2021 at 09:32:31PM +0300, Vladimir Sementsov-Ogievskiy wrote: Add Den and Roman (his new address) Thanks, I missed it on the list indeed. 06.11.2021 16:41, Philippe Mathieu-Daudé wrote: This is the 4th time I send this patch. Is the VMBus infrastructure used / maintained? Should we deprecate & remove? I think it's fair to say it's not maintained. The whole hw/hyperv/vmbus.c was submitted as a part of the work by Jon to enable some obscure windows debugging feature which only worked in presence of VMBus. It was mostly taken from the respective branch of the (now effectively abandoned) downstream tree with an implementation of the core VMBus infrastructure and the devices using it; however, none of the actual VMBus devices ever made it into the mainline tree. The VMBus code works fine, is mostly self-contained and by being a part of the upstream QEMU it does benefit from any improvements done there and so it is much less likely to bit-rot with time. I am still committed to upstreaming a Hyper-V Dynamic Memory Protocol driver (which uses VMBus), however had been preempted by higher-priority work for now. Thanks, Maciej
Re: [PATCH v4 0/1] hw/hyperv/vmbus: Is it maintained?
On Fri, Nov 12, 2021 at 09:32:31PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Add Den and Roman (his new address) Thanks, I missed it on the list indeed. > 06.11.2021 16:41, Philippe Mathieu-Daudé wrote: > > This is the 4th time I send this patch. Is the VMBus infrastructure > > used / maintained? Should we deprecate & remove? I think it's fair to say it's not maintained. The whole hw/hyperv/vmbus.c was submitted as a part of the work by Jon to enable some obscure windows debugging feature which only worked in presence of VMBus. It was mostly taken from the respective branch of the (now effectively abandoned) downstream tree with an implementation of the core VMBus infrastructure and the devices using it; however, none of the actual VMBus devices ever made it into the mainline tree. > > > >$ ./scripts/get_maintainer.pl -f hw/hyperv/vmbus.c -f > > include/hw/hyperv/vmbus.h > >get_maintainer.pl: No maintainers found > > > > Philippe Mathieu-Daudé (1): > >hw/hyperv/vmbus: Remove unused vmbus_load/save_req() > > > > include/hw/hyperv/vmbus.h | 3 -- > > hw/hyperv/vmbus.c | 59 --- > > 2 files changed, 62 deletions(-) This seems to basically be the revert of 4dd8a7064b "vmbus: add infrastructure to save/load vmbus requests"; it was originally meant to be submitted with the code that would use it, vmbus scsi controller, but that never happened. It believe it's safe to remove without affecting Jon's work, but I'd rather check with him. Thanks, Roman.
Re: [PATCH v4 0/1] hw/hyperv/vmbus: Is it maintained?
Add Den and Roman (his new address) 06.11.2021 16:41, Philippe Mathieu-Daudé wrote: This is the 4th time I send this patch. Is the VMBus infrastructure used / maintained? Should we deprecate & remove? $ ./scripts/get_maintainer.pl -f hw/hyperv/vmbus.c -f include/hw/hyperv/vmbus.h get_maintainer.pl: No maintainers found Philippe Mathieu-Daudé (1): hw/hyperv/vmbus: Remove unused vmbus_load/save_req() include/hw/hyperv/vmbus.h | 3 -- hw/hyperv/vmbus.c | 59 --- 2 files changed, 62 deletions(-) -- Best regards, Vladimir
Re: [PATCH v4 0/1] hw/hyperv/vmbus: Is it maintained?
On 11/6/21 20:28, Maciej S. Szmigiero wrote: > On 06.11.2021 14:41, Philippe Mathieu-Daudé wrote: >> This is the 4th time I send this patch. Is the VMBus infrastructure >> used / maintained? Should we deprecate & remove? >> >> $ ./scripts/get_maintainer.pl -f hw/hyperv/vmbus.c -f >> include/hw/hyperv/vmbus.h >> get_maintainer.pl: No maintainers found > > There's an email thread at [1] explaining the reasons for having VMBus > infrastructure last time such question was asked. > > In short: mere presence of a working VMBus is needed for some high-speed > Windows debugging, also people are working on VMBus host device drivers. Great. Do you mind adding an entry in MAINTAINERS to cover these files, so we stop wondering about them? > Your patch makes sense to me, so for it: > Reviewed-by: Maciej S. Szmigiero Thank you. > [1]: > https://lore.kernel.org/qemu-devel/20201009193919.gf7...@habkost.net/T/#u >
Re: [PATCH v4 0/1] hw/hyperv/vmbus: Is it maintained?
On 06.11.2021 14:41, Philippe Mathieu-Daudé wrote: This is the 4th time I send this patch. Is the VMBus infrastructure used / maintained? Should we deprecate & remove? $ ./scripts/get_maintainer.pl -f hw/hyperv/vmbus.c -f include/hw/hyperv/vmbus.h get_maintainer.pl: No maintainers found There's an email thread at [1] explaining the reasons for having VMBus infrastructure last time such question was asked. In short: mere presence of a working VMBus is needed for some high-speed Windows debugging, also people are working on VMBus host device drivers. Your patch makes sense to me, so for it: Reviewed-by: Maciej S. Szmigiero Thanks, Maciej [1]: https://lore.kernel.org/qemu-devel/20201009193919.gf7...@habkost.net/T/#u
[PATCH v4 0/1] hw/hyperv/vmbus: Is it maintained?
This is the 4th time I send this patch. Is the VMBus infrastructure used / maintained? Should we deprecate & remove? $ ./scripts/get_maintainer.pl -f hw/hyperv/vmbus.c -f include/hw/hyperv/vmbus.h get_maintainer.pl: No maintainers found Philippe Mathieu-Daudé (1): hw/hyperv/vmbus: Remove unused vmbus_load/save_req() include/hw/hyperv/vmbus.h | 3 -- hw/hyperv/vmbus.c | 59 --- 2 files changed, 62 deletions(-) -- 2.31.1