Re: [Qemu-devel] [PATCH] configure: Replace which(1) with command -v

2014-11-19 Thread Peter Maydell
On 19 November 2014 07:13, Fam Zheng f...@redhat.com wrote:
 Because which(1) is not always installed, whereas command -v is
 the more native way to check for a command.

 Signed-off-by: Fam Zheng f...@redhat.com
 ---
  configure | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

 diff --git a/configure b/configure
 index 47048f0..986a13d 100755
 --- a/configure
 +++ b/configure
 @@ -2727,7 +2727,7 @@ fi
  if test $modules = yes; then
  shacmd_probe=sha1sum sha1 shasum
  for c in $shacmd_probe; do
 -if which $c /dev/null 21; then
 +if command -v $c /dev/null 21; then
  shacmd=$c
  break
  fi

Configure already provides the shell function has
for checking for existence of a command -- can we just
use that?

thanks
-- PMM



[Qemu-devel] [PATCH] configure: Replace which(1) with command -v

2014-11-18 Thread Fam Zheng
Because which(1) is not always installed, whereas command -v is
the more native way to check for a command.

Signed-off-by: Fam Zheng f...@redhat.com
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure b/configure
index 47048f0..986a13d 100755
--- a/configure
+++ b/configure
@@ -2727,7 +2727,7 @@ fi
 if test $modules = yes; then
 shacmd_probe=sha1sum sha1 shasum
 for c in $shacmd_probe; do
-if which $c /dev/null 21; then
+if command -v $c /dev/null 21; then
 shacmd=$c
 break
 fi
-- 
1.9.3