Re: [Qemu-devel] [PATCH v3 03/29] tcg-aarch64: Don't handle mov/movi in tcg_out_op

2013-09-12 Thread Claudio Fontana
On 12.09.2013 16:02, Richard Henderson wrote:
> On 09/12/2013 01:30 AM, Claudio Fontana wrote:
>>> +case INDEX_op_mov_i64:
>>> +case INDEX_op_mov_i32:
>>> +case INDEX_op_movi_i64:
>>> +case INDEX_op_movi_i32:
>>> +/* Always implemented with tcg_out_mov/i, never with tcg_out_op.  
>>> */
>>>  default:
>>> -tcg_abort(); /* opcode not implemented */
>>> +/* Opcode not implemented.  */
>>> +tcg_abort();
>>>  }
>>>  }
>>>  
>>
>> Ok
> 
> Sadly, "Ok" is neither Reviewed-by or Signed-off-by.
> 
> 

There is nothing sad about it. When it's reviewed, you will know.




Re: [Qemu-devel] [PATCH v3 03/29] tcg-aarch64: Don't handle mov/movi in tcg_out_op

2013-09-12 Thread Peter Maydell
On 12 September 2013 15:31, Claudio Fontana  wrote:
> On 12.09.2013 16:02, Richard Henderson wrote:
>> On 09/12/2013 01:30 AM, Claudio Fontana wrote:
>>> Ok
>>
>> Sadly, "Ok" is neither Reviewed-by or Signed-off-by

> There is nothing sad about it. When it's reviewed, you will know.

The point is that "Ok" is not particularly useful feedback
because it looks like a reviewd-by/acked-by but isn't. It's
confusing so it's better to avoid it.

-- PMM



Re: [Qemu-devel] [PATCH v3 03/29] tcg-aarch64: Don't handle mov/movi in tcg_out_op

2013-09-12 Thread Richard Henderson
On 09/12/2013 01:30 AM, Claudio Fontana wrote:
>> +case INDEX_op_mov_i64:
>> +case INDEX_op_mov_i32:
>> +case INDEX_op_movi_i64:
>> +case INDEX_op_movi_i32:
>> +/* Always implemented with tcg_out_mov/i, never with tcg_out_op.  */
>>  default:
>> -tcg_abort(); /* opcode not implemented */
>> +/* Opcode not implemented.  */
>> +tcg_abort();
>>  }
>>  }
>>  
> 
> Ok

Sadly, "Ok" is neither Reviewed-by or Signed-off-by.


r~




Re: [Qemu-devel] [PATCH v3 03/29] tcg-aarch64: Don't handle mov/movi in tcg_out_op

2013-09-12 Thread Claudio Fontana
On 02.09.2013 19:54, Richard Henderson wrote:
> Signed-off-by: Richard Henderson 
> ---
>  tcg/aarch64/tcg-target.c | 20 +++-
>  1 file changed, 7 insertions(+), 13 deletions(-)
> 
> diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target.c
> index bde4c72..79a447d 100644
> --- a/tcg/aarch64/tcg-target.c
> +++ b/tcg/aarch64/tcg-target.c
> @@ -1162,18 +1162,6 @@ static void tcg_out_op(TCGContext *s, TCGOpcode opc,
>   args[0], args[1], args[2]);
>  break;
>  
> -case INDEX_op_mov_i64:
> -case INDEX_op_mov_i32:
> -tcg_out_movr(s, ext, args[0], args[1]);
> -break;
> -
> -case INDEX_op_movi_i64:
> -tcg_out_movi(s, TCG_TYPE_I64, args[0], args[1]);
> -break;
> -case INDEX_op_movi_i32:
> -tcg_out_movi(s, TCG_TYPE_I32, args[0], args[1]);
> -break;
> -
>  case INDEX_op_add_i64:
>  case INDEX_op_add_i32:
>  tcg_out_arith(s, ARITH_ADD, ext, args[0], args[1], args[2], 0);
> @@ -1337,8 +1325,14 @@ static void tcg_out_op(TCGContext *s, TCGOpcode opc,
>  tcg_out_movr(s, 0, args[0], args[1]);
>  break;
>  
> +case INDEX_op_mov_i64:
> +case INDEX_op_mov_i32:
> +case INDEX_op_movi_i64:
> +case INDEX_op_movi_i32:
> +/* Always implemented with tcg_out_mov/i, never with tcg_out_op.  */
>  default:
> -tcg_abort(); /* opcode not implemented */
> +/* Opcode not implemented.  */
> +tcg_abort();
>  }
>  }
>  

Ok



-- 
Claudio Fontana
Server OS Architect
Huawei Technologies Duesseldorf GmbH
Riesstraße 25 - 80992 München

office: +49 89 158834 4135
mobile: +49 15253060158




[Qemu-devel] [PATCH v3 03/29] tcg-aarch64: Don't handle mov/movi in tcg_out_op

2013-09-02 Thread Richard Henderson
Signed-off-by: Richard Henderson 
---
 tcg/aarch64/tcg-target.c | 20 +++-
 1 file changed, 7 insertions(+), 13 deletions(-)

diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target.c
index bde4c72..79a447d 100644
--- a/tcg/aarch64/tcg-target.c
+++ b/tcg/aarch64/tcg-target.c
@@ -1162,18 +1162,6 @@ static void tcg_out_op(TCGContext *s, TCGOpcode opc,
  args[0], args[1], args[2]);
 break;
 
-case INDEX_op_mov_i64:
-case INDEX_op_mov_i32:
-tcg_out_movr(s, ext, args[0], args[1]);
-break;
-
-case INDEX_op_movi_i64:
-tcg_out_movi(s, TCG_TYPE_I64, args[0], args[1]);
-break;
-case INDEX_op_movi_i32:
-tcg_out_movi(s, TCG_TYPE_I32, args[0], args[1]);
-break;
-
 case INDEX_op_add_i64:
 case INDEX_op_add_i32:
 tcg_out_arith(s, ARITH_ADD, ext, args[0], args[1], args[2], 0);
@@ -1337,8 +1325,14 @@ static void tcg_out_op(TCGContext *s, TCGOpcode opc,
 tcg_out_movr(s, 0, args[0], args[1]);
 break;
 
+case INDEX_op_mov_i64:
+case INDEX_op_mov_i32:
+case INDEX_op_movi_i64:
+case INDEX_op_movi_i32:
+/* Always implemented with tcg_out_mov/i, never with tcg_out_op.  */
 default:
-tcg_abort(); /* opcode not implemented */
+/* Opcode not implemented.  */
+tcg_abort();
 }
 }
 
-- 
1.8.3.1