RE: [PATCH v8 4/7] migration/multifd: add qpl compression method
> -Original Message- > From: Fabiano Rosas > Sent: Wednesday, June 12, 2024 10:31 PM > To: Liu, Yuan1 ; pet...@redhat.com; > pbonz...@redhat.com; marcandre.lur...@redhat.com; berra...@redhat.com; > th...@redhat.com; phi...@linaro.org > Cc: qemu-devel@nongnu.org; Liu, Yuan1 ; Zou, Nanhai > ; shameerali.kolothum.th...@huawei.com > Subject: Re: [PATCH v8 4/7] migration/multifd: add qpl compression method > > Fabiano Rosas writes: > > > Yuan Liu writes: > > > >> add the Query Processing Library (QPL) compression method > >> > >> Introduce the qpl as a new multifd migration compression method, it can > >> use In-Memory Analytics Accelerator(IAA) to accelerate compression and > >> decompression, which can not only reduce network bandwidth requirement > >> but also reduce host compression and decompression CPU overhead. > >> > >> How to enable qpl compression during migration: > >> migrate_set_parameter multifd-compression qpl > >> > >> There is no qpl compression level parameter added since it only > supports > >> level one, users do not need to specify the qpl compression level. > >> > >> Signed-off-by: Yuan Liu > >> Reviewed-by: Nanhai Zou > >> Reviewed-by: Peter Xu > >> Reviewed-by: Fabiano Rosas > > > > I don't think I ever reviewed this patch. Please drop this when you > > resubmit. > > Actually, just leave it. I thought you'd need to fix the output size on > 6/7, but I saw you just moved it elsewhere. So no need to respin. I'll > queue this version shortly unless anyone else has comments. Got it and thank you for your review.
RE: [PATCH v8 4/7] migration/multifd: add qpl compression method
> -Original Message- > From: Fabiano Rosas > Sent: Wednesday, June 12, 2024 10:27 PM > To: Liu, Yuan1 ; pet...@redhat.com; > pbonz...@redhat.com; marcandre.lur...@redhat.com; berra...@redhat.com; > th...@redhat.com; phi...@linaro.org > Cc: qemu-devel@nongnu.org; Liu, Yuan1 ; Zou, Nanhai > ; shameerali.kolothum.th...@huawei.com > Subject: Re: [PATCH v8 4/7] migration/multifd: add qpl compression method > > Yuan Liu writes: > > > add the Query Processing Library (QPL) compression method > > > > Introduce the qpl as a new multifd migration compression method, it can > > use In-Memory Analytics Accelerator(IAA) to accelerate compression and > > decompression, which can not only reduce network bandwidth requirement > > but also reduce host compression and decompression CPU overhead. > > > > How to enable qpl compression during migration: > > migrate_set_parameter multifd-compression qpl > > > > There is no qpl compression level parameter added since it only supports > > level one, users do not need to specify the qpl compression level. > > > > Signed-off-by: Yuan Liu > > Reviewed-by: Nanhai Zou > > Reviewed-by: Peter Xu > > Reviewed-by: Fabiano Rosas > > I don't think I ever reviewed this patch. Please drop this when you > resubmit. You are right, this is my mistake, I am very sorry.
Re: [PATCH v8 4/7] migration/multifd: add qpl compression method
Fabiano Rosas writes: > Yuan Liu writes: > >> add the Query Processing Library (QPL) compression method >> >> Introduce the qpl as a new multifd migration compression method, it can >> use In-Memory Analytics Accelerator(IAA) to accelerate compression and >> decompression, which can not only reduce network bandwidth requirement >> but also reduce host compression and decompression CPU overhead. >> >> How to enable qpl compression during migration: >> migrate_set_parameter multifd-compression qpl >> >> There is no qpl compression level parameter added since it only supports >> level one, users do not need to specify the qpl compression level. >> >> Signed-off-by: Yuan Liu >> Reviewed-by: Nanhai Zou >> Reviewed-by: Peter Xu >> Reviewed-by: Fabiano Rosas > > I don't think I ever reviewed this patch. Please drop this when you > resubmit. Actually, just leave it. I thought you'd need to fix the output size on 6/7, but I saw you just moved it elsewhere. So no need to respin. I'll queue this version shortly unless anyone else has comments.
Re: [PATCH v8 4/7] migration/multifd: add qpl compression method
Yuan Liu writes: > add the Query Processing Library (QPL) compression method > > Introduce the qpl as a new multifd migration compression method, it can > use In-Memory Analytics Accelerator(IAA) to accelerate compression and > decompression, which can not only reduce network bandwidth requirement > but also reduce host compression and decompression CPU overhead. > > How to enable qpl compression during migration: > migrate_set_parameter multifd-compression qpl > > There is no qpl compression level parameter added since it only supports > level one, users do not need to specify the qpl compression level. > > Signed-off-by: Yuan Liu > Reviewed-by: Nanhai Zou > Reviewed-by: Peter Xu > Reviewed-by: Fabiano Rosas I don't think I ever reviewed this patch. Please drop this when you resubmit.
