Re: [Qemu-devel] [PATCH for-3.1 25/25] MAINTAINERS: Remove duplicate entries of qemu-devel@nongnu.org
On Tue, 27 Nov 2018 10:18:04 +0100 Paolo Bonzini wrote: > On 27/11/18 09:59, Markus Armbruster wrote: > >>> F: linux-headers/ > > For this I propose mst, Conny and myself. Fine with me.
Re: [Qemu-devel] [PATCH for-3.1 25/25] MAINTAINERS: Remove duplicate entries of qemu-devel@nongnu.org
On 27/11/18 10:18, Paolo Bonzini wrote: > On 27/11/18 09:59, Markus Armbruster wrote: LINUX -L: qemu-devel@nongnu.org S: Maintained F: linux-* > > This pattern only matches > > ./block/linux-aio.c > ./stubs/linux-aio.c > > so it can be removed > OK F: linux-headers/ > > For this I propose mst, Conny and myself. Or remove... I'll let them opinate. > POSIX -L: qemu-devel@nongnu.org S: Maintained F: *posix* >>> >>> I agree that we can remove the "L: qemu-devel" entries everywhere, but >>> for these subsystems that have no "M:" entry, but "S: Maintained", this >>> now looks somewhat strange - the subsystem is "Maintained" but has no >>> maintainer? I think we need somebody who feels responsible to pick up >>> patches here...? >> >> It looks strange because it *is* strange. If we take the definition of >> S: in MAINTAINERS seriously, we need to appoint a maintainer (a person, >> not a mailing list), or downgrade to S: Orphan. > > I can volunteer for this one too, but please change the F: patterns to > > F: os-posix.c > F: include/sysemu/os-posix.h > F: util/*posix*.c > F: include/qemu/*posix*.h OK, will do. Thanks Paolo, Phil. > > Thanks, > > Paolo >
Re: [Qemu-devel] [PATCH for-3.1 25/25] MAINTAINERS: Remove duplicate entries of qemu-devel@nongnu.org
On 27/11/18 09:59, Markus Armbruster wrote: >>> LINUX >>> -L: qemu-devel@nongnu.org >>> S: Maintained >>> F: linux-* This pattern only matches ./block/linux-aio.c ./stubs/linux-aio.c so it can be removed >>> F: linux-headers/ For this I propose mst, Conny and myself. >>> POSIX >>> -L: qemu-devel@nongnu.org >>> S: Maintained >>> F: *posix* >> >> I agree that we can remove the "L: qemu-devel" entries everywhere, but >> for these subsystems that have no "M:" entry, but "S: Maintained", this >> now looks somewhat strange - the subsystem is "Maintained" but has no >> maintainer? I think we need somebody who feels responsible to pick up >> patches here...? > > It looks strange because it *is* strange. If we take the definition of > S: in MAINTAINERS seriously, we need to appoint a maintainer (a person, > not a mailing list), or downgrade to S: Orphan. I can volunteer for this one too, but please change the F: patterns to F: os-posix.c F: include/sysemu/os-posix.h F: util/*posix*.c F: include/qemu/*posix*.h Thanks, Paolo
Re: [Qemu-devel] [PATCH for-3.1 25/25] MAINTAINERS: Remove duplicate entries of qemu-devel@nongnu.org
Thomas Huth writes: > On 2018-11-25 21:50, Philippe Mathieu-Daudé wrote: >> The list is always selected by the 'All patches CC here' section. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> MAINTAINERS | 13 - >> 1 file changed, 13 deletions(-) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index c616861ca3..9d6dae71ff 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -109,7 +109,6 @@ L: qemu-s3...@nongnu.org >> Guest CPU cores (TCG): >> -- >> Overall >> -L: qemu-devel@nongnu.org >> M: Peter Crosthwaite >> M: Richard Henderson >> R: Paolo Bonzini >> @@ -403,30 +402,25 @@ Hosts: >> -- >> >> LINUX >> -L: qemu-devel@nongnu.org >> S: Maintained >> F: linux-* >> F: linux-headers/ >> >> POSIX >> -L: qemu-devel@nongnu.org >> S: Maintained >> F: *posix* > > I agree that we can remove the "L: qemu-devel" entries everywhere, but > for these subsystems that have no "M:" entry, but "S: Maintained", this > now looks somewhat strange - the subsystem is "Maintained" but has no > maintainer? I think we need somebody who feels responsible to pick up > patches here...? It looks strange because it *is* strange. If we take the definition of S: in MAINTAINERS seriously, we need to appoint a maintainer (a person, not a mailing list), or downgrade to S: Orphan.
Re: [Qemu-devel] [PATCH for-3.1 25/25] MAINTAINERS: Remove duplicate entries of qemu-devel@nongnu.org
On 2018-11-25 21:50, Philippe Mathieu-Daudé wrote: > The list is always selected by the 'All patches CC here' section. > > Signed-off-by: Philippe Mathieu-Daudé > --- > MAINTAINERS | 13 - > 1 file changed, 13 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index c616861ca3..9d6dae71ff 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -109,7 +109,6 @@ L: qemu-s3...@nongnu.org > Guest CPU cores (TCG): > -- > Overall > -L: qemu-devel@nongnu.org > M: Peter Crosthwaite > M: Richard Henderson > R: Paolo Bonzini > @@ -403,30 +402,25 @@ Hosts: > -- > > LINUX > -L: qemu-devel@nongnu.org > S: Maintained > F: linux-* > F: linux-headers/ > > POSIX > -L: qemu-devel@nongnu.org > S: Maintained > F: *posix* I agree that we can remove the "L: qemu-devel" entries everywhere, but for these subsystems that have no "M:" entry, but "S: Maintained", this now looks somewhat strange - the subsystem is "Maintained" but has no maintainer? I think we need somebody who feels responsible to pick up patches here...? Thomas
