Re: [Qemu-devel] [Qemu-ppc] Forward-porting RTC device for eppc500 ?
В сообщении от Sunday 03 March 2019 03:17:47 BALATON Zoltan написал(а): > On Sun, 3 Mar 2019, Andrew Randrianasulu wrote: > > git commit -a --author="Amit Singh Tomar " > > git format-patch -s 20b084c4b1401b7f8fbc385649d48c67b6f43d44 > > > > scripts/checkpatch.pl > > 0001-Re-applying-Freescale-PPC-E500-i2c-RTC-patch.patch > > > > After this I created new message in Kmail and inserted 0001 file, edited > > it a bit more (adding patchwork link and mentioning fact I actually > > boot-tested patch), and then send out. > > When sending patches to list make sure your mailer sends them as plain > text and does not try to break up lines or alter white space because that > breaks the patch and it won't apply with git am. You can check it in > patchew (linked from SubmitAPatch wiki page): > > https://patchew.org/QEMU/201903030021.22070.randrianas...@gmail.com/ > > Not sure if Kmail can do this, maybe it has some settings for this but > it's usually better to do all editing on the git commit and send patch > mails with git send-email. I see, it failed to apply. Will try to convince git send-mail to work (last time it failed for me, but it was long time ago) > > > Guess next time I better to add second "-s" to git format-patch, so first > > signed-off-by-line from original will be around too? > > > > Or ..lets wait what actual maintainers will say. > > Yes, I'll let actual maintainers to comment then you can do a corrected > version with any requested fixes or Reviewed-by tags added. I think for > next revision you should leave original author's Signed-off-by in commit > message and add yours with -s after that. (When sending another version of > a patch use -v2 option of git format-patch to add v2 to the patch > subject and so on for higher revisions if needed.) Thanks. > > Regards, > BALATON Zoltan
Re: [Qemu-devel] [Qemu-ppc] Forward-porting RTC device for eppc500 ?
On Sun, 3 Mar 2019, Andrew Randrianasulu wrote: git commit -a --author="Amit Singh Tomar " git format-patch -s 20b084c4b1401b7f8fbc385649d48c67b6f43d44 scripts/checkpatch.pl 0001-Re-applying-Freescale-PPC-E500-i2c-RTC-patch.patch After this I created new message in Kmail and inserted 0001 file, edited it a bit more (adding patchwork link and mentioning fact I actually boot-tested patch), and then send out. When sending patches to list make sure your mailer sends them as plain text and does not try to break up lines or alter white space because that breaks the patch and it won't apply with git am. You can check it in patchew (linked from SubmitAPatch wiki page): https://patchew.org/QEMU/201903030021.22070.randrianas...@gmail.com/ Not sure if Kmail can do this, maybe it has some settings for this but it's usually better to do all editing on the git commit and send patch mails with git send-email. Guess next time I better to add second "-s" to git format-patch, so first signed-off-by-line from original will be around too? Or ..lets wait what actual maintainers will say. Yes, I'll let actual maintainers to comment then you can do a corrected version with any requested fixes or Reviewed-by tags added. I think for next revision you should leave original author's Signed-off-by in commit message and add yours with -s after that. (When sending another version of a patch use -v2 option of git format-patch to add v2 to the patch subject and so on for higher revisions if needed.) Regards, BALATON Zoltan
Re: [Qemu-devel] [Qemu-ppc] Forward-porting RTC device for eppc500 ?
В сообщении от Saturday 02 March 2019 23:40:47 BALATON Zoltan написал(а):
[snip]
>
> On Sat, 2 Mar 2019, Andrew Randrianasulu wrote:
> > Should I fix those?
>
> [...]
>
> > total: 14 errors, 2 warnings, 462 lines checked
> >
> > 0001-Re-applying-of-Freescale-PPC500-i2c-RTC-patch-writte.patch has style
> > problems, please review. If any of these errors
> > are false positives report them to the maintainer, see
> > CHECKPATCH in MAINTAINERS.
>
> Yes, patches submitted to the list should pass checkpatch otherwise they
> will be rejected by automated build tests. These are simple to fix, just
> add spaces as checkpatch suggests: (1 << 0) and so on.
>
> (It's better to keep the list cc-d on reply so others can also answer your
> questions or correct my answers if I missed something which is not
> possible if you reply to me off list.)
Posted to list, arrived as
https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg00413.html
I used (in specifically created branch)
git reset origin
git reset --hard
git apply \
/home/guest/botva/src/src/qemu/0001-Re-applying-Freescale-PPC500-i2c-RTC-patch-written-b.patch
rm hw/i2c/mpc_i2c.c (leftover from my previous attempt at commiting)
again
git apply \
/home/guest/botva/src/src/qemu/0001-Re-applying-Freescale-PPC500-i2c-RTC-patch-written-b.patch
{now it applies cleanly)
git add hw/i2c/mpc_i2c.c
make
ppc64-softmmu/qemu-system-ppc64 -M ppce500 -cpu
e5500 -kernel
/mnt/sdb1/PPC-img/linux-image-4.20.12-X1000_X5000/X5000_and_QEMU_e5500/uImage-4.20
-nographic
git commit -a --author="Amit Singh Tomar "
git format-patch -s 20b084c4b1401b7f8fbc385649d48c67b6f43d44
scripts/checkpatch.pl 0001-Re-applying-Freescale-PPC-E500-i2c-RTC-patch.patch
After this I created new message in Kmail and inserted 0001 file, edited it a
bit more (adding patchwork link and mentioning fact I actually boot-tested
patch), and then send out.
Guess next time I better to add second "-s" to git format-patch, so first
signed-off-by-line from original will be around too?
Or ..lets wait what actual maintainers will say.
>
> Regards,
> BALATON Zoltan
Re: [Qemu-devel] [Qemu-ppc] Forward-porting RTC device for eppc500 ?
Hello,
On Sat, 2 Mar 2019, Andrew Randrianasulu wrote:
Hello, all!
I stumbled upon this email from 2015 (trying to understand why my emulated
ppce500 machine failed to set clock correctly:
https://lists.gnu.org/archive/html/qemu-devel/2015-01/msg02642.html
Now, after some quite blind trial-and-error I applied ('forward-ported') this
patch to qemu git commit 0f6a6d5db853c0cbe438c1831c70710bfb6530ee without
actually porting it to new qemu device abstraction model.
It seems to work!
But because I copy-pasted patch from web archive of list - some strings
become "address@hidden", I hope I corrected them right?
You can get all patches submitted to the list from patchew, the original
of this one is here:
http://patchwork.ozlabs.org/patch/431475/
The mbox format patch for git am is at the mbox link:
http://patchwork.ozlabs.org/patch/431475/mbox/
I think you could try to apply that patch with git am, fix any conflicts
due to changes in QEMU since the original patch to get an updated commit,
then use git format-patch to get a current patch you can submit to the
list for inclusion. The detailed description of how to send a patch is
here: https://wiki.qemu.org/Contribute/SubmitAPatch
Basically you should make sure you have an email that can be applied with
git am as that's what maintainers do. It should also have your
Signed-off-by if you made any changes to the patch after the original
Signed-off-by of the original author (you can add it e.g. with git commit
-s or git format-patch -s). Check the patch with scripts/checkpatch.pl
before sending and fix all errors and cc maintainers that you can get with
scripts/get_maintainer.pl. For PPC related stuff you should usually cc
qemu-...@nongnu.org and David Gibson besides sending to
qemu-devel@nongnu.org to make sure it's not lost.
I don't have any comments to the patch, some more comments below the other
topic at the end.
---
diff --git a/default-configs/ppc-softmmu.mak b/default-configs/ppc-softmmu.mak
index 52acb7cf39..a560971f0c 100644
--- a/default-configs/ppc-softmmu.mak
+++ b/default-configs/ppc-softmmu.mak
@@ -8,6 +8,8 @@ include usb.mak
CONFIG_PPC4XX=y
CONFIG_M48T59=y
CONFIG_SERIAL=y
+CONFIG_MPC_I2C=y
+CONFIG_DS1338=y
CONFIG_I8257=y
CONFIG_OPENPIC=y
CONFIG_PPCE500_PCI=y
diff --git a/hw/i2c/Makefile.objs b/hw/i2c/Makefile.objs
index cecee486f7..55473fc6b2 100644
--- a/hw/i2c/Makefile.objs
+++ b/hw/i2c/Makefile.objs
@@ -9,5 +9,6 @@ common-obj-$(CONFIG_EXYNOS4) += exynos4210_i2c.o
common-obj-$(CONFIG_IMX_I2C) += imx_i2c.o
common-obj-$(CONFIG_ASPEED_SOC) += aspeed_i2c.o
common-obj-$(CONFIG_NRF51_SOC) += microbit_i2c.o
+common-obj-$(CONFIG_MPC_I2C) += mpc_i2c.o
obj-$(CONFIG_OMAP) += omap_i2c.o
obj-$(CONFIG_PPC4XX) += ppc4xx_i2c.o
diff --git a/hw/i2c/mpc_i2c.c b/hw/i2c/mpc_i2c.c
new file mode 100644
index 00..54d7a9aabd
--- /dev/null
+++ b/hw/i2c/mpc_i2c.c
@@ -0,0 +1,360 @@
+/*
+ * Copyright (C) 2014 Freescale Semiconductor, Inc. All rights reserved.
+ *
+ * Author: Amit Tomar,
+ *
+ * Description:
+ * This file is derived from IMX I2C controller,
+ * by Jean-Christophe DUBOIS .
+ *
+ * Thanks to Scott Wood and Alexander Graf for their kind help on this.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License, version 2 or later,
+ * as published by the Free Software Foundation.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, see
