Re: [Stable-7.2.12 00/29] Patch Round-up for stable 7.2.12, frozen at 2024-06-07
10.06.2024 15:21, Eric Blake wrote: On Mon, Jun 10, 2024 at 07:17:53AM GMT, Eric Blake wrote: In addition to these two, we also need the following for NBD: 14ddea7e3c81 Eric Blake: qio: Inherit follow_coroutine_ctx across TLS and optionally: 5905c09466f4 Eric Blake: iotests: test NBD+TLS+iothread Hmm; I see you did include them for the 8.2.x branch; and the regression they fix was only introduced in 8.2. Unless we backported the work of removing AioContext to 7.2.x, then not backporting these two that far should not be an issue, after all. Ah yes, some of these don't apply to older (here: 7.2) versions, especially because 7.2 lacks AioContext removal. Such change is too intrusive for a stable release, I'd say. I was in a hurry when replied to your previous reply and didn't check before writing, - if I'd look I would know the reason why I haven't picked them up for 7.2 right away. I'm sorry for this noise. And thank you once again for checking and letting me know, - such attention is appreciated, it is a good reality check for my own sanity ;) (I keep stable-7.2 branch alive still, because it is used in debian stable and in redhat). Thanks! /mjt -- GPG Key transition (from rsa2048 to rsa4096) since 2024-04-24. New key: rsa4096/61AD3D98ECDF2C8E 9D8B E14E 3F2A 9DD7 9199 28F1 61AD 3D98 ECDF 2C8E Old key: rsa2048/457CE0A0804465C5 6EE1 95D1 886E 8FFB 810D 4324 457C E0A0 8044 65C5 Transition statement: http://www.corpit.ru/mjt/gpg-transition-2024.txt
Re: [Stable-7.2.12 00/29] Patch Round-up for stable 7.2.12, frozen at 2024-06-07
On Mon, Jun 10, 2024 at 03:20:53PM GMT, Michael Tokarev wrote: > 10.06.2024 15:17, Eric Blake wrote: > > > 01* 690ceb71936f Philippe Mathieu-Daudé: > > > gitlab-ci: Remove job building EDK2 firmware binaries > > > 02* 7bc1286b81d4 Palmer Dabbelt: > > > gitlab/opensbi: Move to docker:stable > > > 03* 04f6fb897a5a Michael Tokarev: > > > linux-user: do_setsockopt: fix SOL_ALG.ALG_SET_KEY > > > 04* ae6d91a7e9b7 Zhu Yangyang: > > > nbd/server: do not poll within a coroutine context > > > 05* 4fa333e08dd9 Eric Blake: > > > nbd/server: Mark negotiation functions as coroutine_fn > > > > In addition to these two, we also need the following for NBD: > > > > 14ddea7e3c81 Eric Blake: > >qio: Inherit follow_coroutine_ctx across TLS > > Does it need to be in 7.2.12, or can it wait for the next, 7.2.13, release? > > I tagged 7.2.12 yesterday already. So if this change is also needed, I guess > we can make 7.2.13 release sooner than later. > > Thank you for letting me know! See my other response; but I just searched 'git log v7.2.0..origin/stable-7.2', and do not see any mention of 06e0f098 being backported, therefore the trigger is not there and the qio patch is not needed. So it looks there is no need for an immediate 7.2.13, at least from my end. -- Eric Blake, Principal Software Engineer Red Hat, Inc. Virtualization: qemu.org | libguestfs.org
Re: [Stable-7.2.12 00/29] Patch Round-up for stable 7.2.12, frozen at 2024-06-07
On Mon, Jun 10, 2024 at 07:17:53AM GMT, Eric Blake wrote: > On Fri, Jun 07, 2024 at 10:12:02PM GMT, Michael Tokarev wrote: > > The following patches are queued for QEMU stable v7.2.12: > > > > https://gitlab.com/qemu-project/qemu/-/commits/staging-7.2 > > > > Patch freeze is 2024-06-07 (frozen), and the release is planned for > > 2024-06-09: > > > > https://wiki.qemu.org/Planning/7.2 > > > > Please respond here or CC qemu-sta...@nongnu.org on any additional notes > > about the planning release. > > > > The changes which are staging for inclusion, with the original commit hash > > from master branch, are given below the bottom line. > > > > Thanks! > > > > /mjt > > > > -- > > 01* 690ceb71936f Philippe Mathieu-Daudé: > >gitlab-ci: Remove job building EDK2 firmware binaries > > 02* 7bc1286b81d4 Palmer Dabbelt: > >gitlab/opensbi: Move to docker:stable > > 03* 04f6fb897a5a Michael Tokarev: > >linux-user: do_setsockopt: fix SOL_ALG.ALG_SET_KEY > > 04* ae6d91a7e9b7 Zhu Yangyang: > >nbd/server: do not poll within a coroutine context > > 05* 4fa333e08dd9 Eric Blake: > >nbd/server: Mark negotiation functions as coroutine_fn > > In addition to these two, we also need the following for NBD: > > 14ddea7e3c81 Eric Blake: > qio: Inherit follow_coroutine_ctx across TLS > > and optionally: > 5905c09466f4 Eric Blake: > iotests: test NBD+TLS+iothread Hmm; I see you did include them for the 8.2.x branch; and the regression they fix was only introduced in 8.2. Unless we backported the work of removing AioContext to 7.2.x, then not backporting these two that far should not be an issue, after all. -- Eric Blake, Principal Software Engineer Red Hat, Inc. Virtualization: qemu.org | libguestfs.org
Re: [Stable-7.2.12 00/29] Patch Round-up for stable 7.2.12, frozen at 2024-06-07
10.06.2024 15:17, Eric Blake wrote: 01* 690ceb71936f Philippe Mathieu-Daudé: gitlab-ci: Remove job building EDK2 firmware binaries 02* 7bc1286b81d4 Palmer Dabbelt: gitlab/opensbi: Move to docker:stable 03* 04f6fb897a5a Michael Tokarev: linux-user: do_setsockopt: fix SOL_ALG.ALG_SET_KEY 04* ae6d91a7e9b7 Zhu Yangyang: nbd/server: do not poll within a coroutine context 05* 4fa333e08dd9 Eric Blake: nbd/server: Mark negotiation functions as coroutine_fn In addition to these two, we also need the following for NBD: 14ddea7e3c81 Eric Blake: qio: Inherit follow_coroutine_ctx across TLS Does it need to be in 7.2.12, or can it wait for the next, 7.2.13, release? I tagged 7.2.12 yesterday already. So if this change is also needed, I guess we can make 7.2.13 release sooner than later. Thank you for letting me know! /mjt -- GPG Key transition (from rsa2048 to rsa4096) since 2024-04-24. New key: rsa4096/61AD3D98ECDF2C8E 9D8B E14E 3F2A 9DD7 9199 28F1 61AD 3D98 ECDF 2C8E Old key: rsa2048/457CE0A0804465C5 6EE1 95D1 886E 8FFB 810D 4324 457C E0A0 8044 65C5 Transition statement: http://www.corpit.ru/mjt/gpg-transition-2024.txt
Re: [Stable-7.2.12 00/29] Patch Round-up for stable 7.2.12, frozen at 2024-06-07
On Fri, Jun 07, 2024 at 10:12:02PM GMT, Michael Tokarev wrote: > The following patches are queued for QEMU stable v7.2.12: > > https://gitlab.com/qemu-project/qemu/-/commits/staging-7.2 > > Patch freeze is 2024-06-07 (frozen), and the release is planned for > 2024-06-09: > > https://wiki.qemu.org/Planning/7.2 > > Please respond here or CC qemu-sta...@nongnu.org on any additional notes > about the planning release. > > The changes which are staging for inclusion, with the original commit hash > from master branch, are given below the bottom line. > > Thanks! > > /mjt > > -- > 01* 690ceb71936f Philippe Mathieu-Daudé: >gitlab-ci: Remove job building EDK2 firmware binaries > 02* 7bc1286b81d4 Palmer Dabbelt: >gitlab/opensbi: Move to docker:stable > 03* 04f6fb897a5a Michael Tokarev: >linux-user: do_setsockopt: fix SOL_ALG.ALG_SET_KEY > 04* ae6d91a7e9b7 Zhu Yangyang: >nbd/server: do not poll within a coroutine context > 05* 4fa333e08dd9 Eric Blake: >nbd/server: Mark negotiation functions as coroutine_fn In addition to these two, we also need the following for NBD: 14ddea7e3c81 Eric Blake: qio: Inherit follow_coroutine_ctx across TLS and optionally: 5905c09466f4 Eric Blake: iotests: test NBD+TLS+iothread -- Eric Blake, Principal Software Engineer Red Hat, Inc. Virtualization: qemu.org | libguestfs.org
