Re: [Qgis-developer] user-defined symbology defaults + project templates

2012-07-16 Thread Nathan Woodrow
Hey Etienne,

I like the ideas but I do some have some comments on the
implementation from a UI point of view.  I like being able to set the
default symbols for a project, that will come in very handy.  What I
would do here however is have a button with a icon and text rather
than a combobox.  The button would open the symbol selector and let
the user select a symbol.  We are redoing the symbol manager and
symbol selector in the current GSoC, so I think the new version will
work well here. The new symbol manager allows for grouping and
searching so you wouldn't have to scroll though a massive list of
symbols.

For the templates thing I think that is a great idea however maybe we
can expand it a bit more and make it more flexible. What I think we
could do is rather then having a single default temple we could have a
template search path/s and give the user a list of .qgs files in these
folders.  To handle this in the UI I would have New Project From
Temple... menu item that has a sub menu listing all the templates, if
would also add a drop down menu to the New Project toolbar button to
let people select the template from the toolbar.

Thoughts?

- Nathan

On Sun, Jul 15, 2012 at 7:10 AM, Etienne Tourigny
etourigny@gmail.com wrote:
 Hi all,

 There are 2 interrelated topics that I have been thinking about and
 have come up with a solution, and I would like to get other's feedback
 before proceeding further.

 1) Default symbol styles are not user configurable - for example new
 polygons are always filled with a random color, new point symbols are
 always small red dots, etc.

 I see 2 ways to change this - either global or project based. I think
 project based is better because defaults in a given project are
 probably not best for all projects.

 So I have implemented the interface and back-end to select default
 symbology (point, line, polygon) and color ramps for a project, and
 all new symbols have identical properties.
 See attached screenshot for an idea. Should probably also add options
 for rasters (i.e. what's already in the prefs, plus default renderer
 style).

 2) New project defaults may not be ideal for all users - see
 background discussion below which deals with default composer
 templates.

 A solution to this is to have a default project (template) which is
 loaded when a new project is created. My solution allows to select the
 default project template and also adds a UI to load a blank project.
 I realize this may cause some problems, but it's nicer than to have to
 manually load a project template after creating a new project (or
 opening qgis for the first time).

 This, combined with the symbology defaults, means that a user can
 define his personal symbology defaults and have them always loaded
 when a new project is created.

 Any ideas/comments?

 Etienne

 Background discussion:
 http://lists.osgeo.org/pipermail/qgis-user/2012-June/017443.html

 My branch which implements solutions for these 2 issues:
 https://github.com/etiennesky/Quantum-GIS/tree/symbology-default

 ___
 Qgis-developer mailing list
 Qgis-developer@lists.osgeo.org
 http://lists.osgeo.org/mailman/listinfo/qgis-developer

___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer


Re: [Qgis-developer] user-defined symbology defaults + project templates

2012-07-16 Thread Denis Rouzaud

Hi,

I think this is pretty useful!
In parallel to templates, how about adding a button in the project 
settings, to make these settings as global default settings?


Greetings,

Denis

On 07/14/2012 11:10 PM, Etienne Tourigny wrote:

Hi all,

There are 2 interrelated topics that I have been thinking about and
have come up with a solution, and I would like to get other's feedback
before proceeding further.

1) Default symbol styles are not user configurable - for example new
polygons are always filled with a random color, new point symbols are
always small red dots, etc.

I see 2 ways to change this - either global or project based. I think
project based is better because defaults in a given project are
probably not best for all projects.

So I have implemented the interface and back-end to select default
symbology (point, line, polygon) and color ramps for a project, and
all new symbols have identical properties.
See attached screenshot for an idea. Should probably also add options
for rasters (i.e. what's already in the prefs, plus default renderer
style).

2) New project defaults may not be ideal for all users - see
background discussion below which deals with default composer
templates.

A solution to this is to have a default project (template) which is
loaded when a new project is created. My solution allows to select the
default project template and also adds a UI to load a blank project.
I realize this may cause some problems, but it's nicer than to have to
manually load a project template after creating a new project (or
opening qgis for the first time).

This, combined with the symbology defaults, means that a user can
define his personal symbology defaults and have them always loaded
when a new project is created.

Any ideas/comments?

Etienne

Background discussion:
http://lists.osgeo.org/pipermail/qgis-user/2012-June/017443.html

My branch which implements solutions for these 2 issues:
https://github.com/etiennesky/Quantum-GIS/tree/symbology-default


___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer



___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer


Re: [Qgis-developer] New adv labeling freeze-thaw tools

2012-07-16 Thread Marco Hugentobler

Hi Larry

Excellent work, thank you!
The freeze/thaw tool will be a great addition to the label tool bar.

I wonder if the tool could also be active if x/y is data defined and 
rotation not (currently, x/y/rotation need to be data defined to use the 
tool).


On a detail level, in QgsMapToolFreezeLabels::highlightLabel you could 
probably use QgsMapRenderer::mapToLayerCoordinates to transform the 
rectangle (instead of mCoordTransform ).


Regards,
Marco



Am 16.07.2012 05:31, schrieb Larry Shaffer:

Hi,

The current large-format project I'm working on requires me to layout,
for print, thousands of labels. So I spent the last couple of days
making two new tools for the advanced labeling toolbar that allow the
user to interactively 'freeze' (write coords and rotation info to
attribute table) and 'thaw' (revert from data-defined to dynamic) any
rendered labels.

*Show Frozen Labels*

This tool highlights frozen labels for all visible layers. Blue
highlighted labels are frozen, green are frozen and editable (parent
layer's in edit mode).

*Freeze/Thaw Labels*

This tool allows the user to interactively choose, by single or
marquee selection, labels to freeze or thaw. The in-memory attribute
table is immediately updated and results shown to user. This tool
allows the user to interactively manipulate the PAL labeling engine to
find the best solutions for their frozen labels.

Since the topic and how the tool interacts with the labeling engine is
more complicated, I made an intro video. (Note: I haven't had much
sleep recently, so it's a bit rough.)

http://vimeo.com/dakotacarto/freezethawlabels


This is my first C++ project, so I'd be really happy if someone
audited the code before I squash the commits and send a pull request:

https://github.com/dakcarto/Quantum-GIS/tree/feature_freeze-thaw-labels

Only tested on Mac, as of now. Nothing platform-specific about it though.

Regards,

Larry Shaffer
Dakota Cartography
Black Hills, South Dakota


___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer



--
Dr. Marco Hugentobler
Sourcepole -  Linux  Open Source Solutions
Weberstrasse 5, CH-8004 Zürich, Switzerland
marco.hugentob...@sourcepole.ch http://www.sourcepole.ch
Technical Advisor QGIS Project Steering Committee

___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer


Re: [Qgis-developer] Implementing project scales list

2012-07-16 Thread Marco Hugentobler

Hi Alexander

Ok, that sounds reasonable to me (new class in core directory). In that 
case, the new class has a similar role for scales as QgsTolerance has 
for snap distances.



P.S. we can move this discussion do the developers list if necessary.


done.

Thanks,
Marco



Am 16.07.2012 10:28, schrieb Alexander Bruy:

Hi Marco.

2012/7/16 Marco Hugentobler marco.hugentob...@sourcepole.ch:

I'm working on feature #5561 Project scale list [0] and already
implement almost all desired functionality.

Is the implementation similar to the patch which currently is attached to
the ticket?

It uses same idea but with a little different implementation. First I implement
ability to change global scale list from QGIS settings so user can enter
preferred scales and always use them in all project. The second step is a
project level scale list, which can override global settings.

I just push this branch to my fork on GitHub here:
https://github.com/alexbruy/Quantum-GIS/tree/project_scale


Is it ok to create such class and where is better to place it? I think,
it should go to core subdirectory

Could you explain the functionality of the scale manager class? If it is
just QgsProject::instance()-readListEntry() / writeEntry(), it might be
overkill to create a new class (but I guess there is more, I just did not
follow the ticket too closely).

I already use QgsProject::instance()-readListEntry() / writeEntry() to read
and write scale list defined per-project. But I also want to provide for users
easy method to save scale list, move it to another PC (like connection
settings or shortcuts) and then load this list as global or project.

So this class will create separate XML (or even plain text) file from
global/project
scale list or populate global/project scale list from existing file.

P.S. we can move this discussion do the developers list if necessary.

Thanks for your time



--
Dr. Marco Hugentobler
Sourcepole -  Linux  Open Source Solutions
Weberstrasse 5, CH-8004 Zürich, Switzerland
marco.hugentob...@sourcepole.ch http://www.sourcepole.ch
Technical Advisor QGIS Project Steering Committee

___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer


Re: [Qgis-developer] New adv labeling freeze-thaw tools

2012-07-16 Thread Larry Shaffer
On Mon, Jul 16, 2012 at 2:18 AM, Marco Hugentobler
marco.hugentob...@sourcepole.ch wrote:
 Hi Larry

 Excellent work, thank you!
 The freeze/thaw tool will be a great addition to the label tool bar.

 I wonder if the tool could also be active if x/y is data defined and
 rotation not (currently, x/y/rotation need to be data defined to use the
 tool).

Yes, that is an unnecessary restriction. I'll make the rotation field optional.

 On a detail level, in QgsMapToolFreezeLabels::highlightLabel you could
 probably use QgsMapRenderer::mapToLayerCoordinates to transform the
 rectangle (instead of mCoordTransform ).

Will make the change. Thanks.

If you have the time to look at the constructor for
QgsMapToolFreezeLabels (the FIXME), you'll notice I could not find a
way to make the signal/slot connections from there. Currently they are
in qgisapp.cpp, but I would prefer to not pollute that core file with
any more of my tool's code than necessary. What's the simplest way to
create the connections from inside my QObject-inherited tool instead?

Regards,
Larry



 Am 16.07.2012 05:31, schrieb Larry Shaffer:

 Hi,

 The current large-format project I'm working on requires me to layout,
 for print, thousands of labels. So I spent the last couple of days
 making two new tools for the advanced labeling toolbar that allow the
 user to interactively 'freeze' (write coords and rotation info to
 attribute table) and 'thaw' (revert from data-defined to dynamic) any
 rendered labels.

 *Show Frozen Labels*

 This tool highlights frozen labels for all visible layers. Blue
 highlighted labels are frozen, green are frozen and editable (parent
 layer's in edit mode).

 *Freeze/Thaw Labels*

 This tool allows the user to interactively choose, by single or
 marquee selection, labels to freeze or thaw. The in-memory attribute
 table is immediately updated and results shown to user. This tool
 allows the user to interactively manipulate the PAL labeling engine to
 find the best solutions for their frozen labels.

 Since the topic and how the tool interacts with the labeling engine is
 more complicated, I made an intro video. (Note: I haven't had much
 sleep recently, so it's a bit rough.)

 http://vimeo.com/dakotacarto/freezethawlabels


 This is my first C++ project, so I'd be really happy if someone
 audited the code before I squash the commits and send a pull request:

 https://github.com/dakcarto/Quantum-GIS/tree/feature_freeze-thaw-labels

 Only tested on Mac, as of now. Nothing platform-specific about it though.

 Regards,

 Larry Shaffer
 Dakota Cartography
 Black Hills, South Dakota



 ___
 Qgis-developer mailing list
 Qgis-developer@lists.osgeo.org
 http://lists.osgeo.org/mailman/listinfo/qgis-developer



 --
 Dr. Marco Hugentobler
 Sourcepole -  Linux  Open Source Solutions
 Weberstrasse 5, CH-8004 Zürich, Switzerland
 marco.hugentob...@sourcepole.ch http://www.sourcepole.ch
 Technical Advisor QGIS Project Steering Committee


 ___
 Qgis-developer mailing list
 Qgis-developer@lists.osgeo.org
 http://lists.osgeo.org/mailman/listinfo/qgis-developer

___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer


Re: [Qgis-developer] user-defined symbology defaults + project templates

2012-07-16 Thread Giovanni Manghi
Hi Etienne,

 This, combined with the symbology defaults, means that a user can
 define his personal symbology defaults and have them always loaded
 when a new project is created.
 
 Any ideas/comments?


very nice ideas!

I would add the possibility to allow the level of transparency for both
the filling of polygons and the level of transparency of the selection
color. At this moment are by default both 100% solid and this is not
handy in may cases. A certain amount of transparency for polygon filling
helps a lot to quickly see if there are overlapped areas.

Making the selection color a bit transparent is necessary because it can
hide polygons that are below other ones, or even cause to select
polygons by mistake (using the select features by rectangle tool, in
opposition to the select single feature tool). 

cheers

-- Giovanni --

___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer


Re: [Qgis-developer] user-defined symbology defaults + project templates

2012-07-16 Thread Etienne Tourigny
On Mon, Jul 16, 2012 at 5:04 AM, Nathan Woodrow madman...@gmail.com wrote:
 Hey Etienne,

 I like the ideas but I do some have some comments on the
 implementation from a UI point of view.  I like being able to set the
 default symbols for a project, that will come in very handy.  What I
 would do here however is have a button with a icon and text rather
 than a combobox.  The button would open the symbol selector and let
 the user select a symbol.  We are redoing the symbol manager and
 symbol selector in the current GSoC, so I think the new version will
 work well here. The new symbol manager allows for grouping and
 searching so you wouldn't have to scroll though a massive list of
 symbols.

I'm glad others see this as useful!

Any idea when these changes will be available, and if should I wait
before adding my changes to master? In the meantime, I could perhaps
push what I have done.
Currently, the button changes the selected symbol, but it could be
modified to open the symbol lists. I just thought this way was a bit
faster.


 For the templates thing I think that is a great idea however maybe we
 can expand it a bit more and make it more flexible. What I think we
 could do is rather then having a single default temple we could have a
 template search path/s and give the user a list of .qgs files in these
 folders.  To handle this in the UI I would have New Project From
 Temple... menu item that has a sub menu listing all the templates, if
 would also add a drop down menu to the New Project toolbar button to
 let people select the template from the toolbar.

 Thoughts?

I like the idea of multiple templates to choose from, but I would
still like a way to change the global defaults (see answer to Denis).

Any idea on how to manage the template list from a UI perspective?
Just have a file sector and have the user place/save the files there,
and then a dynamic menu which lists these files?

- Etienne



 - Nathan

 On Sun, Jul 15, 2012 at 7:10 AM, Etienne Tourigny
 etourigny@gmail.com wrote:
 Hi all,

 There are 2 interrelated topics that I have been thinking about and
 have come up with a solution, and I would like to get other's feedback
 before proceeding further.

 1) Default symbol styles are not user configurable - for example new
 polygons are always filled with a random color, new point symbols are
 always small red dots, etc.

 I see 2 ways to change this - either global or project based. I think
 project based is better because defaults in a given project are
 probably not best for all projects.

 So I have implemented the interface and back-end to select default
 symbology (point, line, polygon) and color ramps for a project, and
 all new symbols have identical properties.
 See attached screenshot for an idea. Should probably also add options
 for rasters (i.e. what's already in the prefs, plus default renderer
 style).

 2) New project defaults may not be ideal for all users - see
 background discussion below which deals with default composer
 templates.

 A solution to this is to have a default project (template) which is
 loaded when a new project is created. My solution allows to select the
 default project template and also adds a UI to load a blank project.
 I realize this may cause some problems, but it's nicer than to have to
 manually load a project template after creating a new project (or
 opening qgis for the first time).

 This, combined with the symbology defaults, means that a user can
 define his personal symbology defaults and have them always loaded
 when a new project is created.

 Any ideas/comments?

 Etienne

 Background discussion:
 http://lists.osgeo.org/pipermail/qgis-user/2012-June/017443.html

 My branch which implements solutions for these 2 issues:
 https://github.com/etiennesky/Quantum-GIS/tree/symbology-default

 ___
 Qgis-developer mailing list
 Qgis-developer@lists.osgeo.org
 http://lists.osgeo.org/mailman/listinfo/qgis-developer

___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer


Re: [Qgis-developer] user-defined symbology defaults + project templates

2012-07-16 Thread Etienne Tourigny
On Mon, Jul 16, 2012 at 5:11 AM, Denis Rouzaud denis.rouz...@gmail.com wrote:
 Hi,

 I think this is pretty useful!
 In parallel to templates, how about adding a button in the project settings,
 to make these settings as global default settings?

That's the idea of having a Default template, when you create a new
project it loads that project file. I saw it as the simplest way to
treat user defaults, without having to mess too much with the
back-end.
However, I see now that it's probably not the best way to deal with
user defaults.

Should these user defaults be saved to user configuration (QGis.conf),
or a special Default.qgs file in the.qgis directory, or in a
user-defined template file?

How would one proceed than, if for example, global defaults are
overridden by the user, and a specific template is loaded? First load
the global defaults, then the user defaults, then the specific
template?

cheers
Etienne


 Greetings,

 Denis


 On 07/14/2012 11:10 PM, Etienne Tourigny wrote:

 Hi all,

 There are 2 interrelated topics that I have been thinking about and
 have come up with a solution, and I would like to get other's feedback
 before proceeding further.

 1) Default symbol styles are not user configurable - for example new
 polygons are always filled with a random color, new point symbols are
 always small red dots, etc.

 I see 2 ways to change this - either global or project based. I think
 project based is better because defaults in a given project are
 probably not best for all projects.

 So I have implemented the interface and back-end to select default
 symbology (point, line, polygon) and color ramps for a project, and
 all new symbols have identical properties.
 See attached screenshot for an idea. Should probably also add options
 for rasters (i.e. what's already in the prefs, plus default renderer
 style).

 2) New project defaults may not be ideal for all users - see
 background discussion below which deals with default composer
 templates.

 A solution to this is to have a default project (template) which is
 loaded when a new project is created. My solution allows to select the
 default project template and also adds a UI to load a blank project.
 I realize this may cause some problems, but it's nicer than to have to
 manually load a project template after creating a new project (or
 opening qgis for the first time).

 This, combined with the symbology defaults, means that a user can
 define his personal symbology defaults and have them always loaded
 when a new project is created.

 Any ideas/comments?

 Etienne

 Background discussion:
 http://lists.osgeo.org/pipermail/qgis-user/2012-June/017443.html

 My branch which implements solutions for these 2 issues:
 https://github.com/etiennesky/Quantum-GIS/tree/symbology-default



 ___
 Qgis-developer mailing list
 Qgis-developer@lists.osgeo.org
 http://lists.osgeo.org/mailman/listinfo/qgis-developer



___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer


Re: [Qgis-developer] New adv labeling freeze-thaw tools

2012-07-16 Thread Marco Hugentobler

Hi Larry


If you have the time to look at the constructor for
QgsMapToolFreezeLabels (the FIXME), you'll notice I could not find a
way to make the signal/slot connections from there. Currently they are
in qgisapp.cpp, but I would prefer to not pollute that core file with
any more of my tool's code than necessary. What's the simplest way to
create the connections from inside my QObject-inherited tool instead?


The slot methods need to be declared as slots in the header file, like this:

public slots:

//! Update frozen label highlights on canvas render finished
void updateFrozenLabels();
//! Render rectangles around frozen labels
void highlightFrozenLabels();

Currently, they are just normal public methods.

Regards,
Marco

Am 16.07.2012 11:35, schrieb Larry Shaffer:

On Mon, Jul 16, 2012 at 2:18 AM, Marco Hugentobler
marco.hugentob...@sourcepole.ch wrote:

Hi Larry

Excellent work, thank you!
The freeze/thaw tool will be a great addition to the label tool bar.

I wonder if the tool could also be active if x/y is data defined and
rotation not (currently, x/y/rotation need to be data defined to use the
tool).

Yes, that is an unnecessary restriction. I'll make the rotation field optional.


On a detail level, in QgsMapToolFreezeLabels::highlightLabel you could
probably use QgsMapRenderer::mapToLayerCoordinates to transform the
rectangle (instead of mCoordTransform ).

Will make the change. Thanks.

If you have the time to look at the constructor for
QgsMapToolFreezeLabels (the FIXME), you'll notice I could not find a
way to make the signal/slot connections from there. Currently they are
in qgisapp.cpp, but I would prefer to not pollute that core file with
any more of my tool's code than necessary. What's the simplest way to
create the connections from inside my QObject-inherited tool instead?

Regards,
Larry




Am 16.07.2012 05:31, schrieb Larry Shaffer:

Hi,

The current large-format project I'm working on requires me to layout,
for print, thousands of labels. So I spent the last couple of days
making two new tools for the advanced labeling toolbar that allow the
user to interactively 'freeze' (write coords and rotation info to
attribute table) and 'thaw' (revert from data-defined to dynamic) any
rendered labels.

*Show Frozen Labels*

This tool highlights frozen labels for all visible layers. Blue
highlighted labels are frozen, green are frozen and editable (parent
layer's in edit mode).

*Freeze/Thaw Labels*

This tool allows the user to interactively choose, by single or
marquee selection, labels to freeze or thaw. The in-memory attribute
table is immediately updated and results shown to user. This tool
allows the user to interactively manipulate the PAL labeling engine to
find the best solutions for their frozen labels.

Since the topic and how the tool interacts with the labeling engine is
more complicated, I made an intro video. (Note: I haven't had much
sleep recently, so it's a bit rough.)

http://vimeo.com/dakotacarto/freezethawlabels


This is my first C++ project, so I'd be really happy if someone
audited the code before I squash the commits and send a pull request:

https://github.com/dakcarto/Quantum-GIS/tree/feature_freeze-thaw-labels

Only tested on Mac, as of now. Nothing platform-specific about it though.

Regards,

Larry Shaffer
Dakota Cartography
Black Hills, South Dakota



___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer



--
Dr. Marco Hugentobler
Sourcepole -  Linux  Open Source Solutions
Weberstrasse 5, CH-8004 Zürich, Switzerland
marco.hugentob...@sourcepole.ch http://www.sourcepole.ch
Technical Advisor QGIS Project Steering Committee


___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer




--
Dr. Marco Hugentobler
Sourcepole -  Linux  Open Source Solutions
Weberstrasse 5, CH-8004 Zürich, Switzerland
marco.hugentob...@sourcepole.ch http://www.sourcepole.ch
Technical Advisor QGIS Project Steering Committee

___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer


Re: [Qgis-developer] QgisApp::getThemePixmap() should be in QgsApplication instead?

2012-07-16 Thread Radim Blazek
On Mon, Jul 16, 2012 at 12:06 AM, Etienne Tourigny
etourigny@gmail.com wrote:
 Hi all,

 I think that QgisApp::getThemePixmap()  and getThemeIcon() should be
 in QgsApplication so that other modules can access it without
 requiring qgisapp, can I add it there and deprecate the one in
 QgisApp?

I think so. For example QgsDataItem::getThemePixmap (copy of
QgisApp::getThemePixmap)  exists only because QgisApp::getThemePixmap
is not available in core.

Do you want to keep QgisApp::getThemePixmap in 2.0 as deprecated or do
you want to deprecate it for a while and remove before 2.0 release?
General question, is it 2.0 going to have deprecated methods? It
should not, I believe.

Radim

 Etienne
 ___
 Qgis-developer mailing list
 Qgis-developer@lists.osgeo.org
 http://lists.osgeo.org/mailman/listinfo/qgis-developer
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer


Re: [Qgis-developer] QgisApp::getThemePixmap() should be in QgsApplication instead?

2012-07-16 Thread Etienne Tourigny
On Mon, Jul 16, 2012 at 2:12 PM, Radim Blazek radim.bla...@gmail.com wrote:
 On Mon, Jul 16, 2012 at 12:06 AM, Etienne Tourigny
 etourigny@gmail.com wrote:
 Hi all,

 I think that QgisApp::getThemePixmap()  and getThemeIcon() should be
 in QgsApplication so that other modules can access it without
 requiring qgisapp, can I add it there and deprecate the one in
 QgisApp?

 I think so. For example QgsDataItem::getThemePixmap (copy of
 QgisApp::getThemePixmap)  exists only because QgisApp::getThemePixmap
 is not available in core.

my thoughts exactly


 Do you want to keep QgisApp::getThemePixmap in 2.0 as deprecated or do
 you want to deprecate it for a while and remove before 2.0 release?

I would mark it as deprecated it for a time, but remove it entirely
from qgisapp before 2.0 is released.

 General question, is it 2.0 going to have deprecated methods? It
 should not, I believe.

I guess there should not be, but you might want to keep some methods
for backwards-compat, depending on the case.


 Radim

 Etienne
 ___
 Qgis-developer mailing list
 Qgis-developer@lists.osgeo.org
 http://lists.osgeo.org/mailman/listinfo/qgis-developer
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer


Re: [Qgis-developer] QgisApp::getThemePixmap() should be in QgsApplication instead?

2012-07-16 Thread Martin Dobias
On Mon, Jul 16, 2012 at 7:24 PM, Etienne Tourigny
etourigny@gmail.com wrote:
 Do you want to keep QgisApp::getThemePixmap in 2.0 as deprecated or do
 you want to deprecate it for a while and remove before 2.0 release?

 I would mark it as deprecated it for a time, but remove it entirely
 from qgisapp before 2.0 is released.

Given that QgisApp methods can be used only within QGIS application
sources (src/app folder), it is really sufficient to change all
occurrences of getThemePixmap() to use QgsApplication, no need to keep
it as deprecated.

In any case, we should not release 2.0 with deprecated methods / classes.

Regards
Martin
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer


Re: [Qgis-developer] Implementing project scales list

2012-07-16 Thread Alexander Bruy
I just pushed to my fork [0] implementation for scales import/export.
If there are no objections, I'll merge it to master soon.

[0] https://github.com/alexbruy/Quantum-GIS/tree/project_scale

-- 
Alexander Bruy
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer


[Qgis-developer] Remember to look at dash after committing

2012-07-16 Thread Tim Sutton
Just a friendly reminder to those pushing into the master branch -
please remember to run the tests and also check on the dash that they
pass on all platforms. Doing this help can prevent regressions early
in the process.

http://dash.orfeo-toolbox.org/index.php?project=QGISdate=2012-07-15

Thanks!

Regards



-- 
Tim Sutton - QGIS Project Steering Committee Member (Release  Manager)
==
Please do not email me off-list with technical
support questions. Using the lists will gain
more exposure for your issues and the knowledge
surrounding your issue will be shared with all.

Visit http://linfiniti.com to find out about:
 * QGIS programming and support services
 * Mapserver and PostGIS based hosting plans
 * FOSS Consulting Services
Skype: timlinux
Irc: timlinux on #qgis at freenode.net
==
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer


Re: [Qgis-developer] Remember to look at dash after committing

2012-07-16 Thread Etienne Tourigny
Hi Tim

is there any way to get bigger images, when we run the tests locally?
I suspect these errors may be due to a small change I committed (gdal
min/max calculations), will act upon this shortly.

Regards,
Etienne

On Mon, Jul 16, 2012 at 6:15 PM, Tim Sutton li...@linfiniti.com wrote:
 Just a friendly reminder to those pushing into the master branch -
 please remember to run the tests and also check on the dash that they
 pass on all platforms. Doing this help can prevent regressions early
 in the process.

 http://dash.orfeo-toolbox.org/index.php?project=QGISdate=2012-07-15

 Thanks!

 Regards



 --
 Tim Sutton - QGIS Project Steering Committee Member (Release  Manager)
 ==
 Please do not email me off-list with technical
 support questions. Using the lists will gain
 more exposure for your issues and the knowledge
 surrounding your issue will be shared with all.

 Visit http://linfiniti.com to find out about:
  * QGIS programming and support services
  * Mapserver and PostGIS based hosting plans
  * FOSS Consulting Services
 Skype: timlinux
 Irc: timlinux on #qgis at freenode.net
 ==
 ___
 Qgis-developer mailing list
 Qgis-developer@lists.osgeo.org
 http://lists.osgeo.org/mailman/listinfo/qgis-developer
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer


Re: [Qgis-developer] Remember to look at dash after committing

2012-07-16 Thread Etienne Tourigny
I all,

I am writing some tests for the histogram (still a few fixes in the
oven), and I was wondering how I could take advantage of the existing
qgsrenderchecker.

As these tests have invisible gui elements (I have refactored the
histogram into a standalone widget), I'm not sure it should reside in
the core/ directory but be part of the gui/ directory.

Basically the 2 options I see:
- subclass QgsRenderChecker in gui/testqgsrasterhistogram.cpp file
- add these tests to QgsRenderChecker

any ideas?
Etienne

On Mon, Jul 16, 2012 at 6:15 PM, Tim Sutton li...@linfiniti.com wrote:
 Just a friendly reminder to those pushing into the master branch -
 please remember to run the tests and also check on the dash that they
 pass on all platforms. Doing this help can prevent regressions early
 in the process.

 http://dash.orfeo-toolbox.org/index.php?project=QGISdate=2012-07-15

 Thanks!

 Regards



 --
 Tim Sutton - QGIS Project Steering Committee Member (Release  Manager)
 ==
 Please do not email me off-list with technical
 support questions. Using the lists will gain
 more exposure for your issues and the knowledge
 surrounding your issue will be shared with all.

 Visit http://linfiniti.com to find out about:
  * QGIS programming and support services
  * Mapserver and PostGIS based hosting plans
  * FOSS Consulting Services
 Skype: timlinux
 Irc: timlinux on #qgis at freenode.net
 ==
 ___
 Qgis-developer mailing list
 Qgis-developer@lists.osgeo.org
 http://lists.osgeo.org/mailman/listinfo/qgis-developer
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer


Re: [Qgis-developer] Remember to look at dash after committing

2012-07-16 Thread John C. Tull
Speaking of tests, ignore the last post from hawkeye. I'll send an update later 
that will include the latest code improvements and a working test run.

On Jul 16, 2012, at 2:15 PM, Tim Sutton wrote:

 Just a friendly reminder to those pushing into the master branch -
 please remember to run the tests and also check on the dash that they
 pass on all platforms. Doing this help can prevent regressions early
 in the process.
 
 http://dash.orfeo-toolbox.org/index.php?project=QGISdate=2012-07-15
 
 Thanks!
 
 Regards
 
 
 
 -- 
 Tim Sutton - QGIS Project Steering Committee Member (Release  Manager)
 ==
 Please do not email me off-list with technical
 support questions. Using the lists will gain
 more exposure for your issues and the knowledge
 surrounding your issue will be shared with all.
 
 Visit http://linfiniti.com to find out about:
 * QGIS programming and support services
 * Mapserver and PostGIS based hosting plans
 * FOSS Consulting Services
 Skype: timlinux
 Irc: timlinux on #qgis at freenode.net
 ==
 ___
 Qgis-developer mailing list
 Qgis-developer@lists.osgeo.org
 http://lists.osgeo.org/mailman/listinfo/qgis-developer

___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer


Re: [Qgis-developer] QgisApp::getThemePixmap() should be in QgsApplication instead?

2012-07-16 Thread Etienne Tourigny
Committed - there were quite a few changes, and I checked a few
dialogs to make sure it it ok. If anything is funky in icons, the
cause might be here.

On Mon, Jul 16, 2012 at 2:41 PM, Martin Dobias wonder...@gmail.com wrote:
 On Mon, Jul 16, 2012 at 7:24 PM, Etienne Tourigny
 etourigny@gmail.com wrote:
 Do you want to keep QgisApp::getThemePixmap in 2.0 as deprecated or do
 you want to deprecate it for a while and remove before 2.0 release?

 I would mark it as deprecated it for a time, but remove it entirely
 from qgisapp before 2.0 is released.

 Given that QgisApp methods can be used only within QGIS application
 sources (src/app folder), it is really sufficient to change all
 occurrences of getThemePixmap() to use QgsApplication, no need to keep
 it as deprecated.

 In any case, we should not release 2.0 with deprecated methods / classes.

 Regards
 Martin
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer


Re: [Qgis-developer] histogram fixes and improvements

2012-07-16 Thread Etienne Tourigny
On Sun, Jul 15, 2012 at 5:30 AM, Alexander Bruy
alexander.b...@gmail.com wrote:
 Hi Etienne,

 2012/7/14 Etienne Tourigny etourigny@gmail.com:
 - don't use color interpretation band names when band count  1

 IMO, this should be handled in different way. Color interpretation
 also often used in multiband images, so show this info only for
 singleband raster is not correct.

 I just commited my own fixes, including fix for color interpretation
 handling: now all info is displayed as Band 1 (color_intepretation)
 or simply Band 1, if color interpretation is not available.

This makes more sense.

BTW I have added a new test for histogram rendering.


 --
 Alexander Bruy
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer


Re: [Qgis-developer] user-defined symbology defaults + project templates

2012-07-16 Thread Nathan Woodrow
On Tue, Jul 17, 2012 at 1:19 AM, Etienne Tourigny
etourigny@gmail.com wrote:

 I'm glad others see this as useful!

 Any idea when these changes will be available, and if should I wait
 before adding my changes to master? In the meantime, I could perhaps
 push what I have done.
 Currently, the button changes the selected symbol, but it could be
 modified to open the symbol lists. I just thought this way was a bit
 faster.

The reasons I suggested not using a combobox is because with long
names the combobox grows and pushes the size of the dialog box out,
although with a button you are going to have the same issue I guess.
I'm happy for a commit of what you have so far and then we can rework
it once the GSoC stuff is in master.


 I like the idea of multiple templates to choose from, but I would
 still like a way to change the global defaults (see answer to Denis).

+1 as long it is obvious that the defaults have been changed.

 Any idea on how to manage the template list from a UI perspective?
 Just have a file sector and have the user place/save the files there,
 and then a dynamic menu which lists these files?

I would have a folder called 'project_templates in the .qgis folder
and the list could be read from there by default, you could also have
a place in the global settings where you could define other folders to
look for templates.  I might store projects on a network folder so
that other people can access them so it would be good to be able to
tell QGIS to look in there too.

- Nathan
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer


Re: [Qgis-developer] user-defined symbology defaults + project templates

2012-07-16 Thread Nathan Woodrow
On Tue, Jul 17, 2012 at 1:20 AM, Etienne Tourigny
etourigny@gmail.com wrote:
 How would one proceed than, if for example, global defaults are
 overridden by the user, and a specific template is loaded? First load
 the global defaults, then the user defaults, then the specific
 template?

For me the template should overwrite everything.  If I go File- New
Project From Template - My Template then it will take priority over
anything I have set anywhere else.

- Nathan
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer