Re: [QGIS-Developer] Code repository link not updated in Plugin manager and plugin website

2024-01-28 Thread Raymond Nijssen via QGIS-Developer

Diving in the code I found a few suspicious lines.

1. In the Django code, there's no mention of "repository" in this list:

https://github.com/qgis/QGIS-Django/blob/6d03c8428abe9df7634bbf810bbcb63709b11d45/qgis-app/plugins/views.py#L908

2. In the QGIS code, the PluginManager seems to look for 
"code_repository" and not "repository".


https://github.com/qgis/QGIS/blob/4293d4f1c57614e0a4d3835b7d9f18b3a78bcbd1/src/app/pluginmanager/qgspluginmanager.cpp#L991

Hope this helps fixing it. I currently don't have time to setup the 
Django environment and and try fixing it myself.


Raymond


On 26-01-2024 10:03, Raymond Nijssen via QGIS-Developer wrote:

Dear developers,

I found some unexpected behaviour in the plugin management.

I changed the the plugin source code to another github repository and 
wanted to update the links in the plugin metadata.


1. When updating the metadata localy, and running the plugin from local 
code, the metadata changelog is updated (so I know QGIS has read the 
metadata.txt) but the links to the code, homepage and tracker are still 
pointing to the old repository.


2. After uploading the new version of the plugin to the QGIS plugin 
repository, the links to homepage and tracker are updated but the link 
to the code keeps pointing to the old location. (See screenshot)


Is this a bug? If so, where should I file it?

Kind regards and happy QGIS Open Day! :)

Raymond

___
QGIS-Developer mailing list
QGIS-Developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer

___
QGIS-Developer mailing list
QGIS-Developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer


Re: [QGIS-Developer] Code repository link not updated in Plugin manager and plugin website

2024-01-28 Thread Matthias Kuhn via QGIS-Developer
Hi Raymond

Lova is doing some excellent work on the plugin repository recently.
Maybe he will find the time to look into this?
In any case, I think it would be worth opening an issue with your research
on https://github.com/qgis/QGIS-Django/issues to not forget about it and
have a contextualized discussion.

Kind regards
Matthias

On Mon, Jan 29, 2024 at 8:45 AM Raymond Nijssen via QGIS-Developer <
qgis-developer@lists.osgeo.org> wrote:

> Diving in the code I found a few suspicious lines.
>
> 1. In the Django code, there's no mention of "repository" in this list:
>
>
> https://github.com/qgis/QGIS-Django/blob/6d03c8428abe9df7634bbf810bbcb63709b11d45/qgis-app/plugins/views.py#L908
>
> 2. In the QGIS code, the PluginManager seems to look for
> "code_repository" and not "repository".
>
>
> https://github.com/qgis/QGIS/blob/4293d4f1c57614e0a4d3835b7d9f18b3a78bcbd1/src/app/pluginmanager/qgspluginmanager.cpp#L991
>
> Hope this helps fixing it. I currently don't have time to setup the
> Django environment and and try fixing it myself.
>
> Raymond
>
>
> On 26-01-2024 10:03, Raymond Nijssen via QGIS-Developer wrote:
> > Dear developers,
> >
> > I found some unexpected behaviour in the plugin management.
> >
> > I changed the the plugin source code to another github repository and
> > wanted to update the links in the plugin metadata.
> >
> > 1. When updating the metadata localy, and running the plugin from local
> > code, the metadata changelog is updated (so I know QGIS has read the
> > metadata.txt) but the links to the code, homepage and tracker are still
> > pointing to the old repository.
> >
> > 2. After uploading the new version of the plugin to the QGIS plugin
> > repository, the links to homepage and tracker are updated but the link
> > to the code keeps pointing to the old location. (See screenshot)
> >
> > Is this a bug? If so, where should I file it?
> >
> > Kind regards and happy QGIS Open Day! :)
> >
> > Raymond
> >
> > ___
> > QGIS-Developer mailing list
> > QGIS-Developer@lists.osgeo.org
> > List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
> > Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
> ___
> QGIS-Developer mailing list
> QGIS-Developer@lists.osgeo.org
> List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
> Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
>
___
QGIS-Developer mailing list
QGIS-Developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer


Re: [QGIS-Developer] Code repository link not updated in Plugin manager and plugin website

2024-01-29 Thread Raymond Nijssen via QGIS-Developer

Thanks for replying Matthias. Done:

https://github.com/qgis/QGIS-Django/issues/350

Lova, let me know if I can help you with testing or something else.

This is the plugin that should get updated:
https://plugins.qgis.org/plugins/wfs_styler/#plugin-versions

Raymond


On 29-01-2024 08:53, Matthias Kuhn wrote:

Hi Raymond

Lova is doing some excellent work on the plugin repository recently.
Maybe he will find the time to look into this?
In any case, I think it would be worth opening an issue with your 
research on https://github.com/qgis/QGIS-Django/issues 
 to not forget about it and 
have a contextualized discussion.


Kind regards
Matthias

On Mon, Jan 29, 2024 at 8:45 AM Raymond Nijssen via QGIS-Developer 
mailto:qgis-developer@lists.osgeo.org>> 
wrote:


Diving in the code I found a few suspicious lines.

1. In the Django code, there's no mention of "repository" in this list:


https://github.com/qgis/QGIS-Django/blob/6d03c8428abe9df7634bbf810bbcb63709b11d45/qgis-app/plugins/views.py#L908
 


2. In the QGIS code, the PluginManager seems to look for
"code_repository" and not "repository".


https://github.com/qgis/QGIS/blob/4293d4f1c57614e0a4d3835b7d9f18b3a78bcbd1/src/app/pluginmanager/qgspluginmanager.cpp#L991
 


Hope this helps fixing it. I currently don't have time to setup the
Django environment and and try fixing it myself.

Raymond


On 26-01-2024 10:03, Raymond Nijssen via QGIS-Developer wrote:
 > Dear developers,
 >
 > I found some unexpected behaviour in the plugin management.
 >
 > I changed the the plugin source code to another github repository
and
 > wanted to update the links in the plugin metadata.
 >
 > 1. When updating the metadata localy, and running the plugin from
local
 > code, the metadata changelog is updated (so I know QGIS has read the
 > metadata.txt) but the links to the code, homepage and tracker are
still
 > pointing to the old repository.
 >
 > 2. After uploading the new version of the plugin to the QGIS plugin
 > repository, the links to homepage and tracker are updated but the
link
 > to the code keeps pointing to the old location. (See screenshot)
 >
 > Is this a bug? If so, where should I file it?
 >
 > Kind regards and happy QGIS Open Day! :)
 >
 > Raymond
 >
 > ___
 > QGIS-Developer mailing list
 > QGIS-Developer@lists.osgeo.org

 > List info:
https://lists.osgeo.org/mailman/listinfo/qgis-developer

 > Unsubscribe:
https://lists.osgeo.org/mailman/listinfo/qgis-developer

___
QGIS-Developer mailing list
QGIS-Developer@lists.osgeo.org 
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer

Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer



___
QGIS-Developer mailing list
QGIS-Developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer


Re: [QGIS-Developer] Code repository link not updated in Plugin manager and plugin website

2024-01-29 Thread Lova Andriarimalala via QGIS-Developer
Dear Raymond and Matthias,

Thank you, Raymond, for the help in fixing the issue.
Thank you also Matthias for the compliment.

I will add the issue to my work planning, take a look at it and let you know.
For now, if it helps, the plugin repo URL can be updated manually from the Edit 
page in the plugin Manage tab.

Best regards,
Lova

—
[Image]

Lova Andriarimalala
QGIS Full Stack Developer
Visit http://kartoza.com<http://kartoza.com/> to find out about open source:
* Desktop GIS programming services
* Geospatial web development
* GIS Training
* Consulting Services
Office: +261(0)34 09 524 73




From: Raymond Nijssen 
Date: Monday, 29 January 2024 at 11:16 AM
To: Matthias Kuhn 
Cc: qgis-developer@lists.osgeo.org , Lova 
Andriarimalala 
Subject: Re: [QGIS-Developer] Code repository link not updated in Plugin 
manager and plugin website
Thanks for replying Matthias. Done:

https://github.com/qgis/QGIS-Django/issues/350

Lova, let me know if I can help you with testing or something else.

This is the plugin that should get updated:
https://plugins.qgis.org/plugins/wfs_styler/#plugin-versions

Raymond


On 29-01-2024 08:53, Matthias Kuhn wrote:
> Hi Raymond
>
> Lova is doing some excellent work on the plugin repository recently.
> Maybe he will find the time to look into this?
> In any case, I think it would be worth opening an issue with your
> research on https://github.com/qgis/QGIS-Django/issues
> <https://github.com/qgis/QGIS-Django/issues> to not forget about it and
> have a contextualized discussion.
>
> Kind regards
> Matthias
>
> On Mon, Jan 29, 2024 at 8:45 AM Raymond Nijssen via QGIS-Developer
> mailto:qgis-developer@lists.osgeo.org>>
> wrote:
>
> Diving in the code I found a few suspicious lines.
>
> 1. In the Django code, there's no mention of "repository" in this list:
>
> 
> https://github.com/qgis/QGIS-Django/blob/6d03c8428abe9df7634bbf810bbcb63709b11d45/qgis-app/plugins/views.py#L908
>  
> <https://github.com/qgis/QGIS-Django/blob/6d03c8428abe9df7634bbf810bbcb63709b11d45/qgis-app/plugins/views.py#L908>
>
> 2. In the QGIS code, the PluginManager seems to look for
> "code_repository" and not "repository".
>
> 
> https://github.com/qgis/QGIS/blob/4293d4f1c57614e0a4d3835b7d9f18b3a78bcbd1/src/app/pluginmanager/qgspluginmanager.cpp#L991
>  
> <https://github.com/qgis/QGIS/blob/4293d4f1c57614e0a4d3835b7d9f18b3a78bcbd1/src/app/pluginmanager/qgspluginmanager.cpp#L991>
>
> Hope this helps fixing it. I currently don't have time to setup the
> Django environment and and try fixing it myself.
>
> Raymond
>
>
> On 26-01-2024 10:03, Raymond Nijssen via QGIS-Developer wrote:
>  > Dear developers,
>  >
>  > I found some unexpected behaviour in the plugin management.
>  >
>  > I changed the the plugin source code to another github repository
> and
>  > wanted to update the links in the plugin metadata.
>  >
>  > 1. When updating the metadata localy, and running the plugin from
> local
>  > code, the metadata changelog is updated (so I know QGIS has read the
>  > metadata.txt) but the links to the code, homepage and tracker are
> still
>  > pointing to the old repository.
>  >
>  > 2. After uploading the new version of the plugin to the QGIS plugin
>  > repository, the links to homepage and tracker are updated but the
> link
>  > to the code keeps pointing to the old location. (See screenshot)
>  >
>  > Is this a bug? If so, where should I file it?
>  >
>  > Kind regards and happy QGIS Open Day! :)
>  >
>  > Raymond
>  >
>  > ___
>  > QGIS-Developer mailing list
>  > QGIS-Developer@lists.osgeo.org
> <mailto:QGIS-Developer@lists.osgeo.org>
>  > List info:
> https://lists.osgeo.org/mailman/listinfo/qgis-developer
> <https://lists.osgeo.org/mailman/listinfo/qgis-developer>
>  > Unsubscribe:
> https://lists.osgeo.org/mailman/listinfo/qgis-developer
> <https://lists.osgeo.org/mailman/listinfo/qgis-developer>
> ___
> QGIS-Developer mailing list
> QGIS-Developer@lists.osgeo.org <mailto:QGIS-Developer@lists.osgeo.org>
> List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
> <https://lists.osgeo.org/mailman/listinfo/qgis-developer>
> Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
> <https://lists.osgeo.org/mailman/listinfo/qgis-developer>
>
___
QGIS-Developer mailing list
QGIS-Developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer