-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512
On 23-08-26 18:42:38, Marek Marczykowski-Górecki wrote:
> On Sat, Aug 26, 2023 at 06:40:32PM +0200, Marek Marczykowski-Górecki wrote:
> > On Fri, Aug 25, 2023 at 04:52:52PM +0200, Marek Marczykowski-Górecki wrote:
> > > On Mon, Aug 21, 2023 at 08:49:21PM +, Ben Grande wrote:
> > > > On 23-08-20 14:01:53, Marek Marczykowski-Górecki wrote:
> > > > > On Fri, Aug 11, 2023 at 02:17:00PM +, Ben Grande wrote:
> > > > > > Status:
> > > > > > - Missing change 'qubes-policy-editor' to 'qubes-policy-editor-gui';
> > > > >
> > > > > https://github.com/QubesOS/qubes-desktop-linux-manager/pull/172
> > > > >
> > > > > You can rename to plain qubes-policy-editor now.
> > > > >
> > > > > While at it, please add new files to packaging
> > > > > (debian/qubes-core-qrexec.install, rpm_spec/qubes-qrexec.spec.in).
> > > > > Right
> > > > > now packages fail to build.
> > > > >
> > > > > > - Missing review of the last commit quoted above.
> > > > >
> > > > > The last commit looks fine.
> > > >
> > > > Added files to packaging.
> > >
> > > You missed files in python lib dir (qrexec/tools/qubes_policy_...) in
> > > the spec file.
> >
> > I see you added it, but as qrexec_policy_* instead of qubes_policy_*...
>
> And also pylint complains...
> See:
> https://gitlab.com/QubesOS/qubes-core-qrexec/-/pipelines/982836773
>
> > > Generally, the preferred workflow is through github pull requests - we
> > > have CI configured there to catch issues like this. If you really hate
> > > github, sending patches like this is okay too, but since it requires a
> > > bit more manual work on my side (including pushing them to CI
> > > manually...), it also takes some more time to get them merged.
> > >
> > > > I believe in this case it is easier for you to pull from the 'lint'
> > > > branch instead of applying the patches manually as multiple commits were
> > > > done. If that is not the case, I will post the patches.
> > > >
> > > > https://codeberg.org/ben.grande.b/qubes-core-qrexec/src/branch/lint
> > >
> > > Yes, that's fine (but see above).
>
> --
> Best Regards,
> Marek Marczykowski-Górecki
> Invisible Things Lab
Due to the misshappens of not using CI and the extra time required to
review, sorry and the PR: https://github.com/QubesOS/qubes-core-qrexec/pull/122
Only a single commit to add the lint and editor.
- --
Benjamin Grande
-BEGIN PGP SIGNATURE-
iNUEARYKAH0WIQRklnEdsUUe50UmvUUbcxS/DMyWhwUCZOrz718UgAAuAChp
c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0NjQ5
NjcxMURCMTQ1MUVFNzQ1MjZCRDQ1MUI3MzE0QkYwQ0NDOTY4NwAKCRAbcxS/DMyW
hzSWAQDSfVi+MsDsQ5+AJgjPNJS5HPtnwj0MvyR9dvAKvkrqnAD/WW4QP3+dzh5Y
ov2217OCgwgbfhL20ed1wUSqFTThqQo=
=pQv4
-END PGP SIGNATURE-
--
You received this message because you are subscribed to the Google Groups
"qubes-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to qubes-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/qubes-devel/ZOrz77ceRdRQov2J%40personal-mutt.
