Re: [Rd] installing from source

2020-12-28 Thread Ben Bolker
  Kevin Ushey pointed out to me privately that he submitted a bug 
report and a patch for this about a month ago, which Kurt Hornik put in 
R-devel (c79477):


https://bugs.r-project.org/bugzilla/show_bug.cgi?id=17973

On 12/28/20 4:35 AM, Martin Maechler wrote:

Ben Bolker
 on Sun, 27 Dec 2020 15:02:47 -0500 writes:


 > There is a recurring issue with installing from source into paths
 > that contain single quotes/apostrophes. "Why would anyone do that??" is
 > certainly a legitimate response to such a problem, but I would also say
 > this constitutes a legitimate bug.  Would replacing both single-quotes
 > below with \\' solve the problem?

Here, I'm mostly among the  "Why would anyone do that??" people,
but I agree that it's worth some effort to try fixing this.

To your question above: Why don't you create a repr.ex. (we'd
want anyway for R-bugzilla) and *see* if your proposition solves
it - or did I misinterpret the Q?

 > I'm happy to post this (with a patch if my fix seems appropriate) on
 > r-bugzilla.


 > cheers
 > Ben Bolker

 > line 1672 of src/library/tools/R/install.R :

 > cmd <- paste0("tools:::.test_load_package('", pkg_name, "', ",
 > quote_path(lib), ")")


 > 
https://github.com/wch/r-source/blob/2eade649c80725352256f16509f9ff6919fd079c/src/library/tools/R/install.R#L1672

 > 
https://stackoverflow.com/questions/15129888/r-cmd-install-error-unexpected-symbol-in-test-load-package-function

 > 
https://stackoverflow.com/questions/65462881/cannot-download-packages-from-github-from-unexpected-symbol

 > __
 > R-devel@r-project.org mailing list
 > https://stat.ethz.ch/mailman/listinfo/r-devel



__
R-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-devel


Re: [Rd] installing from source

2020-12-28 Thread Martin Maechler
> Ben Bolker 
> on Sun, 27 Dec 2020 15:02:47 -0500 writes:

> There is a recurring issue with installing from source into paths 
> that contain single quotes/apostrophes. "Why would anyone do that??" is 
> certainly a legitimate response to such a problem, but I would also say 
> this constitutes a legitimate bug.  Would replacing both single-quotes 
> below with \\' solve the problem?

Here, I'm mostly among the  "Why would anyone do that??" people,
but I agree that it's worth some effort to try fixing this.

To your question above: Why don't you create a repr.ex. (we'd 
want anyway for R-bugzilla) and *see* if your proposition solves
it - or did I misinterpret the Q?

> I'm happy to post this (with a patch if my fix seems appropriate) on 
> r-bugzilla.


> cheers
> Ben Bolker

> line 1672 of src/library/tools/R/install.R :

> cmd <- paste0("tools:::.test_load_package('", pkg_name, "', ", 
> quote_path(lib), ")")


> 
https://github.com/wch/r-source/blob/2eade649c80725352256f16509f9ff6919fd079c/src/library/tools/R/install.R#L1672

> 
https://stackoverflow.com/questions/15129888/r-cmd-install-error-unexpected-symbol-in-test-load-package-function

> 
https://stackoverflow.com/questions/65462881/cannot-download-packages-from-github-from-unexpected-symbol

> __
> R-devel@r-project.org mailing list
> https://stat.ethz.ch/mailman/listinfo/r-devel

__
R-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-devel


[Rd] installing from source

2020-12-27 Thread Ben Bolker
  There is a recurring issue with installing from source into paths 
that contain single quotes/apostrophes. "Why would anyone do that??" is 
certainly a legitimate response to such a problem, but I would also say 
this constitutes a legitimate bug.  Would replacing both single-quotes 
below with \\' solve the problem?
   I'm happy to post this (with a patch if my fix seems appropriate) on 
r-bugzilla.


  cheers
Ben Bolker

line 1672 of src/library/tools/R/install.R :

  cmd <- paste0("tools:::.test_load_package('", pkg_name, "', ", 
quote_path(lib), ")")



https://github.com/wch/r-source/blob/2eade649c80725352256f16509f9ff6919fd079c/src/library/tools/R/install.R#L1672

https://stackoverflow.com/questions/15129888/r-cmd-install-error-unexpected-symbol-in-test-load-package-function

https://stackoverflow.com/questions/65462881/cannot-download-packages-from-github-from-unexpected-symbol

__
R-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-devel