[request-sponsor] The Diff Output For bug id 6207957
Krishna,
I'll sponsor you for this bug. I'll send comments on your proposed fix
off the list.
Antonello
krishna kumar wrote:
Sir,
I have already sent you the diff output but I think the following will
be more correct with the same effect.
Please check it.
*SCA Number:OS 0191*
My open solaris user id is : krishna.
*BUG ID : 6207957*
*SYNOPSIS:* uu_list_find() leaves error unset when successfully
returning NULL
*DESCRIPTION:*
If uu_list_find() is called on a list which doesn't have a comparison
function, then it sets the uu_error() to UU_ERROR_NOT_SUPPORTED and
returns NULL. NULL is also the return value for when uu_list_find()
completes successfully, but didn't find anything. If the uu_error()
happened to be UU_ERROR_NOT_SUPPORTED before uu_list_find() was
called, then there's no way for the caller to know whether the function
completed successfully.
*CATEGORY:* library
* SUBCATEGORY:* libuutil
*DIFF'S OUTPUT** :*
*
--- uu_list.c.orig Tue Oct 2 19:44:01 2007
+++ uu_list.c Sat Jan 12 13:16:31 2008
@@ -316,7 +316,7 @@
int sorted = lp-ul_sorted;
uu_compare_fn_t *func = lp-ul_pool-ulp_cmp;
uu_list_node_impl_t *np;
-
+ uu_set_error(UU_ERROR_NONE);
if (func == NULL) {
if (out != NULL)
*out = 0;
*
Looking forward to hear from you
* Thanking you sir*
* Krishnakumar D.*
___
request-sponsor mailing list
request-sponsor at opensolaris.org
[request-sponsor] Bug Details
Rohan, I'll sponsor you for this bug. Let's take further communication off the list. Antonello Rohan S wrote: Respected sir, Me and my team mate Jayahari would like to work on this bug. The bug details are provided below My SCA Number is OS0209 *Bug ID* 6208682 *Synopsis* -ri_utmpx_prefix check could go wrong Thank you S.Rohan Jayahari K.R ___ request-sponsor mailing list request-sponsor at opensolaris.org
[request-sponsor] Shooting my mouth off
Avinash, Have a look at usr/src/tools/README.tools After building the tools, go the the top of your workspace (I don't think it will work on cr.opensolaris.org/~avinashj you'll have to do it locally) and run 'ws' to set the environment. Then run wx webrev. However, for it to work, you'll have to properly checkout the files you want to edit with wx edit files to edit You can ask me further questions off the list if you need so. Antonello Avinash Joshi wrote: But how do we do a webrev? I got the workspace at cr.opensolaris.org/~avinashj Thanks regards, Avinash Joshi On 1/31/08, Frank.Hofmann at sun.com Frank.Hofmann at sun.com wrote: On Thu, 31 Jan 2008, Antonello Cruz wrote: James Carlson wrote: Seeing those submitters go to the relevant community or project mailing list with a proposed patch (or better yet a pointer to a webrev) would be greatly preferred, and if we can gently guide them there when they mistakenly post changes here, that'd be good. Quick question: Do the contributors have access to the tools to generate webrevs? If you've got a full opensolaris source tree, you'll find it in: usr/src/tools/scripts/webrev.sh FrankH. ___ request-sponsor mailing list request-sponsor at opensolaris.org
[request-sponsor] Bug: 6280513
Avinash, I'll sponsor you for this bug. Let's take further discussion out of the list. Antonello Avinash Joshi wrote: Can someone please help me out with this bug?? I got the souce making the function call scf_instance_add_pg at: usr/src/cmd/init/init.c: line 3379 and also the function definition of scf_instance_add_pg at usr/src/lib/libscf/common/lowlevel.c: line 2695 This returns a value(probably an error value) using the function call ( datael_add_pg ) whose definition is at: usr/src/lib/libscf/common/lowlevel.c: line 1907 I was trying to link 'em all but was not able to figure out how the process in the init.c goes :( PS: I am still awaiting a sponsor for this bug Thanks Regards, Avinash Joshi This message posted from opensolaris.org ___ request-sponsor mailing list request-sponsor at opensolaris.org
[request-sponsor] patch for 6586072
Ashwin, I'll sponsor you for this bug. Further discussion on this should be offlist. Antonello ashwin wrote: HI I have the patch for bug id 6586072. Requesting sponsor for the same. My SCA Number is OS0144 Synopsis :- uu_warn_internal should be more precise in its newline detection Category:Subcategory :- library:libuutil change to be made in file - onnv/onnv-gate/usr/src/lib/libuutil/common/uu_pname.c link to the bug - http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=6586072 description uu_warn_internal, used by the various forms of uu_warn and uu_die, checks to see if it should append the error text in the following manner: 96 if (strrchr(format, '\n') == NULL) 97 (void) fprintf(stderr, ERRNO_FMT, strerror(err)); This, unfortunately, will cause the error text to be suppressed if text follows the last newline in the supplied message. We should instead check that the newline is at the end of the string. Have attached the diff and the modified file uu_pname.c Thank you ___ request-sponsor mailing list request-sponsor at opensolaris.org
[request-sponsor] patch for Bug 6613302
Ashwin, I'll sponsor you for this bug. Further discussion about it should be offlist. Antonello ashwin wrote: Hi all, Here is the patch for the bug 6613302 Link to the bug is http://bugs.opensolaris.org/view_bug.do?bug_id=6613302 Synopsis:svcadm uses emsg_nomem before it's defined Category : utility:smf Description: emsg_nomem is used before it is defined (v 1.18 of svcadm.c) 2124 scratch_fmri = malloc(max_scf_fmri_sz); 2125 if (scratch_fmri == NULL) 2126 uu_die(emsg_nomem); ... 2146 emsg_nomem = gettext(Out of memory.\n); if the test on line 2125 fail, the user will get a segmentation fault instead of the proper error message. Action to be taken : define emsg_nomem before uu_die uses it. Changes to be made in the file: onnv/onnv-gate/usr/src/cmd/svc/svcadm/svcadm.c My SCA Number is OS0144 Have attached the diff I request a sponsor for integrating this patch Thank you all ___ request-sponsor mailing list request-sponsor at opensolaris.org
