Re: Subversion post-commit not working
From the same directory, what does svn status say? The post-review script uses the same pathing concept as the svn command. Have to be in an active work space (which the response implies you aren't) and be in or above the location with active changes. On Jul 21, 2011 1:57 PM, David davidkazuh...@gmail.com wrote: I'm trying to get post-review to create a review for me from Subversion's post-commit script. However, no matter what options I pass, post-review tries svn info and obviously fails to detect a repository. I'm doing it from the server so there isn't any working copy on the server. For example post-review --username=user --password=password --submit-as=submitter - d RBTools 0.3.2 Home = /home/david svn info git rev-parse --git-dir The current directory does not contain a checkout from a supported source code repository. Even passing a diff file has the same result post-review --diff-filename=test.diff -d RBTools 0.3.2 Home = /home/david svn info git rev-parse --git-dir The current directory does not contain a checkout from a supported source code repository. What am I missing? I'm running from Ubuntu 10.04 -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Added Files not being added to reviews
Hi, After upgrading to 1.6 RC1 and RBTools 0.3, I noticed that added files are not included in review requests by post-review. If I call post-review specifying the added-file filename, I get There don't seem to be any diffs!. Is this intentional? While I'm at it, a feature request: the ability to configure an ignore list for post-review. Right now I have some files that get changed locally automatically but are not commited. Right now I have to manually revert them before calling post-review, or post-review a specific file/folder without them. -- Leonel -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Installing PyLucene on Redhat
On Fri, 2011-07-15 at 11:30 -0700, Billy Visto wrote: When installing PyLucene on Redhat, after installing the jcc, you must modify the makefile to suit your needs. There is a chunk of code commented out that you have to un-comment a section for your os's environment. When you un-comment out the section closest to your os version, you need to also change the JCC variable to the python command given earlier in the document for your version of python. Could you write up your complete steps to getting PyLucene installed and working on Red Hat? I'd like to turn those steps into a tool to include with my EPEL packages. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Added Files not being added to reviews
Hi Leonel, What sort of repository are you using this with? We generally call out to svn diff, git diff, etc., so it's dependent on how the particular SCM works. Can you file the feature request on the bug tracker? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, Jul 25, 2011 at 7:42 AM, Leonel Togniolli tognio...@gmail.comwrote: Hi, After upgrading to 1.6 RC1 and RBTools 0.3, I noticed that added files are not included in review requests by post-review. If I call post-review specifying the added-file filename, I get There don't seem to be any diffs!. Is this intentional? While I'm at it, a feature request: the ability to configure an ignore list for post-review. Right now I have some files that get changed locally automatically but are not commited. Right now I have to manually revert them before calling post-review, or post-review a specific file/folder without them. -- Leonel -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Added Files not being added to reviews
Issue 2188 logged for the feature request. Sorry, meant to include the info but forgot. It's on SVN. The file shows as added the TortoiseSVN's check for modifications dialog. post-review -d didn't seem to show anything interesting. On Mon, Jul 25, 2011 at 2:21 PM, Christian Hammond chip...@chipx86.com wrote: Hi Leonel, What sort of repository are you using this with? We generally call out to svn diff, git diff, etc., so it's dependent on how the particular SCM works. Can you file the feature request on the bug tracker? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, Jul 25, 2011 at 7:42 AM, Leonel Togniolli tognio...@gmail.com wrote: Hi, After upgrading to 1.6 RC1 and RBTools 0.3, I noticed that added files are not included in review requests by post-review. If I call post-review specifying the added-file filename, I get There don't seem to be any diffs!. Is this intentional? While I'm at it, a feature request: the ability to configure an ignore list for post-review. Right now I have some files that get changed locally automatically but are not commited. Right now I have to manually revert them before calling post-review, or post-review a specific file/folder without them. -- Leonel -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Internal Server Error: /admin/feed/news/
I ended up logging Issue 2189 for the unhandled error and Issue 2190
for the feature request.
On Thu, Jul 21, 2011 at 12:41 PM, Leonel Togniolli tognio...@gmail.com wrote:
Sure. Should I log a request for proxy support or a bug for the error I get?
I don't care that much for getting the news loaded, but I'd prefer if
it would handle a problem fetching them more gracefully.
On Wed, Jul 20, 2011 at 8:25 PM, Christian Hammond chip...@chipx86.com
wrote:
Hi Leonel,
This is a known issue. While it won't make 1.6.0, I'd like to get
proxy support in for 1.6.x. I'm not sure we have a bug filed for it,
though. Would you mind filing one?
Christian
On Wednesday, July 20, 2011, Leonel Togniolli tognio...@gmail.com wrote:
Hi !
I'm in the process of upgrading my 1.5.1 install to 1.6 RC1. First
thing I noticed is that when visiting the admin interface the news in
do not load and I get the error below in the mail. There's a proxy
server with authentication so ReviewBoard won't be able to get online
to retrieve news anyway.
Traceback (most recent call last):
File
c:\python25\lib\site-packages\django-1.3-py2.5.egg\django\core\handlers\base.py,
line 111, in get_response
response = callback(request, *callback_args, **callback_kwargs)
File
c:\python25\lib\site-packages\Djblets-0.6.8-py2.5.egg\djblets\feedview\views.py,
line 38, in view_feed
force_overwrite=request.GET.has_key(reload)))
File
c:\python25\lib\site-packages\Djblets-0.6.8-py2.5.egg\djblets\util\misc.py,
line 173, in cache_memoize
data = lookup_callable()
File
c:\python25\lib\site-packages\Djblets-0.6.8-py2.5.egg\djblets\feedview\views.py,
line 23, in fetch_feed
data = urllib2.urlopen(url).read()
File C:\Python25\lib\urllib2.py, line 124, in urlopen
return _opener.open(url, data)
File C:\Python25\lib\urllib2.py, line 381, in open
response = self._open(req, data)
File C:\Python25\lib\urllib2.py, line 399, in _open
'_open', req)
File C:\Python25\lib\urllib2.py, line 360, in _call_chain
result = func(*args)
File C:\Python25\lib\urllib2.py, line 1107, in http_open
return self.do_open(httplib.HTTPConnection, req)
File C:\Python25\lib\urllib2.py, line 1080, in do_open
r = h.getresponse()
File C:\Python25\lib\httplib.py, line 928, in getresponse
response.begin()
File C:\Python25\lib\httplib.py, line 385, in begin
version, status, reason = self._read_status()
File C:\Python25\lib\httplib.py, line 349, in _read_status
raise BadStatusLine(line)
BadStatusLine
ModPythonRequest
path:/admin/feed/news/,
GET:QueryDict: {},
POST:QueryDict: {},
COOKIES:{'JSESSIONID': 'c89210830acfce364e3bd8bb55c921c2',
'rbsessionid': '808f6ddd7ecd1710a507fcfe05c29688',
'screenResolution': '1366x768'},
META:{'AUTH_TYPE': None,
'CONTENT_LENGTH': 0,
'CONTENT_TYPE': None,
'GATEWAY_INTERFACE': 'CGI/1.1',
'HTTP_ACCEPT': 'text/html, */*',
'HTTP_ACCEPT_CHARSET': 'ISO-8859-1,utf-8;q=0.7,*;q=0.3',
'HTTP_ACCEPT_ENCODING': 'gzip,deflate,sdch',
'HTTP_ACCEPT_LANGUAGE': 'en-US,en;q=0.8,pt-BR;q=0.6,pt;q=0.4',
'HTTP_CONNECTION': 'keep-alive',
'HTTP_COOKIE': 'JSESSIONID=c89210830acfce364e3bd8bb55c921c2;
screenResolution=1366x768;
rbsessionid=808f6ddd7ecd1710a507fcfe05c29688',
'HTTP_HOST': 'xxxbuild',
'HTTP_REFERER': 'http://xxxbuild/admin/',
'HTTP_USER_AGENT': 'Mozilla/5.0 (Windows NT 6.1; WOW64)
AppleWebKit/534.30 (KHTML, like Gecko) Chrome/12.0.742.122
Safari/534.30',
'HTTP_X_FCCKV2': 'g2HP6vytWCGacqhIqnHAyiobwZw4nPryglP/jQ==',
'HTTP_X_REQUESTED_WITH': 'XMLHttpRequest',
'PATH_INFO': u'/admin/feed/news/',
'PATH_TRANSLATED': None,
'QUERY_STRING': None,
'REMOTE_ADDR': '172.16.44.61',
'REMOTE_HOST': None,
'REMOTE_IDENT': None,
'REMOTE_USER': None,
'REQUEST_METHOD': 'GET',
'SCRIPT_NAME': '',
'SERVER_NAME': 'xxx2-xxx',
'SERVER_PORT': 80,
'SERVER_PROTOCOL': 'HTTP/1.1',
'SERVER_SOFTWARE': 'mod_python'}
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know
Re: Error when SVN server is unreachable.
Issue 2191 for this one. On Thu, Jul 21, 2011 at 12:39 PM, Leonel Togniolli tognio...@gmail.com wrote: Hi, When trying to access a diff of an existing review request, while the SVN server is for some reason unavailable (and the diff is not cached), I get the error below. It seems to me there's a bug in the error handling. 1.6.1 RC1 global name 'ClientError' is not defined Traceback (most recent call last): File c:\python25\lib\site-packages\ReviewBoard-1.6rc1-py2.5.egg\reviewboard\diffviewer\views.py, line 151, in view_diff interdiffset, highlighting, True) File c:\python25\lib\site-packages\ReviewBoard-1.6rc1-py2.5.egg\reviewboard\diffviewer\diffutils.py, line 1071, in get_diff_files large_data=True) File c:\python25\lib\site-packages\Djblets-0.6.8-py2.5.egg\djblets\util\misc.py, line 166, in cache_memoize data = lookup_callable() File c:\python25\lib\site-packages\ReviewBoard-1.6rc1-py2.5.egg\reviewboard\diffviewer\diffutils.py, line 1070, in lambda enable_syntax_highlighting)), File c:\python25\lib\site-packages\ReviewBoard-1.6rc1-py2.5.egg\reviewboard\diffviewer\diffutils.py, line 551, in get_chunks old = get_original_file(filediff) File c:\python25\lib\site-packages\ReviewBoard-1.6rc1-py2.5.egg\reviewboard\diffviewer\diffutils.py, line 364, in get_original_file large_data=True)[0] File c:\python25\lib\site-packages\Djblets-0.6.8-py2.5.egg\djblets\util\misc.py, line 166, in cache_memoize data = lookup_callable() File c:\python25\lib\site-packages\ReviewBoard-1.6rc1-py2.5.egg\reviewboard\diffviewer\diffutils.py, line 363, in lambda data = cache_memoize(key, lambda: [fetch_file(file, revision)], File c:\python25\lib\site-packages\ReviewBoard-1.6rc1-py2.5.egg\reviewboard\diffviewer\diffutils.py, line 342, in fetch_file data = tool.get_file(file, revision) File c:\python25\lib\site-packages\ReviewBoard-1.6rc1-py2.5.egg\reviewboard\scmtools\svn.py, line 135, in get_file except ClientError, e: NameError: global name 'ClientError' is not defined -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Perforce proxy servers
Yes, thanks David and Christian for the tips on configuration that enabled us to finally track down the mis-configuration. The final, working configuration has the 'p4 info' name in the repository Path and the proxy in the Mirror Path. We still have somewhat of an issue with proxies, however. When the server to which the proxy directs clients changes, Review Board stops working until we manually update the configuration with the new value from 'p4 info'. For example, we had things working at the end of last week, but a weekend fail-over of the Perforce server changed the result of 'p4 info' and everything stopped working again. -Chris On Jul 22, 9:47 am, SCFrench sc...@mathworks.com wrote: I've been working with Chris on this issue. We seem to have it working now. There appears to have been two issues that were combining to make this harder than usual to fix. First, the diagnostics on the call to p4 in get_file in perforce.py are relying on the exit status to indicate that something went wrong. However, as I found here:http://forums.perforce.com/index.php?/topic/682-noob-question-changel..., the exit status of p4 is almost always 0. When I finally figured out what p4 command was being run by get_file, and ran it manually, I got this failure (edited slightly to remove private information): % p4 -p perforce-xx-xxx.mathworks.com:1666 -u cnxx print -q '//xxx/ xxx/queue/matlab/src/m_interpreter/mi_interpreter/clear.cpp#17' //xxx/xxx/queue/matlab/src/m_interpreter/mi_interpreter/clear.cpp#17 - no permission for operation on file(s). % echo $? 0 The link above discusses some ways to improve error checking on scripted p4 invocations, by using the -s option. Not sure if that will work for Review Board, but I thought I'd pass it along. The second issue was that once the file clear.cpp had been incorrectly retrieved, the bad (empty) version got cached, and subsequent attempts to fix the problem by changing the name of the repository at the admin site apparently were effective no-ops because that information is ignored if the file is already cached locally. Restarting memcached cleared the cache and allowed us to make progress on the first issue. Hope this information helps to make Review Board even better! Scott On Jul 20, 1:57 pm, Christian Hammond chip...@chipx86.com wrote: Hi Chris, The Path field should probably point to the proxy, and Mirror Path should point to 'p4 info'. It's a bit confusing (the Mirror Path name exists for legacy reasons) and I want to clean that up, but start with that. Basically, we'll always communicate through Path, but we check both Path and Mirror Path when using post-review. We can't log the commands because, with the exception of one case, we're not calling out to p4. We're instead using the Python bindings for the library that is talking directly to the server. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Wed, Jul 20, 2011 at 8:29 AM, chrisn ch...@newbold.org wrote: I just filedhttp://code.google.com/p/reviewboard/issues/detail?id=2182 to describe an issue with ReviewBoard and Perforce proxy servers that is effectively blocking us from using ReviewBoard. I'd appreciate any thoughts or BTDT advice about how I might be able to work around the problem. Thanks. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Installing PyLucene on Redhat
On Mon, Jul 25, 2011 at 8:33 AM, Stephen Gallagher step...@gallagherhome.com wrote: Could you write up your complete steps to getting PyLucene installed and working on Red Hat? I'd like to turn those steps into a tool to include with my EPEL packages. I don't have steps, but I have packages. RPMs are on S3: http://shrub.appspot.com/files.antoncohen.com/software/pylucene/ PyLucene is the only package required by Review Board. But to build PyLucene from source (e.g., rpmbuild --rebuild) you need JCC, and to build JCC you need to patch python-setuptools. The setuptools patch comes from their bug tacker [1], modified to patch against the EL6 version. I based the spec files on ones created by Felix Schwarz [2]. The SRPMs build with rpmbuild, though I haven't tried from in mock. Tested on Scientific Linux 6 with Review Board 1.5.5 from EPEL. If you are going to build these packages I recommend building on a throw-away dev machine (or in a chroot), and only installing the PyLucene package in production, that way you don't have a weird patched setuptools in production. [1] http://bugs.python.org/setuptools/issue43 [2] http://www.schwarz.eu/opensource/rpm/ Thanks, Anton -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Added Files not being added to reviews
Try running svn add on those files and making sure it knows about them. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, Jul 25, 2011 at 11:06 AM, Leonel Togniolli tognio...@gmail.comwrote: Issue 2188 logged for the feature request. Sorry, meant to include the info but forgot. It's on SVN. The file shows as added the TortoiseSVN's check for modifications dialog. post-review -d didn't seem to show anything interesting. On Mon, Jul 25, 2011 at 2:21 PM, Christian Hammond chip...@chipx86.com wrote: Hi Leonel, What sort of repository are you using this with? We generally call out to svn diff, git diff, etc., so it's dependent on how the particular SCM works. Can you file the feature request on the bug tracker? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, Jul 25, 2011 at 7:42 AM, Leonel Togniolli tognio...@gmail.com wrote: Hi, After upgrading to 1.6 RC1 and RBTools 0.3, I noticed that added files are not included in review requests by post-review. If I call post-review specifying the added-file filename, I get There don't seem to be any diffs!. Is this intentional? While I'm at it, a feature request: the ability to configure an ignore list for post-review. Right now I have some files that get changed locally automatically but are not commited. Right now I have to manually revert them before calling post-review, or post-review a specific file/folder without them. -- Leonel -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Perforce proxy servers
Hi Chris, You may have said this already and I may have missed it, but is the core problem with the various proxy names that post-review's unable to find the correct repository to patch? If so, you can reference repositories by name instead of by path: http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/#repository Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, Jul 25, 2011 at 12:00 PM, chrisn ch...@newbold.org wrote: Yes, thanks David and Christian for the tips on configuration that enabled us to finally track down the mis-configuration. The final, working configuration has the 'p4 info' name in the repository Path and the proxy in the Mirror Path. We still have somewhat of an issue with proxies, however. When the server to which the proxy directs clients changes, Review Board stops working until we manually update the configuration with the new value from 'p4 info'. For example, we had things working at the end of last week, but a weekend fail-over of the Perforce server changed the result of 'p4 info' and everything stopped working again. -Chris On Jul 22, 9:47 am, SCFrench sc...@mathworks.com wrote: I've been working with Chris on this issue. We seem to have it working now. There appears to have been two issues that were combining to make this harder than usual to fix. First, the diagnostics on the call to p4 in get_file in perforce.py are relying on the exit status to indicate that something went wrong. However, as I found here: http://forums.perforce.com/index.php?/topic/682-noob-question-changel..., the exit status of p4 is almost always 0. When I finally figured out what p4 command was being run by get_file, and ran it manually, I got this failure (edited slightly to remove private information): % p4 -p perforce-xx-xxx.mathworks.com:1666 -u cnxx print -q '//xxx/ xxx/queue/matlab/src/m_interpreter/mi_interpreter/clear.cpp#17' //xxx/xxx/queue/matlab/src/m_interpreter/mi_interpreter/clear.cpp#17 - no permission for operation on file(s). % echo $? 0 The link above discusses some ways to improve error checking on scripted p4 invocations, by using the -s option. Not sure if that will work for Review Board, but I thought I'd pass it along. The second issue was that once the file clear.cpp had been incorrectly retrieved, the bad (empty) version got cached, and subsequent attempts to fix the problem by changing the name of the repository at the admin site apparently were effective no-ops because that information is ignored if the file is already cached locally. Restarting memcached cleared the cache and allowed us to make progress on the first issue. Hope this information helps to make Review Board even better! Scott On Jul 20, 1:57 pm, Christian Hammond chip...@chipx86.com wrote: Hi Chris, The Path field should probably point to the proxy, and Mirror Path should point to 'p4 info'. It's a bit confusing (the Mirror Path name exists for legacy reasons) and I want to clean that up, but start with that. Basically, we'll always communicate through Path, but we check both Path and Mirror Path when using post-review. We can't log the commands because, with the exception of one case, we're not calling out to p4. We're instead using the Python bindings for the library that is talking directly to the server. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Wed, Jul 20, 2011 at 8:29 AM, chrisn ch...@newbold.org wrote: I just filedhttp:// code.google.com/p/reviewboard/issues/detail?id=2182 to describe an issue with ReviewBoard and Perforce proxy servers that is effectively blocking us from using ReviewBoard. I'd appreciate any thoughts or BTDT advice about how I might be able to work around the problem. Thanks. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at
Issue 2191 in reviewboard: Error when SVN server is unreachable
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 2191 by ltognio...@ciandt.com: Error when SVN server is unreachable http://code.google.com/p/reviewboard/issues/detail?id=2191 * NOTE: Do not post confidential information in this bug report. * * If you need immediate support, please contact* * reviewbo...@googlegroups.com * What version are you running? 1.6 RC1. What's the URL of the page containing the problem? /r/1/diff What steps will reproduce the problem? 1. Create a review request. don't load it. 2. Take SVN server offline 3. Load review request and look at diffs in the browser. What is the expected output? What do you see instead? exp: proper error handling act: error on error handler: global name 'ClientError' is not defined What operating system are you using? What browser? Server 2003, Chrome (latest) Please provide any additional information below. global name 'ClientError' is not defined Traceback (most recent call last): File c:\python25\lib\site-packages\ReviewBoard-1.6rc1-py2.5.egg\reviewboard\diffviewer\views.py, line 151, in view_diff interdiffset, highlighting, True) File c:\python25\lib\site-packages\ReviewBoard-1.6rc1-py2.5.egg\reviewboard\diffviewer\diffutils.py, line 1071, in get_diff_files large_data=True) File c:\python25\lib\site-packages\Djblets-0.6.8-py2.5.egg\djblets\util\misc.py, line 166, in cache_memoize data = lookup_callable() File c:\python25\lib\site-packages\ReviewBoard-1.6rc1-py2.5.egg\reviewboard\diffviewer\diffutils.py, line 1070, in lambda enable_syntax_highlighting)), File c:\python25\lib\site-packages\ReviewBoard-1.6rc1-py2.5.egg\reviewboard\diffviewer\diffutils.py, line 551, in get_chunks old = get_original_file(filediff) File c:\python25\lib\site-packages\ReviewBoard-1.6rc1-py2.5.egg\reviewboard\diffviewer\diffutils.py, line 364, in get_original_file large_data=True)[0] File c:\python25\lib\site-packages\Djblets-0.6.8-py2.5.egg\djblets\util\misc.py, line 166, in cache_memoize data = lookup_callable() File c:\python25\lib\site-packages\ReviewBoard-1.6rc1-py2.5.egg\reviewboard\diffviewer\diffutils.py, line 363, in lambda data = cache_memoize(key, lambda: [fetch_file(file, revision)], File c:\python25\lib\site-packages\ReviewBoard-1.6rc1-py2.5.egg\reviewboard\diffviewer\diffutils.py, line 342, in fetch_file data = tool.get_file(file, revision) File c:\python25\lib\site-packages\ReviewBoard-1.6rc1-py2.5.egg\reviewboard\scmtools\svn.py, line 135, in get_file except ClientError, e: NameError: global name 'ClientError' is not defined -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2182 in reviewboard: ReviewBoard cannot cope with Perforce proxies
Comment #1 on issue 2182 by ch...@newbold.org: ReviewBoard cannot cope with Perforce proxies http://code.google.com/p/reviewboard/issues/detail?id=2182 It turns out that ReviewBoard does support Perforce environments with proxies, though configuration is somewhat obscure. We now have this (sort of) working in our environment. One remaining issue is that the configuration is not robust to changes in the name of the actual Perforce server on the far side of the proxy. This occurs, for example, when there is a fail-over from one server to another. See further discussion here: http://groups.google.com/group/reviewboard/browse_thread/thread/87c39f8c7e05066e -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2186 in reviewboard: Upgrading site on 1.6 RC2 gives evolution errors
Comment #3 on issue 2186 by chip...@gmail.com: Upgrading site on 1.6 RC2 gives evolution errors http://code.google.com/p/reviewboard/issues/detail?id=2186 Okay, can you also provide the following: 1) A dump of the database schema (use mysqldump -d) 2) A screenshot of your Django Evolution Versions and Evolutions entry listings in the admin UI - Database. 3) Verify you're running the newest Django by doing the following from the console: $ python import django print django.VERSION And showing what that says. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 2192 in reviewboard: Duplicate posts when clicking [Add comment]
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 2192 by yuzi...@gmail.com: Duplicate posts when clicking [Add comment] http://code.google.com/p/reviewboard/issues/detail?id=2192 * NOTE: Do not post confidential information in this bug report. * * If you need immediate support, please contact* * reviewbo...@googlegroups.com * What version are you running? Reviewboard 1.6 RC2 What's the URL of the page containing the problem? http://path.to.reviewboard/r/number/ What steps will reproduce the problem? (Screenshots attached, follow along) [0001.png] Visit your review URL (e.g. http://path.to.reviewboard/r/number/) [0002.png] Click Add comment and type a comment [0003.png] Click [OK] or press Ctrl+Enter [0004.png] Double-click your newly created comment OR click the pencil icon [0005.png] Edit your comment to something else [0006.png] Click [OK] or press Ctrl+Enter [0007.png] At this point, your original comment should be gone, having been replaced by your new comment. [0008.png] Click [Publish] What is the expected output? What do you see instead? At this point, only your NEW comment should be posted. There should be no trace of the old comment. However... [0009.png] Notice that the e-mail from reviewboard illustrates that BOTH comments were in fact posted, and in opposite order to each other. This suggests some sort of copy-on-write behavior where atomicity should have been otherwise violated... [0010.png] Refreshing the reviewboard webpage shows the same thing. Both comments are now visible, even though we really only intended to make one. What operating system are you using? What browser? Verified on the following browsers: chrome 12.0.742.124 Firefox 5.0 Opera 11.50 Build 1074 Verified on the following operating systems: Windows 7 Ubuntu Linux Please provide any additional information below. Attachments: 0001.png 64.4 KB 0002.png 60.3 KB 0003.png 60.7 KB 0004.png 63.7 KB 0005.png 61.0 KB 0006.png 60.9 KB 0007.png 64.1 KB 0008.png 64.5 KB 0009.png 103 KB 0010.png 62.8 KB -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 2193 in reviewboard: Changes between revisions does not handle deleted files correctly
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 2193 by aa...@odiago.com: Changes between revisions does not handle deleted files correctly http://code.google.com/p/reviewboard/issues/detail?id=2193 * NOTE: Do not post confidential information in this bug report. * * If you need immediate support, please contact* * reviewbo...@googlegroups.com * What version are you running? 1.5.4 What's the URL of the page containing the problem? https://review.odiago.com/reviewboard/r/127/diff/1-2/#index_header What steps will reproduce the problem? 1. Using git, create a patch that adds new files Foo and Bar. This is diff r1. 2. Remove file Foo (git rm Foo) and recommit. Upload the new patch (containing only Bar) as diff r2. 3. View diff between r2 and r1. Foo still shows up as a new file being added. It should actually be all highlighted in red as removed in this version. What is the expected output? What do you see instead? What operating system are you using? What browser? Please provide any additional information below. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
