Re: Diff creation problem occuring while creating review request

2014-07-18 Thread David Trowbridge 
It's very hard to tell what should be in there because the file just looks
like garbage characters.

Can you confirm:
- You're letting 'rbt post' create your diff (and not using --diff-filename)
- That revision 5 has been committed to the repository, and your local
checkout has that revision.
- That if you run 'svn diff' in your checkout, what you get looks the same
as the file hello.txt.diff that you attached.

-David


On Fri, Jul 18, 2014 at 12:19 PM, Shahadat Hossain 
wrote:

> David i attached the files.
>
> Thanks
>
>
> On Friday, July 18, 2014 10:21:50 AM UTC+6, Shahadat Hossain wrote:
>>
>>
>> When i get to /tmp directory tmp/reviewboard.zsgPUK/ i get 4 files which
>> i already attach in the attachment. It seems the content of the diff file
>> is what i expected. But i can't understand why this issue is happening in
>> reviewboard view diff button. still having the same issue.
>>
>> Diff currently unavailable.  *Error:* The patch to '/hello.txt' didn't
>> apply cleanly. The temporary files have been left in
>> '/tmp/reviewboard.VeF_ND' for debugging purposes. `patch` returned:
>> patching file /tmp/reviewboard.VeF_ND/tmp8L1ETn Hunk #1 FAILED at 1. 1
>> out of 1 hunk FAILED -- saving rejects to file 
>> /tmp/reviewboard.VeF_ND/tmp8L1ETn-new.rej
>>   Details 
>>
>> Traceback (most recent call last):
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.26-py2.7.egg/reviewboard/diffviewer/views.py",
>>  line 251, in view_diff_fragment
>> diff_file = get_requested_diff_file()
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.26-py2.7.egg/reviewboard/diffviewer/views.py",
>>  line 171, in get_requested_diff_file
>> populate_diff_chunks(files, highlighting, request=request)
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.26-py2.7.egg/reviewboard/diffviewer/diffutils.py",
>>  line 344, in populate_diff_chunks
>> chunks = generator.get_chunks()
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.26-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
>>  line 137, in get_chunks
>> large_data=True)
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/Djblets-0.7.30-py2.7.egg/djblets/util/misc.py",
>>  line 157, in cache_memoize
>> data = lookup_callable()
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.26-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
>>  line 136, in 
>> lambda: list(self._get_chunks_uncached()),
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.26-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
>>  line 142, in _get_chunks_uncached
>> new = get_patched_file(old, self.filediff, self.request)
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.26-py2.7.egg/reviewboard/diffviewer/diffutils.py",
>>  line 152, in get_patched_file
>> return patch(diff, buffer, filediff.dest_file, request)
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.26-py2.7.egg/reviewboard/diffviewer/diffutils.py",
>>  line 96, in patch
>> (filename, tempdir, patch_output))
>> Exception: The patch to '/hello.txt' didn't apply cleanly. The temporary 
>> files have been left in '/tmp/reviewboard.VeF_ND' for debugging purposes.
>> `patch` returned: patching file /tmp/reviewboard.VeF_ND/tmp8L1ETn
>> Hunk #1 FAILED at 1.
>> 1 out of 1 hunk FAILED -- saving rejects to file 
>> /tmp/reviewboard.VeF_ND/tmp8L1ETn-new.rej
>>
>>
>>
>> Thanks & Regards
>> Shahadat
>>
>>
>> On Friday, July 18, 2014 9:55:18 AM UTC+6, David Trowbridge wrote:
>>>
>>> Can you check the contents of the tmp file and the patch file and verify
>>> that they're what you expect?
>>>
>>> -David
>>>
>>>
>>> On Thu, Jul 17, 2014 at 8:36 PM, Shahadat Hossain 
>>> wrote:
>>>
 Also i am getting the below error in the reviewboard server while i try
 to view the diff from view diff button.


 Diff currently unavailable.  *Error:* The patch to '/hello.txt' didn't
 apply cleanly. The temporary files have been left in
 '/tmp/reviewboard.2r0DmL' for debugging purposes. `patch` returned:
 patching file /tmp/reviewboard.2r0DmL/tmp8IOq8N Hunk #1 FAILED at 1. 1
 out of 1 hunk FAILED -- saving rejects to file 
 /tmp/reviewboard.2r0DmL/tmp8IOq8N-new.rej
   Details 

 Traceback (most recent call last):
   File 
 "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.26-py2.7.egg/reviewboard/diffviewer/views.py",
  line 251, in view_diff_fragment
 diff_file = get_requested_diff_file()
   File 
 "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.26-py2.7.egg/reviewboard/diffviewer/views.py",
  line 171, in get_requested_diff_file
 populate_diff_chunks(files, highlighting, request=request)
   File 
 "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.26-py2.7.egg/reviewboard/diffviewer/diffutils.py",

Re: Authentication failed while adding svn repository

2014-07-18 Thread Alexis 
David,

Thanks for the response. All I am saying is that at that point of the code, 
it fails with authentication error not when it checks for the repository. I 
added log messages at the points where it checks for repository and it 
passes. It's at creation time that it fails not when it checks for the 
repository. After I comment out the exception so it can pass the creation 
without authentication, it passes the repository checking and the creation 
of a new repository. So there is one point where it tries to access the 
repository without authentication.

Maybe the error comes from from form.py, clean(self), 
self._verify_repository_path(), scmtool_class.check_repository(path, 
username, password,self.local_site_name)?

What can I do to debug this? Do you want me to put some logging printouts 
at any point of the code? I am obviously running at this point but with a 
monumental hack of commenting out error handling (exceptions).

Alexis

On Friday, 18 July 2014 15:51:55 UTC-5, David Trowbridge wrote:
>
> It's expected that username and password would be None in the particular 
> stack trace you included (since at that point it's just creating it to 
> check that it can). The actual repository checking is a different code path 
> that does include credentials.
>
> -David
>
> On Jul 16, 2014, at 12:11 PM, Alexis > 
> wrote:
>
> Hi Christian,
>
> I am encountering the same issue. it seems that before accessing the 
> repository, review board checks that it exists by trying to access it 
> without credentials (assumes there is public access to read) and then it 
> accesses it using the credentials. I have made the code fail where the 
> error occurs to get a traceback:
> 2014-07-15 15:31:52,529 - ERROR -  - SVN: Failed to get repository 
> information for https://example.com:81/svn/Test: callback_get_login 
> required
> 2014-07-15 15:50:25,674 - ERROR -  - Exception thrown for user admin at 
> http://example.com:8181/reviewboard/admin/db/scmtools/repository/add/
>
> unexpected indent (pysvn.py, line 39)
> Traceback (most recent call last):
>   File 
> "C:\BitNami\reviewboard-2.0.2-0\apps\django\django\core\handlers\base.py", 
> line 112, in get_response
> response = wrapped_callback(request, *callback_args, **callback_kwargs)
>   File 
> "C:\BitNami\reviewboard-2.0.2-0\apps\django\django\contrib\admin\options.py", 
> line 432, in wrapper
> return self.admin_site.admin_view(view)(*args, **kwargs)
>   File 
> "C:\BitNami\reviewboard-2.0.2-0\apps\django\django\utils\decorators.py", 
> line 99, in _wrapped_view
> response = view_func(request, *args, **kwargs)
>   File 
> "C:\BitNami\reviewboard-2.0.2-0\apps\django\django\views\decorators\cache.py",
>  
> line 52, in _wrapped_view_func
> response = view_func(request, *args, **kwargs)
>   File 
> "C:\BitNami\reviewboard-2.0.2-0\apps\django\django\contrib\admin\sites.py", 
> line 198, in inner
> return view(request, *args, **kwargs)
>   File 
> "C:\BitNami\reviewboard-2.0.2-0\apps\django\django\utils\decorators.py", 
> line 29, in _wrapper
> return bound_func(*args, **kwargs)
>   File 
> "C:\BitNami\reviewboard-2.0.2-0\apps\django\django\utils\decorators.py", 
> line 99, in _wrapped_view
> response = view_func(request, *args, **kwargs)
>   File 
> "C:\BitNami\reviewboard-2.0.2-0\apps\django\django\utils\decorators.py", 
> line 25, in bound_func
> return func(self, *args2, **kwargs2)
>   File 
> "C:\BitNami\reviewboard-2.0.2-0\apps\django\django\db\transaction.py", line 
> 371, in inner
> return func(*args, **kwargs)
>   File 
> "C:\BitNami\reviewboard-2.0.2-0\apps\django\django\contrib\admin\options.py", 
> line 1113, in add_view
> if form.is_valid():
>   File 
> "C:\BitNami\reviewboard-2.0.2-0\apps\reviewboard\Lib\site-packages\ReviewBoard-2.0.2-py2.7.egg\reviewboard\scmtools\forms.py",
>  
> line 1024, in is_valid
> if not super(RepositoryForm, self).is_valid():
>   File "C:\BitNami\reviewboard-2.0.2-0\apps\django\django\forms\forms.py", 
> line 129, in is_valid
> return self.is_bound and not bool(self.errors)
>   File "C:\BitNami\reviewboard-2.0.2-0\apps\django\django\forms\forms.py", 
> line 121, in errors
> self.full_clean()
>   File 
> "C:\BitNami\reviewboard-2.0.2-0\apps\reviewboard\Lib\site-packages\ReviewBoard-2.0.2-py2.7.egg\reviewboard\scmtools\forms.py",
>  
> line 813, in full_clean
> super(RepositoryForm, self).full_clean()
>   File "C:\BitNami\reviewboard-2.0.2-0\apps\django\django\forms\forms.py", 
> line 273, in full_clean
> self._clean_fields()
>   File "C:\BitNami\reviewboard-2.0.2-0\apps\django\django\forms\forms.py", 
> line 291, in _clean_fields
> value = getattr(self, 'clean_%s' % name)()
>   File 
> "C:\BitNami\reviewboard-2.0.2-0\apps\reviewboard\Lib\site-packages\ReviewBoard-2.0.2-py2.7.egg\reviewboard\scmtools\forms.py",
>  
> line 988, in clean_tool
> scmtool_class = tool.get_scmtool_class()
>   File 
> "C:\BitNami\reviewboard-2.0.2-0\apps\reviewboard\Lib\site-packages

Re: Adding a new diff to existent review Loops on loading

2014-07-18 Thread David Trowbridge 
OK, I know what's going wrong. We'll get this fixed for 2.0.4.

-David

> On Jul 17, 2014, at 3:55 PM, MoonWalker  wrote:
> 
> 
> Hi David,
> 
> I attached the snapshot. 
> 
> 
> 
> 
> 
> 
>> On Friday, July 18, 2014 6:49:04 AM UTC+10, David Trowbridge wrote:
>> Can you use the "Network" tab to find the contents of the response (the one 
>> returning HTTP 400)?
>> 
>> -David
>> 
>> 
>>> On Wed, Jul 16, 2014 at 7:44 PM, MoonWalker  wrote:
>>> sorry, this is the full one
>>> 
>>> POST http://codereview.devneta.local/api/review-requests/559/diffs/ 400 
>>> (BAD REQUEST) jquery-1.8.2.min.js:2
>>> sendjquery-1.8.2.min.js:2
>>> p.extend.ajaxjquery-1.8.2.min.js:2
>>> fileUploadXhr3rdparty.min.js:4
>>> $.fn.ajaxSubmit3rdparty.min.js:4
>>> doCallbase.min.js:1
>>> nextjquery.gravy.min.js:1
>>> startjquery.gravy.min.js:1
>>> RB.apiCallbase.min.js:1
>>> Backbone.ajaxbase.min.js:1
>>> a.sync3rdparty.min.js:4
>>> RB.BaseResource.Backbone.Model.extend.syncbase.min.js:1
>>> h.extend.save3rdparty.min.js:3
>>> RB.BaseResource.Backbone.Model.extend._saveObjectbase.min.js:1
>>> ready.readybase.min.js:1
>>> RB.BaseResource.Backbone.Model.extend.readybase.min.js:1
>>> RB.BaseResource.Backbone.Model.extend.ensureCreatedbase.min.js:1
>>> ready.readybase.min.js:1
>>> RB.BaseResource.Backbone.Model.extend.readybase.min.js:1
>>> RB.BaseResource.Backbone.Model.extend.readybase.min.js:1
>>> RB.BaseResource.Backbone.Model.extend.savebase.min.js:1
>>> sendbase.min.js:1
>>> (anonymous function)base.min.js:1
>>> p.event.dispatchjquery-1.8.2.min.js:2
>>> g.handle.hjquery-1.8.2.min.js:2
>>> p.event.triggerjquery-1.8.2.min.js:2
>>> (anonymous function)jquery-1.8.2.min.js:2
>>> p.extend.eachjquery-1.8.2.min.js:2
>>> p.fn.p.eachjquery-1.8.2.min.js:2
>>> p.fn.extend.triggerjquery-1.8.2.min.js:2
>>> p.fn.(anonymous function)jquery-1.8.2.min.js:2
>>> (anonymous function)base.min.js:1
>>> p.event.dispatchjquery-1.8.2.min.js:2
>>> g.handle.hjquery-1.8.2.min.js:2
>>> Uncaught TypeError: Cannot read property 'msg' of undefined base.min.js:1
>>> displayErrorsbase.min.js:1
>>> options.dataStoreObject.save.errorbase.min.js:1
>>> (anonymous function)base.min.js:1
>>> e.error3rdparty.min.js:4
>>> (anonymous function)base.min.js:1
>>> kjquery-1.8.2.min.js:2
>>> l.fireWithjquery-1.8.2.min.js:2
>>> yjquery-1.8.2.min.js:2
>>> d
>>> 
 On Thursday, July 17, 2014 12:42:21 PM UTC+10, MoonWalker wrote:
 I noticed this issue several times, and I enabled all the logs and some 
 how there is zero information on them about this issue. I enabled 
 JavaScript console in my browser (chrome latest version under Windows 7) 
 and this is what  I get.
 
 Uncaught TypeError: Cannot read property 'msg' of undefined base.min.js:1
 displayErrorsbase.min.js:1
 options.dataStoreObject.save.errorbase.min.js:1
 (anonymous function)base.min.js:1
 e.error3rdparty.min.js:4
 (anonymous function)base.min.js:1
 kjquery-1.8.2.min.js:2
 l.fireWithjquery-1.8.2.min.js:2
 yjquery-1.8.2.min.js:2
 d
>>> 
>>> -- 
>>> Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
>>> ---
>>> Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
>>> ---
>>> Happy user? Let us know at http://www.reviewboard.org/users/
>>> --- 
>>> You received this message because you are subscribed to the Google Groups 
>>> "reviewboard" group.
>>> To unsubscribe from this group and stop receiving emails from it, send an 
>>> email to reviewboard...@googlegroups.com.
>>> For more options, visit https://groups.google.com/d/optout.
> 
> -- 
> Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
> ---
> Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
> ---
> Happy user? Let us know at http://www.reviewboard.org/users/
> --- 
> You received this message because you are subscribed to the Google Groups 
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Error when diff files on ReviewBoard site

2014-07-18 Thread David Trowbridge 
Something is going wrong when fetching the file from perforce. Is there 
anything in the review board log?

-David

> On Jul 18, 2014, at 12:24 AM, hoàng tuấn  wrote:
> 
> Dear Mr David,
> 
> I am using Perforce and my patch's version is 2.6.
> I will show you more detail and the content of these file.
> 
> At this time, i make a review request and diff file .cpp file. I added 1 line 
> "#include " to diff. This is a error when i want to view diff.
> 
> 
> After that i check in "/tmp/reviewboard.QVafqB": 
> 
> 
> 
> 
> 
> 
> ---
> 
> And i checked another files. But only "tmp1_IEjZ-new.rej" has contents
> 
> 
> 
> Best Regards,
> 
> Nguyen Tuan Hoang
> 
> 
> 
> 
> 
> Vào 10:54:43 UTC+7 Thứ sáu, ngày 18 tháng bảy năm 2014, David Trowbridge đã 
> viết:
>> 
>> A couple questions:
>> 
>> - Can you check the contents of the "new   2.txt.diff" file and see if it's 
>> what you expect?
>> - Can you check the contents of the "tmpeeeSkZ" file and see if it's what 
>> you expect?
>> - What revision control system?
>> - What version of GNU patch?
>> 
>> -David
>> 
>> 
>>> On Thu, Jun 26, 2014 at 2:56 AM, hoàng tuấn  wrote:
> After reinstall, I make a new request  i face the same problem
>>> Exception: The patch to '//depot/P4Test/new  2.txt' didn't apply cleanly. 
>>> The temporary files have been left in '/tmp/reviewboard.GPEAUp' for 
>>> debugging purposes.
>>> `patch` returned: patch:  Only garbage was found in the patch input.
>>> 
>>> 
>>> 
>>> 
>>> And this is the result when i enter the /tmp.reviewboard.GPEAUp 
>>> 
>>> -- 
>>> Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
>>> ---
>>> Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
>>> ---
>>> Happy user? Let us know at http://www.reviewboard.org/users/
>>> --- 
>>> You received this message because you are subscribed to the Google Groups 
>>> "reviewboard" group.
>>> To unsubscribe from this group and stop receiving emails from it, send an 
>>> email to reviewboard...@googlegroups.com.
>>> For more options, visit https://groups.google.com/d/optout.
> 
> -- 
> Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
> ---
> Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
> ---
> Happy user? Let us know at http://www.reviewboard.org/users/
> --- 
> You received this message because you are subscribed to the Google Groups 
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Authentication failed while adding svn repository

2014-07-18 Thread David Trowbridge 
It's expected that username and password would be None in the particular stack 
trace you included (since at that point it's just creating it to check that it 
can). The actual repository checking is a different code path that does include 
credentials.

-David

> On Jul 16, 2014, at 12:11 PM, Alexis  wrote:
> 
> Hi Christian,
> 
> I am encountering the same issue. it seems that before accessing the 
> repository, review board checks that it exists by trying to access it without 
> credentials (assumes there is public access to read) and then it accesses it 
> using the credentials. I have made the code fail where the error occurs to 
> get a traceback:
> 2014-07-15 15:31:52,529 - ERROR -  - SVN: Failed to get repository 
> information for https://example.com:81/svn/Test: callback_get_login required
> 2014-07-15 15:50:25,674 - ERROR -  - Exception thrown for user admin at 
> http://example.com:8181/reviewboard/admin/db/scmtools/repository/add/
> 
> unexpected indent (pysvn.py, line 39)
> Traceback (most recent call last):
>   File 
> "C:\BitNami\reviewboard-2.0.2-0\apps\django\django\core\handlers\base.py", 
> line 112, in get_response
> response = wrapped_callback(request, *callback_args, **callback_kwargs)
>   File 
> "C:\BitNami\reviewboard-2.0.2-0\apps\django\django\contrib\admin\options.py", 
> line 432, in wrapper
> return self.admin_site.admin_view(view)(*args, **kwargs)
>   File 
> "C:\BitNami\reviewboard-2.0.2-0\apps\django\django\utils\decorators.py", line 
> 99, in _wrapped_view
> response = view_func(request, *args, **kwargs)
>   File 
> "C:\BitNami\reviewboard-2.0.2-0\apps\django\django\views\decorators\cache.py",
>  line 52, in _wrapped_view_func
> response = view_func(request, *args, **kwargs)
>   File 
> "C:\BitNami\reviewboard-2.0.2-0\apps\django\django\contrib\admin\sites.py", 
> line 198, in inner
> return view(request, *args, **kwargs)
>   File 
> "C:\BitNami\reviewboard-2.0.2-0\apps\django\django\utils\decorators.py", line 
> 29, in _wrapper
> return bound_func(*args, **kwargs)
>   File 
> "C:\BitNami\reviewboard-2.0.2-0\apps\django\django\utils\decorators.py", line 
> 99, in _wrapped_view
> response = view_func(request, *args, **kwargs)
>   File 
> "C:\BitNami\reviewboard-2.0.2-0\apps\django\django\utils\decorators.py", line 
> 25, in bound_func
> return func(self, *args2, **kwargs2)
>   File "C:\BitNami\reviewboard-2.0.2-0\apps\django\django\db\transaction.py", 
> line 371, in inner
> return func(*args, **kwargs)
>   File 
> "C:\BitNami\reviewboard-2.0.2-0\apps\django\django\contrib\admin\options.py", 
> line 1113, in add_view
> if form.is_valid():
>   File 
> "C:\BitNami\reviewboard-2.0.2-0\apps\reviewboard\Lib\site-packages\ReviewBoard-2.0.2-py2.7.egg\reviewboard\scmtools\forms.py",
>  line 1024, in is_valid
> if not super(RepositoryForm, self).is_valid():
>   File "C:\BitNami\reviewboard-2.0.2-0\apps\django\django\forms\forms.py", 
> line 129, in is_valid
> return self.is_bound and not bool(self.errors)
>   File "C:\BitNami\reviewboard-2.0.2-0\apps\django\django\forms\forms.py", 
> line 121, in errors
> self.full_clean()
>   File 
> "C:\BitNami\reviewboard-2.0.2-0\apps\reviewboard\Lib\site-packages\ReviewBoard-2.0.2-py2.7.egg\reviewboard\scmtools\forms.py",
>  line 813, in full_clean
> super(RepositoryForm, self).full_clean()
>   File "C:\BitNami\reviewboard-2.0.2-0\apps\django\django\forms\forms.py", 
> line 273, in full_clean
> self._clean_fields()
>   File "C:\BitNami\reviewboard-2.0.2-0\apps\django\django\forms\forms.py", 
> line 291, in _clean_fields
> value = getattr(self, 'clean_%s' % name)()
>   File 
> "C:\BitNami\reviewboard-2.0.2-0\apps\reviewboard\Lib\site-packages\ReviewBoard-2.0.2-py2.7.egg\reviewboard\scmtools\forms.py",
>  line 988, in clean_tool
> scmtool_class = tool.get_scmtool_class()
>   File 
> "C:\BitNami\reviewboard-2.0.2-0\apps\reviewboard\Lib\site-packages\ReviewBoard-2.0.2-py2.7.egg\reviewboard\scmtools\models.py",
>  line 56, in get_scmtool_class
> [six.binary_type(attr)])
>   File 
> "C:\BitNami\reviewboard-2.0.2-0\apps\reviewboard\Lib\site-packages\ReviewBoard-2.0.2-py2.7.egg\reviewboard\scmtools\svn\__init__.py",
>  line 552, in 
> recompute_svn_backend()
>   File 
> "C:\BitNami\reviewboard-2.0.2-0\apps\reviewboard\Lib\site-packages\ReviewBoard-2.0.2-py2.7.egg\reviewboard\scmtools\svn\__init__.py",
>  line 527, in recompute_svn_backend
> fromlist=['Client', 'has_svn_backend'])
>   File 
> "C:\BitNami\reviewboard-2.0.2-0\apps\reviewboard\Lib\site-packages\ReviewBoard-2.0.2-py2.7.egg\reviewboard\scmtools\svn\pysvn.py",
>  line 39
> logging.debug('SVN: username: %s, password: %s' %
>^
> IndentationError: unexpected indent
> 2014-07-15 16:25:14,766 - INFO -  - Using reviewboard.scmtools.svn.pysvn 
> backend for SVN
> 2014-07-15 16:35:53,088 - INFO -  - Using reviewboard.scmtools.svn.pysvn 
> backend for SVN
> 2014-07-15 16:36:55,710 - DEBUG -  - SVN: username: None, p

Re: No email notifications

2014-07-18 Thread David Trowbridge 
I suggest looking in the review board logs to see if there are any mail-related 
errors.

-David

> On Jul 18, 2014, at 1:45 PM, Alefiya Mustafa  
> wrote:
> 
> Hi,
> 
> After I added a repository from another server onto review board, Review 
> board stopped sending email notifications. A snapshot of the configuration of 
> the email settings has been attached.
> 
> Any idea as to what could be the problem?
> 
> Alefiya
> 
> 
> 
> -- 
> Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
> ---
> Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
> ---
> Happy user? Let us know at http://www.reviewboard.org/users/
> --- 
> You received this message because you are subscribed to the Google Groups 
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
> 

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

No email notifications

2014-07-18 Thread Alefiya Mustafa 
Hi,

After I added a repository from another server onto review board, Review 
board stopped sending email notifications. A snapshot of the configuration 
of the email settings has been attached.

Any idea as to what could be the problem?

Alefiya



-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Diff creation problem occuring while creating review request

2014-07-18 Thread Shahadat Hossain 
David i attached the files.

Thanks

On Friday, July 18, 2014 10:21:50 AM UTC+6, Shahadat Hossain wrote:
>
>
> When i get to /tmp directory tmp/reviewboard.zsgPUK/ i get 4 files which i 
> already attach in the attachment. It seems the content of the diff file is 
> what i expected. But i can't understand why this issue is happening in 
> reviewboard view diff button. still having the same issue.
>
> Diff currently unavailable.  *Error:* The patch to '/hello.txt' didn't 
> apply cleanly. The temporary files have been left in 
> '/tmp/reviewboard.VeF_ND' for debugging purposes. `patch` returned: 
> patching file /tmp/reviewboard.VeF_ND/tmp8L1ETn Hunk #1 FAILED at 1. 1 out 
> of 1 hunk FAILED -- saving rejects to file 
> /tmp/reviewboard.VeF_ND/tmp8L1ETn-new.rej   Details 
>    
>
> Traceback (most recent call last):
>   File 
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.26-py2.7.egg/reviewboard/diffviewer/views.py",
>  line 251, in view_diff_fragment
> diff_file = get_requested_diff_file()
>   File 
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.26-py2.7.egg/reviewboard/diffviewer/views.py",
>  line 171, in get_requested_diff_file
> populate_diff_chunks(files, highlighting, request=request)
>   File 
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.26-py2.7.egg/reviewboard/diffviewer/diffutils.py",
>  line 344, in populate_diff_chunks
> chunks = generator.get_chunks()
>   File 
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.26-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
>  line 137, in get_chunks
> large_data=True)
>   File 
> "/usr/local/lib/python2.7/dist-packages/Djblets-0.7.30-py2.7.egg/djblets/util/misc.py",
>  line 157, in cache_memoize
> data = lookup_callable()
>   File 
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.26-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
>  line 136, in 
> lambda: list(self._get_chunks_uncached()),
>   File 
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.26-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
>  line 142, in _get_chunks_uncached
> new = get_patched_file(old, self.filediff, self.request)
>   File 
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.26-py2.7.egg/reviewboard/diffviewer/diffutils.py",
>  line 152, in get_patched_file
> return patch(diff, buffer, filediff.dest_file, request)
>   File 
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.26-py2.7.egg/reviewboard/diffviewer/diffutils.py",
>  line 96, in patch
> (filename, tempdir, patch_output))
> Exception: The patch to '/hello.txt' didn't apply cleanly. The temporary 
> files have been left in '/tmp/reviewboard.VeF_ND' for debugging purposes.
> `patch` returned: patching file /tmp/reviewboard.VeF_ND/tmp8L1ETn
> Hunk #1 FAILED at 1.
> 1 out of 1 hunk FAILED -- saving rejects to file 
> /tmp/reviewboard.VeF_ND/tmp8L1ETn-new.rej
>
>
>
> Thanks & Regards
> Shahadat 
>
>
> On Friday, July 18, 2014 9:55:18 AM UTC+6, David Trowbridge wrote:
>>
>> Can you check the contents of the tmp file and the patch file and verify 
>> that they're what you expect?
>>
>> -David
>>
>>
>> On Thu, Jul 17, 2014 at 8:36 PM, Shahadat Hossain  
>> wrote:
>>
>>> Also i am getting the below error in the reviewboard server while i try 
>>> to view the diff from view diff button.
>>>
>>>
>>> Diff currently unavailable.  *Error:* The patch to '/hello.txt' didn't 
>>> apply cleanly. The temporary files have been left in 
>>> '/tmp/reviewboard.2r0DmL' for debugging purposes. `patch` returned: 
>>> patching file /tmp/reviewboard.2r0DmL/tmp8IOq8N Hunk #1 FAILED at 1. 1 out 
>>> of 1 hunk FAILED -- saving rejects to file 
>>> /tmp/reviewboard.2r0DmL/tmp8IOq8N-new.rej   Details 
>>>    
>>>
>>> Traceback (most recent call last):
>>>   File 
>>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.26-py2.7.egg/reviewboard/diffviewer/views.py",
>>>  line 251, in view_diff_fragment
>>> diff_file = get_requested_diff_file()
>>>   File 
>>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.26-py2.7.egg/reviewboard/diffviewer/views.py",
>>>  line 171, in get_requested_diff_file
>>> populate_diff_chunks(files, highlighting, request=request)
>>>   File 
>>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.26-py2.7.egg/reviewboard/diffviewer/diffutils.py",
>>>  line 344, in populate_diff_chunks
>>> chunks = generator.get_chunks()
>>>   File 
>>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.26-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
>>>  line 137, in get_chunks
>>> large_data=True)
>>>   File 
>>> "/usr/local/lib/python2.7/dist-packages/Djblets-0.7.30-py2.7.egg/djblets/util/misc.py",
>>>  line 157, in cache_memoize
>>> data = lookup_callable()
>>>   File 
>>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.26-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
>>>  line 136,

Re: Unable to installing Extensions on RB 2.0.3

2014-07-18 Thread Christian Hammond 
Hey everyone,

I've been out of town this week, but will be back by tonight. I'll look
into what's going on with RBSeverity and get another release out.

Christian


On Friday, July 18, 2014, Griffin Myers  wrote:

> We are also unable to get RBSeverity to work.  I'm using Firefox 30.0 and
> I'm seeing roughly the same reports in their developer tools console:
>
> ReferenceError: RBSeverity is not defined diff:622
>
> which roughly corresponds to the following code:
>
> new RBSeverity.Extension({
>
> id: 'rbseverity.extension.SeverityExtension',
> name: 'Comment Severity',
> urlName: 'view-diff',
> settings: {"_extension_installed_version": "0.5"}
> });
>
>
>
> On Thursday, July 17, 2014 4:41:50 PM UTC-4, Sara Rayburn wrote:
>>
>> I am getting the same errors as MoonWalker.
>>
>> On Tuesday, July 15, 2014 6:29:14 PM UTC-5, MoonWalker wrote:
>>>
>>> I am using RB 2.0.3 and I tried to install the following extensions but
>>> seems like they are not available (easy_install is not able to find them) ,
>>> am I missing something here?
>>>
>>> https://www.reviewboard.org/store/products/6/
>>>
>>> https://www.reviewboard.org/store/products/2/
>>>
>>>  --
> Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
> ---
> Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
> ---
> Happy user? Let us know at http://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com
> 
> .
> For more options, visit https://groups.google.com/d/optout.
>


-- 
-- 
Christian Hammond - christ...@beanbaginc.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Active Directory - Can't Assign New User to Review

2014-07-18 Thread fireworm 
/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/accounts/backends.py
Line 698:
def get_or_create_user(self, username, request, ad_user_data):
username = re.sub(INVALID_USERNAME_CHAR_REGEX, '', username).lower()
logging.error('ActiveDirectoryBackend.get_or_create_user: username 
= %s', username)

/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/webapi/resources/review_request.py
Line 1043:
def _find_user(self, username, local_site, request):
"""Finds a User object matching ``username``.

This will search all authentication backends, and may create the
User object if the authentication backend knows that the user 
exists.
"""
username = username.strip()
ddkflogging.warningsss('trying to find user...')

At this point, I swear there's something simple I'm doing wrong.  (Ubuntu 
isn't exactly an OS I use everyday.)

On Thursday, July 17, 2014 2:06:14 PM UTC-7, David Trowbridge wrote:
>
> That's pretty mysterious. Are you sure that the logging you added is in 
> the correct places?
>
> -David
>
>
> On Thu, Jul 17, 2014 at 2:01 PM, fireworm  > wrote:
>
>> Yep, that's what I did.  But it refuses to acknowledge I changed the 
>> actual execution logic...  Or it's just super smart?
>>
>> For reference, here's what I'm doing:
>>
>> $ sudo chown -R [me] 
>> /usr/locla/lib/python2.7/dist-packages/reviewboard-2.0.1-py2.7.egg/
>>  [delete review_request.pyc and backends.pyc]
>> $ sudo chown -R www-data 
>> /usr/locla/lib/python2.7/dist-packages/reviewboard-2.0.1-py2.7.egg/
>> $ sudo service apache2 restart
>> $ sudo service memcached restart
>>  [reload webpage, try to add a user to the review]
>>  [see that both request_review.pyc and backends.pyc are updated]
>> $ cat /bar/www/[rbsite]/logs/reviewboard.log
>>  [no prints in there from my new logging.debug()]
>> $ sudo cat /var/log/apache2/error.log
>>  [no prints in there from 'bad python code']
>>
>> I think I'm going insane...
>>
>> I've even just restarted the computer itself too, but that doesn't do 
>> anything either...
>>
>> On Thursday, July 17, 2014 1:49:48 PM UTC-7, David Trowbridge wrote:
>>
>>> You probably need to delete the .pyc file and reload the web server.
>>>
>>> -David
>>>
>>>
>>> On Thu, Jul 17, 2014 at 11:32 AM, Bruce Cran  wrote:
>>>
 Do you also need to restart memcached?

 -- 
  Bruce



 On Thu, Jul 17, 2014 at 9:51 AM, Jason Batchkoff  
 wrote:

> *bump bump*
>
> Anyone?  Still haven't figured out how to get a local change to the py 
> scripts to reflect correctly in the running copy.
>
  -- 
 Get the Review Board Power Pack at http://www.reviewboard.org/
 powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google 
 Groups "reviewboard" group.
 To unsubscribe from this group and stop receiving emails from it, send 
 an email to reviewboard...@googlegroups.com.

 For more options, visit https://groups.google.com/d/optout.

>>>
>>>  -- 
>> Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
>> ---
>> Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
>> ---
>> Happy user? Let us know at http://www.reviewboard.org/users/
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to reviewboard...@googlegroups.com .
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Unable to installing Extensions on RB 2.0.3

2014-07-18 Thread Griffin Myers 
We are also unable to get RBSeverity to work.  I'm using Firefox 30.0 and 
I'm seeing roughly the same reports in their developer tools console:

ReferenceError: RBSeverity is not defined diff:622

which roughly corresponds to the following code:

new RBSeverity.Extension({

id: 'rbseverity.extension.SeverityExtension',
name: 'Comment Severity',
urlName: 'view-diff',
settings: {"_extension_installed_version": "0.5"}
});



On Thursday, July 17, 2014 4:41:50 PM UTC-4, Sara Rayburn wrote:
>
> I am getting the same errors as MoonWalker.
>
> On Tuesday, July 15, 2014 6:29:14 PM UTC-5, MoonWalker wrote:
>>
>> I am using RB 2.0.3 and I tried to install the following extensions but 
>> seems like they are not available (easy_install is not able to find them) , 
>> am I missing something here?
>>
>> https://www.reviewboard.org/store/products/6/
>>
>> https://www.reviewboard.org/store/products/2/
>>
>>

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Error when diff files on ReviewBoard site

2014-07-18 Thread hoàng tuấn 
Dear Mr David,

I am using Perforce and my patch's version is 2.6.
I will show you more detail and the content of these file.

At this time, i make a review request and diff file .cpp file. I added 1 
line "#include " to diff. This is a error when i want to view diff.


After that i check in "/tmp/reviewboard.QVafqB": 






---

And i checked another files. But only "tmp1_IEjZ-new.rej" has contents



Best Regards,

Nguyen Tuan Hoang




Vào 10:54:43 UTC+7 Thứ sáu, ngày 18 tháng bảy năm 2014, David Trowbridge đã 
viết:
>
> A couple questions:
>
> - Can you check the contents of the "new   2.txt.diff" file and see if 
> it's what you expect?
> - Can you check the contents of the "tmpeeeSkZ" file and see if it's what 
> you expect?
> - What revision control system?
> - What version of GNU patch?
>
> -David
>
>
> On Thu, Jun 26, 2014 at 2:56 AM, hoàng tuấn  > wrote:
>
>> After reinstall, I make a new request  i face the same problem
>>>
>>> *Exception: The patch to '//depot/P4Test/new  2.txt' didn't apply cleanly. 
>>> The temporary files have been left in '/tmp/reviewboard.GPEAUp' for 
>>> debugging purposes.
>> `patch` returned: patch:  Only garbage was found in the patch input.*
>>
>>
>>
>>  
>> And
>>  
>> this is the result when i enter the /tmp.reviewboard.GPEAUp 
>> 
>>  
>>  
>> -- 
>> Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
>> ---
>> Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
>> ---
>> Happy user? Let us know at http://www.reviewboard.org/users/
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to reviewboard...@googlegroups.com .
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.