How can I post a review for selected files only?

2014-08-06 Thread Tamer Afify
Per the documentation this should do it for Server 1.7.22, rbt 0.6 and SVN 
repository
rbt post -I 
yet that generates a code review request (with a diff file) for all checked 
out files under current path (where rbt is called).

Am I doing something wrong?

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: How can I post a review for selected files only?

2014-08-06 Thread David Trowbridge
Hi,

There was a bug in 0.6 that prevented -I from working with SVN
repositories. This bug was fixed in 0.6.1

-David


On Wed, Aug 6, 2014 at 12:21 PM, Tamer Afify  wrote:

> Per the documentation this should do it for Server 1.7.22, rbt 0.6 and SVN
> repository
> rbt post -I 
> yet that generates a code review request (with a diff file) for all
> checked out files under current path (where rbt is called).
>
> Am I doing something wrong?
>
> --
> Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
> ---
> Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
> ---
> Happy user? Let us know at http://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Clarification of Pre-Commit Workflow

2014-08-06 Thread Christian Hammond
Hi Kevan,

That’s the workflow, though we strongly encourage you to post to a branch based 
off master, and then only merge to master once it’s reviewed.

rbt post will post from the upstream tracking branch (defaulting to 
origin/master, customizable by TRACKING_BRANCH in .reviewboardrc or 
—tracking-branch) to HEAD. In your case, it’s only posting the latest commit 
because you’re committing to master, and have one change from origin/master to 
there.

If you set up Default Reviewers on Review Board, you won’t need to choose any 
reviewers.

Christian

-- 
Christian Hammond - christ...@beanbaginc.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com

On August 5, 2014 at 10:42:45 PM, Kevan Stannard (kevanstann...@gmail.com) 
wrote:

I've been reading the workflow page here:
https://www.reviewboard.org/docs/manual/2.0/users/getting-started/workflow/

We're planning to follow the pre-commit workflow.

Would be grateful if someone could clarify some of the steps for us. Here's my 
current understanding of the first few steps:

1) Make a change to your local source tree.

Here we:
a) Edit a file
b) Commit the change

2) Create a review request for your new change.

Here we:
a) Run rbt post (which seems to post the latest commit?)

3) Publish the review request and wait for your reviewers to see it.

Here we:
a) Log into Review Board
b) Choose reviewers
c) Publish the review request


At the moment we are all committing to master, then push to our origin 
regularly.

Thanks


--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: can't pip install RBTools - no packages on pypi?

2014-08-06 Thread Edward Delaporte
For what it's worth, there seems to be a combination of command line flags 
that works as a workaround:

pip install rbtools --allow-external rbtools --allow-unverified rbtools


On Wednesday, May 7, 2014 8:03:11 AM UTC-5, Jason Antman wrote:
>
> I'm aware that pip is not a supported installation method for ReviewBoard 
> itself. However, I have a number of cases where pip installation is the 
> only method I can do, and I only need access to RBTools for the API client.
>
> As of a few months ago, I was able to `pip install RBTools==0.5.2` without 
> a problem, and I have this in a number of requirements.txt files.
>
> This morning I tried re-deploying one of the applications that uses this, 
> and got an error from pip saying "No distributions at all found" - there 
> don't seem to be any valid packages on pypi itself, and even having it 
> allow external URLs doesn't seem to work.
>
> Is this an intentional change in behavior?
>
> Thanks,
> Jason
>

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: can't pip install RBTools - no packages on pypi?

2014-08-06 Thread David Trowbridge
That will install the package, but I believe pip still doesn't properly 
register python entry points, which means that rbt won't work right.

-David

> On Aug 6, 2014, at 2:04 PM, Edward Delaporte  wrote:
> 
> For what it's worth, there seems to be a combination of command line flags 
> that works as a workaround:
> 
> pip install rbtools --allow-external rbtools --allow-unverified rbtools
> 
> 
>> On Wednesday, May 7, 2014 8:03:11 AM UTC-5, Jason Antman wrote:
>> I'm aware that pip is not a supported installation method for ReviewBoard 
>> itself. However, I have a number of cases where pip installation is the only 
>> method I can do, and I only need access to RBTools for the API client.
>> 
>> As of a few months ago, I was able to `pip install RBTools==0.5.2` without a 
>> problem, and I have this in a number of requirements.txt files.
>> 
>> This morning I tried re-deploying one of the applications that uses this, 
>> and got an error from pip saying "No distributions at all found" - there 
>> don't seem to be any valid packages on pypi itself, and even having it allow 
>> external URLs doesn't seem to work.
>> 
>> Is this an intentional change in behavior?
>> 
>> Thanks,
>> Jason
> 
> -- 
> Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
> ---
> Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
> ---
> Happy user? Let us know at http://www.reviewboard.org/users/
> --- 
> You received this message because you are subscribed to the Google Groups 
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.