Re: A question on the marking of differences in between revisions of a review
Thanks for the explanation David, -amac On Tuesday, November 25, 2014 3:37:17 PM UTC-8, David Trowbridge wrote: > > Ah, I see what's going on. It's being filtered out because it's not > included in any of the changed regions in the new diff. This happens so > that we can filter out unrelated changes from other commits that happen in > between the diffs. > > It's not ideal, but I don't know that we can do anything about this > without bringing back all of the other unrelated changes. > > -David > > On Tue, Nov 25, 2014 at 10:00 AM, Andrew MacLeod > wrote: > >> Thanks David although that is not what not I am seeing now that I tracked >> down the review again. >> >> The interdiff between the revision where the code was removed and any >> revision after it got added back does not show as an added diff. >> >> One correction to my original description, the code was added back in >> revision 6. I have added screenshots to show the behavior. Screenshot of >> the changes from the original to #1 (where the code was removed), 5-6 where >> the code was added back in and finally 1-6. >> >> If I understand you explanation below then this is a bug and the addition >> from 1-6 should be highlighted? This is Review Board version 2.0.11 if that >> makes a difference. >> Thanks, >> >> -amac >> >> On Thursday, November 20, 2014 4:40:48 PM UTC-8, David Trowbridge wrote: >>> >>> This is the case because if you apply rev #2 to the upstream code, those >>> lines are present, and if you apply rev #6 to the upstream code, those >>> lines are also present (so there's no difference between them). If you view >>> the interdiff between 1 and 6, you should see those lines as added. >>> >>> -David >>> >>> On Thu, Nov 20, 2014 at 4:25 PM, Andrew MacLeod >>> wrote: >>> The scenario is as follow. In the first diff posting (rev #1) of a review, lines 5-10 are removed in one particular file. There are lots of other changes in this file and others. In the second diff posting (rev #2) of the review, the lines are added back in. We get several more diff postings on this review until we are at rev#6. Now if you look at the inter-diff changes from rev #2 -> rev #6, the addition of lines 5-10 does *not* show as an addition (ie. in green) on the right hand panel of the diff screen. I can argue why that is the case but my question is this intended behavior? Thanks, -amac -- Get the Review Board Power Pack at http://www.reviewboard.org/ powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. >>> >>> -- >> Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ >> --- >> Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ >> --- >> Happy user? Let us know at http://www.reviewboard.org/users/ >> --- >> You received this message because you are subscribed to the Google Groups >> "reviewboard" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to reviewboard...@googlegroups.com . >> For more options, visit https://groups.google.com/d/optout. >> > > -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Git-Svn Fails finding object name 'trunk'
% rbt diff --debug >>> RBTools 0.6.3 >>> Python 2.7.8 (default, Sep 24 2014, 18:26:21) [GCC 4.9.1 20140903 (prerelease)] >>> Running on Linux-3.17.3-1-ARCH-x86_64-with-glibc2.2.5 >>> Home = /home/jake >>> Current directory = /home/jake/dev//svn >>> Checking for a Subversion repository... >>> Running: svn info --non-interactive >>> Command exited with rc 1: ['svn', 'info', '--non-interactive'] svn: E155007: '/home/jake/dev//svn' is not a working copy --- >>> Checking for a Git repository... >>> Running: git rev-parse --git-dir >>> Running: git config core.bare >>> Running: git rev-parse --show-toplevel >>> Running: git symbolic-ref -q HEAD >>> Running: git svn info >>> repository info: Path: https://svn..com/svn, Base path: /minted/trunk, Supports changesets: False >>> Making HTTP GET request to https://reviewboard..com/api/ >>> Running: git rev-parse refs/heads/master >>> Running: git merge-base 9e7c4871d93fc262a6601327e77ab4ea58c09909 trunk Failed to execute command: ['git', 'merge-base', '9e7c4871d93fc262a6601327e77ab4ea58c09909', 'trunk'] fatal: Not a valid object name trunk Running "rbt diff --track=origin/trunk" works flawlessly Thanks! On Wednesday, November 26, 2014 12:11:37 PM UTC-5, David Trowbridge wrote: > > > Can you run with --debug and send the output? > > -David > On Wed, Nov 26, 2014 at 9:09 AM Jake Champlin > wrote: > >> Using: >> - RBTools 0.6.3 >> - ArchLinux >> - git svn repository >> >> Using a git-svn repository, rbtools fails to find valid object name >> "trunk". >> >> % rbt diff >> Failed to execute command: ['git', 'merge-base', >> '9e7c4871d93fc262a6601327e77ab4ea58c09909', 'trunk'] >> fatal: Not a valid object name trunk >> >> Running `git svn info` fetches valid info from trunk, as well as running >> `git svn log` >> >> This works, however, in OSX; with the same repository, .reviewboardrc >> file, and RBTools version, so I'm wondering if I am missing any packages >> that RBTools needs? >> >> I installed RBTools via easy_install >> >> Thanks! >> >> >> >> -- >> Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ >> --- >> Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ >> --- >> Happy user? Let us know at http://www.reviewboard.org/users/ >> --- >> You received this message because you are subscribed to the Google Groups >> "reviewboard" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to reviewboard...@googlegroups.com . >> For more options, visit https://groups.google.com/d/optout. >> > -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Git-Svn Fails finding object name 'trunk'
Can you run with --debug and send the output? -David On Wed, Nov 26, 2014 at 9:09 AM Jake Champlin wrote: > Using: > - RBTools 0.6.3 > - ArchLinux > - git svn repository > > Using a git-svn repository, rbtools fails to find valid object name > "trunk". > > % rbt diff > Failed to execute command: ['git', 'merge-base', > '9e7c4871d93fc262a6601327e77ab4ea58c09909', 'trunk'] > fatal: Not a valid object name trunk > > Running `git svn info` fetches valid info from trunk, as well as running > `git svn log` > > This works, however, in OSX; with the same repository, .reviewboardrc > file, and RBTools version, so I'm wondering if I am missing any packages > that RBTools needs? > > I installed RBTools via easy_install > > Thanks! > > > > -- > Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ > --- > Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ > --- > Happy user? Let us know at http://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Git-Svn Fails finding object name 'trunk'
Using: - RBTools 0.6.3 - ArchLinux - git svn repository Using a git-svn repository, rbtools fails to find valid object name "trunk". % rbt diff Failed to execute command: ['git', 'merge-base', '9e7c4871d93fc262a6601327e77ab4ea58c09909', 'trunk'] fatal: Not a valid object name trunk Running `git svn info` fetches valid info from trunk, as well as running `git svn log` This works, however, in OSX; with the same repository, .reviewboardrc file, and RBTools version, so I'm wondering if I am missing any packages that RBTools needs? I installed RBTools via easy_install Thanks! -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: SVN connection failure
On Wed, 2014-11-26 at 05:47 -0800, Dan Holmes wrote: > so i tried it and "I've found that the pysvn option is the better one" > appears to be true (this is Ubunutu). > > > now i get the same error i had on the windows server. I don't get > prompted to accept. how do i get this resolved? I already saved the > cert with curl and svn cmds but those apparently didn't store them in > the right place. > > > Unable to connect to a repository at URL > 'https://rmfile02.routematch.local:8443/svn/RouteMatch' Server SSL > certificate verification failed: issuer is not trusted You're going to need to put the public CA certificate for the server into your local trust store. I'm not sure how you do that on Ubuntu, but on Fedora you would drop the CA certificate into /etc/pki/ca-trust/source/anchors/ and then run /usr/bin/update-ca-trust to import it to the trust store. I'm not certain if this is available on Ubuntu, but it's definitely the easy way. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: SVN connection failure
so i tried it and "I've found that the pysvn option is the better one" appears to be true (this is Ubunutu). now i get the same error i had on the windows server. I don't get prompted to accept. how do i get this resolved? I already saved the cert with curl and svn cmds but those apparently didn't store them in the right place. Unable to connect to a repository at URL 'https://rmfile02.routematch.local:8443/svn/RouteMatch' Server SSL certificate verification failed: issuer is not trusted On Wednesday, November 26, 2014 8:43:33 AM UTC-5, Dan Holmes wrote: > > do i have to uninstall subvertpy? how does RB know to use one or the > other? is there a config switch? > > On Wednesday, November 26, 2014 8:34:38 AM UTC-5, Stephen Gallagher wrote: >> >> >> >> >> On Wed, 2014-11-26 at 05:31 -0800, Dan Holmes wrote: >> > subvertpy. felt like the instructions favored that one. >> > >> > >> > >> > >> > >> > >> > On Tuesday, November 25, 2014 6:21:26 PM UTC-5, David Trowbridge >> > wrote: >> > Are you using the pysvn or subvertpy backend? >> > >> >> >> In my experience (on Fedora), I've found that the pysvn option is the >> better one. As I understand it, subvertpy is mainly there because it can >> be installed with easy_install, but it's not nearly as mature as pysvn. >> >> Since your operating system includes a pysvn package, it would probably >> be best to install that using apt and try again. If that works, then >> there's a bug in the subvertpy support somewhere that can be looked >> into, but you'll be up and running in the meantime. >> >> -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: SVN connection failure
do i have to uninstall subvertpy? how does RB know to use one or the other? is there a config switch? On Wednesday, November 26, 2014 8:34:38 AM UTC-5, Stephen Gallagher wrote: > > > > > On Wed, 2014-11-26 at 05:31 -0800, Dan Holmes wrote: > > subvertpy. felt like the instructions favored that one. > > > > > > > > > > > > > > On Tuesday, November 25, 2014 6:21:26 PM UTC-5, David Trowbridge > > wrote: > > Are you using the pysvn or subvertpy backend? > > > > > In my experience (on Fedora), I've found that the pysvn option is the > better one. As I understand it, subvertpy is mainly there because it can > be installed with easy_install, but it's not nearly as mature as pysvn. > > Since your operating system includes a pysvn package, it would probably > be best to install that using apt and try again. If that works, then > there's a bug in the subvertpy support somewhere that can be looked > into, but you'll be up and running in the meantime. > > -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: SVN connection failure
On Wed, 2014-11-26 at 05:31 -0800, Dan Holmes wrote: > subvertpy. felt like the instructions favored that one. > > > > > > > On Tuesday, November 25, 2014 6:21:26 PM UTC-5, David Trowbridge > wrote: > Are you using the pysvn or subvertpy backend? > In my experience (on Fedora), I've found that the pysvn option is the better one. As I understand it, subvertpy is mainly there because it can be installed with easy_install, but it's not nearly as mature as pysvn. Since your operating system includes a pysvn package, it would probably be best to install that using apt and try again. If that works, then there's a bug in the subvertpy support somewhere that can be looked into, but you'll be up and running in the meantime. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: SVN connection failure
subvertpy. felt like the instructions favored that one.
On Tuesday, November 25, 2014 6:21:26 PM UTC-5, David Trowbridge wrote:
>
> Are you using the pysvn or subvertpy backend?
>
> -David
>
> On Tue, Nov 25, 2014 at 9:19 AM, Dan Holmes > wrote:
>
>> I switched to Ubuntu but am still having SVN connection problems. I went
>> back over the installation for SVN python tools and it said it was all
>> installed. What am i missing?
>>
>> from the apache error.log
>> [Tue Nov 25 17:14:27.246518 2014] [:error] [pid 8713] ERROR:root:SVN:
>> Failed to get repository information for
>> https://10.7.0.1:8443/svn/RouteMatch/: ("Unable to connect to a
>> repository at URL 'https://10.7.0.1:8443/svn/RouteMatch'", 230001)
>>
>> however both svn and curl will return without problem.
>>
>> notroot@RMDevTools01:~$ svn info https://10.7.0.1:8443/svn/RouteMatch/
>> Path: RouteMatch
>> URL: https://10.7.0.1:8443/svn/RouteMatch
>> Relative URL: ^/
>> Repository Root: https://10.7.0.1:8443/svn/RouteMatch
>> Repository UUID: 34830635-b4d3-f84e-9563-fed92939f730
>> Revision: 61143
>> Node Kind: directory
>> Last Changed Author:
>> Last Changed Rev: 61143
>> Last Changed Date: 2014-11-25 12:11:56 -0500 (Tue, 25 Nov 2014)
>>
>> notroot@RMDevTools01:~$ curl https://10.7.0.1:8443/svn/RouteMatch/
>> --insecure -u xx
>>
>>
>> >
>> > hrefCDATA #REQUIRED>
>>
>> > pathCDATA #IMPLIED
>> rev CDATA #IMPLIED
>> baseCDATA #IMPLIED>
>>
>>
>>
>> > hrefCDATA #REQUIRED>
>>
>> > hrefCDATA #REQUIRED>
>> ]>
>> > href="http://subversion.apache.org/";>
>>
>> ...
>>
>>
>> --
>> Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
>> ---
>> Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
>> ---
>> Happy user? Let us know at http://www.reviewboard.org/users/
>> ---
>> You received this message because you are subscribed to the Google Groups
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to reviewboard...@googlegroups.com .
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>
--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
