Post review commit through web UI on git repository
Hi all I have a question about post-commit review through UI. I have successfully added git repository and made it publicly visible. But when I go to New Review Request tab, all I see is *Create from a local change *section. According to the documentation, post-commit review should be enabled for git repository type after ReviewBoard 2.0 version. Creation of review request via rbt post is doing ok, but now I wanted to create one directly from UI. ReviewBoard instance I am running is 2.5.7, git repository is self hosted on remote server (git repo is not placed on same machine as ReviewBoard), with gitweb integration. Git repo is SSH backed and I exchanged key pairs between RB and GIT repo. Raw file URL mask is defined with format: http://*url.to.gitweb*/?p= *git-repo*.git;a=blob_plain;f=;h= (entering only http:// *url.to.gitweb*/?p=*git-repo*.git into browser opens git project in gitweb). Am I missing something in configuration or only git repo that is hosted somwhere (GitHub, gitlab, bitbucket...) supports creation of new review request via UI? Thanks in advance -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "Review Board Community" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Slack with ReviewBoard 2.5.9
Ok, great, thank you for fast answer. I know I already asked, but I've seen 3.0 Beta 1 is released. What is the expected release date of 3.0 Beta 2 version? Thank you very much On Mon, Aug 21, 2017 at 9:00 AM, Christian Hammond <christ...@beanbaginc.com > wrote: > Hi Antonio, > > WebHooks are a separate feature from the Slack integration. Configuring > WebHooks to be limited based on the repository won't impact Slack's > behavior. > > To get the behavior you want, you'll either need to fork rbslack or wait > for 3.0. > > Christian > > > On Sun, Aug 20, 2017 at 23:50 Antonio Soldo <antonio.sold...@gmail.com> > wrote: > >> I found this feature under Admin Dashboard -> Webhooks -> Click on >> defined webhook -> Field Apply to has option Only review requests on >> selected repositories. >> I am also posting screenshot of this screen if something is not clear >> from this path. >> >> >> <https://lh3.googleusercontent.com/-nAK39HL0eTQ/WZqCssnhp7I/AQs/_3vuakqCxl4LiOkc4nBW6VWMWHMTvEouQCLcBGAs/s1600/RB_Slack.jpg> >> >> >> On Sunday, August 20, 2017 at 12:49:02 PM UTC+2, Christian Hammond wrote: >> >>> Hi Antonio, >>> >>> rbslack's configuration is pretty limited. I don't believe we allow for >>> specifying just one type of repository. Where are you seeing this option >>> for push notifications? >>> >>> Review Board 3.0 will ship with completely redesigned Slack support, >>> which will allow for specifying as many rule-based configurations as you >>> need. >>> >>> Christian >>> >> On Fri, Aug 18, 2017 at 5:43 AM, Antonio Soldo <antonio...@gmail.com> >>> wrote: >>> >> Hi all >>>> >>>> We might have some problems with current rbslack extension and >>>> reviewboard server. >>>> We are currently using ReviewBoard 2.5.9, and have defined three >>>> different repositories. We only want to receive slack notifications for all >>>> reviews made on only one repository. Through admin dashboard I have set up >>>> to only push notifications only on that one repository, but we are still >>>> receiving notifications for every event, regardless of repository it >>>> originates from. Is this maybe fixed in some other versions of ReviewBoard >>>> or if we configured something wrong? >>>> >>>> Thank you in advance >>>> >>>> Best regards >>>> Antonio >>>> >>> -- >>>> Supercharge your Review Board with Power Pack: >>>> https://www.reviewboard.org/powerpack/ >>>> Want us to host Review Board for you? Check out RBCommons: >>>> https://rbcommons.com/ >>>> Happy user? Let us know! https://www.reviewboard.org/users/ >>>> --- >>>> You received this message because you are subscribed to the Google >>>> Groups "reviewboard" group. >>>> >>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to reviewboard...@googlegroups.com. >>> >>> >>>> For more options, visit https://groups.google.com/d/optout. >>>> >>> >>> >>> >>> -- >>> Christian Hammond >>> President/CEO of Beanbag <https://www.beanbaginc.com/> >>> Makers of Review Board <https://www.reviewboard.org/> >>> >> -- >> Supercharge your Review Board with Power Pack: >> https://www.reviewboard.org/powerpack/ >> Want us to host Review Board for you? Check out RBCommons: >> https://rbcommons.com/ >> Happy user? Let us know! https://www.reviewboard.org/users/ >> --- >> You received this message because you are subscribed to the Google Groups >> "reviewboard" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to reviewboard+unsubscr...@googlegroups.com. >> For more options, visit https://groups.google.com/d/optout. >> > -- > -- > Christian Hammond > President/CEO of Beanbag > Makers of Review Board > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to a topic in the > Google Groups "reviewboard" group. > To unsubscribe from this topic, visit https://groups.google.com/d/ > topic/reviewboard/h36OwqvMYKI/unsubscribe. > To unsubscribe from this group and all its topics, send an email to > reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Slack with ReviewBoard 2.5.9
I found this feature under Admin Dashboard -> Webhooks -> Click on defined webhook -> Field Apply to has option Only review requests on selected repositories. I am also posting screenshot of this screen if something is not clear from this path. <https://lh3.googleusercontent.com/-nAK39HL0eTQ/WZqCssnhp7I/AQs/_3vuakqCxl4LiOkc4nBW6VWMWHMTvEouQCLcBGAs/s1600/RB_Slack.jpg> On Sunday, August 20, 2017 at 12:49:02 PM UTC+2, Christian Hammond wrote: > > Hi Antonio, > > rbslack's configuration is pretty limited. I don't believe we allow for > specifying just one type of repository. Where are you seeing this option > for push notifications? > > Review Board 3.0 will ship with completely redesigned Slack support, which > will allow for specifying as many rule-based configurations as you need. > > Christian > > On Fri, Aug 18, 2017 at 5:43 AM, Antonio Soldo <antonio...@gmail.com > > wrote: > >> Hi all >> >> We might have some problems with current rbslack extension and >> reviewboard server. >> We are currently using ReviewBoard 2.5.9, and have defined three >> different repositories. We only want to receive slack notifications for all >> reviews made on only one repository. Through admin dashboard I have set up >> to only push notifications only on that one repository, but we are still >> receiving notifications for every event, regardless of repository it >> originates from. Is this maybe fixed in some other versions of ReviewBoard >> or if we configured something wrong? >> >> Thank you in advance >> >> Best regards >> Antonio >> >> -- >> Supercharge your Review Board with Power Pack: >> https://www.reviewboard.org/powerpack/ >> Want us to host Review Board for you? Check out RBCommons: >> https://rbcommons.com/ >> Happy user? Let us know! https://www.reviewboard.org/users/ >> --- >> You received this message because you are subscribed to the Google Groups >> "reviewboard" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to reviewboard...@googlegroups.com . >> For more options, visit https://groups.google.com/d/optout. >> > > > > -- > Christian Hammond > President/CEO of Beanbag <https://www.beanbaginc.com/> > Makers of Review Board <https://www.reviewboard.org/> > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Slack with ReviewBoard 2.5.9
Hi all We might have some problems with current rbslack extension and reviewboard server. We are currently using ReviewBoard 2.5.9, and have defined three different repositories. We only want to receive slack notifications for all reviews made on only one repository. Through admin dashboard I have set up to only push notifications only on that one repository, but we are still receiving notifications for every event, regardless of repository it originates from. Is this maybe fixed in some other versions of ReviewBoard or if we configured something wrong? Thank you in advance Best regards Antonio -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Mail notifications are doubled when review is published
Great, thanks for fast reply. I checked with our sys admins and they have been informed about this issue and will try to correct it, asap. Regarding your question, we checked that user in question has both mail addresses same in mailing group and ReviewBoard. So this question is strictly our internal problem which we have to improve. On Wednesday, April 26, 2017 at 7:23:22 AM UTC+2, Christian Hammond wrote: > > Hi Antonio, > > Most mailing list software should handle deduplication of messages. If it > sees an e-mail going out to a mailing list and a member of that list is > already on the To/CC, then it shouldn't be sending the message to that > user. Sounds like that's not happening here. > > What are you using for the mailing lists? Is there a chance that the users > in question have one version of their e-mail address in the mailing list > and another in Review Board? > > Christian > > -- > Christian Hammond > President/CEO of Beanbag <https://www.beanbaginc.com/> > Makers of Review Board <https://www.reviewboard.org/> > > On Tue, Apr 25, 2017 at 5:38 AM, Antonio Soldo <antonio...@gmail.com > > wrote: > >> Hello >> >> We noticed some questionable behavior in our app, so I wanted to check >> with you guys too. We are currently using ReviewBoard 2.5.9. We have >> defined one review group and that group has its mail defined. Our mail >> server then knows what recipients should be addressed when mail is sent to >> that mail group. >> >> Lets say someone from that review group publishes a comment on a review >> that is made for review group. In this case every person in that mailing >> group receives only one mail. >> But when someone (that is also listed as a member of review group) >> replies to this comment, person that first made comment will receive two >> mails - one for mailing group and one for himself. I am not sure who's >> responsibility is to handle this situation (if it is possible to manage it) >> - our mail server or review board. My question is, is this double mail >> notification excepted behavior or not? >> >> Thanks in advance >> >> Antonio Soldo >> >> -- >> Supercharge your Review Board with Power Pack: >> https://www.reviewboard.org/powerpack/ >> Want us to host Review Board for you? Check out RBCommons: >> https://rbcommons.com/ >> Happy user? Let us know! https://www.reviewboard.org/users/ >> --- >> You received this message because you are subscribed to the Google Groups >> "reviewboard" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to reviewboard...@googlegroups.com . >> For more options, visit https://groups.google.com/d/optout. >> > > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Mail notifications are doubled when review is published
Hello We noticed some questionable behavior in our app, so I wanted to check with you guys too. We are currently using ReviewBoard 2.5.9. We have defined one review group and that group has its mail defined. Our mail server then knows what recipients should be addressed when mail is sent to that mail group. Lets say someone from that review group publishes a comment on a review that is made for review group. In this case every person in that mailing group receives only one mail. But when someone (that is also listed as a member of review group) replies to this comment, person that first made comment will receive two mails - one for mailing group and one for himself. I am not sure who's responsibility is to handle this situation (if it is possible to manage it) - our mail server or review board. My question is, is this double mail notification excepted behavior or not? Thanks in advance Antonio Soldo -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Expected release of 3.0 version of reviewboard
Hi Just out of curiosity, what is expected release date of 3.0 reviewboard version? Will it go out in period over two months or it needs more time than that? Thanks in advance -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: reviewboard connecting to the cloudfront when publishing review changes (comments, issues, closing review...)
Thank you very much. Setting environment variable in apache configuartion and restarting it did not help, but your other suggestion did, so thumbs up. Again, thank you very much for fast reply and great suggestions. I owe you, at least, a beer :) On Friday, January 20, 2017 at 10:15:02 AM UTC+1, Christian Hammond wrote: > > Glad you found the cause, and that it wasn't anything concerning! Sounds > like Slack owns that address, then. I tried resolving it before responding > earlier, but couldn't figure out what it mapped to. > > We use Python's urllib2, which respects the http_proxy and https_proxy > environment variables. You should be able to set these in Apache using: > > SetEnv http_proxy http://yourproxy/ > SetEnv https_proxy https://yourproxy/ > > You'll then needed to restart Apache. > > If that fails for some reason, you can try setting the environment > variables in $rbsitedir/htdocs/reviewboard.wsgi. > > Hope that helps! > > Christian > > -- > Christian Hammond > President/CEO of Beanbag <https://www.beanbaginc.com/> > Makers of Review Board <https://www.reviewboard.org/> > > On Fri, Jan 20, 2017 at 12:15 AM, Antonio Soldo <antonio...@gmail.com > > wrote: > >> Thank You Christian for fast reply. >> >> We are not using gravatar images and I tried switching this option on/off >> just in case, but it didn't work out. >> Then I kept digging through every single option in admin dashboard and >> found that one webhook for slack was activated. >> I switched it off and boom, everything works smooth. Again, I am very >> thankful for this effort and fast response as this actually made me think >> and to look deeper and better. >> >> To completely answer to Your questions: >> >> *Q: You're seeing this server-side?*A: Yes, this is traffic on server >> side. >> >> *Q:Is this only when posting a new change for review using command line >> tools, or through the web UI?*A: Tried only through webUI, but I think >> it would act same iff slack webhook is active. >> >> *Q: Do you see it when just browsing through the UI?*A: No, by browsing >> through UI application works fine, its responsive and behaves as planned. >> *Q:* >> *Any chance you have a browser extension that might be accessing >> something?*A: I performed same steps in Mozilla with some 3rd party >> extensions and in Chrome with no extensions at all, and it behaved exactly >> the same in both cases. >> >> *Q: Can you give me the exact command you ran?*A: On review request I >> made some comment, and published it. After publishing it, it keeps the >> 'Loading' banner active, and when trying to switch to any other screen, a >> short popup is displayed with message 'HTTP 0 Error'. Application is again >> in usable state, and everything works as expected until You try to publish >> some change. >> >> >> Apart from not using this webhook at all (it is a neat feature, but not >> the reason to stop using ReviewBoard), is it possible to configure >> ReviewBoard to channel every request through proxy server? >> >> Once again, thank You very much >> >> On Friday, January 20, 2017 at 5:04:44 AM UTC+1, Christian Hammond wrote: >>> >>> Hi Antonio, >>> >>> That's not one of our servers, from what I can tell, and there's nothing >>> in our code referencing this at all. You're seeing this server-side? Is >>> this only when posting a new change for review using command line tools, or >>> through the web UI? Do you see it when just browsing through the UI? >>> >>> We do use https://secure.gravatar.com/, but I don't know whether this >>> is served on CloudFront. >>> >>> If you're on the Admin UI page, we have a browser-side query to >>> beanbaginc.com to check on the support level of the server. >>> >>> Any chance you have a browser extension that might be accessing >>> something? >>> >>> Can you give me the exact command you ran? I'll see if it pops up on my >>> end. >>> >>> Christian >>> >>> -- >>> Christian Hammond >>> President/CEO of Beanbag <https://www.beanbaginc.com/> >>> Makers of Review Board <https://www.reviewboard.org/> >>> >>> On Thu, Jan 19, 2017 at 7:49 AM, Antonio Soldo <antonio...@gmail.com> >>> wrote: >>> >>>> I addition to my question, the reason I'm asking such thing is that we >>>> have our instance of ReviewBoard (and any other tool hosted
Re: reviewboard connecting to the cloudfront when publishing review changes (comments, issues, closing review...)
Thank You Christian for fast reply. We are not using gravatar images and I tried switching this option on/off just in case, but it didn't work out. Then I kept digging through every single option in admin dashboard and found that one webhook for slack was activated. I switched it off and boom, everything works smooth. Again, I am very thankful for this effort and fast response as this actually made me think and to look deeper and better. To completely answer to Your questions: *Q: You're seeing this server-side?*A: Yes, this is traffic on server side. *Q:Is this only when posting a new change for review using command line tools, or through the web UI?*A: Tried only through webUI, but I think it would act same iff slack webhook is active. *Q: Do you see it when just browsing through the UI?*A: No, by browsing through UI application works fine, its responsive and behaves as planned. *Q:* *Any chance you have a browser extension that might be accessing something?*A: I performed same steps in Mozilla with some 3rd party extensions and in Chrome with no extensions at all, and it behaved exactly the same in both cases. *Q: Can you give me the exact command you ran?*A: On review request I made some comment, and published it. After publishing it, it keeps the 'Loading' banner active, and when trying to switch to any other screen, a short popup is displayed with message 'HTTP 0 Error'. Application is again in usable state, and everything works as expected until You try to publish some change. Apart from not using this webhook at all (it is a neat feature, but not the reason to stop using ReviewBoard), is it possible to configure ReviewBoard to channel every request through proxy server? Once again, thank You very much On Friday, January 20, 2017 at 5:04:44 AM UTC+1, Christian Hammond wrote: > > Hi Antonio, > > That's not one of our servers, from what I can tell, and there's nothing > in our code referencing this at all. You're seeing this server-side? Is > this only when posting a new change for review using command line tools, or > through the web UI? Do you see it when just browsing through the UI? > > We do use https://secure.gravatar.com/, but I don't know whether this is > served on CloudFront. > > If you're on the Admin UI page, we have a browser-side query to > beanbaginc.com to check on the support level of the server. > > Any chance you have a browser extension that might be accessing something? > > Can you give me the exact command you ran? I'll see if it pops up on my > end. > > Christian > > -- > Christian Hammond > President/CEO of Beanbag <https://www.beanbaginc.com/> > Makers of Review Board <https://www.reviewboard.org/> > > On Thu, Jan 19, 2017 at 7:49 AM, Antonio Soldo <antonio...@gmail.com > > wrote: > >> I addition to my question, the reason I'm asking such thing is that we >> have our instance of ReviewBoard (and any other tool hosted at us) behind >> proxy, and all outgoing request must be channeled through this proxy. As in >> this case, proxy is bypassed (not consulted), and all outgoing public >> network request are discarded. Because of this, application is slow (for >> example, posting a comment in review takes up to 3 mins) and application is >> barely usable. >> >> As a continuation on first question, is there a possibility to run >> reviewboard in such "eco-system" (where every public http request must go >> through proxy)? >> >> What we tried is to set env variable http_proxy and https_proxy to point >> at out proxy. Running command 'lynx gooogle.com' on CentOS that backs >> ReviewBoard went through proxy and response was received. But repeating >> comment publishing on review resulted in same manner as first time, a >> direct request to cloudfront was made instead of going through proxy. >> >> >> >> On Thursday, January 19, 2017 at 4:02:22 PM UTC+1, Antonio Soldo wrote: >>> >>> Hi all >>> >>> Is there a reason why is ReviewBoard trying to connect to the >>> server-54-192-186-70.cdg51.r.cloudfront.net after every change that is >>> published on review? >>> I was monitoring my net traffic and noticed this connection and did not >>> find anything specific why this server would be contacted. In my admin >>> dashboard I defined that all files are hosted locally. >>> Also, inspecting web server configuration did not give me any clue. I'm >>> attaching captured traffic so everybody could see request made to above >>> mentioned server. >>> >>> I'm hosting ReviewBoard locally, and currently running version 2.5.7 on >>> CentOS 7.3.1611. ReviewBoard is
Re: reviewboard connecting to the cloudfront when publishing review changes (comments, issues, closing review...)
I addition to my question, the reason I'm asking such thing is that we have our instance of ReviewBoard (and any other tool hosted at us) behind proxy, and all outgoing request must be channeled through this proxy. As in this case, proxy is bypassed (not consulted), and all outgoing public network request are discarded. Because of this, application is slow (for example, posting a comment in review takes up to 3 mins) and application is barely usable. As a continuation on first question, is there a possibility to run reviewboard in such "eco-system" (where every public http request must go through proxy)? What we tried is to set env variable http_proxy and https_proxy to point at out proxy. Running command 'lynx gooogle.com' on CentOS that backs ReviewBoard went through proxy and response was received. But repeating comment publishing on review resulted in same manner as first time, a direct request to cloudfront was made instead of going through proxy. On Thursday, January 19, 2017 at 4:02:22 PM UTC+1, Antonio Soldo wrote: > > Hi all > > Is there a reason why is ReviewBoard trying to connect to the > server-54-192-186-70.cdg51.r.cloudfront.net after every change that is > published on review? > I was monitoring my net traffic and noticed this connection and did not > find anything specific why this server would be contacted. In my admin > dashboard I defined that all files are hosted locally. > Also, inspecting web server configuration did not give me any clue. I'm > attaching captured traffic so everybody could see request made to above > mentioned server. > > I'm hosting ReviewBoard locally, and currently running version 2.5.7 on > CentOS 7.3.1611. ReviewBoard is run on Apache web server. > > Thank you in advance > > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
