Re: Lets Encrypt

[Paul Mansfield]

I used the standard apache2 ssl template with the LE files like this:

SSLEngine on
SSLCertificateFile  "/etc/ssl/
example.com/example.com__fullchain.pem"
SSLCertificateKeyFile   "/etc/ssl/
example.com/example.com__privkey.pem"
SSLCipherSuite  HIGH:!aNULL:!MD5

I have a small locked down machine running the LE tools, and also Hashicorp
Vault. This machine has various cron jobs to renew certificates or access
tokens, it can copy them to a Puppet server, and then all my nodes collect
updated https cert and keys and reload their web server when they change.

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/CAMukpcBwE700XnzFcDJFONP5NJmAG6KrdM3cbzHsXJLX1Oiemg%40mail.gmail.com.

Re: Posting a review against multiple repositories.

[Paul Mansfield]

how about having reviews follow the epic/story model... a parent review
with child reviews. Each child review would be associated with individual
repositories, and you then set it so that nothing can be landed until all
related reviews are marked as ship-its?

this might be much easier to achieve in the reviewboard code than reviews
which span repositories?

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/CAMukpcDcj2EWW%2Bv6JdFo57OcxtBuFpk1mr4YQH0mJz5vsQe%3DtQ%40mail.gmail.com.

reviewers idea

[Paul Mansfield]

As previously discusses some teams have a requirement that you get two
ship-its before landing, it would nice if this could be a setting in RB.

It would also be nice if you have a "required reviewers" list so that
something can't be landed without their say-so.

The other reviewers list could then be optional reviewers, or even "FYI".

Would it be possible to allow an admin to change the owner/author of a
review?

thanks

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/CAMukpcAfu7xU4c9rFU_jDFd%2B9yrJDxq2PUTF99zMzawFN4PC7A%40mail.gmail.com.

Re: site migration

[Paul Mansfield]

AIUI, it's all in the database.
https://groups.google.com/g/reviewboard/c/KHjIWCU_YJo

well, apart from people's avatars, so I would back up htdocs/media/


On Tue, 28 Jul 2020 at 17:16, Adam Weremczuk  wrote:

> Hi Paul,
>
> Thanks for the hint, I'll bear it in mind.
>
> What I'm after really is a site migration procedure applicable to my
> environment.
>
> If there is no official documentation in place maybe somebody could at
> least provide a list of steps?
>
> Regards,
> Adam
>
>
> On Tue, 28 Jul 2020 at 17:04, Paul Mansfield <
> paul.mansfi...@agileanalog.com> wrote:
>
>> did you restore your SECRET_KEY?
>>
>> check your reviewboard settings_local.py file
>>
>> mine is in /var/www/reviewboard/conf/settings_local.py because that's the
>> directory for my virtual http server
>>
>> in there you'll find this:
>> # Unique secret key. Don't share this with anybody.
>> SECRET_KEY = 'xxx'
>>
>> you need to make a note/copy of that key from your live RB instance, and
>> if you restore it from a backup, put that key into the new instance.
>>
>>
>>
>>
>> On Tue, 28 Jul 2020 at 15:58, Adam Weremczuk 
>> wrote:
>>
>>> Hi all,
>>>
>>> Today I've attempted a migration from:
>>>
>>> Debian 9.3
>>> Apache 2.4.25
>>> MySQL 5.7.30
>>> ReviewBoard 3.0.17
>>>
>>> to:
>>>
>>> Debian 9.13
>>> Apache 2.4.25
>>> MySQL 5.7.31
>>> ReviewBoard 3.0.18
>>>
>>> Rather small differences and I didn't expect much trouble.
>>>
>>> I started with migrating database (mysqldump) which resulted in the
>>> following error:
>>>
>>>
>>>
>>>
>>> *Something broke! (Error 500)It appears something broke when you tried
>>> to go to here. This is either a bug in Review Board or a server
>>> configuration error. Please report this to your administrator.[Tue Jul 28
>>> 13:05:08.361856 2020] [wsgi:error] [pid 1650:tid 140483573556992] [client
>>> 10.200.20.2:53391 <http://10.200.20.2:53391>] ERROR:root:Could not load
>>> siteconfig: Site matching query does not exist.*
>>>
>>> When I dropped the database and restored the original the error didn't
>>> go away which I found really strange. In order to get a fully functional
>>> vanilla RB 3.0.18 back on the destination I had to restore the entire
>>> container from a pre-db-fiddling backup.
>>>
>>> By looking at the content of mysqldump it doesn't look like db
>>> migration should be necessary anyway. The differences between a vanilla and
>>> data populated dump where down to:
>>>
>>> *ENGINE=InnoDB AUTO_INCREMENT=20 DEFAULT CHARSET=utf8;*
>>>
>>> vs
>>>
>>> *ENGINE=InnoDB DEFAULT CHARSET=utf8;*
>>>
>>> Is it ok to just copy "repository-clones", "data" and "conf" directories
>>> over?
>>>
>>> Is what I'm trying to achieve documented somewhere step by step in
>>> details?
>>>
>>> Please advise.
>>>
>>> Regards,
>>> Adam
>>>
>>> --
>>> Supercharge your Review Board with Power Pack:
>>> https://www.reviewboard.org/powerpack/
>>> Want us to host Review Board for you? Check out RBCommons:
>>> https://rbcommons.com/
>>> Happy user? Let us know! https://www.reviewboard.org/users/
>>> ---
>>> You received this message because you are subscribed to the Google
>>> Groups "Review Board Community" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to reviewboard+unsubscr...@googlegroups.com.
>>> To view this discussion on the web visit
>>> https://groups.google.com/d/msgid/reviewboard/CALC-DAHJf%3DF1nzFF-TwhugqA1Dgj4azZ8F83jLNBofjBZbXFsw%40mail.gmail.com
>>> <https://groups.google.com/d/msgid/reviewboard/CALC-DAHJf%3DF1nzFF-TwhugqA1Dgj4azZ8F83jLNBofjBZbXFsw%40mail.gmail.com?utm_medium=email_source=footer>
>>> .
>>>
>>
>>
>> --
>> P Mansfield, Senior DevOps Engineer, Agile Analog Ltd
>> GPG fingerprint: 8BC9D73EE3D4669C1C138ABD41D5B0C9030D4AE6
>>
>> --
>> Supercharge your Review Board with Power Pack:
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons:
>> https://rbcommons.com/
>> Happy user? Let us know! https

Re: site migration

[Paul Mansfield]

did you restore your SECRET_KEY?

check your reviewboard settings_local.py file

mine is in /var/www/reviewboard/conf/settings_local.py because that's the
directory for my virtual http server

in there you'll find this:
# Unique secret key. Don't share this with anybody.
SECRET_KEY = 'xxx'

you need to make a note/copy of that key from your live RB instance, and if
you restore it from a backup, put that key into the new instance.




On Tue, 28 Jul 2020 at 15:58, Adam Weremczuk  wrote:

> Hi all,
>
> Today I've attempted a migration from:
>
> Debian 9.3
> Apache 2.4.25
> MySQL 5.7.30
> ReviewBoard 3.0.17
>
> to:
>
> Debian 9.13
> Apache 2.4.25
> MySQL 5.7.31
> ReviewBoard 3.0.18
>
> Rather small differences and I didn't expect much trouble.
>
> I started with migrating database (mysqldump) which resulted in the
> following error:
>
>
>
>
> *Something broke! (Error 500)It appears something broke when you tried to
> go to here. This is either a bug in Review Board or a server configuration
> error. Please report this to your administrator.[Tue Jul 28 13:05:08.361856
> 2020] [wsgi:error] [pid 1650:tid 140483573556992] [client 10.200.20.2:53391
> ] ERROR:root:Could not load siteconfig: Site
> matching query does not exist.*
>
> When I dropped the database and restored the original the error didn't go
> away which I found really strange. In order to get a fully functional
> vanilla RB 3.0.18 back on the destination I had to restore the entire
> container from a pre-db-fiddling backup.
>
> By looking at the content of mysqldump it doesn't look like db
> migration should be necessary anyway. The differences between a vanilla and
> data populated dump where down to:
>
> *ENGINE=InnoDB AUTO_INCREMENT=20 DEFAULT CHARSET=utf8;*
>
> vs
>
> *ENGINE=InnoDB DEFAULT CHARSET=utf8;*
>
> Is it ok to just copy "repository-clones", "data" and "conf" directories
> over?
>
> Is what I'm trying to achieve documented somewhere step by step in details?
>
> Please advise.
>
> Regards,
> Adam
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "Review Board Community" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/reviewboard/CALC-DAHJf%3DF1nzFF-TwhugqA1Dgj4azZ8F83jLNBofjBZbXFsw%40mail.gmail.com
> 
> .
>


-- 
P Mansfield, Senior DevOps Engineer, Agile Analog Ltd
GPG fingerprint: 8BC9D73EE3D4669C1C138ABD41D5B0C9030D4AE6

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/CAMukpcDhwVvxF3kXmFF1VnMbW-ud3DDJmAWkuzyHATXHabnS3Q%40mail.gmail.com.

Re: Review Board on Centos 7

[Paul Mansfield]

selinux?

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/CAMukpcDrMV5swmuKoOB9Ni_VAoKUTdOgr6F1QHaoSZPF5UYprQ%40mail.gmail.com.

Re: One of our user not receiving email notifications

[Paul Mansfield]

do you have a local smtp server which relays the email, or are you
directly injecting mail into google's MXers?

if you have a local mail relay, can you check the logs and verify it
is actually completing the email handshake with Google's MXers?

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/CAMukpcDJD3RY%2Bdo7BEhKygE9VVSy5cK-VVFcJ6O3AxBzspJ0tQ%40mail.gmail.com.

Re: LDAP authentication error

[Paul Mansfield]

On Thu, 21 May 2020 at 13:35, Adam Weremczuk  wrote:
> Is my version (3.2.0) known to be problematic and are you suggesting 2.4.15 ?

No, I just wanted to be sure that reviewboard would be able to load
python ldap if it needed it.

if you run "sudo netstat -anp | grep -E '389|636' " and then "tcpdump
port 389 or port 686" can you verify that reviewboard is actually
making a connection to the ldap server?

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/CAMukpcAiWa2EobdaxWasaG_XoH5Ba8Yy2oGq5aDV%2BqZJByNZSA%40mail.gmail.com.

Re: LDAP authentication error

[Paul Mansfield]

On Thu, 21 May 2020 at 11:52, Adam Weremczuk  wrote:
> My LDAP settings:

do you have python (2.x) ldap module installed?

$ pip2 list | egrep ldap
DEPRECATION: Python 2.7 reached the end of its life on January 1st,
2020. Please upgrade your Python as Python 2.7 is no longer
maintained. pip 21.0 will drop support for Python 2.7 in January 2021.
More details about Python 2 support in pip, can be found at
https://pip.pypa.io/en/latest/development/release-process/#python-2-support
python-ldap  2.4.15

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/CAMukpcBh52M_TxbihdKpZD%3D08p44-nF4NLbOBC6PcLV%2BsWqHmw%40mail.gmail.com.

Re: Create likes to award for excellent piece of code or for an excellent review comment

[Paul Mansfield]

how about everybody gets one(?) gold star a day they can award to a
good review or a good file/diff?

On Mon, 18 May 2020 at 04:43, Christian Hammond
 wrote:
>
> I like the idea as well. We've discussed ideas to motivate quality code 
> reviews in the past. I think it's something we'd like to explore in the 
> future.
>
> If there are any ideas in the community on how this might look, please share 
> :)
>
> Christian
>
> On Thu, May 14, 2020 at 4:50 AM Paul Mansfield 
>  wrote:
>>
>> On Wed, 13 May 2020 at 20:26, Dmitriy Matison  wrote:
>> > For the latter I want to award a guy with a like or some sort of a bounty 
>> > badge.
>>
>> I like this idea, Dmitriy is right, a code review can be a daunting
>> thing for someone who's a new coder and can often leave people feeling
>> battered and bruised if they did some complex work which needed
>> refinement!
>>
>> --
>> Supercharge your Review Board with Power Pack: 
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons: 
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> ---
>> You received this message because you are subscribed to the Google Groups 
>> "Review Board Community" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to reviewboard+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/reviewboard/CAMukpcBDETvgbqHz_NdNftY4xFJT%3DSnKjZTyAMUTxthufZ1Vug%40mail.gmail.com.
>
>
>
> --
> Christian Hammond
> President/CEO of Beanbag
> Makers of Review Board
>
> --
> Supercharge your Review Board with Power Pack: 
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons: 
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups 
> "Review Board Community" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to reviewboard+unsubscr...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/reviewboard/CAE7VndnqHwsFGL5657vnWKQ69U%3DNCfiFKna4XWOqK95a_zbc4g%40mail.gmail.com.



-- 
P Mansfield, Senior DevOps Engineer, Agile Analog Ltd
GPG fingerprint: 8BC9D73EE3D4669C1C138ABD41D5B0C9030D4AE6

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/CAMukpcBsW%3DYShApDwCm86Furo5ZEiNY%2BfUxPRa%3DdDEDuRrH2Lw%40mail.gmail.com.

Re: RBTools Ticket #4871: Unable to rbt post when using subversion after renaming a file

[Paul Fee]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4871/
--

New update by pfee
For Beanbag, Inc. > RBTools > Ticket #4871


Reply:

Markdown has adjust some of the above text, hopefully the content and patch 
are still readable.  Shame splat has no button to disable markdown like 
ReviewBoard has.

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard-issues/20200515153634.3562.90160%40ip-10-1-54-209.ec2.internal.

RBTools Ticket #4871: Unable to rbt post when using subversion after renaming a file

[Paul Fee]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4871/
--

New ticket #4871 by pfee
For Beanbag, Inc. > RBTools

Status: New
Tags: Priority:Medium, Type:Defect


--
Unable to rbt post when using subversion after renaming a file
==

# What version are you running?
OpenSUSE Tumbleweed (w/updates as of 15 May 2020)
SVN 1.13.0
Python 3.8.2
RBTools 1.0.2

# What steps will reproduce the problem?
1. Make changes in an SVN sandbox, including renaming a file with "svn mv".
2. Post the changes for review using "rbt post -d --svn-show-copies-as-adds=n"
3. Posting fails due to python exception

# What is the expected output? What do you see instead?
Expect "Review request #xyz posted."

Instead see Python exception and stacktrace:


>>> Running: svn --non-interactive diff --diff-cmd=diff --notice-ancestry -r 
>>> BASE --no-diff-deleted
Traceback (most recent call last):
  File "/usr/bin/rbt", line 11, in 
load_entry_point('RBTools==1.0.2', 'console_scripts', 'rbt')()
  File "/usr/lib/python3.8/site-packages/rbtools/commands/main.py", line 120, 
in main
command.run_from_argv([RB_MAIN, command_name] + args)
  File "/usr/lib/python3.8/site-packages/rbtools/commands/__init__.py", line 
725, in run_from_argv
exit_code = self.main(*args) or 0
  File "/usr/lib/python3.8/site-packages/rbtools/commands/post.py", line 802, 
in main
diff_info = self.tool.diff(
  File "/usr/lib/python3.8/site-packages/rbtools/clients/svn.py", line 517, in 
diff
diff = self._handle_empty_files(diff, diff_cmd,
  File "/usr/lib/python3.8/site-packages/rbtools/clients/svn.py", line 789, in 
_handle_empty_files
result.append(b'--- %s\t%s\n' % (filename.encode(_fs_encoding),
AttributeError: 'bytes' object has no attribute 'encode'

# What operating system are you using?
Linux, openSUSE Tumbleweed.  Distro packaged versions of RBTools, python3 and 
subversion.


# Please provide any additional information below.
Debugged this using python debugger: python3 -m pdb /usr/bin/rbt post -d 
--svn-show-copies-as-adds=n

(Pdb) b /usr/lib/python3.8/site-packages/rbtools/clients/svn.py:789

Relevant code:
 788 result.append(b'%s\n' % self.INDEX_SEP)
 789 result.append(b'--- %s\t%s\n' % 
(filename.encode(_fs_encoding),
 790  base.encode('utf-8')))
 791 result.append(b'+++ %s\t%s\n' % 
(filename.encode(_fs_encoding),
 792  tip.encode('utf-8')))

The "filename" variable is of type "bytes", rather than "str", hence doesn't 
have a .encode() method.

Removing this .encode() call allowed the "rbt post" to work as expected.  The 
contents of filename comes from the "diff_content", so I suspect it will always 
by of type "bytes", though I haven't tested the fix below extensively.

PATCH
=

$ diff -u /usr/lib/python3.8/site-packages/rbtools/clients/svn.py.orig 
/usr/lib/python3.8/site-packages/rbtools/clients/svn.py
--- /usr/lib/python3.8/site-packages/rbtools/clients/svn.py.orig
2020-05-15 16:10:03.876230238 +0100
+++ /usr/lib/python3.8/site-packages/rbtools/clients/svn.py 2020-05-15 
16:12:36.331769935 +0100
@@ -786,9 +786,9 @@
 tip = revisions['tip']
 
 result.append(b'%s\n' % self.INDEX_SEP)
-result.append(b'--- %s\t%s\n' % (filename.encode(_fs_encoding),
+result.append(b'--- %s\t%s\n' % (filename,
  base.encode('utf-8')))
-result.append(b'+++ %s\t%s\n' % (filename.encode(_fs_encoding),
+result.append(b'+++ %s\t%s\n' % (filename,
  tip.encode('utf-8')))
 
 # Skip the next line (the index separator) since we've already

--

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard-issues/20200515153315.3567.78514%40ip-10-1-54-209.ec2.internal.

Re: Create likes to award for excellent piece of code or for an excellent review comment

[Paul Mansfield]

On Wed, 13 May 2020 at 20:26, Dmitriy Matison  wrote:
> For the latter I want to award a guy with a like or some sort of a bounty 
> badge.

I like this idea, Dmitriy is right, a code review can be a daunting
thing for someone who's a new coder and can often leave people feeling
battered and bruised if they did some complex work which needed
refinement!

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/CAMukpcBDETvgbqHz_NdNftY4xFJT%3DSnKjZTyAMUTxthufZ1Vug%40mail.gmail.com.

Re: RBTools Ticket #4728: Git svn : diff can't be generated because of badly formatted call to git rev-list

[Paul Smith]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4728/
--

New update by KG
For Beanbag, Inc. > RBTools > Ticket #4728


Reply:

Is anyone still working on this?  Hitting this with an oldish codebase 
after and accidental update.  Happy to provide version info if someone tells me 
the precise commands I need to type.  I'm a programmer but I don't delve into 
the inners of git-svn ;-).

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard-issues/20200318171004.26230.83967%40ip-10-1-54-209.ec2.internal.

Re: Restrict Submitter

[Paul Mansfield]

as a thought. is it possible with RB to disallow the person submitting the 
review from being able to Ship-It?
also, is it possible to make RB block the landing a review without two 
ship-it's from two different people?

this would help enforce good practises, many orgs including ours require 
two ship-its for merging to master.

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/33cfd45e-93a0-4d35-b478-79eda0ceeb83%40googlegroups.com.

500 error when trying to download a CSV report "code review relationships" for everybody

[Paul Mansfield]

I clicked on the Reports link in the top navigation


and then selected code review relationships and selected everyone.


I then clicked on the Download CSV link on the right hand side and got 
Something broke! (Error 500)

It appears something broke when you tried to go to here. This is either a 
bug in Review Board or a server configuration error. Please report this to 
your administrator.



going directly to this link also reproduces the error:

https://rb.example.com/reports/review-relationships/data/?users===2019-10-27=2019-11-02=true=1
 




when I do this, I see the following error in the log:


2019-11-26 17:04:49,963 - ERROR - None - paulm - 
/reports/review-relationships/data/ - djblets.log.middleware - Exception 
thrown for user paulm at 
https://rb.example.com/reports/review-relationships/data/?users===2019-10-27=2019-11-02=true=1


1L

Traceback (most recent call last):

  File "/usr/lib/python2.7/site-packages/django/core/handlers/base.py", 
line 112, in get_response

response = wrapped_callback(request, *callback_args, **callback_kwargs)

  File 
"/usr/lib/python2.7/site-packages/reviewboard/accounts/decorators.py", line 
29, in _check

return login_required(view_func)(*args, **kwargs)

  File 
"/usr/lib/python2.7/site-packages/django/contrib/auth/decorators.py", line 
22, in _wrapped_view

return view_func(request, *args, **kwargs)

  File "/usr/lib/python2.7/site-packages/reviewboard/site/decorators.py", 
line 36, in _check

return view_func(request, local_site=local_site, *args, **kwargs)

  File "/rbpowerpack/reports/decorators.py", line 29, in _check

  File "/rbpowerpack/reports/views.py", line 58, in report_data

  File "/rbpowerpack/reports/reports.py", line 1188, in get_csv

KeyError: 1L



if I manually select people and DONT choose everyone, then it works fine


-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/bc65422c-bc1f-4399-8a75-be34619009a1%40googlegroups.com.

Re: API call to search for all reviews where branch is a specific value

[Paul Mansfield]

for searching the description and testing fields, a simple free text 
database like namazu would probably be a better way than using SQL to scan 
text fields.

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/e6fc11cf-cfc1-4372-b33a-28d3c7931362%40googlegroups.com.

Re: API call to search for all reviews where branch is a specific value

[Paul Mansfield]

Ideally any field in a review request should be useable as a filter, but I 
accept that the demands of indexing would be a problem.



On Wednesday, 23 October 2019 08:11:25 UTC+1, Christian Hammond wrote:
>
> So there's a challenge with this that I hadn't considered before.
>
> We don't automatically create an index for the branch field. While we 
> could push an update that adds one, this can impact upgrades to 3.0.16, 
> potentially taking a substantially long time to complete. We try to avoid 
> this for point releases, so I'd feel a lot more comfortable adding this 
> index in 4.0, where we're already performing modifications to the database 
> schema.
>
> We could still add the query argument in 3.0.16, but performance wouldn't 
> be ideal without manually adding an index (which may then need to be 
> manually removed when 4.0 is out). So unfortunately, not as clear-cut as I 
> was hoping.
>
> Going to need to ponder this...
>
> Christian
>
> On Tue, Oct 22, 2019 at 11:14 PM Christian Hammond  > wrote:
>
>> Hi Paul,
>>
>> Hmm, I thought we had this as part of the API. I'll add that for 3.0.16. 
>> We're aiming for an early-November release, trying to wrap up some work 
>> before we get that release ready, but it'll probably be the 5th or the 12th.
>>
>> If need-be, extensions can always provide custom API to fill in the gaps 
>> that we're missing, if it's blocking you on something and you can't wait 
>> until the next release.
>>
>> Christian
>>
>> On Mon, Oct 21, 2019 at 3:04 AM Paul Mansfield > > wrote:
>>
>>> Hi,
>>> imagine I have some reviews done on a feature branch called 
>>> "SCRATCH-123", and I want to search for them using the API.
>>>
>>> is this possible?
>>>
>>> reading the documents at 
>>> https://www.reviewboard.org/docs/manual/3.0/webapi/ and
>>>
>>> https://www.reviewboard.org/docs/manual/3.0/webapi/2.0/resources/review-request-list/
>>>
>>> suggests there isn't that ability, it doesn't seem to be possible filter 
>>> on the branch? then I would have to get a list of all review requests on a 
>>> repository and then iterate and filter myself?
>>>
>>> thanks
>>> Paul
>>>
>>> -- 
>>> Supercharge your Review Board with Power Pack: 
>>> https://www.reviewboard.org/powerpack/
>>> Want us to host Review Board for you? Check out RBCommons: 
>>> https://rbcommons.com/
>>> Happy user? Let us know! https://www.reviewboard.org/users/
>>> --- 
>>> You received this message because you are subscribed to the Google 
>>> Groups "Review Board Community" group.
>>> To unsubscribe from this group and stop receiving emails from it, send 
>>> an email to revie...@googlegroups.com .
>>> To view this discussion on the web visit 
>>> https://groups.google.com/d/msgid/reviewboard/3b47b04e-3feb-4bec-9e84-ee749b00150d%40googlegroups.com
>>>  
>>> <https://groups.google.com/d/msgid/reviewboard/3b47b04e-3feb-4bec-9e84-ee749b00150d%40googlegroups.com?utm_medium=email_source=footer>
>>> .
>>>
>>
>>
>> -- 
>> Christian Hammond
>> President/CEO of Beanbag <https://www.beanbaginc.com/>
>> Makers of Review Board <https://www.reviewboard.org/>
>>
>
>
> -- 
> Christian Hammond
> President/CEO of Beanbag <https://www.beanbaginc.com/>
> Makers of Review Board <https://www.reviewboard.org/>
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/d10fb256-cbfb-4a93-977f-400c32ea6fc0%40googlegroups.com.

API call to search for all reviews where branch is a specific value

[Paul Mansfield]

Hi,
imagine I have some reviews done on a feature branch called "SCRATCH-123", 
and I want to search for them using the API.

is this possible?

reading the documents at https://www.reviewboard.org/docs/manual/3.0/webapi/
 and
https://www.reviewboard.org/docs/manual/3.0/webapi/2.0/resources/review-request-list/

suggests there isn't that ability, it doesn't seem to be possible filter on 
the branch? then I would have to get a list of all review requests on a 
repository and then iterate and filter myself?

thanks
Paul

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/3b47b04e-3feb-4bec-9e84-ee749b00150d%40googlegroups.com.

Re: pkg_resources.DistributionNotFound error while testing rbt

[Paul Mansfield]

IME, you're better off using pip to install it

check whether pip has it installed:
$ sudo pip list | grep -i rbt
RBTools   1.0.2 

then
$ sudo pip install RBTools


-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/89d4ba12-5b41-47ea-b925-57e917366cf5%40googlegroups.com.

Re: LDAP Configuration

[Paul Mansfield]

yes please, I had to use this flag: authlogin_nsswitch_use_ldap
I already had the other flags in my deployment scripts in puppet.

On Tuesday, 8 October 2019 11:54:38 UTC+1, Stephen Gallagher wrote:
>
>
>
> On Tue, Oct 8, 2019 at 6:35 AM Paul Mansfield  > wrote:
>
>> I found the problem. facepalm. I should have guessed. damn selinux.
>>
>> I found it because I realised that the avatars weren't working as after 
>> fixing the directory permissions under .../htdocs/media they still didn't 
>> work, so I did a "setenforce permissive" and then discovered that, ldap 
>> login worked too.
>>
>
> Do the SELinux instructions I added to 
>
> https://www.reviewboard.org/docs/manual/dev/admin/installation/creating-sites/
>  
> need updating?
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/32db415b-513e-4d6f-813e-e8c9f0e5018c%40googlegroups.com.

Re: LDAP Configuration

[Paul Mansfield]

BTW, the secret magic command is

sudo setsebool -P authlogin_nsswitch_use_ldap=1


-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/49c6fefd-60da-41e7-b816-7f5effb62242%40googlegroups.com.

Re: LDAP Configuration

[Paul Mansfield]

I found the problem. facepalm. I should have guessed. damn selinux.

I found it because I realised that the avatars weren't working as after 
fixing the directory permissions under .../htdocs/media they still didn't 
work, so I did a "setenforce permissive" and then discovered that, ldap 
login worked too.

Also, avatars were broken because the original reviewboard install was at 
rb.example.com and the restored one at rb2.example.com an I hadn't changed 
the URL in the General Settings. When I looked at the html source, the URL 
was fully qualified with the domain 
(https://rb.example.com/media/...blahblah) rather than being a relative 
URI. When I changed the general settings, the HTML reference also changed 
of course and avatars started working again.

So I guess the local avatar thing is probably a bug since it shouldn't 
really need to depend on a full URL unless that's a function of the way 
it's done in order to work with multiple avatar services.


-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/bbe0cf70-f9ea-4b09-a7a4-db3e0947d50a%40googlegroups.com.

Re: LDAP Configuration

[Paul Mansfield]

Hi,
thanks for coming back to me.

I don't see any outbound packets to the ldap server on the new reviewboard 
server, but I do on the old one - I am looking for any outbound traffic to 
the ldap server, or, any traffic to tcp:389

If I compare the ldap settings page on both servers, they look identical, 
so I am wondering if there's another configuration file I need to tweak.

thanks
Paul

 - 
On Tuesday, 1 October 2019 19:32:00 UTC+1, Christian Hammond wrote:
>
> Hi Paul,
>
> Does the LDAP server restrict access by IP address?
>
> Christian
>
> On Thu, Sep 26, 2019 at 8:22 AM Paul Mansfield  > wrote:
>
>>
>> I was testing my reviewboard backups are good, so I restored from the 
>> mysqldump, and copied over the saved settings_local.py
>>
>> I can login as the admin user, and the ldap settings are the same as the 
>> live server, but I can't login using ldap, and I get this error in the log:
>>
>> [Thu Sep 26 14:20:40.644378 2019] [:error] [pid 25293] 2019-09-26 
>> 14:20:40,644 - WARNING -  - root - Error authenticating with LDAP: {'desc': 
>> "Can't contact LDAP server"}
>>
>>
>> if I run tcpdump on the live server, I see a connection to the ldap 
>> server, but nothing is seen on the new standby server.
>>
>> On the new machine, I can ping the FQDN (ldap.example.com) as well as 
>> just "ldap", so that means DNS is fine, as is the domain search list in 
>> /etc/resolv.conf
>>
>> I checked that python-ldap package is installed on both, as is openldap 
>> package. Nothing obvious different when I run "pip list" on both.
>>
>> I am not sure how to go further with diagnosing the problem and what is 
>> broken, any ideas gratefully received,
>>
>> thanks
>>
>> Paul
>>
>> -- 
>> Supercharge your Review Board with Power Pack: 
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons: 
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "Review Board Community" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to revie...@googlegroups.com .
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/reviewboard/0ff5c79f-7056-482a-8fd7-debbec676a8e%40googlegroups.com
>>  
>> <https://groups.google.com/d/msgid/reviewboard/0ff5c79f-7056-482a-8fd7-debbec676a8e%40googlegroups.com?utm_medium=email_source=footer>
>> .
>>
>
>
> -- 
> Christian Hammond
> President/CEO of Beanbag <https://www.beanbaginc.com/>
> Makers of Review Board <https://www.reviewboard.org/>
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/7fc40899-7fb3-4961-be28-d162b7e6d83e%40googlegroups.com.

Re: LDAP Configuration

[Paul Mansfield]

I was testing my reviewboard backups are good, so I restored from the 
mysqldump, and copied over the saved settings_local.py

I can login as the admin user, and the ldap settings are the same as the 
live server, but I can't login using ldap, and I get this error in the log:

[Thu Sep 26 14:20:40.644378 2019] [:error] [pid 25293] 2019-09-26 
14:20:40,644 - WARNING -  - root - Error authenticating with LDAP: {'desc': 
"Can't contact LDAP server"}


if I run tcpdump on the live server, I see a connection to the ldap server, 
but nothing is seen on the new standby server.

On the new machine, I can ping the FQDN (ldap.example.com) as well as just 
"ldap", so that means DNS is fine, as is the domain search list in 
/etc/resolv.conf

I checked that python-ldap package is installed on both, as is openldap 
package. Nothing obvious different when I run "pip list" on both.

I am not sure how to go further with diagnosing the problem and what is 
broken, any ideas gratefully received,

thanks

Paul

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/0ff5c79f-7056-482a-8fd7-debbec676a8e%40googlegroups.com.

Re: The file was not found in the repository. (HTTP 400, API Error 207)

[Paul Mansfield]

I think my problems are compounded because we're using centos7 and we have 
a lot of python3 packages "retrofitted" so it is very easy to get into a 
mess between pip2 and pip3 packages.

Now we've bought into reviewboard, as part of a backup/restore disaster 
recovery test, I will build a new reviewboard server which can be 
independent from other things and thus not get snarled up with packages 
installed for the other services :-(

In the long run when reviewboard runs on python3, then things will get 
simpler ;-)
thanks very much for your time,
Paul


On Tuesday, 24 September 2019 21:04:27 UTC+1, Christian Hammond wrote:
>
> Hi Paul,
>
> Strange.. that does sound like a Python version dependency conflict. 
> Unfortunately, Python’s design here has some less-than-ideal qualities. If 
> *any* dependency conflicts, all things registered through the Python 
> Entrypoint plugin system (extensions, repository types) will fail to load. 
> We have some bullet-proofing we need to do here to stop crashes and just 
> throw a big error up on the page, but we can’t work around the core design 
> issue in Python to the extent we’d like.
>
> You probably didn’t need to regenerate the access key, but it never hurts.
>
> Christian
>
>
> On Tue, Sep 24, 2019 at 09:01 Paul Mansfield  > wrote:
>
>> it appears that somehow the pip installation of 
>> aws/awscli/boto/boto3/botocore was all fouled up... I removed them all and 
>> reinstalled them.
>>
>> along the way I also regenerated the access key for codecommit access, 
>> I'm not sure whether that was actually required or not.
>>
>> so it seems to be working again.
>>
>> -- 
>> Supercharge your Review Board with Power Pack: 
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons: 
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "Review Board Community" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to revie...@googlegroups.com .
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/reviewboard/3c22cdb0-e1cc-4ee6-baac-77317945b4a2%40googlegroups.com
>>  
>> <https://groups.google.com/d/msgid/reviewboard/3c22cdb0-e1cc-4ee6-baac-77317945b4a2%40googlegroups.com?utm_medium=email_source=footer>
>> .
>>
> -- 
> -- 
> Christian Hammond
> President/CEO of Beanbag
> Makers of Review Board
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/af21612b-c6cc-4e50-86f1-f9e8e3d3c86b%40googlegroups.com.

Re: The file was not found in the repository. (HTTP 400, API Error 207)

[Paul Mansfield]

it appears that somehow the pip installation of 
aws/awscli/boto/boto3/botocore was all fouled up... I removed them all and 
reinstalled them.

along the way I also regenerated the access key for codecommit access, I'm 
not sure whether that was actually required or not.

so it seems to be working again.

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/3c22cdb0-e1cc-4ee6-baac-77317945b4a2%40googlegroups.com.

Re: The file was not found in the repository. (HTTP 400, API Error 207)

[Paul Mansfield]

and I see this in the http error log

[Tue Sep 24 14:57:09.362504 2019] [:error] [pid 29304] 'NoneType' object 
has no attribute 'plans'
[Tue Sep 24 14:57:09.362508 2019] [:error] [pid 29304] Traceback (most 
recent call last):
[Tue Sep 24 14:57:09.362511 2019] [:error] [pid 29304]   File 
"/usr/lib/python2.7/site-packages/django/core/handlers/base.py", line 112, 
in get_response
[Tue Sep 24 14:57:09.362514 2019] [:error] [pid 29304] response = 
wrapped_callback(request, *callback_args, **callback_kwargs)
[Tue Sep 24 14:57:09.362517 2019] [:error] [pid 29304]   File 
"/usr/lib/python2.7/site-packages/django/contrib/admin/options.py", line 
465, in wrapper
[Tue Sep 24 14:57:09.362521 2019] [:error] [pid 29304] return 
self.admin_site.admin_view(view)(*args, **kwargs)
[Tue Sep 24 14:57:09.362523 2019] [:error] [pid 29304]   File 
"/usr/lib/python2.7/site-packages/django/utils/decorators.py", line 99, in 
_wrapped_view
[Tue Sep 24 14:57:09.362549 2019] [:error] [pid 29304] response = 
view_func(request, *args, **kwargs)
[Tue Sep 24 14:57:09.362553 2019] [:error] [pid 29304]   File 
"/usr/lib/python2.7/site-packages/django/views/decorators/cache.py", line 
52, in _wrapped_view_func
[Tue Sep 24 14:57:09.362556 2019] [:error] [pid 29304] response = 
view_func(request, *args, **kwargs)
[Tue Sep 24 14:57:09.362558 2019] [:error] [pid 29304]   File 
"/usr/lib/python2.7/site-packages/django/contrib/admin/sites.py", line 198, 
in inner
[Tue Sep 24 14:57:09.362561 2019] [:error] [pid 29304] return 
view(request, *args, **kwargs)
[Tue Sep 24 14:57:09.362564 2019] [:error] [pid 29304]   File 
"/usr/lib/python2.7/site-packages/django/utils/decorators.py", line 29, in 
_wrapper
[Tue Sep 24 14:57:09.362567 2019] [:error] [pid 29304] return 
bound_func(*args, **kwargs)
[Tue Sep 24 14:57:09.362569 2019] [:error] [pid 29304]   File 
"/usr/lib/python2.7/site-packages/django/utils/decorators.py", line 99, in 
_wrapped_view
[Tue Sep 24 14:57:09.362572 2019] [:error] [pid 29304] response = 
view_func(request, *args, **kwargs)
[Tue Sep 24 14:57:09.362575 2019] [:error] [pid 29304]   File 
"/usr/lib/python2.7/site-packages/django/utils/decorators.py", line 25, in 
bound_func
[Tue Sep 24 14:57:09.362578 2019] [:error] [pid 29304] return 
func(self, *args2, **kwargs2)
[Tue Sep 24 14:57:09.362580 2019] [:error] [pid 29304]   File 
"/usr/lib/python2.7/site-packages/django/db/transaction.py", line 371, in 
inner
[Tue Sep 24 14:57:09.362583 2019] [:error] [pid 29304] return 
func(*args, **kwargs)
[Tue Sep 24 14:57:09.362586 2019] [:error] [pid 29304]   File 
"/usr/lib/python2.7/site-packages/django/contrib/admin/options.py", line 
1270, in change_view
[Tue Sep 24 14:57:09.362589 2019] [:error] [pid 29304] form = 
ModelForm(instance=obj)
[Tue Sep 24 14:57:09.362591 2019] [:error] [pid 29304]   File 
"/usr/lib/python2.7/site-packages/reviewboard/scmtools/forms.py", line 445, 
in __init__
[Tue Sep 24 14:57:09.362594 2019] [:error] [pid 29304]
 self._populate_hosting_service_fields()
[Tue Sep 24 14:57:09.362597 2019] [:error] [pid 29304]   File 
"/usr/lib/python2.7/site-packages/reviewboard/scmtools/forms.py", line 598, 
in _populate_hosting_service_fields
[Tue Sep 24 14:57:09.362603 2019] [:error] [pid 29304] if service.plans:
[Tue Sep 24 14:57:09.362701 2019] [:error] [pid 29304] AttributeError: 
'NoneType' object has no attribute 'plans'

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/dec226f1-e3b2-4264-9283-5421114e6058%40googlegroups.com.

Re: The file was not found in the repository. (HTTP 400, API Error 207)

[Paul Mansfield]

if I try and look at the repo settings in our RB server

https://rb/admin/db/scmtools/repository/5/?_changelist_filters=q%3Dpuppet 


then I see this:

Something broke! (Error 500)

It appears something broke when you tried to go to here. This is either a 
bug in Review Board or a server configuration error. Please report this to 
your administrator.

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/e7f4d35d-6e81-4031-a90b-abefca827782%40googlegroups.com.

The file was not found in the repository. (HTTP 400, API Error 207)

[Paul Mansfield]

Hi,
We do post-commit reviews in feature branches. We are using AWS CodeCommit 
as a git server and have PowerPack licences for it.

I am trying to submit a review from a branch called DEVOPS-74b. I made a 
change, did a git add/commit/push to the branch. I know that the supposedly 
non-existent file is there because if I go to a different workspace and do 
a git clone and checkout the branch, the file exists and my modification is 
in the branch.

The point of branching was commit bd429081243c6fade75b675e74763dc6942578a1, 
so I tell RBT to use that as the initial point for the diff. If I run the 
"git -c" command that rbt prints then I see a perfectly normal git diff, 
nothing unusual, so it looks as if the call to the RB api is breaking.


$ rbt post --debug --branch DEVOPS-74b 
bd429081243c6fade75b675e74763dc6942578a1..DEVOPS-74b"
>>> RBTools 1.0.2
>>> Python 3.6.7 (default, Dec  5 2018, 15:01:38) 
[GCC 4.8.5 20150623 (Red Hat 4.8.5-28)]
>>> Running on 
Linux-3.10.0-957.27.2.el7.x86_64-x86_64-with-centos-7.6.1810-Core
>>> Home = /users/paulm
>>> Current directory = /users/paulm/codecommit/DevOps-puppet
>>> Command line: rbt post --debug --branch DEVOPS-74b 
bd429081243c6fade75b675e74763dc6942578a1..DEVOPS-74b
>>> Running: tf vc help
>>> Checking for a Git repository...
>>> Running: git rev-parse --git-dir
>>> Running: git config core.bare
>>> Running: git rev-parse --show-toplevel
>>> Running: git symbolic-ref -q HEAD
>>> Running: git config --get branch.DEVOPS-74b.merge
>>> Running: git config --get branch.DEVOPS-74b.remote
>>> Running: git config --get remote.origin.url
>>> Repository info: Path: 
ssh://git-codecommit.eu-west-1.amazonaws.com/v1/repos/DevOps-puppet, Base 
path: , Supports changesets: False
>>> Making HTTP GET request to https://rb/api/
>>> Running: git rev-parse 
bd429081243c6fade75b675e74763dc6942578a1..DEVOPS-74b
>>> Running: git config --get branch.DEVOPS-74b.merge
>>> Running: git config --get branch.DEVOPS-74b.remote
>>> Running: git branch --remotes
>>> Running: git rev-list bd429081243c6fade75b675e74763dc6942578a1 --not 
--remotes=origin
>>> Running: git version
>>> Running: git -c core.quotepath=false -c diff.noprefix=false diff 
--no-color --full-index --ignore-submodules -M --no-ext-diff 
bd429081243c6fade75b675e74763dc6942578a1..d8609c47e90ffed2eb7aba5b2968285d79bf1339
>>> Generated diff size: 2104 bytes
>>> Making HTTP GET request to https://rb/api/validation/diffs/
>>> Cached response for HTTP GET https://rb/api/validation/diffs/ expired 
and was modified
>>> Making HTTP POST request to https://rb/api/validation/diffs/
>>> Got API Error 207 (HTTP code 400): The file was not found in the 
repository.
>>> Error data: {'stat': 'fail', 'err': {'msg': 'The file was not found in 
the repository.', 'code': 207}, 'file': 
'environments/production/modules/aa_workstation/manifests/init.pp', 
'revision': '995404bf2e7bf24149269baa4ab9d3bea31b16d2'}
Traceback (most recent call last):
  File "/usr/lib/python3.6/site-packages/rbtools/api/request.py", line 685, 
in make_request
request.url, body, headers, request.method))
  File "/usr/lib/python3.6/site-packages/rbtools/api/cache.py", line 209, 
in make_request
return self.urlopen(request)
  File "/usr/lib64/python3.6/urllib/request.py", line 223, in urlopen
return opener.open(url, data, timeout)
  File "/usr/lib64/python3.6/urllib/request.py", line 532, in open
response = meth(req, response)
  File "/usr/lib/python3.6/site-packages/rbtools/api/request.py", line 240, 
in http_response
response.info())
  File "/usr/lib64/python3.6/urllib/request.py", line 570, in error
return self._call_chain(*args)
  File "/usr/lib64/python3.6/urllib/request.py", line 504, in _call_chain
result = func(*args)
  File "/usr/lib64/python3.6/urllib/request.py", line 650, in 
http_error_default
raise HTTPError(req.full_url, code, msg, hdrs, fp)
urllib.error.HTTPError: HTTP Error 400: BAD REQUEST

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/lib/python3.6/site-packages/rbtools/commands/post.py", line 
867, in main
**validate_kwargs)
  File "/usr/lib/python3.6/site-packages/rbtools/api/decorators.py", line 
27, in request_method
*args, **kwargs)
  File "/usr/lib/python3.6/site-packages/rbtools/api/transport/sync.py", 
line 77, in execute_request_method
return self._execute_request(request)
  File "/usr/lib/python3.6/site-packages/rbtools/api/transport/sync.py", 
line 86, in _execute_request
rsp = self.server.make_request(request)
  File "/usr/lib/python3.6/site-packages/rbtools/api/request.py", line 687, 
in make_request
self.process_error(e.code, e.read())
  File "/usr/lib/python3.6/site-packages/rbtools/api/request.py", line 661, 
in process_error
rsp['err']['msg'])
rbtools.api.errors.BadRequestError: The file was not found in the 
repository. (HTTP 400, API Error 207)

During handling of the above exception, another exception 

Re: database backup and restore

[Paul Mansfield]

Might I suggest a specific section be added to the admin guide explaining 
how to backup and restore a reviewboard installation?
there's no mention of it here
https://www.reviewboard.org/docs/manual/3.0/admin/
if you're restoring a broken system, do you simply install the same version 
you had, and then restore the database?

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/ed34b76d-6be3-4bc0-b286-c32d3e5c3009%40googlegroups.com.

Re: Review Board Ticket #4839: Absolute date support

[Paul Mansfield]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4839/
--

New update by PGuehring
For Beanbag, Inc. > Review Board > Ticket #4839


Reply:

I would prefer to see it the other way round. Show the absolute date and if 
you hover the mouse, it would show the age.

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard-issues/20190819085650.2895.90103%40ip-10-1-54-209.ec2.internal.

Re: Weird authentication issue - username + password not working with RBT

[Paul Mansfield]

just a thought, but do your users have complex passwords with interesting 
punctuation? are they using single or double quotes when providing 
usernames/passwords and require complex escaping of punctuation?



>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/fa6ac324-a504-486e-89f1-310db3a7a5b6%40googlegroups.com.

Re: rbtools.commands.CommandError: Error validating diff 'ascii' codec can't decode byte 0xc2 in position 1333: ordinal not in range(128) (HTTP 400, API Error 224)

[Paul Mansfield]

ok, this fix didn't break anything and I was able to submit a review on the 
feature branch which previously caused the codec error.

thanks

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/f0f6c33d-055d-4389-aad0-9f337f20eb17%40googlegroups.com.

Re: rbtools.commands.CommandError: Error validating diff 'ascii' codec can't decode byte 0xc2 in position 1333: ordinal not in range(128) (HTTP 400, API Error 224)

[Paul Mansfield]

oh, wait... somehow pip got aliassed to pip3. now I've rerun without that, 
it worked.

apologies for the distraction


On Monday, 22 July 2019 12:21:48 UTC+1, Paul Mansfield wrote:
>
> thanks for that
>
> I think I am doing something wrong
>
> $ sudo pip install 
> ReviewBoardPowerPack-3.0.3a0.dev20190701141953-cp27-none-any.whl ERROR: 
> ReviewBoardPowerPack-3.0.3a0.dev20190701141953-cp27-none-any.whl is not a 
> supported wheel on this platform.
>
>
>
>
>
> and yet,,,
>>
>>
> $ wheel unpack 
> ReviewBoardPowerPack-3.0.3a0.dev20190701141953-cp27-none-any.whl 
> Unpacking to: ./ReviewBoardPowerPack-3.0.3a0.dev20190701141953...OK
>
>
>
> /paul is puzzled.
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/07398a29-315a-455c-aef2-8139f83a0eed%40googlegroups.com.

Re: rbtools.commands.CommandError: Error validating diff 'ascii' codec can't decode byte 0xc2 in position 1333: ordinal not in range(128) (HTTP 400, API Error 224)

[Paul Mansfield]

thanks for that

I think I am doing something wrong

$ sudo pip install 
ReviewBoardPowerPack-3.0.3a0.dev20190701141953-cp27-none-any.whl ERROR: 
ReviewBoardPowerPack-3.0.3a0.dev20190701141953-cp27-none-any.whl is not a 
supported wheel on this platform.





and yet,,,
>
>
$ wheel unpack 
ReviewBoardPowerPack-3.0.3a0.dev20190701141953-cp27-none-any.whl 
Unpacking to: ./ReviewBoardPowerPack-3.0.3a0.dev20190701141953...OK



/paul is puzzled.

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/786e3790-ad80-4941-9436-336bf3894ed7%40googlegroups.com.

Re: Upgrading RB v2.5.6.1 to v3.0.15

[Paul Mansfield]

AFAIK, you simply need to upgrade to the highest version of 2.5, and then 
upgrade to 3.x

Do it on a backup copy of your production server

https://www.reviewboard.org/news/2017/11/21/its-here-review-board-3-0-is-here/

https://www.reviewboard.org/docs/releasenotes/reviewboard/3.0/


-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/133aba5f-ad81-44bc-819b-63395d1d2a23%40googlegroups.com.

rbtools.commands.CommandError: Error validating diff 'ascii' codec can't decode byte 0xc2 in position 1333: ordinal not in range(128) (HTTP 400, API Error 224)

[Paul Mansfield]

We've been using reviewboard for a few months now. The server is 3.0.15 on 
CentOS7, as is the client.

I am using python 3.6.8 from the IUS repository.

This is the first time I've encountered this error, trying to submit a 
post-commit review on a feature branch before it gets merged into master.

I've seen similar codec related reported but none quite the same as this.
 

$ rbt post --debug --bugs-closed DEVOPS-163 --branch DEVOPS-163 
master..DEVOPS-163
>>> RBTools 1.0.2
>>> Python 3.6.8 (default, May  2 2019, 20:40:44) 
[GCC 4.8.5 20150623 (Red Hat 4.8.5-36)]
>>> Running on 
Linux-3.10.0-957.21.2.el7.x86_64-x86_64-with-centos-7.6.1810-Core
>>> Home = /users/paulm
>>> Current directory = /users/paulm/codecommit/ADS-CICD-infrastructure/ci
>>> Command line: rbt post --debug --bugs-closed DEVOPS-163 --branch 
DEVOPS-163 master..DEVOPS-163
>>> Running: tf vc help
>>> Checking for a Git repository...
>>> Running: git rev-parse --git-dir
>>> Running: git config core.bare
>>> Running: git rev-parse --show-toplevel
>>> Running: git symbolic-ref -q HEAD
>>> Running: git config --get branch.DEVOPS-163.merge
>>> Running: git config --get branch.DEVOPS-163.remote
>>> Running: git config --get remote.origin.url
>>> Repository info: Path: ssh://
...@git-codecommit.eu-west-1.amazonaws.com/v1/repos/ 

 , Base path: , 
Supports changesets: False
>>> Making HTTP GET request to https://rb. 
 
/api/ 

>>> Running: git rev-parse master..DEVOPS-163
>>> Running: git config --get branch.DEVOPS-163.merge
>>> Running: git config --get branch.DEVOPS-163.remote
>>> Running: git branch --remotes
>>> Running: git rev-list edce8a7dd4284d40a57ba59ba7fac62c34b22f16 --not 
--remotes=origin
>>> Running: git version
>>> Running: git -c core.quotepath=false -c diff.noprefix=false diff 
--no-color --full-index --ignore-submodules -M --no-ext-diff 
edce8a7dd4284d40a57ba59ba7fac62c34b22f16..429fbfbd88d9258f17681407afaa119d4cee7773
>>> Generated diff size: 22187 bytes
>>> Making HTTP GET request to https://rb./api/validation/diffs/ 

>>> Cached response for HTTP GET https://rb. 
 
/api/validation/diffs/ 
 expired and was 
modified
>>> Making HTTP POST request to https://rb. 
 
/api/validation/diffs/ 

>>> Got API Error 224 (HTTP code 400): Unexpected error when validating the 
diff: 'ascii' codec can't decode byte 0xc2 in position 1333: ordinal not in 
range(128)
>>> Error data: {'stat': 'fail', 'err': {'msg': "Unexpected error when 
validating the diff: 'ascii' codec can't decode byte 0xc2 in position 1333: 
ordinal not in range(128)", 'code': 224}}
Traceback (most recent call last):
  File "/usr/lib/python3.6/site-packages/rbtools/api/request.py", line 685, 
in make_request
request.url, body, headers, request.method))
  File "/usr/lib/python3.6/site-packages/rbtools/api/cache.py", line 209, 
in make_request
return self.urlopen(request)
  File "/usr/lib64/python3.6/urllib/request.py", line 223, in urlopen
return opener.open(url, data, timeout)
  File "/usr/lib64/python3.6/urllib/request.py", line 532, in open
response = meth(req, response)
  File "/usr/lib/python3.6/site-packages/rbtools/api/request.py", line 240, 
in http_response
response.info())
  File "/usr/lib64/python3.6/urllib/request.py", line 570, in error
return self._call_chain(*args)
  File "/usr/lib64/python3.6/urllib/request.py", line 504, in _call_chain
result = func(*args)
  File "/usr/lib64/python3.6/urllib/request.py", line 650, in 
http_error_default
raise HTTPError(req.full_url, code, msg, hdrs, fp)
urllib.error.HTTPError: HTTP Error 400: BAD REQUEST

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/lib/python3.6/site-packages/rbtools/commands/post.py", line 
867, in main
**validate_kwargs)
  File "/usr/lib/python3.6/site-packages/rbtools/api/decorators.py", line 
27, in request_method
*args, **kwargs)
  File "/usr/lib/python3.6/site-packages/rbtools/api/transport/sync.py", 
line 77, in execute_request_method
return self._execute_request(request)
  File "/usr/lib/python3.6/site-packages/rbtools/api/transport/sync.py", 
line 86, in _execute_request
rsp = self.server.make_request(request)
  File "/usr/lib/python3.6/site-packages/rbtools/api/request.py", line 687, 
in make_request

Re: rbtools.commands.CommandError: Error validating diff 'ascii' codec can't decode byte 0xc2 in position 1333: ordinal not in range(128) (HTTP 400, API Error 224)

[Paul Mansfield]

>
>
>
I discovered it's possible to change the encoding on a repository, when 
logged in as admin, so I tried "utf-8" and "ascii" and it didn't make a 
difference.  

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard-issues/538ace19-43f5-45df-86e3-b0de6fcefe38%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

rbtools.commands.CommandError: Error validating diff 'ascii' codec can't decode byte 0xc2 in position 1333: ordinal not in range(128) (HTTP 400, API Error 224)

[Paul Mansfield]

We've been using reviewboard for a few months now. The server is 3.0.15 on 
CentOS7, as is the client.

I am using python 3.6.8 from the IUS repository.

This is the first time I've encountered this error, trying to submit a 
post-commit review on a feature branch before it gets merged into master.

I've seen similar codec related reported but none quite the same as this.

 

$ rbt post --debug --bugs-closed DEVOPS-163 --branch DEVOPS-163 
master..DEVOPS-163
>>> RBTools 1.0.2
>>> Python 3.6.8 (default, May  2 2019, 20:40:44) 
[GCC 4.8.5 20150623 (Red Hat 4.8.5-36)]
>>> Running on 
Linux-3.10.0-957.21.2.el7.x86_64-x86_64-with-centos-7.6.1810-Core
>>> Home = /users/paulm
>>> Current directory = /users/paulm/codecommit/ADS-CICD-infrastructure/ci
>>> Command line: rbt post --debug --bugs-closed DEVOPS-163 --branch 
DEVOPS-163 master..DEVOPS-163
>>> Running: tf vc help
>>> Checking for a Git repository...
>>> Running: git rev-parse --git-dir
>>> Running: git config core.bare
>>> Running: git rev-parse --show-toplevel
>>> Running: git symbolic-ref -q HEAD
>>> Running: git config --get branch.DEVOPS-163.merge
>>> Running: git config --get branch.DEVOPS-163.remote
>>> Running: git config --get remote.origin.url
>>> Repository info: Path: 
ssh://apkajzlsxcrn2rybi...@git-codecommit.eu-west-1.amazonaws.com/v1/repos/ADS-CICD-infrastructure,
 
Base path: , Supports changesets: False
>>> Making HTTP GET request to https://rb.aws.agileanalog.com/api/
>>> Running: git rev-parse master..DEVOPS-163
>>> Running: git config --get branch.DEVOPS-163.merge
>>> Running: git config --get branch.DEVOPS-163.remote
>>> Running: git branch --remotes
>>> Running: git rev-list edce8a7dd4284d40a57ba59ba7fac62c34b22f16 --not 
--remotes=origin
>>> Running: git version
>>> Running: git -c core.quotepath=false -c diff.noprefix=false diff 
--no-color --full-index --ignore-submodules -M --no-ext-diff 
edce8a7dd4284d40a57ba59ba7fac62c34b22f16..429fbfbd88d9258f17681407afaa119d4cee7773
>>> Generated diff size: 22187 bytes
>>> Making HTTP GET request to 
https://rb.aws.agileanalog.com/api/validation/diffs/
>>> Cached response for HTTP GET 
https://rb.aws.agileanalog.com/api/validation/diffs/ expired and was 
modified
>>> Making HTTP POST request to 
https://rb.aws.agileanalog.com/api/validation/diffs/
>>> Got API Error 224 (HTTP code 400): Unexpected error when validating the 
diff: 'ascii' codec can't decode byte 0xc2 in position 1333: ordinal not in 
range(128)
>>> Error data: {'stat': 'fail', 'err': {'msg': "Unexpected error when 
validating the diff: 'ascii' codec can't decode byte 0xc2 in position 1333: 
ordinal not in range(128)", 'code': 224}}
Traceback (most recent call last):
  File "/usr/lib/python3.6/site-packages/rbtools/api/request.py", line 685, 
in make_request
request.url, body, headers, request.method))
  File "/usr/lib/python3.6/site-packages/rbtools/api/cache.py", line 209, 
in make_request
return self.urlopen(request)
  File "/usr/lib64/python3.6/urllib/request.py", line 223, in urlopen
return opener.open(url, data, timeout)
  File "/usr/lib64/python3.6/urllib/request.py", line 532, in open
response = meth(req, response)
  File "/usr/lib/python3.6/site-packages/rbtools/api/request.py", line 240, 
in http_response
response.info())
  File "/usr/lib64/python3.6/urllib/request.py", line 570, in error
return self._call_chain(*args)
  File "/usr/lib64/python3.6/urllib/request.py", line 504, in _call_chain
result = func(*args)
  File "/usr/lib64/python3.6/urllib/request.py", line 650, in 
http_error_default
raise HTTPError(req.full_url, code, msg, hdrs, fp)
urllib.error.HTTPError: HTTP Error 400: BAD REQUEST

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/lib/python3.6/site-packages/rbtools/commands/post.py", line 
867, in main
**validate_kwargs)
  File "/usr/lib/python3.6/site-packages/rbtools/api/decorators.py", line 
27, in request_method
*args, **kwargs)
  File "/usr/lib/python3.6/site-packages/rbtools/api/transport/sync.py", 
line 77, in execute_request_method
return self._execute_request(request)
  File "/usr/lib/python3.6/site-packages/rbtools/api/transport/sync.py", 
line 86, in _execute_request
rsp = self.server.make_request(request)
  File "/usr/lib/python3.6/site-packages/rbtools/api/request.py", line 687, 
in make_request
self.process_error(e.code, e.read())
  File "/usr/lib/python3.6/site-packages/rbtools/api/request.py", line 661, 
in process_error
rsp['err']['msg'])
rbtools.api.errors.BadRequestError: Unexpected error when validating the 
diff: 'ascii' codec can't decode byte 0xc2 in position 1333: ordinal not in 
range(128) (HTTP 400, API Error 224)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/bin/rbt", line 10, in 
sys.exit(main())
  File "/usr/lib/python3.6/site-packages/rbtools/commands/main.py", line 
120, in main

Re: Page rendering and default route

[Paul Mansfield]

check you have the following mappings in your apache config for reviewboard

# Alias static media requests to filesystem
Alias /media "/var/www/reviewboard/htdocs/media"
Alias /static "/var/www/reviewboard/htdocs/static"
Alias /errordocs "/var/www/reviewboard/htdocs/errordocs"
Alias /favicon.ico 
"/var/www/reviewboard/htdocs/static/rb/images/favicon.png"



-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/8e49c36c-f71f-4716-8524-28db3d6558d4%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Reviewboard upgrade from v2.5.6.1 to v3.0.14

[Paul Mansfield]

Provided your NFS storage is reliable and highly responsive, I don't see 
why you shouldn't put the service and the backing database onto an NFS 
store.

Still, personally, I'd put it onto the fastest storage which is usually 
local virtual disk, and then ensure that I had good replication of the 
database set up along with regular db dumps and file backups.

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/cc255d95-48a9-4a4f-92ab-d6ed547cb577%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: https://demo.reviewboard.org/ has broken ssl certificate

[Paul Mansfield]

yes, that worked. the UI in Chrome for controlling HSTS is quite primitive, 
but did allow me to enter each domain in turn and delete from the cache.

On Friday, 14 June 2019 11:17:55 UTC+1, Christian Hammond wrote:
>
> Unfortunately, you might have to clear 
> reviewboard.org/demo.reviewboard.org from your HSTS cache in 
> chrome://net-internals/#hsts. Clearing mine solved the redirect locally. 
> It's too bad that Chrome caches it even though the end result is invalid... 
> Though I get why.
>
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/e5d145d0-26aa-4aa2-abbd-fb11ba9a15f7%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Reviewboard and Gitlab

[Paul Mansfield]

I'd use the gitlab API to get a list of repositories

https://docs.gitlab.com/ee/api/repositories.html

and get a list of repositories in RB and compare and create as required
https://www.reviewboard.org/docs/manual/3.0/webapi/2.0/resources/repository-list/

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/7721373d-5128-45b1-be18-e39799b1ad6c%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Reviewboard: You don't have permission to access / on this server.

[Paul Mansfield]

Ensure the wsgi module is installed and loaded into your web server. In 
apache on centos, I have the following installed:

mod_wsgi-3.4-18.el7.x86_64
uwsgi-plugin-common-2.0.17.1-2.el7.x86_64
uwsgi-2.0.17.1-2.el7.x86_64
uwsgi-plugin-python2-2.0.17.1-2.el7.x86_64
mod_proxy_uwsgi-2.0.17.1-2.el7.x86_64



You need the following in your /etc/httpd/conf.d/rb.conf file - the wsgi 
things are the most important:

WSGIPassAuthorization On
WSGIScriptAlias "/" "/var/www/reviewboard/htdocs/reviewboard.wsgi/"


Alias /media "/var/www/reviewboard/htdocs/media"
Alias /static "/var/www/reviewboard/htdocs/static"
Alias /errordocs "/var/www/reviewboard/htdocs/errordocs"
Alias /favicon.ico 
"/var/www/reviewboard/htdocs/static/rb/images/favicon.png"


DocumentRoot "/var/www/reviewboard/htdocs"

AllowOverride All
Options -Indexes +FollowSymLinks
Allow from all


-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/0bf4bdd0-c25f-4950-b312-3581a0ab843f%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Extend trial license

[Paul Mansfield]

Just generate and install another evaluation powerpack licence. That worked 
for me.

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/7b8448fa-9e59-4e4b-bdf5-6c22d440017a%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: https://demo.reviewboard.org/ has broken ssl certificate

[Paul Mansfield]

starting at https://www.reviewboard.org/
I click demo down in the bottom nav bar. that link is 
for http://demo.reviewboard.org/ but it still gets redirected/bounced via 
www.reviewboard.com to the https demo.reviewboard.com

I don't think Firefox honours HSTS?

>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/0d9aeebf-2fa4-4175-8bbb-5db36483f816%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: programmatically add new repositories?

[Paul Mansfield]

Hi,
thanks for coming back to me.
if you have sample code for getting a list of repositories and creating 
them, that would be most excellent. I have python scripts which scan our 
AWS/CC repositories and when new ones appear, add them to our Concourse CI 
system, or Sphinx autodoc etc, so being able to plug into reviewboard would 
be ideal.

we're in the process of working out exactly what we need for our PPack 
licence, hopefully I should have authorisation to buy it soon.

thanks
Paul

>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/df597c8c-bd49-4217-9872-e085c57861d8%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

https://demo.reviewboard.org/ has broken ssl certificate

[Paul Mansfield]

If you're going to enforce HSTS you need to keep the cert up to date 
because it entirely breaks access to the site when it expires

Your connection is not private

Attackers might be trying to steal your information from 
*demo.reviewboard.org* (for example, passwords, messages or credit cards). 
Learn 
more 
NET::ERR_CERT_COMMON_NAME_INVALID
Help improve Safe Browsing by sending some system information and page 
content  to Google. Privacy Policy 

ReloadHide advanced

demo.reviewboard.org normally uses encryption to protect your information. 
When Google Chrome tried to connect to demo.reviewboard.org this time, the 
website sent back unusual and incorrect credentials. This may happen when 
an attacker is trying to pretend to be demo.reviewboard.org, or a Wi-Fi 
sign-in screen has interrupted the connection. Your information is still 
secure because Google Chrome stopped the connection before any data was 
exchanged.

You cannot visit demo.reviewboard.org right now because the website uses 
HSTS. Network errors and attacks are usually temporary, so this page will 
probably work later.


-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/0598b2c0-3a79-4381-8161-0492362dc0f2%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

RB 3.0.14 isn't on EPEL, only 2.5.x.

[Paul Mansfield]

Sorry if this has been covered before. 

The "get review board" page
https://www.reviewboard.org/get/instructions/?org-type=business=rb=linux-rpm=free

says it's on EPEL, but all I can find after looking at four or more mirrors 
is 2.5.x, dating back to Feb 2018.

I'm running CentOS 7, and although I could install from the tar ball from
   https://downloads.reviewboard.org/releases/ReviewBoard/3.0/index.html
I'd rather used a package.


thanks for any hints,
Paul

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board 3.0.14 is out

[Paul Mansfield]

Hi,
the installation instructions for the free version
https://www.reviewboard.org/get/instructions/?org-type=business=rb=linux-rpm=free

says "Review Board 3.0.14 can be installed using yum from the EPEL 
repository"

however, all I can see in EPEL is 2.5.17. I have tried four different EPEL 
mirrors. 

please can someone fix the uploads to EPEL? 

thanks,
Paul

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Gitlab API version supported by ReviewBoard

[Gene Paul Quevedo]

Thanks for that!

On Tue, Sep 11, 2018 at 11:47 PM Dunnigan (US), Terrence J <
terrence.j.dunni...@boeing.com> wrote:

> Review Board 3.0.x supports GitLab API v4
>
>
>
> Terry
>
>
>
> *From:* reviewboard@googlegroups.com [mailto:reviewboard@googlegroups.com]
> *On Behalf Of *Gene Paul Quevedo
> *Sent:* Tuesday, September 11, 2018 1:28 AM
> *To:* Review Board Community 
> *Subject:* Gitlab API version supported by ReviewBoard
>
>
>
> Hello
>
>
>
>
>
> We're currently using GItlab EE v11.04 and we're having an error with
> adding repositories in ReviewBoard
>
> logs on Gitlab show ReviewBoard (our version is 2.5.15) is using v3 of
> Gitlab's API. I tried that and Gitlab's message is
>
>
>
> "API V3 is no longer supported. Use API V4 instead."
>
>
>
> Which Reviewboard version is supporting GItlab API version 4 ?
>
>
>
> - Gene
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "Review Board Community" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to a topic in the
> Google Groups "Review Board Community" group.
> To unsubscribe from this topic, visit
> https://groups.google.com/d/topic/reviewboard/eRCZX-o3qzA/unsubscribe.
> To unsubscribe from this group and all its topics, send an email to
> reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>


-- 
+
Gene Paul L. Quevedo
MS EE, UP Diliman
+639328443765
gepolquev...@yahoo.com

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Gitlab API version supported by ReviewBoard

[Gene Paul Quevedo]

Hello


We're currently using GItlab EE v11.04 and we're having an error with 
adding repositories in ReviewBoard
logs on Gitlab show ReviewBoard (our version is 2.5.15) is using v3 of 
Gitlab's API. I tried that and Gitlab's message is

"API V3 is no longer supported. Use API V4 instead." 

Which Reviewboard version is supporting GItlab API version 4 ?

- Gene

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Annotating Reviews

[Paul Fee]

I've recently been posting large diffs for colleagues to review and had the 
same thoughts about being able to set the order of the files and perhaps 
annotate the code for the benefit of those reviewing my work.

I'm currently using RB2.0.  Would upgrading to RB3.0 help or are there 
plans to enhance this aspect of reviewboard in a future release?

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Exporting Reviewboard contents

[Gene Paul Quevedo]

Thank you Christian!

We're erunning 2.0.25 . I'll have a go on that powerpack and once it's done 
Maybe I can retrieve that beta package

Get Outlook for iOS<https://aka.ms/o0ukef>

From: reviewboard@googlegroups.com <reviewboard@googlegroups.com> on behalf of 
Christian Hammond <christ...@beanbaginc.com>
Sent: Monday, October 16, 2017 4:17:40 PM
To: reviewboard@googlegroups.com
Subject: Re: Exporting Reviewboard contents

Hi Gene,

We're beta-testing a feature for Power Pack that does exactly this. It needs 
some hand-holding right now, and may require some post-import work, but if you 
want to give it a try, I can send a build your way with instructions. You'll 
need to get a Power Pack trial license first at 
https://www.reviewboard.org/powerpack/trial/

Just to check, what version of Review Board are you using?

Christian

On Sun, Oct 15, 2017 at 10:14 PM, Gene Paul Quevedo 
<gene.quev...@gmail.com<mailto:gene.quev...@gmail.com>> wrote:
Hi,

Is there any tool, internal or external to Reviewboard, that can export reviews 
or review requests and so we can import them on another Reviewboard instance?

Our usecase on this matter is we have an external team coming in help us in on 
of our projects and we want them to have their own Reviewboard server but 
contains only a subset of the
Reviews already existing in our current Production server, rather than 
duplicating our server and removing the majority of the reviews

much thanks for any help

--
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to 
reviewboard+unsubscr...@googlegroups.com<mailto:reviewboard+unsubscr...@googlegroups.com>.
For more options, visit https://groups.google.com/d/optout.



--
Christian Hammond
President/CEO of Beanbag<https://www.beanbaginc.com/>
Makers of Review Board<https://www.reviewboard.org/>

--
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to a topic in the Google 
Groups "reviewboard" group.
To unsubscribe from this topic, visit 
https://groups.google.com/d/topic/reviewboard/izdeTtYf4QE/unsubscribe.
To unsubscribe from this group and all its topics, send an email to 
reviewboard+unsubscr...@googlegroups.com<mailto:reviewboard+unsubscr...@googlegroups.com>.
For more options, visit https://groups.google.com/d/optout.

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Exporting Reviewboard contents

[Gene Paul Quevedo]

Hi,

Is there any tool, internal or external to Reviewboard, that can export 
reviews or review requests and so we can import them on another Reviewboard 
instance?

Our usecase on this matter is we have an external team coming in help us in 
on of our projects and we want them to have their own Reviewboard server 
but contains only a subset of the 
Reviews already existing in our current Production server, rather than 
duplicating our server and removing the majority of the reviews

much thanks for any help

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Experiencing migration issues from 2.0.25 to 2.5.15

[Gene Paul Quevedo]

Hi Christian,

I did drop the database before creating it again using the DB Dump. Was
that sufficient? What would be a proper way of recreating it?

On Tue, 29 Aug 2017 at 13:37 Christian Hammond <christ...@beanbaginc.com>
wrote:

> Hi Gene,
>
> Was the database fully recreated between attempts? It seems like there may
> be some stale indexes sitting around.
>
> Christian
>
> On Mon, Aug 28, 2017 at 8:36 PM, Gene Paul Quevedo <gene.quev...@gmail.com
> > wrote:
>
>> Hi Christian,
>>
>> I (re) tried this procedure of creating a dump from production, creating
>> a database on a test server, changing the engine to InnoDB for 64 tables
>> and, running the rb-site upgrade.
>> Still, it's failing somewhere, but I'm able to capture the log message
>> from the upgrade failure, the first after using a pristine DB copy from the
>> production.
>>
>> root@test:~# rb-site upgrade /var/www/netcomm-codereviews
>> Rebuilding directory structure
>> Upgrading site settings_local.py
>> Updating database. This may take a while.
>>
>> The log output below, including warnings and errors,
>> can be ignored unless upgrade fails.
>>
>> --  --
>> Creating tables ...
>> Creating table accounts_trophy
>> Creating table attachments_fileattachmenthistory
>> Creating table diffviewer_rawfilediffdata
>> Creating table notifications_webhooktarget_repositories
>> Creating table notifications_webhooktarget
>> Creating table webapi_webapitoken
>> Upgrading Review Board from 2.0.25 to 2.5.15
>> There are unapplied evolutions for accounts.
>> There are unapplied evolutions for attachments.
>> There are unapplied evolutions for diffviewer.
>> There are unapplied evolutions for notifications.
>> There are unapplied evolutions for reviews.
>> There are unapplied evolutions for webapi.
>> Adding baseline version for new models
>> Evolutions in notifications baseline: webhooktarget_extra_state,
>> webhooktarget_extra_data_null
>> Project signature has changed - an evolution is required
>> Installing custom SQL ...
>> Installing indexes ...
>> Installed 0 object(s) from 0 fixture(s)
>>
>> This may take a while. Please be patient, and do not cancel the upgrade!
>>
>> Applying database evolutions for accounts...
>> Applying database evolutions for attachments...
>> Applying database evolutions for diffviewer...
>> Database evolutions for diffviewer failed!
>> The SQL statement was: CREATE INDEX `diffviewer_filediff_4d02a56a` ON
>> `diffviewer_filediff` (`raw_diff_hash_id`);
>> The database error was: (1061, "Duplicate key name
>> 'diffviewer_filediff_4d02a56a'")
>>
>> CommandError: Error applying evolution for diffviewer: (1061, "Duplicate
>> key name 'diffviewer_filediff_4d02a56a'")
>>
>>
>> ---
>>
>> By the time it failed it has created at least 5 tables. Seems like it's
>> hard to tell what is causing the duplicate key name on table indexes.
>> Attaching here are the latest schema post-upgrade failure
>>
>> but hey! thanks so much for helping me out on this one :)
>>
>> -Gene
>>
>>
>> On Tue, 22 Aug 2017 at 17:10 Christian Hammond <christ...@beanbaginc.com>
>> wrote:
>>
>>> Hi Gene,
>>>
>>> The schema looks healthy at first glance. It seems like a normal 2.0.x
>>> schema, and one that would be safe to upgrade to 2.5.x.
>>>
>>> I don't know what the original error was that you hit (the one in the
>>> original post here was due to a subsequent attempt at upgrading a database
>>> that already failed in a way we couldn't recover from), but one possible
>>> cause of failures would be the table engine type.
>>>
>>> Old versions of MySQL used MyISAM as the table type (the ENGINE= lines
>>> in the schema). Newer MySQL versions (from the past several years onward)
>>> default to InnoDB for any new tables (and 2.5.x would introduce new
>>> tables). If you have a mix of table types, MySQL can end up throwing
>>> confusing errors when attempting to create any relations between those
>>> tables. It's something I'd love for us to be able to catch, but it's pretty
>>> much a MySQL responsibility.
>>>
>>> While I don't know if you hit an error related to that, what you might
>>> want to try doing is converting your schema to use InnoDB for all tables.
>>> You can do a fu

Re: Experiencing migration issues from 2.0.25 to 2.5.15

[Gene Paul Quevedo]

Hi Christian,

I (re) tried this procedure of creating a dump from production, creating a
database on a test server, changing the engine to InnoDB for 64 tables and,
running the rb-site upgrade.
Still, it's failing somewhere, but I'm able to capture the log message from
the upgrade failure, the first after using a pristine DB copy from the
production.

root@test:~# rb-site upgrade /var/www/netcomm-codereviews
Rebuilding directory structure
Upgrading site settings_local.py
Updating database. This may take a while.

The log output below, including warnings and errors,
can be ignored unless upgrade fails.

--  --
Creating tables ...
Creating table accounts_trophy
Creating table attachments_fileattachmenthistory
Creating table diffviewer_rawfilediffdata
Creating table notifications_webhooktarget_repositories
Creating table notifications_webhooktarget
Creating table webapi_webapitoken
Upgrading Review Board from 2.0.25 to 2.5.15
There are unapplied evolutions for accounts.
There are unapplied evolutions for attachments.
There are unapplied evolutions for diffviewer.
There are unapplied evolutions for notifications.
There are unapplied evolutions for reviews.
There are unapplied evolutions for webapi.
Adding baseline version for new models
Evolutions in notifications baseline: webhooktarget_extra_state,
webhooktarget_extra_data_null
Project signature has changed - an evolution is required
Installing custom SQL ...
Installing indexes ...
Installed 0 object(s) from 0 fixture(s)

This may take a while. Please be patient, and do not cancel the upgrade!

Applying database evolutions for accounts...
Applying database evolutions for attachments...
Applying database evolutions for diffviewer...
Database evolutions for diffviewer failed!
The SQL statement was: CREATE INDEX `diffviewer_filediff_4d02a56a` ON
`diffviewer_filediff` (`raw_diff_hash_id`);
The database error was: (1061, "Duplicate key name
'diffviewer_filediff_4d02a56a'")

CommandError: Error applying evolution for diffviewer: (1061, "Duplicate
key name 'diffviewer_filediff_4d02a56a'")

---

By the time it failed it has created at least 5 tables. Seems like it's
hard to tell what is causing the duplicate key name on table indexes.
Attaching here are the latest schema post-upgrade failure

but hey! thanks so much for helping me out on this one :)

-Gene


On Tue, 22 Aug 2017 at 17:10 Christian Hammond <christ...@beanbaginc.com>
wrote:

> Hi Gene,
>
> The schema looks healthy at first glance. It seems like a normal 2.0.x
> schema, and one that would be safe to upgrade to 2.5.x.
>
> I don't know what the original error was that you hit (the one in the
> original post here was due to a subsequent attempt at upgrading a database
> that already failed in a way we couldn't recover from), but one possible
> cause of failures would be the table engine type.
>
> Old versions of MySQL used MyISAM as the table type (the ENGINE= lines in
> the schema). Newer MySQL versions (from the past several years onward)
> default to InnoDB for any new tables (and 2.5.x would introduce new
> tables). If you have a mix of table types, MySQL can end up throwing
> confusing errors when attempting to create any relations between those
> tables. It's something I'd love for us to be able to catch, but it's pretty
> much a MySQL responsibility.
>
> While I don't know if you hit an error related to that, what you might
> want to try doing is converting your schema to use InnoDB for all tables.
> You can do a full database dump from the production server, change all
> ENGINE=MyISAM entries to ENGINE=InnoDB, and then load the database into the
> test server. Then attempt an upgrade, and see if it goes through
> successfully.
>
> If it doesn't succeed, show me the full output, and I'll probably be able
> to narrow it down.
>
> Christian
>
> On Sun, Aug 20, 2017 at 6:25 PM, Gene Paul Quevedo <gene.quev...@gmail.com
> > wrote:
>
>> Oops looks like you might be right. Anyway here's our schema direct
>> coming from our production site.
>>
>> Previously we were running 2.0.20, and the upgrade went smooth if I
>> recall.
>>
>> On Monday, 21 August 2017 10:23:03 UTC+10, Gene Paul Quevedo wrote:
>>>
>>> hi Christian
>>>
>>> The schema is from 2.0.25. It was from a snapshot of our test server
>>> before the upgrade was performed. If there's a suspicion I could generate
>>> again the schema coming from ou production server, which runs 2.0.25
>>>
>>> On Tuesday, 15 August 2017 09:49:09 UTC+10, Christian Hammond wrote:
>>>>
>>>> Hi Gene,
>>>>
>>>> Looks like there was a partial 

Re: Experiencing migration issues from 2.0.25 to 2.5.15

[Gene Paul Quevedo]

Oops looks like you might be right. Anyway here's our schema direct coming 
from our production site. 

Previously we were running 2.0.20, and the upgrade went smooth if I recall. 

On Monday, 21 August 2017 10:23:03 UTC+10, Gene Paul Quevedo wrote:
>
> hi Christian
>
> The schema is from 2.0.25. It was from a snapshot of our test server 
> before the upgrade was performed. If there's a suspicion I could generate 
> again the schema coming from ou production server, which runs 2.0.25 
>
> On Tuesday, 15 August 2017 09:49:09 UTC+10, Christian Hammond wrote:
>>
>> Hi Gene,
>>
>> Looks like there was a partial attempt at an evolution that failed once 
>> before. The "visibility" column was applied and then something apparently 
>> went wrong, or upgrading was cancelled. Deleting the duplicates and running 
>> again would lead to this, unless carefully handled in a way compatible with 
>> django-evolution's internals.
>>
>> Is this database schema the initial one applied from 2.0.25, or what you 
>> have on the test server after the upgrade attempts?
>>
>> Christian
>>
>> On Sun, Aug 13, 2017 at 8:40 PM, Gene Paul Quevedo <gene.q...@gmail.com> 
>> wrote:
>>
>>> Hi,
>>>
>>> I'ts my first time to post here, and I hope someone can point me to the 
>>> right way of solving this issue, even though it seems like there were 
>>> issues like this before
>>>
>>> I'm trying to do a DB upgrade of Review from 2.0.25 to 2.5.15 on a test 
>>> server with a copy of our Database, and seems like it has bumped into this 
>>> issue
>>>
>>> Rebuilding directory structure
>>> Upgrading site settings_local.py
>>> Updating database. This may take a while.
>>>
>>> The log output below, including warnings and errors,
>>> can be ignored unless upgrade fails.
>>>
>>> --  --
>>> Creating tables ...
>>> There are unapplied evolutions for accounts.
>>> There are unapplied evolutions for attachments.
>>> There are unapplied evolutions for diffviewer.
>>> There are unapplied evolutions for reviews.
>>> There are unapplied evolutions for webapi.
>>> Project signature has changed - an evolution is required
>>> Installing custom SQL ...
>>> Installing indexes ...
>>> Installed 0 object(s) from 0 fixture(s)
>>>
>>> This may take a while. Please be patient, and do not cancel the upgrade!
>>>
>>> Applying database evolutions for accounts...
>>> Database evolutions for accounts failed!
>>> The SQL statement was: (u'ALTER TABLE `accounts_reviewrequestvisit` ADD 
>>> COLUMN `visibility` varchar(1) NOT NULL DEFAULT %s;', [u'V'])
>>>
>>>
>>>
>>> *The database error was: (1060, "Duplicate column name 
>>> 'visibility'")CommandError: Error applying evolution for accounts: (1060, 
>>> "Duplicate column name 'visibility'")*
>>> There are probably 4 variations of that 'duplicate column' error, and 
>>> the other one is a 'duplicate index' . 
>>> My initial solution was to delete the duplicates and run the upgrade 
>>> procedure again, but seems like the duplication seems to be repeating (!), 
>>> as if Django Evolution is creating those duplicate columns/indices
>>>
>>> Any ideas on how to debug this further? I'm attaching our DB schema here
>>>
>>> thank you!
>>> - Gene
>>>
>>> -- 
>>> Supercharge your Review Board with Power Pack: 
>>> https://www.reviewboard.org/powerpack/
>>> Want us to host Review Board for you? Check out RBCommons: 
>>> https://rbcommons.com/
>>> Happy user? Let us know! https://www.reviewboard.org/users/
>>> --- 
>>> You received this message because you are subscribed to the Google 
>>> Groups "reviewboard" group.
>>> To unsubscribe from this group and stop receiving emails from it, send 
>>> an email to reviewboard...@googlegroups.com.
>>> For more options, visit https://groups.google.com/d/optout.
>>>
>>
>>
>>
>> -- 
>> Christian Hammond
>> President/CEO of Beanbag <https://www.beanbaginc.com/>
>> Makers of Review Board <https://www.reviewboard.org/>
>>
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--

Re: Experiencing migration issues from 2.0.25 to 2.5.15

[Gene Paul Quevedo]

hi Christian

The schema is from 2.0.25. It was from a snapshot of our test server before 
the upgrade was performed. If there's a suspicion I could generate again 
the schema coming from ou production server, which runs 2.0.25 

On Tuesday, 15 August 2017 09:49:09 UTC+10, Christian Hammond wrote:
>
> Hi Gene,
>
> Looks like there was a partial attempt at an evolution that failed once 
> before. The "visibility" column was applied and then something apparently 
> went wrong, or upgrading was cancelled. Deleting the duplicates and running 
> again would lead to this, unless carefully handled in a way compatible with 
> django-evolution's internals.
>
> Is this database schema the initial one applied from 2.0.25, or what you 
> have on the test server after the upgrade attempts?
>
> Christian
>
> On Sun, Aug 13, 2017 at 8:40 PM, Gene Paul Quevedo <gene.q...@gmail.com 
> > wrote:
>
>> Hi,
>>
>> I'ts my first time to post here, and I hope someone can point me to the 
>> right way of solving this issue, even though it seems like there were 
>> issues like this before
>>
>> I'm trying to do a DB upgrade of Review from 2.0.25 to 2.5.15 on a test 
>> server with a copy of our Database, and seems like it has bumped into this 
>> issue
>>
>> Rebuilding directory structure
>> Upgrading site settings_local.py
>> Updating database. This may take a while.
>>
>> The log output below, including warnings and errors,
>> can be ignored unless upgrade fails.
>>
>> --  --
>> Creating tables ...
>> There are unapplied evolutions for accounts.
>> There are unapplied evolutions for attachments.
>> There are unapplied evolutions for diffviewer.
>> There are unapplied evolutions for reviews.
>> There are unapplied evolutions for webapi.
>> Project signature has changed - an evolution is required
>> Installing custom SQL ...
>> Installing indexes ...
>> Installed 0 object(s) from 0 fixture(s)
>>
>> This may take a while. Please be patient, and do not cancel the upgrade!
>>
>> Applying database evolutions for accounts...
>> Database evolutions for accounts failed!
>> The SQL statement was: (u'ALTER TABLE `accounts_reviewrequestvisit` ADD 
>> COLUMN `visibility` varchar(1) NOT NULL DEFAULT %s;', [u'V'])
>>
>>
>>
>> *The database error was: (1060, "Duplicate column name 
>> 'visibility'")CommandError: Error applying evolution for accounts: (1060, 
>> "Duplicate column name 'visibility'")*
>> There are probably 4 variations of that 'duplicate column' error, and the 
>> other one is a 'duplicate index' . 
>> My initial solution was to delete the duplicates and run the upgrade 
>> procedure again, but seems like the duplication seems to be repeating (!), 
>> as if Django Evolution is creating those duplicate columns/indices
>>
>> Any ideas on how to debug this further? I'm attaching our DB schema here
>>
>> thank you!
>> - Gene
>>
>> -- 
>> Supercharge your Review Board with Power Pack: 
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons: 
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to reviewboard...@googlegroups.com .
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>
>
> -- 
> Christian Hammond
> President/CEO of Beanbag <https://www.beanbaginc.com/>
> Makers of Review Board <https://www.reviewboard.org/>
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Experiencing migration issues from 2.0.25 to 2.5.15

[Gene Paul Quevedo]

Hi,

I'ts my first time to post here, and I hope someone can point me to the 
right way of solving this issue, even though it seems like there were 
issues like this before

I'm trying to do a DB upgrade of Review from 2.0.25 to 2.5.15 on a test 
server with a copy of our Database, and seems like it has bumped into this 
issue

Rebuilding directory structure
Upgrading site settings_local.py
Updating database. This may take a while.

The log output below, including warnings and errors,
can be ignored unless upgrade fails.

--  --
Creating tables ...
There are unapplied evolutions for accounts.
There are unapplied evolutions for attachments.
There are unapplied evolutions for diffviewer.
There are unapplied evolutions for reviews.
There are unapplied evolutions for webapi.
Project signature has changed - an evolution is required
Installing custom SQL ...
Installing indexes ...
Installed 0 object(s) from 0 fixture(s)

This may take a while. Please be patient, and do not cancel the upgrade!

Applying database evolutions for accounts...
Database evolutions for accounts failed!
The SQL statement was: (u'ALTER TABLE `accounts_reviewrequestvisit` ADD 
COLUMN `visibility` varchar(1) NOT NULL DEFAULT %s;', [u'V'])



*The database error was: (1060, "Duplicate column name 
'visibility'")CommandError: Error applying evolution for accounts: (1060, 
"Duplicate column name 'visibility'")*
There are probably 4 variations of that 'duplicate column' error, and the 
other one is a 'duplicate index' . 
My initial solution was to delete the duplicates and run the upgrade 
procedure again, but seems like the duplication seems to be repeating (!), 
as if Django Evolution is creating those duplicate columns/indices

Any ideas on how to debug this further? I'm attaching our DB schema here

thank you!
- Gene

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
-- MySQL dump 10.13  Distrib 5.5.54, for debian-linux-gnu (x86_64)
--
-- Host: localhostDatabase: reviewboard
-- --
-- Server version	5.5.54-0ubuntu0.14.04.1

/*!40101 SET @OLD_CHARACTER_SET_CLIENT=@@CHARACTER_SET_CLIENT */;
/*!40101 SET @OLD_CHARACTER_SET_RESULTS=@@CHARACTER_SET_RESULTS */;
/*!40101 SET @OLD_COLLATION_CONNECTION=@@COLLATION_CONNECTION */;
/*!40101 SET NAMES utf8 */;
/*!40103 SET @OLD_TIME_ZONE=@@TIME_ZONE */;
/*!40103 SET TIME_ZONE='+00:00' */;
/*!40014 SET @OLD_UNIQUE_CHECKS=@@UNIQUE_CHECKS, UNIQUE_CHECKS=0 */;
/*!40014 SET @OLD_FOREIGN_KEY_CHECKS=@@FOREIGN_KEY_CHECKS, FOREIGN_KEY_CHECKS=0 */;
/*!40101 SET @OLD_SQL_MODE=@@SQL_MODE, SQL_MODE='NO_AUTO_VALUE_ON_ZERO' */;
/*!40111 SET @OLD_SQL_NOTES=@@SQL_NOTES, SQL_NOTES=0 */;

--
-- Table structure for table `accounts_localsiteprofile`
--

DROP TABLE IF EXISTS `accounts_localsiteprofile`;
/*!40101 SET @saved_cs_client = @@character_set_client */;
/*!40101 SET character_set_client = utf8 */;
CREATE TABLE `accounts_localsiteprofile` (
  `id` int(11) NOT NULL AUTO_INCREMENT,
  `user_id` int(11) NOT NULL,
  `profile_id` int(11) NOT NULL,
  `local_site_id` int(11) DEFAULT NULL,
  `direct_incoming_request_count` int(11) DEFAULT NULL,
  `total_incoming_request_count` int(11) DEFAULT NULL,
  `pending_outgoing_request_count` int(11) DEFAULT NULL,
  `total_outgoing_request_count` int(11) DEFAULT NULL,
  `starred_public_request_count` int(11) DEFAULT NULL,
  `permissions` longtext,
  PRIMARY KEY (`id`),
  UNIQUE KEY `user_id` (`user_id`,`local_site_id`),
  UNIQUE KEY `profile_id` (`profile_id`,`local_site_id`),
  KEY `accounts_localsiteprofile_403f60f` (`user_id`),
  KEY `accounts_localsiteprofile_141c6eec` (`profile_id`),
  KEY `accounts_localsiteprofile_45ded6af` (`local_site_id`)
) ENGINE=InnoDB AUTO_INCREMENT=105 DEFAULT CHARSET=latin1;
/*!40101 SET character_set_client = @saved_cs_client */;

--
-- Table structure for table `accounts_profile`
--

DROP TABLE IF EXISTS `accounts_profile`;
/*!40101 SET @saved_cs_client = @@character_set_client */;
/*!40101 SET character_set_client = utf8 */;
CREATE TABLE `accounts_profile` (
  `id` int(11) NOT NULL AUTO_INCREMENT,
  `user_id` int(11) NOT NULL,
  `first_time_setup_done` tinyint(1) NOT NULL,
  `collapsed_diffs` tinyint(1) NOT NULL,
  `wordwrapped_diffs` tinyint(1) NOT NULL,
  `syntax_highlighting` tinyint(1) NOT NULL,
  `is_private` tinyint(1) NOT NULL,
  `show_closed` tinyint(1) NOT NULL,
  `sort_review_request_columns` varchar(256) NOT NULL,
  `sort_dashboard_columns` varchar(256) NOT NULL,
  

Re: Review Board turns 10 today!

[Paul Fee]

Fantastic achievement Christian, David and everyone else that has 
contributed.  We use Reviewboard on a daily basis and it helps greatly with 
getting developers to engage in the review process.

Well done and keep up the good work.

Thank you,
Paul

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Testing Needed] Review Board 2.5.2 for RHEL/CentOS 7

[Paul Fee]

Hi Stephen,

That's great news, I had been wondering if Fedora/RHEL users would be 
seeing RB2.5 soon.

On Fedora, it looks like the Django packages have moved ahead to 1.8, but 
RB still needs 1.6.  Hence ReviewBoard has disappeared from Fedora from F22 
onwards :(

Nice to see that the situation on RHEL+EPEL is better.  For users on that 
platform, what can we expect when installing the upgrade?  If I already 
have a 2.0.18 installation and a site populated with users/reviews/comments 
etc. will this migrate without effort up to RB 2.5.2 or is anything else 
required, e.g. database backup/restore?

Thanks,
Paul

On Saturday, December 5, 2015 at 12:05:06 AM UTC, Stephen Gallagher wrote:
>
> Hello, folks! It's time for a big update. As many of you are probably 
> aware, I maintain the RPMs of Review Board that live in Fedora's EPEL 
> project[1] (Extra Packages for Enterprise Linux).
>
> For some time now, EPEL 7 (which provides community-supported add-on 
> software for RHEL 7 and CentOS 7) has been providing Review Board 2.0.x 
> packages. However, time passes and I now feel that it's worth upgrading 
> EPEL 7 to carry 2.5.2 with all of the enhancements and bugfixes that this 
> entails.
>
> This is a pretty major update to the server-side of things, so I'd really 
> like to get some serious testing performed if possible before I push this 
> out to the stable repository. (Getting testing for updates has been a 
> problem in the past, which is why updates tend to trail the upstream 
> releases by at least two weeks; EPEL has a policy that it must remain in 
> the testing repository for at least that time unless it receives positive 
> feedback from people testing it).
>
> So, how can you help? The simplest way to do so would be to install the 
> new RPMs on your RHEL/CentOS 7 systems by installing the EPEL 7 repository 
> and then running:
> `yum install --enablerepo=epel-testing ReviewBoard` or `yum update 
> --enablerepo=epel-testing ReviewBoard` if you have an existing 
> installation. (Note: this was just submitted for the testing repository, so 
> it may take up to 48 hours to reach your local mirror, though usually less 
> than 24).
>
> Then play around with it; test that it upgrades cleanly and that you can 
> create new sites in your preferred configuration. Once you have feedback to 
> provide (positive *or* negative), please create a Fedora Account at  
> https://admin.fedoraproject.org/accounts/ and then log in at 
> https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-b8671a8638 and 
> use the feedback buttons and comment field to let me know how it went.
>
> Warning: if I get no feedback at all, I'm just going to push this to 
> stable at the end of two weeks, so if you don't want any surprises at your 
> next stable update, please help me out here.
>
>
> [1] https://fedoraproject.org/wiki/EPEL
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Repository setup with clearcase, multiple vobs, and multiple views

[Paul Leeming]

Hi,

We are trying to set up a trial of ReviewBoard using ClearCase. It seems 
that a repository on the server an only access one view on a particular 
ClearCase vob. There is an existing post which describes the problem 
perfectly, but unfortunately no one replied.

https://groups.google.com/forum/#!topic/reviewboard/itUvCZK_wJU

Has anyone set up ReviewBoard to work in the way described in the link 
above?

Perhaps the only way we can work with multiple vobs and multiple views on 
each vob is to use a number of snapshot views on the review board server, 
these will obviously need updating every time changes are made to a 
particular vob.

Any feedback gratefully received.






-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

RB 2.5 and Comment Categorization extension

[Paul Wolf]

I'm having problems getting this extension working on a new RB 2.5 
installation.  I'm able to install the extension, enable it, and configure 
some comment types.  However, when I go to add a review comment, the Type 
'select' has no values.  I've tried restarting my server but that didn't 
help. Has anyone else had problems using this extension with RB 2.5?  
Thanks.

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board 2.5 beta 2 is out!

[Paul Fee]

Hi Christian,

I occasionally see bugs when using rbt post to push up multiple drafts 
before I publish.  I suspect that a previous draft is cached server side, 
browser cache clearing and memcached restarts fail to fix the issue.  
Repeat use of rbt post following local code changes doesn't always result 
in visible changes on the interdiff web page.  I haven't been able to 
reliably reproduce this and can't share the specific diffs in question as 
the code is private.

Also, I've seen occasions where I can see the change in the side-by-side 
diff viewer (e.g. lines deleted), however the lines are not always colour 
coded to highlight the change as expected.

I'm using RB 2.0.18.

Sorry, I just noticed I previously asked if the 2.5 interdiff changes were 
relevant for RB1.7, I should have asked if they were relevant to RB2.0 as 
that's the version I've had interdiff viewing problems with.

Thanks,
Paul

On Wednesday, July 22, 2015 at 9:35:30 PM UTC+1, Christian Hammond wrote:

 Hi Paul,

 These fixes are not. Interdiffs were largely rewritten since 1.7 and 
 behave differently. We've had further changes since 2.0 (though we may 
 backport some of these fixes).

 Are there particular fixes you're interested in?

 Christain

 -- 
 Christian Hammond - chi...@chipx86.com javascript:
 Review Board - https://www.reviewboard.org
 Beanbag, Inc. - https://www.beanbaginc.com

 On Tue, Jul 21, 2015 at 3:30 AM, Paul Fee paul@gmail.com 
 javascript: wrote:

 Hi Christian,

 I see this line in the 2.5 Beta 2 release notes:

 * Diff Viewer - Fixed some problems with interdiffs resulting from 
 rebased changes

 Are these fixes applicable to the 1.7 release branch?

 Thanks,
 Paul

 On Monday, July 20, 2015 at 7:54:36 PM UTC+1, Stephen Gallagher wrote:



 On Mon, Jul 20, 2015 at 1:30 PM Christian Hammond 
 chri...@beanbaginc.com wrote:

 Hey everyone,

 We've put out the second beta of Review Board 2.5. We're hoping to wrap 
 this release cycle up soon, get an RC out the door in the next two weeks 
 and then ship the final 2.5 release shortly after. We'd love your testing 
 to help make this happen.

 You can read our announcement, complete with screenshots, here: 
 https://www.reviewboard.org/news/2015/07/20/review-board-2-5-beta-2-out/

 We also have an announcements mailing list available, for those not on 
 it: https://www.reviewboard.org/mailing-lists/

 And as a reminder, we're posting the latest development news, feature 
 additions, design ideas, etc. over at the Review Board ChangeLog: 
 http://changelog.assembly.com/reviewboard


 I've also created a new COPR repository for Fedora 21+ and RHEL/CentOS 
 7. You can now download and install Review Board 2.5 beta 2 for evaluation 
 on those platforms. Browse to 
 https://copr.fedoraproject.org/coprs/sgallagh/reviewboard2.5/ and 
 install the appropriate repository file into /etc/yum.repos.d, then do 'yum 
 install ReviewBoard'. If you already have Review Board on the target 
 system, back it up and then just do 'yum update ReviewBoard' (after having 
 installed the repo file, of course).

 Yum may prompt you to accept the signing key for these new packages; 
 that key should be:
  f836 fa56 6e04 caa8 832f 6efd fa1d d63c 353c 6a28

  -- 
 Supercharge your Review Board with Power Pack: 
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons: 
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google Groups 
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard...@googlegroups.com javascript:.

 For more options, visit https://groups.google.com/d/optout.




-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board 2.5 beta 2 is out!

[Paul Fee]

Hi Christian,

I see this line in the 2.5 Beta 2 release notes:

* Diff Viewer - Fixed some problems with interdiffs resulting from rebased 
changes

Are these fixes applicable to the 1.7 release branch?

Thanks,
Paul

On Monday, July 20, 2015 at 7:54:36 PM UTC+1, Stephen Gallagher wrote:



 On Mon, Jul 20, 2015 at 1:30 PM Christian Hammond chri...@beanbaginc.com 
 javascript: wrote:

 Hey everyone,

 We've put out the second beta of Review Board 2.5. We're hoping to wrap 
 this release cycle up soon, get an RC out the door in the next two weeks 
 and then ship the final 2.5 release shortly after. We'd love your testing 
 to help make this happen.

 You can read our announcement, complete with screenshots, here: 
 https://www.reviewboard.org/news/2015/07/20/review-board-2-5-beta-2-out/

 We also have an announcements mailing list available, for those not on 
 it: https://www.reviewboard.org/mailing-lists/

 And as a reminder, we're posting the latest development news, feature 
 additions, design ideas, etc. over at the Review Board ChangeLog: 
 http://changelog.assembly.com/reviewboard


 I've also created a new COPR repository for Fedora 21+ and RHEL/CentOS 7. 
 You can now download and install Review Board 2.5 beta 2 for evaluation on 
 those platforms. Browse to 
 https://copr.fedoraproject.org/coprs/sgallagh/reviewboard2.5/ and install 
 the appropriate repository file into /etc/yum.repos.d, then do 'yum install 
 ReviewBoard'. If you already have Review Board on the target system, back 
 it up and then just do 'yum update ReviewBoard' (after having installed the 
 repo file, of course).

 Yum may prompt you to accept the signing key for these new packages; that 
 key should be:
  f836 fa56 6e04 caa8 832f 6efd fa1d d63c 353c 6a28



-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

RB 2.0.17 - Interdiff fails to highlight deleted code

[Paul Fee]

Hi all,

I'm using ReviewBoard 2.0.17 and see unexpected behaviour in the diff 
viewer.

Steps to reproduce:

1. Change a few files (I'm using SVN)
2. rbt post changelist
3. Publish review
4. Delete a group of lines from one of the files already changed.
5. rbt post -r ID changelist
6. Publish review
7. Review entire diff: http://reviewboard/r/9581/diff/2/ - Result: PASS
8. Review first interdiff: http://reviewboard/r/9581/diff/1/ - Result: PASS
9. Review second interdiff: http://reviewboard/r/9581/diff/1-2/ - Result: 
FAIL

In the second interdiff, RB states that the file contains only whitespace 
changes, this is incorrect as lines have been deleted.

Expanding the entire file, the contain on the left and right diff panels is 
correct, I can see that the deleted lines have gone, however they're not 
highlighted in red as expected.

I don't think this is related to caching as the following steps had no 
effect, the second interdiff consistently shows the same result.

* systemctl restart memcached
* systemctl restart httpd
* View second interdiff with different browsers (Firefox and Chromium), 
both show same results, hence not a browser cache issue.

I'm running ReviewBoard on CentOS7 using EPEL packages.

Let me know if you need more information to help recreate or fix this bug.

Thanks,
Paul

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board 2.0.16 is released, with security fixes and more

[Paul Fee]

Hi Christian,

It wasn't a browser cache issue as the incorrect results were visible after 
switch between multiple browsers (using independent browser caches), 
therefore the problem must have been on the server.

I tried to reproduce this again today, but wasn't able to - you could take 
that as good news ;)

When I previously saw the bug, the review was created with 2.0.15 and then 
continued to have more diff sets added after the server had been upgraded 
to 2.0.17.  I don't know whether that aspect is relevant.

Anyway, I'll keep an eye on this and if I can reproduce it reliably I'll 
let you know.  In the mean time, ignore this bug report.

Thanks,
Paul

On Saturday, June 20, 2015 at 3:16:14 AM UTC+1, Christian Hammond wrote:

 Hi Paul, 

 Thanks for reporting this. I went through our caching code, and I'm not 
 really sure why this is happening off-hand. Were you able to fix this by 
 clearing your browser cache, or did you have to restart memcached? 

 Christian 

 --   
 Christian Hammond - chri...@beanbaginc.com javascript:   
 Review Board - https://www.reviewboard.org   
 Beanbag, Inc. - https://www.beanbaginc.com 

 -Original Message- 
 From: Paul Fee paul@gmail.com javascript: 
 Reply: revie...@googlegroups.com javascript: revie...@googlegroups.com 
 javascript: 
 Date: June 18, 2015 at 9:45:59 AM 
 To: revie...@googlegroups.com javascript: revie...@googlegroups.com 
 javascript: 
 Subject:  Re: Review Board 2.0.16 is released, with security fixes and 
 more 

  Hi Christian, 

  I'm seeing some buggy behaviour around the caching of diffs. It looks 
 like 
  a server side problem as the buggy diff content persists even if I 
 reload 
  with CTRL-F5 or switch browsers (e.g. firefox to chromium). 

  Steps to reproduce: 

  1. Change some code, I happen to be using SVN. 
  2. Upload diff to existing review. 
  $ rbt post -r XXX svn_changelist 
  3. View the draft interdiff, all it ok at this point. 
  4. Change the code some more without publishing draft changes. 
  5. Upload diff again, should change content of draft diff. 
  $ rbt post -r XXX svn_changelist 
  6. View the draft interdiff - BUG - diff content on web page is from 
 first 
  upload, changes from second rbt post are not displayed. 

  From the 2.0.16 release notes, If a diff has already been viewed once, 
 by 
  anyone, it will be quicker to retrieve and display.. I suspect the 
 draft 
  is being cached. A blunt fix could be to avoid caching diffs for drafts. 
  A better fix would be to invalidate caches for draft diffs when a new 
  diffset is uploaded. 

  Hopefully those steps are clear enough for you to reproduce the issue. 
 Let 
  me know if you need more information. 

  Thanks, 
  Paul 

  -- 
  Supercharge your Review Board with Power Pack: 
 https://www.reviewboard.org/powerpack/ 
  Want us to host Review Board for you? Check out RBCommons: 
 https://rbcommons.com/ 
  Happy user? Let us know! https://www.reviewboard.org/users/ 
  --- 
  You received this message because you are subscribed to the Google 
 Groups reviewboard 
  group. 
  To unsubscribe from this group and stop receiving emails from it, send 
 an email to reviewboard...@googlegroups.com javascript:. 
  For more options, visit https://groups.google.com/d/optout. 




-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board 2.0.16 is released, with security fixes and more

[Paul Fee]

Hi Christian,

I'm seeing some buggy behaviour around the caching of diffs.  It looks like 
a server side problem as the buggy diff content persists even if I reload 
with CTRL-F5 or switch browsers (e.g. firefox to chromium).

Steps to reproduce:

1. Change some code, I happen to be using SVN.
2. Upload diff to existing review.
$ rbt post -r XXX svn_changelist
3. View the draft interdiff, all it ok at this point.
4. Change the code some more without publishing draft changes.
5. Upload diff again, should change content of draft diff.
$ rbt post -r XXX svn_changelist
6. View the draft interdiff - BUG - diff content on web page is from first 
upload, changes from second rbt post are not displayed.

From the 2.0.16 release notes, If a diff has already been viewed once, by 
anyone, it will be quicker to retrieve and display..  I suspect the draft 
is being cached.  A blunt fix could be to avoid caching diffs for drafts.  
A better fix would be to invalidate caches for draft diffs when a new 
diffset is uploaded.

Hopefully those steps are clear enough for you to reproduce the issue.  Let 
me know if you need more information.

Thanks,
Paul

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board 2.0.16 is released, with security fixes and more

[Paul Fee]

Hi Stephen,

The 2.0.17 packages for EPEL7 worked as expected, karma dispensed.

Thanks to all those that contributed to 2.0.16 and 2.0.17, I especially 
liked the fixes to the interdiff version selector as that was bugging me.  
The performance improvements are also nice to see.

Cheers,
Paul

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board 2.0.16 is released, with security fixes and more

[Paul Fee]

Hi Stephen,

EPEL7 upgrade didn't work for me.  Negative karma and details of haystack 
dependency issue here.
https://admin.fedoraproject.org/updates/FEDORA-EPEL-2015-6685/ReviewBoard-2.0.16-1.el7,python-djblets-0.8.19-1.el7,python-django-evolution-0.7.5-1.el7

Forgive the formatting, I see bodhi doesn't preserve line endings within 
the comment box.

HTH,
Paul


On Friday, June 12, 2015 at 5:55:48 PM UTC+1, Stephen Gallagher wrote:



 On Fri, Jun 12, 2015 at 12:47 AM Christian Hammond chri...@beanbaginc.com 
 javascript: wrote:

 Hey everyone,

 We just put out a release of Review Board 2.0.16. This release contains 
 security fixes, so we recommend that you update!

 There are also some significant performance improvements across the 
 entire site, especially for diff loading, along with a great many bug fixes.

 This is all detailed in the news post: 
 https://www.reviewboard.org/news/2015/06/11/review-board-2-0-16-out-safer-faster-and-more-stable/


 Packages for Fedora 21 and RHEL/CentOS 7 are now available at 
 https://admin.fedoraproject.org/updates/search/ReviewBoard

 Packages for Fedora 22 and 23 (Rawhide) are available in my COPR 
 repository:  
 https://copr.fedoraproject.org/coprs/sgallagh/f22-reviewboard/


-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board 2.0.13 is out!

[Paul Fee]

Hi David,

Both ReviewBoard-2.0.13-1.el7 
https://admin.fedoraproject.org/updates/FEDORA-EPEL-2015-0798/ReviewBoard-2.0.13-1.el7,python-djblets-0.8.15-1.el7?_csrf_token=ece4520dac50305f9779aaadf86012cee633767e
 
and RBTools-0.7.1-1.el7 
https://admin.fedoraproject.org/updates/FEDORA-EPEL-2015-0673/RBTools-0.7.1-1.el7?_csrf_token=ece4520dac50305f9779aaadf86012cee633767e
 
are still in testing.
https://admin.fedoraproject.org/updates/search/ReviewBoard
https://admin.fedoraproject.org/updates/search/RBTools

You can upgrade to them by enabling the epel-testing repo like this:
$ sudo yum update --enablerepo=epel-testing RBTools

If you find the new versions work as expected, then please leave positive 
karma by commenting on the versions you've tested.  I did this for the F21 
package, which got it promoted from testing to stable:
https://admin.fedoraproject.org/updates/FEDORA-2015-1786/RBTools-0.7.1-1.fc21

Positive testing results from you will help other EPEL7 users benefit from 
these updates.

Thanks,
Paul

On Thursday, February 19, 2015 at 9:02:58 PM UTC, David Carson wrote:

 Will this show up in CentOS 7 yum soon?  Also, I was expecting the RBTools 
 update to show up in CentOS 7 yum, but it has not.

 Thanks for the great work.  There are several bug fixes that I'm anxious 
 to pick up.

 On Tuesday, February 17, 2015 at 12:40:18 PM UTC-5, Stephen Gallagher 
 wrote:


   On Thu, 2015-02-12 at 14:22 -0800, Christian Hammond wrote: 
  Hey everyone, 
  
  We just put out a release of Review Board 2.0.13. This features several 
  bug fixes, some new features for Subversion and administrators, and API 
  performance improvements when using RBTools 0.7.1+. 
  
  See the announcement for more info: 
  
  
 https://www.reviewboard.org/news/2015/02/12/review-board-2-0-13-released/ 
  
  And the release notes: 
  
  https://www.reviewboard.org/docs/releasenotes/reviewboard/2.0.13/ 


 Fedora 21 and EPEL 7 packages are available at: 
 https://admin.fedoraproject.org/updates/search/ReviewBoard 



-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Digest for reviewboard@googlegroups.com - 16 updates in 3 topics

[Paul Sander]

It is possible to get Review Board to work with a remote Git server, if the Git 
server also runs a web server.  Write a CGI script that takes a repo name and 
SHA-1 checksum as parameters, chdir into the bare repo on the Git server, and 
run git cat-file blob SHA-1 using a text/plain content type. Then configure 
the repo in Review Board with a Raw file URL mask set to invoke the CGI 
script, hard-coding the repo name and replacing revision with the SHA-1 
checksum.

-
If you drive fast enough, every traffic light turns green.

Paul Sander
Principal Member of Technical Staff, ScaleArc
2901 Tasman Dr., Santa Clara, CA 95054
paul.san...@scalearc.commailto:paul.san...@scalearc.com


From: reviewboard@googlegroups.commailto:reviewboard@googlegroups.com 
reviewboard@googlegroups.commailto:reviewboard@googlegroups.com
Reply-To: reviewboard@googlegroups.commailto:reviewboard@googlegroups.com 
reviewboard@googlegroups.commailto:reviewboard@googlegroups.com
Date: Saturday, February 14, 2015 at 2:01 AM
To: reviewboard@googlegroups.commailto:reviewboard@googlegroups.com 
reviewboard@googlegroups.commailto:reviewboard@googlegroups.com
Subject: Digest for 
reviewboard@googlegroups.commailto:reviewboard@googlegroups.com - 16 updates 
in 3 topics


-Original Message-
From: Liam Reimers liam.reim...@gmail.commailto:liam.reim...@gmail.com
Reply: Liam Reimers liam.reim...@gmail.commailto:liam.reim...@gmail.com
Date: February 13, 2015 at 1:22:57 PM
To: reviewboard@googlegroups.commailto:reviewboard@googlegroups.com 
reviewboard@googlegroups.commailto:reviewboard@googlegroups.com
Cc: liam.reim...@gmail.commailto:liam.reim...@gmail.com 
liam.reim...@gmail.commailto:liam.reim...@gmail.com, 
christ...@beanbaginc.commailto:christ...@beanbaginc.com 
christ...@beanbaginc.commailto:christ...@beanbaginc.com
Subject:  Re: The specified diff file could not be parsed.


Liam Reimers liam.reim...@gmail.commailto:liam.reim...@gmail.com: Feb 13 
03:40PM -0800

 Ah, I just saw part of your error: Not a git repository: 'None.'

 How is your repository configured in Review Board?


Name - Repository
Hosting - None (custom)
Type - Git
Path - git@server:path/repo.git

However, note that the client can post a review request using one
invocation (with HEAD~) and not the other, so it would seem that the repo
is configured correctly?

Christian Hammond christ...@beanbaginc.commailto:christ...@beanbaginc.com: 
Feb 14 12:26AM -0800

Unfortunately, that configuration can't work, unless there's also a raw file 
URL field that's filled out. Git's protocol has no ability to fetch the kind of 
information we need remotely, including individual files.

For Git, it's a requirement to either host the repository on the Review Board 
server (or through something like an NFS mount), or to use a service like 
GitWeb. GitWeb is the recommended route right now (though we're working on a 
service to help make all this easier).

If the other changes were successfully posting, my guess is that they were 
introducing new files, which doesn't require communication with the repository. 
Otherwise, there's no way that the file verification could have worked with a 
remote Git path.

Christian

--
Christian Hammond - christ...@beanbaginc.commailto:christ...@beanbaginc.com
Review Board - https://www.reviewboard.org
Beanbag, Inc. - https://www.beanbaginc.com

-Original Message-
From: Liam Reimers liam.reim...@gmail.commailto:liam.reim...@gmail.com
Reply: Liam Reimers liam.reim...@gmail.commailto:liam.reim...@gmail.com
Date: February 13, 2015 at 3:40:54 PM
To: reviewboard@googlegroups.commailto:reviewboard@googlegroups.com 
reviewboard@googlegroups.commailto:reviewboard@googlegroups.com
Cc: liam.reim...@gmail.commailto:liam.reim...@gmail.com 
liam.reim...@gmail.commailto:liam.reim...@gmail.com, 
christ...@beanbaginc.commailto:christ...@beanbaginc.com 
christ...@beanbaginc.commailto:christ...@beanbaginc.com
Subject:  Re: The specified diff file could not be parsed.


Back to top
You received this digest because you're subscribed to updates for this group. 
You can change your settings on the group membership 
pagehttps://groups.google.com/forum/?utm_source=digestutm_medium=email#!forum/reviewboard/join.
To unsubscribe from this group and stop receiving emails from it send an email 
to 
reviewboard+unsubscr...@googlegroups.commailto:reviewboard+unsubscr...@googlegroups.com.

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Using Reviewboard with gitolite the right way?

[paul . sander]

The way I accomplished this was to configure a Git repo in Review Board 
using the ssh method (the git method will probably also work) to access the 
Git repo remotely on my central server, as the Path and Mirror path 
settings in Review Board.  Then I wrote a CGI script that runs on the Git 
server's httpd server that takes a repo name and SHA-1 checksum as 
parameters, and runs git cat-file blob sha in the specified repo.  Then 
I configured Review Board's Raw file URL mask field to invoke this CGI 
script with the proper repo name and passing the revision value as the 
SHA-1 checksum.

The CGI script is about 35 lines of Python code.  This method avoids the 
need to replicate the Git repo on the Review Board server.  The overhead is 
much lower and it eliminates the biggest race condition in the Review Board 
deployment.
 
On Thursday, January 22, 2015 at 8:00:30 AM UTC-8, Marian wrote:


 Now, if I were to use a remote SSH scheme for a Git Path, at least when 
 not using cgit or gitweb, quoting the documentation *Git doesn’t have a 
 way of fetching an individual file of a given revision from a remote server 
 without having an entire clone, so it works differently from other 
 repository types*. 

 It seems to me the most proper way of setting and solving things out is to 
 have a local copy inside reviewboard that is git pulled before any diffing 
 operation occurs.

 Meanwhile, is there any possible way to implement git using gitolite 
 without having a web frontend like gitweb?



-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Errno 13] Permission denied error when sending emails

[Paul Fee]

Hi all (and Stephen),

Looks like there are problems beyond SELinux here.  However in case you 
haven't already, you'll need adjust SELinux so that httpd (which is running 
the RB Django code via mod_wsgi) is allowed make outbound TCP connections 
to port 25.

$ sudo setsebool -P httpd_can_sendmail 1

HTH,
Paul

On Thursday, November 13, 2014 10:17:22 AM UTC, Yang wrote:

 Hello Michaela, 

 Could you please explain more how you fixed this issue? I meet the same 
 problem of sending emails in web2py running on Apache (CentOS). 

 Thanks!

 On Tuesday, August 20, 2013 7:03:51 PM UTC+2, Michaela Newell wrote:

 Actually, figured out what the last bits were it was because I had TLS 
 ticked but my server didn't have it. Fixed now :) Thanks very much. Your 
 command audit2allow -a did not work however.

 On Tuesday, 20 August 2013 17:34:39 UTC+1, Michaela Newell wrote:

 Hi Stephan,

 Thanks for reply. It is RHEL/CentOS 6. It did not go away when I tried 
 the command but the error message has changed. Output from log now is:

 - Error sending e-mail notification with subject 'Review Request 2: gfhgf' 
 on behalf of ' .x...@.com' to ' 
 .x...@.com': STARTTLS extension not supported by server.
 Traceback (most recent call last):
   File 
 /usr/lib/python2.6/site-packages/reviewboard/notifications/email.py, line 
 244, in send_review_mail
 message.send()
   File /usr/lib/python2.6/site-packages/django/core/mail/message.py, line 
 248, in send
 return self.get_connection(fail_silently).send_messages([self])
   File 
 /usr/lib/python2.6/site-packages/django/core/mail/backends/smtp.py, line 
 85, in send_messages
 new_conn_created = self.open()
   File 
 /usr/lib/python2.6/site-packages/django/core/mail/backends/smtp.py, line 
 51, in open
 self.connection.starttls()
   File /usr/lib64/python2.6/smtplib.py, line 611, in starttls
 raise SMTPException(STARTTLS extension not supported by server.)
 SMTPException: STARTTLS extension not supported by server.


 The audit2allow -a command came back with command not found, running as 
 root.

 Michaela

 On Tuesday, 20 August 2013 14:48:30 UTC+1, Stephen Gallagher wrote:

 On 08/20/2013 09:46 AM, Michaela Newell wrote: 
  I am attempting to set-up emails. I have all three options selected 
 and 
  a valid smtp server. When I add a new user the logs show nothing but 
 the 
  email does not get sent. When I add a new review request I get this 
 in 
  the log: 
  
   - Error sending e-mail notification with subject 'Review Request 1: 
 ...' on behalf of '  .x...@.com' to '  
 .x...@.com': [Errno 13] Permission denied 
  Traceback (most recent call last): 
File 
 /usr/lib/python2.6/site-packages/reviewboard/notifications/email.py, 
 line 
 244, in send_review_mail 
  message.send() 
File 
 /usr/lib/python2.6/site-packages/django/core/mail/message.py, line 248, 
 in send 
  return self.get_connection(fail_silently).send_messages([self]) 
File 
 /usr/lib/python2.6/site-packages/django/core/mail/backends/smtp.py, line 
 85, in send_messages 
  new_conn_created = self.open() 
File 
 /usr/lib/python2.6/site-packages/django/core/mail/backends/smtp.py, line 
 48, in open 
  local_hostname=DNS_NAME.get_fqdn()) 
File /usr/lib64/python2.6/smtplib.py, line 239, in __init__ 
  (code, msg) = self.connect(host, port) 
File /usr/lib64/python2.6/smtplib.py, line 295, in connect 
  self.sock = self._get_socket(host, port, self.timeout) 
File /usr/lib64/python2.6/smtplib.py, line 273, in _get_socket 
  return socket.create_connection((port, host), timeout) 
File /usr/lib64/python2.6/socket.py, line 567, in 
 create_connection 
  raise error, msg 
  error: [Errno 13] Permission denied 
  
  
  Does anyone know of any causes? 
  

 Is this RHEL/CentOS 6? It's possibke that SELinux might be interfering. 
 Does it go away if you do 'setenforce 0' as root? If so, please run the 
 command: 
 audit2allow -a 

 and send me the output. 



-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Fresh install on CentOS+EPEL - manual steps necessary beyond package installation

[Paul Fee]

Hi Stephen,

Thanks for the feedback, it's encouraging to see that some of the items 
could be automated and I appreciate that others will remain manual steps 
for the reasons you've stated.

In the mean time, should we enhance the ReviewBoard documentation so that 
it lists the steps necessary to go from a fresh OS install up to a working 
ReviewBoard site?  The current page lacks some of the steps I've detailed.

https://www.reviewboard.org/docs/manual/2.0/admin/installation/linux/

The current page mixes generic steps with distro specific information, 
which may confuse new users as they try to figure out which steps to apply 
and which to skip.  Despite the risk of duplicating information, I think it 
might be clearer and more concise if we had a separate page for 
RHEL/CentOS/Fedora installation.  Similar pages could be constructed for 
other distros.

If this seems reasonable, then how do we go about updating those pages?  
What format are the pages written in?

The longer term aim is that over time as some of the steps get incorporated 
in the distro packages or within rb-site install, then the manual install 
steps will shrink.

Thanks,
Paul


On Friday, October 31, 2014 12:44:46 AM UTC, Stephen Gallagher wrote:




 On Thu, 2014-10-30 at 04:33 -0700, Paul Fee wrote: 
  Hi Stephen et al., 
  
  I'm trying to get a CentOS7+EPEL install procedure that involves 
  minimal setup.  My aim is to get most functionality into the distro 
  packages so that manual steps are reduced.  Thanks for the bugs fixes 
  and support so far. 
  
  Here's a list of the manuals steps still necessary.  I'd like feedback 
  if any of these can be automated and incorporated in a package.  For 
  those that remain manual steps, should we update the install 
  documentation to make this easier for others? 
  
  Manual steps following CentOS7 minimal install: 
  
  1. Enable EPEL 
  $ sudo yum install epel-release 
  

 EPEL is not part of the standard installation for a reason; it's 
 community-provided rather than part of the RHEL standard package set. 
 You can discuss with CentOS whether this should be available by default. 

  2. Install reviewboard, database and memcached 
  $ sudo yum install ReviewBoard mariadb-server memcached 
  
  3. Start database server and secure it 
  $ sudo systemctl enable mariadb 
  $ sudo systemctl start mariadb 
  $ sudo mysql_secure_installation 
  

 These steps we are working on in the Fedora Server product and will 
 hopefully be part of RHEL 8 (or maybe sometime later in the RHEL 7 
 lifecycle). Although our first target is postgresql, not MariaDB. Short 
 version: we intend to have a one-click mechanism to deploy a new DB via 
 the new rolekit project (Shameless plug: this is my latest effort). 


  4. Create database for use by reviewboard 
  $ mysql -u root -p 
   create user review_user@localhost identified by 'review_password'; 
   create database reviewboard; 
   GRANT ALL ON reviewboard.* TO review_user; 
  

 I'll probably try to roll this creation into the rolekit-based 
 deployment as well. 


  5. Create a reviewboard site 
  $ sudo rb-site install /var/www/reviewboard/ 
  

 This part is *very* ReviewBoard specific. We can't hard-code a path into 
 the packages and we can't automatically deploy because we don't know the 
 database information without user input (and RPM installs are 
 non-interactive, unlike Debian packages with debconf. That's a whole 
 other topic though). 


  6. Adjust httpd configuration 
  $ sudo ln 
  -s /var/www/reviewboard.bfs.tsp/conf/apache-wsgi.conf /etc/httpd/conf.d/ 
  

 This is something we could work into the package; we could potentially 
 carry a distribution-specific patch that automatically creates this 
 symlink during 'rb-site install'. Ideally, I'd like to do this as a 
 build flag upstream, so that other distributions could do so as well, 
 but a first path could be a Fedora/EPEL-specific patch. 


  7. Start web server 
  $ sudo systemctl enable memcached 
  $ sudo systemctl start memcached 
  $ sudo systemctl enable httpd 
  $ sudo systemctl start httpd 
  

 Fedora has a strict policy against *automatically* enabling services to 
 start at boot without user intervention. We *could* add a flag for 
 'rb-site install' that would say start automatically after completion, 
 but not until we've already handled item 6 above. 

 We won't be able to do so for memcached, however. Since it isn't 
 guaranteed to be running on the same system... However this does raise 
 the point that I should probably add memcached to the systemd unit file 
 so that if it IS being run on the same system, it's started in the right 
 order. Though this is a low risk of a race, since memcached isn't 
 accessed by ReviewBoard at start-up time to the best of my knowledge; 
 only on requests. So probably both will be available before clients are 
 allowed to talk to the system. 

 I'll patch that in the package but I'm not going to spin another build 
 just

Re: EPEL - rb-site upgrade failure upon reboot prevents httpd startup

[Paul Fee]

Hi Stephen,

Your fix has resolved the issue on my system.  Thanks for the rapid 
response.

Cheers,
Paul

On Wednesday, October 29, 2014 11:39:53 PM UTC, Stephen Gallagher wrote:




 On Wed, 2014-10-29 at 16:27 -0400, Stephen Gallagher wrote: 
  
  
  On Wed, 2014-10-29 at 11:04 -0700, Paul Fee wrote: 
   Hi all (and Stephen Gallagher), 
   
   I'm using CentOS7 + EPEL with ReviewBoard-2.0.11  (fresh install + 
   today's updates).  My site is listed in /etc/reviewboard/sites.  When 
   httpd starts up, it checks if any sites need upgraded.  I'm using a 
   mariadb database. 
   
   When I reboot the box, httpd fails to startup. 
   
    
   $ sudo systemctl status httpd 
   httpd.service - The Apache HTTP Server 
  Loaded: loaded (/usr/lib/systemd/system/httpd.service; enabled) 
 Drop-In: /usr/lib/systemd/system/httpd.service.d 
  └─reviewboard-sites.conf 
  Active: failed (Result: exit-code) since Wed 2014-10-29 17:42:28 
   GMT; 16s ago 
 Process: 1184 ExecStartPre=/usr/bin/rb-site upgrade --all-sites 
   (code=exited, status=1/FAILURE) 
   
   Oct 29 17:42:28 centos7 rb-site[1184]: File 
   /usr/lib/python2.7/site-packages/django/db/backends/mysql/base.py, 
   line 435, in get_new_connection 
   Oct 29 17:42:28 centos7 rb-site[1184]: conn = 
   Database.connect(**conn_params) 
   Oct 29 17:42:28 centos7 rb-site[1184]: File 
   /usr/lib64/python2.7/site-packages/MySQLdb/__init__.py, line 81, in 
   Connect 
   Oct 29 17:42:28 centos7 rb-site[1184]: return Connection(*args, 
   **kwargs) 
   Oct 29 17:42:28 centos7 rb-site[1184]: File 
   /usr/lib64/python2.7/site-packages/MySQLdb/connections.py, line 187, 
   in __init__ 
   Oct 29 17:42:28 centos7 rb-site[1184]: super(Connection, 
   self).__init__(*args, **kwargs2) 
   Oct 29 17:42:28 centos7 rb-site[1184]: 
   django.db.utils.OperationalError: (2002, Can't connect to local MySQL 
   server through socket '...k' (2)) 
   Oct 29 17:42:28 centos7 systemd[1]: httpd.service: control process 
   exited, code=exited status=1 
   Oct 29 17:42:28 centos7 systemd[1]: Failed to start The Apache HTTP 
   Server. 
   Oct 29 17:42:28 centos7 systemd[1]: Unit httpd.service entered failed 
   state. 
   Hint: Some lines were ellipsized, use -l to show in full. 
   == 
   
   I can manually start httpd as mariadb is now running by the time I've 
   logged in. 
   
   If I remove the /etc/reviewboard/sites file, the issue goes away.  If 
   I restore the file, the issue comes back. 
   
   It looks like rb-site upgrade is being run before the database is 
   available.  Should systemd be using socket activation to start mariadb 
   once a connection attempt is made?  I believe 
   the /etc/reviewboard/sites facility is unique to Fedora/EPEL, so this 
   is could be a distro issue rather than ReviewBoard. 
  
  
  MariaDB does not currently support socket-activation. What you need to 
  do as a workaround right now is to add the following lines 
  to /usr/lib/systemd/system/httpd.service.d/reviewboard-sites.conf: 
  
  
  
  [Unit] 
  After=postgresql.service mariadb.service mysql.service 
  
  
  
  I'll roll this into the Fedora and EPEL packages. I hadn't thought of it 
  previously. (Note: it's safe to list all of them on the After= line as 
  this only controls ordering; it doesn't cause any of them to be started 
  that would not already have been). 
  
  Now I just have to hope that Apache never grows a dependency on a 
  database... :) 
  

 Fedora 21: 

 https://admin.fedoraproject.org/updates/FEDORA-2014-13850/ReviewBoard-2.0.11-2.fc21
  

 EPEL 7: 
 https://admin.fedoraproject.org/updates/ReviewBoard-2.0.11-2.el7 



-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Fresh install on CentOS+EPEL - manual steps necessary beyond package installation

[Paul Fee]

Hi Stephen et al.,

I'm trying to get a CentOS7+EPEL install procedure that involves minimal 
setup.  My aim is to get most functionality into the distro packages so 
that manual steps are reduced.  Thanks for the bugs fixes and support so 
far.

Here's a list of the manuals steps still necessary.  I'd like feedback if 
any of these can be automated and incorporated in a package.  For those 
that remain manual steps, should we update the install documentation to 
make this easier for others?

Manual steps following CentOS7 minimal install:

1. Enable EPEL
$ sudo yum install epel-release

2. Install reviewboard, database and memcached
$ sudo yum install ReviewBoard mariadb-server memcached

3. Start database server and secure it
$ sudo systemctl enable mariadb
$ sudo systemctl start mariadb
$ sudo mysql_secure_installation

4. Create database for use by reviewboard
$ mysql -u root -p
 create user review_user@localhost identified by 'review_password';
 create database reviewboard;
 GRANT ALL ON reviewboard.* TO review_user;

5. Create a reviewboard site
$ sudo rb-site install /var/www/reviewboard/

6. Adjust httpd configuration
$ sudo ln -s /var/www/reviewboard.bfs.tsp/conf/apache-wsgi.conf 
/etc/httpd/conf.d/

7. Start web server
$ sudo systemctl enable memcached
$ sudo systemctl start memcached
$ sudo systemctl enable httpd
$ sudo systemctl start httpd

8. Adjust site file permissions
$ sudo chown -R apache /var/www/reviewboard/data 
/var/www/reviewboard/htdocs/media/ext 
/var/www/reviewboard/htdocs/static/ext 
/var/www/reviewboard/htdocs/media/uploaded

9. Adjust site SELinux permissions
$ sudo setsebool -P httpd_can_network_memcache 1
$ sudo chcon --type=httpd_sys_rw_content_t /var/www/reviewboard/data
$ sudo chcon --type=httpd_sys_rw_content_t 
/var/www/reviewboard/htdocs/media/ext
$ sudo chcon --type=httpd_sys_rw_content_t 
/var/www/reviewboard/htdocs/static/ext

10. Open port 80 on firewall
$ sudo firewall-cmd --add-port=80/tcp
$ sudo firewall-cmd --permanent --add-port=80/tcp

My understanding of packaging guidelines is that Fedora/RHEL packages 
shouldn't start services automatically, so perhaps these steps will always 
be necessary.  Also the site directory does not below to the ReviewBoard 
package, so only rb-site would be able to fix the permission issues 
(steps 8 and 9).

Have I missed anything in this list?  Can any of these steps be 
incorporated in the ReviewBoard package or within the rb-site command?  
Perhaps rb-site could include hooks for distros to plug into their own 
customisations, e.g. SELinux configuration on Fedora/RHEL.

Thanks,
Paul

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

EPEL - rb-site upgrade failure upon reboot prevents httpd startup

[Paul Fee]

Hi all (and Stephen Gallagher),

I'm using CentOS7 + EPEL with ReviewBoard-2.0.11  (fresh install + today's 
updates).  My site is listed in /etc/reviewboard/sites.  When httpd starts 
up, it checks if any sites need upgraded.  I'm using a mariadb database.

When I reboot the box, httpd fails to startup.


$ sudo systemctl status httpd
httpd.service - The Apache HTTP Server
   Loaded: loaded (/usr/lib/systemd/system/httpd.service; enabled)
  Drop-In: /usr/lib/systemd/system/httpd.service.d
   └─reviewboard-sites.conf
   Active: failed (Result: exit-code) since Wed 2014-10-29 17:42:28 GMT; 
16s ago
  Process: 1184 ExecStartPre=/usr/bin/rb-site upgrade --all-sites 
(code=exited, status=1/FAILURE)

Oct 29 17:42:28 centos7 rb-site[1184]: File 
/usr/lib/python2.7/site-packages/django/db/backends/mysql/base.py, line 
435, in get_new_connection
Oct 29 17:42:28 centos7 rb-site[1184]: conn = 
Database.connect(**conn_params)
Oct 29 17:42:28 centos7 rb-site[1184]: File 
/usr/lib64/python2.7/site-packages/MySQLdb/__init__.py, line 81, in 
Connect
Oct 29 17:42:28 centos7 rb-site[1184]: return Connection(*args, **kwargs)
Oct 29 17:42:28 centos7 rb-site[1184]: File 
/usr/lib64/python2.7/site-packages/MySQLdb/connections.py, line 187, in 
__init__
Oct 29 17:42:28 centos7 rb-site[1184]: super(Connection, 
self).__init__(*args, **kwargs2)
Oct 29 17:42:28 centos7 rb-site[1184]: django.db.utils.OperationalError: 
(2002, Can't connect to local MySQL server through socket '...k' (2))
Oct 29 17:42:28 centos7 systemd[1]: httpd.service: control process exited, 
code=exited status=1
Oct 29 17:42:28 centos7 systemd[1]: Failed to start The Apache HTTP Server.
Oct 29 17:42:28 centos7 systemd[1]: Unit httpd.service entered failed state.
Hint: Some lines were ellipsized, use -l to show in full.
==

I can manually start httpd as mariadb is now running by the time I've 
logged in.

If I remove the /etc/reviewboard/sites file, the issue goes away.  If I 
restore the file, the issue comes back.

It looks like rb-site upgrade is being run before the database is 
available.  Should systemd be using socket activation to start mariadb once 
a connection attempt is made?  I believe the /etc/reviewboard/sites 
facility is unique to Fedora/EPEL, so this is could be a distro issue 
rather than ReviewBoard.

Thanks,
Paul

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: httpd remains in 'starting' state when starting via systemctl

[Paul Fee]

Hi Stephen,

I don't recall exact details, but I've seen the rb-site upgrade command 
fail on occasion.  I think in my case the sequence was:

* yum update   [Included a reviewboard update]
* reboot
* While httpd service was starting rb-site upgrade was invoked.
* rb-site upgrade failed because mariadb had not started yet.

I manually fixed the issue by starting mariadb and running rb-site upgrade 
by hand.  However it does appear there's a race condition between httpd 
startup and rb-site's dependency on the database being available.

I'm not sure if this matches David's problem, but hopefully the above 
sequence will help you reproduce his issue and enhance the auto upgrade 
feature you implemented for Fedora packages.

Thanks,
Paul

On Wednesday, September 24, 2014 1:14:34 AM UTC+1, David Carson wrote:



 On Tuesday, September 23, 2014 7:10:51 PM UTC-4, Stephen Gallagher wrote:

 On 09/23/2014 03:38 PM, David Carson wrote: 
  After following all directions for installing ReviewBoard 2.0 on CentOS 
  7, I am still seeing one error that bothers me.  When I try to restart 
  httpd, it remains in *'starting'* state and will never go to *'active 
  (running)'* state.  However, if I remove the following file, httpd 
  starts and stops properly. 
  
 /usr/lib/systemd/system/httpd.service.d/reviewboards-sites.conf 
  
  I only discovered this file because there was an error in 
  /var/log/messages regarding the line type=oneshot (which should be 
  *T*ype=oneshot).  After correcting the spelling, I no longer see the 
  error, but I cannot start httpd either. 
  
  I have moved this file out of the way, and my ReviewBoard installation 
  is now working, at least to the point of bringing up the interface and 
  allowing me to login as admin.  But I'm wondering what the 
 repercussions 
  of removing the systemd file might be. 
  

 I'll field this one, since this bit is unique to my packages. The 
 purpose of that oneshot target is to guarantee that the Review Board 
 automatically runs 'rb-site upgrade' for all sites when it is started up 
 (thus guaranteeing that if you perform an RPM upgrade, it will upgrade 
 Review Board the next time it is started. 

 I'm curious why it's hanging during the upgrade step, though. Can you 
 check the journal for what's happening when you see that? 

 The command 'journalctl -e -u httpd.service' should give you the output. 
 It's possible that there's a bug in the upgrade routine. Have you 
 checked for SELinux denials? 


 Stephen,
 This is an internal-only server, so I turned off SELinux before doing 
 anything else (and rebooted, of course).

 The journalctl command seems to indicate that the update finished:


 -- Logs begin at Tue 2014-09-23 18:56:22 EDT, end at Tue 2014-09-23 
 19:50:32 EDT. --
 :
 :
 Sep 23 19:50:13 pinehurst.e.com systemd[1]: Stopping The Apache HTTP 
 Server...
 Sep 23 19:50:14 pinehurst.e.com systemd[1]: Starting The Apache HTTP 
 Server...
 Sep 23 19:50:14 pinehurst.e.com systemd[1]: Started The Apache HTTP 
 Server.
 Sep 23 19:50:27 pinehurst.e.com systemd[1]: Stopping The Apache HTTP 
 Server...
 Sep 23 19:50:28 pinehurst.e.com systemd[1]: Starting The Apache HTTP 
 Server...
 Sep 23 19:50:32 pinehurst.e.com rb-site[3228]: Rebuilding directory 
 structure
 Sep 23 19:50:32 pinehurst.e.com rb-site[3228]: Updating database. This 
 may take a while.
 Sep 23 19:50:32 pinehurst.e.com rb-site[3228]: The log output below, 
 including warnings and errors,
 Sep 23 19:50:32 pinehurst.e.com rb-site[3228]: can be ignored unless 
 upgrade fails.
 Sep 23 19:50:32 pinehurst.e.com rb-site[3228]: -- begin 
 log output --
 Sep 23 19:50:32 pinehurst.e.com rb-site[3228]: Creating tables ...
 Sep 23 19:50:32 pinehurst.e.com rb-site[3228]: Installing custom SQL ...
 Sep 23 19:50:32 pinehurst.e.com rb-site[3228]: Installing indexes ...
 Sep 23 19:50:32 pinehurst.e.com rb-site[3228]: Installed 0 object(s) from 
 0 fixture(s)
 Sep 23 19:50:32 pinehurst.e.com rb-site[3228]: No evolution required.
 Sep 23 19:50:32 pinehurst.e.com rb-site[3228]: --- end 
 log output ---
 Sep 23 19:50:32 pinehurst.e.com rb-site[3228]: Resetting in-database 
 caches.
 Sep 23 19:50:32 pinehurst.e.com rb-site[3228]: *Upgrade complete!* 



 But the systemctl command itself is sitting there, not returning to the 
 command prompt, and the status shows that it is still activating, but never 
 activated:

 (0)[root@pinehurst ~] systemctl status httpd.service
 httpd.service - The Apache HTTP Server
 Loaded: loaded (/usr/lib/systemd/system/httpd.service; enabled)
 Drop-In: /usr/lib/systemd/system/httpd.service.d
 └─reviewboard-sites.conf
 *Active: activating (start) *since Tue 2014-09-23 19:50:28 EDT; 11min ago
 Process: 3223 ExecStop=/bin/kill -WINCH ${MAINPID} (code=exited, 
 status=0/SUCCESS)
 Process: 3228 ExecStartPre=/usr/bin/rb-site upgrade --all-sites 
 (code=exited, status=0/SUCCESS)
 Main PID: 3235 (httpd)
 Status

Re: RBTools 0.6.2 is released

[Paul Fee]

Hi Stephen,

Nice to see RBTools packaged for EPEL7.  What's the status of ReviewBoard2 
for EPEL7?  Need any help?

Thanks,
Paul

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Fedora rawhide: RB Dashboard missing Edit Columns button and column styling

[Paul Fee]

Thanks Stephen and Christian, I've downloaded the rawhide updates from Koji 
and confirmed they've fixed this issue.

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Fedora rawhide: RB Dashboard missing Edit Columns button and column styling

[Paul Fee]

Hi Stephen,

Comparing the HTML using Firefox/Firebug, I see both good and bad pages
have the correct HTML to display the Edit columns heading.  However the
bad page has missing CSS styling.

On Fedora rawhide, with an up to date locate database, I can see an empty
CSS file that looks suspicious.

$ ls -l `locate datagrid | grep css`
-rw-r--r--. 1 root root 6251 May 27 15:03
/usr/lib/python2.7/site-packages/djblets/htdocs/static/djblets/css/datagrid.css
-rw-r--r--. 1 root root 6316 May 27 15:03
/usr/lib/python2.7/site-packages/djblets/htdocs/static/djblets/css/datagrid.da6c340af879.css
-rw-r--r--. 1 root root 6316 May 27 02:01
/usr/lib/python2.7/site-packages/djblets/htdocs/static/djblets/css/datagrid.min.6521a0d8b348.css
-rw-r--r--. 1 root root0 May 27 15:03
/usr/lib/python2.7/site-packages/djblets/htdocs/static/djblets/css/datagrid.min.css
-rw-r--r--. 1 root root0 May 27 15:03
/usr/lib/python2.7/site-packages/djblets/htdocs/static/djblets/css/datagrid.min.d41d8cd98f00.css
-rw-r--r--. 1 root root 6251 May 27 02:01
/usr/lib/python2.7/site-packages/djblets/static/djblets/css/datagrid.css

I expect those two empty files are (part of) the problem.

According to rpm -qf they're both owned by
python-djblets-0.8.1-1.fc21.noarch.

Thanks,
Paul


On 2 June 2014 14:14, Stephen Gallagher step...@gallagherhome.com wrote:

 On 05/30/2014 01:58 PM, Stephen Gallagher wrote:
  On 05/30/2014 12:57 PM, Paul Fee wrote:
  Hi all,
 
  On my Fedora rawhide system with RB2.0 the dashboard doesn't look right.
 
  * The column headers are missing their styling.
  * The Edit Columns button is missing.
 
  I see this with a freshly created site as illustrated below:
 
 
 
 
  There's no issue with RB1.7.25 on Centos6 nor RB2.0.1 hosted at
  http://demo.reviewboard.org/
 
 
 
  I'm suspecting the issue is unique to the Rawhide packages.  Has anyone
  else seen this or able to reproduce?
 
 
  I saw that on an instance I created the other day as well. I'll look
  into it next week.
 

 Ok, I'm pretty stumped here. There's nothing obviously wrong with the
 build [1] [2], but I'm getting output that is apparently *slightly*
 malformed, such that neither Chrome or Firefox will render it properly.
 I do not have a strong background in HTML/JS, so I can't spot the issue.
 I'm attaching the saved page, hopefully someone can take a look and tell
 me where I screwed up.


 [1]

 https://kojipkgs.fedoraproject.org//packages/python-djblets/0.8.1/1.fc21/data/logs/noarch/build.log
 [2]

 https://kojipkgs.fedoraproject.org//packages/ReviewBoard/2.0.1/1.fc21/data/logs/noarch/build.log

 --
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to a topic in the
 Google Groups reviewboard group.
 To unsubscribe from this topic, visit
 https://groups.google.com/d/topic/reviewboard/31p7hxUkUX4/unsubscribe.
 To unsubscribe from this group and all its topics, send an email to
 reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.


-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Problems upgrading from RB1.5 to RB2.0RC3

[Paul Fee]

Thank you Christian and Stephen,

I'm now able to upgrade my RB1.5 database to RB2.0 using the packages from 
Fedora Rawhide.

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Announcing the release of Review Board 2.0!

[Paul Fee]

Thanks, it's working now following the python-djblets-0.8-7 update.

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Announcing the release of Review Board 2.0!

[Paul Fee]

Hi Stephen,

I updated a rawhide machine to ReviewBoard-2.0-12.fc21.noarch.

Upon invoking rb-site, instead of usage help, I get the following error:
===
$ rb-site 
Traceback (most recent call last):
  File /usr/bin/rb-site, line 5, in module
from pkg_resources import load_entry_point
  File /usr/lib/python2.7/site-packages/pkg_resources.py, line 2713, in 
module
parse_requirements(__requires__), Environment()
  File /usr/lib/python2.7/site-packages/pkg_resources.py, line 567, in 
resolve
raise DistributionNotFound(req)
pkg_resources.DistributionNotFound: Djblets=0.8,0.9
===

According to rpm the ReviewBoard package has its dependencies satisfied:

$ rpm -q --requires ReviewBoard | grep djblets
python-djblets = 0.8-6
$ rpm -q python-djblets
python-djblets-0.8-6.fc21.rc2.noarch

Any ideas why rb-site isn't satisfied at runtime with the version of 
Djblets?

Looking in 
/usr/lib/python2.7/site-packages/Djblets-0.8rc2-py2.7.egg-info/PKG-INFO, I 
see Version: 0.8rc2.  Would the rc2 interfere with the version comparison?

Thanks,
Paul

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Problems upgrading from RB1.5 to RB2.0RC3

[Paul Fee]

)
  File /usr/lib/python2.7/site-packages/django/core/management/base.py, 
line 242, in run_from_argv
self.execute(*args, **options.__dict__)
  File /usr/lib/python2.7/site-packages/django/core/management/base.py, 
line 285, in execute
output = self.handle(*args, **options)
  File 
/usr/lib/python2.7/site-packages/django_evolution/management/commands/evolve.py,
 
line 65, in handle
self.evolve(*app_labels, **options)
  File 
/usr/lib/python2.7/site-packages/django_evolution/management/commands/evolve.py,
 
line 125, in evolve
sql.extend(self.evolve_app(app))
  File 
/usr/lib/python2.7/site-packages/django_evolution/management/commands/evolve.py,
 
line 165, in evolve_app
app_mutator_sql = app_mutator.to_sql()
  File /usr/lib/python2.7/site-packages/django_evolution/mutators.py, 
line 303, in to_sql
sql.extend(mutator.to_sql())
  File /usr/lib/python2.7/site-packages/django_evolution/mutators.py, 
line 186, in to_sql
return self.evolver.generate_table_ops_sql(self, self._ops)
  File /usr/lib/python2.7/site-packages/django_evolution/db/common.py, 
line 42, in generate_table_ops_sql
prev_sql_result, prev_op)
  File /usr/lib/python2.7/site-packages/django_evolution/db/common.py, 
line 92, in generate_table_op_sql
sql_result.add(op['sql'])
  File 
/usr/lib/python2.7/site-packages/django_evolution/db/sql_result.py, line 
105, in add
super(AlterTableSQLResult, self).add(sql_result)
  File 
/usr/lib/python2.7/site-packages/django_evolution/db/sql_result.py, line 
30, in add
self.sql += sql_or_result
TypeError: 'NoneType' object is not iterable
===

Anyone got ideas on what's wrong here?  Shall I collect more information to 
help with debugging?

Thanks,
Paul

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Reviewboard 2.0: rb-site upgrade failed migrating from 1.5.

[Paul Fee]

Hi Chris,

I replaced ) ENGINE=MyISAM with ) ENGINE=InnoDB in my database dump and
repeated the import.  This fixed the Foreign key constraint is incorrectly
formed errors.

Thanks for that tip, mysql table types may be outside the scope of rb-site
upgrade, however if the upgrade could recognise this error and give an
informative error message it may help others with future migrations,
allowing them to fix the error themselves.

The upgrade now proceeds past the Creating table X section, but I still
get 'NoneType' object is not iterable errors:

=
Installing custom SQL ...
Installing indexes ...
Installed 0 object(s) from 0 fixture(s)
Registering new SCM Tool Plastic SCM
(reviewboard.scmtools.plastic.PlasticTool) in database
ERROR:root:Unexpected error: 'NoneType' object is not iterable
Traceback (most recent call last):
  File
/usr/lib/python2.7/site-packages/django_evolution/management/commands/evolve.py,
line 65, in handle
self.evolve(*app_labels, **options)
  File
/usr/lib/python2.7/site-packages/django_evolution/management/commands/evolve.py,
line 125, in evolve
sql.extend(self.evolve_app(app))
  File
/usr/lib/python2.7/site-packages/django_evolution/management/commands/evolve.py,
line 165, in evolve_app
app_mutator_sql = app_mutator.to_sql()
  File /usr/lib/python2.7/site-packages/django_evolution/mutators.py,
line 303, in to_sql
sql.extend(mutator.to_sql())
  File /usr/lib/python2.7/site-packages/django_evolution/mutators.py,
line 186, in to_sql
return self.evolver.generate_table_ops_sql(self, self._ops)
  File /usr/lib/python2.7/site-packages/django_evolution/db/common.py,
line 42, in generate_table_ops_sql
prev_sql_result, prev_op)
  File /usr/lib/python2.7/site-packages/django_evolution/db/common.py,
line 92, in generate_table_op_sql
sql_result.add(op['sql'])
  File
/usr/lib/python2.7/site-packages/django_evolution/db/sql_result.py, line
105, in add
super(AlterTableSQLResult, self).add(sql_result)
  File
/usr/lib/python2.7/site-packages/django_evolution/db/sql_result.py, line
30, in add
self.sql += sql_or_result
TypeError: 'NoneType' object is not iterable
Traceback (most recent call last):
  File /bin/rb-site, line 9, in module
load_entry_point('ReviewBoard==2.0rc2', 'console_scripts', 'rb-site')()
  File /usr/lib/python2.7/site-packages/reviewboard/cmdline/rbsite.py,
line 1733, in main
command.run()
  File /usr/lib/python2.7/site-packages/reviewboard/cmdline/rbsite.py,
line 1556, in run
site.migrate_database()
  File /usr/lib/python2.7/site-packages/reviewboard/cmdline/rbsite.py,
line 425, in migrate_database
self.run_manage_command(evolve, [--noinput, --execute])
  File /usr/lib/python2.7/site-packages/reviewboard/cmdline/rbsite.py,
line 626, in run_manage_command
execute_from_command_line([__file__, cmd] + params)
  File
/usr/lib/python2.7/site-packages/django/core/management/__init__.py, line
399, in execute_from_command_line
utility.execute()
  File
/usr/lib/python2.7/site-packages/django/core/management/__init__.py, line
392, in execute
self.fetch_command(subcommand).run_from_argv(self.argv)
  File /usr/lib/python2.7/site-packages/django/core/management/base.py,
line 242, in run_from_argv
self.execute(*args, **options.__dict__)
  File /usr/lib/python2.7/site-packages/django/core/management/base.py,
line 285, in execute
output = self.handle(*args, **options)
  File
/usr/lib/python2.7/site-packages/django_evolution/management/commands/evolve.py,
line 65, in handle
self.evolve(*app_labels, **options)
  File
/usr/lib/python2.7/site-packages/django_evolution/management/commands/evolve.py,
line 125, in evolve
sql.extend(self.evolve_app(app))
  File
/usr/lib/python2.7/site-packages/django_evolution/management/commands/evolve.py,
line 165, in evolve_app
app_mutator_sql = app_mutator.to_sql()
  File /usr/lib/python2.7/site-packages/django_evolution/mutators.py,
line 303, in to_sql
sql.extend(mutator.to_sql())
  File /usr/lib/python2.7/site-packages/django_evolution/mutators.py,
line 186, in to_sql
return self.evolver.generate_table_ops_sql(self, self._ops)
  File /usr/lib/python2.7/site-packages/django_evolution/db/common.py,
line 42, in generate_table_ops_sql
prev_sql_result, prev_op)
  File /usr/lib/python2.7/site-packages/django_evolution/db/common.py,
line 92, in generate_table_op_sql
sql_result.add(op['sql'])
  File
/usr/lib/python2.7/site-packages/django_evolution/db/sql_result.py, line
105, in add
super(AlterTableSQLResult, self).add(sql_result)
  File
/usr/lib/python2.7/site-packages/django_evolution/db/sql_result.py, line
30, in add
self.sql += sql_or_result
TypeError: 'NoneType' object is not iterable
===

Can you help with this problem?

Thanks,
Paul


On 1 May 2014 19:01, Christian Hammond chip...@chipx86.com wrote:

 Hi Paul,

 Your database is using MyISAM while MySQL is configuring new databases to
 use InnoDB. You'll need to edit your database dump

Re: Reviewboard 2.0: rb-site upgrade failed migrating from 1.5.

[Paul Fee]

 self.evolver.generate_table_ops_sql(self, self._ops)
  File /usr/lib/python2.7/site-packages/django_evolution/db/common.py, 
line 42, in generate_table_ops_sql
prev_sql_result, prev_op)
  File /usr/lib/python2.7/site-packages/django_evolution/db/common.py, 
line 92, in generate_table_op_sql
sql_result.add(op['sql'])
  File 
/usr/lib/python2.7/site-packages/django_evolution/db/sql_result.py, line 
105, in add
super(AlterTableSQLResult, self).add(sql_result)
  File 
/usr/lib/python2.7/site-packages/django_evolution/db/sql_result.py, line 
30, in add
self.sql += sql_or_result
TypeError: 'NoneType' object is not iterable
===

On your code review, you say you tested RB1.5 and RB1.6 upgrades to RB2.0 
and they passed.  Can I collect more information for you to identify why 
this RB1.5 to 2.0 migration failed?
https://reviews.reviewboard.org/r/5756/

Thanks,
Paul

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Reviewboard 2.0: rb-site upgrade failed migrating from 1.5.

[Paul Fee]

Hi Chris,

I repeated the test to ensure the database wasn't empty.  I confirmed that
I'd imported the RB1.5 database, ready for rb-site upgrade.

Steps:
# rb-site install /var/www/reviewboard
mysql drop database reviewboard;
mysql create database reviewboard;
# mysql -uroot -p reviewboard  ~/reviewboard.mysql.dump   = Note
reviewboard database is no longer empty, it contains content from RB1.5
from a separate machine.
# rb-site upgrade /var/www/reviewboard


Result: Same failure as previously posted.
django.db.utils.OperationalError: (1054, Unknown column
'diffviewer_filediff.diff_hash_id' in 'where clause')

This migration procedure works on Centos6.5 with RB1.7.22, but failed on
Fedora rawhide with RB2.0RC2 (from Stephen Gallagher's COPR repo).

Is there more info I can collect to help debug?  How far back does RB2.0
support an upgrade from?  Should I upgrade via an intermediate version?

Thanks,
Paul


On 18 April 2014 20:00, Christian Hammond chip...@chipx86.com wrote:

 Hi Paul,

 rb-site upgrade isn't meant to be used on a completely empty database. It
 expects an existing install, so when you dropped and recreated the
 database, it was unable to find the state it needs to perform an actual
 upgrade.

 If you need to just start fresh from a database, you can re-run install,
 or:

 $ rb-site manage /path/to/site syncdb

 That should generate a fresh new database (if there isn't already any
 schema).

 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board - http://www.reviewboard.org
 Beanbag, Inc. - http://www.beanbaginc.com


 On Fri, Apr 18, 2014 at 4:54 AM, Paul Fee paul.f@gmail.com wrote:

 Hi all,

 I was testing migration from a 1.5 system to 2.0RC2.

 I took a mysql dump from the old system and copied it to the new system.
 Following an rb-site install on the new system, I dropped and recreated
 the reviewboard database, then tried rb-site upgrade path.

 This procedure worked on CentOS6/EPEL/ReviewBoard 1.7.22, however with
 Fedora rawhide/COPR/Reviewboard 2.0RC2, I get this error:

 $ sudo rb-site upgrade /var/www/reviewboard
 Traceback (most recent call last):
   File /bin/rb-site, line 9, in module
 load_entry_point('ReviewBoard==2.0rc2', 'console_scripts',
 'rb-site')()
   File /usr/lib/python2.7/site-packages/reviewboard/cmdline/rbsite.py,
 line 1727, in main
 command.run()
   File /usr/lib/python2.7/site-packages/reviewboard/cmdline/rbsite.py,
 line 1530, in run
 diff_dedup_needed = site.get_diff_dedup_needed()
   File /usr/lib/python2.7/site-packages/reviewboard/cmdline/rbsite.py,
 line 443, in get_diff_dedup_needed
 return FileDiff.objects.unmigrated().count()  0
   File /usr/lib/python2.7/site-packages/django/db/models/query.py, line
 291, in count
 return self.query.get_count(using=self.db)
   File /usr/lib/python2.7/site-packages/django/db/models/sql/query.py,
 line 390, in get_count
 number = obj.get_aggregation(using=using)[None]
   File /usr/lib/python2.7/site-packages/django/db/models/sql/query.py,
 line 356, in get_aggregation
 result = query.get_compiler(using).execute_sql(SINGLE)
   File
 /usr/lib/python2.7/site-packages/django/db/models/sql/compiler.py, line
 782, in execute_sql
 cursor.execute(sql, params)
   File /usr/lib/python2.7/site-packages/django/db/backends/util.py,
 line 53, in execute
 return self.cursor.execute(sql, params)
   File /usr/lib/python2.7/site-packages/django/db/utils.py, line 99, in
 __exit__
 six.reraise(dj_exc_type, dj_exc_value, traceback)
   File /usr/lib/python2.7/site-packages/django/db/backends/util.py,
 line 53, in execute
 return self.cursor.execute(sql, params)
   File
 /usr/lib/python2.7/site-packages/django/db/backends/mysql/base.py, line
 124, in execute
 return self.cursor.execute(query, args)
   File /usr/lib64/python2.7/site-packages/MySQLdb/cursors.py, line 174,
 in execute
 self.errorhandler(self, exc, value)
   File /usr/lib64/python2.7/site-packages/MySQLdb/connections.py, line
 36, in defaulterrorhandler
 raise errorclass, errorvalue
 django.db.utils.OperationalError: (1054, Unknown column
 'diffviewer_filediff.diff_hash_id' in 'where clause')

 Since this worked with reviewboard 1.7, I presume this is a bug in 2.0.
 Would you like more data to help diagnose the issue?

 Thanks,
 Paul

 --
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google Groups
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an
 email to reviewboard+unsubscr...@googlegroups.com.

 For more options, visit https://groups.google.com/d/optout.


  --
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com

memcached problems following 1.5 to 1.7.22 migration

[Paul Fee]

Hi all,

I'm testing a migration from 1.5 to 1.7.22.

Summary of migration steps.

Old system:
=
Ubuntu 10.04
Manual installation of Reviewboard 1.5
Dump database: $ mysqldump -u admin -p reviewboard  
/tmp/reviewboard.mysql.dump

New system (separate host, don't want to risk in place upgrade)
==
Minimal install of CentOS 6.5
Add EPEL repo
yum install ReviewBoard mysql-server memcached system-config-firewall-tui
Setup mysql user and create fresh reviewboard database.
rb-site install path
Drop mysql reviewboard database.
Copy mysql dump from old system
Import database: mysql -p reviewboard  reviewboard.mysql.dump
rb-site upgrade path

The upgrade works, the old reviews and users are present.  However the new 
system isn't using memcached.

On the Admin UI, the server cache page reports:

Cache backend:

django.core.cache.backends.memcached.CacheClass

Statistics are not available for this backend


Manual telnet to memcached, port 11211, then issue stats command shows no 
activity:
==
STAT cmd_get 0
STAT cmd_set 0
STAT cmd_flush 0
STAT get_hits 0
STAT get_misses 0
STAT delete_misses 0
STAT delete_hits 0
STAT incr_misses 0
STAT incr_hits 0
STAT decr_misses 0
STAT decr_hits 0
STAT cas_misses 0
STAT cas_hits 0
STAT cas_badval 0
==

Looking into the memcached settings, I see that 
site/conf/settings_local.py has:
# Cache backend settings.
CACHES = {
'default': {
'BACKEND': 'django.core.cache.backends.memcached.MemcachedCache',
'LOCATION': 'localhost:11211',
},
}

However within the reviewboard database in mysql, the 
siteconfig_siteconfiguration table has:
cache_backend: {default: {LOCATION: [localhost:11211], BACKEND: 
django.core.cache.backends.memcached.CacheClass}}

To me it looks like the settings_local.py configuration has come from 
reviewboard 1.7.22 as a result of rb-site install and the mysql 
configuration from reviewboard 1.5 as a result of importing the dump from 
the old system.

The old system is using Django 1.2.3, the new one Django 1.4.8.

The bug appears to be that rb-site upgrade hasn't adjusted the 
siteconfig_siteconfiguration table to take account of the new memcached 
class used in Django 1.4.8.

Is my analysis accurate?  Should I manually adjust the 
siteconfig_siteconfiguration table to fix this?  Can this be fixed in 
reviewboard so others don't experience the same issue?

Thanks,
Paul

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reviewboard 2.0: rb-site upgrade failed migrating from 1.5.

[Paul Fee]

Hi all,

I was testing migration from a 1.5 system to 2.0RC2.

I took a mysql dump from the old system and copied it to the new system.  
Following an rb-site install on the new system, I dropped and recreated 
the reviewboard database, then tried rb-site upgrade path.

This procedure worked on CentOS6/EPEL/ReviewBoard 1.7.22, however with 
Fedora rawhide/COPR/Reviewboard 2.0RC2, I get this error:

$ sudo rb-site upgrade /var/www/reviewboard
Traceback (most recent call last):
  File /bin/rb-site, line 9, in module
load_entry_point('ReviewBoard==2.0rc2', 'console_scripts', 'rb-site')()
  File /usr/lib/python2.7/site-packages/reviewboard/cmdline/rbsite.py, 
line 1727, in main
command.run()
  File /usr/lib/python2.7/site-packages/reviewboard/cmdline/rbsite.py, 
line 1530, in run
diff_dedup_needed = site.get_diff_dedup_needed()
  File /usr/lib/python2.7/site-packages/reviewboard/cmdline/rbsite.py, 
line 443, in get_diff_dedup_needed
return FileDiff.objects.unmigrated().count()  0
  File /usr/lib/python2.7/site-packages/django/db/models/query.py, line 
291, in count
return self.query.get_count(using=self.db)
  File /usr/lib/python2.7/site-packages/django/db/models/sql/query.py, 
line 390, in get_count
number = obj.get_aggregation(using=using)[None]
  File /usr/lib/python2.7/site-packages/django/db/models/sql/query.py, 
line 356, in get_aggregation
result = query.get_compiler(using).execute_sql(SINGLE)
  File /usr/lib/python2.7/site-packages/django/db/models/sql/compiler.py, 
line 782, in execute_sql
cursor.execute(sql, params)
  File /usr/lib/python2.7/site-packages/django/db/backends/util.py, line 
53, in execute
return self.cursor.execute(sql, params)
  File /usr/lib/python2.7/site-packages/django/db/utils.py, line 99, in 
__exit__
six.reraise(dj_exc_type, dj_exc_value, traceback)
  File /usr/lib/python2.7/site-packages/django/db/backends/util.py, line 
53, in execute
return self.cursor.execute(sql, params)
  File /usr/lib/python2.7/site-packages/django/db/backends/mysql/base.py, 
line 124, in execute
return self.cursor.execute(query, args)
  File /usr/lib64/python2.7/site-packages/MySQLdb/cursors.py, line 174, 
in execute
self.errorhandler(self, exc, value)
  File /usr/lib64/python2.7/site-packages/MySQLdb/connections.py, line 
36, in defaulterrorhandler
raise errorclass, errorvalue
django.db.utils.OperationalError: (1054, Unknown column 
'diffviewer_filediff.diff_hash_id' in 'where clause')

Since this worked with reviewboard 1.7, I presume this is a bug in 2.0.  
Would you like more data to help diagnose the issue?

Thanks,
Paul

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Required vs Optional Reviewers

[Paul Fee]

Also, on review notification emails, people get email to them and the group 
gets CCed.  Which fits what the OP asked for.

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: ReviewBoard server tips over about twice a week

[Paul Fee]

MaxRequestsPerChild of 4000 should be fine.  I happen to have mine 
configured to 3000.  I didn't find the root cause of my server's lock ups, 
at the time I noted increased memory use by Apache.  A few months of 
evidence shows the change to be effective.  BTW I'm running RB 1.5 on an 
old Ubuntu release, so my problems may well have been fixed in more recent 
versions.  I expect you've got server issues different from mine, but 
MaxRequestsPerChild shouldn't do any harm.

On Wednesday, September 11, 2013 4:19:17 PM UTC+1, Steve wrote:

 Thanks Paul, that's helpful. We're using the prefork MPM.  Do you think 
 4000 is too large a number for MaxRequetsPerChild?

 --Steve

 On Wednesday, September 11, 2013 2:15:35 AM UTC-7, Paul Fee wrote:

 Your httpd.conf suggests you've got mod_status enabled.  Therefore visit 
 the /server-status URL on your web server.  This should cause Apache httpd 
 to provide a page that summarises the status of all its workers.  That may 
 help you understand why you've got more httpd processes than expected.

 Also, I've found the MaxRequestsPerChild directive to be useful on an 
 installation of mine that would lock up occasionally.  Your config shows 
 the directive set to 4000 for the prefork MPM, but 0 (infinity) for the 
 worker MPM.  Check which MPM you're using (execute httpd -V) and ensure 
 that MaxRequestsPerChild is taking effect.  The config file contains a set 
 of MPM tuning directives, duplicated for prefork and worker, make sure the 
 required configuration is actually active.

 -- 
 Paul

 On Tuesday, September 10, 2013 11:36:59 PM UTC+1, Steve wrote:

 I see the 'server cache' information in the admin page.  It shows the 
 memory usage at around 150MB, so clearly 64MB was not enough. 
  Unfortunately, the load average once again climbed over 100 and I had 
 close to 200 apache processes running.  It's baffling.  Can you guide me on 
 how to limit the number of apache processes and threads?  I've attached the 
 apache httpd.conf file.

 Thanks Christian.

 --steve



-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: ReviewBoard server tips over about twice a week

[Paul Fee]

Your httpd.conf suggests you've got mod_status enabled.  Therefore visit 
the /server-status URL on your web server.  This should cause Apache httpd 
to provide a page that summarises the status of all its workers.  That may 
help you understand why you've got more httpd processes than expected.

Also, I've found the MaxRequestsPerChild directive to be useful on an 
installation of mine that would lock up occasionally.  Your config shows 
the directive set to 4000 for the prefork MPM, but 0 (infinity) for the 
worker MPM.  Check which MPM you're using (execute httpd -V) and ensure 
that MaxRequestsPerChild is taking effect.  The config file contains a set 
of MPM tuning directives, duplicated for prefork and worker, make sure the 
required configuration is actually active.

-- 
Paul

On Tuesday, September 10, 2013 11:36:59 PM UTC+1, Steve wrote:

 I see the 'server cache' information in the admin page.  It shows the 
 memory usage at around 150MB, so clearly 64MB was not enough. 
  Unfortunately, the load average once again climbed over 100 and I had 
 close to 200 apache processes running.  It's baffling.  Can you guide me on 
 how to limit the number of apache processes and threads?  I've attached the 
 apache httpd.conf file.

 Thanks Christian.

 --steve


-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Error using post-review with git

[Paul Albertella]

Hi,

I'm getting a confusing error when I try to run post-review

  Failed to execute command: ['git', 'config', 'core.bare']

I've tried running this command directly in the repository (a non-bare 
clone) and it simply returns. I'm not sure what response the script is 
expecting. I'm using git version 1.7.9.5 and RBTools 0.4.2. I've tried 
specifying the URL of the ReviewBoard instance in ~/.reviewboard.rc as well 
as in the git config, but that makes no difference; I don't think that 
post-review is getting far enough to us the URL anyway,

Any ideas?

Debug output is as follows:

post-review --debug
 RBTools 0.4.2
 Python 2.7.3 (default, Aug  1 2012, 05:14:39) 
[GCC 4.6.3]
 Running on Linux-3.2.0-33-generic-x86_64-with-Ubuntu-12.04-precise
 Home = removed
 Current Directory = removed
 Checking the repository type. Errors shown below are mostly harmless.
DEBUG:root:Checking for a CVS repository...
DEBUG:root:Checking for a ClearCase repository...
DEBUG:root:Checking for a Git repository...
DEBUG:root:Running: git rev-parse --git-dir
DEBUG:root:Running: git config core.bare
Failed to execute command: ['git', 'config', 'core.bare']

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Can't install reviewboard w/ mysql on mac

[Paul]

Hi,

Trying to install reviewboard 1.6.6 on a mac (lion). I installed mysql-
python and mysql 5.5.23 and have it running. When I run sudo rb-site
install and get to the question regarding db, I don't see a mysql
option. It only shows sqlite3. Why doesn't the mysql option show up?

* What database type will you be using?

You can type either the name or the number from the list below.

(1) sqlite3 (not supported for production use)

Database Type:

Thanks,
Paul

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Review board hanging / access issue..

[Paul Schulz]

Hi Chris,

Thank you for your assistance.

Looks like the Powers-that-be around here are reasonable keen to see
us upgrade to 1.6.4.1 and change to using MySQL as the database (from
1.5.4 using SQLite.)

Do you have any suggestions on the best way to do this?

- I will have the opportunity to migrate reviewboard to a fresh
install of CentOS 6.2.

- Do you have any suggestions on migrating the data from SQLite to MySQL?

- Is is possible to change a name of a 'site' after installation

eg. Migrate data 'reviewboard' - 'reviewboard-dev' (for testing)
  Disable old instance of 'reviewboard'
  and rename 'reviewboard-dev' to 'reviewboard'

Cheers,
Paul

On Fri, Feb 17, 2012 at 11:28 AM, Paul Schulz p...@mawsonlakes.org wrote:
 Hi Christian,

 Happy to be included in any migration script testing you may need.

 On Fri, Feb 17, 2012 at 11:21 AM, Christian Hammond chip...@chipx86.com 
 wrote:
 Hi Paul,

 patch actually doesn't listen. What's happening is that an Apache thread
 running Review Board has spun off a patch instance, but due to a quirk and
 bug involving spinning off processes, it's possible they could block on
 waiting for input. Since it stalls, its parent Apache thread also stalls,
 and Apache is what's listening on port 80. This stall is what we've since
 fixed.

 So, that's an issue, but you see database locking because of sqlite. That
 should never be used in production, as it's not designed for concurrency.
 You'll start to hit these issues with normal usage as the number of users go
 up, and every write will block everyone else's read. You should look into
 moving to MySQL or something. The next release of RB 1.6.x will have scripts
 to help in the process of moving databases over.


 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board - http://www.reviewboard.org
 VMware, Inc. - http://www.vmware.com


 On Thu, Feb 16, 2012 at 4:30 PM, Paul Schulz p...@mawsonlakes.org wrote:

 Hi Christian,

 Thank you for your replay.. I had a look in the bugs but wasn't able
 to find anything quickly. (I didn't look that hard.)

 I am using sqlite3 as the database on an old version on Ubuntu. (9.04)
 Upgrading in place has just worked, up to now.

 I will look into upgrading.

 (I still have one question.. how or why does patch end up listeing on port
 80?)

 Thanks again,
 Paul

 On Fri, Feb 17, 2012 at 10:37 AM, Christian Hammond chip...@chipx86.com
 wrote:
  Hi Paul,
 
  What database are you using?
 
  The patch problem is possibly a cause. It blocks Apache threads from
  closing. We've seen this before, and have a fix in a release.
  Unfortunately,
  it requires some newer stuff in order to prevent the problem. You'll
  need
  the latest Review Board 1.6.x release, plus Python 2.6+, in order to fix
  it.
 
  Christian
 
 
  --
  Christian Hammond - chip...@chipx86.com
  Review Board - http://www.reviewboard.org
  VMware, Inc. - http://www.vmware.com
 
 
  On Wed, Feb 15, 2012 at 9:13 PM, Paul Schulz p...@mawsonlakes.org
  wrote:
 
  Greetings,
 
  I have an interesting access issue with my Reviewboard instance.
  I have a dedicated VM running reviewboard 1.5.4.
 
  The Problem:
  Every now and again users have issues using the system and I get Admin
  alert emails with the details below. The load on the machine goes up
  to approximate 4 (single processor).. more observations below.
 
   (Email Message to Root) 
  Traceback (most recent call last):
 
   File
 
  /usr/local/lib/python2.6/dist-packages/Django-1.2.5-py2.6.egg/django/core/handlers/base.py,
  line 100, in get_response
     response = callback(request, *callback_args, **callback_kwargs)
 
   File
 
  /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.5.4-py2.6.egg/reviewboard/accounts/decorators.py,
  line 27, in _check
     return view_func(*args, **kwargs)
 
   File
 
  /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.5.4-py2.6.egg/reviewboard/accounts/decorators.py,
  line 46, in _check_valid_prefs
     return view_func(request, *args, **kwargs)
 
   File
 
  /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.5.4-py2.6.egg/reviewboard/reviews/views.py,
  line 141, in review_detail
     visited.save()
 
   File
 
  /usr/local/lib/python2.6/dist-packages/Django-1.2.5-py2.6.egg/django/db/models/base.py,
  line 458, in save
     self.save_base(using=using, force_insert=force_insert,
  force_update=force_update)
 
   File
 
  /usr/local/lib/python2.6/dist-packages/Django-1.2.5-py2.6.egg/django/db/models/base.py,
  line 558, in save_base
     transaction.commit_unless_managed(using=using)
 
   File
 
  /usr/local/lib/python2.6/dist-packages/Django-1.2.5-py2.6.egg/django/db/transaction.py,
  line 175, in commit_unless_managed
     connection._commit()
 
   File
 
  /usr/local/lib/python2.6/dist-packages/Django-1.2.5-py2.6.egg/django/db/backends/__init__.py,
  line 32, in _commit
     return self.connection.commit()
 
  OperationalError: database is locked
 
 
  ModPythonRequest
  path:/r/1371

Re: Review board hanging / access issue..

[Paul Schulz]

Hi Christian,

Happy to be included in any migration script testing you may need.

On Fri, Feb 17, 2012 at 11:21 AM, Christian Hammond chip...@chipx86.com wrote:
 Hi Paul,

 patch actually doesn't listen. What's happening is that an Apache thread
 running Review Board has spun off a patch instance, but due to a quirk and
 bug involving spinning off processes, it's possible they could block on
 waiting for input. Since it stalls, its parent Apache thread also stalls,
 and Apache is what's listening on port 80. This stall is what we've since
 fixed.

 So, that's an issue, but you see database locking because of sqlite. That
 should never be used in production, as it's not designed for concurrency.
 You'll start to hit these issues with normal usage as the number of users go
 up, and every write will block everyone else's read. You should look into
 moving to MySQL or something. The next release of RB 1.6.x will have scripts
 to help in the process of moving databases over.


 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board - http://www.reviewboard.org
 VMware, Inc. - http://www.vmware.com


 On Thu, Feb 16, 2012 at 4:30 PM, Paul Schulz p...@mawsonlakes.org wrote:

 Hi Christian,

 Thank you for your replay.. I had a look in the bugs but wasn't able
 to find anything quickly. (I didn't look that hard.)

 I am using sqlite3 as the database on an old version on Ubuntu. (9.04)
 Upgrading in place has just worked, up to now.

 I will look into upgrading.

 (I still have one question.. how or why does patch end up listeing on port
 80?)

 Thanks again,
 Paul

 On Fri, Feb 17, 2012 at 10:37 AM, Christian Hammond chip...@chipx86.com
 wrote:
  Hi Paul,
 
  What database are you using?
 
  The patch problem is possibly a cause. It blocks Apache threads from
  closing. We've seen this before, and have a fix in a release.
  Unfortunately,
  it requires some newer stuff in order to prevent the problem. You'll
  need
  the latest Review Board 1.6.x release, plus Python 2.6+, in order to fix
  it.
 
  Christian
 
 
  --
  Christian Hammond - chip...@chipx86.com
  Review Board - http://www.reviewboard.org
  VMware, Inc. - http://www.vmware.com
 
 
  On Wed, Feb 15, 2012 at 9:13 PM, Paul Schulz p...@mawsonlakes.org
  wrote:
 
  Greetings,
 
  I have an interesting access issue with my Reviewboard instance.
  I have a dedicated VM running reviewboard 1.5.4.
 
  The Problem:
  Every now and again users have issues using the system and I get Admin
  alert emails with the details below. The load on the machine goes up
  to approximate 4 (single processor).. more observations below.
 
   (Email Message to Root) 
  Traceback (most recent call last):
 
   File
 
  /usr/local/lib/python2.6/dist-packages/Django-1.2.5-py2.6.egg/django/core/handlers/base.py,
  line 100, in get_response
     response = callback(request, *callback_args, **callback_kwargs)
 
   File
 
  /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.5.4-py2.6.egg/reviewboard/accounts/decorators.py,
  line 27, in _check
     return view_func(*args, **kwargs)
 
   File
 
  /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.5.4-py2.6.egg/reviewboard/accounts/decorators.py,
  line 46, in _check_valid_prefs
     return view_func(request, *args, **kwargs)
 
   File
 
  /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.5.4-py2.6.egg/reviewboard/reviews/views.py,
  line 141, in review_detail
     visited.save()
 
   File
 
  /usr/local/lib/python2.6/dist-packages/Django-1.2.5-py2.6.egg/django/db/models/base.py,
  line 458, in save
     self.save_base(using=using, force_insert=force_insert,
  force_update=force_update)
 
   File
 
  /usr/local/lib/python2.6/dist-packages/Django-1.2.5-py2.6.egg/django/db/models/base.py,
  line 558, in save_base
     transaction.commit_unless_managed(using=using)
 
   File
 
  /usr/local/lib/python2.6/dist-packages/Django-1.2.5-py2.6.egg/django/db/transaction.py,
  line 175, in commit_unless_managed
     connection._commit()
 
   File
 
  /usr/local/lib/python2.6/dist-packages/Django-1.2.5-py2.6.egg/django/db/backends/__init__.py,
  line 32, in _commit
     return self.connection.commit()
 
  OperationalError: database is locked
 
 
  ModPythonRequest
  path:/r/1371/,
  GET:QueryDict: {},
  POST:QueryDict: {},
  COOKIES:{'rbsessionid': '803f0ef200329d8921c1b70a9b7eb8ff'},
  META:{'AUTH_TYPE': None,
   'CONTENT_LENGTH': 0,
   'CONTENT_TYPE': None,
   'GATEWAY_INTERFACE': 'CGI/1.1',
   'HTTP_ACCEPT':
  'text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8',
   'HTTP_ACCEPT_ENCODING': 'gzip, deflate',
   'HTTP_ACCEPT_LANGUAGE': 'en-us,en;q=0.5',
   'HTTP_CONNECTION': 'keep-alive',
   'HTTP_COOKIE': 'rbsessionid=803f0ef200329d8921c1b70a9b7eb8ff',
   'HTTP_HOST': 'review..***',
   'HTTP_IF_NONE_MATCH': ':2012-01-16 10:46:18.283850::2012-02-16
  14:12:08.745932:0:1299464299',
   'HTTP_REFERER': 'http://review.rocksoft.com/dashboard/',
   'HTTP_USER_AGENT': 'Mozilla/5.0 (X11; Ubuntu