Re: space in filename

2012-10-19 Thread Phil Hom
DIff sent.

thanks.

On Thursday, October 18, 2012 3:00:38 PM UTC-7, Christian Hammond wrote:

 Huh, sure is confused.

 Can you send me the header part of the diff? Everything before the actual 
 content.

 Christian

 -- 
 Christian Hammond - chi...@chipx86.com javascript:
 Review Board - http://www.reviewboard.org
 VMware, Inc. - http://www.vmware.com


 On Thu, Oct 18, 2012 at 2:19 PM, Phil Hom phi...@gmail.com 
 javascript:wrote:


 Sorry, We're on rev 1.6.10

 png attached this time.


 On Thursday, October 18, 2012 2:17:28 PM UTC-7, Phil Hom wrote:


 I have a file with a space in the filename, added this file thru git and 
 posted a review.

 Diffs seems confused about the path/filename.
 For example my filename is koalabird/koalabird-service/**
 src/main/scala/com/twitter/**koalabird/Sno Oze.scala

 Diffs shows the file label as 

 Files Changed:

1. Oze.scala https://reviewboard.twitter.biz/r/76383/diff/#0 (was 

 koalabird/koalabird-service/**src/main/scala/com/twitter/**koalabird/Sno): 
1 change [ new 
 contenthttps://reviewboard.twitter.biz/r/76383/diff/#0.0] 

 Here is a png attached.


 Thanks.

  -- 
 Want to help the Review Board project? Donate today at 
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to 
 reviewboard...@googlegroups.com javascript:
 For more options, visit this group at 
 http://groups.google.com/group/reviewboard?hl=en
  
  




-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en




Re: space in filename

2012-10-18 Thread Phil Hom

Sorry, We're on rev 1.6.10

png attached this time.

On Thursday, October 18, 2012 2:17:28 PM UTC-7, Phil Hom wrote:


 I have a file with a space in the filename, added this file thru git and 
 posted a review.

 Diffs seems confused about the path/filename.
 For example my filename is 
 koalabird/koalabird-service/src/main/scala/com/twitter/koalabird/Sno 
 Oze.scala

 Diffs shows the file label as 

 Files Changed:

1. Oze.scala https://reviewboard.twitter.biz/r/76383/diff/#0 (was 
koalabird/koalabird-service/src/main/scala/com/twitter/koalabird/Sno): 1 
change [ new contenthttps://reviewboard.twitter.biz/r/76383/diff/#0.0]

 Here is a png attached.


 Thanks.



-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


attachment: filename.png

Re: Review Board 1.6.10 released

2012-07-25 Thread Phil Hom
We upgraded from 1.6.3 to 1.6.10, everything looks good.
Except the Authentication Settings page only shows Standard Reg and Legacy, 
no LDAP, AD, or others.

Is there something I'm misssing.
THanks.

Phil

On Sunday, July 22, 2012 1:20:30 AM UTC-7, Christian Hammond wrote:

 Hey everyone,

 We just released Review Board 1.6.10, which, amongst other things, is a 
 pretty speedy release.

 A lot of work went into this release to drastically speed up nearly every 
 page. There's more to do, but the improvement should be noticeable. Given 
 the extensive changes that happened under the hood for this, we'd be very 
 interested in knowing if you hit any problems.

 There are some other great little improvements and fixes. See 
 http://www.reviewboard.org/news/2012/07/22/review-board-1610-released/for 
 more information.

 Christian

 -- 
 Christian Hammond - chip...@chipx86.com
 Review Board - http://www.reviewboard.org
 VMware, Inc. - http://www.vmware.com


-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Review Board 1.6.10 released

2012-07-25 Thread Phil Hom
We grabed the gzips from the releases directory and created RPMs for 
DJblets 0.6.21 and reviewboard 1.6.10,
then installed the RPMs, then ran  rb-site upgrade.

We used RPMs before for 1.6.3, so continued doing it this way just in case 
we need to back out.

On Wednesday, July 25, 2012 1:05:27 PM UTC-7, Christian Hammond wrote:

 Did you upgrade using pip or easy_install?

 Christian

 -- 
 Christian Hammond - chip...@chipx86.com
 Review Board - http://www.reviewboard.org
 VMware, Inc. - http://www.vmware.com


 On Wed, Jul 25, 2012 at 12:40 PM, Phil Hom phil...@gmail.com wrote:

 We upgraded from 1.6.3 to 1.6.10, everything looks good.
 Except the Authentication Settings page only shows Standard Reg and 
 Legacy, no LDAP, AD, or others.

 Is there something I'm misssing.
 THanks.

 Phil


 On Sunday, July 22, 2012 1:20:30 AM UTC-7, Christian Hammond wrote:

 Hey everyone,

 We just released Review Board 1.6.10, which, amongst other things, is a 
 pretty speedy release.

 A lot of work went into this release to drastically speed up nearly 
 every page. There's more to do, but the improvement should be noticeable. 
 Given the extensive changes that happened under the hood for this, we'd be 
 very interested in knowing if you hit any problems.

 There are some other great little improvements and fixes. See 
 http://www.reviewboard.org/**news/2012/07/22/review-board-**
 1610-released/http://www.reviewboard.org/news/2012/07/22/review-board-1610-released/for
  more information.

 Christian

 -- 
 Christian Hammond - chip...@chipx86.com
 Review Board - http://www.reviewboard.org
 VMware, Inc. - http://www.vmware.com




-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Review Board 1.6.10 released

2012-07-25 Thread Phil Hom
The problem turned out to be the RPM spec file for reviewboard listed 
Djblets 0.6.20, while we upgraded to 0.6.21.
There were auth module errors in the reviewboard log.

This has been fixed by re-rolling the reviewboard RPM.

Thanks for your help.

Phil 

On Wednesday, July 25, 2012 2:00:36 PM UTC-7, Christian Hammond wrote:

 We make use of setuptools-provided Python Entrypoints, which register some 
 scannable bits of data for things like authentication modules. It sounds 
 like those registrations got lost somehow in your packaging.

 Christian

 -- 
 Christian Hammond - chip...@chipx86.com
 Review Board - http://www.reviewboard.org
 VMware, Inc. - http://www.vmware.com


 On Wed, Jul 25, 2012 at 1:30 PM, Phil Hom phil...@gmail.com wrote:

 We grabed the gzips from the releases directory and created RPMs for 
 DJblets 0.6.21 and reviewboard 1.6.10,
 then installed the RPMs, then ran  rb-site upgrade.

 We used RPMs before for 1.6.3, so continued doing it this way just in 
 case we need to back out.


 On Wednesday, July 25, 2012 1:05:27 PM UTC-7, Christian Hammond wrote:

 Did you upgrade using pip or easy_install?

 Christian

 -- 
 Christian Hammond - chip...@chipx86.com
 Review Board - http://www.reviewboard.org
 VMware, Inc. - http://www.vmware.com


 On Wed, Jul 25, 2012 at 12:40 PM, Phil Hom phil...@gmail.com wrote:

 We upgraded from 1.6.3 to 1.6.10, everything looks good.
 Except the Authentication Settings page only shows Standard Reg and 
 Legacy, no LDAP, AD, or others.

 Is there something I'm misssing.
 THanks.

 Phil


 On Sunday, July 22, 2012 1:20:30 AM UTC-7, Christian Hammond wrote:

 Hey everyone,

 We just released Review Board 1.6.10, which, amongst other things, is 
 a pretty speedy release.

 A lot of work went into this release to drastically speed up nearly 
 every page. There's more to do, but the improvement should be noticeable. 
 Given the extensive changes that happened under the hood for this, we'd 
 be 
 very interested in knowing if you hit any problems.

 There are some other great little improvements and fixes. See 
 http://www.reviewboard.org/**new**s/2012/07/22/review-board-**1610**
 -released/http://www.reviewboard.org/news/2012/07/22/review-board-1610-released/for
  more information.

 Christian

 -- 
 Christian Hammond - chip...@chipx86.com
 Review Board - http://www.reviewboard.org
 VMware, Inc. - http://www.vmware.com


  -- 
 Want to help the Review Board project? Donate today at 
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to 
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at 
 http://groups.google.com/group/reviewboard?hl=en




-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en