Re: Error Sending email

2015-02-09 Thread Tamer Afify
I'm following the code of 'get_email_address_for_user()' any help will be 
appreciated...

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Error Sending email

2015-02-09 Thread Tamer Afify
Please Ignore. 

I resolved the issue I created to waste my time. I realized that some user 
accounts (including mine) was created (logged on the RB site) before I 
setup the email attribute correctly for the LDAP authentication. Which 
caused those accounts to be stored without an email address. I didn't 
realize that their email addresses are never updated. I assumed that only 
usernames is stored and email addresses is generated when email is sent. 
Glad to put the server back into production.

Resolution was to delete those accounts and request users to re-login.

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Error Sending email

2015-02-09 Thread Tamer Afify
I setup RB2.0.12 to use corp SMTP server.
It sends test emails successfully, but fails to send any review request 
notification emails. It probably has to do with resolving user email 
address from ldap (attribute is configured as default 'mail'). What I get 
in log;
 59 2015-02-09 23:04:01,083 - ERROR -  - Error sending e-mail notification 
with subject 'Re: Review Request 16: test RB' on behalf of 'tafy ' to 
'tafy ,mtha ': {'tafy ': (501, '5.1.3 Invalid address'), 'mtha 
': (501, '5.1.3 Invalid address')} 60 Traceback (most recent call last):
 61   File 
/opt/python/lib/python2.7/site-packages/ReviewBoard-2.0.12-py2.7.egg/reviewboard/notifications/email.py,
 
line 293, in send_review_mail
 62 message.send()
 63   File 
/opt/python/lib/python2.7/site-packages/Django-1.6.10-py2.7.egg/django/core/mail/message.py,
 
line 276, in send
 64 return self.get_connection(fail_silently).send_messages([self])
 65   File 
/opt/python/lib/python2.7/site-packages/Django-1.6.10-py2.7.egg/django/core/mail/backends/smtp.py,
 
line 94, in send_messages
 66 sent = self._send(message)
 67   File 
/opt/python/lib/python2.7/site-packages/Django-1.6.10-py2.7.egg/django/core/mail/backends/smtp.py,
 
line 110, in _send
 68 self.connection.sendmail(from_email, recipients, message.as_bytes())
 69   File /opt/python/lib/python2.7/smtplib.py, line 735, in sendmail
 70 raise SMTPRecipientsRefused(senderrs)
 71 SMTPRecipientsRefused: {'tafy ': (501, '5.1.3 Invalid address'), 
'mtha ': (501, '5.1.3 Invalid address')}

in Authentication settings I set;
LDAP Server
LDAP Base DN
Username Attribute: sAMAccountName
Given Name Attribute:givenName
Surname Attribute:sn
Full Name Attribute: empty
E-Mail Domain: tried with or without my corp domain name like corp.com  
@corp.com
E-Mail LDAP Attribute:mail
Custom LDAP User Search Filter:sAMAccountName=%s
Review Board LDAP Bind Account:admin account
Review Board LDAP Bind Password:admin password

Note domain users login successfully on RB.

What should I do to get to the root of this issue ASAP? Where should I look?

I'll start looking in code after 'user.get_full_name()' till I get a 
respond from Christian :) Please help.

Thanks for your support.

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: How to link github account on RB 2.0.11

2015-01-12 Thread Tamer Afify
Hi Christian,

Do I understand from this response that there is no way for RB to support 
code review for GitHub Enterprise (github.companyname.com) without buying 
the power pack? or RB can't support a Git repo with HTTPS protocol?
If it is supported can you provide help on how to add a  GitHub Enterprise 
repository?


On Monday, November 17, 2014 at 5:06:04 PM UTC-6, Christian Hammond wrote:

 I know you're using GitLab now, but as an FYI, the built-in GitHub support 
 in Review Board is only for github.com. GitHub Enterprise support is 
 available through Power Pack (https://www.reviewboard.org/powerpack/) 

 Christian 

 --   
 Christian Hammond - chri...@beanbaginc.com javascript:   
 Review Board - https://www.reviewboard.org   
 Beanbag, Inc. - https://www.beanbaginc.com 

 -Original Message- 
 From: MoonWalker daniel.c...@gmail.com javascript: 
 Reply: revie...@googlegroups.com javascript: revie...@googlegroups.com 
 javascript: 
 Date: November 17, 2014 at 2:33:44 PM 
 To: revie...@googlegroups.com javascript: revie...@googlegroups.com 
 javascript: 
 Subject:  Re: How to link github account on RB 2.0.11 

  Thanks David for your replay. I was using the enterprise edition, but I 
 had 
  so many issue, so I decide to use GitLab instead. Unfortunately I have 
 some 
  issues there as well. More details 
  here https://groups.google.com/forum/#!topic/reviewboard/2mO2CjYetdE 

  On Monday, November 17, 2014 1:19:17 PM UTC+11, David Trowbridge wrote: 
   
   Selecting GitHub means github.com. Are you using GitHub enterprise? 
   
   -david 
   
   On Sun, Nov 16, 2014 at 6:16 PM, MoonWalkerwrote: 
   
   both RB and GitHub are local servers (no internet access) 
   
   On Monday, November 17, 2014 12:55:11 PM UTC+11, David Trowbridge 
 wrote: 
   
   It looks like we have some problems with the error handling, but 
 there's 
   some issue attempting to communicate with GitHub's API. Does this 
 machine 
   have access to the internet? Is it possible that you need to 
 configure an 
   HTTP proxy? 
   
   -David 
   
   On Sun, Nov 16, 2014 at 5:28 PM, MoonWalker   
   wrote: 
   
   I we have a private GitHub repo and I am trying to connect to my RB 
   2.0.11. I noticed that the Account option shows Link a new 
 account but 
   seems like the account is not linked. How shall I link the github 
 account? 
   
   Please take a look at my screen shoot. 
   
   P.S this user has admin rights 
   
   
   
   
 
   
   -- 
   Get the Review Board Power Pack at http://www.reviewboard.org/ 
   powerpack/ 
   --- 
   Sign up for Review Board hosting at RBCommons: 
 https://rbcommons.com/ 
   --- 
   Happy user? Let us know at http://www.reviewboard.org/users/ 
   --- 
   You received this message because you are subscribed to the Google 
   Groups reviewboard group. 
   To unsubscribe from this group and stop receiving emails from it, 
 send 
   an email to reviewboard...@googlegroups.com. 
   For more options, visit https://groups.google.com/d/optout. 
   
   
   -- 
   Get the Review Board Power Pack at 
 http://www.reviewboard.org/powerpack/ 
   --- 
   Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ 
   --- 
   Happy user? Let us know at http://www.reviewboard.org/users/ 
   --- 
   You received this message because you are subscribed to the Google 
 Groups 
   reviewboard group. 
   To unsubscribe from this group and stop receiving emails from it, 
 send an 
   email to reviewboard...@googlegroups.com . 
   For more options, visit https://groups.google.com/d/optout. 
   
   
   

  -- 
  Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ 
  --- 
  Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ 
  --- 
  Happy user? Let us know at http://www.reviewboard.org/users/ 
  --- 
  You received this message because you are subscribed to the Google 
 Groups reviewboard   
  group. 
  To unsubscribe from this group and stop receiving emails from it, send 
 an email to reviewboard...@googlegroups.com javascript:.   
  For more options, visit https://groups.google.com/d/optout. 




-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: How can I post a review for selected files only?

2014-08-12 Thread Tamer Afify
Thanks David for the response. Upgrading to 0.6.2 fixed the issue for me.

On Wednesday, August 6, 2014 2:52:46 PM UTC-5, David Trowbridge wrote:

 Hi,

 There was a bug in 0.6 that prevented -I from working with SVN 
 repositories. This bug was fixed in 0.6.1

 -David


 On Wed, Aug 6, 2014 at 12:21 PM, Tamer Afify tamer...@gmail.com 
 javascript: wrote:

 Per the documentation this should do it for Server 1.7.22, rbt 0.6 and 
 SVN repository
 rbt post -I file path
 yet that generates a code review request (with a diff file) for all 
 checked out files under current path (where rbt is called).

 Am I doing something wrong?

 -- 
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google Groups 
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard...@googlegroups.com javascript:.
 For more options, visit https://groups.google.com/d/optout.




-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


How can I post a review for selected files only?

2014-08-06 Thread Tamer Afify
Per the documentation this should do it for Server 1.7.22, rbt 0.6 and SVN 
repository
rbt post -I file path
yet that generates a code review request (with a diff file) for all checked 
out files under current path (where rbt is called).

Am I doing something wrong?

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Integrated ReviewBoard in TortoiseSVN 1.8.X

2014-05-08 Thread Tamer Afify
Hi All,

I have made few changes in TortoiseSVN 1.8.X release to allow for;
1. Send a pre-commit review request from File Explorer menu
2. Send a post-commit review request from Tortoise Show Logs dialog
3. Review  Commit source in one step, that would add the review URL in the 
commit log message
4. Setup a user local .reviewboardrc configuration file from TortoiseSVN 
settings dialog

I'm new to the open source world. Is that change of any value to the 
ReviewBoard community? If so how can I share source and binaries?
and maybe hopefully get a code review for my changes :)


-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Why the SVN diff have to be for a working copy source to post a review?

2014-04-21 Thread Tamer Afify
As my team starting to do CR process, managers need to review code 
previously checked-in. Yet they don't want to have a local copy of all the 
source code to post reviews. Is there a way to post a review using an SVN 
URL and a revision? What would be the parameters for rbt.exe?

I'm using RBTools 0.6 with SVN server.

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Request a review for post-committed one file revision

2014-04-15 Thread Tamer Afify
Hi All,

Can rbt tool send a code review for one file only post-committed change 
revision? I was imagining something like
rbt post https:\\svn.server\path\to\a\file#0001

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: 'Client' object has no attribute 'config_dir'

2014-03-24 Thread Tamer Afify
Is this a problem because of my setup?

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: 'Client' object has no attribute 'config_dir'

2014-03-24 Thread Tamer Afify
I have two RB servers, both setup identical except one is 1.7.22 and the 
other is RC1.
RB Server setup:
Repository Type: Subversion
Path: https://some.svn.server.com/svn/repo
Username: AD username with access to repo
Password: AD user password
Bug Tracker URL: https://division.server.com/jira/browse/%s
Users with Access: 1 user
Review Groups with access: 1 group

Client Setup:
mac machine with rbt tool 0.5.7
svn command line tool from Apache
svn, version 1.8.3 (r1516576)
   compiled Sep 12 2013, 16:49:04 on x86_64-apple-darwin12.4.0

call command on the checkout root folder
 rbt post


Let me know what other setting that can help.

Thanks for your attention,

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Exception thrown for user AnonymousUser at https://my.reviewboard.url.com/api/info/

2014-03-24 Thread Tamer Afify
I keep getting emails with this exception randomly while users are logging 
in. yet I don't hear any complain from them. Did I miss something in setup?

Users use ActiveDirectory credentials to login.

Here is the debug log lines for it; 

  13383 2014-03-24 21:42:01,572 - DEBUG -  - User al...@my.domain.com is 
trying to log in via AD
  13384 2014-03-24 21:42:01,601 - DEBUG -  - Search root 
dc=my,dc=domain,dc=com
  13385 2014-03-24 21:42:01,612 - ERROR -  - Exception thrown for user 
AnonymousUser at https://my.reviewboard.url.com/api/info/
  13386
  13387 {'info': '04DC: LdapErr: DSID-0C0906DC, comment: In order to 
perform this operation a successful bind must be completed on the 
connection., data 0, v1db0', 'desc': 'Operations error'}
  13388 Traceback (most recent call last):
  13389   File 
/usr/local/lib/python2.7/dist-packages/Django-1.4.10-py2.7.egg/django/core/handlers/base.py,
 
line 111, in get_response
  13390 response = callback(request, *callback_args, **callback_kwargs)
  13391   File 
/usr/local/lib/python2.7/dist-packages/Django-1.4.10-py2.7.egg/django/views/decorators/cache.py,
 
line 89, in _wrapped_view_func
  13392 response = view_func(request, *args, **kwargs)
  13393   File 
/usr/local/lib/python2.7/dist-packages/Django-1.4.10-py2.7.egg/django/views/decorators/vary.py,
 
line 19, in inner_func
  13394 response = func(*args, **kwargs)
  13395   File 
/usr/local/lib/python2.7/dist-packages/Djblets-0.7.28-py2.7.egg/djblets/webapi/resources.py,
 
line 422, in __call__
  13396 auth_result = check_login(request)
  13397   File 
/usr/local/lib/python2.7/dist-packages/Djblets-0.7.28-py2.7.egg/djblets/webapi/auth.py,
 
line 178, in check_login
  13398 result = auth_backend_cls().authenticate(request)
  13399   File 
/usr/local/lib/python2.7/dist-packages/Djblets-0.7.28-py2.7.egg/djblets/webapi/auth.py,
 
line 88, in authenticate
  13400 result = self.login_with_credentials(request, **credentials)
  13401   File 
/usr/local/lib/python2.7/dist-packages/Djblets-0.7.28-py2.7.egg/djblets/webapi/auth.py,
 
line 132, in login_with_credentials
  13402 user = auth.authenticate(username=username, password=password)
  13403   File 
/usr/local/lib/python2.7/dist-packages/Django-1.4.10-py2.7.egg/django/contrib/auth/__init__.py,
 
line 45, in authenticate
  13404 user = backend.authenticate(**credentials)
  13405   File 
/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.22-py2.7.egg/reviewboard/accounts/backends.py,
 
line 564, in authenticate
  13406 userdomain)
  13407   File 
/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.22-py2.7.egg/reviewboard/accounts/backends.py,
 
line 456, in search_ad
  13408 return con.search_s(search_root, scope=ldap.SCOPE_SUBTREE, 
filterstr=filterstr)
  13409   File /usr/lib/python2.7/dist-packages/ldap/ldapobject.py, line 
502, in search_s
  13410 return 
self.search_ext_s(base,scope,filterstr,attrlist,attrsonly,None,None,timeout=self.timeout)
  13411   File /usr/lib/python2.7/dist-packages/ldap/ldapobject.py, line 
496, in search_ext_s
  13412 return self.result(msgid,all=1,timeout=timeout)[1]
  13413   File /usr/lib/python2.7/dist-packages/ldap/ldapobject.py, line 
422, in result
  13414 res_type,res_data,res_msgid = self.result2(msgid,all,timeout)
  13415   File /usr/lib/python2.7/dist-packages/ldap/ldapobject.py, line 
426, in result2
  13416 res_type, res_data, res_msgid, srv_ctrls = 
self.result3(msgid,all,timeout)
  13417   File /usr/lib/python2.7/dist-packages/ldap/ldapobject.py, line 
432, in result3
  13418 ldap_result = self._ldap_call(self._l.result3,msgid,all,timeout)
  13419   File /usr/lib/python2.7/dist-packages/ldap/ldapobject.py, line 
96, in _ldap_call
  13420 result = func(*args,**kwargs)
  13421 OPERATIONS_ERROR: {'info': '04DC: LdapErr: DSID-0C0906DC, 
comment: In order to perform this operation a successful bind must be 
completed on the connection., data 0, v1db0', 'desc': 'Operations error'}
  13422 2014-03-24 21:42:01,613 - ERROR - None - AnonymousUser - /api/info/ 
- Internal Server Error: /api/info/
  13423 Traceback (most recent call last):
  13424   File 
/usr/local/lib/python2.7/dist-packages/Django-1.4.10-py2.7.egg/django/core/handlers/base.py,
 
line 111, in get_response
  13425 response = callback(request, *callback_args, **callback_kwargs)
  13426   File 
/usr/local/lib/python2.7/dist-packages/Django-1.4.10-py2.7.egg/django/views/decorators/cache.py,
 
line 89, in _wrapped_view_func
  13427 response = view_func(request, *args, **kwargs)
  13428   File 
/usr/local/lib/python2.7/dist-packages/Django-1.4.10-py2.7.egg/django/views/decorators/vary.py,
 
line 19, in inner_func
  13429 response = func(*args, **kwargs)
  13430   File 
/usr/local/lib/python2.7/dist-packages/Djblets-0.7.28-py2.7.egg/djblets/webapi/resources.py,
 
line 422, in __call__
  13431 auth_result = check_login(request)
  13432   File 

Re: 'Client' object has no attribute 'config_dir'

2014-03-21 Thread Tamer Afify
I have two RB servers, both setup identical except one is 1.7.22 and the 
other is RC1.
RB Server setup:
Repository Type: Subversion
Path: https://some.svn.server.com/svn/repo
Username: AD username with access to repo
Password: AD user password
Bug Tracker URL: https://division.server.com/jira/browse/%s
Users with Access: 1 user
Review Groups with access: 1 group

Client Setup:
mac machine with rbt tool 0.5.7
svn command line tool from Apache
svn, version 1.8.3 (r1516576)
   compiled Sep 12 2013, 16:49:04 on x86_64-apple-darwin12.4.0

call command on the checkout root folder
 rbt post


Let me know what other setting that can help.

Thanks for your attention,




-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Usability bug in 1.7.22: Review comments recipients

2014-03-21 Thread Tamer Afify
When a reviewer publish his review, the review is set To the reviewers and 
CC the review requester. It should be the opposite as the comments are 
intended for the person doing code change not the reviewers.

Not sure if that feature is incorporated in RC1 2.0 or not, as I'm 
currently blocked from testing RC.

Please let me know if I should place this feature request in a tracking 
system.

Thanks,

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Usability bug in 1.7.22: Review comments recipients

2014-03-21 Thread Tamer Afify
Great thanks for the quick reply. I added extra enhancement to the tracked 
bug.

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


'Client' object has no attribute 'config_dir'

2014-03-20 Thread Tamer Afify
After upgrading to RC1 and do a rbt post I get this error;

DEBUG:root:Error data: {u'fields': {u'path': [u'Client' object has no 
attribute 'config_dir']}, u'stat': u'fail', u'err': {u'msg': u'One or more 
fields had errors', u'code': 105}}
Traceback (most recent call last):
  File /usr/local/bin/rbt, line 8, in module
load_entry_point('RBTools==0.5.7', 'console_scripts', 'rbt')()
  File 
/Library/Python/2.7/site-packages/RBTools-0.5.7-py2.7.egg/rbtools/commands/main.py,
 
line 127, in main
command.run_from_argv([RB_MAIN] + args)
  File 
/Library/Python/2.7/site-packages/RBTools-0.5.7-py2.7.egg/rbtools/commands/__init__.py,
 
line 158, in run_from_argv
exit_code = self.main(*args) or 0
  File 
/Library/Python/2.7/site-packages/RBTools-0.5.7-py2.7.egg/rbtools/commands/post.py,
 
line 659, in main
submit_as=self.options.submit_as)
  File 
/Library/Python/2.7/site-packages/RBTools-0.5.7-py2.7.egg/rbtools/commands/post.py,
 
line 534, in post_request
raise CommandError('\n'.join(error_msg))
rbtools.commands.CommandError: Error uploading diff

How to work fix it?
If I change .reviewboardrc (at the checkout root) to another server with 
1.7.22, it works fine.

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Can reviewboard integrate with multiple domains or LDAP URLs?

2014-03-17 Thread Tamer Afify
Thanks David for your response, I'm not sure what doe sub-domain mean? I 
use LDAP browser to view the domain users and I see majority of users are 
in the OU=Users but few are in another OU=Bla Users, DC=some, DC=domain, 
DC=com. Both have the same DC name but different OUs. So how would such 
user type their username in rereviewboard?

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Can reviewboard integrate with multiple domains or LDAP URLs?

2014-03-11 Thread Tamer Afify
How can I allow login and review process for users from different domains?
I would appreciate any workaround or Dev walk through to get this if it isn't 
yet in feature list. 
Note I have 1.7.9  I have 2.4 as well.
Thanks for your support,

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


What is the correct arguments for rb-site manage?

2014-03-05 Thread Tamer Afify
Hi All,

[root@reviewboard ~]# rb-site manage /var/www/html/reviewboard.searshc.com/ 
get-siteconfig auth_ad_domain_name
CommandError: Command doesn't accept any arguments
[root@reviewboard ~]# rb-site manage /var/www/html/reviewboard.searshc.com/ 
get-siteconfig
CommandError: --key must be provided

how can I use get-siteconfig  set-siteconfig?

After installing 2.0 beta 3 and setting AD authentication and use DNS to 
get DC I'm not able to login to reviewboard anymore.

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Re: What is the correct arguments for rb-site manage?

2014-03-05 Thread Tamer Afify
I figured it out:

rb-site manage /var/www/html/reviewboard.searshc.com/ set-siteconfig -- 
--key=auth_ad_find_dc_from_dns --value=0
rb-site manage /var/www/html/reviewboard.searshc.com/ get-siteconfig -- 
--key=auth_ad_domain_name

but

rb-site manage /var/www/html/reviewboard.searshc.com/ get-siteconfig -- 
--key=auth_ad_find_dc_from_dns
Traceback (most recent call last):
  File /bin/rb-site, line 9, in module
load_entry_point('ReviewBoard==2.0beta3', 'console_scripts', 
'rb-site')()
  File 
/usr/lib/python2.7/site-packages/ReviewBoard-2.0beta3-py2.7.egg/reviewboard/cmdline/rbsite.py,
 
line 2111, in main
command.run()
  File 
/usr/lib/python2.7/site-packages/ReviewBoard-2.0beta3-py2.7.egg/reviewboard/cmdline/rbsite.py,
 
line 2030, in run
site.run_manage_command(args[0], args[1:])
  File 
/usr/lib/python2.7/site-packages/ReviewBoard-2.0beta3-py2.7.egg/reviewboard/cmdline/rbsite.py,
 
line 605, in run_manage_command
execute_from_command_line([__file__, cmd] + params)
  File 
/usr/lib/python2.7/site-packages/Django-1.6.2-py2.7.egg/django/core/management/__init__.py,
 
line 399, in execute_from_command_line
utility.execute()
  File 
/usr/lib/python2.7/site-packages/Django-1.6.2-py2.7.egg/django/core/management/__init__.py,
 
line 392, in execute
self.fetch_command(subcommand).run_from_argv(self.argv)
  File 
/usr/lib/python2.7/site-packages/Django-1.6.2-py2.7.egg/django/core/management/base.py,
 
line 242, in run_from_argv
self.execute(*args, **options.__dict__)
  File 
/usr/lib/python2.7/site-packages/Django-1.6.2-py2.7.egg/django/core/management/base.py,
 
line 285, in execute
output = self.handle(*args, **options)
  File 
/usr/lib/python2.7/site-packages/Django-1.6.2-py2.7.egg/django/core/management/base.py,
 
line 415, in handle
return self.handle_noargs(**options)
  File 
/usr/lib/python2.7/site-packages/Djblets-0.8beta2-py2.7.egg/djblets/siteconfig/management/commands/get-siteconfig.py,
 
line 45, in handle_noargs
self.stdout.write(node[key_basename])
  File 
/usr/lib/python2.7/site-packages/Django-1.6.2-py2.7.egg/django/core/management/base.py,
 
line 65, in write
if ending and not msg.endswith(ending):
AttributeError: 'bool' object has no attribute 'endswith'

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Re: What is the correct arguments for rb-site manage?

2014-03-05 Thread Tamer Afify
oh and of course in 2.0 Beta 3 if set that flag, I wasn't able to log in 
even with admin account.

On Wednesday, March 5, 2014 2:58:47 AM UTC-6, Tamer Afify wrote:

 I figured it out:

 rb-site manage /var/www/html/reviewboard.searshc.com/ set-siteconfig -- 
 --key=auth_ad_find_dc_from_dns --value=0
 rb-site manage /var/www/html/reviewboard.searshc.com/ get-siteconfig -- 
 --key=auth_ad_domain_name

 but

 rb-site manage /var/www/html/reviewboard.searshc.com/ get-siteconfig -- 
 --key=auth_ad_find_dc_from_dns
 Traceback (most recent call last):
   File /bin/rb-site, line 9, in module
 load_entry_point('ReviewBoard==2.0beta3', 'console_scripts', 
 'rb-site')()
   File 
 /usr/lib/python2.7/site-packages/ReviewBoard-2.0beta3-py2.7.egg/reviewboard/cmdline/rbsite.py,
  
 line 2111, in main
 command.run()
   File 
 /usr/lib/python2.7/site-packages/ReviewBoard-2.0beta3-py2.7.egg/reviewboard/cmdline/rbsite.py,
  
 line 2030, in run
 site.run_manage_command(args[0], args[1:])
   File 
 /usr/lib/python2.7/site-packages/ReviewBoard-2.0beta3-py2.7.egg/reviewboard/cmdline/rbsite.py,
  
 line 605, in run_manage_command
 execute_from_command_line([__file__, cmd] + params)
   File 
 /usr/lib/python2.7/site-packages/Django-1.6.2-py2.7.egg/django/core/management/__init__.py,
  
 line 399, in execute_from_command_line
 utility.execute()
   File 
 /usr/lib/python2.7/site-packages/Django-1.6.2-py2.7.egg/django/core/management/__init__.py,
  
 line 392, in execute
 self.fetch_command(subcommand).run_from_argv(self.argv)
   File 
 /usr/lib/python2.7/site-packages/Django-1.6.2-py2.7.egg/django/core/management/base.py,
  
 line 242, in run_from_argv
 self.execute(*args, **options.__dict__)
   File 
 /usr/lib/python2.7/site-packages/Django-1.6.2-py2.7.egg/django/core/management/base.py,
  
 line 285, in execute
 output = self.handle(*args, **options)
   File 
 /usr/lib/python2.7/site-packages/Django-1.6.2-py2.7.egg/django/core/management/base.py,
  
 line 415, in handle
 return self.handle_noargs(**options)
   File 
 /usr/lib/python2.7/site-packages/Djblets-0.8beta2-py2.7.egg/djblets/siteconfig/management/commands/get-siteconfig.py,
  
 line 45, in handle_noargs
 self.stdout.write(node[key_basename])
   File 
 /usr/lib/python2.7/site-packages/Django-1.6.2-py2.7.egg/django/core/management/base.py,
  
 line 65, in write
 if ending and not msg.endswith(ending):
 AttributeError: 'bool' object has no attribute 'endswith'



-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Re: What is the correct arguments for rb-site manage?

2014-03-05 Thread Tamer Afify


 I was getting error error: cannot convert argument to integer emailed 
 to me.



-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Missing an LDAP Bind DN?

2014-02-26 Thread Tamer Afify
Not sure why network administrators do such a variation of ou users, but it 
seems to be quite common. I'll appreciate if that feature would be 
available.

Thanks,

On Tuesday, February 25, 2014 6:51:24 AM UTC-6, Stephen Gallagher wrote:

 On 02/24/2014 08:51 PM, Tamer Afify wrote: 
  Thanks Christian  Stephen for fixing this. It really made me hit my 
  head for a while. 
  
  My corporate un-organized ldap directory shows that my reviewboard users 
  are scattered under different OUs. How can I configure authentication to 
  allow all my users to login? 
  
  i.e. one user is 
  cn=ford,ou=company Users,ou=location,dc=domain1,dc=domain2 
  
  while another is   
  cn=tesla,ou=Users,ou=location,dc=domain1,dc=domain2 
  
  currently I set my LDAP Base DN: to tesla user OU and if any user from 
  Ford OU login I get the following warning in reviewboards.log and fails 
  to login 
  WARNING -  - LDAP error: The specified object does not exist in the 
  Directory: sAMAccountName=ford 
  
  Also it would be great if you document for us what should be in 
  Anonymous User Mask/Password? 
  
  I appreciate your support and can't wait to read your reply 
  

 That's a specific issue I fixed with the new patches. It sounds like we 
 may want to backport that for the 1.7.x series. 

 Christian, is that a patch you'd be willing to accept? I know 1.7.x is 
 kind of winding down now. 


-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Missing an LDAP Bind DN?

2014-02-24 Thread Tamer Afify
Thanks Christian  Stephen for fixing this. It really made me hit my head 
for a while.

My corporate un-organized ldap directory shows that my reviewboard users 
are scattered under different OUs. How can I configure authentication to 
allow all my users to login?

i.e. one user is 
cn=ford,ou=company Users,ou=location,dc=domain1,dc=domain2

while another is  
cn=tesla,ou=Users,ou=location,dc=domain1,dc=domain2 

currently I set my LDAP Base DN: to tesla user OU and if any user from Ford 
OU login I get the following warning in reviewboards.log and fails to login
WARNING -  - LDAP error: The specified object does not exist in the 
Directory: sAMAccountName=ford

Also it would be great if you document for us what should be in Anonymous 
User Mask/Password?

I appreciate your support and can't wait to read your reply

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Use Mail Server Groups in Review Request Groups

2014-02-24 Thread Tamer Afify
Hi,

If I configure my review email server to be my corporate exchange (SMTP) 
server, would I be able to add exchange DL (distribution lists) in my 
review request groups? Or I have to recreate the mail groups in Reviewboard 
as review groups? 

Thanks for your attention,

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Missing an LDAP Bind DN?

2014-02-23 Thread Tamer Afify
Wow, who named those labels MUST be different from who coded the 
authentication, or he is super dum. I have been days trying to figure out 
what is wrong with my ldap login. I'm sure you did too in this 8days. I 
should have re-engineered the code to figure how to use a reviewboard 
feature. That is how the world should go forward.

Really thankful for your post here.

On Friday, September 16, 2011 10:41:17 AM UTC-5, Joe Campbell wrote:

 Never mind - I found this after looking at how the code worked.  This 
 is currently listed as an Anonymous Bind Mask/Anonymous User Mask and 
 an Anonymous User Password.  These are actually the BIND DN and BIND 
 Password that I was looking for and are just very badly mislabeled on 
 the site. 

 Thanks, 
  Joe 


 On Sep 8, 5:42 pm, Joe Campbell joseph.r.campb...@gmail.com wrote: 
  There is currently no way to set a bind DN for a bind user to access 
  the LDAP.  My ldap does not support anonymous binding.  Am I missing 
  this config or is truly not there?

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.