Re: Attachment uploads

[Christian Hammond]

We've never allowed arbitrary users to upload files on another review
request without them being admins (which is still allowed). It's otherwise
not allowed on the API or UI levels. I'd be very curious to learn more
about your prior setup. Is there any chance your copy was modified?

Christian


On Wed, Jun 7, 2017 at 02:40 'Rob Backhurst' via reviewboard <
reviewboard@googlegroups.com> wrote:

> Oh and yes, anyone can add comments so thats fine...
>
>
> On Wednesday, 7 June 2017 09:10:01 UTC+1, Rob Backhurst wrote:
>>
>> Hi,
>>
>>
>> Since we upgraded to RB 2.5.10 there has been a change in the way our
>> developers can upload attachments.
>>
>>
>> Attachments added by anyone other than the submitter do not seem to
>> upload.
>>
>> This is because it puts the RB form into a draft state and only the
>> submitter has visibility and authority to publish draft forms. Is it
>> possible to relax this validation?
>>
>> I believe previously “other” users were able to both comment and
>> additionally upload files.
>>
>>
>> Thanks
>>
>> Rob
>>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
-- 
-- 
Christian Hammond
President/CEO of Beanbag
Makers of Review Board

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Attachment uploads

['Rob Backhurst' via reviewboard]

Oh and yes, anyone can add comments so thats fine...


On Wednesday, 7 June 2017 09:10:01 UTC+1, Rob Backhurst wrote:
>
> Hi,
>
>
> Since we upgraded to RB 2.5.10 there has been a change in the way our 
> developers can upload attachments.
>
>
> Attachments added by anyone other than the submitter do not seem to 
> upload.  
>
> This is because it puts the RB form into a draft state and only the 
> submitter has visibility and authority to publish draft forms. Is it 
> possible to relax this validation?
>
> I believe previously “other” users were able to both comment and 
> additionally upload files.
>
>
> Thanks
>
> Rob
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Attachment uploads

['Rob Backhurst' via reviewboard]

Hi Christian,

Thanks for the quick reply!

So the menu options for other users to upload files shouldn't be available? 
Is this a bug?
We upgraded from 1.7.22 - perhaps also a bug in that version that allowed 
users to do it?



Thanks
Rob

On Wednesday, 7 June 2017 09:15:16 UTC+1, Christian Hammond wrote:
>
> Hi Rob,
>
> It's never been intended for anyone but the owner of the review request to 
> be able to upload attachments to a review request. Review requests are not 
> collaborative in this way. The only users who can modify another user's 
> review request are administrators or those with special permissions set.
>
> Anyone should be able to comment on any file attachment after it's been 
> published. Is that not working?
>
> What version did you upgrade from?
>
> Christian
>
> On Wed, Jun 7, 2017 at 1:10 AM, 'Rob Backhurst' via reviewboard <
> revie...@googlegroups.com > wrote:
>
>> Hi,
>>
>>
>> Since we upgraded to RB 2.5.10 there has been a change in the way our 
>> developers can upload attachments.
>>
>>
>> Attachments added by anyone other than the submitter do not seem to 
>> upload.  
>>
>> This is because it puts the RB form into a draft state and only the 
>> submitter has visibility and authority to publish draft forms. Is it 
>> possible to relax this validation?
>>
>> I believe previously “other” users were able to both comment and 
>> additionally upload files.
>>
>>
>> Thanks
>>
>> Rob
>>
>> -- 
>> Supercharge your Review Board with Power Pack: 
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons: 
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to reviewboard...@googlegroups.com .
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>
>
> -- 
> Christian Hammond
> President/CEO of Beanbag 
> Makers of Review Board 
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Attachment uploads

[Christian Hammond]

Hi Rob,

It's never been intended for anyone but the owner of the review request to
be able to upload attachments to a review request. Review requests are not
collaborative in this way. The only users who can modify another user's
review request are administrators or those with special permissions set.

Anyone should be able to comment on any file attachment after it's been
published. Is that not working?

What version did you upgrade from?

Christian

On Wed, Jun 7, 2017 at 1:10 AM, 'Rob Backhurst' via reviewboard <
reviewboard@googlegroups.com> wrote:

> Hi,
>
>
> Since we upgraded to RB 2.5.10 there has been a change in the way our
> developers can upload attachments.
>
>
> Attachments added by anyone other than the submitter do not seem to
> upload.
>
> This is because it puts the RB form into a draft state and only the
> submitter has visibility and authority to publish draft forms. Is it
> possible to relax this validation?
>
> I believe previously “other” users were able to both comment and
> additionally upload files.
>
>
> Thanks
>
> Rob
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>



-- 
Christian Hammond
President/CEO of Beanbag 
Makers of Review Board 

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Attachment uploads

['Rob Backhurst' via reviewboard]

Hi,


Since we upgraded to RB 2.5.10 there has been a change in the way our 
developers can upload attachments.


Attachments added by anyone other than the submitter do not seem to upload. 
 

This is because it puts the RB form into a draft state and only the 
submitter has visibility and authority to publish draft forms. Is it 
possible to relax this validation?

I believe previously “other” users were able to both comment and 
additionally upload files.


Thanks

Rob

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.