Re: Depends-On, Blocks and Circular Reference

2016-12-19 Thread David Trowbridge 
This bug is fixed in 2.0.21.

-David

On Mon, Dec 19, 2016 at 8:55 AM Philip Sanders 
wrote:

> I think I just hit this issue with the same release too.  Is there any way
> to get out of this situation other than creating an entire new review?
>
>
> On Friday, July 3, 2015 at 3:54:30 PM UTC-5, David Trowbridge wrote:
>
> Dan,
>
> This is something that used to work correctly, but obviously something has
> regressed. I'd actually run into this just a couple days ago, so I'll take
> a look soon.
>
> -David
>
> On Thu, Jul 2, 2015 at 6:01 AM, Daniel Laird 
> wrote:
>
> WE are running 2.0.17 and have managed to create a situation and dont know
> how to resolve it - or whether its a defect
>
> Someone created 2 reviews with code changes that were dependent.
> They marked Review 2 as Depends On Review 1 -  this then updated the
> 'Blocks' field.
> They then marked Review 1 as Depends On Review 2 - as they felt that both
> reviews had to be committed together.
>
> However the server then starts to give us lots of errors:
> Traceback (most recent call last):
>
>   File
> "/usr/local/lib/python2.7/dist-packages/Django-1.6.11-py2.7.egg/django/core/handlers/base.py",
> line 199, in get_response
> response = middleware_method(request, response)
>
>   File
> "/usr/local/lib/python2.7/dist-packages/Django-1.6.11-py2.7.egg/django/middleware/http.py",
> line 14, in process_response
> response['Content-Length'] = str(len(response.content))
>
>   File
> "/usr/local/lib/python2.7/dist-packages/Djblets-0.8.20-py2.7.egg/djblets/webapi/responses.py",
> line 109, in _get_content
> **self.encoder_kwargs)
>
>   File
> "/usr/local/lib/python2.7/dist-packages/Djblets-0.8.20-py2.7.egg/djblets/webapi/encoders.py",
> line 110, in encode
> return super(JSONEncoderAdapter, self).encode(o)
>
>   File "/usr/lib/python2.7/json/encoder.py", line 201, in encode
> chunks = self.iterencode(o, _one_shot=True)
>
>   File "/usr/lib/python2.7/json/encoder.py", line 264, in iterencode
> return _iterencode(o, 0)
>
> ValueError: Circular reference detected
>
> It maybe that the double linking is incorrect usage - however having been
> able to get into that situation.  If we try to remove one of the 'Blocks'
> fields we just get a spinning 'Loading' icon and are unable to move past
> this to remove the Circular Reference.
>
> Not sure if you think this is user error, a defect or a combination of
> both - but thought I would share it.
>
> Cheers
> Dan
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
>
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard...@googlegroups.com.
>
>
> For more options, visit https://groups.google.com/d/optout.
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Depends-On, Blocks and Circular Reference

2016-12-19 Thread Philip Sanders 
I think I just hit this issue with the same release too.  Is there any way 
to get out of this situation other than creating an entire new review?

On Friday, July 3, 2015 at 3:54:30 PM UTC-5, David Trowbridge wrote:
>
> Dan,
>
> This is something that used to work correctly, but obviously something has 
> regressed. I'd actually run into this just a couple days ago, so I'll take 
> a look soon.
>
> -David
>
> On Thu, Jul 2, 2015 at 6:01 AM, Daniel Laird  > wrote:
>
>> WE are running 2.0.17 and have managed to create a situation and dont 
>> know how to resolve it - or whether its a defect
>>
>> Someone created 2 reviews with code changes that were dependent.
>> They marked Review 2 as Depends On Review 1 -  this then updated the 
>> 'Blocks' field.
>> They then marked Review 1 as Depends On Review 2 - as they felt that both 
>> reviews had to be committed together.
>>
>> However the server then starts to give us lots of errors:
>> Traceback (most recent call last):
>>
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/Django-1.6.11-py2.7.egg/django/core/handlers/base.py",
>>  
>> line 199, in get_response
>> response = middleware_method(request, response)
>>
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/Django-1.6.11-py2.7.egg/django/middleware/http.py",
>>  
>> line 14, in process_response
>> response['Content-Length'] = str(len(response.content))
>>
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/Djblets-0.8.20-py2.7.egg/djblets/webapi/responses.py",
>>  
>> line 109, in _get_content
>> **self.encoder_kwargs)
>>
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/Djblets-0.8.20-py2.7.egg/djblets/webapi/encoders.py",
>>  
>> line 110, in encode
>> return super(JSONEncoderAdapter, self).encode(o)
>>
>>   File "/usr/lib/python2.7/json/encoder.py", line 201, in encode
>> chunks = self.iterencode(o, _one_shot=True)
>>
>>   File "/usr/lib/python2.7/json/encoder.py", line 264, in iterencode
>> return _iterencode(o, 0)
>>
>> ValueError: Circular reference detected
>>
>> It maybe that the double linking is incorrect usage - however having been 
>> able to get into that situation.  If we try to remove one of the 'Blocks' 
>> fields we just get a spinning 'Loading' icon and are unable to move past 
>> this to remove the Circular Reference.
>>
>> Not sure if you think this is user error, a defect or a combination of 
>> both - but thought I would share it.
>>
>> Cheers
>> Dan
>>
>> -- 
>> Supercharge your Review Board with Power Pack: 
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons: 
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to reviewboard...@googlegroups.com .
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Depends-On, Blocks and Circular Reference

2015-07-02 Thread Daniel Laird 
WE are running 2.0.17 and have managed to create a situation and dont know 
how to resolve it - or whether its a defect

Someone created 2 reviews with code changes that were dependent.
They marked Review 2 as Depends On Review 1 -  this then updated the 
'Blocks' field.
They then marked Review 1 as Depends On Review 2 - as they felt that both 
reviews had to be committed together.

However the server then starts to give us lots of errors:
Traceback (most recent call last):

  File 
/usr/local/lib/python2.7/dist-packages/Django-1.6.11-py2.7.egg/django/core/handlers/base.py,
 
line 199, in get_response
response = middleware_method(request, response)

  File 
/usr/local/lib/python2.7/dist-packages/Django-1.6.11-py2.7.egg/django/middleware/http.py,
 
line 14, in process_response
response['Content-Length'] = str(len(response.content))

  File 
/usr/local/lib/python2.7/dist-packages/Djblets-0.8.20-py2.7.egg/djblets/webapi/responses.py,
 
line 109, in _get_content
**self.encoder_kwargs)

  File 
/usr/local/lib/python2.7/dist-packages/Djblets-0.8.20-py2.7.egg/djblets/webapi/encoders.py,
 
line 110, in encode
return super(JSONEncoderAdapter, self).encode(o)

  File /usr/lib/python2.7/json/encoder.py, line 201, in encode
chunks = self.iterencode(o, _one_shot=True)

  File /usr/lib/python2.7/json/encoder.py, line 264, in iterencode
return _iterencode(o, 0)

ValueError: Circular reference detected

It maybe that the double linking is incorrect usage - however having been 
able to get into that situation.  If we try to remove one of the 'Blocks' 
fields we just get a spinning 'Loading' icon and are unable to move past 
this to remove the Circular Reference.

Not sure if you think this is user error, a defect or a combination of both 
- but thought I would share it.

Cheers
Dan

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.