Re: Reviewboard 1.7 -> Reviewboard 2.0.x update
HI Christian, Many thanks for the response, it was as you describe, our custom script (which is for following externals) - is meant to strip the URL. But the wildcard match failed sometimes, leaving the full URL in the diff file. Which RB then processed. On moving the data from old server -> new server (with 2.0.11) - I ran some sed scripts to ensure the SVN paths were consistent. Now because the BaseUrl matches the file path RB displays it all fine. I have another issue, but will mail the list about this. Cheers Dan On Friday, 19 December 2014 22:38:42 UTC, Christian Hammond wrote: > > Hi Daniel, > > We never intended the base directory to contain a URL. It sounds like the > custom script is probably responsible for this. > > Can you confirm whether the base directory's URL exactly matches the > configured URL for the repository? > > In the case that it does match, we take the URL as-is, but if it does not > match, we normalize and start building a path (by combining the repository > path, base directory, and file path in the diff). This was not intended to > handle URLs in the path, but it may be the cause of your problems. > > Christian > > -- > Christian Hammond - chi...@chipx86.com > Review Board - https://www.reviewboard.org > Beanbag, Inc. - https://www.beanbaginc.com > > -Original Message- > From: Daniel Laird > > Reply: revie...@googlegroups.com >> > Date: December 19, 2014 at 3:29:19 AM > To: revie...@googlegroups.com >> > Cc: chi...@chipx86.com >> > Subject: Re: Reviewboard 1.7 -> Reviewboard 2.0.x update > > > Christian > > > > Many thanks for getting back to me. > > I think I know why it is breaking but don't know how to fix it. > > > > The diff looks as I would expect (with all files being something like > this): > > Index: libs/A/Source/File.cpp > > === > > --- libs/A/Source/File.cpp (revision 143446) > > +++ libs/A/Source/File.cpp (working copy) > > > > I used the webapi to query the Review and spotted the following on the > diff > > resource associated with the review request: > > http://SVN_SERVER/svn/REPO_NAME/branches/features/software > > > > I suspect that maybe in the old GUI (Reviewboard 1.7) it used to combine > > this basedir and the file path in the diff to draw the differences. > > I think that maybe we have a problem where it appends the Repo Path + > > BaseDir + FilePath > > Maybe there is a difference in RB2.0.x? > > > > Our databases on legacy SW used a lot of SVN externals, so someone wrote > a > > script to generate a single diff file relative to the SVN_SERVER root. > > It allowed us a single review which was better, but it probably set the > > Basedir to be the complete http path. > > Maybe it was not supposed to work that way, but we just got away with > it. > > > > Interested to see what you think and whether there is a regression or a > > misuse by us that has been cleared up in RB2.0, the only problem now is > we > > have 100s of requests that are like this > > > > Hope you can help, and happy to try patches. > > Cheers > > Dan > > > > > > On Thursday, 18 December 2014 20:40:16 UTC, Christian Hammond wrote: > > > > > > Hi Dan, > > > > > > Would you be able to provide some of the data from that diff > > > (specifically, the 'Index:' line, '---', and '+++' lines in the diff)? > > > > > > A lot of work was done on Subversion since 1.7.x, so something may > have > > > regressed. I don't recall being able to handle file paths containing > > > 'http:' in it, though. > > > > > > Christian > > > > > > -- > > > Christian Hammond - chi...@chipx86.com > > > Review Board - http://www.reviewboard.org > > > Beanbag, Inc. - http://www.beanbaginc.com > > > > > > On Thu, Dec 18, 2014 at 4:32 AM, Daniel Laird > > > wrote: > > >> > > >> To follow up the error message we get from the diff viewer is: > > >> The file '/svn/Common_PythonTests/ > > >> http://SVN_SERVER_NAME/svn/Common_PythonTests/path/to/file/base.py' > > >> (r1838) could not be found in the repository: > > >> > '/svn/Common_PythonTests/!svn/rvr/1838/http:/SVN_SERVER/svn/Common_PythonTests/path/to/file/base.py' > > > > >> path no
Re: Reviewboard 1.7 -> Reviewboard 2.0.x update
Hi Daniel, We never intended the base directory to contain a URL. It sounds like the custom script is probably responsible for this. Can you confirm whether the base directory's URL exactly matches the configured URL for the repository? In the case that it does match, we take the URL as-is, but if it does not match, we normalize and start building a path (by combining the repository path, base directory, and file path in the diff). This was not intended to handle URLs in the path, but it may be the cause of your problems. Christian -- Christian Hammond - chip...@chipx86.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com -Original Message- From: Daniel Laird Reply: reviewboard@googlegroups.com > Date: December 19, 2014 at 3:29:19 AM To: reviewboard@googlegroups.com > Cc: chip...@chipx86.com > Subject: Re: Reviewboard 1.7 -> Reviewboard 2.0.x update > Christian > > Many thanks for getting back to me. > I think I know why it is breaking but don't know how to fix it. > > The diff looks as I would expect (with all files being something like this): > Index: libs/A/Source/File.cpp > === > --- libs/A/Source/File.cpp (revision 143446) > +++ libs/A/Source/File.cpp (working copy) > > I used the webapi to query the Review and spotted the following on the diff > resource associated with the review request: > http://SVN_SERVER/svn/REPO_NAME/branches/features/software > > I suspect that maybe in the old GUI (Reviewboard 1.7) it used to combine > this basedir and the file path in the diff to draw the differences. > I think that maybe we have a problem where it appends the Repo Path + > BaseDir + FilePath > Maybe there is a difference in RB2.0.x? > > Our databases on legacy SW used a lot of SVN externals, so someone wrote a > script to generate a single diff file relative to the SVN_SERVER root. > It allowed us a single review which was better, but it probably set the > Basedir to be the complete http path. > Maybe it was not supposed to work that way, but we just got away with it. > > Interested to see what you think and whether there is a regression or a > misuse by us that has been cleared up in RB2.0, the only problem now is we > have 100s of requests that are like this > > Hope you can help, and happy to try patches. > Cheers > Dan > > > On Thursday, 18 December 2014 20:40:16 UTC, Christian Hammond wrote: > > > > Hi Dan, > > > > Would you be able to provide some of the data from that diff > > (specifically, the 'Index:' line, '---', and '+++' lines in the diff)? > > > > A lot of work was done on Subversion since 1.7.x, so something may have > > regressed. I don't recall being able to handle file paths containing > > 'http:' in it, though. > > > > Christian > > > > -- > > Christian Hammond - chi...@chipx86.com > > Review Board - http://www.reviewboard.org > > Beanbag, Inc. - http://www.beanbaginc.com > > > > On Thu, Dec 18, 2014 at 4:32 AM, Daniel Laird > > > wrote: > >> > >> To follow up the error message we get from the diff viewer is: > >> The file '/svn/Common_PythonTests/ > >> http://SVN_SERVER_NAME/svn/Common_PythonTests/path/to/file/base.py' > >> (r1838) could not be found in the repository: > >> '/svn/Common_PythonTests/!svn/rvr/1838/http:/SVN_SERVER/svn/Common_PythonTests/path/to/file/base.py' > >> > >> path not found > >> > >> The review was created before the migration (1.7.25) - we dumped the > >> database, re-imported and off we went. > >> New requests seem to be ok and many of the old requests are fine. This > >> was probably created via the GUI in 1.7.25 and uploaded a diff file > >> produced by SVN diff. > >> > >> Cheers > >> Dan > >> > >> On Thursday, 18 December 2014 11:29:18 UTC, Daniel Laird wrote: > >>> > >>> All, > >>> > >>> We were running Reviewboard 1.7.25 and people used a number of methods > >>> to create review requests: > >>> svn diff - manually upload > >>> post-review > >>> rbt > >>> > >>> I have just migrated us to Reviewboard 2.0.11 and seem to have hit an > >>> issue. > >>> > >>> Some of our reviews no longer display it suggests that a file cant be > >>> found. > >>> And seems to have prepended some sub part of the path before the full > >>> file path. > >>
Re: Reviewboard 1.7 -> Reviewboard 2.0.x update
Christian Many thanks for getting back to me. I think I know why it is breaking but don't know how to fix it. The diff looks as I would expect (with all files being something like this): Index: libs/A/Source/File.cpp === --- libs/A/Source/File.cpp (revision 143446) +++ libs/A/Source/File.cpp (working copy) I used the webapi to query the Review and spotted the following on the diff resource associated with the review request: http://SVN_SERVER/svn/REPO_NAME/branches/features/software I suspect that maybe in the old GUI (Reviewboard 1.7) it used to combine this basedir and the file path in the diff to draw the differences. I think that maybe we have a problem where it appends the Repo Path + BaseDir + FilePath Maybe there is a difference in RB2.0.x? Our databases on legacy SW used a lot of SVN externals, so someone wrote a script to generate a single diff file relative to the SVN_SERVER root. It allowed us a single review which was better, but it probably set the Basedir to be the complete http path. Maybe it was not supposed to work that way, but we just got away with it. Interested to see what you think and whether there is a regression or a misuse by us that has been cleared up in RB2.0, the only problem now is we have 100s of requests that are like this Hope you can help, and happy to try patches. Cheers Dan On Thursday, 18 December 2014 20:40:16 UTC, Christian Hammond wrote: > > Hi Dan, > > Would you be able to provide some of the data from that diff > (specifically, the 'Index:' line, '---', and '+++' lines in the diff)? > > A lot of work was done on Subversion since 1.7.x, so something may have > regressed. I don't recall being able to handle file paths containing > 'http:' in it, though. > > Christian > > -- > Christian Hammond - chi...@chipx86.com > Review Board - http://www.reviewboard.org > Beanbag, Inc. - http://www.beanbaginc.com > > On Thu, Dec 18, 2014 at 4:32 AM, Daniel Laird > wrote: >> >> To follow up the error message we get from the diff viewer is: >> The file '/svn/Common_PythonTests/ >> http://SVN_SERVER_NAME/svn/Common_PythonTests/path/to/file/base.py' >> (r1838) could not be found in the repository: >> '/svn/Common_PythonTests/!svn/rvr/1838/http:/SVN_SERVER/svn/Common_PythonTests/path/to/file/base.py' >> >> path not found >> >> The review was created before the migration (1.7.25) - we dumped the >> database, re-imported and off we went. >> New requests seem to be ok and many of the old requests are fine. This >> was probably created via the GUI in 1.7.25 and uploaded a diff file >> produced by SVN diff. >> >> Cheers >> Dan >> >> On Thursday, 18 December 2014 11:29:18 UTC, Daniel Laird wrote: >>> >>> All, >>> >>> We were running Reviewboard 1.7.25 and people used a number of methods >>> to create review requests: >>> svn diff - manually upload >>> post-review >>> rbt >>> >>> I have just migrated us to Reviewboard 2.0.11 and seem to have hit an >>> issue. >>> >>> Some of our reviews no longer display it suggests that a file cant be >>> found. >>> And seems to have prepended some sub part of the path before the full >>> file path. >>> So I get something like >>> >>> /svn/REPONAME/http://SVN_SERVER/svn/REPONAME/path/to/file.cpp cant be >>> found. >>> >>> Have we got to change something to make these work? >>> >>> I can provide logs offline if that helps? >>> >>> Dan >>> >>> -- >> Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ >> --- >> Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ >> --- >> Happy user? Let us know at http://www.reviewboard.org/users/ >> --- >> You received this message because you are subscribed to the Google Groups >> "reviewboard" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to reviewboard...@googlegroups.com . >> For more options, visit https://groups.google.com/d/optout. >> > -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Reviewboard 1.7 -> Reviewboard 2.0.x update
Hi Dan, Would you be able to provide some of the data from that diff (specifically, the 'Index:' line, '---', and '+++' lines in the diff)? A lot of work was done on Subversion since 1.7.x, so something may have regressed. I don't recall being able to handle file paths containing 'http:' in it, though. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On Thu, Dec 18, 2014 at 4:32 AM, Daniel Laird wrote: > > To follow up the error message we get from the diff viewer is: > The file '/svn/Common_PythonTests/ > http://SVN_SERVER_NAME/svn/Common_PythonTests/path/to/file/base.py' > (r1838) could not be found in the repository: > '/svn/Common_PythonTests/!svn/rvr/1838/http:/SVN_SERVER/svn/Common_PythonTests/path/to/file/base.py' > path not found > > The review was created before the migration (1.7.25) - we dumped the > database, re-imported and off we went. > New requests seem to be ok and many of the old requests are fine. This > was probably created via the GUI in 1.7.25 and uploaded a diff file > produced by SVN diff. > > Cheers > Dan > > On Thursday, 18 December 2014 11:29:18 UTC, Daniel Laird wrote: >> >> All, >> >> We were running Reviewboard 1.7.25 and people used a number of methods to >> create review requests: >> svn diff - manually upload >> post-review >> rbt >> >> I have just migrated us to Reviewboard 2.0.11 and seem to have hit an >> issue. >> >> Some of our reviews no longer display it suggests that a file cant be >> found. >> And seems to have prepended some sub part of the path before the full >> file path. >> So I get something like >> >> /svn/REPONAME/http://SVN_SERVER/svn/REPONAME/path/to/file.cpp cant be >> found. >> >> Have we got to change something to make these work? >> >> I can provide logs offline if that helps? >> >> Dan >> >> -- > Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ > --- > Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ > --- > Happy user? Let us know at http://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Reviewboard 1.7 -> Reviewboard 2.0.x update
To follow up the error message we get from the diff viewer is: The file '/svn/Common_PythonTests/http://SVN_SERVER_NAME/svn/Common_PythonTests/path/to/file/base.py' (r1838) could not be found in the repository: '/svn/Common_PythonTests/!svn/rvr/1838/http:/SVN_SERVER/svn/Common_PythonTests/path/to/file/base.py' path not found The review was created before the migration (1.7.25) - we dumped the database, re-imported and off we went. New requests seem to be ok and many of the old requests are fine. This was probably created via the GUI in 1.7.25 and uploaded a diff file produced by SVN diff. Cheers Dan On Thursday, 18 December 2014 11:29:18 UTC, Daniel Laird wrote: > > All, > > We were running Reviewboard 1.7.25 and people used a number of methods to > create review requests: > svn diff - manually upload > post-review > rbt > > I have just migrated us to Reviewboard 2.0.11 and seem to have hit an > issue. > > Some of our reviews no longer display it suggests that a file cant be > found. > And seems to have prepended some sub part of the path before the full file > path. > So I get something like > > /svn/REPONAME/http://SVN_SERVER/svn/REPONAME/path/to/file.cpp cant be > found. > > Have we got to change something to make these work? > > I can provide logs offline if that helps? > > Dan > > -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Reviewboard 1.7 -> Reviewboard 2.0.x update
All, We were running Reviewboard 1.7.25 and people used a number of methods to create review requests: svn diff - manually upload post-review rbt I have just migrated us to Reviewboard 2.0.11 and seem to have hit an issue. Some of our reviews no longer display it suggests that a file cant be found. And seems to have prepended some sub part of the path before the full file path. So I get something like /svn/REPONAME/http://SVN_SERVER/svn/REPONAME/path/to/file.cpp cant be found. Have we got to change something to make these work? I can provide logs offline if that helps? Dan -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
