Re: post-review tool: How to post only *.c and *.h files
The repository path specified must be the *root* of the SVN repository, which must match what's in Review Board. The files being put up for review should be passed as additional parameters. For example: $ post-review src/*.c Are you trying to post existing (committed) code, or new (uncommitted) code to the repository? If the latter, there was a script for that in another thread. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Tue, Aug 24, 2010 at 7:29 AM, sakthi listsak...@gmail.com wrote: I tried to give a path that resides inside the repository.. I get Got API Error 207 (HTTP code 200): The file was not found in the repository post-review doesnt take path inside repository? Do i have to touch the file which have to be reviewed and check in to post into review board? Kindly help me a way to post the files into review board. Regards Sakthi -error- start--- Review request created Uploading diff, size: 2666171 HTTP POSTing to http://10.20.1.98/revboard/api/json/reviewrequests/3/diff/new/: {'basedir': '/'} Got API Error 207 (HTTP code 200): The file was not found in the repository Error data: {u'stat': u'fail', u'file': u'/projects/starship/branches/br-catIQ/dect/dc-nwk/src-pp/pnciss.c', u'err': {u'msg': u'The file was not found in the repository', u'code': 207}, u'revision': u'21677'} Error uploading diff Your review request still exists, but the diff is not attached. --error-end On Aug 24, 6:30 pm, sakthi listsak...@gmail.com wrote: Hello Christian, Can you tell me how to mention the path? I am stuck up.. i am getting this error as the repository contains doc files.. Failed to execute command: ['svn', 'info', 'Design Specs/ s1020_design.doc'] May i know how to mention only the path that is required? This is the sample command line i used. $ sudo post-review -d --server=http://reviewboard.local.server/-- revision-range=21677:22627 --repository-url=http://svn.local.server/ svn/repos/projects/Project1/ Thanks Sakthi On Aug 24, 12:18 pm, Christian Hammond chip...@chipx86.com wrote: If you can build the file list separately of *.c and *.h files, you can just pass those to post-review. It takes file paths and lists of files. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Mon, Aug 23, 2010 at 11:11 PM, sakthi listsak...@gmail.com wrote: Hi Chris, I accept what you said, I can see some logic there. I dont want to load test scripts and docs for review.. I will have to find a way.. thanks again. sakthi On Aug 24, 2:03 am, Chris Clark chris.cl...@ingres.com wrote: sakthi wrote: Could find i have to use post-review tool to post the code into review board. Can some one help me out how to post ONLY *.c and *.h files recursively from SVN directory. Is there any automated script available.. where i shall modify the require information to post the code that is required? Let me pose a question to you ;-) How are you going to submit just *.c and *.h files to subversion when you come to commit? There is no reviewboard involved at that stage. Postreview will accept the same filenames on command line that subversion will take at submit time. Chris -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com reviewboard%2bunsubscr...@googlegroups.comreviewboard%252bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: post-review tool: How to post only *.c and *.h files
It should. When doing --revision-range with Subversion, we're essentially passing that range to 'svn diff' when generating the diff. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Tue, Aug 24, 2010 at 9:10 AM, sakthi listsak...@gmail.com wrote: does review board handle if the files are deleted and new file that is added in the repository, while doing --revision-range? On Aug 24, 7:29 pm, sakthi listsak...@gmail.com wrote: I tried to give a path that resides inside the repository.. I get Got API Error 207 (HTTP code 200): The file was not found in the repository post-review doesnt take path inside repository? Do i have to touch the file which have to be reviewed and check in to post into review board? Kindly help me a way to post the files into review board. Regards Sakthi -error- start--- Review request created Uploading diff, size: 2666171 HTTP POSTing tohttp:// 10.20.1.98/revboard/api/json/reviewrequests/3/diff/new/:{'basedirhttp://10.20.1.98/revboard/api/json/reviewrequests/3/diff/new/:%7B%27basedir': '/'} Got API Error 207 (HTTP code 200): The file was not found in the repository Error data: {u'stat': u'fail', u'file': u'/projects/starship/branches/br-catIQ/dect/dc-nwk/src-pp/pnciss.c', u'err': {u'msg': u'The file was not found in the repository', u'code': 207}, u'revision': u'21677'} Error uploading diff Your review request still exists, but the diff is not attached. --error-end On Aug 24, 6:30 pm, sakthi listsak...@gmail.com wrote: Hello Christian, Can you tell me how to mention the path? I am stuck up.. i am getting this error as the repository contains doc files.. Failed to execute command: ['svn', 'info', 'Design Specs/ s1020_design.doc'] May i know how to mention only the path that is required? This is the sample command line i used. $ sudo post-review -d --server=http://reviewboard.local.server/-- revision-range=21677:22627 --repository-url=http://svn.local.server/ svn/repos/projects/Project1/ Thanks Sakthi On Aug 24, 12:18 pm, Christian Hammond chip...@chipx86.com wrote: If you can build the file list separately of *.c and *.h files, you can just pass those to post-review. It takes file paths and lists of files. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Mon, Aug 23, 2010 at 11:11 PM, sakthi listsak...@gmail.com wrote: Hi Chris, I accept what you said, I can see some logic there. I dont want to load test scripts and docs for review.. I will have to find a way.. thanks again. sakthi On Aug 24, 2:03 am, Chris Clark chris.cl...@ingres.com wrote: sakthi wrote: Could find i have to use post-review tool to post the code into review board. Can some one help me out how to post ONLY *.c and *.h files recursively from SVN directory. Is there any automated script available.. where i shall modify the require information to post the code that is required? Let me pose a question to you ;-) How are you going to submit just *.c and *.h files to subversion when you come to commit? There is no reviewboard involved at that stage. Postreview will accept the same filenames on command line that subversion will take at submit time. Chris -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com reviewboard%2bunsubscr...@googlegroups.comreviewboard%252bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more
Re: post-review tool: How to post only *.c and *.h files
Hi Chris, I accept what you said, I can see some logic there. I dont want to load test scripts and docs for review.. I will have to find a way.. thanks again. sakthi On Aug 24, 2:03 am, Chris Clark chris.cl...@ingres.com wrote: sakthi wrote: Could find i have to use post-review tool to post the code into review board. Can some one help me out how to post ONLY *.c and *.h files recursively from SVN directory. Is there any automated script available.. where i shall modify the require information to post the code that is required? Let me pose a question to you ;-) How are you going to submit just *.c and *.h files to subversion when you come to commit? There is no reviewboard involved at that stage. Postreview will accept the same filenames on command line that subversion will take at submit time. Chris -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: post-review tool: How to post only *.c and *.h files
There could be -exclude or -include switch to post-review but I think better way is keep all in two separate checkouts which appropriate ignore rulez - one for docs second for source code. On Tue, Aug 24, 2010 at 8:11 AM, sakthi listsak...@gmail.com wrote: Hi Chris, I accept what you said, I can see some logic there. I dont want to load test scripts and docs for review.. I will have to find a way.. thanks again. sakthi On Aug 24, 2:03 am, Chris Clark chris.cl...@ingres.com wrote: sakthi wrote: Could find i have to use post-review tool to post the code into review board. Can some one help me out how to post ONLY *.c and *.h files recursively from SVN directory. Is there any automated script available.. where i shall modify the require information to post the code that is required? Let me pose a question to you ;-) How are you going to submit just *.c and *.h files to subversion when you come to commit? There is no reviewboard involved at that stage. Postreview will accept the same filenames on command line that subversion will take at submit time. Chris -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Jan Koprowski -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: post-review tool: How to post only *.c and *.h files
If you can build the file list separately of *.c and *.h files, you can just pass those to post-review. It takes file paths and lists of files. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, Aug 23, 2010 at 11:11 PM, sakthi listsak...@gmail.com wrote: Hi Chris, I accept what you said, I can see some logic there. I dont want to load test scripts and docs for review.. I will have to find a way.. thanks again. sakthi On Aug 24, 2:03 am, Chris Clark chris.cl...@ingres.com wrote: sakthi wrote: Could find i have to use post-review tool to post the code into review board. Can some one help me out how to post ONLY *.c and *.h files recursively from SVN directory. Is there any automated script available.. where i shall modify the require information to post the code that is required? Let me pose a question to you ;-) How are you going to submit just *.c and *.h files to subversion when you come to commit? There is no reviewboard involved at that stage. Postreview will accept the same filenames on command line that subversion will take at submit time. Chris -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: post-review tool: How to post only *.c and *.h files
Hello Christian, Can you tell me how to mention the path? I am stuck up.. i am getting this error as the repository contains doc files.. Failed to execute command: ['svn', 'info', 'Design Specs/ s1020_design.doc'] May i know how to mention only the path that is required? This is the sample command line i used. $ sudo post-review -d --server=http://reviewboard.local.server/ -- revision-range=21677:22627 --repository-url=http://svn.local.server/ svn/repos/projects/Project1/ Thanks Sakthi On Aug 24, 12:18 pm, Christian Hammond chip...@chipx86.com wrote: If you can build the file list separately of *.c and *.h files, you can just pass those to post-review. It takes file paths and lists of files. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Mon, Aug 23, 2010 at 11:11 PM, sakthi listsak...@gmail.com wrote: Hi Chris, I accept what you said, I can see some logic there. I dont want to load test scripts and docs for review.. I will have to find a way.. thanks again. sakthi On Aug 24, 2:03 am, Chris Clark chris.cl...@ingres.com wrote: sakthi wrote: Could find i have to use post-review tool to post the code into review board. Can some one help me out how to post ONLY *.c and *.h files recursively from SVN directory. Is there any automated script available.. where i shall modify the require information to post the code that is required? Let me pose a question to you ;-) How are you going to submit just *.c and *.h files to subversion when you come to commit? There is no reviewboard involved at that stage. Postreview will accept the same filenames on command line that subversion will take at submit time. Chris -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: post-review tool: How to post only *.c and *.h files
I tried to give a path that resides inside the repository.. I get Got API Error 207 (HTTP code 200): The file was not found in the repository post-review doesnt take path inside repository? Do i have to touch the file which have to be reviewed and check in to post into review board? Kindly help me a way to post the files into review board. Regards Sakthi -error- start--- Review request created Uploading diff, size: 2666171 HTTP POSTing to http://10.20.1.98/revboard/api/json/reviewrequests/3/diff/new/: {'basedir': '/'} Got API Error 207 (HTTP code 200): The file was not found in the repository Error data: {u'stat': u'fail', u'file': u'/projects/starship/branches/br-catIQ/dect/dc-nwk/src-pp/pnciss.c', u'err': {u'msg': u'The file was not found in the repository', u'code': 207}, u'revision': u'21677'} Error uploading diff Your review request still exists, but the diff is not attached. --error-end On Aug 24, 6:30 pm, sakthi listsak...@gmail.com wrote: Hello Christian, Can you tell me how to mention the path? I am stuck up.. i am getting this error as the repository contains doc files.. Failed to execute command: ['svn', 'info', 'Design Specs/ s1020_design.doc'] May i know how to mention only the path that is required? This is the sample command line i used. $ sudo post-review -d --server=http://reviewboard.local.server/-- revision-range=21677:22627 --repository-url=http://svn.local.server/ svn/repos/projects/Project1/ Thanks Sakthi On Aug 24, 12:18 pm, Christian Hammond chip...@chipx86.com wrote: If you can build the file list separately of *.c and *.h files, you can just pass those to post-review. It takes file paths and lists of files. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Mon, Aug 23, 2010 at 11:11 PM, sakthi listsak...@gmail.com wrote: Hi Chris, I accept what you said, I can see some logic there. I dont want to load test scripts and docs for review.. I will have to find a way.. thanks again. sakthi On Aug 24, 2:03 am, Chris Clark chris.cl...@ingres.com wrote: sakthi wrote: Could find i have to use post-review tool to post the code into review board. Can some one help me out how to post ONLY *.c and *.h files recursively from SVN directory. Is there any automated script available.. where i shall modify the require information to post the code that is required? Let me pose a question to you ;-) How are you going to submit just *.c and *.h files to subversion when you come to commit? There is no reviewboard involved at that stage. Postreview will accept the same filenames on command line that subversion will take at submit time. Chris -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: post-review tool: How to post only *.c and *.h files
does review board handle if the files are deleted and new file that is added in the repository, while doing --revision-range? On Aug 24, 7:29 pm, sakthi listsak...@gmail.com wrote: I tried to give a path that resides inside the repository.. I get Got API Error 207 (HTTP code 200): The file was not found in the repository post-review doesnt take path inside repository? Do i have to touch the file which have to be reviewed and check in to post into review board? Kindly help me a way to post the files into review board. Regards Sakthi -error- start--- Review request created Uploading diff, size: 2666171 HTTP POSTing tohttp://10.20.1.98/revboard/api/json/reviewrequests/3/diff/new/:{'basedir': '/'} Got API Error 207 (HTTP code 200): The file was not found in the repository Error data: {u'stat': u'fail', u'file': u'/projects/starship/branches/br-catIQ/dect/dc-nwk/src-pp/pnciss.c', u'err': {u'msg': u'The file was not found in the repository', u'code': 207}, u'revision': u'21677'} Error uploading diff Your review request still exists, but the diff is not attached. --error-end On Aug 24, 6:30 pm, sakthi listsak...@gmail.com wrote: Hello Christian, Can you tell me how to mention the path? I am stuck up.. i am getting this error as the repository contains doc files.. Failed to execute command: ['svn', 'info', 'Design Specs/ s1020_design.doc'] May i know how to mention only the path that is required? This is the sample command line i used. $ sudo post-review -d --server=http://reviewboard.local.server/-- revision-range=21677:22627 --repository-url=http://svn.local.server/ svn/repos/projects/Project1/ Thanks Sakthi On Aug 24, 12:18 pm, Christian Hammond chip...@chipx86.com wrote: If you can build the file list separately of *.c and *.h files, you can just pass those to post-review. It takes file paths and lists of files. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Mon, Aug 23, 2010 at 11:11 PM, sakthi listsak...@gmail.com wrote: Hi Chris, I accept what you said, I can see some logic there. I dont want to load test scripts and docs for review.. I will have to find a way.. thanks again. sakthi On Aug 24, 2:03 am, Chris Clark chris.cl...@ingres.com wrote: sakthi wrote: Could find i have to use post-review tool to post the code into review board. Can some one help me out how to post ONLY *.c and *.h files recursively from SVN directory. Is there any automated script available.. where i shall modify the require information to post the code that is required? Let me pose a question to you ;-) How are you going to submit just *.c and *.h files to subversion when you come to commit? There is no reviewboard involved at that stage. Postreview will accept the same filenames on command line that subversion will take at submit time. Chris -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
post-review tool: How to post only *.c and *.h files
I am first timer for Review Board.. trying to figure out how to post code into review board for review.. and how to initiate review etc... Could find i have to use post-review tool to post the code into review board. Can some one help me out how to post ONLY *.c and *.h files recursively from SVN directory. Is there any automated script available.. where i shall modify the require information to post the code that is required? Cheers Sakthi -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: post-review tool: How to post only *.c and *.h files
sakthi wrote: Could find i have to use post-review tool to post the code into review board. Can some one help me out how to post ONLY *.c and *.h files recursively from SVN directory. Is there any automated script available.. where i shall modify the require information to post the code that is required? Let me pose a question to you ;-) How are you going to submit just *.c and *.h files to subversion when you come to commit? There is no reviewboard involved at that stage. Postreview will accept the same filenames on command line that subversion will take at submit time. Chris -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en