Issue 873 in reviewboard: page not found at /review/r//diff/-/raw
Comment #1 on issue 873 by scott.benjamin: page not found at /review/r//diff/-/raw http://code.google.com/p/reviewboard/issues/detail?id=873 I'm also experiencing this issue. Funny thing is that it doesn't seem to show up until the review is assigned. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 892 in reviewboard: Diff-viewer crash when viewing difference between diffs with new files.
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 892 by eduardofelipe87: Diff-viewer crash when viewing difference between diffs with new files. http://code.google.com/p/reviewboard/issues/detail?id=892 What's the URL of the page containing the problem? /r/11/diff/2-3/#index_header What steps will reproduce the problem? 1. Create new files and post the review of them 2. Update the diff. 3. Request to see what changes between diffs. What is the expected output? What do you see instead? A page containing the difference between two diffs. I see this error: list index out of range Traceback (most recent call last): File "/usr/lib/python2.4/site-packages/ReviewBoard-1.0alpha4- py2.4.egg/reviewboard/diffviewer/views.py", line 145, in view_diff interdiffset, highlighting, True)[0] IndexError: list index out of range What operating system are you using? What browser? MacOS X. Firefox 3.0.6 -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 891 in reviewboard: LDAP enhancements
Comment #1 on issue 891 by schlaber: LDAP enhancements http://code.google.com/p/reviewboard/issues/detail?id=891 3) The ldap username should be case insensitiv. If you login with username "Test" RB will create an new user. If you type "test" as username the next time, RB creates also an new user and doesn't query the user "Test". Both "Test" and "test" are identically in the ldap-tree. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 891 in reviewboard: LDAP enhancements
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 891 by schlaber: LDAP enhancements http://code.google.com/p/reviewboard/issues/detail?id=891 1) Look at the attached image. It's not clear, that one of this two fields must be filled out. If both fields are empty, there is an error during logon. --- if settings.LDAP_EMAIL_DOMAIN: email = u'%...@%s' % (username, settings.LDAP_EMAIL_DOMAIN) elif settings.LDAP_EMAIL_ATTRIBUTE: email = passwd[0][1][settings.LDAP_EMAIL_ATTRIBUTE][0] user = User(username=username, password='', first_name=first_name, last_name=last_name, email=email) --- 2) Is there a good reason why the scope is fix ldap.SCOPE_ONELEVEL? It would be great if there could be an additional setting. I have to search in the scope ldap.SCOPE_SUBTREE --- class LDAPBackend: def authenticate(self, username, password): search = ldapo.search_s(settings.LDAP_BASE_DN, ldap.SCOPE_ONELEVEL, uid) --- Attachments: rb-ldap.png 21.6 KB -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 890 in reviewboard: post-review under Windows-XP (non English language)
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 890 by schlaber: post-review under Windows-XP (non English language) http://code.google.com/p/reviewboard/issues/detail?id=890 What's the URL of the page containing the problem? http://groups.google.de/group/reviewboard/browse_thread/thread/5a60288e363171fa What steps will reproduce the problem? 1. install python2.5 (with all necessary modules), svn-client and gnu-diffutils under an German/Non English Windows-XP 2. Start post-review What is the expected output? What do you see instead? Diff should be uploaded to installed Reviewboard. Cookie-File couldn't be saved, because storing path is hard-coded with English names (see link above) What operating system are you using? What browser? Windows-XP Please provide any additional information below. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 888 in reviewboard: LANGUAGE setting can confuse post-review due to assumption of English output from svn.
Updates: Status: Fixed Comment #4 on issue 888 by chipx86: LANGUAGE setting can confuse post-review due to assumption of English output from svn. http://code.google.com/p/reviewboard/issues/detail?id=888 Should be fixed in alpha 4 (just released it). Let me know if you still have trouble. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 889 in reviewboard: Template for bug-tracker integration is very hard to find for new admin
Comment #6 on issue 889 by ted.dunning: Template for bug-tracker integration is very hard to find for new admin http://code.google.com/p/reviewboard/issues/detail?id=889 Even a wee bit of text on that page would help. "Click on the repository to edit the following additional parameters: " -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 88 in reviewboard: integration with buildbot like systems
Comment #7 on issue 88 by ted.dunning: integration with buildbot like systems http://code.google.com/p/reviewboard/issues/detail?id=88 Hudson (and presumably other continuous integration systems) makes it very easy to have builds trigger pokes of other systems. Thus there is an integration with JIRA that puts a comment on all bugs in the change list of a build. Hudson also handles patch builds well. Apache projects use this extensively by arranging for hudson to scan for issues that are in the "patch available" status. Hudson then downloads the patch, checks out the code, applies the patch and puts a comment back on the original JIRA issue. This structure could easily be adapted if there is a simple way for an outside system to scan for new reviews and a simple API for posting comments. The build system could then sift through the reviews eliminating those it has already seen or which refer to code not under a build watch. Any new qualifying builds would then be built and a summary posted. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 889 in reviewboard: Template for bug-tracker integration is very hard to find for new admin
Comment #5 on issue 889 by chipx86: Template for bug-tracker integration is very hard to find for new admin http://code.google.com/p/reviewboard/issues/detail?id=889 I agree. We're just not at a point where we can do an overhaul of the admin UI to make this more clear. I'm definitely hoping to down the road though. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 889 in reviewboard: Template for bug-tracker integration is very hard to find for new admin
Comment #4 on issue 889 by ted.dunning: Template for bug-tracker integration is very hard to find for new admin http://code.google.com/p/reviewboard/issues/detail?id=889 I generally think that discoverability is better than a manual. Nifty software, btw. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 888 in reviewboard: LANGUAGE setting can confuse post-review due to assumption of English output from svn.
Comment #2 on issue 888 by ted.dunning: LANGUAGE setting can confuse
post-review due to assumption of English output from svn.
http://code.google.com/p/reviewboard/issues/detail?id=888
on Ubuntu 7.10:
$ locale
LANG=zh_CN.UTF-8
LANGUAGE=zh_CN:zh
LC_CTYPE="zh_CN.utf8"
LC_NUMERIC="zh_CN.utf8"
LC_TIME="zh_CN.utf8"
LC_COLLATE="zh_CN.utf8"
LC_MONETARY="zh_CN.utf8"
LC_MESSAGES="zh_CN.utf8"
LC_PAPER="zh_CN.utf8"
LC_NAME="zh_CN.utf8"
LC_ADDRESS="zh_CN.utf8"
LC_TELEPHONE="zh_CN.utf8"
LC_MEASUREMENT="zh_CN.utf8"
LC_IDENTIFICATION="zh_CN.utf8"
LC_ALL=zh_CN.utf8
$ ~/post-review -d
>>> svn info
>>> cleartool pwv -short
Traceback (most recent call last):
File "/home/mud/post-review", line 2307, in
main(sys.argv[1:])
File "/home/mud/post-review", line 2248, in main
repository_info, tool = determine_client()
File "/home/mud/post-review", line 2200, in determine_client
repository_info = tool.get_repository_info()
File "/home/mud/post-review", line 728, in get_repository_info
env={'LANG': 'en_US.UTF-8'})
File "/home/mud/post-review", line 1901, in execute
env=env)
File "/usr/lib/python2.5/subprocess.py", line 594, in __init__
errread, errwrite)
File "/usr/lib/python2.5/subprocess.py", line 1147, in _execute_child
raise child_exception
OSError: [Errno 2] No such file or directory
it will work well after this change:
$ export LANGUAGE=en_US.utf8
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---
Issue 889 in reviewboard: Template for bug-tracker integration is very hard to find for new admin
Updates: Status: Confirmed Comment #3 on issue 889 by chipx86: Template for bug-tracker integration is very hard to find for new admin http://code.google.com/p/reviewboard/issues/detail?id=889 We can certainly add a column. That should be easy to do. I'm working on new documentation that does go into this in some detail. It should be a little easier at least to figure this out from the manual. I'm also hoping to introduce some more streamlined admin UI modifications post-1.0. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 889 in reviewboard: Template for bug-tracker integration is very hard to find for new admin
Comment #2 on issue 889 by ted.dunning: Template for bug-tracker integration is very hard to find for new admin http://code.google.com/p/reviewboard/issues/detail?id=889 OK. That is a fair view of the world. Can the existence of the template be signaled? Perhaps by adding a column to the table summarizing the repositories? Or could there by a little edit pencil in a column that has a header of "Change hidden stuff that we didn't really want you to know about"? -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 889 in reviewboard: Template for bug-tracker integration is very hard to find for new admin
Updates: Labels: -Type-Defect -Priority-Medium Type-Enhancement Priority-Low Milestone-Release1.5 Component-Integration Comment #1 on issue 889 by chipx86: Template for bug-tracker integration is very hard to find for new admin http://code.google.com/p/reviewboard/issues/detail?id=889 It actually is related to the repository. Many of the larger setups out there host a number of different repositories, and these are tied to repositories. For example, we host Google Summer of Code projects, where each repository represents a project, and has its own bug tracker. In the future we may be able to make this more flexible and store bug trackers separately from repositories, making it possible to link one repository to many trackers or vice-versa more easily. But that would be post-1.0. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 887 in reviewboard: Git patch (aqcuired through git show > patch.diff) locks a thread and takes 100% cpu serverside
Comment #2 on issue 887 by jochen.maes: Git patch (aqcuired through git show > patch.diff) locks a thread and takes 100% cpu serverside http://code.google.com/p/reviewboard/issues/detail?id=887 thanks! It works -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 889 in reviewboard: Template for bug-tracker integration is very hard to find for new admin
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 889 by ted.dunning: Template for bug-tracker integration is very hard to find for new admin http://code.google.com/p/reviewboard/issues/detail?id=889 The bug tracker url template is located under the repository configuration. This took me an hour to find and I only found it because I knew it existed and started clicking *everything* to find it. In a related issue, I only clicked on the repository name by accident. There was no clue that there was more configuration to be done other than that showing in the table. I think it would help if the bug tracker template were moved to the general settings. It isn't really related to the SCM repository in any meaningful way. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
