Re: Issue 929 in reviewboard: reviewboard should not alter the diff file
Comment #21 on issue 929 by trowb...@gmail.com: reviewboard should not alter the diff file http://code.google.com/p/reviewboard/issues/detail?id=929 Issue 2953 has been merged into this issue. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 929 in reviewboard: reviewboard should not alter the diff file
Updates: Status: PendingReview Owner: chip...@gmail.com Labels: -Priority-Medium Priority-Critical Milestone-Release1.6.x Comment #18 on issue 929 by chip...@gmail.com: reviewboard should not alter the diff file http://code.google.com/p/reviewboard/issues/detail?id=929 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 929 in reviewboard: reviewboard should not alter the diff file
Updates: Status: Fixed Comment #19 on issue 929 by chip...@gmail.com: reviewboard should not alter the diff file http://code.google.com/p/reviewboard/issues/detail?id=929 This should be fixed properly now, and a release is going up tonight. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 929 in reviewboard: reviewboard should not alter the diff file
Comment #20 on issue 929 by chip...@gmail.com: reviewboard should not alter the diff file http://code.google.com/p/reviewboard/issues/detail?id=929 Pushed to release-1.6.x (8281c37c4fae1f5a283c735f1c7e7cf8546767ac) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 929 in reviewboard: reviewboard should not alter the diff file
Updates: Status: New Comment #17 on issue 929 by trowb...@gmail.com: reviewboard should not alter the diff file http://code.google.com/p/reviewboard/issues/detail?id=929 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 929 in reviewboard: reviewboard should not alter the diff file
Comment #15 on issue 929 by trowb...@gmail.com: reviewboard should not alter the diff file http://code.google.com/p/reviewboard/issues/detail?id=929 Issue 2690 has been merged into this issue. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 929 in reviewboard: reviewboard should not alter the diff file
Comment #16 on issue 929 by srivatsa...@gmail.com: reviewboard should not alter the diff file http://code.google.com/p/reviewboard/issues/detail?id=929 It is not clear whether this issue has been closed or not. Comment #11 gives me the impression this has been fixed? Could you please let us know the version of RB that has the fix. We're desperately trying to get this to work at reviews.apache.org. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 929 in reviewboard: reviewboard should not alter the diff file
Comment #12 on issue 929 by d...@vidsolbach.de: reviewboard should not alter the diff file http://code.google.com/p/reviewboard/issues/detail?id=929 Hi Chris, can you elaborate on how you changed diff handling for git? We have a user of reviewboard.kde.org who saw that all information above line 10 was stripped. I guess he was expecting to be able to see this information (e.g. commit message) even after he uploaded the patch to review board. Any news on this issue? David Attachments: 0001-When-editing-the-Tracks-of-Multiple-Files-show-the-D.patch 2.7 KB -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 929 in reviewboard: reviewboard should not alter the diff file
Comment #13 on issue 929 by d...@vidsolbach.de: reviewboard should not alter the diff file http://code.google.com/p/reviewboard/issues/detail?id=929 Ups sorry, attached the stripped down version. Here is the original patch with the additional info at the top. Attachments: 0001-When-editing-the-Tracks-of-Multiple-Files-show-the-D (1).patch 3.2 KB -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 929 in reviewboard: reviewboard should not alter the diff file
Comment #10 on issue 929 by sed...@gmail.com: reviewboard should not alter the diff file http://code.google.com/p/reviewboard/issues/detail?id=929 All git diff format support tickets were closed as duplicate of this ticket. I don't know why but the need for git diff format support has more ramifications than just sharing diffs: - It can describe move/rename operations which saves the reviewer's time to understand the three pages of removed line block and three pages of added line block were actually a single rename. - Mercurial Queues REQUIRE git-diff format to work correctly. It's recommended to be set it in the .hgrc. That prevents developer from being able to generate unified diff format and requires editing .hgrc file over and over for each specific goal. - When binary files are present, MQ switches to git format which cannot be turned off in newer Mercurial versions (namely 2.2.1). -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 929 in reviewboard: reviewboard should not alter the diff file
Updates: Status: NeedInfo Comment #11 on issue 929 by chip...@gmail.com: reviewboard should not alter the diff file http://code.google.com/p/reviewboard/issues/detail?id=929 Hi sedatk, The reason they were closed is that they're all symptoms of Review Board inadvertently stripping data from the diff when storing in the database. That's a key problem that must be fixed (and I believe we've done that for Git at least, but maybe not in a released version -- I forget when that landed). Can you describe for me how fixing that isn't sufficient for the cases you described? -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 929 in reviewboard: reviewboard should not alter the diff file
Comment #8 on issue 929 by tif...@gmail.com: reviewboard should not alter the diff file http://code.google.com/p/reviewboard/issues/detail?id=929 This really seems like a big issue. It causes git diff files containing diffs concerning binary or utf16 files to become corrupted. This makes reviewboard an unreliable diff sharing location. Is there anyone working on this issue? -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 929 in reviewboard: reviewboard should not alter the diff file
Comment #7 on issue 929 by trowb...@gmail.com: reviewboard should not alter the diff file http://code.google.com/p/reviewboard/issues/detail?id=929 Issue 2420 has been merged into this issue. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 929 in reviewboard: reviewboard should not alter the diff file
Comment #6 on issue 929 by trowb...@gmail.com: reviewboard should not alter the diff file http://code.google.com/p/reviewboard/issues/detail?id=929 Issue 2172 has been merged into this issue. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 929 in reviewboard: reviewboard should not alter the diff file
Comment #4 on issue 929 by chipx86: reviewboard should not alter the diff file http://code.google.com/p/reviewboard/issues/detail?id=929 It does do this. It just breaks it up per-file (which is needed). The problem is that the parser doesn't know about some of the extra metadata. So really, the parser just needs to be fixed to not lose this. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 929 in reviewboard: reviewboard should not alter the diff file
Comment #5 on issue 929 by d...@n-cube.org: reviewboard should not alter the diff file http://code.google.com/p/reviewboard/issues/detail?id=929 I wonder if this wouldn't still be a good idea. I was trying to review http://reviews.reviewboard.org/r/1737/ the other day because I thought it might address this problem, at least for git. However, besides missing the mail headers from format-patch, it was also missing the new file mode lines, so even once I had an appropriate base to apply on, I had to manually edit the diff just to get it to apply. I suspect there's always going to be the risk of losing portions of a diff if you break up and process it and then try to recreate it. Saving a pristine 'patch' alongside the reviewboard internal diff segments might actually be a more robust approach. Whatever we do, we really need to do something. I was hoping Eduardo's patch would do this, but it definitely had some bugs in it and I'm a bit confused over the 'bundle' concept he introduced since a format-patch output is only a single patch... -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
