Re: Review Request 53959: NPE when authenticating via a Centrify LDAP proxy

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53959/#review156553
---




ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProvider.java
 (line 82)


Why is this logged as warn and not debug ?


- Sebastian Toader


On Nov. 21, 2016, 7:43 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53959/
> ---
> 
> (Updated Nov. 21, 2016, 7:43 p.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Oliver Szabo, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18938
> https://issues.apache.org/jira/browse/AMBARI-18938
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When authenticating using LDAP where the LDAP server is a Centrify LDAP 
> proxy, a `NullPointerException` is being thrown due to unexpected missing 
> LDAP user object attributes. 
> 
> ```
> 10 Nov 2016 08:23:38,789 ERROR [ambari-client-thread-25] 
> AmbariLdapBindAuthenticator:95 - Caught exception
> java.lang.NullPointerException
>   at 
> org.apache.ambari.server.security.authorization.AmbariLdapBindAuthenticator.authenticate(AmbariLdapBindAuthenticator.java:83)
>   at 
> org.springframework.security.ldap.authentication.LdapAuthenticationProvider.doAuthentication(LdapAuthenticationProvider.java:178)
>   at 
> org.springframework.security.ldap.authentication.AbstractLdapAuthenticationProvider.authenticate(AbstractLdapAuthenticationProvider.java:61)
>   at 
> org.apache.ambari.server.security.authorization.AmbariLdapAuthenticationProvider.authenticate(AmbariLdapAuthenticationProvider.java:73)
>   at 
> org.springframework.security.authentication.ProviderManager.authenticate(ProviderManager.java:156)
>   at 
> org.springframework.security.web.authentication.www.BasicAuthenticationFilter.doFilter(BasicAuthenticationFilter.java:168)
>   at 
> org.apache.ambari.server.security.authentication.AmbariAuthenticationFilter.doFilter(AmbariAuthenticationFilter.java:88)
>   at 
> org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:342)
>   at 
> org.apache.ambari.server.security.authorization.AmbariUserAuthorizationFilter.doFilter(AmbariUserAuthorizationFilter.java:91)
>   at 
> org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:342)
>   at 
> org.springframework.security.web.context.SecurityContextPersistenceFilter.doFilter(SecurityContextPersistenceFilter.java:87)
>   at 
> org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:342)
>   at 
> org.springframework.security.web.FilterChainProxy.doFilterInternal(FilterChainProxy.java:192)
>   at 
> org.springframework.security.web.FilterChainProxy.doFilter(FilterChainProxy.java:160)
>   at 
> org.springframework.web.filter.DelegatingFilterProxy.invokeDelegate(DelegatingFilterProxy.java:237)
>   at 
> org.springframework.web.filter.DelegatingFilterProxy.doFilter(DelegatingFilterProxy.java:167)
>   at 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1478)
>   at 
> org.apache.ambari.server.api.MethodOverrideFilter.doFilter(MethodOverrideFilter.java:72)
>   at 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1478)
>   at 
> org.apache.ambari.server.api.AmbariPersistFilter.doFilter(AmbariPersistFilter.java:47)
>   at 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1478)
>   at 
> org.apache.ambari.server.security.AbstractSecurityHeaderFilter.doFilter(AbstractSecurityHeaderFilter.java:109)
>   at 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1478)
>   at 
> org.eclipse.jetty.servlets.UserAgentFilter.doFilter(UserAgentFilter.java:82)
>   at org.eclipse.jetty.servlets.GzipFilter.doFilter(GzipFilter.java:294)
>   at 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1478)
>   at 
> org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:499)
>   at 
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:137)
>   at 
> org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:557)
>   at 
> org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:231)
>   at 
> org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1086)
>   at 
> org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:427)
>   at 
> 

Re: Review Request 53959: NPE when authenticating via a Centrify LDAP proxy

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53959/#review156554
---


Ship it!




Ship It!

- Sebastian Toader


On Nov. 21, 2016, 7:43 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53959/
> ---
> 
> (Updated Nov. 21, 2016, 7:43 p.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Oliver Szabo, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18938
> https://issues.apache.org/jira/browse/AMBARI-18938
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When authenticating using LDAP where the LDAP server is a Centrify LDAP 
> proxy, a `NullPointerException` is being thrown due to unexpected missing 
> LDAP user object attributes. 
> 
> ```
> 10 Nov 2016 08:23:38,789 ERROR [ambari-client-thread-25] 
> AmbariLdapBindAuthenticator:95 - Caught exception
> java.lang.NullPointerException
>   at 
> org.apache.ambari.server.security.authorization.AmbariLdapBindAuthenticator.authenticate(AmbariLdapBindAuthenticator.java:83)
>   at 
> org.springframework.security.ldap.authentication.LdapAuthenticationProvider.doAuthentication(LdapAuthenticationProvider.java:178)
>   at 
> org.springframework.security.ldap.authentication.AbstractLdapAuthenticationProvider.authenticate(AbstractLdapAuthenticationProvider.java:61)
>   at 
> org.apache.ambari.server.security.authorization.AmbariLdapAuthenticationProvider.authenticate(AmbariLdapAuthenticationProvider.java:73)
>   at 
> org.springframework.security.authentication.ProviderManager.authenticate(ProviderManager.java:156)
>   at 
> org.springframework.security.web.authentication.www.BasicAuthenticationFilter.doFilter(BasicAuthenticationFilter.java:168)
>   at 
> org.apache.ambari.server.security.authentication.AmbariAuthenticationFilter.doFilter(AmbariAuthenticationFilter.java:88)
>   at 
> org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:342)
>   at 
> org.apache.ambari.server.security.authorization.AmbariUserAuthorizationFilter.doFilter(AmbariUserAuthorizationFilter.java:91)
>   at 
> org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:342)
>   at 
> org.springframework.security.web.context.SecurityContextPersistenceFilter.doFilter(SecurityContextPersistenceFilter.java:87)
>   at 
> org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:342)
>   at 
> org.springframework.security.web.FilterChainProxy.doFilterInternal(FilterChainProxy.java:192)
>   at 
> org.springframework.security.web.FilterChainProxy.doFilter(FilterChainProxy.java:160)
>   at 
> org.springframework.web.filter.DelegatingFilterProxy.invokeDelegate(DelegatingFilterProxy.java:237)
>   at 
> org.springframework.web.filter.DelegatingFilterProxy.doFilter(DelegatingFilterProxy.java:167)
>   at 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1478)
>   at 
> org.apache.ambari.server.api.MethodOverrideFilter.doFilter(MethodOverrideFilter.java:72)
>   at 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1478)
>   at 
> org.apache.ambari.server.api.AmbariPersistFilter.doFilter(AmbariPersistFilter.java:47)
>   at 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1478)
>   at 
> org.apache.ambari.server.security.AbstractSecurityHeaderFilter.doFilter(AbstractSecurityHeaderFilter.java:109)
>   at 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1478)
>   at 
> org.eclipse.jetty.servlets.UserAgentFilter.doFilter(UserAgentFilter.java:82)
>   at org.eclipse.jetty.servlets.GzipFilter.doFilter(GzipFilter.java:294)
>   at 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1478)
>   at 
> org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:499)
>   at 
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:137)
>   at 
> org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:557)
>   at 
> org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:231)
>   at 
> org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1086)
>   at 
> org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:427)
>   at 
> org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:193)
>   at 
> org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1020)
>   at 
> 

Re: Review Request 53972: AMBARI-18955. Cleanup 'LLAP package' folders before a given Hive Server Interactive restart.

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53972/#review156535
---


Ship it!




Ship It!

- Sumit Mohanty


On Nov. 22, 2016, 12:59 a.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53972/
> ---
> 
> (Updated Nov. 22, 2016, 12:59 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18955
> https://issues.apache.org/jira/browse/AMBARI-18955
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> ISSUE:
> 
> - With each start/restart of HSI, a new LLAP package folder gets created as 
> 'llap-slider-MM-DD-HH:MM:SS'.
> - As the process continues, the number of package explosion can end up 
> exhausting the disk space.
> 
> FIX:
> - Delete the previous run package folders before the start/restart.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
>  2c6d4b0 
> 
> Diff: https://reviews.apache.org/r/53972/diff/
> 
> 
> Testing
> ---
> 
> Manually tested on cluster.
> Python UT passes.
> 
> - Jenkins: Pending.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Re: Review Request 53972: AMBARI-18955. Cleanup 'LLAP package' folders before a given Hive Server Interactive restart.

[Swapan Shridhar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53972/
---

(Updated Nov. 22, 2016, 12:59 a.m.)


Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.


Changes
---

Using 'Script.get_tmp_dir()' instead of 'params.tmp_dir' for getting the tmp 
directory.


Bugs: AMBARI-18955
https://issues.apache.org/jira/browse/AMBARI-18955


Repository: ambari


Description
---

ISSUE:

- With each start/restart of HSI, a new LLAP package folder gets created as 
'llap-slider-MM-DD-HH:MM:SS'.
- As the process continues, the number of package explosion can end up 
exhausting the disk space.

FIX:
- Delete the previous run package folders before the start/restart.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
 2c6d4b0 

Diff: https://reviews.apache.org/r/53972/diff/


Testing
---

Manually tested on cluster.
Python UT passes.

- Jenkins: Pending.


Thanks,

Swapan Shridhar

Re: Review Request 53972: AMBARI-18955. Cleanup 'LLAP package' folders before a given Hive Server Interactive restart.

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53972/#review156534
---


Ship it!




Ship It!

- Sumit Mohanty


On Nov. 22, 2016, 12:50 a.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53972/
> ---
> 
> (Updated Nov. 22, 2016, 12:50 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18955
> https://issues.apache.org/jira/browse/AMBARI-18955
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> ISSUE:
> 
> - With each start/restart of HSI, a new LLAP package folder gets created as 
> 'llap-slider-MM-DD-HH:MM:SS'.
> - As the process continues, the number of package explosion can end up 
> exhausting the disk space.
> 
> FIX:
> - Delete the previous run package folders before the start/restart.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
>  2c6d4b0 
> 
> Diff: https://reviews.apache.org/r/53972/diff/
> 
> 
> Testing
> ---
> 
> Manually tested on cluster.
> Python UT passes.
> 
> - Jenkins: Pending.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Review Request 53972: AMBARI-18955. Cleanup 'LLAP package' folders before a given Hive Server Interactive restart.

[Swapan Shridhar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53972/
---

Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.


Bugs: AMBARI-18955
https://issues.apache.org/jira/browse/AMBARI-18955


Repository: ambari


Description
---

ISSUE:

- With each start/restart of HSI, a new LLAP package folder gets created as 
'llap-slider-MM-DD-HH:MM:SS'.
- As the process continues, the number of package explosion can end up 
exhausting the disk space.

FIX:
- Delete the previous run package folders before the start/restart.


Diffs
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
 2c6d4b0 

Diff: https://reviews.apache.org/r/53972/diff/


Testing
---

Manually tested on cluster.
Python UT passes.

- Jenkins: Pending.


Thanks,

Swapan Shridhar

Re: Review Request 53969: When HS2Interactive is enabled, any hive config change results in a CS queue refresh

[Vivek Ratnavel Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53969/
---

(Updated Nov. 21, 2016, 11:13 p.m.)


Review request for Ambari, Jaimin Jetly, Richard Zang, Xi Wang, and Yusaku Sako.


Bugs: AMBARI-18941
https://issues.apache.org/jira/browse/AMBARI-18941


Repository: ambari


Description
---

Ambari keeps refreshing CS queues each time any config is changed in Hive - 
including Hive1 configs. The refresh should happen when the user actually 
changes the capacity scheduler slider.


Diffs
-

  ambari-web/app/controllers/main/service.js d6fbfbb 
  ambari-web/app/messages.js 40bad3e 
  ambari-web/app/mixins/main/service/configs/component_actions_by_configs.js 
9271675 
  ambari-web/app/models/configs/theme/config_action.js 70c1e99 
  ambari-web/app/utils/ajax/ajax.js 0a6719b 
  ambari-web/app/utils/batch_scheduled_requests.js c9828a4 
  ambari-web/test/controllers/main/service_test.js 440c26e 
  ambari-web/test/utils/batch_scheduled_requests_test.js 20b190b 

Diff: https://reviews.apache.org/r/53969/diff/


Testing (updated)
---

Verified Manually. Ambari-web unit tests pass.

25343 tests complete (19 seconds)
57 tests pending


Thanks,

Vivek Ratnavel Subramanian

Review Request 53969: When HS2Interactive is enabled, any hive config change results in a CS queue refresh

[Vivek Ratnavel Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53969/
---

Review request for Ambari, Jaimin Jetly, Richard Zang, Xi Wang, and Yusaku Sako.


Bugs: AMBARI-18941
https://issues.apache.org/jira/browse/AMBARI-18941


Repository: ambari


Description
---

Ambari keeps refreshing CS queues each time any config is changed in Hive - 
including Hive1 configs. The refresh should happen when the user actually 
changes the capacity scheduler slider.


Diffs
-

  ambari-web/app/controllers/main/service.js d6fbfbb 
  ambari-web/app/messages.js 40bad3e 
  ambari-web/app/mixins/main/service/configs/component_actions_by_configs.js 
9271675 
  ambari-web/app/models/configs/theme/config_action.js 70c1e99 
  ambari-web/app/utils/ajax/ajax.js 0a6719b 
  ambari-web/app/utils/batch_scheduled_requests.js c9828a4 
  ambari-web/test/controllers/main/service_test.js 440c26e 
  ambari-web/test/utils/batch_scheduled_requests_test.js 20b190b 

Diff: https://reviews.apache.org/r/53969/diff/


Testing
---

Verified Manually. Amabri-web unit tests pass.

25343 tests complete (19 seconds)
57 tests pending


Thanks,

Vivek Ratnavel Subramanian

Re: Review Request 53922: AMBARI-18942 - Auto-start services: Avoid full page reload after "Save" / "Discard"

[Yusaku Sako]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53922/#review156508
---


Ship it!




Ship It!

- Yusaku Sako


On Nov. 19, 2016, 3:10 a.m., Richard Zang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53922/
> ---
> 
> (Updated Nov. 19, 2016, 3:10 a.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-18942
> https://issues.apache.org/jira/browse/AMBARI-18942
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Avoid reload after save / discard
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/admin/service_auto_start.js b425c78 
>   ambari-web/app/templates/main/admin/service_auto_start.hbs 9dc4dfb 
>   ambari-web/app/views/main/admin/service_auto_start.js dcbbfc9 
>   ambari-web/app/views/main/admin/service_auto_start/component_auto_start.js 
> a25d835 
> 
> Diff: https://reviews.apache.org/r/53922/diff/
> 
> 
> Testing
> ---
> 
> Manually tested on live cluster.
> All unit tests passed.
>   25461 tests complete (22 seconds)
>   57 tests pending
> 
> 
> Thanks,
> 
> Richard Zang
> 
>

Re: Review Request 53801: AMBARI-18901. Use 'Number of LLAP Nodes' selected as the driver for LLAP config calculations.

[Swapan Shridhar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53801/
---

(Updated Nov. 21, 2016, 8:12 p.m.)


Review request for Ambari, Alejandro Fernandez, Madhuvanthi Radhakrishnan, 
Sumit Mohanty, and Siddharth Seth.


Changes
---

Updated branch to be commited into.


Bugs: AMBARI-18901
https://issues.apache.org/jira/browse/AMBARI-18901


Repository: ambari


Description
---

AMBARI-18901. Use 'Number of LLAP Nodes' selected as the driver for LLAP config 
calculations.

Below is the calculation logic used:


**
**


---
For use with default setup - Ambari managed queue

Parameteres
numRequestedLlapNodes   UserInput
tezAmContainerSize  Computed
memoryPerThread Computed// Set as parameter in 
HiveConf. user can override in Advanced
numConcurrentQueriesComputed// user can override in Advanced
maxConcurrentQueriesComputed// Max value for Slider
numLlapNodesComputed// Can be lower for 
small clusters. user can override in Advanced
sliderAmContainerSize   Computed// user can override in Advanced
numExecutorsPerNode Computed// user can override in Advanced  | 
TODO: This and memPerThread are about the same when taking daemonSize, and 
cache into considertaion
cacheMemoryPerNode  Computed// user can override in 
Advanced
amFraction  1   // Set 
to 1 for Ambari controlled queued. | TODO Factor into concurrency for user 
provided queues
llapQueueFraction   Computed// Computed by Ambari. 
(Avoid changing if the current value is > computed value, and the user 
specified the current value?)


numClusterNodes ClusterParameter
nmMemoryPerNode ClusterParameter
nmCpusPerNode   ClusterParameter
minContainerSizeClusterParameter


CONSTANT DEFAULT_EXECUTOR_TO_AM_RATIO = 20;
CONSTANT MIN_EXECUTOR_TO_AM_RATIO = 10;
CONSTANT MAX_CONCURRENT_QUERIES = 32;

nmMemoryPerNodeNormalized = normalizeDown(nmMemoryPerNode, minContainerSize);

totalClusterCapacity = numClusterNodes * nmMemoryPerNodeNormalized;
totalllapMemory = numRequestedLlapNodes * nmMemoryPerNodeNormalized;
amCapacityAvailable = totalLlapMemory; // For the LLAP queue - the AM fraction 
is set to 1

sliderAmSize -> Current calculations remain unchanged. (<=, < fixes)

llapMemoryTezAMsAndDaemons = totalllapMemory - sliderAmSize;
FAIL("Not enough capacity available on the cluster to run LLAP") if 
(llapMemoryTezAMsAndDaemons < 2 * minContainerSize);

tezAmContainerSize = (totalClusterCapacity, minContainerSize) {
desiredSize = { // This part is unchanged from current calculations.
if (totalClusterCapacity <= 4096) {
return 256;
} else if (totalClusterCapacity <= 73728) {
return 512;
} else {
return 1536;
}
}
return normalizeUp(desiredSize, minContainerSize);
}

memoryPerThread = (nmMemoryPerNodeNormalized, nmCpusPerNode) { // TODO: Not 
linear. e.g. 1024 to 1025 goes from 2 executors to 1.
if (userSpecifiedValue) {
return userSpecifiedValue;
} else if (nmMemoryPerNodeNormalized <= 1024) {
return Math.min(512, nmMemoryPerNodeNormalized)
} else if (nmMemoryPerNodeNormalized <= 4096 ) {
return 1024;
} else if (nmMemoryPerNodeNormalized <= 10240) {
return 2048;
} else if (nmMemoryPerNodeNormalized <= 24576) {
return 3072;
} else {
return 4096;
}
}

numConcurrentQueries, maxConcurrentQueries = (nmMemoryPerNodeNormalized, 
nmCpusPerNode, memoryPerThread, numRequestedLlapNodes, 
llapMemoryTezAMsAndDaemons, tezAmContainerSize, amCapacityAvailable) {
maxExecutorsPerNode = getMaxExecutorsPerNode(nmMemoryPerNodeNormalized, 
nmCpusPerNode, memoryPerThread);
FAIL if maxExecutorsPerNode < 1;


// Default 1 AM for every 20 executor threads.
// The second part of the min calculates based on mem required for 
DEFAULT_EXECUTOR_TO_AM_RATIO executors + 1 AM, making use of total memory. 
However, it's possible
// that total memory will not be used - and the numExecutors is instead 
limited by #CPUs. Use maxPerNode to factor this in.
 

Re: Review Request 53958: AMBARI-18934 - Management packs should be able to link grafana dashboards and service metrics for custom services

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53958/#review156502
---


Ship it!




Ship It!

- Di Li


On Nov. 21, 2016, 6:53 p.m., Tim Thorpe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53958/
> ---
> 
> (Updated Nov. 21, 2016, 6:53 p.m.)
> 
> 
> Review request for Ambari, Di Li and Jayush Luniya.
> 
> 
> Bugs: AMBARI-18934
> https://issues.apache.org/jira/browse/AMBARI-18934
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> With the addition of AMBARI-18846 which allows custom services to supply 
> their own dashboards and service metrics.
> 
> With this change, if a service has a dashboards directory within its service 
> definition, the grafana-dashboards subdirectory would be linked to 
> resources/dashboards/grafana-dashboards/MYSERVICE.
> 
> The dashboards/service-metrics/MYSERVICE.txt would be linked to 
> resources/dashboards/service-metrics/MYSERVICE.txt.
> 
> 
> Diffs
> -
> 
>   ambari-server/pom.xml 36c57de 
>   ambari-server/src/main/python/ambari_server/serverConfiguration.py 3086003 
>   ambari-server/src/main/python/ambari_server/setupMpacks.py 773d946 
>   ambari-server/src/test/python/TestMpacks.py 7fb21ae 
>   
> ambari-server/src/test/python/mpacks/mystack-ambari-mpack-1.0.0.1/stacks/MYSTACK/3.0/services/SERVICEC/dashboards/grafana-dashboards/grafana-hdfs-users.json
>  PRE-CREATION 
>   
> ambari-server/src/test/python/mpacks/mystack-ambari-mpack-1.0.0.1/stacks/MYSTACK/3.0/services/SERVICEC/dashboards/service-metrics/STORM.txt
>  PRE-CREATION 
>   ambari-server/src/test/python/uninstall/common-services/SERVICEA 
> PRE-CREATION 
>   ambari-server/src/test/python/uninstall/common-services/SERVICEB 
> PRE-CREATION 
>   ambari-server/src/test/python/uninstall/dashboards/SERVICEA PRE-CREATION 
>   ambari-server/src/test/python/uninstall/dashboards/SERVICEB PRE-CREATION 
>   ambari-server/src/test/python/uninstall/dashboards/files/README.txt 
> PRE-CREATION 
>   ambari-server/src/test/python/uninstall/dashboards/files/STORM.txt 
> PRE-CREATION 
>   ambari-server/src/test/python/uninstall/dashboards/files/metainfo.xml 
> PRE-CREATION 
>   ambari-server/src/test/python/uninstall/extensions/SERVICEA PRE-CREATION 
>   ambari-server/src/test/python/uninstall/extensions/SERVICEB PRE-CREATION 
>   ambari-server/src/test/python/uninstall/stacks/2.0/SERVICEA PRE-CREATION 
>   ambari-server/src/test/python/uninstall/stacks/2.0/SERVICEB PRE-CREATION 
>   ambari-server/src/test/python/uninstall/stacks/2.0/files/README.txt 
> PRE-CREATION 
>   ambari-server/src/test/python/uninstall/stacks/2.0/files/metainfo1.xml 
> PRE-CREATION 
>   ambari-server/src/test/python/uninstall/stacks/2.0/files/metainfo2.xml 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53958/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Tim Thorpe
> 
>

Re: Review Request 53959: NPE when authenticating via a Centrify LDAP proxy

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53959/#review156495
---


Ship it!




Ship It!

- Oliver Szabo


On Nov. 21, 2016, 6:43 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53959/
> ---
> 
> (Updated Nov. 21, 2016, 6:43 p.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Oliver Szabo, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18938
> https://issues.apache.org/jira/browse/AMBARI-18938
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When authenticating using LDAP where the LDAP server is a Centrify LDAP 
> proxy, a `NullPointerException` is being thrown due to unexpected missing 
> LDAP user object attributes. 
> 
> ```
> 10 Nov 2016 08:23:38,789 ERROR [ambari-client-thread-25] 
> AmbariLdapBindAuthenticator:95 - Caught exception
> java.lang.NullPointerException
>   at 
> org.apache.ambari.server.security.authorization.AmbariLdapBindAuthenticator.authenticate(AmbariLdapBindAuthenticator.java:83)
>   at 
> org.springframework.security.ldap.authentication.LdapAuthenticationProvider.doAuthentication(LdapAuthenticationProvider.java:178)
>   at 
> org.springframework.security.ldap.authentication.AbstractLdapAuthenticationProvider.authenticate(AbstractLdapAuthenticationProvider.java:61)
>   at 
> org.apache.ambari.server.security.authorization.AmbariLdapAuthenticationProvider.authenticate(AmbariLdapAuthenticationProvider.java:73)
>   at 
> org.springframework.security.authentication.ProviderManager.authenticate(ProviderManager.java:156)
>   at 
> org.springframework.security.web.authentication.www.BasicAuthenticationFilter.doFilter(BasicAuthenticationFilter.java:168)
>   at 
> org.apache.ambari.server.security.authentication.AmbariAuthenticationFilter.doFilter(AmbariAuthenticationFilter.java:88)
>   at 
> org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:342)
>   at 
> org.apache.ambari.server.security.authorization.AmbariUserAuthorizationFilter.doFilter(AmbariUserAuthorizationFilter.java:91)
>   at 
> org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:342)
>   at 
> org.springframework.security.web.context.SecurityContextPersistenceFilter.doFilter(SecurityContextPersistenceFilter.java:87)
>   at 
> org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:342)
>   at 
> org.springframework.security.web.FilterChainProxy.doFilterInternal(FilterChainProxy.java:192)
>   at 
> org.springframework.security.web.FilterChainProxy.doFilter(FilterChainProxy.java:160)
>   at 
> org.springframework.web.filter.DelegatingFilterProxy.invokeDelegate(DelegatingFilterProxy.java:237)
>   at 
> org.springframework.web.filter.DelegatingFilterProxy.doFilter(DelegatingFilterProxy.java:167)
>   at 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1478)
>   at 
> org.apache.ambari.server.api.MethodOverrideFilter.doFilter(MethodOverrideFilter.java:72)
>   at 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1478)
>   at 
> org.apache.ambari.server.api.AmbariPersistFilter.doFilter(AmbariPersistFilter.java:47)
>   at 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1478)
>   at 
> org.apache.ambari.server.security.AbstractSecurityHeaderFilter.doFilter(AbstractSecurityHeaderFilter.java:109)
>   at 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1478)
>   at 
> org.eclipse.jetty.servlets.UserAgentFilter.doFilter(UserAgentFilter.java:82)
>   at org.eclipse.jetty.servlets.GzipFilter.doFilter(GzipFilter.java:294)
>   at 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1478)
>   at 
> org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:499)
>   at 
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:137)
>   at 
> org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:557)
>   at 
> org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:231)
>   at 
> org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1086)
>   at 
> org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:427)
>   at 
> org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:193)
>   at 
> org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1020)
>   at 
> 

Re: Review Request 53904: Implement Create Alerts: step 1 select alert type

[Vivek Ratnavel Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53904/#review156492
---


Ship it!




Ship It!

- Vivek Ratnavel Subramanian


On Nov. 18, 2016, 10:51 p.m., Xi Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53904/
> ---
> 
> (Updated Nov. 18, 2016, 10:51 p.m.)
> 
> 
> Review request for Ambari, Richard Zang, Vivek Ratnavel Subramanian, and 
> Yusaku Sako.
> 
> 
> Bugs: AMBARI-18912
> https://issues.apache.org/jira/browse/AMBARI-18912
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This is a FE task to implement the "Create Alerts Wizard " based on the 
> design attached.
> In this task, should implement the step 1 in the design. All available alert 
> types should be displayed as options with icon, type and description. Make 
> sure that on clicking a type use would jump to next step.
> 
> 
> Diffs
> -
> 
>   
> ambari-web/app/controllers/main/alerts/add_alert_definition/step1_controller.js
>  2d4f338 
>   ambari-web/app/messages.js 7ba19db 
>   ambari-web/app/models/alerts/alert_definition.js a3c8850 
>   ambari-web/app/styles/alerts.less 4569e25 
>   ambari-web/app/templates/main/alerts/add_alert_definition/step1.hbs ee61648 
>   ambari-web/app/views/main/alerts/add_alert_definition/step1_view.js d55d20f 
> 
> Diff: https://reviews.apache.org/r/53904/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Xi Wang
> 
>

Re: Review Request 53629: AMBARI-18836 Remove group readable from hdfs headless keytab

[Robert Levas]

> On Nov. 11, 2016, 5:28 a.m., Robert Levas wrote:
> > Ship It!
> 
> Shi Wang wrote:
> Hi Robert, could you help commit it if there is no other concern?

Committed...
```
commit 38076327525986b780942f33eff01d2de4a70ce2
Author: Shi Wang 
Date:   Mon Nov 21 14:03:32 2016 -0500
```


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53629/#review155702
---


On Nov. 10, 2016, 4:28 p.m., Shi Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53629/
> ---
> 
> (Updated Nov. 10, 2016, 4:28 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Laszlo Puskas, and Robert Levas.
> 
> 
> Bugs: AMBARI-18836
> https://issues.apache.org/jira/browse/AMBARI-18836
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The Smoke and “Headless” Service users are used by Ambari to perform service 
> “smoke” checks and run alert health checks. 
> The permission for hdfs.headless.keytab is 440. But it will cause security 
> concern to allow other service user in hadoop group to kinit hdfs headless 
> principal using hdfs.headless.keytab. In this way, other service user could 
> "pretend" to be hdfs user and be granted hdfs user's authorities.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/kerberos.json 
> e8c96cb 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py
>  a7feb60 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/HDFS/kerberos.json 
> 974a69c 
> 
> Diff: https://reviews.apache.org/r/53629/diff/
> 
> 
> Testing
> ---
> 
> Hi Robert, 
> What will be your opinion on this?
> Is it necessary to set 440 permission to hdfs headless keytab? The kinit hdfs 
> headless principal operation for webhcat seems useless, I kdestroy the hdfs 
> ticket for hcat user and hive service check/start/stop all works fine. Is 
> there any other tests I should try? Thanks.
> 
> 
> Thanks,
> 
> Shi Wang
> 
>

Re: Review Request 52155: ambari server upgrade ambari to 2.1.1 duplicate key error

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52155/#review156487
---


Ship it!




Ship It!

- Alejandro Fernandez


On Nov. 21, 2016, 7:52 a.m., wang yaoxin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52155/
> ---
> 
> (Updated Nov. 21, 2016, 7:52 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Oliver Szabo, Robert Nettleton, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18441
> https://issues.apache.org/jira/browse/AMBARI-18441
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> My first upgrade test failed due to my environment issue. Since in real 
> production environment this failure would  occur again.
> 
> ambari upgrade to 2.1.1 and later version, if the first time failed , excute 
> ambari-server upgrade again will error duplicate key value violates unique 
> constraint "pk_hostcomponentstate".
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog211.java
>  db13612 
> 
> Diff: https://reviews.apache.org/r/52155/diff/
> 
> 
> Testing
> ---
> 
> the unit test is UpgradeCatalog211Test.java: Process finished with exit code 
> 0.
> done !
> 
> 
> File Attachments
> 
> 
> AMBARI-18441-02.patch
>   
> https://reviews.apache.org/media/uploaded/files/2016/11/16/4c6f3d15-96cc-4c22-babe-b45b103a8c30__AMBARI-18441-02.patch
> 
> 
> Thanks,
> 
> wang yaoxin
> 
>

Re: Review Request 53958: AMBARI-18934 - Management packs should be able to link grafana dashboards and service metrics for custom services

[Tim Thorpe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53958/
---

(Updated Nov. 21, 2016, 6:53 p.m.)


Review request for Ambari, Di Li and Jayush Luniya.


Bugs: AMBARI-18934
https://issues.apache.org/jira/browse/AMBARI-18934


Repository: ambari


Description
---

With the addition of AMBARI-18846 which allows custom services to supply their 
own dashboards and service metrics.

With this change, if a service has a dashboards directory within its service 
definition, the grafana-dashboards subdirectory would be linked to 
resources/dashboards/grafana-dashboards/MYSERVICE.

The dashboards/service-metrics/MYSERVICE.txt would be linked to 
resources/dashboards/service-metrics/MYSERVICE.txt.


Diffs (updated)
-

  ambari-server/pom.xml 36c57de 
  ambari-server/src/main/python/ambari_server/serverConfiguration.py 3086003 
  ambari-server/src/main/python/ambari_server/setupMpacks.py 773d946 
  ambari-server/src/test/python/TestMpacks.py 7fb21ae 
  
ambari-server/src/test/python/mpacks/mystack-ambari-mpack-1.0.0.1/stacks/MYSTACK/3.0/services/SERVICEC/dashboards/grafana-dashboards/grafana-hdfs-users.json
 PRE-CREATION 
  
ambari-server/src/test/python/mpacks/mystack-ambari-mpack-1.0.0.1/stacks/MYSTACK/3.0/services/SERVICEC/dashboards/service-metrics/STORM.txt
 PRE-CREATION 
  ambari-server/src/test/python/uninstall/common-services/SERVICEA PRE-CREATION 
  ambari-server/src/test/python/uninstall/common-services/SERVICEB PRE-CREATION 
  ambari-server/src/test/python/uninstall/dashboards/SERVICEA PRE-CREATION 
  ambari-server/src/test/python/uninstall/dashboards/SERVICEB PRE-CREATION 
  ambari-server/src/test/python/uninstall/dashboards/files/README.txt 
PRE-CREATION 
  ambari-server/src/test/python/uninstall/dashboards/files/STORM.txt 
PRE-CREATION 
  ambari-server/src/test/python/uninstall/dashboards/files/metainfo.xml 
PRE-CREATION 
  ambari-server/src/test/python/uninstall/extensions/SERVICEA PRE-CREATION 
  ambari-server/src/test/python/uninstall/extensions/SERVICEB PRE-CREATION 
  ambari-server/src/test/python/uninstall/stacks/2.0/SERVICEA PRE-CREATION 
  ambari-server/src/test/python/uninstall/stacks/2.0/SERVICEB PRE-CREATION 
  ambari-server/src/test/python/uninstall/stacks/2.0/files/README.txt 
PRE-CREATION 
  ambari-server/src/test/python/uninstall/stacks/2.0/files/metainfo1.xml 
PRE-CREATION 
  ambari-server/src/test/python/uninstall/stacks/2.0/files/metainfo2.xml 
PRE-CREATION 

Diff: https://reviews.apache.org/r/53958/diff/


Testing
---

mvn clean test


Thanks,

Tim Thorpe

Re: Review Request 53958: AMBARI-18934 - Management packs should be able to link grafana dashboards and service metrics for custom services

[Tim Thorpe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53958/
---

(Updated Nov. 21, 2016, 6:51 p.m.)


Review request for Ambari, Di Li and Jayush Luniya.


Changes
---

Fix serverConfiguration.py get_dashboard_location handle the case where a 
KeyError is thrown (if ambari.properties doesn't contain the dashboard path)


Bugs: AMBARI-18934
https://issues.apache.org/jira/browse/AMBARI-18934


Repository: ambari


Description
---

With the addition of AMBARI-18846 which allows custom services to supply their 
own dashboards and service metrics.

With this change, if a service has a dashboards directory within its service 
definition, the grafana-dashboards subdirectory would be linked to 
resources/dashboards/grafana-dashboards/MYSERVICE.

The dashboards/service-metrics/MYSERVICE.txt would be linked to 
resources/dashboards/service-metrics/MYSERVICE.txt.


Diffs (updated)
-

  ambari-server/pom.xml 36c57de 
  ambari-server/src/main/python/ambari_server/serverConfiguration.py 3086003 
  ambari-server/src/main/python/ambari_server/setupMpacks.py 773d946 
  ambari-server/src/test/python/TestMpacks.py 7fb21ae 
  
ambari-server/src/test/python/mpacks/mystack-ambari-mpack-1.0.0.1/stacks/MYSTACK/3.0/services/SERVICEC/dashboards/grafana-dashboards/grafana-hdfs-users.json
 PRE-CREATION 
  
ambari-server/src/test/python/mpacks/mystack-ambari-mpack-1.0.0.1/stacks/MYSTACK/3.0/services/SERVICEC/dashboards/service-metrics/STORM.txt
 PRE-CREATION 
  ambari-server/src/test/python/uninstall/common-services/SERVICEA PRE-CREATION 
  ambari-server/src/test/python/uninstall/common-services/SERVICEB PRE-CREATION 
  ambari-server/src/test/python/uninstall/dashboards/SERVICEA PRE-CREATION 
  ambari-server/src/test/python/uninstall/dashboards/SERVICEB PRE-CREATION 
  ambari-server/src/test/python/uninstall/dashboards/files/README.txt 
PRE-CREATION 
  ambari-server/src/test/python/uninstall/dashboards/files/STORM.txt 
PRE-CREATION 
  ambari-server/src/test/python/uninstall/dashboards/files/metainfo.xml 
PRE-CREATION 
  ambari-server/src/test/python/uninstall/extensions/SERVICEA PRE-CREATION 
  ambari-server/src/test/python/uninstall/extensions/SERVICEB PRE-CREATION 
  ambari-server/src/test/python/uninstall/stacks/2.0/SERVICEA PRE-CREATION 
  ambari-server/src/test/python/uninstall/stacks/2.0/SERVICEB PRE-CREATION 
  ambari-server/src/test/python/uninstall/stacks/2.0/files/README.txt 
PRE-CREATION 
  ambari-server/src/test/python/uninstall/stacks/2.0/files/metainfo1.xml 
PRE-CREATION 
  ambari-server/src/test/python/uninstall/stacks/2.0/files/metainfo2.xml 
PRE-CREATION 

Diff: https://reviews.apache.org/r/53958/diff/


Testing
---

mvn clean test


Thanks,

Tim Thorpe

Re: Review Request 53801: AMBARI-18901. Use 'Number of LLAP Nodes' selected as the driver for LLAP config calculations.

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53801/#review156486
---


Ship it!




Ship It!

- Alejandro Fernandez


On Nov. 19, 2016, 12:49 a.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53801/
> ---
> 
> (Updated Nov. 19, 2016, 12:49 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Madhuvanthi Radhakrishnan, 
> Sumit Mohanty, and Siddharth Seth.
> 
> 
> Bugs: AMBARI-18901
> https://issues.apache.org/jira/browse/AMBARI-18901
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-18901. Use 'Number of LLAP Nodes' selected as the driver for LLAP 
> config calculations.
> 
> Below is the calculation logic used:
> 
> 
> **
> **
> 
> 
> ---
> For use with default setup - Ambari managed queue
> 
> Parameteres
> numRequestedLlapNodes UserInput
> tezAmContainerSizeComputed
> memoryPerThread   Computed// Set as parameter in 
> HiveConf. user can override in Advanced
> numConcurrentQueries  Computed// user can override in Advanced
> maxConcurrentQueries  Computed// Max value for Slider
> numLlapNodes  Computed// Can be lower for 
> small clusters. user can override in Advanced
> sliderAmContainerSize Computed// user can override in Advanced
> numExecutorsPerNode   Computed// user can override in Advanced  | 
> TODO: This and memPerThread are about the same when taking daemonSize, and 
> cache into considertaion
> cacheMemoryPerNodeComputed// user can override in 
> Advanced
> amFraction1   // Set 
> to 1 for Ambari controlled queued. | TODO Factor into concurrency for user 
> provided queues
> llapQueueFraction Computed// Computed by Ambari. 
> (Avoid changing if the current value is > computed value, and the user 
> specified the current value?)
> 
> 
> numClusterNodes   ClusterParameter
> nmMemoryPerNode   ClusterParameter
> nmCpusPerNode ClusterParameter
> minContainerSize  ClusterParameter
> 
> 
> CONSTANT DEFAULT_EXECUTOR_TO_AM_RATIO = 20;
> CONSTANT MIN_EXECUTOR_TO_AM_RATIO = 10;
> CONSTANT MAX_CONCURRENT_QUERIES = 32;
> 
> nmMemoryPerNodeNormalized = normalizeDown(nmMemoryPerNode, minContainerSize);
> 
> totalClusterCapacity = numClusterNodes * nmMemoryPerNodeNormalized;
> totalllapMemory = numRequestedLlapNodes * nmMemoryPerNodeNormalized;
> amCapacityAvailable = totalLlapMemory; // For the LLAP queue - the AM 
> fraction is set to 1
> 
> sliderAmSize -> Current calculations remain unchanged. (<=, < fixes)
> 
> llapMemoryTezAMsAndDaemons = totalllapMemory - sliderAmSize;
> FAIL("Not enough capacity available on the cluster to run LLAP") if 
> (llapMemoryTezAMsAndDaemons < 2 * minContainerSize);
> 
> tezAmContainerSize = (totalClusterCapacity, minContainerSize) {
>   desiredSize = { // This part is unchanged from current calculations.
>   if (totalClusterCapacity <= 4096) {
>   return 256;
>   } else if (totalClusterCapacity <= 73728) {
>   return 512;
>   } else {
>   return 1536;
>   }
>   }
>   return normalizeUp(desiredSize, minContainerSize);
> }
> 
> memoryPerThread = (nmMemoryPerNodeNormalized, nmCpusPerNode) { // TODO: Not 
> linear. e.g. 1024 to 1025 goes from 2 executors to 1.
>   if (userSpecifiedValue) {
>   return userSpecifiedValue;
>   } else if (nmMemoryPerNodeNormalized <= 1024) {
>   return Math.min(512, nmMemoryPerNodeNormalized)
>   } else if (nmMemoryPerNodeNormalized <= 4096 ) {
>   return 1024;
>   } else if (nmMemoryPerNodeNormalized <= 10240) {
>   return 2048;
>   } else if (nmMemoryPerNodeNormalized <= 24576) {
>   return 3072;
>   } else {
>   return 4096;
>   }
> }
> 
> numConcurrentQueries, maxConcurrentQueries = (nmMemoryPerNodeNormalized, 
> nmCpusPerNode, memoryPerThread, numRequestedLlapNodes, 
> llapMemoryTezAMsAndDaemons, tezAmContainerSize, amCapacityAvailable) {
>   maxExecutorsPerNode = getMaxExecutorsPerNode(nmMemoryPerNodeNormalized, 

Re: Review Request 53722: AMBARI-18425:Support PAM as an authentication option for Ranger in Ambari

[Shi Wang]

> On Nov. 21, 2016, 5:17 a.m., Mugdha Varadkar wrote:
> > Ship It!
> 
> Mugdha Varadkar wrote:
> Hi Shi Wang, Please attach latest updated patch on Apache Jira 
> AMBARI-18425 also.
> 
> Shi Wang wrote:
> Thanks Mugdha, I just updated it to the latest version.

Hi Mugdha, Could you help commit it if there is no other concerns? Thanks.


- Shi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53722/#review156438
---


On Nov. 17, 2016, 9:05 p.m., Shi Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53722/
> ---
> 
> (Updated Nov. 17, 2016, 9:05 p.m.)
> 
> 
> Review request for Ambari and Robert Levas.
> 
> 
> Bugs: trunk
> https://issues.apache.org/jira/browse/trunk
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ranger-842 has added PAM support for ranger, we need to add this part to 
> ambari, to do automatic setup for ranger to use PAM authentication.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  6462495 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/templates/ranger_admin_pam.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/templates/ranger_remote_pam.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.5.0/configuration/ranger-admin-site.xml
>  c0e537b 
>   ambari-web/app/data/HDP2.3/site_properties.js 9ae68df 
> 
> Diff: https://reviews.apache.org/r/53722/diff/
> 
> 
> Testing
> ---
> 
> In this patch, the default value for ranger-admin module is
> authsufficientpam_unix.so
> authsufficientpam_sss.so
> account sufficientpam_unix.so
> account sufficientpam_sss.so
> 1. Create a Unix User shiwang, and sync unix user to Ranger, restart 
> ranger-admin as root and login to ranger using shiwang, it will success.
> 2. Change ranger-admin pam file to 
> authsufficientpam_deny.so
> account sufficientpam_deny.so
> and login using shiwang it will fall.
> 3. Change ranger-admin pam file to 
> authsufficientpam_ldap.so
> account sufficientpam_ldap.so
> and use a ldap user that already sync in ranger(it will show user not synced 
> error if not synced in ranger) login will success.
> 4. Configure sssd with ldap and using the synced user from ldap login will 
> success.
> 
> 
> Thanks,
> 
> Shi Wang
> 
>

Re: Review Request 53629: AMBARI-18836 Remove group readable from hdfs headless keytab

[Shi Wang]

> On Nov. 11, 2016, 10:28 a.m., Robert Levas wrote:
> > Ship It!

Hi Robert, could you help commit it if there is no other concern?


- Shi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53629/#review155702
---


On Nov. 10, 2016, 9:28 p.m., Shi Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53629/
> ---
> 
> (Updated Nov. 10, 2016, 9:28 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Laszlo Puskas, and Robert Levas.
> 
> 
> Bugs: AMBARI-18836
> https://issues.apache.org/jira/browse/AMBARI-18836
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The Smoke and “Headless” Service users are used by Ambari to perform service 
> “smoke” checks and run alert health checks. 
> The permission for hdfs.headless.keytab is 440. But it will cause security 
> concern to allow other service user in hadoop group to kinit hdfs headless 
> principal using hdfs.headless.keytab. In this way, other service user could 
> "pretend" to be hdfs user and be granted hdfs user's authorities.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/kerberos.json 
> e8c96cb 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py
>  a7feb60 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/HDFS/kerberos.json 
> 974a69c 
> 
> Diff: https://reviews.apache.org/r/53629/diff/
> 
> 
> Testing
> ---
> 
> Hi Robert, 
> What will be your opinion on this?
> Is it necessary to set 440 permission to hdfs headless keytab? The kinit hdfs 
> headless principal operation for webhcat seems useless, I kdestroy the hdfs 
> ticket for hcat user and hive service check/start/stop all works fine. Is 
> there any other tests I should try? Thanks.
> 
> 
> Thanks,
> 
> Shi Wang
> 
>

Review Request 53959: NPE when authenticating via a Centrify LDAP proxy

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53959/
---

Review request for Ambari, Laszlo Puskas, Oliver Szabo, and Sebastian Toader.


Bugs: AMBARI-18938
https://issues.apache.org/jira/browse/AMBARI-18938


Repository: ambari


Description
---

When authenticating using LDAP where the LDAP server is a Centrify LDAP proxy, 
a `NullPointerException` is being thrown due to unexpected missing LDAP user 
object attributes. 

```
10 Nov 2016 08:23:38,789 ERROR [ambari-client-thread-25] 
AmbariLdapBindAuthenticator:95 - Caught exception
java.lang.NullPointerException
at 
org.apache.ambari.server.security.authorization.AmbariLdapBindAuthenticator.authenticate(AmbariLdapBindAuthenticator.java:83)
at 
org.springframework.security.ldap.authentication.LdapAuthenticationProvider.doAuthentication(LdapAuthenticationProvider.java:178)
at 
org.springframework.security.ldap.authentication.AbstractLdapAuthenticationProvider.authenticate(AbstractLdapAuthenticationProvider.java:61)
at 
org.apache.ambari.server.security.authorization.AmbariLdapAuthenticationProvider.authenticate(AmbariLdapAuthenticationProvider.java:73)
at 
org.springframework.security.authentication.ProviderManager.authenticate(ProviderManager.java:156)
at 
org.springframework.security.web.authentication.www.BasicAuthenticationFilter.doFilter(BasicAuthenticationFilter.java:168)
at 
org.apache.ambari.server.security.authentication.AmbariAuthenticationFilter.doFilter(AmbariAuthenticationFilter.java:88)
at 
org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:342)
at 
org.apache.ambari.server.security.authorization.AmbariUserAuthorizationFilter.doFilter(AmbariUserAuthorizationFilter.java:91)
at 
org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:342)
at 
org.springframework.security.web.context.SecurityContextPersistenceFilter.doFilter(SecurityContextPersistenceFilter.java:87)
at 
org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:342)
at 
org.springframework.security.web.FilterChainProxy.doFilterInternal(FilterChainProxy.java:192)
at 
org.springframework.security.web.FilterChainProxy.doFilter(FilterChainProxy.java:160)
at 
org.springframework.web.filter.DelegatingFilterProxy.invokeDelegate(DelegatingFilterProxy.java:237)
at 
org.springframework.web.filter.DelegatingFilterProxy.doFilter(DelegatingFilterProxy.java:167)
at 
org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1478)
at 
org.apache.ambari.server.api.MethodOverrideFilter.doFilter(MethodOverrideFilter.java:72)
at 
org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1478)
at 
org.apache.ambari.server.api.AmbariPersistFilter.doFilter(AmbariPersistFilter.java:47)
at 
org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1478)
at 
org.apache.ambari.server.security.AbstractSecurityHeaderFilter.doFilter(AbstractSecurityHeaderFilter.java:109)
at 
org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1478)
at 
org.eclipse.jetty.servlets.UserAgentFilter.doFilter(UserAgentFilter.java:82)
at org.eclipse.jetty.servlets.GzipFilter.doFilter(GzipFilter.java:294)
at 
org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1478)
at 
org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:499)
at 
org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:137)
at 
org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:557)
at 
org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:231)
at 
org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1086)
at 
org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:427)
at 
org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:193)
at 
org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1020)
at 
org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:135)
at 
org.apache.ambari.server.controller.AmbariHandlerList.processHandlers(AmbariHandlerList.java:212)
at 
org.apache.ambari.server.controller.AmbariHandlerList.processHandlers(AmbariHandlerList.java:201)
at 
org.apache.ambari.server.controller.AmbariHandlerList.handle(AmbariHandlerList.java:139)
at 
org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:116)
at 

Review Request 53958: AMBARI-18934 - Management packs should be able to link grafana dashboards and service metrics for custom services

[Tim Thorpe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53958/
---

Review request for Ambari, Di Li and Jayush Luniya.


Bugs: AMBARI-18934
https://issues.apache.org/jira/browse/AMBARI-18934


Repository: ambari


Description
---

With the addition of AMBARI-18846 which allows custom services to supply their 
own dashboards and service metrics.

With this change, if a service has a dashboards directory within its service 
definition, the grafana-dashboards subdirectory would be linked to 
resources/dashboards/grafana-dashboards/MYSERVICE.

The dashboards/service-metrics/MYSERVICE.txt would be linked to 
resources/dashboards/service-metrics/MYSERVICE.txt.


Diffs
-

  ambari-server/pom.xml 36c57de 
  ambari-server/src/main/python/ambari_server/serverConfiguration.py 3086003 
  ambari-server/src/main/python/ambari_server/setupMpacks.py 773d946 
  ambari-server/src/test/python/TestMpacks.py 7fb21ae 
  
ambari-server/src/test/python/mpacks/mystack-ambari-mpack-1.0.0.1/stacks/MYSTACK/3.0/services/SERVICEC/dashboards/grafana-dashboards/grafana-hdfs-users.json
 PRE-CREATION 
  
ambari-server/src/test/python/mpacks/mystack-ambari-mpack-1.0.0.1/stacks/MYSTACK/3.0/services/SERVICEC/dashboards/service-metrics/STORM.txt
 PRE-CREATION 
  ambari-server/src/test/python/uninstall/common-services/SERVICEA PRE-CREATION 
  ambari-server/src/test/python/uninstall/common-services/SERVICEB PRE-CREATION 
  ambari-server/src/test/python/uninstall/dashboards/SERVICEA PRE-CREATION 
  ambari-server/src/test/python/uninstall/dashboards/SERVICEB PRE-CREATION 
  ambari-server/src/test/python/uninstall/dashboards/files/README.txt 
PRE-CREATION 
  ambari-server/src/test/python/uninstall/dashboards/files/STORM.txt 
PRE-CREATION 
  ambari-server/src/test/python/uninstall/dashboards/files/metainfo.xml 
PRE-CREATION 
  ambari-server/src/test/python/uninstall/extensions/SERVICEA PRE-CREATION 
  ambari-server/src/test/python/uninstall/extensions/SERVICEB PRE-CREATION 
  ambari-server/src/test/python/uninstall/stacks/2.0/SERVICEA PRE-CREATION 
  ambari-server/src/test/python/uninstall/stacks/2.0/SERVICEB PRE-CREATION 
  ambari-server/src/test/python/uninstall/stacks/2.0/files/README.txt 
PRE-CREATION 
  ambari-server/src/test/python/uninstall/stacks/2.0/files/metainfo1.xml 
PRE-CREATION 
  ambari-server/src/test/python/uninstall/stacks/2.0/files/metainfo2.xml 
PRE-CREATION 

Diff: https://reviews.apache.org/r/53958/diff/


Testing
---

mvn clean test


Thanks,

Tim Thorpe

Re: Review Request 53722: AMBARI-18425:Support PAM as an authentication option for Ranger in Ambari

[Shi Wang]

> On Nov. 21, 2016, 5:17 a.m., Mugdha Varadkar wrote:
> > Ship It!
> 
> Mugdha Varadkar wrote:
> Hi Shi Wang, Please attach latest updated patch on Apache Jira 
> AMBARI-18425 also.

Thanks Mugdha, I just updated it to the latest version.


- Shi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53722/#review156438
---


On Nov. 17, 2016, 9:05 p.m., Shi Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53722/
> ---
> 
> (Updated Nov. 17, 2016, 9:05 p.m.)
> 
> 
> Review request for Ambari and Robert Levas.
> 
> 
> Bugs: trunk
> https://issues.apache.org/jira/browse/trunk
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ranger-842 has added PAM support for ranger, we need to add this part to 
> ambari, to do automatic setup for ranger to use PAM authentication.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  6462495 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/templates/ranger_admin_pam.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/templates/ranger_remote_pam.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.5.0/configuration/ranger-admin-site.xml
>  c0e537b 
>   ambari-web/app/data/HDP2.3/site_properties.js 9ae68df 
> 
> Diff: https://reviews.apache.org/r/53722/diff/
> 
> 
> Testing
> ---
> 
> In this patch, the default value for ranger-admin module is
> authsufficientpam_unix.so
> authsufficientpam_sss.so
> account sufficientpam_unix.so
> account sufficientpam_sss.so
> 1. Create a Unix User shiwang, and sync unix user to Ranger, restart 
> ranger-admin as root and login to ranger using shiwang, it will success.
> 2. Change ranger-admin pam file to 
> authsufficientpam_deny.so
> account sufficientpam_deny.so
> and login using shiwang it will fall.
> 3. Change ranger-admin pam file to 
> authsufficientpam_ldap.so
> account sufficientpam_ldap.so
> and use a ldap user that already sync in ranger(it will show user not synced 
> error if not synced in ranger) login will success.
> 4. Configure sssd with ldap and using the synced user from ldap login will 
> success.
> 
> 
> Thanks,
> 
> Shi Wang
> 
>

Re: Review Request 53901: Allow generic Service Upgrade Packs for all targets

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53901/
---

(Updated Nov. 21, 2016, 1:11 p.m.)


Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Jayush 
Luniya.


Bugs: AMBARI-18937
https://issues.apache.org/jira/browse/AMBARI-18937


Repository: ambari


Description
---

Currently, a custom service can participate in RU/EU only if it adds an Upgrade 
Pack for every target of a stack.  If there is a case of the Upgrade Pack 
ALWAYS being the same no matter the version, then only one file should be 
sufficient.

Also added that a group name must be unique in a XSD since the logic already 
dictated that it must be true (and associated fixes).


Diffs
-

  ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 
37f4167 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java
 edf5c89 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
95c5f06 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 
a01996a 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
f0c6131 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 
f520faf 
  ambari-server/src/main/resources/upgrade-pack.xsd 2871f05 
  
ambari-server/src/test/java/org/apache/ambari/server/state/stack/UpgradePackTest.java
 dde7ffa 
  
ambari-server/src/test/resources/stacks/HDP/2.2.0/services/GANGLIA/upgrades/HDP/rolling-upgrade.xml
 PRE-CREATION 

Diff: https://reviews.apache.org/r/53901/diff/


Testing (updated)
---

Manual.  Automated:

Tests run: 4772, Failures: 0, Errors: 0, Skipped: 37

[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 37:53.587s
[INFO] Finished at: Mon Nov 21 11:31:06 EST 2016
[INFO] Final Memory: 37M/669M
[INFO] 


Thanks,

Nate Cole

Re: Review Request 53951: Refactor hive() function in HIVE service

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53951/#review156465
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Nov. 21, 2016, 6 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53951/
> ---
> 
> (Updated Nov. 21, 2016, 6 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-18950
> https://issues.apache.org/jira/browse/AMBARI-18950
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
>  ec64200 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py 
> c79e773 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 35d2144 
>   ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py 
> b398ac8 
> 
> Diff: https://reviews.apache.org/r/53951/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Review Request 53951: Refactor hive() function in HIVE service

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53951/
---

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-18950
https://issues.apache.org/jira/browse/AMBARI-18950


Repository: ambari


Description
---


Diffs
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
 ec64200 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py 
c79e773 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 35d2144 
  ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py b398ac8 

Diff: https://reviews.apache.org/r/53951/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 53947: hive metrics : support hs2 with remote metastore

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53947/#review156457
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Nov. 21, 2016, 4:31 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53947/
> ---
> 
> (Updated Nov. 21, 2016, 4:31 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-18948
> https://issues.apache.org/jira/browse/AMBARI-18948
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently, the only "enable" config param we set on hive to enable metrics
> logging from hive is "hive.metastore.metrics.enabled". This parameter winds up
> enabling the metrics system for both the metastore as well as HS2 (since HS2
> typically runs with embedded metastore, and the metrics we log for HS2 include
> these api calls up front and center in Grafana).
> 
> However, this is an issue in that we're not enabling/tracking metrics for HS2
> instances that run with a remote metastore, since that is enabled by a
> different flag, called "hive.server2.metrics.enabled". This flag also needs to
> be set when metrics is enabled.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hivemetastore-site.xml
>  b73b1ae 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hiveserver2-interactive-site.xml
>  89bf43c 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hiveserver2-site.xml
>  e120ac2 
> 
> Diff: https://reviews.apache.org/r/53947/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Review Request 53947: hive metrics : support hs2 with remote metastore

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53947/
---

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-18948
https://issues.apache.org/jira/browse/AMBARI-18948


Repository: ambari


Description
---

Currently, the only "enable" config param we set on hive to enable metrics
logging from hive is "hive.metastore.metrics.enabled". This parameter winds up
enabling the metrics system for both the metastore as well as HS2 (since HS2
typically runs with embedded metastore, and the metrics we log for HS2 include
these api calls up front and center in Grafana).

However, this is an issue in that we're not enabling/tracking metrics for HS2
instances that run with a remote metastore, since that is enabled by a
different flag, called "hive.server2.metrics.enabled". This flag also needs to
be set when metrics is enabled.


Diffs
-

  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hivemetastore-site.xml
 b73b1ae 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hiveserver2-interactive-site.xml
 89bf43c 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hiveserver2-site.xml
 e120ac2 

Diff: https://reviews.apache.org/r/53947/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 53901: Allow generic Service Upgrade Packs for all targets

[Nate Cole]

> On Nov. 18, 2016, 4:56 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java,
> >  lines 912-913
> > 
> >
> > Is this really a warning? It's not a problem if CUSTOMSERVICE says it 
> > wants to be after Kafka and Kafka isn't installed.
> > 
> > Or is this a larger problem if "How does a service ensure it's always 
> > upgraded"? The service it chooses might not exist.

Thanks for the review!  Basically I wanted to call out that if one of these 
CUSTOMSERVICE defines a generic upgrade pack, at least call out that there's a 
stack upgrade pack where it can't be applied.  Existing logs don't make that 
very clear.  Sometimes it's hard to weed out the real information among the 
ocean of INFOs.


- Nate


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53901/#review156342
---


On Nov. 18, 2016, 4:12 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53901/
> ---
> 
> (Updated Nov. 18, 2016, 4:12 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Jayush 
> Luniya.
> 
> 
> Bugs: AMBARI-18937
> https://issues.apache.org/jira/browse/AMBARI-18937
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently, a custom service can participate in RU/EU only if it adds an 
> Upgrade Pack for every target of a stack.  If there is a case of the Upgrade 
> Pack ALWAYS being the same no matter the version, then only one file should 
> be sufficient.
> 
> Also added that a group name must be unique in a XSD since the logic already 
> dictated that it must be true (and associated fixes).
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 
> 37f4167 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java
>  edf5c89 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 95c5f06 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 
> a01996a 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> f0c6131 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 
> f520faf 
>   ambari-server/src/main/resources/upgrade-pack.xsd 2871f05 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/UpgradePackTest.java
>  dde7ffa 
>   
> ambari-server/src/test/resources/stacks/HDP/2.2.0/services/GANGLIA/upgrades/HDP/rolling-upgrade.xml
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53901/diff/
> 
> 
> Testing
> ---
> 
> Manual.  Automated pending.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 53945: Infinite spinner displayed instead of some Flume Agent graphs

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53945/#review156454
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Лис. 21, 2016, 1:33 після полудня, Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53945/
> ---
> 
> (Updated Лис. 21, 2016, 1:33 після полудня)
> 
> 
> Review request for Ambari, Aravind Gottipati, Sid Wagle, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-18947
> https://issues.apache.org/jira/browse/AMBARI-18947
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> ChannelSize, EventPutSuccessCount and EventTakeSuccessCount graphs aren't 
> displayed.
> At the same time, JS error is thrown after selecting a host from the table: 
> Uncaught TypeError: Cannot read property '1' of undefined at app.js:178829.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/metrics.json 
> 611a1b7 
> 
> Diff: https://reviews.apache.org/r/53945/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed.
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Review Request 53945: Infinite spinner displayed instead of some Flume Agent graphs

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53945/
---

Review request for Ambari, Aravind Gottipati, Sid Wagle, and Vitalyi Brodetskyi.


Bugs: AMBARI-18947
https://issues.apache.org/jira/browse/AMBARI-18947


Repository: ambari


Description
---

ChannelSize, EventPutSuccessCount and EventTakeSuccessCount graphs aren't 
displayed.
At the same time, JS error is thrown after selecting a host from the table: 
Uncaught TypeError: Cannot read property '1' of undefined at app.js:178829.


Diffs
-

  ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/metrics.json 
611a1b7 

Diff: https://reviews.apache.org/r/53945/diff/


Testing
---

Unit tests passed.


Thanks,

Dmytro Sen

Review Request 53944: Ambari Integration for Zeppelin and Spark 2.0

[Renjith Kamath]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53944/
---

Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav Nagar, 
Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, and Sumit Mohanty.


Bugs: AMBARI-18946
https://issues.apache.org/jira/browse/AMBARI-18946


Repository: ambari


Description
---

Initial support to Spark 1.x and 2.x config in Zeppelin


Diffs
-

  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
 33a2a14 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py
 27ed150 

Diff: https://reviews.apache.org/r/53944/diff/


Testing
---

manually tested on Centos


Thanks,

Renjith Kamath

Re: Review Request 53914: Perf: Fix bugs in deploy-gce-perf-cluster.py to generate correct config file

[Vitalyi Brodetskyi]

> On Лис. 21, 2016, 8:13 до полудня, Dmitro Lisnichenko wrote:
> > contrib/utils/perf/deploy-gce-perf-cluster.py, line 227
> > 
> >
> > why do we need this sleep?

because we are not able to ssh to cluster hosts immediately


- Vitalyi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53914/#review156445
---


On Лис. 19, 2016, 12:12 до полудня, Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53914/
> ---
> 
> (Updated Лис. 19, 2016, 12:12 до полудня)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Dmytro Sen, Sumit Mohanty, Sid 
> Wagle, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-18940
> https://issues.apache.org/jira/browse/AMBARI-18940
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The script to create VMs on GCE for the perf cluster has a bug where each VM 
> will have the exact same agent-multiplier config file with start=1 and 
> num=50, thereby preventing more than 50 agents.
> This is because a single server.sh and agent.sh file is written out, and 
> copied to all VMs.
> We need to create a custom config file for each VM instead.
> 
> 
> Diffs
> -
> 
>   contrib/utils/perf/deploy-gce-perf-cluster.py da45f8f 
> 
> Diff: https://reviews.apache.org/r/53914/diff/
> 
> 
> Testing
> ---
> 
> Verified by deploying a cluster to GCE.
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 53843: Zeppelin view doesn't work with JDK 1.8_91+

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53843/#review156451
---


Ship it!




Ship It!

- Pallav Kulshreshtha


On Nov. 17, 2016, 10:09 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53843/
> ---
> 
> (Updated Nov. 17, 2016, 10:09 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush 
> Luniya, Nitiraj Rathore, Rohit Choudhary, Renjith Kamath, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18918
> https://issues.apache.org/jira/browse/AMBARI-18918
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> At ambari main page, click on the box icon next to the Admin tab on top right 
> corner. Then click Zeppelin View. It will give the following error.
> 
> 
> {code}
> HTTP ERROR 500
> Problem accessing /views/ZEPPELIN/1.0.0/AUTO_ZEPPELIN_INSTANCE/. Reason: 
> Server Error
> Caused by:
> org.apache.jasper.JasperException: PWC6033: Unable to compile class for JSP
> PWC6199: Generated servlet error:
> The type java.io.ObjectInputStream cannot be resolved. It is indirectly 
> referenced from required .class files
> at 
> org.apache.jasper.compiler.DefaultErrorHandler.javacError(DefaultErrorHandler.java:123)
> at 
> org.apache.jasper.compiler.ErrorDispatcher.javacError(ErrorDispatcher.java:296)
> at org.apache.jasper.compiler.Compiler.generateClass(Compiler.java:376)
> at org.apache.jasper.compiler.Compiler.compile(Compiler.java:437)
> at 
> org.apache.jasper.JspCompilationContext.compile(JspCompilationContext.java:608)
> at 
> org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:360)
> at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:486)
> at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:380)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:848)
> at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:684)
> at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:501)
> at 
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:137)
> at org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:575)
> at 
> org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:231)
> at 
> org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1086)
> at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:427)
> at 
> org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:193)
> at 
> org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1020)
> at 
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:135)
> at org.eclipse.jetty.server.Dispatcher.forward(Dispatcher.java:276)
> at org.eclipse.jetty.server.Dispatcher.forward(Dispatcher.java:103)
> at 
> org.apache.ambari.view.zeppelin.ZeppelinServlet.doGet(ZeppelinServlet.java:68)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:735)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:848)
> at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:684)
> at 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1507)
> at 
> org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:330)
> at 
> org.springframework.security.web.access.intercept.FilterSecurityInterceptor.invoke(FilterSecurityInterceptor.java:118)
> at 
> org.springframework.security.web.access.intercept.FilterSecurityInterceptor.doFilter(FilterSecurityInterceptor.java:84)
> at 
> org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:342)
> at 
> org.apache.ambari.server.security.authorization.AmbariAuthorizationFilter.doFilter(AmbariAuthorizationFilter.java:286)
> at 
> org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:342)
> at 
> org.springframework.security.web.access.ExceptionTranslationFilter.doFilter(ExceptionTranslationFilter.java:113)
> at 
> org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:342)
> at 
> org.springframework.security.web.session.SessionManagementFilter.doFilter(SessionManagementFilter.java:103)
> at 
> org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:342)
> at 
> org.springframework.security.web.authentication.AnonymousAuthenticationFilter.doFilter(AnonymousAuthenticationFilter.java:113)
> at 
> org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:342)
> at 
> 

Re: Review Request 53843: Zeppelin view doesn't work with JDK 1.8_91+

[DIPAYAN BHOWMICK]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53843/#review156450
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On Nov. 17, 2016, 10:09 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53843/
> ---
> 
> (Updated Nov. 17, 2016, 10:09 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush 
> Luniya, Nitiraj Rathore, Rohit Choudhary, Renjith Kamath, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18918
> https://issues.apache.org/jira/browse/AMBARI-18918
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> At ambari main page, click on the box icon next to the Admin tab on top right 
> corner. Then click Zeppelin View. It will give the following error.
> 
> 
> {code}
> HTTP ERROR 500
> Problem accessing /views/ZEPPELIN/1.0.0/AUTO_ZEPPELIN_INSTANCE/. Reason: 
> Server Error
> Caused by:
> org.apache.jasper.JasperException: PWC6033: Unable to compile class for JSP
> PWC6199: Generated servlet error:
> The type java.io.ObjectInputStream cannot be resolved. It is indirectly 
> referenced from required .class files
> at 
> org.apache.jasper.compiler.DefaultErrorHandler.javacError(DefaultErrorHandler.java:123)
> at 
> org.apache.jasper.compiler.ErrorDispatcher.javacError(ErrorDispatcher.java:296)
> at org.apache.jasper.compiler.Compiler.generateClass(Compiler.java:376)
> at org.apache.jasper.compiler.Compiler.compile(Compiler.java:437)
> at 
> org.apache.jasper.JspCompilationContext.compile(JspCompilationContext.java:608)
> at 
> org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:360)
> at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:486)
> at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:380)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:848)
> at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:684)
> at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:501)
> at 
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:137)
> at org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:575)
> at 
> org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:231)
> at 
> org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1086)
> at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:427)
> at 
> org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:193)
> at 
> org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1020)
> at 
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:135)
> at org.eclipse.jetty.server.Dispatcher.forward(Dispatcher.java:276)
> at org.eclipse.jetty.server.Dispatcher.forward(Dispatcher.java:103)
> at 
> org.apache.ambari.view.zeppelin.ZeppelinServlet.doGet(ZeppelinServlet.java:68)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:735)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:848)
> at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:684)
> at 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1507)
> at 
> org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:330)
> at 
> org.springframework.security.web.access.intercept.FilterSecurityInterceptor.invoke(FilterSecurityInterceptor.java:118)
> at 
> org.springframework.security.web.access.intercept.FilterSecurityInterceptor.doFilter(FilterSecurityInterceptor.java:84)
> at 
> org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:342)
> at 
> org.apache.ambari.server.security.authorization.AmbariAuthorizationFilter.doFilter(AmbariAuthorizationFilter.java:286)
> at 
> org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:342)
> at 
> org.springframework.security.web.access.ExceptionTranslationFilter.doFilter(ExceptionTranslationFilter.java:113)
> at 
> org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:342)
> at 
> org.springframework.security.web.session.SessionManagementFilter.doFilter(SessionManagementFilter.java:103)
> at 
> org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:342)
> at 
> org.springframework.security.web.authentication.AnonymousAuthenticationFilter.doFilter(AnonymousAuthenticationFilter.java:113)
> at 
> org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:342)
> at 
> 

Re: Review Request 53722: AMBARI-18425:Support PAM as an authentication option for Ranger in Ambari

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53722/#review156449
---


Ship it!




Ship It!

- Robert Levas


On Nov. 17, 2016, 4:05 p.m., Shi Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53722/
> ---
> 
> (Updated Nov. 17, 2016, 4:05 p.m.)
> 
> 
> Review request for Ambari and Robert Levas.
> 
> 
> Bugs: trunk
> https://issues.apache.org/jira/browse/trunk
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ranger-842 has added PAM support for ranger, we need to add this part to 
> ambari, to do automatic setup for ranger to use PAM authentication.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  6462495 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/templates/ranger_admin_pam.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/templates/ranger_remote_pam.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.5.0/configuration/ranger-admin-site.xml
>  c0e537b 
>   ambari-web/app/data/HDP2.3/site_properties.js 9ae68df 
> 
> Diff: https://reviews.apache.org/r/53722/diff/
> 
> 
> Testing
> ---
> 
> In this patch, the default value for ranger-admin module is
> authsufficientpam_unix.so
> authsufficientpam_sss.so
> account sufficientpam_unix.so
> account sufficientpam_sss.so
> 1. Create a Unix User shiwang, and sync unix user to Ranger, restart 
> ranger-admin as root and login to ranger using shiwang, it will success.
> 2. Change ranger-admin pam file to 
> authsufficientpam_deny.so
> account sufficientpam_deny.so
> and login using shiwang it will fall.
> 3. Change ranger-admin pam file to 
> authsufficientpam_ldap.so
> account sufficientpam_ldap.so
> and use a ldap user that already sync in ranger(it will show user not synced 
> error if not synced in ranger) login will success.
> 4. Configure sssd with ldap and using the synced user from ldap login will 
> success.
> 
> 
> Thanks,
> 
> Shi Wang
> 
>

Re: Review Request 53854: Agent Auto Restart Doesn't Release Ping Port

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53854/
---

(Updated Ноя. 21, 2016, 9:27 д.п.)


Review request for Ambari, Andrew Onischuk, Jonathan Hurley, and Vitalyi 
Brodetskyi.


Bugs: AMBARI-18922
https://issues.apache.org/jira/browse/AMBARI-18922


Repository: ambari


Description
---

Ambari agent auto-restart fails


Diffs (updated)
-

  ambari-agent/src/main/python/ambari_agent/AmbariAgent.py d701e49 
  ambari-agent/src/main/python/ambari_agent/StatusCommandsExecutor.py 5d3607a 
  ambari-agent/src/test/python/ambari_agent/TestAmbariAgent.py 1be487c 

Diff: https://reviews.apache.org/r/53854/diff/


Testing
---

Unit tests passed


Thanks,

Dmytro Sen

Re: Review Request 53914: Perf: Fix bugs in deploy-gce-perf-cluster.py to generate correct config file

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53914/#review156445
---


Fix it, then Ship it!





contrib/utils/perf/deploy-gce-perf-cluster.py (line 220)


why do we need this sleep?


- Dmitro Lisnichenko


On Nov. 19, 2016, 2:12 a.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53914/
> ---
> 
> (Updated Nov. 19, 2016, 2:12 a.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Dmytro Sen, Sumit Mohanty, Sid 
> Wagle, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-18940
> https://issues.apache.org/jira/browse/AMBARI-18940
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The script to create VMs on GCE for the perf cluster has a bug where each VM 
> will have the exact same agent-multiplier config file with start=1 and 
> num=50, thereby preventing more than 50 agents.
> This is because a single server.sh and agent.sh file is written out, and 
> copied to all VMs.
> We need to create a custom config file for each VM instead.
> 
> 
> Diffs
> -
> 
>   contrib/utils/perf/deploy-gce-perf-cluster.py da45f8f 
> 
> Diff: https://reviews.apache.org/r/53914/diff/
> 
> 
> Testing
> ---
> 
> Verified by deploying a cluster to GCE.
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>