Review Request 58409: get_value_from_jmx constantly prints exception message in retry mechanism, which brings bad user experience

[Yuanbo Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58409/
---

Review request for Ambari.


Bugs: AMBARI-20754
https://issues.apache.org/jira/browse/AMBARI-20754


Repository: ambari


Description
---

get_value_from_jmx of jmx.py is used in getting NameNode HA state. As we know, 
if the cluster is large, it takes a long time for Namenode to leave safe mode 
when restarting Namenode, thus we use retry mechanism to invoke 
get_value_from_jmx in case of getting wrong state. The problem is that, 
get_value_from_jmx will print several exception message into std_error during 
retrying, it confuses users because there're error messages in std_error, while 
all the services restart successfully


Diffs
-

  ambari-common/src/main/python/resource_management/libraries/functions/jmx.py 
9a4ff5f 
  
ambari-common/src/main/python/resource_management/libraries/functions/namenode_ha_utils.py
 665a8e4 


Diff: https://reviews.apache.org/r/58409/diff/1/


Testing
---


Thanks,

Yuanbo Liu

Re: Review Request 58401: Fix misleading solr-client output messages

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58401/#review171837
---


Ship it!




Ship It!

- Attila Doroszlai


On April 12, 2017, 11:07 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58401/
> ---
> 
> (Updated April 12, 2017, 11:07 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Miklos Gergely, and Robert 
> Nettleton.
> 
> 
> Bugs: AMBARI-20751
> https://issues.apache.org/jira/browse/AMBARI-20751
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In some cases, its possible collection creation is not working (e.g.: solr 
> nodes cannot communicate with each other for some reason in ssl enabled 
> environment). Therefore its possible, that the client say that collection has 
> already created, but in fact that was not successful.
> 
> 
> Diffs
> -
> 
>   
> ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/AmbariSolrCloudClient.java
>  d5d971c 
> 
> 
> Diff: https://reviews.apache.org/r/58401/diff/1/
> 
> 
> Testing
> ---
> 
> done.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Review Request 58407: HDP 3.0 TP - temporarily install RPMs hive2 and remove Pig dependency from Hive

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58407/
---

Review request for Ambari, Sumit Mohanty and Sid Wagle.


Bugs: AMBARI-20753
https://issues.apache.org/jira/browse/AMBARI-20753


Repository: ambari


Description
---

To unblock testing, will temporarily
* rename packages for Hive from "hive" to "hive2" as it used to be in HDP 2.x 
version
* remove dependency that Hive must also install Pig until it is ready for 
packaging


Diffs
-

  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/metainfo.xml 
6d9098f 


Diff: https://reviews.apache.org/r/58407/diff/1/


Testing
---

Ran Python unit tests

--
Total run:1192
Total errors:0
Total failures:0
OK


Thanks,

Alejandro Fernandez

Re: Review Request 58405: Update the Accordion styles in horton style

[Vivek Ratnavel Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58405/#review171827
---


Ship it!




Ship It!

- Vivek Ratnavel Subramanian


On April 12, 2017, 10:19 p.m., Xi Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58405/
> ---
> 
> (Updated April 12, 2017, 10:19 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel 
> Subramanian, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-20752
> https://issues.apache.org/jira/browse/AMBARI-20752
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Need to update the Accordion styles in style guide
> 
> 
> Diffs
> -
> 
>   ambari-web/app/styles/theme/bootstrap-ambari.css b2f5ca4450 
> 
> 
> Diff: https://reviews.apache.org/r/58405/diff/1/
> 
> 
> Testing
> ---
> 
> 20675 passing (25s)
>   128 pending
> 
> 
> Thanks,
> 
> Xi Wang
> 
>

Re: Review Request 58405: Update the Accordion styles in horton style

[Jaimin Jetly]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58405/#review171825
---


Ship it!




Ship It!

- Jaimin Jetly


On April 12, 2017, 10:19 p.m., Xi Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58405/
> ---
> 
> (Updated April 12, 2017, 10:19 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel 
> Subramanian, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-20752
> https://issues.apache.org/jira/browse/AMBARI-20752
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Need to update the Accordion styles in style guide
> 
> 
> Diffs
> -
> 
>   ambari-web/app/styles/theme/bootstrap-ambari.css b2f5ca4450 
> 
> 
> Diff: https://reviews.apache.org/r/58405/diff/1/
> 
> 
> Testing
> ---
> 
> 20675 passing (25s)
>   128 pending
> 
> 
> Thanks,
> 
> Xi Wang
> 
>

Re: Review Request 58405: Update the Accordion styles in horton style

[Jaimin Jetly]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58405/#review171824
---


Ship it!




Ship It!

- Jaimin Jetly


On April 12, 2017, 10:19 p.m., Xi Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58405/
> ---
> 
> (Updated April 12, 2017, 10:19 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel 
> Subramanian, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-20752
> https://issues.apache.org/jira/browse/AMBARI-20752
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Need to update the Accordion styles in style guide
> 
> 
> Diffs
> -
> 
>   ambari-web/app/styles/theme/bootstrap-ambari.css b2f5ca4450 
> 
> 
> Diff: https://reviews.apache.org/r/58405/diff/1/
> 
> 
> Testing
> ---
> 
> 20675 passing (25s)
>   128 pending
> 
> 
> Thanks,
> 
> Xi Wang
> 
>

Review Request 58405: Update the Accordion styles in horton style

[Xi Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58405/
---

Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel 
Subramanian, and Yusaku Sako.


Bugs: AMBARI-20752
https://issues.apache.org/jira/browse/AMBARI-20752


Repository: ambari


Description
---

Need to update the Accordion styles in style guide


Diffs
-

  ambari-web/app/styles/theme/bootstrap-ambari.css b2f5ca4450 


Diff: https://reviews.apache.org/r/58405/diff/1/


Testing
---

20675 passing (25s)
  128 pending


Thanks,

Xi Wang

Re: Review Request 58389: Log Search: Add get clusters endpoint for service and audit logs

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58389/#review171809
---


Ship it!




Ship It!

- Miklos Gergely


On April 12, 2017, 3:51 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58389/
> ---
> 
> (Updated April 12, 2017, 3:51 p.m.)
> 
> 
> Review request for Ambari, Aleksandr Kovalenko, Miklos Gergely, and Robert 
> Nettleton.
> 
> 
> Bugs: AMBARI-20744
> https://issues.apache.org/jira/browse/AMBARI-20744
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add endpoint to get clusters for service and audit log collection.
> As the cluster fields can be different, therefore we need 2 calls for that
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/doc/DocConstants.java
>  984e834 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/AuditLogsManager.java
>  49465d5 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/ManagerBase.java
>  6b40cb5 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/ServiceLogsManager.java
>  9ce209b 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/rest/AuditLogsResource.java
>  2013dc7 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/rest/ServiceLogsResource.java
>  498da69 
> 
> 
> Diff: https://reviews.apache.org/r/58389/diff/1/
> 
> 
> Testing
> ---
> 
> done. manually
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 58401: Fix misleading solr-client output messages

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58401/#review171810
---


Ship it!




Ship It!

- Miklos Gergely


On April 12, 2017, 9:07 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58401/
> ---
> 
> (Updated April 12, 2017, 9:07 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Miklos Gergely, and Robert 
> Nettleton.
> 
> 
> Bugs: AMBARI-20751
> https://issues.apache.org/jira/browse/AMBARI-20751
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In some cases, its possible collection creation is not working (e.g.: solr 
> nodes cannot communicate with each other for some reason in ssl enabled 
> environment). Therefore its possible, that the client say that collection has 
> already created, but in fact that was not successful.
> 
> 
> Diffs
> -
> 
>   
> ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/AmbariSolrCloudClient.java
>  d5d971c 
> 
> 
> Diff: https://reviews.apache.org/r/58401/diff/1/
> 
> 
> Testing
> ---
> 
> done.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 58277: Skip calling stack selector, conf selector tools for Nifi, Streamline, Registry custom services in HDP cluster

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58277/#review171808
---


Ship it!




Ship It!

- Jayush Luniya


On April 12, 2017, 9:55 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58277/
> ---
> 
> (Updated April 12, 2017, 9:55 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20696
> https://issues.apache.org/jira/browse/AMBARI-20696
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The custom services do not advertise any version and hence will not 
> participate in the HDP upgrade process. So selectors need not be called.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
>  79393b985f 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
>  02ae62daf3 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
>  ff00a1f38e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  0d1ef13c21 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  d5018f55b2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  751ce085d8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
>  e42bd45cc1 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py
>  1609050409 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
>  71a02f5e5a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
>  554e089102 
> 
> 
> Diff: https://reviews.apache.org/r/58277/diff/6/
> 
> 
> Testing
> ---
> 
> Installed HDP Regular services with HDF Custom services - Nifi, Strealine, 
> Registry
> Python unit tests
> Java unit tests
> [INFO]
> [INFO] Ambari Main  SUCCESS [ 12.457 
> s]
> [INFO] Apache Ambari Project POM .. SUCCESS [  0.034 
> s]
> [INFO] Ambari Web . SUCCESS [03:22 
> min]
> [INFO] Ambari Views ... SUCCESS [  2.167 
> s]
> [INFO] Ambari Admin View .. SUCCESS [  8.811 
> s]
> [INFO] utility  SUCCESS [  1.172 
> s]
> [INFO] ambari-metrics . SUCCESS [  0.557 
> s]
> [INFO] Ambari Metrics Common .. SUCCESS [  3.959 
> s]
> [INFO] Ambari Metrics Hadoop Sink . SUCCESS [  5.448 
> s]
> [INFO] Ambari Metrics Flume Sink .. SUCCESS [  3.951 
> s]
> [INFO] Ambari Metrics Kafka Sink .. SUCCESS [  3.229 
> s]
> [INFO] Ambari Metrics Storm Sink .. SUCCESS [  1.459 
> s]
> [INFO] Ambari Metrics Storm Sink (Legacy) . SUCCESS [  1.430 
> s]
> [INFO] Ambari Metrics Collector ... SUCCESS [05:27 
> min]
> [INFO] Ambari Metrics Monitor . SUCCESS [  4.367 
> s]
> [INFO] Ambari Metrics Grafana . SUCCESS [  9.257 
> s]
> [INFO] Ambari Metrics Assembly  SUCCESS [01:21 
> min]
> [INFO] Ambari Server .. SUCCESS [29:32 
> min]
> [INFO] Ambari Functional Tests  SUCCESS [  2.179 
> s]
> [INFO] Ambari Agent ... SUCCESS [ 33.694 
> s]
> [INFO] Ambari Client .. SUCCESS [  0.031 
> s]
> [INFO] Ambari Python Client ... SUCCESS [  0.379 
> s]
> [INFO] Ambari Groovy Client ... SUCCESS [  6.721 
> s]
> [INFO] Ambari Shell ... SUCCESS [  0.020 
> s]
> [INFO] Ambari Python Shell  SUCCESS [  0.033 
> s]
> [INFO] Ambari Groovy Shell  SUCCESS [  4.296 
> s]
> [INFO] ambari-logsearch ... SUCCESS [  0.141 
> s]
> [INFO] Ambari Logsearch Appender .. SUCCESS [  0.143 
> s]
> [INFO] Ambari Logsearch Web ... SUCCESS [ 36.382 
> s]
> [INFO] Ambari Logsearch Server  SUCCESS [ 10.359 
> s]
> [INFO] Ambari Logs

Re: Review Request 58277: Skip calling stack selector, conf selector tools for Nifi, Streamline, Registry custom services in HDP cluster

[Madhuvanthi Radhakrishnan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58277/
---

(Updated April 12, 2017, 9:55 p.m.)


Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and Sumit 
Mohanty.


Bugs: AMBARI-20696
https://issues.apache.org/jira/browse/AMBARI-20696


Repository: ambari


Description
---

The custom services do not advertise any version and hence will not participate 
in the HDP upgrade process. So selectors need not be called.


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
 79393b985f 
  
ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
 02ae62daf3 
  
ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
 ff00a1f38e 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
 0d1ef13c21 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 d5018f55b2 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 751ce085d8 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
 e42bd45cc1 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py
 1609050409 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
 71a02f5e5a 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
 554e089102 


Diff: https://reviews.apache.org/r/58277/diff/6/


Testing (updated)
---

Installed HDP Regular services with HDF Custom services - Nifi, Strealine, 
Registry
Python unit tests
Java unit tests
[INFO]
[INFO] Ambari Main  SUCCESS [ 12.457 s]
[INFO] Apache Ambari Project POM .. SUCCESS [  0.034 s]
[INFO] Ambari Web . SUCCESS [03:22 min]
[INFO] Ambari Views ... SUCCESS [  2.167 s]
[INFO] Ambari Admin View .. SUCCESS [  8.811 s]
[INFO] utility  SUCCESS [  1.172 s]
[INFO] ambari-metrics . SUCCESS [  0.557 s]
[INFO] Ambari Metrics Common .. SUCCESS [  3.959 s]
[INFO] Ambari Metrics Hadoop Sink . SUCCESS [  5.448 s]
[INFO] Ambari Metrics Flume Sink .. SUCCESS [  3.951 s]
[INFO] Ambari Metrics Kafka Sink .. SUCCESS [  3.229 s]
[INFO] Ambari Metrics Storm Sink .. SUCCESS [  1.459 s]
[INFO] Ambari Metrics Storm Sink (Legacy) . SUCCESS [  1.430 s]
[INFO] Ambari Metrics Collector ... SUCCESS [05:27 min]
[INFO] Ambari Metrics Monitor . SUCCESS [  4.367 s]
[INFO] Ambari Metrics Grafana . SUCCESS [  9.257 s]
[INFO] Ambari Metrics Assembly  SUCCESS [01:21 min]
[INFO] Ambari Server .. SUCCESS [29:32 min]
[INFO] Ambari Functional Tests  SUCCESS [  2.179 s]
[INFO] Ambari Agent ... SUCCESS [ 33.694 s]
[INFO] Ambari Client .. SUCCESS [  0.031 s]
[INFO] Ambari Python Client ... SUCCESS [  0.379 s]
[INFO] Ambari Groovy Client ... SUCCESS [  6.721 s]
[INFO] Ambari Shell ... SUCCESS [  0.020 s]
[INFO] Ambari Python Shell  SUCCESS [  0.033 s]
[INFO] Ambari Groovy Shell  SUCCESS [  4.296 s]
[INFO] ambari-logsearch ... SUCCESS [  0.141 s]
[INFO] Ambari Logsearch Appender .. SUCCESS [  0.143 s]
[INFO] Ambari Logsearch Web ... SUCCESS [ 36.382 s]
[INFO] Ambari Logsearch Server  SUCCESS [ 10.359 s]
[INFO] Ambari Logsearch Log Feeder  SUCCESS [ 11.536 s]
[INFO] Ambari Logsearch Assembly .. SUCCESS [  0.133 s]
[INFO] Ambari Logsearch Integration Test .. SUCCESS [  0.360 s]
[INFO] ambari-infra ... SUCCESS [  0.022 s]
[INFO] Ambari Infra Solr Client ... SUCCESS [  1.993 s]
[INFO] Ambari Infra Solr Plugin ... SUCCESS [  1.242 s]
[INFO] Ambari Infra Solr Assembly . SUCCESS [  0.038 s]
[INFO] 
[I

Re: Review Request 58277: Skip calling stack selector, conf selector tools for Nifi, Streamline, Registry custom services in HDP cluster

[Madhuvanthi Radhakrishnan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58277/
---

(Updated April 12, 2017, 9:55 p.m.)


Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and Sumit 
Mohanty.


Changes
---

Review comments - add check for service_name. remove hive_env.xml fixes


Bugs: AMBARI-20696
https://issues.apache.org/jira/browse/AMBARI-20696


Repository: ambari


Description
---

The custom services do not advertise any version and hence will not participate 
in the HDP upgrade process. So selectors need not be called.


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
 79393b985f 
  
ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
 02ae62daf3 
  
ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
 ff00a1f38e 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
 0d1ef13c21 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 d5018f55b2 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 751ce085d8 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
 e42bd45cc1 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py
 1609050409 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
 71a02f5e5a 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
 554e089102 


Diff: https://reviews.apache.org/r/58277/diff/6/

Changes: https://reviews.apache.org/r/58277/diff/5-6/


Testing
---

Installed HDP Regular services with HDF Custom services - Nifi, Strealine, 
Registry
Python unit tests
Java unit tests


Thanks,

Madhuvanthi Radhakrishnan

Re: Review Request 58277: Skip calling stack selector, conf selector tools for Nifi, Streamline, Registry custom services in HDP cluster

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58277/#review171800
---




ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
Line 120 (original), 120 (patched)


This change has been reverted  and hence we no longer need to include it in 
the patch



ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml
Line 89 (original), 89 (patched)


This change has been reverted  and hence we no longer need to include it in 
the patch


- Jayush Luniya


On April 12, 2017, 6:04 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58277/
> ---
> 
> (Updated April 12, 2017, 6:04 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20696
> https://issues.apache.org/jira/browse/AMBARI-20696
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The custom services do not advertise any version and hence will not 
> participate in the HDP upgrade process. So selectors need not be called.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
>  79393b985f 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
>  02ae62daf3 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
>  ff00a1f38e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  0d1ef13c21 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  d5018f55b2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  751ce085d8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
>  e42bd45cc1 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
>  ad668a2051 
>   
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml
>  872120cc55 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py
>  1609050409 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
>  71a02f5e5a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
>  554e089102 
> 
> 
> Diff: https://reviews.apache.org/r/58277/diff/5/
> 
> 
> Testing
> ---
> 
> Installed HDP Regular services with HDF Custom services - Nifi, Strealine, 
> Registry
> Python unit tests
> Java unit tests
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 58401: Fix misleading solr-client output messages

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58401/#review171796
---


Ship it!




Ship It!

- Robert Nettleton


On April 12, 2017, 9:07 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58401/
> ---
> 
> (Updated April 12, 2017, 9:07 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Miklos Gergely, and Robert 
> Nettleton.
> 
> 
> Bugs: AMBARI-20751
> https://issues.apache.org/jira/browse/AMBARI-20751
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In some cases, its possible collection creation is not working (e.g.: solr 
> nodes cannot communicate with each other for some reason in ssl enabled 
> environment). Therefore its possible, that the client say that collection has 
> already created, but in fact that was not successful.
> 
> 
> Diffs
> -
> 
>   
> ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/AmbariSolrCloudClient.java
>  d5d971c 
> 
> 
> Diff: https://reviews.apache.org/r/58401/diff/1/
> 
> 
> Testing
> ---
> 
> done.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Review Request 58401: Fix misleading solr-client output messages

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58401/
---

Review request for Ambari, Attila Doroszlai, Miklos Gergely, and Robert 
Nettleton.


Bugs: AMBARI-20751
https://issues.apache.org/jira/browse/AMBARI-20751


Repository: ambari


Description
---

In some cases, its possible collection creation is not working (e.g.: solr 
nodes cannot communicate with each other for some reason in ssl enabled 
environment). Therefore its possible, that the client say that collection has 
already created, but in fact that was not successful.


Diffs
-

  
ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/AmbariSolrCloudClient.java
 d5d971c 


Diff: https://reviews.apache.org/r/58401/diff/1/


Testing
---

done.


Thanks,

Oliver Szabo

Re: Review Request 58277: Skip calling stack selector, conf selector tools for Nifi, Streamline, Registry custom services in HDP cluster

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58277/#review171794
---




ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
Lines 52 (patched)


We should not look at versionAdvertised flag if service name or role is 
null. For instance for custom actions like install_packages the command is not 
specific to a service component and hence we should not skip calling stack/conf 
selector.


- Jayush Luniya


On April 12, 2017, 6:04 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58277/
> ---
> 
> (Updated April 12, 2017, 6:04 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20696
> https://issues.apache.org/jira/browse/AMBARI-20696
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The custom services do not advertise any version and hence will not 
> participate in the HDP upgrade process. So selectors need not be called.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
>  79393b985f 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
>  02ae62daf3 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
>  ff00a1f38e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  0d1ef13c21 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  d5018f55b2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  751ce085d8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
>  e42bd45cc1 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
>  ad668a2051 
>   
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml
>  872120cc55 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py
>  1609050409 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
>  71a02f5e5a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
>  554e089102 
> 
> 
> Diff: https://reviews.apache.org/r/58277/diff/5/
> 
> 
> Testing
> ---
> 
> Installed HDP Regular services with HDF Custom services - Nifi, Strealine, 
> Registry
> Python unit tests
> Java unit tests
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 58277: Skip calling stack selector, conf selector tools for Nifi, Streamline, Registry custom services in HDP cluster

[Jayush Luniya]

> On April 12, 2017, 7:20 p.m., Jonathan Hurley wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
> > Lines 82 (patched)
> > 
> >
> > I don't see this being used anywhere.
> 
> Madhuvanthi Radhakrishnan wrote:
> It is used in 
> ~/hdf-ambari-mpack/src/main/resources/common-services/NIFI/1.0.0/package/scripts/params.py
> stack_version_buildnum = 
> get_component_version_with_stack_selector("/usr/bin/hdf-select", "nifi")
> 
> Jonathan Hurley wrote:
> If that's the only spot using it, then it should be moved into that 
> mpack, no? Otherwsie you risk it being removed in the future and breaking the 
> mpack.

More than one services can use this function (NIFI, STREAMLINE, REGISTRY) and 
dont have a way to have a shared library within mpack. We can just document the 
function that this function can be called by custom services and hence not to 
remove.


- Jayush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58277/#review171778
---


On April 12, 2017, 6:04 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58277/
> ---
> 
> (Updated April 12, 2017, 6:04 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20696
> https://issues.apache.org/jira/browse/AMBARI-20696
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The custom services do not advertise any version and hence will not 
> participate in the HDP upgrade process. So selectors need not be called.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
>  79393b985f 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
>  02ae62daf3 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
>  ff00a1f38e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  0d1ef13c21 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  d5018f55b2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  751ce085d8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
>  e42bd45cc1 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
>  ad668a2051 
>   
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml
>  872120cc55 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py
>  1609050409 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
>  71a02f5e5a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
>  554e089102 
> 
> 
> Diff: https://reviews.apache.org/r/58277/diff/5/
> 
> 
> Testing
> ---
> 
> Installed HDP Regular services with HDF Custom services - Nifi, Strealine, 
> Registry
> Python unit tests
> Java unit tests
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 58367: Allow Potentially Long Running Restart Commands To Have Their Own Timeout

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58367/
---

(Updated April 12, 2017, 4:42 p.m.)


Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.


Changes
---

Updated diff for comments


Bugs: AMBARI-20736
https://issues.apache.org/jira/browse/AMBARI-20736


Repository: ambari


Description
---

Add the ability to set overrides for certain tasks in Upgrade Packs.  This was 
done via ambari.properties for now.  Essentially, tasks may be defined with a 
timeout-config option that will perform a lookup and apply it to the 
ActionExecutionContext instance.  So far only one task was identified that 
requires this, and that's NN restarts.  As we discover other time consuming 
tasks we can add them, or alternatively show customers how to do this for their 
own upgrades.

I did uncover an issue where we associate multiple Task objects to a 
TaskWrapper, which is wrong (should be one-to-one).  In addition, we aren't 
setup currently to allow multiple tasks to run concurrently on one host.  We DO 
allow multiple tasks across hosts to work in parallel, which is fine.  These 
issues will be addressed in a future patch.


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/decorator.py
 55cf335aa0 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 d5018f55b2 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
 709ca9360d 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java
 cd17a7080a 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapper.java
 aac89358da 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Task.java
 5c43c2befd 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/TaskWrapper.java
 11e27cfb9f 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/TaskWrapperBuilder.java
 a75fe00bd4 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py
 04897927f6 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
 f0566d78e4 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 
1340b22711 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
40afc4f356 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
e0882d8350 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 
0f4efdcd0d 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 
d5e9a5b095 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
350395c714 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 
9ac3d52fe8 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
04a06e8447 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
879fe0f9bd 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 
fd72e4d69e 
  ambari-server/src/main/resources/upgrade-pack.xsd 1f11aa1bd4 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java
 999b7a7612 
  ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test.xml 
8d506bfd4e 


Diff: https://reviews.apache.org/r/58367/diff/2/

Changes: https://reviews.apache.org/r/58367/diff/1-2/


Testing
---

Tests run: 4980, Failures: 0, Errors: 0, Skipped: 39

[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 24:22 min
[INFO] Finished at: 2017-04-11T15:05:10-04:00
[INFO] Final Memory: 47M/216M
[INFO] 


--
Total run:1192
Total errors:0
Total failures:0
OK


Thanks,

Nate Cole

Re: Review Request 58371: AMBARI-20737 Able to hide the Use Public Repository option on Register Version page on Ambari Admin View

[Tim Thorpe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58371/#review171786
---


Ship it!




Ship It!

- Tim Thorpe


On April 11, 2017, 9:26 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58371/
> ---
> 
> (Updated April 11, 2017, 9:26 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Sangeeta Ravindran, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-20737
> https://issues.apache.org/jira/browse/AMBARI-20737
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The Register Version UI page on Ambari Admin View shows two options related 
> to adding repo URLs: Use Public Repository and Use Local Repository.
> The Use Public Repository is disabled when no stack repos are marked as 
> "stack_default=false" ( meaning it;s from the stack/repo URL defined in the 
> "latest" section in the repoinfo.xml)
> When repoinfo.xml does not have the latest section, however, the Use Public 
> Repository should be hidden from the view as it'd be definitely no 
> non-default stacks, and the "Why is this disabled ?" explanation does not 
> make sense in this case.
> 
> 
> Diffs
> -
> 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js
>  b3c27dc 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Stack.js 
> e028906 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html
>  3bee2a1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java
>  352aa2d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerTest.java
>  507c560 
> 
> 
> Diff: https://reviews.apache.org/r/58371/diff/1/
> 
> 
> Testing
> ---
> 
> unit tests
> patched a trunk cluster with the change, when all repoinfo.xml from all 
> stacks do not have the "latest" section, the Use Public Repository radio 
> button is hidden. When at least one repoinfo.xml has the "latest" section, 
> the Use Public Repository radio button is shown.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 58277: Skip calling stack selector, conf selector tools for Nifi, Streamline, Registry custom services in HDP cluster

[Jonathan Hurley]

> On April 12, 2017, 3:20 p.m., Jonathan Hurley wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
> > Lines 82 (patched)
> > 
> >
> > I don't see this being used anywhere.
> 
> Madhuvanthi Radhakrishnan wrote:
> It is used in 
> ~/hdf-ambari-mpack/src/main/resources/common-services/NIFI/1.0.0/package/scripts/params.py
> stack_version_buildnum = 
> get_component_version_with_stack_selector("/usr/bin/hdf-select", "nifi")

If that's the only spot using it, then it should be moved into that mpack, no? 
Otherwsie you risk it being removed in the future and breaking the mpack.


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58277/#review171778
---


On April 12, 2017, 2:04 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58277/
> ---
> 
> (Updated April 12, 2017, 2:04 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20696
> https://issues.apache.org/jira/browse/AMBARI-20696
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The custom services do not advertise any version and hence will not 
> participate in the HDP upgrade process. So selectors need not be called.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
>  79393b985f 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
>  02ae62daf3 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
>  ff00a1f38e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  0d1ef13c21 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  d5018f55b2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  751ce085d8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
>  e42bd45cc1 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
>  ad668a2051 
>   
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml
>  872120cc55 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py
>  1609050409 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
>  71a02f5e5a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
>  554e089102 
> 
> 
> Diff: https://reviews.apache.org/r/58277/diff/5/
> 
> 
> Testing
> ---
> 
> Installed HDP Regular services with HDF Custom services - Nifi, Strealine, 
> Registry
> Python unit tests
> Java unit tests
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 58389: Log Search: Add get clusters endpoint for service and audit logs

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58389/#review171782
---


Ship it!




Ship It!

- Robert Nettleton


On April 12, 2017, 3:51 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58389/
> ---
> 
> (Updated April 12, 2017, 3:51 p.m.)
> 
> 
> Review request for Ambari, Aleksandr Kovalenko, Miklos Gergely, and Robert 
> Nettleton.
> 
> 
> Bugs: AMBARI-20744
> https://issues.apache.org/jira/browse/AMBARI-20744
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add endpoint to get clusters for service and audit log collection.
> As the cluster fields can be different, therefore we need 2 calls for that
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/doc/DocConstants.java
>  984e834 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/AuditLogsManager.java
>  49465d5 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/ManagerBase.java
>  6b40cb5 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/ServiceLogsManager.java
>  9ce209b 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/rest/AuditLogsResource.java
>  2013dc7 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/rest/ServiceLogsResource.java
>  498da69 
> 
> 
> Diff: https://reviews.apache.org/r/58389/diff/1/
> 
> 
> Testing
> ---
> 
> done. manually
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 58398: Remove multiprocessing-based StatusCommandsExecutor

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58398/#review171780
---


Ship it!




Ship It!

- Sumit Mohanty


On April 12, 2017, 7:21 p.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58398/
> ---
> 
> (Updated April 12, 2017, 7:21 p.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty and Sid Wagle.
> 
> 
> Bugs: AMBARI-20750
> https://issues.apache.org/jira/browse/AMBARI-20750
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove old multiprocessing-based StatusCommandsExecutor in order to create 
> more reliable and debugable solution.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/StatusCommandsExecutor.py 142e7ca 
> 
> 
> Diff: https://reviews.apache.org/r/58398/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>

Re: Review Request 58277: Skip calling stack selector, conf selector tools for Nifi, Streamline, Registry custom services in HDP cluster

[Madhuvanthi Radhakrishnan]

> On April 12, 2017, 7:20 p.m., Jonathan Hurley wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
> > Lines 82 (patched)
> > 
> >
> > I don't see this being used anywhere.

It is used in 
~/hdf-ambari-mpack/src/main/resources/common-services/NIFI/1.0.0/package/scripts/params.py
stack_version_buildnum = 
get_component_version_with_stack_selector("/usr/bin/hdf-select", "nifi")


- Madhuvanthi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58277/#review171778
---


On April 12, 2017, 6:04 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58277/
> ---
> 
> (Updated April 12, 2017, 6:04 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20696
> https://issues.apache.org/jira/browse/AMBARI-20696
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The custom services do not advertise any version and hence will not 
> participate in the HDP upgrade process. So selectors need not be called.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
>  79393b985f 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
>  02ae62daf3 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
>  ff00a1f38e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  0d1ef13c21 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  d5018f55b2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  751ce085d8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
>  e42bd45cc1 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
>  ad668a2051 
>   
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml
>  872120cc55 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py
>  1609050409 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
>  71a02f5e5a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
>  554e089102 
> 
> 
> Diff: https://reviews.apache.org/r/58277/diff/5/
> 
> 
> Testing
> ---
> 
> Installed HDP Regular services with HDF Custom services - Nifi, Strealine, 
> Registry
> Python unit tests
> Java unit tests
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 58277: Skip calling stack selector, conf selector tools for Nifi, Streamline, Registry custom services in HDP cluster

[Madhuvanthi Radhakrishnan]

> On April 11, 2017, 10:29 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
> > Lines 421 (patched)
> > 
> >
> > Are we using this constant anywhere?

No, removed it.


- Madhuvanthi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58277/#review171651
---


On April 12, 2017, 6:04 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58277/
> ---
> 
> (Updated April 12, 2017, 6:04 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20696
> https://issues.apache.org/jira/browse/AMBARI-20696
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The custom services do not advertise any version and hence will not 
> participate in the HDP upgrade process. So selectors need not be called.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
>  79393b985f 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
>  02ae62daf3 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
>  ff00a1f38e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  0d1ef13c21 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  d5018f55b2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  751ce085d8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
>  e42bd45cc1 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
>  ad668a2051 
>   
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml
>  872120cc55 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py
>  1609050409 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
>  71a02f5e5a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
>  554e089102 
> 
> 
> Diff: https://reviews.apache.org/r/58277/diff/5/
> 
> 
> Testing
> ---
> 
> Installed HDP Regular services with HDF Custom services - Nifi, Strealine, 
> Registry
> Python unit tests
> Java unit tests
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 58277: Skip calling stack selector, conf selector tools for Nifi, Streamline, Registry custom services in HDP cluster

[Madhuvanthi Radhakrishnan]

> On April 11, 2017, 10:09 p.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
> > Lines 49 (patched)
> > 
> >
> > Please create a follow-up Jira to set this to False.
> > I'm ok if this is a temporary patch to unblock some testing.

I have created a follow-up jira and will work on any regressions that might 
cause the defaults as false.


> On April 11, 2017, 10:09 p.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
> > Lines 102 (patched)
> > 
> >
> > Perhaps check that code is 0 and file length is non-zero before getting 
> > file contents.

There is a follow up check-
if code != 0 or out is None:


- Madhuvanthi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58277/#review171639
---


On April 12, 2017, 6:04 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58277/
> ---
> 
> (Updated April 12, 2017, 6:04 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20696
> https://issues.apache.org/jira/browse/AMBARI-20696
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The custom services do not advertise any version and hence will not 
> participate in the HDP upgrade process. So selectors need not be called.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
>  79393b985f 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
>  02ae62daf3 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
>  ff00a1f38e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  0d1ef13c21 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  d5018f55b2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  751ce085d8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
>  e42bd45cc1 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
>  ad668a2051 
>   
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml
>  872120cc55 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py
>  1609050409 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
>  71a02f5e5a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
>  554e089102 
> 
> 
> Diff: https://reviews.apache.org/r/58277/diff/5/
> 
> 
> Testing
> ---
> 
> Installed HDP Regular services with HDF Custom services - Nifi, Strealine, 
> Registry
> Python unit tests
> Java unit tests
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Review Request 58398: Remove multiprocessing-based StatusCommandsExecutor

[Eugene Chekanskiy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58398/
---

Review request for Ambari, Sumit Mohanty and Sid Wagle.


Bugs: AMBARI-20750
https://issues.apache.org/jira/browse/AMBARI-20750


Repository: ambari


Description
---

Remove old multiprocessing-based StatusCommandsExecutor in order to create more 
reliable and debugable solution.


Diffs
-

  ambari-agent/src/main/python/ambari_agent/StatusCommandsExecutor.py 142e7ca 


Diff: https://reviews.apache.org/r/58398/diff/1/


Testing
---

mvn clean test


Thanks,

Eugene Chekanskiy

Re: Review Request 58277: Skip calling stack selector, conf selector tools for Nifi, Streamline, Registry custom services in HDP cluster

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58277/#review171778
---




ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
Lines 82 (patched)


I don't see this being used anywhere.


- Jonathan Hurley


On April 12, 2017, 2:04 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58277/
> ---
> 
> (Updated April 12, 2017, 2:04 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20696
> https://issues.apache.org/jira/browse/AMBARI-20696
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The custom services do not advertise any version and hence will not 
> participate in the HDP upgrade process. So selectors need not be called.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
>  79393b985f 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
>  02ae62daf3 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
>  ff00a1f38e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  0d1ef13c21 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  d5018f55b2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  751ce085d8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
>  e42bd45cc1 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
>  ad668a2051 
>   
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml
>  872120cc55 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py
>  1609050409 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
>  71a02f5e5a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
>  554e089102 
> 
> 
> Diff: https://reviews.apache.org/r/58277/diff/5/
> 
> 
> Testing
> ---
> 
> Installed HDP Regular services with HDF Custom services - Nifi, Strealine, 
> Registry
> Python unit tests
> Java unit tests
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 58367: Allow Potentially Long Running Restart Commands To Have Their Own Timeout

[Jonathan Hurley]

> On April 12, 2017, 10:12 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml
> > Line 551 (original), 551 (patched)
> > 
> >
> > Just to confirm; this can currently be set in ambari.properties, right? 
> > That way nobody has to go changing python or XML files ...
> > 
> > What about specifying this in the upgrade request? I know the UI 
> > doesn't have that option yet, but maybe we should open Jiras for it. That 
> > way a restart isn't required.
> 
> Nate Cole wrote:
> This means the UI has to A) understand what properties can be passed, 
> implying we have to provide those names somehow and B) build the screen for 
> this, which is undefined for 2.5.1.  We can revisit for 3.0 if it's really 
> needed.  Also means we would have to find/define every service that requires 
> a special timeout; so far only NN has been found to be an issue.

I'd think that the upgrade pack would define the parameters and expose them to 
the UI. The UI could then send those back. But, yes, you're right - it's not 
scoped yet. Just thought it would be good to get Jiras to track this. People 
probably want a more interactive upgrade where they can choose options.


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58367/#review171733
---


On April 11, 2017, 3:21 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58367/
> ---
> 
> (Updated April 11, 2017, 3:21 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-20736
> https://issues.apache.org/jira/browse/AMBARI-20736
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add the ability to set overrides for certain tasks in Upgrade Packs.  This 
> was done via ambari.properties for now.  Essentially, tasks may be defined 
> with a timeout-config option that will perform a lookup and apply it to the 
> ActionExecutionContext instance.  So far only one task was identified that 
> requires this, and that's NN restarts.  As we discover other time consuming 
> tasks we can add them, or alternatively show customers how to do this for 
> their own upgrades.
> 
> I did uncover an issue where we associate multiple Task objects to a 
> TaskWrapper, which is wrong (should be one-to-one).  In addition, we aren't 
> setup currently to allow multiple tasks to run concurrently on one host.  We 
> DO allow multiple tasks across hosts to work in parallel, which is fine.  
> These issues will be addressed in a future patch.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/decorator.py
>  55cf335aa0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  d5018f55b2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
>  709ca9360d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java
>  cd17a7080a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapper.java
>  aac89358da 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Task.java
>  5c43c2befd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/TaskWrapper.java
>  11e27cfb9f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/TaskWrapperBuilder.java
>  a75fe00bd4 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py
>  04897927f6 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
>  f0566d78e4 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 
> 1340b22711 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
> 40afc4f356 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> e0882d8350 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 
> 0f4efdcd0d 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 
> d5e9a5b095 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> 350395c714 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 
> 9ac3d52fe8 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
> 04a06e8447 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
> 879fe0f9bd 
>   ambari-server/src/main/resources/stacks/HDP/2.

Re: Review Request 58277: Skip calling stack selector, conf selector tools for Nifi, Streamline, Registry custom services in HDP cluster

[Madhuvanthi Radhakrishnan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58277/
---

(Updated April 12, 2017, 6:04 p.m.)


Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and Sumit 
Mohanty.


Changes
---

Review comments incorporated - python variable name, string formatting.


Bugs: AMBARI-20696
https://issues.apache.org/jira/browse/AMBARI-20696


Repository: ambari


Description
---

The custom services do not advertise any version and hence will not participate 
in the HDP upgrade process. So selectors need not be called.


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
 79393b985f 
  
ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
 02ae62daf3 
  
ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
 ff00a1f38e 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
 0d1ef13c21 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 d5018f55b2 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 751ce085d8 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
 e42bd45cc1 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
 ad668a2051 
  
ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml
 872120cc55 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py
 1609050409 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
 71a02f5e5a 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
 554e089102 


Diff: https://reviews.apache.org/r/58277/diff/5/

Changes: https://reviews.apache.org/r/58277/diff/4-5/


Testing
---

Installed HDP Regular services with HDF Custom services - Nifi, Strealine, 
Registry
Python unit tests
Java unit tests


Thanks,

Madhuvanthi Radhakrishnan

Re: Review Request 57687: AMBARI-20443 No need to show `hive_ambari_database`

[Masahiro Tanaka]

> On April 12, 2017, 10:19 p.m., Attila Doroszlai wrote:
> >

Sorry for my careless mistakeness... I'll fix this.


- Masahiro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57687/#review171728
---


On April 9, 2017, 4:03 p.m., Masahiro Tanaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57687/
> ---
> 
> (Updated April 9, 2017, 4:03 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Yusaku 
> Sako.
> 
> 
> Bugs: AMBARI-20443
> https://issues.apache.org/jira/browse/AMBARI-20443
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In Advanced hive-env, there is a parameter named hive_ambari_database. Though 
> I change the parameter, it looks like nothing has changed. I greped the 
> entire ambari source code, the parameter is not referenced.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
>  5f56617 
>   
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml
>  4ed26f7 
> 
> 
> Diff: https://reviews.apache.org/r/57687/diff/2/
> 
> 
> Testing
> ---
> 
> -1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12858664/AMBARI-20443.0.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/11023//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/11023//console
> This message is automatically generated.
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>

Re: Review Request 57687: AMBARI-20443 No need to show `hive_ambari_database`

[Masahiro Tanaka]

> On April 12, 2017, 10:19 p.m., Attila Doroszlai wrote:
> > ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml
> > Lines 89 (patched)
> > 
> >
> > Same here.

Oh, sorry...
I'll fix this shortly.


- Masahiro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57687/#review171728
---


On April 9, 2017, 4:03 p.m., Masahiro Tanaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57687/
> ---
> 
> (Updated April 9, 2017, 4:03 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Yusaku 
> Sako.
> 
> 
> Bugs: AMBARI-20443
> https://issues.apache.org/jira/browse/AMBARI-20443
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In Advanced hive-env, there is a parameter named hive_ambari_database. Though 
> I change the parameter, it looks like nothing has changed. I greped the 
> entire ambari source code, the parameter is not referenced.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
>  5f56617 
>   
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml
>  4ed26f7 
> 
> 
> Diff: https://reviews.apache.org/r/57687/diff/2/
> 
> 
> Testing
> ---
> 
> -1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12858664/AMBARI-20443.0.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/11023//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/11023//console
> This message is automatically generated.
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>

Re: Review Request 58363: Upgrade Catalog 2.5.1 Changes For HRC Background Task

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58363/#review171753
---


Ship it!




Ship It!

- Alejandro Fernandez


On April 12, 2017, 12:55 a.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58363/
> ---
> 
> (Updated April 12, 2017, 12:55 a.m.)
> 
> 
> Review request for Ambari, Nate Cole and Robert Levas.
> 
> 
> Bugs: AMBARI-20714
> https://issues.apache.org/jira/browse/AMBARI-20714
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Create a new UpgradeCatalog for v2.5.1 and add the DB changes in AMBARI-20712
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java
>  fdec5f0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java
>  590a3e8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog251.java
>  PRE-CREATION 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 5785a9d 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 96ef0ac 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 3396ce9 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql c6bfa94 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql bbf5d3c 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 13ab01d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog251Test.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/58363/diff/2/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 57687: AMBARI-20443 No need to show `hive_ambari_database`

[Alejandro Fernandez]

> On April 12, 2017, 1:19 p.m., Attila Doroszlai wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
> > Line 120 (original), 120 (patched)
> > 
> >
> > `` should be closed by ``, not ``.
> 
> Alejandro Fernandez wrote:
> I read this too quickly, you're right.
> Masahiro, can you submit a patch to fix this. I will revert it for now.

Actually, looks like already reverted in commit 
273653b5a6057951f9df6ab7781e9ddcbd3c448c


- Alejandro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57687/#review171728
---


On April 9, 2017, 7:03 a.m., Masahiro Tanaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57687/
> ---
> 
> (Updated April 9, 2017, 7:03 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Yusaku 
> Sako.
> 
> 
> Bugs: AMBARI-20443
> https://issues.apache.org/jira/browse/AMBARI-20443
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In Advanced hive-env, there is a parameter named hive_ambari_database. Though 
> I change the parameter, it looks like nothing has changed. I greped the 
> entire ambari source code, the parameter is not referenced.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
>  5f56617 
>   
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml
>  4ed26f7 
> 
> 
> Diff: https://reviews.apache.org/r/57687/diff/2/
> 
> 
> Testing
> ---
> 
> -1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12858664/AMBARI-20443.0.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/11023//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/11023//console
> This message is automatically generated.
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>

Re: Review Request 57687: AMBARI-20443 No need to show `hive_ambari_database`

[Alejandro Fernandez]

> On April 12, 2017, 1:19 p.m., Attila Doroszlai wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
> > Line 120 (original), 120 (patched)
> > 
> >
> > `` should be closed by ``, not ``.

I read this too quickly, you're right.
Masahiro, can you submit a patch to fix this. I will revert it for now.


- Alejandro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57687/#review171728
---


On April 9, 2017, 7:03 a.m., Masahiro Tanaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57687/
> ---
> 
> (Updated April 9, 2017, 7:03 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Yusaku 
> Sako.
> 
> 
> Bugs: AMBARI-20443
> https://issues.apache.org/jira/browse/AMBARI-20443
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In Advanced hive-env, there is a parameter named hive_ambari_database. Though 
> I change the parameter, it looks like nothing has changed. I greped the 
> entire ambari source code, the parameter is not referenced.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
>  5f56617 
>   
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml
>  4ed26f7 
> 
> 
> Diff: https://reviews.apache.org/r/57687/diff/2/
> 
> 
> Testing
> ---
> 
> -1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12858664/AMBARI-20443.0.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/11023//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/11023//console
> This message is automatically generated.
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>

Re: Review Request 57451: The Installation of hbase-client failed

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57451/#review171749
---




ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py
Lines 67 (patched)


I've actually never seen this, so perhaps a more appropriate fix would be 
in HDFS Client instead.
HDFS Client itself should ensure that the hadoop conf dir exists.


- Alejandro Fernandez


On April 10, 2017, 7:37 a.m., zhangxiaolu zhangxiaolu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57451/
> ---
> 
> (Updated April 10, 2017, 7:37 a.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Jaimin Jetly, Srimanth Gunturi, Sid 
> Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-20368
> https://issues.apache.org/jira/browse/AMBARI-20368
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The problem is caused by the wrong installation order, which means 
> hbase-client will be installed before the installation of hdfs-client. Under 
> such circumstance, installation of hdfs-client will fail because the 
> hadoop-conf-dir does not exist. 
> Two solutions can be provided to solve this problem:
> 1. Creating the hadoop-conf-dir in hbase.py;
> 2. Setting correct installation order in role_command_order.json;
> Considering that hdfs-client may not beinstalled on the node especially when 
> adding new host, therefore, in my opinion, the second choice would be more 
> appropriate.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py
>  8ad802e 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_client.py 
> cffec06 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py 
> 42bc989 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py 
> 9bb0dd7 
>   
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_phoenix_queryserver.py 
> 60022e1 
> 
> 
> Diff: https://reviews.apache.org/r/57451/diff/5/
> 
> 
> Testing
> ---
> 
> done it
> 
> 
> File Attachments
> 
> 
> AMBARI-20368.patch
>   
> https://reviews.apache.org/media/uploaded/files/2017/04/07/e542fd73-b2b4-4542-94d2-151bbadd8b48__AMBARI-20368.patch
> 
> 
> Thanks,
> 
> zhangxiaolu zhangxiaolu
> 
>

Re: Review Request 57709: Yarn Queue manager capacity field allows entering invalid values

[Anita Jebaraj]

> On April 12, 2017, 11:31 a.m., DIPAYAN BHOWMICK wrote:
> > Ship It!

Thank you for reviewing, can you please help in pushing the changes?


- Anita


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57709/#review171710
---


On April 5, 2017, 9:43 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57709/
> ---
> 
> (Updated April 5, 2017, 9:43 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, belliraj hb, Di Li, DIPAYAN 
> BHOWMICK, Jaimin Jetly, Richard Zang, and Sangeeta Ravindran.
> 
> 
> Bugs: AMBARI-20334
> https://issues.apache.org/jira/browse/AMBARI-20334
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> capacity field in yarn queue manager should allow entering decimal numbers 
> upto 2 places,
> 
> currently the field allows entering values like
> 
> 1.2.3
> 12...
> 1 2.3
> 
> 
> Diffs
> -
> 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/capacityInput.js
>  b6c419a 
> 
> 
> Diff: https://reviews.apache.org/r/57709/diff/2/
> 
> 
> Testing
> ---
> 
> Tested manually
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 58256: Support creating/editing alert dispatch targets for script-based alert dispatchers by web wizard instead of command line

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58256/#review171745
---


Ship it!




Ship It!

- Alejandro Fernandez


On April 12, 2017, 1:44 p.m., yao lei wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58256/
> ---
> 
> Review request for Ambari, Alejandro Fernandez, Alexandr Antonenko, Andrii 
> Tkach, Di Li, Jaimin Jetly, Zhe (Joe) Wang, Matt, Richard Zang, and Yusaku 
> Sako.
> 
> 
> Bugs: AMBARI-18423
> https://issues.apache.org/jira/browse/AMBARI-18423
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari now support creating/editing three kinds of alert dispatch targets by 
> web wizard, including EMAIL,SNMP,Custom SNMP.
> If we want to create another kind of alert dispatch target ALERT_SCRIPT for 
> script-based alert dispatcher,we have to execute a command manually like 
> following:
> {code}
> POST api/v1/alert_targets
> 
> {
>   "AlertTarget": {
> "name": "syslogger",
> "description": "Syslog Target",
> "notification_type": "ALERT_SCRIPT",
> "global": true
>   }
> }
> {code}
> or
> {code}
> POST api/v1/alert_targets
> 
> {
>   "AlertTarget": {
> "name": "syslogger",
> "description": "Syslog Target",
> "notification_type": "ALERT_SCRIPT",
> "global": false,
> "groups":[1,3]
> "alert_states":["WARNING","CRITICAL","UNKNOWN"],
> "properties": {
>   "ambari.dispatch-property.script": 
> "com.mycompany.dispatch.syslog.script"
> }
>   }
> }
> {code}
> More details, please see 
> https://cwiki.apache.org/confluence/display/AMBARI/Creating+a+Script-based+Alert+Dispatcher+-+2.4.0
> We should do this by web wizard rather than command line, which will lead to 
> more convenience
> We think it is really helpeful for us when using script-based alert 
> dispatcher.
> 
> 
> Diffs
> -
> 
>   
> ambari-web/app/controllers/main/alerts/manage_alert_notifications_controller.js
>  73c19c6 
>   ambari-web/app/messages.js a2edf06 
>   ambari-web/app/templates/main/alerts/create_alert_notification.hbs 5b40bca 
>   
> ambari-web/test/controllers/main/alerts/manage_alert_notifications_controller_test.js
>  31da561 
> 
> 
> Diff: https://reviews.apache.org/r/58256/diff/2/
> 
> 
> Testing
> ---
> 
> mvn test
> 20676 passing (34s)
> 128 pending
> 
> 
> Thanks,
> 
> yao lei
> 
>

Review Request 58389: Log Search: Add get clusters endpoint for service and audit logs

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58389/
---

Review request for Ambari, Aleksandr Kovalenko, Miklos Gergely, and Robert 
Nettleton.


Bugs: AMBARI-20744
https://issues.apache.org/jira/browse/AMBARI-20744


Repository: ambari


Description
---

Add endpoint to get clusters for service and audit log collection.
As the cluster fields can be different, therefore we need 2 calls for that


Diffs
-

  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/doc/DocConstants.java
 984e834 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/AuditLogsManager.java
 49465d5 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/ManagerBase.java
 6b40cb5 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/ServiceLogsManager.java
 9ce209b 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/rest/AuditLogsResource.java
 2013dc7 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/rest/ServiceLogsResource.java
 498da69 


Diff: https://reviews.apache.org/r/58389/diff/1/


Testing
---

done. manually


Thanks,

Oliver Szabo

Re: Review Request 58367: Allow Potentially Long Running Restart Commands To Have Their Own Timeout

[Nate Cole]

> On April 12, 2017, 10:12 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
> > Line 469 (original), 469-474 (patched)
> > 
> >
> > Guard against a 0 here with something like Max(getTimeout(), 1)?

Interesting point - good one, I'll guard against that.  But if some clown is 
actually using 0 or negative they should get what's coming :)


> On April 12, 2017, 10:12 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java
> > Lines 130-131 (original), 130-132 (patched)
> > 
> >
> > You removed the TaskWrapper though, right? I'm assuming b/c it wasn't 
> > used - so does this method really generate a task wrapper?

I didn't remove TaskWrapper at this time.  It's still needed as it defines the 
Task that should run, and on what hosts.  The fix for later is that TaskWrapper 
holds List, which is wrong.  I only made this clarifying comment for when 
that fix is made.


> On April 12, 2017, 10:12 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml
> > Line 551 (original), 551 (patched)
> > 
> >
> > Just to confirm; this can currently be set in ambari.properties, right? 
> > That way nobody has to go changing python or XML files ...
> > 
> > What about specifying this in the upgrade request? I know the UI 
> > doesn't have that option yet, but maybe we should open Jiras for it. That 
> > way a restart isn't required.

This means the UI has to A) understand what properties can be passed, implying 
we have to provide those names somehow and B) build the screen for this, which 
is undefined for 2.5.1.  We can revisit for 3.0 if it's really needed.  Also 
means we would have to find/define every service that requires a special 
timeout; so far only NN has been found to be an issue.


> On April 12, 2017, 10:12 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml
> > Line 582 (original), 582 (patched)
> > 
> >
> > I'm fine this the granularity of this since it gets us to where we want 
> > to be. Oringinally, I thought we'd do something more generic like a timeout 
> > for master start - but I guess NN restart could take a much longer time 
> > than Nimbus.

I thought about that, but since we don't have all the places in python where to 
expect this value, it becomes a bit misleading about whether we have 
implemented it or not.  The NN case is simple because we know where the holdup 
is.  For other daemons we can just let the server manage the timeout when 
@retry isn't used.


- Nate


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58367/#review171733
---


On April 11, 2017, 3:21 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58367/
> ---
> 
> (Updated April 11, 2017, 3:21 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-20736
> https://issues.apache.org/jira/browse/AMBARI-20736
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add the ability to set overrides for certain tasks in Upgrade Packs.  This 
> was done via ambari.properties for now.  Essentially, tasks may be defined 
> with a timeout-config option that will perform a lookup and apply it to the 
> ActionExecutionContext instance.  So far only one task was identified that 
> requires this, and that's NN restarts.  As we discover other time consuming 
> tasks we can add them, or alternatively show customers how to do this for 
> their own upgrades.
> 
> I did uncover an issue where we associate multiple Task objects to a 
> TaskWrapper, which is wrong (should be one-to-one).  In addition, we aren't 
> setup currently to allow multiple tasks to run concurrently on one host.  We 
> DO allow multiple tasks across hosts to work in parallel, which is fine.  
> These issues will be addressed in a future patch.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/decorator.py
>  55cf335aa0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  d5018f55b2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
>  709ca

Re: Review Request 57378: RU: MR2 service check failed during rolling upgrade

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57378/#review171738
---



Ping. Can this review be closed?

- Jonathan Hurley


On March 7, 2017, 10:56 a.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57378/
> ---
> 
> (Updated March 7, 2017, 10:56 a.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-20344
> https://issues.apache.org/jira/browse/AMBARI-20344
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> During RU MapReduce Service check failed with exception:
> {code:java}
> 17/02/25 14:18:24 INFO service.AbstractService: Service 
> org.apache.hadoop.yarn.client.api.impl.YarnClientImpl failed in state 
> STARTED; cause: java.lang.RuntimeException: java.lang.RuntimeException: 
> java.lang.ClassNotFoundException: Class 
> org.apache.hadoop.yarn.client.RequestHedgingRMFailoverProxyProvider not found
> java.lang.RuntimeException: java.lang.RuntimeException: 
> java.lang.ClassNotFoundException: Class 
> org.apache.hadoop.yarn.client.RequestHedgingRMFailoverProxyProvider not found
> at org.apache.hadoop.conf.Configuration.getClass(Configuration.java:2227)
> at 
> org.apache.hadoop.yarn.client.RMProxy.createRMFailoverProxyProvider(RMProxy.java:160)
> at org.apache.hadoop.yarn.client.RMProxy.createRMProxy(RMProxy.java:93)
> at 
> org.apache.hadoop.yarn.client.ClientRMProxy.createRMProxy(ClientRMProxy.java:72)
> at 
> org.apache.hadoop.yarn.client.api.impl.YarnClientImpl.serviceStart(YarnClientImpl.java:188)
> at org.apache.hadoop.service.AbstractService.start(AbstractService.java:193)
> at 
> org.apache.hadoop.mapred.ResourceMgrDelegate.serviceStart(ResourceMgrDelegate.java:109)
> at org.apache.hadoop.service.AbstractService.start(AbstractService.java:193)
> at 
> org.apache.hadoop.mapred.ResourceMgrDelegate.(ResourceMgrDelegate.java:98)
> at org.apache.hadoop.mapred.YARNRunner.(YARNRunner.java:112)
> at 
> org.apache.hadoop.mapred.YarnClientProtocolProvider.create(YarnClientProtocolProvider.java:34)
> at org.apache.hadoop.mapreduce.Cluster.initialize(Cluster.java:95)
> at org.apache.hadoop.mapreduce.Cluster.(Cluster.java:82)
> at org.apache.hadoop.mapreduce.Cluster.(Cluster.java:75)
> at org.apache.hadoop.mapreduce.Job$9.run(Job.java:1260)
> at org.apache.hadoop.mapreduce.Job$9.run(Job.java:1256)
> at java.security.AccessController.doPrivileged(Native Method)
> at javax.security.auth.Subject.doAs(Subject.java:415)
> at 
> org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1709)
> at org.apache.hadoop.mapreduce.Job.connect(Job.java:1255)
> at org.apache.hadoop.mapreduce.Job.submit(Job.java:1284)
> at org.apache.hadoop.mapreduce.Job.waitForCompletion(Job.java:1308)
> at org.apache.hadoop.examples.WordCount.main(WordCount.java:87)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at 
> org.apache.hadoop.util.ProgramDriver$ProgramDescription.invoke(ProgramDriver.java:71)
> at org.apache.hadoop.util.ProgramDriver.run(ProgramDriver.java:144)
> at org.apache.hadoop.examples.ExampleDriver.main(ExampleDriver.java:74)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at org.apache.hadoop.util.RunJar.run(RunJar.java:221)
> at org.apache.hadoop.util.RunJar.main(RunJar.java:136)
> Caused by: java.lang.RuntimeException: java.lang.ClassNotFoundException: 
> Class org.apache.hadoop.yarn.client.RequestHedgingRMFailoverProxyProvider not 
> found
> at org.apache.hadoop.conf.Configuration.getClass(Configuration.java:2195)
> at org.apache.hadoop.conf.Configuration.getClass(Configuration.java:2219)
> ... 35 more
> Caused by: java.lang.ClassNotFoundException: Class 
> org.apache.hadoop.yarn.client.RequestHedgingRMFailoverProxyProvider not found
> at 
> org.apache.hadoop.conf.Configuration.getClassByName(Configuration.java:2101)
> at org.apache.hadoop.conf.Configuration.getClass(Configuration.java:2193)
> ... 36 more
> 17/02/25 14:18:24 INFO service.AbstractService: Service 
> org.apache.hadoop.mapred.ResourceMgrDelegate failed in state STARTED; cause: 
> java.lang.RuntimeException: java.lang.RuntimeException: 
> java.lang.ClassNotFoundException: Class 
> org.apache.hadoop.yarn.client.RequestHedgingRMFa

Re: Review Request 58322: Small fixes in Log Search

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58322/#review171737
---


Ship it!




Ship It!

- Oliver Szabo


On April 10, 2017, 9:30 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58322/
> ---
> 
> (Updated April 10, 2017, 9:30 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-20727
> https://issues.apache.org/jira/browse/AMBARI-20727
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove some unused codes, suppress some warnings with annotations, fix 
> generics.
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-appender/pom.xml e14d576 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/steps/LogSearchApiSteps.java
>  bcfc4db 
>   ambari-logsearch/ambari-logsearch-logfeeder/pom.xml 25e4306 
>   ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/log4j.xml 
> 7ef967c 
>   ambari-logsearch/ambari-logsearch-server/pom.xml 52bda8d 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/converter/AbstractLogRequestFacetQueryConverter.java
>  d5e807b 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/handler/ListCollectionHandler.java
>  124ce40 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/handler/UploadConfigurationHandler.java
>  27a6705 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/AuditLogsManager.java
>  49465d5 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/ManagerBase.java
>  6b40cb5 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/ServiceLogsManager.java
>  9ce209b 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/authenticate/LogsearchAuthSuccessHandler.java
>  cf9d200 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/filters/LogsearchKrbFilter.java
>  f4e70d7 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/model/JWTAuthenticationToken.java
>  35175b6 
>   ambari-logsearch/ambari-logsearch-server/src/main/resources/log4j.xml 
> 547841a 
> 
> 
> Diff: https://reviews.apache.org/r/58322/diff/1/
> 
> 
> Testing
> ---
> 
> Tested on local cluster
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 58387: Log Search common properties

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58387/
---

(Updated April 12, 2017, 2:17 p.m.)


Review request for Ambari, Oliver Szabo and Robert Nettleton.


Changes
---

Fix tests.


Bugs: AMBARI-20742
https://issues.apache.org/jira/browse/AMBARI-20742


Repository: ambari


Description
---

Allow specifying properties for both server and log feeder.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-common-properties.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
 84a6ad9 
  ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logfeeder.py 662e4a7 
  ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py 52ac316 
  ambari-server/src/test/python/stacks/2.4/configs/default.json 8822e96 


Diff: https://reviews.apache.org/r/58387/diff/2/

Changes: https://reviews.apache.org/r/58387/diff/1-2/


Testing
---

Tested on local cluster.


Thanks,

Miklos Gergely

Re: Review Request 58387: Log Search common properties

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58387/#review171735
---


Ship it!




Ship It!

- Oliver Szabo


On April 12, 2017, 12:34 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58387/
> ---
> 
> (Updated April 12, 2017, 12:34 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-20742
> https://issues.apache.org/jira/browse/AMBARI-20742
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Allow specifying properties for both server and log feeder.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-common-properties.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
>  d00be4e 
> 
> 
> Diff: https://reviews.apache.org/r/58387/diff/1/
> 
> 
> Testing
> ---
> 
> Tested on local cluster.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 58387: Log Search common properties

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58387/#review171734
---


Ship it!




Ship It!

- Robert Nettleton


On April 12, 2017, 12:34 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58387/
> ---
> 
> (Updated April 12, 2017, 12:34 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-20742
> https://issues.apache.org/jira/browse/AMBARI-20742
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Allow specifying properties for both server and log feeder.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-common-properties.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
>  d00be4e 
> 
> 
> Diff: https://reviews.apache.org/r/58387/diff/1/
> 
> 
> Testing
> ---
> 
> Tested on local cluster.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 58367: Allow Potentially Long Running Restart Commands To Have Their Own Timeout

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58367/#review171733
---


Fix it, then Ship it!





ambari-common/src/main/python/resource_management/libraries/functions/decorator.py
Lines 49 (patched)


If this is true, then I think I've been coding wrong for a while :)



ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
Line 469 (original), 469-474 (patched)


Guard against a 0 here with something like Max(getTimeout(), 1)?



ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java
Lines 130-131 (original), 130-132 (patched)


You removed the TaskWrapper though, right? I'm assuming b/c it wasn't used 
- so does this method really generate a task wrapper?



ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml
Line 551 (original), 551 (patched)


Just to confirm; this can currently be set in ambari.properties, right? 
That way nobody has to go changing python or XML files ...

What about specifying this in the upgrade request? I know the UI doesn't 
have that option yet, but maybe we should open Jiras for it. That way a restart 
isn't required.



ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml
Line 582 (original), 582 (patched)


I'm fine this the granularity of this since it gets us to where we want to 
be. Oringinally, I thought we'd do something more generic like a timeout for 
master start - but I guess NN restart could take a much longer time than Nimbus.


- Jonathan Hurley


On April 11, 2017, 3:21 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58367/
> ---
> 
> (Updated April 11, 2017, 3:21 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-20736
> https://issues.apache.org/jira/browse/AMBARI-20736
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add the ability to set overrides for certain tasks in Upgrade Packs.  This 
> was done via ambari.properties for now.  Essentially, tasks may be defined 
> with a timeout-config option that will perform a lookup and apply it to the 
> ActionExecutionContext instance.  So far only one task was identified that 
> requires this, and that's NN restarts.  As we discover other time consuming 
> tasks we can add them, or alternatively show customers how to do this for 
> their own upgrades.
> 
> I did uncover an issue where we associate multiple Task objects to a 
> TaskWrapper, which is wrong (should be one-to-one).  In addition, we aren't 
> setup currently to allow multiple tasks to run concurrently on one host.  We 
> DO allow multiple tasks across hosts to work in parallel, which is fine.  
> These issues will be addressed in a future patch.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/decorator.py
>  55cf335aa0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  d5018f55b2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
>  709ca9360d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java
>  cd17a7080a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapper.java
>  aac89358da 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Task.java
>  5c43c2befd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/TaskWrapper.java
>  11e27cfb9f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/TaskWrapperBuilder.java
>  a75fe00bd4 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py
>  04897927f6 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
>  f0566d78e4 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 
> 1340b22711 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
> 40afc4f356 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> e0882d8350 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 
> 0f4efdcd0d 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 
> d5e9a5b

Re: Review Request 58277: Skip calling stack selector, conf selector tools for Nifi, Streamline, Registry custom services in HDP cluster

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58277/#review171732
---


Fix it, then Ship it!





ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
Lines 48-49 (patched)


This appears to be relying on the server sending the value properly, if at 
all.  May be safer to assume False.  If it defaults true and the stack selector 
isn't actually available you may be in a bad code path.

Also, we tend to use an underscore format for python variables rather than 
a camel-case.



ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
Lines 107-108 (patched)


%s format is deprecated.  Use {0} notation.


- Nate Cole


On April 12, 2017, 2:15 a.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58277/
> ---
> 
> (Updated April 12, 2017, 2:15 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20696
> https://issues.apache.org/jira/browse/AMBARI-20696
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The custom services do not advertise any version and hence will not 
> participate in the HDP upgrade process. So selectors need not be called.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
>  79393b985f 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
>  02ae62daf3 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
>  ff00a1f38e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  0d1ef13c21 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  d5018f55b2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  751ce085d8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
>  e42bd45cc1 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
>  ad668a2051 
>   
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml
>  872120cc55 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py
>  1609050409 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
>  71a02f5e5a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
>  554e089102 
> 
> 
> Diff: https://reviews.apache.org/r/58277/diff/4/
> 
> 
> Testing
> ---
> 
> Installed HDP Regular services with HDF Custom services - Nifi, Strealine, 
> Registry
> Python unit tests
> Java unit tests
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 58363: Upgrade Catalog 2.5.1 Changes For HRC Background Task

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58363/#review171731
---


Ship it!




Ship It!

- Nate Cole


On April 11, 2017, 8:55 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58363/
> ---
> 
> (Updated April 11, 2017, 8:55 p.m.)
> 
> 
> Review request for Ambari, Nate Cole and Robert Levas.
> 
> 
> Bugs: AMBARI-20714
> https://issues.apache.org/jira/browse/AMBARI-20714
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Create a new UpgradeCatalog for v2.5.1 and add the DB changes in AMBARI-20712
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java
>  fdec5f0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java
>  590a3e8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog251.java
>  PRE-CREATION 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 5785a9d 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 96ef0ac 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 3396ce9 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql c6bfa94 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql bbf5d3c 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 13ab01d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog251Test.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/58363/diff/2/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 58228: Perf: Refactor ambari db-cleanup to include all big tables

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58228/#review171730
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Квітень 12, 2017, 1:14 до полудня, Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58228/
> ---
> 
> (Updated Квітень 12, 2017, 1:14 до полудня)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Myroslav 
> Papirkovskyy, and Sid Wagle.
> 
> 
> Bugs: AMBARI-20687
> https://issues.apache.org/jira/browse/AMBARI-20687
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add check for large tables into db consistency check.
> Add code to cleanup these tables into db-cleanup code.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  e7e9433 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessor.java 
> c132a3d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java 
> 1dd3b54 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java
>  7318162 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestDAO.java 
> 2696f66 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/TopologyHostTaskDAO.java
>  02532db 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/TopologyLogicalRequestDAO.java
>  e917dc2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/TopologyLogicalTaskDAO.java
>  35f47a7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ExecutionCommandEntity.java
>  85f3a25 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java
>  fdec5f0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestEntity.java
>  f19aa72 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestOperationLevelEntity.java
>  ff14e3a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestResourceFilterEntity.java
>  8ee41d2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RoleSuccessCriteriaEntity.java
>  3386c24 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StageEntity.java
>  d035729 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyHostRequestEntity.java
>  b90e192 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyHostTaskEntity.java
>  bba0e06 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyLogicalRequestEntity.java
>  4f865f4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyLogicalTaskEntity.java
>  c71d4e4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java
>  89574bc 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeItemEntity.java
>  560970a 
>   ambari-server/src/main/python/ambari-server.py 87cc6c2 
>   ambari-server/src/main/python/ambari_server/dbCleanup.py abc8267 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java
>  7d8ba50 
> 
> 
> Diff: https://reviews.apache.org/r/58228/diff/8/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 58228: Perf: Refactor ambari db-cleanup to include all big tables

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58228/#review171729
---


Ship it!




Ship It!

- Dmytro Sen


On Апрель 12, 2017, 1:14 д.п., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58228/
> ---
> 
> (Updated Апрель 12, 2017, 1:14 д.п.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Myroslav 
> Papirkovskyy, and Sid Wagle.
> 
> 
> Bugs: AMBARI-20687
> https://issues.apache.org/jira/browse/AMBARI-20687
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add check for large tables into db consistency check.
> Add code to cleanup these tables into db-cleanup code.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  e7e9433 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessor.java 
> c132a3d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java 
> 1dd3b54 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java
>  7318162 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestDAO.java 
> 2696f66 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/TopologyHostTaskDAO.java
>  02532db 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/TopologyLogicalRequestDAO.java
>  e917dc2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/TopologyLogicalTaskDAO.java
>  35f47a7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ExecutionCommandEntity.java
>  85f3a25 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java
>  fdec5f0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestEntity.java
>  f19aa72 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestOperationLevelEntity.java
>  ff14e3a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestResourceFilterEntity.java
>  8ee41d2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RoleSuccessCriteriaEntity.java
>  3386c24 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StageEntity.java
>  d035729 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyHostRequestEntity.java
>  b90e192 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyHostTaskEntity.java
>  bba0e06 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyLogicalRequestEntity.java
>  4f865f4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyLogicalTaskEntity.java
>  c71d4e4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java
>  89574bc 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeItemEntity.java
>  560970a 
>   ambari-server/src/main/python/ambari-server.py 87cc6c2 
>   ambari-server/src/main/python/ambari_server/dbCleanup.py abc8267 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java
>  7d8ba50 
> 
> 
> Diff: https://reviews.apache.org/r/58228/diff/8/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 57687: AMBARI-20443 No need to show `hive_ambari_database`

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57687/#review171728
---




ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
Line 120 (original), 120 (patched)


`` should be closed by ``, not ``.



ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml
Lines 89 (patched)


Same here.


- Attila Doroszlai


On April 9, 2017, 9:03 a.m., Masahiro Tanaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57687/
> ---
> 
> (Updated April 9, 2017, 9:03 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Yusaku 
> Sako.
> 
> 
> Bugs: AMBARI-20443
> https://issues.apache.org/jira/browse/AMBARI-20443
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In Advanced hive-env, there is a parameter named hive_ambari_database. Though 
> I change the parameter, it looks like nothing has changed. I greped the 
> entire ambari source code, the parameter is not referenced.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
>  5f56617 
>   
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml
>  4ed26f7 
> 
> 
> Diff: https://reviews.apache.org/r/57687/diff/2/
> 
> 
> Testing
> ---
> 
> -1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12858664/AMBARI-20443.0.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/11023//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/11023//console
> This message is automatically generated.
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>

Re: Review Request 58208: Wait For DataNodes To Shutdown During a Rolling Upgrade

[Dmitro Lisnichenko]

> On April 11, 2017, 9:20 p.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/resource_management/libraries/script/script.py
> > Lines 352 (patched)
> > 
> >
> > How does this know it's operating on a stop command, or a restart?

it's called from execute() method above


- Dmitro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58208/#review171595
---


On April 12, 2017, 3:57 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58208/
> ---
> 
> (Updated April 12, 2017, 3:57 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-20682
> https://issues.apache.org/jira/browse/AMBARI-20682
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> During a rolling upgrade (especially on a large, heavily used cluster), the 
> DataNodes do not shutdown immediately. However, they do de-register from the 
> NameNode which tricks Ambari into thinking that they are down.
> 
> Since the rolling upgrade uses a {{RESTART}} command, we attempt to start the 
> DataNode back up before the daemon has shutdown:
> 
> {code}
> 2017-03-14 05:00:25,602 - 
> call['/usr/hdp/current/hadoop-hdfs-datanode/bin/hdfs dfsadmin -fs hdfs://c1ha 
> -shutdownDatanode 0.0.0.0:8010 upgrade'] {'user': 'hdfs'}
> 2017-03-14 05:00:28,438 - call returned (0, 'Submitted a shutdown request to 
> datanode 0.0.0.0:8010')
> 2017-03-14 05:00:28,438 - 
> Execute['/usr/hdp/current/hadoop-hdfs-datanode/bin/hdfs dfsadmin -fs 
> hdfs://c1ha -D ipc.client.connect.max.retries=5 -D 
> ipc.client.connect.retry.interval=1000 -getDatanodeInfo 0.0.0.0:8010'] 
> {'tries': 1, 'user': 'hdfs'}
> 2017-03-14 05:00:35,976 - DataNode has successfully shutdown for upgrade.
> {code}
> 
> Even though ~ 6 seconds have passed, the daemon is still running as it 
> drains. Therefore, we attempt to start it which causes a NOOP.
> 
> Instead, we should also monitor for the PID.
> 
> -
> Now STOP command waits until component really dies. Motivation behind that 
> is: we don't want to execute START of still running component again (e.g. 
> during upgrade/RESTART)
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> 9a5da04 
>   
> ambari-funtest/src/test/resources/stacks/HDP/2.0.7/services/HIVE/package/scripts/mysql_service.py
>  4716343 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py
>  151e26c 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode_upgrade.py
>  b55237d 
>   
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HIVE/package/scripts/mysql_service.py
>  11bbdd8 
>   
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HIVE/package/scripts/postgresql_service.py
>  cc7b4cc 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py 1c3c5b7 
> 
> 
> Diff: https://reviews.apache.org/r/58208/diff/3/
> 
> 
> Testing
> ---
> 
> mvn clean test 
> and test on live cluster
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 58208: Wait For DataNodes To Shutdown During a Rolling Upgrade

[Dmitro Lisnichenko]

> On April 11, 2017, 10:18 p.m., Jonathan Hurley wrote:
> > ambari-common/src/main/python/resource_management/libraries/script/script.py
> > Lines 352 (patched)
> > 
> >
> > Can we call this status_method just to make it clearer what's being 
> > executed?

done


- Dmitro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58208/#review171616
---


On April 12, 2017, 3:57 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58208/
> ---
> 
> (Updated April 12, 2017, 3:57 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-20682
> https://issues.apache.org/jira/browse/AMBARI-20682
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> During a rolling upgrade (especially on a large, heavily used cluster), the 
> DataNodes do not shutdown immediately. However, they do de-register from the 
> NameNode which tricks Ambari into thinking that they are down.
> 
> Since the rolling upgrade uses a {{RESTART}} command, we attempt to start the 
> DataNode back up before the daemon has shutdown:
> 
> {code}
> 2017-03-14 05:00:25,602 - 
> call['/usr/hdp/current/hadoop-hdfs-datanode/bin/hdfs dfsadmin -fs hdfs://c1ha 
> -shutdownDatanode 0.0.0.0:8010 upgrade'] {'user': 'hdfs'}
> 2017-03-14 05:00:28,438 - call returned (0, 'Submitted a shutdown request to 
> datanode 0.0.0.0:8010')
> 2017-03-14 05:00:28,438 - 
> Execute['/usr/hdp/current/hadoop-hdfs-datanode/bin/hdfs dfsadmin -fs 
> hdfs://c1ha -D ipc.client.connect.max.retries=5 -D 
> ipc.client.connect.retry.interval=1000 -getDatanodeInfo 0.0.0.0:8010'] 
> {'tries': 1, 'user': 'hdfs'}
> 2017-03-14 05:00:35,976 - DataNode has successfully shutdown for upgrade.
> {code}
> 
> Even though ~ 6 seconds have passed, the daemon is still running as it 
> drains. Therefore, we attempt to start it which causes a NOOP.
> 
> Instead, we should also monitor for the PID.
> 
> -
> Now STOP command waits until component really dies. Motivation behind that 
> is: we don't want to execute START of still running component again (e.g. 
> during upgrade/RESTART)
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> 9a5da04 
>   
> ambari-funtest/src/test/resources/stacks/HDP/2.0.7/services/HIVE/package/scripts/mysql_service.py
>  4716343 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py
>  151e26c 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode_upgrade.py
>  b55237d 
>   
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HIVE/package/scripts/mysql_service.py
>  11bbdd8 
>   
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HIVE/package/scripts/postgresql_service.py
>  cc7b4cc 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py 1c3c5b7 
> 
> 
> Diff: https://reviews.apache.org/r/58208/diff/3/
> 
> 
> Testing
> ---
> 
> mvn clean test 
> and test on live cluster
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 57945: Log Search Configuration API

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57945/#review171725
---


Ship it!




Ship It!

- Oliver Szabo


On April 12, 2017, 9:39 a.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57945/
> ---
> 
> (Updated April 12, 2017, 9:39 a.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-20578
> https://issues.apache.org/jira/browse/AMBARI-20578
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Log Search should store it's configurations (inputs, filters) by using an 
> API, which the user may implement as well to use their own way of storing the 
> configurations. By default for now we offer to store everything in ZooKeeper.
> 
> Also separated Log Feeder config handling from the main class.
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-config-api/.gitignore PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-config-api/pom.xml PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/InputConfigMonitor.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchConfig.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchConfigFactory.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigClass1.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigClass2.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigFactoryTest.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/NonLogSearchConfigClass.java
>  PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-config-api/src/test/resources/log4j.xml 
> PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-config-zookeeper/.gitignore PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-config-zookeeper/pom.xml PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/LogSearchConfigZK.java
>  PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-logfeeder/pom.xml 25e4306 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeeder.java
>  a47c71f 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/common/ConfigHandler.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputConfigUploader.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputManager.java
>  8e70850 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputSimulate.java
>  f93 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputManager.java
>  3c80e50 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputS3File.java
>  26f1ddb 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/LogFeederUtil.java
>  73cf449 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/SSLUtil.java
>  80b34e0 
>   ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/log4j.xml 
> 7ef967c 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/input/InputFileTest.java
>  08aa564 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/input/InputManagerTest.java
>  368a930 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/output/OutputManagerTest.java
>  0a0a195 
>   ambari-logsearch/ambari-logsearch-server/pom.xml 52bda8d 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/LogSearch.java
>  b75da0e 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/common/PropertiesHelper.java
>  73a43ad 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/global/LogSearchConfigState.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/

Re: Review Request 57945: Log Search Configuration API

[Miklos Gergely]

> On March 29, 2017, 3:50 p.m., Oliver Szabo wrote:
> > ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/ShipperConfigManager.java
> > Lines 71 (patched)
> > 
> >
> > as its a spring managed bean, it would be better to Create the Map and 
> > fill with some Pojo fields (like what you can find under 
> > org.apache.ambari.logsearch.conf package) with that we can skip the usage 
> > of properties helper as we want to get rid of it

Pojos will be created in another patch later.


- Miklos


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57945/#review170409
---


On April 12, 2017, 9:39 a.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57945/
> ---
> 
> (Updated April 12, 2017, 9:39 a.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-20578
> https://issues.apache.org/jira/browse/AMBARI-20578
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Log Search should store it's configurations (inputs, filters) by using an 
> API, which the user may implement as well to use their own way of storing the 
> configurations. By default for now we offer to store everything in ZooKeeper.
> 
> Also separated Log Feeder config handling from the main class.
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-config-api/.gitignore PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-config-api/pom.xml PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/InputConfigMonitor.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchConfig.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchConfigFactory.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigClass1.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigClass2.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigFactoryTest.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/NonLogSearchConfigClass.java
>  PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-config-api/src/test/resources/log4j.xml 
> PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-config-zookeeper/.gitignore PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-config-zookeeper/pom.xml PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/LogSearchConfigZK.java
>  PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-logfeeder/pom.xml 25e4306 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeeder.java
>  a47c71f 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/common/ConfigHandler.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputConfigUploader.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputManager.java
>  8e70850 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputSimulate.java
>  f93 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputManager.java
>  3c80e50 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputS3File.java
>  26f1ddb 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/LogFeederUtil.java
>  73cf449 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/SSLUtil.java
>  80b34e0 
>   ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/log4j.xml 
> 7ef967c 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/input/InputFileTest.java
>  08aa564 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/input/InputManagerTest.java
>  368a930 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/output/Outpu

Re: Review Request 58208: Wait For DataNodes To Shutdown During a Rolling Upgrade

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58208/
---

(Updated April 12, 2017, 3:57 p.m.)


Review request for Ambari, Jonathan Hurley and Nate Cole.


Changes
---

Fixed review comments


Bugs: AMBARI-20682
https://issues.apache.org/jira/browse/AMBARI-20682


Repository: ambari


Description
---

During a rolling upgrade (especially on a large, heavily used cluster), the 
DataNodes do not shutdown immediately. However, they do de-register from the 
NameNode which tricks Ambari into thinking that they are down.

Since the rolling upgrade uses a {{RESTART}} command, we attempt to start the 
DataNode back up before the daemon has shutdown:

{code}
2017-03-14 05:00:25,602 - call['/usr/hdp/current/hadoop-hdfs-datanode/bin/hdfs 
dfsadmin -fs hdfs://c1ha -shutdownDatanode 0.0.0.0:8010 upgrade'] {'user': 
'hdfs'}
2017-03-14 05:00:28,438 - call returned (0, 'Submitted a shutdown request to 
datanode 0.0.0.0:8010')
2017-03-14 05:00:28,438 - 
Execute['/usr/hdp/current/hadoop-hdfs-datanode/bin/hdfs dfsadmin -fs 
hdfs://c1ha -D ipc.client.connect.max.retries=5 -D 
ipc.client.connect.retry.interval=1000 -getDatanodeInfo 0.0.0.0:8010'] 
{'tries': 1, 'user': 'hdfs'}
2017-03-14 05:00:35,976 - DataNode has successfully shutdown for upgrade.
{code}

Even though ~ 6 seconds have passed, the daemon is still running as it drains. 
Therefore, we attempt to start it which causes a NOOP.

Instead, we should also monitor for the PID.

-
Now STOP command waits until component really dies. Motivation behind that is: 
we don't want to execute START of still running component again (e.g. during 
upgrade/RESTART)


Diffs (updated)
-

  ambari-common/src/main/python/resource_management/libraries/script/script.py 
9a5da04 
  
ambari-funtest/src/test/resources/stacks/HDP/2.0.7/services/HIVE/package/scripts/mysql_service.py
 4716343 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py
 151e26c 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode_upgrade.py
 b55237d 
  
ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HIVE/package/scripts/mysql_service.py
 11bbdd8 
  
ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HIVE/package/scripts/postgresql_service.py
 cc7b4cc 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py 1c3c5b7 


Diff: https://reviews.apache.org/r/58208/diff/3/

Changes: https://reviews.apache.org/r/58208/diff/2-3/


Testing
---

mvn clean test 
and test on live cluster


Thanks,

Dmitro Lisnichenko

Re: Review Request 58382: Need to disable upload file option from file browser window in workflow manager

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58382/#review171723
---


Ship it!




Ship It!

- Gaurav Nagar


On April 12, 2017, 12:41 p.m., venkat sairam wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58382/
> ---
> 
> (Updated April 12, 2017, 12:41 p.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, and 
> Rohit Choudhary.
> 
> 
> Bugs: AMBARI-20717
> https://issues.apache.org/jira/browse/AMBARI-20717
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Upload button have been disabled in import section.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-config.hbs
>  b674990 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs
>  3b1b6a9 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs
>  429e874 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/hdfs-browser.hbs
>  44f25c8 
> 
> 
> Diff: https://reviews.apache.org/r/58382/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing have been done
> 
> 
> Thanks,
> 
> venkat sairam
> 
>

Review Request 58387: Log Search common properties

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58387/
---

Review request for Ambari, Oliver Szabo and Robert Nettleton.


Bugs: AMBARI-20742
https://issues.apache.org/jira/browse/AMBARI-20742


Repository: ambari


Description
---

Allow specifying properties for both server and log feeder.


Diffs
-

  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-common-properties.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
 d00be4e 


Diff: https://reviews.apache.org/r/58387/diff/1/


Testing
---

Tested on local cluster.


Thanks,

Miklos Gergely

Re: Review Request 57451: The Installation of hbase-client failed

[zhangxiaolu zhangxiaolu]

> On 四月 11, 2017, 6:41 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py
> > Lines 67 (patched)
> > 
> >
> > I'm thinking more about this, what happens if Ambari Agent is running 
> > as non-root?
> > 
> > Perhaps we should instead 
> > 1. introduce Role Command Order rules to handle this scenario
> > OR
> > 2. look for a fix in HDFS Client so that it doesn't fail if hadoop conf 
> > dir doesn't exist.
> > 
> > I prefer option #2 since components should all be idempotent.
> > 
> > How frequently does this happen? Is it only during UI, or BP installs?
> 
> zhangxiaolu zhangxiaolu wrote:
> It happened frequently especially installing all services in first time?I 
> hasn't tested it in BP.

And i'm confused if tried again three times and it would passed when installing 
all services in first time.


- zhangxiaolu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57451/#review171602
---


On 四月 10, 2017, 7:37 a.m., zhangxiaolu zhangxiaolu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57451/
> ---
> 
> (Updated 四月 10, 2017, 7:37 a.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Jaimin Jetly, Srimanth Gunturi, Sid 
> Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-20368
> https://issues.apache.org/jira/browse/AMBARI-20368
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The problem is caused by the wrong installation order, which means 
> hbase-client will be installed before the installation of hdfs-client. Under 
> such circumstance, installation of hdfs-client will fail because the 
> hadoop-conf-dir does not exist. 
> Two solutions can be provided to solve this problem:
> 1. Creating the hadoop-conf-dir in hbase.py;
> 2. Setting correct installation order in role_command_order.json;
> Considering that hdfs-client may not beinstalled on the node especially when 
> adding new host, therefore, in my opinion, the second choice would be more 
> appropriate.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py
>  8ad802e 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_client.py 
> cffec06 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py 
> 42bc989 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py 
> 9bb0dd7 
>   
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_phoenix_queryserver.py 
> 60022e1 
> 
> 
> Diff: https://reviews.apache.org/r/57451/diff/5/
> 
> 
> Testing
> ---
> 
> done it
> 
> 
> File Attachments
> 
> 
> AMBARI-20368.patch
>   
> https://reviews.apache.org/media/uploaded/files/2017/04/07/e542fd73-b2b4-4542-94d2-151bbadd8b48__AMBARI-20368.patch
> 
> 
> Thanks,
> 
> zhangxiaolu zhangxiaolu
> 
>

Re: Review Request 58385: AMBARI-19149. Code cleanup: redundant modifiers (interfaces, enums)

[Sandor Magyari]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58385/#review171718
---


Ship it!




Ship It!

- Sandor Magyari


On April 12, 2017, 11:39 a.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58385/
> ---
> 
> (Updated April 12, 2017, 11:39 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Nate Cole, Sandor 
> Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19149
> https://issues.apache.org/jira/browse/AMBARI-19149
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> * Members of interfaces are always `public`.
>  * Constructors of enums are always `private`.
>  * Member interfaces and enums are implicitly `static`.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/annotations/TransactionalLock.java
>  a8b89a9e374ca35c7ae049aa5789d4c6a5f8bf1e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessor.java
>  b0550c01381e635ee90d58ab26030cb6fc89f56d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  0d1ef13c211a35b4107eea7c8e4eaf69bfde7557 
>   
> ambari-server/src/main/java/org/apache/ambari/server/alerts/AmbariPerformanceRunnable.java
>  8faa2a1ae04d9d04d2d8a54fb0cd80f1e285c2f8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/handlers/RequestHandler.java
>  9e2d92327ccd6888bace2a97d03bbbd5c9ba7981 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/predicate/expressions/Expression.java
>  206f2676cf57cb48b5ea0824c02a3fb17ed86106 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/predicate/operators/LogicalOperator.java
>  8881aadfc6555460fef33a3e7d056b3a4dc4549e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/predicate/operators/Operator.java
>  f9c3acce332b490c199e9e8879821c3e547c8d5c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/predicate/operators/RelationalOperator.java
>  cbcba0caaf27b1388e4429a5fa3c76162cd0018c 
>   ambari-server/src/main/java/org/apache/ambari/server/api/query/Query.java 
> 8ac38ac29a992d3ccdb7fa3a1d4e4668e06893f5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/query/render/Renderer.java
>  b71d96fffed15d7b6a4f0746efa976656929d8b9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstance.java
>  3695807a767f2b56a5895ffa6769c99491660a29 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactory.java
>  0b5859b251fa0bbed35a68d239dafdf85eda1be6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ResultPostProcessor.java
>  ab25bb21bcc3c8f56dff7cd2c20634b1ab65d809 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ResultStatus.java
>  6284879a02d8c73027e64eb62a1ee93287fc25d4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/parsers/RequestBodyParser.java
>  dc16b3e2e7b378c4a89341a61feab0bb2226b16b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/persistence/PersistenceManager.java
>  9a8b677e99f7bd5f3eaee7a0e2fb8698fae48d9c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorRequest.java
>  f5677c1a71c84f9caf96ec6d58bc6c9c73de6b8e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommandType.java
>  5aa1ea9d69871452b99c389af0cbc5c4c4d2c70e 
>   ambari-server/src/main/java/org/apache/ambari/server/api/util/TreeNode.java 
> 60d365ffc3e0f56272e52bfdf56f421caae9b30b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/UpgradeCheckGroup.java
>  67cf4f1a805ee58863a2d0f82886feb5b7750e00 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  a8bfbf0ddc4160591a07d8ccca6172b8afc7adbb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
>  91bfe09debd414fe63a365c15d8e94823495164d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java
>  d0005719a2b01c1c319782cd77b49a01b2454d5c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/MaintenanceStateHelper.java
>  f72f476d21466eaaae9dc1a6751490bdfc5ea2aa 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/gsinstaller/GSInstallerStateProvider.java
>  aef907c72f95495f9c9f8bbb199d989e841e1c8b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractResourceProvider.java
>  01cf79a521aef3922690477cfc076d4ab73197f9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/Arti

Re: Review Request 58385: AMBARI-19149. Code cleanup: redundant modifiers (interfaces, enums)

[Laszlo Puskas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58385/#review171717
---


Ship it!




Ship It!

- Laszlo Puskas


On April 12, 2017, 11:39 a.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58385/
> ---
> 
> (Updated April 12, 2017, 11:39 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Nate Cole, Sandor 
> Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19149
> https://issues.apache.org/jira/browse/AMBARI-19149
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> * Members of interfaces are always `public`.
>  * Constructors of enums are always `private`.
>  * Member interfaces and enums are implicitly `static`.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/annotations/TransactionalLock.java
>  a8b89a9e374ca35c7ae049aa5789d4c6a5f8bf1e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessor.java
>  b0550c01381e635ee90d58ab26030cb6fc89f56d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  0d1ef13c211a35b4107eea7c8e4eaf69bfde7557 
>   
> ambari-server/src/main/java/org/apache/ambari/server/alerts/AmbariPerformanceRunnable.java
>  8faa2a1ae04d9d04d2d8a54fb0cd80f1e285c2f8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/handlers/RequestHandler.java
>  9e2d92327ccd6888bace2a97d03bbbd5c9ba7981 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/predicate/expressions/Expression.java
>  206f2676cf57cb48b5ea0824c02a3fb17ed86106 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/predicate/operators/LogicalOperator.java
>  8881aadfc6555460fef33a3e7d056b3a4dc4549e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/predicate/operators/Operator.java
>  f9c3acce332b490c199e9e8879821c3e547c8d5c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/predicate/operators/RelationalOperator.java
>  cbcba0caaf27b1388e4429a5fa3c76162cd0018c 
>   ambari-server/src/main/java/org/apache/ambari/server/api/query/Query.java 
> 8ac38ac29a992d3ccdb7fa3a1d4e4668e06893f5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/query/render/Renderer.java
>  b71d96fffed15d7b6a4f0746efa976656929d8b9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstance.java
>  3695807a767f2b56a5895ffa6769c99491660a29 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactory.java
>  0b5859b251fa0bbed35a68d239dafdf85eda1be6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ResultPostProcessor.java
>  ab25bb21bcc3c8f56dff7cd2c20634b1ab65d809 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ResultStatus.java
>  6284879a02d8c73027e64eb62a1ee93287fc25d4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/parsers/RequestBodyParser.java
>  dc16b3e2e7b378c4a89341a61feab0bb2226b16b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/persistence/PersistenceManager.java
>  9a8b677e99f7bd5f3eaee7a0e2fb8698fae48d9c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorRequest.java
>  f5677c1a71c84f9caf96ec6d58bc6c9c73de6b8e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommandType.java
>  5aa1ea9d69871452b99c389af0cbc5c4c4d2c70e 
>   ambari-server/src/main/java/org/apache/ambari/server/api/util/TreeNode.java 
> 60d365ffc3e0f56272e52bfdf56f421caae9b30b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/UpgradeCheckGroup.java
>  67cf4f1a805ee58863a2d0f82886feb5b7750e00 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  a8bfbf0ddc4160591a07d8ccca6172b8afc7adbb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
>  91bfe09debd414fe63a365c15d8e94823495164d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java
>  d0005719a2b01c1c319782cd77b49a01b2454d5c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/MaintenanceStateHelper.java
>  f72f476d21466eaaae9dc1a6751490bdfc5ea2aa 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/gsinstaller/GSInstallerStateProvider.java
>  aef907c72f95495f9c9f8bbb199d989e841e1c8b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractResourceProvider.java
>  01cf79a521aef3922690477cfc076d4ab73197f9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/Artif

Re: Review Request 58384: Coordinator Actions(workflows) are empty even when workflows are executed.

[Padma Priya N]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58384/#review171716
---


Ship it!




Ship It!

- Padma Priya N


On April 12, 2017, 10:52 a.m., Madhan Reddy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58384/
> ---
> 
> (Updated April 12, 2017, 10:52 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, Pallav 
> Kulshreshtha, and venkat sairam.
> 
> 
> Bugs: AMBARI-20740
> https://issues.apache.org/jira/browse/AMBARI-20740
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added the api parameter(len 1000) to fetch all actions for a coordinator.
> 
> 
> Diffs
> -
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/routes/design/jobtab.js 
> 3fecbaa 
>   contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 3c5e720 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-job-details.hbs
>  b3f1097 
> 
> 
> Diff: https://reviews.apache.org/r/58384/diff/1/
> 
> 
> Testing
> ---
> 
> Manual
> 
> 
> Thanks,
> 
> Madhan Reddy
> 
>

Re: Review Request 58385: AMBARI-19149. Code cleanup: redundant modifiers (interfaces, enums)

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58385/#review171715
---


Ship it!




Ship It!

- Sebastian Toader


On April 12, 2017, 1:39 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58385/
> ---
> 
> (Updated April 12, 2017, 1:39 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Nate Cole, Sandor 
> Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19149
> https://issues.apache.org/jira/browse/AMBARI-19149
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> * Members of interfaces are always `public`.
>  * Constructors of enums are always `private`.
>  * Member interfaces and enums are implicitly `static`.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/annotations/TransactionalLock.java
>  a8b89a9e374ca35c7ae049aa5789d4c6a5f8bf1e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessor.java
>  b0550c01381e635ee90d58ab26030cb6fc89f56d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  0d1ef13c211a35b4107eea7c8e4eaf69bfde7557 
>   
> ambari-server/src/main/java/org/apache/ambari/server/alerts/AmbariPerformanceRunnable.java
>  8faa2a1ae04d9d04d2d8a54fb0cd80f1e285c2f8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/handlers/RequestHandler.java
>  9e2d92327ccd6888bace2a97d03bbbd5c9ba7981 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/predicate/expressions/Expression.java
>  206f2676cf57cb48b5ea0824c02a3fb17ed86106 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/predicate/operators/LogicalOperator.java
>  8881aadfc6555460fef33a3e7d056b3a4dc4549e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/predicate/operators/Operator.java
>  f9c3acce332b490c199e9e8879821c3e547c8d5c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/predicate/operators/RelationalOperator.java
>  cbcba0caaf27b1388e4429a5fa3c76162cd0018c 
>   ambari-server/src/main/java/org/apache/ambari/server/api/query/Query.java 
> 8ac38ac29a992d3ccdb7fa3a1d4e4668e06893f5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/query/render/Renderer.java
>  b71d96fffed15d7b6a4f0746efa976656929d8b9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstance.java
>  3695807a767f2b56a5895ffa6769c99491660a29 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactory.java
>  0b5859b251fa0bbed35a68d239dafdf85eda1be6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ResultPostProcessor.java
>  ab25bb21bcc3c8f56dff7cd2c20634b1ab65d809 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ResultStatus.java
>  6284879a02d8c73027e64eb62a1ee93287fc25d4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/parsers/RequestBodyParser.java
>  dc16b3e2e7b378c4a89341a61feab0bb2226b16b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/persistence/PersistenceManager.java
>  9a8b677e99f7bd5f3eaee7a0e2fb8698fae48d9c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorRequest.java
>  f5677c1a71c84f9caf96ec6d58bc6c9c73de6b8e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommandType.java
>  5aa1ea9d69871452b99c389af0cbc5c4c4d2c70e 
>   ambari-server/src/main/java/org/apache/ambari/server/api/util/TreeNode.java 
> 60d365ffc3e0f56272e52bfdf56f421caae9b30b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/UpgradeCheckGroup.java
>  67cf4f1a805ee58863a2d0f82886feb5b7750e00 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  a8bfbf0ddc4160591a07d8ccca6172b8afc7adbb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
>  91bfe09debd414fe63a365c15d8e94823495164d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java
>  d0005719a2b01c1c319782cd77b49a01b2454d5c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/MaintenanceStateHelper.java
>  f72f476d21466eaaae9dc1a6751490bdfc5ea2aa 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/gsinstaller/GSInstallerStateProvider.java
>  aef907c72f95495f9c9f8bbb199d989e841e1c8b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractResourceProvider.java
>  01cf79a521aef3922690477cfc076d4ab73197f9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/Arti

Re: Review Request 58383: AMBARI-20741. Hadoop QA should directly link to Maven output if build fails

[Laszlo Puskas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58383/#review171714
---


Ship it!




Ship It!

- Laszlo Puskas


On April 12, 2017, 10:04 a.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58383/
> ---
> 
> (Updated April 12, 2017, 10:04 a.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Laszlo Puskas, Sandor Magyari, Sumit 
> Mohanty, Sebastian Toader, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-20741
> https://issues.apache.org/jira/browse/AMBARI-20741
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added link for both pre-build and patched build.
> 
> 
> Diffs
> -
> 
>   dev-support/test-patch.sh 9b6d83e88e162516ed85aa8a6241bb3802bc1568 
> 
> 
> Diff: https://reviews.apache.org/r/58383/diff/1/
> 
> 
> Testing
> ---
> 
> Text-only change: tested text in JIRA comment preview.
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 58384: Coordinator Actions(workflows) are empty even when workflows are executed.

[belliraj hb]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58384/#review171713
---


Ship it!




Ship It!

- belliraj hb


On April 12, 2017, 10:52 a.m., Madhan Reddy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58384/
> ---
> 
> (Updated April 12, 2017, 10:52 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, Pallav 
> Kulshreshtha, and venkat sairam.
> 
> 
> Bugs: AMBARI-20740
> https://issues.apache.org/jira/browse/AMBARI-20740
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added the api parameter(len 1000) to fetch all actions for a coordinator.
> 
> 
> Diffs
> -
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/routes/design/jobtab.js 
> 3fecbaa 
>   contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 3c5e720 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-job-details.hbs
>  b3f1097 
> 
> 
> Diff: https://reviews.apache.org/r/58384/diff/1/
> 
> 
> Testing
> ---
> 
> Manual
> 
> 
> Thanks,
> 
> Madhan Reddy
> 
>

Re: Review Request 58382: Need to disable upload file option from file browser window in workflow manager

[belliraj hb]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58382/#review171712
---


Ship it!




Ship It!

- belliraj hb


On April 12, 2017, 9:17 a.m., venkat sairam wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58382/
> ---
> 
> (Updated April 12, 2017, 9:17 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Padma Priya N, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-20717
> https://issues.apache.org/jira/browse/AMBARI-20717
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Upload button have been disabled in import section.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-config.hbs
>  b674990 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs
>  3b1b6a9 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs
>  429e874 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/hdfs-browser.hbs
>  44f25c8 
> 
> 
> Diff: https://reviews.apache.org/r/58382/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing have been done
> 
> 
> Thanks,
> 
> venkat sairam
> 
>

Re: Review Request 58383: AMBARI-20741. Hadoop QA should directly link to Maven output if build fails

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58383/#review171711
---


Ship it!




Ship It!

- Sebastian Toader


On April 12, 2017, 12:04 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58383/
> ---
> 
> (Updated April 12, 2017, 12:04 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Laszlo Puskas, Sandor Magyari, Sumit 
> Mohanty, Sebastian Toader, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-20741
> https://issues.apache.org/jira/browse/AMBARI-20741
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added link for both pre-build and patched build.
> 
> 
> Diffs
> -
> 
>   dev-support/test-patch.sh 9b6d83e88e162516ed85aa8a6241bb3802bc1568 
> 
> 
> Diff: https://reviews.apache.org/r/58383/diff/1/
> 
> 
> Testing
> ---
> 
> Text-only change: tested text in JIRA comment preview.
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Review Request 58385: AMBARI-19149. Code cleanup: redundant modifiers (interfaces, enums)

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58385/
---

Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Nate Cole, Sandor 
Magyari, and Sebastian Toader.


Bugs: AMBARI-19149
https://issues.apache.org/jira/browse/AMBARI-19149


Repository: ambari


Description
---

* Members of interfaces are always `public`.
 * Constructors of enums are always `private`.
 * Member interfaces and enums are implicitly `static`.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/annotations/TransactionalLock.java
 a8b89a9e374ca35c7ae049aa5789d4c6a5f8bf1e 
  
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessor.java
 b0550c01381e635ee90d58ab26030cb6fc89f56d 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
 0d1ef13c211a35b4107eea7c8e4eaf69bfde7557 
  
ambari-server/src/main/java/org/apache/ambari/server/alerts/AmbariPerformanceRunnable.java
 8faa2a1ae04d9d04d2d8a54fb0cd80f1e285c2f8 
  
ambari-server/src/main/java/org/apache/ambari/server/api/handlers/RequestHandler.java
 9e2d92327ccd6888bace2a97d03bbbd5c9ba7981 
  
ambari-server/src/main/java/org/apache/ambari/server/api/predicate/expressions/Expression.java
 206f2676cf57cb48b5ea0824c02a3fb17ed86106 
  
ambari-server/src/main/java/org/apache/ambari/server/api/predicate/operators/LogicalOperator.java
 8881aadfc6555460fef33a3e7d056b3a4dc4549e 
  
ambari-server/src/main/java/org/apache/ambari/server/api/predicate/operators/Operator.java
 f9c3acce332b490c199e9e8879821c3e547c8d5c 
  
ambari-server/src/main/java/org/apache/ambari/server/api/predicate/operators/RelationalOperator.java
 cbcba0caaf27b1388e4429a5fa3c76162cd0018c 
  ambari-server/src/main/java/org/apache/ambari/server/api/query/Query.java 
8ac38ac29a992d3ccdb7fa3a1d4e4668e06893f5 
  
ambari-server/src/main/java/org/apache/ambari/server/api/query/render/Renderer.java
 b71d96fffed15d7b6a4f0746efa976656929d8b9 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstance.java
 3695807a767f2b56a5895ffa6769c99491660a29 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactory.java
 0b5859b251fa0bbed35a68d239dafdf85eda1be6 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ResultPostProcessor.java
 ab25bb21bcc3c8f56dff7cd2c20634b1ab65d809 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ResultStatus.java
 6284879a02d8c73027e64eb62a1ee93287fc25d4 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/parsers/RequestBodyParser.java
 dc16b3e2e7b378c4a89341a61feab0bb2226b16b 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/persistence/PersistenceManager.java
 9a8b677e99f7bd5f3eaee7a0e2fb8698fae48d9c 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorRequest.java
 f5677c1a71c84f9caf96ec6d58bc6c9c73de6b8e 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommandType.java
 5aa1ea9d69871452b99c389af0cbc5c4c4d2c70e 
  ambari-server/src/main/java/org/apache/ambari/server/api/util/TreeNode.java 
60d365ffc3e0f56272e52bfdf56f421caae9b30b 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/UpgradeCheckGroup.java
 67cf4f1a805ee58863a2d0f82886feb5b7750e00 
  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 a8bfbf0ddc4160591a07d8ccca6172b8afc7adbb 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
 91bfe09debd414fe63a365c15d8e94823495164d 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java
 d0005719a2b01c1c319782cd77b49a01b2454d5c 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/MaintenanceStateHelper.java
 f72f476d21466eaaae9dc1a6751490bdfc5ea2aa 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/gsinstaller/GSInstallerStateProvider.java
 aef907c72f95495f9c9f8bbb199d989e841e1c8b 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractResourceProvider.java
 01cf79a521aef3922690477cfc076d4ab73197f9 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ArtifactResourceProvider.java
 a6a731c2714b3ada1b28031dd4940e49b660f595 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
 88a8f808bb66c2f48a65f0f36f2a96592fdc99e4 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/JobResourceProvider.java
 2c5741f2542d24da797ef6db9242ae23490b0ea9 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ObservableResourceProvider.java
 c0c1dc483d5f9c7345a15af21fb610bb2a15d838 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/inter

Re: Review Request 57709: Yarn Queue manager capacity field allows entering invalid values

[DIPAYAN BHOWMICK]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57709/#review171710
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On April 5, 2017, 9:43 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57709/
> ---
> 
> (Updated April 5, 2017, 9:43 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, belliraj hb, Di Li, DIPAYAN 
> BHOWMICK, Jaimin Jetly, Richard Zang, and Sangeeta Ravindran.
> 
> 
> Bugs: AMBARI-20334
> https://issues.apache.org/jira/browse/AMBARI-20334
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> capacity field in yarn queue manager should allow entering decimal numbers 
> upto 2 places,
> 
> currently the field allows entering values like
> 
> 1.2.3
> 12...
> 1 2.3
> 
> 
> Diffs
> -
> 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/capacityInput.js
>  b6c419a 
> 
> 
> Diff: https://reviews.apache.org/r/57709/diff/2/
> 
> 
> Testing
> ---
> 
> Tested manually
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 58384: Coordinator Actions(workflows) are empty even when workflows are executed.

[venkat sairam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58384/#review171705
---


Ship it!




Ship It!

- venkat sairam


On April 12, 2017, 10:52 a.m., Madhan Reddy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58384/
> ---
> 
> (Updated April 12, 2017, 10:52 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, Pallav 
> Kulshreshtha, and venkat sairam.
> 
> 
> Bugs: AMBARI-20740
> https://issues.apache.org/jira/browse/AMBARI-20740
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added the api parameter(len 1000) to fetch all actions for a coordinator.
> 
> 
> Diffs
> -
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/routes/design/jobtab.js 
> 3fecbaa 
>   contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 3c5e720 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-job-details.hbs
>  b3f1097 
> 
> 
> Diff: https://reviews.apache.org/r/58384/diff/1/
> 
> 
> Testing
> ---
> 
> Manual
> 
> 
> Thanks,
> 
> Madhan Reddy
> 
>

Review Request 58384: Coordinator Actions(workflows) are empty even when workflows are executed.

[Madhan Reddy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58384/
---

Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, Pallav 
Kulshreshtha, and venkat sairam.


Bugs: AMBARI-20740
https://issues.apache.org/jira/browse/AMBARI-20740


Repository: ambari


Description
---

Added the api parameter(len 1000) to fetch all actions for a coordinator.


Diffs
-

  contrib/views/wfmanager/src/main/resources/ui/app/routes/design/jobtab.js 
3fecbaa 
  contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 3c5e720 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-job-details.hbs
 b3f1097 


Diff: https://reviews.apache.org/r/58384/diff/1/


Testing
---

Manual


Thanks,

Madhan Reddy

Review Request 58383: AMBARI-20741. Hadoop QA should directly link to Maven output if build fails

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58383/
---

Review request for Ambari, Jaimin Jetly, Laszlo Puskas, Sandor Magyari, Sumit 
Mohanty, Sebastian Toader, and Yusaku Sako.


Bugs: AMBARI-20741
https://issues.apache.org/jira/browse/AMBARI-20741


Repository: ambari


Description
---

Added link for both pre-build and patched build.


Diffs
-

  dev-support/test-patch.sh 9b6d83e88e162516ed85aa8a6241bb3802bc1568 


Diff: https://reviews.apache.org/r/58383/diff/1/


Testing
---

Text-only change: tested text in JIRA comment preview.


Thanks,

Attila Doroszlai

Re: Review Request 57945: Log Search Configuration API

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57945/
---

(Updated April 12, 2017, 9:39 a.m.)


Review request for Ambari, Oliver Szabo and Robert Nettleton.


Changes
---

Do not overwrite acls set in a custom property


Bugs: AMBARI-20578
https://issues.apache.org/jira/browse/AMBARI-20578


Repository: ambari


Description
---

Log Search should store it's configurations (inputs, filters) by using an API, 
which the user may implement as well to use their own way of storing the 
configurations. By default for now we offer to store everything in ZooKeeper.

Also separated Log Feeder config handling from the main class.


Diffs (updated)
-

  ambari-logsearch/ambari-logsearch-config-api/.gitignore PRE-CREATION 
  ambari-logsearch/ambari-logsearch-config-api/pom.xml PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/InputConfigMonitor.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchConfig.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchConfigFactory.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigClass1.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigClass2.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigFactoryTest.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/NonLogSearchConfigClass.java
 PRE-CREATION 
  ambari-logsearch/ambari-logsearch-config-api/src/test/resources/log4j.xml 
PRE-CREATION 
  ambari-logsearch/ambari-logsearch-config-zookeeper/.gitignore PRE-CREATION 
  ambari-logsearch/ambari-logsearch-config-zookeeper/pom.xml PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/LogSearchConfigZK.java
 PRE-CREATION 
  ambari-logsearch/ambari-logsearch-logfeeder/pom.xml 25e4306 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeeder.java
 a47c71f 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/common/ConfigHandler.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputConfigUploader.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputManager.java
 8e70850 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputSimulate.java
 f93 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputManager.java
 3c80e50 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputS3File.java
 26f1ddb 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/LogFeederUtil.java
 73cf449 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/SSLUtil.java
 80b34e0 
  ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/log4j.xml 
7ef967c 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/input/InputFileTest.java
 08aa564 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/input/InputManagerTest.java
 368a930 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/output/OutputManagerTest.java
 0a0a195 
  ambari-logsearch/ambari-logsearch-server/pom.xml 52bda8d 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/LogSearch.java
 b75da0e 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/common/PropertiesHelper.java
 73a43ad 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/global/LogSearchConfigState.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/configurer/Configurer.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/configurer/LogSearchConfigConfigurer.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/configurer/LogfeederFilterConfigurer.java
 34e1bec 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/configurer/SolrAuditAliasConfigurer.java
 c80a10d 
  
ambari-logs

Re: Review Request 57451: The Installation of hbase-client failed

[zhangxiaolu zhangxiaolu]

> On 四月 11, 2017, 6:41 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py
> > Lines 67 (patched)
> > 
> >
> > I'm thinking more about this, what happens if Ambari Agent is running 
> > as non-root?
> > 
> > Perhaps we should instead 
> > 1. introduce Role Command Order rules to handle this scenario
> > OR
> > 2. look for a fix in HDFS Client so that it doesn't fail if hadoop conf 
> > dir doesn't exist.
> > 
> > I prefer option #2 since components should all be idempotent.
> > 
> > How frequently does this happen? Is it only during UI, or BP installs?

It happened frequently especially installing all services in first time?I 
hasn't tested it in BP.


- zhangxiaolu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57451/#review171602
---


On 四月 10, 2017, 7:37 a.m., zhangxiaolu zhangxiaolu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57451/
> ---
> 
> (Updated 四月 10, 2017, 7:37 a.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Jaimin Jetly, Srimanth Gunturi, Sid 
> Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-20368
> https://issues.apache.org/jira/browse/AMBARI-20368
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The problem is caused by the wrong installation order, which means 
> hbase-client will be installed before the installation of hdfs-client. Under 
> such circumstance, installation of hdfs-client will fail because the 
> hadoop-conf-dir does not exist. 
> Two solutions can be provided to solve this problem:
> 1. Creating the hadoop-conf-dir in hbase.py;
> 2. Setting correct installation order in role_command_order.json;
> Considering that hdfs-client may not beinstalled on the node especially when 
> adding new host, therefore, in my opinion, the second choice would be more 
> appropriate.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py
>  8ad802e 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_client.py 
> cffec06 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py 
> 42bc989 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py 
> 9bb0dd7 
>   
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_phoenix_queryserver.py 
> 60022e1 
> 
> 
> Diff: https://reviews.apache.org/r/57451/diff/5/
> 
> 
> Testing
> ---
> 
> done it
> 
> 
> File Attachments
> 
> 
> AMBARI-20368.patch
>   
> https://reviews.apache.org/media/uploaded/files/2017/04/07/e542fd73-b2b4-4542-94d2-151bbadd8b48__AMBARI-20368.patch
> 
> 
> Thanks,
> 
> zhangxiaolu zhangxiaolu
> 
>

Review Request 58382: Need to disable upload file option from file browser window in workflow manager

[venkat sairam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58382/
---

Review request for Ambari, belliraj hb, Padma Priya N, and Rohit Choudhary.


Bugs: AMBARI-20717
https://issues.apache.org/jira/browse/AMBARI-20717


Repository: ambari


Description
---

Upload button have been disabled in import section.


Diffs
-

  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-config.hbs
 b674990 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs
 3b1b6a9 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs
 429e874 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/hdfs-browser.hbs
 44f25c8 


Diff: https://reviews.apache.org/r/58382/diff/1/


Testing
---

Manual testing have been done


Thanks,

venkat sairam

Re: Review Request 58354: Handle caching of topologies, configs and metadata

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58354/#review171694
---




ambari-agent/src/main/python/ambari_agent/security.py
Line 104 (original), 104 (patched)


a test class which will be replace soon. By the one working with server. 
Not adding doc to it.


- Andrew Onischuk


On April 12, 2017, 9:09 a.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58354/
> ---
> 
> (Updated April 12, 2017, 9:09 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and 
> Sid Wagle.
> 
> 
> Bugs: AMBARI-20734
> https://issues.apache.org/jira/browse/AMBARI-20734
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> .
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/ClusterCache.py 1986733 
>   ambari-agent/src/main/python/ambari_agent/ClusterConfigurationCache.py 
> 61fdf94 
>   ambari-agent/src/main/python/ambari_agent/ClusterMetadataCache.py 4859b3f 
>   ambari-agent/src/main/python/ambari_agent/ClusterTopologyCache.py 19313c5 
>   ambari-agent/src/main/python/ambari_agent/Constants.py 0ff9eb9 
>   ambari-agent/src/main/python/ambari_agent/Controller.py 4d81947 
>   ambari-agent/src/main/python/ambari_agent/HeartbeatThread.py 2c2f9d8 
>   
> ambari-agent/src/main/python/ambari_agent/listeners/ConfigurationEventListener.py
>  PRE-CREATION 
>   
> ambari-agent/src/main/python/ambari_agent/listeners/MetadataEventListener.py 
> PRE-CREATION 
>   
> ambari-agent/src/main/python/ambari_agent/listeners/ServerResponsesListener.py
>  c7ad082 
>   
> ambari-agent/src/main/python/ambari_agent/listeners/TopologyEventListener.py 
> 44afc48 
>   ambari-agent/src/main/python/ambari_agent/listeners/__init__.py 8cfcc3f 
>   ambari-agent/src/main/python/ambari_agent/security.py 32ad556 
>   ambari-agent/src/test/python/ambari_agent/TestAgentStompResponses.py 
> b0f3a16 
>   
> ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/metadata_after_registration.json
>  PRE-CREATION 
>   
> ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/registration_response.json
>  779f139 
> 
> 
> Diff: https://reviews.apache.org/r/58354/diff/4/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 58354: Handle caching of topologies, configs and metadata

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58354/
---

(Updated April 12, 2017, 9:09 a.m.)


Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and Sid 
Wagle.


Bugs: AMBARI-20734
https://issues.apache.org/jira/browse/AMBARI-20734


Repository: ambari


Description
---

.


Diffs (updated)
-

  ambari-agent/src/main/python/ambari_agent/ClusterCache.py 1986733 
  ambari-agent/src/main/python/ambari_agent/ClusterConfigurationCache.py 
61fdf94 
  ambari-agent/src/main/python/ambari_agent/ClusterMetadataCache.py 4859b3f 
  ambari-agent/src/main/python/ambari_agent/ClusterTopologyCache.py 19313c5 
  ambari-agent/src/main/python/ambari_agent/Constants.py 0ff9eb9 
  ambari-agent/src/main/python/ambari_agent/Controller.py 4d81947 
  ambari-agent/src/main/python/ambari_agent/HeartbeatThread.py 2c2f9d8 
  
ambari-agent/src/main/python/ambari_agent/listeners/ConfigurationEventListener.py
 PRE-CREATION 
  ambari-agent/src/main/python/ambari_agent/listeners/MetadataEventListener.py 
PRE-CREATION 
  
ambari-agent/src/main/python/ambari_agent/listeners/ServerResponsesListener.py 
c7ad082 
  ambari-agent/src/main/python/ambari_agent/listeners/TopologyEventListener.py 
44afc48 
  ambari-agent/src/main/python/ambari_agent/listeners/__init__.py 8cfcc3f 
  ambari-agent/src/main/python/ambari_agent/security.py 32ad556 
  ambari-agent/src/test/python/ambari_agent/TestAgentStompResponses.py b0f3a16 
  
ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/metadata_after_registration.json
 PRE-CREATION 
  
ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/registration_response.json
 779f139 


Diff: https://reviews.apache.org/r/58354/diff/4/

Changes: https://reviews.apache.org/r/58354/diff/3-4/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 58354: Handle caching of topologies, configs and metadata

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58354/
---

(Updated April 12, 2017, 9:09 a.m.)


Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and Sid 
Wagle.


Bugs: AMBARI-20734
https://issues.apache.org/jira/browse/AMBARI-20734


Repository: ambari


Description
---

.


Diffs (updated)
-

  ambari-agent/src/main/python/ambari_agent/ClusterCache.py 1986733 
  ambari-agent/src/main/python/ambari_agent/ClusterConfigurationCache.py 
61fdf94 
  ambari-agent/src/main/python/ambari_agent/ClusterMetadataCache.py 4859b3f 
  ambari-agent/src/main/python/ambari_agent/ClusterTopologyCache.py 19313c5 
  ambari-agent/src/main/python/ambari_agent/Constants.py 0ff9eb9 
  ambari-agent/src/main/python/ambari_agent/Controller.py 4d81947 
  ambari-agent/src/main/python/ambari_agent/HeartbeatThread.py 2c2f9d8 
  
ambari-agent/src/main/python/ambari_agent/listeners/ConfigurationEventListener.py
 PRE-CREATION 
  ambari-agent/src/main/python/ambari_agent/listeners/MetadataEventListener.py 
PRE-CREATION 
  
ambari-agent/src/main/python/ambari_agent/listeners/ServerResponsesListener.py 
c7ad082 
  ambari-agent/src/main/python/ambari_agent/listeners/TopologyEventListener.py 
44afc48 
  ambari-agent/src/main/python/ambari_agent/listeners/__init__.py 8cfcc3f 
  ambari-agent/src/main/python/ambari_agent/security.py 32ad556 
  ambari-agent/src/test/python/ambari_agent/TestAgentStompResponses.py b0f3a16 
  
ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/metadata_after_registration.json
 PRE-CREATION 
  
ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/registration_response.json
 779f139 


Diff: https://reviews.apache.org/r/58354/diff/3/

Changes: https://reviews.apache.org/r/58354/diff/2-3/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 58297: Add stab registering and heartbeating routine via stomp async calls.

[Andrew Onischuk]

> On April 11, 2017, 6:42 p.m., Alejandro Fernandez wrote:
> > ambari-agent/src/main/python/ambari_agent/HeartbeatThread.py
> > Lines 48 (patched)
> > 
> >
> > Generally, add documentation to all classes and functions.

added in another patch


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58297/#review171604
---


On April 11, 2017, 10:57 a.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58297/
> ---
> 
> (Updated April 11, 2017, 10:57 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and 
> Sid Wagle.
> 
> 
> Bugs: AMBARI-20721
> https://issues.apache.org/jira/browse/AMBARI-20721
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> As for registering and heartbeat we still require synchronious behaviour on 
> agent side. This requires a dictionary with blocking pop with correlationId 
> as keys.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/Constants.py 6b80f00 
>   ambari-agent/src/main/python/ambari_agent/HeartbeatThread.py PRE-CREATION 
>   ambari-agent/src/main/python/ambari_agent/Utils.py e7b03f9 
>   
> ambari-agent/src/main/python/ambari_agent/listeners/ServerResponsesListener.py
>  PRE-CREATION 
>   
> ambari-agent/src/main/python/ambari_agent/listeners/TopologyEventListener.py 
> PRE-CREATION 
>   ambari-agent/src/main/python/ambari_agent/listeners/__init__.py 
> PRE-CREATION 
>   ambari-agent/src/main/python/ambari_agent/security.py 45de7bb 
>   ambari-agent/src/test/python/ambari_agent/TestAgentStompResponses.py 
> 983b392 
>   
> ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/heartbeat_request.json
>  PRE-CREATION 
>   ambari-common/src/test/python/coilmq/server/socket_server.py b4f081e 
> 
> 
> Diff: https://reviews.apache.org/r/58297/diff/3/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 57945: Log Search Configuration API

[Miklos Gergely]

> On April 10, 2017, 7:51 p.m., Oliver Szabo wrote:
> > ambari-logsearch/ambari-logsearch-config-zookeeper/pom.xml
> > Lines 52 (patched)
> > 
> >
> > not really an issue but compile is the default scope so its not needed.
> > also maybe you do not need to include version as well in case of 
> > ambari-project has this dependency. if not its okay to include the version 
> > (maybe we should check this with other dependencies as well)

None of the dependencies of these new projects have a parent in the 
ambari-project


- Miklos


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57945/#review171466
---


On April 11, 2017, 3:18 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57945/
> ---
> 
> (Updated April 11, 2017, 3:18 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-20578
> https://issues.apache.org/jira/browse/AMBARI-20578
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Log Search should store it's configurations (inputs, filters) by using an 
> API, which the user may implement as well to use their own way of storing the 
> configurations. By default for now we offer to store everything in ZooKeeper.
> 
> Also separated Log Feeder config handling from the main class.
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-config-api/.gitignore PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-config-api/pom.xml PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/InputConfigMonitor.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchConfig.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchConfigFactory.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigClass1.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigClass2.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigFactoryTest.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/NonLogSearchConfigClass.java
>  PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-config-api/src/test/resources/log4j.xml 
> PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-config-zookeeper/.gitignore PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-config-zookeeper/pom.xml PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/LogSearchConfigZK.java
>  PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-logfeeder/pom.xml 25e4306 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeeder.java
>  a47c71f 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/common/ConfigHandler.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputConfigUploader.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputManager.java
>  8e70850 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputSimulate.java
>  f93 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputManager.java
>  3c80e50 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputS3File.java
>  26f1ddb 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/LogFeederUtil.java
>  73cf449 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/SSLUtil.java
>  80b34e0 
>   ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/log4j.xml 
> 7ef967c 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/input/InputFileTest.java
>  08aa564 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/input/InputManagerTest.java
>  368a930 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/outpu

Re: Review Request 58208: Wait For DataNodes To Shutdown During a Rolling Upgrade

[Dmitro Lisnichenko]

> On April 11, 2017, 10:18 p.m., Jonathan Hurley wrote:
> > ambari-funtest/src/test/resources/stacks/HDP/2.0.7/services/HIVE/package/scripts/mysql_service.py
> > Lines 34-41 (original), 34-45 (patched)
> > 
> >
> > When executing the status command, won't this run it twice if mysql is 
> > running?

looks like you are right


- Dmitro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58208/#review171616
---


On April 11, 2017, 6:22 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58208/
> ---
> 
> (Updated April 11, 2017, 6:22 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-20682
> https://issues.apache.org/jira/browse/AMBARI-20682
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> During a rolling upgrade (especially on a large, heavily used cluster), the 
> DataNodes do not shutdown immediately. However, they do de-register from the 
> NameNode which tricks Ambari into thinking that they are down.
> 
> Since the rolling upgrade uses a {{RESTART}} command, we attempt to start the 
> DataNode back up before the daemon has shutdown:
> 
> {code}
> 2017-03-14 05:00:25,602 - 
> call['/usr/hdp/current/hadoop-hdfs-datanode/bin/hdfs dfsadmin -fs hdfs://c1ha 
> -shutdownDatanode 0.0.0.0:8010 upgrade'] {'user': 'hdfs'}
> 2017-03-14 05:00:28,438 - call returned (0, 'Submitted a shutdown request to 
> datanode 0.0.0.0:8010')
> 2017-03-14 05:00:28,438 - 
> Execute['/usr/hdp/current/hadoop-hdfs-datanode/bin/hdfs dfsadmin -fs 
> hdfs://c1ha -D ipc.client.connect.max.retries=5 -D 
> ipc.client.connect.retry.interval=1000 -getDatanodeInfo 0.0.0.0:8010'] 
> {'tries': 1, 'user': 'hdfs'}
> 2017-03-14 05:00:35,976 - DataNode has successfully shutdown for upgrade.
> {code}
> 
> Even though ~ 6 seconds have passed, the daemon is still running as it 
> drains. Therefore, we attempt to start it which causes a NOOP.
> 
> Instead, we should also monitor for the PID.
> 
> -
> Now STOP command waits until component really dies. Motivation behind that 
> is: we don't want to execute START of still running component again (e.g. 
> during upgrade/RESTART)
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> 9a5da04278 
>   
> ambari-funtest/src/test/resources/stacks/HDP/2.0.7/services/HIVE/package/scripts/mysql_service.py
>  4716343fb2 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py
>  151e26cace 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode_upgrade.py
>  b55237dd1f 
>   
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HIVE/package/scripts/mysql_service.py
>  11bbdd8e6b 
>   
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HIVE/package/scripts/postgresql_service.py
>  cc7b4cc14e 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py 1c3c5b7932 
> 
> 
> Diff: https://reviews.apache.org/r/58208/diff/2/
> 
> 
> Testing
> ---
> 
> mvn clean test 
> and test on live cluster
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 58208: Wait For DataNodes To Shutdown During a Rolling Upgrade

[Dmitro Lisnichenko]

> On April 11, 2017, 10:18 p.m., Jonathan Hurley wrote:
> > ambari-common/src/main/python/resource_management/libraries/script/script.py
> > Lines 357 (patched)
> > 
> >
> > Is counter < 1000 easier to read?

this condition is true every 100 iterations (it's a remainder after division by 
100)


- Dmitro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58208/#review171616
---


On April 11, 2017, 6:22 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58208/
> ---
> 
> (Updated April 11, 2017, 6:22 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-20682
> https://issues.apache.org/jira/browse/AMBARI-20682
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> During a rolling upgrade (especially on a large, heavily used cluster), the 
> DataNodes do not shutdown immediately. However, they do de-register from the 
> NameNode which tricks Ambari into thinking that they are down.
> 
> Since the rolling upgrade uses a {{RESTART}} command, we attempt to start the 
> DataNode back up before the daemon has shutdown:
> 
> {code}
> 2017-03-14 05:00:25,602 - 
> call['/usr/hdp/current/hadoop-hdfs-datanode/bin/hdfs dfsadmin -fs hdfs://c1ha 
> -shutdownDatanode 0.0.0.0:8010 upgrade'] {'user': 'hdfs'}
> 2017-03-14 05:00:28,438 - call returned (0, 'Submitted a shutdown request to 
> datanode 0.0.0.0:8010')
> 2017-03-14 05:00:28,438 - 
> Execute['/usr/hdp/current/hadoop-hdfs-datanode/bin/hdfs dfsadmin -fs 
> hdfs://c1ha -D ipc.client.connect.max.retries=5 -D 
> ipc.client.connect.retry.interval=1000 -getDatanodeInfo 0.0.0.0:8010'] 
> {'tries': 1, 'user': 'hdfs'}
> 2017-03-14 05:00:35,976 - DataNode has successfully shutdown for upgrade.
> {code}
> 
> Even though ~ 6 seconds have passed, the daemon is still running as it 
> drains. Therefore, we attempt to start it which causes a NOOP.
> 
> Instead, we should also monitor for the PID.
> 
> -
> Now STOP command waits until component really dies. Motivation behind that 
> is: we don't want to execute START of still running component again (e.g. 
> during upgrade/RESTART)
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> 9a5da04278 
>   
> ambari-funtest/src/test/resources/stacks/HDP/2.0.7/services/HIVE/package/scripts/mysql_service.py
>  4716343fb2 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py
>  151e26cace 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode_upgrade.py
>  b55237dd1f 
>   
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HIVE/package/scripts/mysql_service.py
>  11bbdd8e6b 
>   
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HIVE/package/scripts/postgresql_service.py
>  cc7b4cc14e 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py 1c3c5b7932 
> 
> 
> Diff: https://reviews.apache.org/r/58208/diff/2/
> 
> 
> Testing
> ---
> 
> mvn clean test 
> and test on live cluster
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 58208: Wait For DataNodes To Shutdown During a Rolling Upgrade

[Dmitro Lisnichenko]

> On April 11, 2017, 9:20 p.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/resource_management/libraries/script/script.py
> > Lines 355 (patched)
> > 
> >
> > Should we have a hard limit, if more than say 5 mins, then abort so we 
> > can avoid an infinite loop.

we still have a STOP command timeout limit. Not sure that adding yet another 
hardcoded timeout is applicable for all cases. Also it would require to fail 
entire STOP command instead of marking it as timed out.


- Dmitro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58208/#review171595
---


On April 11, 2017, 6:22 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58208/
> ---
> 
> (Updated April 11, 2017, 6:22 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-20682
> https://issues.apache.org/jira/browse/AMBARI-20682
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> During a rolling upgrade (especially on a large, heavily used cluster), the 
> DataNodes do not shutdown immediately. However, they do de-register from the 
> NameNode which tricks Ambari into thinking that they are down.
> 
> Since the rolling upgrade uses a {{RESTART}} command, we attempt to start the 
> DataNode back up before the daemon has shutdown:
> 
> {code}
> 2017-03-14 05:00:25,602 - 
> call['/usr/hdp/current/hadoop-hdfs-datanode/bin/hdfs dfsadmin -fs hdfs://c1ha 
> -shutdownDatanode 0.0.0.0:8010 upgrade'] {'user': 'hdfs'}
> 2017-03-14 05:00:28,438 - call returned (0, 'Submitted a shutdown request to 
> datanode 0.0.0.0:8010')
> 2017-03-14 05:00:28,438 - 
> Execute['/usr/hdp/current/hadoop-hdfs-datanode/bin/hdfs dfsadmin -fs 
> hdfs://c1ha -D ipc.client.connect.max.retries=5 -D 
> ipc.client.connect.retry.interval=1000 -getDatanodeInfo 0.0.0.0:8010'] 
> {'tries': 1, 'user': 'hdfs'}
> 2017-03-14 05:00:35,976 - DataNode has successfully shutdown for upgrade.
> {code}
> 
> Even though ~ 6 seconds have passed, the daemon is still running as it 
> drains. Therefore, we attempt to start it which causes a NOOP.
> 
> Instead, we should also monitor for the PID.
> 
> -
> Now STOP command waits until component really dies. Motivation behind that 
> is: we don't want to execute START of still running component again (e.g. 
> during upgrade/RESTART)
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> 9a5da04278 
>   
> ambari-funtest/src/test/resources/stacks/HDP/2.0.7/services/HIVE/package/scripts/mysql_service.py
>  4716343fb2 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py
>  151e26cace 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode_upgrade.py
>  b55237dd1f 
>   
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HIVE/package/scripts/mysql_service.py
>  11bbdd8e6b 
>   
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HIVE/package/scripts/postgresql_service.py
>  cc7b4cc14e 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py 1c3c5b7932 
> 
> 
> Diff: https://reviews.apache.org/r/58208/diff/2/
> 
> 
> Testing
> ---
> 
> mvn clean test 
> and test on live cluster
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>