date:20170421


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58634/
---

(Updated April 21, 2017, 11:34 p.m.)


Review request for Ambari, Sumit Mohanty, Swapan Shridhar, Sid Wagle, and 
Vitalyi Brodetskyi.


Bugs: AMBARI-20326
https://issues.apache.org/jira/browse/AMBARI-20326


Repository: ambari


Description
---

HDP 3.0 support for Hbase with configs, kerberos, widgets, metrics, quicklinks, 
and themes.'

Flatten from HDP 2.0.6 - 2.6 into common-services, and reference in HDP 3.0.

In HDP 3.0, we have created a new stack definition that does not inherit from 
other stacks, in order to reduce the complexity of having to analyze older 
stacks.

This means that we need to create a service definition (metainfo.xml, configs, 
kerberos, widgets, metrics, quicklinks, and themes) that is equivalent to what 
is inherit and deleted from all of the previous stacks.

A merge needs to account for additions, overrides, and deletions.
metainfo.xml and configs perform a merge of older versions
kerberos.json always seems to override the previous file
Because the bits for this service may not yet be available in the HDP 3.0 repo, 
the task is to ensure that /api/v1/stacks/HDP/versions/2.6/services/HBASE(which 
uses inheritance) is equivalent to the flattening of 
/api/v1/stacks/HDP/versions/3.0/services/HBASE .


Diffs (updated)
-

  ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/alerts.json 
PRE-CREATION 
  
ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/configuration/hbase-env.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/configuration/hbase-log4j.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/configuration/hbase-policy.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/configuration/hbase-site.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/configuration/ranger-hbase-audit.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/configuration/ranger-hbase-plugin-properties.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/configuration/ranger-hbase-policymgr-ssl.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/configuration/ranger-hbase-security.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/kerberos.json 
PRE-CREATION 
  ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/metainfo.xml 
PRE-CREATION 
  ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/metrics.json 
PRE-CREATION 
  
ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/files/draining_servers.rb
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/files/hbase-smoke-cleanup.sh
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/files/hbaseSmokeVerify.sh
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/scripts/__init__.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/scripts/functions.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/scripts/hbase.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/scripts/hbase_client.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/scripts/hbase_decommission.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/scripts/hbase_master.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/scripts/hbase_regionserver.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/scripts/hbase_service.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/scripts/hbase_upgrade.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/scripts/params.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/scripts/params_linux.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/scripts/params_windows.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/scripts/phoenix_queryserver.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/scripts/phoenix_service.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/scripts/service_check.py
 PRE-CREATION

Re: Review Request 58634: HDP 3.0 support for HBase with configs, kerberos, widgets, metrics, quicklinks, and themes

2017-04-21 Thread Swapan Shridhar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58634/#review172718
---


Ship it!




Ship It!

- Swapan Shridhar


On April 21, 2017, 9:41 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58634/
> ---
> 
> (Updated April 21, 2017, 9:41 p.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty, Swapan Shridhar, Sid Wagle, and 
> Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-20326
> https://issues.apache.org/jira/browse/AMBARI-20326
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HDP 3.0 support for Hbase with configs, kerberos, widgets, metrics, 
> quicklinks, and themes.'
> 
> Flatten from HDP 2.0.6 - 2.6 into common-services, and reference in HDP 3.0.
> 
> In HDP 3.0, we have created a new stack definition that does not inherit from 
> other stacks, in order to reduce the complexity of having to analyze older 
> stacks.
> 
> This means that we need to create a service definition (metainfo.xml, 
> configs, kerberos, widgets, metrics, quicklinks, and themes) that is 
> equivalent to what is inherit and deleted from all of the previous stacks.
> 
> A merge needs to account for additions, overrides, and deletions.
> metainfo.xml and configs perform a merge of older versions
> kerberos.json always seems to override the previous file
> Because the bits for this service may not yet be available in the HDP 3.0 
> repo, 
> the task is to ensure that 
> /api/v1/stacks/HDP/versions/2.6/services/HBASE(which uses inheritance) is 
> equivalent to the flattening of 
> /api/v1/stacks/HDP/versions/3.0/services/HBASE .
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/alerts.json 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/configuration/hbase-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/configuration/hbase-log4j.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/configuration/hbase-policy.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/configuration/hbase-site.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/configuration/ranger-hbase-audit.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/configuration/ranger-hbase-plugin-properties.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/configuration/ranger-hbase-policymgr-ssl.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/configuration/ranger-hbase-security.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/kerberos.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/metrics.json 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/files/draining_servers.rb
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/files/hbase-smoke-cleanup.sh
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/files/hbaseSmokeVerify.sh
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/scripts/__init__.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/scripts/functions.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/scripts/hbase.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/scripts/hbase_client.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/scripts/hbase_decommission.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/scripts/hbase_master.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/scripts/hbase_regionserver.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/scripts/hbase_service.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/scripts/hbase_upgrade.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/scripts/params.py
>  PRE-CREATION 
>   
>

Re: Review Request 58634: HDP 3.0 support for HBase with configs, kerberos, widgets, metrics, quicklinks, and themes

2017-04-21 Thread Sumit Mohanty


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58634/#review172717
---


Ship it!




Minor: We can drop GANGLIA related artifacts from the new definition.

- Sumit Mohanty


On April 21, 2017, 9:41 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58634/
> ---
> 
> (Updated April 21, 2017, 9:41 p.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty, Swapan Shridhar, Sid Wagle, and 
> Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-20326
> https://issues.apache.org/jira/browse/AMBARI-20326
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HDP 3.0 support for Hbase with configs, kerberos, widgets, metrics, 
> quicklinks, and themes.'
> 
> Flatten from HDP 2.0.6 - 2.6 into common-services, and reference in HDP 3.0.
> 
> In HDP 3.0, we have created a new stack definition that does not inherit from 
> other stacks, in order to reduce the complexity of having to analyze older 
> stacks.
> 
> This means that we need to create a service definition (metainfo.xml, 
> configs, kerberos, widgets, metrics, quicklinks, and themes) that is 
> equivalent to what is inherit and deleted from all of the previous stacks.
> 
> A merge needs to account for additions, overrides, and deletions.
> metainfo.xml and configs perform a merge of older versions
> kerberos.json always seems to override the previous file
> Because the bits for this service may not yet be available in the HDP 3.0 
> repo, 
> the task is to ensure that 
> /api/v1/stacks/HDP/versions/2.6/services/HBASE(which uses inheritance) is 
> equivalent to the flattening of 
> /api/v1/stacks/HDP/versions/3.0/services/HBASE .
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/alerts.json 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/configuration/hbase-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/configuration/hbase-log4j.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/configuration/hbase-policy.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/configuration/hbase-site.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/configuration/ranger-hbase-audit.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/configuration/ranger-hbase-plugin-properties.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/configuration/ranger-hbase-policymgr-ssl.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/configuration/ranger-hbase-security.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/kerberos.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/metrics.json 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/files/draining_servers.rb
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/files/hbase-smoke-cleanup.sh
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/files/hbaseSmokeVerify.sh
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/scripts/__init__.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/scripts/functions.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/scripts/hbase.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/scripts/hbase_client.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/scripts/hbase_decommission.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/scripts/hbase_master.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/scripts/hbase_regionserver.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/scripts/hbase_service.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/scripts/hbase_upgrade.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/scripts/params.py
>  PRE-CREATION 
>   
>

Review Request 58634: HDP 3.0 support for HBase with configs, kerberos, widgets, metrics, quicklinks, and themes


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58634/
---

Review request for Ambari, Sumit Mohanty, Swapan Shridhar, Sid Wagle, and 
Vitalyi Brodetskyi.


Bugs: AMBARI-20326
https://issues.apache.org/jira/browse/AMBARI-20326


Repository: ambari


Description
---

HDP 3.0 support for Hbase with configs, kerberos, widgets, metrics, quicklinks, 
and themes.'

Flatten from HDP 2.0.6 - 2.6 into common-services, and reference in HDP 3.0.

In HDP 3.0, we have created a new stack definition that does not inherit from 
other stacks, in order to reduce the complexity of having to analyze older 
stacks.

This means that we need to create a service definition (metainfo.xml, configs, 
kerberos, widgets, metrics, quicklinks, and themes) that is equivalent to what 
is inherit and deleted from all of the previous stacks.

A merge needs to account for additions, overrides, and deletions.
metainfo.xml and configs perform a merge of older versions
kerberos.json always seems to override the previous file
Because the bits for this service may not yet be available in the HDP 3.0 repo, 
the task is to ensure that /api/v1/stacks/HDP/versions/2.6/services/HBASE(which 
uses inheritance) is equivalent to the flattening of 
/api/v1/stacks/HDP/versions/3.0/services/HBASE .


Diffs
-

  ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/alerts.json 
PRE-CREATION 
  
ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/configuration/hbase-env.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/configuration/hbase-log4j.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/configuration/hbase-policy.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/configuration/hbase-site.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/configuration/ranger-hbase-audit.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/configuration/ranger-hbase-plugin-properties.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/configuration/ranger-hbase-policymgr-ssl.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/configuration/ranger-hbase-security.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/kerberos.json 
PRE-CREATION 
  ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/metainfo.xml 
PRE-CREATION 
  ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/metrics.json 
PRE-CREATION 
  
ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/files/draining_servers.rb
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/files/hbase-smoke-cleanup.sh
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/files/hbaseSmokeVerify.sh
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/scripts/__init__.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/scripts/functions.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/scripts/hbase.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/scripts/hbase_client.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/scripts/hbase_decommission.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/scripts/hbase_master.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/scripts/hbase_regionserver.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/scripts/hbase_service.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/scripts/hbase_upgrade.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/scripts/params.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/scripts/params_linux.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/scripts/params_windows.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/scripts/phoenix_queryserver.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/scripts/phoenix_service.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/scripts/service_check.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/scripts/setup_ranger_hbase.py
 PRE-CREATION

Re: Review Request 58629: Add two new preemption properties to RU/EE (ncole)

2017-04-21 Thread Jonathan Hurley


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58629/#review172716
---


Ship it!




Ship It!

- Jonathan Hurley


On April 21, 2017, 4:56 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58629/
> ---
> 
> (Updated April 21, 2017, 4:56 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Jonathan Hurley, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-20824
> https://issues.apache.org/jira/browse/AMBARI-20824
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add the following two properties for HDP-2.6 upgrades
> 
> yarn.resourcemanager.monitor.capacity.preemption.total_preemption_per_round=0.1
> yarn.resourcemanager.monitor.capacity.preemption.natural_termination_factor=1
> 
> These values will be merged in from the stack automatically with 
> HDP-2.3,-2.4,-2.5 but need to come in correctly for 2.6.x->2.6.y upgrades.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/config-upgrade.xml 
> 87646faa85 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
>  7f0c81821d 
>   ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 
> 727987067b 
> 
> 
> Diff: https://reviews.apache.org/r/58629/diff/1/
> 
> 
> Testing
> ---
> 
> Manual.  Automated pending.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 58629: Add two new preemption properties to RU/EE (ncole)


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58629/#review172710
---


Ship it!




Ship It!

- Alejandro Fernandez


On April 21, 2017, 8:56 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58629/
> ---
> 
> (Updated April 21, 2017, 8:56 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Jonathan Hurley, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-20824
> https://issues.apache.org/jira/browse/AMBARI-20824
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add the following two properties for HDP-2.6 upgrades
> 
> yarn.resourcemanager.monitor.capacity.preemption.total_preemption_per_round=0.1
> yarn.resourcemanager.monitor.capacity.preemption.natural_termination_factor=1
> 
> These values will be merged in from the stack automatically with 
> HDP-2.3,-2.4,-2.5 but need to come in correctly for 2.6.x->2.6.y upgrades.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/config-upgrade.xml 
> 87646faa85 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
>  7f0c81821d 
>   ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 
> 727987067b 
> 
> 
> Diff: https://reviews.apache.org/r/58629/diff/1/
> 
> 
> Testing
> ---
> 
> Manual.  Automated pending.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Review Request 58629: Add two new preemption properties to RU/EE (ncole)

2017-04-21 Thread Nate Cole


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58629/
---

Review request for Ambari, Dmytro Grinenko, Jonathan Hurley, and Vitalyi 
Brodetskyi.


Bugs: AMBARI-20824
https://issues.apache.org/jira/browse/AMBARI-20824


Repository: ambari


Description
---

Add the following two properties for HDP-2.6 upgrades

yarn.resourcemanager.monitor.capacity.preemption.total_preemption_per_round=0.1
yarn.resourcemanager.monitor.capacity.preemption.natural_termination_factor=1

These values will be merged in from the stack automatically with 
HDP-2.3,-2.4,-2.5 but need to come in correctly for 2.6.x->2.6.y upgrades.


Diffs
-

  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/config-upgrade.xml 
87646faa85 
  
ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
 7f0c81821d 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 
727987067b 


Diff: https://reviews.apache.org/r/58629/diff/1/


Testing
---

Manual.  Automated pending.


Thanks,

Nate Cole

Review Request 58627: LogSearch Integration updated to limit requests to portal for missing components

2017-04-21 Thread Robert Nettleton

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58627/
---

Review request for Ambari, Miklos Gergely and Oliver Szabo.

Bugs: AMBARI-20819
https://issues.apache.org/jira/browse/AMBARI-20819

Repository: ambari

Description
---

This patch resolves AMBARI-20819.

The LogSearch Integration layer in Ambari contacts the LogSearch Portal Server
in order to obtain logging data, as well as metadata for the various logging
components.

Generally, this information is cached, but during scale testing it was
determined that the integration layer would repeatedly make requests for
logging metadata for components which did not have the correct LogSearch
metadata in the stack definitions. This causes extra and un-necessary load on
the LogSearch server, and can make debugging the LogSearch service more
difficult, due to the amount of extraneous logs generated by LogSearch as a
result of these extra queries.

This patch resolves this issue by implementing the following:

1. The LogSearchDataRetrievalService has been modified to track any components
that cause errors when the initial metadata for a given component is requested
from LogSearch. If a component has had a maximum number of error results, the
integration layer will ignore this component until the next ambari-server
restart. In addition, the service will log this condition at the DEBUG level
in ambari-server.log.

2. Added new unit tests to verify this change.

Diffs
-

ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LogSearchDataRetrievalService.java
6b484a4

ambari-server/src/test/java/org/apache/ambari/server/controller/logging/LogSearchDataRetrievalServiceTest.java
d60596b

Diff: https://reviews.apache.org/r/58627/diff/1/

Testing
---

Installed a LogSearch cluster on a local VM install, and verified that the
Ambari Integration layer for LogSearch no longer makes the extra queries to
LogSearch server (verified via logsearch-performance.json). Also enabled DEBUG
logging and verified that this condition is logged at the DEBUG level when this
condition occurs.

Also verified that the basic functions of the LogSearch Integration layer in
Ambari are still working as expected with this patch applied.

Thanks,

Robert Nettleton

Re: Review Request 58590: Provide an optional attribute for custom commands to allow using command name in operations window title

2017-04-21 Thread Sangeeta Ravindran



> On April 20, 2017, 9:32 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/HostRoleCommand.java
> > Lines 72 (patched)
> > 
> >
> > I would suggest to actually have a field to overwrite the display name 
> > to use in order to make it more flexible.
> > 
> > The reason being that the custom command name is used to find the 
> > function in python, which is not necessarily very human readable.
> 
> Alejandro Fernandez wrote:
> Sangeeta, what do you think about this? I think it will be more flexible 
> in the long run.

Hi Alejandro,

Yes I think, it would be better to have a field to allow custom commands to 
overwrite the display name. I have created an updated patch based on your 
suggestion and will attach it shortly.


- Sangeeta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58590/#review172549
---


On April 20, 2017, 7:53 p.m., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58590/
> ---
> 
> (Updated April 20, 2017, 7:53 p.m.)
> 
> 
> Review request for Ambari, Di Li and Tim Thorpe.
> 
> 
> Bugs: AMBARI-20616
> https://issues.apache.org/jira/browse/AMBARI-20616
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Some services in our stack have custom commands where the name is a 
> combination of an operation and a component name.
> 
> For e.g. Remove_Logical_myservice_mycomponent
> 
> When the custom command is being executed, the operations window title is 
> displayed as "Remove Logical myservice mycomponent mycomponent"
> 
> It would be useful to provide an optional attribute e.g. useNameInOps for 
> custom commands to allow using the command name itself as the title displayed 
> in the operations window.
> 
> 
> Remove_Logical_myservice_mycomponent
> true
> 
> scripts/mycomponent.py
> PYTHON
>  10800
>  
> 
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/HostRoleCommand.java
>  87a6edf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  17bc718 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TaskResourceProvider.java
>  20b0417 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java
>  86feceb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/CustomCommandDefinition.java
>  280a59b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java
>  633d837 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql fd49b94 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 9fc3209 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 310208d 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql c052104 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 5a58ef8 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 8c7a31d 
>   ambari-server/src/main/resources/properties.json c2545fe 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/TaskResourceProviderTest.java
>  8a52b8a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntityTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java
>  fec041c 
>   ambari-web/app/controllers/wizard/step9_controller.js 4697dad 
>   ambari-web/app/utils/ajax/ajax.js 2b5e52a 
>   ambari-web/app/utils/helper.js 03a2e82 
>   ambari-web/app/utils/host_progress_popup.js c615cae 
>   ambari-web/app/views/wizard/step9/hostLogPopupBody_view.js d983252 
>   ambari-web/test/utils/helper_test.js 4b9ec36 
> 
> 
> Diff: https://reviews.apache.org/r/58590/diff/1/
> 
> 
> Testing
> ---
> 
> Manual Testing.
> Added new test cases.
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Re: Review Request 58590: Provide an optional attribute for custom commands to allow using command name in operations window title



> On April 20, 2017, 9:32 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/HostRoleCommand.java
> > Lines 72 (patched)
> > 
> >
> > I would suggest to actually have a field to overwrite the display name 
> > to use in order to make it more flexible.
> > 
> > The reason being that the custom command name is used to find the 
> > function in python, which is not necessarily very human readable.

Sangeeta, what do you think about this? I think it will be more flexible in the 
long run.


- Alejandro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58590/#review172549
---


On April 20, 2017, 7:53 p.m., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58590/
> ---
> 
> (Updated April 20, 2017, 7:53 p.m.)
> 
> 
> Review request for Ambari, Di Li and Tim Thorpe.
> 
> 
> Bugs: AMBARI-20616
> https://issues.apache.org/jira/browse/AMBARI-20616
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Some services in our stack have custom commands where the name is a 
> combination of an operation and a component name.
> 
> For e.g. Remove_Logical_myservice_mycomponent
> 
> When the custom command is being executed, the operations window title is 
> displayed as "Remove Logical myservice mycomponent mycomponent"
> 
> It would be useful to provide an optional attribute e.g. useNameInOps for 
> custom commands to allow using the command name itself as the title displayed 
> in the operations window.
> 
> 
> Remove_Logical_myservice_mycomponent
> true
> 
> scripts/mycomponent.py
> PYTHON
>  10800
>  
> 
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/HostRoleCommand.java
>  87a6edf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  17bc718 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TaskResourceProvider.java
>  20b0417 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java
>  86feceb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/CustomCommandDefinition.java
>  280a59b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java
>  633d837 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql fd49b94 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 9fc3209 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 310208d 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql c052104 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 5a58ef8 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 8c7a31d 
>   ambari-server/src/main/resources/properties.json c2545fe 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/TaskResourceProviderTest.java
>  8a52b8a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntityTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java
>  fec041c 
>   ambari-web/app/controllers/wizard/step9_controller.js 4697dad 
>   ambari-web/app/utils/ajax/ajax.js 2b5e52a 
>   ambari-web/app/utils/helper.js 03a2e82 
>   ambari-web/app/utils/host_progress_popup.js c615cae 
>   ambari-web/app/views/wizard/step9/hostLogPopupBody_view.js d983252 
>   ambari-web/test/utils/helper_test.js 4b9ec36 
> 
> 
> Diff: https://reviews.apache.org/r/58590/diff/1/
> 
> 
> Testing
> ---
> 
> Manual Testing.
> Added new test cases.
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Re: Review Request 58444: Log Feeder fill cluster name if it is not set

2017-04-21 Thread Oliver Szabo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58444/#review172669
---


Ship it!




Ship It!

- Oliver Szabo


On April 21, 2017, 3:28 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58444/
> ---
> 
> (Updated April 21, 2017, 3:28 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-20766
> https://issues.apache.org/jira/browse/AMBARI-20766
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If for some reason there is no cluster set for a log entry, set it to the 
> actual cluster.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputManager.java
>  9a9f973 
> 
> 
> Diff: https://reviews.apache.org/r/58444/diff/2/
> 
> 
> Testing
> ---
> 
> tested on local cluster
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 58591: Roles page in Ambari UI shows extra rows in IE browser

2017-04-21 Thread Anita Jebaraj



> On April 21, 2017, 6:19 a.m., Alexandr Antonenko wrote:
> > Ship It!

Can you please help in pushing the changes?


- Anita


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58591/#review172589
---


On April 20, 2017, 8:34 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58591/
> ---
> 
> (Updated April 20, 2017, 8:34 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Di Li, Richard Zang, and 
> Sangeeta Ravindran.
> 
> 
> Bugs: AMBARI-20810
> https://issues.apache.org/jira/browse/AMBARI-20810
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Roles page in Ambari UI shows extra empty rows in Internet explorer.
> 
> javascript For..each loop doesn't work as expected for arrays in Internet 
> explorer, which causes the extra rows as in screenshot.
> 
> 
> Diffs
> -
> 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/ClustersManageAccessCtrl.js
>  e1b74aa 
> 
> 
> Diff: https://reviews.apache.org/r/58591/diff/1/
> 
> 
> Testing
> ---
> 
> tested manually, verified in different browsers (IE/firefox/chrome)
> 
> 
> File Attachments
> 
> 
> After fix
>   
> https://reviews.apache.org/media/uploaded/files/2017/04/20/d891ffb5-e048-4c4c-9b50-dca3bab48ba2__Afterfix.jpg
> Before fix
>   
> https://reviews.apache.org/media/uploaded/files/2017/04/20/a6915f9d-d69b-4dda-9e3b-6cfd338cb815__UI.jpg
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 58206: Complete node name is not shown when node name is larger than 17 characters

2017-04-21 Thread Pallav Kulshreshtha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58206/
---

(Updated April 21, 2017, 3:43 p.m.)


Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, 
Nitiraj Rathore, Rohit Choudhary, and venkat sairam.


Bugs: AMBARI-20678
https://issues.apache.org/jira/browse/AMBARI-20678


Repository: ambari


Description
---

Introduced ellipsis css class and showing complete name as tooltip.


Diffs (updated)
-

  contrib/views/hive20/src/main/resources/ui/app/adapters/application.js 
42935fc 
  contrib/views/hive20/src/main/resources/ui/app/styles/app.scss f4b63c5 
  
contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js 
78aa39d 


Diff: https://reviews.apache.org/r/58206/diff/2/

Changes: https://reviews.apache.org/r/58206/diff/1-2/


Testing
---

manually tested.


Thanks,

Pallav Kulshreshtha

Re: Review Request 58444: Log Feeder fill cluster name if it is not set

2017-04-21 Thread Miklos Gergely


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58444/
---

(Updated April 21, 2017, 3:28 p.m.)


Review request for Ambari, Oliver Szabo and Robert Nettleton.


Changes
---

Modify the method so it fits branch-2.5 too


Bugs: AMBARI-20766
https://issues.apache.org/jira/browse/AMBARI-20766


Repository: ambari


Description
---

If for some reason there is no cluster set for a log entry, set it to the 
actual cluster.


Diffs (updated)
-

  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputManager.java
 9a9f973 


Diff: https://reviews.apache.org/r/58444/diff/2/

Changes: https://reviews.apache.org/r/58444/diff/1-2/


Testing
---

tested on local cluster


Thanks,

Miklos Gergely

Review Request 58620: Stack side changes to use instanceId for cluster based segregation of data (AMS)

2017-04-21 Thread Dmytro Sen


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58620/
---

Review request for Ambari, Aravindan Vijayan and Sid Wagle.


Bugs: AMBARI-20820
https://issues.apache.org/jira/browse/AMBARI-20820


Repository: ambari


Description
---

To track changes in
- Stack & AMS Scripts
- Sinks (Services & Ambari Server)


Diffs
-

  
ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
 46f32f9 
  
ambari-metrics/ambari-metrics-flume-sink/src/main/java/org/apache/hadoop/metrics2/sink/flume/FlumeTimelineMetricsSink.java
 3fdf3f4 
  
ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java
 8e0de03 
  
ambari-metrics/ambari-metrics-hadoop-sink/src/test/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSinkTest.java
 5777639 
  
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/application_metric_map.py
 0052808 
  
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py
 5686c50 
  ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py 
ba3f18e 
  
ambari-metrics/ambari-metrics-kafka-sink/src/main/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporter.java
 9d492cb 
  
ambari-metrics/ambari-metrics-kafka-sink/src/test/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporterTest.java
 e1ac48c 
  
ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java
 9a55f10 
  
ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
 60c1427 
  
ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java
 535fae0 
  
ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
 f58f549 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java
 f268149 
  
ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py
 53cf002 
  
ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/templates/hadoop-metrics2-accumulo.properties.j2
 f7926d0 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml
 8e1671e 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
 919f26d 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/hadoop-metrics2-hbase.properties.j2
 8c6f86f 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metric_monitor.ini.j2
 1505f9b 
  
ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params.py
 b143941 
  
ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/templates/flume-metrics2.properties.j2
 cf2bd6c 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
 3177643 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-MASTER.j2
 e808f5d 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-RS.j2
 7e1abbc 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 84bac38 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-hivemetastore.properties.j2
 82f71c5 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-hiveserver2.properties.j2
 f1bfa03 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-llapdaemon.j2
 d63dfb7 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-llaptaskscheduler.j2
 4c9c981 
  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-broker.xml
 f2b4a76 
  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
 32f18f2 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
 44b256e 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1/package/templates/config.yaml.j2
 f2a75cf 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1/package/templates/storm-metrics2.properties.j2
 001ff73 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py
 70ebfeb

Review Request 58619: Stack side changes to use instanceId for cluster based segregation of data (AMS)

2017-04-21 Thread Dmytro Sen


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58619/
---

Review request for Ambari, Aravindan Vijayan and Sid Wagle.


Bugs: AMBARI-20820
https://issues.apache.org/jira/browse/AMBARI-20820


Repository: ambari


Description
---

To track changes in
- Stack & AMS Scripts
- Sinks (Services & Ambari Server)


Diffs
-

  
ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
 46f32f9 
  
ambari-metrics/ambari-metrics-flume-sink/src/main/java/org/apache/hadoop/metrics2/sink/flume/FlumeTimelineMetricsSink.java
 3fdf3f4 
  
ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java
 8e0de03 
  
ambari-metrics/ambari-metrics-hadoop-sink/src/test/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSinkTest.java
 5777639 
  
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/application_metric_map.py
 0052808 
  
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py
 5686c50 
  ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py 
ba3f18e 
  
ambari-metrics/ambari-metrics-kafka-sink/src/main/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporter.java
 9d492cb 
  
ambari-metrics/ambari-metrics-kafka-sink/src/test/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporterTest.java
 e1ac48c 
  
ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java
 9a55f10 
  
ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
 60c1427 
  
ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java
 535fae0 
  
ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
 f58f549 
  ambari-metrics/pom.xml 2d88912 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java
 f268149 
  
ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py
 53cf002 
  
ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/templates/hadoop-metrics2-accumulo.properties.j2
 f7926d0 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml
 8e1671e 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
 919f26d 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/hadoop-metrics2-hbase.properties.j2
 8c6f86f 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metric_monitor.ini.j2
 1505f9b 
  
ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params.py
 b143941 
  
ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/templates/flume-metrics2.properties.j2
 cf2bd6c 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
 3177643 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-MASTER.j2
 e808f5d 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-RS.j2
 7e1abbc 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 84bac38 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-hivemetastore.properties.j2
 82f71c5 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-hiveserver2.properties.j2
 f1bfa03 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-llapdaemon.j2
 d63dfb7 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-llaptaskscheduler.j2
 4c9c981 
  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-broker.xml
 f2b4a76 
  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
 32f18f2 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
 44b256e 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1/package/templates/config.yaml.j2
 f2a75cf 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1/package/templates/storm-metrics2.properties.j2
 001ff73 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py
 70ebfeb

Re: Review Request 58577: Autofix db leads to dangling entries in ClusterConfigMapping table

2017-04-21 Thread Nate Cole


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58577/#review172655
---


Ship it!




Ship It!

- Nate Cole


On April 21, 2017, 4:18 a.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58577/
> ---
> 
> (Updated April 21, 2017, 4:18 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-20805
> https://issues.apache.org/jira/browse/AMBARI-20805
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Existing implementation removes all entities of the same type
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  4cdeecb153 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterDAO.java 
> b727c720bb 
> 
> 
> Diff: https://reviews.apache.org/r/58577/diff/2/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 58568: StackAdvisor should not recommend configuration types for services that are not present in the cluster

2017-04-21 Thread Sebastian Toader


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58568/#review172654
---


Ship it!




Ship It!

- Sebastian Toader


On April 20, 2017, 4:19 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58568/
> ---
> 
> (Updated April 20, 2017, 4:19 p.m.)
> 
> 
> Review request for Ambari, Madhuvanthi Radhakrishnan, Sumit Mohanty, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-20802
> https://issues.apache.org/jira/browse/AMBARI-20802
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When a minimal Blueprint install was attempted in that issue, some failures 
> occurred during the Blueprint deployment.
> After some investigation, we determined that the Blueprints processor was 
> throwing a NullPointerException, due to some configuration types being 
> considered "updated", even though those configuration types are not included 
> in the "desired configuration" for the cluster, since the services associated 
> with those configuration types are not deployed in this current cluster.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
>  ce36208 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
>  be79331 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
>  6cd6d35 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/stack_advisor.py 
> ad35688 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 
> 7ef5fad 
>   ambari-server/src/test/python/stacks/2.1/common/test_stack_advisor.py 
> f9fb1f5 
>   ambari-server/src/test/python/stacks/2.6/common/test_stack_advisor.py 
> 2d7322d 
> 
> 
> Diff: https://reviews.apache.org/r/58568/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 58616: Need a confirmation dialog for table / database delete

2017-04-21 Thread Gaurav Nagar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58616/#review172653
---


Ship it!




Ship It!

- Gaurav Nagar


On April 21, 2017, 12:54 p.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58616/
> ---
> 
> (Updated April 21, 2017, 12:54 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> Rohit Choudhary, and venkat sairam.
> 
> 
> Bugs: AMBARI-20815
> https://issues.apache.org/jira/browse/AMBARI-20815
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added a dialog for taking confirmation from the user for table delete.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/table.js
>  53055cf 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/databases/database/tables/table.hbs
>  2fe3cfb 
> 
> 
> Diff: https://reviews.apache.org/r/58616/diff/1/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Review Request 58617: AMBARI-20816 Create Ranger Hive Service during Hive Metastore restart

2017-04-21 Thread Mugdha Varadkar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58617/
---

Review request for Ambari, Alejandro Fernandez, Gautam Borad, Sumit Mohanty, 
and Velmurugan Periasamy.


Bugs: AMBARI-20816
https://issues.apache.org/jira/browse/AMBARI-20816


Repository: ambari


Description
---

Need to create Ranger Hive service in Cluster1 having Hive Metastore + Ranger 
Service. The Ranger Hive service created in Cluster1 will be used by Cluster2 
having Ranger Hive Plugin enabled under Hive Server2.

Solution:
Need service creation logic using Ranger REST API. The REST API code is already 
available for use.
If ranger.service.config.param.enable.hive.metastore.lookup property present in 
ranger-hive-plugin-properties with value true and Ranger configurations are 
present in the cluster(Ranger installed in same cluster) then only create 
Ranger Hive service.

For installation via blueprint, two extra custom config parameters 
ranger.service.config.param.enable.hive.metastore.lookup with value true and 
ranger.service.config.param.hive.site.file.path with value 
/etc/hive/conf/hive-site.xml are required to be provided in blueprint under 
ranger-hive-plugin-properties config type.

For installation via UI, need to add properties in custom section of 
ranger-hive-plugin-properties under Hive Service config tab.


Diffs
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py
 8b69e45 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 84bac38 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/setup_ranger_hive.py
 80bd7c8 
  
ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive_metastore.py
 8b69e45 
  
ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/params_linux.py
 84bac38 
  
ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/setup_ranger_hive.py
 80bd7c8 


Diff: https://reviews.apache.org/r/58617/diff/1/


Testing
---

Unit Test Report:

Ran 272 tests in 8.920s

OK
--
Total run:1194
Total errors:0
Total failures:0
OK


Thanks,

Mugdha Varadkar

Re: Review Request 58616: Need a confirmation dialog for table / database delete


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58616/#review172652
---


Ship it!




Ship It!

- venkat sairam


On April 21, 2017, 12:54 p.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58616/
> ---
> 
> (Updated April 21, 2017, 12:54 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> Rohit Choudhary, and venkat sairam.
> 
> 
> Bugs: AMBARI-20815
> https://issues.apache.org/jira/browse/AMBARI-20815
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added a dialog for taking confirmation from the user for table delete.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/table.js
>  53055cf 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/databases/database/tables/table.hbs
>  2fe3cfb 
> 
> 
> Diff: https://reviews.apache.org/r/58616/diff/1/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Re: Review Request 58583: Trying to upgrade HDF 2.0.2.0 to HDF 3.0.0.0 fails with NPE

2017-04-21 Thread Jonathan Hurley


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58583/#review172651
---


Ship it!




Ship It!

- Jonathan Hurley


On April 21, 2017, 8:25 a.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58583/
> ---
> 
> (Updated April 21, 2017, 8:25 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-20811
> https://issues.apache.org/jira/browse/AMBARI-20811
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The following steps were followed.
> 1. Installed ambari 2.4.1.0
> 2. Installed HDF 2.0.2.0
> 3. Upgraded ambari to 2.5.0.3
> 4 Upgraded mpack to 3.0.0.0-169 is installed.
> 5. Ambari launches successfully and HDF 2.0.2.0 shows correctly
> 6. Registered and installed the new version 3.0.0.0-169
> 7. Click on express upgrade. Throws 500
> 
> Ambari-server has the following exception in the logs
> {code:None}
> 11 Apr 2017 08:11:59,794 ERROR [ambari-client-thread-194] 
> ContainerResponse:419 - The RuntimeException could not be mapped to a 
> response, re-throwing to the HTTP container
> java.lang.NullPointerException
> at 
> org.apache.ambari.server.state.stack.ConfigUpgradePack.merge(ConfigUpgradePack.java:124)
> at 
> org.apache.ambari.server.controller.internal.UpgradeResourceProvider$ConfigurationPackBuilder.build(UpgradeResourceProvider.java:1839)
> at 
> org.apache.ambari.server.controller.internal.UpgradeResourceProvider.createUpgrade(UpgradeResourceProvider.java:812)
> at 
> org.apache.ambari.server.controller.internal.UpgradeResourceProvider$1.invoke(UpgradeResourceProvider.java:382)
> at 
> org.apache.ambari.server.controller.internal.UpgradeResourceProvider$1.invoke(UpgradeResourceProvider.java:350)
> at 
> org.apache.ambari.server.controller.internal.AbstractResourceProvider.invokeWithRetry(AbstractResourceProvider.java:455)
> at 
> org.apache.ambari.server.controller.internal.AbstractResourceProvider.createResources(AbstractResourceProvider.java:278)
> at 
> org.apache.ambari.server.controller.internal.UpgradeResourceProvider.createResources(UpgradeResourceProvider.java:350)
> at 
> org.apache.ambari.server.controller.internal.ClusterControllerImpl.createResources(ClusterControllerImpl.java:298)
> at 
> org.apache.ambari.server.api.services.persistence.PersistenceManagerImpl.create(PersistenceManagerImpl.java:97)
> at 
> org.apache.ambari.server.api.handlers.CreateHandler.persist(CreateHandler.java:37)
> at 
> org.apache.ambari.server.api.handlers.BaseManagementHandler.handleRequest(BaseManagementHandler.java:73)
> at 
> org.apache.ambari.server.api.services.BaseRequest.process(BaseRequest.java:144)
> at 
> org.apache.ambari.server.api.services.BaseService.handleRequest(BaseService.java:126)
> at 
> org.apache.ambari.server.api.services.BaseService.handleRequest(BaseService.java:90)
> at 
> org.apache.ambari.server.api.services.UpgradeService.createUpgrade(UpgradeService.java:58)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> {code}
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java
>  daa9014162 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerTest.java
>  0234d797c8 
> 
> 
> Diff: https://reviews.apache.org/r/58583/diff/2/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 58346: AMBARI-20733 /var/log/krb5kdc.log is growing rapidly on the KDC server


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58346/#review172650
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On April 21, 2017, 3:53 p.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58346/
> ---
> 
> (Updated April 21, 2017, 3:53 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Robert Levas, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-20733
> https://issues.apache.org/jira/browse/AMBARI-20733
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> kerberos statuses making call on every status command with fresh ticket 
> cache. Ignoring this check for now because it does not do anything for now 
> and need to be reimplemented in something more reliable.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/ActionQueue.py 75880c6 
>   ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
> a67e16e 
>   ambari-agent/src/test/python/ambari_agent/TestActionQueue.py ab46f96 
>   ambari-agent/src/test/python/ambari_agent/TestCustomServiceOrchestrator.py 
> 8e5e9a3 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> d0e5678 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ComponentStatus.java
>  5591ae8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java
>  8cd2804 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_script.py
>  01fbce2 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_collector.py
>  7073de6 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py
>  3c62243 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py
>  6d1dbc5 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py
>  c4960a7 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py
>  d2c8089 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py
>  226e7fd5 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_queryserver.py
>  77820cc 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py
>  cd52885 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py
>  4dabdbc 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py
>  9448fa6 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py
>  1347f37 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/nfsgateway.py
>  7ba1f96 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py
>  0f1f438 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py
>  be0d2ed 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/datanode.py
>  130c021 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/hdfs_client.py
>  4dabdbc 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/journalnode.py
>  9448fa6 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/namenode.py
>  602dad7 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/nfsgateway.py
>  7ba1f96 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/snamenode.py
>  0f1f438 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/zkfc_slave.py
>  19a78c7 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py
>  8b69e45 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py
>  f6251e7 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
>  46864c0 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py
>  93fa411 
>   
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive_metastore.py
>  8b69e45 
>   
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive_server.py
>  f6251e7 
>   
>

Review Request 58616: Need a confirmation dialog for table / database delete

2017-04-21 Thread Pallav Kulshreshtha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58616/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
Rohit Choudhary, and venkat sairam.


Bugs: AMBARI-20815
https://issues.apache.org/jira/browse/AMBARI-20815


Repository: ambari


Description
---

Added a dialog for taking confirmation from the user for table delete.


Diffs
-

  
contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/table.js
 53055cf 
  
contrib/views/hive20/src/main/resources/ui/app/templates/databases/database/tables/table.hbs
 2fe3cfb 


Diff: https://reviews.apache.org/r/58616/diff/1/


Testing
---

manually tested.


Thanks,

Pallav Kulshreshtha

Re: Review Request 58613: Need to show appropriate error message while deleting the workflow history in project manager

2017-04-21 Thread belliraj hb


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58613/#review172649
---


Ship it!




Ship It!

- belliraj hb


On April 21, 2017, 12:02 p.m., Supreeth Sharma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58613/
> ---
> 
> (Updated April 21, 2017, 12:02 p.m.)
> 
> 
> Review request for Ambari, belliraj hb, Padma Priya N, Rohit Choudhary, and 
> venkat sairam.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Changed the message to indicate that item is getting deleted only from the 
> history and file will still be available in HDFS file path
> 
> 
> Diffs
> -
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/drafts-wf.js 
> ed448d9 
>   contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less abb0637 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/drafts-wf.hbs
>  05599e5 
> 
> 
> Diff: https://reviews.apache.org/r/58613/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested the changes
> 
> 
> Thanks,
> 
> Supreeth Sharma
> 
>

Re: Review Request 58614: Project manager window is not opening for the second time

2017-04-21 Thread belliraj hb


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58614/#review172648
---


Ship it!




Ship It!

- belliraj hb


On April 21, 2017, 12:03 p.m., venkat sairam wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58614/
> ---
> 
> (Updated April 21, 2017, 12:03 p.m.)
> 
> 
> Review request for Ambari, belliraj hb, Padma Priya N, Rohit Choudhary, and 
> Supreeth Sharma.
> 
> 
> Bugs: AMBARI-20793
> https://issues.apache.org/jira/browse/AMBARI-20793
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> We have handled the kepyboard and out of clicks scenario to resolve the issue
> 
> 
> Diffs
> -
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/drafts-wf.js 
> ed448d9 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/recent-projects.js
>  bbc51cc 
> 
> 
> Diff: https://reviews.apache.org/r/58614/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing done
> 
> 
> Thanks,
> 
> venkat sairam
> 
>

Re: Review Request 58346: AMBARI-20733 /var/log/krb5kdc.log is growing rapidly on the KDC server

2017-04-21 Thread Eugene Chekanskiy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58346/
---

(Updated April 21, 2017, 12:53 p.m.)


Review request for Ambari, Dmitro Lisnichenko, Robert Levas, and Vitalyi 
Brodetskyi.


Changes
---

updated to lates trunk changes


Bugs: AMBARI-20733
https://issues.apache.org/jira/browse/AMBARI-20733


Repository: ambari


Description
---

kerberos statuses making call on every status command with fresh ticket cache. 
Ignoring this check for now because it does not do anything for now and need to 
be reimplemented in something more reliable.


Diffs (updated)
-

  ambari-agent/src/main/python/ambari_agent/ActionQueue.py 75880c6 
  ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
a67e16e 
  ambari-agent/src/test/python/ambari_agent/TestActionQueue.py ab46f96 
  ambari-agent/src/test/python/ambari_agent/TestCustomServiceOrchestrator.py 
8e5e9a3 
  ambari-common/src/main/python/resource_management/libraries/script/script.py 
d0e5678 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/ComponentStatus.java 
5591ae8 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java
 8cd2804 
  
ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_script.py
 01fbce2 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_collector.py
 7073de6 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py
 3c62243 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py
 6d1dbc5 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py
 c4960a7 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py
 d2c8089 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py
 226e7fd5 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_queryserver.py
 77820cc 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py
 cd52885 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py
 4dabdbc 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py
 9448fa6 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py
 1347f37 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/nfsgateway.py
 7ba1f96 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py
 0f1f438 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py
 be0d2ed 
  
ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/datanode.py
 130c021 
  
ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/hdfs_client.py
 4dabdbc 
  
ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/journalnode.py
 9448fa6 
  
ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/namenode.py
 602dad7 
  
ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/nfsgateway.py
 7ba1f96 
  
ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/snamenode.py
 0f1f438 
  
ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/zkfc_slave.py
 19a78c7 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py
 8b69e45 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py
 f6251e7 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
 46864c0 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py
 93fa411 
  
ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive_metastore.py
 8b69e45 
  
ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive_server.py
 f6251e7 
  
ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive_server_interactive.py
 46864c0 
  
ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/webhcat_server.py
 93fa411 
  
ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/kerberos_client.py
 c50c67b 
  
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py
 31e54e5 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py
 a8b2cf4

Re: Review Request 58591: Roles page in Ambari UI shows extra rows in IE browser

2017-04-21 Thread Di Li


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58591/#review172646
---


Ship it!




Ship It!

- Di Li


On April 20, 2017, 8:34 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58591/
> ---
> 
> (Updated April 20, 2017, 8:34 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Di Li, Richard Zang, and 
> Sangeeta Ravindran.
> 
> 
> Bugs: AMBARI-20810
> https://issues.apache.org/jira/browse/AMBARI-20810
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Roles page in Ambari UI shows extra empty rows in Internet explorer.
> 
> javascript For..each loop doesn't work as expected for arrays in Internet 
> explorer, which causes the extra rows as in screenshot.
> 
> 
> Diffs
> -
> 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/ClustersManageAccessCtrl.js
>  e1b74aa 
> 
> 
> Diff: https://reviews.apache.org/r/58591/diff/1/
> 
> 
> Testing
> ---
> 
> tested manually, verified in different browsers (IE/firefox/chrome)
> 
> 
> File Attachments
> 
> 
> After fix
>   
> https://reviews.apache.org/media/uploaded/files/2017/04/20/d891ffb5-e048-4c4c-9b50-dca3bab48ba2__Afterfix.jpg
> Before fix
>   
> https://reviews.apache.org/media/uploaded/files/2017/04/20/a6915f9d-d69b-4dda-9e3b-6cfd338cb815__UI.jpg
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 58583: Trying to upgrade HDF 2.0.2.0 to HDF 3.0.0.0 fails with NPE


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58583/
---

(Updated April 21, 2017, 3:25 p.m.)


Review request for Ambari, Jonathan Hurley and Nate Cole.


Changes
---

Added a test


Bugs: AMBARI-20811
https://issues.apache.org/jira/browse/AMBARI-20811


Repository: ambari


Description
---

The following steps were followed.
1. Installed ambari 2.4.1.0
2. Installed HDF 2.0.2.0
3. Upgraded ambari to 2.5.0.3
4 Upgraded mpack to 3.0.0.0-169 is installed.
5. Ambari launches successfully and HDF 2.0.2.0 shows correctly
6. Registered and installed the new version 3.0.0.0-169
7. Click on express upgrade. Throws 500

Ambari-server has the following exception in the logs
{code:None}
11 Apr 2017 08:11:59,794 ERROR [ambari-client-thread-194] ContainerResponse:419 
- The RuntimeException could not be mapped to a response, re-throwing to the 
HTTP container
java.lang.NullPointerException
at 
org.apache.ambari.server.state.stack.ConfigUpgradePack.merge(ConfigUpgradePack.java:124)
at 
org.apache.ambari.server.controller.internal.UpgradeResourceProvider$ConfigurationPackBuilder.build(UpgradeResourceProvider.java:1839)
at 
org.apache.ambari.server.controller.internal.UpgradeResourceProvider.createUpgrade(UpgradeResourceProvider.java:812)
at 
org.apache.ambari.server.controller.internal.UpgradeResourceProvider$1.invoke(UpgradeResourceProvider.java:382)
at 
org.apache.ambari.server.controller.internal.UpgradeResourceProvider$1.invoke(UpgradeResourceProvider.java:350)
at 
org.apache.ambari.server.controller.internal.AbstractResourceProvider.invokeWithRetry(AbstractResourceProvider.java:455)
at 
org.apache.ambari.server.controller.internal.AbstractResourceProvider.createResources(AbstractResourceProvider.java:278)
at 
org.apache.ambari.server.controller.internal.UpgradeResourceProvider.createResources(UpgradeResourceProvider.java:350)
at 
org.apache.ambari.server.controller.internal.ClusterControllerImpl.createResources(ClusterControllerImpl.java:298)
at 
org.apache.ambari.server.api.services.persistence.PersistenceManagerImpl.create(PersistenceManagerImpl.java:97)
at 
org.apache.ambari.server.api.handlers.CreateHandler.persist(CreateHandler.java:37)
at 
org.apache.ambari.server.api.handlers.BaseManagementHandler.handleRequest(BaseManagementHandler.java:73)
at 
org.apache.ambari.server.api.services.BaseRequest.process(BaseRequest.java:144)
at 
org.apache.ambari.server.api.services.BaseService.handleRequest(BaseService.java:126)
at 
org.apache.ambari.server.api.services.BaseService.handleRequest(BaseService.java:90)
at 
org.apache.ambari.server.api.services.UpgradeService.createUpgrade(UpgradeService.java:58)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
{code}


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java 
daa9014162 
  
ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerTest.java
 0234d797c8 


Diff: https://reviews.apache.org/r/58583/diff/2/

Changes: https://reviews.apache.org/r/58583/diff/1-2/


Testing
---

mvn clean test


Thanks,

Dmitro Lisnichenko

Re: Review Request 58583: Trying to upgrade HDF 2.0.2.0 to HDF 3.0.0.0 fails with NPE



> On April 20, 2017, 9:51 p.m., Jonathan Hurley wrote:
> > Can we write a simple unit test to verify that on a stack which has no 
> > config pack, one gets created?

done


- Dmitro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58583/#review172537
---


On April 21, 2017, 3:25 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58583/
> ---
> 
> (Updated April 21, 2017, 3:25 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-20811
> https://issues.apache.org/jira/browse/AMBARI-20811
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The following steps were followed.
> 1. Installed ambari 2.4.1.0
> 2. Installed HDF 2.0.2.0
> 3. Upgraded ambari to 2.5.0.3
> 4 Upgraded mpack to 3.0.0.0-169 is installed.
> 5. Ambari launches successfully and HDF 2.0.2.0 shows correctly
> 6. Registered and installed the new version 3.0.0.0-169
> 7. Click on express upgrade. Throws 500
> 
> Ambari-server has the following exception in the logs
> {code:None}
> 11 Apr 2017 08:11:59,794 ERROR [ambari-client-thread-194] 
> ContainerResponse:419 - The RuntimeException could not be mapped to a 
> response, re-throwing to the HTTP container
> java.lang.NullPointerException
> at 
> org.apache.ambari.server.state.stack.ConfigUpgradePack.merge(ConfigUpgradePack.java:124)
> at 
> org.apache.ambari.server.controller.internal.UpgradeResourceProvider$ConfigurationPackBuilder.build(UpgradeResourceProvider.java:1839)
> at 
> org.apache.ambari.server.controller.internal.UpgradeResourceProvider.createUpgrade(UpgradeResourceProvider.java:812)
> at 
> org.apache.ambari.server.controller.internal.UpgradeResourceProvider$1.invoke(UpgradeResourceProvider.java:382)
> at 
> org.apache.ambari.server.controller.internal.UpgradeResourceProvider$1.invoke(UpgradeResourceProvider.java:350)
> at 
> org.apache.ambari.server.controller.internal.AbstractResourceProvider.invokeWithRetry(AbstractResourceProvider.java:455)
> at 
> org.apache.ambari.server.controller.internal.AbstractResourceProvider.createResources(AbstractResourceProvider.java:278)
> at 
> org.apache.ambari.server.controller.internal.UpgradeResourceProvider.createResources(UpgradeResourceProvider.java:350)
> at 
> org.apache.ambari.server.controller.internal.ClusterControllerImpl.createResources(ClusterControllerImpl.java:298)
> at 
> org.apache.ambari.server.api.services.persistence.PersistenceManagerImpl.create(PersistenceManagerImpl.java:97)
> at 
> org.apache.ambari.server.api.handlers.CreateHandler.persist(CreateHandler.java:37)
> at 
> org.apache.ambari.server.api.handlers.BaseManagementHandler.handleRequest(BaseManagementHandler.java:73)
> at 
> org.apache.ambari.server.api.services.BaseRequest.process(BaseRequest.java:144)
> at 
> org.apache.ambari.server.api.services.BaseService.handleRequest(BaseService.java:126)
> at 
> org.apache.ambari.server.api.services.BaseService.handleRequest(BaseService.java:90)
> at 
> org.apache.ambari.server.api.services.UpgradeService.createUpgrade(UpgradeService.java:58)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> {code}
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java
>  daa9014162 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerTest.java
>  0234d797c8 
> 
> 
> Diff: https://reviews.apache.org/r/58583/diff/2/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 58568: StackAdvisor should not recommend configuration types for services that are not present in the cluster

2017-04-21 Thread Vitalyi Brodetskyi



> On Квітень 21, 2017, 11:56 до полудня, Sandor Magyari wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
> > Lines 430 (patched)
> > 
> >
> > But in case we fix updatedConfigTypes in general, to filter out config 
> > types recommended by SA not related to any service in BP, then I think we 
> > don't need to treat core-site here. May be we can hadnle the null in 
> > general, logging a warn message.
> 
> Sandor Magyari wrote:
> Ok, just reproduced the issue and it seems BlueprintConfigProcessor 
> configures the proxy users regradeless there's HDFS or not, so we had to fix 
> it there, until that we can have this check here.

Please take a look at my and Sumits reply here 
https://hortonworks.jira.com/browse/BUG-76895?focusedCommentId=574902=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-574902


- Vitalyi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58568/#review172630
---


On Квітень 20, 2017, 2:19 після полудня, Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58568/
> ---
> 
> (Updated Квітень 20, 2017, 2:19 після полудня)
> 
> 
> Review request for Ambari, Madhuvanthi Radhakrishnan, Sumit Mohanty, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-20802
> https://issues.apache.org/jira/browse/AMBARI-20802
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When a minimal Blueprint install was attempted in that issue, some failures 
> occurred during the Blueprint deployment.
> After some investigation, we determined that the Blueprints processor was 
> throwing a NullPointerException, due to some configuration types being 
> considered "updated", even though those configuration types are not included 
> in the "desired configuration" for the cluster, since the services associated 
> with those configuration types are not deployed in this current cluster.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
>  ce36208 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
>  be79331 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
>  6cd6d35 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/stack_advisor.py 
> ad35688 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 
> 7ef5fad 
>   ambari-server/src/test/python/stacks/2.1/common/test_stack_advisor.py 
> f9fb1f5 
>   ambari-server/src/test/python/stacks/2.6/common/test_stack_advisor.py 
> 2d7322d 
> 
> 
> Diff: https://reviews.apache.org/r/58568/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 58568: StackAdvisor should not recommend configuration types for services that are not present in the cluster

2017-04-21 Thread Vitalyi Brodetskyi



> On Квітень 21, 2017, 11:35 до полудня, Sebastian Toader wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
> > Lines 430 (patched)
> > 
> >
> > Why is this check needed? We should ensure that "core-site" it's not in 
> > the ```updatedConfigTypes``` (e.g. remove not needed config types from 
> > ```updatedConfigTypes``` upfront)

Please take a look at my and Sumits reply here 
https://hortonworks.jira.com/browse/BUG-76895?focusedCommentId=574902=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-574902


- Vitalyi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58568/#review172627
---


On Квітень 20, 2017, 2:19 після полудня, Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58568/
> ---
> 
> (Updated Квітень 20, 2017, 2:19 після полудня)
> 
> 
> Review request for Ambari, Madhuvanthi Radhakrishnan, Sumit Mohanty, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-20802
> https://issues.apache.org/jira/browse/AMBARI-20802
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When a minimal Blueprint install was attempted in that issue, some failures 
> occurred during the Blueprint deployment.
> After some investigation, we determined that the Blueprints processor was 
> throwing a NullPointerException, due to some configuration types being 
> considered "updated", even though those configuration types are not included 
> in the "desired configuration" for the cluster, since the services associated 
> with those configuration types are not deployed in this current cluster.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
>  ce36208 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
>  be79331 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
>  6cd6d35 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/stack_advisor.py 
> ad35688 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 
> 7ef5fad 
>   ambari-server/src/test/python/stacks/2.1/common/test_stack_advisor.py 
> f9fb1f5 
>   ambari-server/src/test/python/stacks/2.6/common/test_stack_advisor.py 
> 2d7322d 
> 
> 
> Diff: https://reviews.apache.org/r/58568/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 58615: Hive view 2.0 Error while uploading a table with partitioned columns

2017-04-21 Thread Gaurav Nagar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58615/#review172633
---


Ship it!




Ship It!

- Gaurav Nagar


On April 21, 2017, 12:06 p.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58615/
> ---
> 
> (Updated April 21, 2017, 12:06 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-20814
> https://issues.apache.org/jira/browse/AMBARI-20814
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Partition information was handled in all queries except the insert from 
> query. 
> Done the required change to get the partition information from UI and using 
> it build 'insert from query'
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/InsertFromQueryGenerator.java
>  8e22fc72b7 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/query/InsertFromQueryInput.java
>  4ff61b40a4 
>   contrib/views/hive20/src/main/resources/ui/app/adapters/application.js 
> 42935fc573 
>   
> contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/upload-table.js
>  5fee140bee 
> 
> 
> Diff: https://reviews.apache.org/r/58615/diff/1/
> 
> 
> Testing
> ---
> 
> manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 58568: StackAdvisor should not recommend configuration types for services that are not present in the cluster

2017-04-21 Thread Sandor Magyari



> On April 21, 2017, 11:56 a.m., Sandor Magyari wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
> > Lines 430 (patched)
> > 
> >
> > But in case we fix updatedConfigTypes in general, to filter out config 
> > types recommended by SA not related to any service in BP, then I think we 
> > don't need to treat core-site here. May be we can hadnle the null in 
> > general, logging a warn message.

Ok, just reproduced the issue and it seems BlueprintConfigProcessor configures 
the proxy users regradeless there's HDFS or not, so we had to fix it there, 
until that we can have this check here.


- Sandor


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58568/#review172630
---


On April 20, 2017, 2:19 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58568/
> ---
> 
> (Updated April 20, 2017, 2:19 p.m.)
> 
> 
> Review request for Ambari, Madhuvanthi Radhakrishnan, Sumit Mohanty, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-20802
> https://issues.apache.org/jira/browse/AMBARI-20802
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When a minimal Blueprint install was attempted in that issue, some failures 
> occurred during the Blueprint deployment.
> After some investigation, we determined that the Blueprints processor was 
> throwing a NullPointerException, due to some configuration types being 
> considered "updated", even though those configuration types are not included 
> in the "desired configuration" for the cluster, since the services associated 
> with those configuration types are not deployed in this current cluster.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
>  ce36208 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
>  be79331 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
>  6cd6d35 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/stack_advisor.py 
> ad35688 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 
> 7ef5fad 
>   ambari-server/src/test/python/stacks/2.1/common/test_stack_advisor.py 
> f9fb1f5 
>   ambari-server/src/test/python/stacks/2.6/common/test_stack_advisor.py 
> 2d7322d 
> 
> 
> Diff: https://reviews.apache.org/r/58568/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 58613: Need to show appropriate error message while deleting the workflow history in project manager


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58613/#review172631
---


Ship it!




Ship It!

- venkat sairam


On April 21, 2017, 12:02 p.m., Supreeth Sharma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58613/
> ---
> 
> (Updated April 21, 2017, 12:02 p.m.)
> 
> 
> Review request for Ambari, belliraj hb, Padma Priya N, Rohit Choudhary, and 
> venkat sairam.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Changed the message to indicate that item is getting deleted only from the 
> history and file will still be available in HDFS file path
> 
> 
> Diffs
> -
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/drafts-wf.js 
> ed448d9 
>   contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less abb0637 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/drafts-wf.hbs
>  05599e5 
> 
> 
> Diff: https://reviews.apache.org/r/58613/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested the changes
> 
> 
> Thanks,
> 
> Supreeth Sharma
> 
>

Review Request 58614: Project manager window is not opening for the second time


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58614/
---

Review request for Ambari, belliraj hb, Padma Priya N, Rohit Choudhary, and 
Supreeth Sharma.


Bugs: AMBARI-20793
https://issues.apache.org/jira/browse/AMBARI-20793


Repository: ambari


Description
---

We have handled the kepyboard and out of clicks scenario to resolve the issue


Diffs
-

  contrib/views/wfmanager/src/main/resources/ui/app/components/drafts-wf.js 
ed448d9 
  
contrib/views/wfmanager/src/main/resources/ui/app/components/recent-projects.js 
bbc51cc 


Diff: https://reviews.apache.org/r/58614/diff/1/


Testing
---

Manual testing done


Thanks,

venkat sairam

Review Request 58613: Need to show appropriate error message while deleting the workflow history in project manager

2017-04-21 Thread Supreeth Sharma


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58613/
---

Review request for Ambari, belliraj hb, Padma Priya N, Rohit Choudhary, and 
venkat sairam.


Repository: ambari


Description
---

Changed the message to indicate that item is getting deleted only from the 
history and file will still be available in HDFS file path


Diffs
-

  contrib/views/wfmanager/src/main/resources/ui/app/components/drafts-wf.js 
ed448d9 
  contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less abb0637 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/drafts-wf.hbs
 05599e5 


Diff: https://reviews.apache.org/r/58613/diff/1/


Testing
---

Manually tested the changes


Thanks,

Supreeth Sharma

Re: Review Request 58568: StackAdvisor should not recommend configuration types for services that are not present in the cluster

2017-04-21 Thread Sandor Magyari


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58568/#review172630
---




ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
Lines 430 (patched)


But in case we fix updatedConfigTypes in general, to filter out config 
types recommended by SA not related to any service in BP, then I think we don't 
need to treat core-site here. May be we can hadnle the null in general, logging 
a warn message.


- Sandor Magyari


On April 20, 2017, 2:19 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58568/
> ---
> 
> (Updated April 20, 2017, 2:19 p.m.)
> 
> 
> Review request for Ambari, Madhuvanthi Radhakrishnan, Sumit Mohanty, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-20802
> https://issues.apache.org/jira/browse/AMBARI-20802
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When a minimal Blueprint install was attempted in that issue, some failures 
> occurred during the Blueprint deployment.
> After some investigation, we determined that the Blueprints processor was 
> throwing a NullPointerException, due to some configuration types being 
> considered "updated", even though those configuration types are not included 
> in the "desired configuration" for the cluster, since the services associated 
> with those configuration types are not deployed in this current cluster.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
>  ce36208 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
>  be79331 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
>  6cd6d35 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/stack_advisor.py 
> ad35688 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 
> 7ef5fad 
>   ambari-server/src/test/python/stacks/2.1/common/test_stack_advisor.py 
> f9fb1f5 
>   ambari-server/src/test/python/stacks/2.6/common/test_stack_advisor.py 
> 2d7322d 
> 
> 
> Diff: https://reviews.apache.org/r/58568/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 58568: StackAdvisor should not recommend configuration types for services that are not present in the cluster

2017-04-21 Thread Sebastian Toader


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58568/#review172627
---




ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
Lines 430 (patched)


Why is this check needed? We should ensure that "core-site" it's not in the 
```updatedConfigTypes``` (e.g. remove not needed config types from 
```updatedConfigTypes``` upfront)


- Sebastian Toader


On April 20, 2017, 4:19 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58568/
> ---
> 
> (Updated April 20, 2017, 4:19 p.m.)
> 
> 
> Review request for Ambari, Madhuvanthi Radhakrishnan, Sumit Mohanty, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-20802
> https://issues.apache.org/jira/browse/AMBARI-20802
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When a minimal Blueprint install was attempted in that issue, some failures 
> occurred during the Blueprint deployment.
> After some investigation, we determined that the Blueprints processor was 
> throwing a NullPointerException, due to some configuration types being 
> considered "updated", even though those configuration types are not included 
> in the "desired configuration" for the cluster, since the services associated 
> with those configuration types are not deployed in this current cluster.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
>  ce36208 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
>  be79331 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
>  6cd6d35 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/stack_advisor.py 
> ad35688 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 
> 7ef5fad 
>   ambari-server/src/test/python/stacks/2.1/common/test_stack_advisor.py 
> f9fb1f5 
>   ambari-server/src/test/python/stacks/2.6/common/test_stack_advisor.py 
> 2d7322d 
> 
> 
> Diff: https://reviews.apache.org/r/58568/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 58567: Need way to explicitly ask for workflow name

2017-04-21 Thread belliraj hb


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58567/#review172626
---


Ship it!




Ship It!

- belliraj hb


On April 21, 2017, 8:35 a.m., Supreeth Sharma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58567/
> ---
> 
> (Updated April 21, 2017, 8:35 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Padma Priya N, Rohit Choudhary, and 
> venkat sairam.
> 
> 
> Bugs: AMBARI-20729
> https://issues.apache.org/jira/browse/AMBARI-20729
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Made the code change to explicitly ask for names while creating coordinator 
> and bundle
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js 
> 99f4fa7 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 
> fba4db5 
> 
> 
> Diff: https://reviews.apache.org/r/58567/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing done
> 
> 
> Thanks,
> 
> Supreeth Sharma
> 
>

Re: Review Request 58567: Need way to explicitly ask for workflow name


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58567/#review172625
---


Ship it!




Ship It!

- venkat sairam


On April 21, 2017, 8:35 a.m., Supreeth Sharma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58567/
> ---
> 
> (Updated April 21, 2017, 8:35 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Padma Priya N, Rohit Choudhary, and 
> venkat sairam.
> 
> 
> Bugs: AMBARI-20729
> https://issues.apache.org/jira/browse/AMBARI-20729
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Made the code change to explicitly ask for names while creating coordinator 
> and bundle
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js 
> 99f4fa7 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 
> fba4db5 
> 
> 
> Diff: https://reviews.apache.org/r/58567/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing done
> 
> 
> Thanks,
> 
> Supreeth Sharma
> 
>

Re: Review Request 58567: Need way to explicitly ask for workflow name

2017-04-21 Thread Padma Priya N


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58567/#review172618
---


Ship it!




Ship It!

- Padma Priya N


On April 21, 2017, 8:35 a.m., Supreeth Sharma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58567/
> ---
> 
> (Updated April 21, 2017, 8:35 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Padma Priya N, Rohit Choudhary, and 
> venkat sairam.
> 
> 
> Bugs: AMBARI-20729
> https://issues.apache.org/jira/browse/AMBARI-20729
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Made the code change to explicitly ask for names while creating coordinator 
> and bundle
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js 
> 99f4fa7 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 
> fba4db5 
> 
> 
> Diff: https://reviews.apache.org/r/58567/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing done
> 
> 
> Thanks,
> 
> Supreeth Sharma
> 
>

Review Request 58567: Need way to explicitly ask for workflow name

2017-04-21 Thread Supreeth Sharma


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58567/
---

Review request for Ambari, belliraj hb, Padma Priya N, Rohit Choudhary, and 
venkat sairam.


Bugs: AMBARI-20729
https://issues.apache.org/jira/browse/AMBARI-20729


Repository: ambari


Description
---

Made the code change to explicitly ask for names while creating coordinator and 
bundle


Diffs
-

  contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js 
99f4fa7 
  contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 
fba4db5 


Diff: https://reviews.apache.org/r/58567/diff/1/


Testing
---

Manual testing done


Thanks,

Supreeth Sharma

Re: Review Request 58574: BE: Characters used in usernames should be constrained

2017-04-21 Thread Balázs Bence Sári


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58574/#review172614
---


Ship it!




Ship It!

- Balázs Bence Sári


On April 21, 2017, 8:15 a.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58574/
> ---
> 
> (Updated April 21, 2017, 8:15 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Balázs Bence Sári, Robert Levas, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20771
> https://issues.apache.org/jira/browse/AMBARI-20771
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Characters used in usernames should be constrained such that they cannot 
> contain the following characters:
>  Less than symbols ( < )
>  Greater than symbols ( > )
>  Ampersand ( & )
>  Back slashes ( \ )
>  Backtick ( ` )
>  Pipe ( | )
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserEntity.java
>  576ca97 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/UserName.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
>  4ed777b 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 
> fdc19d1 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UserDAOTest.java 
> bb0b0cf 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/SecurityHelperImplTest.java
>  d69d49a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationProviderDisableUserTest.java
>  6b98a5b 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLocalUserProviderTest.java
>  9ff381f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariUserAuthenticationFilterTest.java
>  6541a59 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/UserNameTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/UsersTest.java
>  f426c85 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulatorTest.java
>  e5e36f3 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  e31a428 
> 
> 
> Diff: https://reviews.apache.org/r/58574/diff/3/
> 
> 
> Testing
> ---
> 
> Added new unittest, tested manually at end to end level using curl.
> 
> 
> [root@c6401 vagrant]# curl -H "X-Requested-By: Ambari" -H "Content-Type: 
> application/json" -u admin:admin -d 
> '{"Users/user_name":"admin34`","Users/password":"admin","Users/active":true,"Users/admin":false}'
>  http://c6401.ambari.apache.org:8080/api/v1/users
> {
>   "status" : 400,
>   "message" : "Invalid username: admin34` Avoid characters [<, >, &, |, \, `]"
> }
> 
> Existing tests: PENDING
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 58564: Need to change the arrangement of the action buttons in project manager

2017-04-21 Thread Padma Priya N


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58564/#review172609
---


Ship it!




Ship It!

- Padma Priya N


On April 20, 2017, 12:01 p.m., Supreeth Sharma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58564/
> ---
> 
> (Updated April 20, 2017, 12:01 p.m.)
> 
> 
> Review request for Ambari, belliraj hb, Padma Priya N, Rohit Choudhary, and 
> venkat sairam.
> 
> 
> Bugs: AMBARI-20800
> https://issues.apache.org/jira/browse/AMBARI-20800
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Rearranged the Delete and Close buttons so as to keep the styling consistent.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/drafts-wf.hbs
>  ac28de3 
> 
> 
> Diff: https://reviews.apache.org/r/58564/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing done
> 
> 
> Thanks,
> 
> Supreeth Sharma
> 
>

Re: Review Request 58577: Autofix db leads to dangling entries in ClusterConfigMapping table



> On April 20, 2017, 8:03 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
> > Lines 530-532 (original), 530-532 (patched)
> > 
> >
> > Maybe these should be Log.info ?

done


> On April 20, 2017, 8:03 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterDAO.java
> > Lines 380 (patched)
> > 
> >
> > I think you should use version_tag instead of timestamp ...

thanks, fixed


- Dmitro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58577/#review172514
---


On April 21, 2017, 11:18 a.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58577/
> ---
> 
> (Updated April 21, 2017, 11:18 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-20805
> https://issues.apache.org/jira/browse/AMBARI-20805
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Existing implementation removes all entities of the same type
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  4cdeecb153 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterDAO.java 
> b727c720bb 
> 
> 
> Diff: https://reviews.apache.org/r/58577/diff/2/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 58577: Autofix db leads to dangling entries in ClusterConfigMapping table


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58577/
---

(Updated April 21, 2017, 11:18 a.m.)


Review request for Ambari, Jonathan Hurley and Nate Cole.


Changes
---

fix review comments


Bugs: AMBARI-20805
https://issues.apache.org/jira/browse/AMBARI-20805


Repository: ambari


Description
---

Existing implementation removes all entities of the same type


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
 4cdeecb153 
  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterDAO.java 
b727c720bb 


Diff: https://reviews.apache.org/r/58577/diff/2/

Changes: https://reviews.apache.org/r/58577/diff/1-2/


Testing
---

mvn clean test


Thanks,

Dmitro Lisnichenko

Re: Review Request 58574: BE: Characters used in usernames should be constrained

2017-04-21 Thread Attila Magyar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58574/
---

(Updated April 21, 2017, 8:15 a.m.)


Review request for Ambari, Attila Doroszlai, Balázs Bence Sári, Robert Levas, 
and Sebastian Toader.


Changes
---

added license


Bugs: AMBARI-20771
https://issues.apache.org/jira/browse/AMBARI-20771


Repository: ambari


Description
---

Characters used in usernames should be constrained such that they cannot 
contain the following characters:
 Less than symbols ( < )
 Greater than symbols ( > )
 Ampersand ( & )
 Back slashes ( \ )
 Backtick ( ` )
 Pipe ( | )


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserEntity.java
 576ca97 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/UserName.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
 4ed777b 
  ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 
fdc19d1 
  ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UserDAOTest.java 
bb0b0cf 
  
ambari-server/src/test/java/org/apache/ambari/server/security/SecurityHelperImplTest.java
 d69d49a 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationProviderDisableUserTest.java
 6b98a5b 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLocalUserProviderTest.java
 9ff381f 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariUserAuthenticationFilterTest.java
 6541a59 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/UserNameTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/UsersTest.java
 f426c85 
  
ambari-server/src/test/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulatorTest.java
 e5e36f3 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
 e31a428 


Diff: https://reviews.apache.org/r/58574/diff/3/

Changes: https://reviews.apache.org/r/58574/diff/2-3/


Testing
---

Added new unittest, tested manually at end to end level using curl.


[root@c6401 vagrant]# curl -H "X-Requested-By: Ambari" -H "Content-Type: 
application/json" -u admin:admin -d 
'{"Users/user_name":"admin34`","Users/password":"admin","Users/active":true,"Users/admin":false}'
 http://c6401.ambari.apache.org:8080/api/v1/users
{
  "status" : 400,
  "message" : "Invalid username: admin34` Avoid characters [<, >, &, |, \, `]"
}

Existing tests: PENDING


Thanks,

Attila Magyar

Re: Review Request 58592: Upgrade is not taking care of AMBARI-15677