date:20170427

Re: Review Request 58780: WFM: Clicking search icon in workflow dashboard throws error

2017-04-27 Thread Anita Jebaraj



> On April 28, 2017, 5:24 a.m., Padma Priya N wrote:
> > Ship It!

Thank you for reviewing, can you please help in pushing the changes


- Anita


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58780/#review173292
---


On April 27, 2017, 4:41 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58780/
> ---
> 
> (Updated April 27, 2017, 4:41 p.m.)
> 
> 
> Review request for Ambari, belliraj hb, Di Li, DIPAYAN BHOWMICK, Padma Priya 
> N, and Sangeeta Ravindran.
> 
> 
> Bugs: AMBARI-20850
> https://issues.apache.org/jira/browse/AMBARI-20850
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Clicking on search icon when the filter is empty in workflow dashboard throws 
> the error Remote API failed as in screenshot
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/search-create-new-bar.js
>  7e69dea 
> 
> 
> Diff: https://reviews.apache.org/r/58780/diff/2/
> 
> 
> Testing
> ---
> 
> Tested Manually
> 
> 
> File Attachments
> 
> 
> error
>   
> https://reviews.apache.org/media/uploaded/files/2017/04/27/6027e0bc-d946-4d10-80b1-440486278022__wf-error.jpg
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 58780: WFM: Clicking search icon in workflow dashboard throws error

2017-04-27 Thread belliraj hb


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58780/#review173293
---


Ship it!




Ship It!

- belliraj hb


On April 27, 2017, 4:41 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58780/
> ---
> 
> (Updated April 27, 2017, 4:41 p.m.)
> 
> 
> Review request for Ambari, belliraj hb, Di Li, DIPAYAN BHOWMICK, Padma Priya 
> N, and Sangeeta Ravindran.
> 
> 
> Bugs: AMBARI-20850
> https://issues.apache.org/jira/browse/AMBARI-20850
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Clicking on search icon when the filter is empty in workflow dashboard throws 
> the error Remote API failed as in screenshot
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/search-create-new-bar.js
>  7e69dea 
> 
> 
> Diff: https://reviews.apache.org/r/58780/diff/2/
> 
> 
> Testing
> ---
> 
> Tested Manually
> 
> 
> File Attachments
> 
> 
> error
>   
> https://reviews.apache.org/media/uploaded/files/2017/04/27/6027e0bc-d946-4d10-80b1-440486278022__wf-error.jpg
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 58797: AMBARI-20868 : Ranger admin start fails when Ambari Infra is turned off.

2017-04-27 Thread Mugdha Varadkar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58797/#review173287
---


Ship it!




Ship It!

- Mugdha Varadkar


On April 27, 2017, 3:51 p.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58797/
> ---
> 
> (Updated April 27, 2017, 3:51 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Mugdha 
> Varadkar, Oliver Szabo, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-20868
> https://issues.apache.org/jira/browse/AMBARI-20868
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ranger Admin start fails when Ambari Infra or External Solr service is down,. 
> need to handle errors and ensure Ranger start works, despite solr service 
> being down.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  e56a705 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.7.0/properties/ranger-solrconfig.xml.j2
>  34ce70d 
> 
> 
> Diff: https://reviews.apache.org/r/58797/diff/2/
> 
> 
> Testing
> ---
> 
> Verified fresh install on Cent-OS 6.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Re: Review Request 58798: AMBARI-20873 : Atlas gc-worker logs are not generated due to incorrect configuration

2017-04-27 Thread Mugdha Varadkar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58798/#review173286
---


Ship it!




Ship It!

- Mugdha Varadkar


On April 27, 2017, 2:39 p.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58798/
> ---
> 
> (Updated April 27, 2017, 2:39 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan 
> Neethiraj, Mugdha Varadkar, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20873
> https://issues.apache.org/jira/browse/AMBARI-20873
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Atlas gc-worker logs are not generated due to missing / in atlas 
> configurations.
> Currently it is set as -Xloggc:$ATLAS_LOG_DIRgc-worker.log it should actually 
> be -Xloggc:$ATLAS_LOG_DIR/gc-worker.log
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/atlas-env.xml
>  bd0da9f 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
> 1c2ceff 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
>  be8b750 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
>  d822778 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
> 210c4e2 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
> 9a06dd0 
>   ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/config-upgrade.xml 
> f5d87e9 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
>  f7c276b 
>   ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 
> 81757c1 
> 
> 
> Diff: https://reviews.apache.org/r/58798/diff/1/
> 
> 
> Testing
> ---
> 
> Verified fresh install and upgrade on Cent-OS 6.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Re: Review Request 58411: AMBARI-20726: Aggregate alert does not show status properly at Maintenance Mode change

2017-04-27 Thread Qin Liu



> On April 27, 2017, 6:48 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertMaintenanceModeListener.java
> > Line 136 (original), 158-162 (patched)
> > 
> >
> > Let's get rid of this global boolean and just move it directly into the 
> > new method.

Fixed. Thanks Jonathan!


- Qin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58411/#review173234
---


On April 28, 2017, 2:42 a.m., Qin Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58411/
> ---
> 
> (Updated April 28, 2017, 2:42 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Jayush Luniya.
> 
> 
> Bugs: AMBARI-20726
> https://issues.apache.org/jira/browse/AMBARI-20726
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Aggregate alert does not show status properly at Maintenance Mode change.
> 
> Steps to reproduce:
> Install a cluster that has HBase with one regionserver installed.
> 
> Scenario 1:
> 1. Turn On Maintenance Mode on the RegionServer or on the RegionServer host 
> or on the HBase service.
> 2. Stop the RegionServer after that.
> 3. No red alerts will show as expected.
>Percent RegionServers Available - OK affected: [0], total: [1]
> 4. Now Turn Off Maintenance Mode, still keep the RegionServer down.
>But Percent RegionServers Available alert will still show "OK" - "CRIT" is 
> expected.
> 
> Scenario 2:
> 1) Stop the RegionServer - Red alert will show as expected.
>Percent RegionServers Available - CRIT affected: [1], total: [1]
> 2) Now Turn On Maintenance Mode - For RegionServer status, Red alert will be 
> gone as expected.
>But Percent RegionServers Available alert will still show "CRIT" - "OK" is 
> expected.
>
> The fix is to fire an AggregateAlertRecalculateEvent to refresh aggregate 
> alert at Maintenance Mode change time.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertMaintenanceModeListener.java
>  847a207 
>   ambari-server/src/main/java/org/apache/ambari/server/state/AlertState.java 
> 8e04eb1 
>   
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/AlertMaintenanceModeListenerTest.java
>  bdc662a 
> 
> 
> Diff: https://reviews.apache.org/r/58411/diff/4/
> 
> 
> Testing
> ---
> 
> The fix has been manually tested via HDP UI.
> The unit testcase AlertMaintenanceModeListenerTest.java has been updated to 
> reflect the change.
> 
> testrun_ambari-server Results :
> Tests run: 4977, Failures: 0, Errors: 0, Skipped: 39
> 
> The skipped testcases has nothing to do with the fix.
> 
> 
> File Attachments
> 
> 
> AMBARI-20726.patch
>   
> https://reviews.apache.org/media/uploaded/files/2017/04/24/011309ea-84c8-470c-b467-bbe2a2372f46__AMBARI-20726.patch
> AMBARI-20726_2.patch
>   
> https://reviews.apache.org/media/uploaded/files/2017/04/26/8aa802d1-17a9-4871-8ea1-1449a29506ae__AMBARI-20726_2.patch
> 
> 
> Thanks,
> 
> Qin Liu
> 
>

Re: Review Request 58411: AMBARI-20726: Aggregate alert does not show status properly at Maintenance Mode change

2017-04-27 Thread Qin Liu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58411/
---

(Updated April 28, 2017, 2:42 a.m.)

Review request for Ambari, Jonathan Hurley and Jayush Luniya.

Bugs: AMBARI-20726
https://issues.apache.org/jira/browse/AMBARI-20726

Repository: ambari

Description
---

Aggregate alert does not show status properly at Maintenance Mode change.

Steps to reproduce:
Install a cluster that has HBase with one regionserver installed.

Scenario 1:
1. Turn On Maintenance Mode on the RegionServer or on the RegionServer host or
on the HBase service.
2. Stop the RegionServer after that.
3. No red alerts will show as expected.
Percent RegionServers Available - OK affected: [0], total: [1]
4. Now Turn Off Maintenance Mode, still keep the RegionServer down.
But Percent RegionServers Available alert will still show "OK" - "CRIT" is
expected.

Scenario 2:
1) Stop the RegionServer - Red alert will show as expected.
Percent RegionServers Available - CRIT affected: [1], total: [1]
2) Now Turn On Maintenance Mode - For RegionServer status, Red alert will be
gone as expected.
But Percent RegionServers Available alert will still show "CRIT" - "OK" is
expected.

The fix is to fire an AggregateAlertRecalculateEvent to refresh aggregate alert
at Maintenance Mode change time.

Diffs (updated)
-

ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertMaintenanceModeListener.java
847a207
ambari-server/src/main/java/org/apache/ambari/server/state/AlertState.java
8e04eb1

57 matches

Mail list logo