Re: Review Request 58411: AMBARI-20726: Aggregate alert does not show status properly at Maintenance Mode change

[Qin Liu]

> On May 8, 2017, 11:42 p.m., Eric Yang wrote:
> > Ship It!

Thank you so much, Eric!


- Qin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58411/#review174245
---


On May 3, 2017, 4:29 p.m., Qin Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58411/
> ---
> 
> (Updated May 3, 2017, 4:29 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Jayush 
> Luniya.
> 
> 
> Bugs: AMBARI-20726
> https://issues.apache.org/jira/browse/AMBARI-20726
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Aggregate alert does not show status properly at Maintenance Mode change.
> 
> Steps to reproduce:
> Install a cluster that has HBase with one regionserver installed.
> 
> Scenario 1:
> 1. Turn On Maintenance Mode on the RegionServer or on the RegionServer host 
> or on the HBase service.
> 2. Stop the RegionServer after that.
> 3. No red alerts will show as expected.
>Percent RegionServers Available - OK affected: [0], total: [1]
> 4. Now Turn Off Maintenance Mode, still keep the RegionServer down.
>But Percent RegionServers Available alert will still show "OK" - "CRIT" is 
> expected.
> 
> Scenario 2:
> 1) Stop the RegionServer - Red alert will show as expected.
>Percent RegionServers Available - CRIT affected: [1], total: [1]
> 2) Now Turn On Maintenance Mode - For RegionServer status, Red alert will be 
> gone as expected.
>But Percent RegionServers Available alert will still show "CRIT" - "OK" is 
> expected.
>
> The fix is to fire an AggregateAlertRecalculateEvent to refresh aggregate 
> alert at Maintenance Mode change time.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertMaintenanceModeListener.java
>  847a207 
>   ambari-server/src/main/java/org/apache/ambari/server/state/AlertState.java 
> 8e04eb1 
>   
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/AlertMaintenanceModeListenerTest.java
>  bdc662a 
> 
> 
> Diff: https://reviews.apache.org/r/58411/diff/4/
> 
> 
> Testing
> ---
> 
> The fix has been manually tested via HDP UI.
> The unit testcase AlertMaintenanceModeListenerTest.java has been updated to 
> reflect the change.
> 
> testrun_ambari-server Results :
> Tests run: 4977, Failures: 0, Errors: 0, Skipped: 39
> 
> The skipped testcases has nothing to do with the fix.
> 
> 
> File Attachments
> 
> 
> AMBARI-20726.patch
>   
> https://reviews.apache.org/media/uploaded/files/2017/04/24/011309ea-84c8-470c-b467-bbe2a2372f46__AMBARI-20726.patch
> AMBARI-20726_2.patch
>   
> https://reviews.apache.org/media/uploaded/files/2017/04/26/8aa802d1-17a9-4871-8ea1-1449a29506ae__AMBARI-20726_2.patch
> 
> 
> Thanks,
> 
> Qin Liu
> 
>

Re: Review Request 58411: AMBARI-20726: Aggregate alert does not show status properly at Maintenance Mode change

[Eric Yang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58411/#review174245
---


Ship it!




Ship It!

- Eric Yang


On May 3, 2017, 4:29 p.m., Qin Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58411/
> ---
> 
> (Updated May 3, 2017, 4:29 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Jayush 
> Luniya.
> 
> 
> Bugs: AMBARI-20726
> https://issues.apache.org/jira/browse/AMBARI-20726
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Aggregate alert does not show status properly at Maintenance Mode change.
> 
> Steps to reproduce:
> Install a cluster that has HBase with one regionserver installed.
> 
> Scenario 1:
> 1. Turn On Maintenance Mode on the RegionServer or on the RegionServer host 
> or on the HBase service.
> 2. Stop the RegionServer after that.
> 3. No red alerts will show as expected.
>Percent RegionServers Available - OK affected: [0], total: [1]
> 4. Now Turn Off Maintenance Mode, still keep the RegionServer down.
>But Percent RegionServers Available alert will still show "OK" - "CRIT" is 
> expected.
> 
> Scenario 2:
> 1) Stop the RegionServer - Red alert will show as expected.
>Percent RegionServers Available - CRIT affected: [1], total: [1]
> 2) Now Turn On Maintenance Mode - For RegionServer status, Red alert will be 
> gone as expected.
>But Percent RegionServers Available alert will still show "CRIT" - "OK" is 
> expected.
>
> The fix is to fire an AggregateAlertRecalculateEvent to refresh aggregate 
> alert at Maintenance Mode change time.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertMaintenanceModeListener.java
>  847a207 
>   ambari-server/src/main/java/org/apache/ambari/server/state/AlertState.java 
> 8e04eb1 
>   
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/AlertMaintenanceModeListenerTest.java
>  bdc662a 
> 
> 
> Diff: https://reviews.apache.org/r/58411/diff/4/
> 
> 
> Testing
> ---
> 
> The fix has been manually tested via HDP UI.
> The unit testcase AlertMaintenanceModeListenerTest.java has been updated to 
> reflect the change.
> 
> testrun_ambari-server Results :
> Tests run: 4977, Failures: 0, Errors: 0, Skipped: 39
> 
> The skipped testcases has nothing to do with the fix.
> 
> 
> File Attachments
> 
> 
> AMBARI-20726.patch
>   
> https://reviews.apache.org/media/uploaded/files/2017/04/24/011309ea-84c8-470c-b467-bbe2a2372f46__AMBARI-20726.patch
> AMBARI-20726_2.patch
>   
> https://reviews.apache.org/media/uploaded/files/2017/04/26/8aa802d1-17a9-4871-8ea1-1449a29506ae__AMBARI-20726_2.patch
> 
> 
> Thanks,
> 
> Qin Liu
> 
>

Re: Review Request 58864: AMBARI-20698 Ability to export blueprint via Ambari installer UI

[Amruta Borkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58864/
---

(Updated May 8, 2017, 9:45 p.m.)


Review request for Ambari, Di Li, Jaimin Jetly, Jayush Luniya, Robert 
Nettleton, Sangeeta Ravindran, Sumit Mohanty, and Yusaku Sako.


Changes
---

Updated based on Sangeeta's review.
Hello Jaimin, Yusaku, could you please review the patch? 
Thank you.


Bugs: AMBARI-20698
https://issues.apache.org/jira/browse/AMBARI-20698


Repository: ambari


Description
---

UI be able to export a blueprint when a user reaches the Deploy page and the bp 
can be used to install a cluster later on.
This patch exports blueprint and template. Currently HostGroups are formed only 
based on the component mapping. In this patch configGroups are not addressed. 
ConfigGroup and other improvements will be addressed in next revisions of this 
functionality.


Diffs (updated)
-

  ambari-web/app/controllers/wizard/step8_controller.js 4678d03a48 
  ambari-web/app/messages.js 8f8d981af7 
  ambari-web/app/templates/wizard/step8.hbs ac32710468 
  ambari-web/test/controllers/wizard/step8_test.js 7cdb69ab34 


Diff: https://reviews.apache.org/r/58864/diff/3/

Changes: https://reviews.apache.org/r/58864/diff/2-3/


Testing
---

Manual Testing done. I have attached blueprint.json and clustertemplate.json 
files that are currently generated with this patch applied.


File Attachments


exported_blueprint
  
https://reviews.apache.org/media/uploaded/files/2017/04/28/897160b1-46d8-49d1-bc87-f14249718c26__exported_blueprint_.json
exported_clustertemplate
  
https://reviews.apache.org/media/uploaded/files/2017/04/28/e53d037e-a77e-487e-ac08-ce754e4afc97__exported_clustertemplate.json


Thanks,

Amruta Borkar

Review Request 59066: Remove cluster_version use

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59066/
---

Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Dmitro 
Lisnichenko, and Jonathan Hurley.


Bugs: AMBARI-20957
https://issues.apache.org/jira/browse/AMBARI-20957


Repository: ambari


Description
---

Patch and Service upgrades no longer use cluster_version to track a repository 
for upgrade purposes.


Diffs
-

  ambari-server/src/main/java/org/apache/ambari/annotations/Experimental.java 
f51991c8c8 
  
ambari-server/src/main/java/org/apache/ambari/server/StateRecoveryManager.java 
26e5be8216 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
 63eb660e57 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
 707c75681a 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/HardcodedStackVersionPropertiesCheck.java
 314d1a7341 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/InstallPackagesCheck.java
 2c20762194 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/YarnTimelineServerStatePreservingCheck.java
 2200a45306 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java
 835d607275 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 1d43093de2 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 e2bd50f25a 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
 6687942b3f 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
 fd52a3f8b8 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
 c24410788f 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java
 71b9b6bb9a 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java
 d2f3f8d7e1 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java
 c611037c40 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
 b49b66eea8 
  
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/DistributeRepositoriesActionListener.java
 3fda1603f7 
  
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListener.java
 b4ddf09027 
  
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java
 33c622f08b 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterVersionDAO.java
 1bcca60911 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java
 527fd7a009 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterVersionEntity.java
 f1867b47e7 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java
 f5d669e4f5 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
 a4cc757346 
  ambari-server/src/main/java/org/apache/ambari/server/stack/RepoUtil.java 
1380f933c7 
  
ambari-server/src/main/java/org/apache/ambari/server/stack/UpdateActiveRepoVersionOnStartup.java
 29af6a8716 
  ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
88c5a59955 
  
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
 21c275b0b5 
  
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java
 99bc781b78 
  
ambari-server/src/main/java/org/apache/ambari/server/state/services/RetryUpgradeActionService.java
 584ce9884f 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog220.java
 11e90ee386 
  ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql c2a923973f 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 48d2c35692 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 26201fc292 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 156fc08f0b 
  ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 979ea44ed1 
  ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 08c71ff8f5 
  ambari-server/src/main/resources/META-INF/persistence.xml 03756508ee 
  
ambari-server/src/test/java/org/apache/ambari/server/StateRecoveryManagerTest.java
 c5be8f416b 
  
ambari-server/src/test/java/org/apache/ambari/server/agent/HeartbeatProcessorTest.java
 5afeb77f9e 
  
ambari-server/src/test/java/org/apache/ambari/server/agent/HeartbeatTestHelper.java
 6e1ebdd840 
  

Review Request 59062: HDP 3.0 TP - create Service Advisor for Atlas

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59062/
---

Review request for Ambari, Alejandro Fernandez, Dmytro Sen, and Sumit Mohanty.


Bugs: AMBARI-20960
https://issues.apache.org/jira/browse/AMBARI-20960


Repository: ambari


Description
---

.


Diffs
-

  
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/service_advisor.py
 PRE-CREATION 


Diff: https://reviews.apache.org/r/59062/diff/1/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 59045: Insecure SSL: Server Identity Verification Disabled

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59045/#review174217
---


Ship it!




Ship It!

- Robert Levas


On May 8, 2017, 3:13 p.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59045/
> ---
> 
> (Updated May 8, 2017, 3:13 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Robert Levas, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-20953
> https://issues.apache.org/jira/browse/AMBARI-20953
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added option
> 
> [security]
> ca_cert_path=/path/to/pem/formatted/cert/file.pem
> 
> to agent configuration.
> All requests that using https will use file.pem certificates to validate 
> responce from server.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 16fb97d 
>   ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
> 28574cc 
>   ambari-agent/src/main/python/ambari_agent/NetUtil.py fc19605 
>   ambari-agent/src/main/python/ambari_agent/alerts/web_alert.py 79b1c3b 
>   ambari-common/src/main/python/ambari_commons/inet_utils.py d44107d 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/curl_krb_request.py
>  557db58 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> bafb8e2 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py
>  c9b63ff 
> 
> 
> Diff: https://reviews.apache.org/r/59045/diff/3/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>

Re: Review Request 59053: Review for AMBARI-20946

[Diego Santesteban]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59053/
---

(Updated May 8, 2017, 7:09 p.m.)


Review request for Ambari and Tim Thorpe.


Changes
---

Updated the comment that Tim mentioned.


Bugs: AMBARI-20946
https://issues.apache.org/jira/browse/AMBARI-20946


Repository: ambari


Description
---

I added an extra case in resourceFilesKeeper.py to recreate the archive.zip 
file if it doesn't exist, even when the saved and current directory hashes are 
matching.

I added one new test case to make sure this case is working, and modified one 
existing test case to make it specific for the other case (where the 
archive.zip file does exist and the hashes match).


Diffs (updated)
-

  ambari-server/src/main/python/ambari_server/resourceFilesKeeper.py dba6833924 
  ambari-server/src/test/python/TestResourceFilesKeeper.py 4f7dc525d3 


Diff: https://reviews.apache.org/r/59053/diff/2/

Changes: https://reviews.apache.org/r/59053/diff/1-2/


Testing
---

I created a new test case and successfully ran all tests with 'mvn clean test'.

I also applied this change to an existing cluster to ensure that it does fix 
the issue in a real usage case.


Thanks,

Diego Santesteban

Re: Review Request 59050: HDP 3.0 TP - create service definition for Atlas with configs, kerberos, widgets, etc

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59050/#review174206
---


Ship it!




Ship It!

- Alejandro Fernandez


On May 8, 2017, 2:31 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59050/
> ---
> 
> (Updated May 8, 2017, 2:31 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmytro Sen, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20954
> https://issues.apache.org/jira/browse/AMBARI-20954
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> .
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/alerts.json 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/configuration/application-properties.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/configuration/atlas-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/configuration/atlas-log4j.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/configuration/atlas-solrconfig.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/configuration/ranger-atlas-audit.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/configuration/ranger-atlas-plugin-properties.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/configuration/ranger-atlas-policymgr-ssl.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/configuration/ranger-atlas-security.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/kerberos.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/package/scripts/atlas_client.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/package/scripts/metadata.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/package/scripts/metadata_server.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/package/scripts/params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/package/scripts/service_check.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/package/scripts/setup_ranger_atlas.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/package/scripts/status_params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/package/templates/atlas_hbase_setup.rb.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/package/templates/atlas_jaas.conf.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/package/templates/atlas_kafka_acl.sh.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/package/templates/input.config-atlas.json.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/package/templates/kafka_jaas.conf.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/quicklinks/quicklinks.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/role_command_order.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/themes/theme.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/themes/theme_version_2.json
>  PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/3.0/services/ATLAS/metainfo.xml 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59050/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 59045: Insecure SSL: Server Identity Verification Disabled

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59045/#review174204
---


Ship it!




Ship It!

- Alejandro Fernandez


On May 8, 2017, 4:26 p.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59045/
> ---
> 
> (Updated May 8, 2017, 4:26 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Robert Levas, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-20953
> https://issues.apache.org/jira/browse/AMBARI-20953
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added option
> 
> [security]
> ca_cert_path=/path/to/pem/formatted/cert/file.pem
> 
> to agent configuration.
> All requests that using https will use file.pem certificates to validate 
> responce from server.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 16fb97d 
>   ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
> 28574cc 
>   ambari-agent/src/main/python/ambari_agent/NetUtil.py fc19605 
>   ambari-agent/src/main/python/ambari_agent/alerts/web_alert.py 79b1c3b 
>   ambari-common/src/main/python/ambari_commons/inet_utils.py d44107d 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/curl_krb_request.py
>  557db58 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> bafb8e2 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py
>  c9b63ff 
> 
> 
> Diff: https://reviews.apache.org/r/59045/diff/2/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>

Review Request 59059: Runtime filtering is not rendering properly

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59059/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
Rohit Choudhary, and venkat sairam.


Bugs: AMBARI-20519
https://issues.apache.org/jira/browse/AMBARI-20519


Repository: ambari


Description
---

- Accomodate JSON interface changes.
- fix arrow position for bloom filter queries.


Diffs
-

  
contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/processor.js
 1a6d4b3 
  
contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js 
c880614 
  
contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/transformer.js
 57fff1e 


Diff: https://reviews.apache.org/r/59059/diff/1/


Testing
---

manually tested.


Thanks,

Pallav Kulshreshtha

Re: Review Request 59053: Review for AMBARI-20946

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59053/#review174203
---


Ship it!




Ship It!

- Alejandro Fernandez


On May 8, 2017, 4:31 p.m., Diego Santesteban wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59053/
> ---
> 
> (Updated May 8, 2017, 4:31 p.m.)
> 
> 
> Review request for Ambari and Tim Thorpe.
> 
> 
> Bugs: AMBARI-20946
> https://issues.apache.org/jira/browse/AMBARI-20946
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> I added an extra case in resourceFilesKeeper.py to recreate the archive.zip 
> file if it doesn't exist, even when the saved and current directory hashes 
> are matching.
> 
> I added one new test case to make sure this case is working, and modified one 
> existing test case to make it specific for the other case (where the 
> archive.zip file does exist and the hashes match).
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/resourceFilesKeeper.py 
> dba6833924 
>   ambari-server/src/test/python/TestResourceFilesKeeper.py 4f7dc525d3 
> 
> 
> Diff: https://reviews.apache.org/r/59053/diff/1/
> 
> 
> Testing
> ---
> 
> I created a new test case and successfully ran all tests with 'mvn clean 
> test'.
> 
> I also applied this change to an existing cluster to ensure that it does fix 
> the issue in a real usage case.
> 
> 
> Thanks,
> 
> Diego Santesteban
> 
>

Re: Review Request 58845: AMBARI-20891 - Allow extensions to auto-link with supported stack versions

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58845/#review174193
---


Ship it!




Ship It!

- Di Li


On May 5, 2017, 6:30 p.m., Tim Thorpe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58845/
> ---
> 
> (Updated May 5, 2017, 6:30 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Di Li, Jonathan Hurley, 
> Jayush Luniya, and Nate Cole.
> 
> 
> Bugs: AMBARI-20891
> https://issues.apache.org/jira/browse/AMBARI-20891
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> It would possible to link extensions to supported stack versions while 
> parsing the stacks, extensions and common-services directories.
> 
> This would allow extensions to avoid making rest API calls to set up the link.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  751ce08 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementHelper.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ExtensionLinkDAO.java
>  3df1cd5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ExtensionLinkEntity.java
>  12b3ce0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ExtensionModule.java
>  ce92ecf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackManager.java 
> 20e28fc 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 
> d3ad351 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ExtensionInfo.java 
> 656a8ce 
>   ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java 
> 353dd86 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/ExtensionMetainfoXml.java
>  77a7250 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerCommonServicesTest.java
>  4e20c2b 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerExtensionTest.java
>  9900eb5 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerMiscTest.java
>  ca24cd9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerMock.java
>  0fe1573 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerTest.java
>  0a0404a 
>   ambari-server/src/test/resources/extensions/EXT/0.1/metainfo.xml 77a832c 
>   ambari-server/src/test/resources/extensions/EXT/0.2/metainfo.xml 04f733c 
>   ambari-server/src/test/resources/extensions/EXT/0.3/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/test/resources/extensions/EXT/0.3/services/OOZIE2/metainfo.xml
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/extensions/EXT/0.3/services/OOZIE2/themes/broken_theme.json
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/repos/repoinfo.xml
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/HBASE/metainfo.xml
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/HDFS/configuration/global.xml
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/HDFS/configuration/hadoop-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/HDFS/configuration/hbase-site.xml
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/HDFS/configuration/hdfs-log4j.xml
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/HDFS/configuration/hdfs-site.xml
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/HDFS/metainfo.xml
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/HDFS/package/dummy-script.py
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/HIVE/metainfo.xml
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/MAPREDUCE/metainfo.xml
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/ZOOKEEPER/metainfo.xml
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/58845/diff/3/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> mvn clean test -Dtest=StackManagerExtensionTest -DskipPythonTests
> 
> mvn clean test 
> 

Re: Review Request 59053: Review for AMBARI-20946

[Tim Thorpe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59053/#review174188
---


Ship it!




Ship It!

- Tim Thorpe


On May 8, 2017, 4:31 p.m., Diego Santesteban wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59053/
> ---
> 
> (Updated May 8, 2017, 4:31 p.m.)
> 
> 
> Review request for Ambari and Tim Thorpe.
> 
> 
> Bugs: AMBARI-20946
> https://issues.apache.org/jira/browse/AMBARI-20946
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> I added an extra case in resourceFilesKeeper.py to recreate the archive.zip 
> file if it doesn't exist, even when the saved and current directory hashes 
> are matching.
> 
> I added one new test case to make sure this case is working, and modified one 
> existing test case to make it specific for the other case (where the 
> archive.zip file does exist and the hashes match).
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/resourceFilesKeeper.py 
> dba6833924 
>   ambari-server/src/test/python/TestResourceFilesKeeper.py 4f7dc525d3 
> 
> 
> Diff: https://reviews.apache.org/r/59053/diff/1/
> 
> 
> Testing
> ---
> 
> I created a new test case and successfully ran all tests with 'mvn clean 
> test'.
> 
> I also applied this change to an existing cluster to ensure that it does fix 
> the issue in a real usage case.
> 
> 
> Thanks,
> 
> Diego Santesteban
> 
>

Re: Review Request 59053: Review for AMBARI-20946

[Tim Thorpe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59053/#review174187
---




ambari-server/src/main/python/ambari_server/resourceFilesKeeper.py
Line 168 (original), 168 (patched)


Should add a comment in here saying the archive will be created if it 
doesn't exist even if there is a hash file with equal to the directories hash.


- Tim Thorpe


On May 8, 2017, 4:31 p.m., Diego Santesteban wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59053/
> ---
> 
> (Updated May 8, 2017, 4:31 p.m.)
> 
> 
> Review request for Ambari and Tim Thorpe.
> 
> 
> Bugs: AMBARI-20946
> https://issues.apache.org/jira/browse/AMBARI-20946
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> I added an extra case in resourceFilesKeeper.py to recreate the archive.zip 
> file if it doesn't exist, even when the saved and current directory hashes 
> are matching.
> 
> I added one new test case to make sure this case is working, and modified one 
> existing test case to make it specific for the other case (where the 
> archive.zip file does exist and the hashes match).
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/resourceFilesKeeper.py 
> dba6833924 
>   ambari-server/src/test/python/TestResourceFilesKeeper.py 4f7dc525d3 
> 
> 
> Diff: https://reviews.apache.org/r/59053/diff/1/
> 
> 
> Testing
> ---
> 
> I created a new test case and successfully ran all tests with 'mvn clean 
> test'.
> 
> I also applied this change to an existing cluster to ensure that it does fix 
> the issue in a real usage case.
> 
> 
> Thanks,
> 
> Diego Santesteban
> 
>

Re: Review Request 59043: AMBARI-20951. Integrate HostService resource with swagger

[Balázs Bence Sári]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59043/#review174186
---


Ship it!




Ship It!

- Balázs Bence Sári


On May 8, 2017, 7 a.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59043/
> ---
> 
> (Updated May 8, 2017, 7 a.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Jaimin Jetly, Jayush Luniya, 
> Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20951
> https://issues.apache.org/jira/browse/AMBARI-20951
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> * documented `HostService`, `HostRequest`, `HostResponse`
> * removed unused attributes
> * introduced constants for common Swagger parameters
> * subresources are not covered yet
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseService.java
>  0185d37f1a9127c2bd414229b8ab7885e849fbf4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java
>  c26c5d85d4c90a1aee81cb5aafbcac49d185c5e2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/HostEventCreator.java
>  d05fe9dce86eaa712807c50744c1fb93000fbe56 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/HostRequest.java
>  a6168394bf4be45497924e73c84aae393d1c53fe 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/HostResponse.java
>  8032801dd7014b9532b5358c8fc44e5250b90c66 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RootServiceResponseFactory.java
>  40fe3697e98acff0a36dd24f3e51193683b5af93 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
>  f604a7f8be9b2dad7810e46444ae79ead73f8a98 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStatusHelper.java
>  96457ed6302f98f6b402eb27f49cffc41bfe4585 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceHostComponentResourceProvider.java
>  c2fb844ff7e81d8291ae27359dac864aadf50430 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ScaleClusterRequest.java
>  b5d2f9de8a297b68ee569b92bc475e39b39986d2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/PropertyHelper.java
>  c747a33a7d352d8614a573a6b9f3f7149ac5df7c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java 
> db228b194e240a0c895072362ae68d1973742cef 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
>  6d12402e9da92985176c8724f6b705304bba03e3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/HostRequest.java
>  168d13b44777b1891e72287de035e99d1064ab72 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/services/HostServiceTest.java
>  6aef04dda19693cd2408dcfce9be5ca8751550e4 
>   
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/HostEventCreatorTest.java
>  2d1cefcfdcb3604d54338c4c0b314c5fbb740b50 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
>  554e0891020d90593aeee76cbeddf65f5b66e2b0 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractResourceProviderTest.java
>  c7613231b13c8402cffe29f90fac2449e0f0a395 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java
>  ac6ac1d299947a3b4ba0f0f41f7a6f851b2a72db 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceHostComponentResourceProviderTest.java
>  f15c9f2baa20fb69b855d24badb144e354b83891 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ScaleClusterRequestTest.java
>  48d1351dc527488cea06168d2fe0fcc90d9a6eb7 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java
>  2d5978b1788572c716ddfaae2e56b9502097e98f 
> 
> 
> Diff: https://reviews.apache.org/r/59043/diff/1/
> 
> 
> Testing
> ---
> 
> Unit tests pass, except `ServicePropertiesTest`, which fails due to 
> [AMBARI-20443](https://issues.apache.org/jira/browse/AMBARI-20443).
> 
> ```
> $ mvn -am -pl ambari-server clean test
> ...
> Tests in error:
>   ServicePropertiesTest.validatePropertySchemaOfServiceXMLs:49 » Ambari File 
> /Us...
> 
> Tests run: 4971, Failures: 0, Errors: 1, Skipped: 39
> ```
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 59045: Insecure SSL: Server Identity Verification Disabled

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59045/#review174185
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On May 8, 2017, 7:26 p.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59045/
> ---
> 
> (Updated May 8, 2017, 7:26 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Robert Levas, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-20953
> https://issues.apache.org/jira/browse/AMBARI-20953
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added option
> 
> [security]
> ca_cert_path=/path/to/pem/formatted/cert/file.pem
> 
> to agent configuration.
> All requests that using https will use file.pem certificates to validate 
> responce from server.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 16fb97d 
>   ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
> 28574cc 
>   ambari-agent/src/main/python/ambari_agent/NetUtil.py fc19605 
>   ambari-agent/src/main/python/ambari_agent/alerts/web_alert.py 79b1c3b 
>   ambari-common/src/main/python/ambari_commons/inet_utils.py d44107d 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/curl_krb_request.py
>  557db58 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> bafb8e2 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py
>  c9b63ff 
> 
> 
> Diff: https://reviews.apache.org/r/59045/diff/2/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>

Review Request 59053: Review for AMBARI-20946

[Diego Santesteban]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59053/
---

Review request for Ambari and Tim Thorpe.


Bugs: AMBARI-20946
https://issues.apache.org/jira/browse/AMBARI-20946


Repository: ambari


Description
---

I added an extra case in resourceFilesKeeper.py to recreate the archive.zip 
file if it doesn't exist, even when the saved and current directory hashes are 
matching.

I added one new test case to make sure this case is working, and modified one 
existing test case to make it specific for the other case (where the 
archive.zip file does exist and the hashes match).


Diffs
-

  ambari-server/src/main/python/ambari_server/resourceFilesKeeper.py dba6833924 
  ambari-server/src/test/python/TestResourceFilesKeeper.py 4f7dc525d3 


Diff: https://reviews.apache.org/r/59053/diff/1/


Testing
---

I created a new test case and successfully ran all tests with 'mvn clean test'.

I also applied this change to an existing cluster to ensure that it does fix 
the issue in a real usage case.


Thanks,

Diego Santesteban

Re: Review Request 59045: Insecure SSL: Server Identity Verification Disabled

[Eugene Chekanskiy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59045/
---

(Updated May 8, 2017, 4:26 p.m.)


Review request for Ambari, Dmitro Lisnichenko, Robert Levas, and Vitalyi 
Brodetskyi.


Changes
---

fixed import issue, docs


Bugs: AMBARI-20953
https://issues.apache.org/jira/browse/AMBARI-20953


Repository: ambari


Description
---

Added option

[security]
ca_cert_path=/path/to/pem/formatted/cert/file.pem

to agent configuration.
All requests that using https will use file.pem certificates to validate 
responce from server.


Diffs (updated)
-

  ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 16fb97d 
  ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
28574cc 
  ambari-agent/src/main/python/ambari_agent/NetUtil.py fc19605 
  ambari-agent/src/main/python/ambari_agent/alerts/web_alert.py 79b1c3b 
  ambari-common/src/main/python/ambari_commons/inet_utils.py d44107d 
  
ambari-common/src/main/python/resource_management/libraries/functions/curl_krb_request.py
 557db58 
  ambari-common/src/main/python/resource_management/libraries/script/script.py 
bafb8e2 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py
 c9b63ff 


Diff: https://reviews.apache.org/r/59045/diff/2/

Changes: https://reviews.apache.org/r/59045/diff/1-2/


Testing
---

mvn clean test


Thanks,

Eugene Chekanskiy

Re: Review Request 59051: Integrate Log Search integration test framework with Selenium

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59051/#review174182
---


Ship it!




Ship It!

- Robert Nettleton


On May 8, 2017, 3:40 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59051/
> ---
> 
> (Updated May 8, 2017, 3:40 p.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Miklos Gergely, Robert Nettleton, 
> Sandor Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20955
> https://issues.apache.org/jira/browse/AMBARI-20955
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Integrate selenium with log search it framework.
> Tests can be run separately for ui and backend. Currently it requires x11 
> forwarding to see the tests itself. (later headless will be added). Also im 
> using localhost as docker hosts right now, which means it currenty works with 
> docker-for-mac or on linux system with an installed docker
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/README.md 5c41fcd 
>   ambari-logsearch/ambari-logsearch-it/pom.xml ee97e99 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/domain/StoryDataRegistry.java
>  cb72376 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/steps/AbstractLogSearchSteps.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/steps/LogSearchDockerSteps.java
>  32e8cba 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/steps/LogSearchUISteps.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/story/LogSearchApiQueryStory.java
>  45455bf 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/story/LogSearchBackendStories.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/story/LogSearchStory.java
>  ce6b9cb 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/story/LogSearchUIStories.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/story/LogfeederParsingStory.java
>  c502cc4 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/web/AbstractPage.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/web/Home.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/resources/org/apache/ambari/logsearch/story/log_search_api_query_story.story
>  cfaa359 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/resources/org/apache/ambari/logsearch/story/logfeeder_parsing_story.story
>  388e624 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/resources/stories/backend/log_search_api_query_story.story
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/resources/stories/backend/logfeeder_parsing_story.story
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/resources/stories/selenium/login.ui.story
>  PRE-CREATION 
>   ambari-logsearch/docker/Dockerfile 6e8ea3e 
>   ambari-logsearch/docker/bin/start.sh 1efc85c 
>   ambari-logsearch/docker/logsearch-docker.sh eab850e 
> 
> 
> Diff: https://reviews.apache.org/r/59051/diff/1/
> 
> 
> Testing
> ---
> 
> ran with -Dselenium-tests and with -Dbackend-tests as well
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 01:36 min
> [INFO] Finished at: 2017-05-08T16:27:44+02:00
> [INFO] Final Memory: 51M/499M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 59044: AMBARI-20952. Collection added to itself

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59044/#review174181
---


Ship it!




Ship It!

- Oliver Szabo


On May 8, 2017, 8:56 a.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59044/
> ---
> 
> (Updated May 8, 2017, 8:56 a.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Oliver Szabo, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20952
> https://issues.apache.org/jira/browse/AMBARI-20952
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fix typo
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/QuickLinksConfigurationModule.java
>  c879c021bea98b034a6351d2f139670510d21b2b 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/ThemeModule.java 
> 72d3bd367a5f1d0eb4ba0532ecb41abe237e8f53 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/QuickLinksConfigurationModuleTest.java
>  f6b7dfa504f6e8743d760dfaa1edd37d2dbef680 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/ThemeModuleTest.java
>  ec89a8c022089535ea4298c7d495c6f6cf177456 
> 
> 
> Diff: https://reviews.apache.org/r/59044/diff/1/
> 
> 
> Testing
> ---
> 
> New unit test
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Review Request 59051: Integrate Log Search integration test framework with Selenium

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59051/
---

Review request for Ambari, Laszlo Puskas, Miklos Gergely, Robert Nettleton, 
Sandor Magyari, and Sebastian Toader.


Bugs: AMBARI-20955
https://issues.apache.org/jira/browse/AMBARI-20955


Repository: ambari


Description
---

Integrate selenium with log search it framework.
Tests can be run separately for ui and backend. Currently it requires x11 
forwarding to see the tests itself. (later headless will be added). Also im 
using localhost as docker hosts right now, which means it currenty works with 
docker-for-mac or on linux system with an installed docker


Diffs
-

  ambari-logsearch/README.md 5c41fcd 
  ambari-logsearch/ambari-logsearch-it/pom.xml ee97e99 
  
ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/domain/StoryDataRegistry.java
 cb72376 
  
ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/steps/AbstractLogSearchSteps.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/steps/LogSearchDockerSteps.java
 32e8cba 
  
ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/steps/LogSearchUISteps.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/story/LogSearchApiQueryStory.java
 45455bf 
  
ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/story/LogSearchBackendStories.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/story/LogSearchStory.java
 ce6b9cb 
  
ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/story/LogSearchUIStories.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/story/LogfeederParsingStory.java
 c502cc4 
  
ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/web/AbstractPage.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/web/Home.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-it/src/test/resources/org/apache/ambari/logsearch/story/log_search_api_query_story.story
 cfaa359 
  
ambari-logsearch/ambari-logsearch-it/src/test/resources/org/apache/ambari/logsearch/story/logfeeder_parsing_story.story
 388e624 
  
ambari-logsearch/ambari-logsearch-it/src/test/resources/stories/backend/log_search_api_query_story.story
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-it/src/test/resources/stories/backend/logfeeder_parsing_story.story
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-it/src/test/resources/stories/selenium/login.ui.story
 PRE-CREATION 
  ambari-logsearch/docker/Dockerfile 6e8ea3e 
  ambari-logsearch/docker/bin/start.sh 1efc85c 
  ambari-logsearch/docker/logsearch-docker.sh eab850e 


Diff: https://reviews.apache.org/r/59051/diff/1/


Testing
---

ran with -Dselenium-tests and with -Dbackend-tests as well
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 01:36 min
[INFO] Finished at: 2017-05-08T16:27:44+02:00
[INFO] Final Memory: 51M/499M
[INFO] 


Thanks,

Oliver Szabo

Re: Review Request 59043: AMBARI-20951. Integrate HostService resource with swagger

[Jaimin Jetly]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59043/#review174170
---


Ship it!




Ship It!

- Jaimin Jetly


On May 8, 2017, 7 a.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59043/
> ---
> 
> (Updated May 8, 2017, 7 a.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Jaimin Jetly, Jayush Luniya, 
> Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20951
> https://issues.apache.org/jira/browse/AMBARI-20951
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> * documented `HostService`, `HostRequest`, `HostResponse`
> * removed unused attributes
> * introduced constants for common Swagger parameters
> * subresources are not covered yet
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseService.java
>  0185d37f1a9127c2bd414229b8ab7885e849fbf4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java
>  c26c5d85d4c90a1aee81cb5aafbcac49d185c5e2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/HostEventCreator.java
>  d05fe9dce86eaa712807c50744c1fb93000fbe56 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/HostRequest.java
>  a6168394bf4be45497924e73c84aae393d1c53fe 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/HostResponse.java
>  8032801dd7014b9532b5358c8fc44e5250b90c66 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RootServiceResponseFactory.java
>  40fe3697e98acff0a36dd24f3e51193683b5af93 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
>  f604a7f8be9b2dad7810e46444ae79ead73f8a98 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStatusHelper.java
>  96457ed6302f98f6b402eb27f49cffc41bfe4585 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceHostComponentResourceProvider.java
>  c2fb844ff7e81d8291ae27359dac864aadf50430 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ScaleClusterRequest.java
>  b5d2f9de8a297b68ee569b92bc475e39b39986d2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/PropertyHelper.java
>  c747a33a7d352d8614a573a6b9f3f7149ac5df7c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java 
> db228b194e240a0c895072362ae68d1973742cef 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
>  6d12402e9da92985176c8724f6b705304bba03e3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/HostRequest.java
>  168d13b44777b1891e72287de035e99d1064ab72 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/services/HostServiceTest.java
>  6aef04dda19693cd2408dcfce9be5ca8751550e4 
>   
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/HostEventCreatorTest.java
>  2d1cefcfdcb3604d54338c4c0b314c5fbb740b50 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
>  554e0891020d90593aeee76cbeddf65f5b66e2b0 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractResourceProviderTest.java
>  c7613231b13c8402cffe29f90fac2449e0f0a395 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java
>  ac6ac1d299947a3b4ba0f0f41f7a6f851b2a72db 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceHostComponentResourceProviderTest.java
>  f15c9f2baa20fb69b855d24badb144e354b83891 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ScaleClusterRequestTest.java
>  48d1351dc527488cea06168d2fe0fcc90d9a6eb7 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java
>  2d5978b1788572c716ddfaae2e56b9502097e98f 
> 
> 
> Diff: https://reviews.apache.org/r/59043/diff/1/
> 
> 
> Testing
> ---
> 
> Unit tests pass, except `ServicePropertiesTest`, which fails due to 
> [AMBARI-20443](https://issues.apache.org/jira/browse/AMBARI-20443).
> 
> ```
> $ mvn -am -pl ambari-server clean test
> ...
> Tests in error:
>   ServicePropertiesTest.validatePropertySchemaOfServiceXMLs:49 » Ambari File 
> /Us...
> 
> Tests run: 4971, Failures: 0, Errors: 1, Skipped: 39
> ```
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Review Request 59050: HDP 3.0 TP - create service definition for Atlas with configs, kerberos, widgets, etc

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59050/
---

Review request for Ambari, Alejandro Fernandez, Dmytro Sen, and Sumit Mohanty.


Bugs: AMBARI-20954
https://issues.apache.org/jira/browse/AMBARI-20954


Repository: ambari


Description
---

.


Diffs
-

  ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/alerts.json 
PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/configuration/application-properties.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/configuration/atlas-env.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/configuration/atlas-log4j.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/configuration/atlas-solrconfig.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/configuration/ranger-atlas-audit.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/configuration/ranger-atlas-plugin-properties.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/configuration/ranger-atlas-policymgr-ssl.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/configuration/ranger-atlas-security.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/kerberos.json 
PRE-CREATION 
  ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/metainfo.xml 
PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/package/scripts/atlas_client.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/package/scripts/metadata.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/package/scripts/metadata_server.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/package/scripts/params.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/package/scripts/service_check.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/package/scripts/setup_ranger_atlas.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/package/scripts/status_params.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/package/templates/atlas_hbase_setup.rb.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/package/templates/atlas_jaas.conf.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/package/templates/atlas_kafka_acl.sh.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/package/templates/input.config-atlas.json.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/package/templates/kafka_jaas.conf.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/quicklinks/quicklinks.json
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/role_command_order.json
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/themes/theme.json
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/themes/theme_version_2.json
 PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/3.0/services/ATLAS/metainfo.xml 
PRE-CREATION 


Diff: https://reviews.apache.org/r/59050/diff/1/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 59045: Insecure SSL: Server Identity Verification Disabled

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59045/#review174159
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Травень 8, 2017, 11:24 до полудня, Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59045/
> ---
> 
> (Updated Травень 8, 2017, 11:24 до полудня)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Robert Levas, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-20953
> https://issues.apache.org/jira/browse/AMBARI-20953
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added option
> 
> [security]
> ca_cert_path=/path/to/pem/formatted/cert/file.pem
> 
> to agent configuration.
> All requests that using https will use file.pem certificates to validate 
> responce from server.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 16fb97d 
>   ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
> 28574cc 
>   ambari-agent/src/main/python/ambari_agent/NetUtil.py fc19605 
>   ambari-agent/src/main/python/ambari_agent/alerts/web_alert.py 79b1c3b 
>   ambari-common/src/main/python/ambari_commons/inet_utils.py d44107d 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/curl_krb_request.py
>  557db58 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> bafb8e2 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py
>  c9b63ff 
> 
> 
> Diff: https://reviews.apache.org/r/59045/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>

Re: Review Request 58997: Users are not able to login to ambari UI after Ambari upgrade from 2.4.x to 2.5.0

[Nitiraj Rathore]

> On May 8, 2017, 9:32 a.m., Ashwin Rajeev wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
> > Lines 692 (patched)
> > 
> >
> > Does it need to be hardcoded ?

It's fine as it is specifically for that view only.


- Nitiraj


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58997/#review174147
---


On May 5, 2017, 9:12 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58997/
> ---
> 
> (Updated May 5, 2017, 9:12 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Rohit Choudhary, Renjith Kamath, 
> Ashwin Rajeev, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-20936
> https://issues.apache.org/jira/browse/AMBARI-20936
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Instead of deleting entries from DB directly, used uninstalling. Did 
> refactoring to take the DB related code out of the ViewRegistry (which is 
> anyway growing very big and is live object which cannot be used during 
> Upgrade process) to create ViewInstanceOperationHandler.java.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/PrivilegeEntity.java
>  ba39efb6a2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewEntity.java
>  74de530ad7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java
>  b632c54043 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
>  d076a5c3b1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewInstanceOperationHandler.java
>  PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 
> d136db7e49 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
>  190779add8 
>   
> ambari-server/src/test/java/org/apache/ambari/server/view/ViewInstanceOperationHandlerTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java
>  a3728d46b3 
> 
> 
> Diff: https://reviews.apache.org/r/58997/diff/1/
> 
> 
> Testing
> ---
> 
> added : ViewInstanceOperationHandlerTest.java 
> updated : UpgradeCatalog250Test.java, ViewRegistryTest.java
> 
> Manual testing to see if upgrade works fine with and without LDAP users and 
> privileges along with UI deletion of view instance.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 58997: Users are not able to login to ambari UI after Ambari upgrade from 2.4.x to 2.5.0

[DIPAYAN BHOWMICK]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58997/#review174152
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On May 5, 2017, 9:12 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58997/
> ---
> 
> (Updated May 5, 2017, 9:12 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Rohit Choudhary, Renjith Kamath, 
> Ashwin Rajeev, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-20936
> https://issues.apache.org/jira/browse/AMBARI-20936
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Instead of deleting entries from DB directly, used uninstalling. Did 
> refactoring to take the DB related code out of the ViewRegistry (which is 
> anyway growing very big and is live object which cannot be used during 
> Upgrade process) to create ViewInstanceOperationHandler.java.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/PrivilegeEntity.java
>  ba39efb6a2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewEntity.java
>  74de530ad7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java
>  b632c54043 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
>  d076a5c3b1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewInstanceOperationHandler.java
>  PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 
> d136db7e49 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
>  190779add8 
>   
> ambari-server/src/test/java/org/apache/ambari/server/view/ViewInstanceOperationHandlerTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java
>  a3728d46b3 
> 
> 
> Diff: https://reviews.apache.org/r/58997/diff/1/
> 
> 
> Testing
> ---
> 
> added : ViewInstanceOperationHandlerTest.java 
> updated : UpgradeCatalog250Test.java, ViewRegistryTest.java
> 
> Manual testing to see if upgrade works fine with and without LDAP users and 
> privileges along with UI deletion of view instance.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 58997: Users are not able to login to ambari UI after Ambari upgrade from 2.4.x to 2.5.0

[Ashwin Rajeev]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58997/#review174148
---


Ship it!




Ship It!

- Ashwin Rajeev


On May 5, 2017, 9:12 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58997/
> ---
> 
> (Updated May 5, 2017, 9:12 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Rohit Choudhary, Renjith Kamath, 
> Ashwin Rajeev, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-20936
> https://issues.apache.org/jira/browse/AMBARI-20936
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Instead of deleting entries from DB directly, used uninstalling. Did 
> refactoring to take the DB related code out of the ViewRegistry (which is 
> anyway growing very big and is live object which cannot be used during 
> Upgrade process) to create ViewInstanceOperationHandler.java.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/PrivilegeEntity.java
>  ba39efb6a2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewEntity.java
>  74de530ad7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java
>  b632c54043 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
>  d076a5c3b1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewInstanceOperationHandler.java
>  PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 
> d136db7e49 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
>  190779add8 
>   
> ambari-server/src/test/java/org/apache/ambari/server/view/ViewInstanceOperationHandlerTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java
>  a3728d46b3 
> 
> 
> Diff: https://reviews.apache.org/r/58997/diff/1/
> 
> 
> Testing
> ---
> 
> added : ViewInstanceOperationHandlerTest.java 
> updated : UpgradeCatalog250Test.java, ViewRegistryTest.java
> 
> Manual testing to see if upgrade works fine with and without LDAP users and 
> privileges along with UI deletion of view instance.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 58997: Users are not able to login to ambari UI after Ambari upgrade from 2.4.x to 2.5.0

[Ashwin Rajeev]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58997/#review174147
---




ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
Lines 692 (patched)


Does it need to be hardcoded ?


- Ashwin Rajeev


On May 5, 2017, 9:12 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58997/
> ---
> 
> (Updated May 5, 2017, 9:12 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Rohit Choudhary, Renjith Kamath, 
> Ashwin Rajeev, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-20936
> https://issues.apache.org/jira/browse/AMBARI-20936
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Instead of deleting entries from DB directly, used uninstalling. Did 
> refactoring to take the DB related code out of the ViewRegistry (which is 
> anyway growing very big and is live object which cannot be used during 
> Upgrade process) to create ViewInstanceOperationHandler.java.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/PrivilegeEntity.java
>  ba39efb6a2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewEntity.java
>  74de530ad7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java
>  b632c54043 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
>  d076a5c3b1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewInstanceOperationHandler.java
>  PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 
> d136db7e49 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
>  190779add8 
>   
> ambari-server/src/test/java/org/apache/ambari/server/view/ViewInstanceOperationHandlerTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java
>  a3728d46b3 
> 
> 
> Diff: https://reviews.apache.org/r/58997/diff/1/
> 
> 
> Testing
> ---
> 
> added : ViewInstanceOperationHandlerTest.java 
> updated : UpgradeCatalog250Test.java, ViewRegistryTest.java
> 
> Manual testing to see if upgrade works fine with and without LDAP users and 
> privileges along with UI deletion of view instance.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 59043: AMBARI-20951. Integrate HostService resource with swagger

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59043/#review174146
---


Ship it!




Ship It!

- Sebastian Toader


On May 8, 2017, 9 a.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59043/
> ---
> 
> (Updated May 8, 2017, 9 a.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Jaimin Jetly, Jayush Luniya, 
> Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20951
> https://issues.apache.org/jira/browse/AMBARI-20951
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> * documented `HostService`, `HostRequest`, `HostResponse`
> * removed unused attributes
> * introduced constants for common Swagger parameters
> * subresources are not covered yet
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseService.java
>  0185d37f1a9127c2bd414229b8ab7885e849fbf4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java
>  c26c5d85d4c90a1aee81cb5aafbcac49d185c5e2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/HostEventCreator.java
>  d05fe9dce86eaa712807c50744c1fb93000fbe56 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/HostRequest.java
>  a6168394bf4be45497924e73c84aae393d1c53fe 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/HostResponse.java
>  8032801dd7014b9532b5358c8fc44e5250b90c66 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RootServiceResponseFactory.java
>  40fe3697e98acff0a36dd24f3e51193683b5af93 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
>  f604a7f8be9b2dad7810e46444ae79ead73f8a98 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStatusHelper.java
>  96457ed6302f98f6b402eb27f49cffc41bfe4585 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceHostComponentResourceProvider.java
>  c2fb844ff7e81d8291ae27359dac864aadf50430 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ScaleClusterRequest.java
>  b5d2f9de8a297b68ee569b92bc475e39b39986d2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/PropertyHelper.java
>  c747a33a7d352d8614a573a6b9f3f7149ac5df7c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java 
> db228b194e240a0c895072362ae68d1973742cef 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
>  6d12402e9da92985176c8724f6b705304bba03e3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/HostRequest.java
>  168d13b44777b1891e72287de035e99d1064ab72 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/services/HostServiceTest.java
>  6aef04dda19693cd2408dcfce9be5ca8751550e4 
>   
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/HostEventCreatorTest.java
>  2d1cefcfdcb3604d54338c4c0b314c5fbb740b50 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
>  554e0891020d90593aeee76cbeddf65f5b66e2b0 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractResourceProviderTest.java
>  c7613231b13c8402cffe29f90fac2449e0f0a395 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java
>  ac6ac1d299947a3b4ba0f0f41f7a6f851b2a72db 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceHostComponentResourceProviderTest.java
>  f15c9f2baa20fb69b855d24badb144e354b83891 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ScaleClusterRequestTest.java
>  48d1351dc527488cea06168d2fe0fcc90d9a6eb7 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java
>  2d5978b1788572c716ddfaae2e56b9502097e98f 
> 
> 
> Diff: https://reviews.apache.org/r/59043/diff/1/
> 
> 
> Testing
> ---
> 
> Unit tests pass, except `ServicePropertiesTest`, which fails due to 
> [AMBARI-20443](https://issues.apache.org/jira/browse/AMBARI-20443).
> 
> ```
> $ mvn -am -pl ambari-server clean test
> ...
> Tests in error:
>   ServicePropertiesTest.validatePropertySchemaOfServiceXMLs:49 » Ambari File 
> /Us...
> 
> Tests run: 4971, Failures: 0, Errors: 1, Skipped: 39
> ```
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 59044: AMBARI-20952. Collection added to itself

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59044/#review174145
---


Ship it!




Ship It!

- Sebastian Toader


On May 8, 2017, 10:56 a.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59044/
> ---
> 
> (Updated May 8, 2017, 10:56 a.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Oliver Szabo, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20952
> https://issues.apache.org/jira/browse/AMBARI-20952
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fix typo
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/QuickLinksConfigurationModule.java
>  c879c021bea98b034a6351d2f139670510d21b2b 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/ThemeModule.java 
> 72d3bd367a5f1d0eb4ba0532ecb41abe237e8f53 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/QuickLinksConfigurationModuleTest.java
>  f6b7dfa504f6e8743d760dfaa1edd37d2dbef680 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/ThemeModuleTest.java
>  ec89a8c022089535ea4298c7d495c6f6cf177456 
> 
> 
> Diff: https://reviews.apache.org/r/59044/diff/1/
> 
> 
> Testing
> ---
> 
> New unit test
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Review Request 59044: AMBARI-20952. Collection added to itself

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59044/
---

Review request for Ambari, Miklos Gergely, Oliver Szabo, and Sebastian Toader.


Bugs: AMBARI-20952
https://issues.apache.org/jira/browse/AMBARI-20952


Repository: ambari


Description
---

Fix typo


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/stack/QuickLinksConfigurationModule.java
 c879c021bea98b034a6351d2f139670510d21b2b 
  ambari-server/src/main/java/org/apache/ambari/server/stack/ThemeModule.java 
72d3bd367a5f1d0eb4ba0532ecb41abe237e8f53 
  
ambari-server/src/test/java/org/apache/ambari/server/stack/QuickLinksConfigurationModuleTest.java
 f6b7dfa504f6e8743d760dfaa1edd37d2dbef680 
  
ambari-server/src/test/java/org/apache/ambari/server/stack/ThemeModuleTest.java 
ec89a8c022089535ea4298c7d495c6f6cf177456 


Diff: https://reviews.apache.org/r/59044/diff/1/


Testing
---

New unit test


Thanks,

Attila Doroszlai

Review Request 59043: AMBARI-20951. Integrate HostService resource with swagger

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59043/
---

Review request for Ambari, Balázs Bence Sári, Jaimin Jetly, Jayush Luniya, 
Sumit Mohanty, and Sebastian Toader.


Bugs: AMBARI-20951
https://issues.apache.org/jira/browse/AMBARI-20951


Repository: ambari


Description
---

* documented `HostService`, `HostRequest`, `HostResponse`
* removed unused attributes
* introduced constants for common Swagger parameters
* subresources are not covered yet


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseService.java
 0185d37f1a9127c2bd414229b8ab7885e849fbf4 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java
 c26c5d85d4c90a1aee81cb5aafbcac49d185c5e2 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/HostEventCreator.java
 d05fe9dce86eaa712807c50744c1fb93000fbe56 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/HostRequest.java
 a6168394bf4be45497924e73c84aae393d1c53fe 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/HostResponse.java
 8032801dd7014b9532b5358c8fc44e5250b90c66 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/RootServiceResponseFactory.java
 40fe3697e98acff0a36dd24f3e51193683b5af93 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
 f604a7f8be9b2dad7810e46444ae79ead73f8a98 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStatusHelper.java
 96457ed6302f98f6b402eb27f49cffc41bfe4585 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceHostComponentResourceProvider.java
 c2fb844ff7e81d8291ae27359dac864aadf50430 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ScaleClusterRequest.java
 b5d2f9de8a297b68ee569b92bc475e39b39986d2 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/PropertyHelper.java
 c747a33a7d352d8614a573a6b9f3f7149ac5df7c 
  ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java 
db228b194e240a0c895072362ae68d1973742cef 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
 6d12402e9da92985176c8724f6b705304bba03e3 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/HostRequest.java 
168d13b44777b1891e72287de035e99d1064ab72 
  
ambari-server/src/test/java/org/apache/ambari/server/api/services/HostServiceTest.java
 6aef04dda19693cd2408dcfce9be5ca8751550e4 
  
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/HostEventCreatorTest.java
 2d1cefcfdcb3604d54338c4c0b314c5fbb740b50 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
 554e0891020d90593aeee76cbeddf65f5b66e2b0 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractResourceProviderTest.java
 c7613231b13c8402cffe29f90fac2449e0f0a395 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java
 ac6ac1d299947a3b4ba0f0f41f7a6f851b2a72db 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceHostComponentResourceProviderTest.java
 f15c9f2baa20fb69b855d24badb144e354b83891 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ScaleClusterRequestTest.java
 48d1351dc527488cea06168d2fe0fcc90d9a6eb7 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java
 2d5978b1788572c716ddfaae2e56b9502097e98f 


Diff: https://reviews.apache.org/r/59043/diff/1/


Testing
---

Unit tests pass, except `ServicePropertiesTest`, which fails due to 
[AMBARI-20443](https://issues.apache.org/jira/browse/AMBARI-20443).

```
$ mvn -am -pl ambari-server clean test
...
Tests in error:
  ServicePropertiesTest.validatePropertySchemaOfServiceXMLs:49 » Ambari File 
/Us...

Tests run: 4971, Failures: 0, Errors: 1, Skipped: 39
```


Thanks,

Attila Doroszlai