date:20170607

Re: Review Request 59888: Fix ambari-solr-plugin folder structure

2017-06-07 Thread Miklos Gergely


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59888/#review177282
---


Ship it!




Ship It!

- Miklos Gergely


On June 7, 2017, 5:51 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59888/
> ---
> 
> (Updated June 7, 2017, 5:51 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Laszlo Puskas, Miklos Gergely, 
> Robert Nettleton, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21196
> https://issues.apache.org/jira/browse/AMBARI-21196
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> move solr plugin files from "org.apache.ambari.infra.security" folder to 
> org/apache/ambari/infra/security
> 
> (funny fact: it worked with that folder name, as the class was generated into 
> the proper place beacase of the package name)
> 
> 
> Diffs
> -
> 
>   
> ambari-infra/ambari-infra-solr-plugin/src/main/java/org.apache.ambari.infra.security/InfraKerberosHostValidator.java
>   
>   
> ambari-infra/ambari-infra-solr-plugin/src/main/java/org.apache.ambari.infra.security/InfraRuleBasedAuthorizationPlugin.java
>   
>   
> ambari-infra/ambari-infra-solr-plugin/src/main/java/org.apache.ambari.infra.security/InfraUserRolesLookupStrategy.java
>   
> 
> 
> Diff: https://reviews.apache.org/r/59888/diff/1/
> 
> 
> Testing
> ---
> 
> done
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 59888: Fix ambari-solr-plugin folder structure

2017-06-07 Thread Sebastian Toader


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59888/#review177279
---


Ship it!




Ship It!

- Sebastian Toader


On June 7, 2017, 7:51 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59888/
> ---
> 
> (Updated June 7, 2017, 7:51 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Laszlo Puskas, Miklos Gergely, 
> Robert Nettleton, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21196
> https://issues.apache.org/jira/browse/AMBARI-21196
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> move solr plugin files from "org.apache.ambari.infra.security" folder to 
> org/apache/ambari/infra/security
> 
> (funny fact: it worked with that folder name, as the class was generated into 
> the proper place beacase of the package name)
> 
> 
> Diffs
> -
> 
>   
> ambari-infra/ambari-infra-solr-plugin/src/main/java/org.apache.ambari.infra.security/InfraKerberosHostValidator.java
>   
>   
> ambari-infra/ambari-infra-solr-plugin/src/main/java/org.apache.ambari.infra.security/InfraRuleBasedAuthorizationPlugin.java
>   
>   
> ambari-infra/ambari-infra-solr-plugin/src/main/java/org.apache.ambari.infra.security/InfraUserRolesLookupStrategy.java
>   
> 
> 
> Diff: https://reviews.apache.org/r/59888/diff/1/
> 
> 
> Testing
> ---
> 
> done
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 59149: Add Kerberos HTTP SPNEGO authentication support to Hadoop/hbase/kafka/storm sinks

2017-06-07 Thread Qin Liu



> On June 7, 2017, 10:48 p.m., Aravindan Vijayan wrote:
> > Ship It!

Thank you!


- Qin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59149/#review177245
---


On June 1, 2017, 6:52 p.m., Qin Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59149/
> ---
> 
> (Updated June 1, 2017, 6:52 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Di Li, Dmytro Sen, Robert 
> Levas, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-19369
> https://issues.apache.org/jira/browse/AMBARI-19369
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This is a subtask of AMBARI-14384 "Ambari Metrics doesn't use SPNEGO to 
> authenticate".
> 
> In a Kerberos enabled cluster with SPNEGO enabled on Hadoop APIs, Ambari 
> Metrics Collector web-console will be Kerberos HTTP SPNEGO enabled too. But 
> Hadoop/hbase/kafka/storm sinks, clients of Ambari Metrics Collector, 
> currently do not support Kerberos HTTP SPNEGO authentication.
> 
> e.g., 
> /var/log/hadoop-yarn/yarn/yarn-yarn-timelineserver-.log:
> 2016-12-16 22:25:29,471 INFO timeline.HadoopTimelineMetricsSink 
> (AbstractTimelineMetricsSink.java:emitMetricsJson(169)) - Unable to POST 
> metrics to collector, http://metrics-collector:6188/ws/v1/timeline/metrics, 
> statusCode = 401
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-common/pom.xml 62ae75f 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
>  2c6fae2 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AppCookieManager.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/AppCookieManagerTest.java
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-env.xml
>  db36db8 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/hbase_master_jaas.conf.j2
>  a93c36c 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/hbase_regionserver_jaas.conf.j2
>  7097481 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hbase_master_jaas.conf.j2
>  a93c36c 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hbase_regionserver_jaas.conf.j2
>  7097481 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/configuration/hbase-env.xml
>  da12706 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/templates/hbase_master_jaas.conf.j2
>  a93c36c 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/templates/hbase_regionserver_jaas.conf.j2
>  7097481 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py
>  d9b62e2 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/templates/hdfs_dn_jaas.conf.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/templates/hdfs_jn_jaas.conf.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/templates/hdfs_nn_jaas.conf.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/hdfs.py
>  d9b62e2 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/templates/hdfs_dn_jaas.conf.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/templates/hdfs_jn_jaas.conf.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/templates/hdfs_nn_jaas.conf.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-env.xml
>  91af58e 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka_jaas_conf.xml
>  fdde8f2 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/templates/kafka_jaas.conf.j2
>  56c558d 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/storm_yaml_utils.py
>  9d78e71 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/templates/storm_jaas.conf.j2
>  c22cb51 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  3579fcb 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py
>  2e1b208 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/templates/mapred_jaa

Re: Review Request 59149: Add Kerberos HTTP SPNEGO authentication support to Hadoop/hbase/kafka/storm sinks

2017-06-07 Thread Qin Liu



> On June 6, 2017, 5:59 p.m., Robert Levas wrote:
> > Ship It!

Thank you!


- Qin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59149/#review177062
---


On June 1, 2017, 6:52 p.m., Qin Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59149/
> ---
> 
> (Updated June 1, 2017, 6:52 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Di Li, Dmytro Sen, Robert 
> Levas, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-19369
> https://issues.apache.org/jira/browse/AMBARI-19369
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This is a subtask of AMBARI-14384 "Ambari Metrics doesn't use SPNEGO to 
> authenticate".
> 
> In a Kerberos enabled cluster with SPNEGO enabled on Hadoop APIs, Ambari 
> Metrics Collector web-console will be Kerberos HTTP SPNEGO enabled too. But 
> Hadoop/hbase/kafka/storm sinks, clients of Ambari Metrics Collector, 
> currently do not support Kerberos HTTP SPNEGO authentication.
> 
> e.g., 
> /var/log/hadoop-yarn/yarn/yarn-yarn-timelineserver-.log:
> 2016-12-16 22:25:29,471 INFO timeline.HadoopTimelineMetricsSink 
> (AbstractTimelineMetricsSink.java:emitMetricsJson(169)) - Unable to POST 
> metrics to collector, http://metrics-collector:6188/ws/v1/timeline/metrics, 
> statusCode = 401
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-common/pom.xml 62ae75f 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
>  2c6fae2 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AppCookieManager.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/AppCookieManagerTest.java
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-env.xml
>  db36db8 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/hbase_master_jaas.conf.j2
>  a93c36c 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/hbase_regionserver_jaas.conf.j2
>  7097481 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hbase_master_jaas.conf.j2
>  a93c36c 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hbase_regionserver_jaas.conf.j2
>  7097481 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/configuration/hbase-env.xml
>  da12706 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/templates/hbase_master_jaas.conf.j2
>  a93c36c 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/templates/hbase_regionserver_jaas.conf.j2
>  7097481 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py
>  d9b62e2 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/templates/hdfs_dn_jaas.conf.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/templates/hdfs_jn_jaas.conf.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/templates/hdfs_nn_jaas.conf.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/hdfs.py
>  d9b62e2 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/templates/hdfs_dn_jaas.conf.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/templates/hdfs_jn_jaas.conf.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/templates/hdfs_nn_jaas.conf.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-env.xml
>  91af58e 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka_jaas_conf.xml
>  fdde8f2 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/templates/kafka_jaas.conf.j2
>  56c558d 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/storm_yaml_utils.py
>  9d78e71 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/templates/storm_jaas.conf.j2
>  c22cb51 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  3579fcb 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py
>  2e1b208 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/templates/mapred_jaas.conf

Re: Review Request 59870: Part Two: Specify the script directly in alert target for script-based alert dispatchers

2017-06-07 Thread yao lei



> On 六月 8, 2017, 12:23 a.m., Richard Zang wrote:
> > Ship It!

Thank for your review.


- yao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59870/#review177262
---


On 六月 7, 2017, 4:34 a.m., yao lei wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59870/
> ---
> 
> (Updated 六月 7, 2017, 4:34 a.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Richard Zang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-21123
> https://issues.apache.org/jira/browse/AMBARI-21123
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Web Codes Part
> This patch amis to support creating alert target that inclueds property 
> ambari.dispatch-property.script.filename on web UI
> 
> More details, please see https://issues.apache.org/jira/browse/AMBARI-20739
> 
> 
> Diffs
> -
> 
>   
> ambari-web/app/controllers/main/alerts/manage_alert_notifications_controller.js
>  df15513 
>   ambari-web/app/messages.js 02a54f7 
>   ambari-web/app/templates/main/alerts/create_alert_notification.hbs 7ec5b1e 
>   ambari-web/app/utils/validator.js c069724 
>   
> ambari-web/test/controllers/main/alerts/manage_alert_notifications_controller_test.js
>  0d58afa 
> 
> 
> Diff: https://reviews.apache.org/r/59870/diff/1/
> 
> 
> Testing
> ---
> 
> 1.cd ambari-web & mvn test
>   21211 passing (33s)
>   128 pending
>   
> 2.Tested in a cluster
> 
> 
> File Attachments
> 
> 
> script_alert_notification_1.png
>   
> https://reviews.apache.org/media/uploaded/files/2017/06/07/c77c5e4c-4d64-400a-8df9-11df1369e7fd__script_alert_notification_1.png
> script_alert_notification_2.png
>   
> https://reviews.apache.org/media/uploaded/files/2017/06/07/1c230f27-4158-4ef4-90a8-483b3cfd4d52__script_alert_notification_2.png
> 
> 
> Thanks,
> 
> yao lei
> 
>

Re: Review Request 59870: Part Two: Specify the script directly in alert target for script-based alert dispatchers

2017-06-07 Thread Richard Zang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59870/#review177262
---


Ship it!




Ship It!

- Richard Zang


On June 7, 2017, 4:34 a.m., yao lei wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59870/
> ---
> 
> (Updated June 7, 2017, 4:34 a.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Richard Zang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-21123
> https://issues.apache.org/jira/browse/AMBARI-21123
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Web Codes Part
> This patch amis to support creating alert target that inclueds property 
> ambari.dispatch-property.script.filename on web UI
> 
> More details, please see https://issues.apache.org/jira/browse/AMBARI-20739
> 
> 
> Diffs
> -
> 
>   
> ambari-web/app/controllers/main/alerts/manage_alert_notifications_controller.js
>  df15513 
>   ambari-web/app/messages.js 02a54f7 
>   ambari-web/app/templates/main/alerts/create_alert_notification.hbs 7ec5b1e 
>   ambari-web/app/utils/validator.js c069724 
>   
> ambari-web/test/controllers/main/alerts/manage_alert_notifications_controller_test.js
>  0d58afa 
> 
> 
> Diff: https://reviews.apache.org/r/59870/diff/1/
> 
> 
> Testing
> ---
> 
> 1.cd ambari-web & mvn test
>   21211 passing (33s)
>   128 pending
>   
> 2.Tested in a cluster
> 
> 
> File Attachments
> 
> 
> script_alert_notification_1.png
>   
> https://reviews.apache.org/media/uploaded/files/2017/06/07/c77c5e4c-4d64-400a-8df9-11df1369e7fd__script_alert_notification_1.png
> script_alert_notification_2.png
>   
> https://reviews.apache.org/media/uploaded/files/2017/06/07/1c230f27-4158-4ef4-90a8-483b3cfd4d52__script_alert_notification_2.png
> 
> 
> Thanks,
> 
> yao lei
> 
>

Re: Review Request 59149: Add Kerberos HTTP SPNEGO authentication support to Hadoop/hbase/kafka/storm sinks

2017-06-07 Thread Aravindan Vijayan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59149/#review177245
---


Ship it!




Ship It!

- Aravindan Vijayan


On June 1, 2017, 6:52 p.m., Qin Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59149/
> ---
> 
> (Updated June 1, 2017, 6:52 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Di Li, Dmytro Sen, Robert 
> Levas, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-19369
> https://issues.apache.org/jira/browse/AMBARI-19369
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This is a subtask of AMBARI-14384 "Ambari Metrics doesn't use SPNEGO to 
> authenticate".
> 
> In a Kerberos enabled cluster with SPNEGO enabled on Hadoop APIs, Ambari 
> Metrics Collector web-console will be Kerberos HTTP SPNEGO enabled too. But 
> Hadoop/hbase/kafka/storm sinks, clients of Ambari Metrics Collector, 
> currently do not support Kerberos HTTP SPNEGO authentication.
> 
> e.g., 
> /var/log/hadoop-yarn/yarn/yarn-yarn-timelineserver-.log:
> 2016-12-16 22:25:29,471 INFO timeline.HadoopTimelineMetricsSink 
> (AbstractTimelineMetricsSink.java:emitMetricsJson(169)) - Unable to POST 
> metrics to collector, http://metrics-collector:6188/ws/v1/timeline/metrics, 
> statusCode = 401
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-common/pom.xml 62ae75f 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
>  2c6fae2 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AppCookieManager.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/AppCookieManagerTest.java
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-env.xml
>  db36db8 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/hbase_master_jaas.conf.j2
>  a93c36c 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/hbase_regionserver_jaas.conf.j2
>  7097481 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hbase_master_jaas.conf.j2
>  a93c36c 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hbase_regionserver_jaas.conf.j2
>  7097481 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/configuration/hbase-env.xml
>  da12706 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/templates/hbase_master_jaas.conf.j2
>  a93c36c 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/templates/hbase_regionserver_jaas.conf.j2
>  7097481 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py
>  d9b62e2 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/templates/hdfs_dn_jaas.conf.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/templates/hdfs_jn_jaas.conf.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/templates/hdfs_nn_jaas.conf.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/hdfs.py
>  d9b62e2 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/templates/hdfs_dn_jaas.conf.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/templates/hdfs_jn_jaas.conf.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/templates/hdfs_nn_jaas.conf.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-env.xml
>  91af58e 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka_jaas_conf.xml
>  fdde8f2 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/templates/kafka_jaas.conf.j2
>  56c558d 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/storm_yaml_utils.py
>  9d78e71 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/templates/storm_jaas.conf.j2
>  c22cb51 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  3579fcb 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py
>  2e1b208 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/templates/mapred_jaas.conf.j2
>  PRE-CREATION 
>   
> ambari-server

Re: Review Request 59888: Fix ambari-solr-plugin folder structure

2017-06-07 Thread Robert Nettleton


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59888/#review177226
---


Ship it!




Ship It!

- Robert Nettleton


On June 7, 2017, 5:51 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59888/
> ---
> 
> (Updated June 7, 2017, 5:51 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Laszlo Puskas, Miklos Gergely, 
> Robert Nettleton, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21196
> https://issues.apache.org/jira/browse/AMBARI-21196
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> move solr plugin files from "org.apache.ambari.infra.security" folder to 
> org/apache/ambari/infra/security
> 
> (funny fact: it worked with that folder name, as the class was generated into 
> the proper place beacase of the package name)
> 
> 
> Diffs
> -
> 
>   
> ambari-infra/ambari-infra-solr-plugin/src/main/java/org.apache.ambari.infra.security/InfraKerberosHostValidator.java
>   
>   
> ambari-infra/ambari-infra-solr-plugin/src/main/java/org.apache.ambari.infra.security/InfraRuleBasedAuthorizationPlugin.java
>   
>   
> ambari-infra/ambari-infra-solr-plugin/src/main/java/org.apache.ambari.infra.security/InfraUserRolesLookupStrategy.java
>   
> 
> 
> Diff: https://reviews.apache.org/r/59888/diff/1/
> 
> 
> Testing
> ---
> 
> done
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 59884: AMBARI-21185. False positive unused import for nested class referenced only in Javadoc

2017-06-07 Thread Jonathan Hurley


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59884/#review177217
---


Ship it!




Ship It!

- Jonathan Hurley


On June 7, 2017, 12:22 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59884/
> ---
> 
> (Updated June 7, 2017, 12:22 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21185
> https://issues.apache.org/jira/browse/AMBARI-21185
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> * Added package qualifier for `StageWrapper.Type` link.  The import is 
> already removed.
> * Fixed other unresolved references in JavaDoc where I could find the current 
> "target", otherwise removed them.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  cabb9d6c9efe9aa76e4c17341712c200d37123dd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
>  7b6ac7e1ba16875a48b71e504963723c5ac038a7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
>  f8f8faac1afc42dd5d64d42d814c5030f88d1f68 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListener.java
>  5536ef9548473c3fce0f7199d22700d6bd42be14 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java
>  ad34ec7982980f7761243b8407ef382593e09541 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ServiceConfigDAO.java
>  72666e575902b561b1d62d07d6952adb904350a9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
>  475a8c9b3b04cdce18145165985f84ffa1cc3508 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
> 4fddd8ddac9e5bfa9bba4ce2c757154fb5c1bf42 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigFactory.java 
> dda5c9c98f4012bb92e476c5fb8d949e4afb234b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java
>  67ffefde85f73464c1af654706cc1b336ec4e1c3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertUri.java
>  2df1daed28a092afc7ebdb3e8aea16fc85e36106 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelper.java
>  802c8769032afb29559fb11a0624a0b4257158ea 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackUpgradeConfigurationMergeTest.java
>  97b94c3ea2d17d4a10ec12160c91d2c547bb889c 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java
>  8f59c077ba43dc327026ebd5df8a53ac52cd685c 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 
> eff6a9a8b54003319e695785d58263735896e7bd 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java
>  478b1264321661cd5541075873e2efd6ed757013 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java
>  b6fa6d24d98dbc5b595cc67888f5c5150edde85b 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java
>  336db3683022829d94138d360091dd8385daf29b 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalogHelper.java
>  1a9eed423172884c65b457389a3745ac68da0fa4 
> 
> 
> Diff: https://reviews.apache.org/r/59884/diff/1/
> 
> 
> Testing
> ---
> 
> * "Declaration has problems in JavaDoc references" check in IDEA
> * `mvn -am -pl ambari-server -DskipTests clean test` for compilation and 
> Checkstyle audit
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 59886: AMBARI-21195. Enforce minimum Maven version

2017-06-07 Thread Jonathan Hurley


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59886/#review177216
---


Ship it!




Once this is committed, you should also update the Ambari wiki (the development 
section) to require this new min version now.

- Jonathan Hurley


On June 7, 2017, 12:55 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59886/
> ---
> 
> (Updated June 7, 2017, 12:55 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, 
> Sumit Mohanty, Sebastian Toader, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21195
> https://issues.apache.org/jira/browse/AMBARI-21195
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Use Maven Enforcer plugin to specify minimum Maven version for 
> `ambari-server` module
> 
> 
> Diffs
> -
> 
>   ambari-project/pom.xml 98da9f4216b2e231f6a6bb855d6fd878b6d7066c 
>   ambari-server/pom.xml c0aed7bbb381255cd2529d82baf34d677acbc94e 
> 
> 
> Diff: https://reviews.apache.org/r/59886/diff/1/
> 
> 
> Testing
> ---
> 
> Build fails with message about Maven version when using old one:
> 
> ```
> $ PATH=~/lib/apache-maven-3.0.5/bin:$PATH mvn -am -pl ambari-server validate
> ...
> [INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-maven) @ 
> ambari-server ---
> [WARNING] Rule 0: org.apache.maven.plugins.enforcer.RequireMavenVersion 
> failed with message:
> Detected Maven Version: 3.0.5 is not in the allowed range [3.3.9,).
> ...
> [INFO] BUILD FAILURE
> ...
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-enforcer-plugin:1.4.1:enforce (enforce-maven) 
> on project ambari-server: Some Enforcer rules have failed. Look above for 
> specific messages explaining why the rule failed. -> [Help 1]
> ```
> 
> Build succeeds when using 3.3.9 or newer:
> 
> ```
> $ PATH=~/lib/apache-maven-3.3.9/bin:$PATH mvn -am -pl ambari-server validate
> ...
> [INFO] BUILD SUCCESS
> ...
> $ PATH=~/lib/apache-maven-3.5.0/bin:$PATH mvn -am -pl ambari-server validate
> ...
> [INFO] BUILD SUCCESS
> ```
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 59886: AMBARI-21195. Enforce minimum Maven version

2017-06-07 Thread Nate Cole


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59886/#review177215
---


Ship it!




Ship It!

- Nate Cole


On June 7, 2017, 12:55 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59886/
> ---
> 
> (Updated June 7, 2017, 12:55 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, 
> Sumit Mohanty, Sebastian Toader, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21195
> https://issues.apache.org/jira/browse/AMBARI-21195
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Use Maven Enforcer plugin to specify minimum Maven version for 
> `ambari-server` module
> 
> 
> Diffs
> -
> 
>   ambari-project/pom.xml 98da9f4216b2e231f6a6bb855d6fd878b6d7066c 
>   ambari-server/pom.xml c0aed7bbb381255cd2529d82baf34d677acbc94e 
> 
> 
> Diff: https://reviews.apache.org/r/59886/diff/1/
> 
> 
> Testing
> ---
> 
> Build fails with message about Maven version when using old one:
> 
> ```
> $ PATH=~/lib/apache-maven-3.0.5/bin:$PATH mvn -am -pl ambari-server validate
> ...
> [INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-maven) @ 
> ambari-server ---
> [WARNING] Rule 0: org.apache.maven.plugins.enforcer.RequireMavenVersion 
> failed with message:
> Detected Maven Version: 3.0.5 is not in the allowed range [3.3.9,).
> ...
> [INFO] BUILD FAILURE
> ...
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-enforcer-plugin:1.4.1:enforce (enforce-maven) 
> on project ambari-server: Some Enforcer rules have failed. Look above for 
> specific messages explaining why the rule failed. -> [Help 1]
> ```
> 
> Build succeeds when using 3.3.9 or newer:
> 
> ```
> $ PATH=~/lib/apache-maven-3.3.9/bin:$PATH mvn -am -pl ambari-server validate
> ...
> [INFO] BUILD SUCCESS
> ...
> $ PATH=~/lib/apache-maven-3.5.0/bin:$PATH mvn -am -pl ambari-server validate
> ...
> [INFO] BUILD SUCCESS
> ```
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Review Request 59888: Fix ambari-solr-plugin folder structure

2017-06-07 Thread Oliver Szabo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59888/
---

Review request for Ambari, Attila Doroszlai, Laszlo Puskas, Miklos Gergely, 
Robert Nettleton, and Sebastian Toader.


Bugs: AMBARI-21196
https://issues.apache.org/jira/browse/AMBARI-21196


Repository: ambari


Description
---

move solr plugin files from "org.apache.ambari.infra.security" folder to 
org/apache/ambari/infra/security

(funny fact: it worked with that folder name, as the class was generated into 
the proper place beacase of the package name)


Diffs
-

  
ambari-infra/ambari-infra-solr-plugin/src/main/java/org.apache.ambari.infra.security/InfraKerberosHostValidator.java
  
  
ambari-infra/ambari-infra-solr-plugin/src/main/java/org.apache.ambari.infra.security/InfraRuleBasedAuthorizationPlugin.java
  
  
ambari-infra/ambari-infra-solr-plugin/src/main/java/org.apache.ambari.infra.security/InfraUserRolesLookupStrategy.java
  


Diff: https://reviews.apache.org/r/59888/diff/1/


Testing
---

done


Thanks,

Oliver Szabo

Re: Review Request 59877: Custom log4j.properties of Flume

2017-06-07 Thread Alejandro Fernandez


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59877/#review177195
---


Ship it!




Ship It!

- Alejandro Fernandez


On June 7, 2017, 10:46 a.m., wang jianfei wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59877/
> ---
> 
> (Updated June 7, 2017, 10:46 a.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Jaimin Jetly, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-21191
> https://issues.apache.org/jira/browse/AMBARI-21191
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently,if you want to config log4j.properties of Flume,you must change the 
> log4j.properties.j2 in the ambari-agent-host installed flume-agent.
> So,we make it configurable by adding log4j.properties.template.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/configuration/flume-log4j.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume.py
>  6b1d286 
> 
> 
> Diff: https://reviews.apache.org/r/59877/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested.
> 
> 
> Thanks,
> 
> wang jianfei
> 
>

Re: Review Request 59886: AMBARI-21195. Enforce minimum Maven version

2017-06-07 Thread Oliver Szabo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59886/#review177192
---


Ship it!




Ship It!

- Oliver Szabo


On June 7, 2017, 4:55 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59886/
> ---
> 
> (Updated June 7, 2017, 4:55 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, 
> Sumit Mohanty, Sebastian Toader, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21195
> https://issues.apache.org/jira/browse/AMBARI-21195
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Use Maven Enforcer plugin to specify minimum Maven version for 
> `ambari-server` module
> 
> 
> Diffs
> -
> 
>   ambari-project/pom.xml 98da9f4216b2e231f6a6bb855d6fd878b6d7066c 
>   ambari-server/pom.xml c0aed7bbb381255cd2529d82baf34d677acbc94e 
> 
> 
> Diff: https://reviews.apache.org/r/59886/diff/1/
> 
> 
> Testing
> ---
> 
> Build fails with message about Maven version when using old one:
> 
> ```
> $ PATH=~/lib/apache-maven-3.0.5/bin:$PATH mvn -am -pl ambari-server validate
> ...
> [INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-maven) @ 
> ambari-server ---
> [WARNING] Rule 0: org.apache.maven.plugins.enforcer.RequireMavenVersion 
> failed with message:
> Detected Maven Version: 3.0.5 is not in the allowed range [3.3.9,).
> ...
> [INFO] BUILD FAILURE
> ...
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-enforcer-plugin:1.4.1:enforce (enforce-maven) 
> on project ambari-server: Some Enforcer rules have failed. Look above for 
> specific messages explaining why the rule failed. -> [Help 1]
> ```
> 
> Build succeeds when using 3.3.9 or newer:
> 
> ```
> $ PATH=~/lib/apache-maven-3.3.9/bin:$PATH mvn -am -pl ambari-server validate
> ...
> [INFO] BUILD SUCCESS
> ...
> $ PATH=~/lib/apache-maven-3.5.0/bin:$PATH mvn -am -pl ambari-server validate
> ...
> [INFO] BUILD SUCCESS
> ```
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 59886: AMBARI-21195. Enforce minimum Maven version

2017-06-07 Thread Sebastian Toader


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59886/#review177183
---


Ship it!




Ship It!

- Sebastian Toader


On June 7, 2017, 6:55 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59886/
> ---
> 
> (Updated June 7, 2017, 6:55 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, 
> Sumit Mohanty, Sebastian Toader, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21195
> https://issues.apache.org/jira/browse/AMBARI-21195
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Use Maven Enforcer plugin to specify minimum Maven version for 
> `ambari-server` module
> 
> 
> Diffs
> -
> 
>   ambari-project/pom.xml 98da9f4216b2e231f6a6bb855d6fd878b6d7066c 
>   ambari-server/pom.xml c0aed7bbb381255cd2529d82baf34d677acbc94e 
> 
> 
> Diff: https://reviews.apache.org/r/59886/diff/1/
> 
> 
> Testing
> ---
> 
> Build fails with message about Maven version when using old one:
> 
> ```
> $ PATH=~/lib/apache-maven-3.0.5/bin:$PATH mvn -am -pl ambari-server validate
> ...
> [INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-maven) @ 
> ambari-server ---
> [WARNING] Rule 0: org.apache.maven.plugins.enforcer.RequireMavenVersion 
> failed with message:
> Detected Maven Version: 3.0.5 is not in the allowed range [3.3.9,).
> ...
> [INFO] BUILD FAILURE
> ...
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-enforcer-plugin:1.4.1:enforce (enforce-maven) 
> on project ambari-server: Some Enforcer rules have failed. Look above for 
> specific messages explaining why the rule failed. -> [Help 1]
> ```
> 
> Build succeeds when using 3.3.9 or newer:
> 
> ```
> $ PATH=~/lib/apache-maven-3.3.9/bin:$PATH mvn -am -pl ambari-server validate
> ...
> [INFO] BUILD SUCCESS
> ...
> $ PATH=~/lib/apache-maven-3.5.0/bin:$PATH mvn -am -pl ambari-server validate
> ...
> [INFO] BUILD SUCCESS
> ```
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Review Request 59886: AMBARI-21195. Enforce minimum Maven version

2017-06-07 Thread Attila Doroszlai


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59886/
---

Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, 
Sumit Mohanty, Sebastian Toader, and Sid Wagle.


Bugs: AMBARI-21195
https://issues.apache.org/jira/browse/AMBARI-21195


Repository: ambari


Description
---

Use Maven Enforcer plugin to specify minimum Maven version for `ambari-server` 
module


Diffs
-

  ambari-project/pom.xml 98da9f4216b2e231f6a6bb855d6fd878b6d7066c 
  ambari-server/pom.xml c0aed7bbb381255cd2529d82baf34d677acbc94e 


Diff: https://reviews.apache.org/r/59886/diff/1/


Testing
---

Build fails with message about Maven version when using old one:

```
$ PATH=~/lib/apache-maven-3.0.5/bin:$PATH mvn -am -pl ambari-server validate
...
[INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-maven) @ ambari-server 
---
[WARNING] Rule 0: org.apache.maven.plugins.enforcer.RequireMavenVersion failed 
with message:
Detected Maven Version: 3.0.5 is not in the allowed range [3.3.9,).
...
[INFO] BUILD FAILURE
...
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-enforcer-plugin:1.4.1:enforce (enforce-maven) on 
project ambari-server: Some Enforcer rules have failed. Look above for specific 
messages explaining why the rule failed. -> [Help 1]
```

Build succeeds when using 3.3.9 or newer:

```
$ PATH=~/lib/apache-maven-3.3.9/bin:$PATH mvn -am -pl ambari-server validate
...
[INFO] BUILD SUCCESS
...
$ PATH=~/lib/apache-maven-3.5.0/bin:$PATH mvn -am -pl ambari-server validate
...
[INFO] BUILD SUCCESS
```


Thanks,

Attila Doroszlai

Re: Review Request 59884: AMBARI-21185. False positive unused import for nested class referenced only in Javadoc

2017-06-07 Thread Sebastian Toader


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59884/#review177182
---


Ship it!




Ship It!

- Sebastian Toader


On June 7, 2017, 6:22 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59884/
> ---
> 
> (Updated June 7, 2017, 6:22 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21185
> https://issues.apache.org/jira/browse/AMBARI-21185
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> * Added package qualifier for `StageWrapper.Type` link.  The import is 
> already removed.
> * Fixed other unresolved references in JavaDoc where I could find the current 
> "target", otherwise removed them.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  cabb9d6c9efe9aa76e4c17341712c200d37123dd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
>  7b6ac7e1ba16875a48b71e504963723c5ac038a7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
>  f8f8faac1afc42dd5d64d42d814c5030f88d1f68 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListener.java
>  5536ef9548473c3fce0f7199d22700d6bd42be14 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java
>  ad34ec7982980f7761243b8407ef382593e09541 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ServiceConfigDAO.java
>  72666e575902b561b1d62d07d6952adb904350a9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
>  475a8c9b3b04cdce18145165985f84ffa1cc3508 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
> 4fddd8ddac9e5bfa9bba4ce2c757154fb5c1bf42 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigFactory.java 
> dda5c9c98f4012bb92e476c5fb8d949e4afb234b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java
>  67ffefde85f73464c1af654706cc1b336ec4e1c3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertUri.java
>  2df1daed28a092afc7ebdb3e8aea16fc85e36106 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelper.java
>  802c8769032afb29559fb11a0624a0b4257158ea 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackUpgradeConfigurationMergeTest.java
>  97b94c3ea2d17d4a10ec12160c91d2c547bb889c 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java
>  8f59c077ba43dc327026ebd5df8a53ac52cd685c 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 
> eff6a9a8b54003319e695785d58263735896e7bd 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java
>  478b1264321661cd5541075873e2efd6ed757013 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java
>  b6fa6d24d98dbc5b595cc67888f5c5150edde85b 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java
>  336db3683022829d94138d360091dd8385daf29b 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalogHelper.java
>  1a9eed423172884c65b457389a3745ac68da0fa4 
> 
> 
> Diff: https://reviews.apache.org/r/59884/diff/1/
> 
> 
> Testing
> ---
> 
> * "Declaration has problems in JavaDoc references" check in IDEA
> * `mvn -am -pl ambari-server -DskipTests clean test` for compilation and 
> Checkstyle audit
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Review Request 59884: AMBARI-21185. False positive unused import for nested class referenced only in Javadoc

2017-06-07 Thread Attila Doroszlai


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59884/
---

Review request for Ambari, Jonathan Hurley and Sebastian Toader.


Bugs: AMBARI-21185
https://issues.apache.org/jira/browse/AMBARI-21185


Repository: ambari


Description
---

* Added package qualifier for `StageWrapper.Type` link.  The import is already 
removed.
* Fixed other unresolved references in JavaDoc where I could find the current 
"target", otherwise removed them.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 cabb9d6c9efe9aa76e4c17341712c200d37123dd 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
 7b6ac7e1ba16875a48b71e504963723c5ac038a7 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
 f8f8faac1afc42dd5d64d42d814c5030f88d1f68 
  
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListener.java
 5536ef9548473c3fce0f7199d22700d6bd42be14 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java
 ad34ec7982980f7761243b8407ef382593e09541 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ServiceConfigDAO.java
 72666e575902b561b1d62d07d6952adb904350a9 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
 475a8c9b3b04cdce18145165985f84ffa1cc3508 
  ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
4fddd8ddac9e5bfa9bba4ce2c757154fb5c1bf42 
  ambari-server/src/main/java/org/apache/ambari/server/state/ConfigFactory.java 
dda5c9c98f4012bb92e476c5fb8d949e4afb234b 
  
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java 
67ffefde85f73464c1af654706cc1b336ec4e1c3 
  
ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertUri.java 
2df1daed28a092afc7ebdb3e8aea16fc85e36106 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelper.java
 802c8769032afb29559fb11a0624a0b4257158ea 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackUpgradeConfigurationMergeTest.java
 97b94c3ea2d17d4a10ec12160c91d2c547bb889c 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java
 8f59c077ba43dc327026ebd5df8a53ac52cd685c 
  ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 
eff6a9a8b54003319e695785d58263735896e7bd 
  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java
 478b1264321661cd5541075873e2efd6ed757013 
  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java
 b6fa6d24d98dbc5b595cc67888f5c5150edde85b 
  
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java
 336db3683022829d94138d360091dd8385daf29b 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalogHelper.java
 1a9eed423172884c65b457389a3745ac68da0fa4 


Diff: https://reviews.apache.org/r/59884/diff/1/


Testing
---

* "Declaration has problems in JavaDoc references" check in IDEA
* `mvn -am -pl ambari-server -DskipTests clean test` for compilation and 
Checkstyle audit


Thanks,

Attila Doroszlai

Re: Review Request 59838: Stack advisor needs to recommend dependency for slaves and masters

2017-06-07 Thread Di Li


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59838/#review177170
---


Ship it!




Ship It!

- Di Li


On June 7, 2017, 12:26 p.m., Tim Thorpe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59838/
> ---
> 
> (Updated June 7, 2017, 12:26 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Di Li, Jaimin Jetly, Jonathan 
> Hurley, Jayush Luniya, and Nate Cole.
> 
> 
> Bugs: AMBARI-20122
> https://issues.apache.org/jira/browse/AMBARI-20122
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> After resolution of AMBARI-19685, stack advisor validates if stack defined 
> dependency is not satisfied but recommendation API does not account for this.
> 
> Stack defined dependencies are service/component based and has a scope 
> CLUSTER|HOST.  
> 
> During recommendation the services to install have already been selected.  We 
> can't really utilize the cluster scope because either the dependent service 
> was selected or it was not.  If it was not selected it will be caught during 
> validation.  We can only recommend based on HOST scope.
> 
> This JIRA is also limited to only handling those which don't have conditional 
> dependencies.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/stack_advisor.py 4a81dc6 
>   ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 
> 41c57f6 
> 
> 
> Diff: https://reviews.apache.org/r/59838/diff/3/
> 
> 
> Testing
> ---
> 
> Added new test case to test the recommendation of dependencies for slaves and 
> masters
> 
> mvn clean test -DskipSurefireTests
> 
> 
> New trunk without my change
> 
> Total run:1168
> Total errors:13
> Total failures:0
> 
> New trunk with my change
> 
> Total run:1169
> Total errors:13
> Total failures:0
> 
> 
> Thanks,
> 
> Tim Thorpe
> 
>

Re: Review Request 59727: AMBARI-21161 Able to safe guard Ambari server against circular dependencies in role command order

2017-06-07 Thread Tim Thorpe


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59727/#review177169
---


Ship it!




Ship It!

- Tim Thorpe


On June 6, 2017, 8:23 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59727/
> ---
> 
> (Updated June 6, 2017, 8:23 p.m.)
> 
> 
> Review request for Ambari and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21161
> https://issues.apache.org/jira/browse/AMBARI-21161
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> It is important to safe guard against cycle graphs, when Ambari supports 
> mpacks, custom services and service level role command order. Cycle graphs 
> indicate circular dependencies that can cause Ambari enter an infinite loop 
> while building stages, causing Ambari server to take up 100% CPU and large 
> amount of memory.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stageplanner/RoleGraph.java
>  024a5e1 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stageplanner/TestStagePlanner.java
>  271ee89 
>   ambari-server/src/test/resources/stacks/HDP/2.0.6.1/role_command_order.json 
> 6154004 
> 
> 
> Diff: https://reviews.apache.org/r/59727/diff/3/
> 
> 
> Testing
> ---
> 
> unit tests. patch a trunk cluster with code change and install HDP cluster, 
> intentionally add circular reference to make NN start depends on DN start  
> and DN start depends on NN start. Verify UI shows an error message when try 
> to start HDFS service, and does not really kick off the HDFS start. (without 
> the fix, Ambari server will try to start HDFS and gets itself into an 
> infinite loop and uses up 100% CPU and large amount of RAM)
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 59626: HDP deploy from public repo failed

2017-06-07 Thread Dmitro Lisnichenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59626/#review177168
---




utility/pom.xml
Lines 70 (patched)


jdeb goal for utils is broken without that


- Dmitro Lisnichenko


On June 7, 2017, 5:24 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59626/
> ---
> 
> (Updated June 7, 2017, 5:24 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-21091
> https://issues.apache.org/jira/browse/AMBARI-21091
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> We decided to select exact package version by looking through repository for 
> target stack.
> Also other minor fixes
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/packages_analyzer.py
>  8a15ee5ec5 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> 054490b03e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java
>  975d6a63d8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeHistoryEntity.java
>  8bfafd34bf 
>   ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 
> c12dff16b1 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java
>  35fffda001 
>   ambari-server/src/test/python/custom_actions/TestInstallPackages.py 
> 5f5576e3e7 
>   
> ambari-server/src/test/python/custom_actions/configs/install_packages_config.json
>  c6575b51a7 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py 
> fda63e099a 
>   ambari-server/src/test/python/stacks/2.0.6/configs/hbase_with_phx.json 
> 51476031d8 
>   utility/pom.xml 7d5eb930d9 
> 
> 
> Diff: https://reviews.apache.org/r/59626/diff/3/
> 
> 
> Testing
> ---
> 
> Live cluster tests
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 59626: HDP deploy from public repo failed

2017-06-07 Thread Dmitro Lisnichenko



> On June 1, 2017, 9:40 p.m., Nate Cole wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/packages_analyzer.py
> > Lines 118-126 (patched)
> > 
> >
> > Can we target package lists by using the specific repo id?  I think 
> > both zypper and yum allow using ONLY a repo id.  For ubuntu we may need 
> > some magic.

you are right


- Dmitro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59626/#review176642
---


On June 7, 2017, 5:24 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59626/
> ---
> 
> (Updated June 7, 2017, 5:24 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-21091
> https://issues.apache.org/jira/browse/AMBARI-21091
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> We decided to select exact package version by looking through repository for 
> target stack.
> Also other minor fixes
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/packages_analyzer.py
>  8a15ee5ec5 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> 054490b03e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java
>  975d6a63d8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeHistoryEntity.java
>  8bfafd34bf 
>   ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 
> c12dff16b1 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java
>  35fffda001 
>   ambari-server/src/test/python/custom_actions/TestInstallPackages.py 
> 5f5576e3e7 
>   
> ambari-server/src/test/python/custom_actions/configs/install_packages_config.json
>  c6575b51a7 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py 
> fda63e099a 
>   ambari-server/src/test/python/stacks/2.0.6/configs/hbase_with_phx.json 
> 51476031d8 
>   utility/pom.xml 7d5eb930d9 
> 
> 
> Diff: https://reviews.apache.org/r/59626/diff/3/
> 
> 
> Testing
> ---
> 
> Live cluster tests
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 59626: HDP deploy from public repo failed

2017-06-07 Thread Dmitro Lisnichenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59626/
---

(Updated June 7, 2017, 5:24 p.m.)


Review request for Ambari, Jonathan Hurley and Nate Cole.


Changes
---

Added magic for Ubuntu.
Need more magic for Suse (also, ambari-setup for Suse seems to be broken)


Bugs: AMBARI-21091
https://issues.apache.org/jira/browse/AMBARI-21091


Repository: ambari


Description
---

We decided to select exact package version by looking through repository for 
target stack.
Also other minor fixes


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/packages_analyzer.py
 8a15ee5ec5 
  ambari-common/src/main/python/resource_management/libraries/script/script.py 
054490b03e 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java
 975d6a63d8 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeHistoryEntity.java
 8bfafd34bf 
  ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 
c12dff16b1 
  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java
 35fffda001 
  ambari-server/src/test/python/custom_actions/TestInstallPackages.py 
5f5576e3e7 
  
ambari-server/src/test/python/custom_actions/configs/install_packages_config.json
 c6575b51a7 
  ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py 
fda63e099a 
  ambari-server/src/test/python/stacks/2.0.6/configs/hbase_with_phx.json 
51476031d8 
  utility/pom.xml 7d5eb930d9 


Diff: https://reviews.apache.org/r/59626/diff/3/

Changes: https://reviews.apache.org/r/59626/diff/2-3/


Testing
---

Live cluster tests


Thanks,

Dmitro Lisnichenko

Re: Review Request 59838: Stack advisor needs to recommend dependency for slaves and masters

2017-06-07 Thread Tim Thorpe


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59838/
---

(Updated June 7, 2017, 12:26 p.m.)


Review request for Ambari, Alejandro Fernandez, Di Li, Jaimin Jetly, Jonathan 
Hurley, Jayush Luniya, and Nate Cole.


Changes
---

Removed white space


Bugs: AMBARI-20122
https://issues.apache.org/jira/browse/AMBARI-20122


Repository: ambari


Description
---

After resolution of AMBARI-19685, stack advisor validates if stack defined 
dependency is not satisfied but recommendation API does not account for this.

Stack defined dependencies are service/component based and has a scope 
CLUSTER|HOST.  

During recommendation the services to install have already been selected.  We 
can't really utilize the cluster scope because either the dependent service was 
selected or it was not.  If it was not selected it will be caught during 
validation.  We can only recommend based on HOST scope.

This JIRA is also limited to only handling those which don't have conditional 
dependencies.


Diffs (updated)
-

  ambari-server/src/main/resources/stacks/stack_advisor.py 4a81dc6 
  ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 
41c57f6 


Diff: https://reviews.apache.org/r/59838/diff/3/

Changes: https://reviews.apache.org/r/59838/diff/2-3/


Testing
---

Added new test case to test the recommendation of dependencies for slaves and 
masters

mvn clean test -DskipSurefireTests


New trunk without my change

Total run:1168
Total errors:13
Total failures:0

New trunk with my change

Total run:1169
Total errors:13
Total failures:0


Thanks,

Tim Thorpe

Re: Review Request 59838: Stack advisor needs to recommend dependency for slaves and masters

2017-06-07 Thread Tim Thorpe


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59838/
---

(Updated June 7, 2017, 12:23 p.m.)


Review request for Ambari, Alejandro Fernandez, Di Li, Jaimin Jetly, Jonathan 
Hurley, Jayush Luniya, and Nate Cole.


Changes
---

Updated patch to include documenting new functions.


Bugs: AMBARI-20122
https://issues.apache.org/jira/browse/AMBARI-20122


Repository: ambari


Description
---

After resolution of AMBARI-19685, stack advisor validates if stack defined 
dependency is not satisfied but recommendation API does not account for this.

Stack defined dependencies are service/component based and has a scope 
CLUSTER|HOST.  

During recommendation the services to install have already been selected.  We 
can't really utilize the cluster scope because either the dependent service was 
selected or it was not.  If it was not selected it will be caught during 
validation.  We can only recommend based on HOST scope.

This JIRA is also limited to only handling those which don't have conditional 
dependencies.


Diffs (updated)
-

  ambari-server/src/main/resources/stacks/stack_advisor.py 4a81dc6 
  ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 
41c57f6 


Diff: https://reviews.apache.org/r/59838/diff/2/

Changes: https://reviews.apache.org/r/59838/diff/1-2/


Testing
---

Added new test case to test the recommendation of dependencies for slaves and 
masters

mvn clean test -DskipSurefireTests


New trunk without my change

Total run:1168
Total errors:13
Total failures:0

New trunk with my change

Total run:1169
Total errors:13
Total failures:0


Thanks,

Tim Thorpe

Re: Review Request 59846: Get rid deprecated jdk install in the Dockerfile of Log Search

2017-06-07 Thread Miklos Gergely


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59846/#review177163
---


Ship it!




Ship It!

- Miklos Gergely


On June 6, 2017, 5:14 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59846/
> ---
> 
> (Updated June 6, 2017, 5:14 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely and Robert Nettleton.
> 
> 
> Bugs: trunk
> https://issues.apache.org/jira/browse/trunk
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> JDK download location does not exists anymore. (also uses a hash for jdk 
> version, from now, its required)
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/docker/Dockerfile d399fc6 
> 
> 
> Diff: https://reviews.apache.org/r/59846/diff/1/
> 
> 
> Testing
> ---
> 
> done, manually.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Review Request 59877: Custom log4j.properties of Flume

2017-06-07 Thread wang jianfei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59877/
---

Review request for Ambari, Dmytro Sen, Jaimin Jetly, and Vitalyi Brodetskyi.


Bugs: AMBARI-21191
https://issues.apache.org/jira/browse/AMBARI-21191


Repository: ambari


Description
---

Currently,if you want to config log4j.properties of Flume,you must change the 
log4j.properties.j2 in the ambari-agent-host installed flume-agent.
So,we make it configurable by adding log4j.properties.template.


Diffs
-

  
ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/configuration/flume-log4j.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume.py
 6b1d286 


Diff: https://reviews.apache.org/r/59877/diff/1/


Testing
---

Manually tested.


Thanks,

wang jianfei

Re: Review Request 59851: Configuration Symlink Is Incorrect After Stack Distribution

2017-06-07 Thread Dmitro Lisnichenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59851/#review177160
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On June 6, 2017, 9:44 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59851/
> ---
> 
> (Updated June 6, 2017, 9:44 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
> 
> 
> Bugs: AMBARI-21188
> https://issues.apache.org/jira/browse/AMBARI-21188
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The configuration symlinks for a component after installation should reflect 
> something similar to the following:
> 
> /etc/component/conf -> /usr/hdp/current/component/conf
> /usr/hdp/current/component/conf -> /etc/component//conf
> 
> For example:
> {noformat}
> [root@c6403 ~]# ll /etc/zookeeper/
> total 12
> drwxr-xr-x 3 root  root   4096 Jun  5 20:19 2.4.2.0-236
> drwxr-xr-x 3 root  root   4096 Jun  5 20:38 2.6.0.0-334
> lrwxrwxrwx 1 root  root 26 Jun  5 20:38 conf -> 
> /usr/hdp/current/zookeeper-server/conf
> drwxr-xr-x 2 zookeeper hadoop 4096 Jun  5 20:17 conf.backup
> 
> [root@c6403 ~]# ll /usr/hdp/current/zookeeper-server/conf
> lrwxrwxrwx 1 root root 28 Jun  5 20:38 /usr/hdp/current/zookeeper-server/conf 
> -> /etc/zookeeper/2.6.0.0-334/0
> {noformat}
> 
> This is the way that the structure exists after a normal installation today. 
> However, it seems that distribution a new stack breaks this:
> 
> {code}
> [root@c6403 zookeeper]# ll /etc/zookeeper/
> total 12
> drwxr-xr-x 3 root  root   4096 Jun  5 20:19 2.4.2.0-236
> drwxr-xr-x 3 root  root   4096 Jun  5 20:38 2.6.0.0-334
> lrwxrwxrwx 1 root  root 26 Jun  5 20:38 conf -> 
> /etc/zookeeper/conf.backup
> drwxr-xr-x 2 zookeeper hadoop 4096 Jun  5 20:17 conf.backup
> {code}
> 
> The {{conf}} symlink is now pointing to {{conf.backup}} which is the interim 
> temporary location.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py
>  facf186f0e 
>   ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 
> c12dff16b1 
> 
> 
> Diff: https://reviews.apache.org/r/59851/diff/1/
> 
> 
> Testing
> ---
> 
> Total run:1168
> Total errors:0
> Total failures:0
> OK
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 01:23 min
> [INFO] Finished at: 2017-06-06T14:43:58-04:00
> [INFO] Final Memory: 18M/245M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 59574: Add AMS HA support to local metrics aggregator application

2017-06-07 Thread Dmytro Sen



> On Май 30, 2017, 7:47 п.п., Aravindan Vijayan wrote:
> > ambari-metrics/ambari-metrics-host-aggregator/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractMetricPublisher.java
> > Lines 61 (patched)
> > 
> >
> > Are we making changes such that ams-site in all hosts? If not, then 
> > this is a problem.

We do this change in all hosts. This change is already committed into ams.py as 
part of AMBARI-20758


- Dmytro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59574/#review176339
---


On Май 26, 2017, 1:03 п.п., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59574/
> ---
> 
> (Updated Май 26, 2017, 1:03 п.п.)
> 
> 
> Review request for Ambari, Aravindan Vijayan and Sid Wagle.
> 
> 
> Bugs: AMBARI-21128
> https://issues.apache.org/jira/browse/AMBARI-21128
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add AMS HA support for local in-memory metrics aggregation application 
> implemented in AMBARI-20758
> This include switching to working collector
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
>  a8dc571 
>   ambari-metrics/ambari-metrics-host-aggregator/pom.xml 0598bef 
>   
> ambari-metrics/ambari-metrics-host-aggregator/src/main/java/org/apache/hadoop/metrics2/host/aggregator/AbstractMetricPublisherThread.java
>  b1f60fa 
>   
> ambari-metrics/ambari-metrics-host-aggregator/src/main/java/org/apache/hadoop/metrics2/host/aggregator/AggregatedMetricsPublisher.java
>  0540ec9 
>   
> ambari-metrics/ambari-metrics-host-aggregator/src/main/java/org/apache/hadoop/metrics2/host/aggregator/AggregatorApplication.java
>  c6b703b 
>   
> ambari-metrics/ambari-metrics-host-aggregator/src/main/java/org/apache/hadoop/metrics2/host/aggregator/AggregatorWebService.java
>  f96d0ed 
>   
> ambari-metrics/ambari-metrics-host-aggregator/src/main/java/org/apache/hadoop/metrics2/host/aggregator/RawMetricsPublisher.java
>  f317ed9 
>   
> ambari-metrics/ambari-metrics-host-aggregator/src/main/java/org/apache/hadoop/metrics2/host/aggregator/TimelineMetricsHolder.java
>  b355c97 
>   
> ambari-metrics/ambari-metrics-host-aggregator/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractMetricPublisher.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-host-aggregator/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AggregatedMetricsPublisher.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-host-aggregator/src/main/java/org/apache/hadoop/metrics2/sink/timeline/RawMetricsPublisher.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-host-aggregator/src/test/java/org/apache/hadoop/metrics2/host/aggregator/TimelineMetricsHolderTest.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-host-aggregator/src/test/java/org/apache/hadoop/metrics2/sink/timeline/AbstractMetricPublisherTest.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-host-aggregator/src/test/java/org/apache/hadoop/metrics2/sink/timeline/AggregatedMetricsPublisherTest.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-host-aggregator/src/test/java/org/apache/hadoop/metrics2/sink/timeline/RawMetricsPublisherTest.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/aggregator.py
>  2249e53 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/controller.py
>  e5da9ba 
> 
> 
> Diff: https://reviews.apache.org/r/59574/diff/2/
> 
> 
> Testing
> ---
> 
> Unit tests + manual testing with AMS HA
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 59574: Add AMS HA support to local metrics aggregator application

2017-06-07 Thread Dmytro Sen



> On Май 30, 2017, 7:47 п.п., Aravindan Vijayan wrote:
> > ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/aggregator.py
> > Line 46 (original), 47 (patched)
> > 
> >
> > FYI, This means there is no Zk fallback for getting collector hosts in 
> > the AggregatorApplication. (Like metric monitors).

The passed argument is an own hostname, not collector's. The hostname is used 
for sharding. Publisher will try to get working collector host from ZK if the 
current collector host is not available


- Dmytro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59574/#review176339
---


On Май 26, 2017, 1:03 п.п., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59574/
> ---
> 
> (Updated Май 26, 2017, 1:03 п.п.)
> 
> 
> Review request for Ambari, Aravindan Vijayan and Sid Wagle.
> 
> 
> Bugs: AMBARI-21128
> https://issues.apache.org/jira/browse/AMBARI-21128
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add AMS HA support for local in-memory metrics aggregation application 
> implemented in AMBARI-20758
> This include switching to working collector
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
>  a8dc571 
>   ambari-metrics/ambari-metrics-host-aggregator/pom.xml 0598bef 
>   
> ambari-metrics/ambari-metrics-host-aggregator/src/main/java/org/apache/hadoop/metrics2/host/aggregator/AbstractMetricPublisherThread.java
>  b1f60fa 
>   
> ambari-metrics/ambari-metrics-host-aggregator/src/main/java/org/apache/hadoop/metrics2/host/aggregator/AggregatedMetricsPublisher.java
>  0540ec9 
>   
> ambari-metrics/ambari-metrics-host-aggregator/src/main/java/org/apache/hadoop/metrics2/host/aggregator/AggregatorApplication.java
>  c6b703b 
>   
> ambari-metrics/ambari-metrics-host-aggregator/src/main/java/org/apache/hadoop/metrics2/host/aggregator/AggregatorWebService.java
>  f96d0ed 
>   
> ambari-metrics/ambari-metrics-host-aggregator/src/main/java/org/apache/hadoop/metrics2/host/aggregator/RawMetricsPublisher.java
>  f317ed9 
>   
> ambari-metrics/ambari-metrics-host-aggregator/src/main/java/org/apache/hadoop/metrics2/host/aggregator/TimelineMetricsHolder.java
>  b355c97 
>   
> ambari-metrics/ambari-metrics-host-aggregator/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractMetricPublisher.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-host-aggregator/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AggregatedMetricsPublisher.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-host-aggregator/src/main/java/org/apache/hadoop/metrics2/sink/timeline/RawMetricsPublisher.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-host-aggregator/src/test/java/org/apache/hadoop/metrics2/host/aggregator/TimelineMetricsHolderTest.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-host-aggregator/src/test/java/org/apache/hadoop/metrics2/sink/timeline/AbstractMetricPublisherTest.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-host-aggregator/src/test/java/org/apache/hadoop/metrics2/sink/timeline/AggregatedMetricsPublisherTest.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-host-aggregator/src/test/java/org/apache/hadoop/metrics2/sink/timeline/RawMetricsPublisherTest.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/aggregator.py
>  2249e53 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/controller.py
>  e5da9ba 
> 
> 
> Diff: https://reviews.apache.org/r/59574/diff/2/
> 
> 
> Testing
> ---
> 
> Unit tests + manual testing with AMS HA
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 59888: Fix ambari-solr-plugin folder structure

Re: Review Request 59888: Fix ambari-solr-plugin folder structure

Re: Review Request 59149: Add Kerberos HTTP SPNEGO authentication support to Hadoop/hbase/kafka/storm sinks

Re: Review Request 59149: Add Kerberos HTTP SPNEGO authentication support to Hadoop/hbase/kafka/storm sinks

Re: Review Request 59870: Part Two: Specify the script directly in alert target for script-based alert dispatchers

Re: Review Request 59870: Part Two: Specify the script directly in alert target for script-based alert dispatchers

Re: Review Request 59149: Add Kerberos HTTP SPNEGO authentication support to Hadoop/hbase/kafka/storm sinks

Re: Review Request 59888: Fix ambari-solr-plugin folder structure

Re: Review Request 59884: AMBARI-21185. False positive unused import for nested class referenced only in Javadoc

Re: Review Request 59886: AMBARI-21195. Enforce minimum Maven version

Re: Review Request 59886: AMBARI-21195. Enforce minimum Maven version

Review Request 59888: Fix ambari-solr-plugin folder structure

Re: Review Request 59877: Custom log4j.properties of Flume

Re: Review Request 59886: AMBARI-21195. Enforce minimum Maven version

Re: Review Request 59886: AMBARI-21195. Enforce minimum Maven version

Review Request 59886: AMBARI-21195. Enforce minimum Maven version

Re: Review Request 59884: AMBARI-21185. False positive unused import for nested class referenced only in Javadoc

Review Request 59884: AMBARI-21185. False positive unused import for nested class referenced only in Javadoc

Re: Review Request 59838: Stack advisor needs to recommend dependency for slaves and masters

Re: Review Request 59727: AMBARI-21161 Able to safe guard Ambari server against circular dependencies in role command order

Re: Review Request 59626: HDP deploy from public repo failed

Re: Review Request 59626: HDP deploy from public repo failed

Re: Review Request 59626: HDP deploy from public repo failed

Re: Review Request 59838: Stack advisor needs to recommend dependency for slaves and masters

Re: Review Request 59838: Stack advisor needs to recommend dependency for slaves and masters

Re: Review Request 59846: Get rid deprecated jdk install in the Dockerfile of Log Search

Review Request 59877: Custom log4j.properties of Flume

Re: Review Request 59851: Configuration Symlink Is Incorrect After Stack Distribution

Re: Review Request 59574: Add AMS HA support to local metrics aggregator application

Re: Review Request 59574: Add AMS HA support to local metrics aggregator application

30 matches

Site Navigation

Mail list logo

Footer information