Re: Review Request 63034: AMBARI-22244. Update service component API call to work for second service instance

[Swapan Shridhar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63034/#review188424
---


Ship it!




Ship It!

- Swapan Shridhar


On Oct. 17, 2017, 6:34 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63034/
> ---
> 
> (Updated Oct. 17, 2017, 6:34 p.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Jayush Luniya, Madhuvanthi 
> Radhakrishnan, Sandor Magyari, and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-22244
> https://issues.apache.org/jira/browse/AMBARI-22244
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Replaced `serviceName` with `serviceType` in `getService` and `getComponent` 
> calls where found to be necessary.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapper.java
>  ff13d0bc5334922e138ed622f9120a94c6c05883 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
>  bb298d5a5ceda4619de958c7a529101c6e4f2e3f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/alerts/ComponentVersionAlertRunnable.java
>  45cc97348e89cdf5bd73a5d4d6139f808bc23180 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  2bb450bd0ac6a0da064d892e74bbdd05e2475dd6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ComponentService.java
>  60230f6b9fe476deed40ed0f4083ec24bea742f5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ComponentsExistInRepoCheck.java
>  69492574f8756006c9bd7aab495efb269265cfb7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java
>  5ecce88a84bb8897788fe881f0059fcb553c776f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java
>  0f6eb90803ca6b7a5fb9791294a269aaf4e45fb9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  ff35e8042846767adf858a112d0e9da729b81b84 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  58f1cbd464e3b4176cbc5535b92904cd27d8fb3b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
>  ca80961ab3634960e8f12cc56b876109afae33ec 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
>  ba5a4e78aebb49dbcc24d220c35abfd46fe3dbc0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java
>  f7559c6d3422f4902e28b4f205564bc0ac0aaefa 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java
>  ba5fccc1dc1d6ace00ba0f9f36820b055a66ce3b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java
>  252d7726e392307e1a8a0688b8de4e95e4982e8e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProvider.java
>  8c2198bc185da616200bf2701acd4cb8a31f7022 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProvider.java
>  0cd55c31a90a17bcd3a8b17783156dc92b2a6a57 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java
>  cae330b3466982923deb388ac5323c67fffea02d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/DatabaseChecker.java
>  e3f4e1a005c358ef5a7801691b56c9b91c9aaa11 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/DefaultServiceCalculatedState.java
>  603e650894ab27d12cbe2b9c49daf299e5818d5f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HBaseServiceCalculatedState.java
>  765e6fcaaa75086d2bc37e058b6e69e1268be8c2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HDFSServiceCalculatedState.java
>  704b4b96fbe5b54a7c36c22280f27142c0a8cfe9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HiveServiceCalculatedState.java
>  5e23f0b592519746c111dd89afbda37a79c425b7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/OozieServiceCalculatedState.java
>  6c5eab4090a18dce7cea29d8d5038d5ad964fe1c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/YARNServiceCalculatedState.java
>  2fd99e48c34605cd2e28ffdba0c2ea40fe6b49ab 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertMaintenanceModeListener.java
>  

Re: Review Request 63051: Add service group dependencies

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63051/
---

(Updated Жов. 17, 2017, 8:38 після полудня)


Review request for Ambari, Jayush Luniya and Swapan Shridhar.


Bugs: AMBARI-22249
https://issues.apache.org/jira/browse/AMBARI-22249


Repository: ambari


Description
---

Add table servicegroupdependencies


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupRequest.java
 53c3d1e 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupResponse.java
 147650c 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceGroupResourceProvider.java
 2e935af 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceGroupEntity.java
 7f8facb 
  ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
8fd878e 
  ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroup.java 
9850462 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupFactory.java
 7146bdf 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupImpl.java
 735a946 
  
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
 fcc07b6 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
 0434728 
  ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b8c0a42 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c56e486 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 8917d48 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f48bcd6 
  ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql e7c5c72 
  ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql f87af4c 


Diff: https://reviews.apache.org/r/63051/diff/2/

Changes: https://reviews.apache.org/r/63051/diff/1-2/


Testing
---

Will fix tests after patch approve


Thanks,

Vitalyi Brodetskyi

Re: Review Request 63034: AMBARI-22244. Update service component API call to work for second service instance

[Madhuvanthi Radhakrishnan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63034/#review188379
---


Ship it!




Ship It!

- Madhuvanthi Radhakrishnan


On Oct. 17, 2017, 6:34 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63034/
> ---
> 
> (Updated Oct. 17, 2017, 6:34 p.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Jayush Luniya, Madhuvanthi 
> Radhakrishnan, Sandor Magyari, and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-22244
> https://issues.apache.org/jira/browse/AMBARI-22244
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Replaced `serviceName` with `serviceType` in `getService` and `getComponent` 
> calls where found to be necessary.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapper.java
>  ff13d0bc5334922e138ed622f9120a94c6c05883 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
>  bb298d5a5ceda4619de958c7a529101c6e4f2e3f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/alerts/ComponentVersionAlertRunnable.java
>  45cc97348e89cdf5bd73a5d4d6139f808bc23180 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  2bb450bd0ac6a0da064d892e74bbdd05e2475dd6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ComponentService.java
>  60230f6b9fe476deed40ed0f4083ec24bea742f5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ComponentsExistInRepoCheck.java
>  69492574f8756006c9bd7aab495efb269265cfb7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java
>  5ecce88a84bb8897788fe881f0059fcb553c776f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java
>  0f6eb90803ca6b7a5fb9791294a269aaf4e45fb9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  ff35e8042846767adf858a112d0e9da729b81b84 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  58f1cbd464e3b4176cbc5535b92904cd27d8fb3b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
>  ca80961ab3634960e8f12cc56b876109afae33ec 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
>  ba5a4e78aebb49dbcc24d220c35abfd46fe3dbc0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java
>  f7559c6d3422f4902e28b4f205564bc0ac0aaefa 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java
>  ba5fccc1dc1d6ace00ba0f9f36820b055a66ce3b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java
>  252d7726e392307e1a8a0688b8de4e95e4982e8e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProvider.java
>  8c2198bc185da616200bf2701acd4cb8a31f7022 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProvider.java
>  0cd55c31a90a17bcd3a8b17783156dc92b2a6a57 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java
>  cae330b3466982923deb388ac5323c67fffea02d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/DatabaseChecker.java
>  e3f4e1a005c358ef5a7801691b56c9b91c9aaa11 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/DefaultServiceCalculatedState.java
>  603e650894ab27d12cbe2b9c49daf299e5818d5f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HBaseServiceCalculatedState.java
>  765e6fcaaa75086d2bc37e058b6e69e1268be8c2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HDFSServiceCalculatedState.java
>  704b4b96fbe5b54a7c36c22280f27142c0a8cfe9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HiveServiceCalculatedState.java
>  5e23f0b592519746c111dd89afbda37a79c425b7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/OozieServiceCalculatedState.java
>  6c5eab4090a18dce7cea29d8d5038d5ad964fe1c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/YARNServiceCalculatedState.java
>  2fd99e48c34605cd2e28ffdba0c2ea40fe6b49ab 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertMaintenanceModeListener.java
>  

Re: Review Request 63034: AMBARI-22244. Update service component API call to work for second service instance

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63034/
---

(Updated Oct. 17, 2017, 8:34 p.m.)


Review request for Ambari, Balázs Bence Sári, Jayush Luniya, Madhuvanthi 
Radhakrishnan, Sandor Magyari, and Swapan Shridhar.


Changes
---

replaced `serviceName` in few more places


Bugs: AMBARI-22244
https://issues.apache.org/jira/browse/AMBARI-22244


Repository: ambari


Description
---

Replaced `serviceName` with `serviceType` in `getService` and `getComponent` 
calls where found to be necessary.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapper.java
 ff13d0bc5334922e138ed622f9120a94c6c05883 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
 bb298d5a5ceda4619de958c7a529101c6e4f2e3f 
  
ambari-server/src/main/java/org/apache/ambari/server/alerts/ComponentVersionAlertRunnable.java
 45cc97348e89cdf5bd73a5d4d6139f808bc23180 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
 2bb450bd0ac6a0da064d892e74bbdd05e2475dd6 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ComponentService.java
 60230f6b9fe476deed40ed0f4083ec24bea742f5 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/ComponentsExistInRepoCheck.java
 69492574f8756006c9bd7aab495efb269265cfb7 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java
 5ecce88a84bb8897788fe881f0059fcb553c776f 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java
 0f6eb90803ca6b7a5fb9791294a269aaf4e45fb9 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 ff35e8042846767adf858a112d0e9da729b81b84 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 58f1cbd464e3b4176cbc5535b92904cd27d8fb3b 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
 ca80961ab3634960e8f12cc56b876109afae33ec 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
 ba5a4e78aebb49dbcc24d220c35abfd46fe3dbc0 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java
 f7559c6d3422f4902e28b4f205564bc0ac0aaefa 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java
 ba5fccc1dc1d6ace00ba0f9f36820b055a66ce3b 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java
 252d7726e392307e1a8a0688b8de4e95e4982e8e 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProvider.java
 8c2198bc185da616200bf2701acd4cb8a31f7022 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProvider.java
 0cd55c31a90a17bcd3a8b17783156dc92b2a6a57 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java
 cae330b3466982923deb388ac5323c67fffea02d 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/DatabaseChecker.java
 e3f4e1a005c358ef5a7801691b56c9b91c9aaa11 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/DefaultServiceCalculatedState.java
 603e650894ab27d12cbe2b9c49daf299e5818d5f 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HBaseServiceCalculatedState.java
 765e6fcaaa75086d2bc37e058b6e69e1268be8c2 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HDFSServiceCalculatedState.java
 704b4b96fbe5b54a7c36c22280f27142c0a8cfe9 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HiveServiceCalculatedState.java
 5e23f0b592519746c111dd89afbda37a79c425b7 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/OozieServiceCalculatedState.java
 6c5eab4090a18dce7cea29d8d5038d5ad964fe1c 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/YARNServiceCalculatedState.java
 2fd99e48c34605cd2e28ffdba0c2ea40fe6b49ab 
  
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertMaintenanceModeListener.java
 f73d7c98ef6639fa7feaea4399b39b8b6b70a7e0 
  
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertServiceStateListener.java
 053fb5417ddd09a98a66a1bdf45ca0e569b5ed4e 
  
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListener.java
 4846eb1d68049965615ab4366adf32c5e9b1f4be 
  
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java
 

Re: Review Request 63080: Smartsense requires HDFS to be always present while installing

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63080/#review188332
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Жов. 17, 2017, 5:15 після полудня, Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63080/
> ---
> 
> (Updated Жов. 17, 2017, 5:15 після полудня)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-22256
> https://issues.apache.org/jira/browse/AMBARI-22256
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Smartsense cannot be installed without HDFS in the cluster.  
> I am getting the below exception
> 
> 
> 
> 
> Traceback (most recent call last):
>   File 
> "/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/hooks/before-START/scripts/hook.py",
>  line 43, in 
> BeforeStartHook().execute()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
>  line 367, in execute
> method(env)
>   File 
> "/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/hooks/before-START/scripts/hook.py",
>  line 29, in hook
> import params
>   File 
> "/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py",
>  line 331, in 
> if "core-site" in config['configurations'] and namenode_rpc:
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/config_dictionary.py",
>  line 73, in __getattr__
> raise Fail("Configuration parameter '" + self.name + "' was not found 
> in configurations dictionary!")
> resource_management.core.exceptions.Fail: Configuration parameter 
> 'fs.defaultFS' was not found in configurations dictionary!
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py
>  55a609328e 
> 
> 
> Diff: https://reviews.apache.org/r/63080/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Review Request 63080: Smartsense requires HDFS to be always present while installing

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63080/
---

Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-22256
https://issues.apache.org/jira/browse/AMBARI-22256


Repository: ambari


Description
---

Smartsense cannot be installed without HDFS in the cluster.  
I am getting the below exception




Traceback (most recent call last):
  File 
"/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/hooks/before-START/scripts/hook.py",
 line 43, in 
BeforeStartHook().execute()
  File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
 line 367, in execute
method(env)
  File 
"/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/hooks/before-START/scripts/hook.py",
 line 29, in hook
import params
  File 
"/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py",
 line 331, in 
if "core-site" in config['configurations'] and namenode_rpc:
  File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/script/config_dictionary.py",
 line 73, in __getattr__
raise Fail("Configuration parameter '" + self.name + "' was not found 
in configurations dictionary!")
resource_management.core.exceptions.Fail: Configuration parameter 
'fs.defaultFS' was not found in configurations dictionary!


Diffs
-

  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py
 55a609328e 


Diff: https://reviews.apache.org/r/63080/diff/1/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 63075: RU: RU failed on "Updating configuration sqoop-atlas-application.properties"

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63075/#review188330
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Oct. 17, 2017, 5:22 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63075/
> ---
> 
> (Updated Oct. 17, 2017, 5:22 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-22254
> https://issues.apache.org/jira/browse/AMBARI-22254
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Config types are associated with a service.  As a fallback, use the enclosed 
> config-task's service as the source of the service name.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java
>  5c65911a9e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java
>  d8676bdb58 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java
>  7ad02579e8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java
>  9f4440f055 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java
>  d789ab45d9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/ConfigUpgradeValidityTest.java
>  44f72bd72a 
> 
> 
> Diff: https://reviews.apache.org/r/63075/diff/1/
> 
> 
> Testing
> ---
> 
> Manual.  Unit tests:
> 
> [WARNING] Tests run: 4921, Failures: 0, Errors: 0, Skipped: 34
> [INFO]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 24:01.536s
> [INFO] Finished at: Tue Oct 17 10:47:00 EDT 2017
> [INFO] Final Memory: 99M/1912M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 63034: AMBARI-22244. Update service component API call to work for second service instance

[Madhuvanthi Radhakrishnan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63034/#review188326
---




ambari-server/src/main/java/org/apache/ambari/server/checks/ComponentsExistInRepoCheck.java
Line 78 (original), 78 (patched)


Do we not need to change here?


- Madhuvanthi Radhakrishnan


On Oct. 17, 2017, 1:46 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63034/
> ---
> 
> (Updated Oct. 17, 2017, 1:46 p.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Jayush Luniya, Madhuvanthi 
> Radhakrishnan, Sandor Magyari, and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-22244
> https://issues.apache.org/jira/browse/AMBARI-22244
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Replaced `serviceName` with `serviceType` in `getService` and `getComponent` 
> calls where found to be necessary.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
>  bb298d5a5ceda4619de958c7a529101c6e4f2e3f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/alerts/ComponentVersionAlertRunnable.java
>  45cc97348e89cdf5bd73a5d4d6139f808bc23180 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  2bb450bd0ac6a0da064d892e74bbdd05e2475dd6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ComponentService.java
>  60230f6b9fe476deed40ed0f4083ec24bea742f5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ComponentsExistInRepoCheck.java
>  69492574f8756006c9bd7aab495efb269265cfb7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java
>  5ecce88a84bb8897788fe881f0059fcb553c776f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java
>  0f6eb90803ca6b7a5fb9791294a269aaf4e45fb9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  e12477eede7176a19b456294602f91d44a35ad61 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  28b5c28e848720191ddcdf142d52c862755eaab0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
>  ca80961ab3634960e8f12cc56b876109afae33ec 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
>  ba5a4e78aebb49dbcc24d220c35abfd46fe3dbc0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java
>  f7559c6d3422f4902e28b4f205564bc0ac0aaefa 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java
>  ba5fccc1dc1d6ace00ba0f9f36820b055a66ce3b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java
>  252d7726e392307e1a8a0688b8de4e95e4982e8e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProvider.java
>  8c2198bc185da616200bf2701acd4cb8a31f7022 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProvider.java
>  0cd55c31a90a17bcd3a8b17783156dc92b2a6a57 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java
>  cae330b3466982923deb388ac5323c67fffea02d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/DatabaseChecker.java
>  e3f4e1a005c358ef5a7801691b56c9b91c9aaa11 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/DefaultServiceCalculatedState.java
>  603e650894ab27d12cbe2b9c49daf299e5818d5f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HBaseServiceCalculatedState.java
>  765e6fcaaa75086d2bc37e058b6e69e1268be8c2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HDFSServiceCalculatedState.java
>  704b4b96fbe5b54a7c36c22280f27142c0a8cfe9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HiveServiceCalculatedState.java
>  5e23f0b592519746c111dd89afbda37a79c425b7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/OozieServiceCalculatedState.java
>  6c5eab4090a18dce7cea29d8d5038d5ad964fe1c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/YARNServiceCalculatedState.java
>  2fd99e48c34605cd2e28ffdba0c2ea40fe6b49ab 
>   
> 

Re: Review Request 63044: Update JWT Authentication process to work with improved user management facility

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63044/#review188321
---


Ship it!




Ship It!

- Sebastian Toader


On Oct. 16, 2017, 11:02 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63044/
> ---
> 
> (Updated Oct. 16, 2017, 11:02 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, Myroslav Papirkovskyy, Nate Cole, 
> Robert Nettleton, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21217
> https://issues.apache.org/jira/browse/AMBARI-21217
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update JWT Authentication process to work with improved user management 
> facility
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/AmbariErrorHandler.java
>  a57effcd62 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  62e8b864f5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  0d24ef21e7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationEventHandlerImpl.java
>  4cfce2a373 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationFilter.java
>  b3bc4c31fe 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationProvider.java
>  3d20cb9ec2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariBasicAuthenticationFilter.java
>  3667012ae4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariJWTAuthenticationFilter.java
>  3d35578524 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariLocalAuthenticationProvider.java
>  dcdf4710d4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/UserNotFoundException.java
>  0f2fbb6477 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/jwt/AmbariJwtAuthenticationProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/jwt/JwtAuthenticationToken.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/kerberos/AmbariKerberosAuthenticationFilter.java
>  23fa1715b1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
>  0823729905 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariUserAuthentication.java
>  9445882b62 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariUserAuthorizationFilter.java
>  8fbd81614a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/jwt/JwtAuthentication.java
>  7b21ce667d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/jwt/JwtAuthenticationFilter.java
>  f42df6cb24 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/jwt/JwtAuthenticationProperties.java
>  cb456fa6b4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulator.java
>  32dd6dc4b4 
>   ambari-server/src/main/resources/webapp/WEB-INF/spring-security.xml 
> 6650f67c22 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/SecurityHelperImplTest.java
>  4d6d5a9e73 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authentication/AbstractAuthenticationProviderTest.java
>  96b4883fb2 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authentication/AmbariJWTAuthenticationFilterTest.java
>  14c103223e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authentication/AmbariLocalAuthenticationProviderTest.java
>  d445c07e9a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authentication/jwt/AmbariJwtAuthenticationFilterTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProviderTest.java
>  4e080b1617 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AuthorizationHelperTest.java
>  41816aa5c8 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/jwt/JwtAuthenticationFilterTest.java
>  47df030990 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/jwt/JwtAuthenticationPropertiesTest.java
>  144d90a712 
> 
> 
> Diff: https://reviews.apache.org/r/63044/diff/1/
> 
> 
> 

Re: Review Request 63075: RU: RU failed on "Updating configuration sqoop-atlas-application.properties"

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63075/#review188320
---


Ship it!




Ship It!

- Jonathan Hurley


On Oct. 17, 2017, 10:22 a.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63075/
> ---
> 
> (Updated Oct. 17, 2017, 10:22 a.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-22254
> https://issues.apache.org/jira/browse/AMBARI-22254
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Config types are associated with a service.  As a fallback, use the enclosed 
> config-task's service as the source of the service name.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java
>  5c65911a9e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java
>  d8676bdb58 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java
>  7ad02579e8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java
>  9f4440f055 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java
>  d789ab45d9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/ConfigUpgradeValidityTest.java
>  44f72bd72a 
> 
> 
> Diff: https://reviews.apache.org/r/63075/diff/1/
> 
> 
> Testing
> ---
> 
> Manual.  Unit tests pending.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Review Request 63075: RU: RU failed on "Updating configuration sqoop-atlas-application.properties"

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63075/
---

Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.


Bugs: AMBARI-22254
https://issues.apache.org/jira/browse/AMBARI-22254


Repository: ambari


Description
---

Config types are associated with a service.  As a fallback, use the enclosed 
config-task's service as the source of the service name.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java
 5c65911a9e 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java
 d8676bdb58 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java
 7ad02579e8 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java
 9f4440f055 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java
 d789ab45d9 
  
ambari-server/src/test/java/org/apache/ambari/server/state/stack/ConfigUpgradeValidityTest.java
 44f72bd72a 


Diff: https://reviews.apache.org/r/63075/diff/1/


Testing
---

Manual.  Unit tests pending.


Thanks,

Nate Cole

Re: Review Request 63044: Update JWT Authentication process to work with improved user management facility

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63044/#review188313
---


Ship it!




Ship It!

- Nate Cole


On Oct. 16, 2017, 5:02 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63044/
> ---
> 
> (Updated Oct. 16, 2017, 5:02 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, Myroslav Papirkovskyy, Nate Cole, 
> Robert Nettleton, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21217
> https://issues.apache.org/jira/browse/AMBARI-21217
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update JWT Authentication process to work with improved user management 
> facility
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/AmbariErrorHandler.java
>  a57effcd62 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  62e8b864f5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  0d24ef21e7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationEventHandlerImpl.java
>  4cfce2a373 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationFilter.java
>  b3bc4c31fe 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationProvider.java
>  3d20cb9ec2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariBasicAuthenticationFilter.java
>  3667012ae4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariJWTAuthenticationFilter.java
>  3d35578524 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariLocalAuthenticationProvider.java
>  dcdf4710d4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/UserNotFoundException.java
>  0f2fbb6477 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/jwt/AmbariJwtAuthenticationProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/jwt/JwtAuthenticationToken.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/kerberos/AmbariKerberosAuthenticationFilter.java
>  23fa1715b1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
>  0823729905 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariUserAuthentication.java
>  9445882b62 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariUserAuthorizationFilter.java
>  8fbd81614a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/jwt/JwtAuthentication.java
>  7b21ce667d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/jwt/JwtAuthenticationFilter.java
>  f42df6cb24 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/jwt/JwtAuthenticationProperties.java
>  cb456fa6b4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulator.java
>  32dd6dc4b4 
>   ambari-server/src/main/resources/webapp/WEB-INF/spring-security.xml 
> 6650f67c22 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/SecurityHelperImplTest.java
>  4d6d5a9e73 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authentication/AbstractAuthenticationProviderTest.java
>  96b4883fb2 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authentication/AmbariJWTAuthenticationFilterTest.java
>  14c103223e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authentication/AmbariLocalAuthenticationProviderTest.java
>  d445c07e9a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authentication/jwt/AmbariJwtAuthenticationFilterTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProviderTest.java
>  4e080b1617 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AuthorizationHelperTest.java
>  41816aa5c8 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/jwt/JwtAuthenticationFilterTest.java
>  47df030990 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/jwt/JwtAuthenticationPropertiesTest.java
>  144d90a712 
> 
> 
> Diff: https://reviews.apache.org/r/63044/diff/1/
> 
> 
> Testing
> 

Re: Review Request 62982: Expression parser support for JMXServerSide alerts

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62982/#review188311
---


Ship it!




Ship It!

- Nate Cole


On Oct. 16, 2017, 4:27 a.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62982/
> ---
> 
> (Updated Oct. 16, 2017, 4:27 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-22236
> https://issues.apache.org/jira/browse/AMBARI-22236
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Many of the existing JMX alerts use expressions like this
> 
> "jmx": {
> "property_list": [
>   "Hadoop:service=NameNode,name=FSNamesystemState/CapacityUsed",
>   
> "Hadoop:service=NameNode,name=FSNamesystemState/CapacityRemaining"
> ],
> "value": "{0}/({0} + {1}) * 100.0"
>   }
>   
>   
> JMXServerSide alert should be able to evaluate these expressions in a secure 
> and safe way.
> 
> Supported operators: +,-,*,/,(,)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/alerts/JmxServerSideAlert.java
>  a4b86f8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinition.java
>  665430d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/MetricSource.java
>  d7283fe 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/Reporting.java
>  51d074e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProviderTest.java
>  3ef2c48 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/alert/JmxInfoTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62982/diff/1/
> 
> 
> Testing
> ---
> 
> tested with an JMX alert with value="{0}/({0} + {1}) * 100.0"
> 
> existing tests: passed
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 62930: Non-root ambari user causes Express Upgrade to fail during checking HDFS safe mode phase

[Piyush Chavhan]

> On Oct. 17, 2017, 10:56 a.m., Attila Doroszlai wrote:
> >

Hi Attila,

Thanks for reviewing this issue. I have incorporated the below mentioned two 
review comments.


- Piyush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62930/#review188291
---


On Oct. 17, 2017, 1:50 p.m., Piyush Chavhan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62930/
> ---
> 
> (Updated Oct. 17, 2017, 1:50 p.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-22187
> https://issues.apache.org/jira/browse/AMBARI-22187
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If ambari-server and ambari-agents running using non-root user and tried to 
> upgrade from BigInsights stack 4.1 to 4.2.5. Perform Backups fails due to 
> "get safemode state" fails for NameNode
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/services/HDFS/package/scripts/namenode_upgrade.py
>  5969fcf 
> 
> 
> Diff: https://reviews.apache.org/r/62930/diff/2/
> 
> 
> Testing
> ---
> 
> Tested this change on the running cluster by performing express upgrade from 
> BigInsights 4.1 stack to 4.2.5 with HDFS and Zookeeper services running on 
> the cluster.
> 
> UTs are still running for this.
> 
> 
> Thanks,
> 
> Piyush Chavhan
> 
>

Re: Review Request 62930: Non-root ambari user causes Express Upgrade to fail during checking HDFS safe mode phase

[Piyush Chavhan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62930/
---

(Updated Oct. 17, 2017, 1:50 p.m.)


Review request for Ambari.


Bugs: AMBARI-22187
https://issues.apache.org/jira/browse/AMBARI-22187


Repository: ambari


Description
---

If ambari-server and ambari-agents running using non-root user and tried to 
upgrade from BigInsights stack 4.1 to 4.2.5. Perform Backups fails due to "get 
safemode state" fails for NameNode


Diffs (updated)
-

  
ambari-server/src/main/resources/stacks/BigInsights/4.0/services/HDFS/package/scripts/namenode_upgrade.py
 5969fcf 


Diff: https://reviews.apache.org/r/62930/diff/2/

Changes: https://reviews.apache.org/r/62930/diff/1-2/


Testing
---

Tested this change on the running cluster by performing express upgrade from 
BigInsights 4.1 stack to 4.2.5 with HDFS and Zookeeper services running on the 
cluster.

UTs are still running for this.


Thanks,

Piyush Chavhan

Re: Review Request 62982: Expression parser support for JMXServerSide alerts

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62982/#review188306
---


Ship it!




Ship It!

- Jonathan Hurley


On Oct. 16, 2017, 4:27 a.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62982/
> ---
> 
> (Updated Oct. 16, 2017, 4:27 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-22236
> https://issues.apache.org/jira/browse/AMBARI-22236
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Many of the existing JMX alerts use expressions like this
> 
> "jmx": {
> "property_list": [
>   "Hadoop:service=NameNode,name=FSNamesystemState/CapacityUsed",
>   
> "Hadoop:service=NameNode,name=FSNamesystemState/CapacityRemaining"
> ],
> "value": "{0}/({0} + {1}) * 100.0"
>   }
>   
>   
> JMXServerSide alert should be able to evaluate these expressions in a secure 
> and safe way.
> 
> Supported operators: +,-,*,/,(,)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/alerts/JmxServerSideAlert.java
>  a4b86f8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinition.java
>  665430d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/MetricSource.java
>  d7283fe 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/Reporting.java
>  51d074e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProviderTest.java
>  3ef2c48 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/alert/JmxInfoTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62982/diff/1/
> 
> 
> Testing
> ---
> 
> tested with an JMX alert with value="{0}/({0} + {1}) * 100.0"
> 
> existing tests: passed
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 63034: AMBARI-22244. Update service component API call to work for second service instance

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63034/
---

(Updated Oct. 17, 2017, 1:42 p.m.)


Review request for Ambari, Jayush Luniya, Madhuvanthi Radhakrishnan, and Swapan 
Shridhar.


Bugs: AMBARI-22244
https://issues.apache.org/jira/browse/AMBARI-22244


Repository: ambari


Description
---

Replaced `serviceName` with `serviceType` in `getService` and `getComponent` 
calls where found to be necessary.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
 bb298d5a5ceda4619de958c7a529101c6e4f2e3f 
  
ambari-server/src/main/java/org/apache/ambari/server/alerts/ComponentVersionAlertRunnable.java
 45cc97348e89cdf5bd73a5d4d6139f808bc23180 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
 2bb450bd0ac6a0da064d892e74bbdd05e2475dd6 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ComponentService.java
 60230f6b9fe476deed40ed0f4083ec24bea742f5 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/ComponentsExistInRepoCheck.java
 69492574f8756006c9bd7aab495efb269265cfb7 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java
 5ecce88a84bb8897788fe881f0059fcb553c776f 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java
 0f6eb90803ca6b7a5fb9791294a269aaf4e45fb9 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 e12477eede7176a19b456294602f91d44a35ad61 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 28b5c28e848720191ddcdf142d52c862755eaab0 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
 ca80961ab3634960e8f12cc56b876109afae33ec 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
 ba5a4e78aebb49dbcc24d220c35abfd46fe3dbc0 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java
 f7559c6d3422f4902e28b4f205564bc0ac0aaefa 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java
 ba5fccc1dc1d6ace00ba0f9f36820b055a66ce3b 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java
 252d7726e392307e1a8a0688b8de4e95e4982e8e 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProvider.java
 8c2198bc185da616200bf2701acd4cb8a31f7022 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProvider.java
 0cd55c31a90a17bcd3a8b17783156dc92b2a6a57 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java
 cae330b3466982923deb388ac5323c67fffea02d 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/DatabaseChecker.java
 e3f4e1a005c358ef5a7801691b56c9b91c9aaa11 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/DefaultServiceCalculatedState.java
 603e650894ab27d12cbe2b9c49daf299e5818d5f 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HBaseServiceCalculatedState.java
 765e6fcaaa75086d2bc37e058b6e69e1268be8c2 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HDFSServiceCalculatedState.java
 704b4b96fbe5b54a7c36c22280f27142c0a8cfe9 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HiveServiceCalculatedState.java
 5e23f0b592519746c111dd89afbda37a79c425b7 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/OozieServiceCalculatedState.java
 6c5eab4090a18dce7cea29d8d5038d5ad964fe1c 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/YARNServiceCalculatedState.java
 2fd99e48c34605cd2e28ffdba0c2ea40fe6b49ab 
  
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertMaintenanceModeListener.java
 f73d7c98ef6639fa7feaea4399b39b8b6b70a7e0 
  
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertServiceStateListener.java
 053fb5417ddd09a98a66a1bdf45ca0e569b5ed4e 
  
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListener.java
 4846eb1d68049965615ab4366adf32c5e9b1f4be 
  
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java
 e5298dc629262aca4472c58d7d7abd2e7a63720a 
  ambari-server/src/main/java/org/apache/ambari/server/mpack/MpackManager.java 
0fcc28565d26ee0e9459b8329a0b64fbc4c2bde1 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
 

Review Request 63071: A bunch of services fail to start

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63071/
---

Review request for Ambari, Attila Doroszlai, Myroslav Papirkovskyy, and Sid 
Wagle.


Bugs: AMBARI-22251
https://issues.apache.org/jira/browse/AMBARI-22251


Repository: ambari


Description
---

Test full stack deployment and find services which fail to
install/start/service_check.


Diffs
-

  ambari-agent/src/main/python/ambari_agent/ClusterTopologyCache.py af11cc534e 
  ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
8813243030 
  
ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
 12356ed3b3 
  
ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py
 aed635e329 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/params.py
 e039606ae4 
  
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/package/scripts/params.py
 b01884c6ec 
  
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/package/scripts/status_params.py
 6590478aa3 
  
ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params.py
 afbbb5f38a 
  
ambari-server/src/main/resources/common-services/GANGLIA/3.5.0/package/scripts/params.py
 8cb7a0b6a5 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/params.py
 79bfd62a0e 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
 58b44c424a 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
 3b4ab30382 
  
ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/params_linux.py
 fff1167c18 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 c733ddbfeb 
  
ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/params_linux.py
 c18e422c0a 
  
ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/package/scripts/params.py
 937c4b572d 
  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
 e46ce7831d 
  
ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/package/scripts/params.py
 0f2acca3bb 
  
ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/package/scripts/status_params.py
 8a840fb3c2 
  
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
 16c59ca061 
  
ambari-server/src/main/resources/common-services/KNOX/0.5.0.3.0/package/scripts/params_linux.py
 b12ffefb45 
  
ambari-server/src/main/resources/common-services/KNOX/0.5.0.3.0/package/scripts/params_windows.py
 631146d2e1 
  
ambari-server/src/main/resources/common-services/KNOX/0.5.0.3.0/package/scripts/status_params.py
 699d9a847e 
  
ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/params.py
 64d7c5a8ec 
  
ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/service_check.py
 b090e9885f 
  
ambari-server/src/main/resources/common-services/RANGER/1.0.0.3.0/package/scripts/params.py
 1e968a3d0d 
  
ambari-server/src/main/resources/common-services/RANGER_KMS/1.0.0.3.0/package/scripts/params.py
 156db10f6d 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py
 63cee09b7c 
  
ambari-server/src/main/resources/common-services/SPARK/2.2.0/package/scripts/params.py
 1d36a75c8c 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py
 2d6469cca9 
  
ambari-server/src/main/resources/common-services/STORM/1.0.1.3.0/package/scripts/params_linux.py
 664c582262 
  
ambari-server/src/main/resources/common-services/STORM/1.0.1.3.0/package/scripts/status_params.py
 7d97203e51 
  
ambari-server/src/main/resources/common-services/SUPERSET/0.15.0/package/scripts/params.py
 df0d9fd980 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_windows.py
 a1faf772a3 
  
ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/package/scripts/params_windows.py
 a1faf772a3 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/params.py
 dd370bddde 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/params.py
 dd370bddde 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/params.py
 efd00bfe75 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/params.py
 811cc11d12 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py
 466837c5cd 


Diff: https://reviews.apache.org/r/63071/diff/1/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 62930: Non-root ambari user causes Express Upgrade to fail during checking HDFS safe mode phase

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62930/#review188291
---


Fix it, then Ship it!





ambari-server/src/main/resources/stacks/BigInsights/4.0/services/HDFS/package/scripts/namenode_upgrade.py
Line 174 (original), 174 (patched)


Please use `{safemode_check}` for the first part of the command instead of 
repeating the contents.



ambari-server/src/main/resources/stacks/BigInsights/4.0/services/HDFS/package/scripts/namenode_upgrade.py
Line 175 (original), 175 (patched)


Need to pass `user=user` to the `call` function for the command to be run 
as the HDFS user.


- Attila Doroszlai


On Oct. 12, 2017, 4:22 p.m., Piyush Chavhan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62930/
> ---
> 
> (Updated Oct. 12, 2017, 4:22 p.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-22187
> https://issues.apache.org/jira/browse/AMBARI-22187
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If ambari-server and ambari-agents running using non-root user and tried to 
> upgrade from BigInsights stack 4.1 to 4.2.5. Perform Backups fails due to 
> "get safemode state" fails for NameNode
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/services/HDFS/package/scripts/namenode_upgrade.py
>  5969fcf 
> 
> 
> Diff: https://reviews.apache.org/r/62930/diff/1/
> 
> 
> Testing
> ---
> 
> Tested this change on the running cluster by performing express upgrade from 
> BigInsights 4.1 stack to 4.2.5 with HDFS and Zookeeper services running on 
> the cluster.
> 
> UTs are still running for this.
> 
> 
> Thanks,
> 
> Piyush Chavhan
> 
>

Re: Review Request 63027: Allow wildcard for log directory folder in the path component of Logfeeder input

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63027/#review188284
---


Ship it!




Ship It!

- Miklos Gergely


On Oct. 16, 2017, 1:03 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63027/
> ---
> 
> (Updated Oct. 16, 2017, 1:03 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21145
> https://issues.apache.org/jira/browse/AMBARI-21145
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Allow wildcards for handling log directories. Using ant library for this. (on 
> trunk, the solution will be JDK 8 based, so its a temporal hack for 2.6.1, 
> for trunk some classes have cleaned up, so the implementation there will be 
> different)
> 
> The idea is if we have a folder pattern, we will craete a thread group, and 
> there will be different threads for every matching input (now only for tail 
> file)
> 
> Also there is 2 new thread introduced:
> - one which checks is the monitored file too old, if it is, stop the thread 
> for that (detach)
> - an another one which checks there is any new file available (like log files 
> with date patterns in its name), and if it is, update the monitoring thread 
> with that (log path upgrade)
> 
> Introduced some new configuration as well for inputs:
> - path_update_interval_min: the period in minutes for checking new files 
> (default: 5,  based on detach values, its possible that a new input wont be 
> monitored)
> - detach_interval_min: the period in minutes for checking which files are too 
> old (default: 300)
> - detach_time_min: the period in minutes when we flag a file is too old 
> (default: 2000)
> 
> Also fix an issue which cause that we cannot use grok field names more deeply 
> (use deep_extract param for this one in grok filter) and i updated the docker 
> container as well to make it work with branch-2.6 (and use different version 
> for container in order to keep that)
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-logfeeder/pom.xml 49122e8 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterGrok.java
>  7e2da70 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/Input.java
>  9f54d8a 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputFile.java
>  3737839 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/monitor/AbstractLogFileMonitor.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/monitor/LogFileDetachMonitor.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/monitor/LogFilePathUpdateMonitor.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogConfigHandler.java
>  0ece637 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/FileUtil.java
>  ffd6cec 
>   ambari-logsearch/docker/Dockerfile dfa1462 
>   ambari-logsearch/docker/logsearch-docker.sh a2df90f 
> 
> 
> Diff: https://reviews.apache.org/r/63027/diff/1/
> 
> 
> Testing
> ---
> 
> done, no UTs here, FTs are in progress
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 63027: Allow wildcard for log directory folder in the path component of Logfeeder input

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63027/#review188283
---




ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/Input.java
Lines 85 (patched)


This variable is not used for anything, so let's get rid of it, and also 
the function that calculates it in FileUtils



ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/Input.java
Lines 396 (patched)


No need to expose threadGroup



ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/Input.java
Lines 437 (patched)


No need to expose multiFolder, and the class may access the variable 
directly

Also no need to expose logFileDetacherThread, and logFilePathUpdaterThread



ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputFile.java
Lines 37 (patched)


This should go to init(), it doesn't have to be done over and over again 
till the input is ready



ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/monitor/AbstractLogFileMonitor.java
Lines 31 (patched)


inputFile and deteachTime could be protected, thus no getter is needed for 
the extending classes to access them



ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/monitor/AbstractLogFileMonitor.java
Lines 45 (patched)


waitInterval should not be exposed at all



ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/FileUtil.java
Lines 98 (patched)


This is a utility class performing a general operation, do not link it's 
name to it's purpose, so let's call this something like getFilesByPathPattern



ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/FileUtil.java
Lines 105 (patched)


There is a potential hazard, that the folderBeforeRegex repeated after the 
first *, for example: /var/log/*/var/log/...
not likely, but for sure instead of replacing the folderBeforeRegex use 
substring()


- Miklos Gergely


On Oct. 16, 2017, 1:03 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63027/
> ---
> 
> (Updated Oct. 16, 2017, 1:03 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21145
> https://issues.apache.org/jira/browse/AMBARI-21145
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Allow wildcards for handling log directories. Using ant library for this. (on 
> trunk, the solution will be JDK 8 based, so its a temporal hack for 2.6.1, 
> for trunk some classes have cleaned up, so the implementation there will be 
> different)
> 
> The idea is if we have a folder pattern, we will craete a thread group, and 
> there will be different threads for every matching input (now only for tail 
> file)
> 
> Also there is 2 new thread introduced:
> - one which checks is the monitored file too old, if it is, stop the thread 
> for that (detach)
> - an another one which checks there is any new file available (like log files 
> with date patterns in its name), and if it is, update the monitoring thread 
> with that (log path upgrade)
> 
> Introduced some new configuration as well for inputs:
> - path_update_interval_min: the period in minutes for checking new files 
> (default: 5,  based on detach values, its possible that a new input wont be 
> monitored)
> - detach_interval_min: the period in minutes for checking which files are too 
> old (default: 300)
> - detach_time_min: the period in minutes when we flag a file is too old 
> (default: 2000)
> 
> Also fix an issue which cause that we cannot use grok field names more deeply 
> (use deep_extract param for this one in grok filter) and i updated the docker 
> container as well to make it work with branch-2.6 (and use different version 
> for container in order to keep that)
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-logfeeder/pom.xml 49122e8 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterGrok.java
>  7e2da70 
>   
>