Re: Review Request 64971: AMBARI-22252. Revert Blueprint V2 changes

2018-01-08 Thread Robert Nettleton 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64971/#review194982
---


Ship it!




Ship It!

- Robert Nettleton


On Jan. 8, 2018, 8:59 a.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64971/
> ---
> 
> (Updated Jan. 8, 2018, 8:59 a.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Dmytro Sen, Jayush Luniya, 
> Madhuvanthi Radhakrishnan, Robert Nettleton, and Vitalyi Brodetskyi.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> A few changes for Blueprint V2 work were initially commited on 
> `branch-feature-AMBARI-14714` before the "private" feature branch 
> `branch-feature-AMBARI-14714-blueprintv2` was forked.  This change mostly 
> reverts those commits.
> 
> It also fixes `ServiceComponentRequest` usage in `AmbariContext` (wrong 
> constructor was used), and expectations for `createServices` and 
> `createComponents` in `AmbariContextTest` (they are no longer `void` methods).
> 
> The only functional change compared to `trunk` blueprint code is that it 
> creates a default service group when provisioning the cluster.  This is 
> allows successful deployment using "old" blueprints.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/query/render/ClusterBlueprintRenderer.java
>  7171fc79c2d6997c1aa3669a96704e3f35592fa8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceService.java
>  76782d5988364654a5326b5975b1449d7ddea854 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorBlueprintProcessor.java
>  9bbdc37a62cc82e22e3ecb14d016571c63f8943f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/users/ActiveWidgetLayoutService.java
>  2667a0c5d283d2cb2b2e361de833db43d98e144c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/views/ViewInstanceService.java
>  036f1bdb17495dd98ad84c9fed4c2e95d88b4a81 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  c88b23c8af374dd9bd695b70560079871f3366fd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupRequest.java
>  53c3d1e77144458566b49b98d9a8c51381f6ff29 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackV2.java 
> 0b0329c31bb5800eb32ba4b437bd57a41a618dbe 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackV2Factory.java
>  784b3683ba9d3909bb9e6d900e4175b6a00aec9a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
>  5104354fce7701fe023723c19d56d25e7adf5219 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BaseClusterRequest.java
>  a38f478ed05ec88816e6363b31aa102a4a9d353f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  d2f24d9445ea5a33aaf1d286ff40bfc91787c277 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintV2ResourceProvider.java
>  6d2c4f06f5c75fbdf9e81c2d711440862f375bb9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java
>  cc0cea377233931bf65943f792f6a7e11b074f06 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigurationContext.java
>  aa63021b8a5a4e386652b936ceaefe6c2298797e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExportBlueprintRequest.java
>  565369b08b6eeb1a598575e448ce0c6334b6234b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequest.java
>  f773fc8aac61f74988dd63a7a8b2cc30053023d2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ScaleClusterRequest.java
>  1284c265c150aa03c00b43b364c2163ca4e564a5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UnitUpdater.java
>  3a70f8124be3034f29edd51a96e00b8e25dfd661 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/BlueprintV2DAO.java
>  6a054e8c9038acb63579065e6093193a3735eb90 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/BlueprintEntity.java
>  8141f070bb40872fea9fae12e72adcf778ba8225 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/BlueprintV2Entity.java
>  de9bde42b50bdcb073ae6e1b19a835788b00f049 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostGroupComponentEntity.java
>  bd34d29ed89d28df37359522c72749395695b3cf 
>   
>

Re: Review Request 64769: AMBARI-22406 : UI for verifying if repo exist for new OS family and user prompt for entering HDP and HDP-UTILs repo URLs

2018-01-08 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64769/#review194955
---



This has been pushed.  Please close this review and associated jira.

- Nate Cole


On Jan. 8, 2018, 8:05 a.m., Sonia Garudi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64769/
> ---
> 
> (Updated Jan. 8, 2018, 8:05 a.m.)
> 
> 
> Review request for Ambari and Nate Cole.
> 
> 
> Bugs: AMBARI-22406
> https://issues.apache.org/jira/browse/AMBARI-22406
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Includes UI changes in ambari-web to check if the repo is selected or 
> provides prompt to the user to enter the HDP and HDP-utils repo URL's. 
> Includes necessary validation checks for the repo urls, allows user to select 
> the public and local repository and also provides functionality to skip 
> validation checks.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard/step3_controller.js 55f4323 
>   ambari-web/app/messages.js 6da0368 
>   ambari-web/app/styles/wizard.less 4e680ca 
>   ambari-web/app/templates/wizard/step3.hbs ff436a8 
>   ambari-web/app/utils/ajax/ajax.js 483be5e 
>   ambari-web/app/views/wizard/step3/hostWarningPopupBody_view.js 786c4f7 
>   ambari-web/app/views/wizard/step3_view.js 3249b24 
>   ambari-web/test/controllers/wizard/step3_test.js b8bc794 
> 
> 
> Diff: https://reviews.apache.org/r/64769/diff/5/
> 
> 
> Testing
> ---
> 
> Tests were successful in ambari-web
> 
> 
> Thanks,
> 
> Sonia Garudi
> 
>

Re: Review Request 64769: AMBARI-22406 : UI for verifying if repo exist for new OS family and user prompt for entering HDP and HDP-UTILs repo URLs

2018-01-08 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64769/#review194954
---


Ship it!




Ship It!

- Nate Cole


On Jan. 8, 2018, 8:05 a.m., Sonia Garudi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64769/
> ---
> 
> (Updated Jan. 8, 2018, 8:05 a.m.)
> 
> 
> Review request for Ambari and Nate Cole.
> 
> 
> Bugs: AMBARI-22406
> https://issues.apache.org/jira/browse/AMBARI-22406
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Includes UI changes in ambari-web to check if the repo is selected or 
> provides prompt to the user to enter the HDP and HDP-utils repo URL's. 
> Includes necessary validation checks for the repo urls, allows user to select 
> the public and local repository and also provides functionality to skip 
> validation checks.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard/step3_controller.js 55f4323 
>   ambari-web/app/messages.js 6da0368 
>   ambari-web/app/styles/wizard.less 4e680ca 
>   ambari-web/app/templates/wizard/step3.hbs ff436a8 
>   ambari-web/app/utils/ajax/ajax.js 483be5e 
>   ambari-web/app/views/wizard/step3/hostWarningPopupBody_view.js 786c4f7 
>   ambari-web/app/views/wizard/step3_view.js 3249b24 
>   ambari-web/test/controllers/wizard/step3_test.js b8bc794 
> 
> 
> Diff: https://reviews.apache.org/r/64769/diff/5/
> 
> 
> Testing
> ---
> 
> Tests were successful in ambari-web
> 
> 
> Thanks,
> 
> Sonia Garudi
> 
>

Re: Review Request 64769: AMBARI-22406 : UI for verifying if repo exist for new OS family and user prompt for entering HDP and HDP-UTILs repo URLs

2018-01-08 Thread Sonia Garudi 


> On Dec. 22, 2017, 2:51 p.m., Nate Cole wrote:
> > ambari-web/app/controllers/wizard/step3_controller.js
> > Lines 863-880 (patched)
> > 
> >
> > I'm no UI expert, but this entire new block seems to be doing repo 
> > stuff that already is on the UI.  Can you explain the gist here?
> 
> Sonia Garudi wrote:
> We need each host's os type which is not available on the UI. This 
> function makes an API call which gets information of all the bootstrapped 
> hosts .
> 
> Nate Cole wrote:
> I see.  We should probably have that returned as part of host 
> registration and read it from there instead of making another call.  Is that 
> possible in this patch?
> 
> Sonia Garudi wrote:
> The os types of the bootstrapped hosts can be obtained in the 
> registration success callback(isHostsRegisteredSuccessCallback) which would 
> eliminate the above API call. This would involve editing the 
> 'wizard.step3.is_hosts_registered' API call in ajax.js to include the 
> 'Hosts/os_type' field.
> Please let me know your suggestions.
> 
> Nate Cole wrote:
> That sounds reasonable instead of making another call.  Can we make that 
> an error/failure case after registration that we don't have a JAVA_HOME 
> matching the type?
> 
> Yussuf Shaikh wrote:
> Do you want us to fail the Host Registration if java home is not found 
> for host os_type?
> We were planning to just show a message on the host check warnings popup 
> that Host does not have proper Java Home set of its Os type and default java 
> home will be used. This assumption is because during normal(existing) flow 
> Amabari show warning for incorrect Java Home and does not fail registration.
> 
> Nate Cole wrote:
> No need to fail host registration.  The popup informational is fine.

Eliminated the API call by editing registration API to get the os_family. Also 
made changes to display java home host check warnings.


> On Dec. 22, 2017, 2:51 p.m., Nate Cole wrote:
> > ambari-web/app/controllers/wizard/step3_controller.js
> > Lines 968-972 (patched)
> > 
> >
> > Should not rely on the name for the id.  The API should be giving you 
> > the id.
> 
> Sonia Garudi wrote:
> Made the required change in next diff.
> 
> Nate Cole wrote:
> Ok, please resolve review issues as they are fixed in diffs with "Fixed"
> 
> Sonia Garudi wrote:
> I made the change to get the stackId based on repositoryVersion instead 
> of displayName. However, the repositoryVersion is set to '2.6.2.0' 
> irrespective of the actual version of HDP installed(not sure if its a bug). I 
> was unable to retrieve the proper installed version of HDP on the UI using 
> any API call. Please let me know your suggestions.
> 
> Sonia Garudi wrote:
> In the latest diff, I have reverted to the previous change(i.e. use of 
> displayName instead of repositoryVersion to get the version_definition_id).

Do you have any suggestions for getting the proper installed version of HDP? Or 
should we continue using the displayName?
If possible could you merge this patch, as we can include these changes in the 
further patches.


- Sonia


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64769/#review194434
---


On Jan. 8, 2018, 1:05 p.m., Sonia Garudi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64769/
> ---
> 
> (Updated Jan. 8, 2018, 1:05 p.m.)
> 
> 
> Review request for Ambari and Nate Cole.
> 
> 
> Bugs: AMBARI-22406
> https://issues.apache.org/jira/browse/AMBARI-22406
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Includes UI changes in ambari-web to check if the repo is selected or 
> provides prompt to the user to enter the HDP and HDP-utils repo URL's. 
> Includes necessary validation checks for the repo urls, allows user to select 
> the public and local repository and also provides functionality to skip 
> validation checks.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard/step3_controller.js 55f4323 
>   ambari-web/app/messages.js 6da0368 
>   ambari-web/app/styles/wizard.less 4e680ca 
>   ambari-web/app/templates/wizard/step3.hbs ff436a8 
>   ambari-web/app/utils/ajax/ajax.js 483be5e 
>   ambari-web/app/views/wizard/step3/hostWarningPopupBody_view.js 786c4f7 
>   ambari-web/app/views/wizard/step3_view.js 3249b24 
>   ambari-web/test/controllers/wizard/step3_test.js b8bc794 
> 
> 
> Diff: https://reviews.apache.org/r/64769/diff/5/
> 
> 
> Testing
> ---
> 
> Tests were successful in ambari-web
> 
> 
> Thanks,
> 
> Sonia Garudi
> 
>

Re: Review Request 64769: AMBARI-22406 : UI for verifying if repo exist for new OS family and user prompt for entering HDP and HDP-UTILs repo URLs

2018-01-08 Thread Sonia Garudi 


> On Dec. 22, 2017, 2:51 p.m., Nate Cole wrote:
> > ambari-web/app/controllers/wizard/step3_controller.js
> > Lines 968-972 (patched)
> > 
> >
> > Should not rely on the name for the id.  The API should be giving you 
> > the id.
> 
> Sonia Garudi wrote:
> Made the required change in next diff.
> 
> Nate Cole wrote:
> Ok, please resolve review issues as they are fixed in diffs with "Fixed"
> 
> Sonia Garudi wrote:
> I made the change to get the stackId based on repositoryVersion instead 
> of displayName. However, the repositoryVersion is set to '2.6.2.0' 
> irrespective of the actual version of HDP installed(not sure if its a bug). I 
> was unable to retrieve the proper installed version of HDP on the UI using 
> any API call. Please let me know your suggestions.

In the latest diff, I have reverted to the previous change(i.e. use of 
displayName instead of repositoryVersion to get the version_definition_id).


- Sonia


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64769/#review194434
---


On Jan. 8, 2018, 1:05 p.m., Sonia Garudi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64769/
> ---
> 
> (Updated Jan. 8, 2018, 1:05 p.m.)
> 
> 
> Review request for Ambari and Nate Cole.
> 
> 
> Bugs: AMBARI-22406
> https://issues.apache.org/jira/browse/AMBARI-22406
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Includes UI changes in ambari-web to check if the repo is selected or 
> provides prompt to the user to enter the HDP and HDP-utils repo URL's. 
> Includes necessary validation checks for the repo urls, allows user to select 
> the public and local repository and also provides functionality to skip 
> validation checks.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard/step3_controller.js 55f4323 
>   ambari-web/app/messages.js 6da0368 
>   ambari-web/app/styles/wizard.less 4e680ca 
>   ambari-web/app/templates/wizard/step3.hbs ff436a8 
>   ambari-web/app/utils/ajax/ajax.js 483be5e 
>   ambari-web/app/views/wizard/step3/hostWarningPopupBody_view.js 786c4f7 
>   ambari-web/app/views/wizard/step3_view.js 3249b24 
>   ambari-web/test/controllers/wizard/step3_test.js b8bc794 
> 
> 
> Diff: https://reviews.apache.org/r/64769/diff/5/
> 
> 
> Testing
> ---
> 
> Tests were successful in ambari-web
> 
> 
> Thanks,
> 
> Sonia Garudi
> 
>

Re: Review Request 64769: AMBARI-22406 : UI for verifying if repo exist for new OS family and user prompt for entering HDP and HDP-UTILs repo URLs

2018-01-08 Thread Sonia Garudi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64769/
---

(Updated Jan. 8, 2018, 1:05 p.m.)


Review request for Ambari and Nate Cole.


Changes
---

Made changes for using os_family instead of os_type. Also made changes for 
JAVA_HOME host check warnings.


Bugs: AMBARI-22406
https://issues.apache.org/jira/browse/AMBARI-22406


Repository: ambari


Description
---

Includes UI changes in ambari-web to check if the repo is selected or provides 
prompt to the user to enter the HDP and HDP-utils repo URL's. Includes 
necessary validation checks for the repo urls, allows user to select the public 
and local repository and also provides functionality to skip validation checks.


Diffs (updated)
-

  ambari-web/app/controllers/wizard/step3_controller.js 55f4323 
  ambari-web/app/messages.js 6da0368 
  ambari-web/app/styles/wizard.less 4e680ca 
  ambari-web/app/templates/wizard/step3.hbs ff436a8 
  ambari-web/app/utils/ajax/ajax.js 483be5e 
  ambari-web/app/views/wizard/step3/hostWarningPopupBody_view.js 786c4f7 
  ambari-web/app/views/wizard/step3_view.js 3249b24 
  ambari-web/test/controllers/wizard/step3_test.js b8bc794 


Diff: https://reviews.apache.org/r/64769/diff/5/

Changes: https://reviews.apache.org/r/64769/diff/4-5/


Testing
---

Tests were successful in ambari-web


Thanks,

Sonia Garudi

Re: Review Request 64971: AMBARI-22252. Revert Blueprint V2 changes

2018-01-08 Thread Attila Doroszlai 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64971/
---

(Updated Jan. 8, 2018, 9:59 a.m.)


Review request for Ambari, Balázs Bence Sári, Dmytro Sen, Jayush Luniya, 
Madhuvanthi Radhakrishnan, Robert Nettleton, and Vitalyi Brodetskyi.


Changes
---

restore static import in StackConfigTypeValidatorTest


Repository: ambari


Description
---

A few changes for Blueprint V2 work were initially commited on 
`branch-feature-AMBARI-14714` before the "private" feature branch 
`branch-feature-AMBARI-14714-blueprintv2` was forked.  This change mostly 
reverts those commits.

It also fixes `ServiceComponentRequest` usage in `AmbariContext` (wrong 
constructor was used), and expectations for `createServices` and 
`createComponents` in `AmbariContextTest` (they are no longer `void` methods).

The only functional change compared to `trunk` blueprint code is that it 
creates a default service group when provisioning the cluster.  This is allows 
successful deployment using "old" blueprints.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/api/query/render/ClusterBlueprintRenderer.java
 7171fc79c2d6997c1aa3669a96704e3f35592fa8 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceService.java
 76782d5988364654a5326b5975b1449d7ddea854 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorBlueprintProcessor.java
 9bbdc37a62cc82e22e3ecb14d016571c63f8943f 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/users/ActiveWidgetLayoutService.java
 2667a0c5d283d2cb2b2e361de833db43d98e144c 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/views/ViewInstanceService.java
 036f1bdb17495dd98ad84c9fed4c2e95d88b4a81 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 c88b23c8af374dd9bd695b70560079871f3366fd 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupRequest.java
 53c3d1e77144458566b49b98d9a8c51381f6ff29 
  ambari-server/src/main/java/org/apache/ambari/server/controller/StackV2.java 
0b0329c31bb5800eb32ba4b437bd57a41a618dbe 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/StackV2Factory.java
 784b3683ba9d3909bb9e6d900e4175b6a00aec9a 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
 5104354fce7701fe023723c19d56d25e7adf5219 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BaseClusterRequest.java
 a38f478ed05ec88816e6363b31aa102a4a9d353f 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
 d2f24d9445ea5a33aaf1d286ff40bfc91787c277 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintV2ResourceProvider.java
 6d2c4f06f5c75fbdf9e81c2d711440862f375bb9 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java
 cc0cea377233931bf65943f792f6a7e11b074f06 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigurationContext.java
 aa63021b8a5a4e386652b936ceaefe6c2298797e 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExportBlueprintRequest.java
 565369b08b6eeb1a598575e448ce0c6334b6234b 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequest.java
 f773fc8aac61f74988dd63a7a8b2cc30053023d2 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ScaleClusterRequest.java
 1284c265c150aa03c00b43b364c2163ca4e564a5 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UnitUpdater.java
 3a70f8124be3034f29edd51a96e00b8e25dfd661 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/BlueprintV2DAO.java
 6a054e8c9038acb63579065e6093193a3735eb90 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/BlueprintEntity.java
 8141f070bb40872fea9fae12e72adcf778ba8225 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/BlueprintV2Entity.java
 de9bde42b50bdcb073ae6e1b19a835788b00f049 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostGroupComponentEntity.java
 bd34d29ed89d28df37359522c72749395695b3cf 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostGroupComponentEntityPK.java
 812f0d68c867bd9366c7c3dd62cf789389af0f45 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StackEntity.java
 e8047973f9915e62f5a448476064fddec96be630 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyConfigurationsEntity.java
 a29db99e48ee9bd667c9b150fe490a95dd5bd4bb 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyRequestEntity.java

Re: Review Request 64971: AMBARI-22252. Revert Blueprint V2 changes

2018-01-08 Thread Balázs Bence Sári 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64971/#review194938
---




ambari-server/src/test/java/org/apache/ambari/server/topology/validators/StackConfigTypeValidatorTest.java
Line 74 (original), 67 (patched)


Why was static import of EasyMock removed? It improved clarity IMO.


- Balázs Bence Sári


On Jan. 5, 2018, 9:33 a.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64971/
> ---
> 
> (Updated Jan. 5, 2018, 9:33 a.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Dmytro Sen, Jayush Luniya, 
> Madhuvanthi Radhakrishnan, Robert Nettleton, and Vitalyi Brodetskyi.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> A few changes for Blueprint V2 work were initially commited on 
> `branch-feature-AMBARI-14714` before the "private" feature branch 
> `branch-feature-AMBARI-14714-blueprintv2` was forked.  This change mostly 
> reverts those commits.
> 
> It also fixes `ServiceComponentRequest` usage in `AmbariContext` (wrong 
> constructor was used), and expectations for `createServices` and 
> `createComponents` in `AmbariContextTest` (they are no longer `void` methods).
> 
> The only functional change compared to `trunk` blueprint code is that it 
> creates a default service group when provisioning the cluster.  This is 
> allows successful deployment using "old" blueprints.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/query/render/ClusterBlueprintRenderer.java
>  7171fc79c2d6997c1aa3669a96704e3f35592fa8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceService.java
>  76782d5988364654a5326b5975b1449d7ddea854 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorBlueprintProcessor.java
>  9bbdc37a62cc82e22e3ecb14d016571c63f8943f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/users/ActiveWidgetLayoutService.java
>  2667a0c5d283d2cb2b2e361de833db43d98e144c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/views/ViewInstanceService.java
>  036f1bdb17495dd98ad84c9fed4c2e95d88b4a81 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  c88b23c8af374dd9bd695b70560079871f3366fd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupRequest.java
>  53c3d1e77144458566b49b98d9a8c51381f6ff29 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackV2.java 
> 0b0329c31bb5800eb32ba4b437bd57a41a618dbe 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackV2Factory.java
>  784b3683ba9d3909bb9e6d900e4175b6a00aec9a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
>  5104354fce7701fe023723c19d56d25e7adf5219 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BaseClusterRequest.java
>  a38f478ed05ec88816e6363b31aa102a4a9d353f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  d2f24d9445ea5a33aaf1d286ff40bfc91787c277 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintV2ResourceProvider.java
>  6d2c4f06f5c75fbdf9e81c2d711440862f375bb9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java
>  cc0cea377233931bf65943f792f6a7e11b074f06 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigurationContext.java
>  aa63021b8a5a4e386652b936ceaefe6c2298797e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExportBlueprintRequest.java
>  565369b08b6eeb1a598575e448ce0c6334b6234b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequest.java
>  f773fc8aac61f74988dd63a7a8b2cc30053023d2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ScaleClusterRequest.java
>  1284c265c150aa03c00b43b364c2163ca4e564a5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UnitUpdater.java
>  3a70f8124be3034f29edd51a96e00b8e25dfd661 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/BlueprintV2DAO.java
>  6a054e8c9038acb63579065e6093193a3735eb90 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/BlueprintEntity.java
>  8141f070bb40872fea9fae12e72adcf778ba8225 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/BlueprintV2Entity.java
>

Re: Review Request 64971: AMBARI-22252. Revert Blueprint V2 changes

2018-01-08 Thread Balázs Bence Sári 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64971/#review194939
---


Ship it!




Ship It!

- Balázs Bence Sári


On Jan. 5, 2018, 9:33 a.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64971/
> ---
> 
> (Updated Jan. 5, 2018, 9:33 a.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Dmytro Sen, Jayush Luniya, 
> Madhuvanthi Radhakrishnan, Robert Nettleton, and Vitalyi Brodetskyi.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> A few changes for Blueprint V2 work were initially commited on 
> `branch-feature-AMBARI-14714` before the "private" feature branch 
> `branch-feature-AMBARI-14714-blueprintv2` was forked.  This change mostly 
> reverts those commits.
> 
> It also fixes `ServiceComponentRequest` usage in `AmbariContext` (wrong 
> constructor was used), and expectations for `createServices` and 
> `createComponents` in `AmbariContextTest` (they are no longer `void` methods).
> 
> The only functional change compared to `trunk` blueprint code is that it 
> creates a default service group when provisioning the cluster.  This is 
> allows successful deployment using "old" blueprints.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/query/render/ClusterBlueprintRenderer.java
>  7171fc79c2d6997c1aa3669a96704e3f35592fa8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceService.java
>  76782d5988364654a5326b5975b1449d7ddea854 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorBlueprintProcessor.java
>  9bbdc37a62cc82e22e3ecb14d016571c63f8943f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/users/ActiveWidgetLayoutService.java
>  2667a0c5d283d2cb2b2e361de833db43d98e144c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/views/ViewInstanceService.java
>  036f1bdb17495dd98ad84c9fed4c2e95d88b4a81 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  c88b23c8af374dd9bd695b70560079871f3366fd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupRequest.java
>  53c3d1e77144458566b49b98d9a8c51381f6ff29 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackV2.java 
> 0b0329c31bb5800eb32ba4b437bd57a41a618dbe 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackV2Factory.java
>  784b3683ba9d3909bb9e6d900e4175b6a00aec9a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
>  5104354fce7701fe023723c19d56d25e7adf5219 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BaseClusterRequest.java
>  a38f478ed05ec88816e6363b31aa102a4a9d353f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  d2f24d9445ea5a33aaf1d286ff40bfc91787c277 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintV2ResourceProvider.java
>  6d2c4f06f5c75fbdf9e81c2d711440862f375bb9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java
>  cc0cea377233931bf65943f792f6a7e11b074f06 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigurationContext.java
>  aa63021b8a5a4e386652b936ceaefe6c2298797e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExportBlueprintRequest.java
>  565369b08b6eeb1a598575e448ce0c6334b6234b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequest.java
>  f773fc8aac61f74988dd63a7a8b2cc30053023d2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ScaleClusterRequest.java
>  1284c265c150aa03c00b43b364c2163ca4e564a5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UnitUpdater.java
>  3a70f8124be3034f29edd51a96e00b8e25dfd661 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/BlueprintV2DAO.java
>  6a054e8c9038acb63579065e6093193a3735eb90 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/BlueprintEntity.java
>  8141f070bb40872fea9fae12e72adcf778ba8225 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/BlueprintV2Entity.java
>  de9bde42b50bdcb073ae6e1b19a835788b00f049 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostGroupComponentEntity.java
>  bd34d29ed89d28df37359522c72749395695b3cf 
>   
>