Re: Review Request 64155: Update the version of Ember and jQuery for Hive View
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64155/#review192136 --- Ship it! Ship It! - DIPAYAN BHOWMICK On Nov. 29, 2017, 12:40 p.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64155/ > --- > > (Updated Nov. 29, 2017, 12:40 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Nitiraj > Rathore. > > > Bugs: AMBARI-22542 > https://issues.apache.org/jira/browse/AMBARI-22542 > > > Repository: ambari > > > Description > --- > > Changed the ember and jquery versions. > > > Diffs > - > > contrib/views/files/src/main/resources/ui/bower.json f1472ee > contrib/views/hive-next/src/main/resources/ui/hive-web/bower.json 62861b2 > > > Diff: https://reviews.apache.org/r/64155/diff/1/ > > > Testing > --- > > manually tested > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 64111: AMBARI-22527: Error while viewing topology details - Storm View
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64111/#review192001 --- Ship it! Ship It! - DIPAYAN BHOWMICK On Nov. 28, 2017, 8:30 a.m., Sanket Shah wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64111/ > --- > > (Updated Nov. 28, 2017, 8:30 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Sumit Mohanty, Sriharsha > Chintalapani, and Yusaku Sako. > > > Bugs: AMBARI-22527 > https://issues.apache.org/jira/browse/AMBARI-22527 > > > Repository: ambari > > > Description > --- > > On the latest build, due to few npm packages being updated dynamically, Storm > view is running into below mentioned error: > > ``` > Uncaught Error: Minified React error #130; visit > http://facebook.github.io/react/docs/error-decoder.html?invariant=130&args[]=object&args[]=%20Check%20the%20render%20method%20of%20%60e%60. > for the full message or use the non-minified dev environment for full errors > and additional helpful warnings. > at n (vendor.bundle.js:4) > at a (vendor.bundle.js:6) > at Object.updateChildren (vendor.bundle.js:2) > at v._reconcilerUpdateChildren (vendor.bundle.js:3) > at v._updateChildren (vendor.bundle.js:3) > at v.updateChildren (vendor.bundle.js:3) > at v._updateDOMChildren (vendor.bundle.js:2) > at v.updateComponent (vendor.bundle.js:2) > at v.receiveComponent (vendor.bundle.js:2) > at Object.receiveComponent (vendor.bundle.js:2) > ``` > > > Diffs > - > > > contrib/views/storm/src/main/resources/ui/app/scripts/containers/ComponentDetailView.jsx > 2b3ed69 > contrib/views/storm/src/main/resources/ui/package.json f9e029b > > > Diff: https://reviews.apache.org/r/64111/diff/1/ > > > Testing > --- > > Manually ran the mvn clean install and created storm view jar. > Successfully deployed the jar and verified working of storm view. > Clicked on a topology and verified the working of the page since that was the > one throwing above error. > > > Thanks, > > Sanket Shah > >
Re: Review Request 62885: Hive View 2.0 in Ambari 2.5.1 does not use the specified YARN queue when using the "Upload Table" feature.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62885/#review187653 --- Ship it! Ship It! - DIPAYAN BHOWMICK On Oct. 11, 2017, 10:44 a.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62885/ > --- > > (Updated Oct. 11, 2017, 10:44 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and venkat > sairam. > > > Bugs: AMBARI-22202 > https://issues.apache.org/jira/browse/AMBARI-22202 > > > Repository: ambari > > > Description > --- > > added global settings in all the system generated queries > > > Diffs > - > > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/browser/DDLProxy.java > 77857f9628 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/UploadService.java > 3164da09e1 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/query/InsertFromQueryInput.java > b74ba9b0c1 > > contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/upload-table.js > f47d820cbf > > > Diff: https://reviews.apache.org/r/62885/diff/1/ > > > Testing > --- > > manual testing done. > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 62883: Zeppelin start fails due to permission denied error during kinit
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62883/#review187638 --- Ship it! Ship It! - DIPAYAN BHOWMICK On Oct. 11, 2017, 8:56 a.m., Prabhjyot Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62883/ > --- > > (Updated Oct. 11, 2017, 8:56 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, > Rohit Choudhary, Sumit Mohanty, and venkat sairam. > > > Bugs: AMBARI-22199 > https://issues.apache.org/jira/browse/AMBARI-22199 > > > Repository: ambari > > > Description > --- > > Zeppelin fails to come up with following error in ambari stderr logs, on > kerberos enabled enviornment. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py > d615d06d5a > ambari-server/src/test/python/stacks/2.6/ZEPPELIN/test_zeppelin_070.py > 3064880632 > > > Diff: https://reviews.apache.org/r/62883/diff/2/ > > > Testing > --- > > Tested manually > > > Thanks, > > Prabhjyot Singh > >
Re: Review Request 61910: Hive query failing randomly with Null point exception status 500
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61910/#review186225 --- Ship it! Ship It! - DIPAYAN BHOWMICK On Aug. 25, 2017, 7:16 a.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61910/ > --- > > (Updated Aug. 25, 2017, 7:16 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Pallav > Kulshreshtha. > > > Bugs: AMBARI-21799 > https://issues.apache.org/jira/browse/AMBARI-21799 > > > Repository: ambari > > > Description > --- > > Null Pointer Exception is coming while getting message of original exception. > Added a null check. > > > Diffs > - > > > contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/HdfsApi.java > 90fa483ef7 > > > Diff: https://reviews.apache.org/r/61910/diff/1/ > > > Testing > --- > > manual testing done. > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 62119: Ambari Files View - browser going to hung state while opening a HDFS folder which has huge number of files(>10000)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62119/#review184809 --- Ship it! Ship It! - DIPAYAN BHOWMICK On Sept. 7, 2017, 11:12 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62119/ > --- > > (Updated Sept. 7, 2017, 11:12 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > Padma Priya N, Pallav Kulshreshtha, and Prabhjyot Singh. > > > Bugs: AMBARI-21890 > https://issues.apache.org/jira/browse/AMBARI-21890 > > > Repository: ambari > > > Description > --- > > A configurable limit have been imposed on the no of files being retrieved > from the server and the limit by default is set to 5000. > Search has been provided to find the file faster. > > > Diffs > - > > > contrib/views/commons/src/main/java/org/apache/ambari/view/commons/hdfs/FileOperationService.java > d6e484d > contrib/views/files/src/main/resources/ui/app/components/file-search.js > b65749c > contrib/views/files/src/main/resources/ui/app/controllers/files.js 8b5bb7b > contrib/views/files/src/main/resources/ui/app/routes/files.js 140732f > > contrib/views/files/src/main/resources/ui/app/templates/components/file-row.hbs > 72ed840 > > contrib/views/files/src/main/resources/ui/app/templates/components/file-search.hbs > 298d672 > contrib/views/files/src/main/resources/ui/app/templates/files.hbs 63e0dd8 > > contrib/views/files/src/test/java/org/apache/ambari/view/filebrowser/FilebrowserTest.java > f431f66 > > contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/DirListInfo.java > PRE-CREATION > > contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/DirStatus.java > PRE-CREATION > > contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/HdfsApi.java > 90fa483 > > contrib/views/utils/src/test/java/org/apache/ambari/view/utils/hdfs/HdfsApiTest.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/62119/diff/5/ > > > Testing > --- > > Manual testing done. > > > Thanks, > > venkat sairam > >
Re: Review Request 62119: Ambari Files View - browser going to hung state while opening a HDFS folder which has huge number of files(>10000)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62119/#review184790 --- contrib/views/files/src/main/resources/ui/app/controllers/files.js Line 81 (original), 74 (patched) <https://reviews.apache.org/r/62119/#comment260989> I guess you donot need to have a computed property on validSearchText and sortedContent. contrib/views/files/src/main/resources/ui/app/routes/files.js Line 46 (original), 46 (patched) <https://reviews.apache.org/r/62119/#comment260990> Please use a query parameter and reload the route. - DIPAYAN BHOWMICK On Sept. 7, 2017, 6:36 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62119/ > --- > > (Updated Sept. 7, 2017, 6:36 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > Padma Priya N, Pallav Kulshreshtha, and Prabhjyot Singh. > > > Bugs: AMBARI-21890 > https://issues.apache.org/jira/browse/AMBARI-21890 > > > Repository: ambari > > > Description > --- > > A configurable limit have been imposed on the no of files being retrieved > from the server and the limit by default is set to 5000. > Search has been provided to find the file faster. > > > Diffs > - > > > contrib/views/commons/src/main/java/org/apache/ambari/view/commons/hdfs/FileOperationService.java > d6e484d > contrib/views/files/src/main/resources/ui/app/components/file-search.js > b65749c > contrib/views/files/src/main/resources/ui/app/controllers/files.js 8b5bb7b > contrib/views/files/src/main/resources/ui/app/routes/files.js 140732f > > contrib/views/files/src/main/resources/ui/app/templates/components/file-search.hbs > 298d672 > contrib/views/files/src/main/resources/ui/app/templates/files.hbs 63e0dd8 > > contrib/views/files/src/test/java/org/apache/ambari/view/filebrowser/FilebrowserTest.java > f431f66 > > contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/DirListInfo.java > PRE-CREATION > > contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/DirStatus.java > PRE-CREATION > > contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/HdfsApi.java > 90fa483 > > contrib/views/utils/src/test/java/org/apache/ambari/view/utils/hdfs/HdfsApiTest.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/62119/diff/2/ > > > Testing > --- > > Manual testing done. > > > Thanks, > > venkat sairam > >
Re: Review Request 62119: Ambari Files View - browser going to hung state while opening a HDFS folder which has huge number of files(>10000)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62119/#review184707 --- contrib/views/files/src/main/resources/ui/app/controllers/files.js Line 31 (original), 31 (patched) <https://reviews.apache.org/r/62119/#comment260902> What is the use of this counter variable? contrib/views/files/src/main/resources/ui/app/controllers/files.js Line 81 (original), 86 (patched) <https://reviews.apache.org/r/62119/#comment260904> This is not a good pattern to call API from Controller itself. this.store.query will return a promise and hence arrangedContents value can be a promise. Are you not getting any errors in console? Why is the filter cannot be a query parameter like 'path' and everytime the trottle typing fires why can't we reload the route with the the specified query params? I guess if you go by the reloading route way, the counter variable will also not be required and the hackery will be reduce. - DIPAYAN BHOWMICK On Sept. 6, 2017, 12:48 p.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62119/ > --- > > (Updated Sept. 6, 2017, 12:48 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > Padma Priya N, Pallav Kulshreshtha, and Prabhjyot Singh. > > > Bugs: AMBARI-21890 > https://issues.apache.org/jira/browse/AMBARI-21890 > > > Repository: ambari > > > Description > --- > > A configurable limit have been imposed on the no of files being retrieved > from the server and the limit by default is set to 5000. > Search has been provided to find the file faster. > > > Diffs > - > > > contrib/views/commons/src/main/java/org/apache/ambari/view/commons/hdfs/FileOperationService.java > d6e484d > contrib/views/files/src/main/resources/ui/app/controllers/files.js 8b5bb7b > contrib/views/files/src/main/resources/ui/app/routes/files.js 140732f > contrib/views/files/src/main/resources/ui/app/templates/files.hbs 63e0dd8 > > contrib/views/files/src/test/java/org/apache/ambari/view/filebrowser/FilebrowserTest.java > f431f66 > > contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/DirListInfo.java > PRE-CREATION > > contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/DirStatus.java > PRE-CREATION > > contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/HdfsApi.java > 90fa483 > > contrib/views/utils/src/test/java/org/apache/ambari/view/utils/hdfs/HdfsApiTest.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/62119/diff/1/ > > > Testing > --- > > Manual testing done. > > > Thanks, > > venkat sairam > >
Re: Review Request 61884: Zeppelin's secure cookie should only be set when zeppelin is running in HTTPS mode
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61884/#review183727 --- Ship it! Ship It! - DIPAYAN BHOWMICK On Aug. 24, 2017, 10:38 a.m., Prabhjyot Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61884/ > --- > > (Updated Aug. 24, 2017, 10:38 a.m.) > > > Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN > BHOWMICK, Jayush Luniya, Rohit Choudhary, Renjith Kamath, Sumit Mohanty, and > venkat sairam. > > > Bugs: AMBARI-21802 > https://issues.apache.org/jira/browse/AMBARI-21802 > > > Repository: ambari > > > Description > --- > > Zeppelin's secure cookie should only be set when zeppelin is running in HTTPS > mode > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-shiro-ini.xml > 742f5bedca > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/configuration/zeppelin-shiro-ini.xml > 25ea3d04ab > > > Diff: https://reviews.apache.org/r/61884/diff/1/ > > > Testing > --- > > Manually on CentOS 6 > > > Thanks, > > Prabhjyot Singh > >
Re: Review Request 60152: Add "zeppelin.server.ssl.port" in Zeppelin's setting
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60152/#review178483 --- Ship it! Ship It! - DIPAYAN BHOWMICK On June 19, 2017, 7:10 a.m., Prabhjyot Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60152/ > --- > > (Updated June 19, 2017, 7:10 a.m.) > > > Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN > BHOWMICK, Jayush Luniya, Rohit Choudhary, Renjith Kamath, Sumit Mohanty, and > venkat sairam. > > > Bugs: AMBARI-21271 > https://issues.apache.org/jira/browse/AMBARI-21271 > > > Repository: ambari > > > Description > --- > > Add "zeppelin.server.ssl.port" in Zeppelin's setting. This is in associated > with the changes made in https://issues.apache.org/jira/browse/ZEPPELIN-1321. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-config.xml > 85f1859509 > ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/config-upgrade.xml > 564dead112 > ambari-server/src/test/python/stacks/2.6/configs/default.json 2570657b70 > > > Diff: https://reviews.apache.org/r/60152/diff/2/ > > > Testing > --- > > Manually on CentOS 6.4 > > > Thanks, > > Prabhjyot Singh > >
Re: Review Request 60076: Improve Zeppelin startup time
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60076/#review177877 --- Ship it! Ship It! - DIPAYAN BHOWMICK On June 14, 2017, 11:14 a.m., Prabhjyot Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60076/ > --- > > (Updated June 14, 2017, 11:14 a.m.) > > > Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN > BHOWMICK, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, Renjith Kamath, > and Sumit Mohanty. > > > Bugs: AMBARI-21243 > https://issues.apache.org/jira/browse/AMBARI-21243 > > > Repository: ambari > > > Description > --- > > Currently Zeppelin takes more than 1 minute to start. The bulk of the time > during startup is spent with waiting on interpreter.json. > > So the idea of this patch is to have interpeter.json cached, and apply it > does not exists. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/interpreter_json_template.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py > 3d516b0c68 > > > Diff: https://reviews.apache.org/r/60076/diff/1/ > > > Testing > --- > > Manually on CentOS 6 > > > Thanks, > > Prabhjyot Singh > >
Re: Review Request 59909: Hive2. Query result improvements
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59909/#review177289 --- Ship it! Ship It! - DIPAYAN BHOWMICK On June 8, 2017, 7:38 a.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59909/ > --- > > (Updated June 8, 2017, 7:38 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > Rohit Choudhary, and venkat sairam. > > > Bugs: AMBARI-21198 > https://issues.apache.org/jira/browse/AMBARI-21198 > > > Repository: ambari > > > Description > --- > > - Checking if there is current Job Id created, then only showing the result > panel. > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/models/worksheet.js 12a681c > contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js > 6b395ac > > contrib/views/hive20/src/main/resources/ui/app/routes/queries/query/results.js > df970fb > > contrib/views/hive20/src/main/resources/ui/app/templates/components/query-result-table.hbs > 395987f > contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs > 7b27ba7 > > contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/log.hbs > e9f1a50 > > contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/results.hbs > 966312c > > > Diff: https://reviews.apache.org/r/59909/diff/1/ > > > Testing > --- > > manually tested. > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 59741: File View : Download using Concatenate results in incorrect data
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59741/#review176825 --- Ship it! Ship It! - DIPAYAN BHOWMICK On June 2, 2017, 6:25 a.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59741/ > --- > > (Updated June 2, 2017, 6:25 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-21174 > https://issues.apache.org/jira/browse/AMBARI-21174 > > > Repository: ambari > > > Description > --- > > Earlier : incorrect copying of file input stream to output stream because of > which leftover bytes were getting written > In this patch: corrected the copying of stream using IOUtils > > > Diffs > - > > > contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/DownloadService.java > 10b7c9edcc > > > Diff: https://reviews.apache.org/r/59741/diff/1/ > > > Testing > --- > > Manual testing done. > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 59704: Hive view not exporting/downloading the worksheet with entire number of rows to csv
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59704/#review176593 --- Ship it! Ship It! - DIPAYAN BHOWMICK On June 1, 2017, 8:02 a.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59704/ > --- > > (Updated June 1, 2017, 8:02 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, Rohit Choudhary, and venkat sairam. > > > Bugs: AMBARI-21163 > https://issues.apache.org/jira/browse/AMBARI-21163 > > > Repository: ambari > > > Description > --- > > The root cause can be too many number of Inbox objects which create temporary > actors. Some of these actors get killed before receiving the data back. > In this patch : pulled the inbox object creation per object of > NonPersistentCursor > > > Diffs > - > > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/actor/DeathWatch.java > dbb6c3dd6d > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/client/NonPersistentCursor.java > 0be2683371 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/DeathWatch.java > 58cefcddb3 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/client/NonPersistentCursor.java > 1d76e9cf16 > > > Diff: https://reviews.apache.org/r/59704/diff/1/ > > > Testing > --- > > manual testing done. Files are downloading properly now. > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 59526: Unable to upload table via Ambari Hive view if user does not have permission on default database
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59526/#review175934 --- Ship it! Ship It! - DIPAYAN BHOWMICK On May 24, 2017, 1:36 p.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59526/ > --- > > (Updated May 24, 2017, 1:36 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, Rohit Choudhary, and venkat sairam. > > > Bugs: AMBARI-21108 > https://issues.apache.org/jira/browse/AMBARI-21108 > > > Repository: ambari > > > Description > --- > > Hive view 1.5 was using default DB for use statement in upload table feature. > corrected it to use selected database > > > Diffs > - > > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/UploadService.java > a979dc9478 > > > Diff: https://reviews.apache.org/r/59526/diff/1/ > > > Testing > --- > > manual testing done. > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 59442: Files view on IE 11- On Concatenating files or downloading, the concatenated or downloaded file occupies the entire UI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59442/#review175625 --- Ship it! Ship It! - DIPAYAN BHOWMICK On May 22, 2017, 11:08 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59442/ > --- > > (Updated May 22, 2017, 11:08 a.m.) > > > Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, > Nitiraj Rathore, Padma Priya N, Pallav Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-21084 > https://issues.apache.org/jira/browse/AMBARI-21084 > > > Repository: ambari > > > Description > --- > > Content-Disposition have been changed from inline to attachment to fix issues > in IE while downlaoding files > > > Diffs > - > > > contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/DownloadService.java > 10b7c9e > > > Diff: https://reviews.apache.org/r/59442/diff/1/ > > > Testing > --- > > Manual testing done. > > > Thanks, > > venkat sairam > >
Re: Review Request 59222: Hive 1.5.0 view does not load in Internet Explorer 11
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59222/#review175293
---
Ship it!
Ship It!
- DIPAYAN BHOWMICK
On May 12, 2017, 5:15 p.m., Sangeeta Ravindran wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59222/
> ---
>
> (Updated May 12, 2017, 5:15 p.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore,
> and Pallav Kulshreshtha.
>
>
> Bugs: AMBARI-21001
> https://issues.apache.org/jira/browse/AMBARI-21001
>
>
> Repository: ambari
>
>
> Description
> ---
>
> 1. Create a Hive 1.5.0 view instance and execute it in IE 11.
> 2. A blank page is displayed with the following error message in the web
> console:
> SCRIPT1002: Syntax error
> File: hive.js, Line: 8374, Column: 23
>
> The error is on this line in fetchServiceCheckPolicy in
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/routes/splash.js
>
> this.fetchServiceCheckPolicy()
> .then((data) => {
>
> This is because the ES6 arrow (=>) functions are not supported in IE
>
>
> Diffs
> -
>
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/routes/splash.js
> 087bab3
>
>
> Diff: https://reviews.apache.org/r/59222/diff/1/
>
>
> Testing
> ---
>
> Manual testing in FF, Chrome and IE
>
>
> Thanks,
>
> Sangeeta Ravindran
>
>
Re: Review Request 59103: Pig and CapSched views are not loading in 2.4.3
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59103/#review174424 --- Ship it! Ship It! - DIPAYAN BHOWMICK On May 9, 2017, 5:02 p.m., Akhil PB wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59103/ > --- > > (Updated May 9, 2017, 5:02 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, and venkat sairam. > > > Bugs: AMBARI-20968 > https://issues.apache.org/jira/browse/AMBARI-20968 > > > Repository: ambari > > > Description > --- > > After "ember-precompile-brunch" package has been changed from "1.5.1" to > "0.1.0", ember fails to resolve view templates results in pig and capshed > views fails to render. This patch adds custom resolver to fix the issue. > > > Diffs > - > > contrib/views/capacity-scheduler/src/main/resources/ui/app/app.js 4349538 > contrib/views/pig/src/main/resources/ui/pig-web/app/app.js 866b8a7 > > > Diff: https://reviews.apache.org/r/59103/diff/1/ > > > Testing > --- > > Manual unit testing > > > Thanks, > > Akhil PB > >
Re: Review Request 58997: Users are not able to login to ambari UI after Ambari upgrade from 2.4.x to 2.5.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58997/#review174152 --- Ship it! Ship It! - DIPAYAN BHOWMICK On May 5, 2017, 9:12 a.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58997/ > --- > > (Updated May 5, 2017, 9:12 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Rohit Choudhary, Renjith Kamath, > Ashwin Rajeev, and Yusaku Sako. > > > Bugs: AMBARI-20936 > https://issues.apache.org/jira/browse/AMBARI-20936 > > > Repository: ambari > > > Description > --- > > Instead of deleting entries from DB directly, used uninstalling. Did > refactoring to take the DB related code out of the ViewRegistry (which is > anyway growing very big and is live object which cannot be used during > Upgrade process) to create ViewInstanceOperationHandler.java. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/PrivilegeEntity.java > ba39efb6a2 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewEntity.java > 74de530ad7 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java > b632c54043 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java > d076a5c3b1 > > ambari-server/src/main/java/org/apache/ambari/server/view/ViewInstanceOperationHandler.java > PRE-CREATION > ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java > d136db7e49 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java > 190779add8 > > ambari-server/src/test/java/org/apache/ambari/server/view/ViewInstanceOperationHandlerTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java > a3728d46b3 > > > Diff: https://reviews.apache.org/r/58997/diff/1/ > > > Testing > --- > > added : ViewInstanceOperationHandlerTest.java > updated : UpgradeCatalog250Test.java, ViewRegistryTest.java > > Manual testing to see if upgrade works fine with and without LDAP users and > privileges along with UI deletion of view instance. > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 58886: Smartsense view do not load and shows blank
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58886/#review173574 --- Ship it! Ship It! - DIPAYAN BHOWMICK On May 2, 2017, 8:11 a.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58886/ > --- > > (Updated May 2, 2017, 8:11 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, Rohit Choudhary, venkat sairam, and Ashwin Rajeev. > > > Bugs: AMBARI-20905 > https://issues.apache.org/jira/browse/AMBARI-20905 > > > Repository: ambari > > > Description > --- > > If installation fails and is retried the cluster id changes but some view > instances keep older cluster ids which stop views from being displayed later > on. > remove the view instances which contains invalid cluster id before creating > any autoview instance. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ViewInstanceDAO.java > 061c7223d6 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java > b632c54043 > ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java > 24eceb21c6 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AmbariPrivilegeResourceProviderTest.java > 25afe92ce4 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ViewPrivilegeResourceProviderTest.java > 8836af6ead > > ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java > a3728d46b3 > > > Diff: https://reviews.apache.org/r/58886/diff/2/ > > > Testing > --- > > updated testcases where ever needed. Manual testing also done. > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 58887: Sometimes: Command [ambari-server restart] failed after upgrade Smartsense (Upgrade from 2.4.1.0 to 2.5.0.1)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58887/#review173496 --- Ship it! Ship It! - DIPAYAN BHOWMICK On May 1, 2017, 7:16 p.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58887/ > --- > > (Updated May 1, 2017, 7:16 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-20906 > https://issues.apache.org/jira/browse/AMBARI-20906 > > > Repository: ambari > > > Description > --- > > So from logs it looks like the problem happens when the "view directory > watcher" detects change in jar file tries to update the view. > The solution to this is not with proof but a precautionary and preventive of > nature. > I have introduced a property "views.directory.watcher.disable" which can be > set to "true" to disable the View Directory Watcher. > Disabling will help if ambari does not work fine even after restarts. Another > small change is that I have done the method in ViewRegistry to be > synchronized. This will remove cases if any where in the view gets > simultaneously updated. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > f01df9be7d > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java > e266dd5693 > ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java > 24eceb21c6 > > > Diff: https://reviews.apache.org/r/58887/diff/1/ > > > Testing > --- > > Tests cases are clearing. And ambari is coming up properly. > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 58875: Ambari Header misaligned when transitioned to view route
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58875/#review173442 --- Ship it! Ship It! - DIPAYAN BHOWMICK On April 30, 2017, 4:58 a.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58875/ > --- > > (Updated April 30, 2017, 4:58 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > Rohit Choudhary, and venkat sairam. > > > Bugs: AMBARI-20899 > https://issues.apache.org/jira/browse/AMBARI-20899 > > > Repository: ambari > > > Description > --- > > minor css adjustments > > > Diffs > - > > ambari-web/app/styles/application.less 716e272 > ambari-web/app/styles/bootstrap_overrides.less 09e68b6 > > > Diff: https://reviews.apache.org/r/58875/diff/2/ > > > Testing > --- > > manually tested. > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 58834: Flapping tables in table browser
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58834/#review173428 --- Ship it! Ship It! - DIPAYAN BHOWMICK On April 28, 2017, 7:48 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58834/ > --- > > (Updated April 28, 2017, 7:48 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > Pallav Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-20882 > https://issues.apache.org/jira/browse/AMBARI-20882 > > > Repository: ambari > > > Description > --- > > The list which holds the pending calls of database fetch have been cleared. > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/services/auto-refresh.js > b3276e7 > > > Diff: https://reviews.apache.org/r/58834/diff/1/ > > > Testing > --- > > Manual testing done. > > > Thanks, > > venkat sairam > >
Re: Review Request 58836: HiveView2.0: Visual Explain graph zooms out on scrolling down
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58836/#review173422 --- Ship it! Ship It! - DIPAYAN BHOWMICK On April 29, 2017, 7:03 a.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58836/ > --- > > (Updated April 29, 2017, 7:03 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > Rohit Choudhary, and venkat sairam. > > > Bugs: AMBARI-20146 > https://issues.apache.org/jira/browse/AMBARI-20146 > > > Repository: ambari > > > Description > --- > > Introducing manual zoom in and zoom out. > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 29646cc > > contrib/views/hive20/src/main/resources/ui/app/templates/components/visual-explain.hbs > 2edeab2 > > contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/processor.js > 298366f > > contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js > 4d9eff4 > > > Diff: https://reviews.apache.org/r/58836/diff/2/ > > > Testing > --- > > manually tested. > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 58837: Convert all Ambari Views to use yarn package manager
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58837/#review173419 --- Ship it! Ship It! - DIPAYAN BHOWMICK On April 29, 2017, 6:26 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58837/ > --- > > (Updated April 29, 2017, 6:26 a.m.) > > > Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Nitiraj Rathore, > Pallav Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-20885 > https://issues.apache.org/jira/browse/AMBARI-20885 > > > Repository: ambari > > > Description > --- > > Converted all Ambari Views to use yarn package manager with changes in > pom.xml and package.json. > > > Diffs > - > > contrib/views/capacity-scheduler/pom.xml 7a65ffb > contrib/views/capacity-scheduler/src/main/resources/ui/yarn.lock > PRE-CREATION > contrib/views/files/pom.xml 478a537 > contrib/views/files/src/main/resources/ui/package.json 3f27897 > contrib/views/files/src/main/resources/ui/yarn.lock PRE-CREATION > contrib/views/hawq/pom.xml 8089d68 > contrib/views/hawq/src/main/resources/ui/yarn.lock PRE-CREATION > contrib/views/hive-next/pom.xml c0eb774 > contrib/views/hive-next/src/main/resources/ui/hive-web/bower.json d029eff > contrib/views/hive-next/src/main/resources/ui/hive-web/package.json 623f14f > contrib/views/hive-next/src/main/resources/ui/hive-web/yarn.lock > PRE-CREATION > contrib/views/hive20/pom.xml a583d23 > contrib/views/hive20/src/main/resources/ui/package.json 0453a52 > contrib/views/hive20/src/main/resources/ui/yarn.lock PRE-CREATION > contrib/views/hueambarimigration/pom.xml 30e7694 > > contrib/views/hueambarimigration/src/main/resources/ui/hueambarimigration-view/package.json > 09c3a27 > > contrib/views/hueambarimigration/src/main/resources/ui/hueambarimigration-view/yarn.lock > PRE-CREATION > contrib/views/jobs/pom.xml 062f15f > contrib/views/jobs/src/main/resources/ui/yarn.lock PRE-CREATION > contrib/views/pig/pom.xml d89d47e > contrib/views/pig/src/main/resources/ui/pig-web/yarn.lock PRE-CREATION > contrib/views/wfmanager/pom.xml 86c03f9 > contrib/views/wfmanager/src/main/resources/ui/yarn.lock PRE-CREATION > > > Diff: https://reviews.apache.org/r/58837/diff/2/ > > > Testing > --- > > Manual testing done. > > > Thanks, > > venkat sairam > >
Re: Review Request 58837: Convert all Ambari Views to use yarn package manager
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58837/#review173334 --- contrib/views/capacity-scheduler/pom.xml Line 158 (original), 164 (patched) <https://reviews.apache.org/r/58837/#comment246354> Why is this commented out. Please remove it if not required. - DIPAYAN BHOWMICK On April 28, 2017, 10:29 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58837/ > --- > > (Updated April 28, 2017, 10:29 a.m.) > > > Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Nitiraj Rathore, > Pallav Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-20885 > https://issues.apache.org/jira/browse/AMBARI-20885 > > > Repository: ambari > > > Description > --- > > Converted all Ambari Views to use yarn package manager with changes in > pom.xml and package.json. > > > Diffs > - > > contrib/views/capacity-scheduler/pom.xml 7a65ffb > contrib/views/files/pom.xml 478a537 > contrib/views/files/src/main/resources/ui/package.json 3f27897 > contrib/views/hawq/pom.xml 8089d68 > contrib/views/hive-next/pom.xml c0eb774 > contrib/views/hive-next/src/main/resources/ui/hive-web/bower.json d029eff > contrib/views/hive-next/src/main/resources/ui/hive-web/package.json 623f14f > contrib/views/hive20/pom.xml a583d23 > contrib/views/hive20/src/main/resources/ui/package.json 0453a52 > contrib/views/hueambarimigration/pom.xml 30e7694 > > contrib/views/hueambarimigration/src/main/resources/ui/hueambarimigration-view/package.json > 09c3a27 > contrib/views/jobs/pom.xml 062f15f > contrib/views/pig/pom.xml d89d47e > contrib/views/wfmanager/pom.xml 86c03f9 > > > Diff: https://reviews.apache.org/r/58837/diff/1/ > > > Testing > --- > > Manual testing done. > > > Thanks, > > venkat sairam > >
Re: Review Request 58695: HIVE 2 -UX changes- Part1
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58695/#review172928 --- contrib/views/hive20/src/main/resources/ui/app/templates/components/table-statistics.hbs Line 27 (original), 26 (patched) <https://reviews.apache.org/r/58695/#comment245929> Why is the text made uppercase? contrib/views/hive20/src/main/resources/ui/app/templates/udfs.hbs Lines 51 (patched) <https://reviews.apache.org/r/58695/#comment245928> "explain--error" seems to be awkward. - DIPAYAN BHOWMICK On April 25, 2017, 10:31 a.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58695/ > --- > > (Updated April 25, 2017, 10:31 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > Rohit Choudhary, and venkat sairam. > > > Bugs: AMBARI-20842 > https://issues.apache.org/jira/browse/AMBARI-20842 > > > Repository: ambari > > > Description > --- > > Made CSS related chages. > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/adapters/application.js > 42935fc > contrib/views/hive20/src/main/resources/ui/app/components/udf-item.js > 6005444 > contrib/views/hive20/src/main/resources/ui/app/styles/app.scss f4b63c5 > > contrib/views/hive20/src/main/resources/ui/app/templates/components/jobs-browser.hbs > 014691e > > contrib/views/hive20/src/main/resources/ui/app/templates/components/notification-message.hbs > c2b32a1 > > contrib/views/hive20/src/main/resources/ui/app/templates/components/table-rename-form.hbs > b692a9c > > contrib/views/hive20/src/main/resources/ui/app/templates/components/table-statistics.hbs > cdcf762 > > contrib/views/hive20/src/main/resources/ui/app/templates/components/udf-edit.hbs > 24cb495 > > contrib/views/hive20/src/main/resources/ui/app/templates/components/udf-item.hbs > 929b91a > > contrib/views/hive20/src/main/resources/ui/app/templates/components/udf-new.hbs > ddf34d7 > contrib/views/hive20/src/main/resources/ui/app/templates/databases.hbs > ecedef5 > contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs > 989cfc3 > contrib/views/hive20/src/main/resources/ui/app/templates/savedqueries.hbs > c0b5e82 > contrib/views/hive20/src/main/resources/ui/app/templates/udfs.hbs ef6a01c > > > Diff: https://reviews.apache.org/r/58695/diff/1/ > > > Testing > --- > > manually tested. > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 58615: Hive view 2.0 Error while uploading a table with partitioned columns
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58615/#review172909 --- Ship it! Ship It! - DIPAYAN BHOWMICK On April 21, 2017, 12:06 p.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58615/ > --- > > (Updated April 21, 2017, 12:06 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-20814 > https://issues.apache.org/jira/browse/AMBARI-20814 > > > Repository: ambari > > > Description > --- > > Partition information was handled in all queries except the insert from > query. > Done the required change to get the partition information from UI and using > it build 'insert from query' > > > Diffs > - > > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/InsertFromQueryGenerator.java > 8e22fc72b7 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/query/InsertFromQueryInput.java > 4ff61b40a4 > contrib/views/hive20/src/main/resources/ui/app/adapters/application.js > 42935fc573 > > contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/upload-table.js > 5fee140bee > > > Diff: https://reviews.apache.org/r/58615/diff/1/ > > > Testing > --- > > manual testing done. > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 57709: Yarn Queue manager capacity field allows entering invalid values
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57709/#review171710 --- Ship it! Ship It! - DIPAYAN BHOWMICK On April 5, 2017, 9:43 p.m., Anita Jebaraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57709/ > --- > > (Updated April 5, 2017, 9:43 p.m.) > > > Review request for Ambari, Alexandr Antonenko, belliraj hb, Di Li, DIPAYAN > BHOWMICK, Jaimin Jetly, Richard Zang, and Sangeeta Ravindran. > > > Bugs: AMBARI-20334 > https://issues.apache.org/jira/browse/AMBARI-20334 > > > Repository: ambari > > > Description > --- > > capacity field in yarn queue manager should allow entering decimal numbers > upto 2 places, > > currently the field allows entering values like > > 1.2.3 > 12... > 1 2.3 > > > Diffs > - > > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/capacityInput.js > b6c419a > > > Diff: https://reviews.apache.org/r/57709/diff/2/ > > > Testing > --- > > Tested manually > > > Thanks, > > Anita Jebaraj > >
Re: Review Request 58232: Hive view holds the operational logs open and also fills /tmp
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58232/#review171204 --- Ship it! Ship It! - DIPAYAN BHOWMICK On April 6, 2017, 1:02 p.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58232/ > --- > > (Updated April 6, 2017, 1:02 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-20690 > https://issues.apache.org/jira/browse/AMBARI-20690 > > > Repository: ambari > > > Description > --- > > sync connections were not getting closed after 10 mins window of inactivity. > removed the incorrect call to stop scheduler > > > Diffs > - > > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/actor/HiveActor.java > 36bc430b7f > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/actor/JdbcConnector.java > 997c28aab3 > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/actor/OperationController.java > 98e60f2610 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/HiveActor.java > 384b7982bd > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/JdbcConnector.java > f93ecbffb3 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/OperationController.java > f751d8f54b > > > Diff: https://reviews.apache.org/r/58232/diff/1/ > > > Testing > --- > > manual testing done. > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 58206: Complete node name is not shown when node name is larger than 17 characters
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58206/#review171138 --- Ship it! Ship It! - DIPAYAN BHOWMICK On April 5, 2017, 10:05 a.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58206/ > --- > > (Updated April 5, 2017, 10:05 a.m.) > > > Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, > Nitiraj Rathore, Rohit Choudhary, and venkat sairam. > > > Bugs: AMBARI-20678 > https://issues.apache.org/jira/browse/AMBARI-20678 > > > Repository: ambari > > > Description > --- > > Introduced ellipsis css class and showing complete name as tooltip. > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/styles/app.scss f4b63c5 > > contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js > 1cfcb15 > > > Diff: https://reviews.apache.org/r/58206/diff/1/ > > > Testing > --- > > manually tested. > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 57979: hive view 2.0 handling partition table statistics support added in hive server 2.1
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57979/#review170295 --- Ship it! Ship It! - DIPAYAN BHOWMICK On March 28, 2017, 11:02 a.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57979/ > --- > > (Updated March 28, 2017, 11:02 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-20598 > https://issues.apache.org/jira/browse/AMBARI-20598 > > > Repository: ambari > > > Description > --- > > added support for stats of partitioned table > for hive server version 2.1 and above > > > Diffs > - > > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/ConnectionDelegate.java > f3c4e91e0b > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/HiveJdbcConnectionDelegate.java > 5cc60fbb75 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/JdbcConnector.java > 45fc786a38 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/StatementExecutor.java > c3ed14b2a3 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/message/GetDatabaseMetadataJob.java > PRE-CREATION > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/message/ResultInformation.java > 5b5e17c38d > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/message/job/Result.java > f8c3ba0fb4 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/client/DDLDelegator.java > baa82b4d12 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/client/DDLDelegatorImpl.java > ef4f100ab1 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/client/DatabaseMetadataWrapper.java > PRE-CREATION > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/dto/ColumnStats.java > 190ecd36cb > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/dto/TableStats.java > 3048d22190 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/parsers/DatabaseMetadataExtractor.java > PRE-CREATION > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/parsers/TableMetaParser.java > aae23c8ba8 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/parsers/TableMetaParserImpl.java > f2a1933d98 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/browser/DDLProxy.java > 0c93ba31c5 > > contrib/views/hive20/src/main/resources/ui/app/components/table-statistics.js > 0310cbc005 > contrib/views/hive20/src/main/resources/ui/app/services/stats-service.js > 620bf9b61b > > contrib/views/hive20/src/main/resources/ui/app/templates/components/table-statistics.hbs > 5f62fca4e7 > > > Diff: https://reviews.apache.org/r/57979/diff/2/ > > > Testing > --- > > manual testing done for hive 2.1 and hive 1.2 for partitioned and non > partitioned tables. > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 57979: hive view 2.0 handling partition table statistics support added in hive server 2.1
> On March 28, 2017, 10:16 a.m., DIPAYAN BHOWMICK wrote: > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/JdbcConnector.java > > Lines 304 (patched) > > <https://reviews.apache.org/r/57979/diff/1/?file=1677329#file1677329line304> > > > > Take this out in a separate class. The logic of retrieving the values > > should not be here. A Factory sort of which takes a databaseMetaData object > > and returns a DatabaseMetadataWrapper object. fix it and ship it. - DIPAYAN --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57979/#review170288 --- On March 27, 2017, 11:29 p.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57979/ > --- > > (Updated March 27, 2017, 11:29 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-20598 > https://issues.apache.org/jira/browse/AMBARI-20598 > > > Repository: ambari > > > Description > --- > > added support for stats of partitioned table > for hive server version 2.1 and above > > > Diffs > - > > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/ConnectionDelegate.java > f3c4e91e0b > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/HiveJdbcConnectionDelegate.java > 5cc60fbb75 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/JdbcConnector.java > 45fc786a38 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/StatementExecutor.java > c3ed14b2a3 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/message/GetDatabaseMetadataJob.java > PRE-CREATION > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/message/ResultInformation.java > 5b5e17c38d > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/message/job/Result.java > f8c3ba0fb4 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/client/DDLDelegator.java > baa82b4d12 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/client/DDLDelegatorImpl.java > ef4f100ab1 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/client/DatabaseMetadataWrapper.java > PRE-CREATION > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/dto/ColumnStats.java > 190ecd36cb > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/dto/TableStats.java > 3048d22190 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/parsers/TableMetaParser.java > aae23c8ba8 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/parsers/TableMetaParserImpl.java > f2a1933d98 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/browser/DDLProxy.java > 0c93ba31c5 > > contrib/views/hive20/src/main/resources/ui/app/components/table-statistics.js > 0310cbc005 > contrib/views/hive20/src/main/resources/ui/app/services/stats-service.js > 620bf9b61b > > contrib/views/hive20/src/main/resources/ui/app/templates/components/table-statistics.hbs > 5f62fca4e7 > > > Diff: https://reviews.apache.org/r/57979/diff/1/ > > > Testing > --- > > manual testing done for hive 2.1 and hive 1.2 for partitioned and non > partitioned tables. > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 57979: hive view 2.0 handling partition table statistics support added in hive server 2.1
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57979/#review170288 --- contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/JdbcConnector.java Lines 304 (patched) <https://reviews.apache.org/r/57979/#comment243090> Take this out in a separate class. The logic of retrieving the values should not be here. A Factory sort of which takes a databaseMetaData object and returns a DatabaseMetadataWrapper object. - DIPAYAN BHOWMICK On March 27, 2017, 11:29 p.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57979/ > --- > > (Updated March 27, 2017, 11:29 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-20598 > https://issues.apache.org/jira/browse/AMBARI-20598 > > > Repository: ambari > > > Description > --- > > added support for stats of partitioned table > for hive server version 2.1 and above > > > Diffs > - > > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/ConnectionDelegate.java > f3c4e91e0b > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/HiveJdbcConnectionDelegate.java > 5cc60fbb75 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/JdbcConnector.java > 45fc786a38 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/StatementExecutor.java > c3ed14b2a3 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/message/GetDatabaseMetadataJob.java > PRE-CREATION > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/message/ResultInformation.java > 5b5e17c38d > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/message/job/Result.java > f8c3ba0fb4 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/client/DDLDelegator.java > baa82b4d12 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/client/DDLDelegatorImpl.java > ef4f100ab1 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/client/DatabaseMetadataWrapper.java > PRE-CREATION > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/dto/ColumnStats.java > 190ecd36cb > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/dto/TableStats.java > 3048d22190 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/parsers/TableMetaParser.java > aae23c8ba8 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/parsers/TableMetaParserImpl.java > f2a1933d98 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/browser/DDLProxy.java > 0c93ba31c5 > > contrib/views/hive20/src/main/resources/ui/app/components/table-statistics.js > 0310cbc005 > contrib/views/hive20/src/main/resources/ui/app/services/stats-service.js > 620bf9b61b > > contrib/views/hive20/src/main/resources/ui/app/templates/components/table-statistics.hbs > 5f62fca4e7 > > > Diff: https://reviews.apache.org/r/57979/diff/1/ > > > Testing > --- > > manual testing done for hive 2.1 and hive 1.2 for partitioned and non > partitioned tables. > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 57811: Runtime filtering is not rendering properly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57811/#review169727 --- Ship it! Ship It! - DIPAYAN BHOWMICK On March 22, 2017, 4:02 p.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57811/ > --- > > (Updated March 22, 2017, 4:02 p.m.) > > > Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, > Nitiraj Rathore, Rohit Choudhary, and venkat sairam. > > > Bugs: AMBARI-20519 > https://issues.apache.org/jira/browse/AMBARI-20519 > > > Repository: ambari > > > Description > --- > > Found Pattern Group By -> Reduce -> Group By -> Broadcast and club them in a > single node 'Build Bloom Filter' > > > Diffs > - > > > contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/processor.js > f6d3704 > > contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/transformer.js > ac592ec > > > Diff: https://reviews.apache.org/r/57811/diff/2/ > > > Testing > --- > > manually tested. > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 57842: Tez view not loading in secure mode.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57842/#review169719 --- Ship it! Ship It! - DIPAYAN BHOWMICK On March 22, 2017, 1:40 p.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57842/ > --- > > (Updated March 22, 2017, 1:40 p.m.) > > > Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, > Nitiraj Rathore, Rohit Choudhary, and venkat sairam. > > > Bugs: AMBARI-20530 > https://issues.apache.org/jira/browse/AMBARI-20530 > > > Repository: ambari > > > Description > --- > > Added a check in ENV, setting it empty if not found. > > > Diffs > - > > contrib/views/tez/src/main/resources/ui/ambari-scripts/init-view.js 0e0bdee > > > Diff: https://reviews.apache.org/r/57842/diff/1/ > > > Testing > --- > > manually tested. > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 57806: make home directory check as optional in hive20 view
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57806/#review169709 --- Ship it! Ship It! - DIPAYAN BHOWMICK On March 21, 2017, 2:10 p.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57806/ > --- > > (Updated March 21, 2017, 2:10 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-20517 > https://issues.apache.org/jira/browse/AMBARI-20517 > > > Repository: ambari > > > Description > --- > > added property > views.skip.home-directory-check.file-system.list to skip home directory > checks in hive20 view > > > Diffs > - > > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/Constants.java > PRE-CREATION > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/HdfsApiSupplier.java > 8adac24 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/system/ServiceCheck.java > PRE-CREATION > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/system/SystemService.java > dd5bb06 > contrib/views/hive20/src/main/resources/ui/app/adapters/service-check.js > 22bf1b6 > > contrib/views/hive20/src/main/resources/ui/app/configs/service-check-status.js > 2810e80 > contrib/views/hive20/src/main/resources/ui/app/controllers/service-check.js > 10552ea > contrib/views/hive20/src/main/resources/ui/app/routes/service-check.js > 83111cd > contrib/views/hive20/src/main/resources/ui/app/services/service-check.js > a5a4755 > contrib/views/hive20/src/main/resources/ui/app/templates/service-check.hbs > 2a867aa > > > Diff: https://reviews.apache.org/r/57806/diff/1/ > > > Testing > --- > > tested cases where no property is present or no filesystem is present in the > property. > also tested cases where no service checks are done or odd number of service > checks are done. > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 57075: hive-site.xml, hbase-site.xml, etc. are not found in class path for Zeppelin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57075/#review168991 --- Ship it! Ship It! - DIPAYAN BHOWMICK On March 14, 2017, 7:08 a.m., Prabhjyot Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57075/ > --- > > (Updated March 14, 2017, 7:08 a.m.) > > > Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN > BHOWMICK, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, Renjith Kamath, > and Sumit Mohanty. > > > Bugs: AMBARI-20200 > https://issues.apache.org/jira/browse/AMBARI-20200 > > > Repository: ambari > > > Description > --- > > hive-site.xml, hbase-site.xml, etc. are not found in class path for > Zeppelin's interpreter. > > As a result of which JDBC:phoenix on kerberos mode doesn't work. > > > Diffs > - > > > ambari-server/src/main/resources/stacks/HDP/2.6/services/ZEPPELIN/configuration/zeppelin-env.xml > 1f65fac > > > Diff: https://reviews.apache.org/r/57075/diff/7/ > > > Testing > --- > > Manually on CentOS6 > > > Thanks, > > Prabhjyot Singh > >
Re: Review Request 57555: Need some way to know a plan is vectorized
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57555/#review168889 --- Ship it! Ship It! - DIPAYAN BHOWMICK On March 13, 2017, noon, Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57555/ > --- > > (Updated March 13, 2017, noon) > > > Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, > Nitiraj Rathore, Rohit Choudhary, and venkat sairam. > > > Bugs: AMBARI-20416 > https://issues.apache.org/jira/browse/AMBARI-20416 > > > Repository: ambari > > > Description > --- > > added property for determining vectorization. > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/components/visual-explain.js > fd450cc > contrib/views/hive20/src/main/resources/ui/app/routes/databases.js 02dbcac > > contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables.js > f5940e3 > > contrib/views/hive20/src/main/resources/ui/app/templates/components/visual-explain-detail.hbs > 3df8e94 > > contrib/views/hive20/src/main/resources/ui/app/templates/components/visual-explain.hbs > 30f9405 > > contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js > b36d7b4 > > contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/transformer.js > d88de98 > > > Diff: https://reviews.apache.org/r/57555/diff/1/ > > > Testing > --- > > manually tested. > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 57556: Hive View link in service page points to v1.5 auto instance
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57556/#review168778 --- Ship it! Ship It! - DIPAYAN BHOWMICK On March 13, 2017, 12:41 p.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57556/ > --- > > (Updated March 13, 2017, 12:41 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > Pallav Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-20418 > https://issues.apache.org/jira/browse/AMBARI-20418 > > > Repository: ambari > > > Description > --- > > On click of Hive view link in service page will now points to v2.0 hive view > auto instance > > > Diffs > - > > ambari-web/app/views/main/service/services/hive.js c8c341c > > > Diff: https://reviews.apache.org/r/57556/diff/1/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Re: Review Request 57549: Export workflow will create a workflow with workflow name
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57549/#review168743 --- Ship it! Ship It! - DIPAYAN BHOWMICK On March 13, 2017, 9:02 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57549/ > --- > > (Updated March 13, 2017, 9:02 a.m.) > > > Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, > Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-20411 > https://issues.apache.org/jira/browse/AMBARI-20411 > > > Repository: ambari > > > Description > --- > > Workflow exported will be created will be created with workflow name field > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js > f542c07 > contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 5577239 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-workspace.hbs > c190511 > > > Diff: https://reviews.apache.org/r/57549/diff/2/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Re: Review Request 57453: Fix up tez view version
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57453/#review168739 --- Ship it! Ship It! - DIPAYAN BHOWMICK On March 9, 2017, 10 a.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57453/ > --- > > (Updated March 9, 2017, 10 a.m.) > > > Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Pallav > Kulshreshtha, Rohit Choudhary, Sreenath Somarajapuram, and Ashwin Rajeev. > > > Bugs: AMBARI-20370 > https://issues.apache.org/jira/browse/AMBARI-20370 > > > Repository: ambari > > > Description > --- > > tez view version and build removed and short url of auto instance used for > property tez.tez-ui.history-url.base in tez-site > Removed change of tez version from AbstractUpgradeCatalog. > UpgardeCatalog250 now contains code to change the previous value of > tez.tez-ui.history-url.base to > http://HOST:PORT/#/main/view/TEZ/tez_cluster_instance > changed stack_advisor.py in 2.2 and 2.3 for this change to reflect during > installation > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java > 9be541f > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java > 00d1c31 > ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py > d45cf96 > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py > 6d0ce38 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalogTest.java > 5fa7cac > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java > 1a87433 > ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py > 5fce011 > ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py > b1ec05b > > > Diff: https://reviews.apache.org/r/57453/diff/1/ > > > Testing > --- > > Tested the upgrade from 2.4.0.2 to 2.5.0.0. > Tested installation of fresh 2.5.0.0 > Added test cases for changes in UpgardeCatalog250. > updated test_stack_advisor.py test cases. > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 57505: AMBARI-20360. Need to show appropriate error message in cases of UI failures
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57505/#review168600 --- Ship it! Ship It! - DIPAYAN BHOWMICK On March 10, 2017, 11:44 a.m., Madhan Reddy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57505/ > --- > > (Updated March 10, 2017, 11:44 a.m.) > > > Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, and > Pallav Kulshreshtha. > > > Bugs: AMBARI-20360 > https://issues.apache.org/jira/browse/AMBARI-20360 > > > Repository: ambari > > > Description > --- > > Added error message to show if workflow xml doesn't contain workflow-app tag, > similarly coordinator-app tag for coordinator xml and bundle-app tag for > bundle xml. And also added the check for maximum number of nodes to render > and shown the error message if it exceeds maximum. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js > e94d51a > > contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js > c87ea99 > > contrib/views/wfmanager/src/main/resources/ui/app/components/designer-errors.js > fdb4f5e > > contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js > 37992be > > contrib/views/wfmanager/src/main/resources/ui/app/domain/bundle/bundle-xml-importer.js > b3eed4b > > contrib/views/wfmanager/src/main/resources/ui/app/domain/coordinator/coordinator-xml-importer.js > 12d923c > > contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-importer.js > a076e3e > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-errors.hbs > 3cab194 > > > Diff: https://reviews.apache.org/r/57505/diff/1/ > > > Testing > --- > > Manual > > > Thanks, > > Madhan Reddy > >
Re: Review Request 57346: Value for "User Limit Factor" should be float instead of integer in YARN Queue Manager.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57346/#review168506 --- Ship it! Ship It! - DIPAYAN BHOWMICK On March 8, 2017, 11:15 p.m., Anita Jebaraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57346/ > --- > > (Updated March 8, 2017, 11:15 p.m.) > > > Review request for Ambari, Di Li, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and > Sangeeta Ravindran. > > > Bugs: AMBARI-20333 > https://issues.apache.org/jira/browse/AMBARI-20333 > > > Repository: ambari > > > Description > --- > > According to yarn documentation, > "yarn.scheduler.capacity..user-limit-factor" should be a float: > https://hadoop.apache.org/docs/r2.4.1/hadoop-yarn/hadoop-yarn-site/CapacityScheduler.html > > Hence the user should be allowed to enter decimal values for 'User limit > factor' > > > Diffs > - > > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/capacityInput.js > 8eb06c2 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/queue.hbs > 69f5b3b > > > Diff: https://reviews.apache.org/r/57346/diff/3/ > > > Testing > --- > > Tested manually > > > File Attachments > > > screenshot-1.png > > https://reviews.apache.org/media/uploaded/files/2017/03/06/f55e8f25-b625-4285-96ee-beb4fa6992a4__screenshot-1.png > screenshot-1.png > > https://reviews.apache.org/media/uploaded/files/2017/03/07/aaae7eff-4584-42d4-800b-68b880c68b04__screenshot-1.png > > > Thanks, > > Anita Jebaraj > >
Re: Review Request 57467: After clearing the content of Users in Yarn Queue Manager, it still shows the user in effective administrators
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57467/#review168505 --- Ship it! Ship It! - DIPAYAN BHOWMICK On March 9, 2017, 5:24 p.m., Anita Jebaraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57467/ > --- > > (Updated March 9, 2017, 5:24 p.m.) > > > Review request for Ambari, Di Li, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and > Sangeeta Ravindran. > > > Bugs: AMBARI-20363 > https://issues.apache.org/jira/browse/AMBARI-20363 > > > Repository: ambari > > > Description > --- > > In the "Access Control and Status, clear the content of Users under the > "Administer Queue". It' still shows the user icon in Effective Administraters. > > > Diffs > - > > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/userGroupInput.js > 513031c > > > Diff: https://reviews.apache.org/r/57467/diff/1/ > > > Testing > --- > > Tested manually > > > File Attachments > > > Before Fix > > https://reviews.apache.org/media/uploaded/files/2017/03/09/6ca6a48d-cde2-4e1b-a209-aa898244c998__beforefix.png > After fix > > https://reviews.apache.org/media/uploaded/files/2017/03/09/062bb336-0706-442d-a638-f07f8f8363b3__afterFix.PNG > > > Thanks, > > Anita Jebaraj > >
Re: Review Request 57448: Update Zeppelin version on Ambari-2.5 from 0.6.2 to 0.7.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57448/#review168420 --- Ship it! Ship It! - DIPAYAN BHOWMICK On March 9, 2017, 6:47 a.m., Prabhjyot Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57448/ > --- > > (Updated March 9, 2017, 6:47 a.m.) > > > Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN > BHOWMICK, Jayush Luniya, Rohit Choudhary, Renjith Kamath, and Sumit Mohanty. > > > Repository: ambari > > > Description > --- > > Update Zeppelin version on Ambari-2.5 from 0.6.2 to 0.7.0 > > > Diffs > - > > > ambari-server/src/main/resources/stacks/HDP/2.6/services/ZEPPELIN/metainfo.xml > 59a0ae8 > > > Diff: https://reviews.apache.org/r/57448/diff/1/ > > > Testing > --- > > Tested on CentOS 6 > > > Thanks, > > Prabhjyot Singh > >
Re: Review Request 57248: Visual explain is not routing to visual explain tab
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57248/#review167697 --- Ship it! Ship It! - DIPAYAN BHOWMICK On March 2, 2017, 6:08 p.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57248/ > --- > > (Updated March 2, 2017, 6:08 p.m.) > > > Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, > Nitiraj Rathore, Rohit Choudhary, and venkat sairam. > > > Bugs: AMBARI-20274 > https://issues.apache.org/jira/browse/AMBARI-20274 > > > Repository: ambari > > > Description > --- > > changed the logic to re-direct to visual explain route if 'visual explain' > button is clicked. > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js > cf51ff7 > > > Diff: https://reviews.apache.org/r/57248/diff/1/ > > > Testing > --- > > manually tested. > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 56977: Not able to compute the table statistics for partitioned table
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56977/#review167293 --- Ship it! Ship It! - DIPAYAN BHOWMICK On March 1, 2017, 5:37 p.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56977/ > --- > > (Updated March 1, 2017, 5:37 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-20113 > https://issues.apache.org/jira/browse/AMBARI-20113 > > > Repository: ambari > > > Description > --- > > corrected the case of partitioned table in analyze query generation. > > > Diffs > - > > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/AnalyzeTableQueryGenerator.java > 1d68407 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/browser/DDLProxy.java > e433dc4 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/browser/DDLService.java > 89b9d84 > > contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/AnalyzeTableQueryGeneratorSpecTest.groovy > PRE-CREATION > > > Diff: https://reviews.apache.org/r/56977/diff/2/ > > > Testing > --- > > AnalyzeTableQueryGeneratorSpecTest unit test case added. > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 57075: hive-site.xml, hbase-site.xml, etc. are not found in class path for Zeppelin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57075/#review167246 --- Ship it! Ship It! - DIPAYAN BHOWMICK On March 1, 2017, 7:35 a.m., Prabhjyot Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57075/ > --- > > (Updated March 1, 2017, 7:35 a.m.) > > > Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN > BHOWMICK, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, Renjith Kamath, > and Sumit Mohanty. > > > Bugs: AMBARI-20200 > https://issues.apache.org/jira/browse/AMBARI-20200 > > > Repository: ambari > > > Description > --- > > hive-site.xml, hbase-site.xml, etc. are not found in class path for > Zeppelin's interpreter. > > As a result of which JDBC:phoenix on kerberos mode doesn't work. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml > 677158c > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py > 8a1fad6 > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py > 16a2782 > > > Diff: https://reviews.apache.org/r/57075/diff/6/ > > > Testing > --- > > Manually on CentOS6 > > > Thanks, > > Prabhjyot Singh > >
Re: Review Request 57148: HiveView 2.0: save as HDFS shows success message on error
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57148/#review167214 --- Ship it! Ship It! - DIPAYAN BHOWMICK On Feb. 28, 2017, 3:23 p.m., Gaurav Nagar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57148/ > --- > > (Updated Feb. 28, 2017, 3:23 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-20236 > https://issues.apache.org/jira/browse/AMBARI-20236 > > > Repository: ambari > > > Description > --- > > There is no error thrown from the backend in case of failure. Now handle this > case. > > > Diffs > - > > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/backgroundjobs/BackgroundJobController.java > bd3bb23 > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/backgroundjobs/BackgroundJobException.java > PRE-CREATION > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/jobs/JobService.java > 6eedcca > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/backgroundjobs/BackgroundJobController.java > 0b21a18 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/backgroundjobs/BackgroundJobException.java > PRE-CREATION > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/jobs/JobService.java > c5479e7 > > > Diff: https://reviews.apache.org/r/57148/diff/1/ > > > Testing > --- > > Manually Tested > > > Thanks, > > Gaurav Nagar > >
Re: Review Request 57141: Hive View 2.0: Code hints for query editor are not working
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57141/#review167127 --- Ship it! Ship It! - DIPAYAN BHOWMICK On Feb. 28, 2017, 12:23 p.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57141/ > --- > > (Updated Feb. 28, 2017, 12:23 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > Pallav Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-19673 > https://issues.apache.org/jira/browse/AMBARI-19673 > > > Repository: ambari > > > Description > --- > > User should be able to see code hints and syntax colorization while typing > hive queries. > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/components/query-editor.js > 3175a35 > contrib/views/hive20/src/main/resources/ui/ember-cli-build.js c88799a > > Diff: https://reviews.apache.org/r/57141/diff/ > > > Testing > --- > > Manually tested > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 57120: Hive View 2.0 LogAggregator prints lots of warning logs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57120/#review167126 --- Ship it! Ship It! - DIPAYAN BHOWMICK On Feb. 28, 2017, 4:55 a.m., Gaurav Nagar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57120/ > --- > > (Updated Feb. 28, 2017, 4:55 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-20222 > https://issues.apache.org/jira/browse/AMBARI-20222 > > > Repository: ambari > > > Description > --- > > Stopping the statement executor after query end or failure. > > > Diffs > - > > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/actor/JdbcConnector.java > d6d5d51 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/HiveViewImpl.java > aee7d03 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/JdbcConnector.java > 61f0b66 > > Diff: https://reviews.apache.org/r/57120/diff/ > > > Testing > --- > > Manually tested. > > > Thanks, > > Gaurav Nagar > >
Re: Review Request 57126: HiveView2.0: Logs tab is always empty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57126/#review167125 --- Ship it! Ship It! - DIPAYAN BHOWMICK On Feb. 28, 2017, 6:44 a.m., Gaurav Nagar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57126/ > --- > > (Updated Feb. 28, 2017, 6:44 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-20224 > https://issues.apache.org/jira/browse/AMBARI-20224 > > > Repository: ambari > > > Description > --- > > Remove extra '/' from url > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/adapters/query.js f878230 > > Diff: https://reviews.apache.org/r/57126/diff/ > > > Testing > --- > > Manually Tested > > > Thanks, > > Gaurav Nagar > >
Re: Review Request 57124: Hive view 2.0 Fetch stats doesn't work when you point against LLAP
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57124/#review167124 --- Ship it! Ship It! - DIPAYAN BHOWMICK On Feb. 28, 2017, 5:32 a.m., Gaurav Nagar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57124/ > --- > > (Updated Feb. 28, 2017, 5:32 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-20223 > https://issues.apache.org/jira/browse/AMBARI-20223 > > > Repository: ambari > > > Description > --- > > For fetching stats we are using old query syntax that wont work in Hive 2.0. > Changed the query to newer syntax. > > > Diffs > - > > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/AlterTableQueryGenerator.java > b119f6a > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/AnalyzeTableQueryGenerator.java > 902d959 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/FetchColumnStatsQueryGenerator.java > 73b3698 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/InsertFromQueryGenerator.java > 42cec0a > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/RenameTableQueryGenerator.java > 3406b80 > > contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/AlterTableQueryGeneratorTest.java > 35ea416 > > contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/RenameTableQueryGeneratorSpecTest.groovy > cce9e6c > > Diff: https://reviews.apache.org/r/57124/diff/ > > > Testing > --- > > Manually Tested. > > > Thanks, > > Gaurav Nagar > >
Re: Review Request 57129: revert pom.xml changes of AMBARI-19528 for views other than files view
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57129/#review167031 --- Ship it! Ship It! - DIPAYAN BHOWMICK On Feb. 28, 2017, 9:19 a.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57129/ > --- > > (Updated Feb. 28, 2017, 9:19 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-20226 > https://issues.apache.org/jira/browse/AMBARI-20226 > > > Repository: ambari > > > Description > --- > > removed exclusion of jars which were not required. > > > Diffs > - > > contrib/views/commons/pom.xml fb4deea > contrib/views/hive-next/pom.xml cd26d5e > contrib/views/hive20/pom.xml fe85a35 > contrib/views/pig/pom.xml f99b2bb > contrib/views/utils/pom.xml edb1a02 > contrib/views/wfmanager/pom.xml a659de1 > > Diff: https://reviews.apache.org/r/57129/diff/ > > > Testing > --- > > manually tested all views with hdfs and also files view with s3 > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 57035: ambari-server package size increased from 645MB to 1GB
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57035/#review166687 --- Ship it! Ship It! - DIPAYAN BHOWMICK On Feb. 24, 2017, 12:06 p.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57035/ > --- > > (Updated Feb. 24, 2017, 12:06 p.m.) > > > Review request for Ambari, Attila Doroszlai, DIPAYAN BHOWMICK, Gaurav Nagar, > Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-20170 > https://issues.apache.org/jira/browse/AMBARI-20170 > > > Repository: ambari > > > Description > --- > > excluded the aws bundled jar from transitive dependency of hadoop-aws and > included explicitly only in files view > > > Diffs > - > > contrib/views/files/pom.xml 410ed1e > contrib/views/pom.xml dda956f > contrib/views/utils/pom.xml 324fb1a > > Diff: https://reviews.apache.org/r/57035/diff/ > > > Testing > --- > > created build and tested the files sizes. The overall decrease in size would > be 300 MB. > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 57036: Hive View 2.0: Service checks stopped working.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57036/#review166686 --- Ship it! Ship It! - DIPAYAN BHOWMICK On Feb. 24, 2017, 12:07 p.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57036/ > --- > > (Updated Feb. 24, 2017, 12:07 p.m.) > > > Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, > Nitiraj Rathore, Rohit Choudhary, and venkat sairam. > > > Bugs: AMBARI-20171 > https://issues.apache.org/jira/browse/AMBARI-20171 > > > Repository: ambari > > > Description > --- > > change the value to true to make it work. > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/config/environment.js c891508 > > Diff: https://reviews.apache.org/r/57036/diff/ > > > Testing > --- > > manually tested. > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 57019: HiveView2.0: No notifications for successful query which yields no output.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57019/#review166684 --- Ship it! Ship It! - DIPAYAN BHOWMICK On Feb. 24, 2017, 7:35 a.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57019/ > --- > > (Updated Feb. 24, 2017, 7:35 a.m.) > > > Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, > Nitiraj Rathore, Rohit Choudhary, and venkat sairam. > > > Bugs: AMBARI-20162 > https://issues.apache.org/jira/browse/AMBARI-20162 > > > Repository: ambari > > > Description > --- > > - Added successful message for query > - Clean up visual explain code. > - Fix intermittent results null issue. > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js > 16103b7 > > contrib/views/hive20/src/main/resources/ui/app/routes/queries/query/visual-explain.js > ff3832d > contrib/views/hive20/src/main/resources/ui/app/services/jobs.js 273cd90 > > contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/log.hbs > db1cea2 > > contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/results.hbs > 370e3ef > > contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/tez-ui.hbs > 9bf2b2a > > contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/visual-explain.hbs > ef441b5 > > Diff: https://reviews.apache.org/r/57019/diff/ > > > Testing > --- > > manually tested. > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 56977: Not able to compute the table statistics for partitioned table
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56977/#review166504 --- Ship it! Ship It! - DIPAYAN BHOWMICK On Feb. 23, 2017, 9:30 a.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56977/ > --- > > (Updated Feb. 23, 2017, 9:30 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-20113 > https://issues.apache.org/jira/browse/AMBARI-20113 > > > Repository: ambari > > > Description > --- > > corrected the case of partitioned table in analyze query generation. > > > Diffs > - > > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/AnalyzeTableQueryGenerator.java > 902d959 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/browser/DDLProxy.java > e433dc4 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/browser/DDLService.java > 89b9d84 > > contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/AnalyzeTableQueryGeneratorSpecTest.groovy > PRE-CREATION > > Diff: https://reviews.apache.org/r/56977/diff/ > > > Testing > --- > > AnalyzeTableQueryGeneratorSpecTest unit test case added. > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 56975: File upload from Ambari File View does not work in Chrome 56.0.2924.87 and IE 11
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56975/#review166498 --- Ship it! Ship It! - DIPAYAN BHOWMICK On Feb. 23, 2017, 8:59 a.m., Gaurav Nagar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56975/ > --- > > (Updated Feb. 23, 2017, 8:59 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-20137 > https://issues.apache.org/jira/browse/AMBARI-20137 > > > Repository: ambari > > > Description > --- > > 1. Fixed Cannot add directory issue in chrome > 2. Disable cache for ajax > 3. Handle filename in UTF-8 > > > Diffs > - > > > contrib/views/commons/src/main/java/org/apache/ambari/view/commons/hdfs/UploadService.java > 26a4873 > contrib/views/files/src/main/resources/ui/app/adapters/application.js > 4042851 > contrib/views/files/src/main/resources/ui/app/components/upload-file.js > 96686db > > Diff: https://reviews.apache.org/r/56975/diff/ > > > Testing > --- > > Manually Tested. > > > Thanks, > > Gaurav Nagar > >
Re: Review Request 56880: Zeppelin should configure hadoop.proxyuser in HDFS core-site.xml
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56880/#review166377 --- Ship it! Ship It! - DIPAYAN BHOWMICK On Feb. 22, 2017, 5:17 p.m., Prabhjyot Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56880/ > --- > > (Updated Feb. 22, 2017, 5:17 p.m.) > > > Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav > Nagar, Jayush Luniya, Nitiraj Rathore, Rohit Choudhary, Renjith Kamath, and > Sumit Mohanty. > > > Bugs: AMBARI-20094 > https://issues.apache.org/jira/browse/AMBARI-20094 > > > Repository: ambari > > > Description > --- > > Zeppelin should configure hadoop.proxyuser.zeppelin.groups and > hadoop.proxyuser.zeppelin.hosts in HDFS core-site.xml > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/kerberos.json > 5625681 > > ambari-server/src/main/resources/stacks/HDP/2.5/services/ZEPPELIN/kerberos.json > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.6/services/ZEPPELIN/kerberos.json > PRE-CREATION > > Diff: https://reviews.apache.org/r/56880/diff/ > > > Testing > --- > > Manually tested on CentOS6.4 > > > Thanks, > > Prabhjyot Singh > >
Re: Review Request 56606: Allow user to view Tez View after executing query
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56606/#review166352 --- Ship it! Ship It! - DIPAYAN BHOWMICK On Feb. 22, 2017, 11:14 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56606/ > --- > > (Updated Feb. 22, 2017, 11:14 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav > Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-19989 > https://issues.apache.org/jira/browse/AMBARI-19989 > > > Repository: ambari > > > Description > --- > > As per the parity with Hive View 1.5, allow user to traverse to tez view from > the query page after executing a query. > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/models/worksheet.js 4b3e1f9 > contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js > c549d7b > contrib/views/hive20/src/main/resources/ui/app/services/tez-view-info.js > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 5371aa3 > contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs > bf485ca > > contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/tez-ui.hbs > 9dfa3fa > > Diff: https://reviews.apache.org/r/56606/diff/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Re: Review Request 56786: Hive view 2.0 upload table feature does not show error notifications when errors occurs during the process.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56786/#review165943 --- Ship it! Ship It! - DIPAYAN BHOWMICK On Feb. 17, 2017, 1:12 p.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56786/ > --- > > (Updated Feb. 17, 2017, 1:12 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-20064 > https://issues.apache.org/jira/browse/AMBARI-20064 > > > Repository: ambari > > > Description > --- > > added notification in upload table feature. > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/components/upload-table.js > 8df03e5 > contrib/views/hive20/src/main/resources/ui/app/mixins/ui-logger.js 277f69c > > contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/upload-table.js > a9bf9ea > contrib/views/hive20/src/main/resources/ui/app/services/alert-messages.js > a05fc7a > > contrib/views/hive20/src/main/resources/ui/app/templates/components/upload-table.hbs > e4388f0 > > Diff: https://reviews.apache.org/r/56786/diff/ > > > Testing > --- > > manual testing done. > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 56606: Allow user to view Tez View after executing query
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56606/#review165924 --- Ship it! Ship It! - DIPAYAN BHOWMICK On Feb. 16, 2017, 2:33 p.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56606/ > --- > > (Updated Feb. 16, 2017, 2:33 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav > Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-19989 > https://issues.apache.org/jira/browse/AMBARI-19989 > > > Repository: ambari > > > Description > --- > > As per the parity with Hive View 1.5, allow user to traverse to tez view from > the query page after executing a query. > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js > 88202ff > contrib/views/hive20/src/main/resources/ui/app/services/tez-view-info.js > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/styles/app.scss a9c91c7 > contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs > 5b2b5c2 > > Diff: https://reviews.apache.org/r/56606/diff/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Re: Review Request 56705: Hive server error on view navigation when wire encryption is enabled
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56705/#review165816 --- Ship it! Ship It! - DIPAYAN BHOWMICK On Feb. 15, 2017, 1:01 p.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56705/ > --- > > (Updated Feb. 15, 2017, 1:01 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-20021 > https://issues.apache.org/jira/browse/AMBARI-20021 > > > Repository: ambari > > > Description > --- > > in ambari views : removed exclusion of httpcore and httpclient libraries and > added in dependencyManagement to version 4.4 > > > Diffs > - > > contrib/views/commons/pom.xml 9dd18ac > contrib/views/files/pom.xml 2e742df > contrib/views/hive-next/pom.xml 19f55ee > contrib/views/hive20/pom.xml cf5fdde > contrib/views/pig/pom.xml 738d410 > contrib/views/pom.xml c8a88cb > contrib/views/utils/pom.xml ead33b2 > contrib/views/wfmanager/pom.xml 06fbfeb > > Diff: https://reviews.apache.org/r/56705/diff/ > > > Testing > --- > > manual testing done on cluster with hdfs and s3 support > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 56661: HiveView2.0: Table list under DB panel on Query tab appears only if clicked on db name and Not clear how to set the database
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56661/#review165558 --- Ship it! Ship It! - DIPAYAN BHOWMICK On Feb. 14, 2017, 1:59 p.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56661/ > --- > > (Updated Feb. 14, 2017, 1:59 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > and Pallav Kulshreshtha. > > > Bugs: AMBARI-20009 > https://issues.apache.org/jira/browse/AMBARI-20009 > > > Repository: ambari > > > Description > --- > > Tables are not listed when we select the database and the process selection > of database is not clear > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/routes/queries/new.js > 5a869c2 > contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js > 88202ff > > Diff: https://reviews.apache.org/r/56661/diff/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Re: Review Request 56669: Ambari Views do not appear in full screen view
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56669/#review165549 --- Ship it! Ship It! - DIPAYAN BHOWMICK On Feb. 14, 2017, 5:42 p.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56669/ > --- > > (Updated Feb. 14, 2017, 5:42 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > and Rohit Choudhary. > > > Bugs: AMBARI-20012 > https://issues.apache.org/jira/browse/AMBARI-20012 > > > Repository: ambari > > > Description > --- > > changing the css in on enter and on exit of the route. > > > Diffs > - > > ambari-web/app/routes/view.js 752f14d > > Diff: https://reviews.apache.org/r/56669/diff/ > > > Testing > --- > > manually tested. > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 56661: HiveView2.0: Table list under DB panel on Query tab appears only if clicked on db name and Not clear how to set the database
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56661/#review165500 --- contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js (line 55) <https://reviews.apache.org/r/56661/#comment237338> No need to return RSVP.hash as you are only waiting for a single promise. Just return dbModel promise from here. contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js (line 139) <https://reviews.apache.org/r/56661/#comment237340> In newer ember version, self is not required. this is properly scoped. - DIPAYAN BHOWMICK On Feb. 14, 2017, 1:27 p.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56661/ > --- > > (Updated Feb. 14, 2017, 1:27 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > and Pallav Kulshreshtha. > > > Bugs: AMBARI-20009 > https://issues.apache.org/jira/browse/AMBARI-20009 > > > Repository: ambari > > > Description > --- > > Tables are not listed when we select the database and the process selection > of database is not clear > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/routes/queries/new.js > 5a869c2 > contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js > 88202ff > > Diff: https://reviews.apache.org/r/56661/diff/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Re: Review Request 56643: Hive View 2.0 upload table issues : char support, endline support and temp file deletion
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56643/#review165475 --- Ship it! Ship It! - DIPAYAN BHOWMICK On Feb. 14, 2017, 5:56 a.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56643/ > --- > > (Updated Feb. 14, 2017, 5:56 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-1 > https://issues.apache.org/jira/browse/AMBARI-1 > > > Repository: ambari > > > Description > --- > > following bugs in upload table feature have been resolved in this patch: > 1. does not support to specify endlines in input file's fields > 2. if column datatype is char or varchar it gives error. > 3. temporary table does not get deleted if error occurs in table upload. > Options > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/components/radio-button.js > 066168c > contrib/views/hive20/src/main/resources/ui/app/components/upload-table.js > 29e9891 > contrib/views/hive20/src/main/resources/ui/app/locales/en/translations.js > b550dbe > contrib/views/hive20/src/main/resources/ui/app/models/column.js 73a9824 > > contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/upload-table.js > 0e61905 > > contrib/views/hive20/src/main/resources/ui/app/templates/components/csv-format-params.hbs > c63f502 > > contrib/views/hive20/src/main/resources/ui/app/templates/databases/database/tables/new.hbs > 4f3b98a > > Diff: https://reviews.apache.org/r/56643/diff/ > > > Testing > --- > > manual testing done. > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 56488: Hive2: xxx; never returns
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56488/#review165390 --- contrib/views/hive20/src/main/resources/ui/app/adapters/query.js (line 32) <https://reviews.apache.org/r/56488/#comment237224> Not using dateSubmitted anymore. Why keep it? contrib/views/hive20/src/main/resources/ui/app/controllers/settings.js (line 19) <https://reviews.apache.org/r/56488/#comment237223> What is the use of this controller? contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js (line 130) <https://reviews.apache.org/r/56488/#comment237225> Why not set model as an empty worksheet? contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js (line 233) <https://reviews.apache.org/r/56488/#comment237226> Seems to be that you forgot to handle this error situation. - DIPAYAN BHOWMICK On Feb. 13, 2017, 7:35 p.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56488/ > --- > > (Updated Feb. 13, 2017, 7:35 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > and Rohit Choudhary. > > > Bugs: AMBARI-19938 > https://issues.apache.org/jira/browse/AMBARI-19938 > > > Repository: ambari > > > Description > --- > > - Showing notification on getting error. > - Other code re-factor > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/adapters/query.js e519e64 > contrib/views/hive20/src/main/resources/ui/app/controllers/settings.js > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/models/worksheet.js 1787cc7 > contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js > 88202ff > > contrib/views/hive20/src/main/resources/ui/app/templates/components/query-result-table.hbs > 4d8524e > > contrib/views/hive20/src/main/resources/ui/app/templates/components/visual-explain.hbs > e0ceaa2 > contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs > 5b2b5c2 > > Diff: https://reviews.apache.org/r/56488/diff/ > > > Testing > --- > > manually tested. > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 56606: Allow user to view Tez View after executing query
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56606/#review165373 --- contrib/views/hive20/src/main/resources/ui/app/adapters/query.js (line 51) <https://reviews.apache.org/r/56606/#comment237216> Please check, seems like typo. contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js (line 24) <https://reviews.apache.org/r/56606/#comment237207> spelling? contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js (line 30) <https://reviews.apache.org/r/56606/#comment237215> Move these to the service or function as constants as described in the other comment contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js (line 125) <https://reviews.apache.org/r/56606/#comment237214> Too much of tez related logic inside a route, can you move this to a stateless service or utility functions. contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js (line 236) <https://reviews.apache.org/r/56606/#comment237213> In a pure ember way routes should not contain view logic. Please fix this. contrib/views/hive20/src/main/resources/ui/app/services/job-data.js (line 21) <https://reviews.apache.org/r/56606/#comment237212> Why is this service required? contrib/views/hive20/src/main/resources/ui/app/services/jobs.js (line 39) <https://reviews.apache.org/r/56606/#comment237211> Why are you sending job model object when _fetchDummyResult() expects the job id. - DIPAYAN BHOWMICK On Feb. 13, 2017, 6:52 p.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56606/ > --- > > (Updated Feb. 13, 2017, 6:52 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav > Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-19989 > https://issues.apache.org/jira/browse/AMBARI-19989 > > > Repository: ambari > > > Description > --- > > As per the parity with Hive View 1.5, allow user to traverse to tez view from > the query page after executing a query. > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/adapters/file-resource.js > a25adc7 > contrib/views/hive20/src/main/resources/ui/app/adapters/query.js e519e64 > contrib/views/hive20/src/main/resources/ui/app/components/tez-ui.js > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js > 88202ff > contrib/views/hive20/src/main/resources/ui/app/services/job-data.js > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/services/jobs.js 8503715 > contrib/views/hive20/src/main/resources/ui/app/styles/app.scss a9c91c7 > > contrib/views/hive20/src/main/resources/ui/app/templates/components/tez-ui.hbs > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs > 5b2b5c2 > > Diff: https://reviews.apache.org/r/56606/diff/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Re: Review Request 56589: Hive1 View in Ambari shows wrong status
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56589/#review165306 --- Ship it! Ship It! - DIPAYAN BHOWMICK On Feb. 13, 2017, 7:42 a.m., Gaurav Nagar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56589/ > --- > > (Updated Feb. 13, 2017, 7:42 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-19980 > https://issues.apache.org/jira/browse/AMBARI-19980 > > > Repository: ambari > > > Description > --- > > Setting job status to Error if job call fail. > > > Diffs > - > > > contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/index/history-query/logs.js > 2b5fd26 > > Diff: https://reviews.apache.org/r/56589/diff/ > > > Testing > --- > > Manually Tested > > > Thanks, > > Gaurav Nagar > >
Re: Review Request 56488: Hive2: xxx; never returns
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56488/#review164902 --- I guess alert-message is a good candidate for this, rather than introducing a modal. This is inline with what was happening in the old version of the view. Please fix it. - DIPAYAN BHOWMICK On Feb. 9, 2017, 11:25 a.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56488/ > --- > > (Updated Feb. 9, 2017, 11:25 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > and Rohit Choudhary. > > > Bugs: AMBARI-19938 > https://issues.apache.org/jira/browse/AMBARI-19938 > > > Repository: ambari > > > Description > --- > > Added a modal for error. > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js > dcf27b4 > contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs > 8ee8e87 > > Diff: https://reviews.apache.org/r/56488/diff/ > > > Testing > --- > > manually tested. > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 56430: incorrect imports in hive-next view
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56430/#review164850 --- Ship it! Ship It! - DIPAYAN BHOWMICK On Feb. 8, 2017, 6:52 a.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56430/ > --- > > (Updated Feb. 8, 2017, 6:52 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-19913 > https://issues.apache.org/jira/browse/AMBARI-19913 > > > Repository: ambari > > > Description > --- > > corrected the imports and packages. > > > Diffs > - > > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/CSVParams.java > 355ed6a > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/UploadService.java > 0826945 > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/query/QueryGenerator.java > 72f3b7a > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/query/RowFormat.java > 4c1cb2b > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/query/TableInfo.java > a440e51 > > contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/QueryGeneratorTest.java > 1613b05 > > Diff: https://reviews.apache.org/r/56430/diff/ > > > Testing > --- > > manual testing done. > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 56443: HiveView2.0: Long table name spills out of table panel
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56443/#review164705 --- Ship it! Ship It! - DIPAYAN BHOWMICK On Feb. 8, 2017, 4:22 p.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56443/ > --- > > (Updated Feb. 8, 2017, 4:22 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > and Rohit Choudhary. > > > Bugs: AMBARI-19922 > https://issues.apache.org/jira/browse/AMBARI-19922 > > > Repository: ambari > > > Description > --- > > Adding CSS class to deal such isssues. > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 968d3b3 > > contrib/views/hive20/src/main/resources/ui/app/templates/components/job-item.hbs > 291def6 > > contrib/views/hive20/src/main/resources/ui/app/templates/components/list-item.hbs > 4fbd86b > contrib/views/hive20/src/main/resources/ui/app/templates/savedqueries.hbs > 0ab6cfd > > Diff: https://reviews.apache.org/r/56443/diff/ > > > Testing > --- > > manually tested. > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 56389: HiveView2.0 : View migration not working for new hive view
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56389/#review164528 --- Ship it! Ship It! - DIPAYAN BHOWMICK On Feb. 7, 2017, 2:04 p.m., Gaurav Nagar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56389/ > --- > > (Updated Feb. 7, 2017, 2:04 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-19894 > https://issues.apache.org/jira/browse/AMBARI-19894 > > > Repository: ambari > > > Description > --- > > Corrected class names for migration from 1.5.0 to 2.0.0 > > > Diffs > - > > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/DataMigrator.java > ae0a958 > contrib/views/hive20/src/main/resources/view.xml 7cbe15c > > Diff: https://reviews.apache.org/r/56389/diff/ > > > Testing > --- > > Manually Tested. > > > Thanks, > > Gaurav Nagar > >
Re: Review Request 56307: HiveView2.0 : Upload CSV, JSON, XML to create table feature is missing in the new view
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56307/#review164465 --- Ship it! Ship It! - DIPAYAN BHOWMICK On Feb. 4, 2017, 1:54 p.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56307/ > --- > > (Updated Feb. 4, 2017, 1:54 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-19872 > https://issues.apache.org/jira/browse/AMBARI-19872 > > > Repository: ambari > > > Description > --- > > added the feature to upload file and create a table > > > Diffs > - > > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/dto/ColumnInfo.java > 44c82a0 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/InsertFromQueryGenerator.java > PRE-CREATION > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/jobs/JobService.java > 71cedd1 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/CSVParams.java > 355ed6a > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/TableDataReader.java > ee148b8 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/TableInput.java > 4f15c57 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/UploadFromHdfsInput.java > c755c02 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/UploadService.java > 835626d > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/parsers/Parser.java > a012463 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/parsers/PreviewData.java > 50af529 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/query/InsertFromQueryInput.java > 027baff > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/query/QueryGenerator.java > dda178d > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/query/RowFormat.java > 4c1cb2b > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/query/TableInfo.java > bb39271 > contrib/views/hive20/src/main/resources/ui/app/adapters/file-uploader.js > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/adapters/upload-table.js > PRE-CREATION > > contrib/views/hive20/src/main/resources/ui/app/components/csv-format-params.js > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/components/radio-button.js > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/components/simple-table.js > PRE-CREATION > > contrib/views/hive20/src/main/resources/ui/app/components/upload-table-source.js > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/components/upload-table.js > PRE-CREATION > > contrib/views/hive20/src/main/resources/ui/app/components/validated-text-field.js > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/configs/helpers.js 025caa6 > contrib/views/hive20/src/main/resources/ui/app/locales/en/translations.js > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/models/column.js b1fa99c > contrib/views/hive20/src/main/resources/ui/app/router.js bc9bfa5 > > contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/new.js > 6dfdf29 > > contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/upload-table.js > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/services/jobs.js 453eb12 > contrib/views/hive20/src/main/resources/ui/app/services/table-operations.js > 264e617 > > contrib/views/hive20/src/main/resources/ui/app/templates/components/csv-format-params.hbs > PRE-CREATION > > contrib/views/hive20/src/main/resources/ui/app/templates/components/radio-button.hbs > PRE-CREATION > > contrib/views/hive20/src/main/resources/ui/app/templates/components/simple-table.hbs > PRE-CREATION > > contrib/views/hive20/src/main/resources/ui/app/templates/components/upload-table-source.hbs > PRE-CREATION > > contri
Re: Review Request 56082: Hive View : Logs are not complete for hive view
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56082/#review163646 --- Ship it! Ship It! - DIPAYAN BHOWMICK On Jan. 30, 2017, 3:37 p.m., Gaurav Nagar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56082/ > --- > > (Updated Jan. 30, 2017, 3:37 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-19780 > https://issues.apache.org/jira/browse/AMBARI-19780 > > > Repository: ambari > > > Description > --- > > Changes for saving full query logs with multiple statement to file. > > > Diffs > - > > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/actor/LogAggregator.java > 9412f81 > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/actor/StatementExecutor.java > d7b4f54 > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/actor/message/StartLogAggregation.java > b56da08 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/LogAggregator.java > f9c21b4 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/StatementExecutor.java > 03332d9 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/message/StartLogAggregation.java > 922ad1d > > Diff: https://reviews.apache.org/r/56082/diff/ > > > Testing > --- > > Manuall tested. > > > Thanks, > > Gaurav Nagar > >
Re: Review Request 56075: Hive2: LOGS tab is more prominently displayed than RESULTS
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56075/#review163630 --- Ship it! Ship It! - DIPAYAN BHOWMICK On Jan. 30, 2017, 11:47 a.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56075/ > --- > > (Updated Jan. 30, 2017, 11:47 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > and Rohit Choudhary. > > > Bugs: AMBARI-19765 > https://issues.apache.org/jira/browse/AMBARI-19765 > > > Repository: ambari > > > Description > --- > > UI changes > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/models/worksheet.js 6a77633 > contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js > 753b7f7 > contrib/views/hive20/src/main/resources/ui/app/services/jobs.js 5db22d0 > contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 17abb65 > > contrib/views/hive20/src/main/resources/ui/app/templates/components/query-result-table.hbs > 4fe6f43 > contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs > 5cdc9b3 > > Diff: https://reviews.apache.org/r/56075/diff/ > > > Testing > --- > > manually tested. > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 56084: Hive2: Results are not cleared on "execute"
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56084/#review163628 --- Ship it! Ship It! - DIPAYAN BHOWMICK On Jan. 30, 2017, 4:06 p.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56084/ > --- > > (Updated Jan. 30, 2017, 4:06 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > and Rohit Choudhary. > > > Bugs: AMBARI-19782 > https://issues.apache.org/jira/browse/AMBARI-19782 > > > Repository: ambari > > > Description > --- > > UI changes. > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js > 753b7f7 > > contrib/views/hive20/src/main/resources/ui/app/templates/components/query-result-table.hbs > 4fe6f43 > contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs > 5cdc9b3 > > Diff: https://reviews.apache.org/r/56084/diff/ > > > Testing > --- > > manually tested. > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 56078: Hive View 2.0: Table manager - DDL tab should show query as readonly in query editor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56078/#review163629 --- Ship it! Ship It! - DIPAYAN BHOWMICK On Jan. 30, 2017, 4:56 p.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56078/ > --- > > (Updated Jan. 30, 2017, 4:56 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > and Rohit Choudhary. > > > Bugs: AMBARI-19523 > https://issues.apache.org/jira/browse/AMBARI-19523 > > > Repository: ambari > > > Description > --- > > Changed ivy-codemirror to custom component query-editor. > > > Diffs > - > > > contrib/views/hive20/src/main/resources/ui/app/templates/databases/database/tables/table/ddl.hbs > cbbcdd0 > > Diff: https://reviews.apache.org/r/56078/diff/ > > > Testing > --- > > manually tested. > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 56015: Ambari upgrade to Ambari 2.5 causes start DB check failure on Zeppelin configs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56015/#review163254 --- Ship it! Ship It! - DIPAYAN BHOWMICK On Jan. 27, 2017, 12:43 p.m., Renjith Kamath wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56015/ > --- > > (Updated Jan. 27, 2017, 12:43 p.m.) > > > Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush > Luniya, Prabhjyot Singh, Rohit Choudhary, Robert Levas, and Sumit Mohanty. > > > Bugs: AMBARI-19740 > https://issues.apache.org/jira/browse/AMBARI-19740 > > > Repository: ambari > > > Description > --- > > Ambari upgrade to Ambari 2.5 causes start DB check failure on Zeppelin configs > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java > 624e5a2 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java > bbda783 > > Diff: https://reviews.apache.org/r/56015/diff/ > > > Testing > --- > > tested on centos > > > Thanks, > > Renjith Kamath > >
Re: Review Request 55992: Workflow Manager: Path does not get set to selected directory when creating FS action node.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55992/#review163163 --- Ship it! Ship It! - DIPAYAN BHOWMICK On Jan. 26, 2017, 7:19 p.m., Sangeeta Ravindran wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55992/ > --- > > (Updated Jan. 26, 2017, 7:19 p.m.) > > > Review request for Ambari, Di Li, DIPAYAN BHOWMICK, and Nitiraj Rathore. > > > Bugs: AMBARI-19729 > https://issues.apache.org/jira/browse/AMBARI-19729 > > > Repository: ambari > > > Description > --- > > 1. Try to add a FS node to a workflow. > 2. Browse and select a path and click on Select button. The Path field is > still empty. > > Error in the browser console: > > Uncaught TypeError: Cannot set property 'path' of undefined > at Object.u [as set] (vendor-4ae345a01092a915fe851b682258b76a.js:11) > at n. (oozie-designer-21b647fc98ff652bc7cd154671c10e5b.js:5) > at Object.f [as apply] (vendor-4ae345a01092a915fe851b682258b76a.js:11) > at Object.d [as sendEvent] (vendor-4ae345a01092a915fe851b682258b76a.js:10) > at n.trigger [as _super] (vendor-4ae345a01092a915fe851b682258b76a.js:14) > at n.trigger (vendor-4ae345a01092a915fe851b682258b76a.js:16) > at n [as trigger] (vendor-4ae345a01092a915fe851b682258b76a.js:11) > at n.closeFileBrowser > (oozie-designer-21b647fc98ff652bc7cd154671c10e5b.js:6) > at n.send (vendor-4ae345a01092a915fe851b682258b76a.js:15) > at n [as send] (vendor-4ae345a01092a915fe851b682258b76a.js:11) > > With the changes in AMBARI-19332, the input field for directory path was > updated to prep.path (was prep.settings.path before). > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/prepare-config-fs.js > ba9b91e > > Diff: https://reviews.apache.org/r/55992/diff/ > > > Testing > --- > > Tested manually. > Build failure is unrelated to the patch. > > > Thanks, > > Sangeeta Ravindran > >
Re: Review Request 55871: Error on Files view-SIMPLE authentication is not enabled
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55871/#review162772 --- Ship it! Ship It! - DIPAYAN BHOWMICK On Jan. 24, 2017, 5:47 a.m., Gaurav Nagar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55871/ > --- > > (Updated Jan. 24, 2017, 5:47 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-19689 > https://issues.apache.org/jira/browse/AMBARI-19689 > > > Repository: ambari > > > Description > --- > > Setting fs.defaultfs property to webhdfs url after reading the core-site and > hdfs-site. > > > Diffs > - > > > contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/ConfigurationBuilder.java > d1d1bb0 > > Diff: https://reviews.apache.org/r/55871/diff/ > > > Testing > --- > > Manually tested on local vm > > > Thanks, > > Gaurav Nagar > >
Re: Review Request 55831: Hive view loosing one row every 100 row in result set.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55831/#review162611 --- Ship it! Ship It! - DIPAYAN BHOWMICK On Jan. 23, 2017, 7:15 a.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55831/ > --- > > (Updated Jan. 23, 2017, 7:15 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-19666 > https://issues.apache.org/jira/browse/AMBARI-19666 > > > Repository: ambari > > > Description > --- > > corrected the order of boolean check to avoid fetching one more result from > resultSet when not required. > > > Diffs > - > > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/actor/ResultSetIterator.java > 1052bd4 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/ResultSetIterator.java > 4b4a407 > > Diff: https://reviews.apache.org/r/55831/diff/ > > > Testing > --- > > manual testing done. > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 55615: Hive View 2.0: Show query logs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55615/#review162399 --- Ship it! Ship It! - DIPAYAN BHOWMICK On Jan. 20, 2017, 7:44 a.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55615/ > --- > > (Updated Jan. 20, 2017, 7:44 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > and Rohit Choudhary. > > > Bugs: AMBARI-19582 > https://issues.apache.org/jira/browse/AMBARI-19582 > > > Repository: ambari > > > Description > --- > > UI changes for showing the logs and query results in separate tabs. > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/adapters/query.js a666b09 > > contrib/views/hive20/src/main/resources/ui/app/components/query-result-log.js > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/models/worksheet.js 59395e6 > contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js > 606b71a > contrib/views/hive20/src/main/resources/ui/app/services/jobs.js 723953c > contrib/views/hive20/src/main/resources/ui/app/services/query.js 400f78b > > contrib/views/hive20/src/main/resources/ui/app/templates/components/query-result-log.hbs > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs > 2138356 > > Diff: https://reviews.apache.org/r/55615/diff/ > > > Testing > --- > > manually tested. > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 55516: Workflow Manager View: Start record set to 1 even when there are no records
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55516/#review162259 --- Ship it! Ship It! - DIPAYAN BHOWMICK On Jan. 17, 2017, 9:45 p.m., Sangeeta Ravindran wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55516/ > --- > > (Updated Jan. 17, 2017, 9:45 p.m.) > > > Review request for Ambari, Di Li, DIPAYAN BHOWMICK, and Nitiraj Rathore. > > > Bugs: AMBARI-19475 > https://issues.apache.org/jira/browse/AMBARI-19475 > > > Repository: ambari > > > Description > --- > > In the Workflow Manager View, when there are no co-ordinator or bundle > records, the dashboard message says "Showing 1 to 0 of 0 records". This is > because the start record is set to 1 by default. > > Fix is to set the start record to 0, if the total records is 0. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/routes/design/dashboardtab.js > 78bc1c9 > > Diff: https://reviews.apache.org/r/55516/diff/ > > > Testing > --- > > Manual testing. > > > Thanks, > > Sangeeta Ravindran > >
Re: Review Request 55627: Hive view 2.0 REST and backend support for enabling and fetching table and column stats
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55627/#review162030 --- Ship it! Ship It! - DIPAYAN BHOWMICK On Jan. 17, 2017, 4:18 p.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55627/ > --- > > (Updated Jan. 17, 2017, 4:18 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-19584 > https://issues.apache.org/jira/browse/AMBARI-19584 > > > Repository: ambari > > > Description > --- > > Info can be found at : > https://cwiki.apache.org/confluence/display/Hive/StatsDev#StatsDev-ColumnStatistics > Requirements: > 1. REST endpoint to enable statistics for a table with support for stats for > all columns -- done > 2. REST endpoint to fetch table stats -- done : table stats will come with > table info itself > 3. REST endpoint to fetch column stats -- done > > > Diffs > - > > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/dto/ColumnInfo.java > 2876348 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/dto/ColumnStats.java > PRE-CREATION > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/dto/TableMeta.java > f47e76c > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/dto/TableStats.java > PRE-CREATION > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/parsers/TableMetaParserImpl.java > 5cae34a > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/AnalyzeTableQueryGenerator.java > PRE-CREATION > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/FetchColumnStatsQueryGenerator.java > PRE-CREATION > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/browser/DDLProxy.java > 8d995dd > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/browser/DDLService.java > e142baf > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/jobs/JobService.java > 675ea37 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/jobs/ResultsPaginationController.java > 6efa2a9 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/jobs/viewJobs/JobImpl.java > 85ffaf2 > contrib/views/hive20/src/test/rest/postman/hive20.postman_collection.json > d674944 > > Diff: https://reviews.apache.org/r/55627/diff/ > > > Testing > --- > > manual testing done. > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 55516: Workflow Manager View: Start record set to 1 even when there are no records
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55516/#review161916 --- contrib/views/wfmanager/src/main/resources/ui/app/routes/design/dashboardtab.js (line 140) <https://reviews.apache.org/r/55516/#comment233200> Can we conditional ternary operator as an expression and change the code like: res.start = res.total > 0 ? start : 0; Looks, much cleaner to me. - DIPAYAN BHOWMICK On Jan. 17, 2017, 5:53 p.m., Sangeeta Ravindran wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55516/ > --- > > (Updated Jan. 17, 2017, 5:53 p.m.) > > > Review request for Ambari, Di Li, DIPAYAN BHOWMICK, and Nitiraj Rathore. > > > Bugs: AMBARI-19475 > https://issues.apache.org/jira/browse/AMBARI-19475 > > > Repository: ambari > > > Description > --- > > In the Workflow Manager View, when there are no co-ordinator or bundle > records, the dashboard message says "Showing 1 to 0 of 0 records". This is > because the start record is set to 1 by default. > > Fix is to set the start record to 0, if the total records is 0. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/routes/design/dashboardtab.js > 78bc1c9 > > Diff: https://reviews.apache.org/r/55516/diff/ > > > Testing > --- > > Manual testing. > > > Thanks, > > Sangeeta Ravindran > >
Re: Review Request 55575: Ambari trunk build failing due to checkstyle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55575/#review161735 --- Ship it! Ship It! - DIPAYAN BHOWMICK On Jan. 16, 2017, 2:14 p.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55575/ > --- > > (Updated Jan. 16, 2017, 2:14 p.m.) > > > Review request for Ambari, Attila Doroszlai, DIPAYAN BHOWMICK, Gaurav Nagar, > Pallav Kulshreshtha, Rohit Choudhary, and Sebastian Toader. > > > Bugs: AMBARI-19569 > https://issues.apache.org/jira/browse/AMBARI-19569 > > > Repository: ambari > > > Description > --- > > Corrected the order of imports as per checkstyle > > > Diffs > - > > ambari-server/src/main/java/org/apache/ambari/server/view/ClusterImpl.java > 05bbaa2 > > ambari-server/src/main/java/org/apache/ambari/server/view/RemoteAmbariCluster.java > 8b7bed3 > > Diff: https://reviews.apache.org/r/55575/diff/ > > > Testing > --- > > manually run the mvn clean checkstyle:check in ambari-server trunk branch to > confirm > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 55501: Hive View 2.0: Saving worksheet as saved query
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55501/#review161687 --- Ship it! Ship It! - DIPAYAN BHOWMICK On Jan. 14, 2017, 3:35 a.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55501/ > --- > > (Updated Jan. 14, 2017, 3:35 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > and Rohit Choudhary. > > > Bugs: AMBARI-19522 > https://issues.apache.org/jira/browse/AMBARI-19522 > > > Repository: ambari > > > Description > --- > > Saving worksheet as saved query and Export query results featutes > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/adapters/job.js 8ccd7ad > contrib/views/hive20/src/main/resources/ui/app/adapters/saved-query.js > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/components/query-editor.js > b42c495 > > contrib/views/hive20/src/main/resources/ui/app/components/query-result-table.js > 17df66d > contrib/views/hive20/src/main/resources/ui/app/components/save-hdfs.js > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/models/saved-query.js > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/models/worksheet.js d254ed1 > contrib/views/hive20/src/main/resources/ui/app/routes/queries.js 2346345 > contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js > 5eac78a > contrib/views/hive20/src/main/resources/ui/app/routes/savedqueries.js > 8719170 > contrib/views/hive20/src/main/resources/ui/app/services/jobs.js 4928e5c > contrib/views/hive20/src/main/resources/ui/app/services/query.js 5a2f62d > contrib/views/hive20/src/main/resources/ui/app/services/saved-queries.js > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 6bf8e5a > > contrib/views/hive20/src/main/resources/ui/app/templates/components/query-result-table.hbs > 441352e > > contrib/views/hive20/src/main/resources/ui/app/templates/components/save-hdfs.hbs > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs > 371f404 > contrib/views/hive20/src/main/resources/ui/app/templates/savedqueries.hbs > b776fd2 > > Diff: https://reviews.apache.org/r/55501/diff/ > > > Testing > --- > > manually tested > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 55511: Ambari views : Adding new FileSystem support to views should work without code changes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55511/#review161682 --- Ship it! Ship It! - DIPAYAN BHOWMICK On Jan. 13, 2017, 5:57 p.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55511/ > --- > > (Updated Jan. 13, 2017, 5:57 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, Prabhjyot Singh, Rohit Choudhary, Renjith Kamath, and Ashwin > Rajeev. > > > Bugs: AMBARI-19528 > https://issues.apache.org/jira/browse/AMBARI-19528 > > > Repository: ambari > > > Description > --- > > Before this patch : > Right now when new file-system support has to be added to views, we need to > add code to include several more key value pairs into the conf to make it > work. > Usually these key value pairs are file-system class names, secret key and > access key. > > In this patch: > 1. load the complete core-site and hdfs-site into the conf for creating > filesystem. This will load any secret key, access key configured. It will > also load any other necessary parameters. > 2. Create a new view setting's parameter per view which will have semi colon > separated key=value pairs that needs to be loaded into conf for connecting to > the filesystem. This will cover any extra parameters. > 3. changes in pom.xml -> included Amazon S3 related jars and excluded > conflicting jars. > > > Diffs > - > > ambari-server/src/main/java/org/apache/ambari/server/view/ClusterImpl.java > 10f216e > > ambari-server/src/main/java/org/apache/ambari/server/view/RemoteAmbariCluster.java > 6a4f04a > ambari-views/src/main/java/org/apache/ambari/view/cluster/Cluster.java > 7f7c19b > contrib/views/commons/pom.xml 4b7ee3a > > contrib/views/commons/src/main/java/org/apache/ambari/view/commons/hdfs/FileOperationService.java > bc3d11d > > contrib/views/commons/src/main/java/org/apache/ambari/view/commons/hdfs/HdfsService.java > 91eebcf > > contrib/views/commons/src/main/java/org/apache/ambari/view/commons/hdfs/UploadService.java > 97253ad > > contrib/views/commons/src/main/java/org/apache/ambari/view/commons/hdfs/UserService.java > dc303ce > > contrib/views/commons/src/main/java/org/apache/ambari/view/commons/hdfs/ViewPropertyHelper.java > PRE-CREATION > contrib/views/files/pom.xml ad9af4f > > contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/DownloadService.java > 96d3541 > > contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/FileBrowserService.java > adaa6c9 > > contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/FilePreviewService.java > 051e40d > > contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HelpService.java > 92af2d5 > contrib/views/files/src/main/resources/view.xml 640cee9 > contrib/views/hive-next/pom.xml 2e7beab > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/internal/HdfsApiSupplier.java > 1cc1211 > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/files/FileService.java > 654bfcc > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/utils/SharedObjectsFactory.java > dd0b715 > contrib/views/hive-next/src/main/resources/view.xml 1107cd1 > contrib/views/hive20/pom.xml 6fc30f0 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/HdfsApiSupplier.java > e66b9ab > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/browser/FileService.java > 96e9554 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/files/FileService.java > a3623e9 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/utils/SharedObjectsFactory.java > 5bc6070 > contrib/views/hive20/src/main/resources/view.xml 315d0a9 > contrib/views/jobs/src/main/resources/ui/.gitignore 503a8a9 > contrib/views/pig/pom.xml d7d2de9 > > contrib/views/pig/src/main/java/org/apache/ambari/view/pig/resources/files/FileService.java > 509b20e > > contrib/views/pig/src/main/java/org/apache/ambari/view/pig/utils/UserLocalObjects.java > 8293899 > contrib/views/pig/src/main/resources/view.xml da8ffdd > contrib/views/pom.xml 13cfb23 > contrib/views/utils/pom.
Re: Review Request 55267: Hive View 2.0 : add REST endpoint for deleting database
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55267/#review161053 --- Ship it! Ship It! - DIPAYAN BHOWMICK On Jan. 6, 2017, 2:43 p.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55267/ > --- > > (Updated Jan. 6, 2017, 2:43 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-19403 > https://issues.apache.org/jira/browse/AMBARI-19403 > > > Repository: ambari > > > Description > --- > > Added rest endpoint and query generator and service method for the same. > > > Diffs > - > > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/DeleteDatabaseQueryGenerator.java > PRE-CREATION > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/browser/DDLProxy.java > 8c37a96 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/browser/DDLService.java > b278983 > > contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/DeleteDatabaseQueryGeneratorSpecTest.groovy > PRE-CREATION > contrib/views/hive20/src/test/rest/postman/hive20.postman_collection.json > b6d84b3 > > Diff: https://reviews.apache.org/r/55267/diff/ > > > Testing > --- > > added test class DeleteDatabaseQueryGeneratorSpecTest > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 55336: AMBARI-19420: Import from local file system doesn't work if the same file is selected again.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55336/#review160879 --- Ship it! Ship It! - DIPAYAN BHOWMICK On Jan. 9, 2017, 9:08 a.m., Padma Priya N wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55336/ > --- > > (Updated Jan. 9, 2017, 9:08 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > and Pallav Kulshreshtha. > > > Bugs: AMBARI-19420 > https://issues.apache.org/jira/browse/AMBARI-19420 > > > Repository: ambari > > > Description > --- > > Import a workflow by using local file system. Do a reset layout. Import again > the same file. No effect is seen. > Expected: > The file should be able to import again. > > > Diffs > - > > contrib/views/wfmanager/src/main/resources/ui/app/components/file-picker.js > PRE-CREATION > > Diff: https://reviews.apache.org/r/55336/diff/ > > > Testing > --- > > Manual > > > Thanks, > > Padma Priya N > >
Re: Review Request 55257: AMBARI-19398 : Namenode not resolved while submitting workflow in certain environments
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55257/#review160695 --- Ship it! Ship It! - DIPAYAN BHOWMICK On Jan. 6, 2017, 9:35 a.m., Padma Priya N wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55257/ > --- > > (Updated Jan. 6, 2017, 9:35 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > and Pallav Kulshreshtha. > > > Bugs: AMBARI-19398 > https://issues.apache.org/jira/browse/AMBARI-19398 > > > Repository: ambari > > > Description > --- > > Namenode is not resovled while creating configuration in job.properties while > submitting workflow in certain environments. > Step. > if the hdfs-site does not have dfs.namenode.rpc-address property workflow > submission fails. > Expected. > certain environments may not have dfs.namenode.rpc-address set, and in those > environments workflow should be submitted without error > > > Diffs > - > > > contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/AmbariIOUtil.java > 93447b7 > > contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieDelegate.java > 2779f05 > contrib/views/wfmanager/src/main/resources/view.xml b8e2fcc > > Diff: https://reviews.apache.org/r/55257/diff/ > > > Testing > --- > > Manual > > > Thanks, > > Padma Priya N > >
Re: Review Request 55206: AMBARI-19385: Resolve variables in workflow if workflow path in coordinator contains variables.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55206/#review160684 --- Ship it! Ship It! - DIPAYAN BHOWMICK On Jan. 5, 2017, 12:14 p.m., Padma Priya N wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55206/ > --- > > (Updated Jan. 5, 2017, 12:14 p.m.) > > > Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, and Pallav > Kulshreshtha. > > > Bugs: AMBARI-19385 > https://issues.apache.org/jira/browse/AMBARI-19385 > > > Repository: ambari > > > Description > --- > > Resolve variables in workflow ,if workflow path in coordinator contains > variables.. > Steps: > while creating coordinator use variables while configuring the workflow path. > User is not prompted for the variables in workflow. > > Expected. > the variables in workflow should be prompted for user to submit. > > Also need to add custom properties that the user can configure while > submitting workflow/coordinator/bundle. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js > 122b956 > > contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js > 904901c > > contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js > 3454374 > contrib/views/wfmanager/src/main/resources/ui/app/components/job-config.js > 8b685f0 > > contrib/views/wfmanager/src/main/resources/ui/app/services/property-extractor.js > 0ebd9a7 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs > 5b5cd68 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-config.hbs > f0d9ee3 > > Diff: https://reviews.apache.org/r/55206/diff/ > > > Testing > --- > > Manual > > > Thanks, > > Padma Priya N > >
Re: Review Request 55209: ATS service check failed on navigating to Hive View
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55209/#review160681 --- Ship it! Ship It! - DIPAYAN BHOWMICK On Jan. 5, 2017, 1:30 p.m., Gaurav Nagar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55209/ > --- > > (Updated Jan. 5, 2017, 1:30 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-19382 > https://issues.apache.org/jira/browse/AMBARI-19382 > > > Repository: ambari > > > Description > --- > > The ats url is not correctly form when it is https. Using utils to form ats > url now. > > > Diffs > - > > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/HelpService.java > 702b38a > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/jobs/atsJobs/ATSParserFactory.java > 4ff2621 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/HelpService.java > 9fe > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/jobs/atsJobs/ATSParserFactory.java > 343202e > > Diff: https://reviews.apache.org/r/55209/diff/ > > > Testing > --- > > Manual. > > > Thanks, > > Gaurav Nagar > >
Re: Review Request 55164: AMBARI-19352 : Designer should always pick latest version for an action node
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55164/#review160563 --- Ship it! Ship It! - DIPAYAN BHOWMICK On Jan. 5, 2017, 6:34 a.m., Padma Priya N wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55164/ > --- > > (Updated Jan. 5, 2017, 6:34 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > and Pallav Kulshreshtha. > > > Bugs: AMBARI-19352 > https://issues.apache.org/jira/browse/AMBARI-19352 > > > Repository: ambari > > > Description > --- > > Designer should always pick latest version for an action node and the actin > node settings should be specific to each workflow tab. > But as of now, designer is picking up old settings even for a new tab. > Steps to reproduce: > 1) Import a workflow with hive node and hive node version as 0.2. > 2) Open a new tab and add a hive node to the new workflow. > 3) Preview the xml for new workflow. Even the new workflow has hive version > as 0.2. Ideally it should be the latest version 0.6. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js > 4ef0ac3 > > contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-version-settings.js > 3bd6653 > > contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js > 1d7f435 > > contrib/views/wfmanager/src/main/resources/ui/app/components/coord-version-settings.js > 6385a44 > > contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js > c6264ba > > contrib/views/wfmanager/src/main/resources/ui/app/components/version-settings.js > 9103314 > > contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_hanlder.js > af61c91 > > contrib/views/wfmanager/src/main/resources/ui/app/domain/bundle/bundle-xml-importer.js > 2714ca1 > > contrib/views/wfmanager/src/main/resources/ui/app/domain/coordinator/coordinator-xml-importer.js > 76da535 > contrib/views/wfmanager/src/main/resources/ui/app/domain/schema-versions.js > 0a5083f > > contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-importer.js > d001f38 > > contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-json-importer.js > fa428bb > > contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-xml-generator.js > 012e7ac > contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js > f4fc20d > contrib/views/wfmanager/src/main/resources/ui/app/routes/design.js 10f745a > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-config.hbs > 93a0541 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-version-settings.hbs > 6d6f675 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs > fff8c8c > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-version-settings.hbs > be862ac > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-errors.hbs > 8438255 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs > 7449f27 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/version-settings.hbs > 145f81b > contrib/views/wfmanager/src/main/resources/ui/app/templates/design.hbs > d52c893 > > Diff: https://reviews.apache.org/r/55164/diff/ > > > Testing > --- > > Manual > > > Thanks, > > Padma Priya N > >
Re: Review Request 55137: Hive View 2.0.0: Add ability to expand the query editor and the result pane to take 100% height and width
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55137/#review160377 --- Ship it! Ship It! - DIPAYAN BHOWMICK On Jan. 3, 2017, 1:04 p.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55137/ > --- > > (Updated Jan. 3, 2017, 1:04 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, and Rohit > Choudhary. > > > Bugs: AMBARI-19339 > https://issues.apache.org/jira/browse/AMBARI-19339 > > > Repository: ambari > > > Description > --- > > Minor JS and CSS changes. > > > Diffs > - > > > contrib/views/hive20/src/main/resources/ui/app/components/query-result-table.js > 1cb1d3d > contrib/views/hive20/src/main/resources/ui/app/routes/query.js 699b64c > contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 812ae92 > > contrib/views/hive20/src/main/resources/ui/app/templates/components/query-result-table.hbs > 5001c99 > contrib/views/hive20/src/main/resources/ui/app/templates/query.hbs d24c7d0 > > Diff: https://reviews.apache.org/r/55137/diff/ > > > Testing > --- > > manually tested. > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 55082: Change IFrame container layout for the Ambari Views from fixed to fluid
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55082/#review160278 --- Ship it! Ship It! - DIPAYAN BHOWMICK On Dec. 29, 2016, 12:23 p.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55082/ > --- > > (Updated Dec. 29, 2016, 12:23 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Rohit Choudhary, > and Yusaku Sako. > > > Bugs: AMBARI-19315 > https://issues.apache.org/jira/browse/AMBARI-19315 > > > Repository: ambari > > > Description > --- > > - Added a css class 'contribview' in tag when user navigates to any of > the view in contrib directory. > - change the width to 'auto' if it is under contrib view. > - undoing the width changes if user leaves the contrib views so that other > views are not impacted with these changes. > > > Diffs > - > > ambari-web/app/routes/views.js 1d19279 > ambari-web/app/styles/application.less a89296c > ambari-web/app/styles/bootstrap_overrides.less b8cdf49 > > Diff: https://reviews.apache.org/r/55082/diff/ > > > Testing > --- > > manually tested. > > bruch w > > > Thanks, > > Pallav Kulshreshtha > >
