Review Request 64990: Add event for changes in upgrade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64990/ --- Review request for Ambari, Andrew Onischuk, Dmytro Grinenko, Eugene Chekanskiy, and Sid Wagle. Bugs: AMBARI-22742 https://issues.apache.org/jira/browse/AMBARI-22742 Repository: ambari Description --- Server should raise events to publish created/updated upgrades to STOMP topic. Diffs - ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 1fbf1304135eabd11d7595060d660c38031afbb1 ambari-server/src/main/java/org/apache/ambari/server/events/AmbariUpdateEvent.java cfd910b94bb10fd0ab961dd809313ef525c2b57e ambari-server/src/main/java/org/apache/ambari/server/events/DefaultMessageEmitter.java 3ae5955d497955dba141d0af77701bdba5573fea ambari-server/src/main/java/org/apache/ambari/server/events/RequestUpdateEvent.java 4133c6292b85bd37ca033b24e56c987da83862a0 ambari-server/src/main/java/org/apache/ambari/server/events/UpgradeUpdateEvent.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/UpgradeUpdateListener.java PRE-CREATION Diff: https://reviews.apache.org/r/64990/diff/1/ Testing --- manual testing Thanks, Myroslav Papirkovskyy
Review Request 64987: Add event for changes in alert groups.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64987/ --- Review request for Ambari, Andrew Onischuk, Dmytro Grinenko, Eugene Chekanskiy, and Sid Wagle. Bugs: AMBARI-22739 https://issues.apache.org/jira/browse/AMBARI-22739 Repository: ambari Description --- Server should raise events to publish created/removed/updated alert groups to STOMP topic. Diffs - ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/dto/AlertGroupUpdate.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProvider.java e707496542d6890da816447204bbc94e87ef0348 ambari-server/src/main/java/org/apache/ambari/server/events/AlertGroupsUpdateEvent.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/events/AmbariUpdateEvent.java cfd910b94bb10fd0ab961dd809313ef525c2b57e ambari-server/src/main/java/org/apache/ambari/server/events/DefaultMessageEmitter.java 3ae5955d497955dba141d0af77701bdba5573fea ambari-server/src/main/java/org/apache/ambari/server/events/UpdateEventType.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertGroupsUpdateListener.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAO.java 9fdba33e9e36c37760619f2fe1c480e4a130dbbb ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDispatchDAO.java 174604811311b08e93f41d807bf512b1235e8971 Diff: https://reviews.apache.org/r/64987/diff/1/ Testing --- manual testing Thanks, Myroslav Papirkovskyy
Re: Review Request 64984: /events/hostcomponents topic should react on maintenance and stale configs events.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64984/#review194890 --- ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java Lines 480 (patched) <https://reviews.apache.org/r/64984/#comment273967> This is not a heartbeat processing, just reused method which processes command reports. It is not called on heartbeat anymore, since agent doesn't send reports with heartbeats. Nice point for next refactoring though. - Myroslav Papirkovskyy On Січ. 5, 2018, 8:59 після полудня, Myroslav Papirkovskyy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64984/ > --- > > (Updated Січ. 5, 2018, 8:59 після полудня) > > > Review request for Ambari, Andrew Onischuk, Dmytro Grinenko, Eugene > Chekanskiy, and Sid Wagle. > > > Bugs: AMBARI-22737 > https://issues.apache.org/jira/browse/AMBARI-22737 > > > Repository: ambari > > > Description > --- > > /events/hostcomponents topic should react on maintenance state on/off and > stale configs events. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java > fa697278c34d40afc12b93090a4663543bd94923 > > ambari-server/src/main/java/org/apache/ambari/server/events/AmbariEvent.java > 5f410f563c8bc1c167f72dd640b7c84a639a7040 > > ambari-server/src/main/java/org/apache/ambari/server/events/HostComponentUpdate.java > e48014654c127341f25f5f79ec67b93d973c3d5b > > ambari-server/src/main/java/org/apache/ambari/server/events/StaleConfigsUpdateEvent.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/hostcomponents/HostComponentsUpdateListener.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/hosts/HostUpdateListener.java > 6cb831f153e5748d19be26d4f899522fe9420ed6 > ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java > 7cc5799251913dd29ffb83ce13bf7ec328cab3a5 > > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java > b5ade0c841009235c8a2cee593ca8f992902e4ec > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java > 7f1c746eda955edcc3503595789d2bdc0b50891d > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java > d3ba1d50f8d7356d1445637fdc27d00b715de20e > > ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java > ef7d471affd191400e5ccc259420ae4c544789f8 > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java > a1f28f1b3a5dfc5e30b5a2348b681cca892746ba > > ambari-server/src/test/java/org/apache/ambari/server/controller/RefreshYarnCapacitySchedulerReleaseConfigTest.java > ef186f1ac02fa88f035821e073fdcdd6c0a3cada > > ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java > 48864cc3baab7f7b0887f7dd68a5bbdcd9925698 > > > Diff: https://reviews.apache.org/r/64984/diff/1/ > > > Testing > --- > > manual testing > > > Thanks, > > Myroslav Papirkovskyy > >
Re: Review Request 64984: /events/hostcomponents topic should react on maintenance and stale configs events.
> On Січ. 5, 2018, 9:23 після полудня, Sid Wagle wrote: > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java > > Lines 480 (patched) > > <https://reviews.apache.org/r/64984/diff/1/?file=1932790#file1932790line480> > > > > Why is this needed to be done on HB processing? Can you please remind > > me if we still piggy back tags on HB, in any case shouldn't tags matching > > determine staleness? This is not a heartbeat processing, just reused method which processes command reports. It is not called on heartbeat anymore, since agent doesn't send reports with heartbeats. Nice point for next refactoring though. - Myroslav --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64984/#review194888 --- On Січ. 5, 2018, 8:59 після полудня, Myroslav Papirkovskyy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64984/ > --- > > (Updated Січ. 5, 2018, 8:59 після полудня) > > > Review request for Ambari, Andrew Onischuk, Dmytro Grinenko, Eugene > Chekanskiy, and Sid Wagle. > > > Bugs: AMBARI-22737 > https://issues.apache.org/jira/browse/AMBARI-22737 > > > Repository: ambari > > > Description > --- > > /events/hostcomponents topic should react on maintenance state on/off and > stale configs events. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java > fa697278c34d40afc12b93090a4663543bd94923 > > ambari-server/src/main/java/org/apache/ambari/server/events/AmbariEvent.java > 5f410f563c8bc1c167f72dd640b7c84a639a7040 > > ambari-server/src/main/java/org/apache/ambari/server/events/HostComponentUpdate.java > e48014654c127341f25f5f79ec67b93d973c3d5b > > ambari-server/src/main/java/org/apache/ambari/server/events/StaleConfigsUpdateEvent.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/hostcomponents/HostComponentsUpdateListener.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/hosts/HostUpdateListener.java > 6cb831f153e5748d19be26d4f899522fe9420ed6 > ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java > 7cc5799251913dd29ffb83ce13bf7ec328cab3a5 > > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java > b5ade0c841009235c8a2cee593ca8f992902e4ec > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java > 7f1c746eda955edcc3503595789d2bdc0b50891d > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java > d3ba1d50f8d7356d1445637fdc27d00b715de20e > > ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java > ef7d471affd191400e5ccc259420ae4c544789f8 > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java > a1f28f1b3a5dfc5e30b5a2348b681cca892746ba > > ambari-server/src/test/java/org/apache/ambari/server/controller/RefreshYarnCapacitySchedulerReleaseConfigTest.java > ef186f1ac02fa88f035821e073fdcdd6c0a3cada > > ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java > 48864cc3baab7f7b0887f7dd68a5bbdcd9925698 > > > Diff: https://reviews.apache.org/r/64984/diff/1/ > > > Testing > --- > > manual testing > > > Thanks, > > Myroslav Papirkovskyy > >
Review Request 64984: /events/hostcomponents topic should react on maintenance and stale configs events.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64984/ --- Review request for Ambari, Andrew Onischuk, Dmytro Grinenko, Eugene Chekanskiy, and Sid Wagle. Bugs: AMBARI-22737 https://issues.apache.org/jira/browse/AMBARI-22737 Repository: ambari Description --- /events/hostcomponents topic should react on maintenance state on/off and stale configs events. Diffs - ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java fa697278c34d40afc12b93090a4663543bd94923 ambari-server/src/main/java/org/apache/ambari/server/events/AmbariEvent.java 5f410f563c8bc1c167f72dd640b7c84a639a7040 ambari-server/src/main/java/org/apache/ambari/server/events/HostComponentUpdate.java e48014654c127341f25f5f79ec67b93d973c3d5b ambari-server/src/main/java/org/apache/ambari/server/events/StaleConfigsUpdateEvent.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/events/listeners/hostcomponents/HostComponentsUpdateListener.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/events/listeners/hosts/HostUpdateListener.java 6cb831f153e5748d19be26d4f899522fe9420ed6 ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 7cc5799251913dd29ffb83ce13bf7ec328cab3a5 ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java b5ade0c841009235c8a2cee593ca8f992902e4ec ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java 7f1c746eda955edcc3503595789d2bdc0b50891d ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java d3ba1d50f8d7356d1445637fdc27d00b715de20e ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java ef7d471affd191400e5ccc259420ae4c544789f8 ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java a1f28f1b3a5dfc5e30b5a2348b681cca892746ba ambari-server/src/test/java/org/apache/ambari/server/controller/RefreshYarnCapacitySchedulerReleaseConfigTest.java ef186f1ac02fa88f035821e073fdcdd6c0a3cada ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java 48864cc3baab7f7b0887f7dd68a5bbdcd9925698 Diff: https://reviews.apache.org/r/64984/diff/1/ Testing --- manual testing Thanks, Myroslav Papirkovskyy
Review Request 64983: Setup heartbeat for api endpoint.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64983/ --- Review request for Ambari, Andrew Onischuk, Dmytro Grinenko, Eugene Chekanskiy, and Sid Wagle. Bugs: AMBARI-22738 https://issues.apache.org/jira/browse/AMBARI-22738 Repository: ambari Description --- API endpoint uses sockJS fallback options. The SockJS protocol requires server to set proper heartbeat configuration. Diffs - ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 4dffcaa23ab6a7ca5e2f558ae2bbc3ba89d4cbc4 ambari-server/src/main/java/org/apache/ambari/server/configuration/spring/ApiStompConfig.java e968b11f1ae22631cc656003b98ce1da83b25cee Diff: https://reviews.apache.org/r/64983/diff/1/ Testing --- manual testing Thanks, Myroslav Papirkovskyy
Review Request 64981: alert_definitions topic doesn't emit any events to client.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64981/ --- Review request for Ambari, Andrew Onischuk, Dmytro Grinenko, Eugene Chekanskiy, and Sid Wagle. Bugs: AMBARI-22734 https://issues.apache.org/jira/browse/AMBARI-22734 Repository: ambari Description --- /alert_definitions topic doesn't emit any events to the client when definition properties are modified. Diffs - ambari-server/src/main/java/org/apache/ambari/server/MessageDestinationIsNotDefinedException.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/configuration/spring/RootStompConfig.java fda0607d52ab6e57d9d925e2b22a3f4186bbbf62 ambari-server/src/main/java/org/apache/ambari/server/events/AlertDefinitionsMessageEmitter.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/events/AmbariUpdateEvent.java 6991f155bb8942673a4a0be722259b6a7e5bb027 ambari-server/src/main/java/org/apache/ambari/server/events/DefaultMessageEmitter.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/events/MessageEmitter.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/events/NamedHostRoleCommandUpdateEvent.java 53dc69f7fc0458536698fccdb97e6e97fd0705f6 ambari-server/src/main/java/org/apache/ambari/server/events/listeners/requests/StateUpdateListener.java 17e8c3d4692cdc0f3fd20ddd5606fef458048d96 ambari-server/src/main/java/org/apache/ambari/server/events/listeners/tasks/TaskStatusListener.java 58bfcfca289cc2eec8fbef2321683a22eb91e00f Diff: https://reviews.apache.org/r/64981/diff/1/ Testing --- manual check Thanks, Myroslav Papirkovskyy
Review Request 64979: Delete host event doesn't have hostName property.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64979/
---
Review request for Ambari, Andrew Onischuk, Dmytro Grinenko, Eugene Chekanskiy,
and Sid Wagle.
Bugs: AMBARI-22735
https://issues.apache.org/jira/browse/AMBARI-22735
Repository: ambari
Description
---
When deleting a host, you get an event from /events/ui_topologies, but it
doesn't contain hostName property:
```
{"hash":"922d90764f61dcb2687a33e1e4bfc55b5eb755492b14f48044c940d19324b5e72e669b5af42321383026d46df0775730dd8a0f55a28c625b14f6295bfed02917","eventType":"DELETE","clusters":{"2":{"hosts":[{"hostId":51}]}}}
```
Diffs
-
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/TopologyHolder.java
55c0150b9fc54bf608d995155bfbc279711a41bc
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/dto/TopologyHost.java
9cdf9442ff96fe730d456037ae05a7becf9a97e9
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
bd746f57c2dc6a9e948cbb387ce8329d6ff8eb18
Diff: https://reviews.apache.org/r/64979/diff/1/
Testing
---
manual check
Thanks,
Myroslav Papirkovskyy
Review Request 64977: UI receives a topology event when turning on/off maintenance mode for the host
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64977/ --- Review request for Ambari, Andrew Onischuk, Dmytro Grinenko, Eugene Chekanskiy, and Sid Wagle. Bugs: AMBARI-22733 https://issues.apache.org/jira/browse/AMBARI-22733 Repository: ambari Description --- /events/hostcomponents topic should react on maintenance state on/off and stale configs events. Diffs - ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/TopologyHolder.java 55c0150b9fc54bf608d995155bfbc279711a41bc ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/dto/TopologyCluster.java c17ec7fd018fcb85672758535fbdc4532f4c895c ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/dto/TopologyComponent.java d96180dc02f362156d135d19e562e874f07545b6 ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/dto/TopologyHost.java 9cdf9442ff96fe730d456037ae05a7becf9a97e9 Diff: https://reviews.apache.org/r/64977/diff/1/ Testing --- manual check Thanks, Myroslav Papirkovskyy
Re: Review Request 64652: unable to proceed with cluster install after component install fails.
> On Гру. 15, 2017, 9:01 після полудня, Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
> > Lines 1357-1364 (patched)
> > <https://reviews.apache.org/r/64652/diff/1/?file=1918447#file1918447line1357>
> >
> > These records should just be straight up deleted, not marked this way.
>
> Myroslav Papirkovskyy wrote:
> UI makes explicit call to delete host versions, which will fail if we
> just remove records.
>
> Jonathan Hurley wrote:
> If the UI is deleting the records, why do we even need this?
Because we cannot remove CURRENT version. This state is set if at least one
host finished install for all components.
- Myroslav
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64652/#review193951
---
On Гру. 15, 2017, 7 після полудня, Myroslav Papirkovskyy wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64652/
> ---
>
> (Updated Гру. 15, 2017, 7 після полудня)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Nate Cole.
>
>
> Bugs: AMBARI-22659
> https://issues.apache.org/jira/browse/AMBARI-22659
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Unable go back in install wizard if install was finished at one of hosts.
>
> ```
> Request
> URL:http://ambari:8080/api/v1/stacks/HDP/versions/2.6/repository_versions/1
>
> {
> "status" : 500,
> "message" : "org.apache.ambari.server.controller.spi.SystemException:
> Repository version can't be deleted as it is used by the following hosts:
> CURRENT on sanjay-divgi-test-2.openstacklocal,
> sanjay-divgi-test-5.openstacklocal, sanjay-divgi-test-1.openstacklocal,
> sanjay-divgi-test-4.openstacklocal"
> }
> ```
>
>
> Diffs
> -
>
>
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java
> 158370f3528f796e30a46862e8eb42882001ca02
>
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java
> 4a030af122dbe3ceb3c3592c000b126c864dc626
>
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
> c23b971b85a843433f230b5a94c66ac46c5b1914
>
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java
> bb077d6667138acdaeaafa8b07f188b2ce3dc2af
>
>
> Diff: https://reviews.apache.org/r/64652/diff/1/
>
>
> Testing
> ---
>
> mvn clean test
> manual check
>
>
> Thanks,
>
> Myroslav Papirkovskyy
>
>
Re: Review Request 64652: unable to proceed with cluster install after component install fails.
> On Гру. 15, 2017, 9:01 після полудня, Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
> > Lines 1357-1364 (patched)
> > <https://reviews.apache.org/r/64652/diff/1/?file=1918447#file1918447line1357>
> >
> > These records should just be straight up deleted, not marked this way.
UI makes explicit call to delete host versions, which will fail if we just
remove records.
- Myroslav
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64652/#review193951
---
On Гру. 15, 2017, 7 після полудня, Myroslav Papirkovskyy wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64652/
> ---
>
> (Updated Гру. 15, 2017, 7 після полудня)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Nate Cole.
>
>
> Bugs: AMBARI-22659
> https://issues.apache.org/jira/browse/AMBARI-22659
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Unable go back in install wizard if install was finished at one of hosts.
>
> ```
> Request
> URL:http://ambari:8080/api/v1/stacks/HDP/versions/2.6/repository_versions/1
>
> {
> "status" : 500,
> "message" : "org.apache.ambari.server.controller.spi.SystemException:
> Repository version can't be deleted as it is used by the following hosts:
> CURRENT on sanjay-divgi-test-2.openstacklocal,
> sanjay-divgi-test-5.openstacklocal, sanjay-divgi-test-1.openstacklocal,
> sanjay-divgi-test-4.openstacklocal"
> }
> ```
>
>
> Diffs
> -
>
>
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java
> 158370f3528f796e30a46862e8eb42882001ca02
>
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java
> 4a030af122dbe3ceb3c3592c000b126c864dc626
>
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
> c23b971b85a843433f230b5a94c66ac46c5b1914
>
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java
> bb077d6667138acdaeaafa8b07f188b2ce3dc2af
>
>
> Diff: https://reviews.apache.org/r/64652/diff/1/
>
>
> Testing
> ---
>
> mvn clean test
> manual check
>
>
> Thanks,
>
> Myroslav Papirkovskyy
>
>
Review Request 64652: unable to proceed with cluster install after component install fails.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64652/
---
Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
Bugs: AMBARI-22659
https://issues.apache.org/jira/browse/AMBARI-22659
Repository: ambari
Description
---
Unable go back in install wizard if install was finished at one of hosts.
```
Request
URL:http://ambari:8080/api/v1/stacks/HDP/versions/2.6/repository_versions/1
{
"status" : 500,
"message" : "org.apache.ambari.server.controller.spi.SystemException:
Repository version can't be deleted as it is used by the following hosts:
CURRENT on sanjay-divgi-test-2.openstacklocal,
sanjay-divgi-test-5.openstacklocal, sanjay-divgi-test-1.openstacklocal,
sanjay-divgi-test-4.openstacklocal"
}
```
Diffs
-
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java
158370f3528f796e30a46862e8eb42882001ca02
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java
4a030af122dbe3ceb3c3592c000b126c864dc626
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
c23b971b85a843433f230b5a94c66ac46c5b1914
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java
bb077d6667138acdaeaafa8b07f188b2ce3dc2af
Diff: https://reviews.apache.org/r/64652/diff/1/
Testing
---
mvn clean test
manual check
Thanks,
Myroslav Papirkovskyy
Review Request 64547: Hive MetaStore does not start even after passing the mysql-connector to ambari-server
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64547/ --- Review request for Ambari, Andrew Onischuk and Sid Wagle. Bugs: AMBARI-22631 https://issues.apache.org/jira/browse/AMBARI-22631 Repository: ambari Description --- Agent should always download jdbc driver for Hive from server resources. Diffs - ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py 082232011950bd0eb5ad361bf7aa6a1cd761db41 ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py a2b983ed8c37b37d5d12ab4ac1b0673e2f66e040 ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py dca7c18017011ecc8133323510a6352031fc4adb ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py 73f5fe62c870f79d2f55d39a06279e977fb61115 ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py 4eb16c2a3c146ac4d2e61370eb5f3121c7a5331f Diff: https://reviews.apache.org/r/64547/diff/1/ Testing --- mvn clean test manual check Thanks, Myroslav Papirkovskyy
Re: Review Request 64388: Tez service check hangs when adding service
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64388/ --- (Updated Гру. 7, 2017, 4:43 після полудня) Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Sid Wagle. Bugs: AMBARI-22605 https://issues.apache.org/jira/browse/AMBARI-22605 Repository: ambari Description --- STR: Deploy minimal cluster (HDFS, YARN+MR2, ZooKeeper). Add Tez service. Service check hangs for a long time. Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 85e0c1cf130974377abb7b685f191e20324b090e ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListener.java d5a1ac4fd06377a992a8286d6fca366536a25157 Diff: https://reviews.apache.org/r/64388/diff/2/ Changes: https://reviews.apache.org/r/64388/diff/1-2/ Testing --- mvn clean test manual check Thanks, Myroslav Papirkovskyy
Review Request 64388: Tez service check hangs when adding service
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64388/ --- Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Sid Wagle. Bugs: AMBARI-22605 https://issues.apache.org/jira/browse/AMBARI-22605 Repository: ambari Description --- STR: Deploy minimal cluster (HDFS, YARN+MR2, ZooKeeper). Add Tez service. Service check hangs for a long time. Diffs - ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 85e0c1cf130974377abb7b685f191e20324b090e ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListener.java d5a1ac4fd06377a992a8286d6fca366536a25157 Diff: https://reviews.apache.org/r/64388/diff/1/ Testing --- mvn clean test manual check Thanks, Myroslav Papirkovskyy
Review Request 64346: Jetty Session Timeout Is Overridden By Views Initialization. (mpapirkovskyy)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64346/ --- Review request for Ambari, Jonathan Hurley and Sid Wagle. Bugs: AMBARI-22597 https://issues.apache.org/jira/browse/AMBARI-22597 Repository: ambari Description --- Moved max inactive interval configuration to point after views initialization Diffs - ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 863313b015f86b35fccdb8e83d9429e9be9b6f8f Diff: https://reviews.apache.org/r/64346/diff/1/ Testing --- manual Thanks, Myroslav Papirkovskyy
Review Request 64302: PERF 1.0 stack deployment failure in ambari-2.6.1.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64302/ --- Review request for Ambari, Andrew Onischuk and Sid Wagle. Bugs: AMBARI-22584 https://issues.apache.org/jira/browse/AMBARI-22584 Repository: ambari Description --- Backport of AMBARI-22520 Diffs - ambari-server/src/main/resources/stacks/PERF/1.0/configuration/cluster-env.xml f19ac5237e278841dcf1b01db963004753ab77fe ambari-server/src/main/resources/stacks/PERF/1.0/properties/stack_packages.json PRE-CREATION Diff: https://reviews.apache.org/r/64302/diff/1/ Testing --- mvn clean test Thanks, Myroslav Papirkovskyy
Re: Review Request 64209: Need to address HDP-GPL repo update after user accepts license in post-install scenario
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64209/#review192371 --- Ship it! Ship It! - Myroslav Papirkovskyy On Лис. 30, 2017, 3:28 після полудня, Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64209/ > --- > > (Updated Лис. 30, 2017, 3:28 після полудня) > > > Review request for Ambari, Attila Doroszlai, Myroslav Papirkovskyy, Nate > Cole, and Sid Wagle. > > > Bugs: AMBARI-22561 > https://issues.apache.org/jira/browse/AMBARI-22561 > > > Repository: ambari > > > Description > --- > > * User denies the GPL license agreement, UI will still issue PUT call to > create the repo > * Ambari should not write HDP-GPL repo info to the ambari-hdp-1.repo > because it will break yum in local repo world. > * Then the user accepts the license by running ambari-server setup > * The repo file does not get updated on existing hosts > * We need to push the HDP-GPL repo to the repo files on existing hosts only > when the license is accepted > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/lzo_utils.py > 68ee607b9b > > ambari-common/src/main/python/resource_management/libraries/functions/repository_util.py > f1c8ef1b04 > > ambari-common/src/main/python/resource_management/libraries/script/script.py > ccb8a547f4 > > ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java > e207ac5289 > ambari-server/src/main/resources/custom_actions/scripts/install_packages.py > b819dcad96 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py > 82e57aa4f4 > ambari-server/src/test/python/stacks/utils/RMFTestCase.py 80712c5ebe > > > Diff: https://reviews.apache.org/r/64209/diff/1/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
Re: Review Request 64216: . Repository validation fails for HDP-GPL
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64216/ --- (Updated Лис. 30, 2017, 10:23 після полудня) Review request for Ambari, Andrew Onischuk, Jonathan Hurley, and Sid Wagle. Bugs: AMBARI-22565 https://issues.apache.org/jira/browse/AMBARI-22565 Repository: ambari Description --- Server always fail to validate repository with unknown repo_id. We perform repository lookup in stack only to get repo_name. Should use repo_name received from API request. Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 48ab1b93e880e6e46c3e6f70dc433a5a3643a2ee ambari-server/src/main/java/org/apache/ambari/server/controller/RepositoryRequest.java 84929bfe0eb498917401445b5ce8cd8a015bfa0f ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryResourceProvider.java cec43dd40f20061965cc98cc357d193a76a16533 ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java 00b87a69224c35a25c3c0e0ec39a9bbd4fc7a9b8 ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 6e9e5efcd408b683224db46e668a44336a9cf167 Diff: https://reviews.apache.org/r/64216/diff/2/ Changes: https://reviews.apache.org/r/64216/diff/1-2/ Testing --- mvn clean test Thanks, Myroslav Papirkovskyy
Re: Review Request 64216: . Repository validation fails for HDP-GPL
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64216/ --- (Updated Лис. 30, 2017, 7:14 після полудня) Review request for Ambari, Andrew Onischuk, Jonathan Hurley, and Sid Wagle. Bugs: AMBARI-22565 https://issues.apache.org/jira/browse/AMBARI-22565 Repository: ambari Description (updated) --- Server always fail to validate repository with unknown repo_id. We perform repository lookup in stack only to get repo_name. Should use repo_name received from API request. Diffs - ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 48ab1b93e880e6e46c3e6f70dc433a5a3643a2ee ambari-server/src/main/java/org/apache/ambari/server/controller/RepositoryRequest.java 84929bfe0eb498917401445b5ce8cd8a015bfa0f ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryResourceProvider.java cec43dd40f20061965cc98cc357d193a76a16533 ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java 00b87a69224c35a25c3c0e0ec39a9bbd4fc7a9b8 ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 6e9e5efcd408b683224db46e668a44336a9cf167 Diff: https://reviews.apache.org/r/64216/diff/1/ Testing --- mvn clean test Thanks, Myroslav Papirkovskyy
Review Request 64216: . Repository validation fails for HDP-GPL
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64216/ --- Review request for Ambari, Andrew Onischuk, Jonathan Hurley, and Sid Wagle. Bugs: AMBARI-22565 https://issues.apache.org/jira/browse/AMBARI-22565 Repository: ambari Description --- AMBARI-22565 Diffs - ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 48ab1b93e880e6e46c3e6f70dc433a5a3643a2ee ambari-server/src/main/java/org/apache/ambari/server/controller/RepositoryRequest.java 84929bfe0eb498917401445b5ce8cd8a015bfa0f ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryResourceProvider.java cec43dd40f20061965cc98cc357d193a76a16533 ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java 00b87a69224c35a25c3c0e0ec39a9bbd4fc7a9b8 ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 6e9e5efcd408b683224db46e668a44336a9cf167 Diff: https://reviews.apache.org/r/64216/diff/1/ Testing --- mvn clean test Thanks, Myroslav Papirkovskyy
Re: Review Request 64174: Upgrade from Ambari 2.5.2 to 2.6.0 fails.
> On Лис. 29, 2017, 10:54 після полудня, Sid Wagle wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java > > Lines 350 (patched) > > <https://reviews.apache.org/r/64174/diff/1/?file=1903976#file1903976line351> > > > > Will this delete existing data? Any implications of doing so? Just 2 lines below we clear whole upgrade items table, if we don't clear this column FK constraint violation will appear. - Myroslav --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64174/#review192169 --- On Лис. 29, 2017, 10:49 після полудня, Myroslav Papirkovskyy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64174/ > --- > > (Updated Лис. 29, 2017, 10:49 після полудня) > > > Review request for Ambari, Andrew Onischuk and Sid Wagle. > > > Bugs: AMBARI-22544 > https://issues.apache.org/jira/browse/AMBARI-22544 > > > Repository: ambari > > > Description > --- > > When upgrading from Ambari 2.5.2 to Ambari 2.6.0, we hit this error > preventing from completing the ambari-server upgrade. > > ``` > 20 Nov 2017 11:39:08,115 ERROR [main] SchemaUpgradeHelper:202 - Upgrade > failed. > com.mysql.jdbc.exceptions.jdbc4.MySQLIntegrityConstraintViolationException: > Cannot delete or update a parent row: a foreign key constraint fails > (`ambari_01`.`clusters`, CONSTRAINT `FK_clusters_upgrade_id` FOREIGN KEY > (`upgrade_id`) REFERENCES `upgrade` (`upgrade_id`)) > ``` > > To get around this, we had to restore the db backup from 2.5.3 and adjust a > table in mysql with ‘update clusters set upgrade_id = null’ so a record in > the ‘upgrades’ table could be removed. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java > 35f9f65dc89302aaf4c555d269beb221f2c0a793 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog260Test.java > c6111712c3f79347234d282461e0d9f0ed5a8b75 > > > Diff: https://reviews.apache.org/r/64174/diff/1/ > > > Testing > --- > > mvn clean test > manual check of described case > > > Thanks, > > Myroslav Papirkovskyy > >
Review Request 64174: Upgrade from Ambari 2.5.2 to 2.6.0 fails.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64174/ --- Review request for Ambari, Andrew Onischuk and Sid Wagle. Bugs: AMBARI-22544 https://issues.apache.org/jira/browse/AMBARI-22544 Repository: ambari Description --- When upgrading from Ambari 2.5.2 to Ambari 2.6.0, we hit this error preventing from completing the ambari-server upgrade. ``` 20 Nov 2017 11:39:08,115 ERROR [main] SchemaUpgradeHelper:202 - Upgrade failed. com.mysql.jdbc.exceptions.jdbc4.MySQLIntegrityConstraintViolationException: Cannot delete or update a parent row: a foreign key constraint fails (`ambari_01`.`clusters`, CONSTRAINT `FK_clusters_upgrade_id` FOREIGN KEY (`upgrade_id`) REFERENCES `upgrade` (`upgrade_id`)) ``` To get around this, we had to restore the db backup from 2.5.3 and adjust a table in mysql with ‘update clusters set upgrade_id = null’ so a record in the ‘upgrades’ table could be removed. Diffs - ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java 35f9f65dc89302aaf4c555d269beb221f2c0a793 ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog260Test.java c6111712c3f79347234d282461e0d9f0ed5a8b75 Diff: https://reviews.apache.org/r/64174/diff/1/ Testing --- mvn clean test manual check of described case Thanks, Myroslav Papirkovskyy
Review Request 64087: Service config changes on hdp + hdf cluster throws Consistency check failed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64087/ --- Review request for Ambari, Andrew Onischuk and Sid Wagle. Bugs: AMBARI-22523 https://issues.apache.org/jira/browse/AMBARI-22523 Repository: ambari Description --- Consistency check fails with unknown error on config change if HIVE and DRUID services are present. Diffs - ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py a5f54a346379a8fa4252184321620557a06344d3 ambari-server/src/test/python/stacks/2.6/common/test_stack_advisor.py f4c550897d75d54d52810f3070cfc0e7c8742173 Diff: https://reviews.apache.org/r/64087/diff/1/ Testing --- mvn clean test Thanks, Myroslav Papirkovskyy
Re: Review Request 63957: Stack advisor should disallow lzo enable without accepting license agreement.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63957/ --- (Updated Лис. 22, 2017, 8:09 після полудня) Review request for Ambari, Andrew Onischuk, Jonathan Hurley, Nate Cole, and Sid Wagle. Bugs: AMBARI-22484 https://issues.apache.org/jira/browse/AMBARI-22484 Repository: ambari Description --- If the user adds com.hadoop.compression.lzo.LzoCodec to core-site property io.compression.codec.lzo.class and the ambari.properties does not have the allow GPL software install flag, throw validation error Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorRequest.java 64180e5039bdb74d3aaf25e140565c82a95a26c1 ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java 5440462b86cdcfafb1e9ab239dacfddee0b31b93 ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java b2a68d66d777f107fdc4f5576a691e8d25ec2c92 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackAdvisorResourceProvider.java dd32c6badb18c1a8c02b7093813cd92ccd2fc74c ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py c36a41f49b224a904368c7474f0f769348e65ae6 ambari-server/src/main/resources/stacks/stack_advisor.py 8ccbaba9db083068268951ae4e07ce08d32edcc4 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ValidationResourceProviderTest.java cdbf2d782f86b2a30f54619c4e2a9165a020275c ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 9e0070458987ee490f3918fead5ef11d201c8612 Diff: https://reviews.apache.org/r/63957/diff/2/ Changes: https://reviews.apache.org/r/63957/diff/1-2/ Testing --- mvn clean test Thanks, Myroslav Papirkovskyy
Re: Review Request 63955: Validate blueprint does not allow lzo enable without setup with license agreement.
> On Лис. 20, 2017, 8:34 після полудня, Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintImpl.java > > Line 351 (original), 352 (patched) > > <https://reviews.apache.org/r/63955/diff/1/?file=1897721#file1897721line357> > > > > Add missing throws to documentation Fixed in additional commit, exception file got moved between commits, so cannot update rb correctly > On Лис. 20, 2017, 8:34 після полудня, Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidator.java > > Line 38 (original), 38 (patched) > > <https://reviews.apache.org/r/63955/diff/1/?file=1897722#file1897722line38> > > > > add missing throws to documentation Fixed in additional commit, exception file got moved between commits, so cannot update rb correctly - Myroslav --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63955/#review191529 --- On Лис. 20, 2017, 7:06 після полудня, Myroslav Papirkovskyy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63955/ > --- > > (Updated Лис. 20, 2017, 7:06 після полудня) > > > Review request for Ambari, Andrew Onischuk, Jonathan Hurley, Nate Cole, > Robert Nettleton, and Sid Wagle. > > > Bugs: AMBARI-22480 > https://issues.apache.org/jira/browse/AMBARI-22480 > > > Repository: ambari > > > Description > --- > > Blueprint validation should fail if LZO is enabled and GPL license is not > accepted on server setup. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java > 1c127c080cd33314e47bcfff63e0c1e6d58937bc > > ambari-server/src/main/java/org/apache/ambari/server/topology/Blueprint.java > c9dc7281a092ff9f22551c9f8fc64ebca15fda36 > > ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintImpl.java > 1d917e0940b1ba5988a740005017c9d228e46f96 > > ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidator.java > 206d161fc694f67ae982ef668c5057b4bacec59b > > ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java > 1aaa5ce66d1a5385018e4f29c92441e157c2be02 > > ambari-server/src/main/java/org/apache/ambari/server/topology/GPLLicenseNotAcceptedException.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintImplTest.java > fdbc0807788377f689e19200be9d6cdc2c992690 > > ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintValidatorImplTest.java > ea6bee314192f0665d4df652cf0c401e0218026f > > > Diff: https://reviews.apache.org/r/63955/diff/1/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Myroslav Papirkovskyy > >
Review Request 63957: Stack advisor should disallow lzo enable without accepting license agreement.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63957/ --- Review request for Ambari, Andrew Onischuk and Sid Wagle. Bugs: AMBARI-22484 https://issues.apache.org/jira/browse/AMBARI-22484 Repository: ambari Description --- If the user adds com.hadoop.compression.lzo.LzoCodec to core-site property io.compression.codec.lzo.class and the ambari.properties does not have the allow GPL software install flag, throw validation error Diffs - ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorRequest.java 64180e5039bdb74d3aaf25e140565c82a95a26c1 ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java 5440462b86cdcfafb1e9ab239dacfddee0b31b93 ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java b2a68d66d777f107fdc4f5576a691e8d25ec2c92 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackAdvisorResourceProvider.java dd32c6badb18c1a8c02b7093813cd92ccd2fc74c ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py c36a41f49b224a904368c7474f0f769348e65ae6 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ValidationResourceProviderTest.java cdbf2d782f86b2a30f54619c4e2a9165a020275c ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 9e0070458987ee490f3918fead5ef11d201c8612 Diff: https://reviews.apache.org/r/63957/diff/1/ Testing --- mvn clean test Thanks, Myroslav Papirkovskyy
Review Request 63955: Validate blueprint does not allow lzo enable without setup with license agreement.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63955/ --- Review request for Ambari, Andrew Onischuk, Robert Nettleton, and Sid Wagle. Bugs: AMBARI-22480 https://issues.apache.org/jira/browse/AMBARI-22480 Repository: ambari Description --- Blueprint validation should fail if LZO is enabled and GPL license is not accepted on server setup. Diffs - ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java 1c127c080cd33314e47bcfff63e0c1e6d58937bc ambari-server/src/main/java/org/apache/ambari/server/topology/Blueprint.java c9dc7281a092ff9f22551c9f8fc64ebca15fda36 ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintImpl.java 1d917e0940b1ba5988a740005017c9d228e46f96 ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidator.java 206d161fc694f67ae982ef668c5057b4bacec59b ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java 1aaa5ce66d1a5385018e4f29c92441e157c2be02 ambari-server/src/main/java/org/apache/ambari/server/topology/GPLLicenseNotAcceptedException.java PRE-CREATION ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintImplTest.java fdbc0807788377f689e19200be9d6cdc2c992690 ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintValidatorImplTest.java ea6bee314192f0665d4df652cf0c401e0218026f Diff: https://reviews.apache.org/r/63955/diff/1/ Testing --- mvn clean test Thanks, Myroslav Papirkovskyy
Re: Review Request 63051: Add service group dependencies
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63051/#review188696 --- ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceGroupKey.java Lines 33 (patched) <https://reviews.apache.org/r/63051/#comment265705> Duplicated annotation on setter should not be required. AFAIK only one is necessary, either on getter or on field. - Myroslav Papirkovskyy On Жов. 19, 2017, 5:58 після полудня, Vitalyi Brodetskyi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63051/ > --- > > (Updated Жов. 19, 2017, 5:58 після полудня) > > > Review request for Ambari, Jayush Luniya, Myroslav Papirkovskyy, and Swapan > Shridhar. > > > Bugs: AMBARI-22249 > https://issues.apache.org/jira/browse/AMBARI-22249 > > > Repository: ambari > > > Description > --- > > Add table servicegroupdependencies > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceGroupKey.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupRequest.java > 53c3d1e > > ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupResponse.java > 147650c > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceGroupResourceProvider.java > 2e935af > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceGroupEntity.java > 7f8facb > ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java > 8fd878e > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroup.java > 9850462 > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupFactory.java > 7146bdf > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupImpl.java > 735a946 > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java > fcc07b6 > > ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java > 0434728 > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b8c0a42 > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c56e486 > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 8917d48 > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f48bcd6 > ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql e7c5c72 > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql f87af4c > > > Diff: https://reviews.apache.org/r/63051/diff/5/ > > > Testing > --- > > Will fix tests after patch approve > > > Thanks, > > Vitalyi Brodetskyi > >
Re: Review Request 63051: Add service group dependencies
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63051/#review188496 --- ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupRequest.java Lines 29 (patched) <https://reviews.apache.org/r/63051/#comment265484> It will be nice to replace map with POJO: Something like Set will make whole patch easier to read and remove hardcoded key names. - Myroslav Papirkovskyy On Жов. 17, 2017, 11:38 після полудня, Vitalyi Brodetskyi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63051/ > --- > > (Updated Жов. 17, 2017, 11:38 після полудня) > > > Review request for Ambari, Jayush Luniya, Myroslav Papirkovskyy, and Swapan > Shridhar. > > > Bugs: AMBARI-22249 > https://issues.apache.org/jira/browse/AMBARI-22249 > > > Repository: ambari > > > Description > --- > > Add table servicegroupdependencies > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupRequest.java > 53c3d1e > > ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupResponse.java > 147650c > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceGroupResourceProvider.java > 2e935af > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceGroupEntity.java > 7f8facb > ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java > 8fd878e > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroup.java > 9850462 > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupFactory.java > 7146bdf > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupImpl.java > 735a946 > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java > fcc07b6 > > ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java > 0434728 > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b8c0a42 > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c56e486 > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 8917d48 > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f48bcd6 > ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql e7c5c72 > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql f87af4c > > > Diff: https://reviews.apache.org/r/63051/diff/2/ > > > Testing > --- > > Will fix tests after patch approve > > > Thanks, > > Vitalyi Brodetskyi > >
Re: Review Request 61582: Not able to start Yarn services after restoring the configs to initial value
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61582/#review183386
---
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Сер. 21, 2017, 11:48 після полудня, Vitalyi Brodetskyi wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61582/
> ---
>
> (Updated Сер. 21, 2017, 11:48 після полудня)
>
>
> Review request for Ambari, Myroslav Papirkovskyy, Sumit Mohanty, and Sid
> Wagle.
>
>
> Bugs: AMBARI-21173
> https://issues.apache.org/jira/browse/AMBARI-21173
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Change Yarn-site.xml to some custom configs and restart Yarn
> Restore it back to the origin config; Restart fails
> {Code}
> Traceback (most recent call last):
> File
> "/var/lib/ambari-agent/cache/common-services/YARN/3.0.0.3.0/package/scripts/nodemanager.py",
> line 106, in
> Nodemanager().execute()
> File
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
> line 330, in execute
> method(env)
> File
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
> line 835, in restart
> self.stop(env, upgrade_type=upgrade_type)
> File
> "/var/lib/ambari-agent/cache/common-services/YARN/3.0.0.3.0/package/scripts/nodemanager.py",
> line 45, in stop
> import params
> File
> "/var/lib/ambari-agent/cache/common-services/YARN/3.0.0.3.0/package/scripts/params.py",
> line 29, in
> from params_linux import *
> File
> "/var/lib/ambari-agent/cache/common-services/YARN/3.0.0.3.0/package/scripts/params_linux.py",
> line 39, in
> import status_params
> File
> "/var/lib/ambari-agent/cache/common-services/YARN/3.0.0.3.0/package/scripts/status_params.py",
> line 46, in
> yarn_pid_dir = format("{yarn_pid_dir_prefix}/{yarn_user}")
> File
> "/usr/lib/python2.6/site-packages/resource_management/libraries/functions/format.py",
> line 95, in format
> return ConfigurationFormatter().format(format_string, args, **result)
> File
> "/usr/lib/python2.6/site-packages/resource_management/libraries/functions/format.py",
> line 59, in format
> result_protected = self.vformat(format_string, args, all_params)
> File "/usr/lib64/python2.7/string.py", line 549, in vformat
> result = self._vformat(format_string, args, kwargs, used_args, 2)
> File "/usr/lib64/python2.7/string.py", line 582, in _vformat
> result.append(self.format_field(obj, format_spec))
> File "/usr/lib64/python2.7/string.py", line 599, in format_field
> return format(value, format_spec)
> File
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/config_dictionary.py",
> line 73, in __getattr__
> raise Fail("Configuration parameter '" + self.name + "' was not found in
> configurations dictionary!")
> resource_management.core.exceptions.Fail: Configuration parameter 'yarn-env'
> was not found in configurations dictionary!
> {Code}
>
>
> Diffs
> -
>
>
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
> 84b411c
>
>
> Diff: https://reviews.apache.org/r/61582/diff/4/
>
>
> Testing
> ---
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 60897: Add UID/GID related enhancements
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60897/#review180642 --- Ship it! Ship It! - Myroslav Papirkovskyy On Липень 16, 2017, 8:07 після полудня, Eugene Chekanskiy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60897/ > --- > > (Updated Липень 16, 2017, 8:07 після полудня) > > > Review request for Ambari, Aleksandr Kovalenko, Andrii Tkach, Dmitro > Lisnichenko, Robert Levas, and Vitalyi Brodetskyi. > > > Bugs: AMBARI-21483 > https://issues.apache.org/jira/browse/AMBARI-21483 > > > Repository: ambari > > > Description > --- > > Ability to change UID for ambari users. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java > 62396e3 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/files/changeToSecureUid.sh > 08542c4 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/shared_initialization.py > 39f5a47 > > ambari-server/src/test/python/stacks/2.0.6/hooks/before-ANY/test_before_any.py > 75c6543 > ambari-web/app/controllers/wizard/step7_controller.js 9a897d0 > ambari-web/app/mappers/configs/stack_config_properties_mapper.js 9b4b920 > ambari-web/app/styles/application.less 29788bc > > ambari-web/app/templates/wizard/controls_service_config_usergroup_with_id.hbs > PRE-CREATION > ambari-web/app/utils/config.js 00cc2a3 > ambari-web/app/views/common/configs/service_configs_by_category_view.js > 4058020 > ambari-web/app/views/common/controls_view.js edeaf0a > > > Diff: https://reviews.apache.org/r/60897/diff/1/ > > > Testing > --- > > mvn clean test, manual deploy > > > Thanks, > > Eugene Chekanskiy > >
Re: Review Request 60365: Config update API should not need to have a unique tag, BE can auto add the tag when it is missing
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60365/#review178985
---
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Червень 27, 2017, 7:08 після полудня, Vitalyi Brodetskyi wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60365/
> ---
>
> (Updated Червень 27, 2017, 7:08 після полудня)
>
>
> Review request for Ambari, Myroslav Papirkovskyy, Sumit Mohanty, and Sid
> Wagle.
>
>
> Bugs: AMBARI-21317
> https://issues.apache.org/jira/browse/AMBARI-21317
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Currently, a config update expects a tag value from the client calling the
> API. It should be optional and if not provided then BE should generate a
> unique tag and auto add.
>
> {code}
> [{"Clusters":{
> "desired_config":[{
> "type":"zoo.cfg",
> "tag":"version1495042583018",
> "properties":{...
> ...
> {code}
>
>
> Diffs
> -
>
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
> bb1c95e
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
> 6781f65
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/ConfigGroupResponse.java
> 58c680d
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java
> c2b998c
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigImpl.java
> 65b7863
>
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java
> c0e3ef1
>
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProviderTest.java
> 12cbadf
>
>
> Diff: https://reviews.apache.org/r/60365/diff/3/
>
>
> Testing
> ---
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 59684: Log more info about heartbeat message/response when server - agent communication gets out of sync
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59684/#review176456 --- Ship it! Ship It! - Myroslav Papirkovskyy On Травень 31, 2017, 4:49 після полудня, Sebastian Toader wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59684/ > --- > > (Updated Травень 31, 2017, 4:49 після полудня) > > > Review request for Ambari, Attila Doroszlai and Myroslav Papirkovskyy. > > > Bugs: AMBARI-21142 > https://issues.apache.org/jira/browse/AMBARI-21142 > > > Repository: ambari > > > Description > --- > > Currently if ambari server - agent communication gets out of sync only > limited information is logged . This makes difficult the troubleshooting of > the root cause also why the application can not recover from it. > > > Diffs > - > > ambari-agent/src/main/python/ambari_agent/Controller.py 83f1da8 > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java > 6b93462 > > > Diff: https://reviews.apache.org/r/59684/diff/1/ > > > Testing > --- > > Manual testing connection to server lost during heartbeat response processing > on agent side.: > > ambari-agent log: > ERROR 2017-05-31 09:45:52,778 Controller.py:469 - Connection to > ambari-server.node.dc1.consul was lost (details=Simulating connection loss on > heartbeat response !!!) > ... > INFO 2017-05-31 09:45:53,921 Controller.py:438 - Reconnected to > https://ambari-server.node.dc1.consul:8441/agent/v1/heartbeat/ambari-agent-1.node.dc1.consul > > ambari-server log: > 31 May 2017 09:45:53,918 WARN [qtp-ambari-agent-37] HeartBeatHandler:212 - > Old responseId=103 received form host ambari-agent-1.node.dc1.consul - > response was lost - returning cached response with responseId=104 > > > Unit tests: > > Agent: > Ran 452 tests in 30.156s > > OK > > [INFO] > > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Main SUCCESS [ 0.529 > s] > [INFO] Apache Ambari Project POM .. SUCCESS [ 0.004 > s] > [INFO] utility SUCCESS [ 2.002 > s] > [INFO] Ambari Agent ... SUCCESS [ 48.909 > s] > [INFO] > > [INFO] BUILD SUCCESS > > > Server: > Total run:1160 > Total errors:0 > Total failures:0 > OK > [INFO] > > [INFO] > > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Main SUCCESS [ 0.528 > s] > [INFO] Apache Ambari Project POM .. SUCCESS [ 0.003 > s] > [INFO] Ambari Views ... SUCCESS [ 2.305 > s] > [INFO] utility SUCCESS [ 1.066 > s] > [INFO] ambari-metrics . SUCCESS [ 0.298 > s] > [INFO] Ambari Metrics Common .. SUCCESS [ 4.904 > s] > [INFO] Ambari Server .. SUCCESS [48:33 > min] > [INFO] > > > > Thanks, > > Sebastian Toader > >
Re: Review Request 59627: Support CREATE/UPDATE/DELETE of topology, hashes and some events format changes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59627/#review176292 --- Ship it! Ship It! - Myroslav Papirkovskyy On Травень 29, 2017, 5:22 після полудня, Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59627/ > --- > > (Updated Травень 29, 2017, 5:22 після полудня) > > > Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and > Sumit Mohanty. > > > Bugs: AMBARI-21140 > https://issues.apache.org/jira/browse/AMBARI-21140 > > > Repository: ambari > > > Description > --- > > . > > > Diffs > - > > ambari-agent/src/main/python/ambari_agent/ClusterCache.py 4b88f71 > ambari-agent/src/main/python/ambari_agent/ClusterTopologyCache.py 0cfe5a4 > ambari-agent/src/main/python/ambari_agent/ComponentStatusExecutor.py > 6783138 > ambari-agent/src/main/python/ambari_agent/HeartbeatThread.py e88fee7 > ambari-agent/src/main/python/ambari_agent/Utils.py e48aa5f > > ambari-agent/src/main/python/ambari_agent/listeners/ConfigurationEventListener.py > 20b42e6 > > ambari-agent/src/main/python/ambari_agent/listeners/MetadataEventListener.py > c738ea2 > > ambari-agent/src/main/python/ambari_agent/listeners/TopologyEventListener.py > 61e89bd > ambari-agent/src/main/python/ambari_agent/listeners/__init__.py f05f8da > ambari-agent/src/main/python/ambari_agent/security.py df45699 > ambari-agent/src/test/python/ambari_agent/BaseStompServerTestCase.py > 7380727 > ambari-agent/src/test/python/ambari_agent/TestAgentStompResponses.py > 1f3a6e7 > > ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/configurations_update.json > cc1dda0 > > ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/metadata_after_registration.json > 14d7c04 > > ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/topology_add_component.json > PRE-CREATION > > ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/topology_add_component_host.json > PRE-CREATION > > ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/topology_add_host.json > PRE-CREATION > > ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/topology_cache_expected.json > PRE-CREATION > > ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/topology_create.json > PRE-CREATION > > ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/topology_delete_cluster.json > PRE-CREATION > > ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/topology_delete_component.json > PRE-CREATION > > ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/topology_delete_component_host.json > PRE-CREATION > > ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/topology_delete_host.json > PRE-CREATION > > ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/topology_update.json > b403e4d > > > Diff: https://reviews.apache.org/r/59627/diff/2/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
Re: Review Request 59367: Run execution commands sent to /user/commands
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59367/#review175483 --- Ship it! Ship It! - Myroslav Papirkovskyy On Травень 18, 2017, 4:58 після полудня, Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59367/ > --- > > (Updated Травень 18, 2017, 4:58 після полудня) > > > Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and > Sid Wagle. > > > Bugs: AMBARI-21056 > https://issues.apache.org/jira/browse/AMBARI-21056 > > > Repository: ambari > > > Description > --- > > . > > > Diffs > - > > ambari-agent/conf/unix/ambari-agent.ini 441a01d > ambari-agent/src/main/python/ambari_agent/ActionQueue.py 1eda5c2 > ambari-agent/src/main/python/ambari_agent/AmbariConfig.py fe48870 > ambari-agent/src/main/python/ambari_agent/CommandStatusDict.py 7a97f3f > ambari-agent/src/main/python/ambari_agent/CommandStatusReporter.py > PRE-CREATION > ambari-agent/src/main/python/ambari_agent/ComponentStatusExecutor.py > a3798c6 > ambari-agent/src/main/python/ambari_agent/Constants.py 3fbb485 > ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py > 8b8a8f9 > ambari-agent/src/main/python/ambari_agent/HeartbeatThread.py 57748a0 > ambari-agent/src/main/python/ambari_agent/InitializerModule.py e1b4ed7 > ambari-agent/src/main/python/ambari_agent/PythonExecutor.py ea6f895 > > ambari-agent/src/main/python/ambari_agent/listeners/CommandsEventListener.py > PRE-CREATION > > ambari-agent/src/main/python/ambari_agent/listeners/ConfigurationEventListener.py > 722ec3c > ambari-agent/src/main/python/ambari_agent/listeners/__init__.py 2b7e9bc > ambari-agent/src/main/python/ambari_agent/main.py 29eb926 > ambari-agent/src/test/python/ambari_agent/TestAgentStompResponses.py > cab8fe1 > > ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/execution_commands.json > bf54b97 > > > Diff: https://reviews.apache.org/r/59367/diff/2/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
Re: Review Request 58790: Create an ansynchronious status commands executor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58790/#review173185 --- Ship it! Ship It! - Myroslav Papirkovskyy On Квітень 27, 2017, 1:55 після полудня, Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58790/ > --- > > (Updated Квітень 27, 2017, 1:55 після полудня) > > > Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and > Sid Wagle. > > > Bugs: AMBARI-20830 > https://issues.apache.org/jira/browse/AMBARI-20830 > > > Repository: ambari > > > Description > --- > > status commands queue should be generated from the topology information > received from server and be maintained even if server goes down. > > > Diffs > - > > ambari-agent/src/main/python/ambari_agent/ClusterCache.py 4bd94ae > ambari-agent/src/main/python/ambari_agent/ComponentStatusExecutor.py > PRE-CREATION > ambari-agent/src/main/python/ambari_agent/Constants.py 50fac9e > ambari-agent/src/main/python/ambari_agent/HeartbeatThread.py 63674d5 > ambari-agent/src/main/python/ambari_agent/InitializerModule.py 76d14e5 > ambari-agent/src/main/python/ambari_agent/Utils.py 6e919c0 > ambari-agent/src/test/python/ambari_agent/TestAgentStompResponses.py > f5caa7b > > > Diff: https://reviews.apache.org/r/58790/diff/1/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
Re: Review Request 58656: Heartbeat and register with real server instead of mock server
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58656/#review172767 --- Ship it! Ship It! - Myroslav Papirkovskyy On Квітень 24, 2017, 10:23 до полудня, Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58656/ > --- > > (Updated Квітень 24, 2017, 10:23 до полудня) > > > Review request for Ambari and Myroslav Papirkovskyy. > > > Bugs: AMBARI-20828 > https://issues.apache.org/jira/browse/AMBARI-20828 > > > Repository: ambari > > > Description > --- > > > Diffs > - > > ambari-agent/src/main/python/ambari_agent/AmbariConfig.py cf48189 > ambari-agent/src/main/python/ambari_agent/ClusterCache.py f2ac8ed > ambari-agent/src/main/python/ambari_agent/Constants.py 9ad5f2e > ambari-agent/src/main/python/ambari_agent/HeartbeatThread.py b2469d2 > ambari-agent/src/main/python/ambari_agent/InitializerModule.py PRE-CREATION > ambari-agent/src/main/python/ambari_agent/Utils.py 8078ad2 > ambari-agent/src/main/python/ambari_agent/client_example.py 96e76be > ambari-agent/src/main/python/ambari_agent/security.py b1599be > ambari-agent/src/test/python/ambari_agent/BaseStompServerTestCase.py > 194002f > ambari-agent/src/test/python/ambari_agent/TestAgentStompResponses.py > d2a83ff > ambari-common/src/main/python/ambari_stomp/adapter/websocket.py 8416a27 > > > Diff: https://reviews.apache.org/r/58656/diff/1/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
Re: Review Request 58354: Handle caching of topologies, configs and metadata
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58354/#review171562 --- Ship it! Ship It! - Myroslav Papirkovskyy On Квітень 11, 2017, 5:04 після полудня, Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58354/ > --- > > (Updated Квітень 11, 2017, 5:04 після полудня) > > > Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and > Sid Wagle. > > > Bugs: AMBARI-20734 > https://issues.apache.org/jira/browse/AMBARI-20734 > > > Repository: ambari > > > Description > --- > > . > > > Diffs > - > > ambari-agent/src/main/python/ambari_agent/ClusterCache.py 1986733 > ambari-agent/src/main/python/ambari_agent/Constants.py 0ff9eb9 > ambari-agent/src/main/python/ambari_agent/Controller.py 4d81947 > ambari-agent/src/main/python/ambari_agent/HeartbeatThread.py 2c2f9d8 > > ambari-agent/src/main/python/ambari_agent/listeners/ConfigurationEventListener.py > PRE-CREATION > > ambari-agent/src/main/python/ambari_agent/listeners/MetadataEventListener.py > PRE-CREATION > > ambari-agent/src/main/python/ambari_agent/listeners/ServerResponsesListener.py > c7ad082 > > ambari-agent/src/main/python/ambari_agent/listeners/TopologyEventListener.py > 44afc48 > ambari-agent/src/main/python/ambari_agent/listeners/__init__.py 8cfcc3f > ambari-agent/src/main/python/ambari_agent/security.py 32ad556 > ambari-agent/src/test/python/ambari_agent/TestAgentStompResponses.py > b0f3a16 > > > Diff: https://reviews.apache.org/r/58354/diff/2/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
Re: Review Request 58297: Add stab registering and heartbeating routine via stomp async calls.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58297/#review171440 --- Ship it! Ship It! - Myroslav Papirkovskyy On Квітень 10, 2017, 4:35 після полудня, Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58297/ > --- > > (Updated Квітень 10, 2017, 4:35 після полудня) > > > Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and > Sid Wagle. > > > Bugs: AMBARI-20721 > https://issues.apache.org/jira/browse/AMBARI-20721 > > > Repository: ambari > > > Description > --- > > As for registering and heartbeat we still require synchronious behaviour on > agent side. This requires a dictionary with blocking pop with correlationId > as keys. > > > Diffs > - > > ambari-agent/src/main/python/ambari_agent/Constants.py 6b80f00 > ambari-agent/src/main/python/ambari_agent/HeartbeatThread.py PRE-CREATION > ambari-agent/src/main/python/ambari_agent/Utils.py e7b03f9 > > ambari-agent/src/main/python/ambari_agent/listeners/ServerResponsesListener.py > PRE-CREATION > > ambari-agent/src/main/python/ambari_agent/listeners/TopologyEventListener.py > PRE-CREATION > ambari-agent/src/main/python/ambari_agent/listeners/__init__.py > PRE-CREATION > ambari-agent/src/main/python/ambari_agent/security.py 45de7bb > ambari-agent/src/test/python/ambari_agent/TestAgentStompResponses.py > 983b392 > > ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/heartbeat_request.json > PRE-CREATION > > > Diff: https://reviews.apache.org/r/58297/diff/1/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
Re: Review Request 57954: Single process executor possibly can cause deadlock
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57954/#review170159 --- Ship it! Ship It! - Myroslav Papirkovskyy On Березень 27, 2017, 2:46 після полудня, Eugene Chekanskiy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57954/ > --- > > (Updated Березень 27, 2017, 2:46 після полудня) > > > Review request for Ambari, Attila Doroszlai, Andrew Onischuk, Dmytro Sen, > Robert Levas, and Sid Wagle. > > > Bugs: AMBARI-20582 > https://issues.apache.org/jira/browse/AMBARI-20582 > > > Repository: ambari > > > Description > --- > > multimple readers of queue can cause deadlock while using empty()+get(True) > > > Diffs > - > > ambari-agent/src/main/python/ambari_agent/StatusCommandsExecutor.py eaa24c2 > > > Diff: https://reviews.apache.org/r/57954/diff/1/ > > > Testing > --- > > mvn clean test, manual test > > > Thanks, > > Eugene Chekanskiy > >
Re: Review Request 57910: Create a base class for caching in ambari-agent.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57910/#review170151 --- Ship it! Ship It! - Myroslav Papirkovskyy On Березень 27, 2017, 1:32 після полудня, Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57910/ > --- > > (Updated Березень 27, 2017, 1:32 після полудня) > > > Review request for Ambari, Myroslav Papirkovskyy, Sumit Mohanty, and Sid > Wagle. > > > Bugs: AMBARI-20559 > https://issues.apache.org/jira/browse/AMBARI-20559 > > > Repository: ambari > > > Description > --- > > The class should be: > 1\. Thread-safe > 2\. Support caching for multiple clusters > 3\. Write cache to json file for debug purposes. > > In next jiras the class with be derived by ClusterConfigurationCache, > ClusterTopologyCache and ClusterComponentsStatusCache. > > We have already a caching class for alerts. The jira should also rewrite it to > use the base class. > > > Diffs > - > > ambari-agent/src/main/python/ambari_agent/ClusterCache.py PRE-CREATION > ambari-agent/src/main/python/ambari_agent/ClusterConfiguration.py 72b87be > ambari-agent/src/main/python/ambari_agent/ClusterConfigurationCache.py > PRE-CREATION > ambari-agent/src/main/python/ambari_agent/Controller.py 78b5c0c > ambari-agent/src/main/python/ambari_agent/FileCache.py d0c8bdb > ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py 7f3b2a5 > ambari-agent/src/test/python/ambari_agent/TestAlerts.py 64479a2 > ambari-agent/src/test/python/ambari_agent/TestClusterConfigurationCache.py > a418f6d > > > Diff: https://reviews.apache.org/r/57910/diff/5/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
Re: Review Request 56573: Increase default timeout for RM
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56573/#review165249 --- Ship it! Ship It! - Myroslav Papirkovskyy On Лют. 11, 2017, 5:38 після полудня, Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56573/ > --- > > (Updated Лют. 11, 2017, 5:38 після полудня) > > > Review request for Ambari and Dmitro Lisnichenko. > > > Bugs: AMBARI-19977 > https://issues.apache.org/jira/browse/AMBARI-19977 > > > Repository: ambari > > > Description > --- > > > Diffs > - > > > ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/configuration/yarn-site.xml > fcd9380 > > Diff: https://reviews.apache.org/r/56573/diff/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
Re: Review Request 56412: HDP 3.0 TP - Support changed configs and scripts for YARN/MR
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56412/#review164986 --- Ship it! Ship It! - Myroslav Papirkovskyy On Лют. 8, 2017, 1:03 до полудня, Alejandro Fernandez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56412/ > --- > > (Updated Лют. 8, 2017, 1:03 до полудня) > > > Review request for Ambari, Dmytro Sen, Sumit Mohanty, Sid Wagle, and Vitalyi > Brodetskyi. > > > Bugs: AMBARI-19831 > https://issues.apache.org/jira/browse/AMBARI-19831 > > > Repository: ambari > > > Description > --- > > In HDP 3.0, there are expected changes to configs and the startup scripts for > YARN/MR. > > For now, the name of the pid file changed, keep ATS v1.5, and the mapreduce > shuffle class until Spark is ready. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/configuration/core-site.xml > 20b1930 > > ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/configuration/hadoop-env.xml > 3e7388e > > ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/configuration/hadoop-metrics2.properties.xml > 6b45e84 > > ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/configuration/hadoop-policy.xml > 8e9486d > > ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/configuration/hdfs-log4j.xml > 35554e6 > > ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/configuration/hdfs-logsearch-conf.xml > d85a028 > > ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/configuration/hdfs-site.xml > 60fde60 > > ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/configuration/ssl-client.xml > 6ec064a > > ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/configuration/ssl-server.xml > 5d2745f > > ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/configuration-mapred/mapred-env.xml > 2ac0bff > > ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/configuration-mapred/mapred-logsearch-conf.xml > 3c0abbf > > ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/configuration-mapred/mapred-site.xml > e51107a > > ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/configuration/yarn-env.xml > 3bf5bcb > > ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/configuration/yarn-log4j.xml > 8d205f8 > > ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/configuration/yarn-logsearch-conf.xml > 95cf0c9 > > ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/configuration/yarn-site.xml > 4f30cb9 > > ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/metainfo.xml > 14eae07 > > ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/package/scripts/status_params.py > c2e9d92 > > Diff: https://reviews.apache.org/r/56412/diff/ > > > Testing > --- > > Verified on live cluster. > > Python unit tests passed. > -- > Total run:1182 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Alejandro Fernandez > >
Re: Review Request 56407: Upgrade: Package Install stuck in "Installing" state forever
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56407/#review164697 --- Ship it! Ship It! - Myroslav Papirkovskyy On Лют. 8, 2017, 12:08 після полудня, Sebastian Toader wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56407/ > --- > > (Updated Лют. 8, 2017, 12:08 після полудня) > > > Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, Sandor > Magyari, and Sid Wagle. > > > Bugs: AMBARI-19904 > https://issues.apache.org/jira/browse/AMBARI-19904 > > > Repository: ambari > > > Description > --- > > When a command fails the all the other pending commands that belong to the > same request are aborted. In order the cluster state to be correctly > reflected the cluster state has to be recalculated for each aborted command > from all stages of the request. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessor.java > 8aef70d > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java > 7837a7b > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java > dabcb98 > > ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java > ade625a > > Diff: https://reviews.apache.org/r/56407/diff/ > > > Testing > --- > > Manually tested the upgrading of HDP 2.4 to HDP 2.5 with "install_packages" > command failing on at least one agent. > > Unit testing: > mvn test -DskipPythonTests -am -pl ambari-server > > Results : > > Tests run: 4906, Failures: 0, Errors: 0, Skipped: 39 > > > Thanks, > > Sebastian Toader > >
Re: Review Request 56143: Perf: start/stop all actions works much slower after few days of testing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56143/#review163737 --- Ship it! Ship It! - Myroslav Papirkovskyy On Лют. 1, 2017, 1:32 до полудня, Vitalyi Brodetskyi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56143/ > --- > > (Updated Лют. 1, 2017, 1:32 до полудня) > > > Review request for Ambari and Myroslav Papirkovskyy. > > > Bugs: AMBARI-19755 > https://issues.apache.org/jira/browse/AMBARI-19755 > > > Repository: ambari > > > Description > --- > > Fix for "get non existing component from service" fail. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java > 5da8012 > > Diff: https://reviews.apache.org/r/56143/diff/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Vitalyi Brodetskyi > >
Re: Review Request 55989: Perf: start/stop all actions works much slower after few days of testing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55989/#review163663 --- Ship it! Ship It! - Myroslav Papirkovskyy On Січ. 31, 2017, 2:45 після полудня, Vitalyi Brodetskyi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55989/ > --- > > (Updated Січ. 31, 2017, 2:45 після полудня) > > > Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and > Sid Wagle. > > > Repository: ambari > > > Description > --- > > I've deployed cluster with 3000 agents and started my little test script on > it. Script is doing only three actions in loop: 1) Stop All services 2) Start > All services 3) Update zk config. > After few days of work these actions need much more time to be executed. For > example before stop/start all actions took near 7-8 minutes. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java > c53a73d > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java > 93f4a8f > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 0fce72b > > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java > d304bb3 > ambari-server/src/main/java/org/apache/ambari/server/state/Host.java > 04b2104 > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java > 0381e38 > > ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java > 3c7b040 > > ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java > 1bcffe4 > > Diff: https://reviews.apache.org/r/55989/diff/ > > > Testing > --- > > > Thanks, > > Vitalyi Brodetskyi > >
Re: Review Request 55851: Dangling config-group hostmapping entries result in partial loading of config groups
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55851/#review162672
---
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Січ. 23, 2017, 8:36 після полудня, Sid Wagle wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55851/
> ---
>
> (Updated Січ. 23, 2017, 8:36 після полудня)
>
>
> Review request for Ambari, Myroslav Papirkovskyy and Sumit Mohanty.
>
>
> Bugs: AMBARI-19679
> https://issues.apache.org/jira/browse/AMBARI-19679
>
>
> Repository: ambari
>
>
> Description
> ---
>
> _Scenario_:
> ConfigGroups with host mapping to hosts that no longer exist.
> This results in an NPE during lookup from the in-memory Cluster Map.
> {code}
> Host host = clusters.getHost(hostMappingEntity.getHostname());
> {code}
> This is swallowed by the Guice assisted injector leading to partial loading
> of the data from DB.
>
>
> Diffs
> -
>
>
> ambari-server/src/main/java/org/apache/ambari/server/state/configgroup/ConfigGroupImpl.java
> fe1f338
>
> Diff: https://reviews.apache.org/r/55851/diff/
>
>
> Testing
> ---
>
> Manually tested.
>
>
> Thanks,
>
> Sid Wagle
>
>
Re: Review Request 55675: ambari-server setup failed
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55675/#review162093
---
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Січ. 18, 2017, 3:56 після полудня, Vitalyi Brodetskyi wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55675/
> ---
>
> (Updated Січ. 18, 2017, 3:56 після полудня)
>
>
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Myroslav
> Papirkovskyy.
>
>
> Bugs: AMBARI-19612
> https://issues.apache.org/jira/browse/AMBARI-19612
>
>
> Repository: ambari
>
>
> Description
> ---
>
> ambari-server setup failed
> found this issue in logs
> {noformat}
> sing python /usr/bin/python
> Setup ambari-server
> Checking SELinux...
> WARNING: Could not run /usr/sbin/sestatus: OK
> Customize user account for ambari-server daemon [y/n] (n)? Adjusting
> ambari-server permissions and ownership...
> Checking firewall status...
> Checking JDK...
> Do you want to change Oracle JDK [y/n] (n)? input not recognized, please try
> again:
> Do you want to change Oracle JDK [y/n] (n)? Completing setup...
> Configuring database...
> Enter advanced database configuration [y/n] (n)? Configuring database...
> Default properties detected. Using built-in database.
> Configuring ambari database...
> Checking PostgreSQL...
> Configuring local database...
> Configuring PostgreSQL...
> Backup for pg_hba found, reconfiguration not required
> Creating schema and user...
> ERROR: Failed to execute command:['ambari-sudo.sh', 'su', 'postgres', '-',
> '--command=psql -f
> /var/lib/ambari-server/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql -v
> username=\'"ambari"\' -v password="\'bigdata\'" -v dbname="ambari"']
> ERROR: stderr:could not change directory to "/root"
> psql: could not connect to server: No such file or directory
> Is the server running locally and accepting
> connections on Unix domain socket "/var/run/postgresql/.s.PGSQL.5432"?
>
> ERROR: stdout:
> process_pid=28571
>
> failed to execute queries ...retrying (1)
> Creating schema and user...
> ERROR: Failed to execute command:['ambari-sudo.sh', 'su', 'postgres', '-',
> '--command=psql -f
> /var/lib/ambari-server/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql -v
> username=\'"ambari"\' -v password="\'bigdata\'" -v dbname="ambari"']
> ERROR: stderr:could not change directory to "/root"
> psql: could not connect to server: No such file or directory
> Is the server running locally and accepting
> connections on Unix domain socket "/var/run/postgresql/.s.PGSQL.5432"?
>
> ERROR: stdout:
> process_pid=28580
>
> failed to execute queries ...retrying (2)
> Creating schema and user...
> ERROR: Exiting with exit code 2.
> REASON: Running database init script failed. Exiting.{noformat}
> The same result when try to do it manually
>
>
> Diffs
> -
>
> ambari-common/src/main/python/ambari_commons/os_linux.py 25368c6
>
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
> 9459d93
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java
> 1a05b95
>
> Diff: https://reviews.apache.org/r/55675/diff/
>
>
> Testing
> ---
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 55422: Oozie Restart is not prompted on changing core-site.xml
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55422/#review161220 --- Ship it! Ship It! - Myroslav Papirkovskyy On Січ. 11, 2017, 2:44 після полудня, Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55422/ > --- > > (Updated Січ. 11, 2017, 2:44 після полудня) > > > Review request for Ambari and Vitalyi Brodetskyi. > > > Bugs: AMBARI-19463 > https://issues.apache.org/jira/browse/AMBARI-19463 > > > Repository: ambari > > > Description > --- > > Cluster Machines. > <https://github.com/hortonworks/HCube/blob/master/README.md#winchester-hdp-26> > > Ambari: <http://hcube2-1n01.eng.hortonworks.com:8080/> > > After changing core-site.xml from Ambari, oozie restart is not prompted. > Attached is the screenshot. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.3/metainfo.xml > 4d46d74 > ambari-server/src/main/resources/stacks/HDP/2.1/services/OOZIE/metainfo.xml > eab7ae0 > > Diff: https://reviews.apache.org/r/55422/diff/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
Re: Review Request 55266: dfs.exclude file doesn't exist when deploying cluster with NN HA + kerberos via BP
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55266/#review160720 --- Ship it! Ship It! - Myroslav Papirkovskyy On Січ. 6, 2017, 4:19 після полудня, Vitalyi Brodetskyi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55266/ > --- > > (Updated Січ. 6, 2017, 4:19 після полудня) > > > Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Dmytro > Sen. > > > Bugs: AMBARI-19402 > https://issues.apache.org/jira/browse/AMBARI-19402 > > > Repository: ambari > > > Description > --- > > 16/12/29 07:59:16 ERROR blockmanagement.DatanodeManager: error reading hosts > files: > java.io.FileNotFoundException: /etc/hadoop/conf/dfs.exclude (No such file or > directory) > at java.io.FileInputStream.open0(Native Method) > at java.io.FileInputStream.open(FileInputStream.java:195) > at java.io.FileInputStream.(FileInputStream.java:138) > at > org.apache.hadoop.util.HostsFileReader.readFileToSet(HostsFileReader.java:66) > at > org.apache.hadoop.hdfs.server.blockmanagement.HostFileManager.readFile(HostFileManager.java:72) > at > org.apache.hadoop.hdfs.server.blockmanagement.HostFileManager.refresh(HostFileManager.java:138) > at > org.apache.hadoop.hdfs.server.blockmanagement.DatanodeManager.(DatanodeManager.java:205) > at > org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.(BlockManager.java:304) > at > org.apache.hadoop.hdfs.server.namenode.FSNamesystem.(FSNamesystem.java:747) > at > org.apache.hadoop.hdfs.server.namenode.FSNamesystem.(FSNamesystem.java:707) > at org.apache.hadoop.hdfs.server.namenode.NameNode.format(NameNode.java:1166) > at > org.apache.hadoop.hdfs.server.namenode.NameNode.createNameNode(NameNode.java:1616) > at org.apache.hadoop.hdfs.server.namenode.NameNode.main(NameNode.java:1754) > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py > 23119f0 > ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py c186af6 > > Diff: https://reviews.apache.org/r/55266/diff/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Vitalyi Brodetskyi > >
Re: Review Request 53030: Ambari upgrade failed while running 'Alter Table blueprint' - blueprint_name column
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53030/#review153379
---
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Жов. 19, 2016, 10:17 після полудня, Vitalyi Brodetskyi wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53030/
> ---
>
> (Updated Жов. 19, 2016, 10:17 після полудня)
>
>
> Review request for Ambari, Myroslav Papirkovskyy, Sumit Mohanty, and Sid
> Wagle.
>
>
> Bugs: AMBARI-18640
> https://issues.apache.org/jira/browse/AMBARI-18640
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Observed errors in today's run during Ambari upgrade from 2.2.1.1 to
> 2.4.2.0-36
> ambari-server --hash
> c6da6776f029f15d3a7d6009697371eee4e5f4c5
>
> Ambari DB - MySQL; Secure HDP-2.4.0.0 cluster deployed via UI
>
> *Upgrade Log indicates below:*
> {code}
> 18 Oct 2016 14:17:59,115 INFO [main] DBAccessorImpl:824 - Executing query:
> ALTER TABLE users MODIFY user_name VARCHAR(100)
> 18 Oct 2016 14:17:59,154 INFO [main] DBAccessorImpl:824 - Executing query:
> ALTER TABLE users MODIFY user_name VARCHAR(100) NOT NULL
> 18 Oct 2016 14:17:59,191 INFO [main] DBAccessorImpl:824 - Executing query:
> ALTER TABLE host_role_command MODIFY role VARCHAR(100)
> 18 Oct 2016 14:17:59,428 INFO [main] DBAccessorImpl:824 - Executing query:
> ALTER TABLE host_role_command MODIFY status VARCHAR(100)
> 18 Oct 2016 14:17:59,656 INFO [main] DBAccessorImpl:824 - Executing query:
> ALTER TABLE blueprint MODIFY blueprint_name VARCHAR(100)
> 18 Oct 2016 14:17:59,678 ERROR [main] DBAccessorImpl:830 - Error executing
> query: ALTER TABLE blueprint MODIFY blueprint_name VARCHAR(100)
> java.sql.SQLException: Cannot change column 'blueprint_name': used in a
> foreign key constraint 'FK_blueprint_setting_name' of table
> 'ambaricustom.blueprint_setting'
> at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:996)
> at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:3887)
> at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:3823)
> at com.mysql.jdbc.MysqlIO.sendCommand(MysqlIO.java:2435)
> at com.mysql.jdbc.MysqlIO.sqlQueryDirect(MysqlIO.java:2582)
> at com.mysql.jdbc.ConnectionImpl.execSQL(ConnectionImpl.java:2526)
> at com.mysql.jdbc.ConnectionImpl.execSQL(ConnectionImpl.java:2484)
> at com.mysql.jdbc.StatementImpl.execute(StatementImpl.java:848)
> at com.mysql.jdbc.StatementImpl.execute(StatementImpl.java:742)
> at
> org.apache.ambari.server.orm.DBAccessorImpl.executeQuery(DBAccessorImpl.java:827)
> at
> org.apache.ambari.server.orm.DBAccessorImpl.executeQuery(DBAccessorImpl.java:819)
> at
> org.apache.ambari.server.orm.DBAccessorImpl.alterColumn(DBAccessorImpl.java:610)
> at
> org.apache.ambari.server.upgrade.UpgradeCatalog242.updateTablesForMysql(UpgradeCatalog242.java:120)
> at
> org.apache.ambari.server.upgrade.UpgradeCatalog242.executeDDLUpdates(UpgradeCatalog242.java:95)
> at
> org.apache.ambari.server.upgrade.AbstractUpgradeCatalog.upgradeSchema(AbstractUpgradeCatalog.java:889)
> at
> org.apache.ambari.server.upgrade.SchemaUpgradeHelper.executeUpgrade(SchemaUpgradeHelper.java:206)
> at
> org.apache.ambari.server.upgrade.SchemaUpgradeHelper.main(SchemaUpgradeHelper.java:349)
> 18 Oct 2016 14:17:59,680 ERROR [main] SchemaUpgradeHelper:208 - Upgrade
> failed.
> java.sql.SQLException: Cannot change column 'blueprint_name': used in a
> foreign key constraint 'FK_blueprint_setting_name' of table
> 'ambaricustom.blueprint_setting'
> at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:996)
> at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:3887)
> at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:3823)
> at com.mysql.jdbc.MysqlIO.sendCommand(MysqlIO.java:2435)
> at com.mysql.jdbc.MysqlIO.sqlQueryDirect(MysqlIO.java:2582)
> at com.mysql.jdbc.ConnectionImpl.execSQL(ConnectionImpl.java:2526)
> at com.mysql.jdbc.ConnectionImpl.execSQL(ConnectionImpl.java:2484)
> at com.mysql.jdbc.StatementImpl.execute(StatementImpl.java:848)
>
> {code}
>
>
> Diffs
> -
>
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog242.java
> 6fa3e68
>
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog242Test.java
> 81f8451
>
> Diff: https://reviews.apache.org/r/53030/diff/
>
>
> Testing
> ---
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 52791: Getting errors with max length 1000byte, when using Mysql db with charset UTF8
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52791/#review152481 --- Ship it! Ship It! - Myroslav Papirkovskyy On Жов. 12, 2016, 8:41 після полудня, Vitalyi Brodetskyi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52791/ > --- > > (Updated Жов. 12, 2016, 8:41 після полудня) > > > Review request for Ambari, Jonathan Hurley, Myroslav Papirkovskyy, and Sumit > Mohanty. > > > Bugs: AMBARI-18532 > https://issues.apache.org/jira/browse/AMBARI-18532 > > > Repository: ambari > > > Description > --- > > Add related code to UpgradeCatalog. And change all blueprint_name fields to > varchar(100). > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java > ebfb267 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog242.java > PRE-CREATION > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql f84129c > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog242Test.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/52791/diff/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Vitalyi Brodetskyi > >
Re: Review Request 52692: Ambari startup script doesn't work on SUSE and potentially other OS's.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52692/#review151978 --- Ship it! Ship It! - Myroslav Papirkovskyy On Жов. 10, 2016, 5:20 після полудня, Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52692/ > --- > > (Updated Жов. 10, 2016, 5:20 після полудня) > > > Review request for Ambari and Vitalyi Brodetskyi. > > > Bugs: AMBARI-18563 > https://issues.apache.org/jira/browse/AMBARI-18563 > > > Repository: ambari > > > Description > --- > > Since installing the new 2.4.0.1 on SLES 11 the ambari startup script doesn't > work on server boot or reboot. It seems to be the SED line called in the > ambari startup script that doesn't account for a directory structure of > /etc/init.d/rc3.d to populate $ROOT. > > > Diffs > - > > ambari-server/conf/unix/install-helper.sh 229e146 > ambari-server/sbin/ambari-server 64f1c8c > > Diff: https://reviews.apache.org/r/52692/diff/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
Re: Review Request 52532: blueprint_setting table incorrectly defines blueprint_name column in DDL for MySQL
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52532/#review151487
---
Please test changes with different default encodings for MySQL. Theres limit
for complex key size in bytes, but in varchar length depends on encoding.
- Myroslav Papirkovskyy
On Жов. 5, 2016, 1:40 до полудня, Vitalyi Brodetskyi wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52532/
> ---
>
> (Updated Жов. 5, 2016, 1:40 до полудня)
>
>
> Review request for Ambari, Alejandro Fernandez, Robert Levas, Sumit Mohanty,
> and Sid Wagle.
>
>
> Bugs: AMBARI-18532
> https://issues.apache.org/jira/browse/AMBARI-18532
>
>
> Repository: ambari
>
>
> Description
> ---
>
> blueprint_setting table incorrectly defines blueprint_name column in DDL for
> MySQL:
>
> {code:title=Current Definition}
> CREATE TABLE blueprint_setting (
> id BIGINT NOT NULL,
> blueprint_name VARCHAR(100) NOT NULL,
> setting_name VARCHAR(100) NOT NULL,
> setting_data MEDIUMTEXT NOT NULL,
> CONSTRAINT PK_blueprint_setting PRIMARY KEY (id),
> CONSTRAINT UQ_blueprint_setting_name UNIQUE(blueprint_name,setting_name),
> CONSTRAINT FK_blueprint_setting_name FOREIGN KEY (blueprint_name)
> REFERENCES blueprint(blueprint_name));
> {code}
>
> {code:title=Correct Definition}
> CREATE TABLE blueprint_setting (
> id BIGINT NOT NULL,
> blueprint_name VARCHAR(255) NOT NULL,
> setting_name VARCHAR(100) NOT NULL,
> setting_data MEDIUMTEXT NOT NULL,
> CONSTRAINT PK_blueprint_setting PRIMARY KEY (id),
> CONSTRAINT UQ_blueprint_setting_name UNIQUE(blueprint_name,setting_name),
> CONSTRAINT FK_blueprint_setting_name FOREIGN KEY (blueprint_name)
> REFERENCES blueprint(blueprint_name));
> {code}
>
> This will cause errors when creating the table while MySQL sets up the
> foreign key constraint due to the column mismatch.
>
>
> Diffs
> -
>
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java
> ebfb267
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog242.java
> PRE-CREATION
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql e8a2569
>
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog242Test.java
> PRE-CREATION
>
> Diff: https://reviews.apache.org/r/52532/diff/
>
>
> Testing
> ---
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 50195: Oozie Server Start is failed after upgrade from 2.2.2.0 to 2.4.0.0
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50195/#review142772
---
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Липень 19, 2016, 8:38 після полудня, Dmitro Lisnichenko wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50195/
> ---
>
> (Updated Липень 19, 2016, 8:38 після полудня)
>
>
> Review request for Ambari, Dmytro Sen and Myroslav Papirkovskyy.
>
>
> Bugs: AMBARI-17794
> https://issues.apache.org/jira/browse/AMBARI-17794
>
>
> Repository: ambari
>
>
> Description
> ---
>
> STR:
> 1) Install old version
> 2) Enable distributed mode for AMS
> 3) Make ambari only upgrade
>
> Actual result:
> Oozie Server Start is failed after upgrade from 2.2.2.0 to 2.4.0.0
> {code}
> stderr: /var/lib/ambari-agent/data/errors-2079.txt
>
> Traceback (most recent call last):
> File
> "/var/lib/ambari-agent/cache/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py",
> line 215, in
> OozieServer().execute()
> File
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
> line 280, in execute
> method(env)
> File
> "/var/lib/ambari-agent/cache/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py",
> line 95, in start
> oozie_service(action='start', upgrade_type=upgrade_type)
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_family_impl.py",
> line 89, in thunk
> return fn(*args, **kwargs)
> File
> "/var/lib/ambari-agent/cache/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_service.py",
> line 96, in oozie_service
> os.chmod(params.check_db_connection_jar, 0o755)
> OSError: [Errno 1] Operation not permitted:
> '/usr/lib/ambari-agent/DBConnectionVerification.jar'
> {code}
>
>
> Diffs
> -
>
>
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_service.py
> 0713c97
>
> Diff: https://reviews.apache.org/r/50195/diff/
>
>
> Testing
> ---
>
> mvn clean test
>
> checking on live cluster
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 49891: Restart indicator is not shown after modifying the configs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49891/#review142542 --- Ship it! Ship It! - Myroslav Papirkovskyy On Липень 15, 2016, 1:26 після полудня, Dmitro Lisnichenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49891/ > --- > > (Updated Липень 15, 2016, 1:26 після полудня) > > > Review request for Ambari, Andrew Onischuk, Jonathan Hurley, Myroslav > Papirkovskyy, and Sid Wagle. > > > Bugs: AMBARI-17651 > https://issues.apache.org/jira/browse/AMBARI-17651 > > > Repository: ambari > > > Description > --- > > Restart indicator is not shown after modifying the configs. > Test case modified the hdfs config 'Namenode new generation size'. But still > after saving the configuration, restart icon is not shown. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/annotations/TransactionalLock.java > 5934f5a > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java > 94a8fe0 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java > d4e3828 > > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java > 46a3f3e > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigImpl.java > 92ec843 > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java > fdb997b > > ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java > 666111b > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProviderTest.java > dc8017a > > ambari-server/src/test/java/org/apache/ambari/server/state/ConfigHelperTest.java > 0ff143c > > Diff: https://reviews.apache.org/r/49891/diff/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Dmitro Lisnichenko > >
Re: Review Request 49884: Nodemanager is not started after installation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49884/#review141652 --- Ship it! Ship It! - Myroslav Papirkovskyy On Липень 11, 2016, 12:26 після полудня, Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49884/ > --- > > (Updated Липень 11, 2016, 12:26 після полудня) > > > Review request for Ambari and Myroslav Papirkovskyy. > > > Bugs: AMBARI-17646 > https://issues.apache.org/jira/browse/AMBARI-17646 > > > Repository: ambari > > > Description > --- > > Nodemanager is down on one of the nodes after installation. This has impacted > most of the splits in todays run (ambari-2.4.0.0-817). > Nodemanager is found be down on one of the nodes in 3 node cluster and its > running on other two nodes. > Live cluster is available here <https://172.22.66.85:8443/> and is alive for > another 24hrs > > Below error is seen in nodemanager.log : > > 2016-07-10 04:40:59,678 INFO recovery.NMLeveldbStateStoreService > (NMLeveldbStateStoreService.java:checkVersion(1022)) - Loaded NM state version > info 1.0 > 2016-07-10 04:40:59,889 WARN nodemanager.LinuxContainerExecutor > (LinuxContainerExecutor.java:init(195)) - Exit code from container executor > initialization is : 24 > ExitCodeException exitCode=24: File /etc/hadoop/2.4.2.0-258/0 must be owned by > root, but is owned by 2530 > > at org.apache.hadoop.util.Shell.runCommand(Shell.java:576) > at org.apache.hadoop.util.Shell.run(Shell.java:487) > at org.apache.hadoop.util.Shell$ShellCommandExecutor.execute(Shell.java:753) > at org.apache.hadoop.yarn.server.nodemanager.LinuxContainerExecutor.init(Linux > ContainerExecutor.java:192) > at org.apache.hadoop.yarn.server.nodemanager.NodeManager.serviceInit(NodeManag > er.java:236) > at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163) > at org.apache.hadoop.yarn.server.nodemanager.NodeManager.initAndStartNodeManag > er(NodeManager.java:547) > at org.apache.hadoop.yarn.server.nodemanager.NodeManager.main(NodeManager.java > :595) > 2016-07-10 04:40:59,893 INFO nodemanager.ContainerExecutor > (ContainerExecutor.java:logOutput(322)) - > 2016-07-10 04:40:59,893 INFO service.AbstractService > (AbstractService.java:noteFailure(272)) - Service NodeManager failed in state > INITED; cause: org.apache.hadoop.yarn.exceptions.YarnRuntimeException: Failed > to initialize container executor > org.apache.hadoop.yarn.exceptions.YarnRuntimeException: Failed to initialize > container executor > at org.apache.hadoop.yarn.server.nodemanager.NodeManager.serviceInit(NodeManag > er.java:238) > at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163) > at org.apache.hadoop.yarn.server.nodemanager.NodeManager.initAndStartNodeManag > er(NodeManager.java:547) > at org.apache.hadoop.yarn.server.nodemanager.NodeManager.main(NodeManager.java > :595) > Caused by: java.io.IOException: Linux container executor not configured > properly (error=24) > at org.apache.hadoop.yarn.server.nodemanager.LinuxContainerExecutor.init(Linux > ContainerExecutor.java:198) > at org.apache.hadoop.yarn.server.nodemanager.NodeManager.serviceInit(NodeManag > er.java:236) > ... 3 more > Caused by: ExitCodeException exitCode=24: File /etc/hadoop/2.4.2.0-258/0 must > be owned by root, but is owned by 2530 > > at org.apache.hadoop.util.Shell.runCommand(Shell.java:576) > at org.apache.hadoop.util.Shell.run(Shell.java:487) > at org.apache.hadoop.util.Shell$ShellCommandExecutor.execute(Shell.java:753) > at org.apache.hadoop.yarn.server.nodemanager.LinuxContainerExecutor.init(Linux > ContainerExecutor.java:192) > ... 4 more > 2016-07-10 04:40:59,895 FATAL nodemanager.NodeManager > (NodeManager.java:initAndStartNodeManager(550)) - Error starting NodeManager > org.apache.hadoop.yarn.exceptions.YarnRuntimeException: Failed to initialize > container executor > at org.apache.hadoop.yarn.server.nodemanager.NodeManager.serviceInit(NodeManag > er.java:238) > at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163) > at org.apache.hadoop.yarn.server.nodemanager.NodeManager.initAndStartNodeManag > er(NodeManager.java:547) > at org.apache.hadoop.yarn.server.nodemanager.NodeManager.main(NodeManager.java > :595) > Caused by: java.io.IOException: Linux container executor not configured > properly (error=24) > at org
Re: Review Request 49867: UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 with Ubuntu 16 & JDK 8
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49867/#review141610 --- Ship it! Ship It! - Myroslav Papirkovskyy On Липень 10, 2016, 3:23 після полудня, Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49867/ > --- > > (Updated Липень 10, 2016, 3:23 після полудня) > > > Review request for Ambari and Myroslav Papirkovskyy. > > > Bugs: AMBARI-17643 > https://issues.apache.org/jira/browse/AMBARI-17643 > > > Repository: ambari > > > Description > --- > > > Diffs > - > > ambari-common/src/main/python/resource_management/core/environment.py > 1efd89e > > Diff: https://reviews.apache.org/r/49867/diff/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
Re: Review Request 49805: Ambari server schema upgrade failed from 2.1.1 with ORA-12516 error
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49805/#review141273 --- Ship it! Ship It! - Myroslav Papirkovskyy On Липень 8, 2016, 2:25 після полудня, Dmytro Sen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49805/ > --- > > (Updated Липень 8, 2016, 2:25 після полудня) > > > Review request for Ambari, Dmitro Lisnichenko, Myroslav Papirkovskyy, and > Vitalyi Brodetskyi. > > > Bugs: AMBARI-17622 > https://issues.apache.org/jira/browse/AMBARI-17622 > > > Repository: ambari > > > Description > --- > > Steps > Deploy HDP-2.3.0.0 cluster with Ambari 2.1.1 (Oracle DB, unsecure, HA > cluster). Note - the DB instance is dedicated for this cluster and Ambari > server and not shared > Upgrade Ambari to 2.4.0.0-726.x86_64 > Result > Error during Ambari DB schema upgrade. Logs show the below > > 01 Jul 2016 11:47:17,686 ERROR [main] DBAccessorImpl:107 - Error while > creating database accessor > java.sql.SQLException: Listener refused the connection with the following > error: > ORA-12516, TNS:listener could not find available handler with matching > protocol stack > > at oracle.jdbc.driver.T4CConnection.logon(T4CConnection.java:419) > at > oracle.jdbc.driver.PhysicalConnection.(PhysicalConnection.java:536) > at oracle.jdbc.driver.T4CConnection.(T4CConnection.java:228) > at > oracle.jdbc.driver.T4CDriverExtension.getConnection(T4CDriverExtension.java:32) > at oracle.jdbc.driver.OracleDriver.connect(OracleDriver.java:521) > at java.sql.DriverManager.getConnection(DriverManager.java:571) > at java.sql.DriverManager.getConnection(DriverManager.java:215) > at > org.apache.ambari.server.orm.DBAccessorImpl.(DBAccessorImpl.java:87) > 01 Jul 2016 11:47:17,697 ERROR [main] DBAccessorImpl:107 - Error while > creating database accessor > java.sql.SQLException: Listener refused the connection with the following > error: > ORA-12516, TNS:listener could not find available handler with matching > protocol stack > > at oracle.jdbc.driver.T4CConnection.logon(T4CConnection.java:419) > at > oracle.jdbc.driver.PhysicalConnection.(PhysicalConnection.java:536) > 01 Jul 2016 11:47:17,699 ERROR [main] SchemaUpgradeHelper:369 - Unexpected > error, upgrade failed > com.google.inject.ProvisionException: Guice provision errors: > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java > b10d32a > > Diff: https://reviews.apache.org/r/49805/diff/ > > > Testing > --- > > Unit tests passed > > > Thanks, > > Dmytro Sen > >
Re: Review Request 49762: Oozie fails to start when Falcon is not on the same host
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49762/#review141170 --- Ship it! Ship It! - Myroslav Papirkovskyy On Липень 7, 2016, 6:43 після полудня, Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49762/ > --- > > (Updated Липень 7, 2016, 6:43 після полудня) > > > Review request for Ambari and Dmytro Sen. > > > Bugs: AMBARI-17609 > https://issues.apache.org/jira/browse/AMBARI-17609 > > > Repository: ambari > > > Description > --- > > Traceback (most recent call last): > File > "/var/lib/ambari-agent/cache/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py", > line 215, in > OozieServer().execute() > File > "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", > line 280, in execute > method(env) > File > "/var/lib/ambari-agent/cache/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py", > line 88, in start > self.configure(env) > File > "/var/lib/ambari-agent/cache/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py", > line 82, in configure > oozie(is_server=True) > File > "/usr/lib/python2.6/site-packages/ambari_commons/os_family_impl.py", line 89, > in thunk > return fn(*args, **kwargs) > File > "/var/lib/ambari-agent/cache/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py", > line 173, in oozie > oozie_server_specific() > File > "/var/lib/ambari-agent/cache/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py", > line 253, in oozie_server_specific > not_if = no_op_test) > File > "/usr/lib/python2.6/site-packages/resource_management/core/base.py", line > 155, in __init__ > self.env.run() > File > "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", > line 160, in run > self.run_action(resource, action) > File > "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", > line 124, in run_action > provider_action() > File > "/usr/lib/python2.6/site-packages/resource_management/core/providers/system.py", > line 273, in action_run > tries=self.resource.tries, try_sleep=self.resource.try_sleep) > File > "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line > 71, in inner > result = function(command, **kwargs) > File > "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line > 93, in checked_call > tries=tries, try_sleep=try_sleep) > File > "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line > 141, in _call_wrapper > result = _call(command, **kwargs_copy) > File > "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line > 294, in _call > raise Fail(err_msg) > resource_management.core.exceptions.Fail: Execution of 'ambari-sudo.sh cp > /usr/hdp/current/falcon-client/oozie/ext/falcon-oozie-el-extension-*.jar > /usr/hdp/current/oozie-server/libext' returned 1. cp: cannot stat > `/usr/hdp/current/falcon-client/oozie/ext/falcon-oozie-el-extension-*.jar': > No such file or directory > > > Diffs > - > > > ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.3/metainfo.xml > 25584fa > ambari-server/src/main/resources/stacks/HDP/2.3/services/OOZIE/metainfo.xml > 8246f68 > > Diff: https://reviews.apache.org/r/49762/diff/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
Re: Review Request 49626: NN HA enabling failed at 'Stop all Services' step
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49626/#review140797 --- Ship it! Ship It! - Myroslav Papirkovskyy On Липень 5, 2016, 2 після полудня, Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49626/ > --- > > (Updated Липень 5, 2016, 2 після полудня) > > > Review request for Ambari, Dmitro Lisnichenko, Myroslav Papirkovskyy, Nate > Cole, and Sid Wagle. > > > Bugs: AMBARI-17559 > https://issues.apache.org/jira/browse/AMBARI-17559 > > > Repository: ambari > > > Description > --- > > 1) If a command gets aborted, it remains in "IN_PROGRESS" state on the agent. > Agent sends it in each heartbeat until agent gets restarted. > > 2) Because of an ordering issue in the heartbeat report processing, server > sometimes mismatches command statuses. (If we have COMPLETED command and > ABORTED in the same heartbeat, it may think that completed command was > aborted and rejects state change). This situation was rare previously, but > because of the first issue aborted commands come in each Heartbeat. > > > Diffs > - > > ambari-agent/src/main/python/ambari_agent/ActionQueue.py 3832b81 > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionManager.java > 2b121dc > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java > c6036c2 > > ambari-server/src/main/java/org/apache/ambari/server/utils/CommandUtils.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionDBAccessorImpl.java > 50021c2 > > ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionManager.java > f85b95d > > ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java > e0f67af > > ambari-server/src/test/java/org/apache/ambari/server/agent/HeartbeatProcessorTest.java > 913c4ea > > Diff: https://reviews.apache.org/r/49626/diff/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
Re: Review Request 49199: Falcon client install failed
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49199/#review139368
---
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Червень 24, 2016, 4:20 після полудня, Dmytro Sen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49199/
> ---
>
> (Updated Червень 24, 2016, 4:20 після полудня)
>
>
> Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy,
> Vitalyi Brodetskyi, and Venkat Ranganathan.
>
>
> Bugs: AMBARI-17428
> https://issues.apache.org/jira/browse/AMBARI-17428
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Falcon client failed and is blocking UI installs :
>
> "Traceback (most recent call last):\n File
> \"/var/lib/ambari-agent/cache/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py\",
> line 80, in \nFalconClient().execute()\n File
> \"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py\",
> line 280, in execute\nmethod(env)\n File
> \"/var/lib/ambari-agent/cache/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py\",
> line 45, in install\nself.configure(env)\n File
> \"/var/lib/ambari-agent/cache/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py\",
> line 33, in configure\nfalcon('client', action='config')\n File
> \"/usr/lib/python2.6/site-packages/ambari_commons/os_family_impl.py\", line
> 89, in thunk\nreturn fn(*args, **kwargs)\n File
> \"/var/lib/ambari-agent/cache/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py\",
> line 84, in falcon\nowner = params.falcon_user)\n File
> \"/usr/lib/python2.6/site-packages/resource_management/core/ba
se.py\", line 155, in __init__\nself.env.run()\n File
\"/usr/lib/python2.6/site-packages/resource_management/core/environment.py\",
line 160, in run\nself.run_action(resource, action)\n File
\"/usr/lib/python2.6/site-packages/resource_management/core/environment.py\",
line 124, in run_action\nprovider_action()\n File
\"/usr/lib/python2.6/site-packages/resource_management/libraries/providers/properties_file.py\",
line 54, in action_create\nmode = self.resource.mode\n File
\"/usr/lib/python2.6/site-packages/resource_management/core/base.py\", line
155, in __init__\nself.env.run()\n File
\"/usr/lib/python2.6/site-packages/resource_management/core/environment.py\",
line 160, in run\nself.run_action(resource, action)\n File
\"/usr/lib/python2.6/site-packages/resource_management/core/environment.py\",
line 124, in run_action\nprovider_action()\n File
\"/usr/lib/python2.6/site-packages/resource_management/core/providers/system.py\",
line 123, in action_cr
eate\ncontent = self._get_content()\n File
\"/usr/lib/python2.6/site-packages/resource_management/core/providers/system.py\",
line 160, in _get_content\nreturn content()\n File
\"/usr/lib/python2.6/site-packages/resource_management/core/source.py\", line
51, in __call__\nreturn self.get_content()\n File
\"/usr/lib/python2.6/site-packages/resource_management/core/source.py\", line
142, in get_content\nrendered = self.template.render(self.context)\n File
\"/usr/lib/python2.6/site-packages/ambari_jinja2/environment.py\", line 891, in
render\nreturn self.environment.handle_exception(exc_info, True)\n File
\"\", line 2, in top-level template code\n File
\"/usr/lib/python2.6/site-packages/ambari_jinja2/filters.py\", line 176, in
do_dictsort\nreturn sorted(value.items(), key=sort_func)\n File
\"/usr/lib/python2.6/site-packages/resource_management/libraries/script/config_dictionary.py\",
line 73, in __getattr__\nraise Fail(\"Configuration paramet
er '\" + self.name + \"' was not found in configurations
dictionary!\")\nresource_management.core.exceptions.Fail: Configuration
parameter 'falcon-client.properties' was not found in configurations
dictionary!",
>
>
> Diffs
> -
>
>
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-client.properties.xml
> PRE-CREATION
>
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/metainfo.xml
> 985e7f4
>
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
> 2bdaa48
>
> amba
Re: Review Request 49119: AMBARI-17383: User names should be case insensitive
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49119/#review139221 --- ambari-server/src/main/java/org/apache/ambari/server/security/authorization/User.java (line 49) <https://reviews.apache.org/r/49119/#comment204361> IMO user name should be stored and returned in original case. Only comparison should be case insensitive. - Myroslav Papirkovskyy On Червень 23, 2016, 3:14 до полудня, Nahappan Somasundaram wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49119/ > --- > > (Updated Червень 23, 2016, 3:14 до полудня) > > > Review request for Ambari, Myroslav Papirkovskyy, Robert Levas, and Sumit > Mohanty. > > > Bugs: AMBARI-17383 > https://issues.apache.org/jira/browse/AMBARI-17383 > > > Repository: ambari > > > Description > --- > > AMBARI-17383: User names should be case insensitive > > ** Issue: ** > It should not be possible to add user names that differ only by case. > > ** Fix: ** > 1. Make a case insensitive string comparision against the DB Users table to > see if the input user name already exists. > 2. Added a new UT to test this change. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 349668fe57bedbe45be26a03cc92b9fd4a29483b > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserDAO.java > d209cfcfc5ce5a78354220cf084e9a394841af49 > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/User.java > 720918b646d4a70b9b53a1d2da05dd391adb03e7 > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java > 1a7b58db3759dff876ca0e909ab62170c8f49955 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserResourceProviderTest.java > dc22bb914df36bb9b3fbf27d3c2fbf1251489553 > > ambari-server/src/test/java/org/apache/ambari/server/security/authorization/TestUsers.java > 44fb73c2644a75a8165425b97137dac20042972b > > Diff: https://reviews.apache.org/r/49119/diff/ > > > Testing > --- > > ** 1. mvn clean install ** > > [INFO] > > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Main ... SUCCESS [5.972s] > [INFO] Apache Ambari Project POM . SUCCESS [0.038s] > [INFO] Ambari Web SUCCESS [24.668s] > [INFO] Ambari Views .. SUCCESS [1.161s] > [INFO] Ambari Admin View . SUCCESS [9.686s] > [INFO] ambari-metrics SUCCESS [0.711s] > [INFO] Ambari Metrics Common . SUCCESS [0.868s] > [INFO] Ambari Metrics Hadoop Sink SUCCESS [1.184s] > [INFO] Ambari Metrics Flume Sink . SUCCESS [0.648s] > [INFO] Ambari Metrics Kafka Sink . SUCCESS [0.671s] > [INFO] Ambari Metrics Storm Sink . SUCCESS [1.630s] > [INFO] Ambari Metrics Collector .. SUCCESS [9.722s] > [INFO] Ambari Metrics Monitor SUCCESS [2.332s] > [INFO] Ambari Metrics Grafana SUCCESS [0.885s] > [INFO] Ambari Metrics Assembly ... SUCCESS [1:34.064s] > [INFO] Ambari Server . SUCCESS [3:11.990s] > [INFO] Ambari Functional Tests ... SUCCESS [1.250s] > [INFO] Ambari Agent .. SUCCESS [26.046s] > [INFO] Ambari Client . SUCCESS [0.053s] > [INFO] Ambari Python Client .. SUCCESS [0.975s] > [INFO] Ambari Groovy Client .. SUCCESS [2.234s] > [INFO] Ambari Shell .. SUCCESS [0.047s] > [INFO] Ambari Python Shell ... SUCCESS [0.721s] > [INFO] Ambari Groovy Shell ... SUCCESS [1.045s] > [INFO] ambari-logsearch .. SUCCESS [0.262s] > [INFO] Ambari Logsearch Appender . SUCCESS [0.397s] > [INFO] Ambari Logsearch Solr Client .. SUCCESS [1.177s] > [INFO] Ambari Logsearch Portal .
Re: Review Request 48540: Ubuntu 16, Hive Metastore Start failed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48540/#review137277 --- Ship it! Ship It! - Myroslav Papirkovskyy On Червень 10, 2016, 1:23 після полудня, Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48540/ > --- > > (Updated Червень 10, 2016, 1:23 після полудня) > > > Review request for Ambari and Myroslav Papirkovskyy. > > > Bugs: AMBARI-17161 > https://issues.apache.org/jira/browse/AMBARI-17161 > > > Repository: ambari > > > Description > --- > > /var/lib/ambari-agent/tmp/addMysqlUser.sh didn't add mysql user. > > > > + echo 'Adding user hive@% and removing users with empty name' > Adding user hive@% and removing users with empty name > + /var/lib/ambari-agent/ambari-sudo.sh su mysql -s /bin/bash - -c 'mysql > -u root -e "CREATE USER '\''hive'\''@'\''%'\'' IDENTIFIED BY '\''h'\'';"' > ERROR 1698 (28000): Access denied for user 'root'@'localhost' > + /var/lib/ambari-agent/ambari-sudo.sh su mysql -s /bin/bash - -c 'mysql > -u root -e "GRANT ALL PRIVILEGES ON *.* TO '\''hive'\''@'\''%'\'';"' > ERROR 1698 (28000): Access denied for user 'root'@'localhost' > + /var/lib/ambari-agent/ambari-sudo.sh su mysql -s /bin/bash - -c 'mysql > -u root -e "DELETE FROM mysql.user WHERE user='\'''\'';"' > ERROR 1698 (28000): Access denied for user 'root'@'localhost' > + /var/lib/ambari-agent/ambari-sudo.sh su mysql -s /bin/bash - -c 'mysql > -u root -e "flush privileges;"' > ERROR 1698 (28000): Access denied for user 'root'@'localhost' > + /var/lib/ambari-agent/ambari-sudo.sh service mysql stop > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/addMysqlUser.sh > 36ed58f > > Diff: https://reviews.apache.org/r/48540/diff/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
Re: Review Request 48072: Upgrade Catalog 2.4 is not idempotent
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48072/#review135629 --- Ship it! Ship It! - Myroslav Papirkovskyy On Травень 31, 2016, 2:12 після полудня, Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48072/ > --- > > (Updated Травень 31, 2016, 2:12 після полудня) > > > Review request for Ambari and Myroslav Papirkovskyy. > > > Bugs: AMBARI-16964 > https://issues.apache.org/jira/browse/AMBARI-16964 > > > Repository: ambari > > > Description > --- > > **STR:** > Run ambrai-server upgrade twice (a with metainfo change). > **Result:** > > > 30 May 2016 14:21:20,392 ERROR [main] DBAccessorImpl:803 - Error > executing query: UPDATE viewinstance SET cluster_handle_dummy = 2 WHERE > cluster_handle = 'cl1' > org.postgresql.util.PSQLException: ERROR: invalid input syntax for > integer: "cl1" > Position: 73 > at > org.postgresql.core.v3.QueryExecutorImpl.receiveErrorResponse(QueryExecutorImpl.java:2161) > at > org.postgresql.core.v3.QueryExecutorImpl.processResults(QueryExecutorImpl.java:1890) > at > org.postgresql.core.v3.QueryExecutorImpl.execute(QueryExecutorImpl.java:255) > at > org.postgresql.jdbc2.AbstractJdbc2Statement.execute(AbstractJdbc2Statement.java:559) > at > org.postgresql.jdbc2.AbstractJdbc2Statement.executeWithFlags(AbstractJdbc2Statement.java:403) > at > org.postgresql.jdbc2.AbstractJdbc2Statement.execute(AbstractJdbc2Statement.java:395) > at > org.apache.ambari.server.orm.DBAccessorImpl.executeQuery(DBAccessorImpl.java:800) > at > org.apache.ambari.server.orm.DBAccessorImpl.executeQuery(DBAccessorImpl.java:792) > at > org.apache.ambari.server.upgrade.UpgradeCatalog240.updateViewInstanceTable(UpgradeCatalog240.java:2352) > at > org.apache.ambari.server.upgrade.UpgradeCatalog240.executeDDLUpdates(UpgradeCatalog240.java:277) > at > org.apache.ambari.server.upgrade.AbstractUpgradeCatalog.upgradeSchema(AbstractUpgradeCatalog.java:699) > at > org.apache.ambari.server.upgrade.SchemaUpgradeHelper.executeUpgrade(SchemaUpgradeHelper.java:201) > at > org.apache.ambari.server.upgrade.SchemaUpgradeHelper.main(SchemaUpgradeHelper.java:302) > 30 May 2016 14:21:20,424 ERROR [main] SchemaUpgradeHelper:203 - Upgrade > failed. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java > b817a15 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java > 56e8a8a > > Diff: https://reviews.apache.org/r/48072/diff/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
Re: Review Request 47979: Deploy: UI: Hive_metastore not started
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47979/#review135305
---
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Травень 27, 2016, 11:15 після полудня, Vitalyi Brodetskyi wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47979/
> ---
>
> (Updated Травень 27, 2016, 11:15 після полудня)
>
>
> Review request for Ambari, Andrew Onischuk, Dmytro Sen, Nate Cole, and Sumit
> Mohanty.
>
>
> Bugs: AMBARI-16938
> https://issues.apache.org/jira/browse/AMBARI-16938
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Deploy ambari cluster using UI with hive for existing mysql setup
> Actual: Hive metastore is failing to start due to unable to connect to DB.
> 2016-05-26 00:20:15,442 - Execute['/usr/jdk64/jdk1.8.0_77/bin/java -cp
> /usr/lib/ambari-agent/DBConnectionVerification.jar:/usr/hdp/current/hive-metastore/lib/mysql-connector-java.jar
> org.apache.ambari.server.DBConnectionVerification 'jdbc:mysql://host/hivedb'
> hiveuser PROTECTED com.mysql.jdbc.Driver']
> {'path': ['/usr/sbin:/sbin:/usr/local/bin:/bin:/usr/bin'], 'tries': 5,
> 'try_sleep': 10}
>
>
> Diffs
> -
>
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
> abb8469
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
> 5639922
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py
> 7554010
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
> 76a417d
>
> Diff: https://reviews.apache.org/r/47979/diff/
>
>
> Testing
> ---
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 47417: Replace '*' to hdp version in lzo packages
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47417/#review134597
---
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Травень 24, 2016, 5:32 після полудня, Vitalyi Brodetskyi wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47417/
> ---
>
> (Updated Травень 24, 2016, 5:32 після полудня)
>
>
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, and Sumit
> Mohanty.
>
>
> Bugs: AMBARI-16683
> https://issues.apache.org/jira/browse/AMBARI-16683
>
>
> Repository: ambari
>
>
> Description
> ---
>
> As i understood(according to discussion with Andrew O) we had some jira for
> '*' to hdp version replacement in all packages. But here it was not replaced:
> {code}
> def get_lzo_packages(stack_version_unformatted):
> lzo_packages = []
>
> if OSCheck.is_redhat_family() or OSCheck.is_suse_family():
> lzo_packages += ["lzo", "hadoop-lzo-native"]
> elif OSCheck.is_ubuntu_family():
> lzo_packages += ["liblzo2-2"]
>
> if stack_version_unformatted and
> check_stack_feature(StackFeature.ROLLING_UPGRADE, stack_version_unformatted):
> lzo_packages += ["hadooplzo_*"]
> else:
> lzo_packages += ["hadoop-lzo"]
>
> return lzo_packages
> {code}
>
>
> Diffs
> -
>
>
> ambari-common/src/main/python/resource_management/libraries/functions/get_lzo_packages.py
> e189d62
>
> ambari-common/src/main/python/resource_management/libraries/script/script.py
> 0dcbea8
>
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py
> ceee738
>
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py
> 94d9955
> ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py 90c12ca
> ambari-server/src/test/python/stacks/2.0.6/HDFS/test_hdfs_client.py a165718
> ambari-server/src/test/python/stacks/2.0.6/HDFS/test_journalnode.py 08eab25
> ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py 34b639e
> ambari-server/src/test/python/stacks/2.0.6/HDFS/test_nfsgateway.py c8e7d27
> ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_client.py
> 46cacf5
> ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py
> e43f6dc
>
> ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_service_check.py
> 646f5db
> ambari-server/src/test/python/stacks/utils/RMFTestCase.py ebb3cbc
>
> Diff: https://reviews.apache.org/r/47417/diff/
>
>
> Testing
> ---
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 47595: Implement in ams collector batch insert operations to ams-hbase
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47595/#review134361 --- Ship it! Ship It! - Myroslav Papirkovskyy On Травень 23, 2016, 6:11 після полудня, Dmytro Sen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47595/ > --- > > (Updated Травень 23, 2016, 6:11 після полудня) > > > Review request for Ambari, Aravindan Vijayan and Sid Wagle. > > > Bugs: AMBARI-16766 > https://issues.apache.org/jira/browse/AMBARI-16766 > > > Repository: ambari > > > Description > --- > > Check if there is performance boost after replacing insert operations with > bulk loading. > If yes, implement and provide switch property for enabling/disabling this > feature. > > > Diffs > - > > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java > 83aa36b > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/MetricsCacheCommitterThread.java > PRE-CREATION > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java > 52ab083 > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java > 8e9a8d6 > > ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessorTest.java > 290a98a > > ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/discovery/TestMetadataManager.java > 92e4dfc > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml > e5758bf > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/service_check.py > 8f369f7 > > Diff: https://reviews.apache.org/r/47595/diff/ > > > Testing > --- > > Unit tests passed > > > Thanks, > > Dmytro Sen > >
Re: Review Request 47315: Ambari upgrade fails because of new [cluster_type] column
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47315/#review132917 --- Ship it! Ship It! - Myroslav Papirkovskyy On Травень 12, 2016, 5:28 після полудня, Vitalyi Brodetskyi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47315/ > --- > > (Updated Травень 12, 2016, 5:28 після полудня) > > > Review request for Ambari, Dmytro Sen, Myroslav Papirkovskyy, and Sumit > Mohanty. > > > Bugs: AMBARI-16635 > https://issues.apache.org/jira/browse/AMBARI-16635 > > > Repository: ambari > > > Description > --- > > . > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java > ba5774f > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java > 3547ad3 > > Diff: https://reviews.apache.org/r/47315/diff/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Vitalyi Brodetskyi > >
Re: Review Request 46944: AMBARI-16230: Sporadic errors when deploying the cluster
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46944/#review132466 --- Ship it! Ship It! - Myroslav Papirkovskyy On Травень 10, 2016, 7:19 після полудня, Oliver Szabo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46944/ > --- > > (Updated Травень 10, 2016, 7:19 після полудня) > > > Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Myroslav > Papirkovskyy, Sumit Mohanty, and Sebastian Toader. > > > Bugs: AMBARI-16230 > https://issues.apache.org/jira/browse/AMBARI-16230 > > > Repository: ambari > > > Description > --- > > 2 different type of errors can occur during adding any new service to Ambari: > > org.apache.ambari.server.AmbariException: Unable to create a default alert > group for unknown service in cluster > > org.apache.ambari.server.ServiceNotFoundException: Service not found, > clusterName=c1, serviceName= > > The reason is that: ServiceInstalledEvent can be handled quicker than > ServiceImpl.persist() can finish > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java > 47342f3 > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java > 487489b > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java > f38c25a > ambari-server/src/test/java/org/apache/ambari/server/events/EventsTest.java > a3d05a9 > ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java > 19146fd > > ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertEventPublisherTest.java > d1b27a9 > > ambari-server/src/test/java/org/apache/ambari/server/state/alerts/InitialAlertEventTest.java > 1875ba6 > > Diff: https://reviews.apache.org/r/46944/diff/ > > > Testing > --- > > Unit Testing is in progress.. > FT: added new services about 10 times, has no any errors thrown. > > > Thanks, > > Oliver Szabo > >
Re: Review Request 46433: spark history server fails to start after upgrading ambari 2.2.1.0 -> 2.2.2.0 and remaining on derg
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46433/#review129726
---
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Квітень 20, 2016, 2:45 після полудня, Andrew Onischuk wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46433/
> ---
>
> (Updated Квітень 20, 2016, 2:45 після полудня)
>
>
> Review request for Ambari and Myroslav Papirkovskyy.
>
>
> Bugs: AMBARI-15988
> https://issues.apache.org/jira/browse/AMBARI-15988
>
>
> Repository: ambari
>
>
> Description
> ---
>
> After upgrading the cluster to Ambari 2.2.2.0 from ambari 2.2.1.0 various
> services had a restart alert and upon restarting spark we saw a failure. IE
> only ambari upgrade was done.
>
>
>
>
> Traceback (most recent call last):
> File
> "/var/lib/ambari-agent/cache/common-services/SPARK/1.2.0.2.2/package/scripts/job_history_server.py",
> line 95, in
> JobHistoryServer().execute()
> File
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
> line 219, in execute
> method(env)
> File
> "/var/lib/ambari-agent/cache/common-services/SPARK/1.2.0.2.2/package/scripts/job_history_server.py",
> line 55, in start
> spark_service('jobhistoryserver', upgrade_type=upgrade_type,
> action='start')
> File
> "/var/lib/ambari-agent/cache/common-services/SPARK/1.2.0.2.2/package/scripts/spark_service.py",
> line 49, in spark_service
> recursive_chmod=True
> File
> "/usr/lib/python2.6/site-packages/resource_management/core/base.py", line
> 154, in __init__
> self.env.run()
> File
> "/usr/lib/python2.6/site-packages/resource_management/core/environment.py",
> line 160, in run
> self.run_action(resource, action)
> File
> "/usr/lib/python2.6/site-packages/resource_management/core/environment.py",
> line 124, in run_action
> provider_action()
> File
> "/usr/lib/python2.6/site-packages/resource_management/libraries/providers/hdfs_resource.py",
> line 463, in action_create_on_execute
> self.action_delayed("create")
> File
> "/usr/lib/python2.6/site-packages/resource_management/libraries/providers/hdfs_resource.py",
> line 460, in action_delayed
> self.get_hdfs_resource_executor().action_delayed(action_name, self)
> File
> "/usr/lib/python2.6/site-packages/resource_management/libraries/providers/hdfs_resource.py",
> line 250, in action_delayed
> self._assert_valid()
> File
> "/usr/lib/python2.6/site-packages/resource_management/libraries/providers/hdfs_resource.py",
> line 234, in _assert_valid
> self.target_status = self._get_file_status(target)
> File
> "/usr/lib/python2.6/site-packages/resource_management/libraries/providers/hdfs_resource.py",
> line 295, in _get_file_status
> list_status = self.util.run_command(target, 'GETFILESTATUS',
> method='GET', ignore_status_codes=['404'], assertable_result=False)
> File
> "/usr/lib/python2.6/site-packages/resource_management/libraries/providers/hdfs_resource.py",
> line 182, in run_command
> _, out, err = get_user_call_output(cmd, user=self.run_user,
> logoutput=self.logoutput, quiet=False)
> File
> "/usr/lib/python2.6/site-packages/resource_management/libraries/functions/get_user_call_output.py",
> line 61, in get_user_call_output
> raise Fail(err_msg)
> resource_management.core.exceptions.Fail: Execution of 'curl -sS -L -w
> '%{http_code}' -X GET --negotiate -u :
> 'http://hcube2-1n03.eng.hortonworks.com:50070/webhdfs/v1{{spark_history_dir}}?op=GETFILESTATUS=hdfs'
> 1>/tmp/tmpwmdLi2 2>/tmp/tmpH9CmmS' returned 3. curl: (3) [globbing] nested
> braces not supported at pos 57
>
>
> Stack that is running right now is HDP 2.4.0.0
>
> Ambari is running here:
> <https://hcube2-1n01.eng.hortonworks.com:8443/#/main/dashboard/metrics>
>
>
> Diffs
> -
>
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java
> c999d52
>
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog222Test.java
> f543f18
>
> Diff: https://reviews.apache.org/r/46433/diff/
>
>
> Testing
> ---
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 46095: On debian7 UI shows 'os not supported' in processor info
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46095/#review128403
---
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Квітень 12, 2016, 5:11 після полудня, Andrew Onischuk wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46095/
> ---
>
> (Updated Квітень 12, 2016, 5:11 після полудня)
>
>
> Review request for Ambari, Dmytro Sen and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-15836
> https://issues.apache.org/jira/browse/AMBARI-15836
>
>
> Repository: ambari
>
>
> Description
> ---
>
> This is caused by platform python module not able to get processor
> architecture.
>
>
>
> >>> import platform
> >>> platform.processor()
> ''
>
>
> We should use a more reliable way to do that.
> That is by using lsof.
>
>
>
> root@os-d7-cpnlrs-devdeploy-1:~# lscpu | grep "Architecture:" | awk '{
> print $2 }'
> x86_64
>
>
> Diffs
> -
>
> ambari-agent/src/main/python/ambari_agent/Facter.py bad9b96
>
> Diff: https://reviews.apache.org/r/46095/diff/
>
>
> Testing
> ---
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 45904: Ambari upgrade fails with MySQL DB and enforce gtid enabled
> On Квітень 11, 2016, 3:36 після полудня, Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDispatchDAO.java, > > lines 701-708 > > <https://reviews.apache.org/r/45904/diff/3/?file=1337530#file1337530line701> > > > > This solution is still far from ideal. You'll be making something like > > 20,000 database queries and if even 1 fails, then the entire transaction is > > rolled back. > > > > This is why we went for a pure JPQL approach here; it was clean and > > didn't cause any weird problems. > > > > This also doesn't address the fact that nothing prevents future JPQL > > queries from causing a similar problem. > > > > Perhaps we need to consider a different approach. The issue was that > > MySQL was using temporary tables outside of a transaction. If we can solve > > that problem, we can leave the existing JPQL. This is not quite correct. Issue was that EclipseLink uses MySQL temporary tables INSIDE of transactions. Temp tables outside of transaction are supported even with GTID enabled. However disabling temp tables simply doesn't work. EclipseLink starts to generate invalid queries for MySQL. And after quick look at sources it seems that major modifications are required to fix this. For MySQL temp tables are used to bypass limitations of subqueries in delete/update statements. - Myroslav --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45904/#review128100 --- On Квітень 8, 2016, 11:56 після полудня, Sid Wagle wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45904/ > --- > > (Updated Квітень 8, 2016, 11:56 після полудня) > > > Review request for Ambari, Jonathan Hurley, Myroslav Papirkovskyy, and Sumit > Mohanty. > > > Bugs: AMBARI-15774 > https://issues.apache.org/jira/browse/AMBARI-15774 > > > Repository: ambari > > > Description > --- > > Approach: > > - Added member varaibles only when underlying DB columns exist > - Changed DELETE via implcit join query to find and delete > - MySQL temp tables are only used for UPDATE ALL and DELETE ALL, so SELECT > and DELETE is a safer approach > - Visually inspected all Entities under > org.apache.ambari.server.orm.entities.* for absence of this pattern > > Issue: Ambari upgrade is failing from 2.2.0 to 2.2.1.1 with below error: > > Error output from schema upgrade command: > Exception in thread "main" org.apache.ambari.server.AmbariException: > Exception [EclipseLink-4002] (Eclipse Persistence Services - > 2.5.2.v20140319-9ad6abd): > org.eclipse.persistence.exceptions.DatabaseException > Internal Exception: > com.mysql.jdbc.exceptions.jdbc4.MySQLSyntaxErrorException: Table > 'ambari.TL_alert_notice' doesn't exist > Error Code: 1146 > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertReceivedListener.java > a3befa6 > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAO.java > 82fa48a > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDispatchDAO.java > 1f1aa45 > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertsDAO.java > 781d4cf > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertCurrentEntity.java > 604b00e > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertHistoryEntity.java > 03ffcde > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertNoticeEntity.java > ae7495d > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertResourceProviderTest.java > d611fe8 > > ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAOTest.java > 36e75e7 > > ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertsDAOTest.java > 10f099e > > Diff: https://reviews.apache.org/r/45904/diff/ > > > Testing > --- > > Manually verified on 1 node repro cluster. > > All alert unit test passed. > > mvn clean test -Dtest=Alert* -Drat.ignoreErrors -DfailIfNoTests=false > > > Thanks, > > Sid Wagle > >
Re: Review Request 45930: After upgrading to Ambari 2.2.1, Storm widgets are gone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45930/#review127801 --- Ship it! Ship It! - Myroslav Papirkovskyy On Квітень 8, 2016, 6 після полудня, Dmytro Sen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45930/ > --- > > (Updated Квітень 8, 2016, 6 після полудня) > > > Review request for Ambari, Andrew Onischuk, Myroslav Papirkovskyy, and > Vitalyi Brodetskyi. > > > Bugs: AMBARI-15759 > https://issues.apache.org/jira/browse/AMBARI-15759 > > > Repository: ambari > > > Description > --- > > 1. Running Ambari 2.2.1.0 > 2. Upgraded to Amabri 2.2.1.1 > 3. Storm widgets are not showing on Services > Storm > Summary > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java > 77b8b45 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog222Test.java > 5f07e56 > > Diff: https://reviews.apache.org/r/45930/diff/ > > > Testing > --- > > Unit tests passed > > > Thanks, > > Dmytro Sen > >
Re: Review Request 45904: Ambari upgrade fails with MySQL DB and enforce gtid enabled
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45904/#review127749 --- Ship it! Ship It! - Myroslav Papirkovskyy On Квітень 8, 2016, 2:34 до полудня, Sid Wagle wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45904/ > --- > > (Updated Квітень 8, 2016, 2:34 до полудня) > > > Review request for Ambari, Jonathan Hurley, Myroslav Papirkovskyy, and Sumit > Mohanty. > > > Bugs: AMBARI-15774 > https://issues.apache.org/jira/browse/AMBARI-15774 > > > Repository: ambari > > > Description > --- > > Approach: > > - Added member varaibles only when underlying DB columns exist > - Changed DELETE via implcit join query to find and delete > - MySQL temp tables are only used for UPDATE ALL and DELETE ALL, so SELECT > and DELETE is a safer approach > - Visually inspected all Entities under > org.apache.ambari.server.orm.entities.* for absence of this pattern > > Issue: Ambari upgrade is failing from 2.2.0 to 2.2.1.1 with below error: > > Error output from schema upgrade command: > Exception in thread "main" org.apache.ambari.server.AmbariException: > Exception [EclipseLink-4002] (Eclipse Persistence Services - > 2.5.2.v20140319-9ad6abd): > org.eclipse.persistence.exceptions.DatabaseException > Internal Exception: > com.mysql.jdbc.exceptions.jdbc4.MySQLSyntaxErrorException: Table > 'ambari.TL_alert_notice' doesn't exist > Error Code: 1146 > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertReceivedListener.java > a3befa6 > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAO.java > 82fa48a > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDispatchDAO.java > 1f1aa45 > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertsDAO.java > 781d4cf > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertCurrentEntity.java > 604b00e > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertHistoryEntity.java > 03ffcde > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertNoticeEntity.java > ae7495d > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertResourceProviderTest.java > d611fe8 > > ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAOTest.java > 36e75e7 > > ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertsDAOTest.java > 10f099e > > Diff: https://reviews.apache.org/r/45904/diff/ > > > Testing > --- > > Manually verified on 1 node repro cluster. > > All alert unit test passed. > > mvn clean test -Dtest=Alert* -Drat.ignoreErrors -DfailIfNoTests=false > > > Thanks, > > Sid Wagle > >
Re: Review Request 45815: Ambari DB schema upgrade fails with ORA-01408 error
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45815/#review127348 --- Ship it! Ship It! - Myroslav Papirkovskyy On Квітень 6, 2016, 6:47 після полудня, Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45815/ > --- > > (Updated Квітень 6, 2016, 6:47 після полудня) > > > Review request for Ambari and Myroslav Papirkovskyy. > > > Bugs: AMBARI-15737 > https://issues.apache.org/jira/browse/AMBARI-15737 > > > Repository: ambari > > > Description > --- > > Artifacts: > <http://qelog.hortonworks.com/log/os-r7-rjjfis-dergtodergm10dwngd-r7/artifacts > /artifacts/screenshots/com.hw.ambari.ui.tests.monitoring.admin_page.e2e_expres > s_upgrade.E2E_EU_AmbariUpgrade/test001_performAmbariUpgrade/_5_22_52_6_Ambari_ > schema_upgrade_failed/> > > **Steps** > > 1. Install Ambari 2.2.1.1 with HDP-2.4.0.0 and Oracle as Ambari DB > 2. Upgrade Ambari to ambari-server-2.2.2.0-385.x86_64. As part of running > "ambari-server upgrade", observed below error: > > > > 05 Apr 2016 22:51:48,890 INFO [main] AbstractUpgradeCatalog:491 - No > changes detected to config hive-site. Skipping configuration properties update > 05 Apr 2016 22:51:49,159 INFO [main] DBAccessorImpl:744 - Executing > query: CREATE INDEX idx_hrc_status ON host_role_command (status, role) > 05 Apr 2016 22:51:49,203 ERROR [main] DBAccessorImpl:750 - Error > executing query: CREATE INDEX idx_hrc_status ON host_role_command (status, > role) > java.sql.SQLException: ORA-01408: such column list already indexed > > at oracle.jdbc.driver.T4CTTIoer.processError(T4CTTIoer.java:440) > at oracle.jdbc.driver.T4CTTIoer.processError(T4CTTIoer.java:396) > at oracle.jdbc.driver.T4C8Oall.processError(T4C8Oall.java:837) > at oracle.jdbc.driver.T4CTTIfun.receive(T4CTTIfun.java:445) > at oracle.jdbc.driver.T4CTTIfun.doRPC(T4CTTIfun.java:191) > at oracle.jdbc.driver.T4C8Oall.doOALL(T4C8Oall.java:523) > at oracle.jdbc.driver.T4CStatement.doOall8(T4CStatement.java:193) > at > oracle.jdbc.driver.T4CStatement.executeForRows(T4CStatement.java:999) > at > oracle.jdbc.driver.OracleStatement.doExecuteWithTimeout(OracleStatement.java:1315) > at > oracle.jdbc.driver.OracleStatement.executeInternal(OracleStatement.java:1890) > at > oracle.jdbc.driver.OracleStatement.execute(OracleStatement.java:1855) > at > oracle.jdbc.driver.OracleStatementWrapper.execute(OracleStatementWrapper.java:304) > at > org.apache.ambari.server.orm.DBAccessorImpl.executeQuery(DBAccessorImpl.java:747) > at > org.apache.ambari.server.orm.DBAccessorImpl.executeQuery(DBAccessorImpl.java:739) > at > org.apache.ambari.server.orm.DBAccessorImpl.createIndex(DBAccessorImpl.java:416) > at > org.apache.ambari.server.upgrade.UpgradeCatalog222.updateHostRoleCommands(UpgradeCatalog222.java:296) > at > org.apache.ambari.server.upgrade.UpgradeCatalog222.executeDMLUpdates(UpgradeCatalog222.java:180) > at > org.apache.ambari.server.upgrade.AbstractUpgradeCatalog.upgradeData(AbstractUpgradeCatalog.java:662) > at > org.apache.ambari.server.upgrade.SchemaUpgradeHelper.executeDMLUpdates(SchemaUpgradeHelper.java:228) > at > org.apache.ambari.server.upgrade.SchemaUpgradeHelper.main(SchemaUpgradeHelper.java:305) > 05 Apr 2016 22:51:49,205 ERROR [main] SchemaUpgradeHelper:230 - Upgrade > failed. > java.sql.SQLException: ORA-01408: such column list already indexed > > at oracle.jdbc.driver.T4CTTIoer.processError(T4CTTIoer.java:440) > at oracle.jdbc.driver.T4CTTIoer.processError(T4CTTIoer.java:396) > at oracle.jdbc.driver.T4C8Oall.processError(T4C8Oall.java:837) > at oracle.jdbc.driver.T4CTTIfun.receive(T4CTTIfun.java:445) > > > Not sure if this is a regression > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java > 7021a46 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog222Test.java > 7321f69 > > Diff: https://reviews.apache.org/r/45815/diff/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
Re: Review Request 45545: Output short logs summary on start/stop failure
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45545/#review126319 --- Ship it! Ship It! - Myroslav Papirkovskyy On Березень 31, 2016, 6:43 після полудня, Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45545/ > --- > > (Updated Березень 31, 2016, 6:43 після полудня) > > > Review request for Ambari and Dmitro Lisnichenko. > > > Bugs: AMBARI-15650 > https://issues.apache.org/jira/browse/AMBARI-15650 > > > Repository: ambari > > > Description > --- > > There were tons of situations when we had only output of task failure, when a > certain service failed to start/stop/restart, but couldn't get the logs of > services. > Which makes fixing those bugs pretty problematic or even impossible if no > reproduce is available. > This jira aims to output a short tail of service logs on start/stop failures, > this should cover a big part of such a scenarios. > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/__init__.py > e886fe4 > > ambari-common/src/main/python/resource_management/libraries/functions/show_logs.py > PRE-CREATION > > ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py > 05e6eb6 > > ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_service.py > e71d5af > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams_service.py > c9188c2 > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py > b6374f9 > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py > 7b469d3 > > ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume.py > b30b122 > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_service.py > ef4cd5b > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py > d6dec26 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py > 339d52a > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py > 2f94dfb > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service.py > 2553c70 > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py > 2043cfa > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py > af0442c > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_service.py > 5a2474f > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_service.py > 0cb56aa > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_service.py > f5b0c83 > > ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/spark_service.py > 6ada1c2 > > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/service.py > 0222d71 > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service.py > 6d9aef5 > > ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_service.py > d645997 > > ambari-server/src/test/python/stacks/2.0.6/ZOOKEEPER/test_zookeeper_server.py > 1c20915 > ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py > ab5236b > > Diff: https://reviews.apache.org/r/45545/diff/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
Re: Review Request 45545: Output short logs summary on start/stop failure
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45545/#review126311 --- Ship it! Ship It! - Myroslav Papirkovskyy On Березень 31, 2016, 5:50 після полудня, Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45545/ > --- > > (Updated Березень 31, 2016, 5:50 після полудня) > > > Review request for Ambari and Dmitro Lisnichenko. > > > Bugs: AMBARI-15650 > https://issues.apache.org/jira/browse/AMBARI-15650 > > > Repository: ambari > > > Description > --- > > There were tons of situations when we had only output of task failure, when a > certain service failed to start/stop/restart, but couldn't get the logs of > services. > Which makes fixing those bugs pretty problematic or even impossible if no > reproduce is available. > This jira aims to output a short tail of service logs on start/stop failures, > this should cover a big part of such a scenarios. > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/__init__.py > e886fe4 > > ambari-common/src/main/python/resource_management/libraries/functions/show_logs.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_service.py > e71d5af > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams_service.py > c9188c2 > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py > b6374f9 > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py > 7b469d3 > > ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume.py > b30b122 > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_service.py > ef4cd5b > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py > 339d52a > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py > 2f94dfb > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service.py > 2553c70 > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py > 2043cfa > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py > af0442c > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_service.py > 5a2474f > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_service.py > 0cb56aa > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_service.py > f5b0c83 > > ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/spark_service.py > 6ada1c2 > > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/service.py > 0222d71 > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service.py > 6d9aef5 > > ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_service.py > d645997 > > ambari-server/src/test/python/stacks/2.0.6/ZOOKEEPER/test_zookeeper_server.py > 1c20915 > ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py > ab5236b > > Diff: https://reviews.apache.org/r/45545/diff/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
Re: Review Request 45284: Ambari LDAP integration cannot handle LDAP directories with multiple entries for the same user
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45284/#review125610 --- Ship it! Ship It! - Myroslav Papirkovskyy On Березень 27, 2016, 8:42 після полудня, Sebastian Toader wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45284/ > --- > > (Updated Березень 27, 2016, 8:42 після полудня) > > > Review request for Ambari, Andriy Babiichuk, Andrii Tkach, Dmitro > Lisnichenko, Myroslav Papirkovskyy, Oliver Szabo, Robert Levas, and Yusaku > Sako. > > > Bugs: AMBARI-15554 > https://issues.apache.org/jira/browse/AMBARI-15554 > > > Repository: ambari > > > Description > --- > > Problem: > In case LDAP set up with multiple Domains which are joined into a Forrest > with trusts between the different Domains users may appear in different > locations in LDAP. > Since users who wants to access Ambari can be in any domain Ambari has to > search the whole forrest, and as the users appearing in multiple domains are > identical Ambari cannot filter out all but one of the user entries. > > Solution: > 1.If the LDAP search upon login to Ambari leads to multiple match user match > due to the user appears in multiple domains show an error message to user > prompting for providing domain as well to log-in. (e.g. Login Failed: Please > append your domain to your username and try again. Example: username@domain) > > 2. When user provides domain information at login as well Ambari looks up the > user in LDAP using different filter which is configurable. If this > configuration is not set Ambari defaults to filter by userPrincipalName > > 3. A map of login name (login alias) to ambari user name is stored in the > session so as later whenever is needed the login name can be resolved to > ambari user name (user name stored in ambari database). > > 4. User related rest API calls includes user name in the URL. There is a > filter set up for these resolve the user name in the URL to ambari user name > if needed. > > > Diffs > - > > ambari-server/conf/unix/log4j.properties 2ee32d4 > ambari-server/pom.xml 1e44517 > > ambari-server/src/main/java/org/apache/ambari/server/api/UserNameOverrideFilter.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > bf18325 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java > 076f850 > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariAuthentication.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProvider.java > 20cf2fd > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthoritiesPopulator.java > fc7f73a > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapBindAuthenticator.java > ed68c01 > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapUtils.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AuthorizationHelper.java > 0c675b8 > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/DuplicateLdapUserFoundAuthenticationException.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/LdapServerProperties.java > 8eeaf35 > ambari-server/src/main/resources/webapp/WEB-INF/spring-security.xml 3bbc785 > > ambari-server/src/test/java/org/apache/ambari/server/api/UserNameOverrideFilterTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java > 3ecb5aa > > ambari-server/src/test/java/org/apache/ambari/server/security/AmbariLdapUtilsTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariAuthenticationTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProviderForDuplicateUserTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProviderTest.java > d48be85 > > ambari-server/src/test/java/org/apache/ambari/server/security/authorizati
Re: Review Request 45284: Ambari LDAP integration cannot handle LDAP directories with multiple entries for the same user
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45284/#review125401 --- ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java (line 466) <https://reviews.apache.org/r/45284/#comment188194> Name says this is alternative search filter. But decision whether to use it is based on hardcoded UPN format (AmbariLdapUtils). This is not obvious. I understand that this is intended to work with AD specifically and it will. But we need to document this well and, possibly, create another issue for more generic approach. - Myroslav Papirkovskyy On Березень 25, 2016, 1:28 до полудня, Sebastian Toader wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45284/ > --- > > (Updated Березень 25, 2016, 1:28 до полудня) > > > Review request for Ambari, Andriy Babiichuk, Andrii Tkach, Dmitro > Lisnichenko, Myroslav Papirkovskyy, Oliver Szabo, Robert Levas, and Yusaku > Sako. > > > Bugs: AMBARI-15554 > https://issues.apache.org/jira/browse/AMBARI-15554 > > > Repository: ambari > > > Description > --- > > Problem: > In case LDAP set up with multiple Domains which are joined into a Forrest > with trusts between the different Domains users may appear in different > locations in LDAP. > Since users who wants to access Ambari can be in any domain Ambari has to > search the whole forrest, and as the users appearing in multiple domains are > identical Ambari cannot filter out all but one of the user entries. > > Solution: > 1.If the LDAP search upon login to Ambari leads to multiple match user match > due to the user appears in multiple domains show an error message to user > prompting for providing domain as well to log-in. (e.g. Login Failed: Please > append your domain to your username and try again. Example: username@domain) > > 2. When user provides domain information at login as well Ambari looks up the > user in LDAP using different filter which is configurable. If this > configuration is not set Ambari defaults to filter by userPrincipalName > > 3. A map of login name (login alias) to ambari user name is stored in the > session so as later whenever is needed the login name can be resolved to > ambari user name (user name stored in ambari database). > > 4. User related rest API calls includes user name in the URL. There is a > filter set up for these resolve the user name in the URL to ambari user name > if needed. > > > Diffs > - > > ambari-server/pom.xml 1e44517 > > ambari-server/src/main/java/org/apache/ambari/server/api/UserNameOverrideFilter.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > bf18325 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java > 076f850 > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariAuthentication.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProvider.java > 20cf2fd > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthoritiesPopulator.java > fc7f73a > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapBindAuthenticator.java > ed68c01 > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapUtils.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AuthorizationHelper.java > b136182 > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/DuplicateLdapUserFoundAuthenticationException.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/LdapServerProperties.java > 8eeaf35 > ambari-server/src/main/resources/webapp/WEB-INF/spring-security.xml 3bbc785 > > ambari-server/src/test/java/org/apache/ambari/server/api/UserNameOverrideFilterTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java > 3ecb5aa > > ambari-server/src/test/java/org/apache/ambari/server/security/AmbariLdapUtilsTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariAuthenticationTes
Re: Review Request 45125: 'ambari-server check-database' has errors after upgrade to ambari 2.2.2.0 [grafana errors]
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45125/#review124642 --- Ship it! Ship It! - Myroslav Papirkovskyy On Березень 21, 2016, 10:12 після полудня, Vitalyi Brodetskyi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45125/ > --- > > (Updated Березень 21, 2016, 10:12 після полудня) > > > Review request for Ambari, Sumit Mohanty and Sid Wagle. > > > Bugs: AMBARI-15495 > https://issues.apache.org/jira/browse/AMBARI-15495 > > > Repository: ambari > > > Description > --- > > STR: > 1)Deploy old version > 2)Make Ambari only Upgrade > 4)'ambari-server check-database' > Actual result: > 'ambari-server check-database' has errors after upgrade to ambari 2.2.2.0 > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDatabaseHelper.java > 652a49f > > ambari-server/src/test/java/org/apache/ambari/server/checks/CheckDatabaseHelperTest.java > 66c6667 > > Diff: https://reviews.apache.org/r/45125/diff/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Vitalyi Brodetskyi > >
Re: Review Request 45101: Configuration with tag 'TOPOLOGY_RESOLVED' exists for 'cluster-env' error when creating Kerberized cluster with Blueprints
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45101/#review124552 --- ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java (lines 1437 - 1438) <https://reviews.apache.org/r/45101/#comment187165> We chould not hardcode config types here. Simple way to make this dynamic is to use following method: org.apache.ambari.server.state.cluster.ClusterImpl#getServiceByConfigType So after adding this method to Cluster interface check will look like following: if ( cluster.getServiceByCOnfigType != null && clusterConfig.getServiceConfigVersions().isEmpty() ) - Myroslav Papirkovskyy On Березень 21, 2016, 4:23 після полудня, Sebastian Toader wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45101/ > --- > > (Updated Березень 21, 2016, 4:23 після полудня) > > > Review request for Ambari, Myroslav Papirkovskyy, Robert Levas, and Sandor > Magyari. > > > Bugs: AMBARI-15489 > https://issues.apache.org/jira/browse/AMBARI-15489 > > > Repository: ambari > > > Description > --- > > The logic that determines if a new version has to be created for a > configuration should skip cluster wide config types when verifying current > desired config against service configs as these are not service configs. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > ac2fb22 > > Diff: https://reviews.apache.org/r/45101/diff/ > > > Testing > --- > > Manual testing done. > > Unit tests results: > Results : > > Tests run: 3534, Failures: 0, Errors: 0, Skipped: 36 > > > Thanks, > > Sebastian Toader > >
