Re: Review Request 58122: Blueprint export fails if config-type is not mapped to any service after upgrade

2017-04-06 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58122/#review171283
---



Pushed to trunk

- Alejandro Fernandez


On April 5, 2017, 11:45 p.m., Amruta Borkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58122/
> ---
> 
> (Updated April 5, 2017, 11:45 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Di Li, and Robert Nettleton.
> 
> 
> Bugs: AMBARI-20551
> https://issues.apache.org/jira/browse/AMBARI-20551
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Following error is thrown while exporting a blueprint from cluster.
>  ERROR [ambari-client-thread-8726] ReadHandler:99 - Bad request:
> java.lang.IllegalArgumentException: Specified configuration type is not 
> associated with any service: storm-site
> at 
> org.apache.ambari.server.controller.internal.Stack.getServiceForConfigType(Stack.java:494)
> at 
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor$StackPropertyTypeFilter.isPropertyIncluded(BlueprintConfigurationProcessor.java:2946)
> at 
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.shouldPropertyBeExcludedForBlueprintExport(BlueprintConfigurationProcessor.java:939)
> at 
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.doFilterPriorToExport(BlueprintConfigurationProcessor.java:439)
> at 
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.doUpdateForBlueprintExport(BlueprintConfigurationProcessor.java:416)
> at 
> org.apache.ambari.server.api.query.render.ClusterBlueprintRenderer.createBlueprintResource(ClusterBlueprintRenderer.java:186)
> at 
> org.apache.ambari.server.api.query.render.ClusterBlueprintRenderer.finalizeResult(ClusterBlueprintRenderer.java:141)
> at org.apache.ambari.server.api.query.QueryImpl.getResult(QueryImpl.java:839)
> at org.apache.ambari.server.api.query.QueryImpl.execute(QueryImpl.java:223)
> at 
> org.apache.ambari.server.api.handlers.ReadHandler.handleRequest(ReadHandler.java:77)
> at 
> org.apache.ambari.server.api.services.BaseRequest.process(BaseRequest.java:145)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  db1aa074d4 
> 
> 
> Diff: https://reviews.apache.org/r/58122/diff/4/
> 
> 
> Testing
> ---
> 
> Tested manually. Log shows warning about unmapped config-type but blueprint 
> gets exported.
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>

Re: Review Request 58122: Blueprint export fails if config-type is not mapped to any service after upgrade

2017-04-06 Thread Amruta Borkar 


> On April 6, 2017, 11:13 p.m., Alejandro Fernandez wrote:
> > Ship It!

Thank you Alejandro,

Could you please help me push this to trunk?


- Amruta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58122/#review171274
---


On April 5, 2017, 11:45 p.m., Amruta Borkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58122/
> ---
> 
> (Updated April 5, 2017, 11:45 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Di Li, and Robert Nettleton.
> 
> 
> Bugs: AMBARI-20551
> https://issues.apache.org/jira/browse/AMBARI-20551
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Following error is thrown while exporting a blueprint from cluster.
>  ERROR [ambari-client-thread-8726] ReadHandler:99 - Bad request:
> java.lang.IllegalArgumentException: Specified configuration type is not 
> associated with any service: storm-site
> at 
> org.apache.ambari.server.controller.internal.Stack.getServiceForConfigType(Stack.java:494)
> at 
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor$StackPropertyTypeFilter.isPropertyIncluded(BlueprintConfigurationProcessor.java:2946)
> at 
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.shouldPropertyBeExcludedForBlueprintExport(BlueprintConfigurationProcessor.java:939)
> at 
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.doFilterPriorToExport(BlueprintConfigurationProcessor.java:439)
> at 
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.doUpdateForBlueprintExport(BlueprintConfigurationProcessor.java:416)
> at 
> org.apache.ambari.server.api.query.render.ClusterBlueprintRenderer.createBlueprintResource(ClusterBlueprintRenderer.java:186)
> at 
> org.apache.ambari.server.api.query.render.ClusterBlueprintRenderer.finalizeResult(ClusterBlueprintRenderer.java:141)
> at org.apache.ambari.server.api.query.QueryImpl.getResult(QueryImpl.java:839)
> at org.apache.ambari.server.api.query.QueryImpl.execute(QueryImpl.java:223)
> at 
> org.apache.ambari.server.api.handlers.ReadHandler.handleRequest(ReadHandler.java:77)
> at 
> org.apache.ambari.server.api.services.BaseRequest.process(BaseRequest.java:145)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  db1aa074d4 
> 
> 
> Diff: https://reviews.apache.org/r/58122/diff/4/
> 
> 
> Testing
> ---
> 
> Tested manually. Log shows warning about unmapped config-type but blueprint 
> gets exported.
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>

Re: Review Request 58122: Blueprint export fails if config-type is not mapped to any service after upgrade

2017-04-06 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58122/#review171274
---


Ship it!




Ship It!

- Alejandro Fernandez


On April 5, 2017, 11:45 p.m., Amruta Borkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58122/
> ---
> 
> (Updated April 5, 2017, 11:45 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Di Li, and Robert Nettleton.
> 
> 
> Bugs: AMBARI-20551
> https://issues.apache.org/jira/browse/AMBARI-20551
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Following error is thrown while exporting a blueprint from cluster.
>  ERROR [ambari-client-thread-8726] ReadHandler:99 - Bad request:
> java.lang.IllegalArgumentException: Specified configuration type is not 
> associated with any service: storm-site
> at 
> org.apache.ambari.server.controller.internal.Stack.getServiceForConfigType(Stack.java:494)
> at 
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor$StackPropertyTypeFilter.isPropertyIncluded(BlueprintConfigurationProcessor.java:2946)
> at 
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.shouldPropertyBeExcludedForBlueprintExport(BlueprintConfigurationProcessor.java:939)
> at 
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.doFilterPriorToExport(BlueprintConfigurationProcessor.java:439)
> at 
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.doUpdateForBlueprintExport(BlueprintConfigurationProcessor.java:416)
> at 
> org.apache.ambari.server.api.query.render.ClusterBlueprintRenderer.createBlueprintResource(ClusterBlueprintRenderer.java:186)
> at 
> org.apache.ambari.server.api.query.render.ClusterBlueprintRenderer.finalizeResult(ClusterBlueprintRenderer.java:141)
> at org.apache.ambari.server.api.query.QueryImpl.getResult(QueryImpl.java:839)
> at org.apache.ambari.server.api.query.QueryImpl.execute(QueryImpl.java:223)
> at 
> org.apache.ambari.server.api.handlers.ReadHandler.handleRequest(ReadHandler.java:77)
> at 
> org.apache.ambari.server.api.services.BaseRequest.process(BaseRequest.java:145)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  db1aa074d4 
> 
> 
> Diff: https://reviews.apache.org/r/58122/diff/4/
> 
> 
> Testing
> ---
> 
> Tested manually. Log shows warning about unmapped config-type but blueprint 
> gets exported.
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>

Re: Review Request 58122: Blueprint export fails if config-type is not mapped to any service after upgrade

2017-04-06 Thread Amruta Borkar 


> On April 5, 2017, 5:32 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
> > Lines 525 (patched)
> > 
> >
> > Missing spaces after the periods

Thanks Alejandro,
Could you please help me ppush this to trunk?


- Amruta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58122/#review171149
---


On April 5, 2017, 11:45 p.m., Amruta Borkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58122/
> ---
> 
> (Updated April 5, 2017, 11:45 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Di Li, and Robert Nettleton.
> 
> 
> Bugs: AMBARI-20551
> https://issues.apache.org/jira/browse/AMBARI-20551
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Following error is thrown while exporting a blueprint from cluster.
>  ERROR [ambari-client-thread-8726] ReadHandler:99 - Bad request:
> java.lang.IllegalArgumentException: Specified configuration type is not 
> associated with any service: storm-site
> at 
> org.apache.ambari.server.controller.internal.Stack.getServiceForConfigType(Stack.java:494)
> at 
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor$StackPropertyTypeFilter.isPropertyIncluded(BlueprintConfigurationProcessor.java:2946)
> at 
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.shouldPropertyBeExcludedForBlueprintExport(BlueprintConfigurationProcessor.java:939)
> at 
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.doFilterPriorToExport(BlueprintConfigurationProcessor.java:439)
> at 
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.doUpdateForBlueprintExport(BlueprintConfigurationProcessor.java:416)
> at 
> org.apache.ambari.server.api.query.render.ClusterBlueprintRenderer.createBlueprintResource(ClusterBlueprintRenderer.java:186)
> at 
> org.apache.ambari.server.api.query.render.ClusterBlueprintRenderer.finalizeResult(ClusterBlueprintRenderer.java:141)
> at org.apache.ambari.server.api.query.QueryImpl.getResult(QueryImpl.java:839)
> at org.apache.ambari.server.api.query.QueryImpl.execute(QueryImpl.java:223)
> at 
> org.apache.ambari.server.api.handlers.ReadHandler.handleRequest(ReadHandler.java:77)
> at 
> org.apache.ambari.server.api.services.BaseRequest.process(BaseRequest.java:145)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  db1aa074d4 
> 
> 
> Diff: https://reviews.apache.org/r/58122/diff/4/
> 
> 
> Testing
> ---
> 
> Tested manually. Log shows warning about unmapped config-type but blueprint 
> gets exported.
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>

Re: Review Request 58122: Blueprint export fails if config-type is not mapped to any service after upgrade

2017-04-06 Thread Di Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58122/#review171200
---


Ship it!




Ship It!

- Di Li


On April 5, 2017, 11:45 p.m., Amruta Borkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58122/
> ---
> 
> (Updated April 5, 2017, 11:45 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Di Li, and Robert Nettleton.
> 
> 
> Bugs: AMBARI-20551
> https://issues.apache.org/jira/browse/AMBARI-20551
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Following error is thrown while exporting a blueprint from cluster.
>  ERROR [ambari-client-thread-8726] ReadHandler:99 - Bad request:
> java.lang.IllegalArgumentException: Specified configuration type is not 
> associated with any service: storm-site
> at 
> org.apache.ambari.server.controller.internal.Stack.getServiceForConfigType(Stack.java:494)
> at 
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor$StackPropertyTypeFilter.isPropertyIncluded(BlueprintConfigurationProcessor.java:2946)
> at 
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.shouldPropertyBeExcludedForBlueprintExport(BlueprintConfigurationProcessor.java:939)
> at 
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.doFilterPriorToExport(BlueprintConfigurationProcessor.java:439)
> at 
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.doUpdateForBlueprintExport(BlueprintConfigurationProcessor.java:416)
> at 
> org.apache.ambari.server.api.query.render.ClusterBlueprintRenderer.createBlueprintResource(ClusterBlueprintRenderer.java:186)
> at 
> org.apache.ambari.server.api.query.render.ClusterBlueprintRenderer.finalizeResult(ClusterBlueprintRenderer.java:141)
> at org.apache.ambari.server.api.query.QueryImpl.getResult(QueryImpl.java:839)
> at org.apache.ambari.server.api.query.QueryImpl.execute(QueryImpl.java:223)
> at 
> org.apache.ambari.server.api.handlers.ReadHandler.handleRequest(ReadHandler.java:77)
> at 
> org.apache.ambari.server.api.services.BaseRequest.process(BaseRequest.java:145)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  db1aa074d4 
> 
> 
> Diff: https://reviews.apache.org/r/58122/diff/4/
> 
> 
> Testing
> ---
> 
> Tested manually. Log shows warning about unmapped config-type but blueprint 
> gets exported.
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>

Re: Review Request 58122: Blueprint export fails if config-type is not mapped to any service after upgrade

2017-04-05 Thread Amruta Borkar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58122/
---

(Updated April 5, 2017, 11:45 p.m.)


Review request for Ambari, Alejandro Fernandez, Di Li, and Robert Nettleton.


Changes
---

Modified to address the feedback comments.


Bugs: AMBARI-20551
https://issues.apache.org/jira/browse/AMBARI-20551


Repository: ambari


Description
---

Following error is thrown while exporting a blueprint from cluster.
 ERROR [ambari-client-thread-8726] ReadHandler:99 - Bad request:
java.lang.IllegalArgumentException: Specified configuration type is not 
associated with any service: storm-site
at 
org.apache.ambari.server.controller.internal.Stack.getServiceForConfigType(Stack.java:494)
at 
org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor$StackPropertyTypeFilter.isPropertyIncluded(BlueprintConfigurationProcessor.java:2946)
at 
org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.shouldPropertyBeExcludedForBlueprintExport(BlueprintConfigurationProcessor.java:939)
at 
org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.doFilterPriorToExport(BlueprintConfigurationProcessor.java:439)
at 
org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.doUpdateForBlueprintExport(BlueprintConfigurationProcessor.java:416)
at 
org.apache.ambari.server.api.query.render.ClusterBlueprintRenderer.createBlueprintResource(ClusterBlueprintRenderer.java:186)
at 
org.apache.ambari.server.api.query.render.ClusterBlueprintRenderer.finalizeResult(ClusterBlueprintRenderer.java:141)
at org.apache.ambari.server.api.query.QueryImpl.getResult(QueryImpl.java:839)
at org.apache.ambari.server.api.query.QueryImpl.execute(QueryImpl.java:223)
at 
org.apache.ambari.server.api.handlers.ReadHandler.handleRequest(ReadHandler.java:77)
at 
org.apache.ambari.server.api.services.BaseRequest.process(BaseRequest.java:145)


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
 db1aa074d4 


Diff: https://reviews.apache.org/r/58122/diff/4/

Changes: https://reviews.apache.org/r/58122/diff/3-4/


Testing
---

Tested manually. Log shows warning about unmapped config-type but blueprint 
gets exported.


Thanks,

Amruta Borkar

Re: Review Request 58122: Blueprint export fails if config-type is not mapped to any service after upgrade

2017-04-05 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58122/#review171149
---


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
Lines 525 (patched)


Missing spaces after the periods


- Alejandro Fernandez


On April 5, 2017, 4:58 p.m., Amruta Borkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58122/
> ---
> 
> (Updated April 5, 2017, 4:58 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Di Li, and Robert Nettleton.
> 
> 
> Bugs: AMBARI-20551
> https://issues.apache.org/jira/browse/AMBARI-20551
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Following error is thrown while exporting a blueprint from cluster.
>  ERROR [ambari-client-thread-8726] ReadHandler:99 - Bad request:
> java.lang.IllegalArgumentException: Specified configuration type is not 
> associated with any service: storm-site
> at 
> org.apache.ambari.server.controller.internal.Stack.getServiceForConfigType(Stack.java:494)
> at 
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor$StackPropertyTypeFilter.isPropertyIncluded(BlueprintConfigurationProcessor.java:2946)
> at 
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.shouldPropertyBeExcludedForBlueprintExport(BlueprintConfigurationProcessor.java:939)
> at 
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.doFilterPriorToExport(BlueprintConfigurationProcessor.java:439)
> at 
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.doUpdateForBlueprintExport(BlueprintConfigurationProcessor.java:416)
> at 
> org.apache.ambari.server.api.query.render.ClusterBlueprintRenderer.createBlueprintResource(ClusterBlueprintRenderer.java:186)
> at 
> org.apache.ambari.server.api.query.render.ClusterBlueprintRenderer.finalizeResult(ClusterBlueprintRenderer.java:141)
> at org.apache.ambari.server.api.query.QueryImpl.getResult(QueryImpl.java:839)
> at org.apache.ambari.server.api.query.QueryImpl.execute(QueryImpl.java:223)
> at 
> org.apache.ambari.server.api.handlers.ReadHandler.handleRequest(ReadHandler.java:77)
> at 
> org.apache.ambari.server.api.services.BaseRequest.process(BaseRequest.java:145)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  db1aa074d4 
> 
> 
> Diff: https://reviews.apache.org/r/58122/diff/3/
> 
> 
> Testing
> ---
> 
> Tested manually. Log shows warning about unmapped config-type but blueprint 
> gets exported.
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>

Re: Review Request 58122: Blueprint export fails if config-type is not mapped to any service after upgrade

2017-04-05 Thread Amruta Borkar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58122/
---

(Updated April 5, 2017, 4:58 p.m.)


Review request for Ambari, Di Li and Robert Nettleton.


Changes
---

Updated patch to address the comments


Bugs: AMBARI-20551
https://issues.apache.org/jira/browse/AMBARI-20551


Repository: ambari


Description
---

Following error is thrown while exporting a blueprint from cluster.
 ERROR [ambari-client-thread-8726] ReadHandler:99 - Bad request:
java.lang.IllegalArgumentException: Specified configuration type is not 
associated with any service: storm-site
at 
org.apache.ambari.server.controller.internal.Stack.getServiceForConfigType(Stack.java:494)
at 
org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor$StackPropertyTypeFilter.isPropertyIncluded(BlueprintConfigurationProcessor.java:2946)
at 
org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.shouldPropertyBeExcludedForBlueprintExport(BlueprintConfigurationProcessor.java:939)
at 
org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.doFilterPriorToExport(BlueprintConfigurationProcessor.java:439)
at 
org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.doUpdateForBlueprintExport(BlueprintConfigurationProcessor.java:416)
at 
org.apache.ambari.server.api.query.render.ClusterBlueprintRenderer.createBlueprintResource(ClusterBlueprintRenderer.java:186)
at 
org.apache.ambari.server.api.query.render.ClusterBlueprintRenderer.finalizeResult(ClusterBlueprintRenderer.java:141)
at org.apache.ambari.server.api.query.QueryImpl.getResult(QueryImpl.java:839)
at org.apache.ambari.server.api.query.QueryImpl.execute(QueryImpl.java:223)
at 
org.apache.ambari.server.api.handlers.ReadHandler.handleRequest(ReadHandler.java:77)
at 
org.apache.ambari.server.api.services.BaseRequest.process(BaseRequest.java:145)


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
 db1aa074d4 


Diff: https://reviews.apache.org/r/58122/diff/3/

Changes: https://reviews.apache.org/r/58122/diff/2-3/


Testing
---

Tested manually. Log shows warning about unmapped config-type but blueprint 
gets exported.


Thanks,

Amruta Borkar

Re: Review Request 58122: Blueprint export fails if config-type is not mapped to any service after upgrade

2017-04-04 Thread Robert Nettleton 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58122/#review171035
---


Ship it!




- Robert Nettleton


On April 3, 2017, 10:42 p.m., Amruta Borkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58122/
> ---
> 
> (Updated April 3, 2017, 10:42 p.m.)
> 
> 
> Review request for Ambari, Di Li and Robert Nettleton.
> 
> 
> Bugs: AMBARI-20551
> https://issues.apache.org/jira/browse/AMBARI-20551
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Following error is thrown while exporting a blueprint from cluster.
>  ERROR [ambari-client-thread-8726] ReadHandler:99 - Bad request:
> java.lang.IllegalArgumentException: Specified configuration type is not 
> associated with any service: storm-site
> at 
> org.apache.ambari.server.controller.internal.Stack.getServiceForConfigType(Stack.java:494)
> at 
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor$StackPropertyTypeFilter.isPropertyIncluded(BlueprintConfigurationProcessor.java:2946)
> at 
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.shouldPropertyBeExcludedForBlueprintExport(BlueprintConfigurationProcessor.java:939)
> at 
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.doFilterPriorToExport(BlueprintConfigurationProcessor.java:439)
> at 
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.doUpdateForBlueprintExport(BlueprintConfigurationProcessor.java:416)
> at 
> org.apache.ambari.server.api.query.render.ClusterBlueprintRenderer.createBlueprintResource(ClusterBlueprintRenderer.java:186)
> at 
> org.apache.ambari.server.api.query.render.ClusterBlueprintRenderer.finalizeResult(ClusterBlueprintRenderer.java:141)
> at org.apache.ambari.server.api.query.QueryImpl.getResult(QueryImpl.java:839)
> at org.apache.ambari.server.api.query.QueryImpl.execute(QueryImpl.java:223)
> at 
> org.apache.ambari.server.api.handlers.ReadHandler.handleRequest(ReadHandler.java:77)
> at 
> org.apache.ambari.server.api.services.BaseRequest.process(BaseRequest.java:145)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  db1aa074d4 
> 
> 
> Diff: https://reviews.apache.org/r/58122/diff/2/
> 
> 
> Testing
> ---
> 
> Tested manually. Log shows warning about unmapped config-type but blueprint 
> gets exported.
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>

Re: Review Request 58122: Blueprint export fails if config-type is not mapped to any service after upgrade

2017-04-04 Thread Di Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58122/#review171001
---




ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
Lines 523 (patched)


For performance, please avoid string concatenation, just use a long string 
as it is or use a stringbuffer/stringbuilder.


- Di Li


On April 3, 2017, 10:42 p.m., Amruta Borkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58122/
> ---
> 
> (Updated April 3, 2017, 10:42 p.m.)
> 
> 
> Review request for Ambari, Di Li and Robert Nettleton.
> 
> 
> Bugs: AMBARI-20551
> https://issues.apache.org/jira/browse/AMBARI-20551
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Following error is thrown while exporting a blueprint from cluster.
>  ERROR [ambari-client-thread-8726] ReadHandler:99 - Bad request:
> java.lang.IllegalArgumentException: Specified configuration type is not 
> associated with any service: storm-site
> at 
> org.apache.ambari.server.controller.internal.Stack.getServiceForConfigType(Stack.java:494)
> at 
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor$StackPropertyTypeFilter.isPropertyIncluded(BlueprintConfigurationProcessor.java:2946)
> at 
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.shouldPropertyBeExcludedForBlueprintExport(BlueprintConfigurationProcessor.java:939)
> at 
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.doFilterPriorToExport(BlueprintConfigurationProcessor.java:439)
> at 
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.doUpdateForBlueprintExport(BlueprintConfigurationProcessor.java:416)
> at 
> org.apache.ambari.server.api.query.render.ClusterBlueprintRenderer.createBlueprintResource(ClusterBlueprintRenderer.java:186)
> at 
> org.apache.ambari.server.api.query.render.ClusterBlueprintRenderer.finalizeResult(ClusterBlueprintRenderer.java:141)
> at org.apache.ambari.server.api.query.QueryImpl.getResult(QueryImpl.java:839)
> at org.apache.ambari.server.api.query.QueryImpl.execute(QueryImpl.java:223)
> at 
> org.apache.ambari.server.api.handlers.ReadHandler.handleRequest(ReadHandler.java:77)
> at 
> org.apache.ambari.server.api.services.BaseRequest.process(BaseRequest.java:145)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  db1aa074d4 
> 
> 
> Diff: https://reviews.apache.org/r/58122/diff/2/
> 
> 
> Testing
> ---
> 
> Tested manually. Log shows warning about unmapped config-type but blueprint 
> gets exported.
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>

Re: Review Request 58122: Blueprint export fails if config-type is not mapped to any service after upgrade

2017-04-03 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58122/#review170946
---




ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
Lines 523 (patched)


Warnings are going to be ignored. Let's change logger level to error


- Alejandro Fernandez


On April 3, 2017, 10:42 p.m., Amruta Borkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58122/
> ---
> 
> (Updated April 3, 2017, 10:42 p.m.)
> 
> 
> Review request for Ambari, Di Li and Robert Nettleton.
> 
> 
> Bugs: AMBARI-20551
> https://issues.apache.org/jira/browse/AMBARI-20551
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Following error is thrown while exporting a blueprint from cluster.
>  ERROR [ambari-client-thread-8726] ReadHandler:99 - Bad request:
> java.lang.IllegalArgumentException: Specified configuration type is not 
> associated with any service: storm-site
> at 
> org.apache.ambari.server.controller.internal.Stack.getServiceForConfigType(Stack.java:494)
> at 
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor$StackPropertyTypeFilter.isPropertyIncluded(BlueprintConfigurationProcessor.java:2946)
> at 
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.shouldPropertyBeExcludedForBlueprintExport(BlueprintConfigurationProcessor.java:939)
> at 
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.doFilterPriorToExport(BlueprintConfigurationProcessor.java:439)
> at 
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.doUpdateForBlueprintExport(BlueprintConfigurationProcessor.java:416)
> at 
> org.apache.ambari.server.api.query.render.ClusterBlueprintRenderer.createBlueprintResource(ClusterBlueprintRenderer.java:186)
> at 
> org.apache.ambari.server.api.query.render.ClusterBlueprintRenderer.finalizeResult(ClusterBlueprintRenderer.java:141)
> at org.apache.ambari.server.api.query.QueryImpl.getResult(QueryImpl.java:839)
> at org.apache.ambari.server.api.query.QueryImpl.execute(QueryImpl.java:223)
> at 
> org.apache.ambari.server.api.handlers.ReadHandler.handleRequest(ReadHandler.java:77)
> at 
> org.apache.ambari.server.api.services.BaseRequest.process(BaseRequest.java:145)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  db1aa074d4 
> 
> 
> Diff: https://reviews.apache.org/r/58122/diff/2/
> 
> 
> Testing
> ---
> 
> Tested manually. Log shows warning about unmapped config-type but blueprint 
> gets exported.
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>

Review Request 58122: Blueprint export fails if config-type is not mapped to any service after upgrade

2017-03-31 Thread Amruta Borkar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58122/
---

Review request for Ambari, Di Li and Robert Nettleton.


Bugs: AMBARI-20551
https://issues.apache.org/jira/browse/AMBARI-20551


Repository: ambari


Description
---

Following error is thrown while exporting a blueprint from cluster.
 ERROR [ambari-client-thread-8726] ReadHandler:99 - Bad request:
java.lang.IllegalArgumentException: Specified configuration type is not 
associated with any service: storm-site
at 
org.apache.ambari.server.controller.internal.Stack.getServiceForConfigType(Stack.java:494)
at 
org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor$StackPropertyTypeFilter.isPropertyIncluded(BlueprintConfigurationProcessor.java:2946)
at 
org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.shouldPropertyBeExcludedForBlueprintExport(BlueprintConfigurationProcessor.java:939)
at 
org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.doFilterPriorToExport(BlueprintConfigurationProcessor.java:439)
at 
org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.doUpdateForBlueprintExport(BlueprintConfigurationProcessor.java:416)
at 
org.apache.ambari.server.api.query.render.ClusterBlueprintRenderer.createBlueprintResource(ClusterBlueprintRenderer.java:186)
at 
org.apache.ambari.server.api.query.render.ClusterBlueprintRenderer.finalizeResult(ClusterBlueprintRenderer.java:141)
at org.apache.ambari.server.api.query.QueryImpl.getResult(QueryImpl.java:839)
at org.apache.ambari.server.api.query.QueryImpl.execute(QueryImpl.java:223)
at 
org.apache.ambari.server.api.handlers.ReadHandler.handleRequest(ReadHandler.java:77)
at 
org.apache.ambari.server.api.services.BaseRequest.process(BaseRequest.java:145)


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
 25f2001 


Diff: https://reviews.apache.org/r/58122/diff/1/


Testing
---

Tested manually. Log shows warning about unmapped config-type but blueprint 
gets exported.


Thanks,

Amruta Borkar