Re: Review Request 62851: Install and upgrade options are shown for current and already upgraded stack versions

2017-10-10 Thread Nate Cole 


> On Oct. 9, 2017, 10:15 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListener.java
> > Lines 149 (patched)
> > 
> >
> > Should we move this around the switch statement in case anymore case's 
> > are added in the future which should also be skipped?

I was thinking an if/continue before the switch - there's no other code after 
that.


- Nate


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62851/#review187486
---


On Oct. 9, 2017, 5:19 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62851/
> ---
> 
> (Updated Oct. 9, 2017, 5:19 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-22178
> https://issues.apache.org/jira/browse/AMBARI-22178
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The HostVersionOutOfSyncListener is incorrectly setting ALL other 
> host_version records to OUT_OF_SYNC other than what the newly-added component 
> is for.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListener.java
>  78744613ed 
>   
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java
>  076190a47d 
> 
> 
> Diff: https://reviews.apache.org/r/62851/diff/1/
> 
> 
> Testing
> ---
> 
> Manual added host and added new service to verify records.  Unit tests 
> pending.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 62851: Install and upgrade options are shown for current and already upgraded stack versions

2017-10-10 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62851/#review187510
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Oct. 10, 2017, 12:19 a.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62851/
> ---
> 
> (Updated Oct. 10, 2017, 12:19 a.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-22178
> https://issues.apache.org/jira/browse/AMBARI-22178
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The HostVersionOutOfSyncListener is incorrectly setting ALL other 
> host_version records to OUT_OF_SYNC other than what the newly-added component 
> is for.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListener.java
>  78744613ed 
>   
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java
>  076190a47d 
> 
> 
> Diff: https://reviews.apache.org/r/62851/diff/1/
> 
> 
> Testing
> ---
> 
> Manual added host and added new service to verify records.  Unit tests 
> pending.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 62851: Install and upgrade options are shown for current and already upgraded stack versions

2017-10-09 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62851/#review187486
---


Ship it!





ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListener.java
Lines 149 (patched)


Should we move this around the switch statement in case anymore case's are 
added in the future which should also be skipped?


- Jonathan Hurley


On Oct. 9, 2017, 5:19 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62851/
> ---
> 
> (Updated Oct. 9, 2017, 5:19 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-22178
> https://issues.apache.org/jira/browse/AMBARI-22178
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The HostVersionOutOfSyncListener is incorrectly setting ALL other 
> host_version records to OUT_OF_SYNC other than what the newly-added component 
> is for.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListener.java
>  78744613ed 
>   
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java
>  076190a47d 
> 
> 
> Diff: https://reviews.apache.org/r/62851/diff/1/
> 
> 
> Testing
> ---
> 
> Manual added host and added new service to verify records.  Unit tests 
> pending.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Review Request 62851: Install and upgrade options are shown for current and already upgraded stack versions

2017-10-09 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62851/
---

Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.


Bugs: AMBARI-22178
https://issues.apache.org/jira/browse/AMBARI-22178


Repository: ambari


Description
---

The HostVersionOutOfSyncListener is incorrectly setting ALL other host_version 
records to OUT_OF_SYNC other than what the newly-added component is for.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListener.java
 78744613ed 
  
ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java
 076190a47d 


Diff: https://reviews.apache.org/r/62851/diff/1/


Testing
---

Manual added host and added new service to verify records.  Unit tests pending.


Thanks,

Nate Cole