date:20160628

Re: Review Request 49218: Add support for Mesos Fetcher

2016-06-28 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49218/#review139932
---


Ship it!




Master (102f5f0) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On June 29, 2016, 4:36 a.m., Renan DelValle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49218/
> ---
> 
> (Updated June 29, 2016, 4:36 a.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Adding a URIs field to TaskConfig inside the ThriftAPI so that users are able 
> to specify resources they wish to download into the sandbox per job.
> 
> 
> Diffs
> -
> 
>   RELEASE-NOTES.md af2061c7605c12a066778bd99ec1a3857bee6dec 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> 3e6daf53dd563dd7a2d494cc95e9a0aba0b6 
>   docs/features/mesos-fetcher.md PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
> 6c7c75ac86458884bc767736caf47fb56fc8 
>   src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 
> 8103163f5584ed3b0946cd02ec596b5aa75f4475 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  fe18c0f9876a736ea34d4eab92219013cd1e 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> 3b01801d929dd61ee989495bf38af8f03e9f5ad4 
>   src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigManager.java 
> c76164292cf62d2181374c09f8bf6d8d3358e982 
>   src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.java 
> 571201094c1e576e496495a01cb83f6c57decfa8 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/migration/V007_CreateMesosFetcherURIsTable.java
>  PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DbTaskConfig.java 
> a90cb00e240df25dce6d55728859768e22d741a6 
>   
> src/main/resources/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.xml
>  2c8af8b88e41b3b381cac831fd43b1057e4df0aa 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
> 5069bedc08bb7111d0e0f101c8a2c81495b97bc9 
>   
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
>  2dff80b5213e98c778d71955517e5f9227d7d0c1 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> 58785bfa37ff214f26e9f94d836e6df40e411c3b 
>   
> src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java 
> b1593f682f48ea66339bc2372de3e4f14e40be32 
>   src/test/java/org/apache/aurora/scheduler/thrift/Fixtures.java 
> a883b0e33bfec1d14e6fe4ee8ed2200d93acaeec 
>   src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 
> ed69996593f5556d80a9229063ef5c7d658e2cfb 
> 
> Diff: https://reviews.apache.org/r/49218/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build -Pq
> bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> Tested with a custom client submitting TaskConfigs which included URIs when 
> the -enable_mesos_fetcher_for_jobs flag was on as well as when it was off.
> 
> 
> Thanks,
> 
> Renan DelValle
> 
>

Re: Review Request 49218: Add support for Mesos Fetcher

2016-06-28 Thread Renan DelValle


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49218/
---

(Updated June 28, 2016, 9:36 p.m.)


Review request for Aurora.


Changes
---

Added Mesos issue to TODO which tracks output_file attribute for Mesos URI 
fetcher.

Merged in master before submitting.


Repository: aurora


Description
---

Adding a URIs field to TaskConfig inside the ThriftAPI so that users are able 
to specify resources they wish to download into the sandbox per job.


Diffs (updated)
-

  RELEASE-NOTES.md af2061c7605c12a066778bd99ec1a3857bee6dec 
  api/src/main/thrift/org/apache/aurora/gen/api.thrift 
3e6daf53dd563dd7a2d494cc95e9a0aba0b6 
  docs/features/mesos-fetcher.md PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
6c7c75ac86458884bc767736caf47fb56fc8 
  src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 
8103163f5584ed3b0946cd02ec596b5aa75f4475 
  
src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
 fe18c0f9876a736ea34d4eab92219013cd1e 
  src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
3b01801d929dd61ee989495bf38af8f03e9f5ad4 
  src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigManager.java 
c76164292cf62d2181374c09f8bf6d8d3358e982 
  src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.java 
571201094c1e576e496495a01cb83f6c57decfa8 
  
src/main/java/org/apache/aurora/scheduler/storage/db/migration/V007_CreateMesosFetcherURIsTable.java
 PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/storage/db/views/DbTaskConfig.java 
a90cb00e240df25dce6d55728859768e22d741a6 
  
src/main/resources/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.xml 
2c8af8b88e41b3b381cac831fd43b1057e4df0aa 
  src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
5069bedc08bb7111d0e0f101c8a2c81495b97bc9 
  
src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
 2dff80b5213e98c778d71955517e5f9227d7d0c1 
  src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
58785bfa37ff214f26e9f94d836e6df40e411c3b 
  src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java 
b1593f682f48ea66339bc2372de3e4f14e40be32 
  src/test/java/org/apache/aurora/scheduler/thrift/Fixtures.java 
a883b0e33bfec1d14e6fe4ee8ed2200d93acaeec 
  src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 
ed69996593f5556d80a9229063ef5c7d658e2cfb 

Diff: https://reviews.apache.org/r/49218/diff/


Testing
---

./gradlew build -Pq
bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh

Tested with a custom client submitting TaskConfigs which included URIs when the 
-enable_mesos_fetcher_for_jobs flag was on as well as when it was off.


Thanks,

Renan DelValle

Re: Review Request 49218: Add support for Mesos Fetcher

2016-06-28 Thread Renan DelValle



> On June 28, 2016, 8:46 p.m., Joshua Cohen wrote:
> > src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java, line 
> > 267
> > 
> >
> > Is there a mesos ticket tracking this? If so, can you add it here?

Done, looks like this was added in Mesos 0.29. This also made me realize I 
forgot an L in my last name. That's what you get when 3/8ths of your last name 
are the same letter :|.


> On June 28, 2016, 8:46 p.m., Joshua Cohen wrote:
> > src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java,
> >  line 301
> > 
> >
> > It's hard to tell from looking at the review, do we have the inverse of 
> > this scenario covered as well (i.e. mesos fetcher is disabled and task 
> > config has no mesos fetcher uris set)? If not, would you mind adding 
> > coverage for that?

This case should be covered in testGpuResourcesNotAllowed. It has the Mesos 
Fetcher disabled and the task config has no fetcher URIs set. The other case 
that is also handled in other tests is when mesos_fetcher is enabled but no 
fetcher URIs have been provided as well.


- Renan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49218/#review139926
---


On June 28, 2016, 2:39 p.m., Renan DelValle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49218/
> ---
> 
> (Updated June 28, 2016, 2:39 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Adding a URIs field to TaskConfig inside the ThriftAPI so that users are able 
> to specify resources they wish to download into the sandbox per job.
> 
> 
> Diffs
> -
> 
>   RELEASE-NOTES.md af2061c7605c12a066778bd99ec1a3857bee6dec 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> 3e6daf53dd563dd7a2d494cc95e9a0aba0b6 
>   docs/features/mesos-fetcher.md PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
> 6c7c75ac86458884bc767736caf47fb56fc8 
>   src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 
> 4089b79da8079243703eead884e80bcf736f8b29 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  fe18c0f9876a736ea34d4eab92219013cd1e 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> 3b01801d929dd61ee989495bf38af8f03e9f5ad4 
>   src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigManager.java 
> c76164292cf62d2181374c09f8bf6d8d3358e982 
>   src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.java 
> 571201094c1e576e496495a01cb83f6c57decfa8 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/migration/V007_CreateMesosFetcherURIsTable.java
>  PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DbTaskConfig.java 
> a90cb00e240df25dce6d55728859768e22d741a6 
>   
> src/main/resources/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.xml
>  2c8af8b88e41b3b381cac831fd43b1057e4df0aa 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
> 5069bedc08bb7111d0e0f101c8a2c81495b97bc9 
>   
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
>  2dff80b5213e98c778d71955517e5f9227d7d0c1 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> 58785bfa37ff214f26e9f94d836e6df40e411c3b 
>   
> src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java 
> b1593f682f48ea66339bc2372de3e4f14e40be32 
>   src/test/java/org/apache/aurora/scheduler/thrift/Fixtures.java 
> a883b0e33bfec1d14e6fe4ee8ed2200d93acaeec 
>   src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 
> ed69996593f5556d80a9229063ef5c7d658e2cfb 
> 
> Diff: https://reviews.apache.org/r/49218/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build -Pq
> bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> Tested with a custom client submitting TaskConfigs which included URIs when 
> the -enable_mesos_fetcher_for_jobs flag was on as well as when it was off.
> 
> 
> Thanks,
> 
> Renan DelValle
> 
>

Re: Review Request 49218: Add support for Mesos Fetcher

2016-06-28 Thread Joshua Cohen


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49218/#review139926
---


Fix it, then Ship it!




lgtm modulo the below. Please fix or drop issues as warranted and then I can 
commit this.


src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java (line 267)


Is there a mesos ticket tracking this? If so, can you add it here?



src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java (lines 
270 - 271)


Duplicate calls to `setExecutable`?



src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
 (line 301)


It's hard to tell from looking at the review, do we have the inverse of 
this scenario covered as well (i.e. mesos fetcher is disabled and task config 
has no mesos fetcher uris set)? If not, would you mind adding coverage for that?


- Joshua Cohen


On June 28, 2016, 9:39 p.m., Renan DelValle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49218/
> ---
> 
> (Updated June 28, 2016, 9:39 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Adding a URIs field to TaskConfig inside the ThriftAPI so that users are able 
> to specify resources they wish to download into the sandbox per job.
> 
> 
> Diffs
> -
> 
>   RELEASE-NOTES.md af2061c7605c12a066778bd99ec1a3857bee6dec 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> 3e6daf53dd563dd7a2d494cc95e9a0aba0b6 
>   docs/features/mesos-fetcher.md PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
> 6c7c75ac86458884bc767736caf47fb56fc8 
>   src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 
> 4089b79da8079243703eead884e80bcf736f8b29 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  fe18c0f9876a736ea34d4eab92219013cd1e 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> 3b01801d929dd61ee989495bf38af8f03e9f5ad4 
>   src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigManager.java 
> c76164292cf62d2181374c09f8bf6d8d3358e982 
>   src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.java 
> 571201094c1e576e496495a01cb83f6c57decfa8 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/migration/V007_CreateMesosFetcherURIsTable.java
>  PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DbTaskConfig.java 
> a90cb00e240df25dce6d55728859768e22d741a6 
>   
> src/main/resources/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.xml
>  2c8af8b88e41b3b381cac831fd43b1057e4df0aa 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
> 5069bedc08bb7111d0e0f101c8a2c81495b97bc9 
>   
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
>  2dff80b5213e98c778d71955517e5f9227d7d0c1 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> 58785bfa37ff214f26e9f94d836e6df40e411c3b 
>   
> src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java 
> b1593f682f48ea66339bc2372de3e4f14e40be32 
>   src/test/java/org/apache/aurora/scheduler/thrift/Fixtures.java 
> a883b0e33bfec1d14e6fe4ee8ed2200d93acaeec 
>   src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 
> ed69996593f5556d80a9229063ef5c7d658e2cfb 
> 
> Diff: https://reviews.apache.org/r/49218/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build -Pq
> bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> Tested with a custom client submitting TaskConfigs which included URIs when 
> the -enable_mesos_fetcher_for_jobs flag was on as well as when it was off.
> 
> 
> Thanks,
> 
> Renan DelValle
> 
>

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-06-28 Thread Joshua Cohen


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49048/#review139923
---


Ship it!




- Joshua Cohen


On June 28, 2016, 11:57 p.m., Mehrdad Nurolahzade wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49048/
> ---
> 
> (Updated June 28, 2016, 11:57 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1710
> https://issues.apache.org/jira/browse/AURORA-1710
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-1710 Make 'tier' required and remove support for 'production' flag in 
> Job configuration - CLI changes
> 
> 
> Diffs
> -
> 
>   RELEASE-NOTES.md af2061c7605c12a066778bd99ec1a3857bee6dec 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 68baf8fdb90cd26100159401c46c9963c24332b3 
>   src/main/python/apache/aurora/client/cli/context.py 
> 9b1511801d031ff48b81c25688a55cb586b8ac66 
>   src/main/python/apache/aurora/client/config.py 
> 2fc12559016d406c347adb416a5166cca31c961e 
>   src/test/python/apache/aurora/client/cli/test_command_hooks.py 
> 2130f1fa71be02a004cdf8e476a270c81a7105d3 
>   src/test/python/apache/aurora/client/cli/test_context.py 
> 204ca092adad8bf43c5032a02f61bf303fb0b2fc 
>   src/test/python/apache/aurora/client/cli/test_create.py 
> 8c27e2b340bb0a5fb5bcb44ef94d433e7f92c76c 
>   src/test/python/apache/aurora/client/cli/test_cron.py 
> f3c522ed94a2d774865811ceb546bf9df083c14f 
>   src/test/python/apache/aurora/client/cli/test_plugins.py 
> a545fece5e2b3e0017a61e1be9ac478372b1f34d 
>   src/test/python/apache/aurora/client/cli/test_restart.py 
> 967d560e5c7eb0ed85b215fb11d9751b8666acb5 
>   src/test/python/apache/aurora/client/cli/util.py 
> 7b4558ec7f0fb0fd2902591bc6a90dc15051dd6e 
>   src/test/python/apache/aurora/client/test_config.py 
> b1a3c1865819899ef19173be0f861783a2631d0a 
> 
> Diff: https://reviews.apache.org/r/49048/diff/
> 
> 
> Testing
> ---
> 
> ```
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> *** OK (All tests passed) ***
> 
> mesos-master start/running, process 26868
> + RETCODE=0
> + restore_netrc
> + mv /home/vagrant/.netrc.bak /home/vagrant/.netrc
> + true
> Connection to 127.0.0.1 closed.
> 
> real  19m46.324s
> user  0m1.496s
> sys   0m0.774s
> ```
> 
> 
> Thanks,
> 
> Mehrdad Nurolahzade
> 
>

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-06-28 Thread Mehrdad Nurolahzade


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49048/
---

(Updated June 28, 2016, 4:57 p.m.)


Review request for Aurora, Joshua Cohen and Maxim Khutornenko.


Bugs: AURORA-1710
https://issues.apache.org/jira/browse/AURORA-1710


Repository: aurora


Description
---

AURORA-1710 Make 'tier' required and remove support for 'production' flag in 
Job configuration - CLI changes


Diffs
-

  RELEASE-NOTES.md af2061c7605c12a066778bd99ec1a3857bee6dec 
  src/main/python/apache/aurora/client/api/__init__.py 
68baf8fdb90cd26100159401c46c9963c24332b3 
  src/main/python/apache/aurora/client/cli/context.py 
9b1511801d031ff48b81c25688a55cb586b8ac66 
  src/main/python/apache/aurora/client/config.py 
2fc12559016d406c347adb416a5166cca31c961e 
  src/test/python/apache/aurora/client/cli/test_command_hooks.py 
2130f1fa71be02a004cdf8e476a270c81a7105d3 
  src/test/python/apache/aurora/client/cli/test_context.py 
204ca092adad8bf43c5032a02f61bf303fb0b2fc 
  src/test/python/apache/aurora/client/cli/test_create.py 
8c27e2b340bb0a5fb5bcb44ef94d433e7f92c76c 
  src/test/python/apache/aurora/client/cli/test_cron.py 
f3c522ed94a2d774865811ceb546bf9df083c14f 
  src/test/python/apache/aurora/client/cli/test_plugins.py 
a545fece5e2b3e0017a61e1be9ac478372b1f34d 
  src/test/python/apache/aurora/client/cli/test_restart.py 
967d560e5c7eb0ed85b215fb11d9751b8666acb5 
  src/test/python/apache/aurora/client/cli/util.py 
7b4558ec7f0fb0fd2902591bc6a90dc15051dd6e 
  src/test/python/apache/aurora/client/test_config.py 
b1a3c1865819899ef19173be0f861783a2631d0a 

Diff: https://reviews.apache.org/r/49048/diff/


Testing
---

```
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh

*** OK (All tests passed) ***

mesos-master start/running, process 26868
+ RETCODE=0
+ restore_netrc
+ mv /home/vagrant/.netrc.bak /home/vagrant/.netrc
+ true
Connection to 127.0.0.1 closed.

real19m46.324s
user0m1.496s
sys 0m0.774s
```


Thanks,

Mehrdad Nurolahzade

Re: Review Request 49334: AURORA-1725 Expose tier configurations as a debug page

2016-06-28 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49334/#review139893
---


Ship it!




Ship It!

- Maxim Khutornenko


On June 28, 2016, 10:04 p.m., Mehrdad Nurolahzade wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49334/
> ---
> 
> (Updated June 28, 2016, 10:04 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-1725 Expose tier configurations as a debug page
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 
> 4089b79da8079243703eead884e80bcf736f8b29 
>   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
> 496cd5590d6042d30e7bd0410a6c40d804c15023 
>   src/main/java/org/apache/aurora/scheduler/http/Tiers.java PRE-CREATION 
>   src/main/resources/scheduler/assets/index.html 
> eca27e081950a66b743f79ae7ae3d08e4625d2c8 
>   src/test/java/org/apache/aurora/scheduler/TierManagerTest.java 
> 7d9b3330b8c2b7a87b4dc3adfff94e40ef25d294 
>   src/test/java/org/apache/aurora/scheduler/http/AbstractJettyTest.java 
> 561b134152113a50ff495cef28d2396b56d02f1c 
>   src/test/java/org/apache/aurora/scheduler/http/TiersTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/49334/diff/
> 
> 
> Testing
> ---
> 
> Comments:
> - Logged the work done so far (new ```/tiers``` debug page) to this ticket 
> and kept AURORA-1710 for modifications to scheduler UI. 
> - Added comments to AURORA-1710 to clarify the suggested approach for 
> implementation.
> 
> Testing:
> ```
> ./build-support/jenkins/build.sh
> ...
> 
> *** OK (All tests passed) ***
> 
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ...
> mesos-master start/running, process 18776
> + RETCODE=0
> + restore_netrc
> + mv /home/vagrant/.netrc.bak /home/vagrant/.netrc
> + true
> Connection to 127.0.0.1 closed.
> 
> real  15m5.795s
> user  0m1.318s
> sys   0m0.533s
> ```
> 
> 
> Thanks,
> 
> Mehrdad Nurolahzade
> 
>

Re: Review Request 49218: Add support for Mesos Fetcher

2016-06-28 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49218/#review139892
---


Ship it!




Anyone else wants to review this change? If not I will commit it tomorrow.

- Maxim Khutornenko


On June 28, 2016, 9:39 p.m., Renan DelValle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49218/
> ---
> 
> (Updated June 28, 2016, 9:39 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Adding a URIs field to TaskConfig inside the ThriftAPI so that users are able 
> to specify resources they wish to download into the sandbox per job.
> 
> 
> Diffs
> -
> 
>   RELEASE-NOTES.md af2061c7605c12a066778bd99ec1a3857bee6dec 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> 3e6daf53dd563dd7a2d494cc95e9a0aba0b6 
>   docs/features/mesos-fetcher.md PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
> 6c7c75ac86458884bc767736caf47fb56fc8 
>   src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 
> 4089b79da8079243703eead884e80bcf736f8b29 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  fe18c0f9876a736ea34d4eab92219013cd1e 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> 3b01801d929dd61ee989495bf38af8f03e9f5ad4 
>   src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigManager.java 
> c76164292cf62d2181374c09f8bf6d8d3358e982 
>   src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.java 
> 571201094c1e576e496495a01cb83f6c57decfa8 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/migration/V007_CreateMesosFetcherURIsTable.java
>  PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DbTaskConfig.java 
> a90cb00e240df25dce6d55728859768e22d741a6 
>   
> src/main/resources/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.xml
>  2c8af8b88e41b3b381cac831fd43b1057e4df0aa 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
> 5069bedc08bb7111d0e0f101c8a2c81495b97bc9 
>   
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
>  2dff80b5213e98c778d71955517e5f9227d7d0c1 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> 58785bfa37ff214f26e9f94d836e6df40e411c3b 
>   
> src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java 
> b1593f682f48ea66339bc2372de3e4f14e40be32 
>   src/test/java/org/apache/aurora/scheduler/thrift/Fixtures.java 
> a883b0e33bfec1d14e6fe4ee8ed2200d93acaeec 
>   src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 
> ed69996593f5556d80a9229063ef5c7d658e2cfb 
> 
> Diff: https://reviews.apache.org/r/49218/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build -Pq
> bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> Tested with a custom client submitting TaskConfigs which included URIs when 
> the -enable_mesos_fetcher_for_jobs flag was on as well as when it was off.
> 
> 
> Thanks,
> 
> Renan DelValle
> 
>

Re: Review Request 49334: AURORA-1725 Expose tier configurations as a debug page

2016-06-28 Thread David McLaughlin



> On June 28, 2016, 8:53 p.m., David McLaughlin wrote:
> > config/legacy_untested_classes.txt, line 44
> > 
> >
> > Isn't this a fairly easy class to test?
> 
> Mehrdad Nurolahzade wrote:
> I wrote a test for it initially but then I ran into a few problems 
> interesting problems but then eventually gave up. Seems like many other http 
> endpoints have remained untested for a similar reason. I can get behind 
> finding a solution for this testing problem though.
> 
> The ```getTiers()``` call uses ```MessageBodyWriter``` to serialize the 
> ```Map```. The elements in that map can be ordered randomly (depending on map 
> implementation) which makes String equality difficult. That was the easier 
> problem to solve, I used ```LinkedHashMap``` in test fixtures to force 
> determinstic order of elements in the map.
> 
> Then, I ran into the problem of Jackson ordering ```TierInfo``` 
> properties in undeterminstic order. That is, a tier can be serialized as 
> ```"perferred":{"preemptible":false,"revocable":false}``` or 
> ```"perferred":{"revocable":false,"preemptible":false}```. A quick Google 
> search suggested that application of @JasonPropertyOrder on ```TierInfo``` 
> can result in deterministic property serialization order but it did not work 
> for me (potentially because of mocking but I am not sure).
> 
> Anyways, after burning some time here I decided to give up. Let me know 
> if you have any suggestion for testing.
> 
> Mehrdad Nurolahzade wrote:
> Found a simple solution using GSON. Will update this review board shortly.

Thanks!


- David


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49334/#review139857
---


On June 28, 2016, 10:04 p.m., Mehrdad Nurolahzade wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49334/
> ---
> 
> (Updated June 28, 2016, 10:04 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-1725 Expose tier configurations as a debug page
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 
> 4089b79da8079243703eead884e80bcf736f8b29 
>   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
> 496cd5590d6042d30e7bd0410a6c40d804c15023 
>   src/main/java/org/apache/aurora/scheduler/http/Tiers.java PRE-CREATION 
>   src/main/resources/scheduler/assets/index.html 
> eca27e081950a66b743f79ae7ae3d08e4625d2c8 
>   src/test/java/org/apache/aurora/scheduler/TierManagerTest.java 
> 7d9b3330b8c2b7a87b4dc3adfff94e40ef25d294 
>   src/test/java/org/apache/aurora/scheduler/http/AbstractJettyTest.java 
> 561b134152113a50ff495cef28d2396b56d02f1c 
>   src/test/java/org/apache/aurora/scheduler/http/TiersTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/49334/diff/
> 
> 
> Testing
> ---
> 
> Comments:
> - Logged the work done so far (new ```/tiers``` debug page) to this ticket 
> and kept AURORA-1710 for modifications to scheduler UI. 
> - Added comments to AURORA-1710 to clarify the suggested approach for 
> implementation.
> 
> Testing:
> ```
> ./build-support/jenkins/build.sh
> ...
> 
> *** OK (All tests passed) ***
> 
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ...
> mesos-master start/running, process 18776
> + RETCODE=0
> + restore_netrc
> + mv /home/vagrant/.netrc.bak /home/vagrant/.netrc
> + true
> Connection to 127.0.0.1 closed.
> 
> real  15m5.795s
> user  0m1.318s
> sys   0m0.533s
> ```
> 
> 
> Thanks,
> 
> Mehrdad Nurolahzade
> 
>

Re: Review Request 49334: AURORA-1725 Expose tier configurations as a debug page

2016-06-28 Thread David McLaughlin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49334/#review139888
---


Ship it!




Ship It!

- David McLaughlin


On June 28, 2016, 10:04 p.m., Mehrdad Nurolahzade wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49334/
> ---
> 
> (Updated June 28, 2016, 10:04 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-1725 Expose tier configurations as a debug page
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 
> 4089b79da8079243703eead884e80bcf736f8b29 
>   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
> 496cd5590d6042d30e7bd0410a6c40d804c15023 
>   src/main/java/org/apache/aurora/scheduler/http/Tiers.java PRE-CREATION 
>   src/main/resources/scheduler/assets/index.html 
> eca27e081950a66b743f79ae7ae3d08e4625d2c8 
>   src/test/java/org/apache/aurora/scheduler/TierManagerTest.java 
> 7d9b3330b8c2b7a87b4dc3adfff94e40ef25d294 
>   src/test/java/org/apache/aurora/scheduler/http/AbstractJettyTest.java 
> 561b134152113a50ff495cef28d2396b56d02f1c 
>   src/test/java/org/apache/aurora/scheduler/http/TiersTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/49334/diff/
> 
> 
> Testing
> ---
> 
> Comments:
> - Logged the work done so far (new ```/tiers``` debug page) to this ticket 
> and kept AURORA-1710 for modifications to scheduler UI. 
> - Added comments to AURORA-1710 to clarify the suggested approach for 
> implementation.
> 
> Testing:
> ```
> ./build-support/jenkins/build.sh
> ...
> 
> *** OK (All tests passed) ***
> 
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ...
> mesos-master start/running, process 18776
> + RETCODE=0
> + restore_netrc
> + mv /home/vagrant/.netrc.bak /home/vagrant/.netrc
> + true
> Connection to 127.0.0.1 closed.
> 
> real  15m5.795s
> user  0m1.318s
> sys   0m0.533s
> ```
> 
> 
> Thanks,
> 
> Mehrdad Nurolahzade
> 
>

Re: Review Request 49334: AURORA-1725 Expose tier configurations as a debug page

2016-06-28 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49334/#review139885
---


Ship it!




Master (499b11b) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On June 28, 2016, 10:04 p.m., Mehrdad Nurolahzade wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49334/
> ---
> 
> (Updated June 28, 2016, 10:04 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-1725 Expose tier configurations as a debug page
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 
> 4089b79da8079243703eead884e80bcf736f8b29 
>   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
> 496cd5590d6042d30e7bd0410a6c40d804c15023 
>   src/main/java/org/apache/aurora/scheduler/http/Tiers.java PRE-CREATION 
>   src/main/resources/scheduler/assets/index.html 
> eca27e081950a66b743f79ae7ae3d08e4625d2c8 
>   src/test/java/org/apache/aurora/scheduler/TierManagerTest.java 
> 7d9b3330b8c2b7a87b4dc3adfff94e40ef25d294 
>   src/test/java/org/apache/aurora/scheduler/http/AbstractJettyTest.java 
> 561b134152113a50ff495cef28d2396b56d02f1c 
>   src/test/java/org/apache/aurora/scheduler/http/TiersTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/49334/diff/
> 
> 
> Testing
> ---
> 
> Comments:
> - Logged the work done so far (new ```/tiers``` debug page) to this ticket 
> and kept AURORA-1710 for modifications to scheduler UI. 
> - Added comments to AURORA-1710 to clarify the suggested approach for 
> implementation.
> 
> Testing:
> ```
> ./build-support/jenkins/build.sh
> ...
> 
> *** OK (All tests passed) ***
> 
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ...
> mesos-master start/running, process 18776
> + RETCODE=0
> + restore_netrc
> + mv /home/vagrant/.netrc.bak /home/vagrant/.netrc
> + true
> Connection to 127.0.0.1 closed.
> 
> real  15m5.795s
> user  0m1.318s
> sys   0m0.533s
> ```
> 
> 
> Thanks,
> 
> Mehrdad Nurolahzade
> 
>

Re: Review Request 49218: Add support for Mesos Fetcher

2016-06-28 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49218/#review139876
---


Ship it!




Master (499b11b) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On June 28, 2016, 9:39 p.m., Renan DelValle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49218/
> ---
> 
> (Updated June 28, 2016, 9:39 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Adding a URIs field to TaskConfig inside the ThriftAPI so that users are able 
> to specify resources they wish to download into the sandbox per job.
> 
> 
> Diffs
> -
> 
>   RELEASE-NOTES.md af2061c7605c12a066778bd99ec1a3857bee6dec 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> 3e6daf53dd563dd7a2d494cc95e9a0aba0b6 
>   docs/features/mesos-fetcher.md PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
> 6c7c75ac86458884bc767736caf47fb56fc8 
>   src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 
> 4089b79da8079243703eead884e80bcf736f8b29 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  fe18c0f9876a736ea34d4eab92219013cd1e 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> 3b01801d929dd61ee989495bf38af8f03e9f5ad4 
>   src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigManager.java 
> c76164292cf62d2181374c09f8bf6d8d3358e982 
>   src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.java 
> 571201094c1e576e496495a01cb83f6c57decfa8 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/migration/V007_CreateMesosFetcherURIsTable.java
>  PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DbTaskConfig.java 
> a90cb00e240df25dce6d55728859768e22d741a6 
>   
> src/main/resources/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.xml
>  2c8af8b88e41b3b381cac831fd43b1057e4df0aa 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
> 5069bedc08bb7111d0e0f101c8a2c81495b97bc9 
>   
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
>  2dff80b5213e98c778d71955517e5f9227d7d0c1 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> 58785bfa37ff214f26e9f94d836e6df40e411c3b 
>   
> src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java 
> b1593f682f48ea66339bc2372de3e4f14e40be32 
>   src/test/java/org/apache/aurora/scheduler/thrift/Fixtures.java 
> a883b0e33bfec1d14e6fe4ee8ed2200d93acaeec 
>   src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 
> ed69996593f5556d80a9229063ef5c7d658e2cfb 
> 
> Diff: https://reviews.apache.org/r/49218/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build -Pq
> bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> Tested with a custom client submitting TaskConfigs which included URIs when 
> the -enable_mesos_fetcher_for_jobs flag was on as well as when it was off.
> 
> 
> Thanks,
> 
> Renan DelValle
> 
>

Re: Review Request 49339: Update install docs to for Aurora 0.14.0

2016-06-28 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49339/#review139874
---


Ship it!




Master (499b11b) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On June 28, 2016, 9:55 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49339/
> ---
> 
> (Updated June 28, 2016, 9:55 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Update install docs to for Aurora 0.14.0
> 
> *WIP:* This will only work once we have actually published binaries for 0.14 
> (and we haven't even signed-off 0.13, yet).
> 
> 
> Diffs
> -
> 
>   docs/operations/installation.md d3fb529929aaf8975579930d50a59e155d1e4357 
> 
> Diff: https://reviews.apache.org/r/49339/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 49334: AURORA-1725 Expose tier configurations as a debug page

2016-06-28 Thread Mehrdad Nurolahzade


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49334/
---

(Updated June 28, 2016, 3:04 p.m.)


Review request for Aurora, David McLaughlin and Maxim Khutornenko.


Changes
---

Added unit test


Repository: aurora


Description
---

AURORA-1725 Expose tier configurations as a debug page


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 
4089b79da8079243703eead884e80bcf736f8b29 
  src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
496cd5590d6042d30e7bd0410a6c40d804c15023 
  src/main/java/org/apache/aurora/scheduler/http/Tiers.java PRE-CREATION 
  src/main/resources/scheduler/assets/index.html 
eca27e081950a66b743f79ae7ae3d08e4625d2c8 
  src/test/java/org/apache/aurora/scheduler/TierManagerTest.java 
7d9b3330b8c2b7a87b4dc3adfff94e40ef25d294 
  src/test/java/org/apache/aurora/scheduler/http/AbstractJettyTest.java 
561b134152113a50ff495cef28d2396b56d02f1c 
  src/test/java/org/apache/aurora/scheduler/http/TiersTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/49334/diff/


Testing
---

Comments:
- Logged the work done so far (new ```/tiers``` debug page) to this ticket and 
kept AURORA-1710 for modifications to scheduler UI. 
- Added comments to AURORA-1710 to clarify the suggested approach for 
implementation.

Testing:
```
./build-support/jenkins/build.sh
...

*** OK (All tests passed) ***

./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
...
mesos-master start/running, process 18776
+ RETCODE=0
+ restore_netrc
+ mv /home/vagrant/.netrc.bak /home/vagrant/.netrc
+ true
Connection to 127.0.0.1 closed.

real15m5.795s
user0m1.318s
sys 0m0.533s
```


Thanks,

Mehrdad Nurolahzade

Re: Review Request 49334: AURORA-1725 Expose tier configurations as a debug page

2016-06-28 Thread Mehrdad Nurolahzade



> On June 28, 2016, 1:53 p.m., David McLaughlin wrote:
> > config/legacy_untested_classes.txt, line 44
> > 
> >
> > Isn't this a fairly easy class to test?
> 
> Mehrdad Nurolahzade wrote:
> I wrote a test for it initially but then I ran into a few problems 
> interesting problems but then eventually gave up. Seems like many other http 
> endpoints have remained untested for a similar reason. I can get behind 
> finding a solution for this testing problem though.
> 
> The ```getTiers()``` call uses ```MessageBodyWriter``` to serialize the 
> ```Map```. The elements in that map can be ordered randomly (depending on map 
> implementation) which makes String equality difficult. That was the easier 
> problem to solve, I used ```LinkedHashMap``` in test fixtures to force 
> determinstic order of elements in the map.
> 
> Then, I ran into the problem of Jackson ordering ```TierInfo``` 
> properties in undeterminstic order. That is, a tier can be serialized as 
> ```"perferred":{"preemptible":false,"revocable":false}``` or 
> ```"perferred":{"revocable":false,"preemptible":false}```. A quick Google 
> search suggested that application of @JasonPropertyOrder on ```TierInfo``` 
> can result in deterministic property serialization order but it did not work 
> for me (potentially because of mocking but I am not sure).
> 
> Anyways, after burning some time here I decided to give up. Let me know 
> if you have any suggestion for testing.

Found a simple solution using GSON. Will update this review board shortly.


- Mehrdad


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49334/#review139857
---


On June 28, 2016, 1:42 p.m., Mehrdad Nurolahzade wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49334/
> ---
> 
> (Updated June 28, 2016, 1:42 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-1725 Expose tier configurations as a debug page
> 
> 
> Diffs
> -
> 
>   config/legacy_untested_classes.txt 1ea2183ab20cc5c6bca147bcea4e5c708d576b62 
>   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
> 496cd5590d6042d30e7bd0410a6c40d804c15023 
>   src/main/java/org/apache/aurora/scheduler/http/Tiers.java PRE-CREATION 
>   src/main/resources/scheduler/assets/index.html 
> eca27e081950a66b743f79ae7ae3d08e4625d2c8 
>   src/test/java/org/apache/aurora/scheduler/http/AbstractJettyTest.java 
> 561b134152113a50ff495cef28d2396b56d02f1c 
> 
> Diff: https://reviews.apache.org/r/49334/diff/
> 
> 
> Testing
> ---
> 
> Comments:
> - Logged the work done so far (new ```/tiers``` debug page) to this ticket 
> and kept AURORA-1710 for modifications to scheduler UI. 
> - Added comments to AURORA-1710 to clarify the suggested approach for 
> implementation.
> 
> Testing:
> ```
> ./build-support/jenkins/build.sh
> ...
> 
> *** OK (All tests passed) ***
> 
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ...
> mesos-master start/running, process 18776
> + RETCODE=0
> + restore_netrc
> + mv /home/vagrant/.netrc.bak /home/vagrant/.netrc
> + true
> Connection to 127.0.0.1 closed.
> 
> real  15m5.795s
> user  0m1.318s
> sys   0m0.533s
> ```
> 
> 
> Thanks,
> 
> Mehrdad Nurolahzade
> 
>

Re: Review Request 49338: Update packaging for Aurora 0.14

2016-06-28 Thread John Sirois


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49338/#review139871
---


Ship it!




Ship It!

- John Sirois


On June 28, 2016, 3:45 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49338/
> ---
> 
> (Updated June 28, 2016, 3:45 p.m.)
> 
> 
> Review request for Aurora and John Sirois.
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> ---
> 
> Update packaging for Aurora 0.14
> 
> 
> Diffs
> -
> 
>   specs/debian/control c59b67e490e210d7eb5240b8fd880e11151e6f06 
>   specs/rpm/aurora.spec 9a7b345a4b622bbe7b878bf8eef2857f8f131591 
>   test/deb/debian-jessie/README.md 5d7bd03c9e12aa2868193bc90f24dcc392c92358 
>   test/deb/debian-jessie/provision.sh 
> 27f8b8879c9734edeec7677a9ed29b950c83ef8f 
>   test/deb/ubuntu-trusty/README.md 054b9a403ef1eb9d5bb08ce90237de8955418def 
>   test/deb/ubuntu-trusty/provision.sh 
> 2a9e9b66746c92d8924abb218bdc64d9eed15e33 
>   test/rpm/centos-7/README.md 0e7e80912bb23df5bffe627035bcfc8af99cfb67 
>   test/rpm/centos-7/provision.sh e42a015af40ff2c142b259cf04217b09a5e829bf 
> 
> Diff: https://reviews.apache.org/r/49338/diff/
> 
> 
> Testing
> ---
> 
> Manually run through the test instructions in `tests/$distribution'
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Review Request 49339: Update install docs to for Aurora 0.14.0

2016-06-28 Thread Stephan Erb


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49339/
---

Review request for Aurora.


Repository: aurora


Description
---

Update install docs to for Aurora 0.14.0

*WIP:* This will only work once we have actually published binaries for 0.14 
(and we haven't even signed-off 0.13, yet).


Diffs
-

  docs/operations/installation.md d3fb529929aaf8975579930d50a59e155d1e4357 

Diff: https://reviews.apache.org/r/49339/diff/


Testing
---


Thanks,

Stephan Erb

Review Request 49338: Update packaging for Aurora 0.14

2016-06-28 Thread Stephan Erb


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49338/
---

Review request for Aurora and John Sirois.


Repository: aurora-packaging


Description
---

Update packaging for Aurora 0.14


Diffs
-

  specs/debian/control c59b67e490e210d7eb5240b8fd880e11151e6f06 
  specs/rpm/aurora.spec 9a7b345a4b622bbe7b878bf8eef2857f8f131591 
  test/deb/debian-jessie/README.md 5d7bd03c9e12aa2868193bc90f24dcc392c92358 
  test/deb/debian-jessie/provision.sh 27f8b8879c9734edeec7677a9ed29b950c83ef8f 
  test/deb/ubuntu-trusty/README.md 054b9a403ef1eb9d5bb08ce90237de8955418def 
  test/deb/ubuntu-trusty/provision.sh 2a9e9b66746c92d8924abb218bdc64d9eed15e33 
  test/rpm/centos-7/README.md 0e7e80912bb23df5bffe627035bcfc8af99cfb67 
  test/rpm/centos-7/provision.sh e42a015af40ff2c142b259cf04217b09a5e829bf 

Diff: https://reviews.apache.org/r/49338/diff/


Testing
---

Manually run through the test instructions in `tests/$distribution'


Thanks,

Stephan Erb

Re: Review Request 49218: Add support for Mesos Fetcher

2016-06-28 Thread Renan DelValle



> On June 28, 2016, 9:52 a.m., Maxim Khutornenko wrote:
> > LGTM, just a few minor changes left.

Thanks for the quick reviews, really appreciate it.


> On June 28, 2016, 9:52 a.m., Maxim Khutornenko wrote:
> > api/src/main/thrift/org/apache/aurora/gen/api.thrift, lines 148-152
> > 
> >
> > Holes in thrift IDs are legal but since this is a new struct it'd make 
> > sense to avoid them.

Agreed, changed the values so there is no hole.


> On June 28, 2016, 9:52 a.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/app/AppModule.java, line 100
> > 
> >
> > I'd skip `_for_jobs` part in favor of a brief write up under 
> > https://github.com/apache/aurora/tree/master/docs/features describing 
> > custom executors and mesos fetcher.

Added a mesos fetcher document. Custom executors are already documented for the 
most part in docs/opreations/configuration.md. I made a reference to how the 
URIs are different but similar in the Mesos Fetcher document.


- Renan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49218/#review139813
---


On June 28, 2016, 2:39 p.m., Renan DelValle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49218/
> ---
> 
> (Updated June 28, 2016, 2:39 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Adding a URIs field to TaskConfig inside the ThriftAPI so that users are able 
> to specify resources they wish to download into the sandbox per job.
> 
> 
> Diffs
> -
> 
>   RELEASE-NOTES.md af2061c7605c12a066778bd99ec1a3857bee6dec 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> 3e6daf53dd563dd7a2d494cc95e9a0aba0b6 
>   docs/features/mesos-fetcher.md PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
> 6c7c75ac86458884bc767736caf47fb56fc8 
>   src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 
> 4089b79da8079243703eead884e80bcf736f8b29 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  fe18c0f9876a736ea34d4eab92219013cd1e 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> 3b01801d929dd61ee989495bf38af8f03e9f5ad4 
>   src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigManager.java 
> c76164292cf62d2181374c09f8bf6d8d3358e982 
>   src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.java 
> 571201094c1e576e496495a01cb83f6c57decfa8 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/migration/V007_CreateMesosFetcherURIsTable.java
>  PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DbTaskConfig.java 
> a90cb00e240df25dce6d55728859768e22d741a6 
>   
> src/main/resources/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.xml
>  2c8af8b88e41b3b381cac831fd43b1057e4df0aa 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
> 5069bedc08bb7111d0e0f101c8a2c81495b97bc9 
>   
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
>  2dff80b5213e98c778d71955517e5f9227d7d0c1 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> 58785bfa37ff214f26e9f94d836e6df40e411c3b 
>   
> src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java 
> b1593f682f48ea66339bc2372de3e4f14e40be32 
>   src/test/java/org/apache/aurora/scheduler/thrift/Fixtures.java 
> a883b0e33bfec1d14e6fe4ee8ed2200d93acaeec 
>   src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 
> ed69996593f5556d80a9229063ef5c7d658e2cfb 
> 
> Diff: https://reviews.apache.org/r/49218/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build -Pq
> bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> Tested with a custom client submitting TaskConfigs which included URIs when 
> the -enable_mesos_fetcher_for_jobs flag was on as well as when it was off.
> 
> 
> Thanks,
> 
> Renan DelValle
> 
>

Re: Review Request 49218: Add support for Mesos Fetcher

2016-06-28 Thread Renan DelValle


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49218/
---

(Updated June 28, 2016, 2:39 p.m.)


Review request for Aurora.


Changes
---

Removed hole in Thrift API.
Changed scheduler flag from -enable_mesos_fetcher_for_jobs to 
-enable_mesos_fetcher.
Added brief write up in features concerning Mesos Fetcher (custom executors 
feature is documented in docs/opreations/configuration.md).
Formatting fixes.


Repository: aurora


Description
---

Adding a URIs field to TaskConfig inside the ThriftAPI so that users are able 
to specify resources they wish to download into the sandbox per job.


Diffs (updated)
-

  RELEASE-NOTES.md af2061c7605c12a066778bd99ec1a3857bee6dec 
  api/src/main/thrift/org/apache/aurora/gen/api.thrift 
3e6daf53dd563dd7a2d494cc95e9a0aba0b6 
  docs/features/mesos-fetcher.md PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
6c7c75ac86458884bc767736caf47fb56fc8 
  src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 
4089b79da8079243703eead884e80bcf736f8b29 
  
src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
 fe18c0f9876a736ea34d4eab92219013cd1e 
  src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
3b01801d929dd61ee989495bf38af8f03e9f5ad4 
  src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigManager.java 
c76164292cf62d2181374c09f8bf6d8d3358e982 
  src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.java 
571201094c1e576e496495a01cb83f6c57decfa8 
  
src/main/java/org/apache/aurora/scheduler/storage/db/migration/V007_CreateMesosFetcherURIsTable.java
 PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/storage/db/views/DbTaskConfig.java 
a90cb00e240df25dce6d55728859768e22d741a6 
  
src/main/resources/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.xml 
2c8af8b88e41b3b381cac831fd43b1057e4df0aa 
  src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
5069bedc08bb7111d0e0f101c8a2c81495b97bc9 
  
src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
 2dff80b5213e98c778d71955517e5f9227d7d0c1 
  src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
58785bfa37ff214f26e9f94d836e6df40e411c3b 
  src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java 
b1593f682f48ea66339bc2372de3e4f14e40be32 
  src/test/java/org/apache/aurora/scheduler/thrift/Fixtures.java 
a883b0e33bfec1d14e6fe4ee8ed2200d93acaeec 
  src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 
ed69996593f5556d80a9229063ef5c7d658e2cfb 

Diff: https://reviews.apache.org/r/49218/diff/


Testing
---

./gradlew build -Pq
bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh

Tested with a custom client submitting TaskConfigs which included URIs when the 
-enable_mesos_fetcher_for_jobs flag was on as well as when it was off.


Thanks,

Renan DelValle

Re: Review Request 49334: AURORA-1725 Expose tier configurations as a debug page

2016-06-28 Thread Mehrdad Nurolahzade

> On June 28, 2016, 1:53 p.m., David McLaughlin wrote:
> > config/legacy_untested_classes.txt, line 44
> > 
> >
> > Isn't this a fairly easy class to test?

I wrote a test for it initially but then I ran into a few problems interesting 
problems but then eventually gave up. Seems like many other http endpoints have 
remained untested for a similar reason. I can get behind finding a solution for 
this testing problem though.

The ```getTiers()``` call uses ```MessageBodyWriter``` to serialize the 
```Map```. The elements in that map can be ordered randomly (depending on map 
implementation) which makes String equality difficult. That was the easier 
problem to solve, I used ```LinkedHashMap``` in test fixtures to force 
determinstic order of elements in the map.

Then, I ran into the problem of Jackson ordering ```TierInfo``` properties in 
undeterminstic order. That is, a tier can be serialized as 
```"perferred":{"preemptible":false,"revocable":false}``` or 
```"perferred":{"revocable":false,"preemptible":false}```. A quick Google 
search suggested that application of @JasonPropertyOrder on ```TierInfo``` can 
result in deterministic property serialization order but it did not work for me 
(potentially because of mocking but I am not sure).

Anyways, after burning some time here I decided to give up. Let me know if you 
have any suggestion for testing.

- Mehrdad

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49334/#review139857
---

On June 28, 2016, 1:42 p.m., Mehrdad Nurolahzade wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49334/
> ---
> 
> (Updated June 28, 2016, 1:42 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-1725 Expose tier configurations as a debug page
> 
> 
> Diffs
> -
> 
>   config/legacy_untested_classes.txt 1ea2183ab20cc5c6bca147bcea4e5c708d576b62 
>   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
> 496cd5590d6042d30e7bd0410a6c40d804c15023 
>   src/main/java/org/apache/aurora/scheduler/http/Tiers.java PRE-CREATION 
>   src/main/resources/scheduler/assets/index.html 
> eca27e081950a66b743f79ae7ae3d08e4625d2c8 
>   src/test/java/org/apache/aurora/scheduler/http/AbstractJettyTest.java 
> 561b134152113a50ff495cef28d2396b56d02f1c 
> 
> Diff: https://reviews.apache.org/r/49334/diff/
> 
> 
> Testing
> ---
> 
> Comments:
> - Logged the work done so far (new ```/tiers``` debug page) to this ticket 
> and kept AURORA-1710 for modifications to scheduler UI. 
> - Added comments to AURORA-1710 to clarify the suggested approach for 
> implementation.
> 
> Testing:
> ```
> ./build-support/jenkins/build.sh
> ...
> 
> *** OK (All tests passed) ***
> 
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ...
> mesos-master start/running, process 18776
> + RETCODE=0
> + restore_netrc
> + mv /home/vagrant/.netrc.bak /home/vagrant/.netrc
> + true
> Connection to 127.0.0.1 closed.
> 
> real  15m5.795s
> user  0m1.318s
> sys   0m0.533s
> ```
> 
> 
> Thanks,
> 
> Mehrdad Nurolahzade
> 
>

Re: Review Request 49334: AURORA-1725 Expose tier configurations as a debug page

2016-06-28 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49334/#review139860
---


Ship it!




Master (499b11b) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On June 28, 2016, 8:42 p.m., Mehrdad Nurolahzade wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49334/
> ---
> 
> (Updated June 28, 2016, 8:42 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-1725 Expose tier configurations as a debug page
> 
> 
> Diffs
> -
> 
>   config/legacy_untested_classes.txt 1ea2183ab20cc5c6bca147bcea4e5c708d576b62 
>   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
> 496cd5590d6042d30e7bd0410a6c40d804c15023 
>   src/main/java/org/apache/aurora/scheduler/http/Tiers.java PRE-CREATION 
>   src/main/resources/scheduler/assets/index.html 
> eca27e081950a66b743f79ae7ae3d08e4625d2c8 
>   src/test/java/org/apache/aurora/scheduler/http/AbstractJettyTest.java 
> 561b134152113a50ff495cef28d2396b56d02f1c 
> 
> Diff: https://reviews.apache.org/r/49334/diff/
> 
> 
> Testing
> ---
> 
> Comments:
> - Logged the work done so far (new ```/tiers``` debug page) to this ticket 
> and kept AURORA-1710 for modifications to scheduler UI. 
> - Added comments to AURORA-1710 to clarify the suggested approach for 
> implementation.
> 
> Testing:
> ```
> ./build-support/jenkins/build.sh
> ...
> 
> *** OK (All tests passed) ***
> 
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ...
> mesos-master start/running, process 18776
> + RETCODE=0
> + restore_netrc
> + mv /home/vagrant/.netrc.bak /home/vagrant/.netrc
> + true
> Connection to 127.0.0.1 closed.
> 
> real  15m5.795s
> user  0m1.318s
> sys   0m0.533s
> ```
> 
> 
> Thanks,
> 
> Mehrdad Nurolahzade
> 
>

Re: Review Request 49334: AURORA-1725 Expose tier configurations as a debug page

2016-06-28 Thread David McLaughlin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49334/#review139857
---




config/legacy_untested_classes.txt (line 44)


Isn't this a fairly easy class to test?


- David McLaughlin


On June 28, 2016, 8:42 p.m., Mehrdad Nurolahzade wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49334/
> ---
> 
> (Updated June 28, 2016, 8:42 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-1725 Expose tier configurations as a debug page
> 
> 
> Diffs
> -
> 
>   config/legacy_untested_classes.txt 1ea2183ab20cc5c6bca147bcea4e5c708d576b62 
>   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
> 496cd5590d6042d30e7bd0410a6c40d804c15023 
>   src/main/java/org/apache/aurora/scheduler/http/Tiers.java PRE-CREATION 
>   src/main/resources/scheduler/assets/index.html 
> eca27e081950a66b743f79ae7ae3d08e4625d2c8 
>   src/test/java/org/apache/aurora/scheduler/http/AbstractJettyTest.java 
> 561b134152113a50ff495cef28d2396b56d02f1c 
> 
> Diff: https://reviews.apache.org/r/49334/diff/
> 
> 
> Testing
> ---
> 
> Comments:
> - Logged the work done so far (new ```/tiers``` debug page) to this ticket 
> and kept AURORA-1710 for modifications to scheduler UI. 
> - Added comments to AURORA-1710 to clarify the suggested approach for 
> implementation.
> 
> Testing:
> ```
> ./build-support/jenkins/build.sh
> ...
> 
> *** OK (All tests passed) ***
> 
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ...
> mesos-master start/running, process 18776
> + RETCODE=0
> + restore_netrc
> + mv /home/vagrant/.netrc.bak /home/vagrant/.netrc
> + true
> Connection to 127.0.0.1 closed.
> 
> real  15m5.795s
> user  0m1.318s
> sys   0m0.533s
> ```
> 
> 
> Thanks,
> 
> Mehrdad Nurolahzade
> 
>

Review Request 49334: AURORA-1725 Expose tier configurations as a debug page

2016-06-28 Thread Mehrdad Nurolahzade


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49334/
---

Review request for Aurora, David McLaughlin and Maxim Khutornenko.


Repository: aurora


Description
---

AURORA-1725 Expose tier configurations as a debug page


Diffs
-

  config/legacy_untested_classes.txt 1ea2183ab20cc5c6bca147bcea4e5c708d576b62 
  src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
496cd5590d6042d30e7bd0410a6c40d804c15023 
  src/main/java/org/apache/aurora/scheduler/http/Tiers.java PRE-CREATION 
  src/main/resources/scheduler/assets/index.html 
eca27e081950a66b743f79ae7ae3d08e4625d2c8 
  src/test/java/org/apache/aurora/scheduler/http/AbstractJettyTest.java 
561b134152113a50ff495cef28d2396b56d02f1c 

Diff: https://reviews.apache.org/r/49334/diff/


Testing
---

Comments:
- Logged the work done so far (new ```/tiers``` debug page) to this ticket and 
kept AURORA-1710 for modifications to scheduler UI. 
- Added comments to AURORA-1710 to clarify the suggested approach for 
implementation.

Testing:
```
./build-support/jenkins/build.sh
...

*** OK (All tests passed) ***

./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
...
mesos-master start/running, process 18776
+ RETCODE=0
+ restore_netrc
+ mv /home/vagrant/.netrc.bak /home/vagrant/.netrc
+ true
Connection to 127.0.0.1 closed.

real15m5.795s
user0m1.318s
sys 0m0.533s
```


Thanks,

Mehrdad Nurolahzade

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-06-28 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49048/#review139828
---


Ship it!




Master (73dd2a8) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On June 28, 2016, 5:28 p.m., Mehrdad Nurolahzade wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49048/
> ---
> 
> (Updated June 28, 2016, 5:28 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-1710 Make 'tier' required and remove support for 'production' flag in 
> Job configuration - CLI changes
> 
> 
> Diffs
> -
> 
>   RELEASE-NOTES.md af2061c7605c12a066778bd99ec1a3857bee6dec 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 68baf8fdb90cd26100159401c46c9963c24332b3 
>   src/main/python/apache/aurora/client/cli/context.py 
> 9b1511801d031ff48b81c25688a55cb586b8ac66 
>   src/main/python/apache/aurora/client/config.py 
> 2fc12559016d406c347adb416a5166cca31c961e 
>   src/test/python/apache/aurora/client/cli/test_command_hooks.py 
> 2130f1fa71be02a004cdf8e476a270c81a7105d3 
>   src/test/python/apache/aurora/client/cli/test_context.py 
> 204ca092adad8bf43c5032a02f61bf303fb0b2fc 
>   src/test/python/apache/aurora/client/cli/test_create.py 
> 8c27e2b340bb0a5fb5bcb44ef94d433e7f92c76c 
>   src/test/python/apache/aurora/client/cli/test_cron.py 
> f3c522ed94a2d774865811ceb546bf9df083c14f 
>   src/test/python/apache/aurora/client/cli/test_plugins.py 
> a545fece5e2b3e0017a61e1be9ac478372b1f34d 
>   src/test/python/apache/aurora/client/cli/test_restart.py 
> 967d560e5c7eb0ed85b215fb11d9751b8666acb5 
>   src/test/python/apache/aurora/client/cli/util.py 
> 7b4558ec7f0fb0fd2902591bc6a90dc15051dd6e 
>   src/test/python/apache/aurora/client/test_config.py 
> b1a3c1865819899ef19173be0f861783a2631d0a 
> 
> Diff: https://reviews.apache.org/r/49048/diff/
> 
> 
> Testing
> ---
> 
> ```
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> *** OK (All tests passed) ***
> 
> mesos-master start/running, process 26868
> + RETCODE=0
> + restore_netrc
> + mv /home/vagrant/.netrc.bak /home/vagrant/.netrc
> + true
> Connection to 127.0.0.1 closed.
> 
> real  19m46.324s
> user  0m1.496s
> sys   0m0.774s
> ```
> 
> 
> Thanks,
> 
> Mehrdad Nurolahzade
> 
>

Re: Review Request 49330: Add announce and enable_hooks to Job Schema table

2016-06-28 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49330/#review139822
---



Master (73dd2a8) is red with this patch.
  ./build-support/jenkins/build.sh

17:28:35 00:01 [ivy]
17:28:35 00:01   [cache] INFO] 
Downloading 
https://repo1.maven.org/maven2/org/apache/ivy/ivy/2.4.0/ivy-2.4.0.jar

  0% .30 KB
  0% ..   60 KB
  0% ...  80 KB
  0% 110 KB
  0% .   130 KB
  0% ..  160 KB
  0% ... 180 KB
  0% 210 KB
  0% .   230 KB
  0% ..  260 KB
  0% ... 280 KB
  0% 310 KB
  0% .   330 KB
  0% ..  360 KB
  0% ... 380 KB
  0% 410 KB
  0% .   430 KB
  0% ..  460 KB
  0% ... 480 KB
  0% 510 KB
  0% .   530 KB
  0% ..  560 KB
  0% ... 580 KB
  0% 610 KB
  0% .   630 KB
  0% ..  660 KB
  0% ... 680 KB
  0% 710 KB
  0% .   730 KB
  0% ..  760 KB
  0% ... 780 KB
  0% 810 KB
  0% .   830 KB
  0% ..  860 KB
  0% ... 880 KB
  0% 910 KB
  0% .   930 KB
  0% ..  960 KB
  0% ... 980 KB
  0%    1010 KB
  0% .  1030 KB
  0% .. 1060 KB
  0% ...1080 KB
  0%    1110 KB
  0% .  1130 KB
  0% .. 1160 KB
  0% ...1180 KB
  0%    1210 KB
  0% .  1230 KB
100% .. 1252 KB 0.277s
INFO] sha1: 5abe4c24bbe992a9ac07ca563d5bd3e8d569e9ed

17:28:35 00:01   [ivy-bootstrap]
17:28:36 00:02   [bootstrap-nailgun-server][32m
   Caching artifacts for 1 target.[0m
17:28:37 00:03   [resources]
17:28:37 00:03 [prepare]
17:28:37 00:03 [services]
17:28:38 00:04   [compile]
17:28:38 00:04 [compile-jvm-prep-command]
17:28:38 00:04   [jvm_prep_command]
17:28:38 00:04 [compile-prep-command]
17:28:38 00:04 [python-eval]
17:28:38 00:04 [pythonstyle]
17:28:38 00:04   [cache]  [32m
   No cached artifacts for 42 targets.[0m[32m
   Invalidated 42 targets.[0m
17:28:58 00:24 [compile]
17:28:59 00:25 [zinc]
17:28:59 00:25 [jvm-dep-check]
17:28:59 00:25   [test]
17:28:59 00:25 [test-jvm-prep-command]
17:28:59 00:25   [jvm_prep_command]
17:28:59 00:25 [test-prep-command]
17:28:59 00:25 [test]
17:28:59 00:25 [pytest]
17:28:59 00:25   [run]
 
17:29:01 00:27 [chroot]INFO] Attempting to fetch thrift binary from: 
https://dl.bintray.com/pantsbuild/bin/build-support/bin/thrift/linux/x86_64/0.9.1/thrift
 ...

FAILURE: Failed to fetch binary bin/thrift/linux/x86_64/0.9.1/thrift from any 
source: (Failed to fetch binary from 
https://dl.bi

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-06-28 Thread Mehrdad Nurolahzade


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49048/
---

(Updated June 28, 2016, 10:28 a.m.)


Review request for Aurora, Joshua Cohen and Maxim Khutornenko.


Changes
---

Applied suggested refactoring


Repository: aurora


Description
---

AURORA-1710 Make 'tier' required and remove support for 'production' flag in 
Job configuration - CLI changes


Diffs (updated)
-

  RELEASE-NOTES.md af2061c7605c12a066778bd99ec1a3857bee6dec 
  src/main/python/apache/aurora/client/api/__init__.py 
68baf8fdb90cd26100159401c46c9963c24332b3 
  src/main/python/apache/aurora/client/cli/context.py 
9b1511801d031ff48b81c25688a55cb586b8ac66 
  src/main/python/apache/aurora/client/config.py 
2fc12559016d406c347adb416a5166cca31c961e 
  src/test/python/apache/aurora/client/cli/test_command_hooks.py 
2130f1fa71be02a004cdf8e476a270c81a7105d3 
  src/test/python/apache/aurora/client/cli/test_context.py 
204ca092adad8bf43c5032a02f61bf303fb0b2fc 
  src/test/python/apache/aurora/client/cli/test_create.py 
8c27e2b340bb0a5fb5bcb44ef94d433e7f92c76c 
  src/test/python/apache/aurora/client/cli/test_cron.py 
f3c522ed94a2d774865811ceb546bf9df083c14f 
  src/test/python/apache/aurora/client/cli/test_plugins.py 
a545fece5e2b3e0017a61e1be9ac478372b1f34d 
  src/test/python/apache/aurora/client/cli/test_restart.py 
967d560e5c7eb0ed85b215fb11d9751b8666acb5 
  src/test/python/apache/aurora/client/cli/util.py 
7b4558ec7f0fb0fd2902591bc6a90dc15051dd6e 
  src/test/python/apache/aurora/client/test_config.py 
b1a3c1865819899ef19173be0f861783a2631d0a 

Diff: https://reviews.apache.org/r/49048/diff/


Testing
---

```
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh

*** OK (All tests passed) ***

mesos-master start/running, process 26868
+ RETCODE=0
+ restore_netrc
+ mv /home/vagrant/.netrc.bak /home/vagrant/.netrc
+ true
Connection to 127.0.0.1 closed.

real19m46.324s
user0m1.496s
sys 0m0.774s
```


Thanks,

Mehrdad Nurolahzade

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-06-28 Thread Mehrdad Nurolahzade



> On June 28, 2016, 10:02 a.m., Aurora ReviewBot wrote:
> > Master (73dd2a8) is red with this patch.
> >   ./build-support/jenkins/build.sh
> > 
> >  
> > src/test/python/apache/thermos/common/test_planner.py::test_planner_empty 
> > [32mPASSED[0m
> >  
> > src/test/python/apache/thermos/common/test_planner.py::test_planner_unordered
> >  [32mPASSED[0m
> >  
> > src/test/python/apache/thermos/common/test_planner.py::test_planner_ordered 
> > [32mPASSED[0m
> >  
> > src/test/python/apache/thermos/common/test_planner.py::test_planner_mixed 
> > [32mPASSED[0m
> >  
> > src/test/python/apache/thermos/common/test_planner.py::test_planner_unsatisfiables
> >  [32mPASSED[0m
> >  
> >   FAILURES 
> >   
> > test_get_config_with_production_and_tier_is_preemptible 
> >  
> >  [1mdef 
> > test_get_config_with_production_and_tier_is_preemptible():[0m
> >  [1m  context = FakeAuroraCommandContext()[0m
> >  [1m  
> > context.set_options(create_mock_options())[0m
> >  [1m  with 
> > CLUSTERS.patch(AuroraClientCommandTest.TEST_CLUSTERS.values()):[0m
> >  [1mapi = 
> > context.get_api(TEST_CLUSTER.name)[0m
> >  [1mapi.get_tier_configs.return_value = 
> > AuroraClientCommandTest.get_mock_tier_configurations()[0m
> >  [1mwith temporary_file() as fp:[0m
> >  [1m  fp.write(create_test_config())[0m
> >  [1m  fp.flush()[0m
> >  [1m  config = 
> > context.get_job_config(AuroraClientCommandTest.TEST_JOBKEY, fp.name)[0m
> >  [1m  assert not 
> > config.job().taskConfig.production[0m
> >  [1m> assert config.job().taskConfig.tier == 
> > AuroraClientCommandTest.PREEMPTIBLE_TIER.name[0m
> >  [1m[31mE assert 'revocable' == 
> > 'preemptible'[0m
> >  [1m[31mE   - revocable[0m
> >  [1m[31mE   + preemptible[0m
> >  
> >  
> > src/test/python/apache/aurora/client/cli/test_context.py:110: AssertionError
> >  -- Captured stderr call --
> >  INFO:root:OK
> >   INFO] OK
> >   INFO] OK
> >   INFO] OK
> >   generated xml file: 
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml
> >  
> >  [1m[31m 1 failed, 667 passed, 6 skipped, 1 warnings 
> > in 198.50 seconds [0m
> >  
> > FAILURE
> > 
> > [32m
> >Waiting for background workers to finish.[0m
> > 17:01:40 04:08   [complete][31m
> >FAILURE[0m
> > 
> > 
> > I will refresh this build result if you post a review containing 
> > "@ReviewBot retry"

This is passing locally, not sure why it's breaking on the server.


- Mehrdad


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49048/#review139819
---


On June 28, 2016, 10:28 a.m., Mehrdad Nurolahzade wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49048/
> ---
> 
> (Updated June 28, 2016, 10:28 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-1710 Make 'tier' required and remove support for 'production' flag in 
> Job configuration - CLI changes
> 
> 
> Diffs
> -
> 
>   RELEASE-NOTES.md af2061c7605c12a066778bd99ec1a3857bee6dec 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 68baf8fdb90cd26100159401c46c9963c24332b3 
>   src/main/python/apache/aurora/client/cli/context.py 
> 9b1511801d031ff48b81c25688a55cb586b8ac66 
>   src/main/python/apache/aurora/client/config.py 
> 2fc12559016d406c347adb416a5166cca31c961e 
>   src/test/python/apache/aurora/client/cli/test_command_hooks.py 
> 2130f1fa71be02a004cdf8e476a270c81a7105d3 
>   src/test/python/apache/aurora/client/cli/test_context.py 
> 204ca092adad8bf43c5032a02f61bf303fb0b2fc 
>   src/test/python/apache/aurora/client/cli/test_create.py 
> 8c27e2b340bb0a5fb5bcb44ef94d433e7f92c76c 
>   src/test/python/apache/aurora/client/cli/test_cron.py 
> f3c522ed94a2d774865811ceb546bf9df083c14f 
>   src/test/

Review Request 49330: Add announce and enable_hooks to Job Schema table

2016-06-28 Thread Benjamin Staffin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49330/
---

Review request for Aurora.


Repository: aurora


Description
---

Add announce and enable_hooks to Job Schema table


Diffs
-

  docs/reference/configuration.md c56ace0477f3f22c0d56d3dfc4c24b510895aa7e 

Diff: https://reviews.apache.org/r/49330/diff/


Testing
---


Thanks,

Benjamin Staffin

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-06-28 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49048/#review139819
---



Master (73dd2a8) is red with this patch.
  ./build-support/jenkins/build.sh

 
src/test/python/apache/thermos/common/test_planner.py::test_planner_empty 
[32mPASSED[0m
 
src/test/python/apache/thermos/common/test_planner.py::test_planner_unordered 
[32mPASSED[0m
 
src/test/python/apache/thermos/common/test_planner.py::test_planner_ordered 
[32mPASSED[0m
 
src/test/python/apache/thermos/common/test_planner.py::test_planner_mixed 
[32mPASSED[0m
 
src/test/python/apache/thermos/common/test_planner.py::test_planner_unsatisfiables
 [32mPASSED[0m
 
  FAILURES 
  test_get_config_with_production_and_tier_is_preemptible 
 
 [1mdef 
test_get_config_with_production_and_tier_is_preemptible():[0m
 [1m  context = FakeAuroraCommandContext()[0m
 [1m  context.set_options(create_mock_options())[0m
 [1m  with 
CLUSTERS.patch(AuroraClientCommandTest.TEST_CLUSTERS.values()):[0m
 [1mapi = context.get_api(TEST_CLUSTER.name)[0m
 [1mapi.get_tier_configs.return_value = 
AuroraClientCommandTest.get_mock_tier_configurations()[0m
 [1mwith temporary_file() as fp:[0m
 [1m  fp.write(create_test_config())[0m
 [1m  fp.flush()[0m
 [1m  config = 
context.get_job_config(AuroraClientCommandTest.TEST_JOBKEY, fp.name)[0m
 [1m  assert not 
config.job().taskConfig.production[0m
 [1m> assert config.job().taskConfig.tier == 
AuroraClientCommandTest.PREEMPTIBLE_TIER.name[0m
 [1m[31mE assert 'revocable' == 'preemptible'[0m
 [1m[31mE   - revocable[0m
 [1m[31mE   + preemptible[0m
 
 
src/test/python/apache/aurora/client/cli/test_context.py:110: AssertionError
 -- Captured stderr call --
 INFO:root:OK
  INFO] OK
  INFO] OK
  INFO] OK
  generated xml file: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml
 
 [1m[31m 1 failed, 667 passed, 6 skipped, 1 warnings in 
198.50 seconds [0m
 
FAILURE

[32m
   Waiting for background workers to finish.[0m
17:01:40 04:08   [complete][31m
   FAILURE[0m


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On June 28, 2016, 4:51 p.m., Mehrdad Nurolahzade wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49048/
> ---
> 
> (Updated June 28, 2016, 4:51 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-1710 Make 'tier' required and remove support for 'production' flag in 
> Job configuration - CLI changes
> 
> 
> Diffs
> -
> 
>   RELEASE-NOTES.md af2061c7605c12a066778bd99ec1a3857bee6dec 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 68baf8fdb90cd26100159401c46c9963c24332b3 
>   src/main/python/apache/aurora/client/base.py 
> 73953b69b247cf86e691310423b63b3a40f95976 
>   src/main/python/apache/aurora/client/cli/context.py 
> 9b1511801d031ff48b81c25688a55cb586b8ac66 
>   src/main/python/apache/aurora/client/config.py 
> 2fc12559016d406c347adb416a5166cca31c961e 
>   src/test/python/apache/aurora/client/cli/test_command_hooks.py 
> 2130f1fa71be02a004cdf8e476a270c81a7105d3 
>   src/test/python/apache/aurora/client/cli/test_context.py 
> 204ca092adad8bf43c5032a02f61bf303fb0b2fc 
>   src/test/python/apache/aurora/client/cli/test_create.py 
> 8c27e2b340bb0a5fb5bcb44ef94d433e7f92c76c 
>   src/test/python/apache/aurora/client/cli/test_cron.py 
> f3c522ed94a2d774865811ceb546bf9df083c14f 
>   src/test/python/apache/aurora/client/cli/test_plugins.py 
> a545fece5e2b3e0017a61e1be9ac478372b1f34d 
>   src/test/python/apache/aurora/client/cli/test_restart.py 
> 967d560e5c7eb0ed85b215fb11d9751b8666acb5 
>   src/test/python/apache/aurora/client/cli/util.py 
> 7b4558ec7f0fb0fd2902591bc6a90dc15051dd6e 
>   src/test/py

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-06-28 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49048/#review139818
---


Fix it, then Ship it!





src/main/python/apache/aurora/client/base.py (lines 52 - 59)


Please, move this method into config.py as it's only consumer.


- Maxim Khutornenko


On June 28, 2016, 4:51 p.m., Mehrdad Nurolahzade wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49048/
> ---
> 
> (Updated June 28, 2016, 4:51 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-1710 Make 'tier' required and remove support for 'production' flag in 
> Job configuration - CLI changes
> 
> 
> Diffs
> -
> 
>   RELEASE-NOTES.md af2061c7605c12a066778bd99ec1a3857bee6dec 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 68baf8fdb90cd26100159401c46c9963c24332b3 
>   src/main/python/apache/aurora/client/base.py 
> 73953b69b247cf86e691310423b63b3a40f95976 
>   src/main/python/apache/aurora/client/cli/context.py 
> 9b1511801d031ff48b81c25688a55cb586b8ac66 
>   src/main/python/apache/aurora/client/config.py 
> 2fc12559016d406c347adb416a5166cca31c961e 
>   src/test/python/apache/aurora/client/cli/test_command_hooks.py 
> 2130f1fa71be02a004cdf8e476a270c81a7105d3 
>   src/test/python/apache/aurora/client/cli/test_context.py 
> 204ca092adad8bf43c5032a02f61bf303fb0b2fc 
>   src/test/python/apache/aurora/client/cli/test_create.py 
> 8c27e2b340bb0a5fb5bcb44ef94d433e7f92c76c 
>   src/test/python/apache/aurora/client/cli/test_cron.py 
> f3c522ed94a2d774865811ceb546bf9df083c14f 
>   src/test/python/apache/aurora/client/cli/test_plugins.py 
> a545fece5e2b3e0017a61e1be9ac478372b1f34d 
>   src/test/python/apache/aurora/client/cli/test_restart.py 
> 967d560e5c7eb0ed85b215fb11d9751b8666acb5 
>   src/test/python/apache/aurora/client/cli/util.py 
> 7b4558ec7f0fb0fd2902591bc6a90dc15051dd6e 
>   src/test/python/apache/aurora/client/test_config.py 
> b1a3c1865819899ef19173be0f861783a2631d0a 
> 
> Diff: https://reviews.apache.org/r/49048/diff/
> 
> 
> Testing
> ---
> 
> ```
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> *** OK (All tests passed) ***
> 
> mesos-master start/running, process 26868
> + RETCODE=0
> + restore_netrc
> + mv /home/vagrant/.netrc.bak /home/vagrant/.netrc
> + true
> Connection to 127.0.0.1 closed.
> 
> real  19m46.324s
> user  0m1.496s
> sys   0m0.774s
> ```
> 
> 
> Thanks,
> 
> Mehrdad Nurolahzade
> 
>

Re: Review Request 49218: Add support for Mesos Fetcher

2016-06-28 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49218/#review139813
---



LGTM, just a few minor changes left.


api/src/main/thrift/org/apache/aurora/gen/api.thrift (lines 148 - 152)


Holes in thrift IDs are legal but since this is a new struct it'd make 
sense to avoid them.



src/main/java/org/apache/aurora/scheduler/app/AppModule.java (line 100)


I'd skip `_for_jobs` part in favor of a brief write up under 
https://github.com/apache/aurora/tree/master/docs/features describing custom 
executors and mesos fetcher.



src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
 (line 225)


indent is off here



src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java (lines 
268 - 272)


Suggest a small reformatting here:
```
List mesosFetcherUris = 
task.getTask().getMesosFetcherUris().stream()
.map(u -> Protos.CommandInfo.URI.newBuilder().setValue(u.getValue())
.setExecutable(false)
.setExecutable(false)
.setExtract(u.isExtract())
.setCache(u.isCache()).build())
.collect(Collectors.toList());
```


- Maxim Khutornenko


On June 28, 2016, 1:18 a.m., Renan DelValle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49218/
> ---
> 
> (Updated June 28, 2016, 1:18 a.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Adding a URIs field to TaskConfig inside the ThriftAPI so that users are able 
> to specify resources they wish to download into the sandbox per job.
> 
> 
> Diffs
> -
> 
>   RELEASE-NOTES.md af2061c7605c12a066778bd99ec1a3857bee6dec 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> 3e6daf53dd563dd7a2d494cc95e9a0aba0b6 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
> 6c7c75ac86458884bc767736caf47fb56fc8 
>   src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 
> 4089b79da8079243703eead884e80bcf736f8b29 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  fe18c0f9876a736ea34d4eab92219013cd1e 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> 3b01801d929dd61ee989495bf38af8f03e9f5ad4 
>   src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigManager.java 
> c76164292cf62d2181374c09f8bf6d8d3358e982 
>   src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.java 
> 571201094c1e576e496495a01cb83f6c57decfa8 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/migration/V007_CreateMesosFetcherURIsTable.java
>  PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DbTaskConfig.java 
> a90cb00e240df25dce6d55728859768e22d741a6 
>   
> src/main/resources/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.xml
>  2c8af8b88e41b3b381cac831fd43b1057e4df0aa 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
> 5069bedc08bb7111d0e0f101c8a2c81495b97bc9 
>   
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
>  2dff80b5213e98c778d71955517e5f9227d7d0c1 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> 58785bfa37ff214f26e9f94d836e6df40e411c3b 
>   
> src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java 
> b1593f682f48ea66339bc2372de3e4f14e40be32 
>   src/test/java/org/apache/aurora/scheduler/thrift/Fixtures.java 
> a883b0e33bfec1d14e6fe4ee8ed2200d93acaeec 
>   src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 
> ed69996593f5556d80a9229063ef5c7d658e2cfb 
> 
> Diff: https://reviews.apache.org/r/49218/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build -Pq
> bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> Tested with a custom client submitting TaskConfigs which included URIs when 
> the -enable_mesos_fetcher_for_jobs flag was on as well as when it was off.
> 
> 
> Thanks,
> 
> Renan DelValle
> 
>

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-06-28 Thread Mehrdad Nurolahzade


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49048/
---

(Updated June 28, 2016, 9:51 a.m.)


Review request for Aurora, Joshua Cohen and Maxim Khutornenko.


Changes
---

- Applied suggested refactorings
- Updated release notes


Repository: aurora


Description
---

AURORA-1710 Make 'tier' required and remove support for 'production' flag in 
Job configuration - CLI changes


Diffs (updated)
-

  RELEASE-NOTES.md af2061c7605c12a066778bd99ec1a3857bee6dec 
  src/main/python/apache/aurora/client/api/__init__.py 
68baf8fdb90cd26100159401c46c9963c24332b3 
  src/main/python/apache/aurora/client/base.py 
73953b69b247cf86e691310423b63b3a40f95976 
  src/main/python/apache/aurora/client/cli/context.py 
9b1511801d031ff48b81c25688a55cb586b8ac66 
  src/main/python/apache/aurora/client/config.py 
2fc12559016d406c347adb416a5166cca31c961e 
  src/test/python/apache/aurora/client/cli/test_command_hooks.py 
2130f1fa71be02a004cdf8e476a270c81a7105d3 
  src/test/python/apache/aurora/client/cli/test_context.py 
204ca092adad8bf43c5032a02f61bf303fb0b2fc 
  src/test/python/apache/aurora/client/cli/test_create.py 
8c27e2b340bb0a5fb5bcb44ef94d433e7f92c76c 
  src/test/python/apache/aurora/client/cli/test_cron.py 
f3c522ed94a2d774865811ceb546bf9df083c14f 
  src/test/python/apache/aurora/client/cli/test_plugins.py 
a545fece5e2b3e0017a61e1be9ac478372b1f34d 
  src/test/python/apache/aurora/client/cli/test_restart.py 
967d560e5c7eb0ed85b215fb11d9751b8666acb5 
  src/test/python/apache/aurora/client/cli/util.py 
7b4558ec7f0fb0fd2902591bc6a90dc15051dd6e 
  src/test/python/apache/aurora/client/test_config.py 
b1a3c1865819899ef19173be0f861783a2631d0a 

Diff: https://reviews.apache.org/r/49048/diff/


Testing
---

```
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh

*** OK (All tests passed) ***

mesos-master start/running, process 26868
+ RETCODE=0
+ restore_netrc
+ mv /home/vagrant/.netrc.bak /home/vagrant/.netrc
+ true
Connection to 127.0.0.1 closed.

real19m46.324s
user0m1.496s
sys 0m0.774s
```


Thanks,

Mehrdad Nurolahzade

Re: Review Request 49218: Add support for Mesos Fetcher

Re: Review Request 49218: Add support for Mesos Fetcher

Re: Review Request 49218: Add support for Mesos Fetcher

Re: Review Request 49218: Add support for Mesos Fetcher

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

Re: Review Request 49334: AURORA-1725 Expose tier configurations as a debug page

Re: Review Request 49218: Add support for Mesos Fetcher

Re: Review Request 49334: AURORA-1725 Expose tier configurations as a debug page

Re: Review Request 49334: AURORA-1725 Expose tier configurations as a debug page

Re: Review Request 49334: AURORA-1725 Expose tier configurations as a debug page

Re: Review Request 49218: Add support for Mesos Fetcher

Re: Review Request 49339: Update install docs to for Aurora 0.14.0

Re: Review Request 49334: AURORA-1725 Expose tier configurations as a debug page

Re: Review Request 49334: AURORA-1725 Expose tier configurations as a debug page

Re: Review Request 49338: Update packaging for Aurora 0.14

Review Request 49339: Update install docs to for Aurora 0.14.0

Review Request 49338: Update packaging for Aurora 0.14

Re: Review Request 49218: Add support for Mesos Fetcher

Re: Review Request 49218: Add support for Mesos Fetcher

Re: Review Request 49334: AURORA-1725 Expose tier configurations as a debug page

Re: Review Request 49334: AURORA-1725 Expose tier configurations as a debug page

Re: Review Request 49334: AURORA-1725 Expose tier configurations as a debug page

Review Request 49334: AURORA-1725 Expose tier configurations as a debug page

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

Re: Review Request 49330: Add announce and enable_hooks to Job Schema table

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

Review Request 49330: Add announce and enable_hooks to Job Schema table

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

Re: Review Request 49218: Add support for Mesos Fetcher

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

33 matches

Site Navigation

Mail list logo

Footer information