Re: Review Request 64290: Update to Thrift 0.10.0
> On Dec. 12, 2017, 4:11 p.m., Aurora ReviewBot wrote: > > Master (65c2288) is green with this patch. > > ./build-support/jenkins/build.sh > > > > I will refresh this build result if you post a review containing > > "@ReviewBot retry" > > Stephan Erb wrote: > Finally :) Excellent! Thanks for your help with this! - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/#review193623 ------- On Dec. 9, 2017, 9:32 a.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64290/ > --- > > (Updated Dec. 9, 2017, 9:32 a.m.) > > > Review request for Aurora, Stephan Erb and Bill Farner. > > > Repository: aurora > > > Description > --- > > Update to Thrift 0.10.0 (https://github.com/apache/thrift/blob/master/CHANGES) > > Included changes: > > * Update to the latest pants version. This was necesary to get ./pants gen > working. > * The Java hashcode option has been removed as it is now the default. > > > Diffs > - > > .isort.cfg f53ccba7d1d45adcb4753cfd05c53bbec5c89dde > 3rdparty/python/requirements.txt 85a23d7770d82bfc74b1fc847170a8779dd7249f > api/src/main/thrift/org/apache/aurora/gen/BUILD > 835b0cc6f51a592f7d5b6129dbe9519455eb6555 > api/src/main/thrift/org/apache/thermos/BUILD > b58338e76bdee3481071d8f27235a9dbb6bf07b5 > build-support/jenkins/build.sh f59fe278aea55fc3ffa1b5dff7b686cfcfae1ee7 > build-support/packer/build.sh 85444125abc0c7e600a09933411e57c0d74051ac > build-support/python/checkstyle-check > 0c8800232e20347b2be9a538ffed1d47a7815241 > build-support/python/isort 37e6cd23d2437055a15abfec6924c1bdd051de20 > build-support/python/isort-check a1bb94c99250f54f8fc261fb311cd34ce8355c78 > build-support/python/isort-run 1b39d41212d6e870c55d420a9d844fd67dd40eae > build-support/release/make-python-sdists > 51e11dbc1929609374031c9b23a96f035eba902b > build-support/thrift/.gitignore 82c5bc5cd773ecf3ec194de41a340a3ef9b83aa5 > build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch > 77c966caa3d1f644241bcc2b1968bc9306c56689 > > build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch > 42300b43a8f72e45c96b975e5d3a6a7bd0283529 > build-support/thrift/AURORA-1727.lib.py.setup.py.patch > 11c7b13341e156f3686511cb40ab13c1256203a6 > build-support/thrift/BUILD ab19f1f68682d88f731a463c15591e45a317e760 > build-support/thrift/Makefile f440b610afe321af663e393a29eebda7af7bd7a8 > build-support/thrift/prepare_binary.sh > 4ad997bf039294f7940b93a76ebf014689f8f618 > build-support/thrift/thriftw c8debd07bc9da97fb58db795e67c9ac82cc30bc1 > build.gradle 76dcc040a822db2e209646e62b71ae45bf3f4793 > buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy > fc2bc9082dae2c63aa578c05dc89feb346260a67 > pants.ini 0671d9ab6381e5b9c324dc09a891a639cbfb2ccc > src/main/python/apache/aurora/client/cli/BUILD > 80a6dec9acf5b64cff64143929916676b79be686 > src/main/python/apache/thermos/observer/BUILD > 95b8dcd7d123d3a2bcb22df7efc60374ef919bf7 > src/test/python/apache/aurora/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/admin/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/api/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/binding_helpers/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/cli/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/docker/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/common/health_check/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/executor/common/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/thermos/core/test_process.py > 6cb9176e14eccbe7ed10501199a34e5e67d6fe44 > > > Diff: https://reviews.apache.org/r/64290/diff/4/ > > > Testing > --- > > ``` > $ ./build-support/jenkins/build.sh > $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ``` > > > Thanks, > > John Sirois > >
Re: Review Request 64290: Update to Thrift 0.10.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/#review193499 --- @ReviewBot retry - John Sirois On Dec. 9, 2017, 9:32 a.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64290/ > --- > > (Updated Dec. 9, 2017, 9:32 a.m.) > > > Review request for Aurora, Stephan Erb and Bill Farner. > > > Repository: aurora > > > Description > --- > > Update to Thrift 0.10.0 (https://github.com/apache/thrift/blob/master/CHANGES) > > Included changes: > > * Update to the latest pants version. This was necesary to get ./pants gen > working. > * The Java hashcode option has been removed as it is now the default. > > > Diffs > - > > .isort.cfg f53ccba7d1d45adcb4753cfd05c53bbec5c89dde > 3rdparty/python/requirements.txt 85a23d7770d82bfc74b1fc847170a8779dd7249f > api/src/main/thrift/org/apache/aurora/gen/BUILD > 835b0cc6f51a592f7d5b6129dbe9519455eb6555 > api/src/main/thrift/org/apache/thermos/BUILD > b58338e76bdee3481071d8f27235a9dbb6bf07b5 > build-support/jenkins/build.sh f59fe278aea55fc3ffa1b5dff7b686cfcfae1ee7 > build-support/packer/build.sh 85444125abc0c7e600a09933411e57c0d74051ac > build-support/python/checkstyle-check > 0c8800232e20347b2be9a538ffed1d47a7815241 > build-support/python/isort 37e6cd23d2437055a15abfec6924c1bdd051de20 > build-support/python/isort-check a1bb94c99250f54f8fc261fb311cd34ce8355c78 > build-support/python/isort-run 1b39d41212d6e870c55d420a9d844fd67dd40eae > build-support/release/make-python-sdists > 51e11dbc1929609374031c9b23a96f035eba902b > build-support/thrift/.gitignore 82c5bc5cd773ecf3ec194de41a340a3ef9b83aa5 > build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch > 77c966caa3d1f644241bcc2b1968bc9306c56689 > > build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch > 42300b43a8f72e45c96b975e5d3a6a7bd0283529 > build-support/thrift/AURORA-1727.lib.py.setup.py.patch > 11c7b13341e156f3686511cb40ab13c1256203a6 > build-support/thrift/BUILD ab19f1f68682d88f731a463c15591e45a317e760 > build-support/thrift/Makefile f440b610afe321af663e393a29eebda7af7bd7a8 > build-support/thrift/prepare_binary.sh > 4ad997bf039294f7940b93a76ebf014689f8f618 > build-support/thrift/thriftw c8debd07bc9da97fb58db795e67c9ac82cc30bc1 > build.gradle 76dcc040a822db2e209646e62b71ae45bf3f4793 > buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy > fc2bc9082dae2c63aa578c05dc89feb346260a67 > pants.ini 0671d9ab6381e5b9c324dc09a891a639cbfb2ccc > src/main/python/apache/aurora/client/cli/BUILD > 80a6dec9acf5b64cff64143929916676b79be686 > src/main/python/apache/thermos/observer/BUILD > 95b8dcd7d123d3a2bcb22df7efc60374ef919bf7 > src/test/python/apache/aurora/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/admin/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/api/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/binding_helpers/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/cli/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/docker/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/common/health_check/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/executor/common/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/thermos/core/test_process.py > 6cb9176e14eccbe7ed10501199a34e5e67d6fe44 > > > Diff: https://reviews.apache.org/r/64290/diff/4/ > > > Testing > --- > > ``` > $ ./build-support/jenkins/build.sh > $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ``` > > > Thanks, > > John Sirois > >
Re: Review Request 64290: Update to Thrift 0.10.0
> On Dec. 11, 2017, 12:38 p.m., Stephan Erb wrote: > > I have filed https://issues.apache.org/jira/browse/AURORA-1961 to address > > the flaky build. Thanks Stephan. - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/#review193430 --- On Dec. 9, 2017, 9:32 a.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64290/ > --- > > (Updated Dec. 9, 2017, 9:32 a.m.) > > > Review request for Aurora, Stephan Erb and Bill Farner. > > > Repository: aurora > > > Description > --- > > Update to Thrift 0.10.0 (https://github.com/apache/thrift/blob/master/CHANGES) > > Included changes: > > * Update to the latest pants version. This was necesary to get ./pants gen > working. > * The Java hashcode option has been removed as it is now the default. > > > Diffs > - > > .isort.cfg f53ccba7d1d45adcb4753cfd05c53bbec5c89dde > 3rdparty/python/requirements.txt 85a23d7770d82bfc74b1fc847170a8779dd7249f > api/src/main/thrift/org/apache/aurora/gen/BUILD > 835b0cc6f51a592f7d5b6129dbe9519455eb6555 > api/src/main/thrift/org/apache/thermos/BUILD > b58338e76bdee3481071d8f27235a9dbb6bf07b5 > build-support/jenkins/build.sh f59fe278aea55fc3ffa1b5dff7b686cfcfae1ee7 > build-support/packer/build.sh 85444125abc0c7e600a09933411e57c0d74051ac > build-support/python/checkstyle-check > 0c8800232e20347b2be9a538ffed1d47a7815241 > build-support/python/isort 37e6cd23d2437055a15abfec6924c1bdd051de20 > build-support/python/isort-check a1bb94c99250f54f8fc261fb311cd34ce8355c78 > build-support/python/isort-run 1b39d41212d6e870c55d420a9d844fd67dd40eae > build-support/release/make-python-sdists > 51e11dbc1929609374031c9b23a96f035eba902b > build-support/thrift/.gitignore 82c5bc5cd773ecf3ec194de41a340a3ef9b83aa5 > build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch > 77c966caa3d1f644241bcc2b1968bc9306c56689 > > build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch > 42300b43a8f72e45c96b975e5d3a6a7bd0283529 > build-support/thrift/AURORA-1727.lib.py.setup.py.patch > 11c7b13341e156f3686511cb40ab13c1256203a6 > build-support/thrift/BUILD ab19f1f68682d88f731a463c15591e45a317e760 > build-support/thrift/Makefile f440b610afe321af663e393a29eebda7af7bd7a8 > build-support/thrift/prepare_binary.sh > 4ad997bf039294f7940b93a76ebf014689f8f618 > build-support/thrift/thriftw c8debd07bc9da97fb58db795e67c9ac82cc30bc1 > build.gradle 76dcc040a822db2e209646e62b71ae45bf3f4793 > buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy > fc2bc9082dae2c63aa578c05dc89feb346260a67 > pants.ini 0671d9ab6381e5b9c324dc09a891a639cbfb2ccc > src/main/python/apache/aurora/client/cli/BUILD > 80a6dec9acf5b64cff64143929916676b79be686 > src/main/python/apache/thermos/observer/BUILD > 95b8dcd7d123d3a2bcb22df7efc60374ef919bf7 > src/test/python/apache/aurora/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/admin/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/api/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/binding_helpers/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/cli/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/docker/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/common/health_check/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/executor/common/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/thermos/core/test_process.py > 6cb9176e14eccbe7ed10501199a34e5e67d6fe44 > > > Diff: https://reviews.apache.org/r/64290/diff/4/ > > > Testing > --- > > ``` > $ ./build-support/jenkins/build.sh > $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ``` > > > Thanks, > > John Sirois > >
Re: Review Request 64290: Update to Thrift 0.10.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/#review193420 --- @ReviewBot retry - John Sirois On Dec. 9, 2017, 9:32 a.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64290/ > --- > > (Updated Dec. 9, 2017, 9:32 a.m.) > > > Review request for Aurora, Stephan Erb and Bill Farner. > > > Repository: aurora > > > Description > --- > > Update to Thrift 0.10.0 (https://github.com/apache/thrift/blob/master/CHANGES) > > Included changes: > > * Update to the latest pants version. This was necesary to get ./pants gen > working. > * The Java hashcode option has been removed as it is now the default. > > > Diffs > - > > .isort.cfg f53ccba7d1d45adcb4753cfd05c53bbec5c89dde > 3rdparty/python/requirements.txt 85a23d7770d82bfc74b1fc847170a8779dd7249f > api/src/main/thrift/org/apache/aurora/gen/BUILD > 835b0cc6f51a592f7d5b6129dbe9519455eb6555 > api/src/main/thrift/org/apache/thermos/BUILD > b58338e76bdee3481071d8f27235a9dbb6bf07b5 > build-support/jenkins/build.sh f59fe278aea55fc3ffa1b5dff7b686cfcfae1ee7 > build-support/packer/build.sh 85444125abc0c7e600a09933411e57c0d74051ac > build-support/python/checkstyle-check > 0c8800232e20347b2be9a538ffed1d47a7815241 > build-support/python/isort 37e6cd23d2437055a15abfec6924c1bdd051de20 > build-support/python/isort-check a1bb94c99250f54f8fc261fb311cd34ce8355c78 > build-support/python/isort-run 1b39d41212d6e870c55d420a9d844fd67dd40eae > build-support/release/make-python-sdists > 51e11dbc1929609374031c9b23a96f035eba902b > build-support/thrift/.gitignore 82c5bc5cd773ecf3ec194de41a340a3ef9b83aa5 > build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch > 77c966caa3d1f644241bcc2b1968bc9306c56689 > > build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch > 42300b43a8f72e45c96b975e5d3a6a7bd0283529 > build-support/thrift/AURORA-1727.lib.py.setup.py.patch > 11c7b13341e156f3686511cb40ab13c1256203a6 > build-support/thrift/BUILD ab19f1f68682d88f731a463c15591e45a317e760 > build-support/thrift/Makefile f440b610afe321af663e393a29eebda7af7bd7a8 > build-support/thrift/prepare_binary.sh > 4ad997bf039294f7940b93a76ebf014689f8f618 > build-support/thrift/thriftw c8debd07bc9da97fb58db795e67c9ac82cc30bc1 > build.gradle 76dcc040a822db2e209646e62b71ae45bf3f4793 > buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy > fc2bc9082dae2c63aa578c05dc89feb346260a67 > pants.ini 0671d9ab6381e5b9c324dc09a891a639cbfb2ccc > src/main/python/apache/aurora/client/cli/BUILD > 80a6dec9acf5b64cff64143929916676b79be686 > src/main/python/apache/thermos/observer/BUILD > 95b8dcd7d123d3a2bcb22df7efc60374ef919bf7 > src/test/python/apache/aurora/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/admin/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/api/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/binding_helpers/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/cli/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/docker/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/common/health_check/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/executor/common/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/thermos/core/test_process.py > 6cb9176e14eccbe7ed10501199a34e5e67d6fe44 > > > Diff: https://reviews.apache.org/r/64290/diff/4/ > > > Testing > --- > > ``` > $ ./build-support/jenkins/build.sh > $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ``` > > > Thanks, > > John Sirois > >
Re: Review Request 64290: Update to Thrift 0.10.0
> On Dec. 11, 2017, 12:19 a.m., Aurora ReviewBot wrote:
> > Master (ef24c2c) is red with this patch.
> > ./build-support/jenkins/build.sh
> >
> >SUCCESS
> >
> > 07:19:08 00:00 [main]
> >(To run a reporting server: ./pants server)
> > 07:19:08 00:00 [setup]
> > 07:19:08 00:00 [parse]
> >Executing tasks in goals: gen -> pyprep -> setup-py
> > 07:19:08 00:00 [gen]
> > 07:19:09 00:01 [thrift-py]
> > 07:19:09 00:01 [pyprep]
> > 07:19:09 00:01 [interpreter]
> > 07:19:09 00:01 [requirements]
> > 07:19:09 00:01 [cache]
> >No cached artifacts for 1 target.
> >Invalidated 1 target. Failed to install
> > pykerberos-1.1.14 (caused by: NonZeroExit("received exit code 1 during
> > execution of `[u'/usr/bin/python2.7', '-', 'bdist_wheel',
> > '--dist-dir=/tmp/tmpoky0pr']` while trying to execute
> > `[u'/usr/bin/python2.7', '-', 'bdist_wheel',
> > '--dist-dir=/tmp/tmpoky0pr']`",)
> > ):
> > stdout:
> > running bdist_wheel
> > running build
> > running build_ext
> > building 'kerberos' extension
> > creating build
> > creating build/temp.linux-x86_64-2.7
> > creating build/temp.linux-x86_64-2.7/src
> > x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall
> > -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g
> > -fstack-protector-strong -Wformat -Werror=format-security -fPIC
> > -I/usr/include/python2.7 -c src/kerberos.c -o
> > build/temp.linux-x86_64-2.7/src/kerberos.o
> >
> > stderr:
> > In file included from src/kerberos.c:19:0:
> > src/kerberosbasic.h:17:27: fatal error: gssapi/gssapi.h: No such file or
> > directory
> > compilation terminated.
> > error: command 'x86_64-linux-gnu-gcc' failed with exit status 1
> >
> >
> >
> > 07:19:10 00:02 [complete]
> >FAILURE
> > Exception caught: ()
> >
> > Exception message: Package
> > SourcePackage(u'file:///home/jenkins/jenkins-slave/workspace/AuroraBot/.pants.d/python-setup/resolved_requirements/CPython-2.7.12/pykerberos-1.1.14.tar.gz')
> > is not translateable by ChainedTranslator(WheelTranslator, EggTranslator,
> > SourceTranslator)
> >
> >
> >
> > I will refresh this build result if you post a review containing
> > "@ReviewBot retry"
@ReviewBot retry
- John
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64290/#review193376
---
On Dec. 9, 2017, 9:32 a.m., John Sirois wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64290/
> ---
>
> (Updated Dec. 9, 2017, 9:32 a.m.)
>
>
> Review request for Aurora, Stephan Erb and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> ---
>
> Update to Thrift 0.10.0 (https://github.com/apache/thrift/blob/master/CHANGES)
>
> Included changes:
>
> * Update to the latest pants version. This was necesary to get ./pants gen
> working.
> * The Java hashcode option has been removed as it is now the default.
>
>
> Diffs
> -
>
> .isort.cfg f53ccba7d1d45adcb4753cfd05c53bbec5c89dde
> 3rdparty/python/requirements.txt 85a23d7770d82bfc74b1fc847170a8779dd7249f
> api/src/main/thrift/org/apache/aurora/gen/BUILD
> 835b0cc6f51a592f7d5b6129dbe9519455eb6555
> api/src/main/thrift/org/apache/thermos/BUILD
> b58338e76bdee3481071d8f27235a9dbb6bf07b5
> build-support/jenkins/build.sh f59fe278aea55fc3ffa1b5dff7b686cfcfae1ee7
> build-support/packer/build.sh 85444125abc0c7e600a09933411e57c0d74051ac
> build-support/python/checkstyle-check
> 0c8800232e20347b2be9a538ffed1d47a7815241
> build-support/python/isort 37e6cd23d2437055a15abfec6924c1bdd051de20
> build-support/python/isort-check a1bb94c99250f54f8fc261fb311cd34ce8355c78
> build-support/python/isort-run 1b39d41212d6e870c55d420a9d844fd67dd40eae
> build-support/release/make-python-sdists
> 51e11dbc1929609374031c9b23a96f035eba902b
> build-support/thrift/.gitignore 82c5bc5cd773ecf3ec194de41a340a3ef9b83aa5
> build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch
> 77c966caa3d1f644241bcc2
Re: Review Request 64290: Update to Thrift 0.10.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/#review193374 --- @ReviewBot retry - John Sirois On Dec. 9, 2017, 9:32 a.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64290/ > --- > > (Updated Dec. 9, 2017, 9:32 a.m.) > > > Review request for Aurora, Stephan Erb and Bill Farner. > > > Repository: aurora > > > Description > --- > > Update to Thrift 0.10.0 (https://github.com/apache/thrift/blob/master/CHANGES) > > Included changes: > > * Update to the latest pants version. This was necesary to get ./pants gen > working. > * The Java hashcode option has been removed as it is now the default. > > > Diffs > - > > .isort.cfg f53ccba7d1d45adcb4753cfd05c53bbec5c89dde > 3rdparty/python/requirements.txt 85a23d7770d82bfc74b1fc847170a8779dd7249f > api/src/main/thrift/org/apache/aurora/gen/BUILD > 835b0cc6f51a592f7d5b6129dbe9519455eb6555 > api/src/main/thrift/org/apache/thermos/BUILD > b58338e76bdee3481071d8f27235a9dbb6bf07b5 > build-support/jenkins/build.sh f59fe278aea55fc3ffa1b5dff7b686cfcfae1ee7 > build-support/packer/build.sh 85444125abc0c7e600a09933411e57c0d74051ac > build-support/python/checkstyle-check > 0c8800232e20347b2be9a538ffed1d47a7815241 > build-support/python/isort 37e6cd23d2437055a15abfec6924c1bdd051de20 > build-support/python/isort-check a1bb94c99250f54f8fc261fb311cd34ce8355c78 > build-support/python/isort-run 1b39d41212d6e870c55d420a9d844fd67dd40eae > build-support/release/make-python-sdists > 51e11dbc1929609374031c9b23a96f035eba902b > build-support/thrift/.gitignore 82c5bc5cd773ecf3ec194de41a340a3ef9b83aa5 > build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch > 77c966caa3d1f644241bcc2b1968bc9306c56689 > > build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch > 42300b43a8f72e45c96b975e5d3a6a7bd0283529 > build-support/thrift/AURORA-1727.lib.py.setup.py.patch > 11c7b13341e156f3686511cb40ab13c1256203a6 > build-support/thrift/BUILD ab19f1f68682d88f731a463c15591e45a317e760 > build-support/thrift/Makefile f440b610afe321af663e393a29eebda7af7bd7a8 > build-support/thrift/prepare_binary.sh > 4ad997bf039294f7940b93a76ebf014689f8f618 > build-support/thrift/thriftw c8debd07bc9da97fb58db795e67c9ac82cc30bc1 > build.gradle 76dcc040a822db2e209646e62b71ae45bf3f4793 > buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy > fc2bc9082dae2c63aa578c05dc89feb346260a67 > pants.ini 0671d9ab6381e5b9c324dc09a891a639cbfb2ccc > src/main/python/apache/aurora/client/cli/BUILD > 80a6dec9acf5b64cff64143929916676b79be686 > src/main/python/apache/thermos/observer/BUILD > 95b8dcd7d123d3a2bcb22df7efc60374ef919bf7 > src/test/python/apache/aurora/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/admin/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/api/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/binding_helpers/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/cli/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/docker/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/common/health_check/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/executor/common/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/thermos/core/test_process.py > 6cb9176e14eccbe7ed10501199a34e5e67d6fe44 > > > Diff: https://reviews.apache.org/r/64290/diff/4/ > > > Testing > --- > > ``` > $ ./build-support/jenkins/build.sh > $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ``` > > > Thanks, > > John Sirois > >
Re: Review Request 64290: Update to Thrift 0.10.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/#review193356 --- @ReviewBot retry - John Sirois On Dec. 9, 2017, 9:32 a.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64290/ > --- > > (Updated Dec. 9, 2017, 9:32 a.m.) > > > Review request for Aurora, Stephan Erb and Bill Farner. > > > Repository: aurora > > > Description > --- > > Update to Thrift 0.10.0 (https://github.com/apache/thrift/blob/master/CHANGES) > > Included changes: > > * Update to the latest pants version. This was necesary to get ./pants gen > working. > * The Java hashcode option has been removed as it is now the default. > > > Diffs > - > > .isort.cfg f53ccba7d1d45adcb4753cfd05c53bbec5c89dde > 3rdparty/python/requirements.txt 85a23d7770d82bfc74b1fc847170a8779dd7249f > api/src/main/thrift/org/apache/aurora/gen/BUILD > 835b0cc6f51a592f7d5b6129dbe9519455eb6555 > api/src/main/thrift/org/apache/thermos/BUILD > b58338e76bdee3481071d8f27235a9dbb6bf07b5 > build-support/jenkins/build.sh f59fe278aea55fc3ffa1b5dff7b686cfcfae1ee7 > build-support/packer/build.sh 85444125abc0c7e600a09933411e57c0d74051ac > build-support/python/checkstyle-check > 0c8800232e20347b2be9a538ffed1d47a7815241 > build-support/python/isort 37e6cd23d2437055a15abfec6924c1bdd051de20 > build-support/python/isort-check a1bb94c99250f54f8fc261fb311cd34ce8355c78 > build-support/python/isort-run 1b39d41212d6e870c55d420a9d844fd67dd40eae > build-support/release/make-python-sdists > 51e11dbc1929609374031c9b23a96f035eba902b > build-support/thrift/.gitignore 82c5bc5cd773ecf3ec194de41a340a3ef9b83aa5 > build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch > 77c966caa3d1f644241bcc2b1968bc9306c56689 > > build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch > 42300b43a8f72e45c96b975e5d3a6a7bd0283529 > build-support/thrift/AURORA-1727.lib.py.setup.py.patch > 11c7b13341e156f3686511cb40ab13c1256203a6 > build-support/thrift/BUILD ab19f1f68682d88f731a463c15591e45a317e760 > build-support/thrift/Makefile f440b610afe321af663e393a29eebda7af7bd7a8 > build-support/thrift/prepare_binary.sh > 4ad997bf039294f7940b93a76ebf014689f8f618 > build-support/thrift/thriftw c8debd07bc9da97fb58db795e67c9ac82cc30bc1 > build.gradle 76dcc040a822db2e209646e62b71ae45bf3f4793 > buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy > fc2bc9082dae2c63aa578c05dc89feb346260a67 > pants.ini 0671d9ab6381e5b9c324dc09a891a639cbfb2ccc > src/main/python/apache/aurora/client/cli/BUILD > 80a6dec9acf5b64cff64143929916676b79be686 > src/main/python/apache/thermos/observer/BUILD > 95b8dcd7d123d3a2bcb22df7efc60374ef919bf7 > src/test/python/apache/aurora/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/admin/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/api/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/binding_helpers/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/cli/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/docker/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/common/health_check/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/executor/common/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/thermos/core/test_process.py > 6cb9176e14eccbe7ed10501199a34e5e67d6fe44 > > > Diff: https://reviews.apache.org/r/64290/diff/4/ > > > Testing > --- > > ``` > $ ./build-support/jenkins/build.sh > $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ``` > > > Thanks, > > John Sirois > >
Re: Review Request 64290: Update to Thrift 0.10.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/#review193354 --- @ReviewBot retry - John Sirois On Dec. 9, 2017, 9:32 a.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64290/ > --- > > (Updated Dec. 9, 2017, 9:32 a.m.) > > > Review request for Aurora, Stephan Erb and Bill Farner. > > > Repository: aurora > > > Description > --- > > Update to Thrift 0.10.0 (https://github.com/apache/thrift/blob/master/CHANGES) > > Included changes: > > * Update to the latest pants version. This was necesary to get ./pants gen > working. > * The Java hashcode option has been removed as it is now the default. > > > Diffs > - > > .isort.cfg f53ccba7d1d45adcb4753cfd05c53bbec5c89dde > 3rdparty/python/requirements.txt 85a23d7770d82bfc74b1fc847170a8779dd7249f > api/src/main/thrift/org/apache/aurora/gen/BUILD > 835b0cc6f51a592f7d5b6129dbe9519455eb6555 > api/src/main/thrift/org/apache/thermos/BUILD > b58338e76bdee3481071d8f27235a9dbb6bf07b5 > build-support/jenkins/build.sh f59fe278aea55fc3ffa1b5dff7b686cfcfae1ee7 > build-support/packer/build.sh 85444125abc0c7e600a09933411e57c0d74051ac > build-support/python/checkstyle-check > 0c8800232e20347b2be9a538ffed1d47a7815241 > build-support/python/isort 37e6cd23d2437055a15abfec6924c1bdd051de20 > build-support/python/isort-check a1bb94c99250f54f8fc261fb311cd34ce8355c78 > build-support/python/isort-run 1b39d41212d6e870c55d420a9d844fd67dd40eae > build-support/release/make-python-sdists > 51e11dbc1929609374031c9b23a96f035eba902b > build-support/thrift/.gitignore 82c5bc5cd773ecf3ec194de41a340a3ef9b83aa5 > build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch > 77c966caa3d1f644241bcc2b1968bc9306c56689 > > build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch > 42300b43a8f72e45c96b975e5d3a6a7bd0283529 > build-support/thrift/AURORA-1727.lib.py.setup.py.patch > 11c7b13341e156f3686511cb40ab13c1256203a6 > build-support/thrift/BUILD ab19f1f68682d88f731a463c15591e45a317e760 > build-support/thrift/Makefile f440b610afe321af663e393a29eebda7af7bd7a8 > build-support/thrift/prepare_binary.sh > 4ad997bf039294f7940b93a76ebf014689f8f618 > build-support/thrift/thriftw c8debd07bc9da97fb58db795e67c9ac82cc30bc1 > build.gradle 76dcc040a822db2e209646e62b71ae45bf3f4793 > buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy > fc2bc9082dae2c63aa578c05dc89feb346260a67 > pants.ini 0671d9ab6381e5b9c324dc09a891a639cbfb2ccc > src/main/python/apache/aurora/client/cli/BUILD > 80a6dec9acf5b64cff64143929916676b79be686 > src/main/python/apache/thermos/observer/BUILD > 95b8dcd7d123d3a2bcb22df7efc60374ef919bf7 > src/test/python/apache/aurora/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/admin/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/api/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/binding_helpers/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/cli/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/docker/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/common/health_check/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/executor/common/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/thermos/core/test_process.py > 6cb9176e14eccbe7ed10501199a34e5e67d6fe44 > > > Diff: https://reviews.apache.org/r/64290/diff/4/ > > > Testing > --- > > ``` > $ ./build-support/jenkins/build.sh > $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ``` > > > Thanks, > > John Sirois > >
Re: Review Request 64290: Update to Thrift 0.10.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/#review193351 --- @ReviewBot retry - John Sirois On Dec. 9, 2017, 9:32 a.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64290/ > --- > > (Updated Dec. 9, 2017, 9:32 a.m.) > > > Review request for Aurora, Stephan Erb and Bill Farner. > > > Repository: aurora > > > Description > --- > > Update to Thrift 0.10.0 (https://github.com/apache/thrift/blob/master/CHANGES) > > Included changes: > > * Update to the latest pants version. This was necesary to get ./pants gen > working. > * The Java hashcode option has been removed as it is now the default. > > > Diffs > - > > .isort.cfg f53ccba7d1d45adcb4753cfd05c53bbec5c89dde > 3rdparty/python/requirements.txt 85a23d7770d82bfc74b1fc847170a8779dd7249f > api/src/main/thrift/org/apache/aurora/gen/BUILD > 835b0cc6f51a592f7d5b6129dbe9519455eb6555 > api/src/main/thrift/org/apache/thermos/BUILD > b58338e76bdee3481071d8f27235a9dbb6bf07b5 > build-support/jenkins/build.sh f59fe278aea55fc3ffa1b5dff7b686cfcfae1ee7 > build-support/packer/build.sh 85444125abc0c7e600a09933411e57c0d74051ac > build-support/python/checkstyle-check > 0c8800232e20347b2be9a538ffed1d47a7815241 > build-support/python/isort 37e6cd23d2437055a15abfec6924c1bdd051de20 > build-support/python/isort-check a1bb94c99250f54f8fc261fb311cd34ce8355c78 > build-support/python/isort-run 1b39d41212d6e870c55d420a9d844fd67dd40eae > build-support/release/make-python-sdists > 51e11dbc1929609374031c9b23a96f035eba902b > build-support/thrift/.gitignore 82c5bc5cd773ecf3ec194de41a340a3ef9b83aa5 > build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch > 77c966caa3d1f644241bcc2b1968bc9306c56689 > > build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch > 42300b43a8f72e45c96b975e5d3a6a7bd0283529 > build-support/thrift/AURORA-1727.lib.py.setup.py.patch > 11c7b13341e156f3686511cb40ab13c1256203a6 > build-support/thrift/BUILD ab19f1f68682d88f731a463c15591e45a317e760 > build-support/thrift/Makefile f440b610afe321af663e393a29eebda7af7bd7a8 > build-support/thrift/prepare_binary.sh > 4ad997bf039294f7940b93a76ebf014689f8f618 > build-support/thrift/thriftw c8debd07bc9da97fb58db795e67c9ac82cc30bc1 > build.gradle 76dcc040a822db2e209646e62b71ae45bf3f4793 > buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy > fc2bc9082dae2c63aa578c05dc89feb346260a67 > pants.ini 0671d9ab6381e5b9c324dc09a891a639cbfb2ccc > src/main/python/apache/aurora/client/cli/BUILD > 80a6dec9acf5b64cff64143929916676b79be686 > src/main/python/apache/thermos/observer/BUILD > 95b8dcd7d123d3a2bcb22df7efc60374ef919bf7 > src/test/python/apache/aurora/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/admin/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/api/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/binding_helpers/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/cli/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/docker/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/common/health_check/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/executor/common/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/thermos/core/test_process.py > 6cb9176e14eccbe7ed10501199a34e5e67d6fe44 > > > Diff: https://reviews.apache.org/r/64290/diff/4/ > > > Testing > --- > > ``` > $ ./build-support/jenkins/build.sh > $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ``` > > > Thanks, > > John Sirois > >
Re: Review Request 64290: Update to Thrift 0.10.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/#review193344 --- - John Sirois On Dec. 9, 2017, 9:32 a.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64290/ > --- > > (Updated Dec. 9, 2017, 9:32 a.m.) > > > Review request for Aurora, Stephan Erb and Bill Farner. > > > Repository: aurora > > > Description > --- > > Update to Thrift 0.10.0 (https://github.com/apache/thrift/blob/master/CHANGES) > > Included changes: > > * Update to the latest pants version. This was necesary to get ./pants gen > working. > * The Java hashcode option has been removed as it is now the default. > > > Diffs > - > > .isort.cfg f53ccba7d1d45adcb4753cfd05c53bbec5c89dde > 3rdparty/python/requirements.txt 85a23d7770d82bfc74b1fc847170a8779dd7249f > api/src/main/thrift/org/apache/aurora/gen/BUILD > 835b0cc6f51a592f7d5b6129dbe9519455eb6555 > api/src/main/thrift/org/apache/thermos/BUILD > b58338e76bdee3481071d8f27235a9dbb6bf07b5 > build-support/jenkins/build.sh f59fe278aea55fc3ffa1b5dff7b686cfcfae1ee7 > build-support/packer/build.sh 85444125abc0c7e600a09933411e57c0d74051ac > build-support/python/checkstyle-check > 0c8800232e20347b2be9a538ffed1d47a7815241 > build-support/python/isort 37e6cd23d2437055a15abfec6924c1bdd051de20 > build-support/python/isort-check a1bb94c99250f54f8fc261fb311cd34ce8355c78 > build-support/python/isort-run 1b39d41212d6e870c55d420a9d844fd67dd40eae > build-support/release/make-python-sdists > 51e11dbc1929609374031c9b23a96f035eba902b > build-support/thrift/.gitignore 82c5bc5cd773ecf3ec194de41a340a3ef9b83aa5 > build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch > 77c966caa3d1f644241bcc2b1968bc9306c56689 > > build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch > 42300b43a8f72e45c96b975e5d3a6a7bd0283529 > build-support/thrift/AURORA-1727.lib.py.setup.py.patch > 11c7b13341e156f3686511cb40ab13c1256203a6 > build-support/thrift/BUILD ab19f1f68682d88f731a463c15591e45a317e760 > build-support/thrift/Makefile f440b610afe321af663e393a29eebda7af7bd7a8 > build-support/thrift/prepare_binary.sh > 4ad997bf039294f7940b93a76ebf014689f8f618 > build-support/thrift/thriftw c8debd07bc9da97fb58db795e67c9ac82cc30bc1 > build.gradle 76dcc040a822db2e209646e62b71ae45bf3f4793 > buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy > fc2bc9082dae2c63aa578c05dc89feb346260a67 > pants.ini 0671d9ab6381e5b9c324dc09a891a639cbfb2ccc > src/main/python/apache/aurora/client/cli/BUILD > 80a6dec9acf5b64cff64143929916676b79be686 > src/main/python/apache/thermos/observer/BUILD > 95b8dcd7d123d3a2bcb22df7efc60374ef919bf7 > src/test/python/apache/aurora/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/admin/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/api/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/binding_helpers/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/cli/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/docker/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/common/health_check/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/executor/common/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/thermos/core/test_process.py > 6cb9176e14eccbe7ed10501199a34e5e67d6fe44 > > > Diff: https://reviews.apache.org/r/64290/diff/4/ > > > Testing > --- > > ``` > $ ./build-support/jenkins/build.sh > $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ``` > > > Thanks, > > John Sirois > >
Re: Review Request 64290: Update to Thrift 0.10.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/#review193343 --- - John Sirois On Dec. 9, 2017, 9:32 a.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64290/ > --- > > (Updated Dec. 9, 2017, 9:32 a.m.) > > > Review request for Aurora, Stephan Erb and Bill Farner. > > > Repository: aurora > > > Description > --- > > Update to Thrift 0.10.0 (https://github.com/apache/thrift/blob/master/CHANGES) > > Included changes: > > * Update to the latest pants version. This was necesary to get ./pants gen > working. > * The Java hashcode option has been removed as it is now the default. > > > Diffs > - > > .isort.cfg f53ccba7d1d45adcb4753cfd05c53bbec5c89dde > 3rdparty/python/requirements.txt 85a23d7770d82bfc74b1fc847170a8779dd7249f > api/src/main/thrift/org/apache/aurora/gen/BUILD > 835b0cc6f51a592f7d5b6129dbe9519455eb6555 > api/src/main/thrift/org/apache/thermos/BUILD > b58338e76bdee3481071d8f27235a9dbb6bf07b5 > build-support/jenkins/build.sh f59fe278aea55fc3ffa1b5dff7b686cfcfae1ee7 > build-support/packer/build.sh 85444125abc0c7e600a09933411e57c0d74051ac > build-support/python/checkstyle-check > 0c8800232e20347b2be9a538ffed1d47a7815241 > build-support/python/isort 37e6cd23d2437055a15abfec6924c1bdd051de20 > build-support/python/isort-check a1bb94c99250f54f8fc261fb311cd34ce8355c78 > build-support/python/isort-run 1b39d41212d6e870c55d420a9d844fd67dd40eae > build-support/release/make-python-sdists > 51e11dbc1929609374031c9b23a96f035eba902b > build-support/thrift/.gitignore 82c5bc5cd773ecf3ec194de41a340a3ef9b83aa5 > build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch > 77c966caa3d1f644241bcc2b1968bc9306c56689 > > build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch > 42300b43a8f72e45c96b975e5d3a6a7bd0283529 > build-support/thrift/AURORA-1727.lib.py.setup.py.patch > 11c7b13341e156f3686511cb40ab13c1256203a6 > build-support/thrift/BUILD ab19f1f68682d88f731a463c15591e45a317e760 > build-support/thrift/Makefile f440b610afe321af663e393a29eebda7af7bd7a8 > build-support/thrift/prepare_binary.sh > 4ad997bf039294f7940b93a76ebf014689f8f618 > build-support/thrift/thriftw c8debd07bc9da97fb58db795e67c9ac82cc30bc1 > build.gradle 76dcc040a822db2e209646e62b71ae45bf3f4793 > buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy > fc2bc9082dae2c63aa578c05dc89feb346260a67 > pants.ini 0671d9ab6381e5b9c324dc09a891a639cbfb2ccc > src/main/python/apache/aurora/client/cli/BUILD > 80a6dec9acf5b64cff64143929916676b79be686 > src/main/python/apache/thermos/observer/BUILD > 95b8dcd7d123d3a2bcb22df7efc60374ef919bf7 > src/test/python/apache/aurora/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/admin/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/api/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/binding_helpers/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/cli/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/docker/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/common/health_check/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/executor/common/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/thermos/core/test_process.py > 6cb9176e14eccbe7ed10501199a34e5e67d6fe44 > > > Diff: https://reviews.apache.org/r/64290/diff/4/ > > > Testing > --- > > ``` > $ ./build-support/jenkins/build.sh > $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ``` > > > Thanks, > > John Sirois > >
Re: Review Request 64290: Update to Thrift 0.10.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/#review193341 --- @ReviewBot retry - John Sirois On Dec. 9, 2017, 9:32 a.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64290/ > --- > > (Updated Dec. 9, 2017, 9:32 a.m.) > > > Review request for Aurora, Stephan Erb and Bill Farner. > > > Repository: aurora > > > Description > --- > > Update to Thrift 0.10.0 (https://github.com/apache/thrift/blob/master/CHANGES) > > Included changes: > > * Update to the latest pants version. This was necesary to get ./pants gen > working. > * The Java hashcode option has been removed as it is now the default. > > > Diffs > - > > .isort.cfg f53ccba7d1d45adcb4753cfd05c53bbec5c89dde > 3rdparty/python/requirements.txt 85a23d7770d82bfc74b1fc847170a8779dd7249f > api/src/main/thrift/org/apache/aurora/gen/BUILD > 835b0cc6f51a592f7d5b6129dbe9519455eb6555 > api/src/main/thrift/org/apache/thermos/BUILD > b58338e76bdee3481071d8f27235a9dbb6bf07b5 > build-support/jenkins/build.sh f59fe278aea55fc3ffa1b5dff7b686cfcfae1ee7 > build-support/packer/build.sh 85444125abc0c7e600a09933411e57c0d74051ac > build-support/python/checkstyle-check > 0c8800232e20347b2be9a538ffed1d47a7815241 > build-support/python/isort 37e6cd23d2437055a15abfec6924c1bdd051de20 > build-support/python/isort-check a1bb94c99250f54f8fc261fb311cd34ce8355c78 > build-support/python/isort-run 1b39d41212d6e870c55d420a9d844fd67dd40eae > build-support/release/make-python-sdists > 51e11dbc1929609374031c9b23a96f035eba902b > build-support/thrift/.gitignore 82c5bc5cd773ecf3ec194de41a340a3ef9b83aa5 > build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch > 77c966caa3d1f644241bcc2b1968bc9306c56689 > > build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch > 42300b43a8f72e45c96b975e5d3a6a7bd0283529 > build-support/thrift/AURORA-1727.lib.py.setup.py.patch > 11c7b13341e156f3686511cb40ab13c1256203a6 > build-support/thrift/BUILD ab19f1f68682d88f731a463c15591e45a317e760 > build-support/thrift/Makefile f440b610afe321af663e393a29eebda7af7bd7a8 > build-support/thrift/prepare_binary.sh > 4ad997bf039294f7940b93a76ebf014689f8f618 > build-support/thrift/thriftw c8debd07bc9da97fb58db795e67c9ac82cc30bc1 > build.gradle 76dcc040a822db2e209646e62b71ae45bf3f4793 > buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy > fc2bc9082dae2c63aa578c05dc89feb346260a67 > pants.ini 0671d9ab6381e5b9c324dc09a891a639cbfb2ccc > src/main/python/apache/aurora/client/cli/BUILD > 80a6dec9acf5b64cff64143929916676b79be686 > src/main/python/apache/thermos/observer/BUILD > 95b8dcd7d123d3a2bcb22df7efc60374ef919bf7 > src/test/python/apache/aurora/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/admin/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/api/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/binding_helpers/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/cli/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/docker/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/common/health_check/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/executor/common/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/thermos/core/test_process.py > 6cb9176e14eccbe7ed10501199a34e5e67d6fe44 > > > Diff: https://reviews.apache.org/r/64290/diff/4/ > > > Testing > --- > > ``` > $ ./build-support/jenkins/build.sh > $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ``` > > > Thanks, > > John Sirois > >
Re: Review Request 64290: Update to Thrift 0.10.0
> On Dec. 9, 2017, 6:08 a.m., Stephan Erb wrote: > > Looks good, thanks! > > > > This patch will not apply cleanly after the merge of > > https://reviews.apache.org/r/64382/. The merge conflict is trivial to > > resolve though. I have re-run the end-to-end tests with both patches > > applied and all looks good. Thanks Stephan, I've merged and re-posted the diff. We'll see how things go on this flaky test. I may need to detour to fix it up. - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/#review193328 ------- On Dec. 9, 2017, 9:32 a.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64290/ > --- > > (Updated Dec. 9, 2017, 9:32 a.m.) > > > Review request for Aurora, Stephan Erb and Bill Farner. > > > Repository: aurora > > > Description > --- > > Update to Thrift 0.10.0 (https://github.com/apache/thrift/blob/master/CHANGES) > > Included changes: > > * Update to the latest pants version. This was necesary to get ./pants gen > working. > * The Java hashcode option has been removed as it is now the default. > > > Diffs > - > > .isort.cfg f53ccba7d1d45adcb4753cfd05c53bbec5c89dde > 3rdparty/python/requirements.txt 85a23d7770d82bfc74b1fc847170a8779dd7249f > api/src/main/thrift/org/apache/aurora/gen/BUILD > 835b0cc6f51a592f7d5b6129dbe9519455eb6555 > api/src/main/thrift/org/apache/thermos/BUILD > b58338e76bdee3481071d8f27235a9dbb6bf07b5 > build-support/jenkins/build.sh f59fe278aea55fc3ffa1b5dff7b686cfcfae1ee7 > build-support/packer/build.sh 85444125abc0c7e600a09933411e57c0d74051ac > build-support/python/checkstyle-check > 0c8800232e20347b2be9a538ffed1d47a7815241 > build-support/python/isort 37e6cd23d2437055a15abfec6924c1bdd051de20 > build-support/python/isort-check a1bb94c99250f54f8fc261fb311cd34ce8355c78 > build-support/python/isort-run 1b39d41212d6e870c55d420a9d844fd67dd40eae > build-support/release/make-python-sdists > 51e11dbc1929609374031c9b23a96f035eba902b > build-support/thrift/.gitignore 82c5bc5cd773ecf3ec194de41a340a3ef9b83aa5 > build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch > 77c966caa3d1f644241bcc2b1968bc9306c56689 > > build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch > 42300b43a8f72e45c96b975e5d3a6a7bd0283529 > build-support/thrift/AURORA-1727.lib.py.setup.py.patch > 11c7b13341e156f3686511cb40ab13c1256203a6 > build-support/thrift/BUILD ab19f1f68682d88f731a463c15591e45a317e760 > build-support/thrift/Makefile f440b610afe321af663e393a29eebda7af7bd7a8 > build-support/thrift/prepare_binary.sh > 4ad997bf039294f7940b93a76ebf014689f8f618 > build-support/thrift/thriftw c8debd07bc9da97fb58db795e67c9ac82cc30bc1 > build.gradle 76dcc040a822db2e209646e62b71ae45bf3f4793 > buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy > fc2bc9082dae2c63aa578c05dc89feb346260a67 > pants.ini 0671d9ab6381e5b9c324dc09a891a639cbfb2ccc > src/main/python/apache/aurora/client/cli/BUILD > 80a6dec9acf5b64cff64143929916676b79be686 > src/main/python/apache/thermos/observer/BUILD > 95b8dcd7d123d3a2bcb22df7efc60374ef919bf7 > src/test/python/apache/aurora/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/admin/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/api/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/binding_helpers/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/cli/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/docker/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/common/health_check/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/executor/common/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/thermos/core/test_process.py > 6cb9176e14eccbe7ed10501199a34e5e67d6fe44 > > > Diff: https://reviews.apache.org/r/64290/diff/4/ > > > Testing > --- > > ``` > $ ./build-support/jenkins/build.sh > $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ``` > > > Thanks, > > John Sirois > >
Re: Review Request 64290: Update to Thrift 0.10.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/ --- (Updated Dec. 9, 2017, 9:32 a.m.) Review request for Aurora, Stephan Erb and Bill Farner. Changes --- Upgrade to Pants 1.4.0.dev23 with thrift fix. pants.ini | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Repository: aurora Description --- Update to Thrift 0.10.0 (https://github.com/apache/thrift/blob/master/CHANGES) Included changes: * Update to the latest pants version. This was necesary to get ./pants gen working. * The Java hashcode option has been removed as it is now the default. Diffs (updated) - .isort.cfg f53ccba7d1d45adcb4753cfd05c53bbec5c89dde 3rdparty/python/requirements.txt 85a23d7770d82bfc74b1fc847170a8779dd7249f api/src/main/thrift/org/apache/aurora/gen/BUILD 835b0cc6f51a592f7d5b6129dbe9519455eb6555 api/src/main/thrift/org/apache/thermos/BUILD b58338e76bdee3481071d8f27235a9dbb6bf07b5 build-support/jenkins/build.sh f59fe278aea55fc3ffa1b5dff7b686cfcfae1ee7 build-support/packer/build.sh 85444125abc0c7e600a09933411e57c0d74051ac build-support/python/checkstyle-check 0c8800232e20347b2be9a538ffed1d47a7815241 build-support/python/isort 37e6cd23d2437055a15abfec6924c1bdd051de20 build-support/python/isort-check a1bb94c99250f54f8fc261fb311cd34ce8355c78 build-support/python/isort-run 1b39d41212d6e870c55d420a9d844fd67dd40eae build-support/release/make-python-sdists 51e11dbc1929609374031c9b23a96f035eba902b build-support/thrift/.gitignore 82c5bc5cd773ecf3ec194de41a340a3ef9b83aa5 build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch 77c966caa3d1f644241bcc2b1968bc9306c56689 build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch 42300b43a8f72e45c96b975e5d3a6a7bd0283529 build-support/thrift/AURORA-1727.lib.py.setup.py.patch 11c7b13341e156f3686511cb40ab13c1256203a6 build-support/thrift/BUILD ab19f1f68682d88f731a463c15591e45a317e760 build-support/thrift/Makefile f440b610afe321af663e393a29eebda7af7bd7a8 build-support/thrift/prepare_binary.sh 4ad997bf039294f7940b93a76ebf014689f8f618 build-support/thrift/thriftw c8debd07bc9da97fb58db795e67c9ac82cc30bc1 build.gradle 76dcc040a822db2e209646e62b71ae45bf3f4793 buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy fc2bc9082dae2c63aa578c05dc89feb346260a67 pants.ini 0671d9ab6381e5b9c324dc09a891a639cbfb2ccc src/main/python/apache/aurora/client/cli/BUILD 80a6dec9acf5b64cff64143929916676b79be686 src/main/python/apache/thermos/observer/BUILD 95b8dcd7d123d3a2bcb22df7efc60374ef919bf7 src/test/python/apache/aurora/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd src/test/python/apache/aurora/admin/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd src/test/python/apache/aurora/client/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd src/test/python/apache/aurora/client/api/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd src/test/python/apache/aurora/client/binding_helpers/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd src/test/python/apache/aurora/client/cli/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd src/test/python/apache/aurora/client/docker/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd src/test/python/apache/aurora/common/health_check/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd src/test/python/apache/aurora/executor/common/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd src/test/python/apache/thermos/core/test_process.py 6cb9176e14eccbe7ed10501199a34e5e67d6fe44 Diff: https://reviews.apache.org/r/64290/diff/4/ Changes: https://reviews.apache.org/r/64290/diff/3-4/ Testing --- ``` $ ./build-support/jenkins/build.sh $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh ``` Thanks, John Sirois
Re: Review Request 64290: Update to Thrift 0.10.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/#review193330 --- - John Sirois On Dec. 8, 2017, 10:16 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64290/ > --- > > (Updated Dec. 8, 2017, 10:16 p.m.) > > > Review request for Aurora, Stephan Erb and Bill Farner. > > > Repository: aurora > > > Description > --- > > Update to Thrift 0.10.0 (https://github.com/apache/thrift/blob/master/CHANGES) > > Included changes: > > * Update to the latest pants version. This was necesary to get ./pants gen > working. > * The Java hashcode option has been removed as it is now the default. > > > Diffs > - > > .isort.cfg f53ccba7d1d45adcb4753cfd05c53bbec5c89dde > 3rdparty/python/requirements.txt 155930dc6b808fb2f573f427a4508e388ee04b5a > api/src/main/thrift/org/apache/aurora/gen/BUILD > 835b0cc6f51a592f7d5b6129dbe9519455eb6555 > api/src/main/thrift/org/apache/thermos/BUILD > b58338e76bdee3481071d8f27235a9dbb6bf07b5 > build-support/jenkins/build.sh f59fe278aea55fc3ffa1b5dff7b686cfcfae1ee7 > build-support/packer/build.sh 85444125abc0c7e600a09933411e57c0d74051ac > build-support/python/checkstyle-check > 0c8800232e20347b2be9a538ffed1d47a7815241 > build-support/python/isort 37e6cd23d2437055a15abfec6924c1bdd051de20 > build-support/python/isort-check a1bb94c99250f54f8fc261fb311cd34ce8355c78 > build-support/python/isort-run 1b39d41212d6e870c55d420a9d844fd67dd40eae > build-support/release/make-python-sdists > 51e11dbc1929609374031c9b23a96f035eba902b > build-support/thrift/.gitignore 82c5bc5cd773ecf3ec194de41a340a3ef9b83aa5 > build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch > 77c966caa3d1f644241bcc2b1968bc9306c56689 > > build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch > 42300b43a8f72e45c96b975e5d3a6a7bd0283529 > build-support/thrift/AURORA-1727.lib.py.setup.py.patch > 11c7b13341e156f3686511cb40ab13c1256203a6 > build-support/thrift/BUILD ab19f1f68682d88f731a463c15591e45a317e760 > build-support/thrift/Makefile f440b610afe321af663e393a29eebda7af7bd7a8 > build-support/thrift/prepare_binary.sh > 4ad997bf039294f7940b93a76ebf014689f8f618 > build-support/thrift/thriftw c8debd07bc9da97fb58db795e67c9ac82cc30bc1 > build.gradle 76dcc040a822db2e209646e62b71ae45bf3f4793 > buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy > fc2bc9082dae2c63aa578c05dc89feb346260a67 > pants.ini 0671d9ab6381e5b9c324dc09a891a639cbfb2ccc > src/main/python/apache/aurora/client/cli/BUILD > 80a6dec9acf5b64cff64143929916676b79be686 > src/main/python/apache/thermos/observer/BUILD > 95b8dcd7d123d3a2bcb22df7efc60374ef919bf7 > src/test/python/apache/aurora/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/admin/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/api/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/binding_helpers/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/cli/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/docker/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/common/health_check/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/executor/common/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/thermos/core/test_process.py > 6cb9176e14eccbe7ed10501199a34e5e67d6fe44 > > > Diff: https://reviews.apache.org/r/64290/diff/3/ > > > Testing > --- > > ``` > $ ./build-support/jenkins/build.sh > $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ``` > > > Thanks, > > John Sirois > >
Re: Review Request 64290: Update to Thrift 0.10.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/#review193326 --- - John Sirois On Dec. 8, 2017, 10:16 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64290/ > --- > > (Updated Dec. 8, 2017, 10:16 p.m.) > > > Review request for Aurora, Stephan Erb and Bill Farner. > > > Repository: aurora > > > Description > --- > > Update to Thrift 0.10.0 (https://github.com/apache/thrift/blob/master/CHANGES) > > Included changes: > > * Update to the latest pants version. This was necesary to get ./pants gen > working. > * The Java hashcode option has been removed as it is now the default. > > > Diffs > - > > .isort.cfg f53ccba7d1d45adcb4753cfd05c53bbec5c89dde > 3rdparty/python/requirements.txt 155930dc6b808fb2f573f427a4508e388ee04b5a > api/src/main/thrift/org/apache/aurora/gen/BUILD > 835b0cc6f51a592f7d5b6129dbe9519455eb6555 > api/src/main/thrift/org/apache/thermos/BUILD > b58338e76bdee3481071d8f27235a9dbb6bf07b5 > build-support/jenkins/build.sh f59fe278aea55fc3ffa1b5dff7b686cfcfae1ee7 > build-support/packer/build.sh 85444125abc0c7e600a09933411e57c0d74051ac > build-support/python/checkstyle-check > 0c8800232e20347b2be9a538ffed1d47a7815241 > build-support/python/isort 37e6cd23d2437055a15abfec6924c1bdd051de20 > build-support/python/isort-check a1bb94c99250f54f8fc261fb311cd34ce8355c78 > build-support/python/isort-run 1b39d41212d6e870c55d420a9d844fd67dd40eae > build-support/release/make-python-sdists > 51e11dbc1929609374031c9b23a96f035eba902b > build-support/thrift/.gitignore 82c5bc5cd773ecf3ec194de41a340a3ef9b83aa5 > build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch > 77c966caa3d1f644241bcc2b1968bc9306c56689 > > build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch > 42300b43a8f72e45c96b975e5d3a6a7bd0283529 > build-support/thrift/AURORA-1727.lib.py.setup.py.patch > 11c7b13341e156f3686511cb40ab13c1256203a6 > build-support/thrift/BUILD ab19f1f68682d88f731a463c15591e45a317e760 > build-support/thrift/Makefile f440b610afe321af663e393a29eebda7af7bd7a8 > build-support/thrift/prepare_binary.sh > 4ad997bf039294f7940b93a76ebf014689f8f618 > build-support/thrift/thriftw c8debd07bc9da97fb58db795e67c9ac82cc30bc1 > build.gradle 76dcc040a822db2e209646e62b71ae45bf3f4793 > buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy > fc2bc9082dae2c63aa578c05dc89feb346260a67 > pants.ini 0671d9ab6381e5b9c324dc09a891a639cbfb2ccc > src/main/python/apache/aurora/client/cli/BUILD > 80a6dec9acf5b64cff64143929916676b79be686 > src/main/python/apache/thermos/observer/BUILD > 95b8dcd7d123d3a2bcb22df7efc60374ef919bf7 > src/test/python/apache/aurora/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/admin/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/api/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/binding_helpers/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/cli/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/docker/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/common/health_check/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/executor/common/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/thermos/core/test_process.py > 6cb9176e14eccbe7ed10501199a34e5e67d6fe44 > > > Diff: https://reviews.apache.org/r/64290/diff/3/ > > > Testing > --- > > ``` > $ ./build-support/jenkins/build.sh > $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ``` > > > Thanks, > > John Sirois > >
Re: Review Request 64290: Update to Thrift 0.10.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/ --- (Updated Dec. 8, 2017, 10:16 p.m.) Review request for Aurora, Stephan Erb and Bill Farner. Summary (updated) - Update to Thrift 0.10.0 Repository: aurora Description (updated) --- Update to Thrift 0.10.0 (https://github.com/apache/thrift/blob/master/CHANGES) Included changes: * Update to the latest pants version. This was necesary to get ./pants gen working. * The Java hashcode option has been removed as it is now the default. Diffs - .isort.cfg f53ccba7d1d45adcb4753cfd05c53bbec5c89dde 3rdparty/python/requirements.txt 155930dc6b808fb2f573f427a4508e388ee04b5a api/src/main/thrift/org/apache/aurora/gen/BUILD 835b0cc6f51a592f7d5b6129dbe9519455eb6555 api/src/main/thrift/org/apache/thermos/BUILD b58338e76bdee3481071d8f27235a9dbb6bf07b5 build-support/jenkins/build.sh f59fe278aea55fc3ffa1b5dff7b686cfcfae1ee7 build-support/packer/build.sh 85444125abc0c7e600a09933411e57c0d74051ac build-support/python/checkstyle-check 0c8800232e20347b2be9a538ffed1d47a7815241 build-support/python/isort 37e6cd23d2437055a15abfec6924c1bdd051de20 build-support/python/isort-check a1bb94c99250f54f8fc261fb311cd34ce8355c78 build-support/python/isort-run 1b39d41212d6e870c55d420a9d844fd67dd40eae build-support/release/make-python-sdists 51e11dbc1929609374031c9b23a96f035eba902b build-support/thrift/.gitignore 82c5bc5cd773ecf3ec194de41a340a3ef9b83aa5 build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch 77c966caa3d1f644241bcc2b1968bc9306c56689 build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch 42300b43a8f72e45c96b975e5d3a6a7bd0283529 build-support/thrift/AURORA-1727.lib.py.setup.py.patch 11c7b13341e156f3686511cb40ab13c1256203a6 build-support/thrift/BUILD ab19f1f68682d88f731a463c15591e45a317e760 build-support/thrift/Makefile f440b610afe321af663e393a29eebda7af7bd7a8 build-support/thrift/prepare_binary.sh 4ad997bf039294f7940b93a76ebf014689f8f618 build-support/thrift/thriftw c8debd07bc9da97fb58db795e67c9ac82cc30bc1 build.gradle 76dcc040a822db2e209646e62b71ae45bf3f4793 buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy fc2bc9082dae2c63aa578c05dc89feb346260a67 pants.ini 0671d9ab6381e5b9c324dc09a891a639cbfb2ccc src/main/python/apache/aurora/client/cli/BUILD 80a6dec9acf5b64cff64143929916676b79be686 src/main/python/apache/thermos/observer/BUILD 95b8dcd7d123d3a2bcb22df7efc60374ef919bf7 src/test/python/apache/aurora/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd src/test/python/apache/aurora/admin/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd src/test/python/apache/aurora/client/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd src/test/python/apache/aurora/client/api/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd src/test/python/apache/aurora/client/binding_helpers/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd src/test/python/apache/aurora/client/cli/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd src/test/python/apache/aurora/client/docker/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd src/test/python/apache/aurora/common/health_check/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd src/test/python/apache/aurora/executor/common/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd src/test/python/apache/thermos/core/test_process.py 6cb9176e14eccbe7ed10501199a34e5e67d6fe44 Diff: https://reviews.apache.org/r/64290/diff/3/ Testing (updated) --- ``` $ ./build-support/jenkins/build.sh $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh ``` Thanks, John Sirois
Re: Review Request 64290: WIP: Update to Thrift 0.10.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/#review193323 --- @ReviewBot retry - John Sirois On Dec. 8, 2017, 8:47 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64290/ > --- > > (Updated Dec. 8, 2017, 8:47 p.m.) > > > Review request for Aurora, Stephan Erb and Bill Farner. > > > Repository: aurora > > > Description > --- > > Update to Thrift 0.10.0 (https://github.com/apache/thrift/blob/master/CHANGES) > > Included changes: > > * Update to the latest pants version. This was necesary to get ./pants gen > working. > * The Java hashcode option has been removed as it is now the default. > > .isort.cfg > | 1 + > 3rdparty/python/requirements.txt > | 2 +- > api/src/main/thrift/org/apache/aurora/gen/BUILD > | 10 +- > api/src/main/thrift/org/apache/thermos/BUILD > | 2 +- > build-support/jenkins/build.sh > | 3 +- > build-support/packer/build.sh > | 4 +- > build-support/python/checkstyle-check > | 2 +- > build-support/python/isort > | 32 - > build-support/python/isort-check > | 2 +- > build-support/python/isort-run > | 2 +- > build-support/release/make-python-sdists > | 2 +- > build-support/thrift/.gitignore > | 3 +- > build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch > | 370 -- > > build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch > | 15 -- > build-support/thrift/AURORA-1727.lib.py.setup.py.patch > | 45 -- > build-support/thrift/BUILD > | 27 > build-support/thrift/Makefile > | 63 - > build-support/thrift/prepare_binary.sh > | 72 -- > build-support/thrift/thriftw > | 80 --- > build.gradle > | 2 +- > buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy > | 2 +- > pants.ini > | 18 +-- > src/main/python/apache/aurora/client/cli/BUILD > | 4 +- > src/main/python/apache/thermos/observer/BUILD > | 8 +- > src/test/python/apache/aurora/__init__.py > | 13 -- > src/test/python/apache/aurora/admin/__init__.py > | 13 -- > src/test/python/apache/aurora/client/__init__.py > | 13 -- > src/test/python/apache/aurora/client/api/__init__.py > | 13 -- > src/test/python/apache/aurora/client/binding_helpers/__init__.py > | 13 -- > src/test/python/apache/aurora/client/cli/__init__.py > | 13 -- > src/test/python/apache/aurora/client/docker/__init__.py > | 13 -- > src/test/python/apache/aurora/common/health_check/__init__.py > | 13 -- > src/test/python/apache/aurora/executor/common/__init__.py > | 13 -- > src/test/python/apache/thermos/core/test_process.py > | 38 +++--- > 34 files changed, 110 insertions(+), 816 deletions(-) > > > Diffs > - > > .isort.cfg f53ccba7d1d45adcb4753cfd05c53bbec5c89dde > 3rdparty/python/requirements.txt 155930dc6b808fb2f573f427a4508e388e
Re: Review Request 64290: WIP: Update to Thrift 0.10.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/#review193321 --- @ReviewBot retry - John Sirois On Dec. 8, 2017, 8:47 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64290/ > --- > > (Updated Dec. 8, 2017, 8:47 p.m.) > > > Review request for Aurora, Stephan Erb and Bill Farner. > > > Repository: aurora > > > Description > --- > > Update to Thrift 0.10.0 (https://github.com/apache/thrift/blob/master/CHANGES) > > Included changes: > > * Update to the latest pants version. This was necesary to get ./pants gen > working. > * The Java hashcode option has been removed as it is now the default. > > .isort.cfg > | 1 + > 3rdparty/python/requirements.txt > | 2 +- > api/src/main/thrift/org/apache/aurora/gen/BUILD > | 10 +- > api/src/main/thrift/org/apache/thermos/BUILD > | 2 +- > build-support/jenkins/build.sh > | 3 +- > build-support/packer/build.sh > | 4 +- > build-support/python/checkstyle-check > | 2 +- > build-support/python/isort > | 32 - > build-support/python/isort-check > | 2 +- > build-support/python/isort-run > | 2 +- > build-support/release/make-python-sdists > | 2 +- > build-support/thrift/.gitignore > | 3 +- > build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch > | 370 -- > > build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch > | 15 -- > build-support/thrift/AURORA-1727.lib.py.setup.py.patch > | 45 -- > build-support/thrift/BUILD > | 27 > build-support/thrift/Makefile > | 63 - > build-support/thrift/prepare_binary.sh > | 72 -- > build-support/thrift/thriftw > | 80 --- > build.gradle > | 2 +- > buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy > | 2 +- > pants.ini > | 18 +-- > src/main/python/apache/aurora/client/cli/BUILD > | 4 +- > src/main/python/apache/thermos/observer/BUILD > | 8 +- > src/test/python/apache/aurora/__init__.py > | 13 -- > src/test/python/apache/aurora/admin/__init__.py > | 13 -- > src/test/python/apache/aurora/client/__init__.py > | 13 -- > src/test/python/apache/aurora/client/api/__init__.py > | 13 -- > src/test/python/apache/aurora/client/binding_helpers/__init__.py > | 13 -- > src/test/python/apache/aurora/client/cli/__init__.py > | 13 -- > src/test/python/apache/aurora/client/docker/__init__.py > | 13 -- > src/test/python/apache/aurora/common/health_check/__init__.py > | 13 -- > src/test/python/apache/aurora/executor/common/__init__.py > | 13 -- > src/test/python/apache/thermos/core/test_process.py > | 38 +++--- > 34 files changed, 110 insertions(+), 816 deletions(-) > > > Diffs > - > > .isort.cfg f53ccba7d1d45adcb4753cfd05c53bbec5c89dde > 3rdparty/python/requirements.txt 155930dc6b808fb2f573f427a4508e388e
Re: Review Request 64290: WIP: Update to Thrift 0.10.0
> On Dec. 8, 2017, 9:09 p.m., Aurora ReviewBot wrote:
> > Master (4f0299b) is red with this patch.
> > ./build-support/jenkins/build.sh
> >
> >SUCCESS
> >
> > 04:09:45 00:00 [main]
> >(To run a reporting server: ./pants server)
> > 04:09:45 00:00 [setup]
> > 04:09:45 00:00 [parse]
> >Executing tasks in goals: gen -> pyprep -> setup-py
> > 04:09:45 00:00 [gen]
> > 04:09:45 00:00 [thrift-py]
> > 04:09:45 00:00 [pyprep]
> > 04:09:45 00:00 [interpreter]
> > 04:09:46 00:01 [requirements]
> > 04:09:46 00:01 [cache]
> >No cached artifacts for 1 target.
> >Invalidated 1 target. Failed to install
> > pykerberos-1.1.14 (caused by: NonZeroExit("received exit code 1 during
> > execution of `[u'/usr/bin/python2.7', '-', 'bdist_wheel',
> > '--dist-dir=/tmp/tmpeewKc4']` while trying to execute
> > `[u'/usr/bin/python2.7', '-', 'bdist_wheel',
> > '--dist-dir=/tmp/tmpeewKc4']`",)
> > ):
> > stdout:
> > running bdist_wheel
> > running build
> > running build_ext
> > building 'kerberos' extension
> > creating build
> > creating build/temp.linux-x86_64-2.7
> > creating build/temp.linux-x86_64-2.7/src
> > x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall
> > -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g
> > -fstack-protector-strong -Wformat -Werror=format-security -fPIC
> > -I/usr/include/python2.7 -c src/kerberos.c -o
> > build/temp.linux-x86_64-2.7/src/kerberos.o
> >
> > stderr:
> > In file included from src/kerberos.c:19:0:
> > src/kerberosbasic.h:17:27: fatal error: gssapi/gssapi.h: No such file or
> > directory
> > compilation terminated.
> > error: command 'x86_64-linux-gnu-gcc' failed with exit status 1
> >
> >
> >
> > 04:09:48 00:03 [complete]
> >FAILURE
> > Exception caught: ()
> >
> > Exception message: Package
> > SourcePackage(u'file:///home/jenkins/jenkins-slave/workspace/AuroraBot/.pants.d/python-setup/resolved_requirements/CPython-2.7.12/pykerberos-1.1.14.tar.gz')
> > is not translateable by ChainedTranslator(WheelTranslator, EggTranslator,
> > SourceTranslator)
> >
> >
> >
> > I will refresh this build result if you post a review containing
> > "@ReviewBot retry"
This looks like a real issue with the configuration of the node this build was
scheduled on.
- John
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64290/#review193319
---
On Dec. 8, 2017, 8:47 p.m., John Sirois wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64290/
> ---
>
> (Updated Dec. 8, 2017, 8:47 p.m.)
>
>
> Review request for Aurora, Stephan Erb and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> ---
>
> Update to Thrift 0.10.0 (https://github.com/apache/thrift/blob/master/CHANGES)
>
> Included changes:
>
> * Update to the latest pants version. This was necesary to get ./pants gen
> working.
> * The Java hashcode option has been removed as it is now the default.
>
> .isort.cfg
> | 1 +
> 3rdparty/python/requirements.txt
> | 2 +-
> api/src/main/thrift/org/apache/aurora/gen/BUILD
> | 10 +-
> api/src/main/thrift/org/apache/thermos/BUILD
> | 2 +-
> build-support/jenkins/build.sh
> | 3 +-
> build-support/packer/build.sh
> | 4 +-
> build-support/python/checkstyle-check
> | 2 +-
> build-support/python/isort
> | 32 -
> build-support/python/isort-check
> | 2 +-
> build-support/python/isort-run
Re: Review Request 64290: WIP: Update to Thrift 0.10.0
51e11dbc1929609374031c9b23a96f035eba902b build-support/thrift/.gitignore 82c5bc5cd773ecf3ec194de41a340a3ef9b83aa5 build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch 77c966caa3d1f644241bcc2b1968bc9306c56689 build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch 42300b43a8f72e45c96b975e5d3a6a7bd0283529 build-support/thrift/AURORA-1727.lib.py.setup.py.patch 11c7b13341e156f3686511cb40ab13c1256203a6 build-support/thrift/BUILD ab19f1f68682d88f731a463c15591e45a317e760 build-support/thrift/Makefile f440b610afe321af663e393a29eebda7af7bd7a8 build-support/thrift/prepare_binary.sh 4ad997bf039294f7940b93a76ebf014689f8f618 build-support/thrift/thriftw c8debd07bc9da97fb58db795e67c9ac82cc30bc1 build.gradle 76dcc040a822db2e209646e62b71ae45bf3f4793 buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy fc2bc9082dae2c63aa578c05dc89feb346260a67 pants.ini 0671d9ab6381e5b9c324dc09a891a639cbfb2ccc src/main/python/apache/aurora/client/cli/BUILD 80a6dec9acf5b64cff64143929916676b79be686 src/main/python/apache/thermos/observer/BUILD 95b8dcd7d123d3a2bcb22df7efc60374ef919bf7 src/test/python/apache/aurora/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd src/test/python/apache/aurora/admin/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd src/test/python/apache/aurora/client/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd src/test/python/apache/aurora/client/api/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd src/test/python/apache/aurora/client/binding_helpers/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd src/test/python/apache/aurora/client/cli/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd src/test/python/apache/aurora/client/docker/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd src/test/python/apache/aurora/common/health_check/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd src/test/python/apache/aurora/executor/common/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd src/test/python/apache/thermos/core/test_process.py 6cb9176e14eccbe7ed10501199a34e5e67d6fe44 Diff: https://reviews.apache.org/r/64290/diff/3/ Changes: https://reviews.apache.org/r/64290/diff/2-3/ Testing --- FAILS: $ ./build-support/jenkins/build.sh NB: The broken bit is `./build-support/release/make-python-sdists`. The underlying failure looking like: ``` $ ./pants setup-py --recursive src/main/python/apache/aurora/admin 00:17:40 00:00 [main] (To run a reporting server: ./pants server) 00:17:40 00:00 [setup] 00:17:40 00:00 [parse] Executing tasks in goals: gen -> pyprep -> setup-py 00:17:40 00:00 [gen] 00:17:40 00:00 [thrift-py] 00:17:40 00:00 [pyprep] 00:17:40 00:00 [interpreter] 00:17:40 00:00 [requirements] 00:17:40 00:00 [sources] 00:17:40 00:00 [setup-py] 00:17:40 00:00 [setup-py] Creating setup.py project for PythonLibrary(BuildFileAddress(src/main/python/apache/aurora/admin/BUILD, admin)) Creating setup.py project for PythonLibrary(BuildFileAddress(api/src/main/thrift/org/apache/aurora/gen/BUILD, gen)) FAILURE: No exported target owner found for PythonLibrary(.pants.d/gen/thrift-py/252d64521cf9/api.src.main.thrift.org.apache.aurora.gen._api/current:api.src.main.thrift.org.apache.aurora.gen._api) 00:17:40 00:00 [complete] FAILURE ``` Filed this issue against pants: https://github.com/pantsbuild/pants/issues/5153 Thanks, John Sirois
Re: Review Request 64290: WIP: Update to Thrift 0.10.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/#review192929 --- I've got the needed fix out here: https://github.com/pantsbuild/pants/pull/5168 This will be available with the Pants 1.4.0.dev23 release this Friday. - John Sirois On Dec. 4, 2017, 8:23 a.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64290/ > --- > > (Updated Dec. 4, 2017, 8:23 a.m.) > > > Review request for Aurora, Stephan Erb and Bill Farner. > > > Repository: aurora > > > Description > --- > > Update to Thrift 0.10.0 (https://github.com/apache/thrift/blob/master/CHANGES) > > Included changes: > > * Update to the latest pants version. This was necesary to get ./pants gen > working. > * The Java hashcode option has been removed as it is now the default. > > .isort.cfg > | 1 + > 3rdparty/python/requirements.txt > | 2 +- > api/src/main/thrift/org/apache/aurora/gen/BUILD > | 10 +- > api/src/main/thrift/org/apache/thermos/BUILD > | 2 +- > build-support/jenkins/build.sh > | 3 +- > build-support/packer/build.sh > | 4 +- > build-support/python/checkstyle-check > | 2 +- > build-support/python/isort > | 32 - > build-support/python/isort-check > | 2 +- > build-support/python/isort-run > | 2 +- > build-support/release/make-python-sdists > | 2 +- > build-support/thrift/.gitignore > | 3 +- > build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch > | 370 -- > > build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch > | 15 -- > build-support/thrift/AURORA-1727.lib.py.setup.py.patch > | 45 -- > build-support/thrift/BUILD > | 27 > build-support/thrift/Makefile > | 63 - > build-support/thrift/prepare_binary.sh > | 72 -- > build-support/thrift/thriftw > | 80 --- > build.gradle > | 2 +- > buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy > | 2 +- > pants.ini > | 18 +-- > src/main/python/apache/aurora/client/cli/BUILD > | 4 +- > src/main/python/apache/thermos/observer/BUILD > | 8 +- > src/test/python/apache/aurora/__init__.py > | 13 -- > src/test/python/apache/aurora/admin/__init__.py > | 13 -- > src/test/python/apache/aurora/client/__init__.py > | 13 -- > src/test/python/apache/aurora/client/api/__init__.py > | 13 -- > src/test/python/apache/aurora/client/binding_helpers/__init__.py > | 13 -- > src/test/python/apache/aurora/client/cli/__init__.py > | 13 -- > src/test/python/apache/aurora/client/docker/__init__.py > | 13 -- > src/test/python/apache/aurora/common/health_check/__init__.py > | 13 -- > src/test/python/apache/aurora/executor/common/__init__.py > | 13 -- > src/test/python/apache/thermos/core/test_process.py > | 38 +++--- > 34 files changed, 110 insertions(+), 816 deletions(-) > > &
Re: Review Request 64290: WIP: Update to Thrift 0.10.0
-run 1b39d41212d6e870c55d420a9d844fd67dd40eae build-support/release/make-python-sdists 51e11dbc1929609374031c9b23a96f035eba902b build-support/thrift/.gitignore 82c5bc5cd773ecf3ec194de41a340a3ef9b83aa5 build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch 77c966caa3d1f644241bcc2b1968bc9306c56689 build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch 42300b43a8f72e45c96b975e5d3a6a7bd0283529 build-support/thrift/AURORA-1727.lib.py.setup.py.patch 11c7b13341e156f3686511cb40ab13c1256203a6 build-support/thrift/BUILD ab19f1f68682d88f731a463c15591e45a317e760 build-support/thrift/Makefile f440b610afe321af663e393a29eebda7af7bd7a8 build-support/thrift/prepare_binary.sh 4ad997bf039294f7940b93a76ebf014689f8f618 build-support/thrift/thriftw c8debd07bc9da97fb58db795e67c9ac82cc30bc1 build.gradle af119910e84c48f75f2573ababcfa287c3b986fc buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy fc2bc9082dae2c63aa578c05dc89feb346260a67 pants.ini 0671d9ab6381e5b9c324dc09a891a639cbfb2ccc src/main/python/apache/aurora/client/cli/BUILD 80a6dec9acf5b64cff64143929916676b79be686 src/main/python/apache/thermos/observer/BUILD 95b8dcd7d123d3a2bcb22df7efc60374ef919bf7 src/test/python/apache/aurora/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd src/test/python/apache/aurora/admin/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd src/test/python/apache/aurora/client/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd src/test/python/apache/aurora/client/api/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd src/test/python/apache/aurora/client/binding_helpers/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd src/test/python/apache/aurora/client/cli/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd src/test/python/apache/aurora/client/docker/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd src/test/python/apache/aurora/common/health_check/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd src/test/python/apache/aurora/executor/common/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd src/test/python/apache/thermos/core/test_process.py 6cb9176e14eccbe7ed10501199a34e5e67d6fe44 Diff: https://reviews.apache.org/r/64290/diff/2/ Changes: https://reviews.apache.org/r/64290/diff/1-2/ Testing --- FAILS: $ ./build-support/jenkins/build.sh NB: The broken bit is `./build-support/release/make-python-sdists`. The underlying failure looking like: ``` $ ./pants setup-py --recursive src/main/python/apache/aurora/admin 00:17:40 00:00 [main] (To run a reporting server: ./pants server) 00:17:40 00:00 [setup] 00:17:40 00:00 [parse] Executing tasks in goals: gen -> pyprep -> setup-py 00:17:40 00:00 [gen] 00:17:40 00:00 [thrift-py] 00:17:40 00:00 [pyprep] 00:17:40 00:00 [interpreter] 00:17:40 00:00 [requirements] 00:17:40 00:00 [sources] 00:17:40 00:00 [setup-py] 00:17:40 00:00 [setup-py] Creating setup.py project for PythonLibrary(BuildFileAddress(src/main/python/apache/aurora/admin/BUILD, admin)) Creating setup.py project for PythonLibrary(BuildFileAddress(api/src/main/thrift/org/apache/aurora/gen/BUILD, gen)) FAILURE: No exported target owner found for PythonLibrary(.pants.d/gen/thrift-py/252d64521cf9/api.src.main.thrift.org.apache.aurora.gen._api/current:api.src.main.thrift.org.apache.aurora.gen._api) 00:17:40 00:00 [complete] FAILURE ``` Filed this issue against pants: https://github.com/pantsbuild/pants/issues/5153 Thanks, John Sirois
Re: Review Request 64290: WIP: Update to Thrift 0.10.0
> On Dec. 4, 2017, 12:51 a.m., Aurora ReviewBot wrote: > > Master (89338dd) is red with this patch. > > ./build-support/jenkins/build.sh > > > > INFO] Reached consecutive success limit. > > INFO] Reached consecutive success limit. > > INFO] Reached consecutive success limit. > > INFO] Reached consecutive success limit. > > INFO] Reached consecutive success limit. > > INFO] Reached consecutive success limit. > > INFO] Reached consecutive success limit. > > INFO] Reached consecutive success limit. > > INFO] Reached consecutive success limit. > > INFO] Reached consecutive success limit. > > INFO] Reached consecutive success limit. > > INFO] Reached consecutive success limit. > > INFO] Reached consecutive success limit. > > INFO] Reached consecutive success limit. > > INFO] Reached consecutive success limit. > > INFO] Reached consecutive success limit. > > INFO] Reached consecutive success limit. > > INFO] Reached consecutive success limit. > > INFO] Reached consecutive success limit. > > INFO] Reached consecutive success limit. > > INFO] Reached consecutive success limit. > > --- Captured log call > > http_signaler.py52 DEBUGDEBUG] Using > > timeout 1.0 secs. > > health_checker.py 211 DEBUGDEBUG] Health > > checker thread started. > > health_checker.py 132 DEBUGDEBUG] Health > > checks enabled. Performing health check. > > health_checker.py 143 WARNING WARN] Health > > check failure: failure-1 > > health_checker.py 184 WARNING WARN] > > Ignoring failure of attempt: 1 > > health_checker.py 132 DEBUGDEBUG] Health > > checks enabled. Performing health check. > > health_checker.py 143 WARNING WARN] Health > > check failure: failure-2 > > health_checker.py 184 WARNING WARN] > > Ignoring failure of attempt: 2 > > health_checker.py 132 DEBUGDEBUG] Health > > checks enabled. Performing health check. > > health_checker.py 167 INFO INFO] Reached > > consecutive success limit. > > 1 failed, 794 passed, 6 skipped in 272.94 seconds > > > > FAILURE > > > > > >Waiting for background workers to finish. > > 07:51:32 05:12 [complete] > >FAILURE > > > > > > I will refresh this build result if you post a review containing > > "@ReviewBot retry" @ReviewBot retry - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/#review192672 --- On Dec. 4, 2017, 12:27 a.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64290/ > --- > > (Updated Dec. 4, 2017, 12:27 a.m.) > > > Review request for Aurora, Stephan Erb and Bill Farner. > > > Repository: aurora > > > Description > --- > > Update to Thrift 0.10.0 (https://github.com/apache/thrift/blob/master/CHANGES) > > Included changes: > > * Update to the latest pants version. This was necesary to get ./pants gen > working. > * The Java hashcode option has been removed as it is now the default. > > .isort.cfg > | 1 + > 3rdparty/python/requirements.txt > | 2 +- > api/src/main/thrift/org/apache/aurora/gen/BUILD > | 10 +- > api/src/main/thrift/org/apache/thermos/BUILD > | 2 +- > build-support/jenkins/build.sh
Re: Review Request 62590: WIP: Update to Thrift 0.10.0
> On Sept. 26, 2017, 5:53 p.m., Bill Farner wrote: > > ``` > > /bin/sh: cmake: command not found > > ``` > > > > But now i need to install cmake, so i'm not sure this pays off. > > Bill Farner wrote: > (this = the switch to cmake) > > Stephan Erb wrote: > Bison on MacOs is 10 years old. I assumed they have a good reason for it > and considered an added dependency a less risky endeavor. (Or is it just > negligence?) > > Bill Farner wrote: > What i meant to say - currently, i can build aurora on a stock macOS > machine with only a modern JDK and xcode command line utilities. Thrift > 0.10.0 seems to put us in the position of choosing between: > > a.) adding another step to our bootstrap routine to pre-build bison > b.) adding bison as a build-time dependency > c.) adding cmake as a build-time dependency > d.) other options? (i'd like to float the idea of hosting thrift binaries > like how pants does) > > Stephan Erb wrote: > Giving it some thought, you are right that just requring cmake does not > improve the situation in any way. > > I also like that we can build Aurora on a stock MacOS without much hassle > (or administrator rights). I think we should retain this property. This would > restrict us to options a) and d). > > Bill Farner wrote: > I would support (d). We can place unofficial binaries in svn for dev > platforms as needed, and could support using thrift from the `PATH` as a > fallback. This has the bonus of making from-scratch builds much faster. > > Stephan Erb wrote: > I saw your patch to https://github.com/morimekta/providence. Did you > manage to get something working with it? > > Bill Farner wrote: > I'm about 20% along. A very large mechanical patch is needed for Aurora. > The only untested piece is binary format compatibility (which providence > aims to achieve). There is some incompatibility i need to investigate > further (trivial details like a round-tripped `null` collection turning into > an empty collection), but so far it looks good! I'm proceeding with high > confidence, as there is also the future promise of a more approachable > HTTP/JSON interface via thrift IDL when using providence. > > Bill Farner wrote: > I should have clarified - i don't think we should hold back on upgrading > thrift. It's not yet guaranteed that the migration to providence will be > successful or timely. > > As for my proposed (d) above, we could store prebuilt binaries similarly > to how we store mesos eggs: https://svn.apache.org/repos/asf/aurora/3rdparty/ > > Stephan Erb wrote: > I have just pushed another patch that I have been sitting one for a few > days. It suffers from the same pants issues as > https://reviews.apache.org/r/63750/ The still incomplete solution: https://reviews.apache.org/r/64290/ - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62590/#review186342 --- On Dec. 3, 2017, 1:09 p.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62590/ > --- > > (Updated Dec. 3, 2017, 1:09 p.m.) > > > Review request for Aurora and Bill Farner. > > > Repository: aurora > > > Description > --- > > Update to Thrift 0.10.0 (https://github.com/apache/thrift/blob/master/CHANGES) > > Included changes: > > * Update to the latest pants version. This was necesary to make `./pants gen` > working. Unfortunately this breaks a few things. For details see > https://reviews.apache.org/r/63750/ > * The Java `hashcode` option has been removed as it is now the default. > > > Diffs > - > > 3rdparty/python/requirements.txt 155930dc6b808fb2f573f427a4508e388ee04b5a > build-support/packer/build.sh 85444125abc0c7e600a09933411e57c0d74051ac > build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch > 77c966caa3d1f644241bcc2b1968bc9306c56689 > > build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch > 42300b43a8f72e45c96b975e5d3a6a7bd0283529 > build-support/thrift/AURORA-1727.lib.py.setup.py.patch > 11c7b13341e156f3686511cb40ab13c1256203a6 > build-support/thrift/BUILD ab19f1f68682d88f731a463c15591e45a317e760 > build-support/thrift/Makefile f440b610afe321af663e393a29eebda7af7bd7a8 > build-support/thrift/prepare_binary.sh > 4ad997bf039294f7940b93a76ebf014689f8f618 > build-support/thrift/thriftw c8debd07bc9da97fb58db795e67c9ac82cc30bc1 > build.gradle af119910e84c48f75f2573ababcfa287c3b986fc > buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy > fc2bc9082dae2c63aa578c05dc89feb346260a67 > pants.ini 0671d9ab6381e5b9c324dc09a891a639cbfb2ccc > src/mai
Re: Review Request 63750: pants for high-sierra
B
80% 6910 KB
82% . 7080 KB
84% .. 7250 KB
86% ...7430 KB
88% 7600 KB
90% . 7770 KB
92% .. 7940 KB
94% ...8120 KB
96% 8290 KB
98% . 8460 KB
100% .. 8628 KB 0.032s
> > INFO] Fetched thrift binary from:
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift/serve/bin/thrift/linux/x86_64/0.9.1/thrift
> > .
> >
> > 00:13:36 00:01 [pyprep]
> > 00:13:36 00:01 [interpreter]
> > 00:13:40 00:05 [requirements]
> > 00:13:40 00:05 [cache]
> >No cached artifacts for 35 targets.
> >Invalidated 35 targets.
> >Waiting for background workers to finish.
> > 00:13:41 00:06 [complete]
> >FAILURE
> > Exception caught: ()
> >
> > Exception message: Could not satisfy all requirements for
> > mesos.executor==1.4.0:
> > mesos.executor==1.4.0
> >
> >
> >
> > I will refresh this build result if you post a review containing
> > "@ReviewBot retry"
>
> Bill Farner wrote:
> I'm not certain if pex resolution is also affected, but you may want to
> see this issue: https://issues.apache.org/jira/browse/MESOS-8224
>
> Stephan Erb wrote:
> I have been looking into this a bit, but still haven't figured it out.
>
> It seems like pants changed when it tries to resolve dependencies. The
> `mesos.executor` only used to be pulled in when building the executor binary.
> In newer version, pants will check for the existance of the dependency even
> if it is not needed at all, i.e. during test executions. The dependency is
> only available when explicitly downloaded beforehand, so the build fails on
> Jenkins.
>
> John Sirois wrote:
> I've got a fix ... I'll post a diff here later tonight, but wrt
> https://reviews.apache.org/r/62590
> Basically, the current build.sh test command is at fault, executing
> against `src/{main,test}/python::` (which explicitly depends on the
> problematic thermos binary that in turn depends on `mesos.executor`) instead
> of `src/test/python::`.
>
> Bill Farner wrote:
> > `src/{main,test}/python::`
>
> Aha! This makes some sense. Thanks for following along, John!
The still incomplete solution: https://reviews.apache.org/r/64290/
- John
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63750/#review191018
---
On Nov. 14, 2017, 4:51 p.m., se choi wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63750/
> ---
>
> (Updated Nov. 14, 2017, 4:51 p.m.)
>
>
> Review request for Aurora, John Sirois and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> ---
>
> pants for high-sierra
>
>
> Diffs
> -
>
> build-support/thrift/prepare_binary.sh
> 4ad997bf039294f7940b93a76ebf014689f8f618
> pants.ini 0671d9ab6381e5b9c324dc09a891a639cbfb2ccc
>
>
> Diff: https://reviews.apache.org/r/63750/diff/2/
>
>
> Testing
> ---
>
> Review homebrew-core
>
> https://github.com/Homebrew/homebrew-core/pull/20581
>
>
> Thanks,
>
> se choi
>
>
Review Request 64290: WIP: Update to Thrift 0.10.0
77c966caa3d1f644241bcc2b1968bc9306c56689 build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch 42300b43a8f72e45c96b975e5d3a6a7bd0283529 build-support/thrift/AURORA-1727.lib.py.setup.py.patch 11c7b13341e156f3686511cb40ab13c1256203a6 build-support/thrift/BUILD ab19f1f68682d88f731a463c15591e45a317e760 build-support/thrift/Makefile f440b610afe321af663e393a29eebda7af7bd7a8 build-support/thrift/prepare_binary.sh 4ad997bf039294f7940b93a76ebf014689f8f618 build-support/thrift/thriftw c8debd07bc9da97fb58db795e67c9ac82cc30bc1 build.gradle af119910e84c48f75f2573ababcfa287c3b986fc buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy fc2bc9082dae2c63aa578c05dc89feb346260a67 pants.ini 0671d9ab6381e5b9c324dc09a891a639cbfb2ccc src/main/python/apache/aurora/client/cli/BUILD 80a6dec9acf5b64cff64143929916676b79be686 src/main/python/apache/thermos/observer/BUILD 95b8dcd7d123d3a2bcb22df7efc60374ef919bf7 src/test/python/apache/aurora/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd src/test/python/apache/aurora/admin/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd src/test/python/apache/aurora/client/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd src/test/python/apache/aurora/client/api/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd src/test/python/apache/aurora/client/binding_helpers/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd src/test/python/apache/aurora/client/cli/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd src/test/python/apache/aurora/client/docker/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd src/test/python/apache/aurora/common/health_check/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd src/test/python/apache/aurora/executor/common/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd src/test/python/apache/thermos/core/test_process.py 6cb9176e14eccbe7ed10501199a34e5e67d6fe44 Diff: https://reviews.apache.org/r/64290/diff/1/ Testing --- FAILS: $ ./build-support/jenkins/build.sh NB: The broken bit is `./build-support/release/make-python-sdists`. The underlying failure looking like: ``` $ ./pants setup-py --recursive src/main/python/apache/aurora/admin 00:17:40 00:00 [main] (To run a reporting server: ./pants server) 00:17:40 00:00 [setup] 00:17:40 00:00 [parse] Executing tasks in goals: gen -> pyprep -> setup-py 00:17:40 00:00 [gen] 00:17:40 00:00 [thrift-py] 00:17:40 00:00 [pyprep] 00:17:40 00:00 [interpreter] 00:17:40 00:00 [requirements] 00:17:40 00:00 [sources] 00:17:40 00:00 [setup-py] 00:17:40 00:00 [setup-py] Creating setup.py project for PythonLibrary(BuildFileAddress(src/main/python/apache/aurora/admin/BUILD, admin)) Creating setup.py project for PythonLibrary(BuildFileAddress(api/src/main/thrift/org/apache/aurora/gen/BUILD, gen)) FAILURE: No exported target owner found for PythonLibrary(.pants.d/gen/thrift-py/252d64521cf9/api.src.main.thrift.org.apache.aurora.gen._api/current:api.src.main.thrift.org.apache.aurora.gen._api) 00:17:40 00:00 [complete] FAILURE ``` Filed this issue against pants: https://github.com/pantsbuild/pants/issues/5153 Thanks, John Sirois
Re: Review Request 63750: pants for high-sierra
B
80% 6910 KB
82% . 7080 KB
84% .. 7250 KB
86% ...7430 KB
88% 7600 KB
90% . 7770 KB
92% .. 7940 KB
94% ...8120 KB
96% 8290 KB
98% . 8460 KB
100% .. 8628 KB 0.032s
> > INFO] Fetched thrift binary from:
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift/serve/bin/thrift/linux/x86_64/0.9.1/thrift
> > .
> >
> > 00:13:36 00:01 [pyprep]
> > 00:13:36 00:01 [interpreter]
> > 00:13:40 00:05 [requirements]
> > 00:13:40 00:05 [cache]
> >No cached artifacts for 35 targets.
> >Invalidated 35 targets.
> >Waiting for background workers to finish.
> > 00:13:41 00:06 [complete]
> >FAILURE
> > Exception caught: ()
> >
> > Exception message: Could not satisfy all requirements for
> > mesos.executor==1.4.0:
> > mesos.executor==1.4.0
> >
> >
> >
> > I will refresh this build result if you post a review containing
> > "@ReviewBot retry"
>
> Bill Farner wrote:
> I'm not certain if pex resolution is also affected, but you may want to
> see this issue: https://issues.apache.org/jira/browse/MESOS-8224
>
> Stephan Erb wrote:
> I have been looking into this a bit, but still haven't figured it out.
>
> It seems like pants changed when it tries to resolve dependencies. The
> `mesos.executor` only used to be pulled in when building the executor binary.
> In newer version, pants will check for the existance of the dependency even
> if it is not needed at all, i.e. during test executions. The dependency is
> only available when explicitly downloaded beforehand, so the build fails on
> Jenkins.
I've got a fix ... I'll post a diff here later tonight, but wrt
https://reviews.apache.org/r/62590
Basically, the current build.sh test command is at fault, executing against
`src/{main,test}/python::` (which explicitly depends on the problematic thermos
binary that in turn depends on `mesos.executor`) instead of `src/test/python::`.
- John
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63750/#review191018
---
On Nov. 14, 2017, 4:51 p.m., se choi wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63750/
> ---
>
> (Updated Nov. 14, 2017, 4:51 p.m.)
>
>
> Review request for Aurora, John Sirois and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> ---
>
> pants for high-sierra
>
>
> Diffs
> -
>
> build-support/thrift/prepare_binary.sh
> 4ad997bf039294f7940b93a76ebf014689f8f618
> pants.ini 0671d9ab6381e5b9c324dc09a891a639cbfb2ccc
>
>
> Diff: https://reviews.apache.org/r/63750/diff/2/
>
>
> Testing
> ---
>
> Review homebrew-core
>
> https://github.com/Homebrew/homebrew-core/pull/20581
>
>
> Thanks,
>
> se choi
>
>
Re: Review Request 62835: Use compatible Curator session and connection timeouts
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62835/#review187965 --- Ship it! Ship It! - John Sirois On Oct. 13, 2017, 8:36 a.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62835/ > --- > > (Updated Oct. 13, 2017, 8:36 a.m.) > > > Review request for Aurora, David McLaughlin, John Sirois, Renan DelValle, and > Bill Farner. > > > Repository: aurora > > > Description > --- > > Curator will warn if used with a connection timeout that is lower than > the session timeout [1]. As it uses a default connection timeout of 15s > [2], this warning will be emitted using the Aurora default settings. > > This patch remedies this issue in two ways: > > * Making the Curator connection timeout configurable > * Bumping the session timeout to 15s. The current default of 4s is > pretty small and could lead to unexpected failovers during long GC > pauses. This is especially problematic as a failover in Aurora can > be lengthy. > > [1] > https://github.com/apache/curator/blob/15eb063fa22569e797f850fb8d60a0949f52fbf5/curator-client/src/main/java/org/apache/curator/CuratorZookeeperClient.java#L118-L121 > [2] > https://github.com/apache/curator/blob/6ba4de36d4e8b2b65d45c005a6a92dd85c3c497f/curator-framework/src/main/java/org/apache/curator/framework/CuratorFrameworkFactory.java#L60-L61 > > > Diffs > - > > RELEASE-NOTES.md c58e68080beb1740d92639601ef7cc29c63be37e > > commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperUtils.java > 2ada2646da7bdc3276803336cc638e23b9e61d26 > > src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceDiscoveryModule.java > ea167a89a95f0f35d53a34631ae44e0a911a6817 > > src/main/java/org/apache/aurora/scheduler/discovery/FlaggedZooKeeperConfig.java > c2e8ce24bbb029a1c52cbdabce19a98029bc33f2 > src/main/java/org/apache/aurora/scheduler/discovery/ZooKeeperConfig.java > f6faca56cbfceeb9e1226c0e8feec13c7c772d94 > src/test/java/org/apache/aurora/scheduler/config/CommandLineTest.java > 9b4f2ad15ab5b61d4cccfad38ba48f17e7853425 > > src/test/java/org/apache/aurora/scheduler/discovery/AbstractDiscoveryModuleTest.java > 0f2121ef1453b41286f9713d5ce89a26d1cb1b4f > > src/test/java/org/apache/aurora/scheduler/discovery/ZooKeeperConfigTest.java > a065505134c1ad30ba9f4d4cd829355b2acc9a13 > > > Diff: https://reviews.apache.org/r/62835/diff/2/ > > > Testing > --- > > ./gradlew -Pq build > > > Thanks, > > Stephan Erb > >
Re: Review Request 62835: Use compatible Curator session and connection timeouts
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62835/#review187383 --- Ship it! commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperUtils.java Line 42 (original), 42 (patched) <https://reviews.apache.org/r/62835/#comment264349> Is this worth an entry in `New/updated` in `RELEASE-NOTES.md`? Agreed though it seems unlikely an operator inspected the old default, liked it and wanted it, but then did not seal it in by using a flag. Not to mention the new default is probably what they really want. - John Sirois On Oct. 8, 2017, 12:20 p.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62835/ > --- > > (Updated Oct. 8, 2017, 12:20 p.m.) > > > Review request for Aurora, David McLaughlin, John Sirois, Renan DelValle, and > Bill Farner. > > > Repository: aurora > > > Description > --- > > Curator will warn if used with a connection timeout that is lower than > the session timeout [1]. As it uses a default connection timeout of 15s > [2], this warning will be emitted using the Aurora default settings. > > This patch remedies this issue in two ways: > > * Making the Curator connection timeout configurable > * Bumping the session timeout to 15s. The current default of 4s is > pretty small and could lead to unexpected failovers during long GC > pauses. This is especially problematic as a failover in Aurora can > be lengthy. > > [1] > https://github.com/apache/curator/blob/15eb063fa22569e797f850fb8d60a0949f52fbf5/curator-client/src/main/java/org/apache/curator/CuratorZookeeperClient.java#L118-L121 > [2] > https://github.com/apache/curator/blob/6ba4de36d4e8b2b65d45c005a6a92dd85c3c497f/curator-framework/src/main/java/org/apache/curator/framework/CuratorFrameworkFactory.java#L60-L61 > > > Diffs > - > > > commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperUtils.java > 2ada2646da7bdc3276803336cc638e23b9e61d26 > > src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceDiscoveryModule.java > ea167a89a95f0f35d53a34631ae44e0a911a6817 > > src/main/java/org/apache/aurora/scheduler/discovery/FlaggedZooKeeperConfig.java > e8aafe4a47e3f0e6312c8b93dbc32e1c25445dd3 > src/main/java/org/apache/aurora/scheduler/discovery/ZooKeeperConfig.java > 4014a91299d863337c5f58a0495775c5f4aa6c09 > > src/test/java/org/apache/aurora/scheduler/discovery/AbstractDiscoveryModuleTest.java > 0f2121ef1453b41286f9713d5ce89a26d1cb1b4f > > src/test/java/org/apache/aurora/scheduler/discovery/ZooKeeperConfigTest.java > a065505134c1ad30ba9f4d4cd829355b2acc9a13 > > > Diff: https://reviews.apache.org/r/62835/diff/1/ > > > Testing > --- > > ./gradlew -Pq build > > > Thanks, > > Stephan Erb > >
Re: Review Request 62652: Remove legacy commons ZK code
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62652/#review187381 --- Ship it! Ship It! - John Sirois On Oct. 8, 2017, 11:29 a.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62652/ > --- > > (Updated Oct. 8, 2017, 11:29 a.m.) > > > Review request for Aurora, David McLaughlin and John Sirois. > > > Repository: aurora > > > Description > --- > > This is the result removing the deprecated `-zk_use_curator` arg in > `FlaggedZooKeeperConfig.java`, and following the trail of unused code. > Thanks for the clean separation, John! > > > Diffs > - > > RELEASE-NOTES.md c58e68080beb1740d92639601ef7cc29c63be37e > commons/src/main/java/org/apache/aurora/common/net/pool/DynamicHostSet.java > df469efac2d994517d9b931cb2c1582e09d0cab7 > commons/src/main/java/org/apache/aurora/common/zookeeper/Candidate.java > 75c1b1493eb178ea035a0e60f20df694626c7f50 > commons/src/main/java/org/apache/aurora/common/zookeeper/CandidateImpl.java > 98b5ee4690482683526f2e8ce4c965ed052b0232 > commons/src/main/java/org/apache/aurora/common/zookeeper/Group.java > 2720dd13a3cc5e39f7242664fbe98f00fb75eb08 > commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSet.java > aeea02d81faa3c8841edb9002498515dd0b52242 > commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSetImpl.java > ace4980d3e15dc830fea48b83f0688347c71d900 > commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSets.java > 01a54a5718388df7f02992388653d7b049422787 > > commons/src/main/java/org/apache/aurora/common/zookeeper/SingletonServiceImpl.java > d9978a926e05e4303a168c7c51ee226a7dc94336 > > commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperClient.java > ce243fb44266b741ff3f14eb5438ff38cf46133f > > commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperUtils.java > 2ada2646da7bdc3276803336cc638e23b9e61d26 > > commons/src/main/java/org/apache/aurora/common/zookeeper/testing/BaseZooKeeperClientTest.java > ba09279be9d8bfde79b7610a184bb472ab0396b5 > > commons/src/main/java/org/apache/aurora/common/zookeeper/testing/ZooKeeperTestServer.java > 29204cda66343c5b3c80d167eccd36abfb6ee641 > > commons/src/test/java/org/apache/aurora/common/zookeeper/CandidateImplTest.java > 9c0cebe888d966fd64d17778c354136df0e13c7e > commons/src/test/java/org/apache/aurora/common/zookeeper/GroupTest.java > 97a42d1bd6c60598d7936a2c065e163c1505ef3d > commons/src/test/java/org/apache/aurora/common/zookeeper/JsonCodecTest.java > 2166123e9acd701e55e10b450a9eb89054c7afdd > > commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetImplTest.java > f0c0cb4491c7b5c34103864ee244a27db3972a94 > > commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetsTest.java > 0e6719154ee5195111db51d323fa35c3bc56ec2b > > commons/src/test/java/org/apache/aurora/common/zookeeper/SingletonServiceImplTest.java > 5f6cdd83ca6c6338f8c7a0a3c93b960c036cb05e > > commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperClientTest.java > 5eee235162e938ecdfdb7d3c4d31d848a34a648b > > commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperUtilsTest.java > 9e482a6162abe5f9864d0ca0094cd97dc8036496 > > src/main/java/org/apache/aurora/scheduler/discovery/CommonsServiceDiscoveryModule.java > 339f63b94e996e13514e6a6dcd7bbeef3a0f09f8 > > src/main/java/org/apache/aurora/scheduler/discovery/CommonsServiceGroupMonitor.java > 9161455c3101fb0d83633883a67ce0ffe22fcdf8 > > src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceDiscoveryModule.java > ea167a89a95f0f35d53a34631ae44e0a911a6817 > > src/main/java/org/apache/aurora/scheduler/discovery/FlaggedZooKeeperConfig.java > e8aafe4a47e3f0e6312c8b93dbc32e1c25445dd3 > > src/main/java/org/apache/aurora/scheduler/discovery/ServiceDiscoveryModule.java > 917a5679699581fb345d51d2837f372411d4beda > src/main/java/org/apache/aurora/scheduler/discovery/ZooKeeperConfig.java > 4014a91299d863337c5f58a0495775c5f4aa6c09 > src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java > a7c9c83eebbbea7ae8a6c807f98d3ce8bd050137 > > src/test/java/org/apache/aurora/scheduler/discovery/AbstractDiscoveryModuleTest.java > 0f2121ef1453b41286f9713d5ce89a26d1cb1b4f > > src/test/java/org/apache/aurora/scheduler/discovery
Re: Review Request 62623: Use a simpler command line argument system
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62623/#review186790 --- Ship it! I won't have time to give this a good look until Monday 10/2, but I'm happy with a quick skim! - John Sirois On Sept. 29, 2017, 8:07 p.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62623/ > --- > > (Updated Sept. 29, 2017, 8:07 p.m.) > > > Review request for Aurora, David McLaughlin and John Sirois. > > > Repository: aurora > > > Description > --- > > **NOTE: this patch is not ready to commit, but is ready for initial > discussion on the direction** > > This is a very big patch, lots of code removed. I suggest starting with > `CliOptions.java` on page 5, then looking at a few module classes to see the > call site changes. > > I made a similar effort a while back, but was unable to finish due to time > constraints. I'm now proposing a more drastic simplification in command line > argument handling in the scheduler. Less magic, more approachable, less > brittle with other tools (gradle, IDEs). The original approach made lots of > sense in the original environment where Aurora was developed (a monorepo in a > large organization), but this is no longer the case. > > Historical context: > https://mail-archives.apache.org/mod_mbox/aurora-dev/201601.mbox/%3CCAFWq12VJPOxDViDP5OsmXU3skHR6rrp5Zp%2BXgi8HgeHic6pTJw%40mail.gmail.com%3E > > > Diffs > - > > build.gradle f9579a38de95ff9e11cf2e44980d01e103226389 > commons-args/src/main/java/org/apache/aurora/common/args/Arg.java > 4da91591d325ab657dcd37325e5142c65db2ab8c > commons-args/src/main/java/org/apache/aurora/common/args/ArgParser.java > 25ed25093bd9defd78df741b6f51e0de0d1f1709 > commons-args/src/main/java/org/apache/aurora/common/args/CmdLine.java > a72ea7a1669a53d282f9a5a3709add506c9d4b33 > commons-args/src/main/java/org/apache/aurora/common/args/NoParser.java > 3366531cebe6a79d9c568322f9117d7dbc3e824d > commons-args/src/main/java/org/apache/aurora/common/args/Parser.java > 93c23234df38c9f917c0f582b51c25070f996c94 > commons-args/src/main/java/org/apache/aurora/common/args/ParserOracle.java > e84d3029a45cf7ea1f0bb885788c677ed649b60e > commons-args/src/main/java/org/apache/aurora/common/args/Verifier.java > 8f09a9803b8a05b2ab11326d48f26cccaaa278d1 > commons-args/src/main/java/org/apache/aurora/common/args/VerifierFor.java > aad8807938f569d0dc7a970166ee71ea36f3537d > > commons-args/src/main/java/org/apache/aurora/common/args/apt/CmdLineProcessor.java > 5fda5dc6cd8b6d97511073830278850d58bb0bc7 > > commons-args/src/main/java/org/apache/aurora/common/args/apt/Configuration.java > 1832d41feeafb07f4e7f0bef9dbcb6097e288508 > > commons-args/src/main/resources/META-INF/services/javax.annotation.processing.Processor > b548fcdc4389af4420e57908a313435b5300445f > commons/src/main/java/org/apache/aurora/common/args/ArgFilters.java > 9fd6eaec98516c3ca9b9a8647af848fcc96509bd > commons/src/main/java/org/apache/aurora/common/args/ArgScanner.java > 6e7f23d79deff4983b7feb568320cb938583270b > commons/src/main/java/org/apache/aurora/common/args/Args.java > 202835debce817df82bd3d860330d23d9710f489 > commons/src/main/java/org/apache/aurora/common/args/ArgumentInfo.java > a59d1091b36d0b7908143335cf49d0dafb6627a1 > commons/src/main/java/org/apache/aurora/common/args/OptionInfo.java > 2fcd3e8f068c4ef950aabe52ca8050dcbd562500 > commons/src/main/java/org/apache/aurora/common/args/Parsers.java > c4e5fafc49028bd15cfe1bd2a874e73792091cb6 > commons/src/main/java/org/apache/aurora/common/args/TypeUtil.java > 80cbdd00ce2abb298232793c5fd20c83c6ba6de4 > commons/src/main/java/org/apache/aurora/common/args/Verifiers.java > 0212873258867ccdb17244e7b0678a7346e79b73 > > commons/src/main/java/org/apache/aurora/common/args/constraints/CanExecute.java > a26b8a2049a16e96fd97ad2163556de41ba5686e > > commons/src/main/java/org/apache/aurora/common/args/constraints/CanExecuteFileVerifier.java > 5d9b36070af7c717af5edcc0eec6774c2e26c102 > > commons/src/main/java/org/apache/aurora/common/args/constraints/CanRead.java > 3fef6a98e4c926126ac93061dd3b32c39f131e3c > > commons/src/main/java/org/apache/aurora/common/args/constraints/CanReadFileVerifier.java > 8c26304733264b6670e56ab032d7b039f4dfdbfe > > commons/src/main/java/org/apache/aurora/comm
Re: Review Request 62716: Replace auto-generated forwarding code with manual implementations
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62716/#review186789 --- Ship it! Ship It! - John Sirois On Sept. 30, 2017, 11:01 a.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62716/ > --- > > (Updated Sept. 30, 2017, 11:01 a.m.) > > > Review request for Aurora, Jordan Ly and John Sirois. > > > Repository: aurora > > > Description > --- > > Somewhat in the same vein as [62623](https://reviews.apache.org/r/62623/), i > propose we give in to the brittleness of IDEs and build tools in the face of > annotation processors. I can confidently say i've burned far more time > invalidating caches in intellij and gradle to work around this than i would > have spent manually maintaining the generated code. > > This patch cargo cults the code that was being generated for us. > > > Diffs > - > > build.gradle f9579a38de95ff9e11cf2e44980d01e103226389 > > src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java > 325d3a14ce26e8c6d70c5440761f18bc93b7b5cd > > src/test/java/org/apache/aurora/scheduler/thrift/aop/MockDecoratedThrift.java > 0547b1acf0c1fc09898fe05777f45cbaa169eea7 > > > Diff: https://reviews.apache.org/r/62716/diff/1/ > > > Testing > --- > > > Thanks, > > Bill Farner > >
Re: Review Request 62608: Workaround to get pants working in macOS high sierra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62608/#review186371 --- Ship it! Ship It! - John Sirois On Sept. 26, 2017, 7:51 p.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62608/ > --- > > (Updated Sept. 26, 2017, 7:51 p.m.) > > > Review request for Aurora and John Sirois. > > > Repository: aurora > > > Description > --- > > This is a cheat to use pants' thrift binary from 10.12. > > > Diffs > - > > pants.ini f25e1d1a50f457325dbbabf327c31d760cb90339 > > > Diff: https://reviews.apache.org/r/62608/diff/1/ > > > Testing > --- > > > Thanks, > > Bill Farner > >
Re: Review Request 58612: Improve cleanup hints in release and release-candidate scripts
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58612/#review172665 --- Ship it! Ship It! - John Sirois On April 21, 2017, 5:24 a.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58612/ > --- > > (Updated April 21, 2017, 5:24 a.m.) > > > Review request for Aurora, Joshua Cohen and John Sirois. > > > Repository: aurora > > > Description > --- > > I was running into some of those issues in during the last release, > but only managed to file them now. > > > Diffs > - > > build-support/release/release 05a2e023ae1b32779248fe759518925684381c36 > build-support/release/release-candidate > 80b14eac8223a0d52d086eb1c80a8f83ad94e152 > > > Diff: https://reviews.apache.org/r/58612/diff/1/ > > > Testing > --- > > I did *not* run the release script using the proposed changes > as it requires an un-released release candidate. > > There could therefor be a small chance that I broke something. > I beleive it is good enough to correct those during the next > release. > > > Thanks, > > Stephan Erb > >
Re: Review Request 56577: Add basic test scripts for RPM and DEB packages
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56577/#review166045 --- Ship it! A tardy LGTM and thanks. - John Sirois On Feb. 14, 2017, 3:33 p.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56577/ > --- > > (Updated Feb. 14, 2017, 3:33 p.m.) > > > Review request for Aurora, John Sirois and Renan DelValle. > > > Repository: aurora-packaging > > > Description > --- > > Add basic test scripts for RPM and DEB packages > > This reduces some of the manual effort for verifying the binary packages. > > > Diffs > - > > .gitignore 2d30051c482a2416026421808876fe456337290f > build-artifact.sh e4efe5f1ac36c9e19082ef9e8be10507b901076f > test/deb/debian-jessie/README.md 2e9bcb70cb0052c48ad325d9cd29b4a1c0a7eaf6 > test/deb/debian-jessie/Vagrantfile f79c3379c113190784c40211318a8f19bc8e3fa4 > test/deb/debian-jessie/install-aurora.sh PRE-CREATION > test/deb/debian-jessie/provision.sh > 175f1ba81c2b1104b13d5c7ea6c463544c85a11c > test/deb/ubuntu-trusty/README.md 116ae8eb95afbafb5f350be5f41fd2f9efc7d9a8 > test/deb/ubuntu-trusty/Vagrantfile ed5ec8e6b42d2960df9823bfafa13bf182ea2040 > test/deb/ubuntu-trusty/install-aurora.sh PRE-CREATION > test/deb/ubuntu-trusty/provision.sh > 123590e63a1440b787836eee937634bd63648517 > test/deb/ubuntu-xenial/README.md a5284ecaf6803209037a2915b24469a7e154dc8c > test/deb/ubuntu-xenial/Vagrantfile 3ce6209ba616a4d156c5c4c6f24d8f148a0f7522 > test/deb/ubuntu-xenial/install-aurora.sh PRE-CREATION > test/deb/ubuntu-xenial/provision.sh > eda79f69395769e02771e290135b0fef05215b91 > test/rpm/centos-7/README.md 7fcd5a0da87cd62b72a84cc70be96ab93a1cd3c5 > test/rpm/centos-7/Vagrantfile 5059b8410dd271dbae6cd23f5909fd41fb88244a > test/rpm/centos-7/install-aurora.sh PRE-CREATION > test/test-artifact.sh PRE-CREATION > test/test-aurora.sh PRE-CREATION > > Diff: https://reviews.apache.org/r/56577/diff/ > > > Testing > --- > > See the distribution specific README.md. > > > Thanks, > > Stephan Erb > >
Re: Review Request 54288: Make leader elections resilient to ZK disconnections.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54288/#review162710 --- Spoke with Zameer offline and he'll actually land this once he reviews the last change. - John Sirois On Jan. 23, 2017, 1:21 p.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54288/ > --- > > (Updated Jan. 23, 2017, 1:21 p.m.) > > > Review request for Aurora, David McLaughlin, Joshua Cohen, John Sirois, and > Stephan Erb. > > > Bugs: AURORA-1669 > https://issues.apache.org/jira/browse/AURORA-1669 > > > Repository: aurora > > > Description > --- > > As documented in AURORA-1840 the Curator `LeaderLatch` recipe abdicates > leadership if the ZK connection is lost or if there is a timeout. This is not > compatible with the commons based implementation which would only abdicate > leadership if the ZK session timeout occurred. > > This replaces the `LeaderLatch` recipe with the `LeaderSelector` recipe with a > custom listener that only loses leadership if a connection loss occurs. > > > Diffs > - > > > commons/src/main/java/org/apache/aurora/common/zookeeper/testing/ZooKeeperTestServer.java > 50acaeba82e163f8f2970a264cbd889c9eb3b5ed > > src/main/java/org/apache/aurora/scheduler/discovery/CuratorSingletonService.java > c378172c850aafe0a9381552b5067277b40dbfab > > src/test/java/org/apache/aurora/scheduler/discovery/BaseCuratorDiscoveryTest.java > a2b4125369d1f6c0a79bc4ac0fb3d2dab8a6c583 > > src/test/java/org/apache/aurora/scheduler/discovery/CuratorSingletonServiceTest.java > 6ea49b0c690d288ff59d1d4798144bfa2d153d3a > > Diff: https://reviews.apache.org/r/54288/diff/ > > > Testing > --- > > > Thanks, > > Zameer Manji > >
Re: Review Request 54288: Make leader elections resilient to ZK disconnections.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54288/#review162703 --- @ReviewBot retry - John Sirois On Jan. 23, 2017, 1:21 p.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54288/ > --- > > (Updated Jan. 23, 2017, 1:21 p.m.) > > > Review request for Aurora, David McLaughlin, Joshua Cohen, John Sirois, and > Stephan Erb. > > > Bugs: AURORA-1669 > https://issues.apache.org/jira/browse/AURORA-1669 > > > Repository: aurora > > > Description > --- > > As documented in AURORA-1840 the Curator `LeaderLatch` recipe abdicates > leadership if the ZK connection is lost or if there is a timeout. This is not > compatible with the commons based implementation which would only abdicate > leadership if the ZK session timeout occurred. > > This replaces the `LeaderLatch` recipe with the `LeaderSelector` recipe with a > custom listener that only loses leadership if a connection loss occurs. > > > Diffs > - > > > commons/src/main/java/org/apache/aurora/common/zookeeper/testing/ZooKeeperTestServer.java > 50acaeba82e163f8f2970a264cbd889c9eb3b5ed > > src/main/java/org/apache/aurora/scheduler/discovery/CuratorSingletonService.java > c378172c850aafe0a9381552b5067277b40dbfab > > src/test/java/org/apache/aurora/scheduler/discovery/BaseCuratorDiscoveryTest.java > a2b4125369d1f6c0a79bc4ac0fb3d2dab8a6c583 > > src/test/java/org/apache/aurora/scheduler/discovery/CuratorSingletonServiceTest.java > 6ea49b0c690d288ff59d1d4798144bfa2d153d3a > > Diff: https://reviews.apache.org/r/54288/diff/ > > > Testing > --- > > > Thanks, > > Zameer Manji > >
Re: Review Request 54288: Make leader elections resilient to ZK disconnections.
> On Jan. 23, 2017, 2:16 p.m., Aurora ReviewBot wrote: > > Master (75129b6) is red with this patch. > > ./build-support/jenkins/build.sh > > > > Test coverage missing for org/apache/aurora/scheduler/events/Webhook > > Test coverage missing for org/apache/aurora/scheduler/events/WebhookInfo > > Test coverage missing for > > org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl > > Test coverage missing for > > org/apache/aurora/scheduler/storage/log/EntrySerializer$EntrySerializerImpl$1 > > Test coverage missing for > > org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$8 > > Test coverage missing for > > org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$7 > > Test coverage missing for > > org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$4 > > Test coverage missing for > > org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$3 > > Test coverage missing for > > org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$6 > > Test coverage missing for > > org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$5 > > Test coverage missing for > > org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$2 > > Test coverage missing for > > org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$1 > > Test coverage missing for > > org/apache/aurora/scheduler/storage/log/LogStorage$Settings > > Test coverage missing for > > org/apache/aurora/scheduler/storage/log/LogStorage$ScheduledExecutorSchedulingService > > Test coverage missing for > > org/apache/aurora/scheduler/storage/log/LogStorageModule > > Test coverage missing for > > org/apache/aurora/scheduler/storage/backup/TemporaryStorage$TemporaryStorageFactory$1 > > Test coverage missing for > > org/apache/aurora/scheduler/storage/backup/BackupModule > > Test coverage missing for > > org/apache/aurora/scheduler/storage/backup/Recovery$RecoveryImpl > > Test coverage missing for > > org/apache/aurora/scheduler/storage/backup/TemporaryStorage$TemporaryStorageFactory > > Test coverage missing for > > org/apache/aurora/scheduler/storage/backup/Recovery$RecoveryImpl$PendingRecovery > > Test coverage missing for org/apache/aurora/scheduler/TaskVars > > Test coverage missing for > > org/apache/aurora/scheduler/SchedulerLifecycle$DefaultDelayedActions > > Test coverage missing for > > org/apache/aurora/scheduler/TierManager$TierManagerImpl$TierConfig > > Test coverage missing for org/apache/aurora/scheduler/TaskVars$Counter > > Test coverage missing for org/apache/aurora/scheduler/TaskVars$1 > > Test coverage missing for > > org/apache/aurora/scheduler/SchedulerModule$TaskEventBatchWorker > > Test coverage missing for org/apache/aurora/scheduler/HostOffer$1 > > Test coverage missing for org/apache/aurora/scheduler/SchedulerModule > > Test coverage missing for > > org/apache/aurora/scheduler/TaskIdGenerator$TaskIdGeneratorImpl > > Test coverage missing for org/apache/aurora/scheduler/SchedulerModule$1 > > Test coverage missing for > > org/apache/aurora/scheduler/TaskStatusHandlerImpl > > Test coverage missing for > > org/apache/aurora/scheduler/TaskStatusHandlerImpl$1 > > > > * Try: > > Run with --stacktrace option to get the stack trace. Run with --info or > > --debug option to get more log output. > > == > > > > BUILD FAILED > > > > Total time: 4 mins 50.396 secs > > > > > > I will refresh this build result if you post a review containing > > "@ReviewBot retry" This was an incidence of the now well-known: ``` :testJava HotSpot(TM) 64-Bit Server VM warning: INFO: os::commit_memory(0x0007a8e8, 298319872, 0) failed; error='Cannot allocate memory' (errno=12) ``` I'll spin one more retry and then submit this if green. - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54288/#review162700 --- On Jan. 23, 2017, 1:21 p.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54288/ > --- > > (Updated Jan. 23, 2017, 1:21 p.m.) > > > Review request for Aurora, David McLaughlin, Joshua Cohen, John Sirois, and > Stephan Erb. >
Re: Review Request 54288: Make leader elections resilient to ZK disconnections.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54288/#review162697 --- @ReviewBot retry - John Sirois On Jan. 23, 2017, 1:21 p.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54288/ > --- > > (Updated Jan. 23, 2017, 1:21 p.m.) > > > Review request for Aurora, David McLaughlin, Joshua Cohen, John Sirois, and > Stephan Erb. > > > Bugs: AURORA-1669 > https://issues.apache.org/jira/browse/AURORA-1669 > > > Repository: aurora > > > Description > --- > > As documented in AURORA-1840 the Curator `LeaderLatch` recipe abdicates > leadership if the ZK connection is lost or if there is a timeout. This is not > compatible with the commons based implementation which would only abdicate > leadership if the ZK session timeout occurred. > > This replaces the `LeaderLatch` recipe with the `LeaderSelector` recipe with a > custom listener that only loses leadership if a connection loss occurs. > > > Diffs > - > > > commons/src/main/java/org/apache/aurora/common/zookeeper/testing/ZooKeeperTestServer.java > 50acaeba82e163f8f2970a264cbd889c9eb3b5ed > > src/main/java/org/apache/aurora/scheduler/discovery/CuratorSingletonService.java > c378172c850aafe0a9381552b5067277b40dbfab > > src/test/java/org/apache/aurora/scheduler/discovery/BaseCuratorDiscoveryTest.java > a2b4125369d1f6c0a79bc4ac0fb3d2dab8a6c583 > > src/test/java/org/apache/aurora/scheduler/discovery/CuratorSingletonServiceTest.java > 6ea49b0c690d288ff59d1d4798144bfa2d153d3a > > Diff: https://reviews.apache.org/r/54288/diff/ > > > Testing > --- > > > Thanks, > > Zameer Manji > >
Re: Review Request 54288: Make leader elections resilient to ZK disconnections.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54288/#review162691 --- @ReviewBot retry - John Sirois On Jan. 23, 2017, 1:21 p.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54288/ > --- > > (Updated Jan. 23, 2017, 1:21 p.m.) > > > Review request for Aurora, David McLaughlin, Joshua Cohen, John Sirois, and > Stephan Erb. > > > Bugs: AURORA-1669 > https://issues.apache.org/jira/browse/AURORA-1669 > > > Repository: aurora > > > Description > --- > > As documented in AURORA-1840 the Curator `LeaderLatch` recipe abdicates > leadership if the ZK connection is lost or if there is a timeout. This is not > compatible with the commons based implementation which would only abdicate > leadership if the ZK session timeout occurred. > > This replaces the `LeaderLatch` recipe with the `LeaderSelector` recipe with a > custom listener that only loses leadership if a connection loss occurs. > > > Diffs > - > > > commons/src/main/java/org/apache/aurora/common/zookeeper/testing/ZooKeeperTestServer.java > 50acaeba82e163f8f2970a264cbd889c9eb3b5ed > > src/main/java/org/apache/aurora/scheduler/discovery/CuratorSingletonService.java > c378172c850aafe0a9381552b5067277b40dbfab > > src/test/java/org/apache/aurora/scheduler/discovery/BaseCuratorDiscoveryTest.java > a2b4125369d1f6c0a79bc4ac0fb3d2dab8a6c583 > > src/test/java/org/apache/aurora/scheduler/discovery/CuratorSingletonServiceTest.java > 6ea49b0c690d288ff59d1d4798144bfa2d153d3a > > Diff: https://reviews.apache.org/r/54288/diff/ > > > Testing > --- > > > Thanks, > > Zameer Manji > >
Re: Review Request 54288: Make leader elections resilient to ZK disconnections.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54288/#review162688 --- Ship it! Ship It! - John Sirois On Jan. 23, 2017, 1:21 p.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54288/ > --- > > (Updated Jan. 23, 2017, 1:21 p.m.) > > > Review request for Aurora, David McLaughlin, Joshua Cohen, John Sirois, and > Stephan Erb. > > > Bugs: AURORA-1669 > https://issues.apache.org/jira/browse/AURORA-1669 > > > Repository: aurora > > > Description > --- > > As documented in AURORA-1840 the Curator `LeaderLatch` recipe abdicates > leadership if the ZK connection is lost or if there is a timeout. This is not > compatible with the commons based implementation which would only abdicate > leadership if the ZK session timeout occurred. > > This replaces the `LeaderLatch` recipe with the `LeaderSelector` recipe with a > custom listener that only loses leadership if a connection loss occurs. > > > Diffs > - > > > commons/src/main/java/org/apache/aurora/common/zookeeper/testing/ZooKeeperTestServer.java > 50acaeba82e163f8f2970a264cbd889c9eb3b5ed > > src/main/java/org/apache/aurora/scheduler/discovery/CuratorSingletonService.java > c378172c850aafe0a9381552b5067277b40dbfab > > src/test/java/org/apache/aurora/scheduler/discovery/BaseCuratorDiscoveryTest.java > a2b4125369d1f6c0a79bc4ac0fb3d2dab8a6c583 > > src/test/java/org/apache/aurora/scheduler/discovery/CuratorSingletonServiceTest.java > 6ea49b0c690d288ff59d1d4798144bfa2d153d3a > > Diff: https://reviews.apache.org/r/54288/diff/ > > > Testing > --- > > > Thanks, > > Zameer Manji > >
Re: Review Request 54288: Make leader elections resilient to ZK disconnections.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54288/#review162687 --- NB: The [5-6 interdiff](https://reviews.apache.org/r/54288/diff/5-6/) is from me and represents minor changes to remove flakiness of tests. These changes now withstand >25 serial runs whereas they failed generally with <10 serial runs before. I took this opportunity to review Zameer's changes in detail, including the use of a single thread executor - which looked scary in isolation - and this all looks good to me. - John Sirois On Jan. 23, 2017, 1:21 p.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54288/ > --- > > (Updated Jan. 23, 2017, 1:21 p.m.) > > > Review request for Aurora, David McLaughlin, Joshua Cohen, John Sirois, and > Stephan Erb. > > > Bugs: AURORA-1669 > https://issues.apache.org/jira/browse/AURORA-1669 > > > Repository: aurora > > > Description > --- > > As documented in AURORA-1840 the Curator `LeaderLatch` recipe abdicates > leadership if the ZK connection is lost or if there is a timeout. This is not > compatible with the commons based implementation which would only abdicate > leadership if the ZK session timeout occurred. > > This replaces the `LeaderLatch` recipe with the `LeaderSelector` recipe with a > custom listener that only loses leadership if a connection loss occurs. > > > Diffs > - > > > commons/src/main/java/org/apache/aurora/common/zookeeper/testing/ZooKeeperTestServer.java > 50acaeba82e163f8f2970a264cbd889c9eb3b5ed > > src/main/java/org/apache/aurora/scheduler/discovery/CuratorSingletonService.java > c378172c850aafe0a9381552b5067277b40dbfab > > src/test/java/org/apache/aurora/scheduler/discovery/BaseCuratorDiscoveryTest.java > a2b4125369d1f6c0a79bc4ac0fb3d2dab8a6c583 > > src/test/java/org/apache/aurora/scheduler/discovery/CuratorSingletonServiceTest.java > 6ea49b0c690d288ff59d1d4798144bfa2d153d3a > > Diff: https://reviews.apache.org/r/54288/diff/ > > > Testing > --- > > > Thanks, > > Zameer Manji > >
Re: Review Request 55646: Ensure Aurora thrift support js and html.
> On Jan. 17, 2017, 3:28 p.m., Aurora ReviewBot wrote: > > Master (4e92be4) is red with this patch. > > ./build-support/jenkins/build.sh > > > > --- > > * What went wrong: > > Execution failed for task ':analyzeReport'. > > > Test coverage missing for > > > org/apache/aurora/scheduler/storage/db/views/DbImage > > Test coverage missing for org/apache/aurora/scheduler/http/Mname > > Test coverage missing for org/apache/aurora/scheduler/http/Services > > Test coverage missing for org/apache/aurora/scheduler/http/QuitCallback > > Test coverage missing for org/apache/aurora/scheduler/http/Cron > > Test coverage missing for org/apache/aurora/scheduler/app/VolumeParser > > Test coverage missing for > > org/apache/aurora/scheduler/configuration/executor/ExecutorSettingsLoader$Schema > > Test coverage missing for > > org/apache/aurora/scheduler/configuration/executor/ExecutorSettingsLoader > > Test coverage missing for > > org/apache/aurora/scheduler/pruning/TaskHistoryPruner$1 > > Test coverage missing for > > org/apache/aurora/scheduler/stats/AsyncStatsModule$OfferAdapter > > Test coverage missing for > > org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule > > Test coverage missing for > > org/apache/aurora/scheduler/http/api/security/ShiroUtils > > Test coverage missing for > > org/apache/aurora/scheduler/http/api/security/HttpSecurityModule$3 > > Test coverage missing for > > org/apache/aurora/scheduler/http/api/security/HttpSecurityModule$2 > > Test coverage missing for > > org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParser > > Test coverage missing for > > org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule > > Test coverage missing for > > org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule$1 > > Test coverage missing for > > org/apache/aurora/scheduler/log/mesos/MesosLog$LogStream > > Test coverage missing for org/apache/aurora/scheduler/log/mesos/MesosLog > > Test coverage missing for > > org/apache/aurora/scheduler/log/mesos/MesosLog$LogStream$OpStats > > Test coverage missing for > > org/apache/aurora/scheduler/log/mesos/MesosLog$LogStream$1 > > Test coverage missing for > > org/apache/aurora/scheduler/log/mesos/MesosLog$LogStream$LogEntry > > Test coverage missing for > > org/apache/aurora/scheduler/log/mesos/MesosLog$LogStream$LogPosition > > Test coverage missing for > > org/apache/aurora/scheduler/discovery/CommonsServiceDiscoveryModule > > Test coverage missing for > > org/apache/aurora/scheduler/reconciliation/KillRetry$KillAttempt > > Test coverage missing for > > org/apache/aurora/scheduler/preemptor/Preemptor$PreemptorImpl > > Test coverage missing for > > org/apache/aurora/scheduler/events/PubsubEvent$DriverDisconnected > > Test coverage missing for > > org/apache/aurora/scheduler/events/PubsubEvent$DriverRegistered > > Test coverage missing for > > org/apache/aurora/scheduler/storage/db/typehandlers/VolumeModeTypeHandler > > > > * Try: > > Run with --stacktrace option to get the stack trace. Run with --info or > > --debug option to get more log output. > > == > > > > BUILD FAILED > > > > Total time: 52 mins 15.294 secs > > > > > > I will refresh this build result if you post a review containing > > "@ReviewBot retry" This appears to have been: ``` ... Exception applying rule InvalidSlf4jMessageFormat on file /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java, continuing with next rule java.lang.NullPointerException at net.sourceforge.pmd.lang.java.rule.logging.InvalidSlf4jMessageFormatRule.countPlaceholders(InvalidSlf4jMessageFormatRule.java:199) at net.sourceforge.pmd.lang.java.rule.logging.InvalidSlf4jMessageFormatRule.getAmountOfExpectedArguments(InvalidSlf4jMessageFormatRule.java:192) at net.sourceforge.pmd.lang.java.rule.logging.InvalidSlf4jMessageFormatRule.expectedArguments(InvalidSlf4jMessageFormatRule.java:171) at net.sourceforge.pmd.lang.java.rule.logging.InvalidSlf4jMessageFormatRule.visit(InvalidSlf4jMessageFormatRule.java:88) ... ``` - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55646/#review161973 --- On Jan. 17,
Re: Review Request 55646: Ensure Aurora thrift support js and html.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55646/#review161975 --- @ReviewBot retry - John Sirois On Jan. 17, 2017, 2:30 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55646/ > --- > > (Updated Jan. 17, 2017, 2:30 p.m.) > > > Review request for Aurora and Joshua Cohen. > > > Bugs: AURORA-1875 > https://issues.apache.org/jira/browse/AURORA-1875 > > > Repository: aurora > > > Description > --- > > We use these for the Aurora UI and the API docs. > > build-support/thrift/thriftw | 2 ++ > 1 file changed, 2 insertions(+) > > > Diffs > - > > build-support/thrift/thriftw 278576f22b6127da306e2b12ece3686981a317d3 > > Diff: https://reviews.apache.org/r/55646/diff/ > > > Testing > --- > > Missed these 2 in https://reviews.apache.org/r/55536/ > > Our custom thrift build does not rebuild since it passes the new checks: > ``` > $ ./build-support/thrift/thriftw 0.9.1 --which > /home/jsirois/dev/apache/jsirois-aurora/build-support/thrift/thrift-0.9.1/compiler/cpp/thrift > $ ./build-support/thrift/thriftw 0.9.1 -help 2>&1 | grep -iE "javascript|html" > html (HTML): > standalone: Self-contained mode, includes all CSS in the HTML files. > Generates no style.css file, but HTML files will be > larger. > js (Javascript): > ``` > > > Thanks, > > John Sirois > >
Review Request 55646: Ensure Aurora thrift support js and html.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55646/ --- Review request for Aurora and Joshua Cohen. Bugs: AURORA-1875 https://issues.apache.org/jira/browse/AURORA-1875 Repository: aurora Description --- We use these for the Aurora UI and the API docs. build-support/thrift/thriftw | 2 ++ 1 file changed, 2 insertions(+) Diffs - build-support/thrift/thriftw 278576f22b6127da306e2b12ece3686981a317d3 Diff: https://reviews.apache.org/r/55646/diff/ Testing --- Missed these 2 in https://reviews.apache.org/r/55536/ Our custom thrift build does not rebuild since it passes the new checks: ``` $ ./build-support/thrift/thriftw 0.9.1 --which /home/jsirois/dev/apache/jsirois-aurora/build-support/thrift/thrift-0.9.1/compiler/cpp/thrift $ ./build-support/thrift/thriftw 0.9.1 -help 2>&1 | grep -iE "javascript|html" html (HTML): standalone: Self-contained mode, includes all CSS in the HTML files. Generates no style.css file, but HTML files will be larger. js (Javascript): ``` Thanks, John Sirois
Re: Review Request 55583: Make announced scheduler endpoint name configurable
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55583/#review161955
---
Ship it!
Ship It!
- John Sirois
On Jan. 16, 2017, 3:27 p.m., Stephan Erb wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55583/
> ---
>
> (Updated Jan. 16, 2017, 3:27 p.m.)
>
>
> Review request for Aurora, John Sirois and Zameer Manji.
>
>
> Bugs: AURORA-343
> https://issues.apache.org/jira/browse/AURORA-343
>
>
> Repository: aurora
>
>
> Description
> ---
>
> We decided to co-deploy an HTTPS enabled reverse proxy in front of each of
> our Aurora schedulers. The proxy instances bind to `public_ip:8081` and the
> schedulers to `localhost:8081`. By announcing the scheduler endpoint as
> `https` we can ensure the default Aurora [client connects via
> HTTPS](https://github.com/apache/aurora/blob/master/src/main/python/apache/aurora/client/api/scheduler_client.py#L176-L178).
>
>
> Diffs
> -
>
> RELEASE-NOTES.md 164d7a36b745ec3150967c5d34893f6076579115
> docs/operations/security.md 46e0b8a9db654f52467f9adf36307a6a97a7a3ec
> docs/reference/scheduler-configuration.md
> d4e0a9a4735c17d2af9b5f3381beea03ccf84d75
> src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java
> 43cc5b4645bc26b0fc6b23726ad3292699048ded
>
> Diff: https://reviews.apache.org/r/55583/diff/
>
>
> Testing
> ---
>
> Default:
>
> [zk: 127.0.0.1:2181(CONNECTED) 5] get /aurora/scheduler/member_11
>
> {"serviceEndpoint":{"host":"aurora.local","port":8081},"additionalEndpoints":{"http":{"host":"aurora.local","port":8081}},"status":"ALIVE"}
>
> When running with `-serverset_endpoint_name=https`:
>
> [zk: 127.0.0.1:2181(CONNECTED) 0] get /aurora/scheduler/member_19
>
> {"serviceEndpoint":{"host":"aurora.local","port":8081},"additionalEndpoints":{"https":{"host":"aurora.local","port":8081}},"status":"ALIVE"}
>
>
> Thanks,
>
> Stephan Erb
>
>
Re: Review Request 55536: Improve `thriftw` robustness.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55536/
---
(Updated Jan. 14, 2017, 11:19 a.m.)
Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji.
Changes
---
Consistent ${}-style for user-defined vars.
build-support/thrift/thriftw | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Bugs: AURORA-1875
https://issues.apache.org/jira/browse/AURORA-1875
Repository: aurora
Description
---
Now the selected thrift is checked both for the proper version and
support of the gen langs Aurora requires. In addition, all thrifts on
the `PATH` are and an existing locally built thrift is always verified
to protect Aurora thrift requirement changes (if we ever add a gen lang
again).
build-support/thrift/thriftw | 54
+++---
1 file changed, 42 insertions(+), 12 deletions(-)
Diffs (updated)
-
build-support/thrift/thriftw 1185298b902b5f1075816d0113ddc34dd4c26a89
Diff: https://reviews.apache.org/r/55536/diff/
Testing
---
I have thrift latest (0.10.0) installed as a system package:
```
$ ./build-support/thrift/thriftw 0.10.0 --which
/usr/bin/thrift
$ ./build-support/thrift/thriftw 0.10.0 -help 2>&1 | grep Swift
swift (Swift):
$ ./build-support/thrift/thriftw 0.9.1 --which
/home/jsirois/dev/apache/jsirois-aurora/build-support/thrift/thrift-0.9.1/compiler/cpp/thrift
$ ./build-support/thrift/thriftw 0.9.1 -help 2>&1 | grep Swift
$
```
I also edited the "java (Java)" gen identifier to "java (Java2)" and
observed the script forcing a clean recompile of 0.9.1 with a subsequent
failure to find a compatible thrift.
Thanks,
John Sirois
Review Request 55536: Improve `thriftw` robustness.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55536/ --- Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji. Bugs: AURORA-1875 https://issues.apache.org/jira/browse/AURORA-1875 Repository: aurora Description --- Now the selected thrift is checked both for the proper version and support of the gen langs Aurora requires. In addition, all thrifts on the `PATH` are and an existing locally built thrift is always verified to protect Aurora thrift requirement changes (if we ever add a gen lang again). build-support/thrift/thriftw | 54 +++--- 1 file changed, 42 insertions(+), 12 deletions(-) Diffs - build-support/thrift/thriftw 1185298b902b5f1075816d0113ddc34dd4c26a89 Diff: https://reviews.apache.org/r/55536/diff/ Testing --- I have thrift latest (0.10.0) installed as a system package: ``` $ ./build-support/thrift/thriftw 0.10.0 --which /usr/bin/thrift $ ./build-support/thrift/thriftw 0.10.0 -help 2>&1 | grep Swift swift (Swift): $ ./build-support/thrift/thriftw 0.9.1 --which /home/jsirois/dev/apache/jsirois-aurora/build-support/thrift/thrift-0.9.1/compiler/cpp/thrift $ ./build-support/thrift/thriftw 0.9.1 -help 2>&1 | grep Swift $ ``` I also edited the "java (Java)" gen identifier to "java (Java2)" and observed the script forcing a clean recompile of 0.9.1 with a subsequent failure to find a compatible thrift. Thanks, John Sirois
Re: Review Request 55510: Only include basenames in package checksums
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55510/#review161622 --- Ship it! Ship It! - John Sirois On Jan. 13, 2017, 4:25 p.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55510/ > --- > > (Updated Jan. 13, 2017, 4:25 p.m.) > > > Review request for Aurora and John Sirois. > > > Bugs: AURORA-1815 > https://issues.apache.org/jira/browse/AURORA-1815 > > > Repository: aurora-packaging > > > Description > --- > > Only include basenames in package checksums > > > Diffs > - > > build-support/release/release-candidate > 98df82412b6218ed7c1f650a7b1cc725ac297c37 > > Diff: https://reviews.apache.org/r/55510/diff/ > > > Testing > --- > > Before: > 713c53c6ace65683bbb6f6e72881442cc4f7a243 > /home/xxx/zzz/yyy/aurora-packaging/artifacts/aurora-debian-jessie/dist/aurora-tools_0.16.0-snapshot_amd64.deb > > After: > 713c53c6ace65683bbb6f6e72881442cc4f7a243 > aurora-tools_0.16.0-snapshot_amd64.deb > > > Thanks, > > Stephan Erb > >
Re: Review Request 55507: Update packaging scripts for Mesos 1.1.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55507/#review161620 --- Ship it! Ship It! - John Sirois On Jan. 13, 2017, 10:15 a.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55507/ > --- > > (Updated Jan. 13, 2017, 10:15 a.m.) > > > Review request for Aurora, John Sirois and Renan DelValle. > > > Repository: aurora-packaging > > > Description > --- > > Update packaging scripts for Mesos 1.1.0 > > > Diffs > - > > specs/debian/control 39247155780880ced09adae335677745bc9603fd > specs/rpm/aurora.spec 84eeea64fdf12ebfcf0356fc0b7937f50f157ad0 > test/deb/debian-jessie/provision.sh > b79dfea48946b027e5c2ee0e59fa93a51889c930 > test/deb/ubuntu-trusty/provision.sh > b9807ef63f73e985adaae6583023c4f5e762c6aa > test/rpm/centos-7/provision.sh 7bef270de5a3a046b6b068286db39997db64af2f > > Diff: https://reviews.apache.org/r/55507/diff/ > > > Testing > --- > > > Thanks, > > Stephan Erb > >
Re: Review Request 54669: Fix thrift bootstrap to use python2.7.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54669/#review158875 --- Ship it! Ship It! - John Sirois On Dec. 12, 2016, 10:11 a.m., Joshua Cohen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54669/ > --- > > (Updated Dec. 12, 2016, 10:11 a.m.) > > > Review request for Aurora and John Sirois. > > > Repository: aurora > > > Description > --- > > Fix thrift bootstrap to use python2.7. > > > Diffs > - > > build-support/thrift/Makefile 02e983582fb1a89efeee60a2de08f9050f8d17c3 > > Diff: https://reviews.apache.org/r/54669/diff/ > > > Testing > --- > > Verified this patch on a machine where python2.7 is not the default system > python. > > > Thanks, > > Joshua Cohen > >
Re: Review Request 54288: Make leader elections resilient to ZK disconnections.
> On Dec. 8, 2016, 4:42 p.m., Zameer Manji wrote: > > Does anyone know how to get the test reports from jenkins or have an idea > > of what's going on? Yes, these are legit failures, no Jenkins logs needed, just this is enough: ``` org.apache.aurora.scheduler.discovery.CuratorSingletonServiceTest > testAbdicateTransition FAILED java.lang.AssertionError at CuratorSingletonServiceTest.java:125 java.lang.AssertionError org.apache.aurora.scheduler.discovery.CuratorSingletonServiceTest > testLeadAdvertise FAILED java.lang.AssertionError at CuratorSingletonServiceTest.java:94 java.lang.AssertionError ``` I looked at the testLeadAdvertise one 1st which [blocks until an ephemeral node is added](https://github.com/apache/aurora/blob/master/src/test/java/org/apache/aurora/scheduler/discovery/CuratorSingletonServiceTest.java#L82-L83) to the leadership group path as the signal that leadership has been already synchronously obtained. The assumption is broken with LeaderSelector since the transition is [fired on an executor runnable](https://github.com/apache/curator/blob/master/curator-recipes/src/main/java/org/apache/curator/framework/recipes/leader/LeaderSelector.java#L239) and could be delayed arbitrarily past the test assertion. In short, you're getting lucky having these 2 (and maybe more) pass on your machine. Needs careful re-review of the test infra and the new behavior of the LeaderSelector using the thread pool to do leadership transitions async. - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54288/#review158601 --- On Dec. 8, 2016, 4:28 p.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54288/ > --- > > (Updated Dec. 8, 2016, 4:28 p.m.) > > > Review request for Aurora, David McLaughlin, Joshua Cohen, John Sirois, and > Stephan Erb. > > > Bugs: AURORA-1669 > https://issues.apache.org/jira/browse/AURORA-1669 > > > Repository: aurora > > > Description > --- > > As documented in AURORA-1840 the Curator `LeaderLatch` recipe abdicates > leadership if the ZK connection is lost or if there is a timeout. This is not > compatible with the commons based implementation which would only abdicate > leadership if the ZK session timeout occurred. > > This replaces the `LeaderLatch` recipe with the `LeaderSelector` recipe with a > custom listener that only loses leadership if a connection loss occurs. > > > Diffs > - > > > commons/src/main/java/org/apache/aurora/common/zookeeper/testing/ZooKeeperTestServer.java > 50acaeba82e163f8f2970a264cbd889c9eb3b5ed > > src/main/java/org/apache/aurora/scheduler/discovery/CuratorSingletonService.java > c378172c850aafe0a9381552b5067277b40dbfab > > src/test/java/org/apache/aurora/scheduler/discovery/BaseCuratorDiscoveryTest.java > a2b4125369d1f6c0a79bc4ac0fb3d2dab8a6c583 > > src/test/java/org/apache/aurora/scheduler/discovery/CuratorSingletonServiceTest.java > 6ea49b0c690d288ff59d1d4798144bfa2d153d3a > > Diff: https://reviews.apache.org/r/54288/diff/ > > > Testing > --- > > > Thanks, > > Zameer Manji > >
Review Request 54567: Fixup prepare_binary.sh to work under modern bash.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54567/ --- Review request for Aurora and Joshua Cohen. Repository: aurora Description --- Previously pushd/popd were used and these emit data to stdout muddying pants output and breaking setup of the thrift serve dir structure. build-support/thrift/prepare_binary.sh | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) Diffs - build-support/thrift/prepare_binary.sh e3b46aa1f36ed3eecc9bb7794073d18dd950eb1c Diff: https://reviews.apache.org/r/54567/diff/ Testing --- Reproduced the current master CI failure before this change on my linux machine. Fixed with this change. Thanks, John Sirois
Re: Review Request 54550: Specify python2.7 when extracting options from pants.ini during thrift bootstrap.
> On Dec. 8, 2016, 8:29 p.m., John Sirois wrote: > > build-support/thrift/prepare_binary.sh, line 29 > > <https://reviews.apache.org/r/54550/diff/3/?file=1580209#file1580209line29> > > > > aha - popd on linux echos the dirstack - presumably it does not do this > > on osx... so needs a re-direct. Ditto pushd. And AuroraBot really does > > need to go green. > > John Sirois wrote: > ...where linux probably just means modern bash, osx - even Sierra IIUC, > is wtfb (way tf behind). OK - I've reproed the failure mode on my linux machine. I'll send up an RB to fix. I would love to get to the bottom of the pushd/popd thrash though since it seems like this is not needed on linux - which makes no sense to me yet. - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54550/#review158632 --- On Dec. 8, 2016, 7:30 p.m., Joshua Cohen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54550/ > --- > > (Updated Dec. 8, 2016, 7:30 p.m.) > > > Review request for Aurora and Santhosh Kumar Shanmugham. > > > Repository: aurora > > > Description > --- > > We have some CI machines internally where the default python doesn't have the > `json` module, so this script fails. > > > Diffs > - > > build-support/thrift/prepare_binary.sh > a96b33e4564604f72d8fcf284f0cf1adea1866a9 > > Diff: https://reviews.apache.org/r/54550/diff/ > > > Testing > --- > > > Thanks, > > Joshua Cohen > >
Re: Review Request 54550: Specify python2.7 when extracting options from pants.ini during thrift bootstrap.
> On Dec. 8, 2016, 8:29 p.m., John Sirois wrote: > > build-support/thrift/prepare_binary.sh, line 29 > > <https://reviews.apache.org/r/54550/diff/3/?file=1580209#file1580209line29> > > > > aha - popd on linux echos the dirstack - presumably it does not do this > > on osx... so needs a re-direct. Ditto pushd. And AuroraBot really does > > need to go green. ...where linux probably just means modern bash, osx - even Sierra IIUC, is wtfb (way tf behind). - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54550/#review158632 --- On Dec. 8, 2016, 7:30 p.m., Joshua Cohen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54550/ > --- > > (Updated Dec. 8, 2016, 7:30 p.m.) > > > Review request for Aurora and Santhosh Kumar Shanmugham. > > > Repository: aurora > > > Description > --- > > We have some CI machines internally where the default python doesn't have the > `json` module, so this script fails. > > > Diffs > - > > build-support/thrift/prepare_binary.sh > a96b33e4564604f72d8fcf284f0cf1adea1866a9 > > Diff: https://reviews.apache.org/r/54550/diff/ > > > Testing > --- > > > Thanks, > > Joshua Cohen > >
Re: Review Request 54550: Specify python2.7 when extracting options from pants.ini during thrift bootstrap.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54550/#review158632 --- build-support/thrift/prepare_binary.sh (line 29) <https://reviews.apache.org/r/54550/#comment229419> aha - popd on linux echos the dirstack - presumably it does not do this on osx... so needs a re-direct. Ditto pushd. And AuroraBot really does need to go green. - John Sirois On Dec. 8, 2016, 7:30 p.m., Joshua Cohen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54550/ > --- > > (Updated Dec. 8, 2016, 7:30 p.m.) > > > Review request for Aurora and Santhosh Kumar Shanmugham. > > > Repository: aurora > > > Description > --- > > We have some CI machines internally where the default python doesn't have the > `json` module, so this script fails. > > > Diffs > - > > build-support/thrift/prepare_binary.sh > a96b33e4564604f72d8fcf284f0cf1adea1866a9 > > Diff: https://reviews.apache.org/r/54550/diff/ > > > Testing > --- > > > Thanks, > > Joshua Cohen > >
Re: Review Request 54550: Specify python2.7 when extracting options from pants.ini during thrift bootstrap.
> On Dec. 8, 2016, 7:37 p.m., Aurora ReviewBot wrote: > > Master (f5749ce) is red with this patch. > > ./build-support/jenkins/build.sh > > > > You are using pip version 8.1.2, however version 9.0.1 is available. > > You should consider upgrading via the 'pip install --upgrade pip' command. > > > > 02:35:38 00:00 [main] > >(To run a reporting server: ./pants server) > > 02:35:38 00:00 [setup] > > 02:35:38 00:00 [parse][32m > >Executing tasks in goals: compile[0m > > 02:35:38 00:00 [compile] > > 02:35:38 00:00 [compile-prep-command] > > 02:35:38 00:00 [prep_command] > > 02:35:41 00:03 [compile] > > 02:35:41 00:03 [python-eval] > > 02:35:41 00:03 [pythonstyle] > > 02:35:41 00:03 [cache] [32m > >No cached artifacts for 43 targets.[0m[32m > >Invalidated 43 targets.[0m > > 02:36:05 00:27 [complete][32m > >SUCCESS[0m > > + ./pants test.pytest > > --junit-xml-dir=/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results > > src/main/python:: src/test/python:: -- -v > > > > 02:36:06 00:00 [main] > >(To run a reporting server: ./pants server) > > 02:36:06 00:00 [setup] > > 02:36:06 00:00 [parse][32m > >Executing tasks in goals: test[0m > > 02:36:06 00:00 [test] > > 02:36:06 00:00 [test-prep-command] > > 02:36:06 00:00 [prep_command] > > 02:36:09 00:03 [test] > > 02:36:09 00:03 [pytest] > > 02:36:09 00:03 [run] > > > > 02:36:13 00:07 [chroot]INFO] Attempting to fetch thrift binary > > from: > > /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift/serve/bin/thrift/linux/x86_64/0.9.1/thrift > > ... > > > > FAILURE: Failed to fetch binary bin/thrift/linux/x86_64/0.9.1/thrift from > > any source: (Failed to fetch binary from > > /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift/serve/bin/thrift/linux/x86_64/0.9.1/thrift: > > Problem reading data from > > /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift/serve/bin/thrift/linux/x86_64/0.9.1/thrift: > > [Errno 2] No such file or directory: > > u'/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift/serve/bin/thrift/linux/x86_64/0.9.1/thrift') > > > > > > 02:36:13 00:07 [complete][31m > >FAILURE[0m > > > > > > I will refresh this build result if you post a review containing > > "@ReviewBot retry" And master went red in exactly this way. I'm not seeing it at present, but clearly master was in fact green when the initial change went in ... which implies the pushd/popd at least wasn't needed on the apache linux machines ... and so something subtle and odd is going on with that part of the change / your observed need for it. - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54550/#review158629 --- On Dec. 8, 2016, 7:30 p.m., Joshua Cohen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54550/ > --- > > (Updated Dec. 8, 2016, 7:30 p.m.) > > > Review request for Aurora and Santhosh Kumar Shanmugham. > > > Repository: aurora > > > Description > --- > > We have some CI machines internally where the default python doesn't have the > `json` module, so this script fails. > > > Diffs > - > > build-support/thrift/prepare_binary.sh > a96b33e4564604f72d8fcf284f0cf1adea1866a9 > > Diff: https://reviews.apache.org/r/54550/diff/ > > > Testing > --- > > > Thanks, > > Joshua Cohen > >
Re: Review Request 54550: Specify python2.7 when extracting options from pants.ini during thrift bootstrap.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54550/#review158626 --- Ship it! Ship It! - John Sirois On Dec. 8, 2016, 7:15 p.m., Joshua Cohen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54550/ > --- > > (Updated Dec. 8, 2016, 7:15 p.m.) > > > Review request for Aurora and Santhosh Kumar Shanmugham. > > > Repository: aurora > > > Description > --- > > We have some CI machines internally where the default python doesn't have the > `json` module, so this script fails. > > > Diffs > - > > build-support/thrift/prepare_binary.sh > a96b33e4564604f72d8fcf284f0cf1adea1866a9 > > Diff: https://reviews.apache.org/r/54550/diff/ > > > Testing > --- > > > Thanks, > > Joshua Cohen > >
Re: Review Request 54520: Revert BUILD changes in 0c177058.
a65a959c0c472a8af2c9c7a0daf59fc85cb0cbc8 src/test/python/apache/aurora/common/health_check/BUILD 72719f290b3e31bdba5002a8cba7039e236903c9 src/test/python/apache/aurora/config/BUILD f8e83cea9dc2b093e8af0efa2d94ffb94b3d2d95 src/test/python/apache/aurora/executor/BUILD 38ddb143dd6a755deebd8db820bf7b4ae3ba341a src/test/python/apache/aurora/executor/bin/BUILD b8a063580ec1b08df7008a351e02546e2d89c68e src/test/python/apache/aurora/executor/common/BUILD e337ebdc82e70a7fd6ceb8d990b42445cc8d415e src/test/python/apache/aurora/tools/BUILD a64b3603056ebee5bc5bbd081f03a131c4f35a58 src/test/python/apache/thermos/cli/BUILD 0ad1306f23dafeb0281f9f8ce484f589f201dee0 src/test/python/apache/thermos/cli/commands/BUILD 0ad1306f23dafeb0281f9f8ce484f589f201dee0 src/test/python/apache/thermos/common/BUILD 08b008e177ad0a63e35f8ea7cf092fd3bb93533c src/test/python/apache/thermos/config/BUILD 904453884d22d341cb76c20670d641440c4c4c4c src/test/python/apache/thermos/core/BUILD fd2e1527c94462d952752d5a69ac17f46f3221ac src/test/python/apache/thermos/monitoring/BUILD cf7c5f07fd51143d2d56bcc5b7f0c13dc4029c2f src/test/python/apache/thermos/observer/BUILD 1300e61597545f322de296fa91f2d9e1ab4b3bf1 src/test/python/apache/thermos/observer/http/BUILD 1300e61597545f322de296fa91f2d9e1ab4b3bf1 Diff: https://reviews.apache.org/r/54520/diff/ Testing --- Now with files listed and python tests run: ``` ./pants filemap src/test/python/:: ./build-support/jenkins/build.sh ``` Thanks, John Sirois
Re: Review Request 54520: Revert BUILD changes in 0c177058.
> On Dec. 7, 2016, 9:41 p.m., John Sirois wrote:
> > NB: When AuroraBot goes green I'll submit this TBR and file a follow-up
> > issue in Aurora and a corresponding one in pants if needed, to restore the
> > BUILD file changes for default targets and default globs.
Also note this was a mechanical change achieved with:
```
$ git co 0c1770581317d693f3b388c067d2ddd1dcc2b867^ -- src/{main,test}/python/
$ git reset HEAD \
src/main/python/apache/aurora/executor/aurora_executor.py \
src/main/python/apache/aurora/executor/common/health_checker.py \
src/test/python/apache/aurora/executor/common/test_health_checker.py
$ git co -- \
src/main/python/apache/aurora/executor/aurora_executor.py \
src/main/python/apache/aurora/executor/common/health_checker.py \
src/test/python/apache/aurora/executor/common/test_health_checker.py
```
The `git reset HEAD ... && git co -- ...` preserved Santhosh's changes in
[d05ea2bc](https://github.com/apache/aurora/commit/d05ea2bcc4af20af0b5e0a7f3995d02ff25a1626)
- John
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54520/#review158496
-------
On Dec. 7, 2016, 9:39 p.m., John Sirois wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54520/
> ---
>
> (Updated Dec. 7, 2016, 9:39 p.m.)
>
>
> Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> ---
>
> The changes caused `python_tests` target to lose their sources which in
> turn caused tests not to run.
>
> src/main/python/apache/aurora/admin/BUILD | 1 +
> src/main/python/apache/aurora/client/BUILD | 1 +
> src/main/python/apache/aurora/common/BUILD | 1 +
> src/main/python/apache/aurora/config/BUILD | 1 +
> src/main/python/apache/aurora/executor/BUILD| 1 +
> src/main/python/apache/aurora/kerberos/BUILD| 1 +
> src/main/python/apache/aurora/tools/BUILD | 1 +
> src/main/python/apache/thermos/cli/BUILD| 1 +
> src/main/python/apache/thermos/common/BUILD | 1 +
> src/main/python/apache/thermos/config/BUILD | 1 +
> src/main/python/apache/thermos/core/BUILD | 1 +
> src/main/python/apache/thermos/monitoring/BUILD | 1 +
> src/main/python/apache/thermos/observer/BUILD | 1 +
> src/main/python/apache/thermos/runner/BUILD | 1 +
> src/main/python/apache/thermos/testing/BUILD| 1 +
> src/test/python/apache/aurora/BUILD | 1 +
> src/test/python/apache/aurora/admin/BUILD | 2 ++
> src/test/python/apache/aurora/client/BUILD | 2 ++
> src/test/python/apache/aurora/client/api/BUILD | 2 ++
> src/test/python/apache/aurora/client/cli/BUILD | 2 ++
> src/test/python/apache/aurora/client/docker/BUILD | 2 ++
> src/test/python/apache/aurora/client/hooks/BUILD| 3 ++-
> src/test/python/apache/aurora/common/BUILD | 2 ++
> src/test/python/apache/aurora/common/health_check/BUILD | 2 ++
> src/test/python/apache/aurora/config/BUILD | 2 ++
> src/test/python/apache/aurora/executor/BUILD| 2 ++
> src/test/python/apache/aurora/executor/bin/BUILD| 2 ++
> src/test/python/apache/aurora/executor/common/BUILD | 2 ++
> src/test/python/apache/aurora/tools/BUILD | 2 ++
> src/test/python/apache/thermos/cli/BUILD| 2 ++
> src/test/python/apache/thermos/cli/commands/BUILD | 2 ++
> src/test/python/apache/thermos/common/BUILD | 2 ++
> src/test/python/apache/thermos/config/BUILD | 2 ++
> src/test/python/apache/thermos/core/BUILD | 2 ++
> src/test/python/apache/thermos/monitoring/BUILD | 2 ++
> src/test/python/apache/thermos/observer/BUILD | 2 ++
> src/test/python/apache/thermos/observer/http/BUILD | 2 ++
> 37 files changed, 58 insertions(+), 1 deletion(-)
>
>
> Diffs
> -
>
> src/main/python/apache/aurora/admin/BUILD
> 60bfbeda8369db71099a2056c509ea1f34eadaa6
> src/main/python/apache/aurora/client/BUILD
> 452efd45beeb61042b24cf116690221eb95d02ca
> src/main/python/apache/aurora/common/BUILD
> 85b5b45a099556a21d090e180645f0c680d62db3
> src/main/python/apache/aurora/config/BUILD
> 14364ef77eeaa9fe5cd8df731c7047ba18beb361
> src/main/python/apache/aurora/executor/BUIL
Re: Review Request 54520: Revert BUILD changes in 0c177058.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54520/#review158496 --- NB: When AuroraBot goes green I'll submit this TBR and file a follow-up issue in Aurora and a corresponding one in pants if needed, to restore the BUILD file changes for default targets and default globs. - John Sirois On Dec. 7, 2016, 9:39 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54520/ > --- > > (Updated Dec. 7, 2016, 9:39 p.m.) > > > Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji. > > > Repository: aurora > > > Description > --- > > The changes caused `python_tests` target to lose their sources which in > turn caused tests not to run. > > src/main/python/apache/aurora/admin/BUILD | 1 + > src/main/python/apache/aurora/client/BUILD | 1 + > src/main/python/apache/aurora/common/BUILD | 1 + > src/main/python/apache/aurora/config/BUILD | 1 + > src/main/python/apache/aurora/executor/BUILD| 1 + > src/main/python/apache/aurora/kerberos/BUILD| 1 + > src/main/python/apache/aurora/tools/BUILD | 1 + > src/main/python/apache/thermos/cli/BUILD| 1 + > src/main/python/apache/thermos/common/BUILD | 1 + > src/main/python/apache/thermos/config/BUILD | 1 + > src/main/python/apache/thermos/core/BUILD | 1 + > src/main/python/apache/thermos/monitoring/BUILD | 1 + > src/main/python/apache/thermos/observer/BUILD | 1 + > src/main/python/apache/thermos/runner/BUILD | 1 + > src/main/python/apache/thermos/testing/BUILD| 1 + > src/test/python/apache/aurora/BUILD | 1 + > src/test/python/apache/aurora/admin/BUILD | 2 ++ > src/test/python/apache/aurora/client/BUILD | 2 ++ > src/test/python/apache/aurora/client/api/BUILD | 2 ++ > src/test/python/apache/aurora/client/cli/BUILD | 2 ++ > src/test/python/apache/aurora/client/docker/BUILD | 2 ++ > src/test/python/apache/aurora/client/hooks/BUILD| 3 ++- > src/test/python/apache/aurora/common/BUILD | 2 ++ > src/test/python/apache/aurora/common/health_check/BUILD | 2 ++ > src/test/python/apache/aurora/config/BUILD | 2 ++ > src/test/python/apache/aurora/executor/BUILD| 2 ++ > src/test/python/apache/aurora/executor/bin/BUILD| 2 ++ > src/test/python/apache/aurora/executor/common/BUILD | 2 ++ > src/test/python/apache/aurora/tools/BUILD | 2 ++ > src/test/python/apache/thermos/cli/BUILD| 2 ++ > src/test/python/apache/thermos/cli/commands/BUILD | 2 ++ > src/test/python/apache/thermos/common/BUILD | 2 ++ > src/test/python/apache/thermos/config/BUILD | 2 ++ > src/test/python/apache/thermos/core/BUILD | 2 ++ > src/test/python/apache/thermos/monitoring/BUILD | 2 ++ > src/test/python/apache/thermos/observer/BUILD | 2 ++ > src/test/python/apache/thermos/observer/http/BUILD | 2 ++ > 37 files changed, 58 insertions(+), 1 deletion(-) > > > Diffs > - > > src/main/python/apache/aurora/admin/BUILD > 60bfbeda8369db71099a2056c509ea1f34eadaa6 > src/main/python/apache/aurora/client/BUILD > 452efd45beeb61042b24cf116690221eb95d02ca > src/main/python/apache/aurora/common/BUILD > 85b5b45a099556a21d090e180645f0c680d62db3 > src/main/python/apache/aurora/config/BUILD > 14364ef77eeaa9fe5cd8df731c7047ba18beb361 > src/main/python/apache/aurora/executor/BUILD > bb6d4a3e21075ee4d56615e083059d7cae2e3e99 > src/main/python/apache/aurora/kerberos/BUILD > d1e6ded02ad8f71e56659fa4455dbbe14b965249 > src/main/python/apache/aurora/tools/BUILD > c970bec2c64226b22b624f39d21b2cedcaf4d60d > src/main/python/apache/thermos/cli/BUILD > 784b05c6811a86589a5a1a64bc3d15302bb22479 > src/main/python/apache/thermos/common/BUILD > 023b87ff4ac28c58914a1a8d3943fb0554b1a259 > src/main/python/apache/thermos/config/BUILD > 729c6533d3e059c0e65bb69da3af464f1dd9d49f > src/main/python/apache/thermos/core/BUILD > e800ccabfb780e8962686434f18caba522f6516b > src/main/python/apache/thermos/monitoring/BUILD > a1c16ac782da3df78b325f5273f76c47a6a1febf > src/main/python/apache/thermos/observer/BUILD
Review Request 54520: Revert BUILD changes in 0c177058.
72719f290b3e31bdba5002a8cba7039e236903c9 src/test/python/apache/aurora/config/BUILD f8e83cea9dc2b093e8af0efa2d94ffb94b3d2d95 src/test/python/apache/aurora/executor/BUILD 38ddb143dd6a755deebd8db820bf7b4ae3ba341a src/test/python/apache/aurora/executor/bin/BUILD b8a063580ec1b08df7008a351e02546e2d89c68e src/test/python/apache/aurora/executor/common/BUILD e337ebdc82e70a7fd6ceb8d990b42445cc8d415e src/test/python/apache/aurora/tools/BUILD a64b3603056ebee5bc5bbd081f03a131c4f35a58 src/test/python/apache/thermos/cli/BUILD 0ad1306f23dafeb0281f9f8ce484f589f201dee0 src/test/python/apache/thermos/cli/commands/BUILD 0ad1306f23dafeb0281f9f8ce484f589f201dee0 src/test/python/apache/thermos/common/BUILD 08b008e177ad0a63e35f8ea7cf092fd3bb93533c src/test/python/apache/thermos/config/BUILD 904453884d22d341cb76c20670d641440c4c4c4c src/test/python/apache/thermos/core/BUILD fd2e1527c94462d952752d5a69ac17f46f3221ac src/test/python/apache/thermos/monitoring/BUILD cf7c5f07fd51143d2d56bcc5b7f0c13dc4029c2f src/test/python/apache/thermos/observer/BUILD 1300e61597545f322de296fa91f2d9e1ab4b3bf1 src/test/python/apache/thermos/observer/http/BUILD 1300e61597545f322de296fa91f2d9e1ab4b3bf1 Diff: https://reviews.apache.org/r/54520/diff/ Testing --- Now with files listed and python tests run: ``` ./pants filemap src/test/python/:: ./build-support/jenkins/build.sh ``` Thanks, John Sirois
Re: Review Request 53836: Get pants using the same thrift binary as gradle.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53836/#review158279
---
Please take another look, Zameer's comment has been adressed and there have
been a significant number of insignificant automated changes to BUILD targets
(pants no longer requires a `name` for the default target, nor
`globs('*.')` for targets that own all the standard sources in
a directory.
- John Sirois
On Dec. 6, 2016, 5:30 p.m., John Sirois wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53836/
> ---
>
> (Updated Dec. 6, 2016, 5:30 p.m.)
>
>
> Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> ---
>
> This required an upgrade to the latest pants dev release to correct
> an issue with the setup.py binary packager we use to generate sdists.
>
> This is for sanity sake, and, once the TODO in
> `build-support/thrift/prepare_binary.sh` is addressed, it will also
> allow pants-patch-free addition of new platforms (thinking ARM).
>
> api/src/main/thrift/org/apache/aurora/gen/BUILD| 3
> +++
> api/src/main/thrift/org/apache/thermos/BUILD | 1 +
> build-support/thrift/.gitignore| 1 +
> build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch| 42
> +--
> build-support/thrift/AURORA-1727.lib.py.setup.py.patch | 45
> +
> {api/src/main/thrift/org/apache/thermos => build-support/thrift}/BUILD | 18
> -
> build-support/thrift/Makefile | 2
> +-
> build-support/thrift/prepare_binary.sh | 68
> ++
> build-support/thrift/thriftw | 12
> +++--
> pants.ini | 7
> +-
> 10 files changed, 158 insertions(+), 41 deletions(-)
>
>
> Diffs
> -
>
> api/src/main/thrift/org/apache/aurora/gen/BUILD
> f4004a3ca36078c6d24991db4beb68903a05652c
> api/src/main/thrift/org/apache/thermos/BUILD
> cb655a2fd35d22f7d7e80c4311742bad763d8614
> build-support/thrift/.gitignore 9a3adb69210ba3dbf3c1f408895561da37e8f4c3
> build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch
> b69e3fef137cd73c6f2b73201463a0705ef8082a
> build-support/thrift/AURORA-1727.lib.py.setup.py.patch PRE-CREATION
> build-support/thrift/BUILD PRE-CREATION
> build-support/thrift/Makefile 48b174ad622288d2738a5fa37bbb72385fcc3a27
> build-support/thrift/prepare_binary.sh PRE-CREATION
> build-support/thrift/thriftw 50d6dfdeb16ca8bf14aaff7aa826e3d69c5e13f0
> pants.ini cecdb277f327f77b2652f76a30fc8d4ffd9ff1db
> src/main/python/apache/aurora/admin/BUILD
> b5d37f718a25d43d7ac07e30f789cf526bdfdcc2
> src/main/python/apache/aurora/client/BUILD
> 1411765ed47d4286e3ba0636bc3f3c1b29afac02
> src/main/python/apache/aurora/common/BUILD
> 0e4c51020946dc21953493bd43b944177c444c28
> src/main/python/apache/aurora/config/BUILD
> 12e7fe973f456d0847ce63d3b293131a7f4c3bdd
> src/main/python/apache/aurora/executor/BUILD
> 486230db34a22ea5dd0f68da911c0afb1afbcac0
> src/main/python/apache/aurora/kerberos/BUILD
> 847852fdf7762789579f8818c677dc1f79a76c73
> src/main/python/apache/aurora/tools/BUILD
> 6717f92c65d7bc1d71c67e37f57750c28f10fda3
> src/main/python/apache/thermos/cli/BUILD
> a4932b2757a53ab8654c5d9c0fbae4446c9c5383
> src/main/python/apache/thermos/common/BUILD
> 0adabbfa3f0230dae95aca5002c128832916fdd6
> src/main/python/apache/thermos/config/BUILD
> 6e52c4bbe111529e14327de699218d9340e66fa9
> src/main/python/apache/thermos/core/BUILD
> 82448cec3380e237001f2fb02a28df4c5e5adb30
> src/main/python/apache/thermos/monitoring/BUILD
> 65ba7088f65e7baa5d30744736ba456b46a55e86
> src/main/python/apache/thermos/observer/BUILD
> 95b8dcd7d123d3a2bcb22df7efc60374ef919bf7
> src/main/python/apache/thermos/runner/BUILD
> 085b6ce35e8f67d9db0f6838bafeeb525191e6e9
> src/main/python/apache/thermos/testing/BUILD
> 24261701c5334999431a6cd41a6a711753180a89
> src/test/python/apache/aurora/BUILD
> 626f1108a24e25747f2c57b4a9f21acbc32fd2d5
> src/test/python/apache
Re: Review Request 53836: Get pants using the same thrift binary as gradle.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53836/#review158267
---
NB: BUILD file changes removing name for default targets and globs for 1-1-1
targets were automatic.
For name:
```
find . -name "BUILD*" | \
xargs grep -E "name\s*=" | \
sed -r -e "s|((.*/)?([^/]+)/BUILD[^:]*):.*name\s*=\s*['\"]([^'\"]+)['\"].*|\1
\3 \4|" | \
while read file dir name
do
[ "$dir" == "$name" ] && echo "$file $name"
done | \
sort -u | \
while read file name
do
sed -ri \
-e "s|(\s*name\s*=\s*['\"]$name['\"]\s*,\s*|(|" \
-e "/name\s*=\s*['\"]$name['\"]/d" $file
done
```
For globs:
```
for t in python_library python_tests
do
./pants filter --type=$t :: \
| cut -d: -f1 | sort -u | sed -e '/^$/d' -e 's|$|/BUILD|' \
| while read f; do ls $f* || echo $f >2; done \
| xargs sed -r -i "/\bsources\s*=\s*globs(['\"]*.[a-z]+['\"])\s*,?/d"
done
```
- John Sirois
On Dec. 6, 2016, 5:30 p.m., John Sirois wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53836/
> ---
>
> (Updated Dec. 6, 2016, 5:30 p.m.)
>
>
> Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> ---
>
> This required an upgrade to the latest pants dev release to correct
> an issue with the setup.py binary packager we use to generate sdists.
>
> This is for sanity sake, and, once the TODO in
> `build-support/thrift/prepare_binary.sh` is addressed, it will also
> allow pants-patch-free addition of new platforms (thinking ARM).
>
> api/src/main/thrift/org/apache/aurora/gen/BUILD| 3
> +++
> api/src/main/thrift/org/apache/thermos/BUILD | 1 +
> build-support/thrift/.gitignore| 1 +
> build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch| 42
> +--
> build-support/thrift/AURORA-1727.lib.py.setup.py.patch | 45
> +
> {api/src/main/thrift/org/apache/thermos => build-support/thrift}/BUILD | 18
> -
> build-support/thrift/Makefile | 2
> +-
> build-support/thrift/prepare_binary.sh | 68
> ++
> build-support/thrift/thriftw | 12
> +++--
> pants.ini | 7
> +-
> 10 files changed, 158 insertions(+), 41 deletions(-)
>
>
> Diffs
> -
>
> api/src/main/thrift/org/apache/aurora/gen/BUILD
> f4004a3ca36078c6d24991db4beb68903a05652c
> api/src/main/thrift/org/apache/thermos/BUILD
> cb655a2fd35d22f7d7e80c4311742bad763d8614
> build-support/thrift/.gitignore 9a3adb69210ba3dbf3c1f408895561da37e8f4c3
> build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch
> b69e3fef137cd73c6f2b73201463a0705ef8082a
> build-support/thrift/AURORA-1727.lib.py.setup.py.patch PRE-CREATION
> build-support/thrift/BUILD PRE-CREATION
> build-support/thrift/Makefile 48b174ad622288d2738a5fa37bbb72385fcc3a27
> build-support/thrift/prepare_binary.sh PRE-CREATION
> build-support/thrift/thriftw 50d6dfdeb16ca8bf14aaff7aa826e3d69c5e13f0
> pants.ini cecdb277f327f77b2652f76a30fc8d4ffd9ff1db
> src/main/python/apache/aurora/admin/BUILD
> b5d37f718a25d43d7ac07e30f789cf526bdfdcc2
> src/main/python/apache/aurora/client/BUILD
> 1411765ed47d4286e3ba0636bc3f3c1b29afac02
> src/main/python/apache/aurora/common/BUILD
> 0e4c51020946dc21953493bd43b944177c444c28
> src/main/python/apache/aurora/config/BUILD
> 12e7fe973f456d0847ce63d3b293131a7f4c3bdd
> src/main/python/apache/aurora/executor/BUILD
> 486230db34a22ea5dd0f68da911c0afb1afbcac0
> src/main/python/apache/aurora/kerberos/BUILD
> 847852fdf7762789579f8818c677dc1f79a76c73
> src/main/python/apache/aurora/tools/BUILD
> 6717f92c65d7bc1d71c67e37f57750c28f10fda3
> src/main/python/apache/thermos/cli/BUILD
> a4932b2757a53ab8654c5d9c0fbae4446c9c5383
> src/main/python/apache/thermos/common/BUILD
> 0adabbfa3f0230dae95aca5002c128832916fdd6
> src/main/python/apache/thermos/config/BUILD
> 6e52c4
Re: Review Request 53836: Get pants using the same thrift binary as gradle.
> On Nov. 17, 2016, 2:48 p.m., Zameer Manji wrote:
> > api/src/main/thrift/org/apache/aurora/gen/BUILD, line 34
> > <https://reviews.apache.org/r/53836/diff/1/?file=1565790#file1565790line34>
> >
> > Can't we have our own 3rdparty thrift target that includes the thrift
> > lib and this prepare binary? Then we can put the dep in one place.
>
> John Sirois wrote:
> I can, but this requires a custom pants plugin (housed as a loose python
> sourcefile in the repo) to expose, say, an `aurora_py_thrift_lib` target.
> Your comments here expressed reservations about that:
> https://reviews.apache.org/r/40219/
> If you re-ack you're in-fact OK with a custom plugin for this, I'll whip
> up diff 2.
>
> Zameer Manji wrote:
> I think in this case, a custom pants plugin will be better, assuming the
> API in this version is stable until pants 2.x
>
> John Sirois wrote:
> Yes, the API gaurantees are strong with pants since 1.0.0 and the plugin
> APIs needed for this will be stable until 2.x.
>
> John Sirois wrote:
> Re-reading what you suggest which of course requires no plugin, simply
> adding the dep to target at address `3rdparty/python:thrift` is
> straightforward. Will do.
Fixed.
- John
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53836/#review156248
---
On Dec. 6, 2016, 5:30 p.m., John Sirois wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53836/
> ---
>
> (Updated Dec. 6, 2016, 5:30 p.m.)
>
>
> Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> ---
>
> This required an upgrade to the latest pants dev release to correct
> an issue with the setup.py binary packager we use to generate sdists.
>
> This is for sanity sake, and, once the TODO in
> `build-support/thrift/prepare_binary.sh` is addressed, it will also
> allow pants-patch-free addition of new platforms (thinking ARM).
>
> api/src/main/thrift/org/apache/aurora/gen/BUILD| 3
> +++
> api/src/main/thrift/org/apache/thermos/BUILD | 1 +
> build-support/thrift/.gitignore| 1 +
> build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch| 42
> +--
> build-support/thrift/AURORA-1727.lib.py.setup.py.patch | 45
> +
> {api/src/main/thrift/org/apache/thermos => build-support/thrift}/BUILD | 18
> -
> build-support/thrift/Makefile | 2
> +-
> build-support/thrift/prepare_binary.sh | 68
> ++
> build-support/thrift/thriftw | 12
> +++--
> pants.ini | 7
> +-
> 10 files changed, 158 insertions(+), 41 deletions(-)
>
>
> Diffs
> -
>
> api/src/main/thrift/org/apache/aurora/gen/BUILD
> f4004a3ca36078c6d24991db4beb68903a05652c
> api/src/main/thrift/org/apache/thermos/BUILD
> cb655a2fd35d22f7d7e80c4311742bad763d8614
> build-support/thrift/.gitignore 9a3adb69210ba3dbf3c1f408895561da37e8f4c3
> build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch
> b69e3fef137cd73c6f2b73201463a0705ef8082a
> build-support/thrift/AURORA-1727.lib.py.setup.py.patch PRE-CREATION
> build-support/thrift/BUILD PRE-CREATION
> build-support/thrift/Makefile 48b174ad622288d2738a5fa37bbb72385fcc3a27
> build-support/thrift/prepare_binary.sh PRE-CREATION
> build-support/thrift/thriftw 50d6dfdeb16ca8bf14aaff7aa826e3d69c5e13f0
> pants.ini cecdb277f327f77b2652f76a30fc8d4ffd9ff1db
> src/main/python/apache/aurora/admin/BUILD
> b5d37f718a25d43d7ac07e30f789cf526bdfdcc2
> src/main/python/apache/aurora/client/BUILD
> 1411765ed47d4286e3ba0636bc3f3c1b29afac02
> src/main/python/apache/aurora/common/BUILD
> 0e4c51020946dc21953493bd43b944177c444c28
> src/main/python/apache/aurora/config/BUILD
> 12e7fe973f456d0847ce63d3b293131a7f4c3bdd
> src/main/python/apache/aurora/executor/BUILD
> 486230db34a22ea5dd0f68da911c0afb1afbcac0
> src/main/python/apache/aurora/kerberos/BUILD
> 847852fdf7762789579f8818c677dc1f79a76c73
> src/main/python/
Re: Review Request 53836: Get pants using the same thrift binary as gradle.
ILD PRE-CREATION build-support/thrift/Makefile 48b174ad622288d2738a5fa37bbb72385fcc3a27 build-support/thrift/prepare_binary.sh PRE-CREATION build-support/thrift/thriftw 50d6dfdeb16ca8bf14aaff7aa826e3d69c5e13f0 pants.ini cecdb277f327f77b2652f76a30fc8d4ffd9ff1db src/main/python/apache/aurora/admin/BUILD b5d37f718a25d43d7ac07e30f789cf526bdfdcc2 src/main/python/apache/aurora/client/BUILD 1411765ed47d4286e3ba0636bc3f3c1b29afac02 src/main/python/apache/aurora/common/BUILD 0e4c51020946dc21953493bd43b944177c444c28 src/main/python/apache/aurora/config/BUILD 12e7fe973f456d0847ce63d3b293131a7f4c3bdd src/main/python/apache/aurora/executor/BUILD 486230db34a22ea5dd0f68da911c0afb1afbcac0 src/main/python/apache/aurora/kerberos/BUILD 847852fdf7762789579f8818c677dc1f79a76c73 src/main/python/apache/aurora/tools/BUILD 6717f92c65d7bc1d71c67e37f57750c28f10fda3 src/main/python/apache/thermos/cli/BUILD a4932b2757a53ab8654c5d9c0fbae4446c9c5383 src/main/python/apache/thermos/common/BUILD 0adabbfa3f0230dae95aca5002c128832916fdd6 src/main/python/apache/thermos/config/BUILD 6e52c4bbe111529e14327de699218d9340e66fa9 src/main/python/apache/thermos/core/BUILD 82448cec3380e237001f2fb02a28df4c5e5adb30 src/main/python/apache/thermos/monitoring/BUILD 65ba7088f65e7baa5d30744736ba456b46a55e86 src/main/python/apache/thermos/observer/BUILD 95b8dcd7d123d3a2bcb22df7efc60374ef919bf7 src/main/python/apache/thermos/runner/BUILD 085b6ce35e8f67d9db0f6838bafeeb525191e6e9 src/main/python/apache/thermos/testing/BUILD 24261701c5334999431a6cd41a6a711753180a89 src/test/python/apache/aurora/BUILD 626f1108a24e25747f2c57b4a9f21acbc32fd2d5 src/test/python/apache/aurora/admin/BUILD 093537ed13406be3e8dff3245283b4d8d53481a3 src/test/python/apache/aurora/client/BUILD 0dc7b8ed19e1216d027095afc43e063d17bedad1 src/test/python/apache/aurora/client/api/BUILD e9742240ec4847b4256b554a01dd2369f6fb62f5 src/test/python/apache/aurora/client/cli/BUILD 16c4eb5bfbb751ba307f6f7b4335c2dbb99acb46 src/test/python/apache/aurora/client/docker/BUILD 5ea2cf791cdec6011978770fc0cffe90e4e7735d src/test/python/apache/aurora/client/hooks/BUILD 47c86d98ef8e3eaaef3eba1b2e5179848c256fb9 src/test/python/apache/aurora/common/BUILD b3991ee6086269811cffbe5a65bf92fc74002379 src/test/python/apache/aurora/common/health_check/BUILD e73f0c0579d81ed1da8fa663e6a3af5dbc866c73 src/test/python/apache/aurora/config/BUILD ec7909d9442c986225f075ba3ec8e4bfce50dc85 src/test/python/apache/aurora/executor/BUILD d5724746dd0f8b4ef95abbe5a1e75e22548c1b55 src/test/python/apache/aurora/executor/bin/BUILD c9dcb9f1ed98dc98b52a5a5f0acd66845b0fffb3 src/test/python/apache/aurora/executor/common/BUILD 5b794304659d6f80f05a140166c19856c8feef10 src/test/python/apache/aurora/tools/BUILD bf3bbf976968967873c7332708e254a7c2e2a14b src/test/python/apache/thermos/cli/BUILD 401bdba8c89ca47dfd65dc2142fcdb13d544a413 src/test/python/apache/thermos/cli/commands/BUILD 7ed1d6ce067682c298e1a56d28c1b29de1e05086 src/test/python/apache/thermos/common/BUILD b570759b5829c144b7c90744dd5f86cd9f490289 src/test/python/apache/thermos/config/BUILD a507157a3f8df6a705339a91d6e82411d997bdf6 src/test/python/apache/thermos/core/BUILD 957a116ca0ff9e951bbd49b25d0a6a199d994a2b src/test/python/apache/thermos/monitoring/BUILD 8f2b39336dce6c7b580e6ba0009f60afdcb89179 src/test/python/apache/thermos/observer/BUILD ec391f24344eefa7ad6ce50145458692bb8b1d97 src/test/python/apache/thermos/observer/http/BUILD 708f09bef0755baebb64759eb4e920a1e213765b Diff: https://reviews.apache.org/r/53836/diff/ Testing --- Locally green: ``` rm -rf ~/.cache/pants .cache/ git clean -fdx build-support/thrift ./pants clean-all ./build-support/jenkins/build.sh vagrant ssh --command "rm -rf ~/.cache/pants && cd aurora && rm -rf .cache/ && ./pants clean-all" ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh ./build-support/python/make-pycharm-virtualenv ``` Thanks, John Sirois
Re: Review Request 53836: Get pants using the same thrift binary as gradle.
> On Nov. 17, 2016, 2:48 p.m., Zameer Manji wrote:
> > api/src/main/thrift/org/apache/aurora/gen/BUILD, line 34
> > <https://reviews.apache.org/r/53836/diff/1/?file=1565790#file1565790line34>
> >
> > Can't we have our own 3rdparty thrift target that includes the thrift
> > lib and this prepare binary? Then we can put the dep in one place.
>
> John Sirois wrote:
> I can, but this requires a custom pants plugin (housed as a loose python
> sourcefile in the repo) to expose, say, an `aurora_py_thrift_lib` target.
> Your comments here expressed reservations about that:
> https://reviews.apache.org/r/40219/
> If you re-ack you're in-fact OK with a custom plugin for this, I'll whip
> up diff 2.
>
> Zameer Manji wrote:
> I think in this case, a custom pants plugin will be better, assuming the
> API in this version is stable until pants 2.x
>
> John Sirois wrote:
> Yes, the API gaurantees are strong with pants since 1.0.0 and the plugin
> APIs needed for this will be stable until 2.x.
Re-reading what you suggest which of course requires no plugin, simply adding
the dep to target at address `3rdparty/python:thrift` is straightforward. Will
do.
- John
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53836/#review156248
---
On Nov. 16, 2016, 9:46 p.m., John Sirois wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53836/
> ---
>
> (Updated Nov. 16, 2016, 9:46 p.m.)
>
>
> Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> ---
>
> This required an upgrade to the latest pants dev release to correct
> an issue with the setup.py binary packager we use to generate sdists.
>
> This is for sanity sake, and, once the TODO in
> `build-support/thrift/prepare_binary.sh` is addressed, it will also
> allow pants-patch-free addition of new platforms (thinking ARM).
>
> api/src/main/thrift/org/apache/aurora/gen/BUILD| 3
> +++
> api/src/main/thrift/org/apache/thermos/BUILD | 1 +
> build-support/thrift/.gitignore| 1 +
> build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch| 42
> +--
> build-support/thrift/AURORA-1727.lib.py.setup.py.patch | 45
> +
> {api/src/main/thrift/org/apache/thermos => build-support/thrift}/BUILD | 18
> -
> build-support/thrift/Makefile | 2
> +-
> build-support/thrift/prepare_binary.sh | 68
> ++
> build-support/thrift/thriftw | 12
> +++--
> pants.ini | 7
> +-
> 10 files changed, 158 insertions(+), 41 deletions(-)
>
>
> Diffs
> -
>
> api/src/main/thrift/org/apache/aurora/gen/BUILD
> f4004a3ca36078c6d24991db4beb68903a05652c
> api/src/main/thrift/org/apache/thermos/BUILD
> cb655a2fd35d22f7d7e80c4311742bad763d8614
> build-support/thrift/.gitignore 9a3adb69210ba3dbf3c1f408895561da37e8f4c3
> build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch
> b69e3fef137cd73c6f2b73201463a0705ef8082a
> build-support/thrift/AURORA-1727.lib.py.setup.py.patch PRE-CREATION
> build-support/thrift/BUILD PRE-CREATION
> build-support/thrift/Makefile 48b174ad622288d2738a5fa37bbb72385fcc3a27
> build-support/thrift/prepare_binary.sh PRE-CREATION
> build-support/thrift/thriftw 50d6dfdeb16ca8bf14aaff7aa826e3d69c5e13f0
> pants.ini cecdb277f327f77b2652f76a30fc8d4ffd9ff1db
>
> Diff: https://reviews.apache.org/r/53836/diff/
>
>
> Testing
> ---
>
> Locally green:
> ```
> rm -rf ~/.cache/pants .cache/
> git clean -fdx build-support/thrift
> ./pants clean-all
> ./build-support/jenkins/build.sh
>
> vagrant ssh --command "rm -rf ~/.cache/pants && cd aurora && rm -rf .cache/
> && ./pants clean-all"
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
> ./build-support/python/make-pycharm-virtualenv
> ```
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 54250: Revert removal of twitter/commons/zk based leadership code
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54250/#review157591 --- Ship it! Ship It! - John Sirois On Dec. 1, 2016, 3:48 a.m., David McLaughlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54250/ > --- > > (Updated Dec. 1, 2016, 3:48 a.m.) > > > Review request for Aurora, Joshua Cohen, John Sirois, Stephan Erb, and Zameer > Manji. > > > Bugs: AURORA-1840 > https://issues.apache.org/jira/browse/AURORA-1840 > > > Repository: aurora > > > Description > --- > > Reverts the following two commits: > https://github.com/apache/aurora/commit/b417be38fe1fcae6b85f7e91cea961ab272adf3f > https://github.com/apache/aurora/commit/69cba786efc2628eab566201dfea46836a1d9af5 > > > See discussion here: https://issues.apache.org/jira/browse/AURORA-1840 > > > Diffs > - > > RELEASE-NOTES.md 96926f4eb993578ea174d5a2f0ad75472803381d > build.gradle f257440e67384d9bd223b3c39785525bdb54dd9b > commons/src/main/java/org/apache/aurora/common/zookeeper/Candidate.java > PRE-CREATION > commons/src/main/java/org/apache/aurora/common/zookeeper/CandidateImpl.java > PRE-CREATION > commons/src/main/java/org/apache/aurora/common/zookeeper/Group.java > PRE-CREATION > commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSet.java > PRE-CREATION > commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSetImpl.java > PRE-CREATION > commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSets.java > PRE-CREATION > > commons/src/main/java/org/apache/aurora/common/zookeeper/SingletonServiceImpl.java > PRE-CREATION > > commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperClient.java > PRE-CREATION > > commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperUtils.java > PRE-CREATION > > commons/src/main/java/org/apache/aurora/common/zookeeper/testing/BaseZooKeeperClientTest.java > PRE-CREATION > > commons/src/test/java/org/apache/aurora/common/zookeeper/CandidateImplTest.java > PRE-CREATION > commons/src/test/java/org/apache/aurora/common/zookeeper/GroupTest.java > PRE-CREATION > > commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetImplTest.java > PRE-CREATION > > commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetsTest.java > PRE-CREATION > > commons/src/test/java/org/apache/aurora/common/zookeeper/SingletonServiceImplTest.java > PRE-CREATION > > commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperClientTest.java > PRE-CREATION > > commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperUtilsTest.java > PRE-CREATION > config/findbugs/excludeFilter.xml 5eaa11afa0cbe9b6b078066266f36c8a86bc057f > docs/features/service-discovery.md 511c96d8bc65531f4fe637cf02d3ae9eb414964e > docs/reference/scheduler-configuration.md > 895565396a0c927e95bab774ec54c1b908350bc3 > src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java > 76209b12a80f24e410ed96fa8592021417354228 > src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java > e0d32de4ebca05d2d6209ff373f8288e2e07b045 > > src/main/java/org/apache/aurora/scheduler/discovery/CommonsServiceDiscoveryModule.java > PRE-CREATION > > src/main/java/org/apache/aurora/scheduler/discovery/CommonsServiceGroupMonitor.java > PRE-CREATION > src/main/java/org/apache/aurora/scheduler/discovery/Credentials.java > 75d58e7851ff2de986de533c35ccca2e4674f611 > > src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceDiscoveryModule.java > e690d1448a900484ee9723bb8cd47def1a6db31d > > src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitor.java > db886df60cddc490d1a45d31474547e351e81908 > > src/main/java/org/apache/aurora/scheduler/discovery/CuratorSingletonService.java > 321bbb3f6243547d31171692191acfebaf494c96 > > src/main/java/org/apache/aurora/scheduler/discovery/FlaggedZooKeeperConfig.java > d5019bf6d94c82c1a6ab7265613822259eca5175 > src/main/java/org/apache/aurora/scheduler/discovery/JsonCodec.java > 9d22b7683e37ed5cb5dbc0289c4f2aa58bc52347 > > src/main/java/org/apache/aurora/scheduler/discovery/ServiceDiscoveryModule.java > b7ca62c11b6eebfa6b6ce00b2cebfdfea47214f3 > > src/main/java/org/apache/aurora/scheduler/discovery/ServiceGroupMon
Re: Review Request 53519: Tear down the observer in case of on unhandled errors
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53519/#review156802
---
Ship it!
Ship It!
- John Sirois
On Nov. 23, 2016, 3:25 p.m., Stephan Erb wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53519/
> ---
>
> (Updated Nov. 23, 2016, 3:25 p.m.)
>
>
> Review request for Aurora, John Sirois and Zameer Manji.
>
>
> Bugs: AURORA-1801
> https://issues.apache.org/jira/browse/AURORA-1801
>
>
> Repository: aurora
>
>
> Description
> ---
>
> I was not able to manually trigger the root cause of AURORA-1801 by altering
> the Mesos filesystem layout. I have therefore adopted the general teardown
> idea.
>
> Example output (using a hardcoded throw):
>
> ```
> Bottle v0.11.6 server starting up (using CherryPyServer())...
> Listening on http://192.168.33.7:1338/
> Hit Ctrl-C to quit.
>
> E1106 23:03:36.722500 8699 exceptional.py:41] Unhandled error in thread
> Thread-1 [TID=8705]. Tearing down.
> Traceback (most recent call last):
> File "apache/thermos/common/exceptional.py", line 37, in _excepting_run
> self.__real_run(*args, **kw)
> File "apache/thermos/observer/task_observer.py", line 135, in run
> self._detector.refresh()
> File "apache/thermos/observer/detector.py", line 74, in refresh
> self._refresh_detectors()
> File "apache/thermos/observer/detector.py", line 58, in _refresh_detectors
> new_paths = set(self._path_detector.get_paths())
> File "apache/aurora/executor/common/path_detector.py", line 35, in get_paths
> return list(set(path for path in iterate() if os.path.exists(path)))
> File "apache/aurora/executor/common/path_detector.py", line 35, in
> return list(set(path for path in iterate() if os.path.exists(path)))
> File "apache/aurora/executor/common/path_detector.py", line 34, in iterate
> raise RuntimeError("Fail on purpose...")
> RuntimeError: Fail on purpose...
> I1106 23:03:42.513900 8728 static_assets.py:34] detecting assets...
> I1106 23:03:42.541809 8728 static_assets.py:38] detected asset: observer.js
> I1106 23:03:42.542799 8728 static_assets.py:38] detected asset:
> bootstrap.css
> I1106 23:03:42.543728 8728 static_assets.py:38] detected asset:
> jquery.pailer.js
> I1106 23:03:42.544576 8728 static_assets.py:38] detected asset: jquery.js
> I1106 23:03:42.548482 8728 static_assets.py:38] detected asset: favicon.ico
> Bottle v0.11.6 server starting up (using CherryPyServer())...
> Listening on http://192.168.33.7:1338/
> Hit Ctrl-C to quit.
> ```
>
>
> Diffs
> -
>
> src/main/python/apache/aurora/tools/thermos_observer.py
> 0a07df7bed902be2b73d2ca3308a02a1e34760d6
>
> Diff: https://reviews.apache.org/r/53519/diff/
>
>
> Testing
> ---
>
> ./pants test.pytest src/{main,test}/python:: -- -v
> aurorabuild observer
>
>
> Thanks,
>
> Stephan Erb
>
>
Re: Review Request 53836: Get pants using the same thrift binary as gradle.
> On Nov. 17, 2016, 4:28 p.m., Joshua Cohen wrote: > > I'm seeing intermittent failures running the e2e tests with this patch > > applied. That's not necessarily alarming, as we've had reports of this on > > master as well, however the behavior in the event of these failures is > > different with this patch applied. See this gist which contains the full > > output: https://gist.github.com/jcohen/ee69208fbca714d3f3437e4039961edf. > > Note the failure about 80% through, followed by some strange compile issues? > > John Sirois wrote: > Can you click on a line number and paste that url? - not seeing it. > > Joshua Cohen wrote: > I think it's just reviewboard counting the period as part of the url? try > this: https://gist.github.com/jcohen/ee69208fbca714d3f3437e4039961edf > > John Sirois wrote: > Ah - my miscommunication. URL worked fine, I thought clicking on a line > number would ammend the url to an anchor that would skip me down to the error > you saw. Moot since the gist is truncated and you have to view it raw to see > the whole thing (as I now realize). > > > So: > ``` > :commons:generateThriftResources UP-TO-DATE > :commons:processResources > :commons:classes > :commons:jar > :compileJava > > /home/vagrant/aurora/src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java:82: > error: cannot find symbol > class WriteAheadStorage extends WriteAheadStorageForwarder implements > ^ > symbol: class WriteAheadStorageForwarder > error: Problem loading existing flags on compile time classpath: > java.io.EOFException: Unexpected end of ZLIB input stream > at > java.util.zip.ZipFile$ZipFileInflaterInputStream.fill(ZipFile.java:417) > at > java.util.zip.InflaterInputStream.read(InflaterInputStream.java:158) > at java.io.FilterInputStream.read(FilterInputStream.java:133) > at sun.nio.cs.StreamDecoder.readBytes(StreamDecoder.java:284) > at sun.nio.cs.StreamDecoder.implRead(StreamDecoder.java:326) > at sun.nio.cs.StreamDecoder.read(StreamDecoder.java:178) > at java.io.InputStreamReader.read(InputStreamReader.java:184) > at com.google.common.io.MultiReader.read(MultiReader.java:55) > at com.google.common.io.LineReader.readLine(LineReader.java:77) > at > com.google.common.io.CharStreams.readLines(CharStreams.java:146) > at > org.apache.aurora.common.args.apt.Configuration.load(Configuration.java:409) > at > org.apache.aurora.common.args.apt.Configuration.load(Configuration.java:325) > at > org.apache.aurora.common.args.apt.CmdLineProcessor$1.get(CmdLineProcessor.java:103) > at > org.apache.aurora.common.args.apt.CmdLineProcessor$1.get(CmdLineProcessor.java:100) > at > com.google.common.base.Suppliers$MemoizingSupplier.get(Suppliers.java:120) > at > org.apache.aurora.common.args.apt.CmdLineProcessor.process(CmdLineProcessor.java:174) > at > com.sun.tools.javac.processing.JavacProcessingEnvironment.callProcessor(JavacProcessingEnvironment.java:794) > at > com.sun.tools.javac.processing.JavacProcessingEnvironment.discoverAndRunProcs(JavacProcessingEnvironment.java:705) > at > com.sun.tools.javac.processing.JavacProcessingEnvironment.access$1800(JavacProcessingEnvironment.java:91) > at > com.sun.tools.javac.processing.JavacProcessingEnvironment$Round.run(JavacProcessingEnvironment.java:1035) > at > com.sun.tools.javac.processing.JavacProcessingEnvironment.doProcessing(JavacProcessingEnvironment.java:1176) > at > com.sun.tools.javac.main.JavaCompiler.processAnnotations(JavaCompiler.java:1170) > at > com.sun.tools.javac.main.JavaCompiler.compile(JavaCompiler.java:856) > at com.sun.tools.javac.main.Main.compile(Main.java:523) > ``` > > Which has to be unrelated to these changes? > > John Sirois wrote: > Basically the error above is an annotation processor trying to read > classpath resources and encountering a jar on the classpath that is truncated. > > Joshua Cohen wrote: > The odd thing is I'm able to reproduce about 50% of the time with a clean > vagrant image (i.e. vagrant destroy before running the e2e tests). But it > only seems to be failing in this particular way with this patch applied. > > Probably we need a broader ticket to investigate the recent e2e flakiness > though, as regardless of this patch there are issues on maste
Re: Review Request 53836: Get pants using the same thrift binary as gradle.
> On Nov. 17, 2016, 4:28 p.m., Joshua Cohen wrote: > > I'm seeing intermittent failures running the e2e tests with this patch > > applied. That's not necessarily alarming, as we've had reports of this on > > master as well, however the behavior in the event of these failures is > > different with this patch applied. See this gist which contains the full > > output: https://gist.github.com/jcohen/ee69208fbca714d3f3437e4039961edf. > > Note the failure about 80% through, followed by some strange compile issues? > > John Sirois wrote: > Can you click on a line number and paste that url? - not seeing it. > > Joshua Cohen wrote: > I think it's just reviewboard counting the period as part of the url? try > this: https://gist.github.com/jcohen/ee69208fbca714d3f3437e4039961edf > > John Sirois wrote: > Ah - my miscommunication. URL worked fine, I thought clicking on a line > number would ammend the url to an anchor that would skip me down to the error > you saw. Moot since the gist is truncated and you have to view it raw to see > the whole thing (as I now realize). > > > So: > ``` > :commons:generateThriftResources UP-TO-DATE > :commons:processResources > :commons:classes > :commons:jar > :compileJava > > /home/vagrant/aurora/src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java:82: > error: cannot find symbol > class WriteAheadStorage extends WriteAheadStorageForwarder implements > ^ > symbol: class WriteAheadStorageForwarder > error: Problem loading existing flags on compile time classpath: > java.io.EOFException: Unexpected end of ZLIB input stream > at > java.util.zip.ZipFile$ZipFileInflaterInputStream.fill(ZipFile.java:417) > at > java.util.zip.InflaterInputStream.read(InflaterInputStream.java:158) > at java.io.FilterInputStream.read(FilterInputStream.java:133) > at sun.nio.cs.StreamDecoder.readBytes(StreamDecoder.java:284) > at sun.nio.cs.StreamDecoder.implRead(StreamDecoder.java:326) > at sun.nio.cs.StreamDecoder.read(StreamDecoder.java:178) > at java.io.InputStreamReader.read(InputStreamReader.java:184) > at com.google.common.io.MultiReader.read(MultiReader.java:55) > at com.google.common.io.LineReader.readLine(LineReader.java:77) > at > com.google.common.io.CharStreams.readLines(CharStreams.java:146) > at > org.apache.aurora.common.args.apt.Configuration.load(Configuration.java:409) > at > org.apache.aurora.common.args.apt.Configuration.load(Configuration.java:325) > at > org.apache.aurora.common.args.apt.CmdLineProcessor$1.get(CmdLineProcessor.java:103) > at > org.apache.aurora.common.args.apt.CmdLineProcessor$1.get(CmdLineProcessor.java:100) > at > com.google.common.base.Suppliers$MemoizingSupplier.get(Suppliers.java:120) > at > org.apache.aurora.common.args.apt.CmdLineProcessor.process(CmdLineProcessor.java:174) > at > com.sun.tools.javac.processing.JavacProcessingEnvironment.callProcessor(JavacProcessingEnvironment.java:794) > at > com.sun.tools.javac.processing.JavacProcessingEnvironment.discoverAndRunProcs(JavacProcessingEnvironment.java:705) > at > com.sun.tools.javac.processing.JavacProcessingEnvironment.access$1800(JavacProcessingEnvironment.java:91) > at > com.sun.tools.javac.processing.JavacProcessingEnvironment$Round.run(JavacProcessingEnvironment.java:1035) > at > com.sun.tools.javac.processing.JavacProcessingEnvironment.doProcessing(JavacProcessingEnvironment.java:1176) > at > com.sun.tools.javac.main.JavaCompiler.processAnnotations(JavaCompiler.java:1170) > at > com.sun.tools.javac.main.JavaCompiler.compile(JavaCompiler.java:856) > at com.sun.tools.javac.main.Main.compile(Main.java:523) > ``` > > Which has to be unrelated to these changes? Basically the error above is an annotation processor trying to read classpath resources and encountering a jar on the classpath that is truncated. - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53836/#review156262 --- On Nov. 16, 2016, 9:46 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53836/ >
Re: Review Request 53836: Get pants using the same thrift binary as gradle.
> On Nov. 17, 2016, 4:28 p.m., Joshua Cohen wrote: > > I'm seeing intermittent failures running the e2e tests with this patch > > applied. That's not necessarily alarming, as we've had reports of this on > > master as well, however the behavior in the event of these failures is > > different with this patch applied. See this gist which contains the full > > output: https://gist.github.com/jcohen/ee69208fbca714d3f3437e4039961edf. > > Note the failure about 80% through, followed by some strange compile issues? > > John Sirois wrote: > Can you click on a line number and paste that url? - not seeing it. > > Joshua Cohen wrote: > I think it's just reviewboard counting the period as part of the url? try > this: https://gist.github.com/jcohen/ee69208fbca714d3f3437e4039961edf Ah - my miscommunication. URL worked fine, I thought clicking on a line number would ammend the url to an anchor that would skip me down to the error you saw. Moot since the gist is truncated and you have to view it raw to see the whole thing (as I now realize). So: ``` :commons:generateThriftResources UP-TO-DATE :commons:processResources :commons:classes :commons:jar :compileJava /home/vagrant/aurora/src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java:82: error: cannot find symbol class WriteAheadStorage extends WriteAheadStorageForwarder implements ^ symbol: class WriteAheadStorageForwarder error: Problem loading existing flags on compile time classpath: java.io.EOFException: Unexpected end of ZLIB input stream at java.util.zip.ZipFile$ZipFileInflaterInputStream.fill(ZipFile.java:417) at java.util.zip.InflaterInputStream.read(InflaterInputStream.java:158) at java.io.FilterInputStream.read(FilterInputStream.java:133) at sun.nio.cs.StreamDecoder.readBytes(StreamDecoder.java:284) at sun.nio.cs.StreamDecoder.implRead(StreamDecoder.java:326) at sun.nio.cs.StreamDecoder.read(StreamDecoder.java:178) at java.io.InputStreamReader.read(InputStreamReader.java:184) at com.google.common.io.MultiReader.read(MultiReader.java:55) at com.google.common.io.LineReader.readLine(LineReader.java:77) at com.google.common.io.CharStreams.readLines(CharStreams.java:146) at org.apache.aurora.common.args.apt.Configuration.load(Configuration.java:409) at org.apache.aurora.common.args.apt.Configuration.load(Configuration.java:325) at org.apache.aurora.common.args.apt.CmdLineProcessor$1.get(CmdLineProcessor.java:103) at org.apache.aurora.common.args.apt.CmdLineProcessor$1.get(CmdLineProcessor.java:100) at com.google.common.base.Suppliers$MemoizingSupplier.get(Suppliers.java:120) at org.apache.aurora.common.args.apt.CmdLineProcessor.process(CmdLineProcessor.java:174) at com.sun.tools.javac.processing.JavacProcessingEnvironment.callProcessor(JavacProcessingEnvironment.java:794) at com.sun.tools.javac.processing.JavacProcessingEnvironment.discoverAndRunProcs(JavacProcessingEnvironment.java:705) at com.sun.tools.javac.processing.JavacProcessingEnvironment.access$1800(JavacProcessingEnvironment.java:91) at com.sun.tools.javac.processing.JavacProcessingEnvironment$Round.run(JavacProcessingEnvironment.java:1035) at com.sun.tools.javac.processing.JavacProcessingEnvironment.doProcessing(JavacProcessingEnvironment.java:1176) at com.sun.tools.javac.main.JavaCompiler.processAnnotations(JavaCompiler.java:1170) at com.sun.tools.javac.main.JavaCompiler.compile(JavaCompiler.java:856) at com.sun.tools.javac.main.Main.compile(Main.java:523) ``` Which has to be unrelated to these changes? - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53836/#review156262 ------- On Nov. 16, 2016, 9:46 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53836/ > --- > > (Updated Nov. 16, 2016, 9:46 p.m.) > > > Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji. > > > Repository: aurora > > > Description > --- > > This required an upgrade to the latest pants dev release to correct > an issue with the setup.py binary packager we use to generate sdists. > > This is for sanity sake, and, once the TODO in > `build-support/thrift/prepare_binary.sh` is addressed, it will also > allow pants-patch-free addition of new platforms (thinking ARM). > > api/src/main/thrift/org/apache/aurora/ge
Re: Review Request 53836: Get pants using the same thrift binary as gradle.
> On Nov. 17, 2016, 2:48 p.m., Zameer Manji wrote:
> > Seems like a lot of patches to enable this behaviour. I'm not opposed but
> > it seems risky.
>
> John Sirois wrote:
> You find everything risky!
>
> Zameer Manji wrote:
> I'm just afraid that the more patches we have, the harder it will be to
> upgrade to the next version of thrift.
>
> I'll let others weigh in here.
Aha - so you meant thrift patches in particular, not all the pants-related
code. Well, these patches merely _fix_ thrift in general, they are not
specific to aurora. Hopefully 10.0.0 wil be better, but Jake would know better
than I.
> On Nov. 17, 2016, 2:48 p.m., Zameer Manji wrote:
> > api/src/main/thrift/org/apache/aurora/gen/BUILD, line 34
> > <https://reviews.apache.org/r/53836/diff/1/?file=1565790#file1565790line34>
> >
> > Can't we have our own 3rdparty thrift target that includes the thrift
> > lib and this prepare binary? Then we can put the dep in one place.
>
> John Sirois wrote:
> I can, but this requires a custom pants plugin (housed as a loose python
> sourcefile in the repo) to expose, say, an `aurora_py_thrift_lib` target.
> Your comments here expressed reservations about that:
> https://reviews.apache.org/r/40219/
> If you re-ack you're in-fact OK with a custom plugin for this, I'll whip
> up diff 2.
>
> Zameer Manji wrote:
> I think in this case, a custom pants plugin will be better, assuming the
> API in this version is stable until pants 2.x
Yes, the API gaurantees are strong with pants since 1.0.0 and the plugin APIs
needed for this will be stable until 2.x.
- John
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53836/#review156248
---
On Nov. 16, 2016, 9:46 p.m., John Sirois wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53836/
> ---
>
> (Updated Nov. 16, 2016, 9:46 p.m.)
>
>
> Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> ---
>
> This required an upgrade to the latest pants dev release to correct
> an issue with the setup.py binary packager we use to generate sdists.
>
> This is for sanity sake, and, once the TODO in
> `build-support/thrift/prepare_binary.sh` is addressed, it will also
> allow pants-patch-free addition of new platforms (thinking ARM).
>
> api/src/main/thrift/org/apache/aurora/gen/BUILD| 3
> +++
> api/src/main/thrift/org/apache/thermos/BUILD | 1 +
> build-support/thrift/.gitignore| 1 +
> build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch| 42
> +--
> build-support/thrift/AURORA-1727.lib.py.setup.py.patch | 45
> +
> {api/src/main/thrift/org/apache/thermos => build-support/thrift}/BUILD | 18
> -
> build-support/thrift/Makefile | 2
> +-
> build-support/thrift/prepare_binary.sh | 68
> ++
> build-support/thrift/thriftw | 12
> +++--
> pants.ini | 7
> +-
> 10 files changed, 158 insertions(+), 41 deletions(-)
>
>
> Diffs
> -
>
> api/src/main/thrift/org/apache/aurora/gen/BUILD
> f4004a3ca36078c6d24991db4beb68903a05652c
> api/src/main/thrift/org/apache/thermos/BUILD
> cb655a2fd35d22f7d7e80c4311742bad763d8614
> build-support/thrift/.gitignore 9a3adb69210ba3dbf3c1f408895561da37e8f4c3
> build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch
> b69e3fef137cd73c6f2b73201463a0705ef8082a
> build-support/thrift/AURORA-1727.lib.py.setup.py.patch PRE-CREATION
> build-support/thrift/BUILD PRE-CREATION
> build-support/thrift/Makefile 48b174ad622288d2738a5fa37bbb72385fcc3a27
> build-support/thrift/prepare_binary.sh PRE-CREATION
> build-support/thrift/thriftw 50d6dfdeb16ca8bf14aaff7aa826e3d69c5e13f0
> pants.ini cecdb277f327f77b2652f76a30fc8d4ffd9ff1db
>
> Diff: https://reviews.apache.org/r/53836/diff/
>
>
> Testing
> ---
>
> Locally green:
> ```
> rm -rf ~/.cache/pants .cache/
> git clean -fdx build-support/thrift
> ./pants clean-all
> ./build-support/jenkins/build.sh
>
> vagrant ssh --command "rm -rf ~/.cache/pants && cd aurora && rm -rf .cache/
> && ./pants clean-all"
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
> ./build-support/python/make-pycharm-virtualenv
> ```
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 53836: Get pants using the same thrift binary as gradle.
> On Nov. 17, 2016, 4:28 p.m., Joshua Cohen wrote:
> > I'm seeing intermittent failures running the e2e tests with this patch
> > applied. That's not necessarily alarming, as we've had reports of this on
> > master as well, however the behavior in the event of these failures is
> > different with this patch applied. See this gist which contains the full
> > output: https://gist.github.com/jcohen/ee69208fbca714d3f3437e4039961edf.
> > Note the failure about 80% through, followed by some strange compile issues?
Can you click on a line number and paste that url? - not seeing it.
- John
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53836/#review156262
-------
On Nov. 16, 2016, 9:46 p.m., John Sirois wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53836/
> ---
>
> (Updated Nov. 16, 2016, 9:46 p.m.)
>
>
> Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> ---
>
> This required an upgrade to the latest pants dev release to correct
> an issue with the setup.py binary packager we use to generate sdists.
>
> This is for sanity sake, and, once the TODO in
> `build-support/thrift/prepare_binary.sh` is addressed, it will also
> allow pants-patch-free addition of new platforms (thinking ARM).
>
> api/src/main/thrift/org/apache/aurora/gen/BUILD| 3
> +++
> api/src/main/thrift/org/apache/thermos/BUILD | 1 +
> build-support/thrift/.gitignore| 1 +
> build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch| 42
> +--
> build-support/thrift/AURORA-1727.lib.py.setup.py.patch | 45
> +
> {api/src/main/thrift/org/apache/thermos => build-support/thrift}/BUILD | 18
> -
> build-support/thrift/Makefile | 2
> +-
> build-support/thrift/prepare_binary.sh | 68
> ++
> build-support/thrift/thriftw | 12
> +++--
> pants.ini | 7
> +-
> 10 files changed, 158 insertions(+), 41 deletions(-)
>
>
> Diffs
> -
>
> api/src/main/thrift/org/apache/aurora/gen/BUILD
> f4004a3ca36078c6d24991db4beb68903a05652c
> api/src/main/thrift/org/apache/thermos/BUILD
> cb655a2fd35d22f7d7e80c4311742bad763d8614
> build-support/thrift/.gitignore 9a3adb69210ba3dbf3c1f408895561da37e8f4c3
> build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch
> b69e3fef137cd73c6f2b73201463a0705ef8082a
> build-support/thrift/AURORA-1727.lib.py.setup.py.patch PRE-CREATION
> build-support/thrift/BUILD PRE-CREATION
> build-support/thrift/Makefile 48b174ad622288d2738a5fa37bbb72385fcc3a27
> build-support/thrift/prepare_binary.sh PRE-CREATION
> build-support/thrift/thriftw 50d6dfdeb16ca8bf14aaff7aa826e3d69c5e13f0
> pants.ini cecdb277f327f77b2652f76a30fc8d4ffd9ff1db
>
> Diff: https://reviews.apache.org/r/53836/diff/
>
>
> Testing
> ---
>
> Locally green:
> ```
> rm -rf ~/.cache/pants .cache/
> git clean -fdx build-support/thrift
> ./pants clean-all
> ./build-support/jenkins/build.sh
>
> vagrant ssh --command "rm -rf ~/.cache/pants && cd aurora && rm -rf .cache/
> && ./pants clean-all"
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
> ./build-support/python/make-pycharm-virtualenv
> ```
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 53836: Get pants using the same thrift binary as gradle.
> On Nov. 17, 2016, 2:48 p.m., Zameer Manji wrote:
> > Seems like a lot of patches to enable this behaviour. I'm not opposed but
> > it seems risky.
You find everything risky!
> On Nov. 17, 2016, 2:48 p.m., Zameer Manji wrote:
> > api/src/main/thrift/org/apache/aurora/gen/BUILD, line 34
> > <https://reviews.apache.org/r/53836/diff/1/?file=1565790#file1565790line34>
> >
> > Can't we have our own 3rdparty thrift target that includes the thrift
> > lib and this prepare binary? Then we can put the dep in one place.
I can, but this requires a custom pants plugin (housed as a loose python
sourcefile in the repo) to expose, say, an `aurora_py_thrift_lib` target. Your
comments here expressed reservations about that:
https://reviews.apache.org/r/40219/
If you re-ack you're in-fact OK with a custom plugin for this, I'll whip up
diff 2.
- John
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53836/#review156248
-------
On Nov. 16, 2016, 9:46 p.m., John Sirois wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53836/
> ---
>
> (Updated Nov. 16, 2016, 9:46 p.m.)
>
>
> Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> ---
>
> This required an upgrade to the latest pants dev release to correct
> an issue with the setup.py binary packager we use to generate sdists.
>
> This is for sanity sake, and, once the TODO in
> `build-support/thrift/prepare_binary.sh` is addressed, it will also
> allow pants-patch-free addition of new platforms (thinking ARM).
>
> api/src/main/thrift/org/apache/aurora/gen/BUILD| 3
> +++
> api/src/main/thrift/org/apache/thermos/BUILD | 1 +
> build-support/thrift/.gitignore| 1 +
> build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch| 42
> +--
> build-support/thrift/AURORA-1727.lib.py.setup.py.patch | 45
> +
> {api/src/main/thrift/org/apache/thermos => build-support/thrift}/BUILD | 18
> -
> build-support/thrift/Makefile | 2
> +-
> build-support/thrift/prepare_binary.sh | 68
> ++
> build-support/thrift/thriftw | 12
> +++--
> pants.ini | 7
> +-
> 10 files changed, 158 insertions(+), 41 deletions(-)
>
>
> Diffs
> -
>
> api/src/main/thrift/org/apache/aurora/gen/BUILD
> f4004a3ca36078c6d24991db4beb68903a05652c
> api/src/main/thrift/org/apache/thermos/BUILD
> cb655a2fd35d22f7d7e80c4311742bad763d8614
> build-support/thrift/.gitignore 9a3adb69210ba3dbf3c1f408895561da37e8f4c3
> build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch
> b69e3fef137cd73c6f2b73201463a0705ef8082a
> build-support/thrift/AURORA-1727.lib.py.setup.py.patch PRE-CREATION
> build-support/thrift/BUILD PRE-CREATION
> build-support/thrift/Makefile 48b174ad622288d2738a5fa37bbb72385fcc3a27
> build-support/thrift/prepare_binary.sh PRE-CREATION
> build-support/thrift/thriftw 50d6dfdeb16ca8bf14aaff7aa826e3d69c5e13f0
> pants.ini cecdb277f327f77b2652f76a30fc8d4ffd9ff1db
>
> Diff: https://reviews.apache.org/r/53836/diff/
>
>
> Testing
> ---
>
> Locally green:
> ```
> rm -rf ~/.cache/pants .cache/
> git clean -fdx build-support/thrift
> ./pants clean-all
> ./build-support/jenkins/build.sh
>
> vagrant ssh --command "rm -rf ~/.cache/pants && cd aurora && rm -rf .cache/
> && ./pants clean-all"
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
> ./build-support/python/make-pycharm-virtualenv
> ```
>
>
> Thanks,
>
> John Sirois
>
>
Review Request 53836: Get pants using the same thrift binary as gradle.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53836/
---
Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji.
Repository: aurora
Description
---
This required an upgrade to the latest pants dev release to correct
an issue with the setup.py binary packager we use to generate sdists.
This is for sanity sake, and, once the TODO in
`build-support/thrift/prepare_binary.sh` is addressed, it will also
allow pants-patch-free addition of new platforms (thinking ARM).
api/src/main/thrift/org/apache/aurora/gen/BUILD| 3 +++
api/src/main/thrift/org/apache/thermos/BUILD | 1 +
build-support/thrift/.gitignore| 1 +
build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch| 42
+--
build-support/thrift/AURORA-1727.lib.py.setup.py.patch | 45
+
{api/src/main/thrift/org/apache/thermos => build-support/thrift}/BUILD | 18
-
build-support/thrift/Makefile | 2 +-
build-support/thrift/prepare_binary.sh | 68
++
build-support/thrift/thriftw | 12
+++--
pants.ini | 7
+-
10 files changed, 158 insertions(+), 41 deletions(-)
Diffs
-
api/src/main/thrift/org/apache/aurora/gen/BUILD
f4004a3ca36078c6d24991db4beb68903a05652c
api/src/main/thrift/org/apache/thermos/BUILD
cb655a2fd35d22f7d7e80c4311742bad763d8614
build-support/thrift/.gitignore 9a3adb69210ba3dbf3c1f408895561da37e8f4c3
build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch
b69e3fef137cd73c6f2b73201463a0705ef8082a
build-support/thrift/AURORA-1727.lib.py.setup.py.patch PRE-CREATION
build-support/thrift/BUILD PRE-CREATION
build-support/thrift/Makefile 48b174ad622288d2738a5fa37bbb72385fcc3a27
build-support/thrift/prepare_binary.sh PRE-CREATION
build-support/thrift/thriftw 50d6dfdeb16ca8bf14aaff7aa826e3d69c5e13f0
pants.ini cecdb277f327f77b2652f76a30fc8d4ffd9ff1db
Diff: https://reviews.apache.org/r/53836/diff/
Testing
---
Locally green:
```
rm -rf ~/.cache/pants .cache/
git clean -fdx build-support/thrift
./pants clean-all
./build-support/jenkins/build.sh
vagrant ssh --command "rm -rf ~/.cache/pants && cd aurora && rm -rf .cache/ &&
./pants clean-all"
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
./build-support/python/make-pycharm-virtualenv
```
Thanks,
John Sirois
Re: Review Request 53794: Update Curator to 2.11.1
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53794/#review155999 --- Ship it! Ship It! - John Sirois On Nov. 15, 2016, 2:22 p.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53794/ > --- > > (Updated Nov. 15, 2016, 2:22 p.m.) > > > Review request for Aurora, John Sirois and Zameer Manji. > > > Repository: aurora > > > Description > --- > > The latest version includes a couple of bug fixes but nothing major worth > calling out. > > Changelogs: > > * > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12314425&version=12336950 > * > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12314425&version=12335828 > > > Diffs > - > > build.gradle bbd5e3aea33817e41c9cf2878df99ba6fe44ffec > > Diff: https://reviews.apache.org/r/53794/diff/ > > > Testing > --- > > ./gradlew -Pq build > ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > > > Thanks, > > Stephan Erb > >
Re: Review Request 53519: WIP: ExceptionalThread that will tear down the entire application on unhandled errors
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53519/#review155098
---
src/main/python/apache/thermos/common/exceptional.py (line 23)
<https://reviews.apache.org/r/53519/#comment224952>
The [standard pep-257
layout](https://www.python.org/dev/peps/pep-0257/#multi-line-docstrings) is
like so:
"""Summary Sentence.
Description paragraphs.
Go here.
"""
src/main/python/apache/thermos/common/exceptional.py (line 42)
<https://reviews.apache.org/r/53519/#comment224953>
Did you contemplate and reject setting `sys.excepthook` to a custom handler
early in main as an alternative?
- John Sirois
On Nov. 6, 2016, 4:26 p.m., Stephan Erb wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53519/
> ---
>
> (Updated Nov. 6, 2016, 4:26 p.m.)
>
>
> Review request for Aurora, John Sirois and Zameer Manji.
>
>
> Bugs: AURORA-1801
> https://issues.apache.org/jira/browse/AURORA-1801
>
>
> Repository: aurora
>
>
> Description
> ---
>
> I was not able to manually trigger the root cause of AURORA-1801 by altering
> the Mesos filesystem layout. I have therefore adopted the general teardown
> idea. This is a proof of concept. Feedback welcome.
>
> Example output (using a hardcoded throw):
>
> ```
> Bottle v0.11.6 server starting up (using CherryPyServer())...
> Listening on http://192.168.33.7:1338/
> Hit Ctrl-C to quit.
>
> E1106 23:03:36.722500 8699 exceptional.py:41] Unhandled error in thread
> Thread-1 [TID=8705]. Tearing down.
> Traceback (most recent call last):
> File "apache/thermos/common/exceptional.py", line 37, in _excepting_run
> self.__real_run(*args, **kw)
> File "apache/thermos/observer/task_observer.py", line 135, in run
> self._detector.refresh()
> File "apache/thermos/observer/detector.py", line 74, in refresh
> self._refresh_detectors()
> File "apache/thermos/observer/detector.py", line 58, in _refresh_detectors
> new_paths = set(self._path_detector.get_paths())
> File "apache/aurora/executor/common/path_detector.py", line 35, in get_paths
> return list(set(path for path in iterate() if os.path.exists(path)))
> File "apache/aurora/executor/common/path_detector.py", line 35, in
> return list(set(path for path in iterate() if os.path.exists(path)))
> File "apache/aurora/executor/common/path_detector.py", line 34, in iterate
> raise RuntimeError("Fail on purpose...")
> RuntimeError: Fail on purpose...
> I1106 23:03:42.513900 8728 static_assets.py:34] detecting assets...
> I1106 23:03:42.541809 8728 static_assets.py:38] detected asset: observer.js
> I1106 23:03:42.542799 8728 static_assets.py:38] detected asset:
> bootstrap.css
> I1106 23:03:42.543728 8728 static_assets.py:38] detected asset:
> jquery.pailer.js
> I1106 23:03:42.544576 8728 static_assets.py:38] detected asset: jquery.js
> I1106 23:03:42.548482 8728 static_assets.py:38] detected asset: favicon.ico
> Bottle v0.11.6 server starting up (using CherryPyServer())...
> Listening on http://192.168.33.7:1338/
> Hit Ctrl-C to quit.
> ```
>
> Questions:
>
> * Is it a good idea to solve the teardown problem like that?
> * Do we want to update all current usages of
> `twitter.common.exceptions.ExceptionalThread`?
> * Where do we put that code so that we can use it in client, executor and
> observer?
>
>
> Diffs
> -
>
> src/main/python/apache/aurora/tools/thermos_observer.py
> 0a07df7bed902be2b73d2ca3308a02a1e34760d6
> src/main/python/apache/thermos/common/BUILD
> 0adabbfa3f0230dae95aca5002c128832916fdd6
> src/main/python/apache/thermos/common/exceptional.py PRE-CREATION
> src/main/python/apache/thermos/observer/task_observer.py
> 1485de8faef52716f11b82a3556064de26c67427
>
> Diff: https://reviews.apache.org/r/53519/diff/
>
>
> Testing
> ---
>
> ./pants test.pytest src/{main,test}/python:: -- -v
> aurorabuild observer
>
>
> Thanks,
>
> Stephan Erb
>
>
Re: Review Request 52665: Populate curator latches with scheduler information
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52665/#review154670
---
Ship it!
Ship It!
- John Sirois
On Oct. 29, 2016, 4:05 a.m., Jing Chen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52665/
> ---
>
> (Updated Oct. 29, 2016, 4:05 a.m.)
>
>
> Review request for Aurora, Joshua Cohen, John Sirois, and Zameer Manji.
>
>
> Bugs: AURORA-1785
> https://issues.apache.org/jira/browse/AURORA-1785
>
>
> Repository: aurora
>
>
> Description
> ---
>
> Populate curator latches with scheduler information
>
>
> Diffs
> -
>
>
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorSingletonService.java
> 4040067a5301f71f35b6719b42fdf0ecbe282404
>
> Diff: https://reviews.apache.org/r/52665/diff/
>
>
> Testing
> ---
>
> verified in vagrant
>
> (CONNECTED) /> get aurora/scheduler/member_000173
> {"serviceEndpoint":{"host":"aurora.local","port":8081},"additionalEndpoints":{"http":{"host":"aurora.local","port":8081}},"status":"ALIVE"}
> (CONNECTED) /> get
> aurora/scheduler/_c_fe00a931-df92-4041-97db-9ef27a56e264-latch-000172
> aurora.local
>
>
> Thanks,
>
> Jing Chen
>
>
Re: Review Request 53102: Clean up README for packaging repo, update release-candidate script to generate the vote email.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53102/#review153730 --- Ship it! Ship It! - John Sirois On Oct. 22, 2016, 11:46 a.m., Joshua Cohen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53102/ > --- > > (Updated Oct. 22, 2016, 11:46 a.m.) > > > Review request for Aurora, Jake Farrell and Stephan Erb. > > > Repository: aurora-packaging > > > Description > --- > > Clean up README for packaging repo, update release-candidate script to > generate the vote email. > > > Diffs > - > > README.md 440aff22cba9da67f4d466e6bc147aee9ae065d2 > build-support/release/release-candidate > c08c88529ec036989032869198da7a21dcf6ac35 > docs/images/bintray-upload.png 5fd92961d07f14e4e14c32c4aae7e293366ccd6c > > Diff: https://reviews.apache.org/r/53102/diff/ > > > Testing > --- > > > Thanks, > > Joshua Cohen > >
Re: Review Request 52915: Upgrade pants to the 1.3.0 dev series.
> On Oct. 23, 2016, 12:12 p.m., John Sirois wrote: > > Sorry for the delay submitting this, e2e didn't actually pass and I futzed > > with this for a while. > > At the end of the day I needed to re-introduce > > `examples/vagrant/mesos_config/etc_mesos-slave/executor_registration_timeout` > > containing `1mins` to get e2e to pass on my machine. > > That's unrelated though so I'll submit this presently and swing back with a > > change to add that. That change is here: https://reviews.apache.org/r/53131/ - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52915/#review153659 ------- On Oct. 15, 2016, 4:42 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52915/ > --- > > (Updated Oct. 15, 2016, 4:42 p.m.) > > > Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji. > > > Repository: aurora > > > Description > --- > > This gets rid of an impossible to work around warning emitted by every > pants invocation and prepares for consuming an upcoming pants change > that will allow Aurora to use the thrift binary selected by > `build-support/thrift/thriftw` consistently everywhere. > > Release notes are here: > http://www.pantsbuild.org/notes-master.html > > pants.ini | 7 +-- > 1 file changed, 1 insertion(+), 6 deletions(-) > > > Diffs > - > > pants.ini 6ed4186780c485f2d023d8e398429e570e9e5a0c > > Diff: https://reviews.apache.org/r/52915/diff/ > > > Testing > --- > > Locally green: > ``` > ./build-support/jenkins/build.sh > ./build-support/python/make-pycharm-virtualenv > ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ``` > > > Thanks, > > John Sirois > >
Review Request 53131: Re-introduce --executor_registration_timeout.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53131/ --- Review request for Aurora, Joshua Cohen and Stephan Erb. Repository: aurora Description --- This stabilizes the slave against image copies that take a long time which is tracked here: https://issues.apache.org/jira/browse/MESOS-6004. examples/vagrant/mesos_config/etc_mesos-slave/executor_registration_timeout | 1 + 1 file changed, 1 insertion(+) Diffs - examples/vagrant/mesos_config/etc_mesos-slave/executor_registration_timeout PRE-CREATION Diff: https://reviews.apache.org/r/53131/diff/ Testing --- This is what allowed me to get a green e2e in https://reviews.apache.org/r/52915/. Thanks, John Sirois
Re: Review Request 52915: Upgrade pants to the 1.3.0 dev series.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52915/#review153659 --- Sorry for the delay submitting this, e2e didn't actually pass and I futzed with this for a while. At the end of the day I needed to re-introduce `examples/vagrant/mesos_config/etc_mesos-slave/executor_registration_timeout` containing `1mins` to get e2e to pass on my machine. That's unrelated though so I'll submit this presently and swing back with a change to add that. - John Sirois On Oct. 15, 2016, 4:42 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52915/ > --- > > (Updated Oct. 15, 2016, 4:42 p.m.) > > > Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji. > > > Repository: aurora > > > Description > --- > > This gets rid of an impossible to work around warning emitted by every > pants invocation and prepares for consuming an upcoming pants change > that will allow Aurora to use the thrift binary selected by > `build-support/thrift/thriftw` consistently everywhere. > > Release notes are here: > http://www.pantsbuild.org/notes-master.html > > pants.ini | 7 +-- > 1 file changed, 1 insertion(+), 6 deletions(-) > > > Diffs > - > > pants.ini 6ed4186780c485f2d023d8e398429e570e9e5a0c > > Diff: https://reviews.apache.org/r/52915/diff/ > > > Testing > --- > > Locally green: > ``` > ./build-support/jenkins/build.sh > ./build-support/python/make-pycharm-virtualenv > ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ``` > > > Thanks, > > John Sirois > >
Re: Review Request 52921: In immutable Thrift structs, check identity before comparing fields.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52921/#review152893
---
Ship it!
Ship It!
- John Sirois
On Oct. 16, 2016, 5:04 p.m., Stephan Erb wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52921/
> ---
>
> (Updated Oct. 16, 2016, 5:04 p.m.)
>
>
> Review request for Aurora and John Sirois.
>
>
> Repository: aurora
>
>
> Description
> ---
>
> I saw THRIFT-3868 and thought we could apply the same micro-optimization
> as well. Details: https://github.com/apache/thrift/pull/1106
>
> Example of a generated equals method (in ITaskConfig):
>
> @Override
> public boolean equals(Object o) {
> if (this == o) {
> return true;
> }
> if (!(o instanceof ITaskConfig)) {
> return false;
> }
> ITaskConfig other = (ITaskConfig) o;
> return Objects.equals(job, other.job)
> && Objects.equals(owner, other.owner)
> && Objects.equals(isService, other.isService)
> && Objects.equals(numCpus, other.numCpus)
> && Objects.equals(ramMb, other.ramMb)
> && Objects.equals(diskMb, other.diskMb)
> && Objects.equals(priority, other.priority)
> && Objects.equals(maxTaskFailures, other.maxTaskFailures)
> && Objects.equals(production, other.production)
> && Objects.equals(tier, other.tier)
> && Objects.equals(resources, other.resources)
> && Objects.equals(constraints, other.constraints)
> && Objects.equals(requestedPorts, other.requestedPorts)
> && Objects.equals(mesosFetcherUris, other.mesosFetcherUris)
> && Objects.equals(taskLinks, other.taskLinks)
> && Objects.equals(contactEmail, other.contactEmail)
> && Objects.equals(executorConfig, other.executorConfig)
> && Objects.equals(metadata, other.metadata)
> && Objects.equals(container, other.container);
> }
>
>
> Diffs
> -
>
> src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py
> 7c281800b00b973351659ecacd5b7f6e55e46bba
>
> Diff: https://reviews.apache.org/r/52921/diff/
>
>
> Testing
> ---
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Stephan Erb
>
>
Re: Review Request 52921: In immutable Thrift structs, check identity before comparing fields.
> On Oct. 17, 2016, 9:41 a.m., Joshua Cohen wrote:
> > Should we also add:
> >
> > if (o == null) {
> > return false;
> > }
> >
> > ?
> >
> > Curious if we're able to see a difference in benchmarks from this change?
It would be a bit of black magic if that were significantly faster than the
!instanceof check.
- John
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52921/#review152889
---
On Oct. 16, 2016, 5:04 p.m., Stephan Erb wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52921/
> ---
>
> (Updated Oct. 16, 2016, 5:04 p.m.)
>
>
> Review request for Aurora and John Sirois.
>
>
> Repository: aurora
>
>
> Description
> ---
>
> I saw THRIFT-3868 and thought we could apply the same micro-optimization
> as well. Details: https://github.com/apache/thrift/pull/1106
>
> Example of a generated equals method (in ITaskConfig):
>
> @Override
> public boolean equals(Object o) {
> if (this == o) {
> return true;
> }
> if (!(o instanceof ITaskConfig)) {
> return false;
> }
> ITaskConfig other = (ITaskConfig) o;
> return Objects.equals(job, other.job)
> && Objects.equals(owner, other.owner)
> && Objects.equals(isService, other.isService)
> && Objects.equals(numCpus, other.numCpus)
> && Objects.equals(ramMb, other.ramMb)
> && Objects.equals(diskMb, other.diskMb)
> && Objects.equals(priority, other.priority)
> && Objects.equals(maxTaskFailures, other.maxTaskFailures)
> && Objects.equals(production, other.production)
> && Objects.equals(tier, other.tier)
> && Objects.equals(resources, other.resources)
> && Objects.equals(constraints, other.constraints)
> && Objects.equals(requestedPorts, other.requestedPorts)
> && Objects.equals(mesosFetcherUris, other.mesosFetcherUris)
> && Objects.equals(taskLinks, other.taskLinks)
> && Objects.equals(contactEmail, other.contactEmail)
> && Objects.equals(executorConfig, other.executorConfig)
> && Objects.equals(metadata, other.metadata)
> && Objects.equals(container, other.container);
> }
>
>
> Diffs
> -
>
> src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py
> 7c281800b00b973351659ecacd5b7f6e55e46bba
>
> Diff: https://reviews.apache.org/r/52921/diff/
>
>
> Testing
> ---
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Stephan Erb
>
>
Re: Review Request 52915: Upgrade pants to the 1.3.0 dev series.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52915/#review152791 --- The pants bug this avoids solving is documented over here: https://github.com/pantsbuild/pants/issues/3956 - John Sirois On Oct. 15, 2016, 4:42 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52915/ > --- > > (Updated Oct. 15, 2016, 4:42 p.m.) > > > Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji. > > > Repository: aurora > > > Description > --- > > This gets rid of an impossible to work around warning emitted by every > pants invocation and prepares for consuming an upcoming pants change > that will allow Aurora to use the thrift binary selected by > `build-support/thrift/thriftw` consistently everywhere. > > Release notes are here: > http://www.pantsbuild.org/notes-master.html > > pants.ini | 7 +-- > 1 file changed, 1 insertion(+), 6 deletions(-) > > > Diffs > - > > pants.ini 6ed4186780c485f2d023d8e398429e570e9e5a0c > > Diff: https://reviews.apache.org/r/52915/diff/ > > > Testing > --- > > Locally green: > ``` > ./build-support/jenkins/build.sh > ./build-support/python/make-pycharm-virtualenv > ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ``` > > > Thanks, > > John Sirois > >
Review Request 52915: Upgrade pants to the 1.3.0 dev series.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52915/ --- Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji. Repository: aurora Description --- This gets rid of an impossible to work around warning emitted by every pants invocation and prepares for consuming an upcoming pants change that will allow Aurora to use the thrift binary selected by `build-support/thrift/thriftw` consistently everywhere. Release notes are here: http://www.pantsbuild.org/notes-master.html pants.ini | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) Diffs - pants.ini 6ed4186780c485f2d023d8e398429e570e9e5a0c Diff: https://reviews.apache.org/r/52915/diff/ Testing --- Locally green: ``` ./build-support/jenkins/build.sh ./build-support/python/make-pycharm-virtualenv ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh ``` Thanks, John Sirois
Re: Review Request 52790: Upgrade pystachio to 0.8.3
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52790/#review152349 --- Ship it! Ship It! - John Sirois On Oct. 12, 2016, 11:28 a.m., Santhosh Kumar Shanmugham wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52790/ > --- > > (Updated Oct. 12, 2016, 11:28 a.m.) > > > Review request for Aurora, George Sirois, Joshua Cohen, and Zameer Manji. > > > Repository: aurora > > > Description > --- > > Upgrade pystachio to 0.8.3 > > > Diffs > - > > 3rdparty/python/requirements.txt 398338966ba715fae523ee4d12afbba4c0eb6bbb > > Diff: https://reviews.apache.org/r/52790/diff/ > > > Testing > --- > > src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > > > Thanks, > > Santhosh Kumar Shanmugham > >
Re: Review Request 52777: Use Gradle installDist task rather than installApp.
> On Oct. 12, 2016, 4:41 a.m., John Sirois wrote: > > Your testing done says this is enough on the aurora-packaging side, but on > > the [aurora > > side](https://github.com/apache/aurora/blob/master/build.gradle#L24) the > > installed plugin probably also needs to be changed from from 'application' > > to 'distribition' at which point I'm not immediately sure how the [main > > class name](https://github.com/apache/aurora/blob/master/build.gradle#L586) > > is configured in the new regime (maybe the same). > > Stephan Erb wrote: > The changelog says "The installApp task is no longer created by the > application plugin (use installDist instead)." > > I read this as: > > * it is still valid to use the application plugin > * if used, the application plugin will note define the 'installApp" ask > anymore Strange but apparently true. Thanks for reading more closely than I! - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52777/#review152291 --- On Oct. 12, 2016, 4:13 a.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52777/ > ------- > > (Updated Oct. 12, 2016, 4:13 a.m.) > > > Review request for Aurora and John Sirois. > > > Repository: aurora-packaging > > > Description > --- > > The latter was deprecated and finally removed in Gradle 3.0: > > "The installApp task is no longer created by the application plugin > (use installDist instead)." > > https://docs.gradle.org/3.0/release-notes > > > Diffs > - > > specs/debian/rules fc74d1c8c0fd3251828dd2d237ac4ee950a41e42 > > Diff: https://reviews.apache.org/r/52777/diff/ > > > Testing > --- > > ./build-artifact.sh builder/rpm/centos-7 snapshot.tar.gz 0.17-snapshot > ./build-artifact.sh builder/deb/ubuntu-trusty snapshot.tar.gz 0.17-snapshot > ./build-artifact.sh builder/deb/debian-jessie snapshot.tar.gz 0.17-snapshot > > > Thanks, > > Stephan Erb > >
Re: Review Request 52777: Use Gradle installDist task rather than installApp.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52777/#review152291 --- Ship it! Your testing done says this is enough on the aurora-packaging side, but on the [aurora side](https://github.com/apache/aurora/blob/master/build.gradle#L24) the installed plugin probably also needs to be changed from from 'application' to 'distribition' at which point I'm not immediately sure how the [main class name](https://github.com/apache/aurora/blob/master/build.gradle#L586) is configured in the new regime (maybe the same). - John Sirois On Oct. 12, 2016, 4:13 a.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52777/ > --- > > (Updated Oct. 12, 2016, 4:13 a.m.) > > > Review request for Aurora and John Sirois. > > > Repository: aurora-packaging > > > Description > --- > > The latter was deprecated and finally removed in Gradle 3.0: > > "The installApp task is no longer created by the application plugin > (use installDist instead)." > > https://docs.gradle.org/3.0/release-notes > > > Diffs > - > > specs/debian/rules fc74d1c8c0fd3251828dd2d237ac4ee950a41e42 > > Diff: https://reviews.apache.org/r/52777/diff/ > > > Testing > --- > > ./build-artifact.sh builder/rpm/centos-7 snapshot.tar.gz 0.17-snapshot > ./build-artifact.sh builder/deb/ubuntu-trusty snapshot.tar.gz 0.17-snapshot > ./build-artifact.sh builder/deb/debian-jessie snapshot.tar.gz 0.17-snapshot > > > Thanks, > > Stephan Erb > >
Re: Review Request 52739: Update mybatis, h2, and jmh to their latest versions.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52739/#review152141 --- Ship it! Ship It! - John Sirois On Oct. 11, 2016, 9:11 a.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52739/ > --- > > (Updated Oct. 11, 2016, 9:11 a.m.) > > > Review request for Aurora, John Sirois and Zameer Manji. > > > Repository: aurora > > > Description > --- > > I have skimmed the changelogs and the following h2 entries stood out: > > * "Garbage collection of unused chunks should now be faster." > * "Improve performance of cleaning up temp tables - patch from Eric > Faulhaber." > > Running our micro-benchmarks did not indicate any note-worthy performance > difference. > > Full changelogs: > > * http://www.h2database.com/html/changelog.html > * https://github.com/mybatis/mybatis-3/releases > > > Diffs > - > > build.gradle 3cd083ccc72ed9dfb4adc491e9ab5a40d7762879 > config/findbugs/excludeFilter.xml 1c311d321897674504368dcbea9fae3735536f98 > > Diff: https://reviews.apache.org/r/52739/diff/ > > > Testing > --- > > ./gradlew -Pq build > > > Thanks, > > Stephan Erb > >
Re: Review Request 52640: Upgrade to pants 1.2.0rc0.
> On Oct. 10, 2016, 5:31 p.m., John Sirois wrote:
> > I'll submit this tomorrow afternoon if I hear nothing from Zameer by then.
>
> Zameer Manji wrote:
> Sorry for the late shipit, I reviewed this previously and forgot to press
> the button.
No worries - thanks Zameer.
- John
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52640/#review152077
---
On Oct. 7, 2016, 10:34 p.m., John Sirois wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52640/
> ---
>
> (Updated Oct. 7, 2016, 10:34 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> ---
>
> This pulls in support for OSX Sierra.
> Release notes are here: http://pantsbuild.github.io/notes-master.html
>
> pants.ini | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
> Diffs
> -
>
> pants.ini 0ddc0fc4d7805142c61d0aa2da8c6a2ce5b70e7f
>
> Diff: https://reviews.apache.org/r/52640/diff/
>
>
> Testing
> ---
>
> Locally green:
> ```
> ./pants test src/{main,test}/python:: -- -v
> ./build-support/release/make-python-sdists
> vagrant ssh --command 'aurorabuild admin_client client executor observer'
> ```
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 52640: Upgrade to pants 1.2.0rc0.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52640/#review152077
---
I'll submit this tomorrow afternoon if I hear nothing from Zameer by then.
- John Sirois
On Oct. 7, 2016, 10:34 p.m., John Sirois wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52640/
> ---
>
> (Updated Oct. 7, 2016, 10:34 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> ---
>
> This pulls in support for OSX Sierra.
> Release notes are here: http://pantsbuild.github.io/notes-master.html
>
> pants.ini | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
> Diffs
> -
>
> pants.ini 0ddc0fc4d7805142c61d0aa2da8c6a2ce5b70e7f
>
> Diff: https://reviews.apache.org/r/52640/diff/
>
>
> Testing
> ---
>
> Locally green:
> ```
> ./pants test src/{main,test}/python:: -- -v
> ./build-support/release/make-python-sdists
> vagrant ssh --command 'aurorabuild admin_client client executor observer'
> ```
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 52665: Populate curator latches with scheduler information
> On Oct. 9, 2016, 6:49 p.m., John Sirois wrote:
> > src/main/java/org/apache/aurora/scheduler/discovery/CuratorSingletonService.java,
> > line 142
> > <https://reviews.apache.org/r/52665/diff/1/?file=1528674#file1528674line142>
> >
> > This was in my example code, but I don't think its the right answer for
> > the contents of the node; ie: Zameer was gunning for a unique ip such that
> > he could cat the contents of the `*-latch-*` nodes and from that learn
> > which machines were contending for leadership. As things stand, that
> > execercise might net the set `{127.0.0.1, 127.0.0.1, 127.0.0.1}` - not
> > terribly helpful!
> >
> > You may just need to enumerate all non-loopback addresses, like ~so:
> > ```
> > $ cat Address.java
> > import java.net.InetAddress;
> > import java.net.InterfaceAddress;
> > import java.net.NetworkInterface;
> > import java.util.Enumeration;
> >
> > public class Address {
> > public static void main(String[] args) throws Exception {
> > for (Enumeration interfaces =
> > NetworkInterface.getNetworkInterfaces();
> > interfaces.hasMoreElements();) {
> > NetworkInterface networkInterface = interfaces.nextElement();
> > if (!networkInterface.isLoopback()) {
> > System.out.printf("Enumerating addresses of interface %s:%n",
> > networkInterface.getName());
> > for (InterfaceAddress address:
> > networkInterface.getInterfaceAddresses()) {
> > InetAddress inetAddress = address.getAddress();
> > System.out.printf("\t%s: %s%n",
> > inetAddress.getCanonicalHostName(), inetAddress.getHostAddress());
> > }
> > }
> > }
> > }
> > }
> > $ javac Address.java
> > $ java -cp . Address
> > Enumerating addresses of interface vboxnet0:
> > fe80:0:0:0:800:27ff:fe00:0%vboxnet0:
> > fe80:0:0:0:800:27ff:fe00:0%vboxnet0
> > 192.168.33.1: 192.168.33.1
> > Enumerating addresses of interface docker0:
> > 172.17.0.1: 172.17.0.1
> > Enumerating addresses of interface wlp3s0:
> > fe80:0:0:0:183:9e44:9c10:%wlp3s0:
> > fe80:0:0:0:183:9e44:9c10:%wlp3s0
> > 10.0.3.132: 10.0.3.132
> > ```
> >
> > I'm not sure of a more foolproof way pre-serverset-join to get useful
> > addresses regardless of machine setup. Joshua and Zameer likely have better
> > ideas.
>
> Zameer Manji wrote:
> I commented on the ticket, that I think it would be best if the latches
> just had the ServerSet information. If we did that, we would avoid these
> issues.
That may be slightly easier said than done since election preceeds joining (its
a singleton set).
- John
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52665/#review151949
-------
On Oct. 9, 2016, 2:43 a.m., Jing Chen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52665/
> ---
>
> (Updated Oct. 9, 2016, 2:43 a.m.)
>
>
> Review request for Aurora, Joshua Cohen, John Sirois, and Zameer Manji.
>
>
> Bugs: AURORA-1785
> https://issues.apache.org/jira/browse/AURORA-1785
>
>
> Repository: aurora
>
>
> Description
> ---
>
> Populate curator latches with scheduler information
>
>
> Diffs
> -
>
>
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceDiscoveryModule.java
> e690d1448a900484ee9723bb8cd47def1a6db31d
>
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorSingletonService.java
> 4040067a5301f71f35b6719b42fdf0ecbe282404
>
> Diff: https://reviews.apache.org/r/52665/diff/
>
>
> Testing
> ---
>
> verified in vagrant
>
> (CONNECTED) /> get /aurora/scheduler/member_51
> {"serviceEndpoint":{"host":"aurora.local","port":8081},"additionalEndpoints":{"http":{"host":"aurora.local","port":8081}},"status":"ALIVE"}
> (CONNECTED) /> get
> /aurora/scheduler/_c_5c25d2a0-7070-4fde-a50d-78364e763e9c-latch-50
> 127.0.0.1
>
>
> Thanks,
>
> Jing Chen
>
>
Re: Review Request 52665: Populate curator latches with scheduler information
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52665/#review151949
---
src/main/java/org/apache/aurora/scheduler/discovery/CuratorSingletonService.java
(line 142)
<https://reviews.apache.org/r/52665/#comment220611>
This was in my example code, but I don't think its the right answer for the
contents of the node; ie: Zameer was gunning for a unique ip such that he could
cat the contents of the `*-latch-*` nodes and from that learn which machines
were contending for leadership. As things stand, that execercise might net the
set `{127.0.0.1, 127.0.0.1, 127.0.0.1}` - not terribly helpful!
You may just need to enumerate all non-loopback addresses, like ~so:
```
$ cat Address.java
import java.net.InetAddress;
import java.net.InterfaceAddress;
import java.net.NetworkInterface;
import java.util.Enumeration;
public class Address {
public static void main(String[] args) throws Exception {
for (Enumeration interfaces =
NetworkInterface.getNetworkInterfaces();
interfaces.hasMoreElements();) {
NetworkInterface networkInterface = interfaces.nextElement();
if (!networkInterface.isLoopback()) {
System.out.printf("Enumerating addresses of interface %s:%n",
networkInterface.getName());
for (InterfaceAddress address:
networkInterface.getInterfaceAddresses()) {
InetAddress inetAddress = address.getAddress();
System.out.printf("\t%s: %s%n",
inetAddress.getCanonicalHostName(), inetAddress.getHostAddress());
}
}
}
}
}
$ javac Address.java
$ java -cp . Address
Enumerating addresses of interface vboxnet0:
fe80:0:0:0:800:27ff:fe00:0%vboxnet0: fe80:0:0:0:800:27ff:fe00:0%vboxnet0
192.168.33.1: 192.168.33.1
Enumerating addresses of interface docker0:
172.17.0.1: 172.17.0.1
Enumerating addresses of interface wlp3s0:
fe80:0:0:0:183:9e44:9c10:%wlp3s0:
fe80:0:0:0:183:9e44:9c10:%wlp3s0
10.0.3.132: 10.0.3.132
```
I'm not sure of a more foolproof way pre-serverset-join to get useful
addresses regardless of machine setup. Joshua and Zameer likely have better
ideas.
- John Sirois
On Oct. 9, 2016, 2:43 a.m., Jing Chen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52665/
> ---
>
> (Updated Oct. 9, 2016, 2:43 a.m.)
>
>
> Review request for Aurora, Joshua Cohen, John Sirois, and Zameer Manji.
>
>
> Bugs: AURORA-1785
> https://issues.apache.org/jira/browse/AURORA-1785
>
>
> Repository: aurora
>
>
> Description
> ---
>
> Populate curator latches with scheduler information
>
>
> Diffs
> -
>
>
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceDiscoveryModule.java
> e690d1448a900484ee9723bb8cd47def1a6db31d
>
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorSingletonService.java
> 4040067a5301f71f35b6719b42fdf0ecbe282404
>
> Diff: https://reviews.apache.org/r/52665/diff/
>
>
> Testing
> ---
>
> verified in vagrant
>
> (CONNECTED) /> get /aurora/scheduler/member_51
> {"serviceEndpoint":{"host":"aurora.local","port":8081},"additionalEndpoints":{"http":{"host":"aurora.local","port":8081}},"status":"ALIVE"}
> (CONNECTED) /> get
> /aurora/scheduler/_c_5c25d2a0-7070-4fde-a50d-78364e763e9c-latch-50
> 127.0.0.1
>
>
> Thanks,
>
> Jing Chen
>
>
Re: Review Request 52669: Move the H2 database off heap.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52669/#review151943 --- I don't think the micro-benchmarks show anything really. The error bars for the off-heap are generally larger than the values themselves! I imagine jmh is simply not the right tool for testing off-heap. I too though am interested in real-world feedback. - John Sirois On Oct. 9, 2016, 4:35 p.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52669/ > --- > > (Updated Oct. 9, 2016, 4:35 p.m.) > > > Review request for Aurora, David McLaughlin, John Sirois, and Zameer Manji. > > > Repository: aurora > > > Description > --- > > This experiment is inspired by David's comment: "I don’t think the > storage engine matters. We just need to be able to offload it from > the Scheduler JVM. The problem with H2 isn’t SQL or anything else, > it’s the GC pressure." > > Basic idea is to switch to another storage backend: "nioMemFS stores > data outside of the VM's heap - useful for large memory DBs without > incurring GC costs" (http://www.h2database.com/html/advanced.html) > > Our micro-benchmarks look promising > > Current Master (on-heap db): > > TaskStoreBenchmarks.DBFetchTasksBenchmark.run N/A > N/A N/A 1 thrpt5 83399.727 ± 13513.406 ops/s > TaskStoreBenchmarks.DBFetchTasksBenchmark.run N/A > N/A N/A 5 thrpt5 38674.517 ± 26893.133 ops/s > TaskStoreBenchmarks.DBFetchTasksBenchmark.run N/A > N/A N/A 10 thrpt5 0.080 ± 0.037 ops/s > TaskStoreBenchmarks.MemFetchTasksBenchmark.runN/A > N/A N/A 1 thrpt5251.447 ± 234.791 ops/s > TaskStoreBenchmarks.MemFetchTasksBenchmark.runN/A > N/A N/A 5 thrpt5 49.090 ±43.262 ops/s > TaskStoreBenchmarks.MemFetchTasksBenchmark.runN/A > N/A N/A 10 thrpt5 25.915 ±11.143 ops/s > UpdateStoreBenchmarks.JobDetailsBenchmark.run N/A > 1000 N/A N/A thrpt5106.155 ±62.439 ops/s > UpdateStoreBenchmarks.JobDetailsBenchmark.run N/A > 5000 N/A N/A thrpt5 29.003 ±24.196 ops/s > UpdateStoreBenchmarks.JobDetailsBenchmark.run N/A >1 N/A N/A thrpt5 15.572 ± 8.836 ops/s > UpdateStoreBenchmarks.JobInstructionsBenchmark.run 1 > N/A N/A N/A thrpt5 26.939 ±25.415 ops/s > UpdateStoreBenchmarks.JobInstructionsBenchmark.run 10 > N/A N/A N/A thrpt5 28.599 ±26.182 ops/s > UpdateStoreBenchmarks.JobInstructionsBenchmark.run100 > N/A N/A N/A thrpt5 22.560 ± 9.864 ops/s > UpdateStoreBenchmarks.JobInstructionsBenchmark.run 1000 > N/A N/A N/A thrpt5 17.537 ± 6.562 ops/s > UpdateStoreBenchmarks.JobUpdateMetadataBenchmark.run N/A > N/A 10 N/A thrpt5 28.917 ±12.473 ops/s > UpdateStoreBenchmarks.JobUpdateMetadataBenchmark.run N/A > N/A 100 N/A thrpt5 23.867 ± 8.910 ops/s > UpdateStoreBenchmarks.JobUpdateMetadataBenchmark.run N/A > N/A1000 N/A thrpt5 25.711 ±22.488 ops/s > UpdateStoreBenchmarks.JobUpdateMetadataBenchmark.run N/A > N/A 1 N/A thrpt5 11.045 ± 6.477 ops/s > > This patch (off-heap db): > > Benchmark (instanceOverrides) > (instances) (metadata) (numTasks) Mode Cnt Score Error Units > TaskStoreBenchmarks.DBFetchTasksBenchmark.run N/A > N/A N/A 1 thrpt5 81368.994 ± 32366.724 ops/s > TaskStoreBenchmarks.DBFetchTasksBenchmark.run N/A > N/A N/A 5 thrpt5 68668.801 ± 10404.233 ops/s > TaskStoreBenchmarks.DBFetchTasksBenchmark.run
Re: Review Request 52640: Upgrade to pants 1.2.0rc0.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52640/
---
(Updated Oct. 7, 2016, 10:34 p.m.)
Review request for Aurora, Joshua Cohen and Zameer Manji.
Changes
---
Bump up to 1.2.0rc0 - hot off the presses.
pants.ini | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Summary (updated)
-
Upgrade to pants 1.2.0rc0.
Repository: aurora
Description
---
This pulls in support for OSX Sierra.
Release notes are here: http://pantsbuild.github.io/notes-master.html
pants.ini | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Diffs (updated)
-
pants.ini 0ddc0fc4d7805142c61d0aa2da8c6a2ce5b70e7f
Diff: https://reviews.apache.org/r/52640/diff/
Testing
---
Locally green:
```
./pants test src/{main,test}/python:: -- -v
./build-support/release/make-python-sdists
vagrant ssh --command 'aurorabuild admin_client client executor observer'
```
Thanks,
John Sirois
Review Request 52640: Upgrade to pants 1.2.0dev12.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52640/
---
Review request for Aurora, Joshua Cohen and Zameer Manji.
Repository: aurora
Description
---
This pulls in support for OSX Sierra.
Release notes are here: http://pantsbuild.github.io/notes-master.html
pants.ini | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Diffs
-
pants.ini 0ddc0fc4d7805142c61d0aa2da8c6a2ce5b70e7f
Diff: https://reviews.apache.org/r/52640/diff/
Testing
---
Locally green:
```
./pants test src/{main,test}/python:: -- -v
./build-support/release/make-python-sdists
vagrant ssh --command 'aurorabuild admin_client client executor observer'
```
Thanks,
John Sirois
Re: Review Request 52609: Manually configure the private network interface in Vagrant
> On Oct. 6, 2016, 1:10 p.m., John Sirois wrote: > > I added myself as a reviewer since I'm running Vagrant 1.8.6. I'll have > > time to confirm your issue and fix later today and have some feedback for > > you by tomorrow latest. I can confirm both the failure to autoprovision under 1.8.6 and the old Vagrantfile and the fix. Thanks for addressing this Andrew! - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52609/#review151705 --- On Oct. 6, 2016, 12:14 p.m., Andrew Jorgensen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52609/ > --- > > (Updated Oct. 6, 2016, 12:14 p.m.) > > > Review request for Aurora and John Sirois. > > > Repository: aurora > > > Description > --- > > I am not sure of the specifics of why this happens but on vagrant 1.8.6 the > network interface does not come up correctly and the private_network is > attached to the `eth0` nat interface rather than the host-only interface. I > tried a number of different parameters but none of them were able to > configure the network appropriately. This change manually configures the > static ip so that it is connected to the correct adapter. Without this change > I could not access the aurora web interface. > > > Diffs > - > > Vagrantfile 5d6e1b29f28a57cb9a06df5f673c4b56697fbfcb > > Diff: https://reviews.apache.org/r/52609/diff/ > > > Testing > --- > > Ran `vagrant up` and tried to visit http://192.168.33.7:8081 according to the > steps here: > http://aurora.apache.org/documentation/latest/getting-started/vagrant/ > > > Thanks, > > Andrew Jorgensen > >
