Re: Review Request 42328: Add metric for counting uncaught exceptions in async executor.

2016-01-15 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42328/#review114724
---

Ship it!



NEWS (line 26)


It this really news-worthy? I'd expect it to be a low noise feature related 
summary. IMO, adding a stat does not clear that bar.


- Maxim Khutornenko


On Jan. 14, 2016, 11:58 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42328/
> ---
> 
> (Updated Jan. 14, 2016, 11:58 p.m.)
> 
> 
> Review request for Aurora, John Sirois and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1582
> https://issues.apache.org/jira/browse/AURORA-1582
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add metric "async_executor_uncaught_exceptions" for tracking uncaught 
> exceptions in async executor.
> 
> 
> Diffs
> -
> 
>   NEWS 809077fe6f689e726204519f93fdabb89a4bb5e5 
>   src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java 
> 5facc048bc21adb124cb761647553afa9f8ab724 
> 
> Diff: https://reviews.apache.org/r/42328/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 42328: Add metric for counting uncaught exceptions in async executor.

2016-01-15 Thread Zameer Manji 


> On Jan. 15, 2016, 9:42 a.m., Maxim Khutornenko wrote:
> > NEWS, line 26
> > 
> >
> > It this really news-worthy? I'd expect it to be a low noise feature 
> > related summary. IMO, adding a stat does not clear that bar.

Noted, I'll remove it from NEWS.


- Zameer


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42328/#review114724
---


On Jan. 14, 2016, 3:58 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42328/
> ---
> 
> (Updated Jan. 14, 2016, 3:58 p.m.)
> 
> 
> Review request for Aurora, John Sirois and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1582
> https://issues.apache.org/jira/browse/AURORA-1582
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add metric "async_executor_uncaught_exceptions" for tracking uncaught 
> exceptions in async executor.
> 
> 
> Diffs
> -
> 
>   NEWS 809077fe6f689e726204519f93fdabb89a4bb5e5 
>   src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java 
> 5facc048bc21adb124cb761647553afa9f8ab724 
> 
> Diff: https://reviews.apache.org/r/42328/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 42328: Add metric for counting uncaught exceptions in async executor.

2016-01-15 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42328/#review114748
---


Master (b563679) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Jan. 15, 2016, 6:28 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42328/
> ---
> 
> (Updated Jan. 15, 2016, 6:28 p.m.)
> 
> 
> Review request for Aurora, John Sirois and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1582
> https://issues.apache.org/jira/browse/AURORA-1582
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add metric "async_executor_uncaught_exceptions" for tracking uncaught 
> exceptions in async executor.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java 
> 5facc048bc21adb124cb761647553afa9f8ab724 
> 
> Diff: https://reviews.apache.org/r/42328/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 42328: Add metric for counting uncaught exceptions in async executor.

2016-01-15 Thread Zameer Manji 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42328/
---

(Updated Jan. 15, 2016, 10:28 a.m.)


Review request for Aurora, John Sirois and Maxim Khutornenko.


Changes
---

Remove NEWS entry.


Bugs: AURORA-1582
https://issues.apache.org/jira/browse/AURORA-1582


Repository: aurora


Description
---

Add metric "async_executor_uncaught_exceptions" for tracking uncaught 
exceptions in async executor.


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java 
5facc048bc21adb124cb761647553afa9f8ab724 

Diff: https://reviews.apache.org/r/42328/diff/


Testing
---


Thanks,

Zameer Manji

Re: Review Request 42328: Add metric for counting uncaught exceptions in async executor.

2016-01-14 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42328/#review114608
---


Master (4dff5da) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Jan. 14, 2016, 11:27 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42328/
> ---
> 
> (Updated Jan. 14, 2016, 11:27 p.m.)
> 
> 
> Review request for Aurora, John Sirois and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1582
> https://issues.apache.org/jira/browse/AURORA-1582
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add metric "async_executor_uncaught_exceptions" for tracking uncaught 
> exceptions in async executor.
> 
> 
> Diffs
> -
> 
>   NEWS 809077fe6f689e726204519f93fdabb89a4bb5e5 
>   src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java 
> 5facc048bc21adb124cb761647553afa9f8ab724 
> 
> Diff: https://reviews.apache.org/r/42328/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 42328: Add metric for counting uncaught exceptions in async executor.

2016-01-14 Thread John Sirois 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42328/#review114611
---

Ship it!


Ship It!

- John Sirois


On Jan. 14, 2016, 4:58 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42328/
> ---
> 
> (Updated Jan. 14, 2016, 4:58 p.m.)
> 
> 
> Review request for Aurora, John Sirois and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1582
> https://issues.apache.org/jira/browse/AURORA-1582
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add metric "async_executor_uncaught_exceptions" for tracking uncaught 
> exceptions in async executor.
> 
> 
> Diffs
> -
> 
>   NEWS 809077fe6f689e726204519f93fdabb89a4bb5e5 
>   src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java 
> 5facc048bc21adb124cb761647553afa9f8ab724 
> 
> Diff: https://reviews.apache.org/r/42328/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 42328: Add metric for counting uncaught exceptions in async executor.

2016-01-14 Thread Zameer Manji 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42328/
---

(Updated Jan. 14, 2016, 3:58 p.m.)


Review request for Aurora, John Sirois and Maxim Khutornenko.


Changes
---

John's feedback.


Bugs: AURORA-1582
https://issues.apache.org/jira/browse/AURORA-1582


Repository: aurora


Description
---

Add metric "async_executor_uncaught_exceptions" for tracking uncaught 
exceptions in async executor.


Diffs (updated)
-

  NEWS 809077fe6f689e726204519f93fdabb89a4bb5e5 
  src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java 
5facc048bc21adb124cb761647553afa9f8ab724 

Diff: https://reviews.apache.org/r/42328/diff/


Testing
---


Thanks,

Zameer Manji

Re: Review Request 42328: Add metric for counting uncaught exceptions in async executor.

2016-01-14 Thread John Sirois 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42328/#review114607
---

Ship it!



src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java (line 40)


final


- John Sirois


On Jan. 14, 2016, 4:27 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42328/
> ---
> 
> (Updated Jan. 14, 2016, 4:27 p.m.)
> 
> 
> Review request for Aurora, John Sirois and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1582
> https://issues.apache.org/jira/browse/AURORA-1582
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add metric "async_executor_uncaught_exceptions" for tracking uncaught 
> exceptions in async executor.
> 
> 
> Diffs
> -
> 
>   NEWS 809077fe6f689e726204519f93fdabb89a4bb5e5 
>   src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java 
> 5facc048bc21adb124cb761647553afa9f8ab724 
> 
> Diff: https://reviews.apache.org/r/42328/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 42328: Add metric for counting uncaught exceptions in async executor.

2016-01-14 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42328/#review114613
---


Master (4dff5da) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Jan. 14, 2016, 11:58 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42328/
> ---
> 
> (Updated Jan. 14, 2016, 11:58 p.m.)
> 
> 
> Review request for Aurora, John Sirois and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1582
> https://issues.apache.org/jira/browse/AURORA-1582
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add metric "async_executor_uncaught_exceptions" for tracking uncaught 
> exceptions in async executor.
> 
> 
> Diffs
> -
> 
>   NEWS 809077fe6f689e726204519f93fdabb89a4bb5e5 
>   src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java 
> 5facc048bc21adb124cb761647553afa9f8ab724 
> 
> Diff: https://reviews.apache.org/r/42328/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>