Re: Review Request 55902: Capture health check output
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55902/#review163020 --- Ship it! Ship It! - Zameer Manji On Jan. 25, 2017, 10:47 a.m., Dmitriy Shirchenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55902/ > --- > > (Updated Jan. 25, 2017, 10:47 a.m.) > > > Review request for Aurora, Joshua Cohen and Zameer Manji. > > > Bugs: AURORA-1881 > https://issues.apache.org/jira/browse/AURORA-1881 > > > Repository: aurora > > > Description > --- > > Users really could really benefit from seeing the output of the shell health > check failure, so plumbing through the output. > > > Diffs > - > > src/main/python/apache/aurora/common/health_check/shell.py > 58470a48a7a14092eeb8837aada9e358c6922c93 > src/test/python/apache/aurora/common/health_check/test_shell.py > 792ef40028cda112db5b93c4cc37e305937bc351 > > Diff: https://reviews.apache.org/r/55902/diff/ > > > Testing > --- > > added unit tests > e2e tests > screenshot attached. > > > File Attachments > > > Updated screenshot > > https://reviews.apache.org/media/uploaded/files/2017/01/25/90d6ff4f-84f9-4b4d-9b3d-56dadf7027ae__Screen_Shot_2017-01-24_at_5.32.08_PM.png > > > Thanks, > > Dmitriy Shirchenko > >
Re: Review Request 55902: Capture health check output
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55902/#review163009 --- Ship it! Master (52ddce9) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Jan. 25, 2017, 6:47 p.m., Dmitriy Shirchenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55902/ > --- > > (Updated Jan. 25, 2017, 6:47 p.m.) > > > Review request for Aurora, Joshua Cohen and Zameer Manji. > > > Bugs: AURORA-1881 > https://issues.apache.org/jira/browse/AURORA-1881 > > > Repository: aurora > > > Description > --- > > Users really could really benefit from seeing the output of the shell health > check failure, so plumbing through the output. > > > Diffs > - > > src/main/python/apache/aurora/common/health_check/shell.py > 58470a48a7a14092eeb8837aada9e358c6922c93 > src/test/python/apache/aurora/common/health_check/test_shell.py > 792ef40028cda112db5b93c4cc37e305937bc351 > > Diff: https://reviews.apache.org/r/55902/diff/ > > > Testing > --- > > added unit tests > e2e tests > screenshot attached. > > > File Attachments > > > Updated screenshot > > https://reviews.apache.org/media/uploaded/files/2017/01/25/90d6ff4f-84f9-4b4d-9b3d-56dadf7027ae__Screen_Shot_2017-01-24_at_5.32.08_PM.png > > > Thanks, > > Dmitriy Shirchenko > >
Re: Review Request 55902: Capture health check output
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55902/#review163004 --- @ReviewBot retry - Dmitriy Shirchenko On Jan. 25, 2017, 6:47 p.m., Dmitriy Shirchenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55902/ > --- > > (Updated Jan. 25, 2017, 6:47 p.m.) > > > Review request for Aurora, Joshua Cohen and Zameer Manji. > > > Bugs: AURORA-1881 > https://issues.apache.org/jira/browse/AURORA-1881 > > > Repository: aurora > > > Description > --- > > Users really could really benefit from seeing the output of the shell health > check failure, so plumbing through the output. > > > Diffs > - > > src/main/python/apache/aurora/common/health_check/shell.py > 58470a48a7a14092eeb8837aada9e358c6922c93 > src/test/python/apache/aurora/common/health_check/test_shell.py > 792ef40028cda112db5b93c4cc37e305937bc351 > > Diff: https://reviews.apache.org/r/55902/diff/ > > > Testing > --- > > added unit tests > e2e tests > screenshot attached. > > > File Attachments > > > Updated screenshot > > https://reviews.apache.org/media/uploaded/files/2017/01/25/90d6ff4f-84f9-4b4d-9b3d-56dadf7027ae__Screen_Shot_2017-01-24_at_5.32.08_PM.png > > > Thanks, > > Dmitriy Shirchenko > >
Re: Review Request 55902: Capture health check output
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55902/#review162997 --- Master (52ddce9) is red with this patch. ./build-support/jenkins/build.sh entered_patchers = [] exc_info = (, AssertionError('"Command \'failed\' returned non-zero exit st"Command \'failed\' returned non-zero exit status 1 with output:\\nNo file."',), ) patching = arg = [1m@wraps(func)[0m [1mdef patched(*args, **keywargs):[0m [1m# don't use a with here (backwards compatability with Python 2.4)[0m [1mextra_args = [][0m [1mentered_patchers = [][0m [1m[0m [1m# can't use try...except...finally because of Python 2.4[0m [1m# compatibility[0m [1mexc_info = tuple()[0m [1mtry:[0m [1mtry:[0m [1mfor patching in patched.patchings:[0m [1marg = patching.__enter__()[0m [1m entered_patchers.append(patching)[0m [1mif patching.attribute_name is not None:[0m [1mkeywargs.update(arg)[0m [1melif patching.new is DEFAULT:[0m [1mextra_args.append(arg)[0m [1m[0m [1margs += tuple(extra_args)[0m [1m> return func(*args, **keywargs)[0m .pants.d/python-setup/chroots/e015bd17ba7e01e2f429ca36d8f0d3f36744c41b/.deps/mock-1.0.1-py2-none-any.whl/mock.py:1201: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ src/test/python/apache/aurora/common/health_check/test_shell.py:56: in test_health_check_failed [1mself.assertEqual(msg, "Command 'failed' returned non-zero exit status 1 with output:\nNo file.")[0m [1m[31mE AssertionError: "Command 'failed' returned non-zero exit status 1 with output 'No file.'" != "Command 'failed' returned non-zero exit status 1 with output:\nNo file."[0m generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/aaf4d108c31293299a0839bdc404a91802f80937.xml [1m[31m 1 failed, 774 passed, 7 skipped, 1 warnings in 295.34 seconds [0m FAILURE 18:54:33 05:42 [complete][31m FAILURE[0m I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Jan. 25, 2017, 6:47 p.m., Dmitriy Shirchenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55902/ > --- > > (Updated Jan. 25, 2017, 6:47 p.m.) > > > Review request for Aurora, Joshua Cohen and Zameer Manji. > > > Bugs: AURORA-1881 > https://issues.apache.org/jira/browse/AURORA-1881 > > > Repository: aurora > > > Description > --- > > Users really could really benefit from seeing the output of the shell health > check failure, so plumbing through the output. > > > Diffs > - > > src/main/python/apache/aurora/common/health_check/shell.py > 58470a48a7a14092eeb8837aada9e358c6922c93 > src/test/python/apache/aurora/common/health_check/test_shell.py > 792ef40028cda112db5b93c4cc37e305937bc351 > > Diff: https://reviews.apache.org/r/55902/diff/ > > > Testing > --- > > added unit tests > e2e tests > screenshot attached. > > > File Attachments > > > Updated screenshot > > https://reviews.apache.org/media/uploaded/files/2017/01/25/90d6ff4f-84f9-4b4d-9b3d-56dadf7027ae__Screen_Shot_2017-01-24_at_5.32.08_PM.png > > > Thanks, > > Dmitriy Shirchenko > >
Re: Review Request 55902: Capture health check output
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55902/ --- (Updated Jan. 25, 2017, 6:47 p.m.) Review request for Aurora, Joshua Cohen and Zameer Manji. Bugs: AURORA-1881 https://issues.apache.org/jira/browse/AURORA-1881 Repository: aurora Description --- Users really could really benefit from seeing the output of the shell health check failure, so plumbing through the output. Diffs (updated) - src/main/python/apache/aurora/common/health_check/shell.py 58470a48a7a14092eeb8837aada9e358c6922c93 src/test/python/apache/aurora/common/health_check/test_shell.py 792ef40028cda112db5b93c4cc37e305937bc351 Diff: https://reviews.apache.org/r/55902/diff/ Testing --- added unit tests e2e tests screenshot attached. File Attachments Updated screenshot https://reviews.apache.org/media/uploaded/files/2017/01/25/90d6ff4f-84f9-4b4d-9b3d-56dadf7027ae__Screen_Shot_2017-01-24_at_5.32.08_PM.png Thanks, Dmitriy Shirchenko
Re: Review Request 55902: Capture health check output
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55902/#review162993 --- Ship it! lgtm pending a clean reviewbot run. - Joshua Cohen On Jan. 25, 2017, 6:37 p.m., Dmitriy Shirchenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55902/ > --- > > (Updated Jan. 25, 2017, 6:37 p.m.) > > > Review request for Aurora, Joshua Cohen and Zameer Manji. > > > Bugs: AURORA-1881 > https://issues.apache.org/jira/browse/AURORA-1881 > > > Repository: aurora > > > Description > --- > > Users really could really benefit from seeing the output of the shell health > check failure, so plumbing through the output. > > > Diffs > - > > src/main/python/apache/aurora/common/health_check/shell.py > 58470a48a7a14092eeb8837aada9e358c6922c93 > src/test/python/apache/aurora/common/health_check/test_shell.py > 792ef40028cda112db5b93c4cc37e305937bc351 > > Diff: https://reviews.apache.org/r/55902/diff/ > > > Testing > --- > > added unit tests > e2e tests > screenshot attached. > > > File Attachments > > > Updated screenshot > > https://reviews.apache.org/media/uploaded/files/2017/01/25/90d6ff4f-84f9-4b4d-9b3d-56dadf7027ae__Screen_Shot_2017-01-24_at_5.32.08_PM.png > > > Thanks, > > Dmitriy Shirchenko > >
Re: Review Request 55902: Capture health check output
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55902/ --- (Updated Jan. 25, 2017, 6:37 p.m.) Review request for Aurora, Joshua Cohen and Zameer Manji. Bugs: AURORA-1881 https://issues.apache.org/jira/browse/AURORA-1881 Repository: aurora Description --- Users really could really benefit from seeing the output of the shell health check failure, so plumbing through the output. Diffs (updated) - src/main/python/apache/aurora/common/health_check/shell.py 58470a48a7a14092eeb8837aada9e358c6922c93 src/test/python/apache/aurora/common/health_check/test_shell.py 792ef40028cda112db5b93c4cc37e305937bc351 Diff: https://reviews.apache.org/r/55902/diff/ Testing --- added unit tests e2e tests screenshot attached. File Attachments Updated screenshot https://reviews.apache.org/media/uploaded/files/2017/01/25/90d6ff4f-84f9-4b4d-9b3d-56dadf7027ae__Screen_Shot_2017-01-24_at_5.32.08_PM.png Thanks, Dmitriy Shirchenko
Re: Review Request 55902: Capture health check output
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55902/#review162896 --- Master (52ddce9) is red with this patch. ./build-support/jenkins/build.sh virtualenv-15.0.2/virtualenv_support/wheel-0.29.0-py2.py3-none-any.whl + touch virtualenv-15.0.2/BOOTSTRAPPED + popd /home/jenkins/jenkins-slave/workspace/AuroraBot + exec /usr/bin/python2.7 /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/virtualenv-15.0.2/virtualenv.py --no-download /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv New python executable in /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/bin/python2.7 Also creating executable in /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/bin/python Installing setuptools, pip, wheel...done. Collecting isort==4.0.0 Downloading isort-4.0.0-py2.py3-none-any.whl Installing collected packages: isort Successfully installed isort-4.0.0 You are using pip version 8.1.2, however version 9.0.1 is available. You should consider upgrading via the 'pip install --upgrade pip' command. ERROR: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/health_check/shell.py Imports are incorrectly sorted. --- /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/health_check/shell.py:before 2017-01-25 01:41:27.669006 +++ /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/health_check/shell.py:after 2017-01-25 01:45:51.877003 @@ -16,6 +16,7 @@ import sys from subprocess32 import STDOUT + # Recommended pattern for Python 2 and 3 support from https://github.com/google/python-subprocess32 # Backport which adds bug fixes and timeout support for Python 2.7 if os.name == 'posix' and sys.version_info[0] < 3: ERROR: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/common/health_check/test_shell.py Imports are incorrectly sorted. --- /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/common/health_check/test_shell.py:before 2017-01-25 01:41:27.669006 +++ /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/common/health_check/test_shell.py:after 2017-01-25 01:45:52.368200 @@ -17,10 +17,10 @@ import unittest import mock +from subprocess32 import STDOUT from apache.aurora.common.health_check.shell import ShellHealthCheck -from subprocess32 import STDOUT # Recommended pattern for Python 2 and 3 support from https://github.com/google/python-subprocess32 # Backport which adds bug fixes and timeout support for Python 2.7 if os.name == 'posix' and sys.version_info[0] < 3: I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Jan. 25, 2017, 1:34 a.m., Dmitriy Shirchenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55902/ > --- > > (Updated Jan. 25, 2017, 1:34 a.m.) > > > Review request for Aurora, Joshua Cohen and Zameer Manji. > > > Bugs: AURORA-1881 > https://issues.apache.org/jira/browse/AURORA-1881 > > > Repository: aurora > > > Description > --- > > Users really could really benefit from seeing the output of the shell health > check failure, so plumbing through the output. > > > Diffs > - > > src/main/python/apache/aurora/common/health_check/shell.py > 58470a48a7a14092eeb8837aada9e358c6922c93 > src/test/python/apache/aurora/common/health_check/test_shell.py > 792ef40028cda112db5b93c4cc37e305937bc351 > > Diff: https://reviews.apache.org/r/55902/diff/ > > > Testing > --- > > added unit tests > e2e tests > screenshot attached. > > > File Attachments > > > Updated screenshot > > https://reviews.apache.org/media/uploaded/files/2017/01/25/90d6ff4f-84f9-4b4d-9b3d-56dadf7027ae__Screen_Shot_2017-01-24_at_5.32.08_PM.png > > > Thanks, > > Dmitriy Shirchenko > >
Re: Review Request 55902: Capture health check output
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55902/#review162894 --- @ReviewBot retry - Dmitriy Shirchenko On Jan. 25, 2017, 1:34 a.m., Dmitriy Shirchenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55902/ > --- > > (Updated Jan. 25, 2017, 1:34 a.m.) > > > Review request for Aurora, Joshua Cohen and Zameer Manji. > > > Bugs: AURORA-1881 > https://issues.apache.org/jira/browse/AURORA-1881 > > > Repository: aurora > > > Description > --- > > Users really could really benefit from seeing the output of the shell health > check failure, so plumbing through the output. > > > Diffs > - > > src/main/python/apache/aurora/common/health_check/shell.py > 58470a48a7a14092eeb8837aada9e358c6922c93 > src/test/python/apache/aurora/common/health_check/test_shell.py > 792ef40028cda112db5b93c4cc37e305937bc351 > > Diff: https://reviews.apache.org/r/55902/diff/ > > > Testing > --- > > added unit tests > e2e tests > screenshot attached. > > > File Attachments > > > Updated screenshot > > https://reviews.apache.org/media/uploaded/files/2017/01/25/90d6ff4f-84f9-4b4d-9b3d-56dadf7027ae__Screen_Shot_2017-01-24_at_5.32.08_PM.png > > > Thanks, > > Dmitriy Shirchenko > >
Re: Review Request 55902: Capture health check output
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55902/ --- (Updated Jan. 25, 2017, 1:34 a.m.) Review request for Aurora, Joshua Cohen and Zameer Manji. Changes --- Updating screenshot. Bugs: AURORA-1881 https://issues.apache.org/jira/browse/AURORA-1881 Repository: aurora Description --- Users really could really benefit from seeing the output of the shell health check failure, so plumbing through the output. Diffs - src/main/python/apache/aurora/common/health_check/shell.py 58470a48a7a14092eeb8837aada9e358c6922c93 src/test/python/apache/aurora/common/health_check/test_shell.py 792ef40028cda112db5b93c4cc37e305937bc351 Diff: https://reviews.apache.org/r/55902/diff/ Testing --- added unit tests e2e tests screenshot attached. File Attachments (updated) Updated screenshot https://reviews.apache.org/media/uploaded/files/2017/01/25/90d6ff4f-84f9-4b4d-9b3d-56dadf7027ae__Screen_Shot_2017-01-24_at_5.32.08_PM.png Thanks, Dmitriy Shirchenko
Re: Review Request 55902: Capture health check output
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55902/ --- (Updated Jan. 25, 2017, 1:34 a.m.) Review request for Aurora, Joshua Cohen and Zameer Manji. Bugs: AURORA-1881 https://issues.apache.org/jira/browse/AURORA-1881 Repository: aurora Description --- Users really could really benefit from seeing the output of the shell health check failure, so plumbing through the output. Diffs - src/main/python/apache/aurora/common/health_check/shell.py 58470a48a7a14092eeb8837aada9e358c6922c93 src/test/python/apache/aurora/common/health_check/test_shell.py 792ef40028cda112db5b93c4cc37e305937bc351 Diff: https://reviews.apache.org/r/55902/diff/ Testing --- added unit tests e2e tests screenshot attached. File Attachments (updated) Screenshot https://reviews.apache.org/media/uploaded/files/2017/01/25/c4e69424-71ad-4d71-b1f4-895bc6a7821e__Screen_Shot_2017-01-24_at_5.03.06_PM.png Updated screenshot https://reviews.apache.org/media/uploaded/files/2017/01/25/90d6ff4f-84f9-4b4d-9b3d-56dadf7027ae__Screen_Shot_2017-01-24_at_5.32.08_PM.png Thanks, Dmitriy Shirchenko
Re: Review Request 55902: Capture health check output
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55902/#review162892 --- Master (52ddce9) is red with this patch. ./build-support/jenkins/build.sh --- * What went wrong: Execution failed for task ':analyzeReport'. > Test coverage missing for org/apache/aurora/scheduler/storage/db/views/DbImage Test coverage missing for org/apache/aurora/scheduler/http/Mname Test coverage missing for org/apache/aurora/scheduler/http/Services Test coverage missing for org/apache/aurora/scheduler/http/QuitCallback Test coverage missing for org/apache/aurora/scheduler/http/Cron Test coverage missing for org/apache/aurora/scheduler/app/VolumeParser Test coverage missing for org/apache/aurora/scheduler/configuration/executor/ExecutorSettingsLoader$Schema Test coverage missing for org/apache/aurora/scheduler/configuration/executor/ExecutorSettingsLoader Test coverage missing for org/apache/aurora/scheduler/pruning/TaskHistoryPruner$1 Test coverage missing for org/apache/aurora/scheduler/stats/AsyncStatsModule$OfferAdapter Test coverage missing for org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule Test coverage missing for org/apache/aurora/scheduler/http/api/security/ShiroUtils Test coverage missing for org/apache/aurora/scheduler/http/api/security/HttpSecurityModule$3 Test coverage missing for org/apache/aurora/scheduler/http/api/security/HttpSecurityModule$2 Test coverage missing for org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParser Test coverage missing for org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule Test coverage missing for org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule$1 Test coverage missing for org/apache/aurora/scheduler/log/mesos/MesosLog$LogStream Test coverage missing for org/apache/aurora/scheduler/log/mesos/MesosLog Test coverage missing for org/apache/aurora/scheduler/log/mesos/MesosLog$LogStream$OpStats Test coverage missing for org/apache/aurora/scheduler/log/mesos/MesosLog$LogStream$1 Test coverage missing for org/apache/aurora/scheduler/log/mesos/MesosLog$LogStream$LogEntry Test coverage missing for org/apache/aurora/scheduler/log/mesos/MesosLog$LogStream$LogPosition Test coverage missing for org/apache/aurora/scheduler/discovery/CommonsServiceDiscoveryModule Test coverage missing for org/apache/aurora/scheduler/reconciliation/KillRetry$KillAttempt Test coverage missing for org/apache/aurora/scheduler/preemptor/Preemptor$PreemptorImpl Test coverage missing for org/apache/aurora/scheduler/events/PubsubEvent$DriverDisconnected Test coverage missing for org/apache/aurora/scheduler/events/PubsubEvent$DriverRegistered Test coverage missing for org/apache/aurora/scheduler/storage/db/typehandlers/VolumeModeTypeHandler * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. == BUILD FAILED Total time: 6 mins 8.393 secs I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Jan. 25, 2017, 1:08 a.m., Dmitriy Shirchenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55902/ > --- > > (Updated Jan. 25, 2017, 1:08 a.m.) > > > Review request for Aurora, Joshua Cohen and Zameer Manji. > > > Bugs: AURORA-1881 > https://issues.apache.org/jira/browse/AURORA-1881 > > > Repository: aurora > > > Description > --- > > Users really could really benefit from seeing the output of the shell health > check failure, so plumbing through the output. > > > Diffs > - > > src/main/python/apache/aurora/common/health_check/shell.py > 58470a48a7a14092eeb8837aada9e358c6922c93 > src/test/python/apache/aurora/common/health_check/test_shell.py > 792ef40028cda112db5b93c4cc37e305937bc351 > > Diff: https://reviews.apache.org/r/55902/diff/ > > > Testing > --- > > added unit tests > e2e tests > screenshot attached. > > > File Attachments > > > Screenshot > > https://reviews.apache.org/media/uploaded/files/2017/01/25/c4e69424-71ad-4d71-b1f4-895bc6a7821e__Screen_Shot_2017-01-24_at_5.03.06_PM.png > > > Thanks, > > Dmitriy Shirchenko > >