Re: Review Request 34568: run tasks as user that match aurora-role
> On Jan. 9, 2016, 4:43 p.m., Benjamin Staffin wrote: > > Any chance of getting this merged? It might be a surprise to some users, > > since right now there's no requirement for matching role accounts to exist > > inside the docker images, but with the right documentation about how to > > retain the "always root in the container" behavior it ought to be ok. > > Bill Farner wrote: > Unless Bhuvan is willing to revisit, you might have to take over the > patch (which i would welcome). I would like to see a few changes to accept > this: > - enabled with a flag to the executor at least for the first release > - e2e test case verifying the expected behavior Here's my take on it, currently sans tests: https://reviews.apache.org/r/43027/ - Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34568/#review113633 --- On Nov. 2, 2015, 10:26 a.m., Bhuvan Arumugam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34568/ > --- > > (Updated Nov. 2, 2015, 10:26 a.m.) > > > Review request for Aurora, Kevin Sweeney and Zameer Manji. > > > Bugs: AURORA-1237 > https://issues.apache.org/jira/browse/AURORA-1237 > > > Repository: aurora > > > Description > --- > > The tasks inside container should run as user that match aurora-role, if > --nosetuid option is not passed for executor. > > Testing Done: > ./pants test.pytest --no-fast --options='--verbose' src/test/python:: > > Bugs closed: AURORA-1237 > > > Diffs > - > > src/main/python/apache/aurora/executor/thermos_task_runner.py 8ce9168 > > Diff: https://reviews.apache.org/r/34568/diff/ > > > Testing > --- > > > Thanks, > > Bhuvan Arumugam > >
Re: Review Request 34568: run tasks as user that match aurora-role
> On Jan. 9, 2016, 4:43 p.m., Benjamin Staffin wrote: > > Any chance of getting this merged? It might be a surprise to some users, > > since right now there's no requirement for matching role accounts to exist > > inside the docker images, but with the right documentation about how to > > retain the "always root in the container" behavior it ought to be ok. Unless Bhuvan is willing to revisit, you might have to take over the patch (which i would welcome). I would like to see a few changes to accept this: - enabled with a flag to the executor at least for the first release - e2e test case verifying the expected behavior - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34568/#review113633 --- On Nov. 2, 2015, 10:26 a.m., Bhuvan Arumugam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34568/ > --- > > (Updated Nov. 2, 2015, 10:26 a.m.) > > > Review request for Aurora, Kevin Sweeney and Zameer Manji. > > > Bugs: AURORA-1237 > https://issues.apache.org/jira/browse/AURORA-1237 > > > Repository: aurora > > > Description > --- > > The tasks inside container should run as user that match aurora-role, if > --nosetuid option is not passed for executor. > > Testing Done: > ./pants test.pytest --no-fast --options='--verbose' src/test/python:: > > Bugs closed: AURORA-1237 > > > Diffs > - > > src/main/python/apache/aurora/executor/thermos_task_runner.py 8ce9168 > > Diff: https://reviews.apache.org/r/34568/diff/ > > > Testing > --- > > > Thanks, > > Bhuvan Arumugam > >
Re: Review Request 34568: run tasks as user that match aurora-role
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34568/#review113633 --- Any chance of getting this merged? It might be a surprise to some users, since right now there's no requirement for matching role accounts to exist inside the docker images, but with the right documentation about how to retain the "always root in the container" behavior it ought to be ok. - Benjamin Staffin On Nov. 2, 2015, 10:26 a.m., Bhuvan Arumugam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34568/ > --- > > (Updated Nov. 2, 2015, 10:26 a.m.) > > > Review request for Aurora, Kevin Sweeney and Zameer Manji. > > > Bugs: AURORA-1237 > https://issues.apache.org/jira/browse/AURORA-1237 > > > Repository: aurora > > > Description > --- > > The tasks inside container should run as user that match aurora-role, if > --nosetuid option is not passed for executor. > > Testing Done: > ./pants test.pytest --no-fast --options='--verbose' src/test/python:: > > Bugs closed: AURORA-1237 > > > Diffs > - > > src/main/python/apache/aurora/executor/thermos_task_runner.py 8ce9168 > > Diff: https://reviews.apache.org/r/34568/diff/ > > > Testing > --- > > > Thanks, > > Bhuvan Arumugam > >
Re: Review Request 34568: run tasks as user that match aurora-role
> On May 22, 2015, 1:59 a.m., Zameer Manji wrote: > > This change lgtm but I will need to ask you to do the following things: > > 1. Remove wfarner from this review as currently he is on vacation. I > > suggest adding kevints or jcohen. > > 2. Assign the ticket linked to this review to yourself and link to this > > review in the comments of the ticket. > > 3. Confirm the e2e tests work with this change. @zmanji #1 and #2 done. #3, it works locally. i'm retrying the build, with a review comment. - Bhuvan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34568/#review84851 --- On May 21, 2015, 9:54 p.m., Bhuvan Arumugam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34568/ > --- > > (Updated May 21, 2015, 9:54 p.m.) > > > Review request for Aurora, Bill Farner and Zameer Manji. > > > Bugs: AURORA-1237 > https://issues.apache.org/jira/browse/AURORA-1237 > > > Repository: aurora > > > Description > --- > > The tasks inside container should run as user that match aurora-role, if > --nosetuid option is not passed for executor. > > Testing Done: > ./pants test.pytest --no-fast --options='--verbose' src/test/python:: > > Bugs closed: AURORA-1237 > > > Diffs > - > > src/main/python/apache/aurora/executor/thermos_task_runner.py 8ce9168 > > Diff: https://reviews.apache.org/r/34568/diff/ > > > Testing > --- > > > Thanks, > > Bhuvan Arumugam > >
Re: Review Request 34568: run tasks as user that match aurora-role
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34568/#review86109 --- Master (73ceeb2) is green with this patch. ./build-support/jenkins/build.sh However, it appears that it might lack test coverage. I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On May 21, 2015, 9:54 p.m., Bhuvan Arumugam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34568/ > --- > > (Updated May 21, 2015, 9:54 p.m.) > > > Review request for Aurora, Bill Farner and Zameer Manji. > > > Bugs: AURORA-1237 > https://issues.apache.org/jira/browse/AURORA-1237 > > > Repository: aurora > > > Description > --- > > The tasks inside container should run as user that match aurora-role, if > --nosetuid option is not passed for executor. > > Testing Done: > ./pants test.pytest --no-fast --options='--verbose' src/test/python:: > > Bugs closed: AURORA-1237 > > > Diffs > - > > src/main/python/apache/aurora/executor/thermos_task_runner.py 8ce9168 > > Diff: https://reviews.apache.org/r/34568/diff/ > > > Testing > --- > > > Thanks, > > Bhuvan Arumugam > >
Re: Review Request 34568: run tasks as user that match aurora-role
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34568/#review86104 --- @ReviewBot retry - Bhuvan Arumugam On May 21, 2015, 9:54 p.m., Bhuvan Arumugam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34568/ > --- > > (Updated May 21, 2015, 9:54 p.m.) > > > Review request for Aurora, Bill Farner and Zameer Manji. > > > Bugs: AURORA-1237 > https://issues.apache.org/jira/browse/AURORA-1237 > > > Repository: aurora > > > Description > --- > > The tasks inside container should run as user that match aurora-role, if > --nosetuid option is not passed for executor. > > Testing Done: > ./pants test.pytest --no-fast --options='--verbose' src/test/python:: > > Bugs closed: AURORA-1237 > > > Diffs > - > > src/main/python/apache/aurora/executor/thermos_task_runner.py 8ce9168 > > Diff: https://reviews.apache.org/r/34568/diff/ > > > Testing > --- > > > Thanks, > > Bhuvan Arumugam > >
Re: Review Request 34568: run tasks as user that match aurora-role
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34568/#review84851 --- This change lgtm but I will need to ask you to do the following things: 1. Remove wfarner from this review as currently he is on vacation. I suggest adding kevints or jcohen. 2. Assign the ticket linked to this review to yourself and link to this review in the comments of the ticket. 3. Confirm the e2e tests work with this change. - Zameer Manji On May 21, 2015, 2:54 p.m., Bhuvan Arumugam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34568/ > --- > > (Updated May 21, 2015, 2:54 p.m.) > > > Review request for Aurora, Bill Farner and Zameer Manji. > > > Bugs: AURORA-1237 > https://issues.apache.org/jira/browse/AURORA-1237 > > > Repository: aurora > > > Description > --- > > The tasks inside container should run as user that match aurora-role, if > --nosetuid option is not passed for executor. > > Testing Done: > ./pants test.pytest --no-fast --options='--verbose' src/test/python:: > > Bugs closed: AURORA-1237 > > > Diffs > - > > src/main/python/apache/aurora/executor/thermos_task_runner.py 8ce9168 > > Diff: https://reviews.apache.org/r/34568/diff/ > > > Testing > --- > > > Thanks, > > Bhuvan Arumugam > >
Re: Review Request 34568: run tasks as user that match aurora-role
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34568/#review84805 --- Master (998993d) is red with this patch. ./build-support/jenkins/build.sh src.test.python.apache.aurora.client.cli.options . SUCCESS src.test.python.apache.aurora.client.cli.plugins . SUCCESS src.test.python.apache.aurora.client.cli.quota . SUCCESS src.test.python.apache.aurora.client.cli.sla . SUCCESS src.test.python.apache.aurora.client.cli.supdate . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS src.test.python.apache.aurora.client.cli.update . SUCCESS src.test.python.apache.aurora.client.cli.version . SUCCESS src.test.python.apache.aurora.client.config . SUCCESS src.test.python.apache.aurora.client.hooks.hooked_api . SUCCESS src.test.python.apache.aurora.client.hooks.non_hooked_api . SUCCESS src.test.python.apache.aurora.common.test_aurora_job_key . SUCCESS src.test.python.apache.aurora.common.test_cluster . SUCCESS src.test.python.apache.aurora.common.test_cluster_option . SUCCESS src.test.python.apache.aurora.common.test_clusters . SUCCESS src.test.python.apache.aurora.common.test_http_signaler . SUCCESS src.test.python.apache.aurora.common.test_pex_version . SUCCESS src.test.python.apache.aurora.common.test_shellify . SUCCESS src.test.python.apache.aurora.common.test_transport . SUCCESS src.test.python.apache.aurora.config.test_base . SUCCESS src.test.python.apache.aurora.config.test_constraint_parsing . SUCCESS src.test.python.apache.aurora.config.test_loader . SUCCESS src.test.python.apache.aurora.config.test_thrift . SUCCESS src.test.python.apache.aurora.executor.common.path_detector . SUCCESS src.test.python.apache.aurora.executor.common.task_info . SUCCESS src.test.python.apache.aurora.executor.executor_base . SUCCESS src.test.python.apache.aurora.executor.executor_vars . SUCCESS src.test.python.apache.aurora.executor.status_manager . SUCCESS src.test.python.apache.aurora.executor.thermos_task_runner . FAILURE src.test.python.apache.thermos.cli.commands.commands . SUCCESS src.test.python.apache.thermos.cli.common . SUCCESS src.test.python.apache.thermos.cli.main . SUCCESS src.test.python.apache.thermos.common.test_pathspec . SUCCESS src.test.python.apache.thermos.core.test_runner_integration . SUCCESS src.test.python.apache.thermos.monitoring.test_disk . SUCCESS FAILURE [31m FAILURE[0m I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On May 21, 2015, 9:54 p.m., Bhuvan Arumugam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34568/ > --- > > (Updated May 21, 2015, 9:54 p.m.) > > > Review request for Aurora, Bill Farner and Zameer Manji. >
Re: Review Request 34568: run tasks as user that match aurora-role
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34568/#review84799 --- @ReviewBot retry - Bhuvan Arumugam On May 21, 2015, 9:54 p.m., Bhuvan Arumugam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34568/ > --- > > (Updated May 21, 2015, 9:54 p.m.) > > > Review request for Aurora, Bill Farner and Zameer Manji. > > > Bugs: AURORA-1237 > https://issues.apache.org/jira/browse/AURORA-1237 > > > Repository: aurora > > > Description > --- > > The tasks inside container should run as user that match aurora-role, if > --nosetuid option is not passed for executor. > > Testing Done: > ./pants test.pytest --no-fast --options='--verbose' src/test/python:: > > Bugs closed: AURORA-1237 > > > Diffs > - > > src/main/python/apache/aurora/executor/thermos_task_runner.py 8ce9168 > > Diff: https://reviews.apache.org/r/34568/diff/ > > > Testing > --- > > > Thanks, > > Bhuvan Arumugam > >
Re: Review Request 34568: run tasks as user that match aurora-role
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34568/#review84798 --- Master (998993d) is green with this patch. ./build-support/jenkins/build.sh However, it appears that it might lack test coverage. I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On May 21, 2015, 9:54 p.m., Bhuvan Arumugam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34568/ > --- > > (Updated May 21, 2015, 9:54 p.m.) > > > Review request for Aurora, Bill Farner and Zameer Manji. > > > Bugs: AURORA-1237 > https://issues.apache.org/jira/browse/AURORA-1237 > > > Repository: aurora > > > Description > --- > > The tasks inside container should run as user that match aurora-role, if > --nosetuid option is not passed for executor. > > Testing Done: > ./pants test.pytest --no-fast --options='--verbose' src/test/python:: > > Bugs closed: AURORA-1237 > > > Diffs > - > > src/main/python/apache/aurora/executor/thermos_task_runner.py 8ce9168 > > Diff: https://reviews.apache.org/r/34568/diff/ > > > Testing > --- > > > Thanks, > > Bhuvan Arumugam > >
Re: Review Request 34568: run tasks as user that match aurora-role
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34568/ --- (Updated May 21, 2015, 9:54 p.m.) Review request for Aurora, Bill Farner and Zameer Manji. Bugs: AURORA-1237 https://issues.apache.org/jira/browse/AURORA-1237 Repository: aurora Description --- The tasks inside container should run as user that match aurora-role, if --nosetuid option is not passed for executor. Testing Done: ./pants test.pytest --no-fast --options='--verbose' src/test/python:: Bugs closed: AURORA-1237 Diffs (updated) - src/main/python/apache/aurora/executor/thermos_task_runner.py 8ce9168 Diff: https://reviews.apache.org/r/34568/diff/ Testing --- Thanks, Bhuvan Arumugam
Review Request 34568: run tasks as user that match aurora-role
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34568/ --- Review request for Aurora. Repository: aurora Description --- The tasks inside container should run as user that match aurora-role, if --nosetuid option is not passed for executor. Testing Done: ./pants test.pytest --no-fast --options='--verbose' src/test/python:: Bugs closed: AURORA-1237 Diffs - src/main/python/apache/aurora/executor/thermos_task_runner.py 505a1e69ebfe1bd2fa74623063cb923ecff8a021 Diff: https://reviews.apache.org/r/34568/diff/ Testing --- Thanks, Bhuvan Arumugam
