Re: Review Request 34733: Fixing default TaskReconciler initial delay.

2015-05-27 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34733/#review85447
---

Ship it!


Master (5724099) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On May 27, 2015, 9:22 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34733/
> ---
> 
> (Updated May 27, 2015, 9:22 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Bugs: AURORA-1339
> https://issues.apache.org/jira/browse/AURORA-1339
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> The current default value leads to overflow. Fixed the value and added 
> validation.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
> 5f24668265d02b42cf7a05db4f9bc73d8daef0a7 
>   src/main/java/org/apache/aurora/scheduler/async/TaskReconciler.java 
> 23f5f648d3404495e3e9e878592c2638621ce89a 
>   src/test/java/org/apache/aurora/scheduler/async/TaskReconcilerTest.java 
> f56ffd2d7c584042b5c47fa4dba83f35433762f5 
> 
> Diff: https://reviews.apache.org/r/34733/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 34733: Fixing default TaskReconciler initial delay.

2015-05-27 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34733/
---

(Updated May 27, 2015, 9:22 p.m.)


Review request for Aurora, Kevin Sweeney and Zameer Manji.


Changes
---

Kevin's comments.


Bugs: AURORA-1339
https://issues.apache.org/jira/browse/AURORA-1339


Repository: aurora


Description
---

The current default value leads to overflow. Fixed the value and added 
validation.


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
5f24668265d02b42cf7a05db4f9bc73d8daef0a7 
  src/main/java/org/apache/aurora/scheduler/async/TaskReconciler.java 
23f5f648d3404495e3e9e878592c2638621ce89a 
  src/test/java/org/apache/aurora/scheduler/async/TaskReconcilerTest.java 
f56ffd2d7c584042b5c47fa4dba83f35433762f5 

Diff: https://reviews.apache.org/r/34733/diff/


Testing
---

./gradlew -Pq build


Thanks,

Maxim Khutornenko

Re: Review Request 34733: Fixing default TaskReconciler initial delay.

2015-05-27 Thread Maxim Khutornenko 


> On May 27, 2015, 8:58 p.m., Kevin Sweeney wrote:
> > src/main/java/org/apache/aurora/scheduler/async/TaskReconciler.java, line 82
> > 
> >
> > Move this validation to the constructor so that it will halt injector 
> > creation.

Thanks, came to the same conclusion when trying to simplify tests. Done.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34733/#review85438
---


On May 27, 2015, 8:52 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34733/
> ---
> 
> (Updated May 27, 2015, 8:52 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Bugs: AURORA-1339
> https://issues.apache.org/jira/browse/AURORA-1339
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> The current default value leads to overflow. Fixed the value and added 
> validation.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
> 5f24668265d02b42cf7a05db4f9bc73d8daef0a7 
>   src/main/java/org/apache/aurora/scheduler/async/TaskReconciler.java 
> 23f5f648d3404495e3e9e878592c2638621ce89a 
>   src/test/java/org/apache/aurora/scheduler/async/TaskReconcilerTest.java 
> f56ffd2d7c584042b5c47fa4dba83f35433762f5 
> 
> Diff: https://reviews.apache.org/r/34733/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 34733: Fixing default TaskReconciler initial delay.

2015-05-27 Thread Zameer Manji 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34733/#review85441
---

Ship it!


Ship It!

- Zameer Manji


On May 27, 2015, 1:52 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34733/
> ---
> 
> (Updated May 27, 2015, 1:52 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Bugs: AURORA-1339
> https://issues.apache.org/jira/browse/AURORA-1339
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> The current default value leads to overflow. Fixed the value and added 
> validation.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
> 5f24668265d02b42cf7a05db4f9bc73d8daef0a7 
>   src/main/java/org/apache/aurora/scheduler/async/TaskReconciler.java 
> 23f5f648d3404495e3e9e878592c2638621ce89a 
>   src/test/java/org/apache/aurora/scheduler/async/TaskReconcilerTest.java 
> f56ffd2d7c584042b5c47fa4dba83f35433762f5 
> 
> Diff: https://reviews.apache.org/r/34733/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 34733: Fixing default TaskReconciler initial delay.

2015-05-27 Thread Kevin Sweeney 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34733/#review85438
---

Ship it!



src/main/java/org/apache/aurora/scheduler/async/TaskReconciler.java


Move this validation to the constructor so that it will halt injector 
creation.


- Kevin Sweeney


On May 27, 2015, 1:52 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34733/
> ---
> 
> (Updated May 27, 2015, 1:52 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Bugs: AURORA-1339
> https://issues.apache.org/jira/browse/AURORA-1339
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> The current default value leads to overflow. Fixed the value and added 
> validation.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
> 5f24668265d02b42cf7a05db4f9bc73d8daef0a7 
>   src/main/java/org/apache/aurora/scheduler/async/TaskReconciler.java 
> 23f5f648d3404495e3e9e878592c2638621ce89a 
>   src/test/java/org/apache/aurora/scheduler/async/TaskReconcilerTest.java 
> f56ffd2d7c584042b5c47fa4dba83f35433762f5 
> 
> Diff: https://reviews.apache.org/r/34733/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Review Request 34733: Fixing default TaskReconciler initial delay.

2015-05-27 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34733/
---

Review request for Aurora, Kevin Sweeney and Zameer Manji.


Bugs: AURORA-1339
https://issues.apache.org/jira/browse/AURORA-1339


Repository: aurora


Description
---

The current default value leads to overflow. Fixed the value and added 
validation.


Diffs
-

  src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
5f24668265d02b42cf7a05db4f9bc73d8daef0a7 
  src/main/java/org/apache/aurora/scheduler/async/TaskReconciler.java 
23f5f648d3404495e3e9e878592c2638621ce89a 
  src/test/java/org/apache/aurora/scheduler/async/TaskReconcilerTest.java 
f56ffd2d7c584042b5c47fa4dba83f35433762f5 

Diff: https://reviews.apache.org/r/34733/diff/


Testing
---

./gradlew -Pq build


Thanks,

Maxim Khutornenko