Re: Review Request 21136: Add python import order wrapper/commit hook

[Kevin Sweeney]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21136/#review42370
---



src/.isort.cfg


can this live in config/ instead? that's where java checkstyle stuff lives


- Kevin Sweeney


On May 6, 2014, 4:10 p.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21136/
> ---
> 
> (Updated May 6, 2014, 4:10 p.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Bugs: AURORA-149
> https://issues.apache.org/jira/browse/AURORA-149
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Adds build-support/isort wrapper for isort.
> Adds build-support/isort-run to run import sort, build-support/isort-check to 
> run import order check.
> Adds build-support/hooks which contains hooks that people can place into 
> their .git/hooks directory, currently just a pre-commit hook that checks 
> import sort order (which can be overridden with an environment variable.)
> 
> The ordering it produces is different than the one we currently have but 
> closer to straight PEP8.  If it runs, it's about a 500 line diff which I can 
> send later.
> 
> 
> Diffs
> -
> 
>   build-support/hooks/pre-commit PRE-CREATION 
>   build-support/isort PRE-CREATION 
>   build-support/isort-check PRE-CREATION 
>   build-support/isort-run PRE-CREATION 
>   src/.isort.cfg PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/21136/diff/
> 
> 
> Testing
> ---
> 
> Ran the isort and ran tests, everything worked.
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Review Request 21136: Add python import order wrapper/commit hook

[Brian Wickman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21136/
---

Review request for Aurora and Kevin Sweeney.


Repository: aurora


Description
---

Adds build-support/isort wrapper for isort.
Adds build-support/isort-run to run import sort, build-support/isort-check to 
run import order check.
Adds build-support/hooks which contains hooks that people can place into their 
.git/hooks directory, currently just a pre-commit hook that checks import sort 
order (which can be overridden with an environment variable.)

The ordering it produces is different than the one we currently have but closer 
to straight PEP8.  If it runs, it's about a 500 line diff which I can send 
later.


Diffs
-

  build-support/hooks/pre-commit PRE-CREATION 
  build-support/isort PRE-CREATION 
  build-support/isort-check PRE-CREATION 
  build-support/isort-run PRE-CREATION 
  src/.isort.cfg PRE-CREATION 

Diff: https://reviews.apache.org/r/21136/diff/


Testing
---

Ran the isort and ran tests, everything worked.


Thanks,

Brian Wickman

Re: Review Request 21136: Add python import order wrapper/commit hook

[Brian Wickman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21136/
---

(Updated May 6, 2014, 11:10 p.m.)


Review request for Aurora and Kevin Sweeney.


Changes
---

Add related ticket AURORA-149
(The checkstyle part is a subsequent review.)


Bugs: AURORA-149
https://issues.apache.org/jira/browse/AURORA-149


Repository: aurora


Description
---

Adds build-support/isort wrapper for isort.
Adds build-support/isort-run to run import sort, build-support/isort-check to 
run import order check.
Adds build-support/hooks which contains hooks that people can place into their 
.git/hooks directory, currently just a pre-commit hook that checks import sort 
order (which can be overridden with an environment variable.)

The ordering it produces is different than the one we currently have but closer 
to straight PEP8.  If it runs, it's about a 500 line diff which I can send 
later.


Diffs
-

  build-support/hooks/pre-commit PRE-CREATION 
  build-support/isort PRE-CREATION 
  build-support/isort-check PRE-CREATION 
  build-support/isort-run PRE-CREATION 
  src/.isort.cfg PRE-CREATION 

Diff: https://reviews.apache.org/r/21136/diff/


Testing
---

Ran the isort and ran tests, everything worked.


Thanks,

Brian Wickman

Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

[David McLaughlin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21132/
---

Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Bill Farner.


Bugs: AURORA-335
https://issues.apache.org/jira/browse/AURORA-335


Repository: aurora


Description
---

Initial attempt at h2/DB storage implementation (LockStore only)


Diffs
-

  build.gradle 6c758f690b87eede3ae3a7c54fabac20db543840 
  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
bf3d7a36a575bb9d64f4dd851c63fbebda1e61b8 
  src/main/java/org/apache/aurora/scheduler/base/JobKeys.java 
db1bec4f508c8908f212aa541fb86e041a8c471c 
  src/main/java/org/apache/aurora/scheduler/storage/Storage.java 
4b33fe5dd8223ff04060de0fe16b1c0759ead956 
  src/main/java/org/apache/aurora/scheduler/storage/db/DbLockStore.java 
PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 
PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java 
PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/storage/db/JobKeyMapper.java 
PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/storage/db/LockMapper.java 
PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/storage/db/MigrationModule.java 
PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/storage/db/views/LockRow.java 
PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 
c851eeb412b17097ff42abce2b7a42fc1c249013 
  src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java 
4d43f47de75a8bef06f106f563cc071df4cdf093 
  src/main/java/org/apache/aurora/scheduler/storage/mem/MemLockStore.java 
a6319f65bff07db66197e6476647117df6be5c9d 
  src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 
283976ab0554dbe6700bb0d2a1b7702c969227e8 
  src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorageModule.java 
53923627c827131ee4bd93e5c4865d042aee501b 
  src/main/resources/org/apache/aurora/scheduler/storage/db/JobKeyMapper.xml 
PRE-CREATION 
  src/main/resources/org/apache/aurora/scheduler/storage/db/LockMapper.xml 
PRE-CREATION 
  src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
PRE-CREATION 
  src/test/java/org/apache/aurora/scheduler/storage/db/DbLockStoreTest.java 
PRE-CREATION 
  src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 
34377430268002e8e8e5bc803b409e092bb86720 
  src/test/java/org/apache/aurora/scheduler/storage/mem/MemLockStoreTest.java 
a5191500b2958253e14843089a15a1ffd58e6846 

Diff: https://reviews.apache.org/r/21132/diff/


Testing
---


Thanks,

David McLaughlin

Re: Review Request 21055: AURORA-14: Add jenkins-compatible script to build mesos core egg and run executor-large tests

[Brian Wickman]

> On May 6, 2014, 6:59 p.m., Brian Wickman wrote:
> > src/test/python/apache/aurora/executor/test_thermos_executor.py, line 213
> > 
> >
> > out of curiosity, how does this ever work?  checker should always be an 
> > instance and not a class, so issubclass will fail:
> > 
> > >>> f = Foo()
> > >>> issubclass(f, Foo)
> > Traceback (most recent call last):
> >   File "", line 1, in 
> > TypeError: issubclass() arg 1 must be a class
> > 
> > the constructor of ChainedStatusChecker also ensures that all inputs 
> > are instances of the StatusChecker interface:
> > 
> > class ChainedStatusChecker(StatusChecker):
> >   def __init__(self, status_checkers):
> > self._status_checkers = status_checkers
> > self._status = None
> > if not all(isinstance(h_i, StatusChecker) for h_i in 
> > status_checkers):
> >   raise TypeError('ChainedStatusChecker must take an iterable of 
> > StatusCheckers.')
> > super(ChainedStatusChecker, self).__init__()
> >
> 
> Dan Norris wrote:
> That's a copy/paste error on my part. It should have been:
> if issubclass(type(checker), StatusChecker):
> 
> The whole reason for that line is to ensure that we don't try and call 
> .name() something that was coming back as a string in 
> te._chained_checker._status_checkers. I can send you the test output if 
> you're interested in taking a look.

you want isinstance(checker, StatusChecker) instead (calling type(obj) is an 
antipattern in python.)  however, this invariant is already enforced by 
ChainedStatusChecker, so it superfluous.  it sounds like there is a legitimate 
bug somewhere where somebody is calling ".name" instead of ".name()" since it 
was recently changed from an @abstractproperty to a default method.


- Brian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21055/#review42340
---


On May 4, 2014, 12:02 a.m., Dan Norris wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21055/
> ---
> 
> (Updated May 4, 2014, 12:02 a.m.)
> 
> 
> Review request for Aurora, Jake Farrell, Kevin Sweeney, Bill Farner, and 
> Brian Wickman.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-14: Add jenkins-compatible script to build mesos core egg and run 
> executor-large tests
> 
> I took this over from wickman at his request (old review: 
> https://reviews.apache.org/r/19955/).
> 
> Changes:
> - Use mesos 0.18.0 instead of 0.17.0
> - Download mesos source from apache.org
> - Conditionally build mesos .egg
> - Fix a test in test_thermos_executor.py that was broken
> 
> 
> Diffs
> -
> 
>   .mesosversion PRE-CREATION 
>   3rdparty/python/BUILD 122f71db0bc6f37c19ae0f3cb2fcade8321404e6 
>   build-support/jenkins/build.sh f6f4940a1450cd0d8d8497e651d0e6c7377dfc3f 
>   build-support/jenkins/build_executor.sh PRE-CREATION 
>   build-support/jenkins/build_mesos.sh PRE-CREATION 
>   build.gradle 6c758f690b87eede3ae3a7c54fabac20db543840 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 
> 0b143d0a2cbb25c1d35f79963478800a6b6713ec 
> 
> Diff: https://reviews.apache.org/r/21055/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build_mesos.sh && ./pants 
> src/test/python/apache/aurora/executor:executor-large -vxs (what the new 
> build_executor.sh script does)
> 
> 
> Thanks,
> 
> Dan Norris
> 
>

Re: Review Request 21055: AURORA-14: Add jenkins-compatible script to build mesos core egg and run executor-large tests

[Dan Norris]

> On May 6, 2014, 6:59 p.m., Brian Wickman wrote:
> > src/test/python/apache/aurora/executor/test_thermos_executor.py, line 213
> > 
> >
> > out of curiosity, how does this ever work?  checker should always be an 
> > instance and not a class, so issubclass will fail:
> > 
> > >>> f = Foo()
> > >>> issubclass(f, Foo)
> > Traceback (most recent call last):
> >   File "", line 1, in 
> > TypeError: issubclass() arg 1 must be a class
> > 
> > the constructor of ChainedStatusChecker also ensures that all inputs 
> > are instances of the StatusChecker interface:
> > 
> > class ChainedStatusChecker(StatusChecker):
> >   def __init__(self, status_checkers):
> > self._status_checkers = status_checkers
> > self._status = None
> > if not all(isinstance(h_i, StatusChecker) for h_i in 
> > status_checkers):
> >   raise TypeError('ChainedStatusChecker must take an iterable of 
> > StatusCheckers.')
> > super(ChainedStatusChecker, self).__init__()
> >

That's a copy/paste error on my part. It should have been:
if issubclass(type(checker), StatusChecker):

The whole reason for that line is to ensure that we don't try and call .name() 
something that was coming back as a string in 
te._chained_checker._status_checkers. I can send you the test output if you're 
interested in taking a look.


- Dan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21055/#review42340
---


On May 4, 2014, 12:02 a.m., Dan Norris wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21055/
> ---
> 
> (Updated May 4, 2014, 12:02 a.m.)
> 
> 
> Review request for Aurora, Jake Farrell, Kevin Sweeney, Bill Farner, and 
> Brian Wickman.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-14: Add jenkins-compatible script to build mesos core egg and run 
> executor-large tests
> 
> I took this over from wickman at his request (old review: 
> https://reviews.apache.org/r/19955/).
> 
> Changes:
> - Use mesos 0.18.0 instead of 0.17.0
> - Download mesos source from apache.org
> - Conditionally build mesos .egg
> - Fix a test in test_thermos_executor.py that was broken
> 
> 
> Diffs
> -
> 
>   .mesosversion PRE-CREATION 
>   3rdparty/python/BUILD 122f71db0bc6f37c19ae0f3cb2fcade8321404e6 
>   build-support/jenkins/build.sh f6f4940a1450cd0d8d8497e651d0e6c7377dfc3f 
>   build-support/jenkins/build_executor.sh PRE-CREATION 
>   build-support/jenkins/build_mesos.sh PRE-CREATION 
>   build.gradle 6c758f690b87eede3ae3a7c54fabac20db543840 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 
> 0b143d0a2cbb25c1d35f79963478800a6b6713ec 
> 
> Diff: https://reviews.apache.org/r/21055/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build_mesos.sh && ./pants 
> src/test/python/apache/aurora/executor:executor-large -vxs (what the new 
> build_executor.sh script does)
> 
> 
> Thanks,
> 
> Dan Norris
> 
>

Re: Review Request 20648: Remove IsolatedSchedulerModule and surrounding code.

[Maxim Khutornenko]

> On May 6, 2014, 7:19 p.m., Bill Farner wrote:
> > Ping?  Any new thoughts or prevailing dislike for this change?

My thoughts are the same :) I would prefer having a gradual transition to 
vagrant rather than stimulate_via_cutting_the_cord approach.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20648/#review42342
---


On April 24, 2014, 4:22 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20648/
> ---
> 
> (Updated April 24, 2014, 4:22 a.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Bugs: AURORA-340
> https://issues.apache.org/jira/browse/AURORA-340
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove IsolatedSchedulerModule and surrounding code.
> 
> 
> Diffs
> -
> 
>   build.gradle 459cd85f4f239e19e013e74a4745edc7994a9411 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> bf3d7a36a575bb9d64f4dd851c63fbebda1e61b8 
>   src/main/java/org/apache/aurora/scheduler/local/FakeDriverFactory.java 
> 9a78fb9be8578f8cea2e51c0ebf385aafdc8b2a9 
>   
> src/main/java/org/apache/aurora/scheduler/local/IsolatedSchedulerModule.java 
> 1bfd4b69584122f62616ce93098a56fe3cf195d8 
>   src/main/java/org/apache/aurora/scheduler/log/testing/FileLog.java 
> 9186aebef2babc4a76fe05eb3b412be26d7de3c6 
>   
> src/main/java/org/apache/aurora/scheduler/log/testing/FileLogStreamModule.java
>  d8f19e6c1eac1567b3194c5d4ebeb0d5b95073e6 
>   src/test/java/org/apache/aurora/scheduler/log/testing/FileLogTest.java 
> cc31187607e89a9daebe071a8a180d56d873e4c5 
> 
> Diff: https://reviews.apache.org/r/20648/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build
> sh examples/vagrant/test_tutorial.sh
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 20640: Fix createJob to accept non-cron jobs.

[Brian Wickman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20640/#review42338
---


status?

- Brian Wickman


On April 24, 2014, 1:10 a.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20640/
> ---
> 
> (Updated April 24, 2014, 1:10 a.m.)
> 
> 
> Review request for Aurora, Bill Farner and Brian Wickman.
> 
> 
> Bugs: AURORA-349
> https://issues.apache.org/jira/browse/AURORA-349
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Fix createJob to accept non-cron jobs.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 
> 09b7fbd5832991226bc5a012a0a1f5249ac825e6 
> 
> Diff: https://reviews.apache.org/r/20640/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build
> 
> e2e test is not quite fixed but the part that caused this error is
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Re: Review Request 21111: AURORA-388 - Update changelog to only pickup fixed issues

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2/#review42349
---

Ship it!


Ship It!

- Bill Farner


On May 6, 2014, 1:34 p.m., Jake Farrell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2/
> ---
> 
> (Updated May 6, 2014, 1:34 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-388
> https://issues.apache.org/jira/browse/AURORA-388
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-388 - Update changelog to only pickup fixed issues
> 
> Updates the changelog jql to only pick up fixed and done issues.
> 
> 
> Diffs
> -
> 
>   build-support/release/changelog 6bd8ee9e6136c13e223bc166a06c8d80dce2468a 
> 
> Diff: https://reviews.apache.org/r/2/diff/
> 
> 
> Testing
> ---
> 
> Removed CHANGELOG file and switched .auroraversion to 0.5.0 and re-ran 
> script, came back with 160 issues vs the 183 currently listed.
> 
> 
> Thanks,
> 
> Jake Farrell
> 
>

Re: Review Request 20959: Moving kill wait to the client (Part 2: server changes)

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20959/#review42347
---

Ship it!


Ship It!

- Bill Farner


On May 1, 2014, 5:52 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20959/
> ---
> 
> (Updated May 1, 2014, 5:52 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-370
> https://issues.apache.org/jira/browse/AURORA-370
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Dropping killTask wait from the scheduler.
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  abf47d791182680f5bc3b92e4cef937633fc1a2a 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  169c4039bc609ca1b82f9c56661a9648c8d47116 
> 
> Diff: https://reviews.apache.org/r/20959/diff/
> 
> 
> Testing
> ---
> 
> gradle build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 20928: Command hooks: stage 2.

[Mark Chu-Carroll]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20928/
---

(Updated May 6, 2014, 3:14 p.m.)


Review request for Aurora, David McLaughlin and Suman Karumuri.


Changes
---

Rebase to master.


Bugs: aurora-270
https://issues.apache.org/jira/browse/aurora-270


Repository: aurora


Description
---

The second half of command hooks: 
- Dynamically registered hook exceptions are provided, by fetching a hooks skip 
rules file from a 
  URL.
- Hooks are loaded and activated by the noun/verb framework.
- Hook selection and dispatch has been substantially updated.

Also did some long overdue cleanup of string quoting consistency.


Diffs (updated)
-

  3rdparty/python/BUILD 122f71db0bc6f37c19ae0f3cb2fcade8321404e6 
  docs/design/command-hooks.md ee320ed3922928408d23a2dfdf3c42ef96e62ff7 
  src/main/python/apache/aurora/client/cli/BUILD 
1bd565effb3dbe2aeb5d6156575e9316bd77c6a8 
  src/main/python/apache/aurora/client/cli/__init__.py 
1e396b2263451b41cd223708f4cc4cdb1eeddbf0 
  src/main/python/apache/aurora/client/cli/command_hooks.py 
2d200682209e1df83c03f9d515f3b118aaa85a99 
  src/test/python/apache/aurora/client/cli/test_command_hooks.py 
6c6f6f58e0263aeb6442d48e32ea13f1e3b98479 

Diff: https://reviews.apache.org/r/20928/diff/


Testing
---

[sun-wukong incubator-aurora (command-hooks-two)]$ !./p
./pants src/test/python/apache/aurora/client/cli:all
Build operating on targets: 
OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)])
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 4 items

src/test/python/apache/aurora/client/cli/test_bridge.py 

=== 4 passed in 0.02 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 9 items

src/test/python/apache/aurora/client/cli/test_command_hooks.py .

=== 9 passed in 0.80 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 5 items

src/test/python/apache/aurora/client/cli/test_help.py .

=== 5 passed in 0.70 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 36 items

src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
src/test/python/apache/aurora/client/cli/test_create.py 
src/test/python/apache/aurora/client/cli/test_diff.py ...
src/test/python/apache/aurora/client/cli/test_kill.py .
src/test/python/apache/aurora/client/cli/test_open.py .
src/test/python/apache/aurora/client/cli/test_restart.py ...
src/test/python/apache/aurora/client/cli/test_status.py ...
src/test/python/apache/aurora/client/cli/test_update.py ...

== 36 passed in 2.02 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 1 items

src/test/python/apache/aurora/client/cli/test_logging.py .

=== 1 passed in 0.65 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 3 items

src/test/python/apache/aurora/client/cli/test_plugins.py ...

=== 3 passed in 0.67 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 4 items

src/test/python/apache/aurora/client/cli/test_quota.py 

=== 4 passed in 0.67 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 5 items

src/test/python/apache/aurora/client/cli/test_sla.py .

=== 5 passed in 0.72 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 2 items

src/test/python/apache/aurora/client/cli/test_task_run.py ..

=== 2 passed in 0.65 seconds ===
src.test.python.apache.aurora.client.cli.bridge 

Re: Review Request 20723: Add batch options to kill and killall.

[Suman Karumuri]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20723/#review42346
---

Ship it!


Ship It!

- Suman Karumuri


On May 6, 2014, 6 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20723/
> ---
> 
> (Updated May 6, 2014, 6 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Suman Karumuri.
> 
> 
> Bugs: aurora-356
> https://issues.apache.org/jira/browse/aurora-356
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add batch options to kill and killall. (This brings the kill commands in 
> client v1 into parity with client v2.
> At the moment, in order to avoid disrupting current users, v1 still defaults 
> to non-batched operation.)
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/commands/core.py 
> 089a2c6aaa742dc7479014b90c2b3fac46d4befd 
>   src/main/python/apache/aurora/client/options.py 
> 0d85c360dc4c62ab0baf58315a68a32c304fcffc 
>   src/test/python/apache/aurora/client/commands/test_kill.py 
> 7f0b73ca2701f0ce250d906bce1bd8b07b49ae99 
> 
> Diff: https://reviews.apache.org/r/20723/diff/
> 
> 
> Testing
> ---
> 
> [sun-wukong incubator-aurora (batch_v1)]$ ./pants 
> src/test/python/apache/aurora/client/commands:all
> Build operating on targets: 
> OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/commands/BUILD:all)])
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 13 items
> 
> src/test/python/apache/aurora/client/commands/test_admin_sla.py .
> 
> == 13 passed in 0.57 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 28 items
> 
> src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
> src/test/python/apache/aurora/client/commands/test_create.py ..
> src/test/python/apache/aurora/client/commands/test_diff.py ...
> src/test/python/apache/aurora/client/commands/test_kill.py ..
> src/test/python/apache/aurora/client/commands/test_listjobs.py ..
> src/test/python/apache/aurora/client/commands/test_restart.py ...
> src/test/python/apache/aurora/client/commands/test_status.py ...
> src/test/python/apache/aurora/client/commands/test_update.py ...
> 
> == 28 passed in 1.47 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 3 items
> 
> src/test/python/apache/aurora/client/commands/test_hooks.py ...
> 
> === 3 passed in 1.21 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
> 
> src/test/python/apache/aurora/client/commands/test_maintenance.py 
> 
> === 4 passed in 0.48 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
> 
> src/test/python/apache/aurora/client/commands/test_run.py .
> 
> === 1 passed in 0.58 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
> 
> src/test/python/apache/aurora/client/commands/test_ssh.py .
> 
> === 1 passed in 0.47 seconds 
> ===
> src.test.python.apache.aurora.client.commands.admin   
>   .   SUCCESS
> src.test.python.apache.aurora.client.commands.core
>   .   SUCCESS
> src.test.python.apache.aurora.client.commands.hooks   
>   .   SUCCESS
> src.test.python.apache.aurora.client.commands.maintenance 
>   .   SUCCESS
> src.test.python.apache.aurora.client.commands.run 
>   .   SUCCESS
> src.test.python.apache.aurora.client.commands.ssh 
>   .   SUCCESS
> [sun-wukong incubator-aurora (batch_v1)]$
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Re: Review Request 20648: Remove IsolatedSchedulerModule and surrounding code.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20648/#review42342
---


Ping?  Any new thoughts or prevailing dislike for this change?

- Bill Farner


On April 24, 2014, 4:22 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20648/
> ---
> 
> (Updated April 24, 2014, 4:22 a.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Bugs: AURORA-340
> https://issues.apache.org/jira/browse/AURORA-340
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove IsolatedSchedulerModule and surrounding code.
> 
> 
> Diffs
> -
> 
>   build.gradle 459cd85f4f239e19e013e74a4745edc7994a9411 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> bf3d7a36a575bb9d64f4dd851c63fbebda1e61b8 
>   src/main/java/org/apache/aurora/scheduler/local/FakeDriverFactory.java 
> 9a78fb9be8578f8cea2e51c0ebf385aafdc8b2a9 
>   
> src/main/java/org/apache/aurora/scheduler/local/IsolatedSchedulerModule.java 
> 1bfd4b69584122f62616ce93098a56fe3cf195d8 
>   src/main/java/org/apache/aurora/scheduler/log/testing/FileLog.java 
> 9186aebef2babc4a76fe05eb3b412be26d7de3c6 
>   
> src/main/java/org/apache/aurora/scheduler/log/testing/FileLogStreamModule.java
>  d8f19e6c1eac1567b3194c5d4ebeb0d5b95073e6 
>   src/test/java/org/apache/aurora/scheduler/log/testing/FileLogTest.java 
> cc31187607e89a9daebe071a8a180d56d873e4c5 
> 
> Diff: https://reviews.apache.org/r/20648/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build
> sh examples/vagrant/test_tutorial.sh
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 21055: AURORA-14: Add jenkins-compatible script to build mesos core egg and run executor-large tests

[Brian Wickman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21055/#review42340
---



src/test/python/apache/aurora/executor/test_thermos_executor.py


out of curiosity, how does this ever work?  checker should always be an 
instance and not a class, so issubclass will fail:

>>> f = Foo()
>>> issubclass(f, Foo)
Traceback (most recent call last):
  File "", line 1, in 
TypeError: issubclass() arg 1 must be a class

the constructor of ChainedStatusChecker also ensures that all inputs are 
instances of the StatusChecker interface:

class ChainedStatusChecker(StatusChecker):
  def __init__(self, status_checkers):
self._status_checkers = status_checkers
self._status = None
if not all(isinstance(h_i, StatusChecker) for h_i in status_checkers):
  raise TypeError('ChainedStatusChecker must take an iterable of 
StatusCheckers.')
super(ChainedStatusChecker, self).__init__()



- Brian Wickman


On May 4, 2014, 12:02 a.m., Dan Norris wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21055/
> ---
> 
> (Updated May 4, 2014, 12:02 a.m.)
> 
> 
> Review request for Aurora, Jake Farrell, Kevin Sweeney, Bill Farner, and 
> Brian Wickman.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-14: Add jenkins-compatible script to build mesos core egg and run 
> executor-large tests
> 
> I took this over from wickman at his request (old review: 
> https://reviews.apache.org/r/19955/).
> 
> Changes:
> - Use mesos 0.18.0 instead of 0.17.0
> - Download mesos source from apache.org
> - Conditionally build mesos .egg
> - Fix a test in test_thermos_executor.py that was broken
> 
> 
> Diffs
> -
> 
>   .mesosversion PRE-CREATION 
>   3rdparty/python/BUILD 122f71db0bc6f37c19ae0f3cb2fcade8321404e6 
>   build-support/jenkins/build.sh f6f4940a1450cd0d8d8497e651d0e6c7377dfc3f 
>   build-support/jenkins/build_executor.sh PRE-CREATION 
>   build-support/jenkins/build_mesos.sh PRE-CREATION 
>   build.gradle 6c758f690b87eede3ae3a7c54fabac20db543840 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 
> 0b143d0a2cbb25c1d35f79963478800a6b6713ec 
> 
> Diff: https://reviews.apache.org/r/21055/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build_mesos.sh && ./pants 
> src/test/python/apache/aurora/executor:executor-large -vxs (what the new 
> build_executor.sh script does)
> 
> 
> Thanks,
> 
> Dan Norris
> 
>

Re: Review Request 20394: Add return code to task/process pages

[Brian Wickman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20394/#review42339
---


david -- should i submit this?  i just realized that you likely don't have 
commit privileges, so i think this is up to me to submit.

- Brian Wickman


On April 28, 2014, 10:48 p.m., David McLaughlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20394/
> ---
> 
> (Updated April 28, 2014, 10:48 p.m.)
> 
> 
> Review request for Aurora and Brian Wickman.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add return code to task/process pages
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/thermos/observer/http/http_observer.py 
> 118bd2f4889c520683ba04b554d699ecf0bc20ce 
>   src/main/python/apache/thermos/observer/http/templates/process.tpl 
> a7fb90d4decec01cb95f9e5d42288eaae9d71edf 
>   src/main/python/apache/thermos/observer/http/templates/task.tpl 
> b71c80d11255c111873a46b99478c36d39cc8733 
>   src/main/python/apache/thermos/observer/task_observer.py 
> ea40bfa610e2af90904487c809bc83b8b5f214d9 
> 
> Diff: https://reviews.apache.org/r/20394/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 20986: Adding min_instance_count threshold to improve safe domain results.

[Brian Wickman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20986/#review42337
---



src/main/python/apache/aurora/client/api/sla.py


rather than make this required, maybe define

DEFAULT_MIN_INSTANCE_COUNT=2

and do min_instance_count=DEFAULT_MIN_INSTANCE_COUNT in the initializer.  
this way it's not required everywhere.




src/main/python/apache/aurora/client/api/sla.py


hosts should be passed in as hosts=hosts to differentiate it from 
positional args in general.  this is mostly just style though.


- Brian Wickman


On May 1, 2014, 9:49 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20986/
> ---
> 
> (Updated May 1, 2014, 9:49 p.m.)
> 
> 
> Review request for Aurora and Brian Wickman.
> 
> 
> Bugs: AURORA-305
> https://issues.apache.org/jira/browse/AURORA-305
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Low instance count jobs prevent hosts from showing up in the safe domain 
> list. Adding an option to control jobs included into results.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/__init__.py 
> d8a23274bc9d0ba2d0ebc232652ff8c4c5da6eb1 
>   src/main/python/apache/aurora/client/api/sla.py 
> bb705caab4ef7749971613e23c8f6b0d3968ba23 
>   src/main/python/apache/aurora/client/commands/admin.py 
> 912851af1da0f6f706e55e28f6e949e1750b9897 
>   src/test/python/apache/aurora/client/api/test_sla.py 
> 359599af400d621e5652c2e56d01802a804abcc9 
>   src/test/python/apache/aurora/client/commands/test_admin_sla.py 
> aaf6c7f05caf8c809429a122e3d02e8ebb2fa54e 
> 
> Diff: https://reviews.apache.org/r/20986/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 20723: Add batch options to kill and killall.

[Mark Chu-Carroll]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20723/
---

(Updated May 6, 2014, 2 p.m.)


Review request for Aurora, David McLaughlin and Suman Karumuri.


Changes
---

Address Suman's review.


Bugs: aurora-356
https://issues.apache.org/jira/browse/aurora-356


Repository: aurora


Description
---

Add batch options to kill and killall. (This brings the kill commands in client 
v1 into parity with client v2.
At the moment, in order to avoid disrupting current users, v1 still defaults to 
non-batched operation.)


Diffs (updated)
-

  src/main/python/apache/aurora/client/commands/core.py 
089a2c6aaa742dc7479014b90c2b3fac46d4befd 
  src/main/python/apache/aurora/client/options.py 
0d85c360dc4c62ab0baf58315a68a32c304fcffc 
  src/test/python/apache/aurora/client/commands/test_kill.py 
7f0b73ca2701f0ce250d906bce1bd8b07b49ae99 

Diff: https://reviews.apache.org/r/20723/diff/


Testing
---

[sun-wukong incubator-aurora (batch_v1)]$ ./pants 
src/test/python/apache/aurora/client/commands:all
Build operating on targets: 
OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/commands/BUILD:all)])
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 13 items

src/test/python/apache/aurora/client/commands/test_admin_sla.py .

== 13 passed in 0.57 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 28 items

src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
src/test/python/apache/aurora/client/commands/test_create.py ..
src/test/python/apache/aurora/client/commands/test_diff.py ...
src/test/python/apache/aurora/client/commands/test_kill.py ..
src/test/python/apache/aurora/client/commands/test_listjobs.py ..
src/test/python/apache/aurora/client/commands/test_restart.py ...
src/test/python/apache/aurora/client/commands/test_status.py ...
src/test/python/apache/aurora/client/commands/test_update.py ...

== 28 passed in 1.47 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 3 items

src/test/python/apache/aurora/client/commands/test_hooks.py ...

=== 3 passed in 1.21 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 4 items

src/test/python/apache/aurora/client/commands/test_maintenance.py 

=== 4 passed in 0.48 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 1 items

src/test/python/apache/aurora/client/commands/test_run.py .

=== 1 passed in 0.58 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 1 items

src/test/python/apache/aurora/client/commands/test_ssh.py .

=== 1 passed in 0.47 seconds ===
src.test.python.apache.aurora.client.commands.admin 
.   SUCCESS
src.test.python.apache.aurora.client.commands.core  
.   SUCCESS
src.test.python.apache.aurora.client.commands.hooks 
.   SUCCESS
src.test.python.apache.aurora.client.commands.maintenance   
.   SUCCESS
src.test.python.apache.aurora.client.commands.run   
.   SUCCESS
src.test.python.apache.aurora.client.commands.ssh   
.   SUCCESS
[sun-wukong incubator-aurora (batch_v1)]$


Thanks,

Mark Chu-Carroll

Re: Review Request 20928: Command hooks: stage 2.

[Suman Karumuri]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20928/#review42322
---

Ship it!


Also, please reply to the review comments inline.


src/main/python/apache/aurora/client/cli/command_hooks.py


To keep it DRY, just point to the design doc at the top of the file.



src/main/python/apache/aurora/client/cli/command_hooks.py


To keep it DRY, just point to the design doc at the top of the file.


- Suman Karumuri


On May 6, 2014, 2:47 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20928/
> ---
> 
> (Updated May 6, 2014, 2:47 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Suman Karumuri.
> 
> 
> Bugs: aurora-270
> https://issues.apache.org/jira/browse/aurora-270
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> The second half of command hooks: 
> - Dynamically registered hook exceptions are provided, by fetching a hooks 
> skip rules file from a 
>   URL.
> - Hooks are loaded and activated by the noun/verb framework.
> - Hook selection and dispatch has been substantially updated.
> 
> Also did some long overdue cleanup of string quoting consistency.
> 
> 
> Diffs
> -
> 
>   .auroraversion f0334e962b038d4b8a8de7ce87a8dd445616a0ea 
>   3rdparty/python/BUILD 122f71db0bc6f37c19ae0f3cb2fcade8321404e6 
>   docs/design/command-hooks.md ee320ed3922928408d23a2dfdf3c42ef96e62ff7 
>   src/main/python/apache/aurora/client/cli/BUILD 
> 1bd565effb3dbe2aeb5d6156575e9316bd77c6a8 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 1e396b2263451b41cd223708f4cc4cdb1eeddbf0 
>   src/main/python/apache/aurora/client/cli/command_hooks.py 
> 2d200682209e1df83c03f9d515f3b118aaa85a99 
>   src/test/python/apache/aurora/client/cli/test_command_hooks.py 
> 6c6f6f58e0263aeb6442d48e32ea13f1e3b98479 
> 
> Diff: https://reviews.apache.org/r/20928/diff/
> 
> 
> Testing
> ---
> 
> [sun-wukong incubator-aurora (command-hooks-two)]$ !./p
> ./pants src/test/python/apache/aurora/client/cli:all
> Build operating on targets: 
> OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)])
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 4 items
> 
> src/test/python/apache/aurora/client/cli/test_bridge.py 
> 
> === 4 passed in 0.02 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 9 items
> 
> src/test/python/apache/aurora/client/cli/test_command_hooks.py .
> 
> === 9 passed in 0.80 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 5 items
> 
> src/test/python/apache/aurora/client/cli/test_help.py .
> 
> === 5 passed in 0.70 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 36 items
> 
> src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
> src/test/python/apache/aurora/client/cli/test_create.py 
> src/test/python/apache/aurora/client/cli/test_diff.py ...
> src/test/python/apache/aurora/client/cli/test_kill.py .
> src/test/python/apache/aurora/client/cli/test_open.py .
> src/test/python/apache/aurora/client/cli/test_restart.py ...
> src/test/python/apache/aurora/client/cli/test_status.py ...
> src/test/python/apache/aurora/client/cli/test_update.py ...
> 
> == 36 passed in 2.02 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 1 items
> 
> src/test/python/apache/aurora/client/cli/test_logging.py .
> 
> === 1 passed in 0.65 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 3 items
> 
> src/test/python/apache/aurora/client/cli/test_plugins.py ...
> 
> === 3 passed in 0.67 seconds 
> ==

Re: Review Request 20959: Moving kill wait to the client (Part 2: server changes)

[Maxim Khutornenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20959/#review42312
---


Ping, Bill.

- Maxim Khutornenko


On May 1, 2014, 5:52 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20959/
> ---
> 
> (Updated May 1, 2014, 5:52 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-370
> https://issues.apache.org/jira/browse/AURORA-370
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Dropping killTask wait from the scheduler.
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  abf47d791182680f5bc3b92e4cef937633fc1a2a 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  169c4039bc609ca1b82f9c56661a9648c8d47116 
> 
> Diff: https://reviews.apache.org/r/20959/diff/
> 
> 
> Testing
> ---
> 
> gradle build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 20986: Adding min_instance_count threshold to improve safe domain results.

[Maxim Khutornenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20986/#review42311
---


Ping, Brian.

- Maxim Khutornenko


On May 1, 2014, 9:49 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20986/
> ---
> 
> (Updated May 1, 2014, 9:49 p.m.)
> 
> 
> Review request for Aurora and Brian Wickman.
> 
> 
> Bugs: AURORA-305
> https://issues.apache.org/jira/browse/AURORA-305
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Low instance count jobs prevent hosts from showing up in the safe domain 
> list. Adding an option to control jobs included into results.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/__init__.py 
> d8a23274bc9d0ba2d0ebc232652ff8c4c5da6eb1 
>   src/main/python/apache/aurora/client/api/sla.py 
> bb705caab4ef7749971613e23c8f6b0d3968ba23 
>   src/main/python/apache/aurora/client/commands/admin.py 
> 912851af1da0f6f706e55e28f6e949e1750b9897 
>   src/test/python/apache/aurora/client/api/test_sla.py 
> 359599af400d621e5652c2e56d01802a804abcc9 
>   src/test/python/apache/aurora/client/commands/test_admin_sla.py 
> aaf6c7f05caf8c809429a122e3d02e8ebb2fa54e 
> 
> Diff: https://reviews.apache.org/r/20986/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 20928: Command hooks: stage 2.

[Mark Chu-Carroll]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20928/
---

(Updated May 6, 2014, 10:47 a.m.)


Review request for Aurora, David McLaughlin and Suman Karumuri.


Changes
---

Address Suman's review.


Bugs: aurora-270
https://issues.apache.org/jira/browse/aurora-270


Repository: aurora


Description
---

The second half of command hooks: 
- Dynamically registered hook exceptions are provided, by fetching a hooks skip 
rules file from a 
  URL.
- Hooks are loaded and activated by the noun/verb framework.
- Hook selection and dispatch has been substantially updated.

Also did some long overdue cleanup of string quoting consistency.


Diffs (updated)
-

  .auroraversion f0334e962b038d4b8a8de7ce87a8dd445616a0ea 
  3rdparty/python/BUILD 122f71db0bc6f37c19ae0f3cb2fcade8321404e6 
  docs/design/command-hooks.md ee320ed3922928408d23a2dfdf3c42ef96e62ff7 
  src/main/python/apache/aurora/client/cli/BUILD 
1bd565effb3dbe2aeb5d6156575e9316bd77c6a8 
  src/main/python/apache/aurora/client/cli/__init__.py 
1e396b2263451b41cd223708f4cc4cdb1eeddbf0 
  src/main/python/apache/aurora/client/cli/command_hooks.py 
2d200682209e1df83c03f9d515f3b118aaa85a99 
  src/test/python/apache/aurora/client/cli/test_command_hooks.py 
6c6f6f58e0263aeb6442d48e32ea13f1e3b98479 

Diff: https://reviews.apache.org/r/20928/diff/


Testing
---

[sun-wukong incubator-aurora (command-hooks-two)]$ !./p
./pants src/test/python/apache/aurora/client/cli:all
Build operating on targets: 
OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)])
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 4 items

src/test/python/apache/aurora/client/cli/test_bridge.py 

=== 4 passed in 0.02 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 9 items

src/test/python/apache/aurora/client/cli/test_command_hooks.py .

=== 9 passed in 0.80 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 5 items

src/test/python/apache/aurora/client/cli/test_help.py .

=== 5 passed in 0.70 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 36 items

src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
src/test/python/apache/aurora/client/cli/test_create.py 
src/test/python/apache/aurora/client/cli/test_diff.py ...
src/test/python/apache/aurora/client/cli/test_kill.py .
src/test/python/apache/aurora/client/cli/test_open.py .
src/test/python/apache/aurora/client/cli/test_restart.py ...
src/test/python/apache/aurora/client/cli/test_status.py ...
src/test/python/apache/aurora/client/cli/test_update.py ...

== 36 passed in 2.02 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 1 items

src/test/python/apache/aurora/client/cli/test_logging.py .

=== 1 passed in 0.65 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 3 items

src/test/python/apache/aurora/client/cli/test_plugins.py ...

=== 3 passed in 0.67 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 4 items

src/test/python/apache/aurora/client/cli/test_quota.py 

=== 4 passed in 0.67 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 5 items

src/test/python/apache/aurora/client/cli/test_sla.py .

=== 5 passed in 0.72 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 2 items

src/test/python/apache/aurora/client/cli/test_task_run.py ..

=== 2 passed in 0.65 seconds ==

Re: Review Request 20928: Command hooks: stage 2.

[Mark Chu-Carroll]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20928/#review42283
---



src/main/python/apache/aurora/client/cli/__init__.py


Done.

(Getting comments like this in a review is always a bit frustrating, 
because I just want to get stuff done. But then, I look at the code, and you're 
absolutely right, and the code is so much nicer after I fix it. This is exactly 
what makes code review so valuable. Thanks!)




src/main/python/apache/aurora/client/cli/__init__.py


I don't think so. I thought it was just 4 space indent on the next line. 
That's the style that I've used throughout the client.




src/main/python/apache/aurora/client/cli/command_hooks.py


In this case, these submethods are just there to make the condition below 
more readable. They're not intended to ever be used outside of this method 
(which is why they're privates). 

The overall method that they're part of has a good set of tests.




src/main/python/apache/aurora/client/cli/command_hooks.py


(I could have sworn I replied to this already, but reviewboard says I 
didn't. Forgive me if this is a duplicate.)

These are local private methods which only exist to make the compound 
conditional below easier to read. They should never (and in fact can never) be 
called from anywhere else.

The condition that they're part of has a decent set of tests.




src/main/python/apache/aurora/client/cli/command_hooks.py


Added an additional link at the top of the file, but I'd prefer to also 
leave this here.



src/main/python/apache/aurora/client/cli/command_hooks.py


Nope, this is the correct behavior.

The client should not abort because it couldn't read skip rules. The only 
effect that the skip rules error will have is that attempts to execute commands 
blocked by hooks won't be executable. 

We don't want the client to abort all commands because some commands might 
be block. All we want to do is let them (and the loggie service) know that 
there was a problem with the skip rules. This will get logged to loggie, 
because it's got a global handler in place.



- Mark Chu-Carroll


On May 1, 2014, 5:39 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20928/
> ---
> 
> (Updated May 1, 2014, 5:39 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Suman Karumuri.
> 
> 
> Bugs: aurora-270
> https://issues.apache.org/jira/browse/aurora-270
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> The second half of command hooks: 
> - Dynamically registered hook exceptions are provided, by fetching a hooks 
> skip rules file from a 
>   URL.
> - Hooks are loaded and activated by the noun/verb framework.
> - Hook selection and dispatch has been substantially updated.
> 
> Also did some long overdue cleanup of string quoting consistency.
> 
> 
> Diffs
> -
> 
>   3rdparty/python/BUILD 122f71db0bc6f37c19ae0f3cb2fcade8321404e6 
>   docs/design/command-hooks.md ee320ed3922928408d23a2dfdf3c42ef96e62ff7 
>   src/main/python/apache/aurora/client/cli/BUILD 
> 1bd565effb3dbe2aeb5d6156575e9316bd77c6a8 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 1e396b2263451b41cd223708f4cc4cdb1eeddbf0 
>   src/main/python/apache/aurora/client/cli/command_hooks.py 
> 2d200682209e1df83c03f9d515f3b118aaa85a99 
>   src/test/python/apache/aurora/client/cli/test_command_hooks.py 
> 7c6f70c7ef7534e9dd4986364331c67f6f7c36b1 
> 
> Diff: https://reviews.apache.org/r/20928/diff/
> 
> 
> Testing
> ---
> 
> [sun-wukong incubator-aurora (command-hooks-two)]$ !./p
> ./pants src/test/python/apache/aurora/client/cli:all
> Build operating on targets: 
> OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)])
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 4 items
> 
> src/test/python/apache/aurora/client/cli/test_bridge.py 
> 
> === 4 passed in 0.02 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 9 items
> 
> src/test/python/apache/aurora/client/cli/test_command_hooks.py ...

Review Request 21111: AURORA-388 - Update changelog to only pickup fixed issues

[Jake Farrell]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2/
---

Review request for Aurora, Kevin Sweeney and Bill Farner.


Bugs: AURORA-388
https://issues.apache.org/jira/browse/AURORA-388


Repository: aurora


Description
---

AURORA-388 - Update changelog to only pickup fixed issues

Updates the changelog jql to only pick up fixed and done issues.


Diffs
-

  build-support/release/changelog 6bd8ee9e6136c13e223bc166a06c8d80dce2468a 

Diff: https://reviews.apache.org/r/2/diff/


Testing
---

Removed CHANGELOG file and switched .auroraversion to 0.5.0 and re-ran script, 
came back with 160 issues vs the 183 currently listed.


Thanks,

Jake Farrell