Re: Review Request 29165: Add custom user agent for Aurora v1, Aurora v2 and Aurora Admin clients.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29165/#review65644 --- src/main/python/apache/aurora/common/transport.py https://reviews.apache.org/r/29165/#comment108858 does it make sense to have both session_factory and user_agent as arguments to TRequestsTransport if user_agent just gets passed directly to the session_factory anyway? seems like it would be better to facilitate the population of a user-agent by passing a custom session_factory. - Brian Wickman On Dec. 18, 2014, 1:45 a.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29165/ --- (Updated Dec. 18, 2014, 1:45 a.m.) Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Brian Wickman. Bugs: AURORA-934 https://issues.apache.org/jira/browse/AURORA-934 Repository: aurora Description --- Add custom user agent for Aurora v1, Aurora v2 and Aurora Admin clients. Diffs - src/main/python/apache/aurora/client/BUILD 2a66825426923fd7e5b7c70101747bc292208e19 src/main/python/apache/aurora/client/api/__init__.py 9977b419b58bbe2c7f860b1c6ffde6d1a791a05d src/main/python/apache/aurora/client/api/command_runner.py 4d8f0107ed6766603cb44a6b231de6cc44c3df4b src/main/python/apache/aurora/client/api/scheduler_client.py 4ae18f01380893d842674077d98caca135f7d233 src/main/python/apache/aurora/client/base.py a897e879dfda7340d7561247d3fa7cda2dbb5bc6 src/main/python/apache/aurora/client/cli/context.py b1ffc05ebd520e91be58704615c5a12c62e75f03 src/main/python/apache/aurora/client/commands/BUILD f2564839ea782b9b2492afb37756db3f0e7fa2ac src/main/python/apache/aurora/client/commands/admin.py 4b86c5a5851206d875f07c9afa9d68a8f57f5ab7 src/main/python/apache/aurora/client/commands/core.py 7b970e8872c73a30947ce8f407c37da3d06f20df src/main/python/apache/aurora/client/commands/ssh.py b0916edb0f90906e07a80302473ae7a7446f62a9 src/main/python/apache/aurora/client/factory.py 4b31e8503938a3f2af2c2d2a9a7c812cd489fa65 src/main/python/apache/aurora/common/transport.py 76e079ac4c0e7a678af7b1c38ea1398b24ce5e53 src/test/python/apache/aurora/client/api/test_scheduler_client.py b3232e9b00075c8429230fdf4858d039d3df4e36 src/test/python/apache/aurora/client/cli/test_diff.py 95c7c92942c7cbde344a093789b3e04b63200cc5 src/test/python/apache/aurora/client/commands/test_admin.py c7d970c805e7e56f9ecce159c93cd2dac14d1fca src/test/python/apache/aurora/client/commands/test_admin_sla.py 74fc79c23b4718fe0e1bc921c77533ac12c7d085 src/test/python/apache/aurora/client/commands/test_create.py d7c32b368605d14c55e87eb6e6cc04d83a8ef406 src/test/python/apache/aurora/client/commands/test_diff.py b48b53d3282d25c74a8424efe15ad19493acb3a5 src/test/python/apache/aurora/common/test_transport.py 2045f64eac638fbdccf59e7971d23b8854972654 Diff: https://reviews.apache.org/r/29165/diff/ Testing --- ./pants build src/test/python/apache/aurora:: Also ran e2e tests for v1 and v2 and verified the user agent in the scheduler logs. Thanks, Joshua Cohen
Re: Review Request 29165: Add custom user agent for Aurora v1, Aurora v2 and Aurora Admin clients.
On Dec. 19, 2014, 10:25 a.m., Brian Wickman wrote: src/main/python/apache/aurora/common/transport.py, lines 44-45 https://reviews.apache.org/r/29165/diff/3/?file=795507#file795507line44 does it make sense to have both session_factory and user_agent as arguments to TRequestsTransport if user_agent just gets passed directly to the session_factory anyway? seems like it would be better to facilitate the population of a user-agent by passing a custom session_factory. +1 - Kevin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29165/#review65644 --- On Dec. 17, 2014, 5:45 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29165/ --- (Updated Dec. 17, 2014, 5:45 p.m.) Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Brian Wickman. Bugs: AURORA-934 https://issues.apache.org/jira/browse/AURORA-934 Repository: aurora Description --- Add custom user agent for Aurora v1, Aurora v2 and Aurora Admin clients. Diffs - src/main/python/apache/aurora/client/BUILD 2a66825426923fd7e5b7c70101747bc292208e19 src/main/python/apache/aurora/client/api/__init__.py 9977b419b58bbe2c7f860b1c6ffde6d1a791a05d src/main/python/apache/aurora/client/api/command_runner.py 4d8f0107ed6766603cb44a6b231de6cc44c3df4b src/main/python/apache/aurora/client/api/scheduler_client.py 4ae18f01380893d842674077d98caca135f7d233 src/main/python/apache/aurora/client/base.py a897e879dfda7340d7561247d3fa7cda2dbb5bc6 src/main/python/apache/aurora/client/cli/context.py b1ffc05ebd520e91be58704615c5a12c62e75f03 src/main/python/apache/aurora/client/commands/BUILD f2564839ea782b9b2492afb37756db3f0e7fa2ac src/main/python/apache/aurora/client/commands/admin.py 4b86c5a5851206d875f07c9afa9d68a8f57f5ab7 src/main/python/apache/aurora/client/commands/core.py 7b970e8872c73a30947ce8f407c37da3d06f20df src/main/python/apache/aurora/client/commands/ssh.py b0916edb0f90906e07a80302473ae7a7446f62a9 src/main/python/apache/aurora/client/factory.py 4b31e8503938a3f2af2c2d2a9a7c812cd489fa65 src/main/python/apache/aurora/common/transport.py 76e079ac4c0e7a678af7b1c38ea1398b24ce5e53 src/test/python/apache/aurora/client/api/test_scheduler_client.py b3232e9b00075c8429230fdf4858d039d3df4e36 src/test/python/apache/aurora/client/cli/test_diff.py 95c7c92942c7cbde344a093789b3e04b63200cc5 src/test/python/apache/aurora/client/commands/test_admin.py c7d970c805e7e56f9ecce159c93cd2dac14d1fca src/test/python/apache/aurora/client/commands/test_admin_sla.py 74fc79c23b4718fe0e1bc921c77533ac12c7d085 src/test/python/apache/aurora/client/commands/test_create.py d7c32b368605d14c55e87eb6e6cc04d83a8ef406 src/test/python/apache/aurora/client/commands/test_diff.py b48b53d3282d25c74a8424efe15ad19493acb3a5 src/test/python/apache/aurora/common/test_transport.py 2045f64eac638fbdccf59e7971d23b8854972654 Diff: https://reviews.apache.org/r/29165/diff/ Testing --- ./pants build src/test/python/apache/aurora:: Also ran e2e tests for v1 and v2 and verified the user agent in the scheduler logs. Thanks, Joshua Cohen
Re: Review Request 29165: Add custom user agent for Aurora v1, Aurora v2 and Aurora Admin clients.
On Dec. 19, 2014, 6:25 p.m., Brian Wickman wrote: src/main/python/apache/aurora/common/transport.py, lines 44-45 https://reviews.apache.org/r/29165/diff/3/?file=795507#file795507line44 does it make sense to have both session_factory and user_agent as arguments to TRequestsTransport if user_agent just gets passed directly to the session_factory anyway? seems like it would be better to facilitate the population of a user-agent by passing a custom session_factory. Kevin Sweeney wrote: +1 Joshua Cohen wrote: I went back and forth on this. My thinking was the default session factory might do work that we wouldn't want to replicate everywhere that we want to pass in a custom user agent. How would you feel if instead of passing the user agent to the session factory, we explicitly set the user agent on the returned session if the header is not already present? Brian Wickman wrote: This sounds fine to me. Ok, done! - Joshua --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29165/#review65644 --- On Dec. 19, 2014, 7:39 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29165/ --- (Updated Dec. 19, 2014, 7:39 p.m.) Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Brian Wickman. Bugs: AURORA-934 https://issues.apache.org/jira/browse/AURORA-934 Repository: aurora Description --- Add custom user agent for Aurora v1, Aurora v2 and Aurora Admin clients. Diffs - src/main/python/apache/aurora/client/BUILD 2a66825426923fd7e5b7c70101747bc292208e19 src/main/python/apache/aurora/client/api/__init__.py 9977b419b58bbe2c7f860b1c6ffde6d1a791a05d src/main/python/apache/aurora/client/api/command_runner.py 4d8f0107ed6766603cb44a6b231de6cc44c3df4b src/main/python/apache/aurora/client/api/scheduler_client.py 4ae18f01380893d842674077d98caca135f7d233 src/main/python/apache/aurora/client/base.py a897e879dfda7340d7561247d3fa7cda2dbb5bc6 src/main/python/apache/aurora/client/cli/context.py b1ffc05ebd520e91be58704615c5a12c62e75f03 src/main/python/apache/aurora/client/commands/BUILD f2564839ea782b9b2492afb37756db3f0e7fa2ac src/main/python/apache/aurora/client/commands/admin.py 4b86c5a5851206d875f07c9afa9d68a8f57f5ab7 src/main/python/apache/aurora/client/commands/core.py 7b970e8872c73a30947ce8f407c37da3d06f20df src/main/python/apache/aurora/client/commands/ssh.py b0916edb0f90906e07a80302473ae7a7446f62a9 src/main/python/apache/aurora/client/factory.py 4b31e8503938a3f2af2c2d2a9a7c812cd489fa65 src/main/python/apache/aurora/common/transport.py 76e079ac4c0e7a678af7b1c38ea1398b24ce5e53 src/test/python/apache/aurora/client/api/test_scheduler_client.py b3232e9b00075c8429230fdf4858d039d3df4e36 src/test/python/apache/aurora/client/cli/test_diff.py 95c7c92942c7cbde344a093789b3e04b63200cc5 src/test/python/apache/aurora/client/commands/test_admin.py c7d970c805e7e56f9ecce159c93cd2dac14d1fca src/test/python/apache/aurora/client/commands/test_admin_sla.py 74fc79c23b4718fe0e1bc921c77533ac12c7d085 src/test/python/apache/aurora/client/commands/test_create.py d7c32b368605d14c55e87eb6e6cc04d83a8ef406 src/test/python/apache/aurora/client/commands/test_diff.py b48b53d3282d25c74a8424efe15ad19493acb3a5 src/test/python/apache/aurora/common/test_transport.py 2045f64eac638fbdccf59e7971d23b8854972654 Diff: https://reviews.apache.org/r/29165/diff/ Testing --- ./pants build src/test/python/apache/aurora:: Also ran e2e tests for v1 and v2 and verified the user agent in the scheduler logs. Thanks, Joshua Cohen
Review Request 29267: Remove unused 3rdparty dependencies.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29267/ --- Review request for Aurora and Brian Wickman. Repository: aurora Description --- Remove unused 3rdparty dependencies. Wire up tests not linked to src/test/python:all Remove unused tests. Diffs - 3rdparty/python/requirements.txt 9d9e966fbfc2ac9c06e6784d41e83c7971e09895 src/test/python/apache/aurora/client/BUILD e31e434723a8aa884bc528987b8aa98077ec0548 src/test/python/apache/aurora/executor/BUILD 3095f2a148b21365ea2f500039adb5710a187fa1 src/test/python/apache/aurora/executor/common/BUILD 4fa80b82f36afbb8224187c63f7d223750d8b5ea src/test/python/apache/aurora/executor/test_executor_builds.py be6800ffc42fed07ca9171d7f36331e284b224b7 Diff: https://reviews.apache.org/r/29267/diff/ Testing --- Listed leaf dependencies: ```bash for target in $(./pants goal list :: 2/dev/null); do if [[ -z $(./pants goal dependees $target 2/dev/null) ]]; then echo $target fi done ``` Thanks, Kevin Sweeney
Re: Review Request 29165: Add custom user agent for Aurora v1, Aurora v2 and Aurora Admin clients.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29165/#review65664 --- Ship it! Master (9042c56) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Dec. 19, 2014, 7:39 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29165/ --- (Updated Dec. 19, 2014, 7:39 p.m.) Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Brian Wickman. Bugs: AURORA-934 https://issues.apache.org/jira/browse/AURORA-934 Repository: aurora Description --- Add custom user agent for Aurora v1, Aurora v2 and Aurora Admin clients. Diffs - src/main/python/apache/aurora/client/BUILD 2a66825426923fd7e5b7c70101747bc292208e19 src/main/python/apache/aurora/client/api/__init__.py 9977b419b58bbe2c7f860b1c6ffde6d1a791a05d src/main/python/apache/aurora/client/api/command_runner.py 4d8f0107ed6766603cb44a6b231de6cc44c3df4b src/main/python/apache/aurora/client/api/scheduler_client.py 4ae18f01380893d842674077d98caca135f7d233 src/main/python/apache/aurora/client/base.py a897e879dfda7340d7561247d3fa7cda2dbb5bc6 src/main/python/apache/aurora/client/cli/context.py b1ffc05ebd520e91be58704615c5a12c62e75f03 src/main/python/apache/aurora/client/commands/BUILD f2564839ea782b9b2492afb37756db3f0e7fa2ac src/main/python/apache/aurora/client/commands/admin.py 4b86c5a5851206d875f07c9afa9d68a8f57f5ab7 src/main/python/apache/aurora/client/commands/core.py 7b970e8872c73a30947ce8f407c37da3d06f20df src/main/python/apache/aurora/client/commands/ssh.py b0916edb0f90906e07a80302473ae7a7446f62a9 src/main/python/apache/aurora/client/factory.py 4b31e8503938a3f2af2c2d2a9a7c812cd489fa65 src/main/python/apache/aurora/common/transport.py 76e079ac4c0e7a678af7b1c38ea1398b24ce5e53 src/test/python/apache/aurora/client/api/test_scheduler_client.py b3232e9b00075c8429230fdf4858d039d3df4e36 src/test/python/apache/aurora/client/cli/test_diff.py 95c7c92942c7cbde344a093789b3e04b63200cc5 src/test/python/apache/aurora/client/commands/test_admin.py c7d970c805e7e56f9ecce159c93cd2dac14d1fca src/test/python/apache/aurora/client/commands/test_admin_sla.py 74fc79c23b4718fe0e1bc921c77533ac12c7d085 src/test/python/apache/aurora/client/commands/test_create.py d7c32b368605d14c55e87eb6e6cc04d83a8ef406 src/test/python/apache/aurora/client/commands/test_diff.py b48b53d3282d25c74a8424efe15ad19493acb3a5 src/test/python/apache/aurora/common/test_transport.py 2045f64eac638fbdccf59e7971d23b8854972654 Diff: https://reviews.apache.org/r/29165/diff/ Testing --- ./pants build src/test/python/apache/aurora:: Also ran e2e tests for v1 and v2 and verified the user agent in the scheduler logs. Thanks, Joshua Cohen
Re: Review Request 29267: Remove unused 3rdparty dependencies.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29267/#review65667 --- Ship it! Please file an issue to implement the equivalent test_executor_builds functionality into CI. - Brian Wickman On Dec. 19, 2014, 8:04 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29267/ --- (Updated Dec. 19, 2014, 8:04 p.m.) Review request for Aurora and Brian Wickman. Repository: aurora Description --- Remove unused 3rdparty dependencies. Wire up tests not linked to src/test/python:all Remove unused tests. Diffs - 3rdparty/python/requirements.txt 9d9e966fbfc2ac9c06e6784d41e83c7971e09895 src/test/python/apache/aurora/client/BUILD e31e434723a8aa884bc528987b8aa98077ec0548 src/test/python/apache/aurora/executor/BUILD 3095f2a148b21365ea2f500039adb5710a187fa1 src/test/python/apache/aurora/executor/common/BUILD 4fa80b82f36afbb8224187c63f7d223750d8b5ea src/test/python/apache/aurora/executor/test_executor_builds.py be6800ffc42fed07ca9171d7f36331e284b224b7 Diff: https://reviews.apache.org/r/29267/diff/ Testing --- Listed leaf dependencies: ```bash for target in $(./pants goal list :: 2/dev/null); do if [[ -z $(./pants goal dependees $target 2/dev/null) ]]; then echo $target fi done ``` Thanks, Kevin Sweeney
Re: Review Request 29267: Remove unused 3rdparty dependencies.
On Dec. 19, 2014, 12:17 p.m., Brian Wickman wrote: Please file an issue to implement the equivalent test_executor_builds functionality into CI. Done - filed https://issues.apache.org/jira/browse/AURORA-977 - Kevin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29267/#review65667 --- On Dec. 19, 2014, 12:04 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29267/ --- (Updated Dec. 19, 2014, 12:04 p.m.) Review request for Aurora and Brian Wickman. Repository: aurora Description --- Remove unused 3rdparty dependencies. Wire up tests not linked to src/test/python:all Remove unused tests. Diffs - 3rdparty/python/requirements.txt 9d9e966fbfc2ac9c06e6784d41e83c7971e09895 src/test/python/apache/aurora/client/BUILD e31e434723a8aa884bc528987b8aa98077ec0548 src/test/python/apache/aurora/executor/BUILD 3095f2a148b21365ea2f500039adb5710a187fa1 src/test/python/apache/aurora/executor/common/BUILD 4fa80b82f36afbb8224187c63f7d223750d8b5ea src/test/python/apache/aurora/executor/test_executor_builds.py be6800ffc42fed07ca9171d7f36331e284b224b7 Diff: https://reviews.apache.org/r/29267/diff/ Testing --- Listed leaf dependencies: ```bash for target in $(./pants goal list :: 2/dev/null); do if [[ -z $(./pants goal dependees $target 2/dev/null) ]]; then echo $target fi done ``` Thanks, Kevin Sweeney
Re: Review Request 29267: Remove unused 3rdparty dependencies.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29267/#review65672 --- Ship it! Master (9042c56) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Dec. 19, 2014, 8:04 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29267/ --- (Updated Dec. 19, 2014, 8:04 p.m.) Review request for Aurora and Brian Wickman. Repository: aurora Description --- Remove unused 3rdparty dependencies. Wire up tests not linked to src/test/python:all Remove unused tests. Diffs - 3rdparty/python/requirements.txt 9d9e966fbfc2ac9c06e6784d41e83c7971e09895 src/test/python/apache/aurora/client/BUILD e31e434723a8aa884bc528987b8aa98077ec0548 src/test/python/apache/aurora/executor/BUILD 3095f2a148b21365ea2f500039adb5710a187fa1 src/test/python/apache/aurora/executor/common/BUILD 4fa80b82f36afbb8224187c63f7d223750d8b5ea src/test/python/apache/aurora/executor/test_executor_builds.py be6800ffc42fed07ca9171d7f36331e284b224b7 Diff: https://reviews.apache.org/r/29267/diff/ Testing --- Listed leaf dependencies: ```bash for target in $(./pants goal list :: 2/dev/null); do if [[ -z $(./pants goal dependees $target 2/dev/null) ]]; then echo $target fi done ``` Thanks, Kevin Sweeney
Re: Review Request 29165: Add custom user agent for Aurora v1, Aurora v2 and Aurora Admin clients.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29165/#review65684 --- Ship it! Ship It! - Brian Wickman On Dec. 19, 2014, 7:39 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29165/ --- (Updated Dec. 19, 2014, 7:39 p.m.) Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Brian Wickman. Bugs: AURORA-934 https://issues.apache.org/jira/browse/AURORA-934 Repository: aurora Description --- Add custom user agent for Aurora v1, Aurora v2 and Aurora Admin clients. Diffs - src/main/python/apache/aurora/client/BUILD 2a66825426923fd7e5b7c70101747bc292208e19 src/main/python/apache/aurora/client/api/__init__.py 9977b419b58bbe2c7f860b1c6ffde6d1a791a05d src/main/python/apache/aurora/client/api/command_runner.py 4d8f0107ed6766603cb44a6b231de6cc44c3df4b src/main/python/apache/aurora/client/api/scheduler_client.py 4ae18f01380893d842674077d98caca135f7d233 src/main/python/apache/aurora/client/base.py a897e879dfda7340d7561247d3fa7cda2dbb5bc6 src/main/python/apache/aurora/client/cli/context.py b1ffc05ebd520e91be58704615c5a12c62e75f03 src/main/python/apache/aurora/client/commands/BUILD f2564839ea782b9b2492afb37756db3f0e7fa2ac src/main/python/apache/aurora/client/commands/admin.py 4b86c5a5851206d875f07c9afa9d68a8f57f5ab7 src/main/python/apache/aurora/client/commands/core.py 7b970e8872c73a30947ce8f407c37da3d06f20df src/main/python/apache/aurora/client/commands/ssh.py b0916edb0f90906e07a80302473ae7a7446f62a9 src/main/python/apache/aurora/client/factory.py 4b31e8503938a3f2af2c2d2a9a7c812cd489fa65 src/main/python/apache/aurora/common/transport.py 76e079ac4c0e7a678af7b1c38ea1398b24ce5e53 src/test/python/apache/aurora/client/api/test_scheduler_client.py b3232e9b00075c8429230fdf4858d039d3df4e36 src/test/python/apache/aurora/client/cli/test_diff.py 95c7c92942c7cbde344a093789b3e04b63200cc5 src/test/python/apache/aurora/client/commands/test_admin.py c7d970c805e7e56f9ecce159c93cd2dac14d1fca src/test/python/apache/aurora/client/commands/test_admin_sla.py 74fc79c23b4718fe0e1bc921c77533ac12c7d085 src/test/python/apache/aurora/client/commands/test_create.py d7c32b368605d14c55e87eb6e6cc04d83a8ef406 src/test/python/apache/aurora/client/commands/test_diff.py b48b53d3282d25c74a8424efe15ad19493acb3a5 src/test/python/apache/aurora/common/test_transport.py 2045f64eac638fbdccf59e7971d23b8854972654 Diff: https://reviews.apache.org/r/29165/diff/ Testing --- ./pants build src/test/python/apache/aurora:: Also ran e2e tests for v1 and v2 and verified the user agent in the scheduler logs. Thanks, Joshua Cohen
Review Request 29271: Removing cron schedule support from createJob and killTasks
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29271/ --- Review request for Aurora and Kevin Sweeney. Bugs: AURORA-454AURORA-976 https://issues.apache.org/jira/browse/AURORA-454AURORA-976 Repository: aurora Description --- While working on AURORA-454, realized we have a bigger problem with cron schedules killing non-cron jobs. Field AURORA-976, which is also addressed in this diff. Diffs - src/main/java/org/apache/aurora/scheduler/base/Query.java a6ff14a69a32965a87a7a3a6d73ef53f5bdf75c0 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 6e3caa164e4b98907e1a87460aab3afb9be95ef9 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 8d41e7011344aa6a9ba39feacc166dd3c3e64227 Diff: https://reviews.apache.org/r/29271/diff/ Testing --- ./gradlew -Pq build ``` $ aurora cron schedule devcluster/www-data/prod/hello aurora/examples/jobs/cron_hello_world.aurora INFO] Registering job hello with cron Error scheduling cron job devcluster/www-data/prod/hello: Job www-data/prod/hello already exists $ aurora job create devcluster/www-data/prod/hello aurora/examples/jobs/hello_world.aurora INFO] Creating job hello Job creation failed due to error: Job www-data/prod/hello already exists ``` Thanks, Maxim Khutornenko
Review Request 29275: Fixing build break.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29275/ --- Review request for Aurora and Brian Wickman. Repository: aurora Description --- Couple of tests changes escaped in https://reviews.apache.org/r/29165 Diffs - src/test/python/apache/aurora/client/api/test_api.py c91e74e78a35eef7fc48dcb2a00d1bd3c6cb7291 src/test/python/apache/aurora/client/hooks/test_hooked_api.py c2063f2e5fc31761cda0e87d45f6f3e5011a7a63 Diff: https://reviews.apache.org/r/29275/diff/ Testing --- ./pants src/test/python:all Thanks, Maxim Khutornenko
Re: Review Request 29275: Fixing build break.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29275/#review65695 --- Ship it! Ship It! - Brian Wickman On Dec. 19, 2014, 10:46 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29275/ --- (Updated Dec. 19, 2014, 10:46 p.m.) Review request for Aurora and Brian Wickman. Repository: aurora Description --- Couple of tests changes escaped in https://reviews.apache.org/r/29165 Diffs - src/test/python/apache/aurora/client/api/test_api.py c91e74e78a35eef7fc48dcb2a00d1bd3c6cb7291 src/test/python/apache/aurora/client/hooks/test_hooked_api.py c2063f2e5fc31761cda0e87d45f6f3e5011a7a63 Diff: https://reviews.apache.org/r/29275/diff/ Testing --- ./pants src/test/python:all Thanks, Maxim Khutornenko
Re: Review Request 29271: Removing cron schedule support from createJob and killTasks
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29271/#review65697 --- Ship it! Master (84ad650) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Dec. 19, 2014, 10:08 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29271/ --- (Updated Dec. 19, 2014, 10:08 p.m.) Review request for Aurora and Kevin Sweeney. Bugs: AURORA-454 AURORA-976 https://issues.apache.org/jira/browse/AURORA-454 AURORA-976 Repository: aurora Description --- While working on AURORA-454, realized we have a bigger problem with cron schedules killing non-cron jobs. Field AURORA-976, which is also addressed in this diff. Diffs - src/main/java/org/apache/aurora/scheduler/base/Query.java a6ff14a69a32965a87a7a3a6d73ef53f5bdf75c0 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 6e3caa164e4b98907e1a87460aab3afb9be95ef9 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 8d41e7011344aa6a9ba39feacc166dd3c3e64227 Diff: https://reviews.apache.org/r/29271/diff/ Testing --- ./gradlew -Pq build ``` $ aurora cron schedule devcluster/www-data/prod/hello aurora/examples/jobs/cron_hello_world.aurora INFO] Registering job hello with cron Error scheduling cron job devcluster/www-data/prod/hello: Job www-data/prod/hello already exists $ aurora job create devcluster/www-data/prod/hello aurora/examples/jobs/hello_world.aurora INFO] Creating job hello Job creation failed due to error: Job www-data/prod/hello already exists ``` Thanks, Maxim Khutornenko
Review Request 29286: Fix BUILD files in apache.aurora.admin and apache.aurora.client.api.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29286/ --- Review request for Aurora and Brian Wickman. Repository: aurora Description --- Fix BUILD files in apache.aurora.admin and apache.aurora.client.api. Diffs - src/main/python/apache/aurora/admin/BUILD f874264bdf07a9cbb2f0990739be3c95f851b040 src/main/python/apache/aurora/admin/host_maintenance.py 8fa5182fae509493def7175635fbe1cb79fa3eec src/main/python/apache/aurora/client/api/BUILD 65e5a85e23c4c698356c8b45c45943e560c1bcd5 src/main/python/apache/aurora/client/api/command_runner.py 48cb567c2098620e0ee322fe9528e167ce7c7c62 src/main/python/apache/aurora/client/api/disambiguator.py 6a78ccd44533ef327f751a08c9e2e16555354d97 src/test/python/apache/aurora/admin/BUILD 3a216809d1e31247f7d01451fcc7fd877a4c1fb2 src/test/python/apache/aurora/client/api/BUILD 2c0c4070cc1f1784b1d4e7f9cd8aac236e97be75 src/test/python/apache/aurora/client/api/test_task_util.py 048aff6874259810efea463df1ca2a1fdc419ca1 Diff: https://reviews.apache.org/r/29286/diff/ Testing --- ./pants src/test/python:all Thanks, Kevin Sweeney
Re: Review Request 29286: Fix BUILD files in apache.aurora.admin and apache.aurora.client.api.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29286/#review65725 --- Ship it! Master (84ad650) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Dec. 20, 2014, 3:05 a.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29286/ --- (Updated Dec. 20, 2014, 3:05 a.m.) Review request for Aurora and Brian Wickman. Repository: aurora Description --- Fix BUILD files in apache.aurora.admin and apache.aurora.client.api. Diffs - src/main/python/apache/aurora/admin/BUILD f874264bdf07a9cbb2f0990739be3c95f851b040 src/main/python/apache/aurora/admin/host_maintenance.py 8fa5182fae509493def7175635fbe1cb79fa3eec src/main/python/apache/aurora/client/api/BUILD 65e5a85e23c4c698356c8b45c45943e560c1bcd5 src/main/python/apache/aurora/client/api/command_runner.py 48cb567c2098620e0ee322fe9528e167ce7c7c62 src/main/python/apache/aurora/client/api/disambiguator.py 6a78ccd44533ef327f751a08c9e2e16555354d97 src/test/python/apache/aurora/admin/BUILD 3a216809d1e31247f7d01451fcc7fd877a4c1fb2 src/test/python/apache/aurora/client/api/BUILD 2c0c4070cc1f1784b1d4e7f9cd8aac236e97be75 src/test/python/apache/aurora/client/api/test_task_util.py 048aff6874259810efea463df1ca2a1fdc419ca1 Diff: https://reviews.apache.org/r/29286/diff/ Testing --- ./pants src/test/python:all Thanks, Kevin Sweeney
Re: Review Request 29286: Fix BUILD files in apache.aurora.admin and apache.aurora.client.api.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29286/#review65729 --- Ship it! Ship It! - Joe Smith On Dec. 19, 2014, 7:05 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29286/ --- (Updated Dec. 19, 2014, 7:05 p.m.) Review request for Aurora and Brian Wickman. Repository: aurora Description --- Fix BUILD files in apache.aurora.admin and apache.aurora.client.api. Diffs - src/main/python/apache/aurora/admin/BUILD f874264bdf07a9cbb2f0990739be3c95f851b040 src/main/python/apache/aurora/admin/host_maintenance.py 8fa5182fae509493def7175635fbe1cb79fa3eec src/main/python/apache/aurora/client/api/BUILD 65e5a85e23c4c698356c8b45c45943e560c1bcd5 src/main/python/apache/aurora/client/api/command_runner.py 48cb567c2098620e0ee322fe9528e167ce7c7c62 src/main/python/apache/aurora/client/api/disambiguator.py 6a78ccd44533ef327f751a08c9e2e16555354d97 src/test/python/apache/aurora/admin/BUILD 3a216809d1e31247f7d01451fcc7fd877a4c1fb2 src/test/python/apache/aurora/client/api/BUILD 2c0c4070cc1f1784b1d4e7f9cd8aac236e97be75 src/test/python/apache/aurora/client/api/test_task_util.py 048aff6874259810efea463df1ca2a1fdc419ca1 Diff: https://reviews.apache.org/r/29286/diff/ Testing --- ./pants src/test/python:all Thanks, Kevin Sweeney
