[Impala-ASF-CR](asf-site) Adding issues-all mailing list.

[Jim Apple (Code Review)]

Jim Apple has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10257 )

Change subject: Adding issues-all mailing list.
..


Patch Set 1: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/10257
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib629b11e0fc80b0c9b5bf1be5dd58d24845f6524
Gerrit-Change-Number: 10257
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger 
Gerrit-Reviewer: Jim Apple 
Gerrit-Comment-Date: Tue, 01 May 2018 05:12:05 +
Gerrit-HasComments: No

[Impala-ASF-CR](asf-site) [DOCS] Update the latest impala docs to 2.12

[Alex Rodoni (Code Review)]

Alex Rodoni has abandoned this change. ( http://gerrit.cloudera.org:8080/10253 )

Change subject: [DOCS] Update the latest impala docs to 2.12
..


Abandoned

Still trying to fix the current version number issue
--
To view, visit http://gerrit.cloudera.org:8080/10253
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: abandon
Gerrit-Change-Id: I701cd1ef760e6955e1c787a58639130c7cb786d8
Gerrit-Change-Number: 10253
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Ambreen Kazi 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Sailesh Mukil 

[Impala-ASF-CR](asf-site) [DOCS] Add Impala docs from branch 2.x

[Alex Rodoni (Code Review)]

Alex Rodoni has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/10258


Change subject: [DOCS] Add Impala docs from branch 2.x
..

[DOCS] Add Impala docs from branch 2.x

Add Impala docs from branch master, commit hash:
9c32594f722f139955788d0da57bdeecc3bacf75

Change-Id: I4e94fb12984974e280d3c6aeab384c1021b7f76a
---
M docs/build/html/index.html
A docs/build/html/shared/ImpalaVariables.html
A docs/build/html/shared/impala_common.html
M docs/build/html/topics/impala_abort_on_default_limit_exceeded.html
M docs/build/html/topics/impala_abort_on_error.html
M docs/build/html/topics/impala_adls.html
M docs/build/html/topics/impala_admin.html
M docs/build/html/topics/impala_admission.html
M docs/build/html/topics/impala_aggregate_functions.html
M docs/build/html/topics/impala_aliases.html
M docs/build/html/topics/impala_allow_unsupported_formats.html
M docs/build/html/topics/impala_alter_table.html
M docs/build/html/topics/impala_alter_view.html
M docs/build/html/topics/impala_analytic_functions.html
M docs/build/html/topics/impala_appx_count_distinct.html
M docs/build/html/topics/impala_appx_median.html
M docs/build/html/topics/impala_array.html
M docs/build/html/topics/impala_auditing.html
M docs/build/html/topics/impala_authentication.html
M docs/build/html/topics/impala_authorization.html
M docs/build/html/topics/impala_avg.html
M docs/build/html/topics/impala_avro.html
M docs/build/html/topics/impala_batch_size.html
M docs/build/html/topics/impala_bigint.html
M docs/build/html/topics/impala_bit_functions.html
M docs/build/html/topics/impala_boolean.html
M docs/build/html/topics/impala_breakpad.html
M docs/build/html/topics/impala_buffer_pool_limit.html
M docs/build/html/topics/impala_char.html
M docs/build/html/topics/impala_comments.html
M docs/build/html/topics/impala_complex_types.html
M docs/build/html/topics/impala_components.html
M docs/build/html/topics/impala_compression_codec.html
M docs/build/html/topics/impala_compute_stats.html
A docs/build/html/topics/impala_compute_stats_min_sample_size.html
M docs/build/html/topics/impala_concepts.html
M docs/build/html/topics/impala_conditional_functions.html
M docs/build/html/topics/impala_config.html
M docs/build/html/topics/impala_config_options.html
M docs/build/html/topics/impala_config_performance.html
M docs/build/html/topics/impala_connecting.html
M docs/build/html/topics/impala_conversion_functions.html
M docs/build/html/topics/impala_count.html
M docs/build/html/topics/impala_create_database.html
M docs/build/html/topics/impala_create_function.html
M docs/build/html/topics/impala_create_role.html
M docs/build/html/topics/impala_create_table.html
M docs/build/html/topics/impala_create_view.html
M docs/build/html/topics/impala_databases.html
M docs/build/html/topics/impala_datatypes.html
M docs/build/html/topics/impala_datetime_functions.html
M docs/build/html/topics/impala_ddl.html
M docs/build/html/topics/impala_debug_action.html
M docs/build/html/topics/impala_decimal.html
M docs/build/html/topics/impala_decimal_v2.html
M docs/build/html/topics/impala_default_join_distribution_mode.html
M docs/build/html/topics/impala_default_order_by_limit.html
M docs/build/html/topics/impala_default_spillable_buffer_size.html
M docs/build/html/topics/impala_delegation.html
M docs/build/html/topics/impala_delete.html
M docs/build/html/topics/impala_describe.html
M docs/build/html/topics/impala_development.html
M docs/build/html/topics/impala_disable_codegen.html
M docs/build/html/topics/impala_disable_row_runtime_filtering.html
M docs/build/html/topics/impala_disable_streaming_preaggregations.html
M docs/build/html/topics/impala_disable_unsafe_spills.html
M docs/build/html/topics/impala_disk_space.html
M docs/build/html/topics/impala_distinct.html
M docs/build/html/topics/impala_dml.html
M docs/build/html/topics/impala_double.html
M docs/build/html/topics/impala_drop_database.html
M docs/build/html/topics/impala_drop_function.html
M docs/build/html/topics/impala_drop_role.html
M docs/build/html/topics/impala_drop_stats.html
M docs/build/html/topics/impala_drop_table.html
M docs/build/html/topics/impala_drop_view.html
M docs/build/html/topics/impala_exec_single_node_rows_threshold.html
A docs/build/html/topics/impala_exec_time_limit_s.html
M docs/build/html/topics/impala_explain.html
M docs/build/html/topics/impala_explain_level.html
M docs/build/html/topics/impala_explain_plan.html
M docs/build/html/topics/impala_faq.html
M docs/build/html/topics/impala_file_formats.html
M docs/build/html/topics/impala_fixed_issues.html
M docs/build/html/topics/impala_float.html
M docs/build/html/topics/impala_functions.html
M docs/build/html/topics/impala_functions_overview.html
M docs/build/html/topics/impala_grant.html
M docs/build/html/topics/impala_group_by.html
M docs/build/html/topics/impala_group_concat.html
M docs/build/html/topics/impala_hadoop.html
M 

[Impala-ASF-CR] Speed up Python dependencies.

[Lars Volker (Code Review)]

Lars Volker has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10234 )

Change subject: Speed up Python dependencies.
..


Patch Set 4: Code-Review+2

(3 comments)

I left a few nits that could reduce the code a bit, but I'm also good to limit 
this change to adding parallelism. Apologies for the incremental review.

http://gerrit.cloudera.org:8080/#/c/10234/4/infra/python/deps/pip_download.py
File infra/python/deps/pip_download.py:

http://gerrit.cloudera.org:8080/#/c/10234/4/infra/python/deps/pip_download.py@141
PS4, Line 141: for line in file(requirements_file):
Nit: prefer open (https://docs.python.org/2/library/functions.html#file)


http://gerrit.cloudera.org:8080/#/c/10234/4/infra/python/deps/pip_download.py@150
PS4, Line 150: semi_colon_index = line.find(';')
 :   if semi_colon_index != -1:
 : line = line[:semi_colon_index]
 :   l = line.strip()
These four lines can be simplified as:

line.split(';')[0].strip()

The same works for hash_index above.


http://gerrit.cloudera.org:8080/#/c/10234/4/infra/python/deps/pip_download.py@154
PS4, Line 154:   if len(l) > 0:
Invert check and use continue to reduce nesting:

  if not line:
continue



--
To view, visit http://gerrit.cloudera.org:8080/10234
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7cbf622adb7d037f1a53c519402dcd8ae3c0fe30
Gerrit-Change-Number: 10234
Gerrit-PatchSet: 4
Gerrit-Owner: Philip Zeyliger 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Taras Bobrovytsky 
Gerrit-Comment-Date: Tue, 01 May 2018 04:21:29 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] Speed up Python dependencies.

[Philip Zeyliger (Code Review)]

Philip Zeyliger has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10234 )

Change subject: Speed up Python dependencies.
..


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/10234/3/infra/python/deps/pip_download.py
File infra/python/deps/pip_download.py:

http://gerrit.cloudera.org:8080/#/c/10234/3/infra/python/deps/pip_download.py@140
PS3, Line 140: f = open(requirements_file, 'r')
> While you are making changes here, you could actually change this to "for l
Done


http://gerrit.cloudera.org:8080/#/c/10234/3/infra/python/deps/pip_download.py@158
PS3, Line 158:   if pool:
> This check seems unnecessary now
Done



--
To view, visit http://gerrit.cloudera.org:8080/10234
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7cbf622adb7d037f1a53c519402dcd8ae3c0fe30
Gerrit-Change-Number: 10234
Gerrit-PatchSet: 3
Gerrit-Owner: Philip Zeyliger 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Taras Bobrovytsky 
Gerrit-Comment-Date: Tue, 01 May 2018 04:03:09 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6337: Fix infinite loop in Impala shell

[Fredy Wijaya (Code Review)]

Fredy Wijaya has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9195 )

Change subject: IMPALA-6337: Fix infinite loop in Impala shell
..


Patch Set 11:

I just realized we can roll out a bug fix in shell/ext-py/sqlparse-0.0.14. The 
patch in sqlparse-0.1.14 is based on 
https://github.com/andialbrecht/sqlparse/pull/396 with slight modification to 
work on sqlparse-0.0.14.


--
To view, visit http://gerrit.cloudera.org:8080/9195
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9142f21a888189d351f00ce09baeba123bc0959b
Gerrit-Change-Number: 9195
Gerrit-PatchSet: 11
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Taras Bobrovytsky 
Gerrit-Reviewer: Vuk Ercegovac 
Gerrit-Comment-Date: Tue, 01 May 2018 04:02:03 +
Gerrit-HasComments: No

[Impala-ASF-CR] Speed up Python dependencies.

[Philip Zeyliger (Code Review)]

Hello Taras Bobrovytsky, Lars Volker, Michael Brown, Joe McDonnell,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/10234

to look at the new patch set (#4).

Change subject: Speed up Python dependencies.
..

Speed up Python dependencies.

This parallelizes downloading some Python libraries, giving a speedup of
$IMPALA_HOME/infra/python/deps/download_requirements.  I've seen this
take from 7-15 seconds before and from 2-5 seconds after.

I also checked that we always have at least Python 2.6 when
building Impala, so I was able to remove the try/except
handling in bootstrap_toolchain.

Change-Id: I7cbf622adb7d037f1a53c519402dcd8ae3c0fe30
---
M bin/bootstrap_toolchain.py
M infra/python/deps/pip_download.py
2 files changed, 31 insertions(+), 33 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/34/10234/4
--
To view, visit http://gerrit.cloudera.org:8080/10234
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7cbf622adb7d037f1a53c519402dcd8ae3c0fe30
Gerrit-Change-Number: 10234
Gerrit-PatchSet: 4
Gerrit-Owner: Philip Zeyliger 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Taras Bobrovytsky 

[Impala-ASF-CR] IMPALA-6337: Fix infinite loop in Impala shell

[Fredy Wijaya (Code Review)]

Fredy Wijaya has uploaded a new patch set (#11). ( 
http://gerrit.cloudera.org:8080/9195 )

Change subject: IMPALA-6337: Fix infinite loop in Impala shell
..

IMPALA-6337: Fix infinite loop in Impala shell

This patch fixes a bug in sqlparse where sqlparse incorrectly splits a
statement that has a new line inside double quotes. The bug in sqlparse
causes Impala shell to go to infinite loop when a statement contains a
new line inside double quotes.

Testing:
- Added new end-to-end shell tests
- Ran end-to-end shell tests

Change-Id: I9142f21a888189d351f00ce09baeba123bc0959b
---
M shell/ext-py/sqlparse-0.1.14/sqlparse/lexer.py
M shell/ext-py/sqlparse-0.1.14/tests/test_split.py
M tests/shell/test_shell_interactive.py
3 files changed, 24 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/95/9195/11
--
To view, visit http://gerrit.cloudera.org:8080/9195
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9142f21a888189d351f00ce09baeba123bc0959b
Gerrit-Change-Number: 9195
Gerrit-PatchSet: 11
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Taras Bobrovytsky 
Gerrit-Reviewer: Vuk Ercegovac 

[Impala-ASF-CR] IMPALA-6337: Fix infinite loop in Impala shell

[Fredy Wijaya (Code Review)]

Fredy Wijaya has restored this change. ( http://gerrit.cloudera.org:8080/9195 )

Change subject: IMPALA-6337: Fix infinite loop in Impala shell
..


Restored
-- 
To view, visit http://gerrit.cloudera.org:8080/9195
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: restore
Gerrit-Change-Id: I9142f21a888189d351f00ce09baeba123bc0959b
Gerrit-Change-Number: 9195
Gerrit-PatchSet: 10
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Taras Bobrovytsky 
Gerrit-Reviewer: Vuk Ercegovac 

[Impala-ASF-CR] Speed up Python dependencies.

[Lars Volker (Code Review)]

Lars Volker has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10234 )

Change subject: Speed up Python dependencies.
..


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/10234/3/infra/python/deps/pip_download.py
File infra/python/deps/pip_download.py:

http://gerrit.cloudera.org:8080/#/c/10234/3/infra/python/deps/pip_download.py@140
PS3, Line 140: f = open(requirements_file, 'r')
While you are making changes here, you could actually change this to "for line 
in open(...):", which takes care of closing the file, even if it hits an 
exception.


http://gerrit.cloudera.org:8080/#/c/10234/3/infra/python/deps/pip_download.py@158
PS3, Line 158:   if pool:
This check seems unnecessary now



--
To view, visit http://gerrit.cloudera.org:8080/10234
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7cbf622adb7d037f1a53c519402dcd8ae3c0fe30
Gerrit-Change-Number: 10234
Gerrit-PatchSet: 3
Gerrit-Owner: Philip Zeyliger 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Taras Bobrovytsky 
Gerrit-Comment-Date: Tue, 01 May 2018 03:53:09 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-2195: Improper handling of comments in queries

[Fredy Wijaya (Code Review)]

Fredy Wijaya has uploaded a new patch set (#11). ( 
http://gerrit.cloudera.org:8080/9933 )

Change subject: IMPALA-2195: Improper handling of comments in queries
..

IMPALA-2195: Improper handling of comments in queries

This patch fixes an issue where parseline is unable to deduce the
correct command when a statement has a leading comment.

Before:
> -- comment
> insert into table t values(100);
Fetched 1 row(s) in 0.01s

After:
> -- comment
> insert into table t values(100);
Modified 1 row(s) in 0.01s

Before (FE syntax error):
> /*comment*/ help;

After (show help correctly):
> /*comment*/ help;

Testing:
- Added shell tests
- Ran end-to-end shell tests

Change-Id: I7ac7cb5a30e6dda73ebe761d9f0eb9ba038e14a7
---
M shell/impala_shell.py
M tests/shell/test_shell_interactive.py
2 files changed, 157 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/33/9933/11
--
To view, visit http://gerrit.cloudera.org:8080/9933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7ac7cb5a30e6dda73ebe761d9f0eb9ba038e14a7
Gerrit-Change-Number: 9933
Gerrit-PatchSet: 11
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Taras Bobrovytsky 

[Impala-ASF-CR] IMPALA-2195: Improper handling of comments in queries

[Fredy Wijaya (Code Review)]

Fredy Wijaya has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9933 )

Change subject: IMPALA-2195: Improper handling of comments in queries
..


Patch Set 11: Code-Review+1

(3 comments)

Carry Bharath's +1

http://gerrit.cloudera.org:8080/#/c/9933/7/shell/impala_shell.py
File shell/impala_shell.py:

http://gerrit.cloudera.org:8080/#/c/9933/7/shell/impala_shell.py@1306
PS7, Line 1306: leading comment: /*comment*/
> In that case, we could probably contribute it to the argparse, I already se
I'll see if they're willing to accept my patch :)


http://gerrit.cloudera.org:8080/#/c/9933/9/shell/impala_shell.py
File shell/impala_shell.py:

http://gerrit.cloudera.org:8080/#/c/9933/9/shell/impala_shell.py@326
PS9, Line 326: 
self.set_query_options)
> nit: move these to the previous line.
Done


http://gerrit.cloudera.org:8080/#/c/9933/9/tests/shell/test_shell_interactive.py
File tests/shell/test_shell_interactive.py:

http://gerrit.cloudera.org:8080/#/c/9933/9/tests/shell/test_shell_interactive.py@547
PS9, Line 547: proc = pexpect.spawn(SHELL_CMD, ['-d', 'functional'])
> Sorry missed this the last time, could you add an example with multiple pre
Done



--
To view, visit http://gerrit.cloudera.org:8080/9933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ac7cb5a30e6dda73ebe761d9f0eb9ba038e14a7
Gerrit-Change-Number: 9933
Gerrit-PatchSet: 11
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Taras Bobrovytsky 
Gerrit-Comment-Date: Tue, 01 May 2018 03:23:50 +
Gerrit-HasComments: Yes

[Impala-ASF-CR](asf-site) Adding issues-all mailing list.

[Philip Zeyliger (Code Review)]

Philip Zeyliger has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/10257


Change subject: Adding issues-all mailing list.
..

Adding issues-all mailing list.

Thanks to INFRA-16440, we now have a mailing list with all Apache
JIRA notifications, not just creations and removals. Adding it to
the website.

Change-Id: Ib629b11e0fc80b0c9b5bf1be5dd58d24845f6524
---
M community.html
1 file changed, 5 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/57/10257/1
--
To view, visit http://gerrit.cloudera.org:8080/10257
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib629b11e0fc80b0c9b5bf1be5dd58d24845f6524
Gerrit-Change-Number: 10257
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger 

[Impala-ASF-CR] IMPALA-5392: Added all stack frames to ThreadInfo summary.

[Abhishek Sharma (Code Review)]

Abhishek Sharma has uploaded a new patch set (#9). ( 
http://gerrit.cloudera.org:8080/10145 )

Change subject: IMPALA-5392: Added all stack frames to ThreadInfo summary.
..

IMPALA-5392: Added all stack frames to ThreadInfo summary.

The current implementation uses ThreadInfo.toString,
which restricts the number of stack frames to 8.
As a part of this fix, this particular constraint is removed.
Now all stack frames are included in the summary.

Change-Id: I80ab4aad03e0c1f01fecad6b87779531244c28b7
---
M fe/src/main/java/org/apache/impala/common/JniUtil.java
1 file changed, 86 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/45/10145/9
--
To view, visit http://gerrit.cloudera.org:8080/10145
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I80ab4aad03e0c1f01fecad6b87779531244c28b7
Gerrit-Change-Number: 10145
Gerrit-PatchSet: 9
Gerrit-Owner: Abhishek Sharma 
Gerrit-Reviewer: Abhishek Sharma 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Charles Agnello 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Jim Apple 

[Impala-ASF-CR] Speed up Python dependencies.

[Philip Zeyliger (Code Review)]

Hello Taras Bobrovytsky, Lars Volker, Michael Brown, Joe McDonnell,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/10234

to look at the new patch set (#3).

Change subject: Speed up Python dependencies.
..

Speed up Python dependencies.

This parallelizes downloading some Python libraries, giving a speedup of
$IMPALA_HOME/infra/python/deps/download_requirements.  I've seen this
take from 7-15 seconds before and from 2-5 seconds after.

I also checked that we always have at least Python 2.6 when
building Impala, so I was able to remove the try/except
handling in bootstrap_toolchain.

Change-Id: I7cbf622adb7d037f1a53c519402dcd8ae3c0fe30
---
M bin/bootstrap_toolchain.py
M infra/python/deps/pip_download.py
2 files changed, 18 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/34/10234/3
--
To view, visit http://gerrit.cloudera.org:8080/10234
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7cbf622adb7d037f1a53c519402dcd8ae3c0fe30
Gerrit-Change-Number: 10234
Gerrit-PatchSet: 3
Gerrit-Owner: Philip Zeyliger 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Taras Bobrovytsky 

[Impala-ASF-CR] Speed up Python dependencies.

[Philip Zeyliger (Code Review)]

Philip Zeyliger has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10234 )

Change subject: Speed up Python dependencies.
..


Patch Set 2:

(3 comments)

I'm re-running tests on the updated patch.

http://gerrit.cloudera.org:8080/#/c/10234/2/infra/python/deps/pip_download.py
File infra/python/deps/pip_download.py:

http://gerrit.cloudera.org:8080/#/c/10234/2/infra/python/deps/pip_download.py@137
PS2, Line 137: results = []
> Hoist this out of the loop (see my comment below).
Done


http://gerrit.cloudera.org:8080/#/c/10234/2/infra/python/deps/pip_download.py@139
PS2, Line 139: # Multiprocessing was introduced in Python2.6; fail 
gracefully if
> If it was introduced in 2.6, can we not rely on it (I thought that was the
I think we can. I observed that even when we build for CentOS 5, we have a copy 
of Python2.6 for our build. (I observed it doing threading in 
bootstrap_toolchain.py in the log.)


http://gerrit.cloudera.org:8080/#/c/10234/2/infra/python/deps/pip_download.py@172
PS2, Line 172: if results:
> Nice catch. We can get rid of the "if results:" line
Done



--
To view, visit http://gerrit.cloudera.org:8080/10234
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7cbf622adb7d037f1a53c519402dcd8ae3c0fe30
Gerrit-Change-Number: 10234
Gerrit-PatchSet: 2
Gerrit-Owner: Philip Zeyliger 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Taras Bobrovytsky 
Gerrit-Comment-Date: Tue, 01 May 2018 03:15:44 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6802 (part 1): Clean up authorization tests

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/10135 )

Change subject: IMPALA-6802 (part 1): Clean up authorization tests
..

IMPALA-6802 (part 1): Clean up authorization tests

The first patch of this patch is to introduce a new mechanism of testing
authorization that tests authorization at every hierarchy. This patch
rewrites the authorization tests for select statements.

Testing:
- Added new authorization tests
- Ran all front-end tests

Cherry-picks: not for 2.x

Change-Id: I9cd5713607c423f644451af5ebb3494d3a728e3b
Reviewed-on: http://gerrit.cloudera.org:8080/10135
Reviewed-by: Alex Behm 
Tested-by: Impala Public Jenkins 
---
A fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java
M fe/src/test/java/org/apache/impala/testutil/ImpaladTestCatalog.java
2 files changed, 659 insertions(+), 3 deletions(-)

Approvals:
  Alex Behm: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/10135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9cd5713607c423f644451af5ebb3494d3a728e3b
Gerrit-Change-Number: 10135
Gerrit-PatchSet: 13
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins 

[Impala-ASF-CR] IMPALA-6802 (part 1): Clean up authorization tests

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10135 )

Change subject: IMPALA-6802 (part 1): Clean up authorization tests
..


Patch Set 12: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/10135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9cd5713607c423f644451af5ebb3494d3a728e3b
Gerrit-Change-Number: 10135
Gerrit-PatchSet: 12
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Tue, 01 May 2018 02:53:41 +
Gerrit-HasComments: No

[Impala-ASF-CR](2.x) IMPALA-6070: Further improvements to test-with-docker.

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/10248 )

Change subject: IMPALA-6070: Further improvements to test-with-docker.
..

IMPALA-6070: Further improvements to test-with-docker.

This commit tackles a few additions and improvements to
test-with-docker. In general, I'm adding workloads (e.g., exhaustive,
rat-check), tuning memory setting and parallelism, and trying to speed
things up.

Bug fixes:

* Embarassingly, I was still skipping thrift-server-test in the backend
  tests. This was a mistake in handling feedback from my last review.

* I made the timeline a little bit taller to clip less.

Adding workloads:

* I added the RAT licensing check.

* I added exhaustive runs. This led me to model the suites a little
  bit more in Python, with a class representing a suite with a
  bunch of data about the suite. It's not perfect and still
  coupled with the entrypoint.sh shell script, but it feels
  workable. As part of adding exhaustive tests, I had
  to re-work the timeout handling, since now different
  suites meaningfully have different timeouts.

Speed ups:

* To speed up test runs, I added a mechanism to split py.test suites into
  multiple shards with a py.test argument. This involved a little bit of work in
  conftest.py, and exposing $RUN_CUSTOM_CLUSTER_TESTS_ARGS in run-all-tests.sh.

  Furthermore, I moved a bit more logic about managing the
  list of suites into Python.

* Doing the full build with "-notests" and only building
  the backend tests in the relevant target that needs them. This speeds
  up "docker commit" significantly by removing about 20GB from the
  container.  I had to indicates that expr-codegen-test depends on
  expr-codegen-test-ir, which was missing.

* I sped up copying the Kudu data: previously I did
  both a move and a copy; now I'm doing a move followed by a move. One
  of the moves is cross-filesystem so is slow, but this does half the
  amount of copying.

Memory usage:

* I tweaked the memlimit_gb settings to have a higher default. I've been
  fighting empirically to have the tests run well on c4.8xlarge and
  m4.10xlarge.

The more memory a minicluster and test suite run uses, the fewer parallel
suites we can run. By observing the peak processes at the tail of a run (with a
new "memory_usage" function that uses a ps/sort/awk trick) and by observing
peak container total_rss, I found that we had several JVMs that
didn't have Xmx settings set. I added Xms/Xmx settings in a few
places:

 * The non-first Impalad does very little JVM work, so having
   an Xmx keeps it small, even in the parallel tests.
 * Datanodes do work, but they essentially were never garbage
   collecting, because JVM defaults let them use up to 1/4th
   the machine memory. (I observed this based on RSS at the
   end of the run; nothing fancier.) Adding Xms/Xmx settings
   helped.
 * Similarly, I piped the settings through to HBase.

A few daemons still run without resource limitations, but they don't
seem to be a problem.

Change-Id: I43fe124f00340afa21ad1eeb6432d6d50151ca7c
Reviewed-on: http://gerrit.cloudera.org:8080/10123
Reviewed-by: Joe McDonnell 
Tested-by: Impala Public Jenkins 
Reviewed-on: http://gerrit.cloudera.org:8080/10248
Reviewed-by: Philip Zeyliger 
---
M be/src/exprs/CMakeLists.txt
M bin/run-all-tests.sh
M docker/entrypoint.sh
M docker/monitor.py
M docker/test-with-docker.py
M docker/timeline.html.template
M testdata/bin/run-hbase.sh
M testdata/cluster/node_templates/common/etc/init.d/hdfs-common
M tests/conftest.py
M tests/run-tests.py
10 files changed, 425 insertions(+), 148 deletions(-)

Approvals:
  Philip Zeyliger: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/10248
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I43fe124f00340afa21ad1eeb6432d6d50151ca7c
Gerrit-Change-Number: 10248
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Brown 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Philip Zeyliger 

[Impala-ASF-CR](2.x) IMPALA-6070: Further improvements to test-with-docker.

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10248 )

Change subject: IMPALA-6070: Further improvements to test-with-docker.
..


Patch Set 1: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/10248
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I43fe124f00340afa21ad1eeb6432d6d50151ca7c
Gerrit-Change-Number: 10248
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Brown 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Tue, 01 May 2018 02:46:37 +
Gerrit-HasComments: No

[Impala-ASF-CR](asf-site) [DOCS] Update the latest impala docs to 2.12

[Alex Rodoni (Code Review)]

Alex Rodoni has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/10253


Change subject: [DOCS] Update the latest impala docs to 2.12
..

[DOCS] Update the latest impala docs to 2.12

Update the html and pdf docs for 2.12
commit hash 9c32594f722f139955788d0da57bdeecc3bacf75

Change-Id: I701cd1ef760e6955e1c787a58639130c7cb786d8
---
M docs/build/html/index.html
A docs/build/html/shared/ImpalaVariables.html
A docs/build/html/shared/impala_common.html
M docs/build/html/topics/impala_admission.html
M docs/build/html/topics/impala_alter_table.html
M docs/build/html/topics/impala_analytic_functions.html
M docs/build/html/topics/impala_array.html
M docs/build/html/topics/impala_bigint.html
M docs/build/html/topics/impala_char.html
M docs/build/html/topics/impala_components.html
M docs/build/html/topics/impala_compute_stats.html
A docs/build/html/topics/impala_compute_stats_min_sample_size.html
M docs/build/html/topics/impala_config_options.html
M docs/build/html/topics/impala_conversion_functions.html
M docs/build/html/topics/impala_datetime_functions.html
M docs/build/html/topics/impala_decimal.html
M docs/build/html/topics/impala_double.html
A docs/build/html/topics/impala_exec_time_limit_s.html
M docs/build/html/topics/impala_fixed_issues.html
M docs/build/html/topics/impala_float.html
M docs/build/html/topics/impala_grant.html
M docs/build/html/topics/impala_hints.html
M docs/build/html/topics/impala_incompatible_changes.html
M docs/build/html/topics/impala_insert.html
M docs/build/html/topics/impala_int.html
M docs/build/html/topics/impala_invalidate_metadata.html
M docs/build/html/topics/impala_joins.html
M docs/build/html/topics/impala_known_issues.html
M docs/build/html/topics/impala_kudu.html
M docs/build/html/topics/impala_langref_sql.html
M docs/build/html/topics/impala_langref_unsupported.html
M docs/build/html/topics/impala_literals.html
M docs/build/html/topics/impala_map.html
M docs/build/html/topics/impala_math_functions.html
M docs/build/html/topics/impala_new_features.html
M docs/build/html/topics/impala_parquet_fallback_schema_resolution.html
M docs/build/html/topics/impala_partitioning.html
M docs/build/html/topics/impala_perf_joins.html
M docs/build/html/topics/impala_perf_stats.html
M docs/build/html/topics/impala_planning.html
M docs/build/html/topics/impala_proxy.html
M docs/build/html/topics/impala_query_options.html
M docs/build/html/topics/impala_release_notes.html
M docs/build/html/topics/impala_relnotes.html
M docs/build/html/topics/impala_replica_preference.html
M docs/build/html/topics/impala_reserved_words.html
M docs/build/html/topics/impala_revoke.html
M docs/build/html/topics/impala_runtime_filtering.html
M docs/build/html/topics/impala_scalability.html
M docs/build/html/topics/impala_select.html
M docs/build/html/topics/impala_shell_options.html
A docs/build/html/topics/impala_shuffle_distinct_exprs.html
M docs/build/html/topics/impala_smallint.html
M docs/build/html/topics/impala_ssl.html
M docs/build/html/topics/impala_string_functions.html
M docs/build/html/topics/impala_struct.html
M docs/build/html/topics/impala_tablesample.html
M docs/build/html/topics/impala_timestamp.html
M docs/build/html/topics/impala_tinyint.html
M docs/build/html/topics/impala_union.html
M docs/build/html/topics/impala_upgrading.html
M docs/build/html/topics/impala_upsert.html
M docs/build/html/topics/impala_varchar.html
A docs/build/impala-2.12.pdf
A docs/build/impala.pdf
M impala-docs.html
66 files changed, 8,121 insertions(+), 2,400 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/53/10253/1
--
To view, visit http://gerrit.cloudera.org:8080/10253
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: newchange
Gerrit-Change-Id: I701cd1ef760e6955e1c787a58639130c7cb786d8
Gerrit-Change-Number: 10253
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni 

[Impala-ASF-CR] IMPALA-2195: Improper handling of comments in queries

[Bharath Vissapragada (Code Review)]

Bharath Vissapragada has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9933 )

Change subject: IMPALA-2195: Improper handling of comments in queries
..


Patch Set 9: Code-Review+1

(3 comments)

I'll let someone else +2 this since the approach is debatable. The patch looks 
good to me once the remaining nits are addressed.

http://gerrit.cloudera.org:8080/#/c/9933/7/shell/impala_shell.py
File shell/impala_shell.py:

http://gerrit.cloudera.org:8080/#/c/9933/7/shell/impala_shell.py@1306
PS7, Line 1306: args: connect
> Done. docstring updated.
In that case, we could probably contribute it to the argparse, I already see a 
couple of your commits there :-).


http://gerrit.cloudera.org:8080/#/c/9933/9/shell/impala_shell.py
File shell/impala_shell.py:

http://gerrit.cloudera.org:8080/#/c/9933/9/shell/impala_shell.py@326
PS9, Line 326:  command,
nit: move these to the previous line.


http://gerrit.cloudera.org:8080/#/c/9933/9/tests/shell/test_shell_interactive.py
File tests/shell/test_shell_interactive.py:

http://gerrit.cloudera.org:8080/#/c/9933/9/tests/shell/test_shell_interactive.py@547
PS9, Line 547: assert ('--delete\n', 'select 1') == \
Sorry missed this the last time, could you add an example with multiple prefix 
comments.

/* foo */
/* bar */
-- test
select 1



--
To view, visit http://gerrit.cloudera.org:8080/9933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ac7cb5a30e6dda73ebe761d9f0eb9ba038e14a7
Gerrit-Change-Number: 9933
Gerrit-PatchSet: 9
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Taras Bobrovytsky 
Gerrit-Comment-Date: Mon, 30 Apr 2018 23:34:07 +
Gerrit-HasComments: Yes

[Impala-ASF-CR](asf-site) [DOCS] 2.12 HTML and PDF uploaded

[Alex Rodoni (Code Review)]

Alex Rodoni has abandoned this change. ( http://gerrit.cloudera.org:8080/10252 )

Change subject: [DOCS] 2.12 HTML and PDF uploaded
..


Abandoned

I will re-submit the docs from 2.x branch.
--
To view, visit http://gerrit.cloudera.org:8080/10252
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: abandon
Gerrit-Change-Id: Id412e6620a3978c1f72a060ff178ccf5f760e57e
Gerrit-Change-Number: 10252
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Ambreen Kazi 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Sailesh Mukil 

[Impala-ASF-CR] IMPALA-6954: Fix problems with CTAS into Kudu with an expr rewrite

[Zoram Thanga (Code Review)]

Zoram Thanga has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10251 )

Change subject: IMPALA-6954: Fix problems with CTAS into Kudu with an expr 
rewrite
..


Patch Set 1: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/10251
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I731743bd84cc695119e99342e1b155096147f0ed
Gerrit-Change-Number: 10251
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Zoram Thanga 
Gerrit-Comment-Date: Mon, 30 Apr 2018 23:10:39 +
Gerrit-HasComments: No

[Impala-ASF-CR](asf-site) [DOCS] 2.12 HTML and PDF uploaded

[Ambreen Kazi (Code Review)]

Ambreen Kazi has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10252 )

Change subject: [DOCS] 2.12 HTML and PDF uploaded
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10252/1/impala-docs.html
File impala-docs.html:

http://gerrit.cloudera.org:8080/#/c/10252/1/impala-docs.html@132
PS1, Line 132: impala-2.12.pdf
the pdf file attached to this change is called impala.pdf. do you need to 
rename it to impala-2.12.pdf?



--
To view, visit http://gerrit.cloudera.org:8080/10252
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: comment
Gerrit-Change-Id: Id412e6620a3978c1f72a060ff178ccf5f760e57e
Gerrit-Change-Number: 10252
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Ambreen Kazi 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Comment-Date: Mon, 30 Apr 2018 23:09:43 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6908: IsConnResetTException() should include ECONNRESET

[Michael Ho (Code Review)]

Michael Ho has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10247 )

Change subject: IMPALA-6908: IsConnResetTException() should include ECONNRESET
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10247/1/be/src/rpc/thrift-util.cc
File be/src/rpc/thrift-util.cc:

http://gerrit.cloudera.org:8080/#/c/10247/1/be/src/rpc/thrift-util.cc@205
PS1, Line 205:  (e.getType() == TTransportException::NOT_OPEN &&
 :  strstr(e.what(), "ECONNRESET") != nullptr);
As discussed offline, this may not be applicable anymore with the recent 
upgrade of Thrift to 0.9.3 
(https://github.com/apache/thrift/blob/0.9.3/lib/cpp/src/thrift/transport/TSocket.cpp#L582-L584).

The upgrade of Thrift was only applied to master but not 2.x so this patch may 
still be valid for 2.x.

I wonder if it makes sense to #ifdef it in the code somehow.



--
To view, visit http://gerrit.cloudera.org:8080/10247
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1bb997a833917e5166c9ca192da219f50f4439e2
Gerrit-Change-Number: 10247
Gerrit-PatchSet: 1
Gerrit-Owner: Sailesh Mukil 
Gerrit-Reviewer: Michael Ho 
Gerrit-Comment-Date: Mon, 30 Apr 2018 23:00:57 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4123 (prep): Parquet column reader cleanup

[Tim Armstrong (Code Review)]

Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9799 )

Change subject: IMPALA-4123 (prep): Parquet column reader cleanup
..


Patch Set 5: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/9799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc00352df3a0b2d605f872ae7e43db2dc90faab1
Gerrit-Change-Number: 9799
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Mon, 30 Apr 2018 23:06:50 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6802 (part 1): Clean up authorization tests

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10135 )

Change subject: IMPALA-6802 (part 1): Clean up authorization tests
..


Patch Set 12:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2386/


--
To view, visit http://gerrit.cloudera.org:8080/10135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9cd5713607c423f644451af5ebb3494d3a728e3b
Gerrit-Change-Number: 10135
Gerrit-PatchSet: 12
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Mon, 30 Apr 2018 23:00:32 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6802 (part 1): Clean up authorization tests

[Alex Behm (Code Review)]

Alex Behm has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10135 )

Change subject: IMPALA-6802 (part 1): Clean up authorization tests
..


Patch Set 12: Code-Review+2

Very nice. Let's keep the cleanup going!


--
To view, visit http://gerrit.cloudera.org:8080/10135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9cd5713607c423f644451af5ebb3494d3a728e3b
Gerrit-Change-Number: 10135
Gerrit-PatchSet: 12
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Comment-Date: Mon, 30 Apr 2018 22:59:49 +
Gerrit-HasComments: No

[Impala-ASF-CR](asf-site) [DOCS] 2.12 HTML and PDF uploaded

[Alex Rodoni (Code Review)]

Alex Rodoni has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/10252


Change subject: [DOCS] 2.12 HTML and PDF uploaded
..

[DOCS] 2.12 HTML and PDF uploaded

Add Impala docs from branch mater, commit hash:
167ed627febe5a10d8a4a7474a34efde1ac6f1c2

Change-Id: Id412e6620a3978c1f72a060ff178ccf5f760e57e
---
M docs/build/html/index.html
A docs/build/html/shared/ImpalaVariables.html
A docs/build/html/shared/impala_common.html
M docs/build/html/topics/impala_abort_on_error.html
M docs/build/html/topics/impala_adls.html
M docs/build/html/topics/impala_admin.html
M docs/build/html/topics/impala_admission.html
M docs/build/html/topics/impala_aggregate_functions.html
M docs/build/html/topics/impala_aliases.html
M docs/build/html/topics/impala_allow_unsupported_formats.html
M docs/build/html/topics/impala_alter_table.html
M docs/build/html/topics/impala_alter_view.html
M docs/build/html/topics/impala_analytic_functions.html
M docs/build/html/topics/impala_appx_count_distinct.html
M docs/build/html/topics/impala_appx_median.html
M docs/build/html/topics/impala_array.html
M docs/build/html/topics/impala_auditing.html
M docs/build/html/topics/impala_authentication.html
M docs/build/html/topics/impala_authorization.html
M docs/build/html/topics/impala_avg.html
M docs/build/html/topics/impala_avro.html
M docs/build/html/topics/impala_batch_size.html
M docs/build/html/topics/impala_bigint.html
M docs/build/html/topics/impala_bit_functions.html
M docs/build/html/topics/impala_boolean.html
M docs/build/html/topics/impala_breakpad.html
M docs/build/html/topics/impala_buffer_pool_limit.html
M docs/build/html/topics/impala_char.html
M docs/build/html/topics/impala_comments.html
M docs/build/html/topics/impala_complex_types.html
M docs/build/html/topics/impala_components.html
M docs/build/html/topics/impala_compression_codec.html
M docs/build/html/topics/impala_compute_stats.html
A docs/build/html/topics/impala_compute_stats_min_sample_size.html
M docs/build/html/topics/impala_concepts.html
M docs/build/html/topics/impala_conditional_functions.html
M docs/build/html/topics/impala_config.html
M docs/build/html/topics/impala_config_options.html
M docs/build/html/topics/impala_config_performance.html
M docs/build/html/topics/impala_connecting.html
M docs/build/html/topics/impala_conversion_functions.html
M docs/build/html/topics/impala_count.html
M docs/build/html/topics/impala_create_database.html
M docs/build/html/topics/impala_create_function.html
M docs/build/html/topics/impala_create_role.html
M docs/build/html/topics/impala_create_table.html
M docs/build/html/topics/impala_create_view.html
M docs/build/html/topics/impala_databases.html
M docs/build/html/topics/impala_datatypes.html
M docs/build/html/topics/impala_datetime_functions.html
M docs/build/html/topics/impala_ddl.html
M docs/build/html/topics/impala_debug_action.html
M docs/build/html/topics/impala_decimal.html
M docs/build/html/topics/impala_decimal_v2.html
M docs/build/html/topics/impala_default_join_distribution_mode.html
M docs/build/html/topics/impala_default_spillable_buffer_size.html
M docs/build/html/topics/impala_delegation.html
M docs/build/html/topics/impala_delete.html
M docs/build/html/topics/impala_describe.html
M docs/build/html/topics/impala_development.html
M docs/build/html/topics/impala_disable_codegen.html
M docs/build/html/topics/impala_disable_row_runtime_filtering.html
M docs/build/html/topics/impala_disable_streaming_preaggregations.html
M docs/build/html/topics/impala_disable_unsafe_spills.html
M docs/build/html/topics/impala_disk_space.html
M docs/build/html/topics/impala_distinct.html
M docs/build/html/topics/impala_dml.html
M docs/build/html/topics/impala_double.html
M docs/build/html/topics/impala_drop_database.html
M docs/build/html/topics/impala_drop_function.html
M docs/build/html/topics/impala_drop_role.html
M docs/build/html/topics/impala_drop_stats.html
M docs/build/html/topics/impala_drop_table.html
M docs/build/html/topics/impala_drop_view.html
M docs/build/html/topics/impala_exec_single_node_rows_threshold.html
A docs/build/html/topics/impala_exec_time_limit_s.html
M docs/build/html/topics/impala_explain.html
M docs/build/html/topics/impala_explain_level.html
M docs/build/html/topics/impala_explain_plan.html
M docs/build/html/topics/impala_faq.html
M docs/build/html/topics/impala_file_formats.html
M docs/build/html/topics/impala_fixed_issues.html
M docs/build/html/topics/impala_float.html
M docs/build/html/topics/impala_functions.html
M docs/build/html/topics/impala_functions_overview.html
M docs/build/html/topics/impala_grant.html
M docs/build/html/topics/impala_group_by.html
M docs/build/html/topics/impala_group_concat.html
M docs/build/html/topics/impala_hadoop.html
M docs/build/html/topics/impala_having.html
M docs/build/html/topics/impala_hbase.html
M docs/build/html/topics/impala_hbase_cache_blocks.html
M 

[Impala-ASF-CR] IMPALA-6954: Fix problems with CTAS into Kudu with an expr rewrite

[Thomas Tauber-Marshall (Code Review)]

Thomas Tauber-Marshall has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/10251


Change subject: IMPALA-6954: Fix problems with CTAS into Kudu with an expr 
rewrite
..

IMPALA-6954: Fix problems with CTAS into Kudu with an expr rewrite

This patch fixes two problems:
- Previously a CTAS into a Kudu table where an expr rewrite occurred
  would create an unpartitioned table, due to the partition info being
  reset in TableDataLayout and then never reconstructed. Since the
  Kudu partition info is set by the parser and never changes, the
  solution is to not reset it.
- Previously a CTAS into a Kudu table with a range partition where an
  expr rewrite occurred would fail with an analysis exception due to
  a Precondition check in RangePartition.analyze that checked that
  the RangePartition wasn't already analyzed, as the analysis can't
  be done twice. Since the state in RangePartition never changes, it
  doesn't need to be reanalyzed and we can just return instead of
  failing on the check.

Testing:
- Added an e2e test that creates a partitioned Kudu table with a CTAS
  with a rewrite, and checks that the expected partitions are created.

Change-Id: I731743bd84cc695119e99342e1b155096147f0ed
---
M fe/src/main/java/org/apache/impala/analysis/RangePartition.java
M fe/src/main/java/org/apache/impala/analysis/TableDataLayout.java
M testdata/workloads/functional-query/queries/QueryTest/kudu_create.test
3 files changed, 14 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/10251/1
--
To view, visit http://gerrit.cloudera.org:8080/10251
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I731743bd84cc695119e99342e1b155096147f0ed
Gerrit-Change-Number: 10251
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall 

[Impala-ASF-CR](2.x) IMPALA-6070: Further improvements to test-with-docker.

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10248 )

Change subject: IMPALA-6070: Further improvements to test-with-docker.
..


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2385/


--
To view, visit http://gerrit.cloudera.org:8080/10248
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I43fe124f00340afa21ad1eeb6432d6d50151ca7c
Gerrit-Change-Number: 10248
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Brown 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Mon, 30 Apr 2018 22:52:05 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

[Kim Jin Chul (Code Review)]

Kim Jin Chul has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8851 )

Change subject: IMPALA-3193: Show table's comment on show tables
..


Patch Set 19:

Sorry for the delay. I am facing a minor problem in my local development 
environment. I am willing to deliver this change.


--
To view, visit http://gerrit.cloudera.org:8080/8851
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I44f814af05db6f3c027718ade9f474f8b8153bcd
Gerrit-Change-Number: 8851
Gerrit-PatchSet: 19
Gerrit-Owner: Kim Jin Chul 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Kim Jin Chul 
Gerrit-Comment-Date: Mon, 30 Apr 2018 22:47:35 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6802 (part 1): Clean up authorization tests

[Fredy Wijaya (Code Review)]

Fredy Wijaya has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10135 )

Change subject: IMPALA-6802 (part 1): Clean up authorization tests
..


Patch Set 12:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/10135/11/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java
File fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java:

http://gerrit.cloudera.org:8080/#/c/10135/11/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java@94
PS11, Line 94: Set expectedPrivileges = Sets.newHashSet(
> You can create this set once and save many lines
Done


http://gerrit.cloudera.org:8080/#/c/10135/11/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java@195
PS11, Line 195: allExcept(TPrivilegeLevel.ALL, 
TPrivilegeLevel.SELECT)))
> create expected set once
Done


http://gerrit.cloudera.org:8080/#/c/10135/11/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java@209
PS11, Line 209: 
.error(selectError("functional_seq_snap.subquery_view"), onServer(
> fix indentation
Done


http://gerrit.cloudera.org:8080/#/c/10135/11/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java@271
PS11, Line 271: .ok(onServer(TPrivilegeLevel.SELECT))
> factor out the err msg here and elsewhere to condense the tests
Done



--
To view, visit http://gerrit.cloudera.org:8080/10135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9cd5713607c423f644451af5ebb3494d3a728e3b
Gerrit-Change-Number: 10135
Gerrit-PatchSet: 12
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Comment-Date: Mon, 30 Apr 2018 22:47:45 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6802 (part 1): Clean up authorization tests

[Fredy Wijaya (Code Review)]

Fredy Wijaya has uploaded a new patch set (#12). ( 
http://gerrit.cloudera.org:8080/10135 )

Change subject: IMPALA-6802 (part 1): Clean up authorization tests
..

IMPALA-6802 (part 1): Clean up authorization tests

The first patch of this patch is to introduce a new mechanism of testing
authorization that tests authorization at every hierarchy. This patch
rewrites the authorization tests for select statements.

Testing:
- Added new authorization tests
- Ran all front-end tests

Cherry-picks: not for 2.x

Change-Id: I9cd5713607c423f644451af5ebb3494d3a728e3b
---
A fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java
M fe/src/test/java/org/apache/impala/testutil/ImpaladTestCatalog.java
2 files changed, 659 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/35/10135/12
--
To view, visit http://gerrit.cloudera.org:8080/10135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9cd5713607c423f644451af5ebb3494d3a728e3b
Gerrit-Change-Number: 10135
Gerrit-PatchSet: 12
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Fredy Wijaya 

[Impala-ASF-CR] Warn about Hadoop / Java version incompatibility

[Joe McDonnell (Code Review)]

Joe McDonnell has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10244 )

Change subject: Warn about Hadoop / Java version incompatibility
..


Patch Set 2: Code-Review+2

This looks reasonable to me.


--
To view, visit http://gerrit.cloudera.org:8080/10244
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d8b505cf045eeb562d16ce4ce09da0712dc03eb
Gerrit-Change-Number: 10244
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Mon, 30 Apr 2018 22:38:50 +
Gerrit-HasComments: No

[Impala-ASF-CR] [DOCS] Fixed a typo that broke a keyref

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10249 )

Change subject: [DOCS] Fixed a typo that broke a keyref
..


Patch Set 1: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/10249
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6957e96add649b898cef5b8b0d74dc28d5adee20
Gerrit-Change-Number: 10249
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Mon, 30 Apr 2018 22:28:50 +
Gerrit-HasComments: No

[Impala-ASF-CR] [DOCS] Fixed a typo that broke a keyref

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/10249 )

Change subject: [DOCS] Fixed a typo that broke a keyref
..

[DOCS] Fixed a typo that broke a keyref

Change-Id: I6957e96add649b898cef5b8b0d74dc28d5adee20
Reviewed-on: http://gerrit.cloudera.org:8080/10249
Reviewed-by: Alex Rodoni 
Tested-by: Impala Public Jenkins 
---
M docs/topics/impala_decimal.xml
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Alex Rodoni: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/10249
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6957e96add649b898cef5b8b0d74dc28d5adee20
Gerrit-Change-Number: 10249
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 

[Impala-ASF-CR] [DOCS] Fixed a typo that broke a keyref

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10249 )

Change subject: [DOCS] Fixed a typo that broke a keyref
..


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-docs-submit/274/


--
To view, visit http://gerrit.cloudera.org:8080/10249
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6957e96add649b898cef5b8b0d74dc28d5adee20
Gerrit-Change-Number: 10249
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Mon, 30 Apr 2018 22:22:48 +
Gerrit-HasComments: No

[Impala-ASF-CR] [DOCS] Fixed a typo that broke a keyref

[Alex Rodoni (Code Review)]

Alex Rodoni has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/10249


Change subject: [DOCS] Fixed a typo that broke a keyref
..

[DOCS] Fixed a typo that broke a keyref

Change-Id: I6957e96add649b898cef5b8b0d74dc28d5adee20
---
M docs/topics/impala_decimal.xml
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/49/10249/1
--
To view, visit http://gerrit.cloudera.org:8080/10249
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6957e96add649b898cef5b8b0d74dc28d5adee20
Gerrit-Change-Number: 10249
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni 

[Impala-ASF-CR](2.x) IMPALA-6070: Further improvements to test-with-docker.

[Philip Zeyliger (Code Review)]

Philip Zeyliger has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10248 )

Change subject: IMPALA-6070: Further improvements to test-with-docker.
..


Patch Set 1: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/10248
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I43fe124f00340afa21ad1eeb6432d6d50151ca7c
Gerrit-Change-Number: 10248
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Brown 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Mon, 30 Apr 2018 22:18:02 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6802 (part 1): Clean up authorization tests

[Fredy Wijaya (Code Review)]

Fredy Wijaya has uploaded a new patch set (#11). ( 
http://gerrit.cloudera.org:8080/10135 )

Change subject: IMPALA-6802 (part 1): Clean up authorization tests
..

IMPALA-6802 (part 1): Clean up authorization tests

The first patch of this patch is to introduce a new mechanism of testing
authorization that tests authorization at every hierarchy. This patch
rewrites the authorization tests for select statements.

Testing:
- Added new authorization tests
- Ran all front-end tests

Cherry-picks: not for 2.x

Change-Id: I9cd5713607c423f644451af5ebb3494d3a728e3b
---
A fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java
M fe/src/test/java/org/apache/impala/testutil/ImpaladTestCatalog.java
2 files changed, 770 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/35/10135/11
--
To view, visit http://gerrit.cloudera.org:8080/10135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9cd5713607c423f644451af5ebb3494d3a728e3b
Gerrit-Change-Number: 10135
Gerrit-PatchSet: 11
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Fredy Wijaya 

[Impala-ASF-CR](2.x) Update version to 2.13.0-SNAPSHOT

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/10241 )

Change subject: Update version to 2.13.0-SNAPSHOT
..

Update version to 2.13.0-SNAPSHOT

Change-Id: Iac447c57a273e0c334e0e63d6e740c2a00d5c762
Reviewed-on: http://gerrit.cloudera.org:8080/10241
Reviewed-by: Lars Volker 
Tested-by: Impala Public Jenkins 
---
M bin/save-version.sh
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Lars Volker: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/10241
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: merged
Gerrit-Change-Id: Iac447c57a273e0c334e0e63d6e740c2a00d5c762
Gerrit-Change-Number: 10241
Gerrit-PatchSet: 2
Gerrit-Owner: Sailesh Mukil 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 

[Impala-ASF-CR](2.x) Update version to 2.13.0-SNAPSHOT

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10241 )

Change subject: Update version to 2.13.0-SNAPSHOT
..


Patch Set 1: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/10241
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac447c57a273e0c334e0e63d6e740c2a00d5c762
Gerrit-Change-Number: 10241
Gerrit-PatchSet: 1
Gerrit-Owner: Sailesh Mukil 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Comment-Date: Mon, 30 Apr 2018 22:06:28 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-2195: Improper handling of comments in queries

[Fredy Wijaya (Code Review)]

Fredy Wijaya has uploaded a new patch set (#9). ( 
http://gerrit.cloudera.org:8080/9933 )

Change subject: IMPALA-2195: Improper handling of comments in queries
..

IMPALA-2195: Improper handling of comments in queries

This patch fixes an issue where parseline is unable to deduce the
correct command when a statement has a leading comment.

Before:
> -- comment
> insert into table t values(100);
Fetched 1 row(s) in 0.01s

After:
> -- comment
> insert into table t values(100);
Modified 1 row(s) in 0.01s

Before (FE syntax error):
> /*comment*/ help;

After (show help correctly):
> /*comment*/ help;

Testing:
- Added shell tests
- Ran end-to-end shell tests

Change-Id: I7ac7cb5a30e6dda73ebe761d9f0eb9ba038e14a7
---
M shell/impala_shell.py
M tests/shell/test_shell_interactive.py
2 files changed, 133 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/33/9933/9
--
To view, visit http://gerrit.cloudera.org:8080/9933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7ac7cb5a30e6dda73ebe761d9f0eb9ba038e14a7
Gerrit-Change-Number: 9933
Gerrit-PatchSet: 9
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Taras Bobrovytsky 

[Impala-ASF-CR] IMPALA-2195: Improper handling of comments in queries

[Fredy Wijaya (Code Review)]

Fredy Wijaya has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9933 )

Change subject: IMPALA-2195: Improper handling of comments in queries
..


Patch Set 9:

(10 comments)

http://gerrit.cloudera.org:8080/#/c/9933/7/shell/impala_shell.py
File shell/impala_shell.py:

http://gerrit.cloudera.org:8080/#/c/9933/7/shell/impala_shell.py@320
PS7, Line 320:   sys.exit(1)
> nit: Add a comment that we are reconstructing the query stmt by adding the
Done


http://gerrit.cloudera.org:8080/#/c/9933/7/shell/impala_shell.py@322
PS7, Line 322:  comment (if exists) will be
> Can be simplified with -- self.comment or ""
Done


http://gerrit.cloudera.org:8080/#/c/9933/7/shell/impala_shell.py@590
PS7, Line 590:   # is necessary to find a proper function and here is a 
right place
> can we call it prefix_comments/leading_comments to make it more clearer? co
Done


http://gerrit.cloudera.org:8080/#/c/9933/7/shell/impala_shell.py@1288
PS7, Line 1288: self._disable_readline()
> I think we need to expand the method doc a little more. Why we strip the le
Done


http://gerrit.cloudera.org:8080/#/c/9933/7/shell/impala_shell.py@1289
PS7, Line 1289:
> , comment
Done


http://gerrit.cloudera.org:8080/#/c/9933/7/shell/impala_shell.py@1294
PS7, Line 1294: ten original line, with leadi
> nit:reword to ..deduce the 'command' part ... maybe?
Done


http://gerrit.cloudera.org:8080/#/c/9933/7/shell/impala_shell.py@1295
PS7, Line 1295: and trailing space removed and special characters transfor
> nit: Already in the beginning, keep one.
Done


http://gerrit.cloudera.org:8080/#/c/9933/7/shell/impala_shell.py@1306
PS7, Line 1306: args: connect
> nit: Returns (comment, query.?
Done. docstring updated.

IMO it's better to keep it here and keep only bug fixes in 
shell/ext-py/sqlparse . It makes it easier to upgrade sqlparse in the future.


http://gerrit.cloudera.org:8080/#/c/9933/7/tests/shell/test_shell_interactive.py
File tests/shell/test_shell_interactive.py:

http://gerrit.cloudera.org:8080/#/c/9933/7/tests/shell/test_shell_interactive.py@545
PS7, Line 545:   def test_strip_leading_comment(self):
> Add a method doc.
Done


http://gerrit.cloudera.org:8080/#/c/9933/7/tests/shell/test_shell_interactive.py@565
PS7, Line 565: ImpalaShellClass.strip_leading_comment('select /*do not 
delete*/ 1')
> Can you add one example with join hints too? SHUFFLE etc.
Done



--
To view, visit http://gerrit.cloudera.org:8080/9933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ac7cb5a30e6dda73ebe761d9f0eb9ba038e14a7
Gerrit-Change-Number: 9933
Gerrit-PatchSet: 9
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Taras Bobrovytsky 
Gerrit-Comment-Date: Mon, 30 Apr 2018 21:45:33 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6802 (part 1): Clean up authorization tests

[Alex Behm (Code Review)]

Alex Behm has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10135 )

Change subject: IMPALA-6802 (part 1): Clean up authorization tests
..


Patch Set 8:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/10135/8/fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java
File fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java:

http://gerrit.cloudera.org:8080/#/c/10135/8/fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java@654
PS8, Line 654:   public void TestPrivilegeRequests() throws ImpalaException {
I think these should go into AuthorizationTestV2


http://gerrit.cloudera.org:8080/#/c/10135/8/fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java@671
PS8, Line 671: verifyPrivilegeReqs("select alltypes.* from 
functional.alltypes", Sets.newHashSet(
we should also test a "use functional" and referencing "alltypes"


http://gerrit.cloudera.org:8080/#/c/10135/8/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java
File fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java:

http://gerrit.cloudera.org:8080/#/c/10135/8/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java@89
PS8, Line 89: // Test qualified and unqualified names.
We've already tested those elsewhere, so no need.


http://gerrit.cloudera.org:8080/#/c/10135/8/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java@143
PS8, Line 143: // Unqualified table name.
already tested elsewhere



--
To view, visit http://gerrit.cloudera.org:8080/10135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9cd5713607c423f644451af5ebb3494d3a728e3b
Gerrit-Change-Number: 10135
Gerrit-PatchSet: 8
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Comment-Date: Mon, 30 Apr 2018 21:41:18 +
Gerrit-HasComments: Yes

[Impala-ASF-CR](2.x) IMPALA-6070: Further improvements to test-with-docker.

[Michael Brown (Code Review)]

Michael Brown has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10248 )

Change subject: IMPALA-6070: Further improvements to test-with-docker.
..


Patch Set 1:

(1 comment)

Not a clean cherry-pick. See below.

http://gerrit.cloudera.org:8080/#/c/10248/1/testdata/bin/run-hbase.sh
File testdata/bin/run-hbase.sh:

http://gerrit.cloudera.org:8080/#/c/10248/1/testdata/bin/run-hbase.sh@39
PS1, Line 39: export HBASE_HEAPSIZE=1g
The fixed conflict was here: On master, we expected to add L39 under an 
unrelated IMPALA_MINICLUSTER_PROFILE conditional. On 2.x, that conditional is 
not here. I confirmed HBASE_HEAPSIZE is an env variable in our toolchain Hbase 
1.2.0, so it seems OK to have this here.



--
To view, visit http://gerrit.cloudera.org:8080/10248
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I43fe124f00340afa21ad1eeb6432d6d50151ca7c
Gerrit-Change-Number: 10248
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Brown 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Mon, 30 Apr 2018 21:32:05 +
Gerrit-HasComments: Yes

[Impala-ASF-CR](2.x) IMPALA-6070: Further improvements to test-with-docker.

[Michael Brown (Code Review)]

Hello Joe McDonnell, Impala Public Jenkins,

I'd like you to do a code review. Please visit

http://gerrit.cloudera.org:8080/10248

to review the following change.


Change subject: IMPALA-6070: Further improvements to test-with-docker.
..

IMPALA-6070: Further improvements to test-with-docker.

This commit tackles a few additions and improvements to
test-with-docker. In general, I'm adding workloads (e.g., exhaustive,
rat-check), tuning memory setting and parallelism, and trying to speed
things up.

Bug fixes:

* Embarassingly, I was still skipping thrift-server-test in the backend
  tests. This was a mistake in handling feedback from my last review.

* I made the timeline a little bit taller to clip less.

Adding workloads:

* I added the RAT licensing check.

* I added exhaustive runs. This led me to model the suites a little
  bit more in Python, with a class representing a suite with a
  bunch of data about the suite. It's not perfect and still
  coupled with the entrypoint.sh shell script, but it feels
  workable. As part of adding exhaustive tests, I had
  to re-work the timeout handling, since now different
  suites meaningfully have different timeouts.

Speed ups:

* To speed up test runs, I added a mechanism to split py.test suites into
  multiple shards with a py.test argument. This involved a little bit of work in
  conftest.py, and exposing $RUN_CUSTOM_CLUSTER_TESTS_ARGS in run-all-tests.sh.

  Furthermore, I moved a bit more logic about managing the
  list of suites into Python.

* Doing the full build with "-notests" and only building
  the backend tests in the relevant target that needs them. This speeds
  up "docker commit" significantly by removing about 20GB from the
  container.  I had to indicates that expr-codegen-test depends on
  expr-codegen-test-ir, which was missing.

* I sped up copying the Kudu data: previously I did
  both a move and a copy; now I'm doing a move followed by a move. One
  of the moves is cross-filesystem so is slow, but this does half the
  amount of copying.

Memory usage:

* I tweaked the memlimit_gb settings to have a higher default. I've been
  fighting empirically to have the tests run well on c4.8xlarge and
  m4.10xlarge.

The more memory a minicluster and test suite run uses, the fewer parallel
suites we can run. By observing the peak processes at the tail of a run (with a
new "memory_usage" function that uses a ps/sort/awk trick) and by observing
peak container total_rss, I found that we had several JVMs that
didn't have Xmx settings set. I added Xms/Xmx settings in a few
places:

 * The non-first Impalad does very little JVM work, so having
   an Xmx keeps it small, even in the parallel tests.
 * Datanodes do work, but they essentially were never garbage
   collecting, because JVM defaults let them use up to 1/4th
   the machine memory. (I observed this based on RSS at the
   end of the run; nothing fancier.) Adding Xms/Xmx settings
   helped.
 * Similarly, I piped the settings through to HBase.

A few daemons still run without resource limitations, but they don't
seem to be a problem.

Change-Id: I43fe124f00340afa21ad1eeb6432d6d50151ca7c
Reviewed-on: http://gerrit.cloudera.org:8080/10123
Reviewed-by: Joe McDonnell 
Tested-by: Impala Public Jenkins 
---
M be/src/exprs/CMakeLists.txt
M bin/run-all-tests.sh
M docker/entrypoint.sh
M docker/monitor.py
M docker/test-with-docker.py
M docker/timeline.html.template
M testdata/bin/run-hbase.sh
M testdata/cluster/node_templates/common/etc/init.d/hdfs-common
M tests/conftest.py
M tests/run-tests.py
10 files changed, 425 insertions(+), 148 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/48/10248/1
--
To view, visit http://gerrit.cloudera.org:8080/10248
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I43fe124f00340afa21ad1eeb6432d6d50151ca7c
Gerrit-Change-Number: 10248
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Brown 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Philip Zeyliger 

[Impala-ASF-CR] IMPALA-5969: [DOCS] Adds --auth creds ok in clear to shell options

[Jim Apple (Code Review)]

Jim Apple has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10236 )

Change subject: IMPALA-5969: [DOCS] Adds --auth_creds_ok_in_clear to shell 
options
..


Patch Set 1:

(2 comments)

Thank you for contributing! Some review comments are below:

http://gerrit.cloudera.org:8080/#/c/10236/1/docs/topics/impala_shell_options.xml
File docs/topics/impala_shell_options.xml:

http://gerrit.cloudera.org:8080/#/c/10236/1/docs/topics/impala_shell_options.xml@560
PS1, Line 560: 2.12.0 IMPALA-5969
This was IMPALA-2143, in a much older version of Impala. 2.3 or before.


http://gerrit.cloudera.org:8080/#/c/10236/1/docs/topics/impala_shell_options.xml@562
PS1, Line 562: >N/A<
How did you check that this cannot be done in a config file?



--
To view, visit http://gerrit.cloudera.org:8080/10236
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19450ebd839b84a85598d283c04a77662fa5e44e
Gerrit-Change-Number: 10236
Gerrit-PatchSet: 1
Gerrit-Owner: shashanknaik...@gmail.com
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Jim Apple 
Gerrit-Comment-Date: Mon, 30 Apr 2018 21:09:49 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6908: IsConnResetTException() should include ECONNRESET

[Sailesh Mukil (Code Review)]

Sailesh Mukil has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/10247


Change subject: IMPALA-6908: IsConnResetTException() should include ECONNRESET
..

IMPALA-6908: IsConnResetTException() should include ECONNRESET

The utility function IsConnResetTException() attempted to match error
strings from RPCs that fail due to the remote end resetting the connection
for any reason. However, it did not take care of the situation where
ECONNRESET was sent on a cluster not using TLS.

This patch adds this case as well and adds a custom cluster fault
injection test to test the same.

Change-Id: I1bb997a833917e5166c9ca192da219f50f4439e2
---
M be/src/rpc/thrift-util.cc
M be/src/testutil/fault-injection-util.cc
M be/src/testutil/fault-injection-util.h
M tests/custom_cluster/test_rpc_exception.py
4 files changed, 19 insertions(+), 8 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/47/10247/1
--
To view, visit http://gerrit.cloudera.org:8080/10247
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1bb997a833917e5166c9ca192da219f50f4439e2
Gerrit-Change-Number: 10247
Gerrit-PatchSet: 1
Gerrit-Owner: Sailesh Mukil 

[Impala-ASF-CR] IMPALA-5969: [DOCS] Adds --auth creds ok in clear to shell options

[Anonymous Coward (Code Review)]

shashanknaik...@gmail.com has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/10236


Change subject: IMPALA-5969: [DOCS] Adds --auth_creds_ok_in_clear to shell 
options
..

IMPALA-5969: [DOCS] Adds --auth_creds_ok_in_clear to shell options

This patch adds --auth_creds_ok_in_clear to the impala_shell_options
documentation xml

Change-Id: I19450ebd839b84a85598d283c04a77662fa5e44e
---
M docs/topics/impala_shell_options.xml
1 file changed, 9 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/36/10236/1
--
To view, visit http://gerrit.cloudera.org:8080/10236
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I19450ebd839b84a85598d283c04a77662fa5e44e
Gerrit-Change-Number: 10236
Gerrit-PatchSet: 1
Gerrit-Owner: shashanknaik...@gmail.com
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Jim Apple 

[Impala-ASF-CR] Fix minor perf bug in BufferedTupleStream

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/10239 )

Change subject: Fix minor perf bug in BufferedTupleStream
..

Fix minor perf bug in BufferedTupleStream

The code referenced a member variable when the intent was clearly to use
the template argument.

Change-Id: I05bae0018f79aec9c6014ae228ff28621b548860
Reviewed-on: http://gerrit.cloudera.org:8080/10239
Reviewed-by: Alex Behm 
Tested-by: Impala Public Jenkins 
---
M be/src/runtime/buffered-tuple-stream.cc
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Alex Behm: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/10239
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I05bae0018f79aec9c6014ae228ff28621b548860
Gerrit-Change-Number: 10239
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Impala Public Jenkins 

[Impala-ASF-CR] Fix minor perf bug in BufferedTupleStream

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10239 )

Change subject: Fix minor perf bug in BufferedTupleStream
..


Patch Set 1: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/10239
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I05bae0018f79aec9c6014ae228ff28621b548860
Gerrit-Change-Number: 10239
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Mon, 30 Apr 2018 20:37:41 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-2195: Improper handling of comments in queries

[Bharath Vissapragada (Code Review)]

Bharath Vissapragada has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9933 )

Change subject: IMPALA-2195: Improper handling of comments in queries
..


Patch Set 7:

(10 comments)

After discussing with Fredy, I agree with his analysis that the current code is 
structured in a way that the query 'line' undergoes many transformations at 
multiple places and it probably does not make sense to store a global comment 
stripped query in the beginning and work on that. Adding to that there is a 
complexity of local shell commands (that aren't passed to the coordinator), 
which makes the code flow even more complex.

So, the current approach of stripping the leading comments separately right 
before onecmd() is a reasonable approach and unfortunately, we do multiple 
query parsing attempts on the shell side on the same query which is something 
we need to fix eventually.

Alex/Taras/others, do you have any reservations about this approach?

http://gerrit.cloudera.org:8080/#/c/9933/7/shell/impala_shell.py
File shell/impala_shell.py:

http://gerrit.cloudera.org:8080/#/c/9933/7/shell/impala_shell.py@320
PS7, Line 320:   sys.exit(1)
nit: Add a comment that we are reconstructing the query stmt by adding the 
leading comments or something like that.


http://gerrit.cloudera.org:8080/#/c/9933/7/shell/impala_shell.py@322
PS7, Line 322: self.comment if self.comment else ""
Can be simplified with -- self.comment or ""


http://gerrit.cloudera.org:8080/#/c/9933/7/shell/impala_shell.py@590
PS7, Line 590:   command, arg, line, comment = self.parseline(line)
can we call it prefix_comments/leading_comments to make it more clearer? 
comment seems too general.


http://gerrit.cloudera.org:8080/#/c/9933/7/shell/impala_shell.py@1288
PS7, Line 1288: """Parse the line into a command name and a string 
containing
I think we need to expand the method doc a little more. Why we strip the 
leading comment. Please add an example if you think that helps. Also how we 
deal with local commands that aren't sent to the fe.


http://gerrit.cloudera.org:8080/#/c/9933/7/shell/impala_shell.py@1289
PS7, Line 1289: ).
, comment


http://gerrit.cloudera.org:8080/#/c/9933/7/shell/impala_shell.py@1294
PS7, Line 1294: produce a 'command' correctly
nit:reword to ..deduce the 'command' part ... maybe?


http://gerrit.cloudera.org:8080/#/c/9933/7/shell/impala_shell.py@1295
PS7, Line 1295: This function returns a tuple(command, arg, line, comment)
nit: Already in the beginning, keep one.


http://gerrit.cloudera.org:8080/#/c/9933/7/shell/impala_shell.py@1306
PS7, Line 1306: Filter a leading comment in the SQL statement.
nit: Returns (comment, query.?

I'm hoping this either makes it to the sqlstream code or we move it to 
shell/ext-py/sqparse.. as a patch. Seems a little out of place here. Thoughts?


http://gerrit.cloudera.org:8080/#/c/9933/7/tests/shell/test_shell_interactive.py
File tests/shell/test_shell_interactive.py:

http://gerrit.cloudera.org:8080/#/c/9933/7/tests/shell/test_shell_interactive.py@545
PS7, Line 545:   def test_strip_leading_comment(self):
Add a method doc.


http://gerrit.cloudera.org:8080/#/c/9933/7/tests/shell/test_shell_interactive.py@565
PS7, Line 565:
Can you add one example with join hints too? SHUFFLE etc.



--
To view, visit http://gerrit.cloudera.org:8080/9933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ac7cb5a30e6dda73ebe761d9f0eb9ba038e14a7
Gerrit-Change-Number: 9933
Gerrit-PatchSet: 7
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Taras Bobrovytsky 
Gerrit-Comment-Date: Mon, 30 Apr 2018 19:26:05 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] Warn about Hadoop / Java version incompatibility

[Lars Volker (Code Review)]

Lars Volker has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10244 )

Change subject: Warn about Hadoop / Java version incompatibility
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10244/1/bin/impala-config.sh
File bin/impala-config.sh:

http://gerrit.cloudera.org:8080/#/c/10244/1/bin/impala-config.sh@224
PS1, Line 224:
 :   # Check for minimum required Java version
 :   # Only issue Java version warning when running Java 7.
 :   if $JAVA -version 2>&1 | grep -q 'java version "1.7'; then
 : cat << EOF
 :
 : Your development environment is configured for Hadoop 3 and Java 
7. Hadoop 3 requires at
 : least Java 8. Your JAVA binary currently points to $JAVA
 : and reports the following version:
 :
 : EOF
 : $JAVA -version
 : echo
 :   fi
> If we are warning rather than exiting, then it would be useful to have this
Done



--
To view, visit http://gerrit.cloudera.org:8080/10244
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d8b505cf045eeb562d16ce4ce09da0712dc03eb
Gerrit-Change-Number: 10244
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Mon, 30 Apr 2018 18:40:45 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] Warn about Hadoop / Java version incompatibility

[Lars Volker (Code Review)]

Hello Michael Brown, Philip Zeyliger, Joe McDonnell,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/10244

to look at the new patch set (#2).

Change subject: Warn about Hadoop / Java version incompatibility
..

Warn about Hadoop / Java version incompatibility

Running Hadoop 3 with Java 7 can result in some obscure error messages.
This change adds a warning to impala-config.sh when using Hadoop 3 with
Java 7.

   Your development environment is configured for Hadoop 3 and Java 7.
   Hadoop 3 requires at least Java 8. Your JAVA binary currently points
   to /usr/lib/jvm/java-7-oracle-amd64/bin/java and reports the
   following version:

   java version "1.7.0_75"
   Java(TM) SE Runtime Environment (build 1.7.0_75-b13)
   Java HotSpot(TM) 64-Bit Server VM (build 24.75-b04, mixed mode)

It also catches failure of the minicluster start and prints an
additional warning when running with Hadoop 3 and Java 7.

Change-Id: I4d8b505cf045eeb562d16ce4ce09da0712dc03eb
---
M bin/impala-config.sh
M testdata/bin/run-mini-dfs.sh
2 files changed, 35 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/10244/2
--
To view, visit http://gerrit.cloudera.org:8080/10244
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4d8b505cf045eeb562d16ce4ce09da0712dc03eb
Gerrit-Change-Number: 10244
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Philip Zeyliger 

[Impala-ASF-CR] Warn about Hadoop / Java version incompatibility

[Joe McDonnell (Code Review)]

Joe McDonnell has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10244 )

Change subject: Warn about Hadoop / Java version incompatibility
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10244/1/bin/impala-config.sh
File bin/impala-config.sh:

http://gerrit.cloudera.org:8080/#/c/10244/1/bin/impala-config.sh@224
PS1, Line 224:
 :   # Check for minimum required Java version
 :   # Only issue Java version warning when running Java 7.
 :   if $JAVA -version 2>&1 | grep -q 'java version "1.7'; then
 : cat << EOF
 :
 : Your development environment is configured for Hadoop 3 and Java 
7. Hadoop 3 requires at
 : least Java 8. Your JAVA binary currently points to $JAVA
 : and reports the following version:
 :
 : EOF
 : $JAVA -version
 : echo
 :   fi
If we are warning rather than exiting, then it would be useful to have this be 
the last thing that a user would see. I think we do a bunch of prints down 
below that would push this off the terminal screen.



--
To view, visit http://gerrit.cloudera.org:8080/10244
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d8b505cf045eeb562d16ce4ce09da0712dc03eb
Gerrit-Change-Number: 10244
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Mon, 30 Apr 2018 18:38:02 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10066 )

Change subject: IMPALA-6522: [DOCS] Document Decimal V2
..


Patch Set 17:

Build started: https://jenkins.impala.io/job/gerrit-docs-submit/273/


--
To view, visit http://gerrit.cloudera.org:8080/10066
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d
Gerrit-Change-Number: 10066
Gerrit-PatchSet: 17
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Greg Rahn 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Taras Bobrovytsky 
Gerrit-Comment-Date: Mon, 30 Apr 2018 18:29:51 +
Gerrit-HasComments: No

[Impala-ASF-CR](2.x) Update version to 2.13.0-SNAPSHOT

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10241 )

Change subject: Update version to 2.13.0-SNAPSHOT
..


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2384/


--
To view, visit http://gerrit.cloudera.org:8080/10241
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac447c57a273e0c334e0e63d6e740c2a00d5c762
Gerrit-Change-Number: 10241
Gerrit-PatchSet: 1
Gerrit-Owner: Sailesh Mukil 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Comment-Date: Mon, 30 Apr 2018 18:17:23 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10066 )

Change subject: IMPALA-6522: [DOCS] Document Decimal V2
..


Patch Set 17:

Build started: https://jenkins.impala.io/job/gerrit-docs-submit/272/


--
To view, visit http://gerrit.cloudera.org:8080/10066
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d
Gerrit-Change-Number: 10066
Gerrit-PatchSet: 17
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Greg Rahn 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Taras Bobrovytsky 
Gerrit-Comment-Date: Mon, 30 Apr 2018 18:13:52 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2

[Alex Rodoni (Code Review)]

Alex Rodoni has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/10066 )

Change subject: IMPALA-6522: [DOCS] Document Decimal V2
..

IMPALA-6522: [DOCS] Document Decimal V2

Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d
Cherry-picks: not for 2.x.
Reviewed-on: http://gerrit.cloudera.org:8080/10066
Tested-by: Impala Public Jenkins 
Reviewed-by: Alex Rodoni 
---
M docs/impala_keydefs.ditamap
M docs/topics/impala_decimal.xml
2 files changed, 846 insertions(+), 704 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Alex Rodoni: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/10066
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d
Gerrit-Change-Number: 10066
Gerrit-PatchSet: 17
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Greg Rahn 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Taras Bobrovytsky 

[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2

[Alex Rodoni (Code Review)]

Alex Rodoni has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10066 )

Change subject: IMPALA-6522: [DOCS] Document Decimal V2
..


Patch Set 16: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/10066
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d
Gerrit-Change-Number: 10066
Gerrit-PatchSet: 16
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Greg Rahn 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Taras Bobrovytsky 
Gerrit-Comment-Date: Mon, 30 Apr 2018 18:13:31 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10066 )

Change subject: IMPALA-6522: [DOCS] Document Decimal V2
..


Patch Set 16: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/10066
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d
Gerrit-Change-Number: 10066
Gerrit-PatchSet: 16
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Greg Rahn 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Taras Bobrovytsky 
Gerrit-Comment-Date: Mon, 30 Apr 2018 18:11:59 +
Gerrit-HasComments: No

[Impala-ASF-CR](2.x) Update version to 2.13.0-SNAPSHOT

[Lars Volker (Code Review)]

Lars Volker has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10241 )

Change subject: Update version to 2.13.0-SNAPSHOT
..


Patch Set 1: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/10241
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac447c57a273e0c334e0e63d6e740c2a00d5c762
Gerrit-Change-Number: 10241
Gerrit-PatchSet: 1
Gerrit-Owner: Sailesh Mukil 
Gerrit-Reviewer: Lars Volker 
Gerrit-Comment-Date: Mon, 30 Apr 2018 18:10:58 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10066 )

Change subject: IMPALA-6522: [DOCS] Document Decimal V2
..


Patch Set 16:

Build started: https://jenkins.impala.io/job/gerrit-docs-submit/271/


--
To view, visit http://gerrit.cloudera.org:8080/10066
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d
Gerrit-Change-Number: 10066
Gerrit-PatchSet: 16
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Greg Rahn 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Taras Bobrovytsky 
Gerrit-Comment-Date: Mon, 30 Apr 2018 18:03:07 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2

[Alex Rodoni (Code Review)]

Hello Greg Rahn, Taras Bobrovytsky, Alex Behm, Dan Hecht, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/10066

to look at the new patch set (#16).

Change subject: IMPALA-6522: [DOCS] Document Decimal V2
..

IMPALA-6522: [DOCS] Document Decimal V2

Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d
Cherry-picks: not for 2.x.
---
M docs/impala_keydefs.ditamap
M docs/topics/impala_decimal.xml
2 files changed, 846 insertions(+), 704 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/66/10066/16
--
To view, visit http://gerrit.cloudera.org:8080/10066
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d
Gerrit-Change-Number: 10066
Gerrit-PatchSet: 16
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Greg Rahn 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Taras Bobrovytsky 

[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10066 )

Change subject: IMPALA-6522: [DOCS] Document Decimal V2
..


Patch Set 15: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/10066
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d
Gerrit-Change-Number: 10066
Gerrit-PatchSet: 15
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Greg Rahn 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Taras Bobrovytsky 
Gerrit-Comment-Date: Mon, 30 Apr 2018 17:44:48 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10066 )

Change subject: IMPALA-6522: [DOCS] Document Decimal V2
..


Patch Set 15:

Build started: https://jenkins.impala.io/job/gerrit-docs-submit/270/


--
To view, visit http://gerrit.cloudera.org:8080/10066
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d
Gerrit-Change-Number: 10066
Gerrit-PatchSet: 15
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Greg Rahn 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Taras Bobrovytsky 
Gerrit-Comment-Date: Mon, 30 Apr 2018 17:41:50 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2

[Alex Behm (Code Review)]

Alex Behm has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10066 )

Change subject: IMPALA-6522: [DOCS] Document Decimal V2
..


Patch Set 15: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/10066
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d
Gerrit-Change-Number: 10066
Gerrit-PatchSet: 15
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Greg Rahn 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Taras Bobrovytsky 
Gerrit-Comment-Date: Mon, 30 Apr 2018 17:36:42 +
Gerrit-HasComments: No

[Impala-ASF-CR] Warn about Hadoop / Java version incompatibility

[Lars Volker (Code Review)]

Lars Volker has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/10244


Change subject: Warn about Hadoop / Java version incompatibility
..

Warn about Hadoop / Java version incompatibility

Running Hadoop 3 with Java 7 can result in some obscure error messages.
This change adds a warning to impala-config.sh when using Hadoop 3 with
Java 7.

   Your development environment is configured for Hadoop 3 and Java 7.
   Hadoop 3 requires at least Java 8. Your JAVA binary currently points
   to /usr/lib/jvm/java-7-oracle-amd64/bin/java and reports the
   following version:

   java version "1.7.0_75"
   Java(TM) SE Runtime Environment (build 1.7.0_75-b13)
   Java HotSpot(TM) 64-Bit Server VM (build 24.75-b04, mixed mode)

It also catches failure of the minicluster start and prints an
additional warning when running with Hadoop 3 and Java 7.

Change-Id: I4d8b505cf045eeb562d16ce4ce09da0712dc03eb
---
M bin/impala-config.sh
M testdata/bin/run-mini-dfs.sh
2 files changed, 33 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/10244/1
--
To view, visit http://gerrit.cloudera.org:8080/10244
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4d8b505cf045eeb562d16ce4ce09da0712dc03eb
Gerrit-Change-Number: 10244
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker 

[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2

[Alex Rodoni (Code Review)]

Alex Rodoni has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10066 )

Change subject: IMPALA-6522: [DOCS] Document Decimal V2
..


Patch Set 14:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10066/14/docs/topics/impala_decimal.xml
File docs/topics/impala_decimal.xml:

http://gerrit.cloudera.org:8080/#/c/10066/14/docs/topics/impala_decimal.xml@390
PS14, Line 390:   If there is enough precision but not enough scale in 
the destination, Impala rounds
> Not correct. Impala does not round for assignments.
Done



--
To view, visit http://gerrit.cloudera.org:8080/10066
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d
Gerrit-Change-Number: 10066
Gerrit-PatchSet: 14
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Greg Rahn 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Taras Bobrovytsky 
Gerrit-Comment-Date: Mon, 30 Apr 2018 17:32:50 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2

[Alex Rodoni (Code Review)]

Hello Greg Rahn, Taras Bobrovytsky, Alex Behm, Dan Hecht, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/10066

to look at the new patch set (#15).

Change subject: IMPALA-6522: [DOCS] Document Decimal V2
..

IMPALA-6522: [DOCS] Document Decimal V2

Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d
Cherry-picks: not for 2.x.
---
M docs/impala_keydefs.ditamap
M docs/topics/impala_decimal.xml
2 files changed, 849 insertions(+), 704 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/66/10066/15
--
To view, visit http://gerrit.cloudera.org:8080/10066
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d
Gerrit-Change-Number: 10066
Gerrit-PatchSet: 15
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Greg Rahn 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Taras Bobrovytsky 

[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2

[Alex Behm (Code Review)]

Alex Behm has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10066 )

Change subject: IMPALA-6522: [DOCS] Document Decimal V2
..


Patch Set 14:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10066/14/docs/topics/impala_decimal.xml
File docs/topics/impala_decimal.xml:

http://gerrit.cloudera.org:8080/#/c/10066/14/docs/topics/impala_decimal.xml@390
PS14, Line 390:   If there is enough precision but not enough scale in 
the destination, Impala rounds
Not correct. Impala does not round for assignments.

Assignments require enough scale *and* precision.



--
To view, visit http://gerrit.cloudera.org:8080/10066
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d
Gerrit-Change-Number: 10066
Gerrit-PatchSet: 14
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Greg Rahn 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Taras Bobrovytsky 
Gerrit-Comment-Date: Mon, 30 Apr 2018 17:22:39 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

[Alex Behm (Code Review)]

Alex Behm has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8851 )

Change subject: IMPALA-3193: Show table's comment on show tables
..


Patch Set 19:

Did you get a chance to investigate? Anything I can help with?


--
To view, visit http://gerrit.cloudera.org:8080/8851
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I44f814af05db6f3c027718ade9f474f8b8153bcd
Gerrit-Change-Number: 8851
Gerrit-PatchSet: 19
Gerrit-Owner: Kim Jin Chul 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Kim Jin Chul 
Gerrit-Comment-Date: Mon, 30 Apr 2018 17:11:08 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2

[Alex Rodoni (Code Review)]

Hello Greg Rahn, Taras Bobrovytsky, Alex Behm, Dan Hecht, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/10066

to look at the new patch set (#14).

Change subject: IMPALA-6522: [DOCS] Document Decimal V2
..

IMPALA-6522: [DOCS] Document Decimal V2

Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d
Cherry-picks: not for 2.x.
---
M docs/impala_keydefs.ditamap
M docs/topics/impala_decimal.xml
2 files changed, 855 insertions(+), 704 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/66/10066/14
--
To view, visit http://gerrit.cloudera.org:8080/10066
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d
Gerrit-Change-Number: 10066
Gerrit-PatchSet: 14
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Greg Rahn 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Taras Bobrovytsky 

[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2

[Alex Rodoni (Code Review)]

Alex Rodoni has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10066 )

Change subject: IMPALA-6522: [DOCS] Document Decimal V2
..


Patch Set 13:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/10066/13/docs/topics/impala_decimal.xml
File docs/topics/impala_decimal.xml:

http://gerrit.cloudera.org:8080/#/c/10066/13/docs/topics/impala_decimal.xml@197
PS13, Line 197:   
> Let's move and replace this paragraph with the one on L208.
Done


http://gerrit.cloudera.org:8080/#/c/10066/13/docs/topics/impala_decimal.xml@209
PS13, Line 209:   Note that in memory and on disk for binary file formats, 
such as Parquet or Avro,
> This is not quite accurate and redundant with L197. Let's replace this para
Done


http://gerrit.cloudera.org:8080/#/c/10066/13/docs/topics/impala_decimal.xml@395
PS13, Line 395:   
> These points are not correct. For assignments, Impala is very strict. If th
Made the second point clear. And changed "leading digits" to "precision".


http://gerrit.cloudera.org:8080/#/c/10066/13/docs/topics/impala_decimal.xml@431
PS13, Line 431:   DECIMAL. An error returns.
> An error is returned.
Done



--
To view, visit http://gerrit.cloudera.org:8080/10066
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d
Gerrit-Change-Number: 10066
Gerrit-PatchSet: 13
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Greg Rahn 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Taras Bobrovytsky 
Gerrit-Comment-Date: Mon, 30 Apr 2018 17:08:02 +
Gerrit-HasComments: Yes

[Impala-ASF-CR](2.x) Update version to 2.13.0-SNAPSHOT

[Sailesh Mukil (Code Review)]

Sailesh Mukil has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/10241


Change subject: Update version to 2.13.0-SNAPSHOT
..

Update version to 2.13.0-SNAPSHOT

Change-Id: Iac447c57a273e0c334e0e63d6e740c2a00d5c762
---
M bin/save-version.sh
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/41/10241/1
--
To view, visit http://gerrit.cloudera.org:8080/10241
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iac447c57a273e0c334e0e63d6e740c2a00d5c762
Gerrit-Change-Number: 10241
Gerrit-PatchSet: 1
Gerrit-Owner: Sailesh Mukil 

[Impala-ASF-CR] IMPALA-6916: Implement COMMENT ON DATABASE

[Alex Behm (Code Review)]

Alex Behm has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10171 )

Change subject: IMPALA-6916: Implement COMMENT ON DATABASE
..


Patch Set 6:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/10171/6/common/thrift/JniCatalog.thrift
File common/thrift/JniCatalog.thrift:

http://gerrit.cloudera.org:8080/#/c/10171/6/common/thrift/JniCatalog.thrift@635
PS6, Line 635:   // Name of comment to alter.
Comment what happens if the comment is not set


http://gerrit.cloudera.org:8080/#/c/10171/6/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:

http://gerrit.cloudera.org:8080/#/c/10171/6/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3534
PS6, Line 3534: long newVersion = catalog_.incrementAndGetCatalogVersion();
There's a subtle race here with the statestore topic update thread that calls 
CatalogServiceCatalog.getCatalogDelta().

The main problem here is that incrementing the global version and setting the 
version on the db are not atomic. So in CatalogServiceCatalog.getCatalogDelta() 
we could getVersion() and then not include the db even though it falls within 
the expected version range due to this race.

For tables, we solve this problem with a lock in Table. We could follow a 
similar pattern for the db, but let's check with Dimitris whether this is a 
path we want to go down now.



--
To view, visit http://gerrit.cloudera.org:8080/10171
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcf909c18f97073346f6f603538bf921e69fbb00
Gerrit-Change-Number: 10171
Gerrit-PatchSet: 6
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Comment-Date: Mon, 30 Apr 2018 16:49:12 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] Fix minor perf bug in BufferedTupleStream

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10239 )

Change subject: Fix minor perf bug in BufferedTupleStream
..


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2383/


--
To view, visit http://gerrit.cloudera.org:8080/10239
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I05bae0018f79aec9c6014ae228ff28621b548860
Gerrit-Change-Number: 10239
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Mon, 30 Apr 2018 16:42:06 +
Gerrit-HasComments: No

[Impala-ASF-CR] Fix minor perf bug in BufferedTupleStream

[Alex Behm (Code Review)]

Alex Behm has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10239 )

Change subject: Fix minor perf bug in BufferedTupleStream
..


Patch Set 1: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/10239
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I05bae0018f79aec9c6014ae228ff28621b548860
Gerrit-Change-Number: 10239
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Alex Behm 
Gerrit-Comment-Date: Mon, 30 Apr 2018 16:34:21 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2

[Alex Behm (Code Review)]

Alex Behm has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10066 )

Change subject: IMPALA-6522: [DOCS] Document Decimal V2
..


Patch Set 13:

(4 comments)

Looks good, last round

http://gerrit.cloudera.org:8080/#/c/10066/13/docs/topics/impala_decimal.xml
File docs/topics/impala_decimal.xml:

http://gerrit.cloudera.org:8080/#/c/10066/13/docs/topics/impala_decimal.xml@197
PS13, Line 197:   
Let's move and replace this paragraph with the one on L208.


http://gerrit.cloudera.org:8080/#/c/10066/13/docs/topics/impala_decimal.xml@209
PS13, Line 209:   Note that in memory and on disk for binary file formats, 
such as Parquet or Avro,
This is not quite accurate and redundant with L197. Let's replace this 
paragraph as mentioned above.


http://gerrit.cloudera.org:8080/#/c/10066/13/docs/topics/impala_decimal.xml@395
PS13, Line 395:   
These points are not correct. For assignments, Impala is very strict. If the 
destination does not have enough precision, then Impala returns an error. No 
rounding is performed at all.


http://gerrit.cloudera.org:8080/#/c/10066/13/docs/topics/impala_decimal.xml@431
PS13, Line 431:   DECIMAL. An error returns.
An error is returned.



--
To view, visit http://gerrit.cloudera.org:8080/10066
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d
Gerrit-Change-Number: 10066
Gerrit-PatchSet: 13
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Greg Rahn 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Taras Bobrovytsky 
Gerrit-Comment-Date: Mon, 30 Apr 2018 16:32:08 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] Fix minor perf bug in BufferedTupleStream

[Tim Armstrong (Code Review)]

Tim Armstrong has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/10239


Change subject: Fix minor perf bug in BufferedTupleStream
..

Fix minor perf bug in BufferedTupleStream

The code referenced a member variable when the intent was clearly to use
the template argument.

Change-Id: I05bae0018f79aec9c6014ae228ff28621b548860
---
M be/src/runtime/buffered-tuple-stream.cc
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/10239/1
--
To view, visit http://gerrit.cloudera.org:8080/10239
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I05bae0018f79aec9c6014ae228ff28621b548860
Gerrit-Change-Number: 10239
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong 

[Impala-ASF-CR] IMPALA-6941: load more text scanner compression plugins

[Tim Armstrong (Code Review)]

Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10165 )

Change subject: IMPALA-6941: load more text scanner compression plugins
..


Patch Set 6:

This should be ready for review now.


--
To view, visit http://gerrit.cloudera.org:8080/10165
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If2a9c4a4a11bed81df706e9e834400bfedfe48e6
Gerrit-Change-Number: 10165
Gerrit-PatchSet: 6
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Mon, 30 Apr 2018 16:03:15 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6941: load more text scanner compression plugins

[Tim Armstrong (Code Review)]

Tim Armstrong has uploaded a new patch set (#6). ( 
http://gerrit.cloudera.org:8080/10165 )

Change subject: IMPALA-6941: load more text scanner compression plugins
..

IMPALA-6941: load more text scanner compression plugins

Add extensions for LZ4 and ZSTD (which are supported by Hadoop).
Even without a plugin this results in better behaviour because
we don't try to treat the files with unknown extensions as
uncompressed text.

Also allow loading tables containing files with unsupported
compression types. There was weird behaviour before we knew
of the file extension but didn't support querying the table -
the catalog would load the table but the impalad would fail
processing the catalog update. The simplest way to fix it
is to just allow loading the tables.

Switch to always checking plugin version - running mismatched plugin
is inherently unsafe.

Testing:
Positive case where LZO is loaded is exercised. Added
coverage for negative case where LZO is disabled.

Fixed test gaps:
* Querying LZO table with LZO plugin not available.
* Interacting with tables with known but unsupported text
  compressions.
* Querying files with unknown compression suffixes (which are
  treated as uncompressed text).

Change-Id: If2a9c4a4a11bed81df706e9e834400bfedfe48e6
---
M be/src/common/global-flags.cc
M be/src/exec/CMakeLists.txt
D be/src/exec/hdfs-lzo-text-scanner.cc
D be/src/exec/hdfs-lzo-text-scanner.h
A be/src/exec/hdfs-plugin-text-scanner.cc
A be/src/exec/hdfs-plugin-text-scanner.h
M be/src/exec/hdfs-scan-node-base.cc
M be/src/exec/hdfs-text-scanner.cc
M be/src/exec/hdfs-text-scanner.h
M be/src/util/backend-gflag-util.cc
M common/fbs/CatalogObjects.fbs
M common/thrift/BackendGflags.thrift
M fe/src/main/java/org/apache/impala/catalog/HdfsCompression.java
M fe/src/main/java/org/apache/impala/catalog/HdfsFileFormat.java
M fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java
M fe/src/main/java/org/apache/impala/service/BackendConfig.java
A testdata/workloads/functional-query/queries/QueryTest/disable-lzo-plugin.test
A 
testdata/workloads/functional-query/queries/QueryTest/unsupported-compression-partitions.test
A tests/custom_cluster/test_scanner_plugin.py
M tests/metadata/test_partition_metadata.py
20 files changed, 483 insertions(+), 239 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/65/10165/6
--
To view, visit http://gerrit.cloudera.org:8080/10165
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If2a9c4a4a11bed81df706e9e834400bfedfe48e6
Gerrit-Change-Number: 10165
Gerrit-PatchSet: 6
Gerrit-Owner: Tim Armstrong 

[Impala-ASF-CR] IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries

[Alex Behm (Code Review)]

Alex Behm has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9005 )

Change subject: IMPALA-6314: Add run time scalar subquery check for 
uncorrelated subqueries
..


Patch Set 32:

Nice work, Zoltan! This was a pretty intense task. Thanks for pulling through.


--
To view, visit http://gerrit.cloudera.org:8080/9005
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f52b93a60eeacedd242a2f17fa6b99c4fc38e06
Gerrit-Change-Number: 9005
Gerrit-PatchSet: 32
Gerrit-Owner: Zoltan Borok-Nagy 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Attila Jeges 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Vuk Ercegovac 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Mon, 30 Apr 2018 16:02:52 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6951: Revert "Warn about Hadoop / Java version incompatibility"

[Michael Brown (Code Review)]

Michael Brown has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10238 )

Change subject: IMPALA-6951: Revert "Warn about Hadoop / Java version 
incompatibility"
..


Patch Set 1: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/10238
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I41a9afb1a1bc9be1cae687edc06ca3b554a32c7b
Gerrit-Change-Number: 10238
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Brown 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Mon, 30 Apr 2018 15:58:41 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6951: Revert "Warn about Hadoop / Java version incompatibility"

[Michael Brown (Code Review)]

Michael Brown has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/10238 )

Change subject: IMPALA-6951: Revert "Warn about Hadoop / Java version 
incompatibility"
..

IMPALA-6951: Revert "Warn about Hadoop / Java version incompatibility"

This reverts commit 22c7ded07eb2710aba3e1aa07ed7ec1a448f7c61.

Change-Id: I41a9afb1a1bc9be1cae687edc06ca3b554a32c7b
Reviewed-on: http://gerrit.cloudera.org:8080/10238
Reviewed-by: Philip Zeyliger 
Tested-by: Michael Brown 
---
M bin/impala-config.sh
1 file changed, 0 insertions(+), 15 deletions(-)

Approvals:
  Philip Zeyliger: Looks good to me, approved
  Michael Brown: Verified

--
To view, visit http://gerrit.cloudera.org:8080/10238
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I41a9afb1a1bc9be1cae687edc06ca3b554a32c7b
Gerrit-Change-Number: 10238
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Brown 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Philip Zeyliger 

[Impala-ASF-CR] IMPALA-6951: Revert "Warn about Hadoop / Java version incompatibility"

[Philip Zeyliger (Code Review)]

Philip Zeyliger has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10238 )

Change subject: IMPALA-6951: Revert "Warn about Hadoop / Java version 
incompatibility"
..


Patch Set 1: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10238/1/bin/impala-config.sh
File bin/impala-config.sh:

http://gerrit.cloudera.org:8080/#/c/10238/1/bin/impala-config.sh@a237
PS1, Line 237:
For when we re-apply this, I think we could just remove this line, too. i.e., 
when I read the commit message, I thought "warning" was just that. This is more 
like an error, eh?



--
To view, visit http://gerrit.cloudera.org:8080/10238
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I41a9afb1a1bc9be1cae687edc06ca3b554a32c7b
Gerrit-Change-Number: 10238
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Brown 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Mon, 30 Apr 2018 15:56:22 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6951: Revert "Warn about Hadoop / Java version incompatibility"

[Michael Brown (Code Review)]

Michael Brown has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/10238


Change subject: IMPALA-6951: Revert "Warn about Hadoop / Java version 
incompatibility"
..

IMPALA-6951: Revert "Warn about Hadoop / Java version incompatibility"

This reverts commit 22c7ded07eb2710aba3e1aa07ed7ec1a448f7c61.

Change-Id: I41a9afb1a1bc9be1cae687edc06ca3b554a32c7b
---
M bin/impala-config.sh
1 file changed, 0 insertions(+), 15 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/38/10238/1
--
To view, visit http://gerrit.cloudera.org:8080/10238
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I41a9afb1a1bc9be1cae687edc06ca3b554a32c7b
Gerrit-Change-Number: 10238
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Brown 

[Impala-ASF-CR] IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries

[Zoltan Borok-Nagy (Code Review)]

Zoltan Borok-Nagy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9005 )

Change subject: IMPALA-6314: Add run time scalar subquery check for 
uncorrelated subqueries
..


Patch Set 32:

Yay, it's finally in, it was a long journey! :)
Thanks to everyone who participated in the review.
Special thanks to Alex for the tremendous amount of insights about the frontend!


--
To view, visit http://gerrit.cloudera.org:8080/9005
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f52b93a60eeacedd242a2f17fa6b99c4fc38e06
Gerrit-Change-Number: 9005
Gerrit-PatchSet: 32
Gerrit-Owner: Zoltan Borok-Nagy 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Attila Jeges 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Vuk Ercegovac 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Mon, 30 Apr 2018 09:13:11 +
Gerrit-HasComments: No