[Impala-ASF-CR] IMPALA-8717: impala-shell support for HS2 HTTP endpoint
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13746 ) Change subject: IMPALA-8717: impala-shell support for HS2 HTTP endpoint .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/3764/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13746 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8323950857dfe1c1dfd5377fde79f87bc2ce9534 Gerrit-Change-Number: 13746 Gerrit-PatchSet: 3 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 27 Jun 2019 06:58:31 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5031: link fesupport so FE tests run with UBSAN
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13710 ) Change subject: IMPALA-5031: link fesupport so FE tests run with UBSAN .. IMPALA-5031: link fesupport so FE tests run with UBSAN This commit enables the frontend and JDBC tests to run under UBSAN. Before this comit, they fail with an error message about finding the UBSAN support functions like __ubsan_handle_load_invalid_value. Linking those functions into libfesupport.so requires using the linker flag --whole-archive so that these symbols, which are not directly referenced by the source code used to build libfesupport.so, are included. This patch also enables the custom cluster tests to run under UBSAN; they recently gained frontend tests in commit d72f3330c1edc9086ba120e6d3469a75c0aea083. Change-Id: I42049fb3e2de83aee0d0e00e2703788afde739e2 Reviewed-on: http://gerrit.cloudera.org:8080/13710 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M be/src/service/CMakeLists.txt M bin/impala-config.sh 2 files changed, 13 insertions(+), 0 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/13710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I42049fb3e2de83aee0d0e00e2703788afde739e2 Gerrit-Change-Number: 13710 Gerrit-PatchSet: 7 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-5031: link fesupport so FE tests run with UBSAN
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13710 ) Change subject: IMPALA-5031: link fesupport so FE tests run with UBSAN .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/13710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42049fb3e2de83aee0d0e00e2703788afde739e2 Gerrit-Change-Number: 13710 Gerrit-PatchSet: 6 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Thu, 27 Jun 2019 06:56:00 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8663 : FileMetadataLoader should skip hidden and tmp directories
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13665 ) Change subject: IMPALA-8663 : FileMetadataLoader should skip hidden and tmp directories .. Patch Set 8: (6 comments) http://gerrit.cloudera.org:8080/#/c/13665/8/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java File fe/src/main/java/org/apache/impala/common/FileSystemUtil.java: http://gerrit.cloudera.org:8080/#/c/13665/8/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@541 PS8, Line 541: temporary directories the code now seems to also skip any files that match this pattern, not just directories. I think that's probably OK but we should be clear on the semantics. http://gerrit.cloudera.org:8080/#/c/13665/8/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@545 PS8, Line 545: all underlying files (except which are :* in the ignored directories) does this mean we no longer yield directories, and only yield files? does this not break the case of an empty base data dir, which actually has semantic value? http://gerrit.cloudera.org:8080/#/c/13665/8/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@568 PS8, Line 568: isS3AFileSystem(p) why'd you change from isS3AFileSystem(fs) to isS3AFileSystem(p)? In the case that 'p' isn't a fully qualified path, this will check the wrong filesystem, and we don't have any preconditions checking that 'p' must be fully qualified. http://gerrit.cloudera.org:8080/#/c/13665/8/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@568 PS8, Line 568: isS3AFileSystem perhaps we can add a @VisibleForTesting way we can make this path get used even for non-S3, so we can get test coverage here? http://gerrit.cloudera.org:8080/#/c/13665/8/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@626 PS8, Line 626: LISTING_TYPE style nit: enums should be named like classes (ListingType) http://gerrit.cloudera.org:8080/#/c/13665/8/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@699 PS8, Line 699: // if the current file is on a ignored path return early : if (isIgnoredPath(fileStatus)) return; how does this prevent recursion into tmp dirs in the recursive listFiles case? It seems like this is only checking the filename (last path component) and not intermediate path components, which we'd need to be doing to filter out contents of subdirectories for the "native recursion" -- To view, visit http://gerrit.cloudera.org:8080/13665 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2c4a22908304fe9e377d77d6c18d401c3f3294aa Gerrit-Change-Number: 13665 Gerrit-PatchSet: 8 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Thu, 27 Jun 2019 06:46:34 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8717: impala-shell support for HS2 HTTP endpoint
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13746 ) Change subject: IMPALA-8717: impala-shell support for HS2 HTTP endpoint .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4561/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/13746 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8323950857dfe1c1dfd5377fde79f87bc2ce9534 Gerrit-Change-Number: 13746 Gerrit-PatchSet: 3 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 27 Jun 2019 06:39:48 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8717: impala-shell support for HS2 HTTP endpoint
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13746 ) Change subject: IMPALA-8717: impala-shell support for HS2 HTTP endpoint .. Patch Set 3: (9 comments) http://gerrit.cloudera.org:8080/#/c/13746/3/shell/impala_client.py File shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/13746/3/shell/impala_client.py@375 PS3, Line 375: flake8: E261 at least two spaces before inline comment http://gerrit.cloudera.org:8080/#/c/13746/3/shell/impala_client.py@379 PS3, Line 379: flake8: E222 multiple spaces after operator http://gerrit.cloudera.org:8080/#/c/13746/3/shell/impala_client.py@384 PS3, Line 384: flake8: E203 whitespace before ':' http://gerrit.cloudera.org:8080/#/c/13746/3/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/13746/3/shell/impala_shell.py@537 PS3, Line 537: . flake8: E501 line too long (93 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13746/3/shell/impala_shell.py@797 PS3, Line 797: L flake8: E501 line too long (102 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13746/3/shell/option_parser.py File shell/option_parser.py: http://gerrit.cloudera.org:8080/#/c/13746/3/shell/option_parser.py@266 PS3, Line 266: " flake8: E501 line too long (91 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13746/3/tests/common/test_dimensions.py File tests/common/test_dimensions.py: http://gerrit.cloudera.org:8080/#/c/13746/3/tests/common/test_dimensions.py@120 PS3, Line 120: def create_http_transport_dimension(): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/13746/3/tests/common/test_dimensions.py@123 PS3, Line 123: def beeswax_http_constraint(v): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/13746/3/tests/shell/util.py File tests/shell/util.py: http://gerrit.cloudera.org:8080/#/c/13746/3/tests/shell/util.py@153 PS3, Line 153: ) flake8: E501 line too long (93 > 90 characters) -- To view, visit http://gerrit.cloudera.org:8080/13746 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8323950857dfe1c1dfd5377fde79f87bc2ce9534 Gerrit-Change-Number: 13746 Gerrit-PatchSet: 3 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 27 Jun 2019 06:18:41 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8717: impala-shell support for HS2 HTTP endpoint
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13746 to look at the new patch set (#3). Change subject: IMPALA-8717: impala-shell support for HS2 HTTP endpoint .. IMPALA-8717: impala-shell support for HS2 HTTP endpoint Adds impala-shell support to connect to HiveServer2 HTTP endpoint. Relies on toolchain change at https://gerrit.cloudera.org/#/c/13725/. Adds a new shell flag --use_http_transport that tells it to pick the appropriate client transport. Example usages: --- impala-shell --protocol='hs2' --use_http_transport impala-shell --protocol='hs2' --use_http_transport --ldap -u. impala-shell --protocol-'hs2' --use_http_transport --ssl --ca_cert... Limitations: --- - Does not work with the default --protocol='beeswax' due to lack of server side support. Appropriate error message is thrown. - Does not support Kerberos (-k) due to lack ot SPNEGO support. Testing: - Parameterized existing shell tests to support this combination. - Manually tested plain LDAP and LDAP + TLS combinations due to lack of LDAP support in tests. Change-Id: I8323950857dfe1c1dfd5377fde79f87bc2ce9534 --- M be/src/service/impala-server.cc M bin/impala-config.sh M shell/impala_client.py M shell/impala_shell.py M shell/option_parser.py M tests/common/impala_test_suite.py M tests/common/test_dimensions.py M tests/conftest.py M tests/custom_cluster/test_client_ssl.py M tests/shell/test_shell_commandline.py M tests/shell/test_shell_interactive.py M tests/shell/util.py 12 files changed, 103 insertions(+), 27 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/13746/3 -- To view, visit http://gerrit.cloudera.org:8080/13746 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8323950857dfe1c1dfd5377fde79f87bc2ce9534 Gerrit-Change-Number: 13746 Gerrit-PatchSet: 3 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-8369: Bump CDP BUILD NUMBER and re-enable test max nesting depth
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13723 ) Change subject: IMPALA-8369: Bump CDP_BUILD_NUMBER and re-enable test_max_nesting_depth .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/13723 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1d6f4e29997c9cf2238e1d614f8d1ed7d35ffe92 Gerrit-Change-Number: 13723 Gerrit-PatchSet: 3 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Thu, 27 Jun 2019 05:03:54 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8369: Bump CDP BUILD NUMBER and re-enable test max nesting depth
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13723 ) Change subject: IMPALA-8369: Bump CDP_BUILD_NUMBER and re-enable test_max_nesting_depth .. IMPALA-8369: Bump CDP_BUILD_NUMBER and re-enable test_max_nesting_depth Switch to a newer version of CDP Hive where HIVE-20833 is reverted. HIVE-20833 was backported without HIVE-20221, which broke the the handling of column PARTITION_PARAMS.PARAM_KEY in HMS, leading to several test failures in Impala. The new HIVE version also includes the fix for HIVE-21796, so test_max_nesting_depth could be also re-enabled with Hive 3. Change-Id: I1d6f4e29997c9cf2238e1d614f8d1ed7d35ffe92 Reviewed-on: http://gerrit.cloudera.org:8080/13723 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M bin/impala-config.sh M tests/common/skip.py M tests/query_test/test_nested_types.py 3 files changed, 6 insertions(+), 10 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/13723 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I1d6f4e29997c9cf2238e1d614f8d1ed7d35ffe92 Gerrit-Change-Number: 13723 Gerrit-PatchSet: 4 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Zoltan Borok-Nagy
[Impala-ASF-CR] IMPALA-8585: Fix upgraded table related tests in AcidUtilsTest
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13730 ) Change subject: IMPALA-8585: Fix upgraded table related tests in AcidUtilsTest .. IMPALA-8585: Fix upgraded table related tests in AcidUtilsTest The following changes were ok on their own, but together led to broken tests on Hive 3: https://gerrit.cloudera.org/#/c/13428/ https://gerrit.cloudera.org/#/c/13427/ Change-Id: Iad41c1a7b0458a405b95f62d8e0ecd93947f492d Reviewed-on: http://gerrit.cloudera.org:8080/13730 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M fe/src/test/java/org/apache/impala/util/AcidUtilsTest.java 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/13730 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Iad41c1a7b0458a405b95f62d8e0ecd93947f492d Gerrit-Change-Number: 13730 Gerrit-PatchSet: 4 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Zoltan Borok-Nagy
[Impala-ASF-CR] IMPALA-8585: Fix upgraded table related tests in AcidUtilsTest
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13730 ) Change subject: IMPALA-8585: Fix upgraded table related tests in AcidUtilsTest .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/13730 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iad41c1a7b0458a405b95f62d8e0ecd93947f492d Gerrit-Change-Number: 13730 Gerrit-PatchSet: 3 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Thu, 27 Jun 2019 05:02:38 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8630: Hash the full path when calculating consistent remote placement
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13545 ) Change subject: IMPALA-8630: Hash the full path when calculating consistent remote placement .. Patch Set 13: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/13545 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I46c739fc31af539af2b3509e2a161f4e29f44d7b Gerrit-Change-Number: 13545 Gerrit-PatchSet: 13 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Thu, 27 Jun 2019 04:24:19 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8681: Only show ValidWriteIdLists for Acid tables
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13736 ) Change subject: IMPALA-8681: Only show ValidWriteIdLists for Acid tables .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/3763/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13736 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifcc31c7ddcfc471b0e5308f7e4aaadfa8189a905 Gerrit-Change-Number: 13736 Gerrit-PatchSet: 2 Gerrit-Owner: Yongzhi Chen Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Yongzhi Chen Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Thu, 27 Jun 2019 03:20:31 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8716: Log a group of privileges into a single audit event.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13744 ) Change subject: IMPALA-8716: Log a group of privileges into a single audit event. .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/3762/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13744 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib53102bc1ceaf9d62544090dc00f3231fae0efca Gerrit-Change-Number: 13744 Gerrit-PatchSet: 2 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Thu, 27 Jun 2019 03:02:10 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8681: Only show ValidWriteIdLists for Acid tables
Yongzhi Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/13736 ) Change subject: IMPALA-8681: Only show ValidWriteIdLists for Acid tables .. Patch Set 2: (1 comment) Add a new test with patch2 http://gerrit.cloudera.org:8080/#/c/13736/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13736/1//COMMIT_MSG@16 PS1, Line 16: Fixed StmtMetadataLoaderTest. > Maybe you coud add Hive3-only e2e tests with RUNTIME_PROFILE section that h Done -- To view, visit http://gerrit.cloudera.org:8080/13736 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifcc31c7ddcfc471b0e5308f7e4aaadfa8189a905 Gerrit-Change-Number: 13736 Gerrit-PatchSet: 2 Gerrit-Owner: Yongzhi Chen Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Yongzhi Chen Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Thu, 27 Jun 2019 02:38:51 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8681: Only show ValidWriteIdLists for Acid tables
Hello Zoltan Borok-Nagy, Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13736 to look at the new patch set (#2). Change subject: IMPALA-8681: Only show ValidWriteIdLists for Acid tables .. IMPALA-8681: Only show ValidWriteIdLists for Acid tables Lists ValidWriteIds for transactional tables in profile. If a query does not trigger any transactional table loading, the query profile will not have the "Loaded ValidWriteIdLists" timeline. Tests: Manual tests. Fixed StmtMetadataLoaderTest. Added acid_profile test Sample output: Query Compilation: 3s525ms - Metadata load started: 37.369ms (37.369ms) - Metadata load finished. loaded-tables=1/1 ... - Loaded ValidWriteIdLists for transactional tables: functional.insert_only_transactional_table:0:9223372036854775807:: : 3s312ms (551.463us) - Analysis finished: 3s370ms (58.110ms) ... Change-Id: Ifcc31c7ddcfc471b0e5308f7e4aaadfa8189a905 --- M fe/src/main/java/org/apache/impala/analysis/StmtMetadataLoader.java M fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java A testdata/workloads/functional-query/queries/QueryTest/acid-profile.test M tests/common/skip.py M tests/query_test/test_acid.py 5 files changed, 42 insertions(+), 10 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/36/13736/2 -- To view, visit http://gerrit.cloudera.org:8080/13736 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ifcc31c7ddcfc471b0e5308f7e4aaadfa8189a905 Gerrit-Change-Number: 13736 Gerrit-PatchSet: 2 Gerrit-Owner: Yongzhi Chen Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Yongzhi Chen Gerrit-Reviewer: Zoltan Borok-Nagy
[Impala-ASF-CR] IMPALA-8716: Log a group of privileges into a single audit event.
Fredy Wijaya has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/13744 ) Change subject: IMPALA-8716: Log a group of privileges into a single audit event. .. IMPALA-8716: Log a group of privileges into a single audit event. This patch updates the audit log handler to group a privilege that consists of multiple privileges into a single audit event. For example if we run "show partitions foo.bar" and we have SELECT privilege on table "foo.bar", before this patch, we would be creating 2 audit events: - Attempt to check if there's INSERT privilege on table "foo.bar" Result: denied, access type: insert, resource: foo.bar - Attempt to check if there's SELECT privilege on table "foo.bar" Result: allowed, access type: select, resource: foo.bar After this patch, we will only create a single audit event, e.g. Result: allowed, access type: view_metadata, resource: foo.bar Testing: - Updated tests in RangerAuditLogTest - Ran FE tests Change-Id: Ib53102bc1ceaf9d62544090dc00f3231fae0efca --- M fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java M fe/src/test/java/org/apache/impala/authorization/ranger/RangerAuditLogTest.java 2 files changed, 87 insertions(+), 20 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/13744/2 -- To view, visit http://gerrit.cloudera.org:8080/13744 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib53102bc1ceaf9d62544090dc00f3231fae0efca Gerrit-Change-Number: 13744 Gerrit-PatchSet: 2 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Todd Lipcon
[Impala-ASF-CR] Add ext-py/bitarray-0.9.0 in .gitignore
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13745 ) Change subject: Add ext-py/bitarray-0.9.0 in .gitignore .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13745 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I22abd82eb2c5a4a52fd56fd2266b636a0dbde071 Gerrit-Change-Number: 13745 Gerrit-PatchSet: 2 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Thu, 27 Jun 2019 02:05:18 + Gerrit-HasComments: No
[Impala-ASF-CR] Add ext-py/bitarray-0.9.0 in .gitignore
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13745 ) Change subject: Add ext-py/bitarray-0.9.0 in .gitignore .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4559/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/13745 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I22abd82eb2c5a4a52fd56fd2266b636a0dbde071 Gerrit-Change-Number: 13745 Gerrit-PatchSet: 2 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Thu, 27 Jun 2019 02:05:19 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5031: link fesupport so FE tests run with UBSAN
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13710 ) Change subject: IMPALA-5031: link fesupport so FE tests run with UBSAN .. Patch Set 6: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4558/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/13710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42049fb3e2de83aee0d0e00e2703788afde739e2 Gerrit-Change-Number: 13710 Gerrit-PatchSet: 6 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Thu, 27 Jun 2019 01:21:53 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5031: link fesupport so FE tests run with UBSAN
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13710 ) Change subject: IMPALA-5031: link fesupport so FE tests run with UBSAN .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42049fb3e2de83aee0d0e00e2703788afde739e2 Gerrit-Change-Number: 13710 Gerrit-PatchSet: 6 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Thu, 27 Jun 2019 01:21:52 + Gerrit-HasComments: No
[Impala-ASF-CR] Add ext-py/bitarray-0.9.0 in .gitignore
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13745 ) Change subject: Add ext-py/bitarray-0.9.0 in .gitignore .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/3761/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13745 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I22abd82eb2c5a4a52fd56fd2266b636a0dbde071 Gerrit-Change-Number: 13745 Gerrit-PatchSet: 1 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Thu, 27 Jun 2019 00:29:34 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8716: Log a group of privileges into a single audit event.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13744 ) Change subject: IMPALA-8716: Log a group of privileges into a single audit event. .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/3760/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13744 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib53102bc1ceaf9d62544090dc00f3231fae0efca Gerrit-Change-Number: 13744 Gerrit-PatchSet: 1 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Thu, 27 Jun 2019 00:28:08 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8713: fix stack overflow in unhex()
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13743 ) Change subject: IMPALA-8713: fix stack overflow in unhex() .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/3759/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13743 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie0c1760511a04c0823fc465cf6e529e9681b2488 Gerrit-Change-Number: 13743 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 27 Jun 2019 00:27:03 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8476: Replace Sentry admin check workaround with proper Sentry API
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13346 ) Change subject: IMPALA-8476: Replace Sentry admin check workaround with proper Sentry API .. Patch Set 15: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/13346 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5a27140d401494bc372ad0da96ada57bda94cd82 Gerrit-Change-Number: 13346 Gerrit-PatchSet: 15 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 27 Jun 2019 00:22:43 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8476: Replace Sentry admin check workaround with proper Sentry API
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13346 ) Change subject: IMPALA-8476: Replace Sentry admin check workaround with proper Sentry API .. IMPALA-8476: Replace Sentry admin check workaround with proper Sentry API Impala uses a workaround to detect if a user is a Sentry admin by calling the Sentry API to list privileges associated with the user since previously Sentry did not provide a suitable API to peform this check. This patch invokes a new API in SENTRY-2440 to perform the Sentry admin check. Also modified test_sentry.py to exercise the code paths corresponding to the following 3 different types of users: (i) a Sentry admin, (ii) an existing user which is not a Sentry admin, and (iii) a non-existing user. Testing: 1. Passed the tests in the revised test_sentry.py. Change-Id: I5a27140d401494bc372ad0da96ada57bda94cd82 Reviewed-on: http://gerrit.cloudera.org:8080/13346 Reviewed-by: Fredy Wijaya Tested-by: Impala Public Jenkins --- M fe/src/main/java/org/apache/impala/authorization/sentry/SentryCatalogdAuthorizationManager.java M fe/src/main/java/org/apache/impala/authorization/sentry/SentryPolicyService.java M fe/src/main/java/org/apache/impala/authorization/sentry/SentryProxy.java M fe/src/main/java/org/apache/impala/service/JniCatalog.java M tests/authorization/test_sentry.py 5 files changed, 54 insertions(+), 23 deletions(-) Approvals: Fredy Wijaya: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/13346 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I5a27140d401494bc372ad0da96ada57bda94cd82 Gerrit-Change-Number: 13346 Gerrit-PatchSet: 16 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] Add ext-py/bitarray-0.9.0 in .gitignore
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13745 ) Change subject: Add ext-py/bitarray-0.9.0 in .gitignore .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13745 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I22abd82eb2c5a4a52fd56fd2266b636a0dbde071 Gerrit-Change-Number: 13745 Gerrit-PatchSet: 1 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Thu, 27 Jun 2019 00:20:34 + Gerrit-HasComments: No
[Impala-ASF-CR] Add ext-py/bitarray-0.9.0 in .gitignore
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13745 Change subject: Add ext-py/bitarray-0.9.0 in .gitignore .. Add ext-py/bitarray-0.9.0 in .gitignore Change-Id: I22abd82eb2c5a4a52fd56fd2266b636a0dbde071 --- M shell/.gitignore 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/45/13745/1 -- To view, visit http://gerrit.cloudera.org:8080/13745 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I22abd82eb2c5a4a52fd56fd2266b636a0dbde071 Gerrit-Change-Number: 13745 Gerrit-PatchSet: 1 Gerrit-Owner: Fredy Wijaya
[Impala-ASF-CR] IMPALA-8716: Log a group of privileges into a single audit event.
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13744 Change subject: IMPALA-8716: Log a group of privileges into a single audit event. .. IMPALA-8716: Log a group of privileges into a single audit event. This patch updates the audit log handler to group a privilege that consists of multiple privileges into a single audit event. For example if we run "show partitions foo.bar" and we have SELECT privilege on table "foo.bar", before this patch, we would be creating 2 audit events: - Attempt to check if there's INSERT privilege on table "foo.bar" Result: denied, access type: insert, resource: foo.bar - Attempt to check if there's SELECT privilege on table "foo.bar" Result: allowed, access type: select, resource: foo.bar After this patch, we will only create a single audit event, e.g. Result: allowed, access type: view_metadata, resource: foo.bar Testing: - Updated tests in RangerAuditLogTest - Ran FE tests Change-Id: Ib53102bc1ceaf9d62544090dc00f3231fae0efca --- M fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java M fe/src/test/java/org/apache/impala/authorization/ranger/RangerAuditLogTest.java 2 files changed, 81 insertions(+), 20 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/13744/1 -- To view, visit http://gerrit.cloudera.org:8080/13744 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib53102bc1ceaf9d62544090dc00f3231fae0efca Gerrit-Change-Number: 13744 Gerrit-PatchSet: 1 Gerrit-Owner: Fredy Wijaya
[Impala-ASF-CR] IMPALA-8713: fix stack overflow in unhex()
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13743 Change subject: IMPALA-8713: fix stack overflow in unhex() .. IMPALA-8713: fix stack overflow in unhex() Write the results into the output heap buffer instead of into a temporary stack buffer. No additional memory is used because AnyValUtil::FromBuffer() allocated a temporary buffer anyway. Testing: Added a targeted test to expr-test that caused a crash before this fix. Change-Id: Ie0c1760511a04c0823fc465cf6e529e9681b2488 --- M be/src/exprs/expr-test.cc M be/src/exprs/math-functions-ir.cc 2 files changed, 6 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/43/13743/1 -- To view, visit http://gerrit.cloudera.org:8080/13743 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ie0c1760511a04c0823fc465cf6e529e9681b2488 Gerrit-Change-Number: 13743 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong
[Impala-ASF-CR] IMPALA-8369: Bump CDP BUILD NUMBER and re-enable test max nesting depth
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13723 ) Change subject: IMPALA-8369: Bump CDP_BUILD_NUMBER and re-enable test_max_nesting_depth .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13723 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1d6f4e29997c9cf2238e1d614f8d1ed7d35ffe92 Gerrit-Change-Number: 13723 Gerrit-PatchSet: 3 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Wed, 26 Jun 2019 23:20:02 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8369: Bump CDP BUILD NUMBER and re-enable test max nesting depth
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13723 ) Change subject: IMPALA-8369: Bump CDP_BUILD_NUMBER and re-enable test_max_nesting_depth .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4557/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/13723 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1d6f4e29997c9cf2238e1d614f8d1ed7d35ffe92 Gerrit-Change-Number: 13723 Gerrit-PatchSet: 3 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Wed, 26 Jun 2019 23:20:04 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8369: Bump CDP BUILD NUMBER and re-enable test max nesting depth
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13723 ) Change subject: IMPALA-8369: Bump CDP_BUILD_NUMBER and re-enable test_max_nesting_depth .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4556/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/13723 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1d6f4e29997c9cf2238e1d614f8d1ed7d35ffe92 Gerrit-Change-Number: 13723 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Wed, 26 Jun 2019 23:19:11 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8585: Fix upgraded table related tests in AcidUtilsTest
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13730 ) Change subject: IMPALA-8585: Fix upgraded table related tests in AcidUtilsTest .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13730 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iad41c1a7b0458a405b95f62d8e0ecd93947f492d Gerrit-Change-Number: 13730 Gerrit-PatchSet: 3 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Wed, 26 Jun 2019 23:18:30 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8585: Fix upgraded table related tests in AcidUtilsTest
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13730 ) Change subject: IMPALA-8585: Fix upgraded table related tests in AcidUtilsTest .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4555/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/13730 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iad41c1a7b0458a405b95f62d8e0ecd93947f492d Gerrit-Change-Number: 13730 Gerrit-PatchSet: 3 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Wed, 26 Jun 2019 23:18:31 + Gerrit-HasComments: No
[Impala-ASF-CR] Fix incorrect timestamp units in the logs
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13731 ) Change subject: Fix incorrect timestamp units in the logs .. Fix incorrect timestamp units in the logs EventSequence.markEvent() returns ns, so the existing conversion is incorrect. Change-Id: I132a007404dcf5291e70f2642ed3e9f995d694b1 Reviewed-on: http://gerrit.cloudera.org:8080/13731 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M fe/src/main/java/org/apache/impala/authorization/BaseAuthorizationChecker.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/13731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I132a007404dcf5291e70f2642ed3e9f995d694b1 Gerrit-Change-Number: 13731 Gerrit-PatchSet: 4 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] Fix incorrect timestamp units in the logs
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13731 ) Change subject: Fix incorrect timestamp units in the logs .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/13731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I132a007404dcf5291e70f2642ed3e9f995d694b1 Gerrit-Change-Number: 13731 Gerrit-PatchSet: 3 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 26 Jun 2019 23:02:58 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8702: Remove the PlannerTestOption of VALIDATE CARDINALITY to avoid a flaky test
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13717 ) Change subject: IMPALA-8702: Remove the PlannerTestOption of VALIDATE_CARDINALITY to avoid a flaky test .. IMPALA-8702: Remove the PlannerTestOption of VALIDATE_CARDINALITY to avoid a flaky test Removed the PlannerTestOption of VALIDATE_CARDINALITY in testJoins() and testFkPkJoinDetection() to avoid checking the estimated cardinality which may be slightly different each time due to IMPALA-7608 when an hdfs table without stats is involved in a query. Change-Id: Ie7fce59ecef45df7edc71cde1f8166ccfd45d187 Reviewed-on: http://gerrit.cloudera.org:8080/13717 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M fe/src/test/java/org/apache/impala/planner/PlannerTest.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/13717 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ie7fce59ecef45df7edc71cde1f8166ccfd45d187 Gerrit-Change-Number: 13717 Gerrit-PatchSet: 6 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-8702: Remove the PlannerTestOption of VALIDATE CARDINALITY to avoid a flaky test
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13717 ) Change subject: IMPALA-8702: Remove the PlannerTestOption of VALIDATE_CARDINALITY to avoid a flaky test .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/13717 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie7fce59ecef45df7edc71cde1f8166ccfd45d187 Gerrit-Change-Number: 13717 Gerrit-PatchSet: 5 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 26 Jun 2019 22:59:59 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8630: Hash the full path when calculating consistent remote placement
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13545 ) Change subject: IMPALA-8630: Hash the full path when calculating consistent remote placement .. Patch Set 13: Code-Review+2 Rebased, carry +2 -- To view, visit http://gerrit.cloudera.org:8080/13545 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I46c739fc31af539af2b3509e2a161f4e29f44d7b Gerrit-Change-Number: 13545 Gerrit-PatchSet: 13 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Wed, 26 Jun 2019 22:51:16 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8630: Hash the full path when calculating consistent remote placement
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13545 ) Change subject: IMPALA-8630: Hash the full path when calculating consistent remote placement .. Patch Set 13: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4554/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/13545 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I46c739fc31af539af2b3509e2a161f4e29f44d7b Gerrit-Change-Number: 13545 Gerrit-PatchSet: 13 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Wed, 26 Jun 2019 22:51:40 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8476: Replace Sentry admin check workaround with proper Sentry API
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13346 ) Change subject: IMPALA-8476: Replace Sentry admin check workaround with proper Sentry API .. Patch Set 15: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/3758/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13346 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5a27140d401494bc372ad0da96ada57bda94cd82 Gerrit-Change-Number: 13346 Gerrit-PatchSet: 15 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 26 Jun 2019 19:17:44 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8369: Bump CDP BUILD NUMBER and re-enable test max nesting depth
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13723 ) Change subject: IMPALA-8369: Bump CDP_BUILD_NUMBER and re-enable test_max_nesting_depth .. Patch Set 2: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4550/ -- To view, visit http://gerrit.cloudera.org:8080/13723 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1d6f4e29997c9cf2238e1d614f8d1ed7d35ffe92 Gerrit-Change-Number: 13723 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Wed, 26 Jun 2019 19:09:52 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8476: Replace Sentry admin check workaround with proper Sentry API
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13346 ) Change subject: IMPALA-8476: Replace Sentry admin check workaround with proper Sentry API .. Patch Set 13: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/3757/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13346 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5a27140d401494bc372ad0da96ada57bda94cd82 Gerrit-Change-Number: 13346 Gerrit-PatchSet: 13 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 26 Jun 2019 19:00:16 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8341: [DOCS] Describe the setting for remote data caching
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13724 ) Change subject: IMPALA-8341: [DOCS] Describe the setting for remote data caching .. IMPALA-8341: [DOCS] Describe the setting for remote data caching Change-Id: I7dd958e4de109b46eaf906fe93145799af123b3f Reviewed-on: http://gerrit.cloudera.org:8080/13724 Tested-by: Impala Public Jenkins Reviewed-by: Michael Ho --- M docs/impala.ditamap A docs/topics/impala_data_cache.xml 2 files changed, 87 insertions(+), 2 deletions(-) Approvals: Impala Public Jenkins: Verified Michael Ho: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/13724 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I7dd958e4de109b46eaf906fe93145799af123b3f Gerrit-Change-Number: 13724 Gerrit-PatchSet: 4 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho
[Impala-ASF-CR] IMPALA-8341: [DOCS] Describe the setting for remote data caching
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13724 ) Change subject: IMPALA-8341: [DOCS] Describe the setting for remote data caching .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13724 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7dd958e4de109b46eaf906fe93145799af123b3f Gerrit-Change-Number: 13724 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Comment-Date: Wed, 26 Jun 2019 18:45:27 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8476: Replace Sentry admin check workaround with proper Sentry API
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13346 ) Change subject: IMPALA-8476: Replace Sentry admin check workaround with proper Sentry API .. Patch Set 15: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13346 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5a27140d401494bc372ad0da96ada57bda94cd82 Gerrit-Change-Number: 13346 Gerrit-PatchSet: 15 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 26 Jun 2019 18:41:37 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8476: Replace Sentry admin check workaround with proper Sentry API
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13346 ) Change subject: IMPALA-8476: Replace Sentry admin check workaround with proper Sentry API .. Patch Set 15: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4553/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/13346 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5a27140d401494bc372ad0da96ada57bda94cd82 Gerrit-Change-Number: 13346 Gerrit-PatchSet: 15 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 26 Jun 2019 18:41:51 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8476: Replace Sentry admin check workaround with proper Sentry API
Fang-Yu Rao has uploaded a new patch set (#15). ( http://gerrit.cloudera.org:8080/13346 ) Change subject: IMPALA-8476: Replace Sentry admin check workaround with proper Sentry API .. IMPALA-8476: Replace Sentry admin check workaround with proper Sentry API Impala uses a workaround to detect if a user is a Sentry admin by calling the Sentry API to list privileges associated with the user since previously Sentry did not provide a suitable API to peform this check. This patch invokes a new API in SENTRY-2440 to perform the Sentry admin check. Also modified test_sentry.py to exercise the code paths corresponding to the following 3 different types of users: (i) a Sentry admin, (ii) an existing user which is not a Sentry admin, and (iii) a non-existing user. Testing: 1. Passed the tests in the revised test_sentry.py. Change-Id: I5a27140d401494bc372ad0da96ada57bda94cd82 --- M fe/src/main/java/org/apache/impala/authorization/sentry/SentryCatalogdAuthorizationManager.java M fe/src/main/java/org/apache/impala/authorization/sentry/SentryPolicyService.java M fe/src/main/java/org/apache/impala/authorization/sentry/SentryProxy.java M fe/src/main/java/org/apache/impala/service/JniCatalog.java M tests/authorization/test_sentry.py 5 files changed, 54 insertions(+), 23 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/13346/15 -- To view, visit http://gerrit.cloudera.org:8080/13346 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I5a27140d401494bc372ad0da96ada57bda94cd82 Gerrit-Change-Number: 13346 Gerrit-PatchSet: 15 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-8476: Replace Sentry admin check workaround with proper Sentry API
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13346 ) Change subject: IMPALA-8476: Replace Sentry admin check workaround with proper Sentry API .. Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/13346/13/fe/src/main/java/org/apache/impala/authorization/sentry/SentryPolicyService.java File fe/src/main/java/org/apache/impala/authorization/sentry/SentryPolicyService.java: http://gerrit.cloudera.org:8080/#/c/13346/13/fe/src/main/java/org/apache/impala/authorization/sentry/SentryPolicyService.java@538 PS13, Line 538: public boolean isSentryAdmin(User user) throws line has trailing whitespace -- To view, visit http://gerrit.cloudera.org:8080/13346 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5a27140d401494bc372ad0da96ada57bda94cd82 Gerrit-Change-Number: 13346 Gerrit-PatchSet: 13 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 26 Jun 2019 18:20:48 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8476: Replace Sentry admin check workaround with proper Sentry API
Fang-Yu Rao has uploaded a new patch set (#13). ( http://gerrit.cloudera.org:8080/13346 ) Change subject: IMPALA-8476: Replace Sentry admin check workaround with proper Sentry API .. IMPALA-8476: Replace Sentry admin check workaround with proper Sentry API Impala uses a workaround to detect if a user is a Sentry admin by calling the Sentry API to list privileges associated with the user since previously Sentry did not provide a suitable API to peform this check. This patch invokes a new API in SENTRY-2440 to perform the Sentry admin check. Also modified test_sentry.py to exercise the code paths corresponding to the following 3 different types of users: (i) a Sentry admin, (ii) an existing user which is not a Sentry admin, and (iii) a non-existing user. Testing: 1. Passed the tests in the revised test_sentry.py. Change-Id: I5a27140d401494bc372ad0da96ada57bda94cd82 --- M fe/src/main/java/org/apache/impala/authorization/sentry/SentryCatalogdAuthorizationManager.java M fe/src/main/java/org/apache/impala/authorization/sentry/SentryPolicyService.java M fe/src/main/java/org/apache/impala/authorization/sentry/SentryProxy.java M fe/src/main/java/org/apache/impala/service/JniCatalog.java M tests/authorization/test_sentry.py 5 files changed, 54 insertions(+), 23 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/13346/13 -- To view, visit http://gerrit.cloudera.org:8080/13346 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I5a27140d401494bc372ad0da96ada57bda94cd82 Gerrit-Change-Number: 13346 Gerrit-PatchSet: 13 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] Revert "IMPALA-7322: Add storage wait time to profile"
Yongzhi Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/13738 ) Change subject: Revert "IMPALA-7322: Add storage wait time to profile" .. Patch Set 2: I will fix the tests. -- To view, visit http://gerrit.cloudera.org:8080/13738 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8fc33db75c21973d209d518c1fb02bd5f9728aee Gerrit-Change-Number: 13738 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Yongzhi Chen Gerrit-Comment-Date: Wed, 26 Jun 2019 18:11:22 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8341: [DOCS] Describe the setting for remote data caching
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13724 ) Change subject: IMPALA-8341: [DOCS] Describe the setting for remote data caching .. Patch Set 3: Verified+1 Build Successful https://jenkins.impala.io/job/gerrit-docs-auto-test/359/ : Doc tests passed. -- To view, visit http://gerrit.cloudera.org:8080/13724 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7dd958e4de109b46eaf906fe93145799af123b3f Gerrit-Change-Number: 13724 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Comment-Date: Wed, 26 Jun 2019 17:59:18 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7734: Catalog and Statestore memz page shows useless memory
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/13670 ) Change subject: IMPALA-7734: Catalog and Statestore memz page shows useless memory .. Patch Set 6: (3 comments) Overall, re-factoring LGTM. Just some docs comments. http://gerrit.cloudera.org:8080/#/c/13670/6/be/src/util/memusage-path-handlers.h File be/src/util/memusage-path-handlers.h: http://gerrit.cloudera.org:8080/#/c/13670/6/be/src/util/memusage-path-handlers.h@33 PS6, Line 33: /// Adds a set of memory usage metrics to the webserver to display Should add more docs, like what memory usage metrics are added and when. http://gerrit.cloudera.org:8080/#/c/13670/6/be/src/util/memusage-path-handlers.cc File be/src/util/memusage-path-handlers.cc: http://gerrit.cloudera.org:8080/#/c/13670/6/be/src/util/memusage-path-handlers.cc@32 PS6, Line 32: void AddMemTracker(MemTracker* mem_tracker, would be nice to add some docs to each of these methods http://gerrit.cloudera.org:8080/#/c/13670/6/be/src/util/memusage-path-handlers.cc@67 PS6, Line 67: nit: extra new line? -- To view, visit http://gerrit.cloudera.org:8080/13670 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1a42434b98aec1d9e0be6ae52325049378fdde23 Gerrit-Change-Number: 13670 Gerrit-PatchSet: 6 Gerrit-Owner: Tamas Mate Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Tamas Mate Gerrit-Comment-Date: Wed, 26 Jun 2019 17:59:13 + Gerrit-HasComments: Yes
[Impala-ASF-CR] Revert "IMPALA-8627: re-enable catalog v2 in containers"
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13739 ) Change subject: Revert "IMPALA-8627: re-enable catalog v2 in containers" .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/3756/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13739 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5037c94d22101458f0c6fffa976f0ee73f5f9455 Gerrit-Change-Number: 13739 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 26 Jun 2019 17:49:14 + Gerrit-HasComments: No
[Impala-ASF-CR] Revert "IMPALA-7322: Add storage wait time to profile"
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13738 ) Change subject: Revert "IMPALA-7322: Add storage wait time to profile" .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/3755/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13738 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8fc33db75c21973d209d518c1fb02bd5f9728aee Gerrit-Change-Number: 13738 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 26 Jun 2019 17:48:28 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8665:Include extra info in error message when date cast fails
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13680 ) Change subject: IMPALA-8665:Include extra info in error message when date cast fails .. Patch Set 8: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/3754/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13680 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If800b7696515cd61afee27220c55ff2440a86f04 Gerrit-Change-Number: 13680 Gerrit-PatchSet: 8 Gerrit-Owner: Jiawei Wang Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jiawei Wang Gerrit-Comment-Date: Wed, 26 Jun 2019 17:47:52 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8585: Fix upgraded table related tests in AcidUtilsTest
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13730 ) Change subject: IMPALA-8585: Fix upgraded table related tests in AcidUtilsTest .. Patch Set 2: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4548/ -- To view, visit http://gerrit.cloudera.org:8080/13730 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iad41c1a7b0458a405b95f62d8e0ecd93947f492d Gerrit-Change-Number: 13730 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Wed, 26 Jun 2019 17:43:33 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8341: [DOCS] Describe the setting for remote data caching
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13724 ) Change subject: IMPALA-8341: [DOCS] Describe the setting for remote data caching .. Patch Set 3: Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/359/ Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/13724 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7dd958e4de109b46eaf906fe93145799af123b3f Gerrit-Change-Number: 13724 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Comment-Date: Wed, 26 Jun 2019 17:33:02 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8341: [DOCS] Describe the setting for remote data caching
Hello Michael Ho, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13724 to look at the new patch set (#3). Change subject: IMPALA-8341: [DOCS] Describe the setting for remote data caching .. IMPALA-8341: [DOCS] Describe the setting for remote data caching Change-Id: I7dd958e4de109b46eaf906fe93145799af123b3f --- M docs/impala.ditamap A docs/topics/impala_data_cache.xml 2 files changed, 87 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/24/13724/3 -- To view, visit http://gerrit.cloudera.org:8080/13724 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7dd958e4de109b46eaf906fe93145799af123b3f Gerrit-Change-Number: 13724 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho
[Impala-ASF-CR] Fix incorrect timestamp units in the logs
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13731 ) Change subject: Fix incorrect timestamp units in the logs .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I132a007404dcf5291e70f2642ed3e9f995d694b1 Gerrit-Change-Number: 13731 Gerrit-PatchSet: 3 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 26 Jun 2019 17:26:36 + Gerrit-HasComments: No
[Impala-ASF-CR] Fix incorrect timestamp units in the logs
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13731 ) Change subject: Fix incorrect timestamp units in the logs .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4552/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/13731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I132a007404dcf5291e70f2642ed3e9f995d694b1 Gerrit-Change-Number: 13731 Gerrit-PatchSet: 3 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 26 Jun 2019 17:26:37 + Gerrit-HasComments: No
[Impala-ASF-CR] Fix incorrect timestamp units in the logs
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13731 ) Change subject: Fix incorrect timestamp units in the logs .. Patch Set 2: Code-Review+2 > Patch Set 2: Verified-1 > > Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4547/ Unrelated flaky tests. Re-running the merge. -- To view, visit http://gerrit.cloudera.org:8080/13731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I132a007404dcf5291e70f2642ed3e9f995d694b1 Gerrit-Change-Number: 13731 Gerrit-PatchSet: 2 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 26 Jun 2019 17:25:59 + Gerrit-HasComments: No
[Impala-ASF-CR] Fix incorrect timestamp units in the logs
Fredy Wijaya has removed a vote on this change. Change subject: Fix incorrect timestamp units in the logs .. Removed Verified-1 by Impala Public Jenkins -- To view, visit http://gerrit.cloudera.org:8080/13731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: I132a007404dcf5291e70f2642ed3e9f995d694b1 Gerrit-Change-Number: 13731 Gerrit-PatchSet: 2 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-8612: Fix sporadic NPE when dropping an authorized table
Fredy Wijaya has posted comments on this change. (
http://gerrit.cloudera.org:8080/13508 )
Change subject: IMPALA-8612: Fix sporadic NPE when dropping an authorized table
..
Patch Set 3:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/13508/3/fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java
File fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java:
http://gerrit.cloudera.org:8080/#/c/13508/3/fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java@40
PS3, Line 40: Expr
Shouldn't this be DropTableOrViewStmt?
http://gerrit.cloudera.org:8080/#/c/13508/3/fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java@131
PS3, Line 131: "Ignoring TableLoadingException for " + dbName_ + "." +
tableName_
nit: it's usually preferable to use the SLF4J log format, e.g.
LOG.info("Ignoring TableLoadingException for {}.{}", dbName_, getTbl());
http://gerrit.cloudera.org:8080/#/c/13508/3/fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java@134
PS3, Line 134: tableName_
tableName_.toString() may print "db.tbl":
https://github.com/apache/impala/blob/572c1278566ca329f3e47e5c2d7e13dd0c7967f7/fe/src/main/java/org/apache/impala/analysis/TableName.java#L85-L92,
should we use getTbl() instead similar to L115 and L120?
--
To view, visit http://gerrit.cloudera.org:8080/13508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I70bd7ca4796b24920ee156436bf8bbc682e7d952
Gerrit-Change-Number: 13508
Gerrit-PatchSet: 3
Gerrit-Owner: Gabor Kaszab
Gerrit-Reviewer: Fredy Wijaya
Gerrit-Reviewer: Gabor Kaszab
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Zoltan Borok-Nagy
Gerrit-Comment-Date: Wed, 26 Jun 2019 17:24:30 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8710: Increase allowed bit width to 64 for bit packing
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13737 ) Change subject: IMPALA-8710: Increase allowed bit width to 64 for bit packing .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/3753/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13737 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3ff3b387cbe8e41dd78c45411ef54de4afa8 Gerrit-Change-Number: 13737 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 26 Jun 2019 17:17:17 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8702: Remove the PlannerTestOption of VALIDATE CARDINALITY to avoid a flaky test
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13717 ) Change subject: IMPALA-8702: Remove the PlannerTestOption of VALIDATE_CARDINALITY to avoid a flaky test .. Patch Set 4: Unrelated tests were flaky. Reverted those changes then will merge again. -- To view, visit http://gerrit.cloudera.org:8080/13717 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie7fce59ecef45df7edc71cde1f8166ccfd45d187 Gerrit-Change-Number: 13717 Gerrit-PatchSet: 4 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 26 Jun 2019 17:14:00 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8702: Remove the PlannerTestOption of VALIDATE CARDINALITY to avoid a flaky test
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13717 ) Change subject: IMPALA-8702: Remove the PlannerTestOption of VALIDATE_CARDINALITY to avoid a flaky test .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13717 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie7fce59ecef45df7edc71cde1f8166ccfd45d187 Gerrit-Change-Number: 13717 Gerrit-PatchSet: 5 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 26 Jun 2019 17:13:45 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8702: Remove the PlannerTestOption of VALIDATE CARDINALITY to avoid a flaky test
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13717 ) Change subject: IMPALA-8702: Remove the PlannerTestOption of VALIDATE_CARDINALITY to avoid a flaky test .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4551/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/13717 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie7fce59ecef45df7edc71cde1f8166ccfd45d187 Gerrit-Change-Number: 13717 Gerrit-PatchSet: 5 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 26 Jun 2019 17:13:46 + Gerrit-HasComments: No
[Impala-ASF-CR] Revert "IMPALA-8627: re-enable catalog v2 in containers"
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13739 ) Change subject: Revert "IMPALA-8627: re-enable catalog v2 in containers" .. Patch Set 1: Verified+1 Code-Review+2 Reverting to unbreak builds -- To view, visit http://gerrit.cloudera.org:8080/13739 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5037c94d22101458f0c6fffa976f0ee73f5f9455 Gerrit-Change-Number: 13739 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 26 Jun 2019 17:13:18 + Gerrit-HasComments: No
[Impala-ASF-CR] Revert "IMPALA-8627: re-enable catalog v2 in containers"
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13739 ) Change subject: Revert "IMPALA-8627: re-enable catalog v2 in containers" .. Revert "IMPALA-8627: re-enable catalog v2 in containers" This reverts commit 1e1b8e9bc6418fecfe4e57cb4fe25d1f64129657. Some tests appear to be flaky as a result of this change. Change-Id: I5037c94d22101458f0c6fffa976f0ee73f5f9455 Reviewed-on: http://gerrit.cloudera.org:8080/13739 Reviewed-by: Tim Armstrong Tested-by: Tim Armstrong --- M docker/catalogd/Dockerfile M docker/coord_exec/Dockerfile M docker/coordinator/Dockerfile 3 files changed, 3 insertions(+), 5 deletions(-) Approvals: Tim Armstrong: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/13739 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I5037c94d22101458f0c6fffa976f0ee73f5f9455 Gerrit-Change-Number: 13739 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] Revert "IMPALA-7322: Add storage wait time to profile"
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13738 ) Change subject: Revert "IMPALA-7322: Add storage wait time to profile" .. Patch Set 1: Verified+1 Code-Review+2 Will push through to unbreak precommit. -- To view, visit http://gerrit.cloudera.org:8080/13738 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8fc33db75c21973d209d518c1fb02bd5f9728aee Gerrit-Change-Number: 13738 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 26 Jun 2019 17:12:19 + Gerrit-HasComments: No
[Impala-ASF-CR] Revert "IMPALA-7322: Add storage wait time to profile"
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13738 ) Change subject: Revert "IMPALA-7322: Add storage wait time to profile" .. Revert "IMPALA-7322: Add storage wait time to profile" This reverts commit 2fd795cf56e65a43087375867dcc9890e3a27330. The test added has some issues: * Fails with the local catalog enabled * Is flaky if run concurrently with other tests that touch the same tables. Change-Id: I8fc33db75c21973d209d518c1fb02bd5f9728aee Reviewed-on: http://gerrit.cloudera.org:8080/13738 Reviewed-by: Tim Armstrong Tested-by: Tim Armstrong --- M common/thrift/CatalogObjects.thrift M fe/src/main/java/org/apache/impala/analysis/StmtMetadataLoader.java M fe/src/main/java/org/apache/impala/catalog/HBaseTable.java M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java M fe/src/main/java/org/apache/impala/catalog/KuduTable.java M fe/src/main/java/org/apache/impala/catalog/Table.java M tests/query_test/test_observability.py 7 files changed, 29 insertions(+), 131 deletions(-) Approvals: Tim Armstrong: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/13738 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I8fc33db75c21973d209d518c1fb02bd5f9728aee Gerrit-Change-Number: 13738 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] Revert "IMPALA-8627: re-enable catalog v2 in containers"
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13739 Change subject: Revert "IMPALA-8627: re-enable catalog v2 in containers" .. Revert "IMPALA-8627: re-enable catalog v2 in containers" This reverts commit 1e1b8e9bc6418fecfe4e57cb4fe25d1f64129657. Some tests appear to be flaky as a result of this change. Change-Id: I5037c94d22101458f0c6fffa976f0ee73f5f9455 --- M docker/catalogd/Dockerfile M docker/coord_exec/Dockerfile M docker/coordinator/Dockerfile 3 files changed, 3 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/13739/1 -- To view, visit http://gerrit.cloudera.org:8080/13739 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I5037c94d22101458f0c6fffa976f0ee73f5f9455 Gerrit-Change-Number: 13739 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong
[Impala-ASF-CR] Revert "IMPALA-7322: Add storage wait time to profile"
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13738 Change subject: Revert "IMPALA-7322: Add storage wait time to profile" .. Revert "IMPALA-7322: Add storage wait time to profile" This reverts commit 2fd795cf56e65a43087375867dcc9890e3a27330. The test added has some issues: * Fails with the local catalog enabled * Is flaky if run concurrently with other tests that touch the same tables. Change-Id: I8fc33db75c21973d209d518c1fb02bd5f9728aee --- M common/thrift/CatalogObjects.thrift M fe/src/main/java/org/apache/impala/analysis/StmtMetadataLoader.java M fe/src/main/java/org/apache/impala/catalog/HBaseTable.java M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java M fe/src/main/java/org/apache/impala/catalog/KuduTable.java M fe/src/main/java/org/apache/impala/catalog/Table.java M tests/query_test/test_observability.py 7 files changed, 29 insertions(+), 131 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/38/13738/1 -- To view, visit http://gerrit.cloudera.org:8080/13738 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I8fc33db75c21973d209d518c1fb02bd5f9728aee Gerrit-Change-Number: 13738 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong
[Impala-ASF-CR] IMPALA-8665:Include extra info in error message when date cast fails
Jiawei Wang has uploaded a new patch set (#8). (
http://gerrit.cloudera.org:8080/13680 )
Change subject: IMPALA-8665:Include extra info in error message when date cast
fails
..
IMPALA-8665:Include extra info in error message when date cast fails
This change extends the error message Impala yields when casting STRING
to DATE (explicitly or implicitly) fails. The new error message includes
the violating string value.
Testing:
changes -> date-partitioning.test & date.test
query_test/test_date_queries.py test passed
Example:
select cast('20' as date);
ERROR: UDF ERROR: String to Date parse failed. Invalid string val: "20"
Change-Id: If800b7696515cd61afee27220c55ff2440a86f04
---
M be/src/exprs/cast-functions-ir.cc
M testdata/workloads/functional-query/queries/QueryTest/date-partitioning.test
M testdata/workloads/functional-query/queries/QueryTest/date.test
3 files changed, 12 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/80/13680/8
--
To view, visit http://gerrit.cloudera.org:8080/13680
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If800b7696515cd61afee27220c55ff2440a86f04
Gerrit-Change-Number: 13680
Gerrit-PatchSet: 8
Gerrit-Owner: Jiawei Wang
Gerrit-Reviewer: Attila Jeges
Gerrit-Reviewer: Gabor Kaszab
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jiawei Wang
[Impala-ASF-CR] IMPALA-7322: Add storage wait time to profile
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12940 ) Change subject: IMPALA-7322: Add storage wait time to profile .. Patch Set 15: Actually the test is also flaky with metadata v1 as far as I can see, since it can run in parallel with other tests that touch functional.alltypes. I'm going to revert this and my change. -- To view, visit http://gerrit.cloudera.org:8080/12940 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6dde7e394b7c1c396d835ef6aa0a55930c0a8660 Gerrit-Change-Number: 12940 Gerrit-PatchSet: 15 Gerrit-Owner: Yongzhi Chen Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Reviewer: Yongzhi Chen Gerrit-Comment-Date: Wed, 26 Jun 2019 17:06:20 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7322: Add storage wait time to profile
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12940 ) Change subject: IMPALA-7322: Add storage wait time to profile .. Patch Set 15: It fails reliably with the local catalog, so raced with my change to enable local catalog in precommit. -- To view, visit http://gerrit.cloudera.org:8080/12940 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6dde7e394b7c1c396d835ef6aa0a55930c0a8660 Gerrit-Change-Number: 12940 Gerrit-PatchSet: 15 Gerrit-Owner: Yongzhi Chen Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Reviewer: Yongzhi Chen Gerrit-Comment-Date: Wed, 26 Jun 2019 17:04:35 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8710: Increase allowed bit width to 64 for bit packing
Daniel Becker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13737 Change subject: IMPALA-8710: Increase allowed bit width to 64 for bit packing .. IMPALA-8710: Increase allowed bit width to 64 for bit packing Increasing the allowed bit width for bit packing and bit unpacking to 64 bits. This will be needed to support the Parquet delta encoding. Added new methods to BitWriter and BatchedBitReader handling Uleb and ZigZag integers for 64 bits, also needed by delta encoding. Testing: - Modified bit packing and unpacking tests to test bit widths up to 64 bits. - Tests covering the additions in BitWriter and BatchedBitReader. Change-Id: I3ff3b387cbe8e41dd78c45411ef54de4afa8 --- M be/src/util/CMakeLists.txt M be/src/util/bit-packing-test.cc M be/src/util/bit-packing.h M be/src/util/bit-packing.inline.h M be/src/util/bit-stream-utils-test.cc M be/src/util/bit-stream-utils.h M be/src/util/bit-stream-utils.inline.h M be/src/util/rle-encoding.h M be/src/util/rle-test.cc 9 files changed, 307 insertions(+), 105 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/37/13737/1 -- To view, visit http://gerrit.cloudera.org:8080/13737 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I3ff3b387cbe8e41dd78c45411ef54de4afa8 Gerrit-Change-Number: 13737 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Becker
[Impala-ASF-CR] IMPALA-8665 Include extra info in error message when date cast fails
Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/13680 ) Change subject: IMPALA-8665 Include extra info in error message when date cast fails .. Patch Set 7: (3 comments) Thank you! I have few more nit-picky comments before we can merge this in: http://gerrit.cloudera.org:8080/#/c/13680/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13680/7//COMMIT_MSG@7 PS7, Line 7: IMPALA-8665 nit: In the change title, the JIRA number should be followed with a colon or dot character. "IMPALA-8665: " instead of "IMPALA-8665 " I know it is silly, but these are the rules :) http://gerrit.cloudera.org:8080/#/c/13680/7//COMMIT_MSG@19 PS7, Line 19: ERROR: UDF ERROR: String to Date parse failed. Invalid string val: "2000" nit: long line. Lines in the Commit Message should wrap at 72 characters. http://gerrit.cloudera.org:8080/#/c/13680/7/be/src/exprs/cast-functions-ir.cc File be/src/exprs/cast-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/13680/7/be/src/exprs/cast-functions-ir.cc@312 PS7, Line 312: char* stringVal = reinterpret_cast(val.ptr); 'val' is a const reference, so probably it's be best to keep val.ptr's constness: const char* stringVal = reinterpret_cast(val.ptr); -- To view, visit http://gerrit.cloudera.org:8080/13680 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If800b7696515cd61afee27220c55ff2440a86f04 Gerrit-Change-Number: 13680 Gerrit-PatchSet: 7 Gerrit-Owner: Jiawei Wang Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jiawei Wang Gerrit-Comment-Date: Wed, 26 Jun 2019 16:15:11 + Gerrit-HasComments: Yes
[native-toolchain-CR] SSL client support for THttpClient py implementation
Bharath Vissapragada has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13725 ) Change subject: SSL client support for THttpClient py implementation .. SSL client support for THttpClient py implementation Thrift 0.9.3-p7 adds the ability to pass SSL context from the clients for cert verification. This is needed for impala-shell support for HTTP based server endpoints. Change-Id: Ia0f76318aa18075b0e6e43aaf997b90e463228ce Reviewed-on: http://gerrit.cloudera.org:8080/13725 Reviewed-by: Tim Armstrong Tested-by: Bharath Vissapragada --- M buildall.sh A source/thrift/thrift-0.9.3-patches/0007-SSL-support-for-THttpClient-py.patch 2 files changed, 130 insertions(+), 2 deletions(-) Approvals: Tim Armstrong: Looks good to me, approved Bharath Vissapragada: Verified -- To view, visit http://gerrit.cloudera.org:8080/13725 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ia0f76318aa18075b0e6e43aaf997b90e463228ce Gerrit-Change-Number: 13725 Gerrit-PatchSet: 4 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Tim Armstrong
[native-toolchain-CR] SSL client support for THttpClient py implementation
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13725 ) Change subject: SSL client support for THttpClient py implementation .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/13725 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia0f76318aa18075b0e6e43aaf997b90e463228ce Gerrit-Change-Number: 13725 Gerrit-PatchSet: 3 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 26 Jun 2019 15:43:59 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7322: Add storage wait time to profile
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12940 ) Change subject: IMPALA-7322: Add storage wait time to profile .. Patch Set 15: It looks like the tests added here are a little flaky. https://jenkins.impala.io/job/ubuntu-16.04-dockerised-tests/630/testReport/junit/query_test.test_observability/TestObservability/test_query_profile_storage_load_time_filesystem/ https://jenkins.impala.io/job/ubuntu-16.04-dockerised-tests/630/testReport/junit/query_test.test_observability/TestObservability/test_query_profile_storage_load_time/ Probably a matter of time before other builds run into it, just a heads up. -- To view, visit http://gerrit.cloudera.org:8080/12940 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6dde7e394b7c1c396d835ef6aa0a55930c0a8660 Gerrit-Change-Number: 12940 Gerrit-PatchSet: 15 Gerrit-Owner: Yongzhi Chen Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Reviewer: Yongzhi Chen Gerrit-Comment-Date: Wed, 26 Jun 2019 15:40:25 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8369: Bump CDP BUILD NUMBER and re-enable test max nesting depth
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13723 ) Change subject: IMPALA-8369: Bump CDP_BUILD_NUMBER and re-enable test_max_nesting_depth .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13723 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1d6f4e29997c9cf2238e1d614f8d1ed7d35ffe92 Gerrit-Change-Number: 13723 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Wed, 26 Jun 2019 15:03:57 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8681: Only show ValidWriteIdLists for Acid tables
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13736 ) Change subject: IMPALA-8681: Only show ValidWriteIdLists for Acid tables .. Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/13736/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13736/1//COMMIT_MSG@16 PS1, Line 16: Fixed StmtMetadataLoaderTest. Maybe you coud add Hive3-only e2e tests with RUNTIME_PROFILE section that has "row_regex" check, like e.g. in QueryTest/spilling-aggs.test. -- To view, visit http://gerrit.cloudera.org:8080/13736 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifcc31c7ddcfc471b0e5308f7e4aaadfa8189a905 Gerrit-Change-Number: 13736 Gerrit-PatchSet: 1 Gerrit-Owner: Yongzhi Chen Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Yongzhi Chen Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Wed, 26 Jun 2019 14:55:42 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8681: Only show ValidWriteIdLists for Acid tables
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13736 ) Change subject: IMPALA-8681: Only show ValidWriteIdLists for Acid tables .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/3752/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13736 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifcc31c7ddcfc471b0e5308f7e4aaadfa8189a905 Gerrit-Change-Number: 13736 Gerrit-PatchSet: 1 Gerrit-Owner: Yongzhi Chen Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 26 Jun 2019 14:31:34 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8612: Fix sporadic NPE when dropping an authorized table
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13508 ) Change subject: IMPALA-8612: Fix sporadic NPE when dropping an authorized table .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/3751/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13508 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70bd7ca4796b24920ee156436bf8bbc682e7d952 Gerrit-Change-Number: 13508 Gerrit-PatchSet: 2 Gerrit-Owner: Gabor Kaszab Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Wed, 26 Jun 2019 13:57:30 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8681: Only show ValidWriteIdLists for Acid tables
Yongzhi Chen has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13736 Change subject: IMPALA-8681: Only show ValidWriteIdLists for Acid tables .. IMPALA-8681: Only show ValidWriteIdLists for Acid tables Lists ValidWriteIds for transactional tables in profile. If a query does not trigger any transactional table loading, the query profile will not have the "Loaded ValidWriteIdLists" timeline. Tests: Manual tests. Fixed StmtMetadataLoaderTest. Sample output: Query Compilation: 3s525ms - Metadata load started: 37.369ms (37.369ms) - Metadata load finished. loaded-tables=1/1 ... - Loaded ValidWriteIdLists for transactional tables: functional.insert_only_transactional_table:0:9223372036854775807:: : 3s312ms (551.463us) - Analysis finished: 3s370ms (58.110ms) ... Change-Id: Ifcc31c7ddcfc471b0e5308f7e4aaadfa8189a905 --- M fe/src/main/java/org/apache/impala/analysis/StmtMetadataLoader.java M fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java 2 files changed, 13 insertions(+), 9 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/36/13736/1 -- To view, visit http://gerrit.cloudera.org:8080/13736 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ifcc31c7ddcfc471b0e5308f7e4aaadfa8189a905 Gerrit-Change-Number: 13736 Gerrit-PatchSet: 1 Gerrit-Owner: Yongzhi Chen
[Impala-ASF-CR] IMPALA-8369: Bump CDP BUILD NUMBER and re-enable test max nesting depth
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13723 ) Change subject: IMPALA-8369: Bump CDP_BUILD_NUMBER and re-enable test_max_nesting_depth .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4550/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/13723 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1d6f4e29997c9cf2238e1d614f8d1ed7d35ffe92 Gerrit-Change-Number: 13723 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 26 Jun 2019 13:29:25 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8612: Fix sporadic NPE when dropping an authorized table
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/13508 ) Change subject: IMPALA-8612: Fix sporadic NPE when dropping an authorized table .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/13508/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13508/1//COMMIT_MSG@7 PS1, Line 7: NPE > nit: might worth spell it out at least once. Done http://gerrit.cloudera.org:8080/#/c/13508/1/fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java File fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java: http://gerrit.cloudera.org:8080/#/c/13508/1/fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java@124 PS1, Line 124: // in a bad state, eg. deleted externally from Kudu, can be dropped. > Should we log the exception? Done http://gerrit.cloudera.org:8080/#/c/13508/1/fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java@124 PS1, Line 124: // in a bad state, eg. deleted externally from Kudu, can be dropped. > We should have an E2E test here by having a table that is dropped externall I have tried this but apparently that won't work. I created a table with Impala, dropped it with Hive and tried to drop it with Impala. The TableLoadingException case was covered, that is fine, but later on in CatalogOpExecutor.dropTableOrView() an ImpalaRuntimeException is thrown saying the table no longer exists in HSM and should run invalidate metadata. All in all the updateOwnerPrivileges() function is not invoked. -- To view, visit http://gerrit.cloudera.org:8080/13508 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70bd7ca4796b24920ee156436bf8bbc682e7d952 Gerrit-Change-Number: 13508 Gerrit-PatchSet: 3 Gerrit-Owner: Gabor Kaszab Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Wed, 26 Jun 2019 13:25:14 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8612: Fix sporadic NPE when dropping an authorized table
Hello Fredy Wijaya, Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13508 to look at the new patch set (#3). Change subject: IMPALA-8612: Fix sporadic NPE when dropping an authorized table .. IMPALA-8612: Fix sporadic NPE when dropping an authorized table In the analyze() function of DropTableOrViewStmt it's possible that serverName_ is not set when analyzer.getTable() throws. As a result when the Catalog executes the drop table DDL it runs into a failing Precondition check and throws a NullPointerException when updating user privileges. Note, to run into the NPE it's required to have authorization enabled. Change-Id: I70bd7ca4796b24920ee156436bf8bbc682e7d952 --- M fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java 1 file changed, 9 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/13508/3 -- To view, visit http://gerrit.cloudera.org:8080/13508 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I70bd7ca4796b24920ee156436bf8bbc682e7d952 Gerrit-Change-Number: 13508 Gerrit-PatchSet: 3 Gerrit-Owner: Gabor Kaszab Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Zoltan Borok-Nagy
[Impala-ASF-CR] IMPALA-8612: Fix sporadic NPE when dropping an authorized table
Hello Fredy Wijaya, Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13508 to look at the new patch set (#2). Change subject: IMPALA-8612: Fix sporadic NPE when dropping an authorized table .. IMPALA-8612: Fix sporadic NPE when dropping an authorized table In the analyze() function of DropTableOrViewStmt it's possible that serverName_ is not set when analyzer.getTable() throws. As a result when the Catalog executes the drop table DDL it runs into a failing Precondition check and throws a NPE when updating user privileges. Note, to run into the NPE it's required to have authorization enabled. Change-Id: I70bd7ca4796b24920ee156436bf8bbc682e7d952 --- M fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java 1 file changed, 9 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/13508/2 -- To view, visit http://gerrit.cloudera.org:8080/13508 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I70bd7ca4796b24920ee156436bf8bbc682e7d952 Gerrit-Change-Number: 13508 Gerrit-PatchSet: 2 Gerrit-Owner: Gabor Kaszab Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Zoltan Borok-Nagy
[Impala-ASF-CR] IMPALA-8369: Bump CDP BUILD NUMBER and re-enable test max nesting depth
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13723 ) Change subject: IMPALA-8369: Bump CDP_BUILD_NUMBER and re-enable test_max_nesting_depth .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4549/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/13723 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1d6f4e29997c9cf2238e1d614f8d1ed7d35ffe92 Gerrit-Change-Number: 13723 Gerrit-PatchSet: 1 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 26 Jun 2019 12:21:02 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8585: Fix upgraded table related tests in AcidUtilsTest
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13730 ) Change subject: IMPALA-8585: Fix upgraded table related tests in AcidUtilsTest .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13730 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iad41c1a7b0458a405b95f62d8e0ecd93947f492d Gerrit-Change-Number: 13730 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Wed, 26 Jun 2019 12:07:02 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8585: Fix upgraded table related tests in AcidUtilsTest
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13730 ) Change subject: IMPALA-8585: Fix upgraded table related tests in AcidUtilsTest .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4548/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/13730 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iad41c1a7b0458a405b95f62d8e0ecd93947f492d Gerrit-Change-Number: 13730 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Wed, 26 Jun 2019 12:07:03 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8585: Fix upgraded table related tests in AcidUtilsTest
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13730 ) Change subject: IMPALA-8585: Fix upgraded table related tests in AcidUtilsTest .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13730 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iad41c1a7b0458a405b95f62d8e0ecd93947f492d Gerrit-Change-Number: 13730 Gerrit-PatchSet: 1 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Wed, 26 Jun 2019 11:03:37 + Gerrit-HasComments: No
[Impala-ASF-CR] Fix incorrect timestamp units in the logs
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13731 ) Change subject: Fix incorrect timestamp units in the logs .. Patch Set 2: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4547/ -- To view, visit http://gerrit.cloudera.org:8080/13731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I132a007404dcf5291e70f2642ed3e9f995d694b1 Gerrit-Change-Number: 13731 Gerrit-PatchSet: 2 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 26 Jun 2019 09:21:16 + Gerrit-HasComments: No
