Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13508 )
Change subject: IMPALA-8612: Fix sporadic NPE when dropping an authorized table ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/13508/3/fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java File fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java: http://gerrit.cloudera.org:8080/#/c/13508/3/fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java@40 PS3, Line 40: Expr Shouldn't this be DropTableOrViewStmt? http://gerrit.cloudera.org:8080/#/c/13508/3/fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java@131 PS3, Line 131: "Ignoring TableLoadingException for " + dbName_ + "." + tableName_ nit: it's usually preferable to use the SLF4J log format, e.g. LOG.info("Ignoring TableLoadingException for {}.{}", dbName_, getTbl()); http://gerrit.cloudera.org:8080/#/c/13508/3/fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java@134 PS3, Line 134: tableName_ tableName_.toString() may print "db.tbl": https://github.com/apache/impala/blob/572c1278566ca329f3e47e5c2d7e13dd0c7967f7/fe/src/main/java/org/apache/impala/analysis/TableName.java#L85-L92, should we use getTbl() instead similar to L115 and L120? -- To view, visit http://gerrit.cloudera.org:8080/13508 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70bd7ca4796b24920ee156436bf8bbc682e7d952 Gerrit-Change-Number: 13508 Gerrit-PatchSet: 3 Gerrit-Owner: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Wed, 26 Jun 2019 17:24:30 +0000 Gerrit-HasComments: Yes
